{"action":"created","issue":{"url":"https://api.github.com/repos/cloudant/sync-android/issues/284","repository_url":"https://api.github.com/repos/cloudant/sync-android","labels_url":"https://api.github.com/repos/cloudant/sync-android/issues/284/labels{/name}","comments_url":"https://api.github.com/repos/cloudant/sync-android/issues/284/comments","events_url":"https://api.github.com/repos/cloudant/sync-android/issues/284/events","html_url":"https://github.com/cloudant/sync-android/issues/284","id":161651986,"number":284,"title":"Move IndexManager public API to Datastore","user":{"login":"ricellis","id":10698320,"avatar_url":"https://avatars.githubusercontent.com/u/10698320?v=3","gravatar_id":"","url":"https://api.github.com/users/ricellis","html_url":"https://github.com/ricellis","followers_url":"https://api.github.com/users/ricellis/followers","following_url":"https://api.github.com/users/ricellis/following{/other_user}","gists_url":"https://api.github.com/users/ricellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ricellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricellis/subscriptions","organizations_url":"https://api.github.com/users/ricellis/orgs","repos_url":"https://api.github.com/users/ricellis/repos","events_url":"https://api.github.com/users/ricellis/events{/privacy}","received_events_url":"https://api.github.com/users/ricellis/received_events","type":"User","site_admin":false},"labels":[{"id":80423560,"url":"https://api.github.com/repos/cloudant/sync-android/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":{"login":"tomblench","id":6302842,"avatar_url":"https://avatars.githubusercontent.com/u/6302842?v=3","gravatar_id":"","url":"https://api.github.com/users/tomblench","html_url":"https://github.com/tomblench","followers_url":"https://api.github.com/users/tomblench/followers","following_url":"https://api.github.com/users/tomblench/following{/other_user}","gists_url":"https://api.github.com/users/tomblench/gists{/gist_id}","starred_url":"https://api.github.com/users/tomblench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomblench/subscriptions","organizations_url":"https://api.github.com/users/tomblench/orgs","repos_url":"https://api.github.com/users/tomblench/repos","events_url":"https://api.github.com/users/tomblench/events{/privacy}","received_events_url":"https://api.github.com/users/tomblench/received_events","type":"User","site_admin":false},"assignees":[{"login":"tomblench","id":6302842,"avatar_url":"https://avatars.githubusercontent.com/u/6302842?v=3","gravatar_id":"","url":"https://api.github.com/users/tomblench","html_url":"https://github.com/tomblench","followers_url":"https://api.github.com/users/tomblench/followers","following_url":"https://api.github.com/users/tomblench/following{/other_user}","gists_url":"https://api.github.com/users/tomblench/gists{/gist_id}","starred_url":"https://api.github.com/users/tomblench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomblench/subscriptions","organizations_url":"https://api.github.com/users/tomblench/orgs","repos_url":"https://api.github.com/users/tomblench/repos","events_url":"https://api.github.com/users/tomblench/events{/privacy}","received_events_url":"https://api.github.com/users/tomblench/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-06-22T10:59:57Z","updated_at":"2017-02-07T10:27:55Z","closed_at":"2017-02-07T10:27:55Z","body":"The IndexManager lifecycle is tied to that of a Datastore because it cannot exist without it. We should cement that relationship by moving the public methods from IndexManager to Datastore. This will also make the query experience on Android and iOS more consistent.\n\n~~1.  Mark IndexManager as not API (this could be a major version change if for example making IndexManager a default visibility class, so will need some careful thought around deprecation or using the not API tags and backwards compatibility)\n2.  Add a DatastoreIndexManager interface containing the public methods in the IndexManager\n3.  DatastoreImpl to implement Datastore and DatastoreIndexManager\n4. Close IndexManager when the datastore is closed~~\n\n(See edit below)\n"},"comment":{"url":"https://api.github.com/repos/cloudant/sync-android/issues/comments/277959046","html_url":"https://github.com/cloudant/sync-android/issues/284#issuecomment-277959046","issue_url":"https://api.github.com/repos/cloudant/sync-android/issues/284","id":277959046,"user":{"login":"ricellis","id":10698320,"avatar_url":"https://avatars.githubusercontent.com/u/10698320?v=3","gravatar_id":"","url":"https://api.github.com/users/ricellis","html_url":"https://github.com/ricellis","followers_url":"https://api.github.com/users/ricellis/followers","following_url":"https://api.github.com/users/ricellis/following{/other_user}","gists_url":"https://api.github.com/users/ricellis/gists{/gist_id}","starred_url":"https://api.github.com/users/ricellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricellis/subscriptions","organizations_url":"https://api.github.com/users/ricellis/orgs","repos_url":"https://api.github.com/users/ricellis/repos","events_url":"https://api.github.com/users/ricellis/events{/privacy}","received_events_url":"https://api.github.com/users/ricellis/received_events","type":"User","site_admin":false},"created_at":"2017-02-07T10:27:54Z","updated_at":"2017-02-07T10:27:54Z","body":"Fixed by the merge of v2 stuff #501 "}}
{"actor":{"display_login":"ricellis"}}