{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/parity/pulls/comments/136815706","pull_request_review_id":60406482,"id":136815706,"diff_hunk":"@@ -53,6 +59,9 @@ const HISTORY: u64 = 2048;\n /// The best block key. Maps to an RLP list: [best_era, last_era]\n const CURRENT_KEY: &'static [u8] = &*b\"best_and_latest\";\n \n+/// Key storing the last canonical epoch transition.\n+const LAST_CANONICAL_TRANSITION: &'static [u8] = &*b\"canonical_transition\";","path":"ethcore/light/src/client/header_chain.rs","position":42,"original_position":42,"commit_id":"7ac3dd088916c356f5df33e32ff5fbed8cac9709","original_commit_id":"ffae847b48a260789e265ca1e2bec83459101d26","user":{"login":"rphmeier","id":10121380,"avatar_url":"https://avatars1.githubusercontent.com/u/10121380?v=4","gravatar_id":"","url":"https://api.github.com/users/rphmeier","html_url":"https://github.com/rphmeier","followers_url":"https://api.github.com/users/rphmeier/followers","following_url":"https://api.github.com/users/rphmeier/following{/other_user}","gists_url":"https://api.github.com/users/rphmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/rphmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphmeier/subscriptions","organizations_url":"https://api.github.com/users/rphmeier/orgs","repos_url":"https://api.github.com/users/rphmeier/repos","events_url":"https://api.github.com/users/rphmeier/events{/privacy}","received_events_url":"https://api.github.com/users/rphmeier/received_events","type":"User","site_admin":false},"body":"No, the most recent version of the code instantiates this key if it doesn't exist already. Only chains which don't use epochs can be synced by the light client right now anyway. When running the new version, their genesis epoch data will be populated correctly.","created_at":"2017-09-04T12:51:36Z","updated_at":"2017-09-04T12:51:37Z","html_url":"https://github.com/paritytech/parity/pull/6370#discussion_r136815706","pull_request_url":"https://api.github.com/repos/paritytech/parity/pulls/6370","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments/136815706"},"html":{"href":"https://github.com/paritytech/parity/pull/6370#discussion_r136815706"},"pull_request":{"href":"https://api.github.com/repos/paritytech/parity/pulls/6370"}},"in_reply_to_id":136691538},"pull_request":{"url":"https://api.github.com/repos/paritytech/parity/pulls/6370","id":137468987,"html_url":"https://github.com/paritytech/parity/pull/6370","diff_url":"https://github.com/paritytech/parity/pull/6370.diff","patch_url":"https://github.com/paritytech/parity/pull/6370.patch","issue_url":"https://api.github.com/repos/paritytech/parity/issues/6370","number":6370,"state":"open","locked":false,"title":"Light-client sync for contract-based PoA","user":{"login":"rphmeier","id":10121380,"avatar_url":"https://avatars1.githubusercontent.com/u/10121380?v=4","gravatar_id":"","url":"https://api.github.com/users/rphmeier","html_url":"https://github.com/rphmeier","followers_url":"https://api.github.com/users/rphmeier/followers","following_url":"https://api.github.com/users/rphmeier/following{/other_user}","gists_url":"https://api.github.com/users/rphmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/rphmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphmeier/subscriptions","organizations_url":"https://api.github.com/users/rphmeier/orgs","repos_url":"https://api.github.com/users/rphmeier/repos","events_url":"https://api.github.com/users/rphmeier/events{/privacy}","received_events_url":"https://api.github.com/users/rphmeier/received_events","type":"User","site_admin":false},"body":"Summary of changes:\r\n  - Generalize state-dependent proofs\r\n  - Check for signals.\r\n  - Store pending and finalized epoch changes in the light client's header chain.\r\n  - Separate `EngineClient` from `BlockChainClient` and implement `EngineClient` for light client.\r\n  - Fetch and check epoch change proofs from the network on demand during light sync.","created_at":"2017-08-24T14:32:00Z","updated_at":"2017-09-04T12:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8ef8ae865f0d9882016db3a58cec1c844acb9c3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"keorn","id":7750981,"avatar_url":"https://avatars0.githubusercontent.com/u/7750981?v=4","gravatar_id":"","url":"https://api.github.com/users/keorn","html_url":"https://github.com/keorn","followers_url":"https://api.github.com/users/keorn/followers","following_url":"https://api.github.com/users/keorn/following{/other_user}","gists_url":"https://api.github.com/users/keorn/gists{/gist_id}","starred_url":"https://api.github.com/users/keorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keorn/subscriptions","organizations_url":"https://api.github.com/users/keorn/orgs","repos_url":"https://api.github.com/users/keorn/repos","events_url":"https://api.github.com/users/keorn/events{/privacy}","received_events_url":"https://api.github.com/users/keorn/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/parity/pulls/6370/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity/pulls/6370/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity/issues/6370/comments","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/7ac3dd088916c356f5df33e32ff5fbed8cac9709","head":{"label":"paritytech:light-poa","ref":"light-poa","sha":"7ac3dd088916c356f5df33e32ff5fbed8cac9709","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2017-09-04T10:34:38Z","pushed_at":"2017-09-04T12:47:58Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"","size":101715,"stargazers_count":1978,"watchers_count":1978,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":390,"mirror_url":null,"open_issues_count":290,"forks":390,"open_issues":290,"watchers":1978,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"b731ccea1843560ff436f563c2b6906d2d12cdb2","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2017-09-04T10:34:38Z","pushed_at":"2017-09-04T12:47:58Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"","size":101715,"stargazers_count":1978,"watchers_count":1978,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":390,"mirror_url":null,"open_issues_count":290,"forks":390,"open_issues":290,"watchers":1978,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/6370"},"html":{"href":"https://github.com/paritytech/parity/pull/6370"},"issue":{"href":"https://api.github.com/repos/paritytech/parity/issues/6370"},"comments":{"href":"https://api.github.com/repos/paritytech/parity/issues/6370/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity/pulls/6370/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity/pulls/6370/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity/statuses/7ac3dd088916c356f5df33e32ff5fbed8cac9709"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rphmeier"}}