{"action":"opened","number":7189,"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/7189","id":114060245,"html_url":"https://github.com/playframework/playframework/pull/7189","diff_url":"https://github.com/playframework/playframework/pull/7189.diff","patch_url":"https://github.com/playframework/playframework/pull/7189.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/7189","number":7189,"state":"open","locked":false,"title":"Make it possible to disable the reverse router","user":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars2.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"body":"Fixes #7185. Makes sure RoutesPrefix is generated regardless of whether reverse routes are enabled, since it is used in the generated forwards router.\r\n\r\nOne of the scripted tests was failing for me locally but it wasn't clear why. Maybe someone more familiar with those tests can help.","created_at":"2017-04-04T02:36:01Z","updated_at":"2017-04-04T02:36:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/7189/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/7189/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/7189/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/c33f38dcc90e0e5086fc72b02038304b53be8b5c","head":{"label":"gmethvin:disable-reverse-routes","ref":"disable-reverse-routes","sha":"c33f38dcc90e0e5086fc72b02038304b53be8b5c","user":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars2.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"repo":{"id":10559361,"name":"playframework","full_name":"gmethvin/playframework","owner":{"login":"gmethvin","id":171663,"avatar_url":"https://avatars2.githubusercontent.com/u/171663?v=3","gravatar_id":"","url":"https://api.github.com/users/gmethvin","html_url":"https://github.com/gmethvin","followers_url":"https://api.github.com/users/gmethvin/followers","following_url":"https://api.github.com/users/gmethvin/following{/other_user}","gists_url":"https://api.github.com/users/gmethvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gmethvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmethvin/subscriptions","organizations_url":"https://api.github.com/users/gmethvin/orgs","repos_url":"https://api.github.com/users/gmethvin/repos","events_url":"https://api.github.com/users/gmethvin/events{/privacy}","received_events_url":"https://api.github.com/users/gmethvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmethvin/playframework","description":"Play framework 2.x","fork":true,"url":"https://api.github.com/repos/gmethvin/playframework","forks_url":"https://api.github.com/repos/gmethvin/playframework/forks","keys_url":"https://api.github.com/repos/gmethvin/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmethvin/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmethvin/playframework/teams","hooks_url":"https://api.github.com/repos/gmethvin/playframework/hooks","issue_events_url":"https://api.github.com/repos/gmethvin/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/gmethvin/playframework/events","assignees_url":"https://api.github.com/repos/gmethvin/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/gmethvin/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/gmethvin/playframework/tags","blobs_url":"https://api.github.com/repos/gmethvin/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmethvin/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmethvin/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmethvin/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmethvin/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/gmethvin/playframework/languages","stargazers_url":"https://api.github.com/repos/gmethvin/playframework/stargazers","contributors_url":"https://api.github.com/repos/gmethvin/playframework/contributors","subscribers_url":"https://api.github.com/repos/gmethvin/playframework/subscribers","subscription_url":"https://api.github.com/repos/gmethvin/playframework/subscription","commits_url":"https://api.github.com/repos/gmethvin/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmethvin/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmethvin/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmethvin/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmethvin/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/gmethvin/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmethvin/playframework/merges","archive_url":"https://api.github.com/repos/gmethvin/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmethvin/playframework/downloads","issues_url":"https://api.github.com/repos/gmethvin/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/gmethvin/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/gmethvin/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/gmethvin/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmethvin/playframework/labels{/name}","releases_url":"https://api.github.com/repos/gmethvin/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/gmethvin/playframework/deployments","created_at":"2013-06-07T21:37:27Z","updated_at":"2014-07-24T15:49:25Z","pushed_at":"2017-04-04T02:33:54Z","git_url":"git://github.com/gmethvin/playframework.git","ssh_url":"git@github.com:gmethvin/playframework.git","clone_url":"https://github.com/gmethvin/playframework.git","svn_url":"https://github.com/gmethvin/playframework","homepage":"http://www.playframework.org/","size":85358,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"5e7cf8ca728e14eb51145ea68c8f3d4bee9b141c","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars3.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars3.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","deployments_url":"https://api.github.com/repos/playframework/playframework/deployments","created_at":"2011-09-07T09:24:08Z","updated_at":"2017-04-03T20:09:09Z","pushed_at":"2017-04-04T02:14:17Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":86227,"stargazers_count":9150,"watchers_count":9150,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3165,"mirror_url":null,"open_issues_count":272,"forks":3165,"open_issues":272,"watchers":9150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/7189"},"html":{"href":"https://github.com/playframework/playframework/pull/7189"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/7189"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/7189/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/7189/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/7189/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/c33f38dcc90e0e5086fc72b02038304b53be8b5c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"gmethvin"}}