{"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls/13","id":156534938,"html_url":"https://github.com/JunichiIto/ruby-problem-201712/pull/13","diff_url":"https://github.com/JunichiIto/ruby-problem-201712/pull/13.diff","patch_url":"https://github.com/JunichiIto/ruby-problem-201712/pull/13.patch","issue_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/issues/13","number":13,"state":"open","locked":false,"title":"レビュー by sinamon129","user":{"login":"sinamon129","id":2012540,"avatar_url":"https://avatars1.githubusercontent.com/u/2012540?v=4","gravatar_id":"","url":"https://api.github.com/users/sinamon129","html_url":"https://github.com/sinamon129","followers_url":"https://api.github.com/users/sinamon129/followers","following_url":"https://api.github.com/users/sinamon129/following{/other_user}","gists_url":"https://api.github.com/users/sinamon129/gists{/gist_id}","starred_url":"https://api.github.com/users/sinamon129/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinamon129/subscriptions","organizations_url":"https://api.github.com/users/sinamon129/orgs","repos_url":"https://api.github.com/users/sinamon129/repos","events_url":"https://api.github.com/users/sinamon129/events{/privacy}","received_events_url":"https://api.github.com/users/sinamon129/received_events","type":"User","site_admin":false},"body":"コードレビューです 😆 \r\n\r\n- 3行目~ 8行目までの転置行列を作る部分について\r\n\t- 組み込み関数がある部分は自分で実装せずに使ってみるとよいです \r\n\t- Arrayクラスには、自身を行列と見立てて行列の転置をおこなう `#transpose` があるので利用してみましょう \r\n- `#split(\"\\n\")` は `#lines` とも書けますよ！\r\n- ブロックの引数が省略形になっていたので、何が入っているか判断できる名前だといいかもしれないです 🤔 \r\n\t- 2行目と10行目のsはそれぞれ文字列と配列で別物ですね\r\n- 文脈でメソッドを分割すると、他の人が処理を追いやすくなると思います 😄 \r\n\t- 文字列をArrayへ変換している部分\r\n\t- Arrayを文字列に変換する部分","created_at":"2017-12-05T18:07:09Z","updated_at":"2017-12-05T18:07:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls/13/commits","review_comments_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls/13/comments","review_comment_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/issues/13/comments","statuses_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/statuses/6364f9f640e44c37bfc4e4c6d118b7fd73373005","head":{"label":"sinamon129:refactor-treansport","ref":"refactor-treansport","sha":"6364f9f640e44c37bfc4e4c6d118b7fd73373005","user":{"login":"sinamon129","id":2012540,"avatar_url":"https://avatars1.githubusercontent.com/u/2012540?v=4","gravatar_id":"","url":"https://api.github.com/users/sinamon129","html_url":"https://github.com/sinamon129","followers_url":"https://api.github.com/users/sinamon129/followers","following_url":"https://api.github.com/users/sinamon129/following{/other_user}","gists_url":"https://api.github.com/users/sinamon129/gists{/gist_id}","starred_url":"https://api.github.com/users/sinamon129/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinamon129/subscriptions","organizations_url":"https://api.github.com/users/sinamon129/orgs","repos_url":"https://api.github.com/users/sinamon129/repos","events_url":"https://api.github.com/users/sinamon129/events{/privacy}","received_events_url":"https://api.github.com/users/sinamon129/received_events","type":"User","site_admin":false},"repo":{"id":113210533,"name":"ruby-problem-201712","full_name":"sinamon129/ruby-problem-201712","owner":{"login":"sinamon129","id":2012540,"avatar_url":"https://avatars1.githubusercontent.com/u/2012540?v=4","gravatar_id":"","url":"https://api.github.com/users/sinamon129","html_url":"https://github.com/sinamon129","followers_url":"https://api.github.com/users/sinamon129/followers","following_url":"https://api.github.com/users/sinamon129/following{/other_user}","gists_url":"https://api.github.com/users/sinamon129/gists{/gist_id}","starred_url":"https://api.github.com/users/sinamon129/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinamon129/subscriptions","organizations_url":"https://api.github.com/users/sinamon129/orgs","repos_url":"https://api.github.com/users/sinamon129/repos","events_url":"https://api.github.com/users/sinamon129/events{/privacy}","received_events_url":"https://api.github.com/users/sinamon129/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sinamon129/ruby-problem-201712","description":"A small Ruby problem for Rails developers meetup December 2017.","fork":true,"url":"https://api.github.com/repos/sinamon129/ruby-problem-201712","forks_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/forks","keys_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/teams","hooks_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/hooks","issue_events_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/issues/events{/number}","events_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/events","assignees_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/assignees{/user}","branches_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/branches{/branch}","tags_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/tags","blobs_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/statuses/{sha}","languages_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/languages","stargazers_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/stargazers","contributors_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/contributors","subscribers_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/subscribers","subscription_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/subscription","commits_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/contents/{+path}","compare_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/merges","archive_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/downloads","issues_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/issues{/number}","pulls_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/pulls{/number}","milestones_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/milestones{/number}","notifications_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/labels{/name}","releases_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/releases{/id}","deployments_url":"https://api.github.com/repos/sinamon129/ruby-problem-201712/deployments","created_at":"2017-12-05T17:08:57Z","updated_at":"2017-12-05T17:08:58Z","pushed_at":"2017-12-05T17:49:51Z","git_url":"git://github.com/sinamon129/ruby-problem-201712.git","ssh_url":"git@github.com:sinamon129/ruby-problem-201712.git","clone_url":"https://github.com/sinamon129/ruby-problem-201712.git","svn_url":"https://github.com/sinamon129/ruby-problem-201712","homepage":null,"size":8,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JunichiIto:master","ref":"master","sha":"17bce38cef45bfb47b89664f33006d5712f1afc5","user":{"login":"JunichiIto","id":1148320,"avatar_url":"https://avatars2.githubusercontent.com/u/1148320?v=4","gravatar_id":"","url":"https://api.github.com/users/JunichiIto","html_url":"https://github.com/JunichiIto","followers_url":"https://api.github.com/users/JunichiIto/followers","following_url":"https://api.github.com/users/JunichiIto/following{/other_user}","gists_url":"https://api.github.com/users/JunichiIto/gists{/gist_id}","starred_url":"https://api.github.com/users/JunichiIto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunichiIto/subscriptions","organizations_url":"https://api.github.com/users/JunichiIto/orgs","repos_url":"https://api.github.com/users/JunichiIto/repos","events_url":"https://api.github.com/users/JunichiIto/events{/privacy}","received_events_url":"https://api.github.com/users/JunichiIto/received_events","type":"User","site_admin":false},"repo":{"id":111983387,"name":"ruby-problem-201712","full_name":"JunichiIto/ruby-problem-201712","owner":{"login":"JunichiIto","id":1148320,"avatar_url":"https://avatars2.githubusercontent.com/u/1148320?v=4","gravatar_id":"","url":"https://api.github.com/users/JunichiIto","html_url":"https://github.com/JunichiIto","followers_url":"https://api.github.com/users/JunichiIto/followers","following_url":"https://api.github.com/users/JunichiIto/following{/other_user}","gists_url":"https://api.github.com/users/JunichiIto/gists{/gist_id}","starred_url":"https://api.github.com/users/JunichiIto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JunichiIto/subscriptions","organizations_url":"https://api.github.com/users/JunichiIto/orgs","repos_url":"https://api.github.com/users/JunichiIto/repos","events_url":"https://api.github.com/users/JunichiIto/events{/privacy}","received_events_url":"https://api.github.com/users/JunichiIto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JunichiIto/ruby-problem-201712","description":"A small Ruby problem for Rails developers meetup December 2017.","fork":false,"url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712","forks_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/forks","keys_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/teams","hooks_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/hooks","issue_events_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/issues/events{/number}","events_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/events","assignees_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/assignees{/user}","branches_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/branches{/branch}","tags_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/tags","blobs_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/git/refs{/sha}","trees_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/statuses/{sha}","languages_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/languages","stargazers_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/stargazers","contributors_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/contributors","subscribers_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/subscribers","subscription_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/subscription","commits_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/commits{/sha}","git_commits_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/git/commits{/sha}","comments_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/comments{/number}","issue_comment_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/issues/comments{/number}","contents_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/contents/{+path}","compare_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/merges","archive_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/downloads","issues_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/issues{/number}","pulls_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls{/number}","milestones_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/milestones{/number}","notifications_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/labels{/name}","releases_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/releases{/id}","deployments_url":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/deployments","created_at":"2017-11-25T06:52:43Z","updated_at":"2017-12-02T09:10:35Z","pushed_at":"2017-12-05T16:52:30Z","git_url":"git://github.com/JunichiIto/ruby-problem-201712.git","ssh_url":"git@github.com:JunichiIto/ruby-problem-201712.git","clone_url":"https://github.com/JunichiIto/ruby-problem-201712.git","svn_url":"https://github.com/JunichiIto/ruby-problem-201712","homepage":null,"size":8,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":20,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls/13"},"html":{"href":"https://github.com/JunichiIto/ruby-problem-201712/pull/13"},"issue":{"href":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/issues/13"},"comments":{"href":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/JunichiIto/ruby-problem-201712/statuses/6364f9f640e44c37bfc4e4c6d118b7fd73373005"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"sinamon129"}}