{"action":"created","issue":{"url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1742","repository_url":"https://api.github.com/repos/graphite-project/graphite-web","labels_url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1742/labels{/name}","comments_url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1742/comments","events_url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1742/events","html_url":"https://github.com/graphite-project/graphite-web/pull/1742","id":187972346,"number":1742,"title":"Don't fetch data from offline backends.","user":{"login":"nyerup","id":76253,"avatar_url":"https://avatars.githubusercontent.com/u/76253?v=3","gravatar_id":"","url":"https://api.github.com/users/nyerup","html_url":"https://github.com/nyerup","followers_url":"https://api.github.com/users/nyerup/followers","following_url":"https://api.github.com/users/nyerup/following{/other_user}","gists_url":"https://api.github.com/users/nyerup/gists{/gist_id}","starred_url":"https://api.github.com/users/nyerup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyerup/subscriptions","organizations_url":"https://api.github.com/users/nyerup/orgs","repos_url":"https://api.github.com/users/nyerup/repos","events_url":"https://api.github.com/users/nyerup/events{/privacy}","received_events_url":"https://api.github.com/users/nyerup/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-08T11:51:11Z","updated_at":"2017-02-18T22:10:17Z","closed_at":"2017-02-18T22:01:45Z","pull_request":{"url":"https://api.github.com/repos/graphite-project/graphite-web/pulls/1742","html_url":"https://github.com/graphite-project/graphite-web/pull/1742","diff_url":"https://github.com/graphite-project/graphite-web/pull/1742.diff","patch_url":"https://github.com/graphite-project/graphite-web/pull/1742.patch"},"body":"I experienced that having a CLUSTER_NODE offline rendered Graphite\r\ncompletely unresponsive, and found out that this was due to an uncaught\r\nexception in HTTPConnectionWithTimeout.connect().\r\n\r\nIn addition to this, render/datalib.py always iterated through all\r\nCLUSTER_NODEs, without considering their 'available' property, i.e. if\r\nthey'd been marked as offline.\r\n\r\nrender/datalib.py:\r\n  When fetching remote data, bypass remote stores that aren't available.\r\n\r\nremote_storage.py:\r\n  Also mark stores unavailable if requests to them fail on network or\r\n  transport level."},"comment":{"url":"https://api.github.com/repos/graphite-project/graphite-web/issues/comments/280878865","html_url":"https://github.com/graphite-project/graphite-web/pull/1742#issuecomment-280878865","issue_url":"https://api.github.com/repos/graphite-project/graphite-web/issues/1742","id":280878865,"user":{"login":"nyerup","id":76253,"avatar_url":"https://avatars.githubusercontent.com/u/76253?v=3","gravatar_id":"","url":"https://api.github.com/users/nyerup","html_url":"https://github.com/nyerup","followers_url":"https://api.github.com/users/nyerup/followers","following_url":"https://api.github.com/users/nyerup/following{/other_user}","gists_url":"https://api.github.com/users/nyerup/gists{/gist_id}","starred_url":"https://api.github.com/users/nyerup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyerup/subscriptions","organizations_url":"https://api.github.com/users/nyerup/orgs","repos_url":"https://api.github.com/users/nyerup/repos","events_url":"https://api.github.com/users/nyerup/events{/privacy}","received_events_url":"https://api.github.com/users/nyerup/received_events","type":"User","site_admin":false},"created_at":"2017-02-18T22:10:17Z","updated_at":"2017-02-18T22:10:17Z","body":"All right, makes good sense. Sorry for not getting around to clearing out these questions sooner.\r\nI'll look through #1818, and open a new merge request if I find anything meaningful to contribute."}}
{"actor":{"display_login":"nyerup"}}