{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/107806471","pull_request_review_id":28801009,"id":107806471,"diff_hunk":"@@ -66,6 +66,8 @@ const (\n \tZeroedThickDiskType       = \"zeroedThick\"\n \tVolDir                    = \"kubevols\"\n \tRoundTripperDefaultCount  = 3\n+\tDummyVMName               = \"kubernetes-helper-vm\"","path":"pkg/cloudprovider/providers/vsphere/vsphere.go","position":4,"original_position":4,"commit_id":"a0a4351dbbe46f7e2b1c9cdb7eb08a608e1af4a0","original_commit_id":"f060456bdd14b25fd89d5f195dd346651adabfcf","user":{"login":"kerneltime","id":774455,"avatar_url":"https://avatars2.githubusercontent.com/u/774455?v=3","gravatar_id":"","url":"https://api.github.com/users/kerneltime","html_url":"https://github.com/kerneltime","followers_url":"https://api.github.com/users/kerneltime/followers","following_url":"https://api.github.com/users/kerneltime/following{/other_user}","gists_url":"https://api.github.com/users/kerneltime/gists{/gist_id}","starred_url":"https://api.github.com/users/kerneltime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerneltime/subscriptions","organizations_url":"https://api.github.com/users/kerneltime/orgs","repos_url":"https://api.github.com/users/kerneltime/repos","events_url":"https://api.github.com/users/kerneltime/events{/privacy}","received_events_url":"https://api.github.com/users/kerneltime/received_events","type":"User","site_admin":false},"body":"Ok. I guess since the VM is not deleted this is true only for the first and second volume creation race.","created_at":"2017-03-23T23:20:02Z","updated_at":"2017-03-23T23:20:02Z","html_url":"https://github.com/kubernetes/kubernetes/pull/42974#discussion_r107806471","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42974","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/107806471"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/42974#discussion_r107806471"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42974"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42974","id":110334595,"html_url":"https://github.com/kubernetes/kubernetes/pull/42974","diff_url":"https://github.com/kubernetes/kubernetes/pull/42974.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/42974.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42974","number":42974,"state":"open","locked":false,"title":"VSAN policy support for storage volume provisioning inside kubernetes","user":{"login":"BaluDontu","id":22899615,"avatar_url":"https://avatars2.githubusercontent.com/u/22899615?v=3","gravatar_id":"","url":"https://api.github.com/users/BaluDontu","html_url":"https://github.com/BaluDontu","followers_url":"https://api.github.com/users/BaluDontu/followers","following_url":"https://api.github.com/users/BaluDontu/following{/other_user}","gists_url":"https://api.github.com/users/BaluDontu/gists{/gist_id}","starred_url":"https://api.github.com/users/BaluDontu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaluDontu/subscriptions","organizations_url":"https://api.github.com/users/BaluDontu/orgs","repos_url":"https://api.github.com/users/BaluDontu/repos","events_url":"https://api.github.com/users/BaluDontu/events{/privacy}","received_events_url":"https://api.github.com/users/BaluDontu/received_events","type":"User","site_admin":false},"body":"The vsphere users will have the ability to specify custom Virtual SAN Storage Capabilities during dynamic volume provisioning. You can now define storage requirements, such as performance and availability, in the form of storage capabilities during dynamic volume provisioning. The storage capability requirements are converted into a Virtual SAN policy which are then pushed down to the Virtual SAN layer when a storage volume (virtual disk) is being created. The virtual disk is distributed across the Virtual SAN datastore to meet the requirements.\r\n\r\nFor example, User creates a storage class with VSAN storage capabilities:\r\n\r\n> kind: StorageClass\r\n> apiVersion: storage.k8s.io/v1beta1\r\n> metadata:\r\n>   name: slow\r\n> provisioner: kubernetes.io/vsphere-volume\r\n> parameters:\r\n>   hostFailuresToTolerate: \"2\"\r\n>   diskStripes: \"1\"\r\n>   cacheReservation: \"20\"\r\n>   datastore: VSANDatastore\r\n\r\nThe vSphere Cloud provider provisions a virtual disk (VMDK) on VSAN with the policy configured to the disk.\r\n\r\nWhen you know storage requirements of your application that is being deployed on a container, you can specify these storage capabilities when you create a storage class inside Kubernetes.\r\n\r\n@pdhamdhere @tthole @abrarshivani @divyenpatel \r\n\r\n","created_at":"2017-03-13T03:40:25Z","updated_at":"2017-03-23T23:20:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8578a998e43a6e0c37590e71c39173f690b6e015","assignee":{"login":"kerneltime","id":774455,"avatar_url":"https://avatars2.githubusercontent.com/u/774455?v=3","gravatar_id":"","url":"https://api.github.com/users/kerneltime","html_url":"https://github.com/kerneltime","followers_url":"https://api.github.com/users/kerneltime/followers","following_url":"https://api.github.com/users/kerneltime/following{/other_user}","gists_url":"https://api.github.com/users/kerneltime/gists{/gist_id}","starred_url":"https://api.github.com/users/kerneltime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerneltime/subscriptions","organizations_url":"https://api.github.com/users/kerneltime/orgs","repos_url":"https://api.github.com/users/kerneltime/repos","events_url":"https://api.github.com/users/kerneltime/events{/privacy}","received_events_url":"https://api.github.com/users/kerneltime/received_events","type":"User","site_admin":false},"assignees":[{"login":"kerneltime","id":774455,"avatar_url":"https://avatars2.githubusercontent.com/u/774455?v=3","gravatar_id":"","url":"https://api.github.com/users/kerneltime","html_url":"https://github.com/kerneltime","followers_url":"https://api.github.com/users/kerneltime/followers","following_url":"https://api.github.com/users/kerneltime/following{/other_user}","gists_url":"https://api.github.com/users/kerneltime/gists{/gist_id}","starred_url":"https://api.github.com/users/kerneltime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerneltime/subscriptions","organizations_url":"https://api.github.com/users/kerneltime/orgs","repos_url":"https://api.github.com/users/kerneltime/repos","events_url":"https://api.github.com/users/kerneltime/events{/privacy}","received_events_url":"https://api.github.com/users/kerneltime/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42974/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42974/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42974/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a0a4351dbbe46f7e2b1c9cdb7eb08a608e1af4a0","head":{"label":"vmware:VSANPolicyProvisioningForKubernetesOnKubernetesRepo","ref":"VSANPolicyProvisioningForKubernetesOnKubernetesRepo","sha":"a0a4351dbbe46f7e2b1c9cdb7eb08a608e1af4a0","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49536898,"name":"kubernetes","full_name":"vmware/kubernetes","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/vmware/kubernetes","forks_url":"https://api.github.com/repos/vmware/kubernetes/forks","keys_url":"https://api.github.com/repos/vmware/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/kubernetes/teams","hooks_url":"https://api.github.com/repos/vmware/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vmware/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/kubernetes/events","assignees_url":"https://api.github.com/repos/vmware/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/kubernetes/tags","blobs_url":"https://api.github.com/repos/vmware/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vmware/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vmware/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vmware/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vmware/kubernetes/subscription","commits_url":"https://api.github.com/repos/vmware/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/kubernetes/merges","archive_url":"https://api.github.com/repos/vmware/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/kubernetes/downloads","issues_url":"https://api.github.com/repos/vmware/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vmware/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/kubernetes/deployments","created_at":"2016-01-12T23:58:29Z","updated_at":"2017-01-25T00:24:09Z","pushed_at":"2017-03-23T22:48:02Z","git_url":"git://github.com/vmware/kubernetes.git","ssh_url":"git@github.com:vmware/kubernetes.git","clone_url":"https://github.com/vmware/kubernetes.git","svn_url":"https://github.com/vmware/kubernetes","homepage":"http://kubernetes.io","size":417503,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":48,"forks":7,"open_issues":48,"watchers":9,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1e879c69ecf09ec73fc35ecc014ada41624bd002","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-03-23T22:48:37Z","pushed_at":"2017-03-23T23:14:13Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":586301,"stargazers_count":21719,"watchers_count":21719,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7495,"mirror_url":null,"open_issues_count":5613,"forks":7495,"open_issues":5613,"watchers":21719,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42974"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/42974"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/42974"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/42974/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42974/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42974/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a0a4351dbbe46f7e2b1c9cdb7eb08a608e1af4a0"}}}}
{"actor":{"display_login":"kerneltime"}}