{"action":"created","comment":{"url":"https://api.github.com/repos/improbable-eng/kedge/pulls/comments/158048053","pull_request_review_id":84792118,"id":158048053,"diff_hunk":"@@ -88,15 +98,33 @@ func (r *static) serviceNameMatches(fullMethodName string, matcher string) bool\n \treturn fullMethodName == matcher\n }\n \n-func (r *static) authorityMatches(md metautils.NiceMD, matcher string) bool {\n-\tif matcher == \"\" {\n+func (r *static) authorityHostMatches(md metautils.NiceMD, hostMatcher string) bool {\n+\tif hostMatcher == \"\" {\n+\t\treturn true\n+\t}\n+\tauth := md.Get(\":authority\")\n+\tif auth == \"\" {\n+\t\treturn false // there was no authority header and it was expected\n+\t}\n+\n+\treturn stripPort(auth) == hostMatcher","path":"pkg/kedge/grpc/director/router/router.go","position":48,"original_position":48,"commit_id":"650bb76edc8c5fd092073759e6ce045a2dd910a7","original_commit_id":"d4048b7dc708b02ee1051c713353df82a5b724fa","user":{"login":"stefan-improbable","id":27731402,"avatar_url":"https://avatars1.githubusercontent.com/u/27731402?v=4","gravatar_id":"","url":"https://api.github.com/users/stefan-improbable","html_url":"https://github.com/stefan-improbable","followers_url":"https://api.github.com/users/stefan-improbable/followers","following_url":"https://api.github.com/users/stefan-improbable/following{/other_user}","gists_url":"https://api.github.com/users/stefan-improbable/gists{/gist_id}","starred_url":"https://api.github.com/users/stefan-improbable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefan-improbable/subscriptions","organizations_url":"https://api.github.com/users/stefan-improbable/orgs","repos_url":"https://api.github.com/users/stefan-improbable/repos","events_url":"https://api.github.com/users/stefan-improbable/events{/privacy}","received_events_url":"https://api.github.com/users/stefan-improbable/received_events","type":"User","site_admin":false},"body":"Can you use net.SplitHostPort and also in authorityPortMatches?","created_at":"2017-12-20T15:08:59Z","updated_at":"2017-12-20T15:08:59Z","html_url":"https://github.com/improbable-eng/kedge/pull/85#discussion_r158048053","pull_request_url":"https://api.github.com/repos/improbable-eng/kedge/pulls/85","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/improbable-eng/kedge/pulls/comments/158048053"},"html":{"href":"https://github.com/improbable-eng/kedge/pull/85#discussion_r158048053"},"pull_request":{"href":"https://api.github.com/repos/improbable-eng/kedge/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/improbable-eng/kedge/pulls/85","id":159423284,"html_url":"https://github.com/improbable-eng/kedge/pull/85","diff_url":"https://github.com/improbable-eng/kedge/pull/85.diff","patch_url":"https://github.com/improbable-eng/kedge/pull/85.patch","issue_url":"https://api.github.com/repos/improbable-eng/kedge/issues/85","number":85,"state":"open","locked":false,"title":"Fixed not working authority matcher for kedge gRPC, Added more tags.","user":{"login":"Bplotka","id":6950331,"avatar_url":"https://avatars2.githubusercontent.com/u/6950331?v=4","gravatar_id":"","url":"https://api.github.com/users/Bplotka","html_url":"https://github.com/Bplotka","followers_url":"https://api.github.com/users/Bplotka/followers","following_url":"https://api.github.com/users/Bplotka/following{/other_user}","gists_url":"https://api.github.com/users/Bplotka/gists{/gist_id}","starred_url":"https://api.github.com/users/Bplotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bplotka/subscriptions","organizations_url":"https://api.github.com/users/Bplotka/orgs","repos_url":"https://api.github.com/users/Bplotka/repos","events_url":"https://api.github.com/users/Bplotka/events{/privacy}","received_events_url":"https://api.github.com/users/Bplotka/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Bartek Plotka <bwplotka@gmail.com>","created_at":"2017-12-20T13:59:37Z","updated_at":"2017-12-20T15:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdc97b27cad1e2706ac3185c72e6b0221dcfb288","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joshpmcghee","id":4654998,"avatar_url":"https://avatars1.githubusercontent.com/u/4654998?v=4","gravatar_id":"","url":"https://api.github.com/users/joshpmcghee","html_url":"https://github.com/joshpmcghee","followers_url":"https://api.github.com/users/joshpmcghee/followers","following_url":"https://api.github.com/users/joshpmcghee/following{/other_user}","gists_url":"https://api.github.com/users/joshpmcghee/gists{/gist_id}","starred_url":"https://api.github.com/users/joshpmcghee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshpmcghee/subscriptions","organizations_url":"https://api.github.com/users/joshpmcghee/orgs","repos_url":"https://api.github.com/users/joshpmcghee/repos","events_url":"https://api.github.com/users/joshpmcghee/events{/privacy}","received_events_url":"https://api.github.com/users/joshpmcghee/received_events","type":"User","site_admin":false},{"login":"adamhosier","id":8737058,"avatar_url":"https://avatars1.githubusercontent.com/u/8737058?v=4","gravatar_id":"","url":"https://api.github.com/users/adamhosier","html_url":"https://github.com/adamhosier","followers_url":"https://api.github.com/users/adamhosier/followers","following_url":"https://api.github.com/users/adamhosier/following{/other_user}","gists_url":"https://api.github.com/users/adamhosier/gists{/gist_id}","starred_url":"https://api.github.com/users/adamhosier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamhosier/subscriptions","organizations_url":"https://api.github.com/users/adamhosier/orgs","repos_url":"https://api.github.com/users/adamhosier/repos","events_url":"https://api.github.com/users/adamhosier/events{/privacy}","received_events_url":"https://api.github.com/users/adamhosier/received_events","type":"User","site_admin":false},{"login":"apuchitnis","id":10189197,"avatar_url":"https://avatars2.githubusercontent.com/u/10189197?v=4","gravatar_id":"","url":"https://api.github.com/users/apuchitnis","html_url":"https://github.com/apuchitnis","followers_url":"https://api.github.com/users/apuchitnis/followers","following_url":"https://api.github.com/users/apuchitnis/following{/other_user}","gists_url":"https://api.github.com/users/apuchitnis/gists{/gist_id}","starred_url":"https://api.github.com/users/apuchitnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apuchitnis/subscriptions","organizations_url":"https://api.github.com/users/apuchitnis/orgs","repos_url":"https://api.github.com/users/apuchitnis/repos","events_url":"https://api.github.com/users/apuchitnis/events{/privacy}","received_events_url":"https://api.github.com/users/apuchitnis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/improbable-eng/kedge/pulls/85/commits","review_comments_url":"https://api.github.com/repos/improbable-eng/kedge/pulls/85/comments","review_comment_url":"https://api.github.com/repos/improbable-eng/kedge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/improbable-eng/kedge/issues/85/comments","statuses_url":"https://api.github.com/repos/improbable-eng/kedge/statuses/650bb76edc8c5fd092073759e6ce045a2dd910a7","head":{"label":"improbable-eng:authority-fix-v2","ref":"authority-fix-v2","sha":"650bb76edc8c5fd092073759e6ce045a2dd910a7","user":{"login":"improbable-eng","id":26084283,"avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"repo":{"id":85936254,"name":"kedge","full_name":"improbable-eng/kedge","owner":{"login":"improbable-eng","id":26084283,"avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-eng/kedge","description":"kEdge - Kubernetes Edge Proxy for gRPC and HTTP Microservices","fork":false,"url":"https://api.github.com/repos/improbable-eng/kedge","forks_url":"https://api.github.com/repos/improbable-eng/kedge/forks","keys_url":"https://api.github.com/repos/improbable-eng/kedge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-eng/kedge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-eng/kedge/teams","hooks_url":"https://api.github.com/repos/improbable-eng/kedge/hooks","issue_events_url":"https://api.github.com/repos/improbable-eng/kedge/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-eng/kedge/events","assignees_url":"https://api.github.com/repos/improbable-eng/kedge/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-eng/kedge/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-eng/kedge/tags","blobs_url":"https://api.github.com/repos/improbable-eng/kedge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-eng/kedge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-eng/kedge/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-eng/kedge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-eng/kedge/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-eng/kedge/languages","stargazers_url":"https://api.github.com/repos/improbable-eng/kedge/stargazers","contributors_url":"https://api.github.com/repos/improbable-eng/kedge/contributors","subscribers_url":"https://api.github.com/repos/improbable-eng/kedge/subscribers","subscription_url":"https://api.github.com/repos/improbable-eng/kedge/subscription","commits_url":"https://api.github.com/repos/improbable-eng/kedge/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-eng/kedge/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-eng/kedge/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-eng/kedge/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-eng/kedge/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-eng/kedge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-eng/kedge/merges","archive_url":"https://api.github.com/repos/improbable-eng/kedge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-eng/kedge/downloads","issues_url":"https://api.github.com/repos/improbable-eng/kedge/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-eng/kedge/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-eng/kedge/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-eng/kedge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-eng/kedge/labels{/name}","releases_url":"https://api.github.com/repos/improbable-eng/kedge/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-eng/kedge/deployments","created_at":"2017-03-23T10:21:29Z","updated_at":"2017-12-16T14:40:51Z","pushed_at":"2017-12-20T14:56:10Z","git_url":"git://github.com/improbable-eng/kedge.git","ssh_url":"git@github.com:improbable-eng/kedge.git","clone_url":"https://github.com/improbable-eng/kedge.git","svn_url":"https://github.com/improbable-eng/kedge","homepage":"","size":4505,"stargazers_count":18,"watchers_count":18,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":6,"watchers":18,"default_branch":"master"}},"base":{"label":"improbable-eng:master","ref":"master","sha":"1efd44ab15088ddcf1776c7dad3451569eb76617","user":{"login":"improbable-eng","id":26084283,"avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"repo":{"id":85936254,"name":"kedge","full_name":"improbable-eng/kedge","owner":{"login":"improbable-eng","id":26084283,"avatar_url":"https://avatars2.githubusercontent.com/u/26084283?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-eng","html_url":"https://github.com/improbable-eng","followers_url":"https://api.github.com/users/improbable-eng/followers","following_url":"https://api.github.com/users/improbable-eng/following{/other_user}","gists_url":"https://api.github.com/users/improbable-eng/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-eng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-eng/subscriptions","organizations_url":"https://api.github.com/users/improbable-eng/orgs","repos_url":"https://api.github.com/users/improbable-eng/repos","events_url":"https://api.github.com/users/improbable-eng/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-eng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-eng/kedge","description":"kEdge - Kubernetes Edge Proxy for gRPC and HTTP Microservices","fork":false,"url":"https://api.github.com/repos/improbable-eng/kedge","forks_url":"https://api.github.com/repos/improbable-eng/kedge/forks","keys_url":"https://api.github.com/repos/improbable-eng/kedge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-eng/kedge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-eng/kedge/teams","hooks_url":"https://api.github.com/repos/improbable-eng/kedge/hooks","issue_events_url":"https://api.github.com/repos/improbable-eng/kedge/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-eng/kedge/events","assignees_url":"https://api.github.com/repos/improbable-eng/kedge/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-eng/kedge/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-eng/kedge/tags","blobs_url":"https://api.github.com/repos/improbable-eng/kedge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-eng/kedge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-eng/kedge/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-eng/kedge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-eng/kedge/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-eng/kedge/languages","stargazers_url":"https://api.github.com/repos/improbable-eng/kedge/stargazers","contributors_url":"https://api.github.com/repos/improbable-eng/kedge/contributors","subscribers_url":"https://api.github.com/repos/improbable-eng/kedge/subscribers","subscription_url":"https://api.github.com/repos/improbable-eng/kedge/subscription","commits_url":"https://api.github.com/repos/improbable-eng/kedge/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-eng/kedge/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-eng/kedge/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-eng/kedge/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-eng/kedge/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-eng/kedge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-eng/kedge/merges","archive_url":"https://api.github.com/repos/improbable-eng/kedge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-eng/kedge/downloads","issues_url":"https://api.github.com/repos/improbable-eng/kedge/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-eng/kedge/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-eng/kedge/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-eng/kedge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-eng/kedge/labels{/name}","releases_url":"https://api.github.com/repos/improbable-eng/kedge/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-eng/kedge/deployments","created_at":"2017-03-23T10:21:29Z","updated_at":"2017-12-16T14:40:51Z","pushed_at":"2017-12-20T14:56:10Z","git_url":"git://github.com/improbable-eng/kedge.git","ssh_url":"git@github.com:improbable-eng/kedge.git","clone_url":"https://github.com/improbable-eng/kedge.git","svn_url":"https://github.com/improbable-eng/kedge","homepage":"","size":4505,"stargazers_count":18,"watchers_count":18,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":6,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/improbable-eng/kedge/pulls/85"},"html":{"href":"https://github.com/improbable-eng/kedge/pull/85"},"issue":{"href":"https://api.github.com/repos/improbable-eng/kedge/issues/85"},"comments":{"href":"https://api.github.com/repos/improbable-eng/kedge/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/improbable-eng/kedge/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/improbable-eng/kedge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/improbable-eng/kedge/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/improbable-eng/kedge/statuses/650bb76edc8c5fd092073759e6ce045a2dd910a7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"stefan-improbable"}}