{"action":"created","issue":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1192","repository_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle","labels_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1192/labels{/name}","comments_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1192/comments","events_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1192/events","html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1192","id":206114945,"number":1192,"title":"Replaced form types for the FQCN's","user":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars.githubusercontent.com/u/1137485?v=3","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"labels":[{"id":369793228,"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/labels/review%20required","name":"review required","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-02-08T07:09:11Z","updated_at":"2017-02-12T09:42:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/pulls/1192","html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1192","diff_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1192.diff","patch_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1192.patch"},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 3.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataMediaBundle/blob/3.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targetting this branch, because this is BC.\r\n\r\n<!--\r\n    Specify which issues will be fixed/closed.\r\n    Remove it if this is not related.\r\n-->\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Changed\r\n- Replaced form types for the FQCN's\r\n```\r\n\r\n## To do\r\n\r\n<!--\r\n    If this is a work in progress, COMPLETE and ADD needed tasks.\r\n    You can add as many tasks as you want.\r\n    If some are not relevant, just REMOVE them.\r\n-->\r\n\r\n- [x] Finish replacements\r\n- [x] Update the tests\r\n\r\n## Subject\r\n\r\n<!-- Describe your Pull Request content here -->\r\n\r\nTrying to make SF3 work with this bundle. I think this is mandatory for SF3, am I wrong? Because I get a lot of deprecations in SF2.8.\r\nIs there a way, or it is implemented in another way in other sonata bundles to avoid all this code?\r\nAlso, do I need to replace DataGridMapper types and ListMapper types?\r\n"},"comment":{"url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/comments/279207183","html_url":"https://github.com/sonata-project/SonataMediaBundle/pull/1192#issuecomment-279207183","issue_url":"https://api.github.com/repos/sonata-project/SonataMediaBundle/issues/1192","id":279207183,"user":{"login":"jordisala1991","id":1137485,"avatar_url":"https://avatars.githubusercontent.com/u/1137485?v=3","gravatar_id":"","url":"https://api.github.com/users/jordisala1991","html_url":"https://github.com/jordisala1991","followers_url":"https://api.github.com/users/jordisala1991/followers","following_url":"https://api.github.com/users/jordisala1991/following{/other_user}","gists_url":"https://api.github.com/users/jordisala1991/gists{/gist_id}","starred_url":"https://api.github.com/users/jordisala1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordisala1991/subscriptions","organizations_url":"https://api.github.com/users/jordisala1991/orgs","repos_url":"https://api.github.com/users/jordisala1991/repos","events_url":"https://api.github.com/users/jordisala1991/events{/privacy}","received_events_url":"https://api.github.com/users/jordisala1991/received_events","type":"User","site_admin":false},"created_at":"2017-02-12T09:42:33Z","updated_at":"2017-02-12T09:42:33Z","body":"Did a little refactor to change:\r\n\r\n`public function setUp()` to `protected function setUp()`"}}
{"actor":{"display_login":"jordisala1991"}}