{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48297","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48297/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48297/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48297/events","html_url":"https://github.com/kubernetes/kubernetes/issues/48297","id":239623423,"number":48297,"title":"Replace usage of deprecated prometheus.Handler","user":{"login":"timstclair","id":3272040,"avatar_url":"https://avatars2.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false},"labels":[{"id":433686790,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/help-wanted","name":"help-wanted","color":"006b75","default":false},{"id":122775691,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":482207917,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/instrumentation","name":"sig/instrumentation","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":{"login":"fraenkel","id":929377,"avatar_url":"https://avatars2.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false},"assignees":[{"login":"fraenkel","id":929377,"avatar_url":"https://avatars2.githubusercontent.com/u/929377?v=3","gravatar_id":"","url":"https://api.github.com/users/fraenkel","html_url":"https://github.com/fraenkel","followers_url":"https://api.github.com/users/fraenkel/followers","following_url":"https://api.github.com/users/fraenkel/following{/other_user}","gists_url":"https://api.github.com/users/fraenkel/gists{/gist_id}","starred_url":"https://api.github.com/users/fraenkel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraenkel/subscriptions","organizations_url":"https://api.github.com/users/fraenkel/orgs","repos_url":"https://api.github.com/users/fraenkel/repos","events_url":"https://api.github.com/users/fraenkel/events{/privacy}","received_events_url":"https://api.github.com/users/fraenkel/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-06-29T22:00:25Z","updated_at":"2017-07-10T23:23:48Z","closed_at":null,"body":"From comment on `prometheus.Handler`:\r\n```\r\n// Deprecated: Please note the issues described in the doc comment of\r\n// InstrumentHandler. You might want to consider using promhttp.Handler instead\r\n// (which is not instrumented, but can be instrumented with the tooling provided\r\n```\r\n\r\nUsage in Kubernetes:\r\n```\r\ncmd/kube-controller-manager/app/controllermanager.go\r\n145:\t\tmux.Handle(\"/metrics\", prometheus.Handler())\r\n\r\ncmd/cloud-controller-manager/app/controllermanager.go\r\n121:\t\tmux.Handle(\"/metrics\", prometheus.Handler())\r\n\r\ncmd/kube-proxy/app/server.go\r\n646:\t\tmux.Handle(\"/metrics\", prometheus.Handler())\r\n\r\nstaging/src/k8s.io/apiserver/pkg/server/routes/metrics.go\r\n35:\tc.Handle(\"/metrics\", prometheus.Handler())\r\n44:\tdefaultMetricsHandler := prometheus.Handler().ServeHTTP\r\n\r\nvendor/github.com/grpc-ecosystem/go-grpc-prometheus/README.md\r\n41:    http.Handle(\"/metrics\", prometheus.Handler())\r\n\r\nvendor/github.com/coreos/etcd/etcdserver/api/v2http/client.go\r\n108:\tmux.Handle(metricsPath, prometheus.Handler())\r\n\r\npkg/kubelet/kuberuntime/instrumented_services_test.go\r\n41:\tmux.Handle(\"/metrics\", prometheus.Handler())\r\n\r\npkg/kubelet/server/server.go\r\n280:\ts.restfulCont.Handle(metricsPath, prometheus.Handler())\r\n\r\nfederation/cmd/federation-controller-manager/app/controllermanager.go\r\n107:\t\tmux.Handle(\"/metrics\", prometheus.Handler())\r\n\r\nplugin/cmd/kube-scheduler/app/server.go\r\n167:\tmux.Handle(\"/metrics\", prometheus.Handler())\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/314277563","html_url":"https://github.com/kubernetes/kubernetes/issues/48297#issuecomment-314277563","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48297","id":314277563,"user":{"login":"tallclair","id":29742491,"avatar_url":"https://avatars2.githubusercontent.com/u/29742491?v=3","gravatar_id":"","url":"https://api.github.com/users/tallclair","html_url":"https://github.com/tallclair","followers_url":"https://api.github.com/users/tallclair/followers","following_url":"https://api.github.com/users/tallclair/following{/other_user}","gists_url":"https://api.github.com/users/tallclair/gists{/gist_id}","starred_url":"https://api.github.com/users/tallclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallclair/subscriptions","organizations_url":"https://api.github.com/users/tallclair/orgs","repos_url":"https://api.github.com/users/tallclair/repos","events_url":"https://api.github.com/users/tallclair/events{/privacy}","received_events_url":"https://api.github.com/users/tallclair/received_events","type":"User","site_admin":false},"created_at":"2017-07-10T23:23:48Z","updated_at":"2017-07-10T23:23:48Z","body":"> Are we ok with the slight changes in metrics that come with moving to promhttp?\r\n\r\nDo you know what kinds of changes we can expect?"}}
{"actor":{"display_login":"tallclair"}}