{"action":"closed","number":57,"pull_request":{"url":"https://api.github.com/repos/invicticide/fractive/pulls/57","id":159983610,"html_url":"https://github.com/invicticide/fractive/pull/57","diff_url":"https://github.com/invicticide/fractive/pull/57.diff","patch_url":"https://github.com/invicticide/fractive/pull/57.patch","issue_url":"https://api.github.com/repos/invicticide/fractive/issues/57","number":57,"state":"closed","locked":false,"title":"No more error behavior when functions don't have a return value","user":{"login":"NQNStudios","id":2584745,"avatar_url":"https://avatars0.githubusercontent.com/u/2584745?v=4","gravatar_id":"","url":"https://api.github.com/users/NQNStudios","html_url":"https://github.com/NQNStudios","followers_url":"https://api.github.com/users/NQNStudios/followers","following_url":"https://api.github.com/users/NQNStudios/following{/other_user}","gists_url":"https://api.github.com/users/NQNStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/NQNStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NQNStudios/subscriptions","organizations_url":"https://api.github.com/users/NQNStudios/orgs","repos_url":"https://api.github.com/users/NQNStudios/repos","events_url":"https://api.github.com/users/NQNStudios/events{/privacy}","received_events_url":"https://api.github.com/users/NQNStudios/received_events","type":"User","site_admin":false},"body":"I was experiencing an extremely difficult bug to find and fix, all because a function in my JavaScript didn't have a return value. I made a 2-line fix to make this a non-issue.\r\n\r\nChanges proposed by this pull request:\r\n- Functions don't need a return statement. Without one, they expand as an empty string.\r\n\r\n@invicticide to review\r\n","created_at":"2017-12-23T23:59:28Z","updated_at":"2017-12-24T01:15:55Z","closed_at":"2017-12-24T01:15:55Z","merged_at":"2017-12-24T01:15:55Z","merge_commit_sha":"eb2655c64e7195330266ee475514ea8955742851","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/invicticide/fractive/pulls/57/commits","review_comments_url":"https://api.github.com/repos/invicticide/fractive/pulls/57/comments","review_comment_url":"https://api.github.com/repos/invicticide/fractive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/invicticide/fractive/issues/57/comments","statuses_url":"https://api.github.com/repos/invicticide/fractive/statuses/eb2655c64e7195330266ee475514ea8955742851","head":{"label":"NQNStudios:function-check","ref":"function-check","sha":"eb2655c64e7195330266ee475514ea8955742851","user":{"login":"NQNStudios","id":2584745,"avatar_url":"https://avatars0.githubusercontent.com/u/2584745?v=4","gravatar_id":"","url":"https://api.github.com/users/NQNStudios","html_url":"https://github.com/NQNStudios","followers_url":"https://api.github.com/users/NQNStudios/followers","following_url":"https://api.github.com/users/NQNStudios/following{/other_user}","gists_url":"https://api.github.com/users/NQNStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/NQNStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NQNStudios/subscriptions","organizations_url":"https://api.github.com/users/NQNStudios/orgs","repos_url":"https://api.github.com/users/NQNStudios/repos","events_url":"https://api.github.com/users/NQNStudios/events{/privacy}","received_events_url":"https://api.github.com/users/NQNStudios/received_events","type":"User","site_admin":false},"repo":{"id":106948980,"name":"SpaceFractive","full_name":"NQNStudios/SpaceFractive","owner":{"login":"NQNStudios","id":2584745,"avatar_url":"https://avatars0.githubusercontent.com/u/2584745?v=4","gravatar_id":"","url":"https://api.github.com/users/NQNStudios","html_url":"https://github.com/NQNStudios","followers_url":"https://api.github.com/users/NQNStudios/followers","following_url":"https://api.github.com/users/NQNStudios/following{/other_user}","gists_url":"https://api.github.com/users/NQNStudios/gists{/gist_id}","starred_url":"https://api.github.com/users/NQNStudios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NQNStudios/subscriptions","organizations_url":"https://api.github.com/users/NQNStudios/orgs","repos_url":"https://api.github.com/users/NQNStudios/repos","events_url":"https://api.github.com/users/NQNStudios/events{/privacy}","received_events_url":"https://api.github.com/users/NQNStudios/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NQNStudios/SpaceFractive","description":"Fractive is a hypertext authoring tool, primarily intended for the creation of interactive fiction.","fork":true,"url":"https://api.github.com/repos/NQNStudios/SpaceFractive","forks_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/forks","keys_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/teams","hooks_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/hooks","issue_events_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/issues/events{/number}","events_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/events","assignees_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/assignees{/user}","branches_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/branches{/branch}","tags_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/tags","blobs_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/git/refs{/sha}","trees_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/statuses/{sha}","languages_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/languages","stargazers_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/stargazers","contributors_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/contributors","subscribers_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/subscribers","subscription_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/subscription","commits_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/commits{/sha}","git_commits_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/git/commits{/sha}","comments_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/comments{/number}","issue_comment_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/issues/comments{/number}","contents_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/contents/{+path}","compare_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/merges","archive_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/downloads","issues_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/issues{/number}","pulls_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/pulls{/number}","milestones_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/milestones{/number}","notifications_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/labels{/name}","releases_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/releases{/id}","deployments_url":"https://api.github.com/repos/NQNStudios/SpaceFractive/deployments","created_at":"2017-10-14T17:38:37Z","updated_at":"2017-12-08T23:59:10Z","pushed_at":"2017-12-23T23:56:53Z","git_url":"git://github.com/NQNStudios/SpaceFractive.git","ssh_url":"git@github.com:NQNStudios/SpaceFractive.git","clone_url":"https://github.com/NQNStudios/SpaceFractive.git","svn_url":"https://github.com/NQNStudios/SpaceFractive","homepage":"","size":733,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":0,"default_branch":"dev"}},"base":{"label":"invicticide:dev","ref":"dev","sha":"024517743fc0dc03689e824bab9b4c3d7fa83f5e","user":{"login":"invicticide","id":5454687,"avatar_url":"https://avatars1.githubusercontent.com/u/5454687?v=4","gravatar_id":"","url":"https://api.github.com/users/invicticide","html_url":"https://github.com/invicticide","followers_url":"https://api.github.com/users/invicticide/followers","following_url":"https://api.github.com/users/invicticide/following{/other_user}","gists_url":"https://api.github.com/users/invicticide/gists{/gist_id}","starred_url":"https://api.github.com/users/invicticide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invicticide/subscriptions","organizations_url":"https://api.github.com/users/invicticide/orgs","repos_url":"https://api.github.com/users/invicticide/repos","events_url":"https://api.github.com/users/invicticide/events{/privacy}","received_events_url":"https://api.github.com/users/invicticide/received_events","type":"User","site_admin":false},"repo":{"id":102974227,"name":"fractive","full_name":"invicticide/fractive","owner":{"login":"invicticide","id":5454687,"avatar_url":"https://avatars1.githubusercontent.com/u/5454687?v=4","gravatar_id":"","url":"https://api.github.com/users/invicticide","html_url":"https://github.com/invicticide","followers_url":"https://api.github.com/users/invicticide/followers","following_url":"https://api.github.com/users/invicticide/following{/other_user}","gists_url":"https://api.github.com/users/invicticide/gists{/gist_id}","starred_url":"https://api.github.com/users/invicticide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invicticide/subscriptions","organizations_url":"https://api.github.com/users/invicticide/orgs","repos_url":"https://api.github.com/users/invicticide/repos","events_url":"https://api.github.com/users/invicticide/events{/privacy}","received_events_url":"https://api.github.com/users/invicticide/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/invicticide/fractive","description":"Fractive is a hypertext authoring tool, primarily intended for the creation of interactive fiction.","fork":false,"url":"https://api.github.com/repos/invicticide/fractive","forks_url":"https://api.github.com/repos/invicticide/fractive/forks","keys_url":"https://api.github.com/repos/invicticide/fractive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/invicticide/fractive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/invicticide/fractive/teams","hooks_url":"https://api.github.com/repos/invicticide/fractive/hooks","issue_events_url":"https://api.github.com/repos/invicticide/fractive/issues/events{/number}","events_url":"https://api.github.com/repos/invicticide/fractive/events","assignees_url":"https://api.github.com/repos/invicticide/fractive/assignees{/user}","branches_url":"https://api.github.com/repos/invicticide/fractive/branches{/branch}","tags_url":"https://api.github.com/repos/invicticide/fractive/tags","blobs_url":"https://api.github.com/repos/invicticide/fractive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/invicticide/fractive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/invicticide/fractive/git/refs{/sha}","trees_url":"https://api.github.com/repos/invicticide/fractive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/invicticide/fractive/statuses/{sha}","languages_url":"https://api.github.com/repos/invicticide/fractive/languages","stargazers_url":"https://api.github.com/repos/invicticide/fractive/stargazers","contributors_url":"https://api.github.com/repos/invicticide/fractive/contributors","subscribers_url":"https://api.github.com/repos/invicticide/fractive/subscribers","subscription_url":"https://api.github.com/repos/invicticide/fractive/subscription","commits_url":"https://api.github.com/repos/invicticide/fractive/commits{/sha}","git_commits_url":"https://api.github.com/repos/invicticide/fractive/git/commits{/sha}","comments_url":"https://api.github.com/repos/invicticide/fractive/comments{/number}","issue_comment_url":"https://api.github.com/repos/invicticide/fractive/issues/comments{/number}","contents_url":"https://api.github.com/repos/invicticide/fractive/contents/{+path}","compare_url":"https://api.github.com/repos/invicticide/fractive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/invicticide/fractive/merges","archive_url":"https://api.github.com/repos/invicticide/fractive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/invicticide/fractive/downloads","issues_url":"https://api.github.com/repos/invicticide/fractive/issues{/number}","pulls_url":"https://api.github.com/repos/invicticide/fractive/pulls{/number}","milestones_url":"https://api.github.com/repos/invicticide/fractive/milestones{/number}","notifications_url":"https://api.github.com/repos/invicticide/fractive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/invicticide/fractive/labels{/name}","releases_url":"https://api.github.com/repos/invicticide/fractive/releases{/id}","deployments_url":"https://api.github.com/repos/invicticide/fractive/deployments","created_at":"2017-09-09T17:52:24Z","updated_at":"2017-12-02T04:37:50Z","pushed_at":"2017-12-24T01:15:55Z","git_url":"git://github.com/invicticide/fractive.git","ssh_url":"git@github.com:invicticide/fractive.git","clone_url":"https://github.com/invicticide/fractive.git","svn_url":"https://github.com/invicticide/fractive","homepage":"","size":600,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1,"open_issues":17,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/invicticide/fractive/pulls/57"},"html":{"href":"https://github.com/invicticide/fractive/pull/57"},"issue":{"href":"https://api.github.com/repos/invicticide/fractive/issues/57"},"comments":{"href":"https://api.github.com/repos/invicticide/fractive/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/invicticide/fractive/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/invicticide/fractive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/invicticide/fractive/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/invicticide/fractive/statuses/eb2655c64e7195330266ee475514ea8955742851"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"invicticide","id":5454687,"avatar_url":"https://avatars1.githubusercontent.com/u/5454687?v=4","gravatar_id":"","url":"https://api.github.com/users/invicticide","html_url":"https://github.com/invicticide","followers_url":"https://api.github.com/users/invicticide/followers","following_url":"https://api.github.com/users/invicticide/following{/other_user}","gists_url":"https://api.github.com/users/invicticide/gists{/gist_id}","starred_url":"https://api.github.com/users/invicticide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/invicticide/subscriptions","organizations_url":"https://api.github.com/users/invicticide/orgs","repos_url":"https://api.github.com/users/invicticide/repos","events_url":"https://api.github.com/users/invicticide/events{/privacy}","received_events_url":"https://api.github.com/users/invicticide/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":13,"changed_files":6}}
{"actor":{"display_login":"invicticide"}}