{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11114","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11114/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11114/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11114/events","html_url":"https://github.com/civicrm/civicrm-core/pull/11114","id":264743576,"number":11114,"title":"CRM-21298 System check: bypass missing indices check until update indices works","user":{"login":"agh1","id":1682375,"avatar_url":"https://avatars0.githubusercontent.com/u/1682375?v=4","gravatar_id":"","url":"https://api.github.com/users/agh1","html_url":"https://github.com/agh1","followers_url":"https://api.github.com/users/agh1/followers","following_url":"https://api.github.com/users/agh1/following{/other_user}","gists_url":"https://api.github.com/users/agh1/gists{/gist_id}","starred_url":"https://api.github.com/users/agh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agh1/subscriptions","organizations_url":"https://api.github.com/users/agh1/orgs","repos_url":"https://api.github.com/users/agh1/repos","events_url":"https://api.github.com/users/agh1/events{/privacy}","received_events_url":"https://api.github.com/users/agh1/received_events","type":"User","site_admin":false},"labels":[{"id":710549998,"url":"https://api.github.com/repos/civicrm/civicrm-core/labels/4.7.26-rc","name":"4.7.26-rc","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-11T21:34:21Z","updated_at":"2017-10-12T12:13:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11114","html_url":"https://github.com/civicrm/civicrm-core/pull/11114","diff_url":"https://github.com/civicrm/civicrm-core/pull/11114.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/11114.patch"},"body":"Overview\r\n----------------------------------------\r\nThe \"Performance warning: Missing indices\" system check should be bypassed until the \"Update Indices\" task works reliably.\r\n\r\n*This is in the RC branch because the Update Indices problem is not resolved in 4.7.26*\r\n\r\nBefore\r\n----------------------------------------\r\nUsers of many sites (including as one example a demo site where 4.7.17 was installed and then upgraded to 4.7.25) are presented with a `WARNING` level message in the system check stating that they have missing indices.  An Update Indices button is in the message.  Clicking the button (for many sites) causes a database error as documented in [CRM-20817](https://issues.civicrm.org/jira/browse/CRM-20817).\r\n\r\nAfter\r\n----------------------------------------\r\nThe system check will never produce the \"Performance warning: Missing indices\" message.\r\n\r\nTechnical Details\r\n----------------------------------------\r\nI left all the code in there to run the check and update the indices.  The `checkIndices()` function just returns an empty array before getting to that point.  This allows for easy removal for testing and when the update tool is actually reliable.\n\n---\n\n * [CRM-21298: Don't offer to fix indices until we can do it right](https://issues.civicrm.org/jira/browse/CRM-21298)"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/336111938","html_url":"https://github.com/civicrm/civicrm-core/pull/11114#issuecomment-336111938","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11114","id":336111938,"user":{"login":"seanmadsen","id":42411,"avatar_url":"https://avatars1.githubusercontent.com/u/42411?v=4","gravatar_id":"","url":"https://api.github.com/users/seanmadsen","html_url":"https://github.com/seanmadsen","followers_url":"https://api.github.com/users/seanmadsen/followers","following_url":"https://api.github.com/users/seanmadsen/following{/other_user}","gists_url":"https://api.github.com/users/seanmadsen/gists{/gist_id}","starred_url":"https://api.github.com/users/seanmadsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanmadsen/subscriptions","organizations_url":"https://api.github.com/users/seanmadsen/orgs","repos_url":"https://api.github.com/users/seanmadsen/repos","events_url":"https://api.github.com/users/seanmadsen/events{/privacy}","received_events_url":"https://api.github.com/users/seanmadsen/received_events","type":"User","site_admin":false},"created_at":"2017-10-12T12:13:20Z","updated_at":"2017-10-12T12:13:20Z","author_association":"MEMBER","body":"Tim asked me to help with this PR by clarifying some of its context. \r\n\r\nFrom what I can tell, this change is bypassing earlier changes made by @jitendrapurohit and merged by @eileenmcnaughton in #10908. Do either of you have thoughts about this PR, especially since it is made against the RC branch and thus requires action more quickly than other PRs?"}}
{"actor":{"display_login":"seanmadsen"}}