{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/comments/157230554","pull_request_review_id":83844100,"id":157230554,"diff_hunk":"@@ -1,51 +1,32 @@\n-.PHONY: all clean install build\n-all: build doc\n+OPAM_PREFIX?=$(DESTDIR)$(shell opam config var prefix)\n+OPAM_LIBDIR?=$(DESTDIR)$(shell opam config var lib)\n \n-J=4\n+.PHONY: release build install uninstall clean test doc reindent\n \n-export OCAMLRUNPARAM=b\n+release:","path":"Makefile","position":10,"original_position":10,"commit_id":"99e05a70f1dc4eda4fdf531fe35557737e481623","original_commit_id":"c4c71cca3131c10fb1f0b7ceac4d72d47e964098","user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"body":"If I use release, we do not need to change the spec file at all","created_at":"2017-12-15T15:42:09Z","updated_at":"2017-12-15T15:42:09Z","html_url":"https://github.com/xapi-project/xcp-rrdd/pull/78#discussion_r157230554","pull_request_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/78","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/comments/157230554"},"html":{"href":"https://github.com/xapi-project/xcp-rrdd/pull/78#discussion_r157230554"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/78"}},"in_reply_to_id":157229571},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/78","id":157846110,"html_url":"https://github.com/xapi-project/xcp-rrdd/pull/78","diff_url":"https://github.com/xapi-project/xcp-rrdd/pull/78.diff","patch_url":"https://github.com/xapi-project/xcp-rrdd/pull/78.patch","issue_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/78","number":78,"state":"open","locked":false,"title":"Port to jbuilder","user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"body":"Includes restructuring stdext and the move from xstringext to astring. Does not require a new spec file","created_at":"2017-12-12T14:43:00Z","updated_at":"2017-12-15T15:42:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07080ecaee091f4291977f0eea47b28b043a8c89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gaborigloi","id":10549240,"avatar_url":"https://avatars3.githubusercontent.com/u/10549240?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborigloi","html_url":"https://github.com/gaborigloi","followers_url":"https://api.github.com/users/gaborigloi/followers","following_url":"https://api.github.com/users/gaborigloi/following{/other_user}","gists_url":"https://api.github.com/users/gaborigloi/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborigloi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborigloi/subscriptions","organizations_url":"https://api.github.com/users/gaborigloi/orgs","repos_url":"https://api.github.com/users/gaborigloi/repos","events_url":"https://api.github.com/users/gaborigloi/events{/privacy}","received_events_url":"https://api.github.com/users/gaborigloi/received_events","type":"User","site_admin":false},{"login":"YarsinCitrix","id":29856854,"avatar_url":"https://avatars2.githubusercontent.com/u/29856854?v=4","gravatar_id":"","url":"https://api.github.com/users/YarsinCitrix","html_url":"https://github.com/YarsinCitrix","followers_url":"https://api.github.com/users/YarsinCitrix/followers","following_url":"https://api.github.com/users/YarsinCitrix/following{/other_user}","gists_url":"https://api.github.com/users/YarsinCitrix/gists{/gist_id}","starred_url":"https://api.github.com/users/YarsinCitrix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YarsinCitrix/subscriptions","organizations_url":"https://api.github.com/users/YarsinCitrix/orgs","repos_url":"https://api.github.com/users/YarsinCitrix/repos","events_url":"https://api.github.com/users/YarsinCitrix/events{/privacy}","received_events_url":"https://api.github.com/users/YarsinCitrix/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/78/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/78/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/78/comments","statuses_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/statuses/99e05a70f1dc4eda4fdf531fe35557737e481623","head":{"label":"mseri:jbuilder","ref":"jbuilder","sha":"99e05a70f1dc4eda4fdf531fe35557737e481623","user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"repo":{"id":72841521,"name":"xcp-rrdd","full_name":"mseri/xcp-rrdd","owner":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mseri/xcp-rrdd","description":"The XCP RRDD daemon","fork":true,"url":"https://api.github.com/repos/mseri/xcp-rrdd","forks_url":"https://api.github.com/repos/mseri/xcp-rrdd/forks","keys_url":"https://api.github.com/repos/mseri/xcp-rrdd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mseri/xcp-rrdd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mseri/xcp-rrdd/teams","hooks_url":"https://api.github.com/repos/mseri/xcp-rrdd/hooks","issue_events_url":"https://api.github.com/repos/mseri/xcp-rrdd/issues/events{/number}","events_url":"https://api.github.com/repos/mseri/xcp-rrdd/events","assignees_url":"https://api.github.com/repos/mseri/xcp-rrdd/assignees{/user}","branches_url":"https://api.github.com/repos/mseri/xcp-rrdd/branches{/branch}","tags_url":"https://api.github.com/repos/mseri/xcp-rrdd/tags","blobs_url":"https://api.github.com/repos/mseri/xcp-rrdd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mseri/xcp-rrdd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mseri/xcp-rrdd/git/refs{/sha}","trees_url":"https://api.github.com/repos/mseri/xcp-rrdd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mseri/xcp-rrdd/statuses/{sha}","languages_url":"https://api.github.com/repos/mseri/xcp-rrdd/languages","stargazers_url":"https://api.github.com/repos/mseri/xcp-rrdd/stargazers","contributors_url":"https://api.github.com/repos/mseri/xcp-rrdd/contributors","subscribers_url":"https://api.github.com/repos/mseri/xcp-rrdd/subscribers","subscription_url":"https://api.github.com/repos/mseri/xcp-rrdd/subscription","commits_url":"https://api.github.com/repos/mseri/xcp-rrdd/commits{/sha}","git_commits_url":"https://api.github.com/repos/mseri/xcp-rrdd/git/commits{/sha}","comments_url":"https://api.github.com/repos/mseri/xcp-rrdd/comments{/number}","issue_comment_url":"https://api.github.com/repos/mseri/xcp-rrdd/issues/comments{/number}","contents_url":"https://api.github.com/repos/mseri/xcp-rrdd/contents/{+path}","compare_url":"https://api.github.com/repos/mseri/xcp-rrdd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mseri/xcp-rrdd/merges","archive_url":"https://api.github.com/repos/mseri/xcp-rrdd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mseri/xcp-rrdd/downloads","issues_url":"https://api.github.com/repos/mseri/xcp-rrdd/issues{/number}","pulls_url":"https://api.github.com/repos/mseri/xcp-rrdd/pulls{/number}","milestones_url":"https://api.github.com/repos/mseri/xcp-rrdd/milestones{/number}","notifications_url":"https://api.github.com/repos/mseri/xcp-rrdd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mseri/xcp-rrdd/labels{/name}","releases_url":"https://api.github.com/repos/mseri/xcp-rrdd/releases{/id}","deployments_url":"https://api.github.com/repos/mseri/xcp-rrdd/deployments","created_at":"2016-11-04T11:24:20Z","updated_at":"2016-11-04T11:24:21Z","pushed_at":"2017-12-15T15:41:31Z","git_url":"git://github.com/mseri/xcp-rrdd.git","ssh_url":"git@github.com:mseri/xcp-rrdd.git","clone_url":"https://github.com/mseri/xcp-rrdd.git","svn_url":"https://github.com/mseri/xcp-rrdd","homepage":null,"size":28733,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"4ba7fe219e61375b2fa5f1d0bc4b50c44309bc99","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":8459591,"name":"xcp-rrdd","full_name":"xapi-project/xcp-rrdd","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xcp-rrdd","description":"The XCP RRDD daemon","fork":false,"url":"https://api.github.com/repos/xapi-project/xcp-rrdd","forks_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/forks","keys_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/teams","hooks_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/events","assignees_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/tags","blobs_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/subscription","commits_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/merges","archive_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/downloads","issues_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xcp-rrdd/deployments","created_at":"2013-02-27T16:02:11Z","updated_at":"2016-02-25T14:31:14Z","pushed_at":"2017-12-15T15:41:32Z","git_url":"git://github.com/xapi-project/xcp-rrdd.git","ssh_url":"git@github.com:xapi-project/xcp-rrdd.git","clone_url":"https://github.com/xapi-project/xcp-rrdd.git","svn_url":"https://github.com/xapi-project/xcp-rrdd","homepage":null,"size":28713,"stargazers_count":2,"watchers_count":2,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":14,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/78"},"html":{"href":"https://github.com/xapi-project/xcp-rrdd/pull/78"},"issue":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/78"},"comments":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xcp-rrdd/statuses/99e05a70f1dc4eda4fdf531fe35557737e481623"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mseri"}}