{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/nvml/issues/1674","repository_url":"https://api.github.com/repos/pmem/nvml","labels_url":"https://api.github.com/repos/pmem/nvml/issues/1674/labels{/name}","comments_url":"https://api.github.com/repos/pmem/nvml/issues/1674/comments","events_url":"https://api.github.com/repos/pmem/nvml/issues/1674/events","html_url":"https://github.com/pmem/nvml/pull/1674","id":207472460,"number":1674,"title":"Unicode","user":{"login":"lplewa","id":19689632,"avatar_url":"https://avatars.githubusercontent.com/u/19689632?v=3","gravatar_id":"","url":"https://api.github.com/users/lplewa","html_url":"https://github.com/lplewa","followers_url":"https://api.github.com/users/lplewa/followers","following_url":"https://api.github.com/users/lplewa/following{/other_user}","gists_url":"https://api.github.com/users/lplewa/gists{/gist_id}","starred_url":"https://api.github.com/users/lplewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lplewa/subscriptions","organizations_url":"https://api.github.com/users/lplewa/orgs","repos_url":"https://api.github.com/users/lplewa/repos","events_url":"https://api.github.com/users/lplewa/events{/privacy}","received_events_url":"https://api.github.com/users/lplewa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2017-02-14T10:15:21Z","updated_at":"2017-02-28T14:52:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pmem/nvml/pulls/1674","html_url":"https://github.com/pmem/nvml/pull/1674","diff_url":"https://github.com/pmem/nvml/pull/1674.diff","patch_url":"https://github.com/pmem/nvml/pull/1674.patch"},"body":"<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/nvml/1674)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/pmem/nvml/issues/comments/283059934","html_url":"https://github.com/pmem/nvml/pull/1674#issuecomment-283059934","issue_url":"https://api.github.com/repos/pmem/nvml/issues/1674","id":283059934,"user":{"login":"lplewa","id":19689632,"avatar_url":"https://avatars.githubusercontent.com/u/19689632?v=3","gravatar_id":"","url":"https://api.github.com/users/lplewa","html_url":"https://github.com/lplewa","followers_url":"https://api.github.com/users/lplewa/followers","following_url":"https://api.github.com/users/lplewa/following{/other_user}","gists_url":"https://api.github.com/users/lplewa/gists{/gist_id}","starred_url":"https://api.github.com/users/lplewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lplewa/subscriptions","organizations_url":"https://api.github.com/users/lplewa/orgs","repos_url":"https://api.github.com/users/lplewa/repos","events_url":"https://api.github.com/users/lplewa/events{/privacy}","received_events_url":"https://api.github.com/users/lplewa/received_events","type":"User","site_admin":false},"created_at":"2017-02-28T14:52:48Z","updated_at":"2017-02-28T14:52:48Z","body":"\n\n\n\nReview status: 360 of 746 files reviewed at latest revision, 62 unresolved discussions, some commit checks failed.\n\n---\n\n*[src/common/file.h, line 91 at r6](https://reviewable.io:443/reviews/pmem/nvml/1674#-Kd_PXIsp0k4vGxGaY_3:-Ke3oadHUSS-PSVwISdH:b-896fix) ([raw file](https://github.com/pmem/nvml/blob/acd0513b5020c777dd888340b8aa2e171fe9c5a0/src/common/file.h#L91)):*\n<details><summary><i>Previously, janekmi (Jan Michalski) wrote…</i></summary><blockquote>\n\nBTW maybe add a comment about this plan to make sure we do not miss it?\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/common/os_windows.c, line 57 at r6](https://reviewable.io:443/reviews/pmem/nvml/1674#-Kd_Ef2b1X4cR6wxUQG0:-Ke3p6OuFlRtpi9d-Jwa:b-896fix) ([raw file](https://github.com/pmem/nvml/blob/acd0513b5020c777dd888340b8aa2e171fe9c5a0/src/common/os_windows.c#L57)):*\n<details><summary><i>Previously, plebioda (Pawel Lebioda) wrote…</i></summary><blockquote>\n\nOk. So the comment is a bit confusing for me..\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/common/os_windows.c, line 40 at r11](https://reviewable.io:443/reviews/pmem/nvml/1674#-Ke38pudGgSYmM_HL3TT:-Ke3okQWPRiNzA1SAyYv:b-896fix) ([raw file](https://github.com/pmem/nvml/blob/c70159047e49bc75b235f0e564beb5a02ae77f52/src/common/os_windows.c#L40)):*\n<details><summary><i>Previously, janekmi (Jan Michalski) wrote…</i></summary><blockquote>\n\nSince it is not magic invisible string anymore it is redundant to write hex in comment.\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/examples/libpmem/full_copy.vcxproj, line 66 at r11](https://reviewable.io:443/reviews/pmem/nvml/1674#-Ke39WwiwqUrixVYpY9x:-Ke3pACthmJAVP8CRwIt:b83igd5) ([raw file](https://github.com/pmem/nvml/blob/c70159047e49bc75b235f0e564beb5a02ae77f52/src/examples/libpmem/full_copy.vcxproj#L66)):*\n<details><summary><i>Previously, janekmi (Jan Michalski) wrote…</i></summary><blockquote>\n\nIt is possible to write this define in one place and inherit definitions from there?\n</blockquote></details>\n\nIt is possible - but we dont want to do this.\n\nin vcxproj there is feature including one project in second one, but it's breaks visual studio to edit project files for visual studio gui (visual studio can broke for project files)\n\nmy previous project was using this feature what caused that any change in project files was task for few weeks)\n\n---\n\n*[src/include/libpmem.h, line 66 at r6](https://reviewable.io:443/reviews/pmem/nvml/1674#-KcwyJBWGFmZ0CDlSzij:-Ke3qFDuvJj8LEJbbWaB:b6nffqw) ([raw file](https://github.com/pmem/nvml/blob/acd0513b5020c777dd888340b8aa2e171fe9c5a0/src/include/libpmem.h#L66)):*\n<details><summary><i>Previously, janekmi (Jan Michalski) wrote…</i></summary><blockquote>\n\nSo we are releasing Windows library without any documentation?\n</blockquote></details>\n\nWe will do this before official windows release \n\n---\n\n*[src/libvmem/vmem.c, line 264 at r6](https://reviewable.io:443/reviews/pmem/nvml/1674#-Kd_zuL-uC27Ui0FMX9C:-Ke49mLxwYg7R8bBH0i2:b-z62qyv) ([raw file](https://github.com/pmem/nvml/blob/acd0513b5020c777dd888340b8aa2e171fe9c5a0/src/libvmem/vmem.c#L264)):*\n<details><summary><i>Previously, plebioda (Pawel Lebioda) wrote…</i></summary><blockquote>\n\nhow about adding this to an abstraction layer and leave this function empty for windows ?\n</blockquote></details>\n\nwe use this function in vmem_create (we can use in in case of in region)\n\n---\n\n*[src/test/out_err_mt_win/out_err_mt_win.c, line 34 at r6](https://reviewable.io:443/reviews/pmem/nvml/1674#-Kcw6frYsFNVf9THl27W-r6-34:-Ke3rGeQYTyqkIbkMJI2:b-m8ursr) ([raw file](https://github.com/pmem/nvml/blob/acd0513b5020c777dd888340b8aa2e171fe9c5a0/src/test/out_err_mt_win/out_err_mt_win.c#L34)):*\n<details><summary><i>Previously, plebioda (Pawel Lebioda) wrote…</i></summary><blockquote>\n\n+1\n</blockquote></details>\n\nNow we can't\n\nwe need different function main different prinfs (%s -> %S) we are calling different functions which require different argument types and returns different values \n\n\nit will require enormous amount of macros to do this \n\n---\n\n*[src/test/unittest/ut.c, line 634 at r6](https://reviewable.io:443/reviews/pmem/nvml/1674#-Kd1CxP9XidMtP2yAWJ2:-Ke3sJDBoDz_zLp0c_ZL:b-896fix) ([raw file](https://github.com/pmem/nvml/blob/acd0513b5020c777dd888340b8aa2e171fe9c5a0/src/test/unittest/ut.c#L634)):*\n<details><summary><i>Previously, janekmi (Jan Michalski) wrote…</i></summary><blockquote>\n\nMissing space after \"(internal)\".\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/test/out_err_mt_win/.gitignore, line 1 at r6](https://reviewable.io:443/reviews/pmem/nvml/1674#-Kd18E35yi_7kam0klmj:-Ke3sfYuTLMbaEnR0Vtg:b-896fix) ([raw file](https://github.com/pmem/nvml/blob/acd0513b5020c777dd888340b8aa2e171fe9c5a0/src/test/out_err_mt_win/.gitignore#L1)):*\n<details><summary><i>Previously, janekmi (Jan Michalski) wrote…</i></summary><blockquote>\n\nRemove file.\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/nvml/1674)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"lplewa"}}