{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/110843545","pull_request_review_id":32043135,"id":110843545,"diff_hunk":"@@ -38,7 +38,9 @@ func IsValidDriver(string, driver string) error {\n }\n \n func RequiresRestartMsg(string, string) error {\n-\tfmt.Fprintln(os.Stdout, \"To apply the changes, you must delete the current VM with `minishift delete` and start a new VM with `minishift start`.\")\n+\tfmt.Fprintln(os.Stdout, \"To apply the changes, \"+\n+\t\t\"you must delete the current VM with `minishift delete` if VM exist \"+","path":"cmd/minishift/cmd/config/validations.go","position":6,"original_position":6,"commit_id":"e381dd77b0bb2c08320a1be94b81c3e170d417ce","original_commit_id":"e381dd77b0bb2c08320a1be94b81c3e170d417ce","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars3.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"I think we can do better than this. We literally should check whether the machine exists. If so we write print:\r\n\r\n\"No Minishift VM defined. Settings will be applied on next 'minishift start'\"\r\n\r\nIf the machine does exist:\r\n\r\n\"Settings are only applied when a new Minishift instance is created. You currently have an existing VM. To apply the changes, you must delete the current VM with `minishift delete` and start a new VM with `minishift start`.\"","created_at":"2017-04-11T08:38:01Z","updated_at":"2017-04-11T08:38:05Z","html_url":"https://github.com/minishift/minishift/pull/731#discussion_r110843545","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/731","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/110843545"},"html":{"href":"https://github.com/minishift/minishift/pull/731#discussion_r110843545"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/731"}}},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/731","id":115259018,"html_url":"https://github.com/minishift/minishift/pull/731","diff_url":"https://github.com/minishift/minishift/pull/731.diff","patch_url":"https://github.com/minishift/minishift/pull/731.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/731","number":731,"state":"open","locked":false,"title":"Issue #708 Rewording around warning message for config set","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars1.githubusercontent.com/u/410007?v=3","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"body":"This patch is only for rewording around config set method.","created_at":"2017-04-11T07:42:27Z","updated_at":"2017-04-11T08:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bced6fa0b77b4658df434623142d85d108468438","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/731/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/731/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/731/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/e381dd77b0bb2c08320a1be94b81c3e170d417ce","head":{"label":"praveenkumar:issue_708","ref":"issue_708","sha":"e381dd77b0bb2c08320a1be94b81c3e170d417ce","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars1.githubusercontent.com/u/410007?v=3","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"repo":{"id":74443040,"name":"minishift","full_name":"praveenkumar/minishift","owner":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars1.githubusercontent.com/u/410007?v=3","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/praveenkumar/minishift","description":null,"fork":true,"url":"https://api.github.com/repos/praveenkumar/minishift","forks_url":"https://api.github.com/repos/praveenkumar/minishift/forks","keys_url":"https://api.github.com/repos/praveenkumar/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praveenkumar/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praveenkumar/minishift/teams","hooks_url":"https://api.github.com/repos/praveenkumar/minishift/hooks","issue_events_url":"https://api.github.com/repos/praveenkumar/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/praveenkumar/minishift/events","assignees_url":"https://api.github.com/repos/praveenkumar/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/praveenkumar/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/praveenkumar/minishift/tags","blobs_url":"https://api.github.com/repos/praveenkumar/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praveenkumar/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praveenkumar/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/praveenkumar/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praveenkumar/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/praveenkumar/minishift/languages","stargazers_url":"https://api.github.com/repos/praveenkumar/minishift/stargazers","contributors_url":"https://api.github.com/repos/praveenkumar/minishift/contributors","subscribers_url":"https://api.github.com/repos/praveenkumar/minishift/subscribers","subscription_url":"https://api.github.com/repos/praveenkumar/minishift/subscription","commits_url":"https://api.github.com/repos/praveenkumar/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/praveenkumar/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/praveenkumar/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/praveenkumar/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/praveenkumar/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/praveenkumar/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praveenkumar/minishift/merges","archive_url":"https://api.github.com/repos/praveenkumar/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praveenkumar/minishift/downloads","issues_url":"https://api.github.com/repos/praveenkumar/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/praveenkumar/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/praveenkumar/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/praveenkumar/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praveenkumar/minishift/labels{/name}","releases_url":"https://api.github.com/repos/praveenkumar/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/praveenkumar/minishift/deployments","created_at":"2016-11-22T06:46:12Z","updated_at":"2016-11-22T06:46:15Z","pushed_at":"2017-04-11T07:44:38Z","git_url":"git://github.com/praveenkumar/minishift.git","ssh_url":"git@github.com:praveenkumar/minishift.git","clone_url":"https://github.com/praveenkumar/minishift.git","svn_url":"https://github.com/praveenkumar/minishift","homepage":null,"size":156520,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"710e1bf55ef8c4fac06b8bc886f0426979b0bc0b","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars2.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars2.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-04-10T17:34:36Z","pushed_at":"2017-04-11T07:44:40Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":156482,"stargazers_count":353,"watchers_count":353,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":86,"mirror_url":null,"open_issues_count":179,"forks":86,"open_issues":179,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/731"},"html":{"href":"https://github.com/minishift/minishift/pull/731"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/731"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/731/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/731/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/731/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/e381dd77b0bb2c08320a1be94b81c3e170d417ce"}}}}
{"actor":{"display_login":"hferentschik"}}