{"action":"created","comment":{"url":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/comments/154751155","pull_request_review_id":80960692,"id":154751155,"diff_hunk":"@@ -0,0 +1,51 @@\n+#!/bin/bash\n+#\n+# Copyright 2017-present The Material Motion Authors. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+# Migration script from v1 to v2 interchange APIs.\n+\n+if [ \"$#\" -ne 1 ]; then\n+  echo \"Usage: $(basename $0) <path>\"\n+  exit 1\n+fi\n+\n+search_path=\"$1\"\n+\n+replace_objc() {\n+  find \"$search_path\" -type f -name \"*.h\" | xargs sed -i '' \"$1\"\n+  find \"$search_path\" -type f -name \"*.m\" | xargs sed -i '' \"$1\"\n+}\n+\n+replace_swift() {\n+  find \"$search_path\" -type f -name \"*.swift\" | xargs sed -i '' \"$1\"\n+}\n+\n+replace_all() {\n+  replace_objc $1\n+  replace_swift $1\n+}\n+\n+# replace_all \"s/MotionCurveMakeSpring(mass/TimingCurve(springWithMass/g\"","path":"scripts/v1_to_v2.sh","position":null,"original_position":40,"commit_id":"c4a4cc2b54d834e9f86c438996bd00297713808f","original_commit_id":"a400a253b8c13717384f6d588cf1572323a6ac7b","user":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-12-04T19:30:26Z","updated_at":"2017-12-04T19:30:26Z","html_url":"https://github.com/material-motion/motion-interchange-objc/pull/22#discussion_r154751155","pull_request_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/22","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/comments/154751155"},"html":{"href":"https://github.com/material-motion/motion-interchange-objc/pull/22#discussion_r154751155"},"pull_request":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/22"}},"in_reply_to_id":154734629},"pull_request":{"url":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/22","id":155955403,"html_url":"https://github.com/material-motion/motion-interchange-objc/pull/22","diff_url":"https://github.com/material-motion/motion-interchange-objc/pull/22.diff","patch_url":"https://github.com/material-motion/motion-interchange-objc/pull/22.patch","issue_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues/22","number":22,"state":"open","locked":false,"title":"Implement v2 APIs","user":{"login":"jverkoey","id":45670,"avatar_url":"https://avatars0.githubusercontent.com/u/45670?v=4","gravatar_id":"","url":"https://api.github.com/users/jverkoey","html_url":"https://github.com/jverkoey","followers_url":"https://api.github.com/users/jverkoey/followers","following_url":"https://api.github.com/users/jverkoey/following{/other_user}","gists_url":"https://api.github.com/users/jverkoey/gists{/gist_id}","starred_url":"https://api.github.com/users/jverkoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jverkoey/subscriptions","organizations_url":"https://api.github.com/users/jverkoey/orgs","repos_url":"https://api.github.com/users/jverkoey/repos","events_url":"https://api.github.com/users/jverkoey/events{/privacy}","received_events_url":"https://api.github.com/users/jverkoey/received_events","type":"User","site_admin":false},"body":"In short: this PR drops the redundant \"motion\" prefix on various types and aligns naming with system terminology where possible and re-implements the APIs as Objective-C APIs, closing #5.\r\n\r\n| Old API | New API | Rationale |\r\n|:------- |:-------- |:-----------|\r\n| MotionTiming | AnimationTraits | This structure is intended to describe animations only, not motion in general. |\r\n| MotionCurve | TimingCurve | This brings the API name closer to the similarly-purposed `CAMediaTimingFunction`. MotionCurve could also be easily confused with motion through x/y space rather than through time (e.g. ArcMove), which will be problematic as we start defining paths of motion through space. |\r\n| MotionRepetition | RepetitionTraits | This aligns the naming with AnimationTraits. |\r\n\r\nAll prior APIs have been deleted, including the macro-based APIs and any active deprecations. This is a major change and will bump the release to v2.\r\n\r\nA migration script has been included to ease migration of existing code.","created_at":"2017-12-01T20:55:03Z","updated_at":"2017-12-04T19:30:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53057db49cce94500b5f34b8e4ff513aaefb7b7d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"samnm","id":1251373,"avatar_url":"https://avatars2.githubusercontent.com/u/1251373?v=4","gravatar_id":"","url":"https://api.github.com/users/samnm","html_url":"https://github.com/samnm","followers_url":"https://api.github.com/users/samnm/followers","following_url":"https://api.github.com/users/samnm/following{/other_user}","gists_url":"https://api.github.com/users/samnm/gists{/gist_id}","starred_url":"https://api.github.com/users/samnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samnm/subscriptions","organizations_url":"https://api.github.com/users/samnm/orgs","repos_url":"https://api.github.com/users/samnm/repos","events_url":"https://api.github.com/users/samnm/events{/privacy}","received_events_url":"https://api.github.com/users/samnm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/22/commits","review_comments_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/22/comments","review_comment_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues/22/comments","statuses_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/statuses/c4a4cc2b54d834e9f86c438996bd00297713808f","head":{"label":"material-motion:v2","ref":"v2","sha":"c4a4cc2b54d834e9f86c438996bd00297713808f","user":{"login":"material-motion","id":11580480,"avatar_url":"https://avatars1.githubusercontent.com/u/11580480?v=4","gravatar_id":"","url":"https://api.github.com/users/material-motion","html_url":"https://github.com/material-motion","followers_url":"https://api.github.com/users/material-motion/followers","following_url":"https://api.github.com/users/material-motion/following{/other_user}","gists_url":"https://api.github.com/users/material-motion/gists{/gist_id}","starred_url":"https://api.github.com/users/material-motion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-motion/subscriptions","organizations_url":"https://api.github.com/users/material-motion/orgs","repos_url":"https://api.github.com/users/material-motion/repos","events_url":"https://api.github.com/users/material-motion/events{/privacy}","received_events_url":"https://api.github.com/users/material-motion/received_events","type":"Organization","site_admin":false},"repo":{"id":92880742,"name":"motion-interchange-objc","full_name":"material-motion/motion-interchange-objc","owner":{"login":"material-motion","id":11580480,"avatar_url":"https://avatars1.githubusercontent.com/u/11580480?v=4","gravatar_id":"","url":"https://api.github.com/users/material-motion","html_url":"https://github.com/material-motion","followers_url":"https://api.github.com/users/material-motion/followers","following_url":"https://api.github.com/users/material-motion/following{/other_user}","gists_url":"https://api.github.com/users/material-motion/gists{/gist_id}","starred_url":"https://api.github.com/users/material-motion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-motion/subscriptions","organizations_url":"https://api.github.com/users/material-motion/orgs","repos_url":"https://api.github.com/users/material-motion/repos","events_url":"https://api.github.com/users/material-motion/events{/privacy}","received_events_url":"https://api.github.com/users/material-motion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-motion/motion-interchange-objc","description":"A standard format for representing motion specifications in Objective-C and Swift.","fork":false,"url":"https://api.github.com/repos/material-motion/motion-interchange-objc","forks_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/forks","keys_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/teams","hooks_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/hooks","issue_events_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues/events{/number}","events_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/events","assignees_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/assignees{/user}","branches_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/branches{/branch}","tags_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/tags","blobs_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/languages","stargazers_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/stargazers","contributors_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/contributors","subscribers_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/subscribers","subscription_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/subscription","commits_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/contents/{+path}","compare_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/merges","archive_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/downloads","issues_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues{/number}","pulls_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/labels{/name}","releases_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/releases{/id}","deployments_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/deployments","created_at":"2017-05-30T22:13:44Z","updated_at":"2017-06-06T22:21:55Z","pushed_at":"2017-12-04T19:30:20Z","git_url":"git://github.com/material-motion/motion-interchange-objc.git","ssh_url":"git@github.com:material-motion/motion-interchange-objc.git","clone_url":"https://github.com/material-motion/motion-interchange-objc.git","svn_url":"https://github.com/material-motion/motion-interchange-objc","homepage":"","size":115,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":5,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-motion:develop","ref":"develop","sha":"866ec18cf2353c2682f89d1350af57c05ce25839","user":{"login":"material-motion","id":11580480,"avatar_url":"https://avatars1.githubusercontent.com/u/11580480?v=4","gravatar_id":"","url":"https://api.github.com/users/material-motion","html_url":"https://github.com/material-motion","followers_url":"https://api.github.com/users/material-motion/followers","following_url":"https://api.github.com/users/material-motion/following{/other_user}","gists_url":"https://api.github.com/users/material-motion/gists{/gist_id}","starred_url":"https://api.github.com/users/material-motion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-motion/subscriptions","organizations_url":"https://api.github.com/users/material-motion/orgs","repos_url":"https://api.github.com/users/material-motion/repos","events_url":"https://api.github.com/users/material-motion/events{/privacy}","received_events_url":"https://api.github.com/users/material-motion/received_events","type":"Organization","site_admin":false},"repo":{"id":92880742,"name":"motion-interchange-objc","full_name":"material-motion/motion-interchange-objc","owner":{"login":"material-motion","id":11580480,"avatar_url":"https://avatars1.githubusercontent.com/u/11580480?v=4","gravatar_id":"","url":"https://api.github.com/users/material-motion","html_url":"https://github.com/material-motion","followers_url":"https://api.github.com/users/material-motion/followers","following_url":"https://api.github.com/users/material-motion/following{/other_user}","gists_url":"https://api.github.com/users/material-motion/gists{/gist_id}","starred_url":"https://api.github.com/users/material-motion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-motion/subscriptions","organizations_url":"https://api.github.com/users/material-motion/orgs","repos_url":"https://api.github.com/users/material-motion/repos","events_url":"https://api.github.com/users/material-motion/events{/privacy}","received_events_url":"https://api.github.com/users/material-motion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-motion/motion-interchange-objc","description":"A standard format for representing motion specifications in Objective-C and Swift.","fork":false,"url":"https://api.github.com/repos/material-motion/motion-interchange-objc","forks_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/forks","keys_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/teams","hooks_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/hooks","issue_events_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues/events{/number}","events_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/events","assignees_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/assignees{/user}","branches_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/branches{/branch}","tags_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/tags","blobs_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/languages","stargazers_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/stargazers","contributors_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/contributors","subscribers_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/subscribers","subscription_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/subscription","commits_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/contents/{+path}","compare_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/merges","archive_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/downloads","issues_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues{/number}","pulls_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/labels{/name}","releases_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/releases{/id}","deployments_url":"https://api.github.com/repos/material-motion/motion-interchange-objc/deployments","created_at":"2017-05-30T22:13:44Z","updated_at":"2017-06-06T22:21:55Z","pushed_at":"2017-12-04T19:30:20Z","git_url":"git://github.com/material-motion/motion-interchange-objc.git","ssh_url":"git@github.com:material-motion/motion-interchange-objc.git","clone_url":"https://github.com/material-motion/motion-interchange-objc.git","svn_url":"https://github.com/material-motion/motion-interchange-objc","homepage":"","size":115,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":5,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/22"},"html":{"href":"https://github.com/material-motion/motion-interchange-objc/pull/22"},"issue":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues/22"},"comments":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/material-motion/motion-interchange-objc/statuses/c4a4cc2b54d834e9f86c438996bd00297713808f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jverkoey"}}