{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/118135176","pull_request_review_id":39897169,"id":118135176,"diff_hunk":"@@ -83,27 +157,54 @@ class FileSnapshotMetadataModel(base_models.BaseSnapshotMetadataModel):\n \n \n class FileSnapshotContentModel(base_models.BaseSnapshotContentModel):\n-    \"\"\"Class for storing the content of the file snapshots.\"\"\"\n+    \"\"\"Class for storing the content of the file snapshots.\n+\n+    Attributes:\n+        content: BlobProperty. The contents of a file snapshot.\n+    \"\"\"\n \n     # Overwrite the superclass member to use a BlobProperty for raw strings.\n     content = ndb.BlobProperty(indexed=False)\n \n \n class FileModel(base_models.VersionedModel):\n-    \"\"\"File data model, keyed by exploration id and absolute file name.\"\"\"\n+    \"\"\"File data model, keyed by exploration id and absolute file name.\n+\n+    Attributes:\n+        SNAPSHOT_METADATA_CLASS: FileSnapshotMetadataModel. The class which\n+            stores the commit history of the file snapshots.\n+        SNAPSHOT_CONTENT_CLASS: FileSnapshotContentModel. The class which\n+            stores the content of the file snapshots.\n+        content: BlobProperty. The contents of the file.","path":"core/storage/file/gae_models.py","position":140,"original_position":140,"commit_id":"f18c5369c535a289979f71f9e68d7ebc931d8d5e","original_commit_id":"f18c5369c535a289979f71f9e68d7ebc931d8d5e","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars3.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"body":"Can drop this -- see above.","created_at":"2017-05-24T00:12:48Z","updated_at":"2017-05-24T00:17:18Z","html_url":"https://github.com/oppia/oppia/pull/3457#discussion_r118135176","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/3457","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/118135176"},"html":{"href":"https://github.com/oppia/oppia/pull/3457#discussion_r118135176"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3457"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/3457","id":121876556,"html_url":"https://github.com/oppia/oppia/pull/3457","diff_url":"https://github.com/oppia/oppia/pull/3457.diff","patch_url":"https://github.com/oppia/oppia/pull/3457.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/3457","number":3457,"state":"open","locked":false,"title":"Fix #2394: Add docstrings to core/storage/file/gae_models.py","user":{"login":"Ian91","id":16965009,"avatar_url":"https://avatars2.githubusercontent.com/u/16965009?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian91","html_url":"https://github.com/Ian91","followers_url":"https://api.github.com/users/Ian91/followers","following_url":"https://api.github.com/users/Ian91/following{/other_user}","gists_url":"https://api.github.com/users/Ian91/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian91/subscriptions","organizations_url":"https://api.github.com/users/Ian91/orgs","repos_url":"https://api.github.com/users/Ian91/repos","events_url":"https://api.github.com/users/Ian91/events{/privacy}","received_events_url":"https://api.github.com/users/Ian91/received_events","type":"User","site_admin":false},"body":"   * Do the \"not implemented\" methods FileMetadataModel.get_new_id() and FileModel.get_new_id()   need any documentation?\r\n\r\n   * I removed the returning of a None object from the methods FileMetadataModel.commit() and FileModel.commit(), but kept the calls that produced the None objects. It seems that the return statements were mistakes or obsolete.\r\n\r\n   * The term \"overwrite\" was present in some existing documentation, so I left it in there, but I thought it should have been \"override\".","created_at":"2017-05-22T22:15:35Z","updated_at":"2017-05-24T00:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"148e6d64a9368add9d47fccd1a74682357f2b01b","assignee":{"login":"Ian91","id":16965009,"avatar_url":"https://avatars2.githubusercontent.com/u/16965009?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian91","html_url":"https://github.com/Ian91","followers_url":"https://api.github.com/users/Ian91/followers","following_url":"https://api.github.com/users/Ian91/following{/other_user}","gists_url":"https://api.github.com/users/Ian91/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian91/subscriptions","organizations_url":"https://api.github.com/users/Ian91/orgs","repos_url":"https://api.github.com/users/Ian91/repos","events_url":"https://api.github.com/users/Ian91/events{/privacy}","received_events_url":"https://api.github.com/users/Ian91/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ian91","id":16965009,"avatar_url":"https://avatars2.githubusercontent.com/u/16965009?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian91","html_url":"https://github.com/Ian91","followers_url":"https://api.github.com/users/Ian91/followers","following_url":"https://api.github.com/users/Ian91/following{/other_user}","gists_url":"https://api.github.com/users/Ian91/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian91/subscriptions","organizations_url":"https://api.github.com/users/Ian91/orgs","repos_url":"https://api.github.com/users/Ian91/repos","events_url":"https://api.github.com/users/Ian91/events{/privacy}","received_events_url":"https://api.github.com/users/Ian91/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/3457/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/3457/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/3457/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/f18c5369c535a289979f71f9e68d7ebc931d8d5e","head":{"label":"Ian91:docstrings-storage-models","ref":"docstrings-storage-models","sha":"f18c5369c535a289979f71f9e68d7ebc931d8d5e","user":{"login":"Ian91","id":16965009,"avatar_url":"https://avatars2.githubusercontent.com/u/16965009?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian91","html_url":"https://github.com/Ian91","followers_url":"https://api.github.com/users/Ian91/followers","following_url":"https://api.github.com/users/Ian91/following{/other_user}","gists_url":"https://api.github.com/users/Ian91/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian91/subscriptions","organizations_url":"https://api.github.com/users/Ian91/orgs","repos_url":"https://api.github.com/users/Ian91/repos","events_url":"https://api.github.com/users/Ian91/events{/privacy}","received_events_url":"https://api.github.com/users/Ian91/received_events","type":"User","site_admin":false},"repo":{"id":92097306,"name":"oppia","full_name":"Ian91/oppia","owner":{"login":"Ian91","id":16965009,"avatar_url":"https://avatars2.githubusercontent.com/u/16965009?v=3","gravatar_id":"","url":"https://api.github.com/users/Ian91","html_url":"https://github.com/Ian91","followers_url":"https://api.github.com/users/Ian91/followers","following_url":"https://api.github.com/users/Ian91/following{/other_user}","gists_url":"https://api.github.com/users/Ian91/gists{/gist_id}","starred_url":"https://api.github.com/users/Ian91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ian91/subscriptions","organizations_url":"https://api.github.com/users/Ian91/orgs","repos_url":"https://api.github.com/users/Ian91/repos","events_url":"https://api.github.com/users/Ian91/events{/privacy}","received_events_url":"https://api.github.com/users/Ian91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ian91/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/Ian91/oppia","forks_url":"https://api.github.com/repos/Ian91/oppia/forks","keys_url":"https://api.github.com/repos/Ian91/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ian91/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ian91/oppia/teams","hooks_url":"https://api.github.com/repos/Ian91/oppia/hooks","issue_events_url":"https://api.github.com/repos/Ian91/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/Ian91/oppia/events","assignees_url":"https://api.github.com/repos/Ian91/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/Ian91/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/Ian91/oppia/tags","blobs_url":"https://api.github.com/repos/Ian91/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ian91/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ian91/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ian91/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ian91/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/Ian91/oppia/languages","stargazers_url":"https://api.github.com/repos/Ian91/oppia/stargazers","contributors_url":"https://api.github.com/repos/Ian91/oppia/contributors","subscribers_url":"https://api.github.com/repos/Ian91/oppia/subscribers","subscription_url":"https://api.github.com/repos/Ian91/oppia/subscription","commits_url":"https://api.github.com/repos/Ian91/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ian91/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ian91/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ian91/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ian91/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/Ian91/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ian91/oppia/merges","archive_url":"https://api.github.com/repos/Ian91/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ian91/oppia/downloads","issues_url":"https://api.github.com/repos/Ian91/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/Ian91/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/Ian91/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/Ian91/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ian91/oppia/labels{/name}","releases_url":"https://api.github.com/repos/Ian91/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/Ian91/oppia/deployments","created_at":"2017-05-22T20:38:17Z","updated_at":"2017-05-22T20:38:22Z","pushed_at":"2017-05-22T22:04:38Z","git_url":"git://github.com/Ian91/oppia.git","ssh_url":"git@github.com:Ian91/oppia.git","clone_url":"https://github.com/Ian91/oppia.git","svn_url":"https://github.com/Ian91/oppia","homepage":"https://www.oppia.org","size":51707,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"93e5639a5ba5c514f41c9c94456a7dab12af00d3","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars2.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars2.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2017-05-21T08:51:45Z","pushed_at":"2017-05-23T21:26:08Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":51711,"stargazers_count":309,"watchers_count":309,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":430,"mirror_url":null,"open_issues_count":356,"forks":430,"open_issues":356,"watchers":309,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3457"},"html":{"href":"https://github.com/oppia/oppia/pull/3457"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/3457"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/3457/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3457/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3457/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/f18c5369c535a289979f71f9e68d7ebc931d8d5e"}}}}
{"actor":{"display_login":"seanlip"}}