{"action":"created","issue":{"url":"https://api.github.com/repos/xunit/xunit/issues/1520","repository_url":"https://api.github.com/repos/xunit/xunit","labels_url":"https://api.github.com/repos/xunit/xunit/issues/1520/labels{/name}","comments_url":"https://api.github.com/repos/xunit/xunit/issues/1520/comments","events_url":"https://api.github.com/repos/xunit/xunit/issues/1520/events","html_url":"https://github.com/xunit/xunit/issues/1520","id":266048750,"number":1520,"title":"Dotnet Pack requires IsPackable setting in the csproj for class libraries with a reference to Xunit","user":{"login":"djowatts","id":2462078,"avatar_url":"https://avatars2.githubusercontent.com/u/2462078?v=4","gravatar_id":"","url":"https://api.github.com/users/djowatts","html_url":"https://github.com/djowatts","followers_url":"https://api.github.com/users/djowatts/followers","following_url":"https://api.github.com/users/djowatts/following{/other_user}","gists_url":"https://api.github.com/users/djowatts/gists{/gist_id}","starred_url":"https://api.github.com/users/djowatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djowatts/subscriptions","organizations_url":"https://api.github.com/users/djowatts/orgs","repos_url":"https://api.github.com/users/djowatts/repos","events_url":"https://api.github.com/users/djowatts/events{/privacy}","received_events_url":"https://api.github.com/users/djowatts/received_events","type":"User","site_admin":false},"labels":[{"id":713233349,"url":"https://api.github.com/repos/xunit/xunit/labels/[r]%20By%20Design","name":"[r] By Design","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-17T09:12:57Z","updated_at":"2017-10-19T01:02:50Z","closed_at":null,"author_association":"NONE","body":"Hello, \r\n\r\nWhen trying to get a class library built in .Net core with xUnit referenced, the `dotnet pack` command does not produce a nuget package unless you add the `IsPackable` setting into your csproj file. \r\n\r\n[Here is an issue within the dotnet CLI project](https://github.com/dotnet/cli/issues/7539) that references the issue on web projects. \r\n\r\nTo replicate, create a dotnet core class library and reference xUnit, then attempt to run dotnet pack from the command line.\r\n"},"comment":{"url":"https://api.github.com/repos/xunit/xunit/issues/comments/337769772","html_url":"https://github.com/xunit/xunit/issues/1520#issuecomment-337769772","issue_url":"https://api.github.com/repos/xunit/xunit/issues/1520","id":337769772,"user":{"login":"bradwilson","id":16944,"avatar_url":"https://avatars3.githubusercontent.com/u/16944?v=4","gravatar_id":"","url":"https://api.github.com/users/bradwilson","html_url":"https://github.com/bradwilson","followers_url":"https://api.github.com/users/bradwilson/followers","following_url":"https://api.github.com/users/bradwilson/following{/other_user}","gists_url":"https://api.github.com/users/bradwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/bradwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradwilson/subscriptions","organizations_url":"https://api.github.com/users/bradwilson/orgs","repos_url":"https://api.github.com/users/bradwilson/repos","events_url":"https://api.github.com/users/bradwilson/events{/privacy}","received_events_url":"https://api.github.com/users/bradwilson/received_events","type":"User","site_admin":false},"created_at":"2017-10-19T01:02:50Z","updated_at":"2017-10-19T01:02:50Z","author_association":"OWNER","body":"As I understand it, this advice for non-packability comes from the .NET SDK team to the VSTest team, to make test projects not packable by default. This is called out in our [release notes for 2.3](https://xunit.github.io/releases/2.3):\r\n\r\n> As a reminder: If you're extending xUnit.net and want to publish your extension as a NuGet package, you should import `xunit.extensibility.core` and/or `xunit.extensibility.execution`, not `xunit` or `xunit.core`. If you do this wrong, you might have problems generating your NuGet package via `dotnet pack`."}}
{"actor":{"display_login":"bradwilson"}}