{"action":"created","issue":{"url":"https://api.github.com/repos/dgoodwin/tito/issues/283","repository_url":"https://api.github.com/repos/dgoodwin/tito","labels_url":"https://api.github.com/repos/dgoodwin/tito/issues/283/labels{/name}","comments_url":"https://api.github.com/repos/dgoodwin/tito/issues/283/comments","events_url":"https://api.github.com/repos/dgoodwin/tito/issues/283/events","html_url":"https://github.com/dgoodwin/tito/pull/283","id":229629964,"number":283,"title":"force VersionTagger when tito tag is called with --use-version","user":{"login":"evgeni","id":94284,"avatar_url":"https://avatars0.githubusercontent.com/u/94284?v=3","gravatar_id":"","url":"https://api.github.com/users/evgeni","html_url":"https://github.com/evgeni","followers_url":"https://api.github.com/users/evgeni/followers","following_url":"https://api.github.com/users/evgeni/following{/other_user}","gists_url":"https://api.github.com/users/evgeni/gists{/gist_id}","starred_url":"https://api.github.com/users/evgeni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgeni/subscriptions","organizations_url":"https://api.github.com/users/evgeni/orgs","repos_url":"https://api.github.com/users/evgeni/repos","events_url":"https://api.github.com/users/evgeni/events{/privacy}","received_events_url":"https://api.github.com/users/evgeni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-05-18T10:52:50Z","updated_at":"2017-05-18T15:35:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dgoodwin/tito/pulls/283","html_url":"https://github.com/dgoodwin/tito/pull/283","diff_url":"https://github.com/dgoodwin/tito/pull/283.diff","patch_url":"https://github.com/dgoodwin/tito/pull/283.patch"},"body":"In 6b57b0b, the code that checked wither we used `--use-version` was removed, because both `VersionTagger` and `ForceVersionTagger` are identical now. However, this breaks setups where the default tagger is `ReleaseTagger` but the user still wants to use `--use-version` sometimes.\r\n\r\nThus let's force `VersionTagger` when `--use-version` was given and only use whatever is in `tito.props` when it was not.\r\n\r\nFixes: #274\r\n\r\nSigned-off-by: Evgeni Golov <egolov@redhat.com>"},"comment":{"url":"https://api.github.com/repos/dgoodwin/tito/issues/comments/302442591","html_url":"https://github.com/dgoodwin/tito/pull/283#issuecomment-302442591","issue_url":"https://api.github.com/repos/dgoodwin/tito/issues/283","id":302442591,"user":{"login":"dgoodwin","id":51265,"avatar_url":"https://avatars0.githubusercontent.com/u/51265?v=3","gravatar_id":"","url":"https://api.github.com/users/dgoodwin","html_url":"https://github.com/dgoodwin","followers_url":"https://api.github.com/users/dgoodwin/followers","following_url":"https://api.github.com/users/dgoodwin/following{/other_user}","gists_url":"https://api.github.com/users/dgoodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dgoodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgoodwin/subscriptions","organizations_url":"https://api.github.com/users/dgoodwin/orgs","repos_url":"https://api.github.com/users/dgoodwin/repos","events_url":"https://api.github.com/users/dgoodwin/events{/privacy}","received_events_url":"https://api.github.com/users/dgoodwin/received_events","type":"User","site_admin":false},"created_at":"2017-05-18T15:35:55Z","updated_at":"2017-05-18T15:35:55Z","body":"I'm a bit nervous about switching out the tagger too (even though that's what we always did). Also in the common ReleaseTagger use case you most likely want to version tag and reset release to 1, which is exactly what VersionTagger does. However it still feels wrong to bypass your custom tagger.\r\n\r\nTaggers explicitly supporting manually specifying version (and perhaps a --use-release someday) seems like it is required, and if they don't we would error out. In this case we'd need to modify ReleaseTagger to be able to swap in the new version. \r\n\r\nWhat do you think @evgeni, and would you be up to implement this?\r\n\r\nWe also should get a unit test on this situation."}}
{"actor":{"display_login":"dgoodwin"}}