{"action":"created","issue":{"url":"https://api.github.com/repos/piratar/wasa2il/issues/154","repository_url":"https://api.github.com/repos/piratar/wasa2il","labels_url":"https://api.github.com/repos/piratar/wasa2il/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/piratar/wasa2il/issues/154/comments","events_url":"https://api.github.com/repos/piratar/wasa2il/issues/154/events","html_url":"https://github.com/piratar/wasa2il/issues/154","id":235033591,"number":154,"title":"Clean up requirements.txt","user":{"login":"7oi","id":2581375,"avatar_url":"https://avatars2.githubusercontent.com/u/2581375?v=3","gravatar_id":"","url":"https://api.github.com/users/7oi","html_url":"https://github.com/7oi","followers_url":"https://api.github.com/users/7oi/followers","following_url":"https://api.github.com/users/7oi/following{/other_user}","gists_url":"https://api.github.com/users/7oi/gists{/gist_id}","starred_url":"https://api.github.com/users/7oi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7oi/subscriptions","organizations_url":"https://api.github.com/users/7oi/orgs","repos_url":"https://api.github.com/users/7oi/repos","events_url":"https://api.github.com/users/7oi/events{/privacy}","received_events_url":"https://api.github.com/users/7oi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-10T23:52:38Z","updated_at":"2017-06-11T00:34:14Z","closed_at":"2017-06-11T00:34:14Z","body":"## Problem\r\nThe requirements.txt file seems unnecessarily bloated. I've gone through the list and I've found multiple libraries that are never imported in the code and don't seem to be at all required for running the system. Possibly a lot of them are either old and redundant or possible contaminations from developers environments.\r\n\r\n## Suggested solution\r\nMy suggestion would be to strip out all the bloatware and also possibly create a requirements-dev.txt file. Of course that could bring up possibilites of cross-contamination again once updating the requirements.txt with any more modules, but it's still not that difficult to handle.\r\n\r\n## Details\r\nHere are my findings about the unimported modules:\r\n* ipython         : Utterly unnecessary unless in a development environment where it can be rather useful.\r\n* gnureadline     : possibly there just for devs on other platforms than Linux that do not come shipped with GNU redline installed. Needs not be in porduction.\r\n* pytz            : brings the Olson tz database into Python. Never used and probably unnecessary.\r\n* texttable       : Python module for creating simple ASCII tables. Not sure about the point of\r\n* pyOpenSSL       : OpenSSL library. Not used anywhere.\r\n* pycparser       : parser for the C language, written in pure Python. Never used.\r\n* pyasn1          : Generic implementation of ASN.1 types (X.208). Never imported anywhere.\r\n* idna            : Internationalized Domain Names in Applications. Never imported, although useful in a way. We should consider utilising it.\r\n* ipaddress       : Port of the 3.3+ ipaddress module to 2.6, 2.7, 3.2. Can't find any trace of it's usage.\r\n* diff-match-patch: in requirements.txt but also copied into codebase?\r\n* enum34          : Python 3.4 Enum backport. No. Just no. Just convert all to Python 3.4+\r\n* defusedxml      : XML bomb protection for Python stdlib modules. Possibly replaced by lxml\r\n* openpyxl        : module for working with spreadsheets. pyexcel is used, not openpyxl, although openpyxl is a more popular choice.\r\n* jdcal           : required for openpyxl, so pretty onnecessary\r\n* et-xmlfile      : low memory library for creating large XML files. Originally written for openpyxl\r\n* odfpy           : Yet another xml library, this one focusing on OpenDocument. Never imported\r\n* eight           : Python 2 -> 3 porting helper library. Never used and should never be used. A straight up conversion from 2 -> 3 is way better.\r\n\r\nAlso here are DB requirements. Should they be there or should they be chosen alongside a DB?\r\n* MySQL-python -----> Why are there two modules for MySQL?\r\n* PyMySQL _______/\r\n* psycopg2\r\n\r\nAnyone care to object or explain the bloatware?"},"comment":{"url":"https://api.github.com/repos/piratar/wasa2il/issues/comments/307598286","html_url":"https://github.com/piratar/wasa2il/issues/154#issuecomment-307598286","issue_url":"https://api.github.com/repos/piratar/wasa2il/issues/154","id":307598286,"user":{"login":"7oi","id":2581375,"avatar_url":"https://avatars2.githubusercontent.com/u/2581375?v=3","gravatar_id":"","url":"https://api.github.com/users/7oi","html_url":"https://github.com/7oi","followers_url":"https://api.github.com/users/7oi/followers","following_url":"https://api.github.com/users/7oi/following{/other_user}","gists_url":"https://api.github.com/users/7oi/gists{/gist_id}","starred_url":"https://api.github.com/users/7oi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7oi/subscriptions","organizations_url":"https://api.github.com/users/7oi/orgs","repos_url":"https://api.github.com/users/7oi/repos","events_url":"https://api.github.com/users/7oi/events{/privacy}","received_events_url":"https://api.github.com/users/7oi/received_events","type":"User","site_admin":false},"created_at":"2017-06-11T00:34:14Z","updated_at":"2017-06-11T00:34:14Z","body":"On further inspection, many of them seem to be requirements of other installed modules.\r\n\r\nStill, weird.\r\n\r\nClosing this issue."}}
{"actor":{"display_login":"7oi"}}