{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/127357658","pull_request_review_id":49934034,"id":127357658,"diff_hunk":"@@ -0,0 +1,95 @@\n+// Distributed under the MIT License.\n+// See LICENSE.txt for details.\n+\n+/// \\file\n+/// Defines class template Neighbors.\n+\n+#pragma once\n+\n+#include <iosfwd>\n+#include <memory>\n+#include <unordered_set>\n+\n+#include \"Domain/Direction.hpp\"\n+#include \"Domain/ElementId.hpp\"\n+#include \"Domain/Orientation.hpp\"\n+\n+/// \\ingroup ComputationalDomain\n+/// Information about the neighbors of an Element in a particular direction.\n+///\n+/// \\tparam VolumeDim the volume dimension.\n+template <size_t VolumeDim>\n+class Neighbors {\n+  static constexpr int private_asserts() {\n+    static_assert(std::is_nothrow_move_constructible<Neighbors>::value and\n+                      std::is_nothrow_move_assignable<Neighbors>::value,\n+                  \"Missing move semantics\");\n+    return 0;\n+  }\n+\n+ public:\n+  /// Construct with the ids and orientation of the neighbors.","path":"src/Domain/Neighbors.hpp","position":31,"original_position":31,"commit_id":"dc0436e5f0ed7ed6eee1c9232c0c065e9c5bd954","original_commit_id":"dc0436e5f0ed7ed6eee1c9232c0c065e9c5bd954","user":{"login":"osheamonn","id":13049958,"avatar_url":"https://avatars0.githubusercontent.com/u/13049958?v=4","gravatar_id":"","url":"https://api.github.com/users/osheamonn","html_url":"https://github.com/osheamonn","followers_url":"https://api.github.com/users/osheamonn/followers","following_url":"https://api.github.com/users/osheamonn/following{/other_user}","gists_url":"https://api.github.com/users/osheamonn/gists{/gist_id}","starred_url":"https://api.github.com/users/osheamonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheamonn/subscriptions","organizations_url":"https://api.github.com/users/osheamonn/orgs","repos_url":"https://api.github.com/users/osheamonn/repos","events_url":"https://api.github.com/users/osheamonn/events{/privacy}","received_events_url":"https://api.github.com/users/osheamonn/received_events","type":"User","site_admin":false},"body":"Comment's probably unnecessary. ","created_at":"2017-07-13T23:40:57Z","updated_at":"2017-07-13T23:45:26Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/109#discussion_r127357658","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/127357658"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/109#discussion_r127357658"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/109","id":130473362,"html_url":"https://github.com/sxs-collaboration/spectre/pull/109","diff_url":"https://github.com/sxs-collaboration/spectre/pull/109.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/109.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/109","number":109,"state":"open","locked":false,"title":"Add Block and test","user":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars0.githubusercontent.com/u/27026354?v=3","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"body":"Notable: Block construction now only takes Neighbors and no longer takes ExternalBoundaries - the ExternalBoundaries are deduced from the Neighbors during construction.","created_at":"2017-07-13T21:38:32Z","updated_at":"2017-07-13T23:45:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5db5b69d34fe42b00d5ae5df37859237f8e79180","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/109/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/109/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/109/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/dc0436e5f0ed7ed6eee1c9232c0c065e9c5bd954","head":{"label":"gsb76:gab_block_addition","ref":"gab_block_addition","sha":"dc0436e5f0ed7ed6eee1c9232c0c065e9c5bd954","user":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars0.githubusercontent.com/u/27026354?v=3","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"repo":{"id":94911327,"name":"spectre","full_name":"gsb76/spectre","owner":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars0.githubusercontent.com/u/27026354?v=3","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsb76/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/gsb76/spectre","forks_url":"https://api.github.com/repos/gsb76/spectre/forks","keys_url":"https://api.github.com/repos/gsb76/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsb76/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsb76/spectre/teams","hooks_url":"https://api.github.com/repos/gsb76/spectre/hooks","issue_events_url":"https://api.github.com/repos/gsb76/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/gsb76/spectre/events","assignees_url":"https://api.github.com/repos/gsb76/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/gsb76/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/gsb76/spectre/tags","blobs_url":"https://api.github.com/repos/gsb76/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsb76/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsb76/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsb76/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsb76/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/gsb76/spectre/languages","stargazers_url":"https://api.github.com/repos/gsb76/spectre/stargazers","contributors_url":"https://api.github.com/repos/gsb76/spectre/contributors","subscribers_url":"https://api.github.com/repos/gsb76/spectre/subscribers","subscription_url":"https://api.github.com/repos/gsb76/spectre/subscription","commits_url":"https://api.github.com/repos/gsb76/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsb76/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsb76/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsb76/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsb76/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/gsb76/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsb76/spectre/merges","archive_url":"https://api.github.com/repos/gsb76/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsb76/spectre/downloads","issues_url":"https://api.github.com/repos/gsb76/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/gsb76/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/gsb76/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/gsb76/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsb76/spectre/labels{/name}","releases_url":"https://api.github.com/repos/gsb76/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/gsb76/spectre/deployments","created_at":"2017-06-20T16:16:01Z","updated_at":"2017-06-20T16:16:03Z","pushed_at":"2017-07-13T21:29:40Z","git_url":"git://github.com/gsb76/spectre.git","ssh_url":"git@github.com:gsb76/spectre.git","clone_url":"https://github.com/gsb76/spectre.git","svn_url":"https://github.com/gsb76/spectre","homepage":null,"size":2881,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"6e865f2c857978071fd7f0f66804c70de0c0a067","user":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars5.githubusercontent.com/u/26882595?v=3","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars5.githubusercontent.com/u/26882595?v=3","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":null,"fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2017-07-05T19:27:55Z","pushed_at":"2017-07-13T21:38:33Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":null,"size":9702,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":16,"forks":6,"open_issues":16,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/109"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/109"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/109"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/dc0436e5f0ed7ed6eee1c9232c0c065e9c5bd954"}}}}
{"actor":{"display_login":"osheamonn"}}