{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/clouddriver/pulls/comments/114876020","pull_request_review_id":36374473,"id":114876020,"diff_hunk":"@@ -1,33 +1,44 @@\n package com.netflix.spinnaker.clouddriver.dcos\n \n import groovy.transform.ToString\n+import mesosphere.dcos.client.Config\n+import mesosphere.dcos.client.model.DCOSAuthCredentials\n \n class DcosConfigurationProperties {\n   public static final int ASYNC_OPERATION_TIMEOUT_SECONDS_DEFAULT = 300\n   public static final int ASYNC_OPERATION_MAX_POLLING_INTERVAL_SECONDS = 8\n \n+  List<Cluster> clusters = []\n   List<Account> accounts = []\n \n   int asyncOperationTimeoutSecondsDefault = ASYNC_OPERATION_TIMEOUT_SECONDS_DEFAULT\n   int asyncOperationMaxPollingIntervalSeconds = ASYNC_OPERATION_MAX_POLLING_INTERVAL_SECONDS\n \n-  // TODO consider moving load balancer config to account.\n-  LoadBalancerConfig loadBalancer\n-\n-  static class Account {\n+  static class Cluster {\n     String name\n-    String environment\n-    String accountType\n     String dcosUrl\n+    String caCertData\n+    String caCertFile\n+    LoadBalancerConfig loadBalancer\n+    List<LinkedDockerRegistryConfiguration> dockerRegistries\n+    boolean insecureSkipTlsVerify\n+    String secretStore\n+  }\n+\n+  static class ClusterCredentials {","path":"clouddriver-dcos/src/main/groovy/com/netflix/spinnaker/clouddriver/dcos/DcosConfigurationProperties.groovy","position":34,"original_position":34,"commit_id":"87cace99601c43304181ca8ee923c72bb97bc89a","original_commit_id":"87cace99601c43304181ca8ee923c72bb97bc89a","user":{"login":"mtweten","id":1782074,"avatar_url":"https://avatars0.githubusercontent.com/u/1782074?v=3","gravatar_id":"","url":"https://api.github.com/users/mtweten","html_url":"https://github.com/mtweten","followers_url":"https://api.github.com/users/mtweten/followers","following_url":"https://api.github.com/users/mtweten/following{/other_user}","gists_url":"https://api.github.com/users/mtweten/gists{/gist_id}","starred_url":"https://api.github.com/users/mtweten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtweten/subscriptions","organizations_url":"https://api.github.com/users/mtweten/orgs","repos_url":"https://api.github.com/users/mtweten/repos","events_url":"https://api.github.com/users/mtweten/events{/privacy}","received_events_url":"https://api.github.com/users/mtweten/received_events","type":"User","site_admin":false},"body":"Nit: ClusterCredential? (since it's only a single credential)","created_at":"2017-05-04T20:12:09Z","updated_at":"2017-05-04T21:02:00Z","html_url":"https://github.com/cerner/clouddriver/pull/20#discussion_r114876020","pull_request_url":"https://api.github.com/repos/cerner/clouddriver/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/cerner/clouddriver/pulls/comments/114876020"},"html":{"href":"https://github.com/cerner/clouddriver/pull/20#discussion_r114876020"},"pull_request":{"href":"https://api.github.com/repos/cerner/clouddriver/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/clouddriver/pulls/20","id":118835403,"html_url":"https://github.com/cerner/clouddriver/pull/20","diff_url":"https://github.com/cerner/clouddriver/pull/20.diff","patch_url":"https://github.com/cerner/clouddriver/pull/20.patch","issue_url":"https://api.github.com/repos/cerner/clouddriver/issues/20","number":20,"state":"open","locked":false,"title":"Adding support for multiple DC/OS clusters per account.","user":{"login":"TrevinTeacutter","id":25596866,"avatar_url":"https://avatars0.githubusercontent.com/u/25596866?v=3","gravatar_id":"","url":"https://api.github.com/users/TrevinTeacutter","html_url":"https://github.com/TrevinTeacutter","followers_url":"https://api.github.com/users/TrevinTeacutter/followers","following_url":"https://api.github.com/users/TrevinTeacutter/following{/other_user}","gists_url":"https://api.github.com/users/TrevinTeacutter/gists{/gist_id}","starred_url":"https://api.github.com/users/TrevinTeacutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrevinTeacutter/subscriptions","organizations_url":"https://api.github.com/users/TrevinTeacutter/orgs","repos_url":"https://api.github.com/users/TrevinTeacutter/repos","events_url":"https://api.github.com/users/TrevinTeacutter/events{/privacy}","received_events_url":"https://api.github.com/users/TrevinTeacutter/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-03T19:22:28Z","updated_at":"2017-05-04T21:02:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d37748e94fcddcd6d01f162f11346a924dc401a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/clouddriver/pulls/20/commits","review_comments_url":"https://api.github.com/repos/cerner/clouddriver/pulls/20/comments","review_comment_url":"https://api.github.com/repos/cerner/clouddriver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/clouddriver/issues/20/comments","statuses_url":"https://api.github.com/repos/cerner/clouddriver/statuses/87cace99601c43304181ca8ee923c72bb97bc89a","head":{"label":"cerner:issue-254","ref":"issue-254","sha":"87cace99601c43304181ca8ee923c72bb97bc89a","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":81138430,"name":"clouddriver","full_name":"cerner/clouddriver","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/cerner/clouddriver","forks_url":"https://api.github.com/repos/cerner/clouddriver/forks","keys_url":"https://api.github.com/repos/cerner/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/clouddriver/teams","hooks_url":"https://api.github.com/repos/cerner/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/cerner/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/clouddriver/events","assignees_url":"https://api.github.com/repos/cerner/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/clouddriver/tags","blobs_url":"https://api.github.com/repos/cerner/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/clouddriver/languages","stargazers_url":"https://api.github.com/repos/cerner/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/cerner/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/cerner/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/cerner/clouddriver/subscription","commits_url":"https://api.github.com/repos/cerner/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/clouddriver/merges","archive_url":"https://api.github.com/repos/cerner/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/clouddriver/downloads","issues_url":"https://api.github.com/repos/cerner/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/cerner/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/clouddriver/deployments","created_at":"2017-02-06T22:04:53Z","updated_at":"2017-02-06T22:05:02Z","pushed_at":"2017-05-04T19:16:02Z","git_url":"git://github.com/cerner/clouddriver.git","ssh_url":"git@github.com:cerner/clouddriver.git","clone_url":"https://github.com/cerner/clouddriver.git","svn_url":"https://github.com/cerner/clouddriver","homepage":null,"size":31664,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cerner:integration","ref":"integration","sha":"b0bcbd6cbe295438a09d7b76ffa6f32450aa111f","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":81138430,"name":"clouddriver","full_name":"cerner/clouddriver","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/clouddriver","description":"read and write operations across cloud providers","fork":true,"url":"https://api.github.com/repos/cerner/clouddriver","forks_url":"https://api.github.com/repos/cerner/clouddriver/forks","keys_url":"https://api.github.com/repos/cerner/clouddriver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/clouddriver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/clouddriver/teams","hooks_url":"https://api.github.com/repos/cerner/clouddriver/hooks","issue_events_url":"https://api.github.com/repos/cerner/clouddriver/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/clouddriver/events","assignees_url":"https://api.github.com/repos/cerner/clouddriver/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/clouddriver/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/clouddriver/tags","blobs_url":"https://api.github.com/repos/cerner/clouddriver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/clouddriver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/clouddriver/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/clouddriver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/clouddriver/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/clouddriver/languages","stargazers_url":"https://api.github.com/repos/cerner/clouddriver/stargazers","contributors_url":"https://api.github.com/repos/cerner/clouddriver/contributors","subscribers_url":"https://api.github.com/repos/cerner/clouddriver/subscribers","subscription_url":"https://api.github.com/repos/cerner/clouddriver/subscription","commits_url":"https://api.github.com/repos/cerner/clouddriver/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/clouddriver/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/clouddriver/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/clouddriver/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/clouddriver/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/clouddriver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/clouddriver/merges","archive_url":"https://api.github.com/repos/cerner/clouddriver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/clouddriver/downloads","issues_url":"https://api.github.com/repos/cerner/clouddriver/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/clouddriver/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/clouddriver/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/clouddriver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/clouddriver/labels{/name}","releases_url":"https://api.github.com/repos/cerner/clouddriver/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/clouddriver/deployments","created_at":"2017-02-06T22:04:53Z","updated_at":"2017-02-06T22:05:02Z","pushed_at":"2017-05-04T19:16:02Z","git_url":"git://github.com/cerner/clouddriver.git","ssh_url":"git@github.com:cerner/clouddriver.git","clone_url":"https://github.com/cerner/clouddriver.git","svn_url":"https://github.com/cerner/clouddriver","homepage":null,"size":31664,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/clouddriver/pulls/20"},"html":{"href":"https://github.com/cerner/clouddriver/pull/20"},"issue":{"href":"https://api.github.com/repos/cerner/clouddriver/issues/20"},"comments":{"href":"https://api.github.com/repos/cerner/clouddriver/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/clouddriver/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/clouddriver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/clouddriver/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/clouddriver/statuses/87cace99601c43304181ca8ee923c72bb97bc89a"}}}}
{"actor":{"display_login":"mtweten"}}