{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/18988","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/18988/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/18988/comments","events_url":"https://api.github.com/repos/apache/spark/issues/18988/events","html_url":"https://github.com/apache/spark/pull/18988","id":251138255,"number":18988,"title":"[SPARK-21778][SQL] Simpler Dataset.sample API in Scala / Java","user":{"login":"rxin","id":323388,"avatar_url":"https://avatars0.githubusercontent.com/u/323388?v=4","gravatar_id":"","url":"https://api.github.com/users/rxin","html_url":"https://github.com/rxin","followers_url":"https://api.github.com/users/rxin/followers","following_url":"https://api.github.com/users/rxin/following{/other_user}","gists_url":"https://api.github.com/users/rxin/gists{/gist_id}","starred_url":"https://api.github.com/users/rxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxin/subscriptions","organizations_url":"https://api.github.com/users/rxin/orgs","repos_url":"https://api.github.com/users/rxin/repos","events_url":"https://api.github.com/users/rxin/events{/privacy}","received_events_url":"https://api.github.com/users/rxin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-08-18T04:46:45Z","updated_at":"2017-08-18T12:00:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/18988","html_url":"https://github.com/apache/spark/pull/18988","diff_url":"https://github.com/apache/spark/pull/18988.diff","patch_url":"https://github.com/apache/spark/pull/18988.patch"},"body":"## What changes were proposed in this pull request?\r\nDataset.sample requires a boolean flag withReplacement as the first argument. However, most of the time users simply want to sample some records without replacement. This ticket introduces a new sample function that simply takes in the fraction and seed.\r\n\r\n## How was this patch tested?\r\nTested manually. Not sure yet if we should add a test case for just this wrapper ...\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/323335172","html_url":"https://github.com/apache/spark/pull/18988#issuecomment-323335172","issue_url":"https://api.github.com/repos/apache/spark/issues/18988","id":323335172,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars1.githubusercontent.com/u/8108735?v=4","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2017-08-18T12:00:14Z","updated_at":"2017-08-18T12:00:14Z","body":"**[Test build #80836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80836/testReport)** for PR 18988 at commit [`a21d8b0`](https://github.com/apache/spark/commit/a21d8b07a130fc47e76a96935f272cb720ff1250).\n * This patch **fails PySpark unit tests**.\n * This patch merges cleanly.\n * This patch adds no public classes."}}
{"actor":{"display_login":"SparkQA"}}