{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/comments/151288319","pull_request_review_id":76972445,"id":151288319,"diff_hunk":"@@ -112,6 +112,22 @@\n \n     })\n   });\n+  test('testing for deserialization of date', function(done) {\n+    var dateArr = [];\n+    dateArr[0] = new Date();\n+    dateArr[1] = String(dateArr[0].getTime()); //string timestamp\n+    dateArr[2] = dateArr[0].getTime(); //number timestamp\n+    dateArr[3] = dateArr[0].toString(); //full date\n+    setTimeout(function(){\n+      let ser = [];\n+      ser[0] = window.XFoo.prototype._deserializeValue(dateArr[1], Date);\n+      ser[1] = window.XFoo.prototype._deserializeValue(dateArr[2], Date);\n+      ser[2] = window.XFoo.prototype._deserializeValue(dateArr[3], Date);","path":"test/unit/property-accessors.html","position":14,"original_position":14,"commit_id":"939ce63ced8d3ff34ab6b196d95f4a31bf856697","original_commit_id":"939ce63ced8d3ff34ab6b196d95f4a31bf856697","user":{"login":"TimvdLippe","id":5948271,"avatar_url":"https://avatars3.githubusercontent.com/u/5948271?v=4","gravatar_id":"","url":"https://api.github.com/users/TimvdLippe","html_url":"https://github.com/TimvdLippe","followers_url":"https://api.github.com/users/TimvdLippe/followers","following_url":"https://api.github.com/users/TimvdLippe/following{/other_user}","gists_url":"https://api.github.com/users/TimvdLippe/gists{/gist_id}","starred_url":"https://api.github.com/users/TimvdLippe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimvdLippe/subscriptions","organizations_url":"https://api.github.com/users/TimvdLippe/orgs","repos_url":"https://api.github.com/users/TimvdLippe/repos","events_url":"https://api.github.com/users/TimvdLippe/events{/privacy}","received_events_url":"https://api.github.com/users/TimvdLippe/received_events","type":"User","site_admin":false},"body":"It seems like there is no assertion for this line? Could you add one for it? Also the variable name `ser` seems cryptic to me. Would be better to use a longer name to improve readability","created_at":"2017-11-15T23:59:31Z","updated_at":"2017-11-15T23:59:48Z","html_url":"https://github.com/Polymer/polymer/pull/4706#discussion_r151288319","pull_request_url":"https://api.github.com/repos/Polymer/polymer/pulls/4706","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments/151288319"},"html":{"href":"https://github.com/Polymer/polymer/pull/4706#discussion_r151288319"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/4706"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/4706","id":127002723,"html_url":"https://github.com/Polymer/polymer/pull/4706","diff_url":"https://github.com/Polymer/polymer/pull/4706.diff","patch_url":"https://github.com/Polymer/polymer/pull/4706.patch","issue_url":"https://api.github.com/repos/Polymer/polymer/issues/4706","number":4706,"state":"open","locked":false,"title":"Resolves Issue with DeSerialization of Date: #4696","user":{"login":"ronak1009","id":12443143,"avatar_url":"https://avatars1.githubusercontent.com/u/12443143?v=4","gravatar_id":"","url":"https://api.github.com/users/ronak1009","html_url":"https://github.com/ronak1009","followers_url":"https://api.github.com/users/ronak1009/followers","following_url":"https://api.github.com/users/ronak1009/following{/other_user}","gists_url":"https://api.github.com/users/ronak1009/gists{/gist_id}","starred_url":"https://api.github.com/users/ronak1009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronak1009/subscriptions","organizations_url":"https://api.github.com/users/ronak1009/orgs","repos_url":"https://api.github.com/users/ronak1009/repos","events_url":"https://api.github.com/users/ronak1009/events{/privacy}","received_events_url":"https://api.github.com/users/ronak1009/received_events","type":"User","site_admin":false},"body":"Fixes #4696: Issue with DeSerialization of Date\r\n","created_at":"2017-06-22T14:14:16Z","updated_at":"2017-11-15T23:59:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"331752adc31f15b72ff6b137f00a2b1a85e2cc95","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer/pulls/4706/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer/pulls/4706/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer/issues/4706/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/939ce63ced8d3ff34ab6b196d95f4a31bf856697","head":{"label":"ronak1009:master","ref":"master","sha":"939ce63ced8d3ff34ab6b196d95f4a31bf856697","user":{"login":"ronak1009","id":12443143,"avatar_url":"https://avatars1.githubusercontent.com/u/12443143?v=4","gravatar_id":"","url":"https://api.github.com/users/ronak1009","html_url":"https://github.com/ronak1009","followers_url":"https://api.github.com/users/ronak1009/followers","following_url":"https://api.github.com/users/ronak1009/following{/other_user}","gists_url":"https://api.github.com/users/ronak1009/gists{/gist_id}","starred_url":"https://api.github.com/users/ronak1009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronak1009/subscriptions","organizations_url":"https://api.github.com/users/ronak1009/orgs","repos_url":"https://api.github.com/users/ronak1009/repos","events_url":"https://api.github.com/users/ronak1009/events{/privacy}","received_events_url":"https://api.github.com/users/ronak1009/received_events","type":"User","site_admin":false},"repo":{"id":94989341,"name":"polymer","full_name":"ronak1009/polymer","owner":{"login":"ronak1009","id":12443143,"avatar_url":"https://avatars1.githubusercontent.com/u/12443143?v=4","gravatar_id":"","url":"https://api.github.com/users/ronak1009","html_url":"https://github.com/ronak1009","followers_url":"https://api.github.com/users/ronak1009/followers","following_url":"https://api.github.com/users/ronak1009/following{/other_user}","gists_url":"https://api.github.com/users/ronak1009/gists{/gist_id}","starred_url":"https://api.github.com/users/ronak1009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronak1009/subscriptions","organizations_url":"https://api.github.com/users/ronak1009/orgs","repos_url":"https://api.github.com/users/ronak1009/repos","events_url":"https://api.github.com/users/ronak1009/events{/privacy}","received_events_url":"https://api.github.com/users/ronak1009/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ronak1009/polymer","description":"Build modern apps using web components","fork":true,"url":"https://api.github.com/repos/ronak1009/polymer","forks_url":"https://api.github.com/repos/ronak1009/polymer/forks","keys_url":"https://api.github.com/repos/ronak1009/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ronak1009/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ronak1009/polymer/teams","hooks_url":"https://api.github.com/repos/ronak1009/polymer/hooks","issue_events_url":"https://api.github.com/repos/ronak1009/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/ronak1009/polymer/events","assignees_url":"https://api.github.com/repos/ronak1009/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/ronak1009/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/ronak1009/polymer/tags","blobs_url":"https://api.github.com/repos/ronak1009/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ronak1009/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ronak1009/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ronak1009/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ronak1009/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/ronak1009/polymer/languages","stargazers_url":"https://api.github.com/repos/ronak1009/polymer/stargazers","contributors_url":"https://api.github.com/repos/ronak1009/polymer/contributors","subscribers_url":"https://api.github.com/repos/ronak1009/polymer/subscribers","subscription_url":"https://api.github.com/repos/ronak1009/polymer/subscription","commits_url":"https://api.github.com/repos/ronak1009/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ronak1009/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ronak1009/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ronak1009/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ronak1009/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/ronak1009/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ronak1009/polymer/merges","archive_url":"https://api.github.com/repos/ronak1009/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ronak1009/polymer/downloads","issues_url":"https://api.github.com/repos/ronak1009/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/ronak1009/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/ronak1009/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/ronak1009/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ronak1009/polymer/labels{/name}","releases_url":"https://api.github.com/repos/ronak1009/polymer/releases{/id}","deployments_url":"https://api.github.com/repos/ronak1009/polymer/deployments","created_at":"2017-06-21T09:52:00Z","updated_at":"2017-06-21T09:52:04Z","pushed_at":"2017-10-06T13:45:11Z","git_url":"git://github.com/ronak1009/polymer.git","ssh_url":"git@github.com:ronak1009/polymer.git","clone_url":"https://github.com/ronak1009/polymer.git","svn_url":"https://github.com/ronak1009/polymer","homepage":"https://www.polymer-project.org/","size":23388,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"48fdac7f795c17df154fd7f64830cd6182426536","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":5532320,"name":"polymer","full_name":"Polymer/polymer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer","description":"Build modern apps using web components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer","forks_url":"https://api.github.com/repos/Polymer/polymer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer/deployments","created_at":"2012-08-23T20:56:30Z","updated_at":"2017-11-15T16:35:05Z","pushed_at":"2017-11-15T23:56:47Z","git_url":"git://github.com/Polymer/polymer.git","ssh_url":"git@github.com:Polymer/polymer.git","clone_url":"https://github.com/Polymer/polymer.git","svn_url":"https://github.com/Polymer/polymer","homepage":"https://www.polymer-project.org/","size":23714,"stargazers_count":18726,"watchers_count":18726,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1878,"mirror_url":null,"archived":false,"open_issues_count":420,"forks":1878,"open_issues":420,"watchers":18726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/4706"},"html":{"href":"https://github.com/Polymer/polymer/pull/4706"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer/issues/4706"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer/issues/4706/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/4706/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/4706/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer/statuses/939ce63ced8d3ff34ab6b196d95f4a31bf856697"}},"author_association":"NONE"}}
{"actor":{"display_login":"TimvdLippe"}}