{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/159125788","pull_request_review_id":86033650,"id":159125788,"diff_hunk":"@@ -77,5 +77,10 @@ See the LICENSE file in the project root for more information.\n       <LinkerArg Include=\"/OPT:REF\" />\n       <LinkerArg Include=\"/OPT:ICF\" />\n     </ItemGroup>\n+\n+    <Exec Command=\"where /Q $(CppLinker)\" IgnoreExitCode=\"true\">","path":"src/BuildIntegration/Microsoft.NETCore.Native.Windows.props","position":5,"original_position":5,"commit_id":"a975d564d53485810ea640e7108d985a0f4e09c9","original_commit_id":"a975d564d53485810ea640e7108d985a0f4e09c9","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Add similar message for Unix as well?","created_at":"2017-12-30T17:23:58Z","updated_at":"2017-12-30T17:23:58Z","html_url":"https://github.com/dotnet/corert/pull/5171#discussion_r159125788","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/5171","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/159125788"},"html":{"href":"https://github.com/dotnet/corert/pull/5171#discussion_r159125788"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5171"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/5171","id":160593827,"html_url":"https://github.com/dotnet/corert/pull/5171","diff_url":"https://github.com/dotnet/corert/pull/5171.diff","patch_url":"https://github.com/dotnet/corert/pull/5171.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/5171","number":5171,"state":"open","locked":false,"title":"Add diagnostic messages to the build targets","user":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars0.githubusercontent.com/u/13110571?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"body":"Two things:\r\n* Running ILC takes a while but we don't print any information about it. Print a message.\r\n* Invoking the publish from a clean command promt is something that will happen very often I assume. Make sure the failure message is more prescriptive.\r\n\r\nWe'll want to make these messages localizable at some point...","created_at":"2017-12-30T16:30:46Z","updated_at":"2017-12-30T17:23:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40267e02c52ebbe88440c363575a7759e9de5eef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/5171/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/5171/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/5171/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/a975d564d53485810ea640e7108d985a0f4e09c9","head":{"label":"MichalStrehovsky:diagMessages","ref":"diagMessages","sha":"a975d564d53485810ea640e7108d985a0f4e09c9","user":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars0.githubusercontent.com/u/13110571?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"repo":{"id":46432791,"name":"corert","full_name":"MichalStrehovsky/corert","owner":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars0.githubusercontent.com/u/13110571?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MichalStrehovsky/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/MichalStrehovsky/corert","forks_url":"https://api.github.com/repos/MichalStrehovsky/corert/forks","keys_url":"https://api.github.com/repos/MichalStrehovsky/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MichalStrehovsky/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MichalStrehovsky/corert/teams","hooks_url":"https://api.github.com/repos/MichalStrehovsky/corert/hooks","issue_events_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues/events{/number}","events_url":"https://api.github.com/repos/MichalStrehovsky/corert/events","assignees_url":"https://api.github.com/repos/MichalStrehovsky/corert/assignees{/user}","branches_url":"https://api.github.com/repos/MichalStrehovsky/corert/branches{/branch}","tags_url":"https://api.github.com/repos/MichalStrehovsky/corert/tags","blobs_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MichalStrehovsky/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/MichalStrehovsky/corert/languages","stargazers_url":"https://api.github.com/repos/MichalStrehovsky/corert/stargazers","contributors_url":"https://api.github.com/repos/MichalStrehovsky/corert/contributors","subscribers_url":"https://api.github.com/repos/MichalStrehovsky/corert/subscribers","subscription_url":"https://api.github.com/repos/MichalStrehovsky/corert/subscription","commits_url":"https://api.github.com/repos/MichalStrehovsky/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/MichalStrehovsky/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/MichalStrehovsky/corert/contents/{+path}","compare_url":"https://api.github.com/repos/MichalStrehovsky/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MichalStrehovsky/corert/merges","archive_url":"https://api.github.com/repos/MichalStrehovsky/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MichalStrehovsky/corert/downloads","issues_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues{/number}","pulls_url":"https://api.github.com/repos/MichalStrehovsky/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/MichalStrehovsky/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/MichalStrehovsky/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MichalStrehovsky/corert/labels{/name}","releases_url":"https://api.github.com/repos/MichalStrehovsky/corert/releases{/id}","deployments_url":"https://api.github.com/repos/MichalStrehovsky/corert/deployments","created_at":"2015-11-18T16:45:32Z","updated_at":"2016-01-14T03:31:37Z","pushed_at":"2017-12-30T16:34:13Z","git_url":"git://github.com/MichalStrehovsky/corert.git","ssh_url":"git@github.com:MichalStrehovsky/corert.git","clone_url":"https://github.com/MichalStrehovsky/corert.git","svn_url":"https://github.com/MichalStrehovsky/corert","homepage":"http://dotnet.github.io/","size":24077,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0fae9d362f17b25f3201f23f8e3e2922ddc73b12","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2017-12-29T00:07:09Z","pushed_at":"2017-12-30T16:54:30Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dot.net","size":23965,"stargazers_count":828,"watchers_count":828,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":250,"license":null,"forks":276,"open_issues":250,"watchers":828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5171"},"html":{"href":"https://github.com/dotnet/corert/pull/5171"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/5171"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/5171/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5171/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/5171/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/a975d564d53485810ea640e7108d985a0f4e09c9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkotas"}}