{"action":"created","comment":{"url":"https://api.github.com/repos/krakjoe/pthreads/pulls/comments/119994817","pull_request_review_id":41927776,"id":119994817,"diff_hunk":"@@ -239,7 +239,9 @@ void pthreads_current_thread(zval *return_value) {\n \n /* {{{ */\n int pthreads_connect(pthreads_object_t* source, pthreads_object_t* destination) {\n-\tif (source && destination) {\n+\tpthreads_ident_t destCreator = destination->creator;","path":"src/object.c","position":5,"original_position":5,"commit_id":"fe4c0bb2be7ac4c8e6c0620c9d128c8e2a19711d","original_commit_id":"fe4c0bb2be7ac4c8e6c0620c9d128c8e2a19711d","user":{"login":"tpunt","id":1403064,"avatar_url":"https://avatars0.githubusercontent.com/u/1403064?v=3","gravatar_id":"","url":"https://api.github.com/users/tpunt","html_url":"https://github.com/tpunt","followers_url":"https://api.github.com/users/tpunt/followers","following_url":"https://api.github.com/users/tpunt/following{/other_user}","gists_url":"https://api.github.com/users/tpunt/gists{/gist_id}","starred_url":"https://api.github.com/users/tpunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpunt/subscriptions","organizations_url":"https://api.github.com/users/tpunt/orgs","repos_url":"https://api.github.com/users/tpunt/repos","events_url":"https://api.github.com/users/tpunt/events{/privacy}","received_events_url":"https://api.github.com/users/tpunt/received_events","type":"User","site_admin":false},"body":"Can you place this declaration inside of the `if` statement below, please. The below condition is checking to make sure `destination` is not `NULL`, so there must be some case when it can be `NULL` (in which case, the current code will segfault by trying to deref a `NULL` pointer (`destination`)).","created_at":"2017-06-03T20:45:10Z","updated_at":"2017-06-03T20:45:10Z","html_url":"https://github.com/krakjoe/pthreads/pull/685#discussion_r119994817","pull_request_url":"https://api.github.com/repos/krakjoe/pthreads/pulls/685","_links":{"self":{"href":"https://api.github.com/repos/krakjoe/pthreads/pulls/comments/119994817"},"html":{"href":"https://github.com/krakjoe/pthreads/pull/685#discussion_r119994817"},"pull_request":{"href":"https://api.github.com/repos/krakjoe/pthreads/pulls/685"}}},"pull_request":{"url":"https://api.github.com/repos/krakjoe/pthreads/pulls/685","id":108664828,"html_url":"https://github.com/krakjoe/pthreads/pull/685","diff_url":"https://github.com/krakjoe/pthreads/pull/685.diff","patch_url":"https://github.com/krakjoe/pthreads/pull/685.patch","issue_url":"https://api.github.com/repos/krakjoe/pthreads/issues/685","number":685,"state":"open","locked":false,"title":"#666 - don't override creator TSRMLS","user":{"login":"SirSnyder","id":4345652,"avatar_url":"https://avatars0.githubusercontent.com/u/4345652?v=3","gravatar_id":"","url":"https://api.github.com/users/SirSnyder","html_url":"https://github.com/SirSnyder","followers_url":"https://api.github.com/users/SirSnyder/followers","following_url":"https://api.github.com/users/SirSnyder/following{/other_user}","gists_url":"https://api.github.com/users/SirSnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/SirSnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirSnyder/subscriptions","organizations_url":"https://api.github.com/users/SirSnyder/orgs","repos_url":"https://api.github.com/users/SirSnyder/repos","events_url":"https://api.github.com/users/SirSnyder/events{/privacy}","received_events_url":"https://api.github.com/users/SirSnyder/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-02T01:02:40Z","updated_at":"2017-06-03T20:45:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"685613914612a9e4cb5ad2d20eefd142c59666ae","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/krakjoe/pthreads/pulls/685/commits","review_comments_url":"https://api.github.com/repos/krakjoe/pthreads/pulls/685/comments","review_comment_url":"https://api.github.com/repos/krakjoe/pthreads/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krakjoe/pthreads/issues/685/comments","statuses_url":"https://api.github.com/repos/krakjoe/pthreads/statuses/fe4c0bb2be7ac4c8e6c0620c9d128c8e2a19711d","head":{"label":"SirSnyder:bug/666_segfault","ref":"bug/666_segfault","sha":"fe4c0bb2be7ac4c8e6c0620c9d128c8e2a19711d","user":{"login":"SirSnyder","id":4345652,"avatar_url":"https://avatars0.githubusercontent.com/u/4345652?v=3","gravatar_id":"","url":"https://api.github.com/users/SirSnyder","html_url":"https://github.com/SirSnyder","followers_url":"https://api.github.com/users/SirSnyder/followers","following_url":"https://api.github.com/users/SirSnyder/following{/other_user}","gists_url":"https://api.github.com/users/SirSnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/SirSnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirSnyder/subscriptions","organizations_url":"https://api.github.com/users/SirSnyder/orgs","repos_url":"https://api.github.com/users/SirSnyder/repos","events_url":"https://api.github.com/users/SirSnyder/events{/privacy}","received_events_url":"https://api.github.com/users/SirSnyder/received_events","type":"User","site_admin":false},"repo":{"id":80170816,"name":"pthreads","full_name":"SirSnyder/pthreads","owner":{"login":"SirSnyder","id":4345652,"avatar_url":"https://avatars0.githubusercontent.com/u/4345652?v=3","gravatar_id":"","url":"https://api.github.com/users/SirSnyder","html_url":"https://github.com/SirSnyder","followers_url":"https://api.github.com/users/SirSnyder/followers","following_url":"https://api.github.com/users/SirSnyder/following{/other_user}","gists_url":"https://api.github.com/users/SirSnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/SirSnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirSnyder/subscriptions","organizations_url":"https://api.github.com/users/SirSnyder/orgs","repos_url":"https://api.github.com/users/SirSnyder/repos","events_url":"https://api.github.com/users/SirSnyder/events{/privacy}","received_events_url":"https://api.github.com/users/SirSnyder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SirSnyder/pthreads","description":"Threading for PHP - Share Nothing, Do Everything :)","fork":true,"url":"https://api.github.com/repos/SirSnyder/pthreads","forks_url":"https://api.github.com/repos/SirSnyder/pthreads/forks","keys_url":"https://api.github.com/repos/SirSnyder/pthreads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SirSnyder/pthreads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SirSnyder/pthreads/teams","hooks_url":"https://api.github.com/repos/SirSnyder/pthreads/hooks","issue_events_url":"https://api.github.com/repos/SirSnyder/pthreads/issues/events{/number}","events_url":"https://api.github.com/repos/SirSnyder/pthreads/events","assignees_url":"https://api.github.com/repos/SirSnyder/pthreads/assignees{/user}","branches_url":"https://api.github.com/repos/SirSnyder/pthreads/branches{/branch}","tags_url":"https://api.github.com/repos/SirSnyder/pthreads/tags","blobs_url":"https://api.github.com/repos/SirSnyder/pthreads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SirSnyder/pthreads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SirSnyder/pthreads/git/refs{/sha}","trees_url":"https://api.github.com/repos/SirSnyder/pthreads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SirSnyder/pthreads/statuses/{sha}","languages_url":"https://api.github.com/repos/SirSnyder/pthreads/languages","stargazers_url":"https://api.github.com/repos/SirSnyder/pthreads/stargazers","contributors_url":"https://api.github.com/repos/SirSnyder/pthreads/contributors","subscribers_url":"https://api.github.com/repos/SirSnyder/pthreads/subscribers","subscription_url":"https://api.github.com/repos/SirSnyder/pthreads/subscription","commits_url":"https://api.github.com/repos/SirSnyder/pthreads/commits{/sha}","git_commits_url":"https://api.github.com/repos/SirSnyder/pthreads/git/commits{/sha}","comments_url":"https://api.github.com/repos/SirSnyder/pthreads/comments{/number}","issue_comment_url":"https://api.github.com/repos/SirSnyder/pthreads/issues/comments{/number}","contents_url":"https://api.github.com/repos/SirSnyder/pthreads/contents/{+path}","compare_url":"https://api.github.com/repos/SirSnyder/pthreads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SirSnyder/pthreads/merges","archive_url":"https://api.github.com/repos/SirSnyder/pthreads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SirSnyder/pthreads/downloads","issues_url":"https://api.github.com/repos/SirSnyder/pthreads/issues{/number}","pulls_url":"https://api.github.com/repos/SirSnyder/pthreads/pulls{/number}","milestones_url":"https://api.github.com/repos/SirSnyder/pthreads/milestones{/number}","notifications_url":"https://api.github.com/repos/SirSnyder/pthreads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SirSnyder/pthreads/labels{/name}","releases_url":"https://api.github.com/repos/SirSnyder/pthreads/releases{/id}","deployments_url":"https://api.github.com/repos/SirSnyder/pthreads/deployments","created_at":"2017-01-27T00:56:23Z","updated_at":"2017-03-14T14:23:07Z","pushed_at":"2017-06-01T11:29:25Z","git_url":"git://github.com/SirSnyder/pthreads.git","ssh_url":"git@github.com:SirSnyder/pthreads.git","clone_url":"https://github.com/SirSnyder/pthreads.git","svn_url":"https://github.com/SirSnyder/pthreads","homepage":"","size":2102,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"krakjoe:master","ref":"master","sha":"19973972f6548b60e41170acd4e5819e1a4eeb0a","user":{"login":"krakjoe","id":2236138,"avatar_url":"https://avatars1.githubusercontent.com/u/2236138?v=3","gravatar_id":"","url":"https://api.github.com/users/krakjoe","html_url":"https://github.com/krakjoe","followers_url":"https://api.github.com/users/krakjoe/followers","following_url":"https://api.github.com/users/krakjoe/following{/other_user}","gists_url":"https://api.github.com/users/krakjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/krakjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakjoe/subscriptions","organizations_url":"https://api.github.com/users/krakjoe/orgs","repos_url":"https://api.github.com/users/krakjoe/repos","events_url":"https://api.github.com/users/krakjoe/events{/privacy}","received_events_url":"https://api.github.com/users/krakjoe/received_events","type":"User","site_admin":false},"repo":{"id":5589723,"name":"pthreads","full_name":"krakjoe/pthreads","owner":{"login":"krakjoe","id":2236138,"avatar_url":"https://avatars1.githubusercontent.com/u/2236138?v=3","gravatar_id":"","url":"https://api.github.com/users/krakjoe","html_url":"https://github.com/krakjoe","followers_url":"https://api.github.com/users/krakjoe/followers","following_url":"https://api.github.com/users/krakjoe/following{/other_user}","gists_url":"https://api.github.com/users/krakjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/krakjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakjoe/subscriptions","organizations_url":"https://api.github.com/users/krakjoe/orgs","repos_url":"https://api.github.com/users/krakjoe/repos","events_url":"https://api.github.com/users/krakjoe/events{/privacy}","received_events_url":"https://api.github.com/users/krakjoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krakjoe/pthreads","description":"Threading for PHP - Share Nothing, Do Everything :)","fork":false,"url":"https://api.github.com/repos/krakjoe/pthreads","forks_url":"https://api.github.com/repos/krakjoe/pthreads/forks","keys_url":"https://api.github.com/repos/krakjoe/pthreads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krakjoe/pthreads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krakjoe/pthreads/teams","hooks_url":"https://api.github.com/repos/krakjoe/pthreads/hooks","issue_events_url":"https://api.github.com/repos/krakjoe/pthreads/issues/events{/number}","events_url":"https://api.github.com/repos/krakjoe/pthreads/events","assignees_url":"https://api.github.com/repos/krakjoe/pthreads/assignees{/user}","branches_url":"https://api.github.com/repos/krakjoe/pthreads/branches{/branch}","tags_url":"https://api.github.com/repos/krakjoe/pthreads/tags","blobs_url":"https://api.github.com/repos/krakjoe/pthreads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krakjoe/pthreads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krakjoe/pthreads/git/refs{/sha}","trees_url":"https://api.github.com/repos/krakjoe/pthreads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krakjoe/pthreads/statuses/{sha}","languages_url":"https://api.github.com/repos/krakjoe/pthreads/languages","stargazers_url":"https://api.github.com/repos/krakjoe/pthreads/stargazers","contributors_url":"https://api.github.com/repos/krakjoe/pthreads/contributors","subscribers_url":"https://api.github.com/repos/krakjoe/pthreads/subscribers","subscription_url":"https://api.github.com/repos/krakjoe/pthreads/subscription","commits_url":"https://api.github.com/repos/krakjoe/pthreads/commits{/sha}","git_commits_url":"https://api.github.com/repos/krakjoe/pthreads/git/commits{/sha}","comments_url":"https://api.github.com/repos/krakjoe/pthreads/comments{/number}","issue_comment_url":"https://api.github.com/repos/krakjoe/pthreads/issues/comments{/number}","contents_url":"https://api.github.com/repos/krakjoe/pthreads/contents/{+path}","compare_url":"https://api.github.com/repos/krakjoe/pthreads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krakjoe/pthreads/merges","archive_url":"https://api.github.com/repos/krakjoe/pthreads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krakjoe/pthreads/downloads","issues_url":"https://api.github.com/repos/krakjoe/pthreads/issues{/number}","pulls_url":"https://api.github.com/repos/krakjoe/pthreads/pulls{/number}","milestones_url":"https://api.github.com/repos/krakjoe/pthreads/milestones{/number}","notifications_url":"https://api.github.com/repos/krakjoe/pthreads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krakjoe/pthreads/labels{/name}","releases_url":"https://api.github.com/repos/krakjoe/pthreads/releases{/id}","deployments_url":"https://api.github.com/repos/krakjoe/pthreads/deployments","created_at":"2012-08-28T17:57:40Z","updated_at":"2017-06-03T17:08:06Z","pushed_at":"2017-06-03T17:51:31Z","git_url":"git://github.com/krakjoe/pthreads.git","ssh_url":"git@github.com:krakjoe/pthreads.git","clone_url":"https://github.com/krakjoe/pthreads.git","svn_url":"https://github.com/krakjoe/pthreads","homepage":"","size":2082,"stargazers_count":2500,"watchers_count":2500,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":413,"mirror_url":null,"open_issues_count":38,"forks":413,"open_issues":38,"watchers":2500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krakjoe/pthreads/pulls/685"},"html":{"href":"https://github.com/krakjoe/pthreads/pull/685"},"issue":{"href":"https://api.github.com/repos/krakjoe/pthreads/issues/685"},"comments":{"href":"https://api.github.com/repos/krakjoe/pthreads/issues/685/comments"},"review_comments":{"href":"https://api.github.com/repos/krakjoe/pthreads/pulls/685/comments"},"review_comment":{"href":"https://api.github.com/repos/krakjoe/pthreads/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krakjoe/pthreads/pulls/685/commits"},"statuses":{"href":"https://api.github.com/repos/krakjoe/pthreads/statuses/fe4c0bb2be7ac4c8e6c0620c9d128c8e2a19711d"}}}}
{"actor":{"display_login":"tpunt"}}