{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-kernel/pulls/comments/95723344","pull_request_review_id":16287425,"id":95723344,"diff_hunk":"@@ -76,6 +76,13 @@ protected void addClassPathEntries() throws MalformedURLException {\n \t\taddFileUrl(new File(ROOT + File.separator + LIB + File.separator\n \t\t\t\t+ \"checkin-client\" + File.separator + \"log4j.properties\"));\n \n+\t\t//add component/plugins\n+\t\tString internalLibPath = System.getProperty(\"components.repo\");","path":"core/org.wso2.carbon.bootstrap/src/main/java/org/wso2/carbon/bootstrap/CheckinClientBootstrap.java","position":5,"original_position":5,"commit_id":"6f95a5b2861009a362ab3a12948c6d78e8ccdd07","original_commit_id":"6f95a5b2861009a362ab3a12948c6d78e8ccdd07","user":{"login":"madhawa-gunasekara","id":6748599,"avatar_url":"https://avatars.githubusercontent.com/u/6748599?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawa-gunasekara","html_url":"https://github.com/madhawa-gunasekara","followers_url":"https://api.github.com/users/madhawa-gunasekara/followers","following_url":"https://api.github.com/users/madhawa-gunasekara/following{/other_user}","gists_url":"https://api.github.com/users/madhawa-gunasekara/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawa-gunasekara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawa-gunasekara/subscriptions","organizations_url":"https://api.github.com/users/madhawa-gunasekara/orgs","repos_url":"https://api.github.com/users/madhawa-gunasekara/repos","events_url":"https://api.github.com/users/madhawa-gunasekara/events{/privacy}","received_events_url":"https://api.github.com/users/madhawa-gunasekara/received_events","type":"User","site_admin":false},"body":"I have moved most of them. In this class, we don't have access to inner carbon class path. ","created_at":"2017-01-12T04:14:25Z","updated_at":"2017-01-12T04:14:25Z","html_url":"https://github.com/wso2/carbon-kernel/pull/1257#discussion_r95723344","pull_request_url":"https://api.github.com/repos/wso2/carbon-kernel/pulls/1257","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-kernel/pulls/comments/95723344"},"html":{"href":"https://github.com/wso2/carbon-kernel/pull/1257#discussion_r95723344"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-kernel/pulls/1257"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-kernel/pulls/1257","id":100601841,"html_url":"https://github.com/wso2/carbon-kernel/pull/1257","diff_url":"https://github.com/wso2/carbon-kernel/pull/1257.diff","patch_url":"https://github.com/wso2/carbon-kernel/pull/1257.patch","issue_url":"https://api.github.com/repos/wso2/carbon-kernel/issues/1257","number":1257,"state":"open","locked":false,"title":"Adding system parameters ","user":{"login":"madhawa-gunasekara","id":6748599,"avatar_url":"https://avatars.githubusercontent.com/u/6748599?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawa-gunasekara","html_url":"https://github.com/madhawa-gunasekara","followers_url":"https://api.github.com/users/madhawa-gunasekara/followers","following_url":"https://api.github.com/users/madhawa-gunasekara/following{/other_user}","gists_url":"https://api.github.com/users/madhawa-gunasekara/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawa-gunasekara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawa-gunasekara/subscriptions","organizations_url":"https://api.github.com/users/madhawa-gunasekara/orgs","repos_url":"https://api.github.com/users/madhawa-gunasekara/repos","events_url":"https://api.github.com/users/madhawa-gunasekara/events{/privacy}","received_events_url":"https://api.github.com/users/madhawa-gunasekara/received_events","type":"User","site_admin":false},"body":"Added some system properties to locate \r\nrepository/components folder              =   carbon.components.dir.path     //equinox framework related stuff \r\nrepository/components/extensions      =   carbon.extensions.dir.path   // carbon extensions\r\nrepository/components/dropins            =   carbon.dropins.dir.path  //extenal osgi bundles\r\nrepository/components/lib                    =   carbon.external.lib.dir.path // external thirda party lib\r\nrepository/components/patches           =   carbon.patches.dir.path  // carbon patches\r\nrepository/components/servicepacks   =   carbon.servicepacks.dir.path // carbon servicepacks\r\n/lib                                                        =   carbon.internal.lib.dir.path // tomcat and other related stuff for internal usage\r\n\r\n-Dcarbon.components.dir.path=\"$CARBON_HOME/wso2/components\" \\\r\n-Dcarbon.extensions.dir.path=\"$CARBON_HOME/extensions\" \\\r\n-Dcarbon.dropins.dir.path=\"$CARBON_HOME/dropins\" \\\r\n-Dcarbon.external.lib.dir.path=\"$CARBON_HOME/lib\" \\\r\n-Dcarbon.patches.dir.path=\"$CARBON_HOME/patches\" \\\r\n-Dcarbon.servicepacks.dir.path=\"$CARBON_HOME/servicepacks\" \\\r\n-Dcarbon.internal.lib.dir.path=\"$CARBON_HOME/wso2/lib\" \\","created_at":"2017-01-08T13:04:14Z","updated_at":"2017-01-12T04:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"502e35dc24bf51432e93de4370cefaea70bc30cd","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/wso2/carbon-kernel/milestones/7","html_url":"https://github.com/wso2/carbon-kernel/milestone/7","labels_url":"https://api.github.com/repos/wso2/carbon-kernel/milestones/7/labels","id":2223001,"number":7,"title":"4.4.12","description":null,"creator":{"login":"Niranjan-K","id":5525926,"avatar_url":"https://avatars.githubusercontent.com/u/5525926?v=3","gravatar_id":"","url":"https://api.github.com/users/Niranjan-K","html_url":"https://github.com/Niranjan-K","followers_url":"https://api.github.com/users/Niranjan-K/followers","following_url":"https://api.github.com/users/Niranjan-K/following{/other_user}","gists_url":"https://api.github.com/users/Niranjan-K/gists{/gist_id}","starred_url":"https://api.github.com/users/Niranjan-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Niranjan-K/subscriptions","organizations_url":"https://api.github.com/users/Niranjan-K/orgs","repos_url":"https://api.github.com/users/Niranjan-K/repos","events_url":"https://api.github.com/users/Niranjan-K/events{/privacy}","received_events_url":"https://api.github.com/users/Niranjan-K/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2017-01-02T09:22:23Z","updated_at":"2017-01-09T11:05:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/wso2/carbon-kernel/pulls/1257/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-kernel/pulls/1257/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-kernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-kernel/issues/1257/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-kernel/statuses/6f95a5b2861009a362ab3a12948c6d78e8ccdd07","head":{"label":"madhawa-gunasekara:integrator","ref":"integrator","sha":"6f95a5b2861009a362ab3a12948c6d78e8ccdd07","user":{"login":"madhawa-gunasekara","id":6748599,"avatar_url":"https://avatars.githubusercontent.com/u/6748599?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawa-gunasekara","html_url":"https://github.com/madhawa-gunasekara","followers_url":"https://api.github.com/users/madhawa-gunasekara/followers","following_url":"https://api.github.com/users/madhawa-gunasekara/following{/other_user}","gists_url":"https://api.github.com/users/madhawa-gunasekara/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawa-gunasekara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawa-gunasekara/subscriptions","organizations_url":"https://api.github.com/users/madhawa-gunasekara/orgs","repos_url":"https://api.github.com/users/madhawa-gunasekara/repos","events_url":"https://api.github.com/users/madhawa-gunasekara/events{/privacy}","received_events_url":"https://api.github.com/users/madhawa-gunasekara/received_events","type":"User","site_admin":false},"repo":{"id":34850642,"name":"carbon4-kernel","full_name":"madhawa-gunasekara/carbon4-kernel","owner":{"login":"madhawa-gunasekara","id":6748599,"avatar_url":"https://avatars.githubusercontent.com/u/6748599?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawa-gunasekara","html_url":"https://github.com/madhawa-gunasekara","followers_url":"https://api.github.com/users/madhawa-gunasekara/followers","following_url":"https://api.github.com/users/madhawa-gunasekara/following{/other_user}","gists_url":"https://api.github.com/users/madhawa-gunasekara/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawa-gunasekara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawa-gunasekara/subscriptions","organizations_url":"https://api.github.com/users/madhawa-gunasekara/orgs","repos_url":"https://api.github.com/users/madhawa-gunasekara/repos","events_url":"https://api.github.com/users/madhawa-gunasekara/events{/privacy}","received_events_url":"https://api.github.com/users/madhawa-gunasekara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madhawa-gunasekara/carbon4-kernel","description":null,"fork":true,"url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel","forks_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/forks","keys_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/teams","hooks_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/hooks","issue_events_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/events","assignees_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/tags","blobs_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/languages","stargazers_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/stargazers","contributors_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/contributors","subscribers_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/subscribers","subscription_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/subscription","commits_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/merges","archive_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/downloads","issues_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/labels{/name}","releases_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/madhawa-gunasekara/carbon4-kernel/deployments","created_at":"2015-04-30T11:19:31Z","updated_at":"2015-04-30T11:19:37Z","pushed_at":"2017-01-12T01:45:24Z","git_url":"git://github.com/madhawa-gunasekara/carbon4-kernel.git","ssh_url":"git@github.com:madhawa-gunasekara/carbon4-kernel.git","clone_url":"https://github.com/madhawa-gunasekara/carbon4-kernel.git","svn_url":"https://github.com/madhawa-gunasekara/carbon4-kernel","homepage":null,"size":36816,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:4.4.x","ref":"4.4.x","sha":"53251d2614dfce0df9715a44314068f9598c30ce","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":16162184,"name":"carbon-kernel","full_name":"wso2/carbon-kernel","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-kernel","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-kernel","forks_url":"https://api.github.com/repos/wso2/carbon-kernel/forks","keys_url":"https://api.github.com/repos/wso2/carbon-kernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-kernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-kernel/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-kernel/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-kernel/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-kernel/events","assignees_url":"https://api.github.com/repos/wso2/carbon-kernel/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-kernel/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-kernel/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-kernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-kernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-kernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-kernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-kernel/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-kernel/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-kernel/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-kernel/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-kernel/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-kernel/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-kernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-kernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-kernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-kernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-kernel/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-kernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-kernel/merges","archive_url":"https://api.github.com/repos/wso2/carbon-kernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-kernel/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-kernel/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-kernel/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-kernel/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-kernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-kernel/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-kernel/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-kernel/deployments","created_at":"2014-01-23T04:23:41Z","updated_at":"2017-01-03T08:52:18Z","pushed_at":"2017-01-12T01:45:26Z","git_url":"git://github.com/wso2/carbon-kernel.git","ssh_url":"git@github.com:wso2/carbon-kernel.git","clone_url":"https://github.com/wso2/carbon-kernel.git","svn_url":"https://github.com/wso2/carbon-kernel","homepage":null,"size":44969,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":29,"forks":286,"open_issues":29,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-kernel/pulls/1257"},"html":{"href":"https://github.com/wso2/carbon-kernel/pull/1257"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-kernel/issues/1257"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-kernel/issues/1257/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-kernel/pulls/1257/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-kernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-kernel/pulls/1257/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-kernel/statuses/6f95a5b2861009a362ab3a12948c6d78e8ccdd07"}}}}
{"actor":{"display_login":"madhawa-gunasekara"}}