{"action":"created","issue":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2784","repository_url":"https://api.github.com/repos/ow2-proactive/scheduling","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2784/labels{/name}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2784/comments","events_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2784/events","html_url":"https://github.com/ow2-proactive/scheduling/pull/2784","id":206019780,"number":2784,"title":"Restore nodes lock on RM restart","user":{"login":"lpellegr","id":128898,"avatar_url":"https://avatars.githubusercontent.com/u/128898?v=3","gravatar_id":"","url":"https://api.github.com/users/lpellegr","html_url":"https://github.com/lpellegr","followers_url":"https://api.github.com/users/lpellegr/followers","following_url":"https://api.github.com/users/lpellegr/following{/other_user}","gists_url":"https://api.github.com/users/lpellegr/gists{/gist_id}","starred_url":"https://api.github.com/users/lpellegr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpellegr/subscriptions","organizations_url":"https://api.github.com/users/lpellegr/orgs","repos_url":"https://api.github.com/users/lpellegr/repos","events_url":"https://api.github.com/users/lpellegr/events{/privacy}","received_events_url":"https://api.github.com/users/lpellegr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lpellegr","id":128898,"avatar_url":"https://avatars.githubusercontent.com/u/128898?v=3","gravatar_id":"","url":"https://api.github.com/users/lpellegr","html_url":"https://github.com/lpellegr","followers_url":"https://api.github.com/users/lpellegr/followers","following_url":"https://api.github.com/users/lpellegr/following{/other_user}","gists_url":"https://api.github.com/users/lpellegr/gists{/gist_id}","starred_url":"https://api.github.com/users/lpellegr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpellegr/subscriptions","organizations_url":"https://api.github.com/users/lpellegr/orgs","repos_url":"https://api.github.com/users/lpellegr/repos","events_url":"https://api.github.com/users/lpellegr/events{/privacy}","received_events_url":"https://api.github.com/users/lpellegr/received_events","type":"User","site_admin":false},"assignees":[{"login":"lpellegr","id":128898,"avatar_url":"https://avatars.githubusercontent.com/u/128898?v=3","gravatar_id":"","url":"https://api.github.com/users/lpellegr","html_url":"https://github.com/lpellegr","followers_url":"https://api.github.com/users/lpellegr/followers","following_url":"https://api.github.com/users/lpellegr/following{/other_user}","gists_url":"https://api.github.com/users/lpellegr/gists{/gist_id}","starred_url":"https://api.github.com/users/lpellegr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpellegr/subscriptions","organizations_url":"https://api.github.com/users/lpellegr/orgs","repos_url":"https://api.github.com/users/lpellegr/repos","events_url":"https://api.github.com/users/lpellegr/events{/privacy}","received_events_url":"https://api.github.com/users/lpellegr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-02-07T21:25:02Z","updated_at":"2017-02-08T00:17:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/2784","html_url":"https://github.com/ow2-proactive/scheduling/pull/2784","diff_url":"https://github.com/ow2-proactive/scheduling/pull/2784.diff","patch_url":"https://github.com/ow2-proactive/scheduling/pull/2784.patch"},"body":"This PR resolves #2758.\r\n\r\nAll commits will be squashed before merging."},"comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/comments/278188315","html_url":"https://github.com/ow2-proactive/scheduling/pull/2784#issuecomment-278188315","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/2784","id":278188315,"user":{"login":"sonarqube-activeeon","id":14940028,"avatar_url":"https://avatars.githubusercontent.com/u/14940028?v=3","gravatar_id":"","url":"https://api.github.com/users/sonarqube-activeeon","html_url":"https://github.com/sonarqube-activeeon","followers_url":"https://api.github.com/users/sonarqube-activeeon/followers","following_url":"https://api.github.com/users/sonarqube-activeeon/following{/other_user}","gists_url":"https://api.github.com/users/sonarqube-activeeon/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarqube-activeeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarqube-activeeon/subscriptions","organizations_url":"https://api.github.com/users/sonarqube-activeeon/orgs","repos_url":"https://api.github.com/users/sonarqube-activeeon/repos","events_url":"https://api.github.com/users/sonarqube-activeeon/events{/privacy}","received_events_url":"https://api.github.com/users/sonarqube-activeeon/received_events","type":"User","site_admin":false},"created_at":"2017-02-08T00:17:51Z","updated_at":"2017-02-08T00:17:51Z","body":"SonarQube analysis reported 15 issues\n* ![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) 3 critical\n* ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) 6 major\n* ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) 5 minor\n* ![INFO](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-info.png) 1 info\n\n#### Top 10 issues\n\n1. ![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) [InfrastructureManager.java#L98](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/nodesource/infrastructure/InfrastructureManager.java#L98): Make \"deployingNodes\" private or transient. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS1948)\n1. ![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) [InfrastructureManager.java#L100](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/nodesource/infrastructure/InfrastructureManager.java#L100): Make \"lostNodes\" private or transient. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS1948)\n1. ![CRITICAL](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-critical.png) [AbstractRMNode.java#L80](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/rmnode/AbstractRMNode.java#L80): Make \"nodeSource\" transient or serializable. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS1948)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [RMDBManager.java#L154](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/db/RMDBManager.java#L154): Refactor this code to not nest more than 3 if/for/while/switch/try statements. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS134)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [RMDBManager.java#L154](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/db/RMDBManager.java#L154): Merge this if statement with the enclosing one. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS1066)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [AbstractRMNode.java#L135](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/rmnode/AbstractRMNode.java#L135): Add a default case to this switch. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3ASwitchLastCaseIsDefaultCheck)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [RMDeployingNode.java#L61](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/rmnode/RMDeployingNode.java#L61): Override this superclass' \"equals\" method. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS2160)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [RMNodeImpl.java#L82](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/rmnode/RMNodeImpl.java#L82): Override this superclass' \"equals\" method. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS2160)\n1. ![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) [RMNodeHelper.java#L35](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/utils/RMNodeHelper.java#L35): Add a private constructor to hide the implicit public one. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AS1118)\n1. ![MINOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-minor.png) [RMCore.java#L58](https://github.com/ow2-proactive/scheduling/blob/888d43bff983ccf097242417ff8f2e33adf7bdc9/rm/rm-server/src/main/java/org/ow2/proactive/resourcemanager/core/RMCore.java#L58): Remove this unused import 'javax.xml.ws.Provider'. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://master.ci.activeeon.com:9000/coding_rules#rule_key=squid%3AUselessImportCheck)\n"}}
{"actor":{"display_login":"sonarqube-activeeon"}}