{"action":"created","comment":{"url":"https://api.github.com/repos/windingtree/LifToken/pulls/comments/138435271","pull_request_review_id":62230084,"id":138435271,"diff_hunk":"@@ -346,18 +357,56 @@ contract LifCrowdsale is Ownable, Pausable {\n       foundationWallet.transfer(foundationBalanceCapWei);\n \n       // TODO: create the MVM with a start block that equals one month after crowdsale ends\n-      LifMarketValidationMechanism newMVM = new LifMarketValidationMechanism(\n+      MVM = new LifMarketValidationMechanism(\n         address(token), block.timestamp.add(10), 30 days, MVMPeriods, foundationWallet\n       );\n-      newMVM.fund.value(mmFundBalance)();\n-      newMVM.transferOwnership(foundationWallet);\n \n-      MVM = address(newMVM);\n+      mintExtraTokens(uint256(MVMPeriods));\n+\n+      MVM.fund.value(mmFundBalance)();\n+      MVM.transferOwnership(foundationWallet);\n \n     }\n   }\n \n   /**\n+     @dev Internal. Distribute the rest of the tokens among founders and advisors\n+   */\n+  function mintExtraTokens(uint256 foundationMonthsStart) internal {\n+    // calculate how much tokens will the founders, foundation and advisors will receive\n+    uint256 foundersTokens = token.totalSupply().mul(128).div(1000);\n+    uint256 foundationTokens = token.totalSupply().mul(50).div(1000);\n+    uint256 advisorsTokens = token.totalSupply().mul(72).div(1000);\n+\n+    // create the vested payment schedule for the founders\n+    foundersVestedPayment = new VestedPayment(\n+      block.timestamp, 30 days, 48, 12, foundersTokens, token\n+    );\n+    token.mint(foundersVestedPayment, foundersTokens);\n+    foundersVestedPayment.transferOwnership(foundationWallet);\n+\n+    // create the vested payment schedule for the foundation\n+    uint256 foundationPaymentStart = foundationMonthsStart.mul(604800);","path":"contracts/LifCrowdsale.sol","position":72,"original_position":72,"commit_id":"8ca60aacb3ed2e42513bb4bbb4115161f8aae9c3","original_commit_id":"8ca60aacb3ed2e42513bb4bbb4115161f8aae9c3","user":{"login":"nberger","id":81371,"avatar_url":"https://avatars1.githubusercontent.com/u/81371?v=4","gravatar_id":"","url":"https://api.github.com/users/nberger","html_url":"https://github.com/nberger","followers_url":"https://api.github.com/users/nberger/followers","following_url":"https://api.github.com/users/nberger/following{/other_user}","gists_url":"https://api.github.com/users/nberger/gists{/gist_id}","starred_url":"https://api.github.com/users/nberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nberger/subscriptions","organizations_url":"https://api.github.com/users/nberger/orgs","repos_url":"https://api.github.com/users/nberger/repos","events_url":"https://api.github.com/users/nberger/events{/privacy}","received_events_url":"https://api.github.com/users/nberger/received_events","type":"User","site_admin":false},"body":"604800 is a week, I think we are talking about months here. Maybe it's better to use `foundationMonthsStart.mul(1 month)` (or `30 days` instead of `1 month`)","created_at":"2017-09-12T18:50:07Z","updated_at":"2017-09-12T18:50:08Z","html_url":"https://github.com/windingtree/LifToken/pull/182#discussion_r138435271","pull_request_url":"https://api.github.com/repos/windingtree/LifToken/pulls/182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/comments/138435271"},"html":{"href":"https://github.com/windingtree/LifToken/pull/182#discussion_r138435271"},"pull_request":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/windingtree/LifToken/pulls/182","id":140378327,"html_url":"https://github.com/windingtree/LifToken/pull/182","diff_url":"https://github.com/windingtree/LifToken/pull/182.diff","patch_url":"https://github.com/windingtree/LifToken/pull/182.patch","issue_url":"https://api.github.com/repos/windingtree/LifToken/issues/182","number":182,"state":"open","locked":false,"title":"Integrate vested tokens","user":{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-11T16:25:40Z","updated_at":"2017-09-12T18:50:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"507ba68e48c2061bf4d629967f5cbdfe95f6e879","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/windingtree/LifToken/pulls/182/commits","review_comments_url":"https://api.github.com/repos/windingtree/LifToken/pulls/182/comments","review_comment_url":"https://api.github.com/repos/windingtree/LifToken/pulls/comments{/number}","comments_url":"https://api.github.com/repos/windingtree/LifToken/issues/182/comments","statuses_url":"https://api.github.com/repos/windingtree/LifToken/statuses/8ca60aacb3ed2e42513bb4bbb4115161f8aae9c3","head":{"label":"AugustoL:integrate-vestedTokens","ref":"integrate-vestedTokens","sha":"8ca60aacb3ed2e42513bb4bbb4115161f8aae9c3","user":{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false},"repo":{"id":76576781,"name":"LifToken","full_name":"AugustoL/LifToken","owner":{"login":"AugustoL","id":7763867,"avatar_url":"https://avatars2.githubusercontent.com/u/7763867?v=4","gravatar_id":"","url":"https://api.github.com/users/AugustoL","html_url":"https://github.com/AugustoL","followers_url":"https://api.github.com/users/AugustoL/followers","following_url":"https://api.github.com/users/AugustoL/following{/other_user}","gists_url":"https://api.github.com/users/AugustoL/gists{/gist_id}","starred_url":"https://api.github.com/users/AugustoL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugustoL/subscriptions","organizations_url":"https://api.github.com/users/AugustoL/orgs","repos_url":"https://api.github.com/users/AugustoL/repos","events_url":"https://api.github.com/users/AugustoL/events{/privacy}","received_events_url":"https://api.github.com/users/AugustoL/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AugustoL/LifToken","description":"Líf is the token for the Winding Tree platform","fork":true,"url":"https://api.github.com/repos/AugustoL/LifToken","forks_url":"https://api.github.com/repos/AugustoL/LifToken/forks","keys_url":"https://api.github.com/repos/AugustoL/LifToken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AugustoL/LifToken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AugustoL/LifToken/teams","hooks_url":"https://api.github.com/repos/AugustoL/LifToken/hooks","issue_events_url":"https://api.github.com/repos/AugustoL/LifToken/issues/events{/number}","events_url":"https://api.github.com/repos/AugustoL/LifToken/events","assignees_url":"https://api.github.com/repos/AugustoL/LifToken/assignees{/user}","branches_url":"https://api.github.com/repos/AugustoL/LifToken/branches{/branch}","tags_url":"https://api.github.com/repos/AugustoL/LifToken/tags","blobs_url":"https://api.github.com/repos/AugustoL/LifToken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AugustoL/LifToken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AugustoL/LifToken/git/refs{/sha}","trees_url":"https://api.github.com/repos/AugustoL/LifToken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AugustoL/LifToken/statuses/{sha}","languages_url":"https://api.github.com/repos/AugustoL/LifToken/languages","stargazers_url":"https://api.github.com/repos/AugustoL/LifToken/stargazers","contributors_url":"https://api.github.com/repos/AugustoL/LifToken/contributors","subscribers_url":"https://api.github.com/repos/AugustoL/LifToken/subscribers","subscription_url":"https://api.github.com/repos/AugustoL/LifToken/subscription","commits_url":"https://api.github.com/repos/AugustoL/LifToken/commits{/sha}","git_commits_url":"https://api.github.com/repos/AugustoL/LifToken/git/commits{/sha}","comments_url":"https://api.github.com/repos/AugustoL/LifToken/comments{/number}","issue_comment_url":"https://api.github.com/repos/AugustoL/LifToken/issues/comments{/number}","contents_url":"https://api.github.com/repos/AugustoL/LifToken/contents/{+path}","compare_url":"https://api.github.com/repos/AugustoL/LifToken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AugustoL/LifToken/merges","archive_url":"https://api.github.com/repos/AugustoL/LifToken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AugustoL/LifToken/downloads","issues_url":"https://api.github.com/repos/AugustoL/LifToken/issues{/number}","pulls_url":"https://api.github.com/repos/AugustoL/LifToken/pulls{/number}","milestones_url":"https://api.github.com/repos/AugustoL/LifToken/milestones{/number}","notifications_url":"https://api.github.com/repos/AugustoL/LifToken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AugustoL/LifToken/labels{/name}","releases_url":"https://api.github.com/repos/AugustoL/LifToken/releases{/id}","deployments_url":"https://api.github.com/repos/AugustoL/LifToken/deployments","created_at":"2016-12-15T16:31:35Z","updated_at":"2016-12-15T16:31:37Z","pushed_at":"2017-09-12T18:32:14Z","git_url":"git://github.com/AugustoL/LifToken.git","ssh_url":"git@github.com:AugustoL/LifToken.git","clone_url":"https://github.com/AugustoL/LifToken.git","svn_url":"https://github.com/AugustoL/LifToken","homepage":"","size":616,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"windingtree:master","ref":"master","sha":"577819a62f9d8af522da9c33b9789f44b891e7e3","user":{"login":"windingtree","id":22484548,"avatar_url":"https://avatars2.githubusercontent.com/u/22484548?v=4","gravatar_id":"","url":"https://api.github.com/users/windingtree","html_url":"https://github.com/windingtree","followers_url":"https://api.github.com/users/windingtree/followers","following_url":"https://api.github.com/users/windingtree/following{/other_user}","gists_url":"https://api.github.com/users/windingtree/gists{/gist_id}","starred_url":"https://api.github.com/users/windingtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windingtree/subscriptions","organizations_url":"https://api.github.com/users/windingtree/orgs","repos_url":"https://api.github.com/users/windingtree/repos","events_url":"https://api.github.com/users/windingtree/events{/privacy}","received_events_url":"https://api.github.com/users/windingtree/received_events","type":"Organization","site_admin":false},"repo":{"id":75439674,"name":"LifToken","full_name":"windingtree/LifToken","owner":{"login":"windingtree","id":22484548,"avatar_url":"https://avatars2.githubusercontent.com/u/22484548?v=4","gravatar_id":"","url":"https://api.github.com/users/windingtree","html_url":"https://github.com/windingtree","followers_url":"https://api.github.com/users/windingtree/followers","following_url":"https://api.github.com/users/windingtree/following{/other_user}","gists_url":"https://api.github.com/users/windingtree/gists{/gist_id}","starred_url":"https://api.github.com/users/windingtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/windingtree/subscriptions","organizations_url":"https://api.github.com/users/windingtree/orgs","repos_url":"https://api.github.com/users/windingtree/repos","events_url":"https://api.github.com/users/windingtree/events{/privacy}","received_events_url":"https://api.github.com/users/windingtree/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/windingtree/LifToken","description":"Líf is the token for the Winding Tree platform","fork":false,"url":"https://api.github.com/repos/windingtree/LifToken","forks_url":"https://api.github.com/repos/windingtree/LifToken/forks","keys_url":"https://api.github.com/repos/windingtree/LifToken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/windingtree/LifToken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/windingtree/LifToken/teams","hooks_url":"https://api.github.com/repos/windingtree/LifToken/hooks","issue_events_url":"https://api.github.com/repos/windingtree/LifToken/issues/events{/number}","events_url":"https://api.github.com/repos/windingtree/LifToken/events","assignees_url":"https://api.github.com/repos/windingtree/LifToken/assignees{/user}","branches_url":"https://api.github.com/repos/windingtree/LifToken/branches{/branch}","tags_url":"https://api.github.com/repos/windingtree/LifToken/tags","blobs_url":"https://api.github.com/repos/windingtree/LifToken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/windingtree/LifToken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/windingtree/LifToken/git/refs{/sha}","trees_url":"https://api.github.com/repos/windingtree/LifToken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/windingtree/LifToken/statuses/{sha}","languages_url":"https://api.github.com/repos/windingtree/LifToken/languages","stargazers_url":"https://api.github.com/repos/windingtree/LifToken/stargazers","contributors_url":"https://api.github.com/repos/windingtree/LifToken/contributors","subscribers_url":"https://api.github.com/repos/windingtree/LifToken/subscribers","subscription_url":"https://api.github.com/repos/windingtree/LifToken/subscription","commits_url":"https://api.github.com/repos/windingtree/LifToken/commits{/sha}","git_commits_url":"https://api.github.com/repos/windingtree/LifToken/git/commits{/sha}","comments_url":"https://api.github.com/repos/windingtree/LifToken/comments{/number}","issue_comment_url":"https://api.github.com/repos/windingtree/LifToken/issues/comments{/number}","contents_url":"https://api.github.com/repos/windingtree/LifToken/contents/{+path}","compare_url":"https://api.github.com/repos/windingtree/LifToken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/windingtree/LifToken/merges","archive_url":"https://api.github.com/repos/windingtree/LifToken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/windingtree/LifToken/downloads","issues_url":"https://api.github.com/repos/windingtree/LifToken/issues{/number}","pulls_url":"https://api.github.com/repos/windingtree/LifToken/pulls{/number}","milestones_url":"https://api.github.com/repos/windingtree/LifToken/milestones{/number}","notifications_url":"https://api.github.com/repos/windingtree/LifToken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/windingtree/LifToken/labels{/name}","releases_url":"https://api.github.com/repos/windingtree/LifToken/releases{/id}","deployments_url":"https://api.github.com/repos/windingtree/LifToken/deployments","created_at":"2016-12-02T23:41:12Z","updated_at":"2017-09-11T19:28:02Z","pushed_at":"2017-09-12T18:32:16Z","git_url":"git://github.com/windingtree/LifToken.git","ssh_url":"git@github.com:windingtree/LifToken.git","clone_url":"https://github.com/windingtree/LifToken.git","svn_url":"https://github.com/windingtree/LifToken","homepage":"","size":565,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/182"},"html":{"href":"https://github.com/windingtree/LifToken/pull/182"},"issue":{"href":"https://api.github.com/repos/windingtree/LifToken/issues/182"},"comments":{"href":"https://api.github.com/repos/windingtree/LifToken/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/windingtree/LifToken/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/windingtree/LifToken/statuses/8ca60aacb3ed2e42513bb4bbb4115161f8aae9c3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nberger"}}