{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/140828075","pull_request_review_id":64956501,"id":140828075,"diff_hunk":"@@ -28,7 +28,9 @@ set -u\n # Print commands\n set -x\n \n-RBAC_FILE='install/kubernetes/istio-rbac-beta.yaml'\n-\n echo 'Running e2e with rbac, with auth Tests'\n-./prow/e2e-suite.sh --rbac_path=\"${RBAC_FILE}\" --auth_enable \"${@}\"\n+if [ \"$#\" != 0 ]; then","path":"prow/e2e-suite-rbac-auth.sh","position":8,"original_position":8,"commit_id":"57423d32a7264a8ecc2d555cbd1baec3ddf60a59","original_commit_id":"57423d32a7264a8ecc2d555cbd1baec3ddf60a59","user":{"login":"sebastienvas","id":17773671,"avatar_url":"https://avatars1.githubusercontent.com/u/17773671?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienvas","html_url":"https://github.com/sebastienvas","followers_url":"https://api.github.com/users/sebastienvas/followers","following_url":"https://api.github.com/users/sebastienvas/following{/other_user}","gists_url":"https://api.github.com/users/sebastienvas/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienvas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienvas/subscriptions","organizations_url":"https://api.github.com/users/sebastienvas/orgs","repos_url":"https://api.github.com/users/sebastienvas/repos","events_url":"https://api.github.com/users/sebastienvas/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienvas/received_events","type":"User","site_admin":false},"body":"Why is this required ?","created_at":"2017-09-25T16:30:24Z","updated_at":"2017-09-25T16:30:24Z","html_url":"https://github.com/istio/istio/pull/902#discussion_r140828075","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/902","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/140828075"},"html":{"href":"https://github.com/istio/istio/pull/902#discussion_r140828075"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/902"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/902","id":142499230,"html_url":"https://github.com/istio/istio/pull/902","diff_url":"https://github.com/istio/istio/pull/902.diff","patch_url":"https://github.com/istio/istio/pull/902.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/902","number":902,"state":"open","locked":false,"title":"Enable cluster wide installation in tests","user":{"login":"andraxylia","id":10883640,"avatar_url":"https://avatars0.githubusercontent.com/u/10883640?v=4","gravatar_id":"","url":"https://api.github.com/users/andraxylia","html_url":"https://github.com/andraxylia","followers_url":"https://api.github.com/users/andraxylia/followers","following_url":"https://api.github.com/users/andraxylia/following{/other_user}","gists_url":"https://api.github.com/users/andraxylia/gists{/gist_id}","starred_url":"https://api.github.com/users/andraxylia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andraxylia/subscriptions","organizations_url":"https://api.github.com/users/andraxylia/orgs","repos_url":"https://api.github.com/users/andraxylia/repos","events_url":"https://api.github.com/users/andraxylia/events{/privacy}","received_events_url":"https://api.github.com/users/andraxylia/received_events","type":"User","site_admin":false},"body":"Enabled \"new-e2e-rbac-noauth.sh\" to run cluster wide, with auth, and initializer. This script creates a new GKE cluster for every run and deletes it in the end. TODO: rename the script to e2e-cluster-wide-auth in the repo istio-testing, after validation that it works as expected.\r\n\r\nIf --cluster-wide true flag is passed, the tests install the istio.yaml and istio-auth.yaml, instead of the istio-one-namespace.yaml and istio-auth-one-namespace.yaml.\r\n\r\nRemoved unused rbac-beta file.\r\n\r\nRemoved the un-needed lines that create the namespace, ns is included in the yaml file. \r\n\r\nAdded tests for uninstalling by running kubectl delete on the istio.yaml, similar to what user will do.\r\n \r\nFixed the e2e scripts to work on mac, by using lower case for the generated uuid.\r\n\r\nIncludes a fix to be able to run piped Unix commands.","created_at":"2017-09-22T05:23:37Z","updated_at":"2017-09-25T16:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f81776c60c536b623df94b75784594e2771838e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"costinm","id":84202,"avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"ZackButcher","id":1923135,"avatar_url":"https://avatars2.githubusercontent.com/u/1923135?v=4","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},{"login":"rshriram","id":8202871,"avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/902/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/902/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/902/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/57423d32a7264a8ecc2d555cbd1baec3ddf60a59","head":{"label":"istio:e2e","ref":"e2e","sha":"57423d32a7264a8ecc2d555cbd1baec3ddf60a59","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2017-09-25T13:57:50Z","pushed_at":"2017-09-25T16:28:40Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":102547,"stargazers_count":2892,"watchers_count":2892,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":140,"forks":284,"open_issues":140,"watchers":2892,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"402061ed51be2f0796ff75d541a8c4e3debfb2bf","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2017-09-25T13:57:50Z","pushed_at":"2017-09-25T16:28:40Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":102547,"stargazers_count":2892,"watchers_count":2892,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":284,"mirror_url":null,"open_issues_count":140,"forks":284,"open_issues":140,"watchers":2892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/902"},"html":{"href":"https://github.com/istio/istio/pull/902"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/902"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/902/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/902/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/902/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/57423d32a7264a8ecc2d555cbd1baec3ddf60a59"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sebastienvas"}}