{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/comments/112697484","pull_request_review_id":34034625,"id":112697484,"diff_hunk":"@@ -12,6 +12,21 @@ describe('Teaser Presenter', () => {\n \n \tcontext('classModifiers', () => {\n \n+\t\tit('produces an empty array if mods undefined', () => {\n+\t\t\tconst content = { mods: undefined };\n+\t\t\tsubject = new Presenter(content);\n+\t\t\texpect(subject.classModifiers).to.deep.equal([]);\n+\t\t});\n+\n+\t\tit('does not save previous teaser modifiers to new teaser', () => {\n+\t\t\tconst content = { isOpinion: true };\n+\t\t\tlet teaser1 = new Presenter(content);\n+\t\t\tlet teaser2 =new Presenter(content);","path":"tests/presenters/teaser-presenter.spec.js","position":13,"original_position":13,"commit_id":"ae29f4e1d034c138706ff70225b4f14bd7b1514a","original_commit_id":"ae29f4e1d034c138706ff70225b4f14bd7b1514a","user":{"login":"andygnewman","id":8938227,"avatar_url":"https://avatars1.githubusercontent.com/u/8938227?v=3","gravatar_id":"","url":"https://api.github.com/users/andygnewman","html_url":"https://github.com/andygnewman","followers_url":"https://api.github.com/users/andygnewman/followers","following_url":"https://api.github.com/users/andygnewman/following{/other_user}","gists_url":"https://api.github.com/users/andygnewman/gists{/gist_id}","starred_url":"https://api.github.com/users/andygnewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andygnewman/subscriptions","organizations_url":"https://api.github.com/users/andygnewman/orgs","repos_url":"https://api.github.com/users/andygnewman/repos","events_url":"https://api.github.com/users/andygnewman/events{/privacy}","received_events_url":"https://api.github.com/users/andygnewman/received_events","type":"User","site_admin":false},"body":"This doesn't test the condition that we were trying to avoid.\r\n\r\nWhat you want to do is something like;\r\n```\r\nconst mods = ['test'];\r\nconst content = { mods, isOpinion:true };\r\nconst teaser = new Presenter(content);\r\nexpect(teaser.classModifiers).to.contain('opinion');\r\nexpect(mods).to.not.contain('opinion');","created_at":"2017-04-21T14:17:38Z","updated_at":"2017-04-21T14:17:38Z","html_url":"https://github.com/Financial-Times/n-teaser/pull/107#discussion_r112697484","pull_request_url":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/107","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/comments/112697484"},"html":{"href":"https://github.com/Financial-Times/n-teaser/pull/107#discussion_r112697484"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/107","id":116799100,"html_url":"https://github.com/Financial-Times/n-teaser/pull/107","diff_url":"https://github.com/Financial-Times/n-teaser/pull/107.diff","patch_url":"https://github.com/Financial-Times/n-teaser/pull/107.patch","issue_url":"https://api.github.com/repos/Financial-Times/n-teaser/issues/107","number":107,"state":"open","locked":false,"title":"fixes mod repetition if multiple teasers exist in succession","user":{"login":"gvonkoss","id":16777943,"avatar_url":"https://avatars3.githubusercontent.com/u/16777943?v=3","gravatar_id":"","url":"https://api.github.com/users/gvonkoss","html_url":"https://github.com/gvonkoss","followers_url":"https://api.github.com/users/gvonkoss/followers","following_url":"https://api.github.com/users/gvonkoss/following{/other_user}","gists_url":"https://api.github.com/users/gvonkoss/gists{/gist_id}","starred_url":"https://api.github.com/users/gvonkoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvonkoss/subscriptions","organizations_url":"https://api.github.com/users/gvonkoss/orgs","repos_url":"https://api.github.com/users/gvonkoss/repos","events_url":"https://api.github.com/users/gvonkoss/events{/privacy}","received_events_url":"https://api.github.com/users/gvonkoss/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-20T15:26:55Z","updated_at":"2017-04-21T14:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46aebec991ef9c09325738baefef6d2ac31f2fed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/107/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/107/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/n-teaser/issues/107/comments","statuses_url":"https://api.github.com/repos/Financial-Times/n-teaser/statuses/ae29f4e1d034c138706ff70225b4f14bd7b1514a","head":{"label":"Financial-Times:repeated-mods","ref":"repeated-mods","sha":"ae29f4e1d034c138706ff70225b4f14bd7b1514a","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars2.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":70815728,"name":"n-teaser","full_name":"Financial-Times/n-teaser","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars2.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/n-teaser","description":"n-card’s replacement: improved styles, simpler combinations, more basic templating","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-teaser","forks_url":"https://api.github.com/repos/Financial-Times/n-teaser/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-teaser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-teaser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-teaser/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-teaser/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-teaser/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-teaser/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-teaser/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-teaser/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-teaser/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-teaser/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-teaser/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-teaser/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-teaser/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-teaser/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-teaser/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-teaser/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-teaser/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-teaser/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-teaser/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-teaser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-teaser/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-teaser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-teaser/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-teaser/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-teaser/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-teaser/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-teaser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-teaser/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-teaser/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-teaser/deployments","created_at":"2016-10-13T14:35:10Z","updated_at":"2016-12-02T11:01:48Z","pushed_at":"2017-04-21T14:12:27Z","git_url":"git://github.com/Financial-Times/n-teaser.git","ssh_url":"git@github.com:Financial-Times/n-teaser.git","clone_url":"https://github.com/Financial-Times/n-teaser.git","svn_url":"https://github.com/Financial-Times/n-teaser","homepage":"","size":197,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":1,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"773b8ce285fa52695a04883ab3fd385b9e74ea6b","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars2.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":70815728,"name":"n-teaser","full_name":"Financial-Times/n-teaser","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars2.githubusercontent.com/u/3502508?v=3","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/n-teaser","description":"n-card’s replacement: improved styles, simpler combinations, more basic templating","fork":false,"url":"https://api.github.com/repos/Financial-Times/n-teaser","forks_url":"https://api.github.com/repos/Financial-Times/n-teaser/forks","keys_url":"https://api.github.com/repos/Financial-Times/n-teaser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/n-teaser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/n-teaser/teams","hooks_url":"https://api.github.com/repos/Financial-Times/n-teaser/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/n-teaser/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/n-teaser/events","assignees_url":"https://api.github.com/repos/Financial-Times/n-teaser/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/n-teaser/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/n-teaser/tags","blobs_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/n-teaser/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/n-teaser/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/n-teaser/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/n-teaser/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/n-teaser/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/n-teaser/subscription","commits_url":"https://api.github.com/repos/Financial-Times/n-teaser/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/n-teaser/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/n-teaser/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/n-teaser/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/n-teaser/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/n-teaser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/n-teaser/merges","archive_url":"https://api.github.com/repos/Financial-Times/n-teaser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/n-teaser/downloads","issues_url":"https://api.github.com/repos/Financial-Times/n-teaser/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/n-teaser/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/n-teaser/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/n-teaser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/n-teaser/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/n-teaser/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/n-teaser/deployments","created_at":"2016-10-13T14:35:10Z","updated_at":"2016-12-02T11:01:48Z","pushed_at":"2017-04-21T14:12:27Z","git_url":"git://github.com/Financial-Times/n-teaser.git","ssh_url":"git@github.com:Financial-Times/n-teaser.git","clone_url":"https://github.com/Financial-Times/n-teaser.git","svn_url":"https://github.com/Financial-Times/n-teaser","homepage":"","size":197,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/107"},"html":{"href":"https://github.com/Financial-Times/n-teaser/pull/107"},"issue":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/issues/107"},"comments":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/n-teaser/statuses/ae29f4e1d034c138706ff70225b4f14bd7b1514a"}}}}
{"actor":{"display_login":"andygnewman"}}