{"action":"created","comment":{"url":"https://api.github.com/repos/mobxjs/mobx/pulls/comments/97356742","pull_request_review_id":17963262,"id":97356742,"diff_hunk":"@@ -0,0 +1,45 @@\n+const messages = {\n+\"m001\" : \"It is not allowed to assign new values to @action fields\" ,\n+\"m002\" : \"`runInAction` expects a function\" ,\n+\"m003\" : \"`runInAction` expects a function without arguments\" ,\n+\"m004\" : \"autorun expects a function\" ,\n+\"m005\" : \"Warning: attempted to pass an action to autorun. Actions are untracked and will not trigger on state changes. Use `reaction` or wrap only your state modification code in an action.\" ,\n+\"m006\" : \"Warning: attempted to pass an action to autorunAsync. Actions are untracked and will not trigger on state changes. Use `reaction` or wrap only your state modification code in an action.\" ,\n+\"m007\" : \"reaction only accepts 2 or 3 arguments. If migrating from MobX 2, please provide an options object\" ,\n+\"m008\" : \"wrapping reaction expression in `asReference` is no longer supported, use options object instead\" ,\n+\"m009\" : \"@computed can only be used on getter functions, like: '@computed get myProps() { return ...; }'. It looks like it was used on a property.\" ,\n+\"m010\" : \"@computed can only be used on getter functions, like: '@computed get myProps() { return ...; }'\" ,\n+\"m011\" : \"First argument to `computed` should be an expression. If using computed as decorator, don't pass it arguments\" ,\n+\"m012\" : \"computed takes one or two arguments if used as function\" ,\n+\"m013\" : \"[mobx.expr] 'expr' should only be used inside other reactive functions.\" ,\n+\"m014\" : \"extendObservable expected 2 or more arguments\" ,\n+\"m015\" : \"extendObservable expects an object as first argument\" ,\n+\"m016\" : \"extendObservable should not be used on maps, use map.merge instead\" ,\n+\"m017\" : \"all arguments of extendObservable should be objects\" ,\n+\"m018\" : \"extending an object with another observable (object) is not supported. Please construct an explicit propertymap, using `toJS` if need. See issue #540\" ,\n+\"m019\" : \"[mobx.isObservable] isObservable(object, propertyName) is not supported for arrays and maps. Use map.has or array.length instead.\" ,\n+\"m020\" : \"modifiers can only be used for individual object properties\" ,\n+\"m021\" : \"observable expects zero or one arguments\" ,\n+\"m022\" : \"@observable can not be used on getters, use @computed instead\" ,\n+\"m023\" : \"Using `transaction` is deprecated, use `runInAction` or `(@)action` instead.\" ,\n+\"m024\" : \"whyRun() can only be used if a derivation is active, or by passing an computed value / reaction explicitly. If you invoked whyRun from inside a computation; the computation is currently suspended but re-evaluating because somebody requested its value.\" ,\n+\"m025\" : \"whyRun can only be used on reactions and computed values\" ,\n+\"m026\" : \"`action` can only be invoked on functions\" ,\n+\"m027\" : \"Computed values or transformers should not invoke actions or trigger other side effects\" ,\n+\"m028\" : \"It is not allowed to set `useStrict` when a derivation is running\" ,\n+\"m029\" : \"INTERNAL ERROR only onBecomeUnobserved shouldn't be called twice in a row\" ,\n+\"m030\" : \"It is not allowed to create or change state outside an `action` when MobX is in strict mode. Wrap the current method in `action` if this state change is intended\" ,\n+\"m031\" : \"It is not allowed to change the state when a computed value or transformer is being evaluated. Use 'autorun' to create reactive functions with side-effects.\" ,\n+\"m032\" : \"* This computation is suspended (not in use by any reaction) and won't run automatically.\\n\tDidn't expect this computation to be suspended at this point?\\n\t  1. Make sure this computation is used by a reaction (reaction, autorun, observer).\\n\t  2. Check whether you are using this computation synchronously (in the same stack as they reaction that needs it).\",\n+\"m033\" : \"`observe` doesn't support the fire immediately property for observable maps.\" ,\n+\"m034\" : \"`mobx.map` is deprecated, use `new ObservableMap` or `mobx.observable.map` instead\" ,\n+\"m035\" : \"Cannot make the designated object observable; it is not extensible\" ,\n+\"m036\" : \"It is not possible to get index atoms from arrays\" ,\n+\"m037\" : \"\\nHi there! I'm sorry you have just run into an exception.\\n\\nIf your debugger ends up here, know that some reaction (like the render() of an observer component, autorun or reaction)\\nthrew an exception and that mobx caught it, to avoid that it brings the rest of your application down.\\nThe original cause of the exception (the code that caused this reaction to run (again)), is still in the stack.\\n\\n\t\tHowever, more interesting is the actual stack trace of the error itself.\\n\t\tHopefully the error is an instanceof Error, because in that case you can inspect the original stack of the error from where it was thrown.\\n\t\tSee \\`error.stack\\` property, or press the very subtle \\\"(...)\\\" link you see near the console.error message that probably brought you here.\\n\t\tThat stack is more interesting than the stack of this console.error itself.\\n\\n\t\tIf the exception you see is an exception you created yourself, make sure to use \\`throw new Error(\\\"Oops\\\")\\` instead of \\`throw \\\"Oops\\\"\\`,\\n\t\tbecause the javascript environment will only preserve the original stack trace in the first form.\\n\\n\t\tYou can also make sure the debugger pauses the next time this very same exception is thrown by enabling \\\"Pause on caught exception\\\".\\n\t\t(Note that it might pause on many other, unrelated exception as well).\\n\\n\t\tIf that all doesn't help you out, feel free to open an issue https://github.com/mobxjs/mobx/issues!\\n\",\n+\"m038\" : \"Missing items in this list?\\n\t  1. Check whether all used values are properly marked as observable (use isObservable to verify)\\n\t  2. Make sure you didn't dereference values too early. MobX observes props, not primitives. E.g: use 'person.name' instead of 'name' in your computation.\",\n+\n+}\n+\n+export function getMessage(id : string) {\n+\treturn messages[id];\n+};","path":"src/utils/messages.ts","position":44,"original_position":45,"commit_id":"9f8cdab77d19b86da6af401c86b0212d1e413c8c","original_commit_id":"ac9aaac54b5dccae2e4e6816c6ec152a841ada56","user":{"login":"reisel","id":15262287,"avatar_url":"https://avatars.githubusercontent.com/u/15262287?v=3","gravatar_id":"","url":"https://api.github.com/users/reisel","html_url":"https://github.com/reisel","followers_url":"https://api.github.com/users/reisel/followers","following_url":"https://api.github.com/users/reisel/following{/other_user}","gists_url":"https://api.github.com/users/reisel/gists{/gist_id}","starred_url":"https://api.github.com/users/reisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reisel/subscriptions","organizations_url":"https://api.github.com/users/reisel/orgs","repos_url":"https://api.github.com/users/reisel/repos","events_url":"https://api.github.com/users/reisel/events{/privacy}","received_events_url":"https://api.github.com/users/reisel/received_events","type":"User","site_admin":false},"body":"where?","created_at":"2017-01-23T16:27:56Z","updated_at":"2017-01-23T16:27:56Z","html_url":"https://github.com/mobxjs/mobx/pull/783#discussion_r97356742","pull_request_url":"https://api.github.com/repos/mobxjs/mobx/pulls/783","_links":{"self":{"href":"https://api.github.com/repos/mobxjs/mobx/pulls/comments/97356742"},"html":{"href":"https://github.com/mobxjs/mobx/pull/783#discussion_r97356742"},"pull_request":{"href":"https://api.github.com/repos/mobxjs/mobx/pulls/783"}}},"pull_request":{"url":"https://api.github.com/repos/mobxjs/mobx/pulls/783","id":102420939,"html_url":"https://github.com/mobxjs/mobx/pull/783","diff_url":"https://github.com/mobxjs/mobx/pull/783.diff","patch_url":"https://github.com/mobxjs/mobx/pull/783.patch","issue_url":"https://api.github.com/repos/mobxjs/mobx/issues/783","number":783,"state":"open","locked":false,"title":"Extract messages to separate file #GoodnessSquad","user":{"login":"reisel","id":15262287,"avatar_url":"https://avatars.githubusercontent.com/u/15262287?v=3","gravatar_id":"","url":"https://api.github.com/users/reisel","html_url":"https://github.com/reisel","followers_url":"https://api.github.com/users/reisel/followers","following_url":"https://api.github.com/users/reisel/following{/other_user}","gists_url":"https://api.github.com/users/reisel/gists{/gist_id}","starred_url":"https://api.github.com/users/reisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reisel/subscriptions","organizations_url":"https://api.github.com/users/reisel/orgs","repos_url":"https://api.github.com/users/reisel/repos","events_url":"https://api.github.com/users/reisel/events{/privacy}","received_events_url":"https://api.github.com/users/reisel/received_events","type":"User","site_admin":false},"body":"First stage of issue: #653 \r\nI've extracted messages to a separate file in order to substitute them in the production build.\r\nextracted 5.8kb of data.\r\n","created_at":"2017-01-20T08:27:31Z","updated_at":"2017-01-23T16:27:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"504f2f843dd1ccf9d9d0cc92ae5f78d1ab0010a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mobxjs/mobx/pulls/783/commits","review_comments_url":"https://api.github.com/repos/mobxjs/mobx/pulls/783/comments","review_comment_url":"https://api.github.com/repos/mobxjs/mobx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobxjs/mobx/issues/783/comments","statuses_url":"https://api.github.com/repos/mobxjs/mobx/statuses/9f8cdab77d19b86da6af401c86b0212d1e413c8c","head":{"label":"reisel:extractMessages","ref":"extractMessages","sha":"9f8cdab77d19b86da6af401c86b0212d1e413c8c","user":{"login":"reisel","id":15262287,"avatar_url":"https://avatars.githubusercontent.com/u/15262287?v=3","gravatar_id":"","url":"https://api.github.com/users/reisel","html_url":"https://github.com/reisel","followers_url":"https://api.github.com/users/reisel/followers","following_url":"https://api.github.com/users/reisel/following{/other_user}","gists_url":"https://api.github.com/users/reisel/gists{/gist_id}","starred_url":"https://api.github.com/users/reisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reisel/subscriptions","organizations_url":"https://api.github.com/users/reisel/orgs","repos_url":"https://api.github.com/users/reisel/repos","events_url":"https://api.github.com/users/reisel/events{/privacy}","received_events_url":"https://api.github.com/users/reisel/received_events","type":"User","site_admin":false},"repo":{"id":79505591,"name":"mobx","full_name":"reisel/mobx","owner":{"login":"reisel","id":15262287,"avatar_url":"https://avatars.githubusercontent.com/u/15262287?v=3","gravatar_id":"","url":"https://api.github.com/users/reisel","html_url":"https://github.com/reisel","followers_url":"https://api.github.com/users/reisel/followers","following_url":"https://api.github.com/users/reisel/following{/other_user}","gists_url":"https://api.github.com/users/reisel/gists{/gist_id}","starred_url":"https://api.github.com/users/reisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reisel/subscriptions","organizations_url":"https://api.github.com/users/reisel/orgs","repos_url":"https://api.github.com/users/reisel/repos","events_url":"https://api.github.com/users/reisel/events{/privacy}","received_events_url":"https://api.github.com/users/reisel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reisel/mobx","description":"Simple, scalable state management.","fork":true,"url":"https://api.github.com/repos/reisel/mobx","forks_url":"https://api.github.com/repos/reisel/mobx/forks","keys_url":"https://api.github.com/repos/reisel/mobx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reisel/mobx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reisel/mobx/teams","hooks_url":"https://api.github.com/repos/reisel/mobx/hooks","issue_events_url":"https://api.github.com/repos/reisel/mobx/issues/events{/number}","events_url":"https://api.github.com/repos/reisel/mobx/events","assignees_url":"https://api.github.com/repos/reisel/mobx/assignees{/user}","branches_url":"https://api.github.com/repos/reisel/mobx/branches{/branch}","tags_url":"https://api.github.com/repos/reisel/mobx/tags","blobs_url":"https://api.github.com/repos/reisel/mobx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reisel/mobx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reisel/mobx/git/refs{/sha}","trees_url":"https://api.github.com/repos/reisel/mobx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reisel/mobx/statuses/{sha}","languages_url":"https://api.github.com/repos/reisel/mobx/languages","stargazers_url":"https://api.github.com/repos/reisel/mobx/stargazers","contributors_url":"https://api.github.com/repos/reisel/mobx/contributors","subscribers_url":"https://api.github.com/repos/reisel/mobx/subscribers","subscription_url":"https://api.github.com/repos/reisel/mobx/subscription","commits_url":"https://api.github.com/repos/reisel/mobx/commits{/sha}","git_commits_url":"https://api.github.com/repos/reisel/mobx/git/commits{/sha}","comments_url":"https://api.github.com/repos/reisel/mobx/comments{/number}","issue_comment_url":"https://api.github.com/repos/reisel/mobx/issues/comments{/number}","contents_url":"https://api.github.com/repos/reisel/mobx/contents/{+path}","compare_url":"https://api.github.com/repos/reisel/mobx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reisel/mobx/merges","archive_url":"https://api.github.com/repos/reisel/mobx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reisel/mobx/downloads","issues_url":"https://api.github.com/repos/reisel/mobx/issues{/number}","pulls_url":"https://api.github.com/repos/reisel/mobx/pulls{/number}","milestones_url":"https://api.github.com/repos/reisel/mobx/milestones{/number}","notifications_url":"https://api.github.com/repos/reisel/mobx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reisel/mobx/labels{/name}","releases_url":"https://api.github.com/repos/reisel/mobx/releases{/id}","deployments_url":"https://api.github.com/repos/reisel/mobx/deployments","created_at":"2017-01-19T23:29:58Z","updated_at":"2017-01-19T23:30:01Z","pushed_at":"2017-01-23T16:27:21Z","git_url":"git://github.com/reisel/mobx.git","ssh_url":"git@github.com:reisel/mobx.git","clone_url":"https://github.com/reisel/mobx.git","svn_url":"https://github.com/reisel/mobx","homepage":"https://mobx.js.org","size":13470,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mobxjs:master","ref":"master","sha":"568b1af5637874eee0493f889a6409206ec970cd","user":{"login":"mobxjs","id":17475736,"avatar_url":"https://avatars.githubusercontent.com/u/17475736?v=3","gravatar_id":"","url":"https://api.github.com/users/mobxjs","html_url":"https://github.com/mobxjs","followers_url":"https://api.github.com/users/mobxjs/followers","following_url":"https://api.github.com/users/mobxjs/following{/other_user}","gists_url":"https://api.github.com/users/mobxjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mobxjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobxjs/subscriptions","organizations_url":"https://api.github.com/users/mobxjs/orgs","repos_url":"https://api.github.com/users/mobxjs/repos","events_url":"https://api.github.com/users/mobxjs/events{/privacy}","received_events_url":"https://api.github.com/users/mobxjs/received_events","type":"Organization","site_admin":false},"repo":{"id":32215970,"name":"mobx","full_name":"mobxjs/mobx","owner":{"login":"mobxjs","id":17475736,"avatar_url":"https://avatars.githubusercontent.com/u/17475736?v=3","gravatar_id":"","url":"https://api.github.com/users/mobxjs","html_url":"https://github.com/mobxjs","followers_url":"https://api.github.com/users/mobxjs/followers","following_url":"https://api.github.com/users/mobxjs/following{/other_user}","gists_url":"https://api.github.com/users/mobxjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mobxjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobxjs/subscriptions","organizations_url":"https://api.github.com/users/mobxjs/orgs","repos_url":"https://api.github.com/users/mobxjs/repos","events_url":"https://api.github.com/users/mobxjs/events{/privacy}","received_events_url":"https://api.github.com/users/mobxjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobxjs/mobx","description":"Simple, scalable state management.","fork":false,"url":"https://api.github.com/repos/mobxjs/mobx","forks_url":"https://api.github.com/repos/mobxjs/mobx/forks","keys_url":"https://api.github.com/repos/mobxjs/mobx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobxjs/mobx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobxjs/mobx/teams","hooks_url":"https://api.github.com/repos/mobxjs/mobx/hooks","issue_events_url":"https://api.github.com/repos/mobxjs/mobx/issues/events{/number}","events_url":"https://api.github.com/repos/mobxjs/mobx/events","assignees_url":"https://api.github.com/repos/mobxjs/mobx/assignees{/user}","branches_url":"https://api.github.com/repos/mobxjs/mobx/branches{/branch}","tags_url":"https://api.github.com/repos/mobxjs/mobx/tags","blobs_url":"https://api.github.com/repos/mobxjs/mobx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobxjs/mobx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobxjs/mobx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobxjs/mobx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobxjs/mobx/statuses/{sha}","languages_url":"https://api.github.com/repos/mobxjs/mobx/languages","stargazers_url":"https://api.github.com/repos/mobxjs/mobx/stargazers","contributors_url":"https://api.github.com/repos/mobxjs/mobx/contributors","subscribers_url":"https://api.github.com/repos/mobxjs/mobx/subscribers","subscription_url":"https://api.github.com/repos/mobxjs/mobx/subscription","commits_url":"https://api.github.com/repos/mobxjs/mobx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobxjs/mobx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobxjs/mobx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobxjs/mobx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobxjs/mobx/contents/{+path}","compare_url":"https://api.github.com/repos/mobxjs/mobx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobxjs/mobx/merges","archive_url":"https://api.github.com/repos/mobxjs/mobx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobxjs/mobx/downloads","issues_url":"https://api.github.com/repos/mobxjs/mobx/issues{/number}","pulls_url":"https://api.github.com/repos/mobxjs/mobx/pulls{/number}","milestones_url":"https://api.github.com/repos/mobxjs/mobx/milestones{/number}","notifications_url":"https://api.github.com/repos/mobxjs/mobx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobxjs/mobx/labels{/name}","releases_url":"https://api.github.com/repos/mobxjs/mobx/releases{/id}","deployments_url":"https://api.github.com/repos/mobxjs/mobx/deployments","created_at":"2015-03-14T14:31:38Z","updated_at":"2017-01-23T14:34:52Z","pushed_at":"2017-01-23T16:27:23Z","git_url":"git://github.com/mobxjs/mobx.git","ssh_url":"git@github.com:mobxjs/mobx.git","clone_url":"https://github.com/mobxjs/mobx.git","svn_url":"https://github.com/mobxjs/mobx","homepage":"https://mobx.js.org","size":13494,"stargazers_count":6923,"watchers_count":6923,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":320,"mirror_url":null,"open_issues_count":38,"forks":320,"open_issues":38,"watchers":6923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mobxjs/mobx/pulls/783"},"html":{"href":"https://github.com/mobxjs/mobx/pull/783"},"issue":{"href":"https://api.github.com/repos/mobxjs/mobx/issues/783"},"comments":{"href":"https://api.github.com/repos/mobxjs/mobx/issues/783/comments"},"review_comments":{"href":"https://api.github.com/repos/mobxjs/mobx/pulls/783/comments"},"review_comment":{"href":"https://api.github.com/repos/mobxjs/mobx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobxjs/mobx/pulls/783/commits"},"statuses":{"href":"https://api.github.com/repos/mobxjs/mobx/statuses/9f8cdab77d19b86da6af401c86b0212d1e413c8c"}}}}
{"actor":{"display_login":"reisel"}}