{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/16303","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/16303/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/16303/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/16303/events","html_url":"https://github.com/edx/edx-platform/pull/16303","id":267473660,"number":16303,"title":"[ENT-671] Show the Enterprise tagline on the logistration page.","user":{"login":"UmanShahzad","id":10018065,"avatar_url":"https://avatars0.githubusercontent.com/u/10018065?v=4","gravatar_id":"","url":"https://api.github.com/users/UmanShahzad","html_url":"https://github.com/UmanShahzad","followers_url":"https://api.github.com/users/UmanShahzad/followers","following_url":"https://api.github.com/users/UmanShahzad/following{/other_user}","gists_url":"https://api.github.com/users/UmanShahzad/gists{/gist_id}","starred_url":"https://api.github.com/users/UmanShahzad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmanShahzad/subscriptions","organizations_url":"https://api.github.com/users/UmanShahzad/orgs","repos_url":"https://api.github.com/users/UmanShahzad/repos","events_url":"https://api.github.com/users/UmanShahzad/events{/privacy}","received_events_url":"https://api.github.com/users/UmanShahzad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"UmanShahzad","id":10018065,"avatar_url":"https://avatars0.githubusercontent.com/u/10018065?v=4","gravatar_id":"","url":"https://api.github.com/users/UmanShahzad","html_url":"https://github.com/UmanShahzad","followers_url":"https://api.github.com/users/UmanShahzad/followers","following_url":"https://api.github.com/users/UmanShahzad/following{/other_user}","gists_url":"https://api.github.com/users/UmanShahzad/gists{/gist_id}","starred_url":"https://api.github.com/users/UmanShahzad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmanShahzad/subscriptions","organizations_url":"https://api.github.com/users/UmanShahzad/orgs","repos_url":"https://api.github.com/users/UmanShahzad/repos","events_url":"https://api.github.com/users/UmanShahzad/events{/privacy}","received_events_url":"https://api.github.com/users/UmanShahzad/received_events","type":"User","site_admin":false},"assignees":[{"login":"UmanShahzad","id":10018065,"avatar_url":"https://avatars0.githubusercontent.com/u/10018065?v=4","gravatar_id":"","url":"https://api.github.com/users/UmanShahzad","html_url":"https://github.com/UmanShahzad","followers_url":"https://api.github.com/users/UmanShahzad/followers","following_url":"https://api.github.com/users/UmanShahzad/following{/other_user}","gists_url":"https://api.github.com/users/UmanShahzad/gists{/gist_id}","starred_url":"https://api.github.com/users/UmanShahzad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UmanShahzad/subscriptions","organizations_url":"https://api.github.com/users/UmanShahzad/orgs","repos_url":"https://api.github.com/users/UmanShahzad/repos","events_url":"https://api.github.com/users/UmanShahzad/events{/privacy}","received_events_url":"https://api.github.com/users/UmanShahzad/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-10-22T15:24:35Z","updated_at":"2017-10-24T13:30:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/16303","html_url":"https://github.com/edx/edx-platform/pull/16303","diff_url":"https://github.com/edx/edx-platform/pull/16303.diff","patch_url":"https://github.com/edx/edx-platform/pull/16303.patch"},"body":"This makes sure the enterprise tagline renders on the logistration page as well. Previously it was rendering only on the course/program enrollment landing pages and the DSC page, but those are on separate code bases, so we needed a separate PR for the logistration page.\r\n\r\n**JIRA tickets**: [ENT-671](https://openedx.atlassian.net/browse/ENT-671)\r\n\r\n**Dependencies**: None\r\n\r\n**Screenshots**: TBD\r\n\r\n**Sandbox URL**: TBD - sandbox is being provisioned.\r\n\r\n**Merge deadline**: End of sprint.\r\n\r\n**Testing instructions**:\r\n\r\n1. Go into incognito.\r\n1. Attempt to go to the course enrollment landing page for some enterprise customer for whom the registration page still shows up (Aviato/Pied Piper?).\r\n1. When redirected to the registration page with the enterprise sidebar, ensure you also see the enterprise tagline at the top next to the logo.\r\n1. Make your browser's screen size smaller and smaller and ensure the tagline renders well with the logo at all possible screen sizes, including mobile-level.\r\n\r\n**Settings**\r\n```yaml\r\nENTERPRISE_TAGLINE: 'Yes, this is the tagline.'\r\nEDXAPP_FEATURES:\r\n  ENABLE_COMBINED_LOGIN_REGISTRATION: true\r\n```"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/338990327","html_url":"https://github.com/edx/edx-platform/pull/16303#issuecomment-338990327","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/16303","id":338990327,"user":{"login":"HarryRein","id":3861052,"avatar_url":"https://avatars1.githubusercontent.com/u/3861052?v=4","gravatar_id":"","url":"https://api.github.com/users/HarryRein","html_url":"https://github.com/HarryRein","followers_url":"https://api.github.com/users/HarryRein/followers","following_url":"https://api.github.com/users/HarryRein/following{/other_user}","gists_url":"https://api.github.com/users/HarryRein/gists{/gist_id}","starred_url":"https://api.github.com/users/HarryRein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarryRein/subscriptions","organizations_url":"https://api.github.com/users/HarryRein/orgs","repos_url":"https://api.github.com/users/HarryRein/repos","events_url":"https://api.github.com/users/HarryRein/events{/privacy}","received_events_url":"https://api.github.com/users/HarryRein/received_events","type":"User","site_admin":false},"created_at":"2017-10-24T13:30:18Z","updated_at":"2017-10-24T13:30:18Z","author_association":"MEMBER","body":"@UmanShahzad , you are right that the login registration page is not bootstrap so this change isn't necessary, but in general moving forward be sure to check both the bootstrap and the general folder.\r\n\r\nHowever, per the previous comment, if you have a header/navbar-logo-header.html, be sure to add it there."}}
{"actor":{"display_login":"HarryRein"}}