{"action":"created","comment":{"url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/comments/106827356","pull_request_review_id":27766596,"id":106827356,"diff_hunk":"@@ -0,0 +1,13 @@\n+{\n+  \"compilerOptions\": {\n+    \"target\": \"es6\",","path":"tsconfig.json","position":null,"original_position":3,"commit_id":"6cc51d8a7579b185fa4c0274458caf99c1c79a17","original_commit_id":"ad880eba1469f0c3c3479bec7520a2a542e051a5","user":{"login":"plusjamal","id":26446507,"avatar_url":"https://avatars1.githubusercontent.com/u/26446507?v=3","gravatar_id":"","url":"https://api.github.com/users/plusjamal","html_url":"https://github.com/plusjamal","followers_url":"https://api.github.com/users/plusjamal/followers","following_url":"https://api.github.com/users/plusjamal/following{/other_user}","gists_url":"https://api.github.com/users/plusjamal/gists{/gist_id}","starred_url":"https://api.github.com/users/plusjamal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plusjamal/subscriptions","organizations_url":"https://api.github.com/users/plusjamal/orgs","repos_url":"https://api.github.com/users/plusjamal/repos","events_url":"https://api.github.com/users/plusjamal/events{/privacy}","received_events_url":"https://api.github.com/users/plusjamal/received_events","type":"User","site_admin":false},"body":"Can we also include:\r\n\"noImplicitAny\": true,\r\n\"noImplicitReturns\": true,\r\n\"strictNullChecks\": true\r\n\r\nI think these are good to increase compile time safety.  You can read about the options here and tell me if you agree:\r\nhttps://www.typescriptlang.org/docs/handbook/compiler-options.html","created_at":"2017-03-20T02:06:44Z","updated_at":"2017-03-20T02:30:11Z","html_url":"https://github.com/projectprayerwall/projectprayerwall/pull/2#discussion_r106827356","pull_request_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/comments/106827356"},"html":{"href":"https://github.com/projectprayerwall/projectprayerwall/pull/2#discussion_r106827356"},"pull_request":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/2","id":111315260,"html_url":"https://github.com/projectprayerwall/projectprayerwall/pull/2","diff_url":"https://github.com/projectprayerwall/projectprayerwall/pull/2.diff","patch_url":"https://github.com/projectprayerwall/projectprayerwall/pull/2.patch","issue_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues/2","number":2,"state":"open","locked":false,"title":"Reset","user":{"login":"Gander7","id":4229134,"avatar_url":"https://avatars0.githubusercontent.com/u/4229134?v=3","gravatar_id":"","url":"https://api.github.com/users/Gander7","html_url":"https://github.com/Gander7","followers_url":"https://api.github.com/users/Gander7/followers","following_url":"https://api.github.com/users/Gander7/following{/other_user}","gists_url":"https://api.github.com/users/Gander7/gists{/gist_id}","starred_url":"https://api.github.com/users/Gander7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gander7/subscriptions","organizations_url":"https://api.github.com/users/Gander7/orgs","repos_url":"https://api.github.com/users/Gander7/repos","events_url":"https://api.github.com/users/Gander7/events{/privacy}","received_events_url":"https://api.github.com/users/Gander7/received_events","type":"User","site_admin":false},"body":"Another reset of the project but created from scratch instead of from visual studio. \r\nI this [tutorial ](http://mherman.org/blog/2016/11/05/developing-a-restful-api-with-node-and-typescript/#.WMvAB_nyuUk) as a base. I encourage you to work through it yourself if you have the time, except the mocha script in package.json is broken so use mine.\r\n\r\nI also added comments for as many files as I could to explain the reasons for them.\r\nI added a comments key:value in package.json and tsconfig.json to make comments about those specific files since json doesn't not allow comments.\r\n\r\nStill missing:\r\n- user interface, currently returning json \r\n- a database, currenlty using hardcoded data.json\r\n- automated testing, has automated typescript compilation and manual testing\r\n- removal of superhero samples\r\n- addition of what we will actually do\r\n\r\nwe have to chill or talk at some point a figure out where we are going or what is the first step :P","created_at":"2017-03-17T16:15:32Z","updated_at":"2017-03-20T02:30:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e31764648ee63dfdcffb5b9b8c5c53de11bb849b","assignee":{"login":"Gander7","id":4229134,"avatar_url":"https://avatars0.githubusercontent.com/u/4229134?v=3","gravatar_id":"","url":"https://api.github.com/users/Gander7","html_url":"https://github.com/Gander7","followers_url":"https://api.github.com/users/Gander7/followers","following_url":"https://api.github.com/users/Gander7/following{/other_user}","gists_url":"https://api.github.com/users/Gander7/gists{/gist_id}","starred_url":"https://api.github.com/users/Gander7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gander7/subscriptions","organizations_url":"https://api.github.com/users/Gander7/orgs","repos_url":"https://api.github.com/users/Gander7/repos","events_url":"https://api.github.com/users/Gander7/events{/privacy}","received_events_url":"https://api.github.com/users/Gander7/received_events","type":"User","site_admin":false},"assignees":[{"login":"Gander7","id":4229134,"avatar_url":"https://avatars0.githubusercontent.com/u/4229134?v=3","gravatar_id":"","url":"https://api.github.com/users/Gander7","html_url":"https://github.com/Gander7","followers_url":"https://api.github.com/users/Gander7/followers","following_url":"https://api.github.com/users/Gander7/following{/other_user}","gists_url":"https://api.github.com/users/Gander7/gists{/gist_id}","starred_url":"https://api.github.com/users/Gander7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gander7/subscriptions","organizations_url":"https://api.github.com/users/Gander7/orgs","repos_url":"https://api.github.com/users/Gander7/repos","events_url":"https://api.github.com/users/Gander7/events{/privacy}","received_events_url":"https://api.github.com/users/Gander7/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/2/commits","review_comments_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/2/comments","review_comment_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues/2/comments","statuses_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/statuses/6cc51d8a7579b185fa4c0274458caf99c1c79a17","head":{"label":"projectprayerwall:reset","ref":"reset","sha":"6cc51d8a7579b185fa4c0274458caf99c1c79a17","user":{"login":"projectprayerwall","id":26447781,"avatar_url":"https://avatars3.githubusercontent.com/u/26447781?v=3","gravatar_id":"","url":"https://api.github.com/users/projectprayerwall","html_url":"https://github.com/projectprayerwall","followers_url":"https://api.github.com/users/projectprayerwall/followers","following_url":"https://api.github.com/users/projectprayerwall/following{/other_user}","gists_url":"https://api.github.com/users/projectprayerwall/gists{/gist_id}","starred_url":"https://api.github.com/users/projectprayerwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectprayerwall/subscriptions","organizations_url":"https://api.github.com/users/projectprayerwall/orgs","repos_url":"https://api.github.com/users/projectprayerwall/repos","events_url":"https://api.github.com/users/projectprayerwall/events{/privacy}","received_events_url":"https://api.github.com/users/projectprayerwall/received_events","type":"Organization","site_admin":false},"repo":{"id":85214000,"name":"projectprayerwall","full_name":"projectprayerwall/projectprayerwall","owner":{"login":"projectprayerwall","id":26447781,"avatar_url":"https://avatars3.githubusercontent.com/u/26447781?v=3","gravatar_id":"","url":"https://api.github.com/users/projectprayerwall","html_url":"https://github.com/projectprayerwall","followers_url":"https://api.github.com/users/projectprayerwall/followers","following_url":"https://api.github.com/users/projectprayerwall/following{/other_user}","gists_url":"https://api.github.com/users/projectprayerwall/gists{/gist_id}","starred_url":"https://api.github.com/users/projectprayerwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectprayerwall/subscriptions","organizations_url":"https://api.github.com/users/projectprayerwall/orgs","repos_url":"https://api.github.com/users/projectprayerwall/repos","events_url":"https://api.github.com/users/projectprayerwall/events{/privacy}","received_events_url":"https://api.github.com/users/projectprayerwall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectprayerwall/projectprayerwall","description":"Project to create a real time prayer wall so users can submit prayer requests or pray for others.","fork":false,"url":"https://api.github.com/repos/projectprayerwall/projectprayerwall","forks_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/forks","keys_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/teams","hooks_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/hooks","issue_events_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues/events{/number}","events_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/events","assignees_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/assignees{/user}","branches_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/branches{/branch}","tags_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/tags","blobs_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/statuses/{sha}","languages_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/languages","stargazers_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/stargazers","contributors_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/contributors","subscribers_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/subscribers","subscription_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/subscription","commits_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/contents/{+path}","compare_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/merges","archive_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/downloads","issues_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues{/number}","pulls_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls{/number}","milestones_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/milestones{/number}","notifications_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/labels{/name}","releases_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/releases{/id}","deployments_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/deployments","created_at":"2017-03-16T15:50:17Z","updated_at":"2017-03-17T00:14:52Z","pushed_at":"2017-03-17T16:43:09Z","git_url":"git://github.com/projectprayerwall/projectprayerwall.git","ssh_url":"git@github.com:projectprayerwall/projectprayerwall.git","clone_url":"https://github.com/projectprayerwall/projectprayerwall.git","svn_url":"https://github.com/projectprayerwall/projectprayerwall","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"projectprayerwall:master","ref":"master","sha":"e282aca9cd87c648aa3bbf23d089d34e14d87608","user":{"login":"projectprayerwall","id":26447781,"avatar_url":"https://avatars3.githubusercontent.com/u/26447781?v=3","gravatar_id":"","url":"https://api.github.com/users/projectprayerwall","html_url":"https://github.com/projectprayerwall","followers_url":"https://api.github.com/users/projectprayerwall/followers","following_url":"https://api.github.com/users/projectprayerwall/following{/other_user}","gists_url":"https://api.github.com/users/projectprayerwall/gists{/gist_id}","starred_url":"https://api.github.com/users/projectprayerwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectprayerwall/subscriptions","organizations_url":"https://api.github.com/users/projectprayerwall/orgs","repos_url":"https://api.github.com/users/projectprayerwall/repos","events_url":"https://api.github.com/users/projectprayerwall/events{/privacy}","received_events_url":"https://api.github.com/users/projectprayerwall/received_events","type":"Organization","site_admin":false},"repo":{"id":85214000,"name":"projectprayerwall","full_name":"projectprayerwall/projectprayerwall","owner":{"login":"projectprayerwall","id":26447781,"avatar_url":"https://avatars3.githubusercontent.com/u/26447781?v=3","gravatar_id":"","url":"https://api.github.com/users/projectprayerwall","html_url":"https://github.com/projectprayerwall","followers_url":"https://api.github.com/users/projectprayerwall/followers","following_url":"https://api.github.com/users/projectprayerwall/following{/other_user}","gists_url":"https://api.github.com/users/projectprayerwall/gists{/gist_id}","starred_url":"https://api.github.com/users/projectprayerwall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectprayerwall/subscriptions","organizations_url":"https://api.github.com/users/projectprayerwall/orgs","repos_url":"https://api.github.com/users/projectprayerwall/repos","events_url":"https://api.github.com/users/projectprayerwall/events{/privacy}","received_events_url":"https://api.github.com/users/projectprayerwall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectprayerwall/projectprayerwall","description":"Project to create a real time prayer wall so users can submit prayer requests or pray for others.","fork":false,"url":"https://api.github.com/repos/projectprayerwall/projectprayerwall","forks_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/forks","keys_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/teams","hooks_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/hooks","issue_events_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues/events{/number}","events_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/events","assignees_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/assignees{/user}","branches_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/branches{/branch}","tags_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/tags","blobs_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/statuses/{sha}","languages_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/languages","stargazers_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/stargazers","contributors_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/contributors","subscribers_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/subscribers","subscription_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/subscription","commits_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/contents/{+path}","compare_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/merges","archive_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/downloads","issues_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues{/number}","pulls_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls{/number}","milestones_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/milestones{/number}","notifications_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/labels{/name}","releases_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/releases{/id}","deployments_url":"https://api.github.com/repos/projectprayerwall/projectprayerwall/deployments","created_at":"2017-03-16T15:50:17Z","updated_at":"2017-03-17T00:14:52Z","pushed_at":"2017-03-17T16:43:09Z","git_url":"git://github.com/projectprayerwall/projectprayerwall.git","ssh_url":"git@github.com:projectprayerwall/projectprayerwall.git","clone_url":"https://github.com/projectprayerwall/projectprayerwall.git","svn_url":"https://github.com/projectprayerwall/projectprayerwall","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/2"},"html":{"href":"https://github.com/projectprayerwall/projectprayerwall/pull/2"},"issue":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues/2"},"comments":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/projectprayerwall/projectprayerwall/statuses/6cc51d8a7579b185fa4c0274458caf99c1c79a17"}}}}
{"actor":{"display_login":"plusjamal"}}