{"action":"created","comment":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments/128780130","pull_request_review_id":51495358,"id":128780130,"diff_hunk":"@@ -0,0 +1,26 @@\n+#!/bin/sh\n+# SUMMARY: Check that the format and mount packages work\n+# LABELS:\n+# REPEAT:\n+\n+set -e\n+\n+# Source libraries. Uncomment if needed/defined\n+#. \"${RT_LIB}\"\n+. \"${RT_PROJECT_ROOT}/_lib/lib.sh\"\n+\n+NAME=test-format\n+\n+clean_up() {\n+\tfind . -depth -iname \"${NAME}*\" -not -iname \"*.yml\" -exec rm -rf {} \\;\n+}\n+\n+trap clean_up EXIT\n+\n+# Test code goes here\n+moby build -name ${NAME} -output kernel+initrd test.yml\n+RESULT=\"$(linuxkit run qemu -disk file=${NAME}1.img,size=512M ${NAME})\"","path":"test/cases/040_packages/008_format_mount/000_auto/test.sh","position":22,"original_position":22,"commit_id":"c0a774affcdaaa7c5f4b0717b6b1a27017035efa","original_commit_id":"87e9863351e89a2e9cfeadc8c67885ad3575ffa3","user":{"login":"dave-tucker","id":3781777,"avatar_url":"https://avatars3.githubusercontent.com/u/3781777?v=4","gravatar_id":"","url":"https://api.github.com/users/dave-tucker","html_url":"https://github.com/dave-tucker","followers_url":"https://api.github.com/users/dave-tucker/followers","following_url":"https://api.github.com/users/dave-tucker/following{/other_user}","gists_url":"https://api.github.com/users/dave-tucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-tucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-tucker/subscriptions","organizations_url":"https://api.github.com/users/dave-tucker/orgs","repos_url":"https://api.github.com/users/dave-tucker/repos","events_url":"https://api.github.com/users/dave-tucker/events{/privacy}","received_events_url":"https://api.github.com/users/dave-tucker/received_events","type":"User","site_admin":false},"body":"this one doesn't, but the `by_name` test does. I think I have an idea to avoid pinning to `qemu`. will try it out and re-push\r\n","created_at":"2017-07-21T14:46:51Z","updated_at":"2017-07-21T14:46:51Z","html_url":"https://github.com/linuxkit/linuxkit/pull/2152#discussion_r128780130","pull_request_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2152","_links":{"self":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments/128780130"},"html":{"href":"https://github.com/linuxkit/linuxkit/pull/2152#discussion_r128780130"},"pull_request":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2152"}}},"pull_request":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2152","id":128996578,"html_url":"https://github.com/linuxkit/linuxkit/pull/2152","diff_url":"https://github.com/linuxkit/linuxkit/pull/2152.diff","patch_url":"https://github.com/linuxkit/linuxkit/pull/2152.patch","issue_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2152","number":2152,"state":"open","locked":false,"title":"Improve mount and format packages","user":{"login":"dave-tucker","id":3781777,"avatar_url":"https://avatars3.githubusercontent.com/u/3781777?v=4","gravatar_id":"","url":"https://api.github.com/users/dave-tucker","html_url":"https://github.com/dave-tucker","followers_url":"https://api.github.com/users/dave-tucker/followers","following_url":"https://api.github.com/users/dave-tucker/following{/other_user}","gists_url":"https://api.github.com/users/dave-tucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-tucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-tucker/subscriptions","organizations_url":"https://api.github.com/users/dave-tucker/orgs","repos_url":"https://api.github.com/users/dave-tucker/repos","events_url":"https://api.github.com/users/dave-tucker/events{/privacy}","received_events_url":"https://api.github.com/users/dave-tucker/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/linuxkit/linuxkit/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n- `format`\r\n  - Added supports writing partition labels\r\n  - Added support for creating `btrfs` and `xfs` partitions\r\n- `mount`\r\n  - Allowed for a disk to be specified by name, label or UUID\r\n  - Fixed automatic mount logic to take already mounted disks and partitions in to account.\r\n- Added `extend` package to extend partitions on disks\r\n- Extending disks with the new `extend` package\r\n- Added test cases and updated documentation\r\n\r\n**- How I did it**\r\n\r\nTyping.\r\n\r\n**- How to verify it**\r\n\r\nRun ze tests!\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\nAdd multiple disk/mountpoint support for format and mount packages\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![](https://images.duckduckgo.com/iu/?u=http%3A%2F%2Fwww.indiaonrent.com%2Fforwards%2Fm%2Fmultiple-animals-being-cute-together%2Fres%2Fks2h0f.jpg&f=1)","created_at":"2017-07-05T15:50:52Z","updated_at":"2017-07-21T14:46:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fecfe9d8b217e6adfd5bbbebc0f0632ab15ee332","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2152/commits","review_comments_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2152/comments","review_comment_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2152/comments","statuses_url":"https://api.github.com/repos/linuxkit/linuxkit/statuses/c0a774affcdaaa7c5f4b0717b6b1a27017035efa","head":{"label":"dave-tucker:multi-mount","ref":"multi-mount","sha":"c0a774affcdaaa7c5f4b0717b6b1a27017035efa","user":{"login":"dave-tucker","id":3781777,"avatar_url":"https://avatars3.githubusercontent.com/u/3781777?v=4","gravatar_id":"","url":"https://api.github.com/users/dave-tucker","html_url":"https://github.com/dave-tucker","followers_url":"https://api.github.com/users/dave-tucker/followers","following_url":"https://api.github.com/users/dave-tucker/following{/other_user}","gists_url":"https://api.github.com/users/dave-tucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-tucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-tucker/subscriptions","organizations_url":"https://api.github.com/users/dave-tucker/orgs","repos_url":"https://api.github.com/users/dave-tucker/repos","events_url":"https://api.github.com/users/dave-tucker/events{/privacy}","received_events_url":"https://api.github.com/users/dave-tucker/received_events","type":"User","site_admin":false},"repo":{"id":88644217,"name":"linuxkit","full_name":"dave-tucker/linuxkit","owner":{"login":"dave-tucker","id":3781777,"avatar_url":"https://avatars3.githubusercontent.com/u/3781777?v=4","gravatar_id":"","url":"https://api.github.com/users/dave-tucker","html_url":"https://github.com/dave-tucker","followers_url":"https://api.github.com/users/dave-tucker/followers","following_url":"https://api.github.com/users/dave-tucker/following{/other_user}","gists_url":"https://api.github.com/users/dave-tucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-tucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-tucker/subscriptions","organizations_url":"https://api.github.com/users/dave-tucker/orgs","repos_url":"https://api.github.com/users/dave-tucker/repos","events_url":"https://api.github.com/users/dave-tucker/events{/privacy}","received_events_url":"https://api.github.com/users/dave-tucker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dave-tucker/linuxkit","description":"A toolkit for building secure, portable and lean operating systems for containers","fork":true,"url":"https://api.github.com/repos/dave-tucker/linuxkit","forks_url":"https://api.github.com/repos/dave-tucker/linuxkit/forks","keys_url":"https://api.github.com/repos/dave-tucker/linuxkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dave-tucker/linuxkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dave-tucker/linuxkit/teams","hooks_url":"https://api.github.com/repos/dave-tucker/linuxkit/hooks","issue_events_url":"https://api.github.com/repos/dave-tucker/linuxkit/issues/events{/number}","events_url":"https://api.github.com/repos/dave-tucker/linuxkit/events","assignees_url":"https://api.github.com/repos/dave-tucker/linuxkit/assignees{/user}","branches_url":"https://api.github.com/repos/dave-tucker/linuxkit/branches{/branch}","tags_url":"https://api.github.com/repos/dave-tucker/linuxkit/tags","blobs_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dave-tucker/linuxkit/statuses/{sha}","languages_url":"https://api.github.com/repos/dave-tucker/linuxkit/languages","stargazers_url":"https://api.github.com/repos/dave-tucker/linuxkit/stargazers","contributors_url":"https://api.github.com/repos/dave-tucker/linuxkit/contributors","subscribers_url":"https://api.github.com/repos/dave-tucker/linuxkit/subscribers","subscription_url":"https://api.github.com/repos/dave-tucker/linuxkit/subscription","commits_url":"https://api.github.com/repos/dave-tucker/linuxkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dave-tucker/linuxkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dave-tucker/linuxkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dave-tucker/linuxkit/contents/{+path}","compare_url":"https://api.github.com/repos/dave-tucker/linuxkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dave-tucker/linuxkit/merges","archive_url":"https://api.github.com/repos/dave-tucker/linuxkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dave-tucker/linuxkit/downloads","issues_url":"https://api.github.com/repos/dave-tucker/linuxkit/issues{/number}","pulls_url":"https://api.github.com/repos/dave-tucker/linuxkit/pulls{/number}","milestones_url":"https://api.github.com/repos/dave-tucker/linuxkit/milestones{/number}","notifications_url":"https://api.github.com/repos/dave-tucker/linuxkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dave-tucker/linuxkit/labels{/name}","releases_url":"https://api.github.com/repos/dave-tucker/linuxkit/releases{/id}","deployments_url":"https://api.github.com/repos/dave-tucker/linuxkit/deployments","created_at":"2017-04-18T16:00:00Z","updated_at":"2017-04-18T16:00:02Z","pushed_at":"2017-07-21T13:20:39Z","git_url":"git://github.com/dave-tucker/linuxkit.git","ssh_url":"git@github.com:dave-tucker/linuxkit.git","clone_url":"https://github.com/dave-tucker/linuxkit.git","svn_url":"https://github.com/dave-tucker/linuxkit","homepage":"","size":19612,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linuxkit:master","ref":"master","sha":"3219daa674e1c569d784486d5f70f165fd70dc77","user":{"login":"linuxkit","id":27256246,"avatar_url":"https://avatars2.githubusercontent.com/u/27256246?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxkit","html_url":"https://github.com/linuxkit","followers_url":"https://api.github.com/users/linuxkit/followers","following_url":"https://api.github.com/users/linuxkit/following{/other_user}","gists_url":"https://api.github.com/users/linuxkit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxkit/subscriptions","organizations_url":"https://api.github.com/users/linuxkit/orgs","repos_url":"https://api.github.com/users/linuxkit/repos","events_url":"https://api.github.com/users/linuxkit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxkit/received_events","type":"Organization","site_admin":false},"repo":{"id":46932243,"name":"linuxkit","full_name":"linuxkit/linuxkit","owner":{"login":"linuxkit","id":27256246,"avatar_url":"https://avatars2.githubusercontent.com/u/27256246?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxkit","html_url":"https://github.com/linuxkit","followers_url":"https://api.github.com/users/linuxkit/followers","following_url":"https://api.github.com/users/linuxkit/following{/other_user}","gists_url":"https://api.github.com/users/linuxkit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxkit/subscriptions","organizations_url":"https://api.github.com/users/linuxkit/orgs","repos_url":"https://api.github.com/users/linuxkit/repos","events_url":"https://api.github.com/users/linuxkit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linuxkit/linuxkit","description":"A toolkit for building secure, portable and lean operating systems for containers","fork":false,"url":"https://api.github.com/repos/linuxkit/linuxkit","forks_url":"https://api.github.com/repos/linuxkit/linuxkit/forks","keys_url":"https://api.github.com/repos/linuxkit/linuxkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linuxkit/linuxkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linuxkit/linuxkit/teams","hooks_url":"https://api.github.com/repos/linuxkit/linuxkit/hooks","issue_events_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/events{/number}","events_url":"https://api.github.com/repos/linuxkit/linuxkit/events","assignees_url":"https://api.github.com/repos/linuxkit/linuxkit/assignees{/user}","branches_url":"https://api.github.com/repos/linuxkit/linuxkit/branches{/branch}","tags_url":"https://api.github.com/repos/linuxkit/linuxkit/tags","blobs_url":"https://api.github.com/repos/linuxkit/linuxkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linuxkit/linuxkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linuxkit/linuxkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/linuxkit/linuxkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linuxkit/linuxkit/statuses/{sha}","languages_url":"https://api.github.com/repos/linuxkit/linuxkit/languages","stargazers_url":"https://api.github.com/repos/linuxkit/linuxkit/stargazers","contributors_url":"https://api.github.com/repos/linuxkit/linuxkit/contributors","subscribers_url":"https://api.github.com/repos/linuxkit/linuxkit/subscribers","subscription_url":"https://api.github.com/repos/linuxkit/linuxkit/subscription","commits_url":"https://api.github.com/repos/linuxkit/linuxkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/linuxkit/linuxkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/linuxkit/linuxkit/contents/{+path}","compare_url":"https://api.github.com/repos/linuxkit/linuxkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linuxkit/linuxkit/merges","archive_url":"https://api.github.com/repos/linuxkit/linuxkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linuxkit/linuxkit/downloads","issues_url":"https://api.github.com/repos/linuxkit/linuxkit/issues{/number}","pulls_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls{/number}","milestones_url":"https://api.github.com/repos/linuxkit/linuxkit/milestones{/number}","notifications_url":"https://api.github.com/repos/linuxkit/linuxkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linuxkit/linuxkit/labels{/name}","releases_url":"https://api.github.com/repos/linuxkit/linuxkit/releases{/id}","deployments_url":"https://api.github.com/repos/linuxkit/linuxkit/deployments","created_at":"2015-11-26T14:48:52Z","updated_at":"2017-07-21T07:09:23Z","pushed_at":"2017-07-21T14:27:06Z","git_url":"git://github.com/linuxkit/linuxkit.git","ssh_url":"git@github.com:linuxkit/linuxkit.git","clone_url":"https://github.com/linuxkit/linuxkit.git","svn_url":"https://github.com/linuxkit/linuxkit","homepage":"","size":19588,"stargazers_count":3007,"watchers_count":3007,"language":"Logos","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":177,"forks":330,"open_issues":177,"watchers":3007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2152"},"html":{"href":"https://github.com/linuxkit/linuxkit/pull/2152"},"issue":{"href":"https://api.github.com/repos/linuxkit/linuxkit/issues/2152"},"comments":{"href":"https://api.github.com/repos/linuxkit/linuxkit/issues/2152/comments"},"review_comments":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2152/comments"},"review_comment":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2152/commits"},"statuses":{"href":"https://api.github.com/repos/linuxkit/linuxkit/statuses/c0a774affcdaaa7c5f4b0717b6b1a27017035efa"}}}}
{"actor":{"display_login":"dave-tucker"}}