{"action":"closed","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50076","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50076/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50076/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50076/events","html_url":"https://github.com/kubernetes/kubernetes/issues/50076","id":247642184,"number":50076,"title":"Identify the server in audit webhook","user":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars1.githubusercontent.com/u/1756505?v=4","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"labels":[{"id":357119284,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/auth","name":"sig/auth","color":"d2b48c","default":false},{"id":258410135,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/federation","name":"sig/federation","color":"d2b48c","default":false},{"id":482207917,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/instrumentation","name":"sig/instrumentation","color":"d2b48c","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-08-03T09:14:53Z","updated_at":"2017-08-18T16:21:52Z","closed_at":"2017-08-18T16:21:52Z","body":"Spinning up a discussion from https://github.com/kubernetes/kubernetes/issues/48561\r\n\r\n> It would be nice to identify the server that sent the audit event, i.e. the aggregator vs. an end-user apiserver.\r\n\r\nIt can be implemented right now by adding a parameter to the webhook address on the deployment stage and process this parameter later in the pipeline. However, it's (relatively) easy to add information to the API and we want to make sure that the information we currently have is in the right state before going to beta / GA.\r\n\r\nOne thought is that it probably doesn't make sense to have this information in the event object, because events from different sources rarely mix up (until the backend anyway) and it would just mean the same information copied all over the request to the webhook. WDYT about adding this information to the EventList object?\r\n\r\n/cc @tallclair @sttts @CaoShuFeng @ericchiang"}}
{"actor":{"display_login":"ericchiang"}}