{"action":"created","comment":{"url":"https://api.github.com/repos/jiahaog/nativefier/pulls/comments/127743696","pull_request_review_id":50358731,"id":127743696,"diff_hunk":"@@ -77,6 +77,80 @@ function maybeCopyIcons(options, appPath, callback) {\n   });\n }\n \n+/**\n+ * Removes the `app-copyright` parameter from options if building for Windows while not on Windows and Wine is not installed\n+ * @param options\n+ */\n+function maybeNoAppCopyrightOption(options) {\n+    const packageOptions = JSON.parse(JSON.stringify(options));\n+    if (options.platform === 'win32' && !isWindows()) {\n+        if (!hasBinary.sync('wine')) {\n+            log.warn('Wine is required to use \"app-copyright\" option for a Windows app when packaging on non-windows platforms');\n+            packageOptions['app-copyright'] = null;\n+        }\n+    }\n+    return packageOptions;\n+}\n+\n+/**\n+ * Removes the `build-version` parameter from options if building for Windows while not on Windows and Wine is not installed\n+ * @param options\n+ */\n+function maybeNoBuildVersionOption(options) {\n+    const packageOptions = JSON.parse(JSON.stringify(options));\n+    if (options.platform === 'win32' && !isWindows()) {\n+        if (!hasBinary.sync('wine')) {\n+            log.warn('Wine is required to use \"build-version\" option for a Windows app when packaging on non-windows platforms');\n+            packageOptions['build-version'] = null;\n+        }\n+    }\n+    return packageOptions;\n+}\n+\n+/**\n+ * Removes the `app-version` parameter from options if building for Windows while not on Windows and Wine is not installed\n+ * @param options\n+ */\n+function maybeNoAppVersionOption(options) {\n+    const packageOptions = JSON.parse(JSON.stringify(options));\n+    if (options.platform === 'win32' && !isWindows()) {\n+        if (!hasBinary.sync('wine')) {\n+            log.warn('Wine is required to use \"app-version\" option for a Windows app when packaging on non-windows platforms');\n+            packageOptions['app-version'] = null;\n+        }\n+    }\n+    return packageOptions;\n+}\n+\n+/**\n+ * Removes the `version-string` parameter from options if building for Windows while not on Windows and Wine is not installed\n+ * @param options\n+ */\n+function maybeNoVersionStringOption(options) {\n+    const packageOptions = JSON.parse(JSON.stringify(options));\n+    if (options.platform === 'win32' && !isWindows()) {","path":"src/build/buildMain.js","position":55,"original_position":55,"commit_id":"c522d4eee25d2de8a4ab2b744b1a5705056e62a0","original_commit_id":"c522d4eee25d2de8a4ab2b744b1a5705056e62a0","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars4.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Expected indentation of 2 spaces but found 4                       indent","created_at":"2017-07-17T15:41:13Z","updated_at":"2017-07-17T15:41:14Z","html_url":"https://github.com/jiahaog/nativefier/pull/244#discussion_r127743696","pull_request_url":"https://api.github.com/repos/jiahaog/nativefier/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/jiahaog/nativefier/pulls/comments/127743696"},"html":{"href":"https://github.com/jiahaog/nativefier/pull/244#discussion_r127743696"},"pull_request":{"href":"https://api.github.com/repos/jiahaog/nativefier/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/jiahaog/nativefier/pulls/244","id":82926102,"html_url":"https://github.com/jiahaog/nativefier/pull/244","diff_url":"https://github.com/jiahaog/nativefier/pull/244.diff","patch_url":"https://github.com/jiahaog/nativefier/pull/244.patch","issue_url":"https://api.github.com/repos/jiahaog/nativefier/issues/244","number":244,"state":"open","locked":false,"title":"Fix #226 - Added support for app-copyright, app-version, build-version, version-string and win32metadata","user":{"login":"githubbob42","id":2529300,"avatar_url":"https://avatars6.githubusercontent.com/u/2529300?v=4","gravatar_id":"","url":"https://api.github.com/users/githubbob42","html_url":"https://github.com/githubbob42","followers_url":"https://api.github.com/users/githubbob42/followers","following_url":"https://api.github.com/users/githubbob42/following{/other_user}","gists_url":"https://api.github.com/users/githubbob42/gists{/gist_id}","starred_url":"https://api.github.com/users/githubbob42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/githubbob42/subscriptions","organizations_url":"https://api.github.com/users/githubbob42/orgs","repos_url":"https://api.github.com/users/githubbob42/repos","events_url":"https://api.github.com/users/githubbob42/events{/privacy}","received_events_url":"https://api.github.com/users/githubbob42/received_events","type":"User","site_admin":false},"body":"See Issue https://github.com/jiahaog/nativefier/issues/226.\n\nAdded support for `app-copyright`, `app-version`, `build-version`, `version-string` and `win32metadata`.\n\nSimilar to PR https://github.com/jiahaog/nativefier/pull/228, but I also needed `build-version`.  I also included support for `win32metadata` since that was recently added to `electron-packager` (v8.0.0) making `version-string` deprecated.\n\n`app-copyright`, `app-version`, `build-version` are supported in the CLI but `version-string` and `win32metadata` only supported via the [Nativefier Programmatic API](https://github.com/jiahaog/nativefier/blob/development/docs/api.md#programmatic-api).\n","created_at":"2016-08-26T17:42:05Z","updated_at":"2017-07-17T15:41:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"463dddd99a9007e3e08679d26610135576c2b387","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jiahaog/nativefier/pulls/244/commits","review_comments_url":"https://api.github.com/repos/jiahaog/nativefier/pulls/244/comments","review_comment_url":"https://api.github.com/repos/jiahaog/nativefier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jiahaog/nativefier/issues/244/comments","statuses_url":"https://api.github.com/repos/jiahaog/nativefier/statuses/c522d4eee25d2de8a4ab2b744b1a5705056e62a0","head":{"label":"githubbob42:addPackagerOptions","ref":"addPackagerOptions","sha":"c522d4eee25d2de8a4ab2b744b1a5705056e62a0","user":{"login":"githubbob42","id":2529300,"avatar_url":"https://avatars6.githubusercontent.com/u/2529300?v=4","gravatar_id":"","url":"https://api.github.com/users/githubbob42","html_url":"https://github.com/githubbob42","followers_url":"https://api.github.com/users/githubbob42/followers","following_url":"https://api.github.com/users/githubbob42/following{/other_user}","gists_url":"https://api.github.com/users/githubbob42/gists{/gist_id}","starred_url":"https://api.github.com/users/githubbob42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/githubbob42/subscriptions","organizations_url":"https://api.github.com/users/githubbob42/orgs","repos_url":"https://api.github.com/users/githubbob42/repos","events_url":"https://api.github.com/users/githubbob42/events{/privacy}","received_events_url":"https://api.github.com/users/githubbob42/received_events","type":"User","site_admin":false},"repo":{"id":66573784,"name":"nativefier","full_name":"githubbob42/nativefier","owner":{"login":"githubbob42","id":2529300,"avatar_url":"https://avatars6.githubusercontent.com/u/2529300?v=4","gravatar_id":"","url":"https://api.github.com/users/githubbob42","html_url":"https://github.com/githubbob42","followers_url":"https://api.github.com/users/githubbob42/followers","following_url":"https://api.github.com/users/githubbob42/following{/other_user}","gists_url":"https://api.github.com/users/githubbob42/gists{/gist_id}","starred_url":"https://api.github.com/users/githubbob42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/githubbob42/subscriptions","organizations_url":"https://api.github.com/users/githubbob42/orgs","repos_url":"https://api.github.com/users/githubbob42/repos","events_url":"https://api.github.com/users/githubbob42/events{/privacy}","received_events_url":"https://api.github.com/users/githubbob42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/githubbob42/nativefier","description":"Wrap any web page natively without even thinking, across Windows, OSX and Linux","fork":true,"url":"https://api.github.com/repos/githubbob42/nativefier","forks_url":"https://api.github.com/repos/githubbob42/nativefier/forks","keys_url":"https://api.github.com/repos/githubbob42/nativefier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/githubbob42/nativefier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/githubbob42/nativefier/teams","hooks_url":"https://api.github.com/repos/githubbob42/nativefier/hooks","issue_events_url":"https://api.github.com/repos/githubbob42/nativefier/issues/events{/number}","events_url":"https://api.github.com/repos/githubbob42/nativefier/events","assignees_url":"https://api.github.com/repos/githubbob42/nativefier/assignees{/user}","branches_url":"https://api.github.com/repos/githubbob42/nativefier/branches{/branch}","tags_url":"https://api.github.com/repos/githubbob42/nativefier/tags","blobs_url":"https://api.github.com/repos/githubbob42/nativefier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/githubbob42/nativefier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/githubbob42/nativefier/git/refs{/sha}","trees_url":"https://api.github.com/repos/githubbob42/nativefier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/githubbob42/nativefier/statuses/{sha}","languages_url":"https://api.github.com/repos/githubbob42/nativefier/languages","stargazers_url":"https://api.github.com/repos/githubbob42/nativefier/stargazers","contributors_url":"https://api.github.com/repos/githubbob42/nativefier/contributors","subscribers_url":"https://api.github.com/repos/githubbob42/nativefier/subscribers","subscription_url":"https://api.github.com/repos/githubbob42/nativefier/subscription","commits_url":"https://api.github.com/repos/githubbob42/nativefier/commits{/sha}","git_commits_url":"https://api.github.com/repos/githubbob42/nativefier/git/commits{/sha}","comments_url":"https://api.github.com/repos/githubbob42/nativefier/comments{/number}","issue_comment_url":"https://api.github.com/repos/githubbob42/nativefier/issues/comments{/number}","contents_url":"https://api.github.com/repos/githubbob42/nativefier/contents/{+path}","compare_url":"https://api.github.com/repos/githubbob42/nativefier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/githubbob42/nativefier/merges","archive_url":"https://api.github.com/repos/githubbob42/nativefier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/githubbob42/nativefier/downloads","issues_url":"https://api.github.com/repos/githubbob42/nativefier/issues{/number}","pulls_url":"https://api.github.com/repos/githubbob42/nativefier/pulls{/number}","milestones_url":"https://api.github.com/repos/githubbob42/nativefier/milestones{/number}","notifications_url":"https://api.github.com/repos/githubbob42/nativefier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/githubbob42/nativefier/labels{/name}","releases_url":"https://api.github.com/repos/githubbob42/nativefier/releases{/id}","deployments_url":"https://api.github.com/repos/githubbob42/nativefier/deployments","created_at":"2016-08-25T16:12:04Z","updated_at":"2016-08-25T16:12:06Z","pushed_at":"2017-07-17T15:41:01Z","git_url":"git://github.com/githubbob42/nativefier.git","ssh_url":"git@github.com:githubbob42/nativefier.git","clone_url":"https://github.com/githubbob42/nativefier.git","svn_url":"https://github.com/githubbob42/nativefier","homepage":"","size":4481,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"jiahaog:master","ref":"master","sha":"38825e8b71068f7ac6746532e4db2cdecb5afc10","user":{"login":"jiahaog","id":7111741,"avatar_url":"https://avatars7.githubusercontent.com/u/7111741?v=4","gravatar_id":"","url":"https://api.github.com/users/jiahaog","html_url":"https://github.com/jiahaog","followers_url":"https://api.github.com/users/jiahaog/followers","following_url":"https://api.github.com/users/jiahaog/following{/other_user}","gists_url":"https://api.github.com/users/jiahaog/gists{/gist_id}","starred_url":"https://api.github.com/users/jiahaog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiahaog/subscriptions","organizations_url":"https://api.github.com/users/jiahaog/orgs","repos_url":"https://api.github.com/users/jiahaog/repos","events_url":"https://api.github.com/users/jiahaog/events{/privacy}","received_events_url":"https://api.github.com/users/jiahaog/received_events","type":"User","site_admin":false},"repo":{"id":38558578,"name":"nativefier","full_name":"jiahaog/nativefier","owner":{"login":"jiahaog","id":7111741,"avatar_url":"https://avatars7.githubusercontent.com/u/7111741?v=4","gravatar_id":"","url":"https://api.github.com/users/jiahaog","html_url":"https://github.com/jiahaog","followers_url":"https://api.github.com/users/jiahaog/followers","following_url":"https://api.github.com/users/jiahaog/following{/other_user}","gists_url":"https://api.github.com/users/jiahaog/gists{/gist_id}","starred_url":"https://api.github.com/users/jiahaog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiahaog/subscriptions","organizations_url":"https://api.github.com/users/jiahaog/orgs","repos_url":"https://api.github.com/users/jiahaog/repos","events_url":"https://api.github.com/users/jiahaog/events{/privacy}","received_events_url":"https://api.github.com/users/jiahaog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiahaog/nativefier","description":"Make any web page a desktop application","fork":false,"url":"https://api.github.com/repos/jiahaog/nativefier","forks_url":"https://api.github.com/repos/jiahaog/nativefier/forks","keys_url":"https://api.github.com/repos/jiahaog/nativefier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiahaog/nativefier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiahaog/nativefier/teams","hooks_url":"https://api.github.com/repos/jiahaog/nativefier/hooks","issue_events_url":"https://api.github.com/repos/jiahaog/nativefier/issues/events{/number}","events_url":"https://api.github.com/repos/jiahaog/nativefier/events","assignees_url":"https://api.github.com/repos/jiahaog/nativefier/assignees{/user}","branches_url":"https://api.github.com/repos/jiahaog/nativefier/branches{/branch}","tags_url":"https://api.github.com/repos/jiahaog/nativefier/tags","blobs_url":"https://api.github.com/repos/jiahaog/nativefier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiahaog/nativefier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiahaog/nativefier/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiahaog/nativefier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiahaog/nativefier/statuses/{sha}","languages_url":"https://api.github.com/repos/jiahaog/nativefier/languages","stargazers_url":"https://api.github.com/repos/jiahaog/nativefier/stargazers","contributors_url":"https://api.github.com/repos/jiahaog/nativefier/contributors","subscribers_url":"https://api.github.com/repos/jiahaog/nativefier/subscribers","subscription_url":"https://api.github.com/repos/jiahaog/nativefier/subscription","commits_url":"https://api.github.com/repos/jiahaog/nativefier/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiahaog/nativefier/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiahaog/nativefier/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiahaog/nativefier/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiahaog/nativefier/contents/{+path}","compare_url":"https://api.github.com/repos/jiahaog/nativefier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiahaog/nativefier/merges","archive_url":"https://api.github.com/repos/jiahaog/nativefier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiahaog/nativefier/downloads","issues_url":"https://api.github.com/repos/jiahaog/nativefier/issues{/number}","pulls_url":"https://api.github.com/repos/jiahaog/nativefier/pulls{/number}","milestones_url":"https://api.github.com/repos/jiahaog/nativefier/milestones{/number}","notifications_url":"https://api.github.com/repos/jiahaog/nativefier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiahaog/nativefier/labels{/name}","releases_url":"https://api.github.com/repos/jiahaog/nativefier/releases{/id}","deployments_url":"https://api.github.com/repos/jiahaog/nativefier/deployments","created_at":"2015-07-05T05:56:42Z","updated_at":"2017-07-17T14:55:37Z","pushed_at":"2017-07-17T15:41:02Z","git_url":"git://github.com/jiahaog/nativefier.git","ssh_url":"git@github.com:jiahaog/nativefier.git","clone_url":"https://github.com/jiahaog/nativefier.git","svn_url":"https://github.com/jiahaog/nativefier","homepage":"","size":4353,"stargazers_count":11265,"watchers_count":11265,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":495,"mirror_url":null,"open_issues_count":80,"forks":495,"open_issues":80,"watchers":11265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jiahaog/nativefier/pulls/244"},"html":{"href":"https://github.com/jiahaog/nativefier/pull/244"},"issue":{"href":"https://api.github.com/repos/jiahaog/nativefier/issues/244"},"comments":{"href":"https://api.github.com/repos/jiahaog/nativefier/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/jiahaog/nativefier/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/jiahaog/nativefier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jiahaog/nativefier/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/jiahaog/nativefier/statuses/c522d4eee25d2de8a4ab2b744b1a5705056e62a0"}}}}
{"actor":{"display_login":"houndci-bot"}}