{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/152775308","pull_request_review_id":78686873,"id":152775308,"diff_hunk":"@@ -1112,6 +1112,8 @@ static int item_do_children(Item *i, const char *path, action_t action) {\n                 if (q < 0 && q != -ENOENT && r == 0)\n                         r = q;\n \n+                dirent_ensure_type(d, de);\n+\n                 if (IN_SET(de->d_type, DT_UNKNOWN, DT_DIR)) {","path":"src/tmpfiles/tmpfiles.c","position":6,"original_position":6,"commit_id":"5327a80939f9521761879fe16cbc218cf9bf9429","original_commit_id":"5327a80939f9521761879fe16cbc218cf9bf9429","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"i see. but i think it would be nicer to then simply also make it handle ELOOP silently, i.e. just add ELOOP to the IN_SET() expression?","created_at":"2017-11-23T11:16:50Z","updated_at":"2017-11-23T11:16:50Z","html_url":"https://github.com/systemd/systemd/pull/7423#discussion_r152775308","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/7423","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/152775308"},"html":{"href":"https://github.com/systemd/systemd/pull/7423#discussion_r152775308"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/7423"}},"in_reply_to_id":152760500},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/7423","id":154255881,"html_url":"https://github.com/systemd/systemd/pull/7423","diff_url":"https://github.com/systemd/systemd/pull/7423.diff","patch_url":"https://github.com/systemd/systemd/pull/7423.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/7423","number":7423,"state":"open","locked":false,"title":"tmpfiles: ensure entry type if DT_UNKNOWN.","user":{"login":"lrubaszewski","id":24234765,"avatar_url":"https://avatars0.githubusercontent.com/u/24234765?v=4","gravatar_id":"","url":"https://api.github.com/users/lrubaszewski","html_url":"https://github.com/lrubaszewski","followers_url":"https://api.github.com/users/lrubaszewski/followers","following_url":"https://api.github.com/users/lrubaszewski/following{/other_user}","gists_url":"https://api.github.com/users/lrubaszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lrubaszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrubaszewski/subscriptions","organizations_url":"https://api.github.com/users/lrubaszewski/orgs","repos_url":"https://api.github.com/users/lrubaszewski/repos","events_url":"https://api.github.com/users/lrubaszewski/events{/privacy}","received_events_url":"https://api.github.com/users/lrubaszewski/received_events","type":"User","site_admin":false},"body":"Some filesystems do not set d_type value when\r\nreaddir is called, so entry type is unknown.\r\nTherefore fstat shall be called to ensure entry type.\r\n\r\nfor more details see: man 3 readdir","created_at":"2017-11-22T21:11:01Z","updated_at":"2017-11-23T11:16:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"879417995fc8d0918d384b19471727b84b4a50b4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/7423/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/7423/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/7423/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/5327a80939f9521761879fe16cbc218cf9bf9429","head":{"label":"lrubaszewski:tmpfiles_ensure_type","ref":"tmpfiles_ensure_type","sha":"5327a80939f9521761879fe16cbc218cf9bf9429","user":{"login":"lrubaszewski","id":24234765,"avatar_url":"https://avatars0.githubusercontent.com/u/24234765?v=4","gravatar_id":"","url":"https://api.github.com/users/lrubaszewski","html_url":"https://github.com/lrubaszewski","followers_url":"https://api.github.com/users/lrubaszewski/followers","following_url":"https://api.github.com/users/lrubaszewski/following{/other_user}","gists_url":"https://api.github.com/users/lrubaszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lrubaszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrubaszewski/subscriptions","organizations_url":"https://api.github.com/users/lrubaszewski/orgs","repos_url":"https://api.github.com/users/lrubaszewski/repos","events_url":"https://api.github.com/users/lrubaszewski/events{/privacy}","received_events_url":"https://api.github.com/users/lrubaszewski/received_events","type":"User","site_admin":false},"repo":{"id":111731662,"name":"systemd","full_name":"lrubaszewski/systemd","owner":{"login":"lrubaszewski","id":24234765,"avatar_url":"https://avatars0.githubusercontent.com/u/24234765?v=4","gravatar_id":"","url":"https://api.github.com/users/lrubaszewski","html_url":"https://github.com/lrubaszewski","followers_url":"https://api.github.com/users/lrubaszewski/followers","following_url":"https://api.github.com/users/lrubaszewski/following{/other_user}","gists_url":"https://api.github.com/users/lrubaszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/lrubaszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrubaszewski/subscriptions","organizations_url":"https://api.github.com/users/lrubaszewski/orgs","repos_url":"https://api.github.com/users/lrubaszewski/repos","events_url":"https://api.github.com/users/lrubaszewski/events{/privacy}","received_events_url":"https://api.github.com/users/lrubaszewski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lrubaszewski/systemd","description":"🐧 ⚙️ – systemd System and Service Manager ","fork":true,"url":"https://api.github.com/repos/lrubaszewski/systemd","forks_url":"https://api.github.com/repos/lrubaszewski/systemd/forks","keys_url":"https://api.github.com/repos/lrubaszewski/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lrubaszewski/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lrubaszewski/systemd/teams","hooks_url":"https://api.github.com/repos/lrubaszewski/systemd/hooks","issue_events_url":"https://api.github.com/repos/lrubaszewski/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/lrubaszewski/systemd/events","assignees_url":"https://api.github.com/repos/lrubaszewski/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/lrubaszewski/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/lrubaszewski/systemd/tags","blobs_url":"https://api.github.com/repos/lrubaszewski/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lrubaszewski/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lrubaszewski/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lrubaszewski/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lrubaszewski/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/lrubaszewski/systemd/languages","stargazers_url":"https://api.github.com/repos/lrubaszewski/systemd/stargazers","contributors_url":"https://api.github.com/repos/lrubaszewski/systemd/contributors","subscribers_url":"https://api.github.com/repos/lrubaszewski/systemd/subscribers","subscription_url":"https://api.github.com/repos/lrubaszewski/systemd/subscription","commits_url":"https://api.github.com/repos/lrubaszewski/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lrubaszewski/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lrubaszewski/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lrubaszewski/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lrubaszewski/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/lrubaszewski/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lrubaszewski/systemd/merges","archive_url":"https://api.github.com/repos/lrubaszewski/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lrubaszewski/systemd/downloads","issues_url":"https://api.github.com/repos/lrubaszewski/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/lrubaszewski/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/lrubaszewski/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/lrubaszewski/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lrubaszewski/systemd/labels{/name}","releases_url":"https://api.github.com/repos/lrubaszewski/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/lrubaszewski/systemd/deployments","created_at":"2017-11-22T20:57:31Z","updated_at":"2017-11-22T20:57:40Z","pushed_at":"2017-11-22T20:59:30Z","git_url":"git://github.com/lrubaszewski/systemd.git","ssh_url":"git@github.com:lrubaszewski/systemd.git","clone_url":"https://github.com/lrubaszewski/systemd.git","svn_url":"https://github.com/lrubaszewski/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":79039,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"0a5b5115b137698909257ef0e21d7f353a69daa7","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"🐧 ⚙️ – systemd System and Service Manager ","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2017-11-23T07:58:00Z","pushed_at":"2017-11-23T10:07:21Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":79305,"stargazers_count":2417,"watchers_count":2417,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1007,"mirror_url":null,"archived":false,"open_issues_count":784,"forks":1007,"open_issues":784,"watchers":2417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/7423"},"html":{"href":"https://github.com/systemd/systemd/pull/7423"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/7423"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/7423/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/7423/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/7423/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/5327a80939f9521761879fe16cbc218cf9bf9429"}},"author_association":"NONE"}}
{"actor":{"display_login":"poettering"}}