{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43890","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43890/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43890/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43890/events","html_url":"https://github.com/kubernetes/kubernetes/pull/43890","id":218408584,"number":43890,"title":"Make func modifySandboxNamespaceOptions() more robust","user":{"login":"xlgao-zju","id":1636894,"avatar_url":"https://avatars2.githubusercontent.com/u/1636894?v=3","gravatar_id":"","url":"https://api.github.com/users/xlgao-zju","html_url":"https://github.com/xlgao-zju","followers_url":"https://api.github.com/users/xlgao-zju/followers","following_url":"https://api.github.com/users/xlgao-zju/following{/other_user}","gists_url":"https://api.github.com/users/xlgao-zju/gists{/gist_id}","starred_url":"https://api.github.com/users/xlgao-zju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xlgao-zju/subscriptions","organizations_url":"https://api.github.com/users/xlgao-zju/orgs","repos_url":"https://api.github.com/users/xlgao-zju/repos","events_url":"https://api.github.com/users/xlgao-zju/events{/privacy}","received_events_url":"https://api.github.com/users/xlgao-zju/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":335674843,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge","name":"do-not-merge","color":"e11d21","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530192,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars1.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"assignees":[{"login":"feiskyer","id":676637,"avatar_url":"https://avatars1.githubusercontent.com/u/676637?v=3","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-03-31T06:20:37Z","updated_at":"2017-03-31T08:12:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43890","html_url":"https://github.com/kubernetes/kubernetes/pull/43890","diff_url":"https://github.com/kubernetes/kubernetes/pull/43890.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/43890.patch"},"body":"Make func `modifySandboxNamespaceOptions()` more robust, just like what we do in func [`modifyContainerNamespaceOptions`](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/dockershim/security_context.go#L117).\r\n\r\n/cc @feiskyer \r\n\r\nSigned-off-by: Xianglin Gao <xlgao@zju.edu.cn>\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/290646779","html_url":"https://github.com/kubernetes/kubernetes/pull/43890#issuecomment-290646779","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43890","id":290646779,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars3.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-03-31T08:12:31Z","updated_at":"2017-03-31T08:12:31Z","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/43890#issuecomment-290646709\" title=\"LGTM\">feiskyer</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/43890#\" title=\"Author self-approved\">xlgao-zju</a>*\nWe suggest the following additional approver: @derekwaynecarr\n\n<details open>\nNeeds approval from an approver in each of these OWNERS Files:\n\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={approvers:[derekwaynecarr]} -->"}}
{"actor":{"display_login":"k8s-merge-robot"}}