{"action":"created","comment":{"url":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/comments/147189901","pull_request_review_id":72250371,"id":147189901,"diff_hunk":"@@ -400,6 +402,28 @@ var ROSE = (function() {\n         }\n     }\n \n+    function SoundController(loader) {\n+        this.loader = loader;\n+        this.sounds = [null];\n+        var self = this;\n+\n+        loader.load(\"res/soundtrack/Nyan_Cat.ogg\", function (sound) {\n+            sound.loop = true;\n+            self.sounds[0] = sound;\n+            self.toggle_sound(0);\n+        });\n+    }\n+\n+    SoundController.prototype.toggle_sound = function(sound_id) {","path":"rose/web/game.js","position":41,"original_position":41,"commit_id":"8d877e22b2e106b33caaf0e899d6bf30519b49bf","original_commit_id":"8d877e22b2e106b33caaf0e899d6bf30519b49bf","user":{"login":"nirs","id":395026,"avatar_url":"https://avatars0.githubusercontent.com/u/395026?v=4","gravatar_id":"","url":"https://api.github.com/users/nirs","html_url":"https://github.com/nirs","followers_url":"https://api.github.com/users/nirs/followers","following_url":"https://api.github.com/users/nirs/following{/other_user}","gists_url":"https://api.github.com/users/nirs/gists{/gist_id}","starred_url":"https://api.github.com/users/nirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirs/subscriptions","organizations_url":"https://api.github.com/users/nirs/orgs","repos_url":"https://api.github.com/users/nirs/repos","events_url":"https://api.github.com/users/nirs/events{/privacy}","received_events_url":"https://api.github.com/users/nirs/received_events","type":"User","site_admin":false},"body":"I'm not sure how you are going to use this in the next version, since when clicking sound button, we have to:\r\n- play/pause sound\r\n- replace the icon\r\n\r\nIt seems that the entire sound controller belongs to the next PR, this PR is happy with the plain loader, playing the file when it was loaded, as in the first commit.","created_at":"2017-10-26T16:03:34Z","updated_at":"2017-10-26T16:03:59Z","html_url":"https://github.com/RedHat-Israel/ROSE/pull/236#discussion_r147189901","pull_request_url":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/236","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/comments/147189901"},"html":{"href":"https://github.com/RedHat-Israel/ROSE/pull/236#discussion_r147189901"},"pull_request":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/236"}}},"pull_request":{"url":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/236","id":147979654,"html_url":"https://github.com/RedHat-Israel/ROSE/pull/236","diff_url":"https://github.com/RedHat-Israel/ROSE/pull/236.diff","patch_url":"https://github.com/RedHat-Israel/ROSE/pull/236.patch","issue_url":"https://api.github.com/repos/RedHat-Israel/ROSE/issues/236","number":236,"state":"open","locked":false,"title":"Add web soundtrack","user":{"login":"devmattrick","id":5848320,"avatar_url":"https://avatars2.githubusercontent.com/u/5848320?v=4","gravatar_id":"","url":"https://api.github.com/users/devmattrick","html_url":"https://github.com/devmattrick","followers_url":"https://api.github.com/users/devmattrick/followers","following_url":"https://api.github.com/users/devmattrick/following{/other_user}","gists_url":"https://api.github.com/users/devmattrick/gists{/gist_id}","starred_url":"https://api.github.com/users/devmattrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devmattrick/subscriptions","organizations_url":"https://api.github.com/users/devmattrick/orgs","repos_url":"https://api.github.com/users/devmattrick/repos","events_url":"https://api.github.com/users/devmattrick/events{/privacy}","received_events_url":"https://api.github.com/users/devmattrick/received_events","type":"User","site_admin":false},"body":"Adds a soundtrack to the webpage upon startup (also allows the ability to mute/ unmute and stores it in local storage), resolving both #230 and #231.\r\n\r\nPlease let me know if you'd like any changes made!","created_at":"2017-10-22T07:08:26Z","updated_at":"2017-10-26T16:03:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1f50af08cbddb2625a75ab15029483e31e70bd3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/236/commits","review_comments_url":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/236/comments","review_comment_url":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHat-Israel/ROSE/issues/236/comments","statuses_url":"https://api.github.com/repos/RedHat-Israel/ROSE/statuses/8d877e22b2e106b33caaf0e899d6bf30519b49bf","head":{"label":"devmattrick:web-sound","ref":"web-sound","sha":"8d877e22b2e106b33caaf0e899d6bf30519b49bf","user":{"login":"devmattrick","id":5848320,"avatar_url":"https://avatars2.githubusercontent.com/u/5848320?v=4","gravatar_id":"","url":"https://api.github.com/users/devmattrick","html_url":"https://github.com/devmattrick","followers_url":"https://api.github.com/users/devmattrick/followers","following_url":"https://api.github.com/users/devmattrick/following{/other_user}","gists_url":"https://api.github.com/users/devmattrick/gists{/gist_id}","starred_url":"https://api.github.com/users/devmattrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devmattrick/subscriptions","organizations_url":"https://api.github.com/users/devmattrick/orgs","repos_url":"https://api.github.com/users/devmattrick/repos","events_url":"https://api.github.com/users/devmattrick/events{/privacy}","received_events_url":"https://api.github.com/users/devmattrick/received_events","type":"User","site_admin":false},"repo":{"id":107842498,"name":"ROSE","full_name":"devmattrick/ROSE","owner":{"login":"devmattrick","id":5848320,"avatar_url":"https://avatars2.githubusercontent.com/u/5848320?v=4","gravatar_id":"","url":"https://api.github.com/users/devmattrick","html_url":"https://github.com/devmattrick","followers_url":"https://api.github.com/users/devmattrick/followers","following_url":"https://api.github.com/users/devmattrick/following{/other_user}","gists_url":"https://api.github.com/users/devmattrick/gists{/gist_id}","starred_url":"https://api.github.com/users/devmattrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devmattrick/subscriptions","organizations_url":"https://api.github.com/users/devmattrick/orgs","repos_url":"https://api.github.com/users/devmattrick/repos","events_url":"https://api.github.com/users/devmattrick/events{/privacy}","received_events_url":"https://api.github.com/users/devmattrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/devmattrick/ROSE","description":"ROSE project car race game","fork":true,"url":"https://api.github.com/repos/devmattrick/ROSE","forks_url":"https://api.github.com/repos/devmattrick/ROSE/forks","keys_url":"https://api.github.com/repos/devmattrick/ROSE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devmattrick/ROSE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devmattrick/ROSE/teams","hooks_url":"https://api.github.com/repos/devmattrick/ROSE/hooks","issue_events_url":"https://api.github.com/repos/devmattrick/ROSE/issues/events{/number}","events_url":"https://api.github.com/repos/devmattrick/ROSE/events","assignees_url":"https://api.github.com/repos/devmattrick/ROSE/assignees{/user}","branches_url":"https://api.github.com/repos/devmattrick/ROSE/branches{/branch}","tags_url":"https://api.github.com/repos/devmattrick/ROSE/tags","blobs_url":"https://api.github.com/repos/devmattrick/ROSE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devmattrick/ROSE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devmattrick/ROSE/git/refs{/sha}","trees_url":"https://api.github.com/repos/devmattrick/ROSE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devmattrick/ROSE/statuses/{sha}","languages_url":"https://api.github.com/repos/devmattrick/ROSE/languages","stargazers_url":"https://api.github.com/repos/devmattrick/ROSE/stargazers","contributors_url":"https://api.github.com/repos/devmattrick/ROSE/contributors","subscribers_url":"https://api.github.com/repos/devmattrick/ROSE/subscribers","subscription_url":"https://api.github.com/repos/devmattrick/ROSE/subscription","commits_url":"https://api.github.com/repos/devmattrick/ROSE/commits{/sha}","git_commits_url":"https://api.github.com/repos/devmattrick/ROSE/git/commits{/sha}","comments_url":"https://api.github.com/repos/devmattrick/ROSE/comments{/number}","issue_comment_url":"https://api.github.com/repos/devmattrick/ROSE/issues/comments{/number}","contents_url":"https://api.github.com/repos/devmattrick/ROSE/contents/{+path}","compare_url":"https://api.github.com/repos/devmattrick/ROSE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devmattrick/ROSE/merges","archive_url":"https://api.github.com/repos/devmattrick/ROSE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devmattrick/ROSE/downloads","issues_url":"https://api.github.com/repos/devmattrick/ROSE/issues{/number}","pulls_url":"https://api.github.com/repos/devmattrick/ROSE/pulls{/number}","milestones_url":"https://api.github.com/repos/devmattrick/ROSE/milestones{/number}","notifications_url":"https://api.github.com/repos/devmattrick/ROSE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devmattrick/ROSE/labels{/name}","releases_url":"https://api.github.com/repos/devmattrick/ROSE/releases{/id}","deployments_url":"https://api.github.com/repos/devmattrick/ROSE/deployments","created_at":"2017-10-22T06:24:36Z","updated_at":"2017-10-22T06:24:38Z","pushed_at":"2017-10-26T07:34:36Z","git_url":"git://github.com/devmattrick/ROSE.git","ssh_url":"git@github.com:devmattrick/ROSE.git","clone_url":"https://github.com/devmattrick/ROSE.git","svn_url":"https://github.com/devmattrick/ROSE","homepage":"","size":9147,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RedHat-Israel:master","ref":"master","sha":"10cbbb396c18ac4a7cc9785d2a7b1ede8138700c","user":{"login":"RedHat-Israel","id":29605090,"avatar_url":"https://avatars1.githubusercontent.com/u/29605090?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHat-Israel","html_url":"https://github.com/RedHat-Israel","followers_url":"https://api.github.com/users/RedHat-Israel/followers","following_url":"https://api.github.com/users/RedHat-Israel/following{/other_user}","gists_url":"https://api.github.com/users/RedHat-Israel/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHat-Israel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHat-Israel/subscriptions","organizations_url":"https://api.github.com/users/RedHat-Israel/orgs","repos_url":"https://api.github.com/users/RedHat-Israel/repos","events_url":"https://api.github.com/users/RedHat-Israel/events{/privacy}","received_events_url":"https://api.github.com/users/RedHat-Israel/received_events","type":"Organization","site_admin":false},"repo":{"id":15367572,"name":"ROSE","full_name":"RedHat-Israel/ROSE","owner":{"login":"RedHat-Israel","id":29605090,"avatar_url":"https://avatars1.githubusercontent.com/u/29605090?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHat-Israel","html_url":"https://github.com/RedHat-Israel","followers_url":"https://api.github.com/users/RedHat-Israel/followers","following_url":"https://api.github.com/users/RedHat-Israel/following{/other_user}","gists_url":"https://api.github.com/users/RedHat-Israel/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHat-Israel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHat-Israel/subscriptions","organizations_url":"https://api.github.com/users/RedHat-Israel/orgs","repos_url":"https://api.github.com/users/RedHat-Israel/repos","events_url":"https://api.github.com/users/RedHat-Israel/events{/privacy}","received_events_url":"https://api.github.com/users/RedHat-Israel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHat-Israel/ROSE","description":"ROSE project car race game","fork":false,"url":"https://api.github.com/repos/RedHat-Israel/ROSE","forks_url":"https://api.github.com/repos/RedHat-Israel/ROSE/forks","keys_url":"https://api.github.com/repos/RedHat-Israel/ROSE/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHat-Israel/ROSE/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHat-Israel/ROSE/teams","hooks_url":"https://api.github.com/repos/RedHat-Israel/ROSE/hooks","issue_events_url":"https://api.github.com/repos/RedHat-Israel/ROSE/issues/events{/number}","events_url":"https://api.github.com/repos/RedHat-Israel/ROSE/events","assignees_url":"https://api.github.com/repos/RedHat-Israel/ROSE/assignees{/user}","branches_url":"https://api.github.com/repos/RedHat-Israel/ROSE/branches{/branch}","tags_url":"https://api.github.com/repos/RedHat-Israel/ROSE/tags","blobs_url":"https://api.github.com/repos/RedHat-Israel/ROSE/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHat-Israel/ROSE/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHat-Israel/ROSE/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHat-Israel/ROSE/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHat-Israel/ROSE/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHat-Israel/ROSE/languages","stargazers_url":"https://api.github.com/repos/RedHat-Israel/ROSE/stargazers","contributors_url":"https://api.github.com/repos/RedHat-Israel/ROSE/contributors","subscribers_url":"https://api.github.com/repos/RedHat-Israel/ROSE/subscribers","subscription_url":"https://api.github.com/repos/RedHat-Israel/ROSE/subscription","commits_url":"https://api.github.com/repos/RedHat-Israel/ROSE/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHat-Israel/ROSE/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHat-Israel/ROSE/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHat-Israel/ROSE/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHat-Israel/ROSE/contents/{+path}","compare_url":"https://api.github.com/repos/RedHat-Israel/ROSE/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHat-Israel/ROSE/merges","archive_url":"https://api.github.com/repos/RedHat-Israel/ROSE/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHat-Israel/ROSE/downloads","issues_url":"https://api.github.com/repos/RedHat-Israel/ROSE/issues{/number}","pulls_url":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHat-Israel/ROSE/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHat-Israel/ROSE/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHat-Israel/ROSE/labels{/name}","releases_url":"https://api.github.com/repos/RedHat-Israel/ROSE/releases{/id}","deployments_url":"https://api.github.com/repos/RedHat-Israel/ROSE/deployments","created_at":"2013-12-21T23:47:56Z","updated_at":"2017-10-26T07:35:39Z","pushed_at":"2017-10-26T07:34:37Z","git_url":"git://github.com/RedHat-Israel/ROSE.git","ssh_url":"git@github.com:RedHat-Israel/ROSE.git","clone_url":"https://github.com/RedHat-Israel/ROSE.git","svn_url":"https://github.com/RedHat-Israel/ROSE","homepage":"","size":9154,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":41,"forks":39,"open_issues":41,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/236"},"html":{"href":"https://github.com/RedHat-Israel/ROSE/pull/236"},"issue":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/issues/236"},"comments":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/RedHat-Israel/ROSE/statuses/8d877e22b2e106b33caaf0e899d6bf30519b49bf"}},"author_association":"NONE"}}
{"actor":{"display_login":"nirs"}}