{"action":"created","comment":{"url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/comments/117164991","pull_request_review_id":38844471,"id":117164991,"diff_hunk":"@@ -1,25 +1,52 @@\n <link rel=\"import\" href=\"../../../../bower_components/polymer/polymer.html\">\n+<link rel=\"import\" href=\"../../../../bower_components/paper-material/paper-material.html\">\n \n+<link rel=\"import\" href=\"../../../elements/ip-reporting/list-view-indicators.html\">\n+<link rel=\"import\" href=\"../../../elements/etools-prp-ajax.html\">\n <link rel=\"import\" href=\"../../../elements/page-header.html\">\n <link rel=\"import\" href=\"../../../elements/page-body.html\">\n+<link rel=\"import\" href=\"../../../endpoints.html\">\n+<link rel=\"import\" href=\"../../../redux/actions.html\">\n+<link rel=\"import\" href=\"../../../redux/store.html\">\n \n <dom-module id=\"page-ip-reporting-indicators\">\n   <template>\n-    <style>\n-      :host {\n-        display: block;\n-      }\n-    </style>\n-\n     <page-header title=\"Indicators\"></page-header>\n-\n     <page-body>\n+      <list-view-indicators />\n     </page-body>\n+    <etools-prp-ajax","path":"polymer/src/pages/app/ip-reporting/indicators.html","position":25,"original_position":25,"commit_id":"0cc3bf6a26630cf26f05afb3a0121694ff014dc6","original_commit_id":"0cc3bf6a26630cf26f05afb3a0121694ff014dc6","user":{"login":"rkrupinski","id":775177,"avatar_url":"https://avatars0.githubusercontent.com/u/775177?v=3","gravatar_id":"","url":"https://api.github.com/users/rkrupinski","html_url":"https://github.com/rkrupinski","followers_url":"https://api.github.com/users/rkrupinski/followers","following_url":"https://api.github.com/users/rkrupinski/following{/other_user}","gists_url":"https://api.github.com/users/rkrupinski/gists{/gist_id}","starred_url":"https://api.github.com/users/rkrupinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkrupinski/subscriptions","organizations_url":"https://api.github.com/users/rkrupinski/orgs","repos_url":"https://api.github.com/users/rkrupinski/repos","events_url":"https://api.github.com/users/rkrupinski/events{/privacy}","received_events_url":"https://api.github.com/users/rkrupinski/received_events","type":"User","site_admin":false},"body":"It's just me, but I prefer putting non-rendering elements at the top of a template.","created_at":"2017-05-18T05:47:26Z","updated_at":"2017-05-18T05:59:16Z","html_url":"https://github.com/unicef/etools-partner-reporting-portal/pull/56#discussion_r117164991","pull_request_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/comments/117164991"},"html":{"href":"https://github.com/unicef/etools-partner-reporting-portal/pull/56#discussion_r117164991"},"pull_request":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/56","id":120958213,"html_url":"https://github.com/unicef/etools-partner-reporting-portal/pull/56","diff_url":"https://github.com/unicef/etools-partner-reporting-portal/pull/56.diff","patch_url":"https://github.com/unicef/etools-partner-reporting-portal/pull/56.patch","issue_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/56","number":56,"state":"open","locked":false,"title":"Feature indicator list #19","user":{"login":"ErinOC","id":3789362,"avatar_url":"https://avatars3.githubusercontent.com/u/3789362?v=3","gravatar_id":"","url":"https://api.github.com/users/ErinOC","html_url":"https://github.com/ErinOC","followers_url":"https://api.github.com/users/ErinOC/followers","following_url":"https://api.github.com/users/ErinOC/following{/other_user}","gists_url":"https://api.github.com/users/ErinOC/gists{/gist_id}","starred_url":"https://api.github.com/users/ErinOC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErinOC/subscriptions","organizations_url":"https://api.github.com/users/ErinOC/orgs","repos_url":"https://api.github.com/users/ErinOC/repos","events_url":"https://api.github.com/users/ErinOC/events{/privacy}","received_events_url":"https://api.github.com/users/ErinOC/received_events","type":"User","site_admin":false},"body":"Rafal - \r\n\r\nI’m submitting a PR now so we stay on the same page and so you can stop me if I’m doing something wrong.  Ignore the backend stuff; Silin and I are working on the same branch.\r\n\r\nFYI: Silin is making API changes so the data will be changing.\r\n\r\n**Additions that relate to tables more broadly:**\r\n\r\n1) The ‘col’ classes used in the Unicef examples don’t seem to work (and I couldn’t find that class referenced elsewhere.  I’m using flex classes instead.\r\n\r\n2) I added a behaviors object for pagination, pulling from https://github.com/unicef/etools-partnership-management/blob/1e750168e34ec6abae7ecb17beeea97dfacdd737/pmp/app-behaviors/lists-common-behavior.html  Currently the ‘Rows Per Page’ numbers are adjusting correctly, but the number of rows is not.\r\n\r\n3) I added styles/data-table-custom to make the icons gray and hide the divider line that showed up when expanded (still need to figure out how to show it when the row is NOT expanded).  I also need to figure out how to show the expand icon on the right side of the table.\r\n\r\n4) I didn't find an etools component for the progress bar so I used Polymer's and added styling.","created_at":"2017-05-17T01:30:25Z","updated_at":"2017-05-18T05:59:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57e1888dec2c4123847de308ace9dfe77a7b2bf1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lkolacz","id":4430194,"avatar_url":"https://avatars1.githubusercontent.com/u/4430194?v=3","gravatar_id":"","url":"https://api.github.com/users/lkolacz","html_url":"https://github.com/lkolacz","followers_url":"https://api.github.com/users/lkolacz/followers","following_url":"https://api.github.com/users/lkolacz/following{/other_user}","gists_url":"https://api.github.com/users/lkolacz/gists{/gist_id}","starred_url":"https://api.github.com/users/lkolacz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkolacz/subscriptions","organizations_url":"https://api.github.com/users/lkolacz/orgs","repos_url":"https://api.github.com/users/lkolacz/repos","events_url":"https://api.github.com/users/lkolacz/events{/privacy}","received_events_url":"https://api.github.com/users/lkolacz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/56/commits","review_comments_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/56/comments","review_comment_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/56/comments","statuses_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/statuses/0cc3bf6a26630cf26f05afb3a0121694ff014dc6","head":{"label":"unicef:feature-indicator-list-#19","ref":"feature-indicator-list-#19","sha":"0cc3bf6a26630cf26f05afb3a0121694ff014dc6","user":{"login":"unicef","id":175849,"avatar_url":"https://avatars3.githubusercontent.com/u/175849?v=3","gravatar_id":"","url":"https://api.github.com/users/unicef","html_url":"https://github.com/unicef","followers_url":"https://api.github.com/users/unicef/followers","following_url":"https://api.github.com/users/unicef/following{/other_user}","gists_url":"https://api.github.com/users/unicef/gists{/gist_id}","starred_url":"https://api.github.com/users/unicef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicef/subscriptions","organizations_url":"https://api.github.com/users/unicef/orgs","repos_url":"https://api.github.com/users/unicef/repos","events_url":"https://api.github.com/users/unicef/events{/privacy}","received_events_url":"https://api.github.com/users/unicef/received_events","type":"Organization","site_admin":false},"repo":{"id":85220489,"name":"etools-partner-reporting-portal","full_name":"unicef/etools-partner-reporting-portal","owner":{"login":"unicef","id":175849,"avatar_url":"https://avatars3.githubusercontent.com/u/175849?v=3","gravatar_id":"","url":"https://api.github.com/users/unicef","html_url":"https://github.com/unicef","followers_url":"https://api.github.com/users/unicef/followers","following_url":"https://api.github.com/users/unicef/following{/other_user}","gists_url":"https://api.github.com/users/unicef/gists{/gist_id}","starred_url":"https://api.github.com/users/unicef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicef/subscriptions","organizations_url":"https://api.github.com/users/unicef/orgs","repos_url":"https://api.github.com/users/unicef/repos","events_url":"https://api.github.com/users/unicef/events{/privacy}","received_events_url":"https://api.github.com/users/unicef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicef/etools-partner-reporting-portal","description":null,"fork":false,"url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal","forks_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/forks","keys_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/teams","hooks_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/hooks","issue_events_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/events{/number}","events_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/events","assignees_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/assignees{/user}","branches_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/branches{/branch}","tags_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/tags","blobs_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/languages","stargazers_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/stargazers","contributors_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/contributors","subscribers_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/subscribers","subscription_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/subscription","commits_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/contents/{+path}","compare_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/merges","archive_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/downloads","issues_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues{/number}","pulls_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/labels{/name}","releases_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/releases{/id}","deployments_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/deployments","created_at":"2017-03-16T16:53:52Z","updated_at":"2017-05-16T21:12:08Z","pushed_at":"2017-05-18T01:44:01Z","git_url":"git://github.com/unicef/etools-partner-reporting-portal.git","ssh_url":"git@github.com:unicef/etools-partner-reporting-portal.git","clone_url":"https://github.com/unicef/etools-partner-reporting-portal.git","svn_url":"https://github.com/unicef/etools-partner-reporting-portal","homepage":null,"size":4117,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":28,"forks":0,"open_issues":28,"watchers":1,"default_branch":"develop"}},"base":{"label":"unicef:develop","ref":"develop","sha":"ae71b0b696dc00f4bd6c543f0a0138a60725b9df","user":{"login":"unicef","id":175849,"avatar_url":"https://avatars3.githubusercontent.com/u/175849?v=3","gravatar_id":"","url":"https://api.github.com/users/unicef","html_url":"https://github.com/unicef","followers_url":"https://api.github.com/users/unicef/followers","following_url":"https://api.github.com/users/unicef/following{/other_user}","gists_url":"https://api.github.com/users/unicef/gists{/gist_id}","starred_url":"https://api.github.com/users/unicef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicef/subscriptions","organizations_url":"https://api.github.com/users/unicef/orgs","repos_url":"https://api.github.com/users/unicef/repos","events_url":"https://api.github.com/users/unicef/events{/privacy}","received_events_url":"https://api.github.com/users/unicef/received_events","type":"Organization","site_admin":false},"repo":{"id":85220489,"name":"etools-partner-reporting-portal","full_name":"unicef/etools-partner-reporting-portal","owner":{"login":"unicef","id":175849,"avatar_url":"https://avatars3.githubusercontent.com/u/175849?v=3","gravatar_id":"","url":"https://api.github.com/users/unicef","html_url":"https://github.com/unicef","followers_url":"https://api.github.com/users/unicef/followers","following_url":"https://api.github.com/users/unicef/following{/other_user}","gists_url":"https://api.github.com/users/unicef/gists{/gist_id}","starred_url":"https://api.github.com/users/unicef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicef/subscriptions","organizations_url":"https://api.github.com/users/unicef/orgs","repos_url":"https://api.github.com/users/unicef/repos","events_url":"https://api.github.com/users/unicef/events{/privacy}","received_events_url":"https://api.github.com/users/unicef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicef/etools-partner-reporting-portal","description":null,"fork":false,"url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal","forks_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/forks","keys_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/teams","hooks_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/hooks","issue_events_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/events{/number}","events_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/events","assignees_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/assignees{/user}","branches_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/branches{/branch}","tags_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/tags","blobs_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/languages","stargazers_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/stargazers","contributors_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/contributors","subscribers_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/subscribers","subscription_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/subscription","commits_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/contents/{+path}","compare_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/merges","archive_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/downloads","issues_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues{/number}","pulls_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/labels{/name}","releases_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/releases{/id}","deployments_url":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/deployments","created_at":"2017-03-16T16:53:52Z","updated_at":"2017-05-16T21:12:08Z","pushed_at":"2017-05-18T01:44:01Z","git_url":"git://github.com/unicef/etools-partner-reporting-portal.git","ssh_url":"git@github.com:unicef/etools-partner-reporting-portal.git","clone_url":"https://github.com/unicef/etools-partner-reporting-portal.git","svn_url":"https://github.com/unicef/etools-partner-reporting-portal","homepage":null,"size":4117,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":28,"forks":0,"open_issues":28,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/56"},"html":{"href":"https://github.com/unicef/etools-partner-reporting-portal/pull/56"},"issue":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/56"},"comments":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/unicef/etools-partner-reporting-portal/statuses/0cc3bf6a26630cf26f05afb3a0121694ff014dc6"}}}}
{"actor":{"display_login":"rkrupinski"}}