{"action":"created","issue":{"url":"https://api.github.com/repos/philc/vimium/issues/2513","repository_url":"https://api.github.com/repos/philc/vimium","labels_url":"https://api.github.com/repos/philc/vimium/issues/2513/labels{/name}","comments_url":"https://api.github.com/repos/philc/vimium/issues/2513/comments","events_url":"https://api.github.com/repos/philc/vimium/issues/2513/events","html_url":"https://github.com/philc/vimium/issues/2513","id":229110299,"number":2513,"title":"Vimium breaks escape/meta key in google sheets, despite excluding all keys for the site","user":{"login":"cbetti","id":1813522,"avatar_url":"https://avatars0.githubusercontent.com/u/1813522?v=3","gravatar_id":"","url":"https://api.github.com/users/cbetti","html_url":"https://github.com/cbetti","followers_url":"https://api.github.com/users/cbetti/followers","following_url":"https://api.github.com/users/cbetti/following{/other_user}","gists_url":"https://api.github.com/users/cbetti/gists{/gist_id}","starred_url":"https://api.github.com/users/cbetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbetti/subscriptions","organizations_url":"https://api.github.com/users/cbetti/orgs","repos_url":"https://api.github.com/users/cbetti/repos","events_url":"https://api.github.com/users/cbetti/events{/privacy}","received_events_url":"https://api.github.com/users/cbetti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-16T17:28:20Z","updated_at":"2017-05-17T04:33:54Z","closed_at":null,"body":"**Reproduction**\r\n\r\n1. Create a rule to exclude all vimium key bindings from google sheets.\r\n2. Edit a spreadsheet cell.\r\n3. Press ESC key.\r\n\r\n**Expected**\r\nCell changes are cancelled and cell edit mode is terminated.\r\n\r\n**Actual**\r\nESC key does nothing.\r\n\r\n**Notes**\r\nIt seems like the ESC key is not excluded, despite an empty Exclude keys field in the rule. However, other vimium bindings are properly excluded. For example, pressing 'i' once causes a cell's contents to be replaced with the character 'i'.\r\n\r\n**Sys Info**\r\nOS X on MacBook Pro\r\nChrome Version 57.0.2987.133 (64-bit)\r\nVimium 1.59"},"comment":{"url":"https://api.github.com/repos/philc/vimium/issues/comments/301982748","html_url":"https://github.com/philc/vimium/issues/2513#issuecomment-301982748","issue_url":"https://api.github.com/repos/philc/vimium/issues/2513","id":301982748,"user":{"login":"smblott-github","id":2641335,"avatar_url":"https://avatars3.githubusercontent.com/u/2641335?v=3","gravatar_id":"","url":"https://api.github.com/users/smblott-github","html_url":"https://github.com/smblott-github","followers_url":"https://api.github.com/users/smblott-github/followers","following_url":"https://api.github.com/users/smblott-github/following{/other_user}","gists_url":"https://api.github.com/users/smblott-github/gists{/gist_id}","starred_url":"https://api.github.com/users/smblott-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smblott-github/subscriptions","organizations_url":"https://api.github.com/users/smblott-github/orgs","repos_url":"https://api.github.com/users/smblott-github/repos","events_url":"https://api.github.com/users/smblott-github/events{/privacy}","received_events_url":"https://api.github.com/users/smblott-github/received_events","type":"User","site_admin":false},"created_at":"2017-05-17T04:33:54Z","updated_at":"2017-05-17T04:33:54Z","body":"> Cell changes are cancelled and cell edit mode is terminated.\r\n\r\n@cbetti... This (expected) behaviour is the behaviour I see; so, cannot reproduce.  Moreover, looking at the code, then Vimium's keyboard handlers are (correctly) skipped if Vimium is disabled on a page."}}
{"actor":{"display_login":"smblott-github"}}