{"action":"created","issue":{"url":"https://api.github.com/repos/movableink/ics-generator/issues/6","repository_url":"https://api.github.com/repos/movableink/ics-generator","labels_url":"https://api.github.com/repos/movableink/ics-generator/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/movableink/ics-generator/issues/6/comments","events_url":"https://api.github.com/repos/movableink/ics-generator/issues/6/events","html_url":"https://github.com/movableink/ics-generator/pull/6","id":261130199,"number":6,"title":"Hardcode Ect/GMT for passed times, expecting UTC dates","user":{"login":"jacobjzhang","id":6591285,"avatar_url":"https://avatars1.githubusercontent.com/u/6591285?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobjzhang","html_url":"https://github.com/jacobjzhang","followers_url":"https://api.github.com/users/jacobjzhang/followers","following_url":"https://api.github.com/users/jacobjzhang/following{/other_user}","gists_url":"https://api.github.com/users/jacobjzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobjzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobjzhang/subscriptions","organizations_url":"https://api.github.com/users/jacobjzhang/orgs","repos_url":"https://api.github.com/users/jacobjzhang/repos","events_url":"https://api.github.com/users/jacobjzhang/events{/privacy}","received_events_url":"https://api.github.com/users/jacobjzhang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-27T21:54:29Z","updated_at":"2017-09-28T14:22:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/movableink/ics-generator/pulls/6","html_url":"https://github.com/movableink/ics-generator/pull/6","diff_url":"https://github.com/movableink/ics-generator/pull/6.diff","patch_url":"https://github.com/movableink/ics-generator/pull/6.patch"},"body":"Some background: since the origin of the ICS generator, we've had:\r\n\r\n`X-WR-TIMEZONE:<%= timezone %>`\r\n\r\nand\r\n\r\n```\r\nDTSTART;TZID=<%= timezone %>:<%= startDate %>\r\nDTEND;TZID=<%= timezone %>:<%= endDate %>\r\n```\r\n\r\nin the template file. The `<%= timezone% =>` in `X-WR-TIMEZONE` would localize the start time to the recipient's timezone, and the `<%= timezone% =>` in `DSTART` and `DTEND` were the timezones that the event was taking place in.\r\n\r\nThis never raised any red flags, as most of our clients would use this app to notify their customers of events in their old timezone (e.g. East coast companies would be planning east coast events for east coast customers). \r\n\r\nHowever, this became a problem when the event was in a certain timezone (say, JST in Japan), and recipients included people in Europe and the Americas. Because we were passing the same value in both fields, this would render as the incorrect time in the calendar.\r\n\r\nIt seems like the best option at the moment, given the issues of `Add-to-Cal` and https://github.com/movableink/studio-add-to-calendar/pull/4, is to always pass the event time in a standardized, UTC format. Thus, the change here would be that we always anticipate a UTC formatted timezone moving forward."},"comment":{"url":"https://api.github.com/repos/movableink/ics-generator/issues/comments/332852092","html_url":"https://github.com/movableink/ics-generator/pull/6#issuecomment-332852092","issue_url":"https://api.github.com/repos/movableink/ics-generator/issues/6","id":332852092,"user":{"login":"snackzone","id":13219985,"avatar_url":"https://avatars1.githubusercontent.com/u/13219985?v=4","gravatar_id":"","url":"https://api.github.com/users/snackzone","html_url":"https://github.com/snackzone","followers_url":"https://api.github.com/users/snackzone/followers","following_url":"https://api.github.com/users/snackzone/following{/other_user}","gists_url":"https://api.github.com/users/snackzone/gists{/gist_id}","starred_url":"https://api.github.com/users/snackzone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snackzone/subscriptions","organizations_url":"https://api.github.com/users/snackzone/orgs","repos_url":"https://api.github.com/users/snackzone/repos","events_url":"https://api.github.com/users/snackzone/events{/privacy}","received_events_url":"https://api.github.com/users/snackzone/received_events","type":"User","site_admin":false},"created_at":"2017-09-28T14:22:29Z","updated_at":"2017-09-28T14:22:29Z","author_association":"CONTRIBUTOR","body":"I think your suggestion of passing the 'Z' at the end of the datetime object (Zulu time!) makes sense. \r\n\r\nRight now the time generated depends on both the ics generator and the add to calendar app working together. Moving all of the business logic into the app seems like a good thing, and hopefully will remove the need for PRs being made across both repos."}}
{"actor":{"display_login":"snackzone"}}