{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/normandy/issues/613","repository_url":"https://api.github.com/repos/mozilla/normandy","labels_url":"https://api.github.com/repos/mozilla/normandy/issues/613/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/normandy/issues/613/comments","events_url":"https://api.github.com/repos/mozilla/normandy/issues/613/events","html_url":"https://github.com/mozilla/normandy/pull/613","id":214222164,"number":613,"title":"Merge peer-signing feature branch into master","user":{"login":"rehandalal","id":987136,"avatar_url":"https://avatars1.githubusercontent.com/u/987136?v=3","gravatar_id":"","url":"https://api.github.com/users/rehandalal","html_url":"https://github.com/rehandalal","followers_url":"https://api.github.com/users/rehandalal/followers","following_url":"https://api.github.com/users/rehandalal/following{/other_user}","gists_url":"https://api.github.com/users/rehandalal/gists{/gist_id}","starred_url":"https://api.github.com/users/rehandalal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehandalal/subscriptions","organizations_url":"https://api.github.com/users/rehandalal/orgs","repos_url":"https://api.github.com/users/rehandalal/repos","events_url":"https://api.github.com/users/rehandalal/events{/privacy}","received_events_url":"https://api.github.com/users/rehandalal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Osmose","id":193106,"avatar_url":"https://avatars2.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},"assignees":[{"login":"Osmose","id":193106,"avatar_url":"https://avatars2.githubusercontent.com/u/193106?v=3","gravatar_id":"","url":"https://api.github.com/users/Osmose","html_url":"https://github.com/Osmose","followers_url":"https://api.github.com/users/Osmose/followers","following_url":"https://api.github.com/users/Osmose/following{/other_user}","gists_url":"https://api.github.com/users/Osmose/gists{/gist_id}","starred_url":"https://api.github.com/users/Osmose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Osmose/subscriptions","organizations_url":"https://api.github.com/users/Osmose/orgs","repos_url":"https://api.github.com/users/Osmose/repos","events_url":"https://api.github.com/users/Osmose/events{/privacy}","received_events_url":"https://api.github.com/users/Osmose/received_events","type":"User","site_admin":false},{"login":"mythmon","id":305049,"avatar_url":"https://avatars0.githubusercontent.com/u/305049?v=3","gravatar_id":"","url":"https://api.github.com/users/mythmon","html_url":"https://github.com/mythmon","followers_url":"https://api.github.com/users/mythmon/followers","following_url":"https://api.github.com/users/mythmon/following{/other_user}","gists_url":"https://api.github.com/users/mythmon/gists{/gist_id}","starred_url":"https://api.github.com/users/mythmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mythmon/subscriptions","organizations_url":"https://api.github.com/users/mythmon/orgs","repos_url":"https://api.github.com/users/mythmon/repos","events_url":"https://api.github.com/users/mythmon/events{/privacy}","received_events_url":"https://api.github.com/users/mythmon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-03-14T22:11:52Z","updated_at":"2017-03-29T16:18:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/normandy/pulls/613","html_url":"https://github.com/mozilla/normandy/pull/613","diff_url":"https://github.com/mozilla/normandy/pull/613.diff","patch_url":"https://github.com/mozilla/normandy/pull/613.patch"},"body":"ec829a6 is the relevant merge commit.\r\n\r\nr?"},"comment":{"url":"https://api.github.com/repos/mozilla/normandy/issues/comments/290142447","html_url":"https://github.com/mozilla/normandy/pull/613#issuecomment-290142447","issue_url":"https://api.github.com/repos/mozilla/normandy/issues/613","id":290142447,"user":{"login":"andymikulski","id":2767162,"avatar_url":"https://avatars2.githubusercontent.com/u/2767162?v=3","gravatar_id":"","url":"https://api.github.com/users/andymikulski","html_url":"https://github.com/andymikulski","followers_url":"https://api.github.com/users/andymikulski/followers","following_url":"https://api.github.com/users/andymikulski/following{/other_user}","gists_url":"https://api.github.com/users/andymikulski/gists{/gist_id}","starred_url":"https://api.github.com/users/andymikulski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymikulski/subscriptions","organizations_url":"https://api.github.com/users/andymikulski/orgs","repos_url":"https://api.github.com/users/andymikulski/repos","events_url":"https://api.github.com/users/andymikulski/events{/privacy}","received_events_url":"https://api.github.com/users/andymikulski/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T16:18:29Z","updated_at":"2017-03-29T16:18:29Z","body":"1 + 2. There was an issue with the form not updating the recipes in memory - though the changes are sent to API and saved, the 'selected revision' was not updated locally, so the form didn't know that it needed to update.\r\n\r\n3. You're right that the PATCH isn't saving the data passed to it - @rehandalal will need to check that out. There was also a front end issue where the page grabbed the `is approved` and `is enabled` value from the wrong place, which has been fixed.\r\n\r\n4. The loading indicator should be fixed with the patch for 1 + 2, though with the non-working PATCH, the form appears with incorrect information. Fixing the API should fix all the 'outdated info' issues."}}
{"actor":{"display_login":"andymikulski"}}