{"push_id":2126728046,"size":6,"distinct_size":6,"ref":"refs/heads/master","head":"6a02b02700d65c842e757ff1559d5bff10ab5724","before":"b05caba044231f3bc8fa6b3300305ef6058ba41e","commits":[{"sha":"019954975949a3626e56c308a9441c6bbfdb80a7","author":{"name":"Thomas Broyer","email":"cd78b2cf9f6a97fe88bd214d6fb33f41d755737a@ltgt.net"},"message":"Add missing FranceConnect.soy to SoyFileSet\n\nChange-Id: Ie8d74f8190f08981cdc8d4f96b1da6fed10ebc84","distinct":true,"url":"https://api.github.com/repos/ozwillo/ozwillo-kernel/commits/019954975949a3626e56c308a9441c6bbfdb80a7"},{"sha":"57ffccb9e0b8f0ccaf15bb2ac747005315c11cd5","author":{"name":"Thomas Broyer","email":"cd78b2cf9f6a97fe88bd214d6fb33f41d755737a@ltgt.net"},"message":"Fix catalog not returning some visible services in certain circumstances\n\nSpecifically, the JongoCatalogEntryRepository (used when there's\nno fulltext search terms) did not account for the 'visibility'\nfield, so it wasn't returning services whose 'visible' field had\nbeen removed and replaced with 'visibility'.\n\nChange-Id: I77d937da9ea3166edaf090f24e10d1e655e70559","distinct":true,"url":"https://api.github.com/repos/ozwillo/ozwillo-kernel/commits/57ffccb9e0b8f0ccaf15bb2ac747005315c11cd5"},{"sha":"734560d875b6ba78ffd826b21561e27cf9bc3b02","author":{"name":"Thomas Broyer","email":"cd78b2cf9f6a97fe88bd214d6fb33f41d755737a@ltgt.net"},"message":"Fix catalog not unindexing services when changed to hidden\n\nLogic was here, but wasn't looking at the correct data, and\nwould never unindex a service due to a change of visibility.\n\nNote that this is still partially flawed, as the unindexing\nrequest outcome is ignored (only logged). Ideally, we should\nunindex first then update MongoDB (so that an undexing error\nwould be returned to the caller; and a MongoDB error would\nonly produce false-negatives from the index, never false-\npositives like today); that would however mean that the\nindex would have to be capable of checking the version for\noptimistic locks; or make the update dance more complex\n(e.g. get the doc from the index, then delete it, unconditionally,\nthen update MongoDB, and if it fails with an invalid version\nthen we can re-insert the document in the index).\nAn alternative would be to have a queue of indexation tasks,\nso we could queue the deletion and have it repeated (requeued)\nuntil it succeeds and we get into an eventually consistent state.\n\nChange-Id: I8cba9dae619d917fa220cf5f3dc6c503471b7501","distinct":true,"url":"https://api.github.com/repos/ozwillo/ozwillo-kernel/commits/734560d875b6ba78ffd826b21561e27cf9bc3b02"},{"sha":"8f6bcfce13354a35cda72505ebbe3a7cbe9a9eb5","author":{"name":"Thomas Broyer","email":"cd78b2cf9f6a97fe88bd214d6fb33f41d755737a@ltgt.net"},"message":"Fix catalog not returning some visible services in certain circumstances\n\nSpecifically, the JongoCatalogEntryRepository (used when there's\nno fulltext search terms) did not account for the 'visibility'\nfield, so it wasn't returning services whose 'visible' field had\nbeen removed and replaced with 'visibility'.\n\nChange-Id: I77d937da9ea3166edaf090f24e10d1e655e70559\n\n# Conflicts:\n#\toasis-webapp/src/main/java/oasis/jongo/applications/v2/JongoCatalogEntryRepository.java","distinct":true,"url":"https://api.github.com/repos/ozwillo/ozwillo-kernel/commits/8f6bcfce13354a35cda72505ebbe3a7cbe9a9eb5"},{"sha":"33ab56d05cb5b4652d84ba0405f657d740937570","author":{"name":"Thomas Broyer","email":"cd78b2cf9f6a97fe88bd214d6fb33f41d755737a@ltgt.net"},"message":"Fix catalog not unindexing services when changed to hidden\n\nLogic was here, but wasn't looking at the correct data, and\nwould never unindex a service due to a change of visibility.\n\nNote that this is still partially flawed, as the unindexing\nrequest outcome is ignored (only logged). Ideally, we should\nunindex first then update MongoDB (so that an undexing error\nwould be returned to the caller; and a MongoDB error would\nonly produce false-negatives from the index, never false-\npositives like today); that would however mean that the\nindex would have to be capable of checking the version for\noptimistic locks; or make the update dance more complex\n(e.g. get the doc from the index, then delete it, unconditionally,\nthen update MongoDB, and if it fails with an invalid version\nthen we can re-insert the document in the index).\nAn alternative would be to have a queue of indexation tasks,\nso we could queue the deletion and have it repeated (requeued)\nuntil it succeeds and we get into an eventually consistent state.\n\nChange-Id: I8cba9dae619d917fa220cf5f3dc6c503471b7501\n\n# Conflicts:\n#\toasis-webapp/src/main/java/oasis/catalog/IndexingServiceRepository.java","distinct":true,"url":"https://api.github.com/repos/ozwillo/ozwillo-kernel/commits/33ab56d05cb5b4652d84ba0405f657d740937570"},{"sha":"6a02b02700d65c842e757ff1559d5bff10ab5724","author":{"name":"Thomas Broyer","email":"cd78b2cf9f6a97fe88bd214d6fb33f41d755737a@ltgt.net"},"message":"Merge branch 'v1.48.x' into 'master'\n\nChange-Id: I978edbd84a15a5d8aa39d2d12a8019471b49c720","distinct":true,"url":"https://api.github.com/repos/ozwillo/ozwillo-kernel/commits/6a02b02700d65c842e757ff1559d5bff10ab5724"}]}
{"actor":{"display_login":"tbroyer"}}