{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/hono/pulls/comments/139605535","pull_request_review_id":63559233,"id":139605535,"diff_hunk":"@@ -81,7 +87,8 @@ public HonoReceiver(final HonoReceiverSampler sampler) throws InterruptedExcepti\n     private void connect() throws InterruptedException {\n         final CountDownLatch receiverConnectLatch = new CountDownLatch(1);\n         amqpNetworkClient = new HonoClientImpl(vertx, amqpNetworkConnectionFactory);\n-        amqpNetworkClient.connect(getClientOptions(), connectionHandler -> {\n+        amqpNetworkClient.connect(getClientOptions(Integer.parseInt(sampler.getReconnectAttempts())),\n+                connectionHandler -> {","path":"jmeter/src/main/java/org/eclipse/hono/jmeter/client/HonoReceiver.java","position":null,"original_position":69,"commit_id":"720c7a01453e09b84485ae5d76d70d87e56c3029","original_commit_id":"694d68dacbf49a22e0bf620e7688a219926222b6","user":{"login":"pellmann","id":12810428,"avatar_url":"https://avatars0.githubusercontent.com/u/12810428?v=4","gravatar_id":"","url":"https://api.github.com/users/pellmann","html_url":"https://github.com/pellmann","followers_url":"https://api.github.com/users/pellmann/followers","following_url":"https://api.github.com/users/pellmann/following{/other_user}","gists_url":"https://api.github.com/users/pellmann/gists{/gist_id}","starred_url":"https://api.github.com/users/pellmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pellmann/subscriptions","organizations_url":"https://api.github.com/users/pellmann/orgs","repos_url":"https://api.github.com/users/pellmann/repos","events_url":"https://api.github.com/users/pellmann/events{/privacy}","received_events_url":"https://api.github.com/users/pellmann/received_events","type":"User","site_admin":false},"body":"Yes, but for a user without the code it might be better to give him a hint to the reconnect attempts field, I think.","created_at":"2017-09-19T06:24:49Z","updated_at":"2017-09-19T06:24:49Z","html_url":"https://github.com/eclipse/hono/pull/338#discussion_r139605535","pull_request_url":"https://api.github.com/repos/eclipse/hono/pulls/338","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments/139605535"},"html":{"href":"https://github.com/eclipse/hono/pull/338#discussion_r139605535"},"pull_request":{"href":"https://api.github.com/repos/eclipse/hono/pulls/338"}},"in_reply_to_id":139401859},"pull_request":{"url":"https://api.github.com/repos/eclipse/hono/pulls/338","id":141268867,"html_url":"https://github.com/eclipse/hono/pull/338","diff_url":"https://github.com/eclipse/hono/pull/338.diff","patch_url":"https://github.com/eclipse/hono/pull/338.patch","issue_url":"https://api.github.com/repos/eclipse/hono/issues/338","number":338,"state":"open","locked":false,"title":"Hono JMeter Plugin: using the time stamp from the message received for sampling","user":{"login":"balsmn","id":17613889,"avatar_url":"https://avatars0.githubusercontent.com/u/17613889?v=4","gravatar_id":"","url":"https://api.github.com/users/balsmn","html_url":"https://github.com/balsmn","followers_url":"https://api.github.com/users/balsmn/followers","following_url":"https://api.github.com/users/balsmn/following{/other_user}","gists_url":"https://api.github.com/users/balsmn/gists{/gist_id}","starred_url":"https://api.github.com/users/balsmn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balsmn/subscriptions","organizations_url":"https://api.github.com/users/balsmn/orgs","repos_url":"https://api.github.com/users/balsmn/repos","events_url":"https://api.github.com/users/balsmn/events{/privacy}","received_events_url":"https://api.github.com/users/balsmn/received_events","type":"User","site_admin":false},"body":"As part of this PR a new feature for JMeter Hono plugin is provided. Hono JMeter plugin could now use the time stamp from the received message for sampling. This is esspecially useful when a JMeter scenario contains delays between sending messages to Hono and receiving it. The time stamp can either be part of the payload (restricted currently to JSON format) or as Application property.\r\n\r\nSigned-off-by: Balasubramanian <balasubramanian.azhagappan@bosch-si.com>","created_at":"2017-09-15T09:39:53Z","updated_at":"2017-09-19T06:24:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a404006c955ff7aff76373199b6664dfafc83386","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/hono/pulls/338/commits","review_comments_url":"https://api.github.com/repos/eclipse/hono/pulls/338/comments","review_comment_url":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/hono/issues/338/comments","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/720c7a01453e09b84485ae5d76d70d87e56c3029","head":{"label":"bsinno:PR/jmeter_use_sender_timer","ref":"PR/jmeter_use_sender_timer","sha":"720c7a01453e09b84485ae5d76d70d87e56c3029","user":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":51764062,"name":"hono","full_name":"bsinno/hono","owner":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsinno/hono","description":"Hono project","fork":true,"url":"https://api.github.com/repos/bsinno/hono","forks_url":"https://api.github.com/repos/bsinno/hono/forks","keys_url":"https://api.github.com/repos/bsinno/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/hono/teams","hooks_url":"https://api.github.com/repos/bsinno/hono/hooks","issue_events_url":"https://api.github.com/repos/bsinno/hono/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/hono/events","assignees_url":"https://api.github.com/repos/bsinno/hono/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/hono/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/hono/tags","blobs_url":"https://api.github.com/repos/bsinno/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/hono/languages","stargazers_url":"https://api.github.com/repos/bsinno/hono/stargazers","contributors_url":"https://api.github.com/repos/bsinno/hono/contributors","subscribers_url":"https://api.github.com/repos/bsinno/hono/subscribers","subscription_url":"https://api.github.com/repos/bsinno/hono/subscription","commits_url":"https://api.github.com/repos/bsinno/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/hono/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/hono/merges","archive_url":"https://api.github.com/repos/bsinno/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/hono/downloads","issues_url":"https://api.github.com/repos/bsinno/hono/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/hono/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/hono/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/hono/deployments","created_at":"2016-02-15T15:18:09Z","updated_at":"2017-03-14T22:30:42Z","pushed_at":"2017-09-18T22:27:00Z","git_url":"git://github.com/bsinno/hono.git","ssh_url":"git@github.com:bsinno/hono.git","clone_url":"https://github.com/bsinno/hono.git","svn_url":"https://github.com/bsinno/hono","homepage":null,"size":7118,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"89f66884d782a57c30f6d09268850f06fbf26a15","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":51307016,"name":"hono","full_name":"eclipse/hono","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/hono","description":"Eclipse Hono™ Project","fork":false,"url":"https://api.github.com/repos/eclipse/hono","forks_url":"https://api.github.com/repos/eclipse/hono/forks","keys_url":"https://api.github.com/repos/eclipse/hono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/hono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/hono/teams","hooks_url":"https://api.github.com/repos/eclipse/hono/hooks","issue_events_url":"https://api.github.com/repos/eclipse/hono/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/hono/events","assignees_url":"https://api.github.com/repos/eclipse/hono/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/hono/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/hono/tags","blobs_url":"https://api.github.com/repos/eclipse/hono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/hono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/hono/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/hono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/hono/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/hono/languages","stargazers_url":"https://api.github.com/repos/eclipse/hono/stargazers","contributors_url":"https://api.github.com/repos/eclipse/hono/contributors","subscribers_url":"https://api.github.com/repos/eclipse/hono/subscribers","subscription_url":"https://api.github.com/repos/eclipse/hono/subscription","commits_url":"https://api.github.com/repos/eclipse/hono/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/hono/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/hono/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/hono/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/hono/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/hono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/hono/merges","archive_url":"https://api.github.com/repos/eclipse/hono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/hono/downloads","issues_url":"https://api.github.com/repos/eclipse/hono/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/hono/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/hono/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/hono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/hono/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/hono/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/hono/deployments","created_at":"2016-02-08T15:45:28Z","updated_at":"2017-09-05T11:23:03Z","pushed_at":"2017-09-18T15:19:50Z","git_url":"git://github.com/eclipse/hono.git","ssh_url":"git@github.com:eclipse/hono.git","clone_url":"https://github.com/eclipse/hono.git","svn_url":"https://github.com/eclipse/hono","homepage":"http://www.eclipse.org/hono","size":7834,"stargazers_count":86,"watchers_count":86,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":36,"forks":25,"open_issues":36,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/hono/pulls/338"},"html":{"href":"https://github.com/eclipse/hono/pull/338"},"issue":{"href":"https://api.github.com/repos/eclipse/hono/issues/338"},"comments":{"href":"https://api.github.com/repos/eclipse/hono/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/hono/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/hono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/hono/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/hono/statuses/720c7a01453e09b84485ae5d76d70d87e56c3029"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pellmann"}}