{"action":"created","issue":{"url":"https://api.github.com/repos/unrolled/render/issues/63","repository_url":"https://api.github.com/repos/unrolled/render","labels_url":"https://api.github.com/repos/unrolled/render/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/unrolled/render/issues/63/comments","events_url":"https://api.github.com/repos/unrolled/render/issues/63/events","html_url":"https://github.com/unrolled/render/pull/63","id":262173961,"number":63,"title":"RenderPartialsWithoutPrefix should be RenderPartialsWithoutSuffix ","user":{"login":"doctoro","id":433794,"avatar_url":"https://avatars1.githubusercontent.com/u/433794?v=4","gravatar_id":"","url":"https://api.github.com/users/doctoro","html_url":"https://github.com/doctoro","followers_url":"https://api.github.com/users/doctoro/followers","following_url":"https://api.github.com/users/doctoro/following{/other_user}","gists_url":"https://api.github.com/users/doctoro/gists{/gist_id}","starred_url":"https://api.github.com/users/doctoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctoro/subscriptions","organizations_url":"https://api.github.com/users/doctoro/orgs","repos_url":"https://api.github.com/users/doctoro/repos","events_url":"https://api.github.com/users/doctoro/events{/privacy}","received_events_url":"https://api.github.com/users/doctoro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-02T18:05:34Z","updated_at":"2017-10-03T20:09:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/unrolled/render/pulls/63","html_url":"https://github.com/unrolled/render/pull/63","diff_url":"https://github.com/unrolled/render/pull/63.diff","patch_url":"https://github.com/unrolled/render/pull/63.patch"},"body":"The option is called RenderPartialsWithoutPrefix, however the intent is to allow you omit the suffix. Changed it to RenderPartialsWithoutSuffix.\r\n\r\nVery minor quibble for an otherwise incredibly useful library :-)\r\n"},"comment":{"url":"https://api.github.com/repos/unrolled/render/issues/comments/333963020","html_url":"https://github.com/unrolled/render/pull/63#issuecomment-333963020","issue_url":"https://api.github.com/repos/unrolled/render/issues/63","id":333963020,"user":{"login":"unrolled","id":407228,"avatar_url":"https://avatars3.githubusercontent.com/u/407228?v=4","gravatar_id":"","url":"https://api.github.com/users/unrolled","html_url":"https://github.com/unrolled","followers_url":"https://api.github.com/users/unrolled/followers","following_url":"https://api.github.com/users/unrolled/following{/other_user}","gists_url":"https://api.github.com/users/unrolled/gists{/gist_id}","starred_url":"https://api.github.com/users/unrolled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unrolled/subscriptions","organizations_url":"https://api.github.com/users/unrolled/orgs","repos_url":"https://api.github.com/users/unrolled/repos","events_url":"https://api.github.com/users/unrolled/events{/privacy}","received_events_url":"https://api.github.com/users/unrolled/received_events","type":"User","site_admin":false},"created_at":"2017-10-03T20:09:14Z","updated_at":"2017-10-03T20:09:14Z","author_association":"OWNER","body":"Hey @doctoro, thanks for the PR! You are 100% correct that this function was mislabeled... my bad for not catching this before!\r\n\r\nHowever, I'm not going to change it's name for the sake of backwards compatibility. If someone is already using this option, we rename it, and they update to the latest version of `render`... their code would no longer compile as that option would no longer exist!\r\n\r\nIf you would like, we could change the comment pointing out this fact as an interim \"solution\". Then if we ever create v2 of `render`, we can correct this issue as some API compatibility issues would be expected with a major update."}}
{"actor":{"display_login":"unrolled"}}