{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/comments/99085181","pull_request_review_id":19747282,"id":99085181,"diff_hunk":"@@ -189,7 +189,7 @@ def guess_content_type_and_encoding(path):\n                 tc_response['putUrl'], data=fh, headers=_craft_artifact_put_headers(content_type, content_encoding),\n                 skip_auto_headers=skip_auto_headers, compress=False\n             ) as resp:\n-                log.info(resp.status)\n+                log.info(\"create_artifact {}: {}\".format(path, resp.status))","path":"scriptworker/artifacts.py","position":5,"original_position":5,"commit_id":"ba876a8ad22db5700ab25b9da3385b171633200b","original_commit_id":"ba876a8ad22db5700ab25b9da3385b171633200b","user":{"login":"JohanLorenzo","id":5907366,"avatar_url":"https://avatars.githubusercontent.com/u/5907366?v=3","gravatar_id":"","url":"https://api.github.com/users/JohanLorenzo","html_url":"https://github.com/JohanLorenzo","followers_url":"https://api.github.com/users/JohanLorenzo/followers","following_url":"https://api.github.com/users/JohanLorenzo/following{/other_user}","gists_url":"https://api.github.com/users/JohanLorenzo/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanLorenzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanLorenzo/subscriptions","organizations_url":"https://api.github.com/users/JohanLorenzo/orgs","repos_url":"https://api.github.com/users/JohanLorenzo/repos","events_url":"https://api.github.com/users/JohanLorenzo/events{/privacy}","received_events_url":"https://api.github.com/users/JohanLorenzo/received_events","type":"User","site_admin":false},"body":"Sweet! ","created_at":"2017-02-02T10:01:25Z","updated_at":"2017-02-02T10:02:01Z","html_url":"https://github.com/mozilla-releng/scriptworker/pull/72#discussion_r99085181","pull_request_url":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/comments/99085181"},"html":{"href":"https://github.com/mozilla-releng/scriptworker/pull/72#discussion_r99085181"},"pull_request":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/72","id":104206424,"html_url":"https://github.com/mozilla-releng/scriptworker/pull/72","diff_url":"https://github.com/mozilla-releng/scriptworker/pull/72.diff","patch_url":"https://github.com/mozilla-releng/scriptworker/pull/72.patch","issue_url":"https://api.github.com/repos/mozilla-releng/scriptworker/issues/72","number":72,"state":"open","locked":false,"title":"fix taskcluster>=1.0.0 support; improve upload logging","user":{"login":"escapewindow","id":826343,"avatar_url":"https://avatars.githubusercontent.com/u/826343?v=3","gravatar_id":"","url":"https://api.github.com/users/escapewindow","html_url":"https://github.com/escapewindow","followers_url":"https://api.github.com/users/escapewindow/followers","following_url":"https://api.github.com/users/escapewindow/following{/other_user}","gists_url":"https://api.github.com/users/escapewindow/gists{/gist_id}","starred_url":"https://api.github.com/users/escapewindow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escapewindow/subscriptions","organizations_url":"https://api.github.com/users/escapewindow/orgs","repos_url":"https://api.github.com/users/escapewindow/repos","events_url":"https://api.github.com/users/escapewindow/events{/privacy}","received_events_url":"https://api.github.com/users/escapewindow/received_events","type":"User","site_admin":false},"body":"First, `taskcluster>=1.0.0` changes how we make new artifact urls.  I think this is an improvement, but it breaks `get_artifact_url`.  I added support for 1.0.x without breaking 0.3.x for now; we can tear out 0.3.x support once we're on >=1.0.0 for a while and don't foresee needing to go back.\r\n\r\nSecond, while debugging async uploads, we see lots of this:\r\n\r\n```\r\n2017-01-25 19:29:53,340 - scriptworker.utils - DEBUG - retry_async: <function put at 0x7f99bcc7f2f0>: sleeping before retry\r\n2017-01-25 19:29:53,341 - beetmoverscript.script - INFO - 200\r\n2017-01-25 19:29:53,342 - beetmoverscript.script - INFO - \r\n2017-01-25 19:29:53,349 - beetmoverscript.script - INFO - 200\r\n2017-01-25 19:29:53,350 - beetmoverscript.script - INFO - \r\n2017-01-25 19:29:53,355 - beetmoverscript.script - INFO - 200\r\n2017-01-25 19:29:53,357 - beetmoverscript.script - INFO - \r\n2017-01-25 19:29:53,360 - beetmoverscript.script - INFO - 200\r\n2017-01-25 19:29:53,363 - beetmoverscript.script - INFO - \r\n2017-01-25 19:29:56,922 - beetmoverscript.script - INFO - 400\r\n```\r\n\r\nIt's not clear which artifacts are succeeding and which are retrying.  By adding the path before the status, we'll be able to debug a bit easier.  We'll need a similar patch for beetmoverscript.","created_at":"2017-02-01T19:40:51Z","updated_at":"2017-02-02T10:02:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d054dea056c437f2cda0b2fef13211f7cf5a3984","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/72/commits","review_comments_url":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/72/comments","review_comment_url":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-releng/scriptworker/issues/72/comments","statuses_url":"https://api.github.com/repos/mozilla-releng/scriptworker/statuses/ba876a8ad22db5700ab25b9da3385b171633200b","head":{"label":"escapewindow:fix-downloads","ref":"fix-downloads","sha":"ba876a8ad22db5700ab25b9da3385b171633200b","user":{"login":"escapewindow","id":826343,"avatar_url":"https://avatars.githubusercontent.com/u/826343?v=3","gravatar_id":"","url":"https://api.github.com/users/escapewindow","html_url":"https://github.com/escapewindow","followers_url":"https://api.github.com/users/escapewindow/followers","following_url":"https://api.github.com/users/escapewindow/following{/other_user}","gists_url":"https://api.github.com/users/escapewindow/gists{/gist_id}","starred_url":"https://api.github.com/users/escapewindow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escapewindow/subscriptions","organizations_url":"https://api.github.com/users/escapewindow/orgs","repos_url":"https://api.github.com/users/escapewindow/repos","events_url":"https://api.github.com/users/escapewindow/events{/privacy}","received_events_url":"https://api.github.com/users/escapewindow/received_events","type":"User","site_admin":false},"repo":{"id":63281828,"name":"scriptworker","full_name":"escapewindow/scriptworker","owner":{"login":"escapewindow","id":826343,"avatar_url":"https://avatars.githubusercontent.com/u/826343?v=3","gravatar_id":"","url":"https://api.github.com/users/escapewindow","html_url":"https://github.com/escapewindow","followers_url":"https://api.github.com/users/escapewindow/followers","following_url":"https://api.github.com/users/escapewindow/following{/other_user}","gists_url":"https://api.github.com/users/escapewindow/gists{/gist_id}","starred_url":"https://api.github.com/users/escapewindow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escapewindow/subscriptions","organizations_url":"https://api.github.com/users/escapewindow/orgs","repos_url":"https://api.github.com/users/escapewindow/repos","events_url":"https://api.github.com/users/escapewindow/events{/privacy}","received_events_url":"https://api.github.com/users/escapewindow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/escapewindow/scriptworker","description":"Minimal taskcluster worker for releng-oriented tasks","fork":true,"url":"https://api.github.com/repos/escapewindow/scriptworker","forks_url":"https://api.github.com/repos/escapewindow/scriptworker/forks","keys_url":"https://api.github.com/repos/escapewindow/scriptworker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/escapewindow/scriptworker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/escapewindow/scriptworker/teams","hooks_url":"https://api.github.com/repos/escapewindow/scriptworker/hooks","issue_events_url":"https://api.github.com/repos/escapewindow/scriptworker/issues/events{/number}","events_url":"https://api.github.com/repos/escapewindow/scriptworker/events","assignees_url":"https://api.github.com/repos/escapewindow/scriptworker/assignees{/user}","branches_url":"https://api.github.com/repos/escapewindow/scriptworker/branches{/branch}","tags_url":"https://api.github.com/repos/escapewindow/scriptworker/tags","blobs_url":"https://api.github.com/repos/escapewindow/scriptworker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/escapewindow/scriptworker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/escapewindow/scriptworker/git/refs{/sha}","trees_url":"https://api.github.com/repos/escapewindow/scriptworker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/escapewindow/scriptworker/statuses/{sha}","languages_url":"https://api.github.com/repos/escapewindow/scriptworker/languages","stargazers_url":"https://api.github.com/repos/escapewindow/scriptworker/stargazers","contributors_url":"https://api.github.com/repos/escapewindow/scriptworker/contributors","subscribers_url":"https://api.github.com/repos/escapewindow/scriptworker/subscribers","subscription_url":"https://api.github.com/repos/escapewindow/scriptworker/subscription","commits_url":"https://api.github.com/repos/escapewindow/scriptworker/commits{/sha}","git_commits_url":"https://api.github.com/repos/escapewindow/scriptworker/git/commits{/sha}","comments_url":"https://api.github.com/repos/escapewindow/scriptworker/comments{/number}","issue_comment_url":"https://api.github.com/repos/escapewindow/scriptworker/issues/comments{/number}","contents_url":"https://api.github.com/repos/escapewindow/scriptworker/contents/{+path}","compare_url":"https://api.github.com/repos/escapewindow/scriptworker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/escapewindow/scriptworker/merges","archive_url":"https://api.github.com/repos/escapewindow/scriptworker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/escapewindow/scriptworker/downloads","issues_url":"https://api.github.com/repos/escapewindow/scriptworker/issues{/number}","pulls_url":"https://api.github.com/repos/escapewindow/scriptworker/pulls{/number}","milestones_url":"https://api.github.com/repos/escapewindow/scriptworker/milestones{/number}","notifications_url":"https://api.github.com/repos/escapewindow/scriptworker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/escapewindow/scriptworker/labels{/name}","releases_url":"https://api.github.com/repos/escapewindow/scriptworker/releases{/id}","deployments_url":"https://api.github.com/repos/escapewindow/scriptworker/deployments","created_at":"2016-07-13T21:47:10Z","updated_at":"2016-07-13T21:47:11Z","pushed_at":"2017-02-01T19:29:25Z","git_url":"git://github.com/escapewindow/scriptworker.git","ssh_url":"git@github.com:escapewindow/scriptworker.git","clone_url":"https://github.com/escapewindow/scriptworker.git","svn_url":"https://github.com/escapewindow/scriptworker","homepage":null,"size":907,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-releng:master","ref":"master","sha":"278988f8be3854ab1928c7043fce1dc4b3f0d491","user":{"login":"mozilla-releng","id":19614164,"avatar_url":"https://avatars.githubusercontent.com/u/19614164?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-releng","html_url":"https://github.com/mozilla-releng","followers_url":"https://api.github.com/users/mozilla-releng/followers","following_url":"https://api.github.com/users/mozilla-releng/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-releng/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-releng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-releng/subscriptions","organizations_url":"https://api.github.com/users/mozilla-releng/orgs","repos_url":"https://api.github.com/users/mozilla-releng/repos","events_url":"https://api.github.com/users/mozilla-releng/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-releng/received_events","type":"Organization","site_admin":false},"repo":{"id":56792799,"name":"scriptworker","full_name":"mozilla-releng/scriptworker","owner":{"login":"mozilla-releng","id":19614164,"avatar_url":"https://avatars.githubusercontent.com/u/19614164?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-releng","html_url":"https://github.com/mozilla-releng","followers_url":"https://api.github.com/users/mozilla-releng/followers","following_url":"https://api.github.com/users/mozilla-releng/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-releng/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-releng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-releng/subscriptions","organizations_url":"https://api.github.com/users/mozilla-releng/orgs","repos_url":"https://api.github.com/users/mozilla-releng/repos","events_url":"https://api.github.com/users/mozilla-releng/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-releng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-releng/scriptworker","description":"Minimal taskcluster worker for releng-oriented tasks","fork":false,"url":"https://api.github.com/repos/mozilla-releng/scriptworker","forks_url":"https://api.github.com/repos/mozilla-releng/scriptworker/forks","keys_url":"https://api.github.com/repos/mozilla-releng/scriptworker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-releng/scriptworker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-releng/scriptworker/teams","hooks_url":"https://api.github.com/repos/mozilla-releng/scriptworker/hooks","issue_events_url":"https://api.github.com/repos/mozilla-releng/scriptworker/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-releng/scriptworker/events","assignees_url":"https://api.github.com/repos/mozilla-releng/scriptworker/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-releng/scriptworker/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-releng/scriptworker/tags","blobs_url":"https://api.github.com/repos/mozilla-releng/scriptworker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-releng/scriptworker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-releng/scriptworker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-releng/scriptworker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-releng/scriptworker/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-releng/scriptworker/languages","stargazers_url":"https://api.github.com/repos/mozilla-releng/scriptworker/stargazers","contributors_url":"https://api.github.com/repos/mozilla-releng/scriptworker/contributors","subscribers_url":"https://api.github.com/repos/mozilla-releng/scriptworker/subscribers","subscription_url":"https://api.github.com/repos/mozilla-releng/scriptworker/subscription","commits_url":"https://api.github.com/repos/mozilla-releng/scriptworker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-releng/scriptworker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-releng/scriptworker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-releng/scriptworker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-releng/scriptworker/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-releng/scriptworker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-releng/scriptworker/merges","archive_url":"https://api.github.com/repos/mozilla-releng/scriptworker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-releng/scriptworker/downloads","issues_url":"https://api.github.com/repos/mozilla-releng/scriptworker/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-releng/scriptworker/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-releng/scriptworker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-releng/scriptworker/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-releng/scriptworker/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-releng/scriptworker/deployments","created_at":"2016-04-21T17:22:40Z","updated_at":"2016-11-29T19:54:14Z","pushed_at":"2017-02-01T19:40:52Z","git_url":"git://github.com/mozilla-releng/scriptworker.git","ssh_url":"git@github.com:mozilla-releng/scriptworker.git","clone_url":"https://github.com/mozilla-releng/scriptworker.git","svn_url":"https://github.com/mozilla-releng/scriptworker","homepage":null,"size":822,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/72"},"html":{"href":"https://github.com/mozilla-releng/scriptworker/pull/72"},"issue":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/issues/72"},"comments":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-releng/scriptworker/statuses/ba876a8ad22db5700ab25b9da3385b171633200b"}}}}
{"actor":{"display_login":"JohanLorenzo"}}