{"action":"created","comment":{"url":"https://api.github.com/repos/golemfactory/golem/pulls/comments/145083966","pull_request_review_id":69829605,"id":145083966,"diff_hunk":"@@ -21,19 +18,12 @@ def append_ulong(self, num):\n             raise AttributeError(\"num must be grater than 0\")\r\n         str_num_rep = struct.pack(\"!L\", num)\r\n         self.buffered_data = b\"\".join([self.buffered_data, str_num_rep])\r\n-        return str_num_rep\r\n \r\n-    def append_string(self, data, check_size=True, overflow_prefix=None):\r\n+    def append_string(self, data):\r\n         \"\"\" Append given string to data buffer\r\n-        :param check_size: keep buffer size below MAX_BUFFER_SIZE\r\n-        :param overflow_prefix: string to prepend on overflow\r\n         :param str data: string to append\r\n         \"\"\"\r\n-        new_size = self.data_size() + len(data)\r\n-        if check_size and new_size > MAX_BUFFER_SIZE:\r\n-            self.buffered_data = b\"\".join([overflow_prefix or '', data])\r\n-        else:\r\n-            self.buffered_data = b\"\".join([self.buffered_data, data])\r\n+        self.buffered_data = b\"\".join([self.buffered_data, data])\r","path":"golem/core/databuffer.py","position":29,"original_position":29,"commit_id":"51ce34d5ed76224535d01dc53ee13d59c80a8f2d","original_commit_id":"51ce34d5ed76224535d01dc53ee13d59c80a8f2d","user":{"login":"etam","id":220752,"avatar_url":"https://avatars1.githubusercontent.com/u/220752?v=4","gravatar_id":"","url":"https://api.github.com/users/etam","html_url":"https://github.com/etam","followers_url":"https://api.github.com/users/etam/followers","following_url":"https://api.github.com/users/etam/following{/other_user}","gists_url":"https://api.github.com/users/etam/gists{/gist_id}","starred_url":"https://api.github.com/users/etam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etam/subscriptions","organizations_url":"https://api.github.com/users/etam/orgs","repos_url":"https://api.github.com/users/etam/repos","events_url":"https://api.github.com/users/etam/events{/privacy}","received_events_url":"https://api.github.com/users/etam/received_events","type":"User","site_admin":false},"body":"At 10000 bytes they become equal","created_at":"2017-10-17T10:05:59Z","updated_at":"2017-10-17T10:05:59Z","html_url":"https://github.com/golemfactory/golem/pull/1476#discussion_r145083966","pull_request_url":"https://api.github.com/repos/golemfactory/golem/pulls/1476","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/comments/145083966"},"html":{"href":"https://github.com/golemfactory/golem/pull/1476#discussion_r145083966"},"pull_request":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/1476"}},"in_reply_to_id":145054466},"pull_request":{"url":"https://api.github.com/repos/golemfactory/golem/pulls/1476","id":146036811,"html_url":"https://github.com/golemfactory/golem/pull/1476","diff_url":"https://github.com/golemfactory/golem/pull/1476.diff","patch_url":"https://github.com/golemfactory/golem/pull/1476.patch","issue_url":"https://api.github.com/repos/golemfactory/golem/issues/1476","number":1476,"state":"open","locked":false,"title":"Changes to message serialization, signing and verification","user":{"login":"mfranciszkiewicz","id":3238836,"avatar_url":"https://avatars2.githubusercontent.com/u/3238836?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranciszkiewicz","html_url":"https://github.com/mfranciszkiewicz","followers_url":"https://api.github.com/users/mfranciszkiewicz/followers","following_url":"https://api.github.com/users/mfranciszkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/mfranciszkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranciszkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranciszkiewicz/subscriptions","organizations_url":"https://api.github.com/users/mfranciszkiewicz/orgs","repos_url":"https://api.github.com/users/mfranciszkiewicz/repos","events_url":"https://api.github.com/users/mfranciszkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/mfranciszkiewicz/received_events","type":"User","site_admin":false},"body":"- signature verification does not require message re-serialization\r\n- signature verification is no longer affected by the order of properties inside objects\r\n\r\nAddresses #1457","created_at":"2017-10-11T19:13:12Z","updated_at":"2017-10-17T10:05:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1858d4bcfd43001697e4581ce6fd06f29c5e0ae4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/golemfactory/golem/pulls/1476/commits","review_comments_url":"https://api.github.com/repos/golemfactory/golem/pulls/1476/comments","review_comment_url":"https://api.github.com/repos/golemfactory/golem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/golemfactory/golem/issues/1476/comments","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/51ce34d5ed76224535d01dc53ee13d59c80a8f2d","head":{"label":"golemfactory:p2p2-messages","ref":"p2p2-messages","sha":"51ce34d5ed76224535d01dc53ee13d59c80a8f2d","user":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":46433937,"name":"golem","full_name":"golemfactory/golem","owner":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/golem","description":"Golem is creating a global market for computing power.","fork":false,"url":"https://api.github.com/repos/golemfactory/golem","forks_url":"https://api.github.com/repos/golemfactory/golem/forks","keys_url":"https://api.github.com/repos/golemfactory/golem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/golem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/golem/teams","hooks_url":"https://api.github.com/repos/golemfactory/golem/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/golem/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/golem/events","assignees_url":"https://api.github.com/repos/golemfactory/golem/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/golem/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/golem/tags","blobs_url":"https://api.github.com/repos/golemfactory/golem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/golem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/golem/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/golem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/golem/languages","stargazers_url":"https://api.github.com/repos/golemfactory/golem/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/golem/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/golem/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/golem/subscription","commits_url":"https://api.github.com/repos/golemfactory/golem/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/golem/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/golem/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/golem/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/golem/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/golem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/golem/merges","archive_url":"https://api.github.com/repos/golemfactory/golem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/golem/downloads","issues_url":"https://api.github.com/repos/golemfactory/golem/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/golem/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/golem/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/golem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/golem/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/golem/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/golem/deployments","created_at":"2015-11-18T17:02:35Z","updated_at":"2017-10-17T09:07:15Z","pushed_at":"2017-10-17T06:54:46Z","git_url":"git://github.com/golemfactory/golem.git","ssh_url":"git@github.com:golemfactory/golem.git","clone_url":"https://github.com/golemfactory/golem.git","svn_url":"https://github.com/golemfactory/golem","homepage":"https://golem.network","size":74923,"stargazers_count":1591,"watchers_count":1591,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":234,"forks":156,"open_issues":234,"watchers":1591,"default_branch":"develop"}},"base":{"label":"golemfactory:develop","ref":"develop","sha":"a511bbc414e738fa639b7e14e9c339e919ffd7b1","user":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"repo":{"id":46433937,"name":"golem","full_name":"golemfactory/golem","owner":{"login":"golemfactory","id":23193179,"avatar_url":"https://avatars1.githubusercontent.com/u/23193179?v=4","gravatar_id":"","url":"https://api.github.com/users/golemfactory","html_url":"https://github.com/golemfactory","followers_url":"https://api.github.com/users/golemfactory/followers","following_url":"https://api.github.com/users/golemfactory/following{/other_user}","gists_url":"https://api.github.com/users/golemfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/golemfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golemfactory/subscriptions","organizations_url":"https://api.github.com/users/golemfactory/orgs","repos_url":"https://api.github.com/users/golemfactory/repos","events_url":"https://api.github.com/users/golemfactory/events{/privacy}","received_events_url":"https://api.github.com/users/golemfactory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/golemfactory/golem","description":"Golem is creating a global market for computing power.","fork":false,"url":"https://api.github.com/repos/golemfactory/golem","forks_url":"https://api.github.com/repos/golemfactory/golem/forks","keys_url":"https://api.github.com/repos/golemfactory/golem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/golemfactory/golem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/golemfactory/golem/teams","hooks_url":"https://api.github.com/repos/golemfactory/golem/hooks","issue_events_url":"https://api.github.com/repos/golemfactory/golem/issues/events{/number}","events_url":"https://api.github.com/repos/golemfactory/golem/events","assignees_url":"https://api.github.com/repos/golemfactory/golem/assignees{/user}","branches_url":"https://api.github.com/repos/golemfactory/golem/branches{/branch}","tags_url":"https://api.github.com/repos/golemfactory/golem/tags","blobs_url":"https://api.github.com/repos/golemfactory/golem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/golemfactory/golem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/golemfactory/golem/git/refs{/sha}","trees_url":"https://api.github.com/repos/golemfactory/golem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/golemfactory/golem/statuses/{sha}","languages_url":"https://api.github.com/repos/golemfactory/golem/languages","stargazers_url":"https://api.github.com/repos/golemfactory/golem/stargazers","contributors_url":"https://api.github.com/repos/golemfactory/golem/contributors","subscribers_url":"https://api.github.com/repos/golemfactory/golem/subscribers","subscription_url":"https://api.github.com/repos/golemfactory/golem/subscription","commits_url":"https://api.github.com/repos/golemfactory/golem/commits{/sha}","git_commits_url":"https://api.github.com/repos/golemfactory/golem/git/commits{/sha}","comments_url":"https://api.github.com/repos/golemfactory/golem/comments{/number}","issue_comment_url":"https://api.github.com/repos/golemfactory/golem/issues/comments{/number}","contents_url":"https://api.github.com/repos/golemfactory/golem/contents/{+path}","compare_url":"https://api.github.com/repos/golemfactory/golem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/golemfactory/golem/merges","archive_url":"https://api.github.com/repos/golemfactory/golem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/golemfactory/golem/downloads","issues_url":"https://api.github.com/repos/golemfactory/golem/issues{/number}","pulls_url":"https://api.github.com/repos/golemfactory/golem/pulls{/number}","milestones_url":"https://api.github.com/repos/golemfactory/golem/milestones{/number}","notifications_url":"https://api.github.com/repos/golemfactory/golem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/golemfactory/golem/labels{/name}","releases_url":"https://api.github.com/repos/golemfactory/golem/releases{/id}","deployments_url":"https://api.github.com/repos/golemfactory/golem/deployments","created_at":"2015-11-18T17:02:35Z","updated_at":"2017-10-17T09:07:15Z","pushed_at":"2017-10-17T06:54:46Z","git_url":"git://github.com/golemfactory/golem.git","ssh_url":"git@github.com:golemfactory/golem.git","clone_url":"https://github.com/golemfactory/golem.git","svn_url":"https://github.com/golemfactory/golem","homepage":"https://golem.network","size":74923,"stargazers_count":1591,"watchers_count":1591,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":234,"forks":156,"open_issues":234,"watchers":1591,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/1476"},"html":{"href":"https://github.com/golemfactory/golem/pull/1476"},"issue":{"href":"https://api.github.com/repos/golemfactory/golem/issues/1476"},"comments":{"href":"https://api.github.com/repos/golemfactory/golem/issues/1476/comments"},"review_comments":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/1476/comments"},"review_comment":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/golemfactory/golem/pulls/1476/commits"},"statuses":{"href":"https://api.github.com/repos/golemfactory/golem/statuses/51ce34d5ed76224535d01dc53ee13d59c80a8f2d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"etam"}}