{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/104550336","pull_request_review_id":25392813,"id":104550336,"diff_hunk":"@@ -11,71 +11,99 @@\n             <argument type=\"service\" id=\"templating.loader\" />\n             <argument type=\"service\" id=\"templating.globals\" />\n             <call method=\"setCharset\"><argument>%kernel.charset%</argument></call>\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.slots\" class=\"Symfony\\Component\\Templating\\Helper\\SlotsHelper\">\n             <tag name=\"templating.helper\" alias=\"slots\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.request\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\RequestHelper\">\n             <tag name=\"templating.helper\" alias=\"request\" />\n             <argument type=\"service\" id=\"request_stack\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.session\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\SessionHelper\">\n             <tag name=\"templating.helper\" alias=\"session\" />\n             <argument type=\"service\" id=\"request_stack\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.router\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\RouterHelper\">\n             <tag name=\"templating.helper\" alias=\"router\" />\n             <argument type=\"service\" id=\"router\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.assets\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\AssetsHelper\">\n             <tag name=\"templating.helper\" alias=\"assets\" />\n             <argument /> <!-- packages -->\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.actions\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\ActionsHelper\">\n             <tag name=\"templating.helper\" alias=\"actions\" />\n             <argument type=\"service\" id=\"fragment.handler\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.code\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\CodeHelper\">\n             <tag name=\"templating.helper\" alias=\"code\" />\n             <argument type=\"service\" id=\"debug.file_link_formatter\"></argument>\n             <argument>%kernel.root_dir%</argument>\n             <argument>%kernel.charset%</argument>\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.translator\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\TranslatorHelper\">\n             <tag name=\"templating.helper\" alias=\"translator\" />\n             <argument type=\"service\" id=\"translator\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.form\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\FormHelper\">\n             <tag name=\"templating.helper\" alias=\"form\" />\n             <argument type=\"service\" id=\"templating.form.renderer\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.helper.stopwatch\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\Helper\\StopwatchHelper\">\n             <tag name=\"templating.helper\" alias=\"stopwatch\" />\n             <argument type=\"service\" id=\"debug.stopwatch\" on-invalid=\"ignore\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.form.engine\" class=\"Symfony\\Component\\Form\\Extension\\Templating\\TemplatingRendererEngine\" public=\"false\">\n             <argument type=\"service\" id=\"templating.engine.php\" />\n             <argument>%templating.helper.form.resources%</argument>\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.form.renderer\" class=\"Symfony\\Component\\Form\\FormRenderer\" public=\"false\">\n             <argument type=\"service\" id=\"templating.form.engine\" />\n             <argument type=\"service\" id=\"security.csrf.token_manager\" on-invalid=\"null\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>\n         </service>\n \n         <service id=\"templating.globals\" class=\"Symfony\\Bundle\\FrameworkBundle\\Templating\\GlobalVariables\">\n             <argument type=\"service\" id=\"service_container\" />\n+\n+            <deprecated>The \"%service_id%\" service is deprecated since Symfony 3.3 and will be removed in 4.0.</deprecated>","path":"src/Symfony/Bundle/FrameworkBundle/Resources/config/templating_php.xml","position":96,"original_position":96,"commit_id":"245ffd0093e48e27fce9b8ab06ee97e65cccbfed","original_commit_id":"245ffd0093e48e27fce9b8ab06ee97e65cccbfed","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars3.githubusercontent.com/u/7502063?v=3","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"body":"could we use `_defaults` instead of updating them all? (would apply to other files)","created_at":"2017-03-06T23:18:07Z","updated_at":"2017-03-06T23:49:06Z","html_url":"https://github.com/symfony/symfony/pull/21035#discussion_r104550336","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/21035","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/104550336"},"html":{"href":"https://github.com/symfony/symfony/pull/21035#discussion_r104550336"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21035"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/21035","id":99257220,"html_url":"https://github.com/symfony/symfony/pull/21035","diff_url":"https://github.com/symfony/symfony/pull/21035.diff","patch_url":"https://github.com/symfony/symfony/pull/21035.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/21035","number":21035,"state":"open","locked":false,"title":"[FrameworkBundle] Deprecate the Templating component integration","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars1.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   | yes\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n\r\nThis PR deprecates the Templating component integration in FrameworkBundle. Only a few people use it because almost everybody use Twig or the serializer to output data. Removing this component will facilitate the maintenance.","created_at":"2016-12-23T15:56:38Z","updated_at":"2017-03-06T23:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9a17d68193db7b639e18edbf025f174583c6fb6","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/16","html_url":"https://github.com/symfony/symfony/milestone/16","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/16/labels","id":2180800,"number":16,"title":"3.3","description":"https://symfony.com/roadmap?version=3.3#checker","creator":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars3.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":151,"state":"open","created_at":"2016-12-07T08:48:45Z","updated_at":"2017-03-06T21:43:13Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/21035/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/21035/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/21035/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/245ffd0093e48e27fce9b8ab06ee97e65cccbfed","head":{"label":"dunglas:deprecate_templating_fwb","ref":"deprecate_templating_fwb","sha":"245ffd0093e48e27fce9b8ab06ee97e65cccbfed","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars1.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"repo":{"id":1124839,"name":"symfony","full_name":"dunglas/symfony","owner":{"login":"dunglas","id":57224,"avatar_url":"https://avatars1.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dunglas/symfony","description":"The Symfony2 PHP framework (PHP 5.3 only -- not yet stable) -- documentation for master is at http://docs.symfony-reloaded.org/master/","fork":true,"url":"https://api.github.com/repos/dunglas/symfony","forks_url":"https://api.github.com/repos/dunglas/symfony/forks","keys_url":"https://api.github.com/repos/dunglas/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dunglas/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dunglas/symfony/teams","hooks_url":"https://api.github.com/repos/dunglas/symfony/hooks","issue_events_url":"https://api.github.com/repos/dunglas/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/dunglas/symfony/events","assignees_url":"https://api.github.com/repos/dunglas/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/dunglas/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/dunglas/symfony/tags","blobs_url":"https://api.github.com/repos/dunglas/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dunglas/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dunglas/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/dunglas/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dunglas/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/dunglas/symfony/languages","stargazers_url":"https://api.github.com/repos/dunglas/symfony/stargazers","contributors_url":"https://api.github.com/repos/dunglas/symfony/contributors","subscribers_url":"https://api.github.com/repos/dunglas/symfony/subscribers","subscription_url":"https://api.github.com/repos/dunglas/symfony/subscription","commits_url":"https://api.github.com/repos/dunglas/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/dunglas/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/dunglas/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/dunglas/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/dunglas/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/dunglas/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dunglas/symfony/merges","archive_url":"https://api.github.com/repos/dunglas/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dunglas/symfony/downloads","issues_url":"https://api.github.com/repos/dunglas/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/dunglas/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/dunglas/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/dunglas/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dunglas/symfony/labels{/name}","releases_url":"https://api.github.com/repos/dunglas/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/dunglas/symfony/deployments","created_at":"2010-11-30T08:18:04Z","updated_at":"2016-01-28T23:52:00Z","pushed_at":"2017-03-02T20:12:52Z","git_url":"git://github.com/dunglas/symfony.git","ssh_url":"git@github.com:dunglas/symfony.git","clone_url":"https://github.com/dunglas/symfony.git","svn_url":"https://github.com/dunglas/symfony","homepage":"http://www.symfony-project.org/","size":84715,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"a0f1e850c0490065edfe20a272d2301af4e876a2","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars0.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars0.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-03-06T21:23:16Z","pushed_at":"2017-03-06T21:41:52Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":88271,"stargazers_count":13975,"watchers_count":13975,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5382,"mirror_url":null,"open_issues_count":800,"forks":5382,"open_issues":800,"watchers":13975,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21035"},"html":{"href":"https://github.com/symfony/symfony/pull/21035"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/21035"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/21035/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21035/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21035/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/245ffd0093e48e27fce9b8ab06ee97e65cccbfed"}}}}
{"actor":{"display_login":"chalasr"}}