{"action":"created","issue":{"url":"https://api.github.com/repos/qTox/qTox/issues/4507","repository_url":"https://api.github.com/repos/qTox/qTox","labels_url":"https://api.github.com/repos/qTox/qTox/issues/4507/labels{/name}","comments_url":"https://api.github.com/repos/qTox/qTox/issues/4507/comments","events_url":"https://api.github.com/repos/qTox/qTox/issues/4507/events","html_url":"https://github.com/qTox/qTox/pull/4507","id":240713981,"number":4507,"title":"fix(ui): Use native file picker dialog","user":{"login":"anoadragon453","id":1342360,"avatar_url":"https://avatars2.githubusercontent.com/u/1342360?v=3","gravatar_id":"","url":"https://api.github.com/users/anoadragon453","html_url":"https://github.com/anoadragon453","followers_url":"https://api.github.com/users/anoadragon453/followers","following_url":"https://api.github.com/users/anoadragon453/following{/other_user}","gists_url":"https://api.github.com/users/anoadragon453/gists{/gist_id}","starred_url":"https://api.github.com/users/anoadragon453/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anoadragon453/subscriptions","organizations_url":"https://api.github.com/users/anoadragon453/orgs","repos_url":"https://api.github.com/users/anoadragon453/repos","events_url":"https://api.github.com/users/anoadragon453/events{/privacy}","received_events_url":"https://api.github.com/users/anoadragon453/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Diadlo","id":6306608,"avatar_url":"https://avatars0.githubusercontent.com/u/6306608?v=3","gravatar_id":"","url":"https://api.github.com/users/Diadlo","html_url":"https://github.com/Diadlo","followers_url":"https://api.github.com/users/Diadlo/followers","following_url":"https://api.github.com/users/Diadlo/following{/other_user}","gists_url":"https://api.github.com/users/Diadlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diadlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diadlo/subscriptions","organizations_url":"https://api.github.com/users/Diadlo/orgs","repos_url":"https://api.github.com/users/Diadlo/repos","events_url":"https://api.github.com/users/Diadlo/events{/privacy}","received_events_url":"https://api.github.com/users/Diadlo/received_events","type":"User","site_admin":false},"assignees":[{"login":"Diadlo","id":6306608,"avatar_url":"https://avatars0.githubusercontent.com/u/6306608?v=3","gravatar_id":"","url":"https://api.github.com/users/Diadlo","html_url":"https://github.com/Diadlo","followers_url":"https://api.github.com/users/Diadlo/followers","following_url":"https://api.github.com/users/Diadlo/following{/other_user}","gists_url":"https://api.github.com/users/Diadlo/gists{/gist_id}","starred_url":"https://api.github.com/users/Diadlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Diadlo/subscriptions","organizations_url":"https://api.github.com/users/Diadlo/orgs","repos_url":"https://api.github.com/users/Diadlo/repos","events_url":"https://api.github.com/users/Diadlo/events{/privacy}","received_events_url":"https://api.github.com/users/Diadlo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2017-07-05T16:57:12Z","updated_at":"2017-07-09T02:15:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qTox/qTox/pulls/4507","html_url":"https://github.com/qTox/qTox/pull/4507","diff_url":"https://github.com/qTox/qTox/pull/4507.diff","patch_url":"https://github.com/qTox/qTox/pull/4507.patch"},"body":"The original reason that the Qt picker was used instead of the native\r\npicker was that the native option would cause Nautilus/GNOME-based\r\npickers to hang.\r\n\r\nThis turned out to be due with a Qt bug with parenting Gtk windows. As a\r\nresult the parent of each file dialog window has been set to NULL,\r\neliminating the crash. As far as tests have shown, this produces no\r\nadverse effects on either floating or tiling wms.\r\n\r\nFixes #3494 \r\n\r\n---\r\n\r\n~~**NOTE:** I've tested this on Arch/KDE, Arch/GNOME, Ubuntu/GNOME and all performs as expected. If someone with a **non-gnome** DE with **nautilus** as the default file manager would like to test this patch and see if a crash still occurs that would be most appreciated.~~\r\n\r\n~~Otherwise everything should work as expected with normal distros, as well as on Windows/Mac.~~\r\n\r\nShould work on all distros now. Testing is appreciated, so far only i3/Nautilus and KDE/Dolphin configurations have been tested.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/qtox/qtox/4507)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/qTox/qTox/issues/comments/313892970","html_url":"https://github.com/qTox/qTox/pull/4507#issuecomment-313892970","issue_url":"https://api.github.com/repos/qTox/qTox/issues/4507","id":313892970,"user":{"login":"anoadragon453","id":1342360,"avatar_url":"https://avatars2.githubusercontent.com/u/1342360?v=3","gravatar_id":"","url":"https://api.github.com/users/anoadragon453","html_url":"https://github.com/anoadragon453","followers_url":"https://api.github.com/users/anoadragon453/followers","following_url":"https://api.github.com/users/anoadragon453/following{/other_user}","gists_url":"https://api.github.com/users/anoadragon453/gists{/gist_id}","starred_url":"https://api.github.com/users/anoadragon453/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anoadragon453/subscriptions","organizations_url":"https://api.github.com/users/anoadragon453/orgs","repos_url":"https://api.github.com/users/anoadragon453/repos","events_url":"https://api.github.com/users/anoadragon453/events{/privacy}","received_events_url":"https://api.github.com/users/anoadragon453/received_events","type":"User","site_admin":false},"created_at":"2017-07-09T02:15:07Z","updated_at":"2017-07-09T02:15:07Z","body":"![2017-07-08-191406](https://user-images.githubusercontent.com/1342360/27990644-b06a9348-6411-11e7-9638-1bab0a72cae6.png)\r\n\r\n@zetok Seems to switch to a different file picker in my i3. Do you have a default file manager installed?"}}
{"actor":{"display_login":"anoadragon453"}}