{"action":"created","issue":{"url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy-revision-data/issues/57","repository_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy-revision-data","labels_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy-revision-data/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy-revision-data/issues/57/comments","events_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy-revision-data/issues/57/events","html_url":"https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/pull/57","id":218499489,"number":57,"title":"Support custom generators","user":{"login":"michalsnik","id":4093559,"avatar_url":"https://avatars3.githubusercontent.com/u/4093559?v=3","gravatar_id":"","url":"https://api.github.com/users/michalsnik","html_url":"https://github.com/michalsnik","followers_url":"https://api.github.com/users/michalsnik/followers","following_url":"https://api.github.com/users/michalsnik/following{/other_user}","gists_url":"https://api.github.com/users/michalsnik/gists{/gist_id}","starred_url":"https://api.github.com/users/michalsnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalsnik/subscriptions","organizations_url":"https://api.github.com/users/michalsnik/orgs","repos_url":"https://api.github.com/users/michalsnik/repos","events_url":"https://api.github.com/users/michalsnik/events{/privacy}","received_events_url":"https://api.github.com/users/michalsnik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-31T13:18:28Z","updated_at":"2017-03-31T18:06:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy-revision-data/pulls/57","html_url":"https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/pull/57","diff_url":"https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/pull/57.diff","patch_url":"https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/pull/57.patch"},"body":"## What Changed & Why\r\nThis PR resolves #23, by adding ability to use custom generators on top of choosen one. User is able to override outcome of the selected generator or write completely unique one if needed.\r\n\r\n## Related issues\r\n#23 \r\n\r\n## PR Checklist\r\n- [x] Add tests\r\n- [x] Add documentation\r\n- [x] Prefix documentation-only commits with [DOC]\r\n\r\n## People\r\n@Bockit\r\n@jrowlingson\r\n@lukemelia"},"comment":{"url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy-revision-data/issues/comments/290785862","html_url":"https://github.com/ember-cli-deploy/ember-cli-deploy-revision-data/pull/57#issuecomment-290785862","issue_url":"https://api.github.com/repos/ember-cli-deploy/ember-cli-deploy-revision-data/issues/57","id":290785862,"user":{"login":"achambers","id":416724,"avatar_url":"https://avatars3.githubusercontent.com/u/416724?v=3","gravatar_id":"","url":"https://api.github.com/users/achambers","html_url":"https://github.com/achambers","followers_url":"https://api.github.com/users/achambers/followers","following_url":"https://api.github.com/users/achambers/following{/other_user}","gists_url":"https://api.github.com/users/achambers/gists{/gist_id}","starred_url":"https://api.github.com/users/achambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achambers/subscriptions","organizations_url":"https://api.github.com/users/achambers/orgs","repos_url":"https://api.github.com/users/achambers/repos","events_url":"https://api.github.com/users/achambers/events{/privacy}","received_events_url":"https://api.github.com/users/achambers/received_events","type":"User","site_admin":false},"created_at":"2017-03-31T18:06:27Z","updated_at":"2017-03-31T18:06:27Z","body":"Thanks @michalsnik. I'll have a chat with @lukemelia and @ghedamat about this as there are a few things in this area that we need to sort out. I'm not personally convinced this is the correct approach to what you're trying to do. \r\n\r\nThat aside, the `generator` property function you have here doesn't conform to how every other config prop function works which can make thing a confusing to consumers. \r\n\r\nIt is generally expected that config property functions will be called with the `context` object passed in as opposed to your data object. This is done as it's encouraged that plugin authors use `this.readConfig` to access config props. \r\n\r\nI wouldn't be comfortable using the approach you have as the config prop in question works differently to the conventions we've created. \r\n\r\nI'll get back to you after I talk through a few other things with the team. \r\n\r\nThanks for your contributions to making the eco system a better place :)"}}
{"actor":{"display_login":"achambers"}}