{"action":"opened","number":313,"pull_request":{"url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/313","id":138447160,"html_url":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/313","diff_url":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/313.diff","patch_url":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/313.patch","issue_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/313","number":313,"state":"open","locked":false,"title":"WIP : Delete topics","user":{"login":"treziac","id":2729252,"avatar_url":"https://avatars0.githubusercontent.com/u/2729252?v=4","gravatar_id":"","url":"https://api.github.com/users/treziac","html_url":"https://github.com/treziac","followers_url":"https://api.github.com/users/treziac/followers","following_url":"https://api.github.com/users/treziac/following{/other_user}","gists_url":"https://api.github.com/users/treziac/gists{/gist_id}","starred_url":"https://api.github.com/users/treziac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treziac/subscriptions","organizations_url":"https://api.github.com/users/treziac/orgs","repos_url":"https://api.github.com/users/treziac/repos","events_url":"https://api.github.com/users/treziac/events{/privacy}","received_events_url":"https://api.github.com/users/treziac/received_events","type":"User","site_admin":false},"body":"Binding to https://github.com/edenhill/librdkafka/pull/1399\r\n\r\nNeed to include proper librdkafka dll for it to work\r\n\r\n## Admin interface / client\r\nThis is more for discussion on how to implement AdminClient : either create a completly different handle (like here in the AdminClient, in which case we will have to deprecate all admin method from producer/consumer to put them in), either only on existing handle (like here on the Producer), either on both, either AdminClient.CreateFrom(producer | consumer). I like it to be able to use admin api from existing handle, so I'm just again the \"new AdminClient only\"\r\n\r\nI made the producer explicitly implement IAdmin more for testing (prevent producer.DeleteTopics usage), not necesseraly a good idea. Idealy we should add the IProducer, ISerializingProducer api, so that we can distinguish producing method from admin method easily (having a IProducer producer = new Producer())\r\n\r\nI let some existing common method in AdminClient, will have to decide which one make it to IAdmin api and which one don't.\r\n\r\n## Delete topics\r\nThe way to treat timeout is more something to discuss on librdkafka PR first than here, but the way exception have to be treated in C# can be reviewed also\r\n\r\n","created_at":"2017-08-30T14:49:59Z","updated_at":"2017-08-30T14:49:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/313/commits","review_comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/313/comments","review_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/313/comments","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/statuses/2ce59d57a8cb46af8431f7ed3a31d6b1711a9303","head":{"label":"treziac:deleteTopics","ref":"deleteTopics","sha":"2ce59d57a8cb46af8431f7ed3a31d6b1711a9303","user":{"login":"treziac","id":2729252,"avatar_url":"https://avatars0.githubusercontent.com/u/2729252?v=4","gravatar_id":"","url":"https://api.github.com/users/treziac","html_url":"https://github.com/treziac","followers_url":"https://api.github.com/users/treziac/followers","following_url":"https://api.github.com/users/treziac/following{/other_user}","gists_url":"https://api.github.com/users/treziac/gists{/gist_id}","starred_url":"https://api.github.com/users/treziac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treziac/subscriptions","organizations_url":"https://api.github.com/users/treziac/orgs","repos_url":"https://api.github.com/users/treziac/repos","events_url":"https://api.github.com/users/treziac/events{/privacy}","received_events_url":"https://api.github.com/users/treziac/received_events","type":"User","site_admin":false},"repo":{"id":82150787,"name":"confluent-kafka-dotnet","full_name":"treziac/confluent-kafka-dotnet","owner":{"login":"treziac","id":2729252,"avatar_url":"https://avatars0.githubusercontent.com/u/2729252?v=4","gravatar_id":"","url":"https://api.github.com/users/treziac","html_url":"https://github.com/treziac","followers_url":"https://api.github.com/users/treziac/followers","following_url":"https://api.github.com/users/treziac/following{/other_user}","gists_url":"https://api.github.com/users/treziac/gists{/gist_id}","starred_url":"https://api.github.com/users/treziac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treziac/subscriptions","organizations_url":"https://api.github.com/users/treziac/orgs","repos_url":"https://api.github.com/users/treziac/repos","events_url":"https://api.github.com/users/treziac/events{/privacy}","received_events_url":"https://api.github.com/users/treziac/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/treziac/confluent-kafka-dotnet","description":"Confluent's Apache Kafka .NET client","fork":true,"url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet","forks_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/forks","keys_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/teams","hooks_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/hooks","issue_events_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/events","assignees_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/tags","blobs_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/languages","stargazers_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/stargazers","contributors_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/contributors","subscribers_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/subscribers","subscription_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/subscription","commits_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/merges","archive_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/downloads","issues_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/treziac/confluent-kafka-dotnet/deployments","created_at":"2017-02-16T07:09:29Z","updated_at":"2017-06-02T10:37:29Z","pushed_at":"2017-08-30T12:27:05Z","git_url":"git://github.com/treziac/confluent-kafka-dotnet.git","ssh_url":"git@github.com:treziac/confluent-kafka-dotnet.git","clone_url":"https://github.com/treziac/confluent-kafka-dotnet.git","svn_url":"https://github.com/treziac/confluent-kafka-dotnet","homepage":"","size":8152,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"9e794ed4d6d43e173c31dc2351a67b67ba4c056c","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":72554578,"name":"confluent-kafka-dotnet","full_name":"confluentinc/confluent-kafka-dotnet","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/confluent-kafka-dotnet","description":"Confluent's Apache Kafka .NET client","fork":false,"url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet","forks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/forks","keys_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/teams","hooks_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/events","assignees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/tags","blobs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/languages","stargazers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/subscription","commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/merges","archive_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/downloads","issues_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/deployments","created_at":"2016-11-01T16:25:52Z","updated_at":"2017-08-30T14:16:13Z","pushed_at":"2017-08-29T15:56:27Z","git_url":"git://github.com/confluentinc/confluent-kafka-dotnet.git","ssh_url":"git@github.com:confluentinc/confluent-kafka-dotnet.git","clone_url":"https://github.com/confluentinc/confluent-kafka-dotnet.git","svn_url":"https://github.com/confluentinc/confluent-kafka-dotnet","homepage":"","size":662,"stargazers_count":229,"watchers_count":229,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":73,"forks":66,"open_issues":73,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/313"},"html":{"href":"https://github.com/confluentinc/confluent-kafka-dotnet/pull/313"},"issue":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/313"},"comments":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/issues/313/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/313/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/pulls/313/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/confluent-kafka-dotnet/statuses/2ce59d57a8cb46af8431f7ed3a31d6b1711a9303"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":717,"deletions":10,"changed_files":7}}
{"actor":{"display_login":"treziac"}}