{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/136754165","pull_request_review_id":60335061,"id":136754165,"diff_hunk":"@@ -680,15 +680,15 @@ in {\n \n   attrs = buildPythonPackage (rec {","path":"pkgs/top-level/python-packages.nix","position":2,"original_position":2,"commit_id":"6d3537a8620953e424019eb19d8a8f1217f9a490","original_commit_id":"6d3537a8620953e424019eb19d8a8f1217f9a490","user":{"login":"FRidh","id":2129135,"avatar_url":"https://avatars3.githubusercontent.com/u/2129135?v=4","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false},"body":"could you move this to a separate expression","created_at":"2017-09-04T06:54:29Z","updated_at":"2017-09-04T06:58:30Z","html_url":"https://github.com/NixOS/nixpkgs/pull/28947#discussion_r136754165","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/28947","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/136754165"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/28947#discussion_r136754165"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/28947"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/28947","id":139056120,"html_url":"https://github.com/NixOS/nixpkgs/pull/28947","diff_url":"https://github.com/NixOS/nixpkgs/pull/28947.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/28947.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/28947","number":28947,"state":"open","locked":false,"title":"Fix magic-wormhole","user":{"login":"jluttine","id":2195834,"avatar_url":"https://avatars2.githubusercontent.com/u/2195834?v=4","gravatar_id":"","url":"https://api.github.com/users/jluttine","html_url":"https://github.com/jluttine","followers_url":"https://api.github.com/users/jluttine/followers","following_url":"https://api.github.com/users/jluttine/following{/other_user}","gists_url":"https://api.github.com/users/jluttine/gists{/gist_id}","starred_url":"https://api.github.com/users/jluttine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluttine/subscriptions","organizations_url":"https://api.github.com/users/jluttine/orgs","repos_url":"https://api.github.com/users/jluttine/repos","events_url":"https://api.github.com/users/jluttine/events{/privacy}","received_events_url":"https://api.github.com/users/jluttine/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nFixes magic-wormhole by adding some required dependencies and making some necessary upgrades to some packages.\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-09-03T18:04:51Z","updated_at":"2017-09-04T06:58:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bff3bcceaa53685a8417503ef3043c9e46c081aa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/28947/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/28947/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/28947/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/6d3537a8620953e424019eb19d8a8f1217f9a490","head":{"label":"jluttine:fix-magic-wormhole","ref":"fix-magic-wormhole","sha":"6d3537a8620953e424019eb19d8a8f1217f9a490","user":{"login":"jluttine","id":2195834,"avatar_url":"https://avatars2.githubusercontent.com/u/2195834?v=4","gravatar_id":"","url":"https://api.github.com/users/jluttine","html_url":"https://github.com/jluttine","followers_url":"https://api.github.com/users/jluttine/followers","following_url":"https://api.github.com/users/jluttine/following{/other_user}","gists_url":"https://api.github.com/users/jluttine/gists{/gist_id}","starred_url":"https://api.github.com/users/jluttine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluttine/subscriptions","organizations_url":"https://api.github.com/users/jluttine/orgs","repos_url":"https://api.github.com/users/jluttine/repos","events_url":"https://api.github.com/users/jluttine/events{/privacy}","received_events_url":"https://api.github.com/users/jluttine/received_events","type":"User","site_admin":false},"repo":{"id":71211679,"name":"nixpkgs","full_name":"jluttine/nixpkgs","owner":{"login":"jluttine","id":2195834,"avatar_url":"https://avatars2.githubusercontent.com/u/2195834?v=4","gravatar_id":"","url":"https://api.github.com/users/jluttine","html_url":"https://github.com/jluttine","followers_url":"https://api.github.com/users/jluttine/followers","following_url":"https://api.github.com/users/jluttine/following{/other_user}","gists_url":"https://api.github.com/users/jluttine/gists{/gist_id}","starred_url":"https://api.github.com/users/jluttine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluttine/subscriptions","organizations_url":"https://api.github.com/users/jluttine/orgs","repos_url":"https://api.github.com/users/jluttine/repos","events_url":"https://api.github.com/users/jluttine/events{/privacy}","received_events_url":"https://api.github.com/users/jluttine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jluttine/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/jluttine/nixpkgs","forks_url":"https://api.github.com/repos/jluttine/nixpkgs/forks","keys_url":"https://api.github.com/repos/jluttine/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jluttine/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jluttine/nixpkgs/teams","hooks_url":"https://api.github.com/repos/jluttine/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/jluttine/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/jluttine/nixpkgs/events","assignees_url":"https://api.github.com/repos/jluttine/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/jluttine/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/jluttine/nixpkgs/tags","blobs_url":"https://api.github.com/repos/jluttine/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jluttine/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jluttine/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jluttine/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jluttine/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/jluttine/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/jluttine/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/jluttine/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/jluttine/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/jluttine/nixpkgs/subscription","commits_url":"https://api.github.com/repos/jluttine/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jluttine/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jluttine/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jluttine/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jluttine/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/jluttine/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jluttine/nixpkgs/merges","archive_url":"https://api.github.com/repos/jluttine/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jluttine/nixpkgs/downloads","issues_url":"https://api.github.com/repos/jluttine/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/jluttine/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/jluttine/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/jluttine/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jluttine/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/jluttine/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/jluttine/nixpkgs/deployments","created_at":"2016-10-18T05:20:44Z","updated_at":"2016-10-18T05:21:07Z","pushed_at":"2017-09-03T18:03:44Z","git_url":"git://github.com/jluttine/nixpkgs.git","ssh_url":"git@github.com:jluttine/nixpkgs.git","clone_url":"https://github.com/jluttine/nixpkgs.git","svn_url":"https://github.com/jluttine/nixpkgs","homepage":null,"size":541731,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"c23654b2ed827986a7efe16f50f0653256628b24","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-09-03T17:04:50Z","pushed_at":"2017-09-04T05:58:52Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":563044,"stargazers_count":1845,"watchers_count":1845,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2211,"mirror_url":null,"open_issues_count":2256,"forks":2211,"open_issues":2256,"watchers":1845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/28947"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/28947"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/28947"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/28947/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/28947/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/28947/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/6d3537a8620953e424019eb19d8a8f1217f9a490"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FRidh"}}