{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8041","repository_url":"https://api.github.com/repos/rapid7/metasploit-framework","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8041/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8041/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8041/events","html_url":"https://github.com/rapid7/metasploit-framework/pull/8041","id":211226624,"number":8041,"title":"warn when lhost set to 127.0.0.1","user":{"login":"bermannoah","id":15199622,"avatar_url":"https://avatars1.githubusercontent.com/u/15199622?v=3","gravatar_id":"","url":"https://api.github.com/users/bermannoah","html_url":"https://github.com/bermannoah","followers_url":"https://api.github.com/users/bermannoah/followers","following_url":"https://api.github.com/users/bermannoah/following{/other_user}","gists_url":"https://api.github.com/users/bermannoah/gists{/gist_id}","starred_url":"https://api.github.com/users/bermannoah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bermannoah/subscriptions","organizations_url":"https://api.github.com/users/bermannoah/orgs","repos_url":"https://api.github.com/users/bermannoah/repos","events_url":"https://api.github.com/users/bermannoah/events{/privacy}","received_events_url":"https://api.github.com/users/bermannoah/received_events","type":"User","site_admin":false},"labels":[{"id":213102939,"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/enhancement","name":"enhancement","color":"5319e7","default":true},{"id":177954079,"url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/payload","name":"payload","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2017-03-01T22:19:17Z","updated_at":"2017-03-09T17:38:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/8041","html_url":"https://github.com/rapid7/metasploit-framework/pull/8041","diff_url":"https://github.com/rapid7/metasploit-framework/pull/8041.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/8041.patch"},"body":"See issue #7188. This pull request adds an alert if you set LHOST to 127.0.0.1. Please let me know if there is any additional behavior desired or if I ought to change the warning message. I set the alert to a `print_error` but would be happy to change it to a different type.\r\n\r\n## Verification\r\n\r\nThe steps needed to make sure this thing works:\r\n\r\n- [ ] Start `msfconsole`\r\n- [ ] `set lhost 127.0.0.1`\r\n- [ ] Verify: It will still set `lhost` to `127.0.0.1` but it will print a warning - for now: \"You may experience errors with this choice of address for LHOST.\" \r\n- [ ] `set lhost 0.0.0.0` (or any other IP)\r\n- [ ] Verify: It will set `lhost` to that address with no warnings. (Unless you use a different address that produces a warning.)\r\n- [ ] `rake spec` to test that all tests still pass.\r\n### Console Output\r\n\r\n```\r\nmsf > set lhost 127.0.0.1\r\n[ - ] You may experience errors with this choice of address for LHOST.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/285423698","html_url":"https://github.com/rapid7/metasploit-framework/pull/8041#issuecomment-285423698","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8041","id":285423698,"user":{"login":"rwhitcroft","id":9545632,"avatar_url":"https://avatars1.githubusercontent.com/u/9545632?v=3","gravatar_id":"","url":"https://api.github.com/users/rwhitcroft","html_url":"https://github.com/rwhitcroft","followers_url":"https://api.github.com/users/rwhitcroft/followers","following_url":"https://api.github.com/users/rwhitcroft/following{/other_user}","gists_url":"https://api.github.com/users/rwhitcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/rwhitcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwhitcroft/subscriptions","organizations_url":"https://api.github.com/users/rwhitcroft/orgs","repos_url":"https://api.github.com/users/rwhitcroft/repos","events_url":"https://api.github.com/users/rwhitcroft/events{/privacy}","received_events_url":"https://api.github.com/users/rwhitcroft/received_events","type":"User","site_admin":false},"created_at":"2017-03-09T17:38:37Z","updated_at":"2017-03-09T17:38:37Z","body":"Yes, both files need to be updated. Your code should look identical to the code @busterb suggested here: https://github.com/rapid7/metasploit-framework/pull/8063/files#r104604972 - watch your spacing, indentation, etc.\r\n\r\nIt might also be helpful to get more familiar with the fundamentals of Git and Ruby before diving right into making PRs. Just a suggestion!"}}
{"actor":{"display_login":"rwhitcroft"}}