{"action":"closed","number":166,"pull_request":{"url":"https://api.github.com/repos/rack-test/rack-test/pulls/166","id":119494041,"html_url":"https://github.com/rack-test/rack-test/pull/166","diff_url":"https://github.com/rack-test/rack-test/pull/166.diff","patch_url":"https://github.com/rack-test/rack-test/pull/166.patch","issue_url":"https://api.github.com/repos/rack-test/rack-test/issues/166","number":166,"state":"closed","locked":false,"title":"Generate rack-test.gemspec from Thorfile adding license, updating homepage","user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars1.githubusercontent.com/u/121989?v=3","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"body":"* Added license information in `Thorfile`. Right now the gemspec file has 2 license parts in the file.\r\n  Also the license information would be better to be included in `Thorfile`. And the gemspec file should be generated from `Thorfile` by `thor` command.\r\n  This fixes https://github.com/rack-test/rack-test/pull/130\r\n* Updated homepage in `Thorfile`.\r\n\r\nI used Ruby 2.2.7 to use `thor`.\r\nBecause when I used Ruby 2.4, the strings part of the gemfile was generated as `\"foo\".freeze`.\r\nThat is hard to check the difference of last modified one.\r\n\r\nBelow is how to generate.\r\n\r\n```\r\n$ which ruby\r\n/usr/local/ruby-2.2.7/bin/ruby\r\n\r\n$ ruby -v\r\nruby 2.2.7p470 (2017-03-28 revision 58193) [x86_64-linux]\r\n\r\n$ which bundle\r\n/usr/local/ruby-2.2.7/bin/bundle\r\n\r\n$ bundle -v\r\nBundler version 1.14.6\r\n\r\n$ bundle install --path vendor/bundle\r\n\r\n$ bundle exec thor :gemspec\r\nWrote gemspec to rack-test.gemspec\r\nWARNING:  open-ended dependency on rack (>= 1.0) is not recommended\r\n  if rack is semantically versioned, use:\r\n    add_runtime_dependency 'rack', '~> 1.0'\r\nWARNING:  See http://guides.rubygems.org/specification-reference/ for help\r\n```\r\n","created_at":"2017-05-08T17:19:47Z","updated_at":"2017-05-08T20:24:24Z","closed_at":"2017-05-08T20:24:24Z","merged_at":"2017-05-08T20:24:24Z","merge_commit_sha":"8fc7790e2870553fb52f8fc842b8780b068881d7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rack-test/rack-test/pulls/166/commits","review_comments_url":"https://api.github.com/repos/rack-test/rack-test/pulls/166/comments","review_comment_url":"https://api.github.com/repos/rack-test/rack-test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rack-test/rack-test/issues/166/comments","statuses_url":"https://api.github.com/repos/rack-test/rack-test/statuses/9a7cfa4424a772b0871fea5894799d593fa41693","head":{"label":"junaruga:feature/generate-gemspec","ref":"feature/generate-gemspec","sha":"9a7cfa4424a772b0871fea5894799d593fa41693","user":{"login":"junaruga","id":121989,"avatar_url":"https://avatars1.githubusercontent.com/u/121989?v=3","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"repo":{"id":71563130,"name":"rack-test","full_name":"junaruga/rack-test","owner":{"login":"junaruga","id":121989,"avatar_url":"https://avatars1.githubusercontent.com/u/121989?v=3","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/junaruga/rack-test","description":"Rack::Test is a layer on top of Rack's MockRequest similar to Merb's RequestHelper","fork":true,"url":"https://api.github.com/repos/junaruga/rack-test","forks_url":"https://api.github.com/repos/junaruga/rack-test/forks","keys_url":"https://api.github.com/repos/junaruga/rack-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/junaruga/rack-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/junaruga/rack-test/teams","hooks_url":"https://api.github.com/repos/junaruga/rack-test/hooks","issue_events_url":"https://api.github.com/repos/junaruga/rack-test/issues/events{/number}","events_url":"https://api.github.com/repos/junaruga/rack-test/events","assignees_url":"https://api.github.com/repos/junaruga/rack-test/assignees{/user}","branches_url":"https://api.github.com/repos/junaruga/rack-test/branches{/branch}","tags_url":"https://api.github.com/repos/junaruga/rack-test/tags","blobs_url":"https://api.github.com/repos/junaruga/rack-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/junaruga/rack-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/junaruga/rack-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/junaruga/rack-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/junaruga/rack-test/statuses/{sha}","languages_url":"https://api.github.com/repos/junaruga/rack-test/languages","stargazers_url":"https://api.github.com/repos/junaruga/rack-test/stargazers","contributors_url":"https://api.github.com/repos/junaruga/rack-test/contributors","subscribers_url":"https://api.github.com/repos/junaruga/rack-test/subscribers","subscription_url":"https://api.github.com/repos/junaruga/rack-test/subscription","commits_url":"https://api.github.com/repos/junaruga/rack-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/junaruga/rack-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/junaruga/rack-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/junaruga/rack-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/junaruga/rack-test/contents/{+path}","compare_url":"https://api.github.com/repos/junaruga/rack-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/junaruga/rack-test/merges","archive_url":"https://api.github.com/repos/junaruga/rack-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/junaruga/rack-test/downloads","issues_url":"https://api.github.com/repos/junaruga/rack-test/issues{/number}","pulls_url":"https://api.github.com/repos/junaruga/rack-test/pulls{/number}","milestones_url":"https://api.github.com/repos/junaruga/rack-test/milestones{/number}","notifications_url":"https://api.github.com/repos/junaruga/rack-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/junaruga/rack-test/labels{/name}","releases_url":"https://api.github.com/repos/junaruga/rack-test/releases{/id}","deployments_url":"https://api.github.com/repos/junaruga/rack-test/deployments","created_at":"2016-10-21T12:27:50Z","updated_at":"2016-10-21T12:31:07Z","pushed_at":"2017-05-08T20:18:15Z","git_url":"git://github.com/junaruga/rack-test.git","ssh_url":"git@github.com:junaruga/rack-test.git","clone_url":"https://github.com/junaruga/rack-test.git","svn_url":"https://github.com/junaruga/rack-test","homepage":"","size":339,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rack-test:master","ref":"master","sha":"6e44c82aede1479bfe5d7e0bf0a748693e4be95a","user":{"login":"rack-test","id":26618800,"avatar_url":"https://avatars1.githubusercontent.com/u/26618800?v=3","gravatar_id":"","url":"https://api.github.com/users/rack-test","html_url":"https://github.com/rack-test","followers_url":"https://api.github.com/users/rack-test/followers","following_url":"https://api.github.com/users/rack-test/following{/other_user}","gists_url":"https://api.github.com/users/rack-test/gists{/gist_id}","starred_url":"https://api.github.com/users/rack-test/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rack-test/subscriptions","organizations_url":"https://api.github.com/users/rack-test/orgs","repos_url":"https://api.github.com/users/rack-test/repos","events_url":"https://api.github.com/users/rack-test/events{/privacy}","received_events_url":"https://api.github.com/users/rack-test/received_events","type":"Organization","site_admin":false},"repo":{"id":135912,"name":"rack-test","full_name":"rack-test/rack-test","owner":{"login":"rack-test","id":26618800,"avatar_url":"https://avatars1.githubusercontent.com/u/26618800?v=3","gravatar_id":"","url":"https://api.github.com/users/rack-test","html_url":"https://github.com/rack-test","followers_url":"https://api.github.com/users/rack-test/followers","following_url":"https://api.github.com/users/rack-test/following{/other_user}","gists_url":"https://api.github.com/users/rack-test/gists{/gist_id}","starred_url":"https://api.github.com/users/rack-test/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rack-test/subscriptions","organizations_url":"https://api.github.com/users/rack-test/orgs","repos_url":"https://api.github.com/users/rack-test/repos","events_url":"https://api.github.com/users/rack-test/events{/privacy}","received_events_url":"https://api.github.com/users/rack-test/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rack-test/rack-test","description":"Rack::Test is a layer on top of Rack's MockRequest similar to Merb's RequestHelper","fork":false,"url":"https://api.github.com/repos/rack-test/rack-test","forks_url":"https://api.github.com/repos/rack-test/rack-test/forks","keys_url":"https://api.github.com/repos/rack-test/rack-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rack-test/rack-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rack-test/rack-test/teams","hooks_url":"https://api.github.com/repos/rack-test/rack-test/hooks","issue_events_url":"https://api.github.com/repos/rack-test/rack-test/issues/events{/number}","events_url":"https://api.github.com/repos/rack-test/rack-test/events","assignees_url":"https://api.github.com/repos/rack-test/rack-test/assignees{/user}","branches_url":"https://api.github.com/repos/rack-test/rack-test/branches{/branch}","tags_url":"https://api.github.com/repos/rack-test/rack-test/tags","blobs_url":"https://api.github.com/repos/rack-test/rack-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rack-test/rack-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rack-test/rack-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/rack-test/rack-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rack-test/rack-test/statuses/{sha}","languages_url":"https://api.github.com/repos/rack-test/rack-test/languages","stargazers_url":"https://api.github.com/repos/rack-test/rack-test/stargazers","contributors_url":"https://api.github.com/repos/rack-test/rack-test/contributors","subscribers_url":"https://api.github.com/repos/rack-test/rack-test/subscribers","subscription_url":"https://api.github.com/repos/rack-test/rack-test/subscription","commits_url":"https://api.github.com/repos/rack-test/rack-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/rack-test/rack-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/rack-test/rack-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/rack-test/rack-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/rack-test/rack-test/contents/{+path}","compare_url":"https://api.github.com/repos/rack-test/rack-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rack-test/rack-test/merges","archive_url":"https://api.github.com/repos/rack-test/rack-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rack-test/rack-test/downloads","issues_url":"https://api.github.com/repos/rack-test/rack-test/issues{/number}","pulls_url":"https://api.github.com/repos/rack-test/rack-test/pulls{/number}","milestones_url":"https://api.github.com/repos/rack-test/rack-test/milestones{/number}","notifications_url":"https://api.github.com/repos/rack-test/rack-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rack-test/rack-test/labels{/name}","releases_url":"https://api.github.com/repos/rack-test/rack-test/releases{/id}","deployments_url":"https://api.github.com/repos/rack-test/rack-test/deployments","created_at":"2009-02-24T02:13:47Z","updated_at":"2017-05-08T13:25:23Z","pushed_at":"2017-05-08T20:24:24Z","git_url":"git://github.com/rack-test/rack-test.git","ssh_url":"git@github.com:rack-test/rack-test.git","clone_url":"https://github.com/rack-test/rack-test.git","svn_url":"https://github.com/rack-test/rack-test","homepage":"","size":343,"stargazers_count":725,"watchers_count":725,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":190,"mirror_url":null,"open_issues_count":51,"forks":190,"open_issues":51,"watchers":725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rack-test/rack-test/pulls/166"},"html":{"href":"https://github.com/rack-test/rack-test/pull/166"},"issue":{"href":"https://api.github.com/repos/rack-test/rack-test/issues/166"},"comments":{"href":"https://api.github.com/repos/rack-test/rack-test/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/rack-test/rack-test/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/rack-test/rack-test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rack-test/rack-test/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/rack-test/rack-test/statuses/9a7cfa4424a772b0871fea5894799d593fa41693"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"junaruga","id":121989,"avatar_url":"https://avatars1.githubusercontent.com/u/121989?v=3","gravatar_id":"","url":"https://api.github.com/users/junaruga","html_url":"https://github.com/junaruga","followers_url":"https://api.github.com/users/junaruga/followers","following_url":"https://api.github.com/users/junaruga/following{/other_user}","gists_url":"https://api.github.com/users/junaruga/gists{/gist_id}","starred_url":"https://api.github.com/users/junaruga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junaruga/subscriptions","organizations_url":"https://api.github.com/users/junaruga/orgs","repos_url":"https://api.github.com/users/junaruga/repos","events_url":"https://api.github.com/users/junaruga/events{/privacy}","received_events_url":"https://api.github.com/users/junaruga/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":16,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"junaruga"}}