{"action":"created","comment":{"url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/comments/135244372","pull_request_review_id":58636612,"id":135244372,"diff_hunk":"@@ -784,14 +784,20 @@ finalize_ipl_tape_address_data(struct job_ipl_tape_data* ipl_tape, char *name)\n \n \n static int\n-check_job_ipl_data(struct job_ipl_data *ipl, char* name)\n+check_job_ipl_data(struct job_ipl_data *ipl, char* name, bool may_ignore)\n {\n \tint rc;\n \n \tif (ipl->image != NULL) {\n \t\trc = misc_check_readable_file(ipl->image);\n \t\tif (rc) {\n-\t\t\tif (name == NULL) {\n+\t\t\tif (may_ignore && ipl->optional) {\n+\t\t\t\tprintf(\"Ignored section '%s': Image file '%s'\\n\",\n+\t\t\t\t\t\tname, ipl->image);","path":"zipl/src/job.c","position":15,"original_position":15,"commit_id":"1a0a15df33b00302752436cb992e2c096e8859ea","original_commit_id":"1a0a15df33b00302752436cb992e2c096e8859ea","user":{"login":"pkern","id":42176,"avatar_url":"https://avatars3.githubusercontent.com/u/42176?v=4","gravatar_id":"","url":"https://api.github.com/users/pkern","html_url":"https://github.com/pkern","followers_url":"https://api.github.com/users/pkern/followers","following_url":"https://api.github.com/users/pkern/following{/other_user}","gists_url":"https://api.github.com/users/pkern/gists{/gist_id}","starred_url":"https://api.github.com/users/pkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkern/subscriptions","organizations_url":"https://api.github.com/users/pkern/orgs","repos_url":"https://api.github.com/users/pkern/repos","events_url":"https://api.github.com/users/pkern/events{/privacy}","received_events_url":"https://api.github.com/users/pkern/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-08-25T12:14:13Z","updated_at":"2017-08-25T12:14:13Z","html_url":"https://github.com/ibm-s390-tools/s390-tools/pull/2#discussion_r135244372","pull_request_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/comments/135244372"},"html":{"href":"https://github.com/ibm-s390-tools/s390-tools/pull/2#discussion_r135244372"},"pull_request":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/2"}},"in_reply_to_id":135217589},"pull_request":{"url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/2","id":137541573,"html_url":"https://github.com/ibm-s390-tools/s390-tools/pull/2","diff_url":"https://github.com/ibm-s390-tools/s390-tools/pull/2.diff","patch_url":"https://github.com/ibm-s390-tools/s390-tools/pull/2.patch","issue_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/issues/2","number":2,"state":"open","locked":false,"title":"zipl: Allow optional entries that are left out when files are missing.","user":{"login":"pkern","id":42176,"avatar_url":"https://avatars3.githubusercontent.com/u/42176?v=4","gravatar_id":"","url":"https://api.github.com/users/pkern","html_url":"https://github.com/pkern","followers_url":"https://api.github.com/users/pkern/followers","following_url":"https://api.github.com/users/pkern/following{/other_user}","gists_url":"https://api.github.com/users/pkern/gists{/gist_id}","starred_url":"https://api.github.com/users/pkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkern/subscriptions","organizations_url":"https://api.github.com/users/pkern/orgs","repos_url":"https://api.github.com/users/pkern/repos","events_url":"https://api.github.com/users/pkern/events{/privacy}","received_events_url":"https://api.github.com/users/pkern/received_events","type":"User","site_admin":false},"body":"Debian carried a patch forever that allowed zipl to run even if not all\r\nmenu items had files attached. If a required file is missing for an\r\nentry (e.g. vmlinuz.old or initrd.img.old) and it is marked as \"optional\"\r\nin the config, the section will be skipped. This allows to zipl to install\r\nafter bootstraping, as booting on s390 still relies on the kernel/initrd\r\nsymlinks in the root directory.\r\n\r\nSigned-off-by: Philipp Kern <pkern@debian.org>","created_at":"2017-08-24T20:14:20Z","updated_at":"2017-08-25T12:14:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce696f240aae394ac200b478b12c730fa7a9abba","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/issues/2/comments","statuses_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/statuses/1a0a15df33b00302752436cb992e2c096e8859ea","head":{"label":"pkern:master","ref":"master","sha":"1a0a15df33b00302752436cb992e2c096e8859ea","user":{"login":"pkern","id":42176,"avatar_url":"https://avatars3.githubusercontent.com/u/42176?v=4","gravatar_id":"","url":"https://api.github.com/users/pkern","html_url":"https://github.com/pkern","followers_url":"https://api.github.com/users/pkern/followers","following_url":"https://api.github.com/users/pkern/following{/other_user}","gists_url":"https://api.github.com/users/pkern/gists{/gist_id}","starred_url":"https://api.github.com/users/pkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkern/subscriptions","organizations_url":"https://api.github.com/users/pkern/orgs","repos_url":"https://api.github.com/users/pkern/repos","events_url":"https://api.github.com/users/pkern/events{/privacy}","received_events_url":"https://api.github.com/users/pkern/received_events","type":"User","site_admin":false},"repo":{"id":100990640,"name":"s390-tools","full_name":"pkern/s390-tools","owner":{"login":"pkern","id":42176,"avatar_url":"https://avatars3.githubusercontent.com/u/42176?v=4","gravatar_id":"","url":"https://api.github.com/users/pkern","html_url":"https://github.com/pkern","followers_url":"https://api.github.com/users/pkern/followers","following_url":"https://api.github.com/users/pkern/following{/other_user}","gists_url":"https://api.github.com/users/pkern/gists{/gist_id}","starred_url":"https://api.github.com/users/pkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkern/subscriptions","organizations_url":"https://api.github.com/users/pkern/orgs","repos_url":"https://api.github.com/users/pkern/repos","events_url":"https://api.github.com/users/pkern/events{/privacy}","received_events_url":"https://api.github.com/users/pkern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkern/s390-tools","description":"Tools for use with the s390 Linux kernel and device drivers","fork":true,"url":"https://api.github.com/repos/pkern/s390-tools","forks_url":"https://api.github.com/repos/pkern/s390-tools/forks","keys_url":"https://api.github.com/repos/pkern/s390-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkern/s390-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkern/s390-tools/teams","hooks_url":"https://api.github.com/repos/pkern/s390-tools/hooks","issue_events_url":"https://api.github.com/repos/pkern/s390-tools/issues/events{/number}","events_url":"https://api.github.com/repos/pkern/s390-tools/events","assignees_url":"https://api.github.com/repos/pkern/s390-tools/assignees{/user}","branches_url":"https://api.github.com/repos/pkern/s390-tools/branches{/branch}","tags_url":"https://api.github.com/repos/pkern/s390-tools/tags","blobs_url":"https://api.github.com/repos/pkern/s390-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkern/s390-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkern/s390-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkern/s390-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkern/s390-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/pkern/s390-tools/languages","stargazers_url":"https://api.github.com/repos/pkern/s390-tools/stargazers","contributors_url":"https://api.github.com/repos/pkern/s390-tools/contributors","subscribers_url":"https://api.github.com/repos/pkern/s390-tools/subscribers","subscription_url":"https://api.github.com/repos/pkern/s390-tools/subscription","commits_url":"https://api.github.com/repos/pkern/s390-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkern/s390-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkern/s390-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkern/s390-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkern/s390-tools/contents/{+path}","compare_url":"https://api.github.com/repos/pkern/s390-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkern/s390-tools/merges","archive_url":"https://api.github.com/repos/pkern/s390-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkern/s390-tools/downloads","issues_url":"https://api.github.com/repos/pkern/s390-tools/issues{/number}","pulls_url":"https://api.github.com/repos/pkern/s390-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/pkern/s390-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/pkern/s390-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkern/s390-tools/labels{/name}","releases_url":"https://api.github.com/repos/pkern/s390-tools/releases{/id}","deployments_url":"https://api.github.com/repos/pkern/s390-tools/deployments","created_at":"2017-08-21T20:37:32Z","updated_at":"2017-08-21T20:37:36Z","pushed_at":"2017-08-24T20:13:18Z","git_url":"git://github.com/pkern/s390-tools.git","ssh_url":"git@github.com:pkern/s390-tools.git","clone_url":"https://github.com/pkern/s390-tools.git","svn_url":"https://github.com/pkern/s390-tools","homepage":null,"size":1258,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ibm-s390-tools:master","ref":"master","sha":"39382ec5fdaa78c8b9e3534ff9537af7ce130607","user":{"login":"ibm-s390-tools","id":31205023,"avatar_url":"https://avatars2.githubusercontent.com/u/31205023?v=4","gravatar_id":"","url":"https://api.github.com/users/ibm-s390-tools","html_url":"https://github.com/ibm-s390-tools","followers_url":"https://api.github.com/users/ibm-s390-tools/followers","following_url":"https://api.github.com/users/ibm-s390-tools/following{/other_user}","gists_url":"https://api.github.com/users/ibm-s390-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/ibm-s390-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibm-s390-tools/subscriptions","organizations_url":"https://api.github.com/users/ibm-s390-tools/orgs","repos_url":"https://api.github.com/users/ibm-s390-tools/repos","events_url":"https://api.github.com/users/ibm-s390-tools/events{/privacy}","received_events_url":"https://api.github.com/users/ibm-s390-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":100932559,"name":"s390-tools","full_name":"ibm-s390-tools/s390-tools","owner":{"login":"ibm-s390-tools","id":31205023,"avatar_url":"https://avatars2.githubusercontent.com/u/31205023?v=4","gravatar_id":"","url":"https://api.github.com/users/ibm-s390-tools","html_url":"https://github.com/ibm-s390-tools","followers_url":"https://api.github.com/users/ibm-s390-tools/followers","following_url":"https://api.github.com/users/ibm-s390-tools/following{/other_user}","gists_url":"https://api.github.com/users/ibm-s390-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/ibm-s390-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibm-s390-tools/subscriptions","organizations_url":"https://api.github.com/users/ibm-s390-tools/orgs","repos_url":"https://api.github.com/users/ibm-s390-tools/repos","events_url":"https://api.github.com/users/ibm-s390-tools/events{/privacy}","received_events_url":"https://api.github.com/users/ibm-s390-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ibm-s390-tools/s390-tools","description":"Tools for use with the s390 Linux kernel and device drivers","fork":false,"url":"https://api.github.com/repos/ibm-s390-tools/s390-tools","forks_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/forks","keys_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/teams","hooks_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/hooks","issue_events_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/issues/events{/number}","events_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/events","assignees_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/assignees{/user}","branches_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/branches{/branch}","tags_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/tags","blobs_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/languages","stargazers_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/stargazers","contributors_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/contributors","subscribers_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/subscribers","subscription_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/subscription","commits_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/contents/{+path}","compare_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/merges","archive_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/downloads","issues_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/issues{/number}","pulls_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/labels{/name}","releases_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/releases{/id}","deployments_url":"https://api.github.com/repos/ibm-s390-tools/s390-tools/deployments","created_at":"2017-08-21T08:51:29Z","updated_at":"2017-08-25T10:51:48Z","pushed_at":"2017-08-24T20:14:20Z","git_url":"git://github.com/ibm-s390-tools/s390-tools.git","ssh_url":"git@github.com:ibm-s390-tools/s390-tools.git","clone_url":"https://github.com/ibm-s390-tools/s390-tools.git","svn_url":"https://github.com/ibm-s390-tools/s390-tools","homepage":null,"size":1255,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/2"},"html":{"href":"https://github.com/ibm-s390-tools/s390-tools/pull/2"},"issue":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/issues/2"},"comments":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ibm-s390-tools/s390-tools/statuses/1a0a15df33b00302752436cb992e2c096e8859ea"}}}}
{"actor":{"display_login":"pkern"}}