{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/123997398","pull_request_review_id":46247979,"id":123997398,"diff_hunk":"@@ -272,18 +281,46 @@ void MainWindow::Pause()\n \n bool MainWindow::Stop()\n {\n+  if (!Core::IsRunning())\n+    return true;\n+\n   bool stop = true;\n+  Core::State state = Core::GetState();\n+  // Set to false when Netplay is running as a CPU thread\n+  bool pause = true;","path":"Source/Core/DolphinQt2/MainWindow.cpp","position":52,"original_position":52,"commit_id":"5c65abcd953701b70337678b20874b70f9289091","original_commit_id":"5c65abcd953701b70337678b20874b70f9289091","user":{"login":"leoetlino","id":4209061,"avatar_url":"https://avatars1.githubusercontent.com/u/4209061?v=3","gravatar_id":"","url":"https://api.github.com/users/leoetlino","html_url":"https://github.com/leoetlino","followers_url":"https://api.github.com/users/leoetlino/followers","following_url":"https://api.github.com/users/leoetlino/following{/other_user}","gists_url":"https://api.github.com/users/leoetlino/gists{/gist_id}","starred_url":"https://api.github.com/users/leoetlino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoetlino/subscriptions","organizations_url":"https://api.github.com/users/leoetlino/orgs","repos_url":"https://api.github.com/users/leoetlino/repos","events_url":"https://api.github.com/users/leoetlino/events{/privacy}","received_events_url":"https://api.github.com/users/leoetlino/received_events","type":"User","site_admin":false},"body":"What is the point of this variable?","created_at":"2017-06-26T12:36:16Z","updated_at":"2017-06-26T12:36:16Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/5681#discussion_r123997398","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5681","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/123997398"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5681#discussion_r123997398"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5681"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5681","id":127332678,"html_url":"https://github.com/dolphin-emu/dolphin/pull/5681","diff_url":"https://github.com/dolphin-emu/dolphin/pull/5681.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/5681.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5681","number":5681,"state":"open","locked":false,"title":"Qt: Implement safe shutdown","user":{"login":"spycrab","id":1440715,"avatar_url":"https://avatars1.githubusercontent.com/u/1440715?v=3","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"body":"Allows games to safely shut down in Qt.","created_at":"2017-06-24T15:01:44Z","updated_at":"2017-06-26T12:36:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c2bef63e7356eaa6ade7b380d30133662cdd03f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5681/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5681/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5681/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/5c65abcd953701b70337678b20874b70f9289091","head":{"label":"spycrab:qt_safeshutdown","ref":"qt_safeshutdown","sha":"5c65abcd953701b70337678b20874b70f9289091","user":{"login":"spycrab","id":1440715,"avatar_url":"https://avatars1.githubusercontent.com/u/1440715?v=3","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"repo":{"id":88349585,"name":"dolphin","full_name":"spycrab/dolphin","owner":{"login":"spycrab","id":1440715,"avatar_url":"https://avatars1.githubusercontent.com/u/1440715?v=3","gravatar_id":"","url":"https://api.github.com/users/spycrab","html_url":"https://github.com/spycrab","followers_url":"https://api.github.com/users/spycrab/followers","following_url":"https://api.github.com/users/spycrab/following{/other_user}","gists_url":"https://api.github.com/users/spycrab/gists{/gist_id}","starred_url":"https://api.github.com/users/spycrab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spycrab/subscriptions","organizations_url":"https://api.github.com/users/spycrab/orgs","repos_url":"https://api.github.com/users/spycrab/repos","events_url":"https://api.github.com/users/spycrab/events{/privacy}","received_events_url":"https://api.github.com/users/spycrab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spycrab/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/spycrab/dolphin","forks_url":"https://api.github.com/repos/spycrab/dolphin/forks","keys_url":"https://api.github.com/repos/spycrab/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spycrab/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spycrab/dolphin/teams","hooks_url":"https://api.github.com/repos/spycrab/dolphin/hooks","issue_events_url":"https://api.github.com/repos/spycrab/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/spycrab/dolphin/events","assignees_url":"https://api.github.com/repos/spycrab/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/spycrab/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/spycrab/dolphin/tags","blobs_url":"https://api.github.com/repos/spycrab/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spycrab/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spycrab/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/spycrab/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spycrab/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/spycrab/dolphin/languages","stargazers_url":"https://api.github.com/repos/spycrab/dolphin/stargazers","contributors_url":"https://api.github.com/repos/spycrab/dolphin/contributors","subscribers_url":"https://api.github.com/repos/spycrab/dolphin/subscribers","subscription_url":"https://api.github.com/repos/spycrab/dolphin/subscription","commits_url":"https://api.github.com/repos/spycrab/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/spycrab/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/spycrab/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/spycrab/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/spycrab/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/spycrab/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spycrab/dolphin/merges","archive_url":"https://api.github.com/repos/spycrab/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spycrab/dolphin/downloads","issues_url":"https://api.github.com/repos/spycrab/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/spycrab/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/spycrab/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/spycrab/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spycrab/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/spycrab/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/spycrab/dolphin/deployments","created_at":"2017-04-15T13:46:17Z","updated_at":"2017-04-15T13:46:43Z","pushed_at":"2017-06-25T12:52:23Z","git_url":"git://github.com/spycrab/dolphin.git","ssh_url":"git@github.com:spycrab/dolphin.git","clone_url":"https://github.com/spycrab/dolphin.git","svn_url":"https://github.com/spycrab/dolphin","homepage":"https://dolphin-emu.org/","size":304490,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"991062093b41a4cd3471be8bb96e3c2d0bf36a45","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-06-26T06:47:15Z","pushed_at":"2017-06-26T09:54:22Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":342209,"stargazers_count":3420,"watchers_count":3420,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":876,"mirror_url":null,"open_issues_count":140,"forks":876,"open_issues":140,"watchers":3420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5681"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5681"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5681"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5681/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5681/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5681/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/5c65abcd953701b70337678b20874b70f9289091"}}}}
{"actor":{"display_login":"leoetlino"}}