{"action":"created","issue":{"url":"https://api.github.com/repos/mxmCherry/openrtb/issues/9","repository_url":"https://api.github.com/repos/mxmCherry/openrtb","labels_url":"https://api.github.com/repos/mxmCherry/openrtb/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/mxmCherry/openrtb/issues/9/comments","events_url":"https://api.github.com/repos/mxmCherry/openrtb/issues/9/events","html_url":"https://github.com/mxmCherry/openrtb/pull/9","id":249056833,"number":9,"title":"force skip flag to be sent when it's value is 0","user":{"login":"evgenigourvitch","id":20422268,"avatar_url":"https://avatars3.githubusercontent.com/u/20422268?v=4","gravatar_id":"","url":"https://api.github.com/users/evgenigourvitch","html_url":"https://github.com/evgenigourvitch","followers_url":"https://api.github.com/users/evgenigourvitch/followers","following_url":"https://api.github.com/users/evgenigourvitch/following{/other_user}","gists_url":"https://api.github.com/users/evgenigourvitch/gists{/gist_id}","starred_url":"https://api.github.com/users/evgenigourvitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evgenigourvitch/subscriptions","organizations_url":"https://api.github.com/users/evgenigourvitch/orgs","repos_url":"https://api.github.com/users/evgenigourvitch/repos","events_url":"https://api.github.com/users/evgenigourvitch/events{/privacy}","received_events_url":"https://api.github.com/users/evgenigourvitch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-09T14:48:52Z","updated_at":"2017-08-09T17:30:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mxmCherry/openrtb/pulls/9","html_url":"https://github.com/mxmCherry/openrtb/pull/9","diff_url":"https://github.com/mxmCherry/openrtb/pull/9.diff","patch_url":"https://github.com/mxmCherry/openrtb/pull/9.patch"},"body":"hey,\r\nTrying to send video.skip with value 0 (for non skippable video) but since omitempty is presented in the video struct definition  seems like a problem.\r\n\r\nthanks,"},"comment":{"url":"https://api.github.com/repos/mxmCherry/openrtb/issues/comments/321325360","html_url":"https://github.com/mxmCherry/openrtb/pull/9#issuecomment-321325360","issue_url":"https://api.github.com/repos/mxmCherry/openrtb/issues/9","id":321325360,"user":{"login":"mxmCherry","id":5172338,"avatar_url":"https://avatars1.githubusercontent.com/u/5172338?v=4","gravatar_id":"","url":"https://api.github.com/users/mxmCherry","html_url":"https://github.com/mxmCherry","followers_url":"https://api.github.com/users/mxmCherry/followers","following_url":"https://api.github.com/users/mxmCherry/following{/other_user}","gists_url":"https://api.github.com/users/mxmCherry/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmCherry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmCherry/subscriptions","organizations_url":"https://api.github.com/users/mxmCherry/orgs","repos_url":"https://api.github.com/users/mxmCherry/repos","events_url":"https://api.github.com/users/mxmCherry/events{/privacy}","received_events_url":"https://api.github.com/users/mxmCherry/received_events","type":"User","site_admin":false},"created_at":"2017-08-09T17:30:58Z","updated_at":"2017-08-09T17:30:58Z","body":"Seems that OpenRTB describes special treatment for the absence of `video.skip` attribute ([specs](http://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdf), 7.4 Skippability section).\r\n\r\nIMO, absence of this attribute should mean \"video not skippable\", but it's not clearly specified in OpenRTB, so let's assume that absence is some meaningful state, that can be analyzed by bidder.\r\n\r\nSo, this attribute actually needs to be a pointer (`*int8`) to be able to represent tri-state value (omitted, `0` and `1`) \"idiomatically\". With `json:...,omitempty` (so null value won't be serialized). Could you, please, alter your PR with this?\r\n\r\nThere are more attributes, which require such special absence treatment, but let's change only this one for now."}}
{"actor":{"display_login":"mxmCherry"}}