{"action":"created","issue":{"url":"https://api.github.com/repos/rullzer/previewgenerator/issues/2","repository_url":"https://api.github.com/repos/rullzer/previewgenerator","labels_url":"https://api.github.com/repos/rullzer/previewgenerator/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/rullzer/previewgenerator/issues/2/comments","events_url":"https://api.github.com/repos/rullzer/previewgenerator/issues/2/events","html_url":"https://github.com/rullzer/previewgenerator/issues/2","id":194604722,"number":2,"title":"Missing check about  running processes","user":{"login":"blizzz","id":2184312,"avatar_url":"https://avatars1.githubusercontent.com/u/2184312?v=3","gravatar_id":"","url":"https://api.github.com/users/blizzz","html_url":"https://github.com/blizzz","followers_url":"https://api.github.com/users/blizzz/followers","following_url":"https://api.github.com/users/blizzz/following{/other_user}","gists_url":"https://api.github.com/users/blizzz/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzz/subscriptions","organizations_url":"https://api.github.com/users/blizzz/orgs","repos_url":"https://api.github.com/users/blizzz/repos","events_url":"https://api.github.com/users/blizzz/events{/privacy}","received_events_url":"https://api.github.com/users/blizzz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-09T14:07:02Z","updated_at":"2017-03-14T20:51:23Z","closed_at":null,"body":"There is no lockfile, flag or other control that indicates that preview generation is still running. Thus,  when running ``./occ preview:pre-generate`` it  will just start to  do the same tasks. Depending on the activity on the instance, one run of ``./occ preview:pre-generate`` can already take a long time. So there is the chance that previews for each file are generated twice or multiple files (and making them processes run even longer).\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/rullzer/previewgenerator/issues/comments/286555711","html_url":"https://github.com/rullzer/previewgenerator/issues/2#issuecomment-286555711","issue_url":"https://api.github.com/repos/rullzer/previewgenerator/issues/2","id":286555711,"user":{"login":"rullzer","id":45821,"avatar_url":"https://avatars1.githubusercontent.com/u/45821?v=3","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"created_at":"2017-03-14T20:51:23Z","updated_at":"2017-03-14T20:51:23Z","body":"Ok so I finally also got bit by this. Thing is that if something goes wrong in the preview generation and php errors out (out of ram, gd error) a lockfile would not be ideal.\r\n\r\nSo what should solve it I think\r\n\r\n1. When running the preGenerate just update the value after each file. Yes sure not awesome but when generating previews I really don't care about the extra query.\r\n2. When done with the command clear the value\r\n3. When a new command is launched. If the value is set but more than 30 minutes ago we assume it crashed."}}
{"actor":{"display_login":"rullzer"}}