{"action":"opened","number":7781,"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/7781","id":143537697,"html_url":"https://github.com/MarlinFirmware/Marlin/pull/7781","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/7781.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/7781.patch","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7781","number":7781,"state":"open","locked":false,"title":"Update LPC persistent store to initialize eeprom.dat with FF","user":{"login":"victorpv","id":11166017,"avatar_url":"https://avatars1.githubusercontent.com/u/11166017?v=4","gravatar_id":"","url":"https://api.github.com/users/victorpv","html_url":"https://github.com/victorpv","followers_url":"https://api.github.com/users/victorpv/followers","following_url":"https://api.github.com/users/victorpv/following{/other_user}","gists_url":"https://api.github.com/users/victorpv/gists{/gist_id}","starred_url":"https://api.github.com/users/victorpv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorpv/subscriptions","organizations_url":"https://api.github.com/users/victorpv/orgs","repos_url":"https://api.github.com/users/victorpv/repos","events_url":"https://api.github.com/users/victorpv/events{/privacy}","received_events_url":"https://api.github.com/users/victorpv/received_events","type":"User","site_admin":false},"body":"This change initialize any data in eeprom.dat beyond the current file size to FF.\r\nThat way if eeprom.dat is deleted and created again, it doesn't take the old values or random ones, but rather starts with FF in all positions as a real brand new or erased eeprom.dat\r\nCurrently if you delete eeprom.dat and restart the board, the new file is created in the same sector with the same content, since FAT does not actually delete the data, just marks the sector as free. I tested by deleting the file, and then rebooting the board, and checking the file content.\r\nThe change can be tested in the same way, deleting, rebooting the board, and then the new content should be all FF.\r\n\r\nIf an eeprom file already exist with data on it, but smaller than E2END, it will be padded with FF on first access, so it will not have random or old content appended.","created_at":"2017-09-28T01:44:04Z","updated_at":"2017-09-28T01:44:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/7781/commits","review_comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/7781/comments","review_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7781/comments","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/b3a80ef490a94a3fdb2ac623259e5a24a5564d1a","head":{"label":"victorpv:patch-2","ref":"patch-2","sha":"b3a80ef490a94a3fdb2ac623259e5a24a5564d1a","user":{"login":"victorpv","id":11166017,"avatar_url":"https://avatars1.githubusercontent.com/u/11166017?v=4","gravatar_id":"","url":"https://api.github.com/users/victorpv","html_url":"https://github.com/victorpv","followers_url":"https://api.github.com/users/victorpv/followers","following_url":"https://api.github.com/users/victorpv/following{/other_user}","gists_url":"https://api.github.com/users/victorpv/gists{/gist_id}","starred_url":"https://api.github.com/users/victorpv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorpv/subscriptions","organizations_url":"https://api.github.com/users/victorpv/orgs","repos_url":"https://api.github.com/users/victorpv/repos","events_url":"https://api.github.com/users/victorpv/events{/privacy}","received_events_url":"https://api.github.com/users/victorpv/received_events","type":"User","site_admin":false},"repo":{"id":104965923,"name":"Marlin","full_name":"victorpv/Marlin","owner":{"login":"victorpv","id":11166017,"avatar_url":"https://avatars1.githubusercontent.com/u/11166017?v=4","gravatar_id":"","url":"https://api.github.com/users/victorpv","html_url":"https://github.com/victorpv","followers_url":"https://api.github.com/users/victorpv/followers","following_url":"https://api.github.com/users/victorpv/following{/other_user}","gists_url":"https://api.github.com/users/victorpv/gists{/gist_id}","starred_url":"https://api.github.com/users/victorpv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victorpv/subscriptions","organizations_url":"https://api.github.com/users/victorpv/orgs","repos_url":"https://api.github.com/users/victorpv/repos","events_url":"https://api.github.com/users/victorpv/events{/privacy}","received_events_url":"https://api.github.com/users/victorpv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victorpv/Marlin","description":"Optimized firmware for RepRap 3D printers based on the Arduino platform.","fork":true,"url":"https://api.github.com/repos/victorpv/Marlin","forks_url":"https://api.github.com/repos/victorpv/Marlin/forks","keys_url":"https://api.github.com/repos/victorpv/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victorpv/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victorpv/Marlin/teams","hooks_url":"https://api.github.com/repos/victorpv/Marlin/hooks","issue_events_url":"https://api.github.com/repos/victorpv/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/victorpv/Marlin/events","assignees_url":"https://api.github.com/repos/victorpv/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/victorpv/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/victorpv/Marlin/tags","blobs_url":"https://api.github.com/repos/victorpv/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victorpv/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victorpv/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/victorpv/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victorpv/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/victorpv/Marlin/languages","stargazers_url":"https://api.github.com/repos/victorpv/Marlin/stargazers","contributors_url":"https://api.github.com/repos/victorpv/Marlin/contributors","subscribers_url":"https://api.github.com/repos/victorpv/Marlin/subscribers","subscription_url":"https://api.github.com/repos/victorpv/Marlin/subscription","commits_url":"https://api.github.com/repos/victorpv/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/victorpv/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/victorpv/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/victorpv/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/victorpv/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/victorpv/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victorpv/Marlin/merges","archive_url":"https://api.github.com/repos/victorpv/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victorpv/Marlin/downloads","issues_url":"https://api.github.com/repos/victorpv/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/victorpv/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/victorpv/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/victorpv/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victorpv/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/victorpv/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/victorpv/Marlin/deployments","created_at":"2017-09-27T03:09:25Z","updated_at":"2017-09-27T03:09:30Z","pushed_at":"2017-09-28T01:43:44Z","git_url":"git://github.com/victorpv/Marlin.git","ssh_url":"git@github.com:victorpv/Marlin.git","clone_url":"https://github.com/victorpv/Marlin.git","svn_url":"https://github.com/victorpv/Marlin","homepage":"http://www.marlinfw.org/","size":50050,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"RC"}},"base":{"label":"MarlinFirmware:bugfix-2.0.x","ref":"bugfix-2.0.x","sha":"17dddda02455da693eae0552f8da8d7d5db4e0c3","user":{"login":"MarlinFirmware","id":10418365,"avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"repo":{"id":2200856,"name":"Marlin","full_name":"MarlinFirmware/Marlin","owner":{"login":"MarlinFirmware","id":10418365,"avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarlinFirmware/Marlin","description":"Optimized firmware for RepRap 3D printers based on the Arduino platform.","fork":false,"url":"https://api.github.com/repos/MarlinFirmware/Marlin","forks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/forks","keys_url":"https://api.github.com/repos/MarlinFirmware/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarlinFirmware/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarlinFirmware/Marlin/teams","hooks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/hooks","issue_events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/events","assignees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/MarlinFirmware/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/tags","blobs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarlinFirmware/Marlin/languages","stargazers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/stargazers","contributors_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contributors","subscribers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscribers","subscription_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscription","commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/MarlinFirmware/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarlinFirmware/Marlin/merges","archive_url":"https://api.github.com/repos/MarlinFirmware/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarlinFirmware/Marlin/downloads","issues_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarlinFirmware/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarlinFirmware/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/MarlinFirmware/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/deployments","created_at":"2011-08-13T08:07:20Z","updated_at":"2017-09-27T22:34:48Z","pushed_at":"2017-09-28T01:36:26Z","git_url":"git://github.com/MarlinFirmware/Marlin.git","ssh_url":"git@github.com:MarlinFirmware/Marlin.git","clone_url":"https://github.com/MarlinFirmware/Marlin.git","svn_url":"https://github.com/MarlinFirmware/Marlin","homepage":"http://www.marlinfw.org/","size":49175,"stargazers_count":2867,"watchers_count":2867,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4534,"mirror_url":null,"open_issues_count":949,"forks":4534,"open_issues":949,"watchers":2867,"default_branch":"1.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/7781"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/7781"},"issue":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7781"},"comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/7781/comments"},"review_comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/7781/comments"},"review_comment":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/7781/commits"},"statuses":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/b3a80ef490a94a3fdb2ac623259e5a24a5564d1a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":17,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"victorpv"}}