{"action":"created","comment":{"url":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/comments/111561568","pull_request_review_id":32815962,"id":111561568,"diff_hunk":"@@ -138,22 +138,23 @@\n                 var amount, browseFilterHeight, discussionBottomOffset, discussionsBodyBottom,\n                     discussionsBodyTop, headerHeight, refineBarHeight, scrollTop, sidebarHeight, topOffset,\n                     windowHeight, $discussionBody, $sidebar;\n+                var sidebar_padding = 10;","path":"lms/djangoapps/discussion/static/discussion/js/views/discussion_board_view.js","position":4,"original_position":4,"commit_id":"cfd7edb3340fc86b9d13f717b1ec64d60f1dd849","original_commit_id":"cfd7edb3340fc86b9d13f717b1ec64d60f1dd849","user":{"login":"ziafazal","id":434995,"avatar_url":"https://avatars2.githubusercontent.com/u/434995?v=3","gravatar_id":"","url":"https://api.github.com/users/ziafazal","html_url":"https://github.com/ziafazal","followers_url":"https://api.github.com/users/ziafazal/followers","following_url":"https://api.github.com/users/ziafazal/following{/other_user}","gists_url":"https://api.github.com/users/ziafazal/gists{/gist_id}","starred_url":"https://api.github.com/users/ziafazal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziafazal/subscriptions","organizations_url":"https://api.github.com/users/ziafazal/orgs","repos_url":"https://api.github.com/users/ziafazal/repos","events_url":"https://api.github.com/users/ziafazal/events{/privacy}","received_events_url":"https://api.github.com/users/ziafazal/received_events","type":"User","site_admin":false},"body":"If we replace this line in `render` method of `DiscussionBoardView`\r\n```\r\n$(window).bind('load scroll resize', this.updateSidebar);\r\n```\r\nwith this\r\n```\r\n$(window).bind('load scroll resize', $.proxy(this.updateSidebar, this));\r\n```\r\nwe would be able to pass  proper `this` context to `updateSidebar` method and we would not need to make all those changes.\r\nIf this works we need to push this change in upstream too.\r\n","created_at":"2017-04-14T11:08:29Z","updated_at":"2017-04-14T11:09:33Z","html_url":"https://github.com/edx-solutions/edx-platform/pull/786#discussion_r111561568","pull_request_url":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/786","_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/comments/111561568"},"html":{"href":"https://github.com/edx-solutions/edx-platform/pull/786#discussion_r111561568"},"pull_request":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/786"}}},"pull_request":{"url":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/786","id":115896518,"html_url":"https://github.com/edx-solutions/edx-platform/pull/786","diff_url":"https://github.com/edx-solutions/edx-platform/pull/786.diff","patch_url":"https://github.com/edx-solutions/edx-platform/pull/786.patch","issue_url":"https://api.github.com/repos/edx-solutions/edx-platform/issues/786","number":786,"state":"open","locked":false,"title":"[YONK-533]: Fix css of inline and course wide discussion","user":{"login":"ayesha-baig","id":11050661,"avatar_url":"https://avatars0.githubusercontent.com/u/11050661?v=3","gravatar_id":"","url":"https://api.github.com/users/ayesha-baig","html_url":"https://github.com/ayesha-baig","followers_url":"https://api.github.com/users/ayesha-baig/followers","following_url":"https://api.github.com/users/ayesha-baig/following{/other_user}","gists_url":"https://api.github.com/users/ayesha-baig/gists{/gist_id}","starred_url":"https://api.github.com/users/ayesha-baig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayesha-baig/subscriptions","organizations_url":"https://api.github.com/users/ayesha-baig/orgs","repos_url":"https://api.github.com/users/ayesha-baig/repos","events_url":"https://api.github.com/users/ayesha-baig/events{/privacy}","received_events_url":"https://api.github.com/users/ayesha-baig/received_events","type":"User","site_admin":false},"body":"@ziafazal, could you please review these changes to adjust the left sidebar and also to enable the discussions header on inline discussion page. \r\n\r\nHere is the related JIRA story, https://openedx.atlassian.net/browse/YONK-533","created_at":"2017-04-14T07:45:28Z","updated_at":"2017-04-14T11:09:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"148af74a23852801a272ab6e216488c77f00da53","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/786/commits","review_comments_url":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/786/comments","review_comment_url":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx-solutions/edx-platform/issues/786/comments","statuses_url":"https://api.github.com/repos/edx-solutions/edx-platform/statuses/cfd7edb3340fc86b9d13f717b1ec64d60f1dd849","head":{"label":"edx-solutions:ayeshabaig/YONK-533","ref":"ayeshabaig/YONK-533","sha":"cfd7edb3340fc86b9d13f717b1ec64d60f1dd849","user":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars0.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":16513414,"name":"edx-platform","full_name":"edx-solutions/edx-platform","owner":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars0.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/edx-solutions/edx-platform","forks_url":"https://api.github.com/repos/edx-solutions/edx-platform/forks","keys_url":"https://api.github.com/repos/edx-solutions/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx-solutions/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/edx-platform/events","assignees_url":"https://api.github.com/repos/edx-solutions/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx-solutions/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/edx-platform/merges","archive_url":"https://api.github.com/repos/edx-solutions/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx-solutions/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/edx-platform/deployments","created_at":"2014-02-04T14:02:57Z","updated_at":"2016-11-09T13:27:11Z","pushed_at":"2017-04-14T07:45:29Z","git_url":"git://github.com/edx-solutions/edx-platform.git","ssh_url":"git@github.com:edx-solutions/edx-platform.git","clone_url":"https://github.com/edx-solutions/edx-platform.git","svn_url":"https://github.com/edx-solutions/edx-platform","homepage":"http://code.edx.org/","size":776759,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"edx-solutions:ayeshabaig/rebase-ficus-fixes","ref":"ayeshabaig/rebase-ficus-fixes","sha":"acb9b29b712710b35f2144dfa6b7e694c074de01","user":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars0.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":16513414,"name":"edx-platform","full_name":"edx-solutions/edx-platform","owner":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars0.githubusercontent.com/u/6585054?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/edx-solutions/edx-platform","forks_url":"https://api.github.com/repos/edx-solutions/edx-platform/forks","keys_url":"https://api.github.com/repos/edx-solutions/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx-solutions/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/edx-platform/events","assignees_url":"https://api.github.com/repos/edx-solutions/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx-solutions/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/edx-platform/merges","archive_url":"https://api.github.com/repos/edx-solutions/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx-solutions/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/edx-platform/deployments","created_at":"2014-02-04T14:02:57Z","updated_at":"2016-11-09T13:27:11Z","pushed_at":"2017-04-14T07:45:29Z","git_url":"git://github.com/edx-solutions/edx-platform.git","ssh_url":"git@github.com:edx-solutions/edx-platform.git","clone_url":"https://github.com/edx-solutions/edx-platform.git","svn_url":"https://github.com/edx-solutions/edx-platform","homepage":"http://code.edx.org/","size":776759,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/786"},"html":{"href":"https://github.com/edx-solutions/edx-platform/pull/786"},"issue":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/issues/786"},"comments":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/issues/786/comments"},"review_comments":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/786/comments"},"review_comment":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/pulls/786/commits"},"statuses":{"href":"https://api.github.com/repos/edx-solutions/edx-platform/statuses/cfd7edb3340fc86b9d13f717b1ec64d60f1dd849"}}}}
{"actor":{"display_login":"ziafazal"}}