{"action":"closed","issue":{"url":"https://api.github.com/repos/privacyidea/privacyidea/issues/650","repository_url":"https://api.github.com/repos/privacyidea/privacyidea","labels_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/650/comments","events_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/650/events","html_url":"https://github.com/privacyidea/privacyidea/issues/650","id":214247940,"number":650,"title":"Redundant ldap3 open() calls","user":{"login":"quynh-axiadids","id":23221438,"avatar_url":"https://avatars0.githubusercontent.com/u/23221438?v=3","gravatar_id":"","url":"https://api.github.com/users/quynh-axiadids","html_url":"https://github.com/quynh-axiadids","followers_url":"https://api.github.com/users/quynh-axiadids/followers","following_url":"https://api.github.com/users/quynh-axiadids/following{/other_user}","gists_url":"https://api.github.com/users/quynh-axiadids/gists{/gist_id}","starred_url":"https://api.github.com/users/quynh-axiadids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quynh-axiadids/subscriptions","organizations_url":"https://api.github.com/users/quynh-axiadids/orgs","repos_url":"https://api.github.com/users/quynh-axiadids/repos","events_url":"https://api.github.com/users/quynh-axiadids/events{/privacy}","received_events_url":"https://api.github.com/users/quynh-axiadids/received_events","type":"User","site_admin":false},"labels":[{"id":400747524,"url":"https://api.github.com/repos/privacyidea/privacyidea/labels/Topic:LDAP","name":"Topic:LDAP","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/privacyidea/privacyidea/milestones/31","html_url":"https://github.com/privacyidea/privacyidea/milestone/31","labels_url":"https://api.github.com/repos/privacyidea/privacyidea/milestones/31/labels","id":2381089,"number":31,"title":"2.19","description":"","creator":{"login":"cornelinux","id":1908620,"avatar_url":"https://avatars2.githubusercontent.com/u/1908620?v=3","gravatar_id":"","url":"https://api.github.com/users/cornelinux","html_url":"https://github.com/cornelinux","followers_url":"https://api.github.com/users/cornelinux/followers","following_url":"https://api.github.com/users/cornelinux/following{/other_user}","gists_url":"https://api.github.com/users/cornelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/cornelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornelinux/subscriptions","organizations_url":"https://api.github.com/users/cornelinux/orgs","repos_url":"https://api.github.com/users/cornelinux/repos","events_url":"https://api.github.com/users/cornelinux/events{/privacy}","received_events_url":"https://api.github.com/users/cornelinux/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":2,"state":"open","created_at":"2017-03-13T06:41:44Z","updated_at":"2017-03-16T13:25:29Z","due_on":"2017-05-25T07:00:00Z","closed_at":null},"comments":11,"created_at":"2017-03-15T00:30:48Z","updated_at":"2017-03-16T13:25:29Z","closed_at":"2017-03-16T13:25:29Z","body":"Please think about and cover the following questions:\r\n\r\n# Versions\r\n\r\nprivacyIDEA: 2.18\r\n\r\nInstallation method:\r\n\r\n- from source / github\r\n## more details: \r\n\r\nOS: Amazon Linux\r\n\r\nWebserver:\r\n\r\nTokendatabase: PostgreSQL\r\n\r\n====\r\n\r\nHi @cornelinux,\r\n\r\nWe are in the progress of testing 2.18 migration.\r\n\r\nI found some open() call for ldap3 that creates unnecessary connections to the ldap servers (which may turn out to be very expensive calls in some cases of remote ldap server) (privacyidea/lib/resolvers/LDAPIdResolver.py, line 1042)\r\n\r\nI also attempt to remove other redundant open() calls that are followed by a bind(), because the ldap3 documentation states that:\r\n\r\n> In ldap3 you establish the connection to the server with the open() method of the Connection object. The bind() method will open the connection if not already open.\r\n\r\n(http://ldap3.readthedocs.io/bind.html)\r\n\r\nI am looking forward to your input.\r\n\r\nThank you.\r\n\r\n\r\n"}}
{"actor":{"display_login":"cornelinux"}}