{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/123621787","pull_request_review_id":45845240,"id":123621787,"diff_hunk":"@@ -40,3 +40,14 @@ class PyCdatLite(PythonPackage):\n     depends_on(\"python@2.5:2.8\", type=('build', 'run'))\n     depends_on(\"py-numpy\", type=('build', 'run'))\n     depends_on('py-setuptools', type='build')\n+\n+    phases = ['install']\n+\n+    def install(self, spec, prefix):\n+        \"\"\"Install everything from build directory.\"\"\"\n+        install_args = self.install_args(spec, prefix)\n+        # Combine all phases into a single setup.py command,\n+        # otherwise extensions are rebuilt without rpath by install phase:","path":"var/spack/repos/builtin/packages/py-cdat-lite/package.py","position":11,"original_position":11,"commit_id":"ed5b10295dd301fce73f8652ee228dede293af42","original_commit_id":"ed5b10295dd301fce73f8652ee228dede293af42","user":{"login":"adamjstewart","id":12021217,"avatar_url":"https://avatars1.githubusercontent.com/u/12021217?v=3","gravatar_id":"","url":"https://api.github.com/users/adamjstewart","html_url":"https://github.com/adamjstewart","followers_url":"https://api.github.com/users/adamjstewart/followers","following_url":"https://api.github.com/users/adamjstewart/following{/other_user}","gists_url":"https://api.github.com/users/adamjstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjstewart/subscriptions","organizations_url":"https://api.github.com/users/adamjstewart/orgs","repos_url":"https://api.github.com/users/adamjstewart/repos","events_url":"https://api.github.com/users/adamjstewart/events{/privacy}","received_events_url":"https://api.github.com/users/adamjstewart/received_events","type":"User","site_admin":false},"body":"Hmm, I don't know if `--skip-build` does what I think it does. According to the help message:\r\n```\r\n$ python setup.py install --help\r\n...\r\n  --skip-build                         skip rebuilding everything (for\r\n                                       testing/debugging)\r\n```\r\nI figured that this meant I could run:\r\n```\r\n$ python setup.py build\r\n$ python setup.py install --skip-build\r\n```\r\nand separate out the logic, but this doesn't work at all for `py-numpy`. The build phase doesn't actually do much of anything, and the install phase crashes when I use `--skip-build`. So I won't be adding `--skip-build`. Guess I'll have to investigate this a bit more.","created_at":"2017-06-22T21:03:28Z","updated_at":"2017-06-22T21:03:28Z","html_url":"https://github.com/LLNL/spack/pull/4521#discussion_r123621787","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/4521","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/123621787"},"html":{"href":"https://github.com/LLNL/spack/pull/4521#discussion_r123621787"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4521"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/4521","id":125939499,"html_url":"https://github.com/LLNL/spack/pull/4521","diff_url":"https://github.com/LLNL/spack/pull/4521.diff","patch_url":"https://github.com/LLNL/spack/pull/4521.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/4521","number":4521,"state":"open","locked":false,"title":"py-cdat-lite: ensure that RPATH includes netcdf","user":{"login":"mjwoods","id":16091567,"avatar_url":"https://avatars0.githubusercontent.com/u/16091567?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwoods","html_url":"https://github.com/mjwoods","followers_url":"https://api.github.com/users/mjwoods/followers","following_url":"https://api.github.com/users/mjwoods/following{/other_user}","gists_url":"https://api.github.com/users/mjwoods/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwoods/subscriptions","organizations_url":"https://api.github.com/users/mjwoods/orgs","repos_url":"https://api.github.com/users/mjwoods/repos","events_url":"https://api.github.com/users/mjwoods/events{/privacy}","received_events_url":"https://api.github.com/users/mjwoods/received_events","type":"User","site_admin":false},"body":"In py-cdat-lite, the netcdf library was not being found during `import cdms2` (unless a suitable library was installed in a system directory). I now set the RPATH explicitly in the install method of the package.","created_at":"2017-06-16T00:42:33Z","updated_at":"2017-06-22T21:03:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5094ab65e5cd181f9eac4186ca2c2560e65b425b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/4521/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/4521/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/4521/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/ed5b10295dd301fce73f8652ee228dede293af42","head":{"label":"mjwoods:py-cdat-lite-rpath","ref":"py-cdat-lite-rpath","sha":"ed5b10295dd301fce73f8652ee228dede293af42","user":{"login":"mjwoods","id":16091567,"avatar_url":"https://avatars0.githubusercontent.com/u/16091567?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwoods","html_url":"https://github.com/mjwoods","followers_url":"https://api.github.com/users/mjwoods/followers","following_url":"https://api.github.com/users/mjwoods/following{/other_user}","gists_url":"https://api.github.com/users/mjwoods/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwoods/subscriptions","organizations_url":"https://api.github.com/users/mjwoods/orgs","repos_url":"https://api.github.com/users/mjwoods/repos","events_url":"https://api.github.com/users/mjwoods/events{/privacy}","received_events_url":"https://api.github.com/users/mjwoods/received_events","type":"User","site_admin":false},"repo":{"id":86433073,"name":"spack","full_name":"mjwoods/spack","owner":{"login":"mjwoods","id":16091567,"avatar_url":"https://avatars0.githubusercontent.com/u/16091567?v=3","gravatar_id":"","url":"https://api.github.com/users/mjwoods","html_url":"https://github.com/mjwoods","followers_url":"https://api.github.com/users/mjwoods/followers","following_url":"https://api.github.com/users/mjwoods/following{/other_user}","gists_url":"https://api.github.com/users/mjwoods/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwoods/subscriptions","organizations_url":"https://api.github.com/users/mjwoods/orgs","repos_url":"https://api.github.com/users/mjwoods/repos","events_url":"https://api.github.com/users/mjwoods/events{/privacy}","received_events_url":"https://api.github.com/users/mjwoods/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjwoods/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/mjwoods/spack","forks_url":"https://api.github.com/repos/mjwoods/spack/forks","keys_url":"https://api.github.com/repos/mjwoods/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjwoods/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjwoods/spack/teams","hooks_url":"https://api.github.com/repos/mjwoods/spack/hooks","issue_events_url":"https://api.github.com/repos/mjwoods/spack/issues/events{/number}","events_url":"https://api.github.com/repos/mjwoods/spack/events","assignees_url":"https://api.github.com/repos/mjwoods/spack/assignees{/user}","branches_url":"https://api.github.com/repos/mjwoods/spack/branches{/branch}","tags_url":"https://api.github.com/repos/mjwoods/spack/tags","blobs_url":"https://api.github.com/repos/mjwoods/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjwoods/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjwoods/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjwoods/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjwoods/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/mjwoods/spack/languages","stargazers_url":"https://api.github.com/repos/mjwoods/spack/stargazers","contributors_url":"https://api.github.com/repos/mjwoods/spack/contributors","subscribers_url":"https://api.github.com/repos/mjwoods/spack/subscribers","subscription_url":"https://api.github.com/repos/mjwoods/spack/subscription","commits_url":"https://api.github.com/repos/mjwoods/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjwoods/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjwoods/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjwoods/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjwoods/spack/contents/{+path}","compare_url":"https://api.github.com/repos/mjwoods/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjwoods/spack/merges","archive_url":"https://api.github.com/repos/mjwoods/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjwoods/spack/downloads","issues_url":"https://api.github.com/repos/mjwoods/spack/issues{/number}","pulls_url":"https://api.github.com/repos/mjwoods/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/mjwoods/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/mjwoods/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjwoods/spack/labels{/name}","releases_url":"https://api.github.com/repos/mjwoods/spack/releases{/id}","deployments_url":"https://api.github.com/repos/mjwoods/spack/deployments","created_at":"2017-03-28T08:13:42Z","updated_at":"2017-03-28T08:13:48Z","pushed_at":"2017-06-22T04:25:08Z","git_url":"git://github.com/mjwoods/spack.git","ssh_url":"git@github.com:mjwoods/spack.git","clone_url":"https://github.com/mjwoods/spack.git","svn_url":"https://github.com/mjwoods/spack","homepage":"https://spack.io","size":25576,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"da67ee9790598fa91aa97af173660560202b3e82","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars3.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars3.githubusercontent.com/u/5921419?v=3","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2017-06-21T11:50:56Z","pushed_at":"2017-06-22T21:00:43Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"https://spack.io","size":25595,"stargazers_count":303,"watchers_count":303,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":250,"mirror_url":null,"open_issues_count":684,"forks":250,"open_issues":684,"watchers":303,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4521"},"html":{"href":"https://github.com/LLNL/spack/pull/4521"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/4521"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/4521/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4521/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/4521/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/ed5b10295dd301fce73f8652ee228dede293af42"}}}}
{"actor":{"display_login":"adamjstewart"}}