{"action":"opened","number":1552,"pull_request":{"url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls/1552","id":129566558,"html_url":"https://github.com/squizlabs/PHP_CodeSniffer/pull/1552","diff_url":"https://github.com/squizlabs/PHP_CodeSniffer/pull/1552.diff","patch_url":"https://github.com/squizlabs/PHP_CodeSniffer/pull/1552.patch","issue_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1552","number":1552,"state":"open","locked":false,"title":"Improve compatibility of Windows BAT files","user":{"login":"JorisDebonnet","id":3286264,"avatar_url":"https://avatars3.githubusercontent.com/u/3286264?v=3","gravatar_id":"","url":"https://api.github.com/users/JorisDebonnet","html_url":"https://github.com/JorisDebonnet","followers_url":"https://api.github.com/users/JorisDebonnet/followers","following_url":"https://api.github.com/users/JorisDebonnet/following{/other_user}","gists_url":"https://api.github.com/users/JorisDebonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisDebonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisDebonnet/subscriptions","organizations_url":"https://api.github.com/users/JorisDebonnet/orgs","repos_url":"https://api.github.com/users/JorisDebonnet/repos","events_url":"https://api.github.com/users/JorisDebonnet/events{/privacy}","received_events_url":"https://api.github.com/users/JorisDebonnet/received_events","type":"User","site_admin":false},"body":"The batch files didn't work for me because neither of those `@var_names@` existed (frankly I don't even know that syntax). I found several blog posts online about how to \"fix\" this by editing the bat file, but I figured it would be nice if this was simply included in this repository. Better out-of-the-box compatibility, yay!\r\n\r\nSo I extended the .bat files to support both the original logic, and the situation where \"php\" is available in the Environment Variables in Windows, which I believe is usually recommended to do. \r\n\r\n(Further, I think `@bin_dir@` is actually never required because we can use %~dp0, but I decided not to touch the orginal logic more than needed)","created_at":"2017-07-09T14:50:44Z","updated_at":"2017-07-09T14:50:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls/1552/commits","review_comments_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls/1552/comments","review_comment_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1552/comments","statuses_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/statuses/e6ac7d2f79ee3a31e6b4fdf3d428400a5e15c0b0","head":{"label":"JorisDebonnet:master","ref":"master","sha":"e6ac7d2f79ee3a31e6b4fdf3d428400a5e15c0b0","user":{"login":"JorisDebonnet","id":3286264,"avatar_url":"https://avatars3.githubusercontent.com/u/3286264?v=3","gravatar_id":"","url":"https://api.github.com/users/JorisDebonnet","html_url":"https://github.com/JorisDebonnet","followers_url":"https://api.github.com/users/JorisDebonnet/followers","following_url":"https://api.github.com/users/JorisDebonnet/following{/other_user}","gists_url":"https://api.github.com/users/JorisDebonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisDebonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisDebonnet/subscriptions","organizations_url":"https://api.github.com/users/JorisDebonnet/orgs","repos_url":"https://api.github.com/users/JorisDebonnet/repos","events_url":"https://api.github.com/users/JorisDebonnet/events{/privacy}","received_events_url":"https://api.github.com/users/JorisDebonnet/received_events","type":"User","site_admin":false},"repo":{"id":96688677,"name":"PHP_CodeSniffer","full_name":"JorisDebonnet/PHP_CodeSniffer","owner":{"login":"JorisDebonnet","id":3286264,"avatar_url":"https://avatars3.githubusercontent.com/u/3286264?v=3","gravatar_id":"","url":"https://api.github.com/users/JorisDebonnet","html_url":"https://github.com/JorisDebonnet","followers_url":"https://api.github.com/users/JorisDebonnet/followers","following_url":"https://api.github.com/users/JorisDebonnet/following{/other_user}","gists_url":"https://api.github.com/users/JorisDebonnet/gists{/gist_id}","starred_url":"https://api.github.com/users/JorisDebonnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorisDebonnet/subscriptions","organizations_url":"https://api.github.com/users/JorisDebonnet/orgs","repos_url":"https://api.github.com/users/JorisDebonnet/repos","events_url":"https://api.github.com/users/JorisDebonnet/events{/privacy}","received_events_url":"https://api.github.com/users/JorisDebonnet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JorisDebonnet/PHP_CodeSniffer","description":"PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards.","fork":true,"url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer","forks_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/forks","keys_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/teams","hooks_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/hooks","issue_events_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/issues/events{/number}","events_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/events","assignees_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/assignees{/user}","branches_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/branches{/branch}","tags_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/tags","blobs_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/statuses/{sha}","languages_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/languages","stargazers_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/stargazers","contributors_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/contributors","subscribers_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/subscribers","subscription_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/subscription","commits_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/contents/{+path}","compare_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/merges","archive_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/downloads","issues_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/issues{/number}","pulls_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/pulls{/number}","milestones_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/milestones{/number}","notifications_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/labels{/name}","releases_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/releases{/id}","deployments_url":"https://api.github.com/repos/JorisDebonnet/PHP_CodeSniffer/deployments","created_at":"2017-07-09T14:13:23Z","updated_at":"2017-07-09T14:13:27Z","pushed_at":"2017-07-09T14:45:56Z","git_url":"git://github.com/JorisDebonnet/PHP_CodeSniffer.git","ssh_url":"git@github.com:JorisDebonnet/PHP_CodeSniffer.git","clone_url":"https://github.com/JorisDebonnet/PHP_CodeSniffer.git","svn_url":"https://github.com/JorisDebonnet/PHP_CodeSniffer","homepage":"http://pear.php.net/package/PHP_CodeSniffer","size":150975,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"squizlabs:master","ref":"master","sha":"9fcb514c25ad37ef6329908060ab62fcd943c684","user":{"login":"squizlabs","id":997547,"avatar_url":"https://avatars1.githubusercontent.com/u/997547?v=3","gravatar_id":"","url":"https://api.github.com/users/squizlabs","html_url":"https://github.com/squizlabs","followers_url":"https://api.github.com/users/squizlabs/followers","following_url":"https://api.github.com/users/squizlabs/following{/other_user}","gists_url":"https://api.github.com/users/squizlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/squizlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squizlabs/subscriptions","organizations_url":"https://api.github.com/users/squizlabs/orgs","repos_url":"https://api.github.com/users/squizlabs/repos","events_url":"https://api.github.com/users/squizlabs/events{/privacy}","received_events_url":"https://api.github.com/users/squizlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":2699935,"name":"PHP_CodeSniffer","full_name":"squizlabs/PHP_CodeSniffer","owner":{"login":"squizlabs","id":997547,"avatar_url":"https://avatars1.githubusercontent.com/u/997547?v=3","gravatar_id":"","url":"https://api.github.com/users/squizlabs","html_url":"https://github.com/squizlabs","followers_url":"https://api.github.com/users/squizlabs/followers","following_url":"https://api.github.com/users/squizlabs/following{/other_user}","gists_url":"https://api.github.com/users/squizlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/squizlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squizlabs/subscriptions","organizations_url":"https://api.github.com/users/squizlabs/orgs","repos_url":"https://api.github.com/users/squizlabs/repos","events_url":"https://api.github.com/users/squizlabs/events{/privacy}","received_events_url":"https://api.github.com/users/squizlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squizlabs/PHP_CodeSniffer","description":"PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards.","fork":false,"url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer","forks_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/forks","keys_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/teams","hooks_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/hooks","issue_events_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/events{/number}","events_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/events","assignees_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/assignees{/user}","branches_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/branches{/branch}","tags_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/tags","blobs_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/statuses/{sha}","languages_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/languages","stargazers_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/stargazers","contributors_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/contributors","subscribers_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/subscribers","subscription_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/subscription","commits_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/contents/{+path}","compare_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/merges","archive_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/downloads","issues_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues{/number}","pulls_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls{/number}","milestones_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/milestones{/number}","notifications_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/labels{/name}","releases_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/releases{/id}","deployments_url":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/deployments","created_at":"2011-11-03T04:06:24Z","updated_at":"2017-07-09T13:58:48Z","pushed_at":"2017-07-08T13:30:16Z","git_url":"git://github.com/squizlabs/PHP_CodeSniffer.git","ssh_url":"git@github.com:squizlabs/PHP_CodeSniffer.git","clone_url":"https://github.com/squizlabs/PHP_CodeSniffer.git","svn_url":"https://github.com/squizlabs/PHP_CodeSniffer","homepage":"http://pear.php.net/package/PHP_CodeSniffer","size":150975,"stargazers_count":3645,"watchers_count":3645,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":774,"mirror_url":null,"open_issues_count":122,"forks":774,"open_issues":122,"watchers":3645,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls/1552"},"html":{"href":"https://github.com/squizlabs/PHP_CodeSniffer/pull/1552"},"issue":{"href":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1552"},"comments":{"href":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/issues/1552/comments"},"review_comments":{"href":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls/1552/comments"},"review_comment":{"href":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/pulls/1552/commits"},"statuses":{"href":"https://api.github.com/repos/squizlabs/PHP_CodeSniffer/statuses/e6ac7d2f79ee3a31e6b4fdf3d428400a5e15c0b0"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":20,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"JorisDebonnet"}}