{"action":"created","comment":{"url":"https://api.github.com/repos/rdelval/gorealis/pulls/comments/107334158","pull_request_review_id":28297976,"id":107334158,"diff_hunk":"@@ -92,41 +212,43 @@ func defaultTTransport(urlstr string, timeoutms int) (thrift.TTransport, error)\n \n // Create a default configuration of the transport layer, requires a URL to test connection with.\n // Uses HTTP Post as transport layer and Thrift JSON as the wire protocol by default.\n-func NewDefaultConfig(url string, timeoutms int) (RealisConfig, error) {\n-\treturn NewTJSONConfig(url, timeoutms)\n+func newDefaultConfig(url string, timeoutms int) (*RealisConfig, error) {\n+\treturn newTJSONConfig(url, timeoutms)\n }\n \n // Creates a realis config object using HTTP Post and Thrift JSON protocol to communicate with Aurora.\n-func NewTJSONConfig(url string, timeoutms int) (RealisConfig, error) {\n+func newTJSONConfig(url string, timeoutms int) (*RealisConfig, error) {\n \ttrans, err := defaultTTransport(url, timeoutms)\n \tif err != nil {\n-\t\treturn RealisConfig{}, errors.Wrap(err, \"Error creating realis config\")\n+\t\treturn &RealisConfig{}, errors.Wrap(err, \"Error creating realis config\")\n \t}\n \n \thttpTrans := (trans).(*thrift.THttpClient)\n \thttpTrans.SetHeader(\"Content-Type\", \"application/x-thrift\")\n \n-\treturn RealisConfig{transport: trans, protoFactory: thrift.NewTJSONProtocolFactory()}, nil\n+\treturn &RealisConfig{transport: trans, protoFactory: thrift.NewTJSONProtocolFactory()}, nil\n }\n \n // Creates a realis config config using HTTP Post and Thrift Binary protocol to communicate with Aurora.\n-func NewTBinaryConfig(url string, timeoutms int) (RealisConfig, error) {\n+func newTBinaryConfig(url string, timeoutms int) (*RealisConfig, error) {\n \ttrans, err := defaultTTransport(url, timeoutms)\n \tif err != nil {\n-\t\treturn RealisConfig{}, errors.Wrap(err, \"Error creating realis config\")\n+\t\treturn &RealisConfig{}, errors.Wrap(err, \"Error creating realis config\")\n \t}\n \n \thttpTrans := (trans).(*thrift.THttpClient)\n \thttpTrans.SetHeader(\"Accept\", \"application/vnd.apache.thrift.binary\")\n \thttpTrans.SetHeader(\"Content-Type\", \"application/vnd.apache.thrift.binary\")\n \thttpTrans.SetHeader(\"User-Agent\", \"GoRealis v1.0.4\")\n \n-\treturn RealisConfig{transport: trans, protoFactory: thrift.NewTBinaryProtocolFactoryDefault()}, nil\n+\treturn &RealisConfig{transport: trans, protoFactory: thrift.NewTBinaryProtocolFactoryDefault()}, nil\n \n }\n \n // Helper function to add basic authorization needed to communicate with Apache Aurora.\n func AddBasicAuth(config *RealisConfig, username string, password string) {","path":"realis.go","position":204,"original_position":204,"commit_id":"9c4c2fce44e07fb8f8f35649d7aa8558a4567553","original_commit_id":"9c4c2fce44e07fb8f8f35649d7aa8558a4567553","user":{"login":"kkrishna","id":1519139,"avatar_url":"https://avatars3.githubusercontent.com/u/1519139?v=3","gravatar_id":"","url":"https://api.github.com/users/kkrishna","html_url":"https://github.com/kkrishna","followers_url":"https://api.github.com/users/kkrishna/followers","following_url":"https://api.github.com/users/kkrishna/following{/other_user}","gists_url":"https://api.github.com/users/kkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrishna/subscriptions","organizations_url":"https://api.github.com/users/kkrishna/orgs","repos_url":"https://api.github.com/users/kkrishna/repos","events_url":"https://api.github.com/users/kkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/kkrishna/received_events","type":"User","site_admin":false},"body":"yep this can be made private.. will be taken care in next pr.","created_at":"2017-03-22T05:14:55Z","updated_at":"2017-03-22T05:14:55Z","html_url":"https://github.com/rdelval/gorealis/pull/22#discussion_r107334158","pull_request_url":"https://api.github.com/repos/rdelval/gorealis/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/rdelval/gorealis/pulls/comments/107334158"},"html":{"href":"https://github.com/rdelval/gorealis/pull/22#discussion_r107334158"},"pull_request":{"href":"https://api.github.com/repos/rdelval/gorealis/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/rdelval/gorealis/pulls/22","id":111906716,"html_url":"https://github.com/rdelval/gorealis/pull/22","diff_url":"https://github.com/rdelval/gorealis/pull/22.diff","patch_url":"https://github.com/rdelval/gorealis/pull/22.patch","issue_url":"https://api.github.com/repos/rdelval/gorealis/issues/22","number":22,"state":"closed","locked":false,"title":"Gorealis Resiliency","user":{"login":"kkrishna","id":1519139,"avatar_url":"https://avatars3.githubusercontent.com/u/1519139?v=3","gravatar_id":"","url":"https://api.github.com/users/kkrishna","html_url":"https://github.com/kkrishna","followers_url":"https://api.github.com/users/kkrishna/followers","following_url":"https://api.github.com/users/kkrishna/following{/other_user}","gists_url":"https://api.github.com/users/kkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrishna/subscriptions","organizations_url":"https://api.github.com/users/kkrishna/orgs","repos_url":"https://api.github.com/users/kkrishna/repos","events_url":"https://api.github.com/users/kkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/kkrishna/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-22T00:04:30Z","updated_at":"2017-03-22T05:14:55Z","closed_at":"2017-03-22T05:06:25Z","merged_at":"2017-03-22T05:06:25Z","merge_commit_sha":"764cfac09990d3c08b7676509d6afa02563269e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rdelval/gorealis/pulls/22/commits","review_comments_url":"https://api.github.com/repos/rdelval/gorealis/pulls/22/comments","review_comment_url":"https://api.github.com/repos/rdelval/gorealis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rdelval/gorealis/issues/22/comments","statuses_url":"https://api.github.com/repos/rdelval/gorealis/statuses/9c4c2fce44e07fb8f8f35649d7aa8558a4567553","head":{"label":"kkrishna:master","ref":"master","sha":"9c4c2fce44e07fb8f8f35649d7aa8558a4567553","user":{"login":"kkrishna","id":1519139,"avatar_url":"https://avatars3.githubusercontent.com/u/1519139?v=3","gravatar_id":"","url":"https://api.github.com/users/kkrishna","html_url":"https://github.com/kkrishna","followers_url":"https://api.github.com/users/kkrishna/followers","following_url":"https://api.github.com/users/kkrishna/following{/other_user}","gists_url":"https://api.github.com/users/kkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrishna/subscriptions","organizations_url":"https://api.github.com/users/kkrishna/orgs","repos_url":"https://api.github.com/users/kkrishna/repos","events_url":"https://api.github.com/users/kkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/kkrishna/received_events","type":"User","site_admin":false},"repo":{"id":73747397,"name":"gorealis","full_name":"kkrishna/gorealis","owner":{"login":"kkrishna","id":1519139,"avatar_url":"https://avatars3.githubusercontent.com/u/1519139?v=3","gravatar_id":"","url":"https://api.github.com/users/kkrishna","html_url":"https://github.com/kkrishna","followers_url":"https://api.github.com/users/kkrishna/followers","following_url":"https://api.github.com/users/kkrishna/following{/other_user}","gists_url":"https://api.github.com/users/kkrishna/gists{/gist_id}","starred_url":"https://api.github.com/users/kkrishna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkrishna/subscriptions","organizations_url":"https://api.github.com/users/kkrishna/orgs","repos_url":"https://api.github.com/users/kkrishna/repos","events_url":"https://api.github.com/users/kkrishna/events{/privacy}","received_events_url":"https://api.github.com/users/kkrishna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkrishna/gorealis","description":"Go library for communicating with Apache Aurora","fork":true,"url":"https://api.github.com/repos/kkrishna/gorealis","forks_url":"https://api.github.com/repos/kkrishna/gorealis/forks","keys_url":"https://api.github.com/repos/kkrishna/gorealis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkrishna/gorealis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkrishna/gorealis/teams","hooks_url":"https://api.github.com/repos/kkrishna/gorealis/hooks","issue_events_url":"https://api.github.com/repos/kkrishna/gorealis/issues/events{/number}","events_url":"https://api.github.com/repos/kkrishna/gorealis/events","assignees_url":"https://api.github.com/repos/kkrishna/gorealis/assignees{/user}","branches_url":"https://api.github.com/repos/kkrishna/gorealis/branches{/branch}","tags_url":"https://api.github.com/repos/kkrishna/gorealis/tags","blobs_url":"https://api.github.com/repos/kkrishna/gorealis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkrishna/gorealis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkrishna/gorealis/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkrishna/gorealis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkrishna/gorealis/statuses/{sha}","languages_url":"https://api.github.com/repos/kkrishna/gorealis/languages","stargazers_url":"https://api.github.com/repos/kkrishna/gorealis/stargazers","contributors_url":"https://api.github.com/repos/kkrishna/gorealis/contributors","subscribers_url":"https://api.github.com/repos/kkrishna/gorealis/subscribers","subscription_url":"https://api.github.com/repos/kkrishna/gorealis/subscription","commits_url":"https://api.github.com/repos/kkrishna/gorealis/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkrishna/gorealis/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkrishna/gorealis/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkrishna/gorealis/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkrishna/gorealis/contents/{+path}","compare_url":"https://api.github.com/repos/kkrishna/gorealis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkrishna/gorealis/merges","archive_url":"https://api.github.com/repos/kkrishna/gorealis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkrishna/gorealis/downloads","issues_url":"https://api.github.com/repos/kkrishna/gorealis/issues{/number}","pulls_url":"https://api.github.com/repos/kkrishna/gorealis/pulls{/number}","milestones_url":"https://api.github.com/repos/kkrishna/gorealis/milestones{/number}","notifications_url":"https://api.github.com/repos/kkrishna/gorealis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkrishna/gorealis/labels{/name}","releases_url":"https://api.github.com/repos/kkrishna/gorealis/releases{/id}","deployments_url":"https://api.github.com/repos/kkrishna/gorealis/deployments","created_at":"2016-11-14T21:14:12Z","updated_at":"2016-11-16T06:24:19Z","pushed_at":"2017-03-21T23:59:37Z","git_url":"git://github.com/kkrishna/gorealis.git","ssh_url":"git@github.com:kkrishna/gorealis.git","clone_url":"https://github.com/kkrishna/gorealis.git","svn_url":"https://github.com/kkrishna/gorealis","homepage":"","size":354,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rdelval:master","ref":"master","sha":"1b475175db39a86c8eb9645f8629dd585844349f","user":{"login":"rdelval","id":1643994,"avatar_url":"https://avatars3.githubusercontent.com/u/1643994?v=3","gravatar_id":"","url":"https://api.github.com/users/rdelval","html_url":"https://github.com/rdelval","followers_url":"https://api.github.com/users/rdelval/followers","following_url":"https://api.github.com/users/rdelval/following{/other_user}","gists_url":"https://api.github.com/users/rdelval/gists{/gist_id}","starred_url":"https://api.github.com/users/rdelval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdelval/subscriptions","organizations_url":"https://api.github.com/users/rdelval/orgs","repos_url":"https://api.github.com/users/rdelval/repos","events_url":"https://api.github.com/users/rdelval/events{/privacy}","received_events_url":"https://api.github.com/users/rdelval/received_events","type":"User","site_admin":false},"repo":{"id":64781142,"name":"gorealis","full_name":"rdelval/gorealis","owner":{"login":"rdelval","id":1643994,"avatar_url":"https://avatars3.githubusercontent.com/u/1643994?v=3","gravatar_id":"","url":"https://api.github.com/users/rdelval","html_url":"https://github.com/rdelval","followers_url":"https://api.github.com/users/rdelval/followers","following_url":"https://api.github.com/users/rdelval/following{/other_user}","gists_url":"https://api.github.com/users/rdelval/gists{/gist_id}","starred_url":"https://api.github.com/users/rdelval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdelval/subscriptions","organizations_url":"https://api.github.com/users/rdelval/orgs","repos_url":"https://api.github.com/users/rdelval/repos","events_url":"https://api.github.com/users/rdelval/events{/privacy}","received_events_url":"https://api.github.com/users/rdelval/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdelval/gorealis","description":"Go library for communicating with Apache Aurora","fork":false,"url":"https://api.github.com/repos/rdelval/gorealis","forks_url":"https://api.github.com/repos/rdelval/gorealis/forks","keys_url":"https://api.github.com/repos/rdelval/gorealis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdelval/gorealis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdelval/gorealis/teams","hooks_url":"https://api.github.com/repos/rdelval/gorealis/hooks","issue_events_url":"https://api.github.com/repos/rdelval/gorealis/issues/events{/number}","events_url":"https://api.github.com/repos/rdelval/gorealis/events","assignees_url":"https://api.github.com/repos/rdelval/gorealis/assignees{/user}","branches_url":"https://api.github.com/repos/rdelval/gorealis/branches{/branch}","tags_url":"https://api.github.com/repos/rdelval/gorealis/tags","blobs_url":"https://api.github.com/repos/rdelval/gorealis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdelval/gorealis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdelval/gorealis/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdelval/gorealis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdelval/gorealis/statuses/{sha}","languages_url":"https://api.github.com/repos/rdelval/gorealis/languages","stargazers_url":"https://api.github.com/repos/rdelval/gorealis/stargazers","contributors_url":"https://api.github.com/repos/rdelval/gorealis/contributors","subscribers_url":"https://api.github.com/repos/rdelval/gorealis/subscribers","subscription_url":"https://api.github.com/repos/rdelval/gorealis/subscription","commits_url":"https://api.github.com/repos/rdelval/gorealis/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdelval/gorealis/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdelval/gorealis/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdelval/gorealis/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdelval/gorealis/contents/{+path}","compare_url":"https://api.github.com/repos/rdelval/gorealis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdelval/gorealis/merges","archive_url":"https://api.github.com/repos/rdelval/gorealis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdelval/gorealis/downloads","issues_url":"https://api.github.com/repos/rdelval/gorealis/issues{/number}","pulls_url":"https://api.github.com/repos/rdelval/gorealis/pulls{/number}","milestones_url":"https://api.github.com/repos/rdelval/gorealis/milestones{/number}","notifications_url":"https://api.github.com/repos/rdelval/gorealis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdelval/gorealis/labels{/name}","releases_url":"https://api.github.com/repos/rdelval/gorealis/releases{/id}","deployments_url":"https://api.github.com/repos/rdelval/gorealis/deployments","created_at":"2016-08-02T18:15:59Z","updated_at":"2017-03-16T17:40:45Z","pushed_at":"2017-03-22T05:06:25Z","git_url":"git://github.com/rdelval/gorealis.git","ssh_url":"git@github.com:rdelval/gorealis.git","clone_url":"https://github.com/rdelval/gorealis.git","svn_url":"https://github.com/rdelval/gorealis","homepage":"","size":344,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rdelval/gorealis/pulls/22"},"html":{"href":"https://github.com/rdelval/gorealis/pull/22"},"issue":{"href":"https://api.github.com/repos/rdelval/gorealis/issues/22"},"comments":{"href":"https://api.github.com/repos/rdelval/gorealis/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/rdelval/gorealis/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/rdelval/gorealis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rdelval/gorealis/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/rdelval/gorealis/statuses/9c4c2fce44e07fb8f8f35649d7aa8558a4567553"}}}}
{"actor":{"display_login":"kkrishna"}}