{"action":"created","comment":{"url":"https://api.github.com/repos/keathley/wallaby/pulls/comments/139866234","pull_request_review_id":63856474,"id":139866234,"diff_hunk":"@@ -217,6 +278,18 @@ defmodule Wallaby.Query do\n   end\n \n   @spec compile(t) :: compiled\n+  @doc \"\"\"\n+  Takes a query and compiles it into either css or xpath, which are the queries\n+  that will finally be issued to the driver.","path":"lib/wallaby/query.ex","position":158,"original_position":158,"commit_id":"8b2a6149adcb1fc6596219e3a99882d5abc6cdd4","original_commit_id":"8b2a6149adcb1fc6596219e3a99882d5abc6cdd4","user":{"login":"aaronrenner","id":120878,"avatar_url":"https://avatars1.githubusercontent.com/u/120878?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronrenner","html_url":"https://github.com/aaronrenner","followers_url":"https://api.github.com/users/aaronrenner/followers","following_url":"https://api.github.com/users/aaronrenner/following{/other_user}","gists_url":"https://api.github.com/users/aaronrenner/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronrenner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronrenner/subscriptions","organizations_url":"https://api.github.com/users/aaronrenner/orgs","repos_url":"https://api.github.com/users/aaronrenner/repos","events_url":"https://api.github.com/users/aaronrenner/events{/privacy}","received_events_url":"https://api.github.com/users/aaronrenner/received_events","type":"User","site_admin":false},"body":"How about \"Compiles a query into css or xpath so its ready to be sent to the driver\"?","created_at":"2017-09-20T03:04:44Z","updated_at":"2017-09-20T03:22:15Z","html_url":"https://github.com/keathley/wallaby/pull/308#discussion_r139866234","pull_request_url":"https://api.github.com/repos/keathley/wallaby/pulls/308","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/keathley/wallaby/pulls/comments/139866234"},"html":{"href":"https://github.com/keathley/wallaby/pull/308#discussion_r139866234"},"pull_request":{"href":"https://api.github.com/repos/keathley/wallaby/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/keathley/wallaby/pulls/308","id":141956588,"html_url":"https://github.com/keathley/wallaby/pull/308","diff_url":"https://github.com/keathley/wallaby/pull/308.diff","patch_url":"https://github.com/keathley/wallaby/pull/308.patch","issue_url":"https://api.github.com/repos/keathley/wallaby/issues/308","number":308,"state":"open","locked":false,"title":"Document the Query module, especially specific queries","user":{"login":"PragTob","id":606517,"avatar_url":"https://avatars1.githubusercontent.com/u/606517?v=4","gravatar_id":"","url":"https://api.github.com/users/PragTob","html_url":"https://github.com/PragTob","followers_url":"https://api.github.com/users/PragTob/followers","following_url":"https://api.github.com/users/PragTob/following{/other_user}","gists_url":"https://api.github.com/users/PragTob/gists{/gist_id}","starred_url":"https://api.github.com/users/PragTob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PragTob/subscriptions","organizations_url":"https://api.github.com/users/PragTob/orgs","repos_url":"https://api.github.com/users/PragTob/repos","events_url":"https://api.github.com/users/PragTob/events{/privacy}","received_events_url":"https://api.github.com/users/PragTob/received_events","type":"User","site_admin":false},"body":"Feedback very welcome! This is stuff I'd often look up myself by compiling queries while working with wallaby :)\r\n\r\nHonestly: I'm not the best at xpath ;P So theoretically I might have gotten some of those wrong.\r\n\r\nSome ideas/thoughts:\r\n* Not sure if the attributes should be like they are atm e.g. id or if it should be in ` e.g. `id`\r\n* I had thought about including a doc test that shows a compiled query (I just looked at those when I wrote these) - might help for people, might be too much - my biggest fear is that we'd basically have to adjust these tests every time we change how something is compiled which sounds like a medium big manual churn.\r\n\r\nDoc writing style etc. can gladly be commented on, nut sure if all the words are used ideally :)\r\n","created_at":"2017-09-19T21:04:33Z","updated_at":"2017-09-20T03:22:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea41f22def11a63657fd516b8f74ffbb530ec177","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/keathley/wallaby/pulls/308/commits","review_comments_url":"https://api.github.com/repos/keathley/wallaby/pulls/308/comments","review_comment_url":"https://api.github.com/repos/keathley/wallaby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keathley/wallaby/issues/308/comments","statuses_url":"https://api.github.com/repos/keathley/wallaby/statuses/8b2a6149adcb1fc6596219e3a99882d5abc6cdd4","head":{"label":"keathley:query-docs","ref":"query-docs","sha":"8b2a6149adcb1fc6596219e3a99882d5abc6cdd4","user":{"login":"keathley","id":1642095,"avatar_url":"https://avatars1.githubusercontent.com/u/1642095?v=4","gravatar_id":"","url":"https://api.github.com/users/keathley","html_url":"https://github.com/keathley","followers_url":"https://api.github.com/users/keathley/followers","following_url":"https://api.github.com/users/keathley/following{/other_user}","gists_url":"https://api.github.com/users/keathley/gists{/gist_id}","starred_url":"https://api.github.com/users/keathley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keathley/subscriptions","organizations_url":"https://api.github.com/users/keathley/orgs","repos_url":"https://api.github.com/users/keathley/repos","events_url":"https://api.github.com/users/keathley/events{/privacy}","received_events_url":"https://api.github.com/users/keathley/received_events","type":"User","site_admin":false},"repo":{"id":52619134,"name":"wallaby","full_name":"keathley/wallaby","owner":{"login":"keathley","id":1642095,"avatar_url":"https://avatars1.githubusercontent.com/u/1642095?v=4","gravatar_id":"","url":"https://api.github.com/users/keathley","html_url":"https://github.com/keathley","followers_url":"https://api.github.com/users/keathley/followers","following_url":"https://api.github.com/users/keathley/following{/other_user}","gists_url":"https://api.github.com/users/keathley/gists{/gist_id}","starred_url":"https://api.github.com/users/keathley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keathley/subscriptions","organizations_url":"https://api.github.com/users/keathley/orgs","repos_url":"https://api.github.com/users/keathley/repos","events_url":"https://api.github.com/users/keathley/events{/privacy}","received_events_url":"https://api.github.com/users/keathley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keathley/wallaby","description":"Concurrent browser tests with elixir","fork":false,"url":"https://api.github.com/repos/keathley/wallaby","forks_url":"https://api.github.com/repos/keathley/wallaby/forks","keys_url":"https://api.github.com/repos/keathley/wallaby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keathley/wallaby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keathley/wallaby/teams","hooks_url":"https://api.github.com/repos/keathley/wallaby/hooks","issue_events_url":"https://api.github.com/repos/keathley/wallaby/issues/events{/number}","events_url":"https://api.github.com/repos/keathley/wallaby/events","assignees_url":"https://api.github.com/repos/keathley/wallaby/assignees{/user}","branches_url":"https://api.github.com/repos/keathley/wallaby/branches{/branch}","tags_url":"https://api.github.com/repos/keathley/wallaby/tags","blobs_url":"https://api.github.com/repos/keathley/wallaby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keathley/wallaby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keathley/wallaby/git/refs{/sha}","trees_url":"https://api.github.com/repos/keathley/wallaby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keathley/wallaby/statuses/{sha}","languages_url":"https://api.github.com/repos/keathley/wallaby/languages","stargazers_url":"https://api.github.com/repos/keathley/wallaby/stargazers","contributors_url":"https://api.github.com/repos/keathley/wallaby/contributors","subscribers_url":"https://api.github.com/repos/keathley/wallaby/subscribers","subscription_url":"https://api.github.com/repos/keathley/wallaby/subscription","commits_url":"https://api.github.com/repos/keathley/wallaby/commits{/sha}","git_commits_url":"https://api.github.com/repos/keathley/wallaby/git/commits{/sha}","comments_url":"https://api.github.com/repos/keathley/wallaby/comments{/number}","issue_comment_url":"https://api.github.com/repos/keathley/wallaby/issues/comments{/number}","contents_url":"https://api.github.com/repos/keathley/wallaby/contents/{+path}","compare_url":"https://api.github.com/repos/keathley/wallaby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keathley/wallaby/merges","archive_url":"https://api.github.com/repos/keathley/wallaby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keathley/wallaby/downloads","issues_url":"https://api.github.com/repos/keathley/wallaby/issues{/number}","pulls_url":"https://api.github.com/repos/keathley/wallaby/pulls{/number}","milestones_url":"https://api.github.com/repos/keathley/wallaby/milestones{/number}","notifications_url":"https://api.github.com/repos/keathley/wallaby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keathley/wallaby/labels{/name}","releases_url":"https://api.github.com/repos/keathley/wallaby/releases{/id}","deployments_url":"https://api.github.com/repos/keathley/wallaby/deployments","created_at":"2016-02-26T16:57:42Z","updated_at":"2017-09-16T15:00:50Z","pushed_at":"2017-09-19T21:04:34Z","git_url":"git://github.com/keathley/wallaby.git","ssh_url":"git@github.com:keathley/wallaby.git","clone_url":"https://github.com/keathley/wallaby.git","svn_url":"https://github.com/keathley/wallaby","homepage":"","size":567,"stargazers_count":509,"watchers_count":509,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":35,"forks":63,"open_issues":35,"watchers":509,"default_branch":"master"}},"base":{"label":"keathley:master","ref":"master","sha":"8dd5124130b98739d2f620c7824c362093d8bc73","user":{"login":"keathley","id":1642095,"avatar_url":"https://avatars1.githubusercontent.com/u/1642095?v=4","gravatar_id":"","url":"https://api.github.com/users/keathley","html_url":"https://github.com/keathley","followers_url":"https://api.github.com/users/keathley/followers","following_url":"https://api.github.com/users/keathley/following{/other_user}","gists_url":"https://api.github.com/users/keathley/gists{/gist_id}","starred_url":"https://api.github.com/users/keathley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keathley/subscriptions","organizations_url":"https://api.github.com/users/keathley/orgs","repos_url":"https://api.github.com/users/keathley/repos","events_url":"https://api.github.com/users/keathley/events{/privacy}","received_events_url":"https://api.github.com/users/keathley/received_events","type":"User","site_admin":false},"repo":{"id":52619134,"name":"wallaby","full_name":"keathley/wallaby","owner":{"login":"keathley","id":1642095,"avatar_url":"https://avatars1.githubusercontent.com/u/1642095?v=4","gravatar_id":"","url":"https://api.github.com/users/keathley","html_url":"https://github.com/keathley","followers_url":"https://api.github.com/users/keathley/followers","following_url":"https://api.github.com/users/keathley/following{/other_user}","gists_url":"https://api.github.com/users/keathley/gists{/gist_id}","starred_url":"https://api.github.com/users/keathley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keathley/subscriptions","organizations_url":"https://api.github.com/users/keathley/orgs","repos_url":"https://api.github.com/users/keathley/repos","events_url":"https://api.github.com/users/keathley/events{/privacy}","received_events_url":"https://api.github.com/users/keathley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keathley/wallaby","description":"Concurrent browser tests with elixir","fork":false,"url":"https://api.github.com/repos/keathley/wallaby","forks_url":"https://api.github.com/repos/keathley/wallaby/forks","keys_url":"https://api.github.com/repos/keathley/wallaby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keathley/wallaby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keathley/wallaby/teams","hooks_url":"https://api.github.com/repos/keathley/wallaby/hooks","issue_events_url":"https://api.github.com/repos/keathley/wallaby/issues/events{/number}","events_url":"https://api.github.com/repos/keathley/wallaby/events","assignees_url":"https://api.github.com/repos/keathley/wallaby/assignees{/user}","branches_url":"https://api.github.com/repos/keathley/wallaby/branches{/branch}","tags_url":"https://api.github.com/repos/keathley/wallaby/tags","blobs_url":"https://api.github.com/repos/keathley/wallaby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keathley/wallaby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keathley/wallaby/git/refs{/sha}","trees_url":"https://api.github.com/repos/keathley/wallaby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keathley/wallaby/statuses/{sha}","languages_url":"https://api.github.com/repos/keathley/wallaby/languages","stargazers_url":"https://api.github.com/repos/keathley/wallaby/stargazers","contributors_url":"https://api.github.com/repos/keathley/wallaby/contributors","subscribers_url":"https://api.github.com/repos/keathley/wallaby/subscribers","subscription_url":"https://api.github.com/repos/keathley/wallaby/subscription","commits_url":"https://api.github.com/repos/keathley/wallaby/commits{/sha}","git_commits_url":"https://api.github.com/repos/keathley/wallaby/git/commits{/sha}","comments_url":"https://api.github.com/repos/keathley/wallaby/comments{/number}","issue_comment_url":"https://api.github.com/repos/keathley/wallaby/issues/comments{/number}","contents_url":"https://api.github.com/repos/keathley/wallaby/contents/{+path}","compare_url":"https://api.github.com/repos/keathley/wallaby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keathley/wallaby/merges","archive_url":"https://api.github.com/repos/keathley/wallaby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keathley/wallaby/downloads","issues_url":"https://api.github.com/repos/keathley/wallaby/issues{/number}","pulls_url":"https://api.github.com/repos/keathley/wallaby/pulls{/number}","milestones_url":"https://api.github.com/repos/keathley/wallaby/milestones{/number}","notifications_url":"https://api.github.com/repos/keathley/wallaby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keathley/wallaby/labels{/name}","releases_url":"https://api.github.com/repos/keathley/wallaby/releases{/id}","deployments_url":"https://api.github.com/repos/keathley/wallaby/deployments","created_at":"2016-02-26T16:57:42Z","updated_at":"2017-09-16T15:00:50Z","pushed_at":"2017-09-19T21:04:34Z","git_url":"git://github.com/keathley/wallaby.git","ssh_url":"git@github.com:keathley/wallaby.git","clone_url":"https://github.com/keathley/wallaby.git","svn_url":"https://github.com/keathley/wallaby","homepage":"","size":567,"stargazers_count":509,"watchers_count":509,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":35,"forks":63,"open_issues":35,"watchers":509,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keathley/wallaby/pulls/308"},"html":{"href":"https://github.com/keathley/wallaby/pull/308"},"issue":{"href":"https://api.github.com/repos/keathley/wallaby/issues/308"},"comments":{"href":"https://api.github.com/repos/keathley/wallaby/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/keathley/wallaby/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/keathley/wallaby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keathley/wallaby/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/keathley/wallaby/statuses/8b2a6149adcb1fc6596219e3a99882d5abc6cdd4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"aaronrenner"}}