{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/111932912","pull_request_review_id":33207987,"id":111932912,"diff_hunk":"@@ -490,38 +497,45 @@ def run(self, result=None):\n             if stopTestRun is not None:\n                 stopTestRun()\n \n-    def setUp(self, macaddr=None, memory_mb=None, cpus=None):\n+    def setUp(self):\n+        if opts.address and self.provision is not None:\n+            raise unittest.SkipTest(\"Cannot provision multiple machines if a specific machine address is specified\")","path":"test/common/testlib.py","position":88,"original_position":88,"commit_id":"cc2cb14550bb3dbba10c41da1a5786bd9e015b65","original_commit_id":"cc2cb14550bb3dbba10c41da1a5786bd9e015b65","user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars0.githubusercontent.com/u/200109?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"body":"Ah, this is only for the CLI option. I see, ignore me then.","created_at":"2017-04-18T11:46:01Z","updated_at":"2017-04-18T11:46:01Z","html_url":"https://github.com/cockpit-project/cockpit/pull/6334#discussion_r111932912","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/6334","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/111932912"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/6334#discussion_r111932912"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/6334"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/6334","id":115719006,"html_url":"https://github.com/cockpit-project/cockpit/pull/6334","diff_url":"https://github.com/cockpit-project/cockpit/pull/6334.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/6334.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/6334","number":6334,"state":"open","locked":false,"title":"test: Use qemu user and socket based networking","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars2.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"Here we change to use qemu user and socket based networking.\r\n\r\n 1. We split the networks for test access to a machine and network for\r\n    machines to access one another.\r\n\r\n 2. The network that we use for test access to ssh/cockpit is\r\n    a qemu user mode network. This network does not have internet\r\n    routable access during testing, only during ```vm-run``` and ```vm-create```. The SSH\r\n    and Cockpit ports are forwarded locally. Each machine is\r\n    isolated from each other on this network.\r\n\r\n 3. The network we use for inter machine access is a qemu\r\n    socket mcast network. Each test case gets its own isolated\r\n    mcast network for its machines. During ```vm-run``` there is a shared network here. There is no DHCP, DNS or\r\n    routing on this network. These interfaces have predictable\r\n    mac addresses like ```ee:00:00:00:00:01``` for the first machine\r\n    and ```:02``` for the second ... etc.\r\n\r\n 4. All machines that are run via vm-run have routable internet\r\n    access over the qemu user network.\r\n\r\nFollowing upshots of the above:\r\n\r\n * If you want machines to talk to one another you have to give\r\n   them addresses explicitly on the socket mcast network.\r\n\r\n * To access machines use their localhost mapped SSH port or\r\n   Cockpit port. These look like ```127.0.0.1:2201``` and ```127.0.0.1:9091```\r\n   respectively. Look at the virtual machine name to determine this.\r\n\r\nRemaining work:\r\n\r\n* [x] Basic implementation\r\n* [x] Make IPA and Openshift VMs with fixed addresses set their own addresses\r\n* [x] Migrate multi machine tests\r\n* [x] Make test/vm-run print its SSH and Cockpit addresses\r\n","created_at":"2017-04-13T09:40:50Z","updated_at":"2017-04-18T11:46:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b919380770ae74c5c451438d45cbb83d1536effe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/6334/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/6334/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/6334/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/cc2cb14550bb3dbba10c41da1a5786bd9e015b65","head":{"label":"stefwalter:socket-network","ref":"socket-network","sha":"cc2cb14550bb3dbba10c41da1a5786bd9e015b65","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars2.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"repo":{"id":14296513,"name":"cockpit","full_name":"stefwalter/cockpit","owner":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars2.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefwalter/cockpit","description":"Cockpit, a user interface for Linux servers","fork":true,"url":"https://api.github.com/repos/stefwalter/cockpit","forks_url":"https://api.github.com/repos/stefwalter/cockpit/forks","keys_url":"https://api.github.com/repos/stefwalter/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefwalter/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefwalter/cockpit/teams","hooks_url":"https://api.github.com/repos/stefwalter/cockpit/hooks","issue_events_url":"https://api.github.com/repos/stefwalter/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/stefwalter/cockpit/events","assignees_url":"https://api.github.com/repos/stefwalter/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/stefwalter/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/stefwalter/cockpit/tags","blobs_url":"https://api.github.com/repos/stefwalter/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefwalter/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefwalter/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefwalter/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefwalter/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/stefwalter/cockpit/languages","stargazers_url":"https://api.github.com/repos/stefwalter/cockpit/stargazers","contributors_url":"https://api.github.com/repos/stefwalter/cockpit/contributors","subscribers_url":"https://api.github.com/repos/stefwalter/cockpit/subscribers","subscription_url":"https://api.github.com/repos/stefwalter/cockpit/subscription","commits_url":"https://api.github.com/repos/stefwalter/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefwalter/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefwalter/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefwalter/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefwalter/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/stefwalter/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefwalter/cockpit/merges","archive_url":"https://api.github.com/repos/stefwalter/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefwalter/cockpit/downloads","issues_url":"https://api.github.com/repos/stefwalter/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/stefwalter/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/stefwalter/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/stefwalter/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefwalter/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/stefwalter/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/stefwalter/cockpit/deployments","created_at":"2013-11-11T09:27:50Z","updated_at":"2016-11-16T10:33:58Z","pushed_at":"2017-04-18T08:29:40Z","git_url":"git://github.com/stefwalter/cockpit.git","ssh_url":"git@github.com:stefwalter/cockpit.git","clone_url":"https://github.com/stefwalter/cockpit.git","svn_url":"https://github.com/stefwalter/cockpit","homepage":"http://www.cockpit-project.org/","size":35504,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"75cb474d045a72f904dbb586183ad27cbb808ed0","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars1.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars1.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"There's code a goin' on","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2017-04-17T14:10:44Z","pushed_at":"2017-04-18T11:06:54Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":32750,"stargazers_count":2017,"watchers_count":2017,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":297,"mirror_url":null,"open_issues_count":416,"forks":297,"open_issues":416,"watchers":2017,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/6334"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/6334"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/6334"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/6334/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/6334/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/6334/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/cc2cb14550bb3dbba10c41da1a5786bd9e015b65"}}}}
{"actor":{"display_login":"martinpitt"}}