{"action":"created","issue":{"url":"https://api.github.com/repos/ncapdevi/FragNav/issues/41","repository_url":"https://api.github.com/repos/ncapdevi/FragNav","labels_url":"https://api.github.com/repos/ncapdevi/FragNav/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/ncapdevi/FragNav/issues/41/comments","events_url":"https://api.github.com/repos/ncapdevi/FragNav/issues/41/events","html_url":"https://github.com/ncapdevi/FragNav/issues/41","id":207064400,"number":41,"title":"Fragment Transaction - Shared Elements, etc","user":{"login":"liquidninja24","id":1657404,"avatar_url":"https://avatars.githubusercontent.com/u/1657404?v=3","gravatar_id":"","url":"https://api.github.com/users/liquidninja24","html_url":"https://github.com/liquidninja24","followers_url":"https://api.github.com/users/liquidninja24/followers","following_url":"https://api.github.com/users/liquidninja24/following{/other_user}","gists_url":"https://api.github.com/users/liquidninja24/gists{/gist_id}","starred_url":"https://api.github.com/users/liquidninja24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquidninja24/subscriptions","organizations_url":"https://api.github.com/users/liquidninja24/orgs","repos_url":"https://api.github.com/users/liquidninja24/repos","events_url":"https://api.github.com/users/liquidninja24/events{/privacy}","received_events_url":"https://api.github.com/users/liquidninja24/received_events","type":"User","site_admin":false},"labels":[{"id":348063715,"url":"https://api.github.com/repos/ncapdevi/FragNav/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"ncapdevi","id":933088,"avatar_url":"https://avatars.githubusercontent.com/u/933088?v=3","gravatar_id":"","url":"https://api.github.com/users/ncapdevi","html_url":"https://github.com/ncapdevi","followers_url":"https://api.github.com/users/ncapdevi/followers","following_url":"https://api.github.com/users/ncapdevi/following{/other_user}","gists_url":"https://api.github.com/users/ncapdevi/gists{/gist_id}","starred_url":"https://api.github.com/users/ncapdevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncapdevi/subscriptions","organizations_url":"https://api.github.com/users/ncapdevi/orgs","repos_url":"https://api.github.com/users/ncapdevi/repos","events_url":"https://api.github.com/users/ncapdevi/events{/privacy}","received_events_url":"https://api.github.com/users/ncapdevi/received_events","type":"User","site_admin":false},"assignees":[{"login":"ncapdevi","id":933088,"avatar_url":"https://avatars.githubusercontent.com/u/933088?v=3","gravatar_id":"","url":"https://api.github.com/users/ncapdevi","html_url":"https://github.com/ncapdevi","followers_url":"https://api.github.com/users/ncapdevi/followers","following_url":"https://api.github.com/users/ncapdevi/following{/other_user}","gists_url":"https://api.github.com/users/ncapdevi/gists{/gist_id}","starred_url":"https://api.github.com/users/ncapdevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncapdevi/subscriptions","organizations_url":"https://api.github.com/users/ncapdevi/orgs","repos_url":"https://api.github.com/users/ncapdevi/repos","events_url":"https://api.github.com/users/ncapdevi/events{/privacy}","received_events_url":"https://api.github.com/users/ncapdevi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-02-12T17:22:31Z","updated_at":"2017-02-13T00:02:49Z","closed_at":null,"body":"@ncapdevi: Great library!\r\n\r\nI'm looking to implement FragNav into a single activity application with tabs, and was wondering if you'd given any thought to more complex transitions, or FragmentTransaction behavior in general? Specifically, I'm interested in utilizing shared element transitions as explained here: https://medium.com/@bherbst/fragment-transitions-with-shared-elements-7c7d71d31cbb#.y6g2ft1sv.\r\n\r\nThe immediate fix for this could be to overload the pushFragment and popFragment methods to allow passing in a `List` of `Pair`s of shared elements, but then you go down the slipper slope of adding new params for every property on a FragmentTransaction. To make things more extensible I thought about passing in a callback that takes in a FragmentTransaction and let's the caller modify properties on it before the FragNavController commits the transaction. This, however, opens up the possibility for a developer to completely screw themselves.\r\n\r\nDo you have any thoughts on this?\r\n\r\nThanks!\r\nNick"},"comment":{"url":"https://api.github.com/repos/ncapdevi/FragNav/issues/comments/279266134","html_url":"https://github.com/ncapdevi/FragNav/issues/41#issuecomment-279266134","issue_url":"https://api.github.com/repos/ncapdevi/FragNav/issues/41","id":279266134,"user":{"login":"ncapdevi","id":933088,"avatar_url":"https://avatars.githubusercontent.com/u/933088?v=3","gravatar_id":"","url":"https://api.github.com/users/ncapdevi","html_url":"https://github.com/ncapdevi","followers_url":"https://api.github.com/users/ncapdevi/followers","following_url":"https://api.github.com/users/ncapdevi/following{/other_user}","gists_url":"https://api.github.com/users/ncapdevi/gists{/gist_id}","starred_url":"https://api.github.com/users/ncapdevi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncapdevi/subscriptions","organizations_url":"https://api.github.com/users/ncapdevi/orgs","repos_url":"https://api.github.com/users/ncapdevi/repos","events_url":"https://api.github.com/users/ncapdevi/events{/privacy}","received_events_url":"https://api.github.com/users/ncapdevi/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T00:02:49Z","updated_at":"2017-02-13T00:02:49Z","body":"Yup, I definitely like that the most.  I think that strikes a nice balance. I'll go ahead and branch off, write up a version of it and it'd be a big help if you could check it and make sure it'd work for your use case."}}
{"actor":{"display_login":"ncapdevi"}}