{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/140350755","pull_request_review_id":64412927,"id":140350755,"diff_hunk":"@@ -3545,7 +3545,7 @@ unsigned long ODBC::ConvertCharToNumeric(SQLPOINTER srcDataPtr,\n     rTrim(cTmpBuf);\n     tempLen = strlen(cTmpBuf);\n     errno = 0;\n-\tdTmp = strtod(cTmpBuf, &errorCharPtr);\n+\tdTmp = strtold(cTmpBuf, &errorCharPtr);","path":"core/conn/unixodbc/odbc/odbcclient/unixcli/cli/ctosqlconv.cpp","position":5,"original_position":5,"commit_id":"693a3ceda4c818caf3735dffd763a616b533d2af","original_commit_id":"693a3ceda4c818caf3735dffd763a616b533d2af","user":{"login":"selvaganesang","id":8702996,"avatar_url":"https://avatars1.githubusercontent.com/u/8702996?v=4","gravatar_id":"","url":"https://api.github.com/users/selvaganesang","html_url":"https://github.com/selvaganesang","followers_url":"https://api.github.com/users/selvaganesang/followers","following_url":"https://api.github.com/users/selvaganesang/following{/other_user}","gists_url":"https://api.github.com/users/selvaganesang/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaganesang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaganesang/subscriptions","organizations_url":"https://api.github.com/users/selvaganesang/orgs","repos_url":"https://api.github.com/users/selvaganesang/repos","events_url":"https://api.github.com/users/selvaganesang/events{/privacy}","received_events_url":"https://api.github.com/users/selvaganesang/received_events","type":"User","site_admin":false},"body":"This looks innocuous, but strlod return long double which is 16 byte.  This 16 byte is assigned to 8 byte double dTmp. I am not sure if there is an implicit casting to double from long double can work as expected. ","created_at":"2017-09-21T20:29:30Z","updated_at":"2017-09-21T20:29:31Z","html_url":"https://github.com/apache/incubator-trafodion/pull/1241#discussion_r140350755","pull_request_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1241","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/140350755"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/1241#discussion_r140350755"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1241"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1241","id":142023741,"html_url":"https://github.com/apache/incubator-trafodion/pull/1241","diff_url":"https://github.com/apache/incubator-trafodion/pull/1241.diff","patch_url":"https://github.com/apache/incubator-trafodion/pull/1241.patch","issue_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/1241","number":1241,"state":"open","locked":false,"title":"[TRAFODION-2750] Using function strtod is not enough to convert C_CHAR to DOUBLE","user":{"login":"Weixin-Xu","id":25025405,"avatar_url":"https://avatars0.githubusercontent.com/u/25025405?v=4","gravatar_id":"","url":"https://api.github.com/users/Weixin-Xu","html_url":"https://github.com/Weixin-Xu","followers_url":"https://api.github.com/users/Weixin-Xu/followers","following_url":"https://api.github.com/users/Weixin-Xu/following{/other_user}","gists_url":"https://api.github.com/users/Weixin-Xu/gists{/gist_id}","starred_url":"https://api.github.com/users/Weixin-Xu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Weixin-Xu/subscriptions","organizations_url":"https://api.github.com/users/Weixin-Xu/orgs","repos_url":"https://api.github.com/users/Weixin-Xu/repos","events_url":"https://api.github.com/users/Weixin-Xu/events{/privacy}","received_events_url":"https://api.github.com/users/Weixin-Xu/received_events","type":"User","site_admin":false},"body":"client app with odbc driver :\r\nDDL : \"CREATE TABLE DOUBLE_TEST(A DOUBLE PRECISION)\"\r\nbuffer =   \"-2.22507e-308\"\r\nBind SQL_C_CHAR to SQL_DOUBLE\r\nreturn :\r\nState: 22003\r\nNative Error: 0\r\nError: [Trafodion ODBC Driver] NUMERIC VALUE OUT OF RANGE. Incorrect Format or Data. Row: 1 Column: 1\r\n\r\nunit test for driver code :\r\nchar buffer[] = \"-2.22507e-308\";\r\ndouble db;\r\nerrno = 0;\r\ndb = strtod(buffer,NULL);\r\nreturn :\r\ndb = -0.000000\r\nerrno = 34","created_at":"2017-09-20T07:00:44Z","updated_at":"2017-09-21T20:29:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2203afd1a6b367af31378109b20478cd2bca3efa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1241/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1241/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/1241/comments","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/693a3ceda4c818caf3735dffd763a616b533d2af","head":{"label":"Weixin-Xu:master","ref":"master","sha":"693a3ceda4c818caf3735dffd763a616b533d2af","user":{"login":"Weixin-Xu","id":25025405,"avatar_url":"https://avatars0.githubusercontent.com/u/25025405?v=4","gravatar_id":"","url":"https://api.github.com/users/Weixin-Xu","html_url":"https://github.com/Weixin-Xu","followers_url":"https://api.github.com/users/Weixin-Xu/followers","following_url":"https://api.github.com/users/Weixin-Xu/following{/other_user}","gists_url":"https://api.github.com/users/Weixin-Xu/gists{/gist_id}","starred_url":"https://api.github.com/users/Weixin-Xu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Weixin-Xu/subscriptions","organizations_url":"https://api.github.com/users/Weixin-Xu/orgs","repos_url":"https://api.github.com/users/Weixin-Xu/repos","events_url":"https://api.github.com/users/Weixin-Xu/events{/privacy}","received_events_url":"https://api.github.com/users/Weixin-Xu/received_events","type":"User","site_admin":false},"repo":{"id":88608086,"name":"incubator-trafodion","full_name":"Weixin-Xu/incubator-trafodion","owner":{"login":"Weixin-Xu","id":25025405,"avatar_url":"https://avatars0.githubusercontent.com/u/25025405?v=4","gravatar_id":"","url":"https://api.github.com/users/Weixin-Xu","html_url":"https://github.com/Weixin-Xu","followers_url":"https://api.github.com/users/Weixin-Xu/followers","following_url":"https://api.github.com/users/Weixin-Xu/following{/other_user}","gists_url":"https://api.github.com/users/Weixin-Xu/gists{/gist_id}","starred_url":"https://api.github.com/users/Weixin-Xu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Weixin-Xu/subscriptions","organizations_url":"https://api.github.com/users/Weixin-Xu/orgs","repos_url":"https://api.github.com/users/Weixin-Xu/repos","events_url":"https://api.github.com/users/Weixin-Xu/events{/privacy}","received_events_url":"https://api.github.com/users/Weixin-Xu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Weixin-Xu/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":true,"url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion","forks_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/Weixin-Xu/incubator-trafodion/deployments","created_at":"2017-04-18T09:38:48Z","updated_at":"2017-04-18T09:39:18Z","pushed_at":"2017-09-20T06:29:45Z","git_url":"git://github.com/Weixin-Xu/incubator-trafodion.git","ssh_url":"git@github.com:Weixin-Xu/incubator-trafodion.git","clone_url":"https://github.com/Weixin-Xu/incubator-trafodion.git","svn_url":"https://github.com/Weixin-Xu/incubator-trafodion","homepage":null,"size":82494,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"dc0d2043d05c1d8830cfbaa7c6fa16dad26a53ba","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36349344,"name":"incubator-trafodion","full_name":"apache/incubator-trafodion","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-trafodion","forks_url":"https://api.github.com/repos/apache/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/apache/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/apache/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/apache/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/apache/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/apache/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/apache/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-trafodion/deployments","created_at":"2015-05-27T07:00:05Z","updated_at":"2017-08-31T15:41:57Z","pushed_at":"2017-09-20T23:56:03Z","git_url":"git://github.com/apache/incubator-trafodion.git","ssh_url":"git@github.com:apache/incubator-trafodion.git","clone_url":"https://github.com/apache/incubator-trafodion.git","svn_url":"https://github.com/apache/incubator-trafodion","homepage":null,"size":82436,"stargazers_count":113,"watchers_count":113,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":97,"mirror_url":"git://git.apache.org/incubator-trafodion.git","open_issues_count":9,"forks":97,"open_issues":9,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1241"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/1241"},"issue":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/1241"},"comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/1241/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1241/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1241/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-trafodion/statuses/693a3ceda4c818caf3735dffd763a616b533d2af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"selvaganesang"}}