{"action":"created","comment":{"url":"https://api.github.com/repos/ibis-project/ibis/pulls/comments/121259671","pull_request_review_id":43299973,"id":121259671,"diff_hunk":"@@ -239,6 +245,17 @@ def execute_any_all_series(op, data, scope=None):\n     return getattr(data, type(op).__name__.lower())()\n \n \n+@execute_node.register(ops.CountDistinct, pd.Series)\n+def execute_count_distinct_series(op, data, scope=None):\n+    # TODO(phillipc): Does count distinct have a mask?\n+    return data.nunique()\n+\n+\n+@execute_node.register(ops.Count, pd.DataFrame, type(None))\n+def execute_count_frame(op, data, _, scope=None):\n+    return len(data)","path":"ibis/pandas/execution.py","position":142,"original_position":142,"commit_id":"34c53cc49195b6382b1aca9323d94485e841b691","original_commit_id":"34c53cc49195b6382b1aca9323d94485e841b691","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars1.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"shouldn't this be ``data.count()`` this is a 1 dim reduction no, e.g. return a pd.Series).","created_at":"2017-06-10T15:24:18Z","updated_at":"2017-06-10T15:24:18Z","html_url":"https://github.com/ibis-project/ibis/pull/1020#discussion_r121259671","pull_request_url":"https://api.github.com/repos/ibis-project/ibis/pulls/1020","_links":{"self":{"href":"https://api.github.com/repos/ibis-project/ibis/pulls/comments/121259671"},"html":{"href":"https://github.com/ibis-project/ibis/pull/1020#discussion_r121259671"},"pull_request":{"href":"https://api.github.com/repos/ibis-project/ibis/pulls/1020"}}},"pull_request":{"url":"https://api.github.com/repos/ibis-project/ibis/pulls/1020","id":124994199,"html_url":"https://github.com/ibis-project/ibis/pull/1020","diff_url":"https://github.com/ibis-project/ibis/pull/1020.diff","patch_url":"https://github.com/ibis-project/ibis/pull/1020.patch","issue_url":"https://api.github.com/repos/ibis-project/ibis/issues/1020","number":1020,"state":"open","locked":false,"title":"ENH: Implement distinct, count distinct, count on tables, and value counts","user":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars2.githubusercontent.com/u/417981?v=3","gravatar_id":"","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-06-10T15:20:34Z","updated_at":"2017-06-10T15:24:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9025b551c94f9f0cebe21e28b58c182dd00dc648","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ibis-project/ibis/pulls/1020/commits","review_comments_url":"https://api.github.com/repos/ibis-project/ibis/pulls/1020/comments","review_comment_url":"https://api.github.com/repos/ibis-project/ibis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ibis-project/ibis/issues/1020/comments","statuses_url":"https://api.github.com/repos/ibis-project/ibis/statuses/34c53cc49195b6382b1aca9323d94485e841b691","head":{"label":"cpcloud:distinct","ref":"distinct","sha":"34c53cc49195b6382b1aca9323d94485e841b691","user":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars2.githubusercontent.com/u/417981?v=3","gravatar_id":"","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"repo":{"id":41739288,"name":"ibis","full_name":"cpcloud/ibis","owner":{"login":"cpcloud","id":417981,"avatar_url":"https://avatars2.githubusercontent.com/u/417981?v=3","gravatar_id":"","url":"https://api.github.com/users/cpcloud","html_url":"https://github.com/cpcloud","followers_url":"https://api.github.com/users/cpcloud/followers","following_url":"https://api.github.com/users/cpcloud/following{/other_user}","gists_url":"https://api.github.com/users/cpcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/cpcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpcloud/subscriptions","organizations_url":"https://api.github.com/users/cpcloud/orgs","repos_url":"https://api.github.com/users/cpcloud/repos","events_url":"https://api.github.com/users/cpcloud/events{/privacy}","received_events_url":"https://api.github.com/users/cpcloud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpcloud/ibis","description":"Productivity-centric Python big data analysis framework for high performance at Hadoop-scale, with first-class integration with Impala. Co-founded by the creator of pandas","fork":true,"url":"https://api.github.com/repos/cpcloud/ibis","forks_url":"https://api.github.com/repos/cpcloud/ibis/forks","keys_url":"https://api.github.com/repos/cpcloud/ibis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpcloud/ibis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpcloud/ibis/teams","hooks_url":"https://api.github.com/repos/cpcloud/ibis/hooks","issue_events_url":"https://api.github.com/repos/cpcloud/ibis/issues/events{/number}","events_url":"https://api.github.com/repos/cpcloud/ibis/events","assignees_url":"https://api.github.com/repos/cpcloud/ibis/assignees{/user}","branches_url":"https://api.github.com/repos/cpcloud/ibis/branches{/branch}","tags_url":"https://api.github.com/repos/cpcloud/ibis/tags","blobs_url":"https://api.github.com/repos/cpcloud/ibis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpcloud/ibis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpcloud/ibis/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpcloud/ibis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpcloud/ibis/statuses/{sha}","languages_url":"https://api.github.com/repos/cpcloud/ibis/languages","stargazers_url":"https://api.github.com/repos/cpcloud/ibis/stargazers","contributors_url":"https://api.github.com/repos/cpcloud/ibis/contributors","subscribers_url":"https://api.github.com/repos/cpcloud/ibis/subscribers","subscription_url":"https://api.github.com/repos/cpcloud/ibis/subscription","commits_url":"https://api.github.com/repos/cpcloud/ibis/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpcloud/ibis/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpcloud/ibis/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpcloud/ibis/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpcloud/ibis/contents/{+path}","compare_url":"https://api.github.com/repos/cpcloud/ibis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpcloud/ibis/merges","archive_url":"https://api.github.com/repos/cpcloud/ibis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpcloud/ibis/downloads","issues_url":"https://api.github.com/repos/cpcloud/ibis/issues{/number}","pulls_url":"https://api.github.com/repos/cpcloud/ibis/pulls{/number}","milestones_url":"https://api.github.com/repos/cpcloud/ibis/milestones{/number}","notifications_url":"https://api.github.com/repos/cpcloud/ibis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpcloud/ibis/labels{/name}","releases_url":"https://api.github.com/repos/cpcloud/ibis/releases{/id}","deployments_url":"https://api.github.com/repos/cpcloud/ibis/deployments","created_at":"2015-09-01T13:10:15Z","updated_at":"2016-11-13T20:40:51Z","pushed_at":"2017-06-10T15:21:49Z","git_url":"git://github.com/cpcloud/ibis.git","ssh_url":"git@github.com:cpcloud/ibis.git","clone_url":"https://github.com/cpcloud/ibis.git","svn_url":"https://github.com/cpcloud/ibis","homepage":"","size":2883,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ibis-project:master","ref":"master","sha":"b954ed61d4587542f456e8ea7eedad02f9618282","user":{"login":"ibis-project","id":27442526,"avatar_url":"https://avatars0.githubusercontent.com/u/27442526?v=3","gravatar_id":"","url":"https://api.github.com/users/ibis-project","html_url":"https://github.com/ibis-project","followers_url":"https://api.github.com/users/ibis-project/followers","following_url":"https://api.github.com/users/ibis-project/following{/other_user}","gists_url":"https://api.github.com/users/ibis-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ibis-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibis-project/subscriptions","organizations_url":"https://api.github.com/users/ibis-project/orgs","repos_url":"https://api.github.com/users/ibis-project/repos","events_url":"https://api.github.com/users/ibis-project/events{/privacy}","received_events_url":"https://api.github.com/users/ibis-project/received_events","type":"Organization","site_admin":false},"repo":{"id":34139230,"name":"ibis","full_name":"ibis-project/ibis","owner":{"login":"ibis-project","id":27442526,"avatar_url":"https://avatars0.githubusercontent.com/u/27442526?v=3","gravatar_id":"","url":"https://api.github.com/users/ibis-project","html_url":"https://github.com/ibis-project","followers_url":"https://api.github.com/users/ibis-project/followers","following_url":"https://api.github.com/users/ibis-project/following{/other_user}","gists_url":"https://api.github.com/users/ibis-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ibis-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibis-project/subscriptions","organizations_url":"https://api.github.com/users/ibis-project/orgs","repos_url":"https://api.github.com/users/ibis-project/repos","events_url":"https://api.github.com/users/ibis-project/events{/privacy}","received_events_url":"https://api.github.com/users/ibis-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ibis-project/ibis","description":"A pandas-like deferred expression system, with first-class SQL support (Impala, PostgreSQL, SQLite, ...)","fork":false,"url":"https://api.github.com/repos/ibis-project/ibis","forks_url":"https://api.github.com/repos/ibis-project/ibis/forks","keys_url":"https://api.github.com/repos/ibis-project/ibis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibis-project/ibis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibis-project/ibis/teams","hooks_url":"https://api.github.com/repos/ibis-project/ibis/hooks","issue_events_url":"https://api.github.com/repos/ibis-project/ibis/issues/events{/number}","events_url":"https://api.github.com/repos/ibis-project/ibis/events","assignees_url":"https://api.github.com/repos/ibis-project/ibis/assignees{/user}","branches_url":"https://api.github.com/repos/ibis-project/ibis/branches{/branch}","tags_url":"https://api.github.com/repos/ibis-project/ibis/tags","blobs_url":"https://api.github.com/repos/ibis-project/ibis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibis-project/ibis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibis-project/ibis/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibis-project/ibis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibis-project/ibis/statuses/{sha}","languages_url":"https://api.github.com/repos/ibis-project/ibis/languages","stargazers_url":"https://api.github.com/repos/ibis-project/ibis/stargazers","contributors_url":"https://api.github.com/repos/ibis-project/ibis/contributors","subscribers_url":"https://api.github.com/repos/ibis-project/ibis/subscribers","subscription_url":"https://api.github.com/repos/ibis-project/ibis/subscription","commits_url":"https://api.github.com/repos/ibis-project/ibis/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibis-project/ibis/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibis-project/ibis/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibis-project/ibis/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibis-project/ibis/contents/{+path}","compare_url":"https://api.github.com/repos/ibis-project/ibis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibis-project/ibis/merges","archive_url":"https://api.github.com/repos/ibis-project/ibis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibis-project/ibis/downloads","issues_url":"https://api.github.com/repos/ibis-project/ibis/issues{/number}","pulls_url":"https://api.github.com/repos/ibis-project/ibis/pulls{/number}","milestones_url":"https://api.github.com/repos/ibis-project/ibis/milestones{/number}","notifications_url":"https://api.github.com/repos/ibis-project/ibis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibis-project/ibis/labels{/name}","releases_url":"https://api.github.com/repos/ibis-project/ibis/releases{/id}","deployments_url":"https://api.github.com/repos/ibis-project/ibis/deployments","created_at":"2015-04-17T20:43:46Z","updated_at":"2017-06-07T09:29:02Z","pushed_at":"2017-06-10T15:21:50Z","git_url":"git://github.com/ibis-project/ibis.git","ssh_url":"git@github.com:ibis-project/ibis.git","clone_url":"https://github.com/ibis-project/ibis.git","svn_url":"https://github.com/ibis-project/ibis","homepage":"http://ibis-project.org","size":2786,"stargazers_count":838,"watchers_count":838,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":235,"forks":113,"open_issues":235,"watchers":838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ibis-project/ibis/pulls/1020"},"html":{"href":"https://github.com/ibis-project/ibis/pull/1020"},"issue":{"href":"https://api.github.com/repos/ibis-project/ibis/issues/1020"},"comments":{"href":"https://api.github.com/repos/ibis-project/ibis/issues/1020/comments"},"review_comments":{"href":"https://api.github.com/repos/ibis-project/ibis/pulls/1020/comments"},"review_comment":{"href":"https://api.github.com/repos/ibis-project/ibis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ibis-project/ibis/pulls/1020/commits"},"statuses":{"href":"https://api.github.com/repos/ibis-project/ibis/statuses/34c53cc49195b6382b1aca9323d94485e841b691"}}}}
{"actor":{"display_login":"jreback"}}