{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/11997","repository_url":"https://api.github.com/repos/Microsoft/TypeScript","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/11997/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/11997/comments","events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/11997/events","html_url":"https://github.com/Microsoft/TypeScript/issues/11997","id":186860633,"number":11997,"title":"Language services for keyof types","user":{"login":"jods4","id":3832820,"avatar_url":"https://avatars1.githubusercontent.com/u/3832820?v=3","gravatar_id":"","url":"https://api.github.com/users/jods4","html_url":"https://github.com/jods4","followers_url":"https://api.github.com/users/jods4/followers","following_url":"https://api.github.com/users/jods4/following{/other_user}","gists_url":"https://api.github.com/users/jods4/gists{/gist_id}","starred_url":"https://api.github.com/users/jods4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jods4/subscriptions","organizations_url":"https://api.github.com/users/jods4/orgs","repos_url":"https://api.github.com/users/jods4/repos","events_url":"https://api.github.com/users/jods4/events{/privacy}","received_events_url":"https://api.github.com/users/jods4/received_events","type":"User","site_admin":false},"labels":[{"id":113970366,"url":"https://api.github.com/repos/Microsoft/TypeScript/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":371615233,"url":"https://api.github.com/repos/Microsoft/TypeScript/labels/Design%20Limitation","name":"Design Limitation","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"andy-ms","id":19274678,"avatar_url":"https://avatars0.githubusercontent.com/u/19274678?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-ms","html_url":"https://github.com/andy-ms","followers_url":"https://api.github.com/users/andy-ms/followers","following_url":"https://api.github.com/users/andy-ms/following{/other_user}","gists_url":"https://api.github.com/users/andy-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-ms/subscriptions","organizations_url":"https://api.github.com/users/andy-ms/orgs","repos_url":"https://api.github.com/users/andy-ms/repos","events_url":"https://api.github.com/users/andy-ms/events{/privacy}","received_events_url":"https://api.github.com/users/andy-ms/received_events","type":"User","site_admin":false},"assignees":[{"login":"andy-ms","id":19274678,"avatar_url":"https://avatars0.githubusercontent.com/u/19274678?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-ms","html_url":"https://github.com/andy-ms","followers_url":"https://api.github.com/users/andy-ms/followers","following_url":"https://api.github.com/users/andy-ms/following{/other_user}","gists_url":"https://api.github.com/users/andy-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-ms/subscriptions","organizations_url":"https://api.github.com/users/andy-ms/orgs","repos_url":"https://api.github.com/users/andy-ms/repos","events_url":"https://api.github.com/users/andy-ms/events{/privacy}","received_events_url":"https://api.github.com/users/andy-ms/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/TypeScript/milestones/43","html_url":"https://github.com/Microsoft/TypeScript/milestone/43","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones/43/labels","id":2434754,"number":43,"title":"TypeScript 2.4","description":"","creator":{"login":"mhegazy","id":8000722,"avatar_url":"https://avatars0.githubusercontent.com/u/8000722?v=3","gravatar_id":"","url":"https://api.github.com/users/mhegazy","html_url":"https://github.com/mhegazy","followers_url":"https://api.github.com/users/mhegazy/followers","following_url":"https://api.github.com/users/mhegazy/following{/other_user}","gists_url":"https://api.github.com/users/mhegazy/gists{/gist_id}","starred_url":"https://api.github.com/users/mhegazy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhegazy/subscriptions","organizations_url":"https://api.github.com/users/mhegazy/orgs","repos_url":"https://api.github.com/users/mhegazy/repos","events_url":"https://api.github.com/users/mhegazy/events{/privacy}","received_events_url":"https://api.github.com/users/mhegazy/received_events","type":"User","site_admin":false},"open_issues":107,"closed_issues":59,"state":"open","created_at":"2017-04-04T20:52:53Z","updated_at":"2017-05-12T18:36:50Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-11-02T17:03:12Z","updated_at":"2017-05-12T19:44:43Z","closed_at":"2017-05-12T18:06:15Z","body":"As asked by @mhegazy in #11929 this issue is for tracking language services for the new `keyof` type.\r\n\r\n----\r\n\r\nI hope this will surface in the language services like _Find references_ and _Rename_?\r\n\r\n```ts\r\nfunction pluck<T, K extends keyof T>(xs: T[], prop: K): T[K][];\r\n\r\nclass Thing { name: string; }\r\n\r\n// Is this found when looking for references to Thing.name?\r\n// Does renaming Thing.name to firstName update the string?\r\nlet x = pluck(things, \"name\");\r\n```` "},"comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments/301168903","html_url":"https://github.com/Microsoft/TypeScript/issues/11997#issuecomment-301168903","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/11997","id":301168903,"user":{"login":"jods4","id":3832820,"avatar_url":"https://avatars1.githubusercontent.com/u/3832820?v=3","gravatar_id":"","url":"https://api.github.com/users/jods4","html_url":"https://github.com/jods4","followers_url":"https://api.github.com/users/jods4/followers","following_url":"https://api.github.com/users/jods4/following{/other_user}","gists_url":"https://api.github.com/users/jods4/gists{/gist_id}","starred_url":"https://api.github.com/users/jods4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jods4/subscriptions","organizations_url":"https://api.github.com/users/jods4/orgs","repos_url":"https://api.github.com/users/jods4/repos","events_url":"https://api.github.com/users/jods4/events{/privacy}","received_events_url":"https://api.github.com/users/jods4/received_events","type":"User","site_admin":false},"created_at":"2017-05-12T19:44:43Z","updated_at":"2017-05-12T19:44:43Z","body":"Just saying: this is a hard hit into the `keyof` experience, especially when considering its use in places where `nameof` could have been used. Several people in the `nameof` thread were content with `keyof`, should these language services later come.\r\n\r\nAt least, I feel like you should tag this \"Revisit\" or something and keep it open until you find a design that can support it. Closing because it's hard to do now doesn't feel good/right."}}
{"actor":{"display_login":"jods4"}}