{"action":"created","comment":{"url":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/comments/103298405","pull_request_review_id":24080113,"id":103298405,"diff_hunk":"@@ -0,0 +1,52 @@\n+import SelectAll from 'ember-light-table/behaviors/select-all';\n+\n+export default SelectAll.extend({\n+\n+  // passed in\n+  requiresKeyboard: true,\n+\n+  init() {\n+    this._super.call(this, ...arguments);\n+    this.events.onSelectRow = [ 'rowClick:_all' ];\n+    this.events.onExtendRange = [ 'rowClick:shift' ];\n+    this.events.onToggleRow = [ 'rowClick:ctrl' ];\n+  },\n+\n+  _prevSelectedIndex: -1,\n+\n+  _onRowClick(ltBody, row, f) {\n+    let table = ltBody.get('table');\n+    let i = table.get('rows').indexOf(row);\n+    f.call(this, i, table);\n+    this._prevSelectedIndex = i;\n+  },\n+\n+  onSelectRow(ltBody, row) {\n+    let isSelected = row.get('selected');\n+    if (this.get('requiresKeyboard')) {\n+      this._onRowClick(ltBody, row, function(i, table) {","path":"addon/behaviors/multi-select.js","position":27,"original_position":27,"commit_id":"6544f912d4f9a0720d6d8a5f450eeb8d56475c65","original_commit_id":"6544f912d4f9a0720d6d8a5f450eeb8d56475c65","user":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"body":"Please refactor to use ES6 syntax ","created_at":"2017-02-27T20:02:49Z","updated_at":"2017-02-27T20:08:02Z","html_url":"https://github.com/offirgolan/ember-light-table/pull/347#discussion_r103298405","pull_request_url":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/347","_links":{"self":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/comments/103298405"},"html":{"href":"https://github.com/offirgolan/ember-light-table/pull/347#discussion_r103298405"},"pull_request":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/347"}}},"pull_request":{"url":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/347","id":108054596,"html_url":"https://github.com/offirgolan/ember-light-table/pull/347","diff_url":"https://github.com/offirgolan/ember-light-table/pull/347.diff","patch_url":"https://github.com/offirgolan/ember-light-table/pull/347.patch","issue_url":"https://api.github.com/repos/offirgolan/ember-light-table/issues/347","number":347,"state":"open","locked":false,"title":"Modular behaviors + Keyboard support","user":{"login":"plcarmel","id":6952307,"avatar_url":"https://avatars.githubusercontent.com/u/6952307?v=3","gravatar_id":"","url":"https://api.github.com/users/plcarmel","html_url":"https://github.com/plcarmel","followers_url":"https://api.github.com/users/plcarmel/followers","following_url":"https://api.github.com/users/plcarmel/following{/other_user}","gists_url":"https://api.github.com/users/plcarmel/gists{/gist_id}","starred_url":"https://api.github.com/users/plcarmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plcarmel/subscriptions","organizations_url":"https://api.github.com/users/plcarmel/orgs","repos_url":"https://api.github.com/users/plcarmel/repos","events_url":"https://api.github.com/users/plcarmel/events{/privacy}","received_events_url":"https://api.github.com/users/plcarmel/received_events","type":"User","site_admin":false},"body":"To resolve #236 \r\n\r\nWork in progress.\r\n\r\nI will...\r\n- add more tests.\r\n- implement row expansion using the keyboard.\r\n- continue improving \"spreadsheet select\" so it has most of the selection features and key bindings of MS Excel\r\n- improve \"single-select\" and \"multi-select\", possibly making them behave like @ScottSmix suggested in #236 \r\n","created_at":"2017-02-27T06:32:56Z","updated_at":"2017-02-27T20:08:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03a5b32243d7fd45dcb22f49d34d795583a41ce0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/347/commits","review_comments_url":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/347/comments","review_comment_url":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/comments{/number}","comments_url":"https://api.github.com/repos/offirgolan/ember-light-table/issues/347/comments","statuses_url":"https://api.github.com/repos/offirgolan/ember-light-table/statuses/6544f912d4f9a0720d6d8a5f450eeb8d56475c65","head":{"label":"plcarmel:behaviors","ref":"behaviors","sha":"6544f912d4f9a0720d6d8a5f450eeb8d56475c65","user":{"login":"plcarmel","id":6952307,"avatar_url":"https://avatars.githubusercontent.com/u/6952307?v=3","gravatar_id":"","url":"https://api.github.com/users/plcarmel","html_url":"https://github.com/plcarmel","followers_url":"https://api.github.com/users/plcarmel/followers","following_url":"https://api.github.com/users/plcarmel/following{/other_user}","gists_url":"https://api.github.com/users/plcarmel/gists{/gist_id}","starred_url":"https://api.github.com/users/plcarmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plcarmel/subscriptions","organizations_url":"https://api.github.com/users/plcarmel/orgs","repos_url":"https://api.github.com/users/plcarmel/repos","events_url":"https://api.github.com/users/plcarmel/events{/privacy}","received_events_url":"https://api.github.com/users/plcarmel/received_events","type":"User","site_admin":false},"repo":{"id":74528562,"name":"ember-light-table","full_name":"plcarmel/ember-light-table","owner":{"login":"plcarmel","id":6952307,"avatar_url":"https://avatars.githubusercontent.com/u/6952307?v=3","gravatar_id":"","url":"https://api.github.com/users/plcarmel","html_url":"https://github.com/plcarmel","followers_url":"https://api.github.com/users/plcarmel/followers","following_url":"https://api.github.com/users/plcarmel/following{/other_user}","gists_url":"https://api.github.com/users/plcarmel/gists{/gist_id}","starred_url":"https://api.github.com/users/plcarmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plcarmel/subscriptions","organizations_url":"https://api.github.com/users/plcarmel/orgs","repos_url":"https://api.github.com/users/plcarmel/repos","events_url":"https://api.github.com/users/plcarmel/events{/privacy}","received_events_url":"https://api.github.com/users/plcarmel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plcarmel/ember-light-table","description":"Lightweight, contextual component based table for Ember 2.3+","fork":true,"url":"https://api.github.com/repos/plcarmel/ember-light-table","forks_url":"https://api.github.com/repos/plcarmel/ember-light-table/forks","keys_url":"https://api.github.com/repos/plcarmel/ember-light-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plcarmel/ember-light-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plcarmel/ember-light-table/teams","hooks_url":"https://api.github.com/repos/plcarmel/ember-light-table/hooks","issue_events_url":"https://api.github.com/repos/plcarmel/ember-light-table/issues/events{/number}","events_url":"https://api.github.com/repos/plcarmel/ember-light-table/events","assignees_url":"https://api.github.com/repos/plcarmel/ember-light-table/assignees{/user}","branches_url":"https://api.github.com/repos/plcarmel/ember-light-table/branches{/branch}","tags_url":"https://api.github.com/repos/plcarmel/ember-light-table/tags","blobs_url":"https://api.github.com/repos/plcarmel/ember-light-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plcarmel/ember-light-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plcarmel/ember-light-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/plcarmel/ember-light-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plcarmel/ember-light-table/statuses/{sha}","languages_url":"https://api.github.com/repos/plcarmel/ember-light-table/languages","stargazers_url":"https://api.github.com/repos/plcarmel/ember-light-table/stargazers","contributors_url":"https://api.github.com/repos/plcarmel/ember-light-table/contributors","subscribers_url":"https://api.github.com/repos/plcarmel/ember-light-table/subscribers","subscription_url":"https://api.github.com/repos/plcarmel/ember-light-table/subscription","commits_url":"https://api.github.com/repos/plcarmel/ember-light-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/plcarmel/ember-light-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/plcarmel/ember-light-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/plcarmel/ember-light-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/plcarmel/ember-light-table/contents/{+path}","compare_url":"https://api.github.com/repos/plcarmel/ember-light-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plcarmel/ember-light-table/merges","archive_url":"https://api.github.com/repos/plcarmel/ember-light-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plcarmel/ember-light-table/downloads","issues_url":"https://api.github.com/repos/plcarmel/ember-light-table/issues{/number}","pulls_url":"https://api.github.com/repos/plcarmel/ember-light-table/pulls{/number}","milestones_url":"https://api.github.com/repos/plcarmel/ember-light-table/milestones{/number}","notifications_url":"https://api.github.com/repos/plcarmel/ember-light-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plcarmel/ember-light-table/labels{/name}","releases_url":"https://api.github.com/repos/plcarmel/ember-light-table/releases{/id}","deployments_url":"https://api.github.com/repos/plcarmel/ember-light-table/deployments","created_at":"2016-11-23T01:26:59Z","updated_at":"2016-11-23T01:27:01Z","pushed_at":"2017-02-27T06:26:24Z","git_url":"git://github.com/plcarmel/ember-light-table.git","ssh_url":"git@github.com:plcarmel/ember-light-table.git","clone_url":"https://github.com/plcarmel/ember-light-table.git","svn_url":"https://github.com/plcarmel/ember-light-table","homepage":"http://offirgolan.github.io/ember-light-table/","size":7297,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"offirgolan:master","ref":"master","sha":"7e98dc6bd3f1c288537037a0fc8edd2def40ae5c","user":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"repo":{"id":51966024,"name":"ember-light-table","full_name":"offirgolan/ember-light-table","owner":{"login":"offirgolan","id":575938,"avatar_url":"https://avatars.githubusercontent.com/u/575938?v=3","gravatar_id":"","url":"https://api.github.com/users/offirgolan","html_url":"https://github.com/offirgolan","followers_url":"https://api.github.com/users/offirgolan/followers","following_url":"https://api.github.com/users/offirgolan/following{/other_user}","gists_url":"https://api.github.com/users/offirgolan/gists{/gist_id}","starred_url":"https://api.github.com/users/offirgolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/offirgolan/subscriptions","organizations_url":"https://api.github.com/users/offirgolan/orgs","repos_url":"https://api.github.com/users/offirgolan/repos","events_url":"https://api.github.com/users/offirgolan/events{/privacy}","received_events_url":"https://api.github.com/users/offirgolan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/offirgolan/ember-light-table","description":"Lightweight, contextual component based table for Ember 2.3+","fork":false,"url":"https://api.github.com/repos/offirgolan/ember-light-table","forks_url":"https://api.github.com/repos/offirgolan/ember-light-table/forks","keys_url":"https://api.github.com/repos/offirgolan/ember-light-table/keys{/key_id}","collaborators_url":"https://api.github.com/repos/offirgolan/ember-light-table/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/offirgolan/ember-light-table/teams","hooks_url":"https://api.github.com/repos/offirgolan/ember-light-table/hooks","issue_events_url":"https://api.github.com/repos/offirgolan/ember-light-table/issues/events{/number}","events_url":"https://api.github.com/repos/offirgolan/ember-light-table/events","assignees_url":"https://api.github.com/repos/offirgolan/ember-light-table/assignees{/user}","branches_url":"https://api.github.com/repos/offirgolan/ember-light-table/branches{/branch}","tags_url":"https://api.github.com/repos/offirgolan/ember-light-table/tags","blobs_url":"https://api.github.com/repos/offirgolan/ember-light-table/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/offirgolan/ember-light-table/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/offirgolan/ember-light-table/git/refs{/sha}","trees_url":"https://api.github.com/repos/offirgolan/ember-light-table/git/trees{/sha}","statuses_url":"https://api.github.com/repos/offirgolan/ember-light-table/statuses/{sha}","languages_url":"https://api.github.com/repos/offirgolan/ember-light-table/languages","stargazers_url":"https://api.github.com/repos/offirgolan/ember-light-table/stargazers","contributors_url":"https://api.github.com/repos/offirgolan/ember-light-table/contributors","subscribers_url":"https://api.github.com/repos/offirgolan/ember-light-table/subscribers","subscription_url":"https://api.github.com/repos/offirgolan/ember-light-table/subscription","commits_url":"https://api.github.com/repos/offirgolan/ember-light-table/commits{/sha}","git_commits_url":"https://api.github.com/repos/offirgolan/ember-light-table/git/commits{/sha}","comments_url":"https://api.github.com/repos/offirgolan/ember-light-table/comments{/number}","issue_comment_url":"https://api.github.com/repos/offirgolan/ember-light-table/issues/comments{/number}","contents_url":"https://api.github.com/repos/offirgolan/ember-light-table/contents/{+path}","compare_url":"https://api.github.com/repos/offirgolan/ember-light-table/compare/{base}...{head}","merges_url":"https://api.github.com/repos/offirgolan/ember-light-table/merges","archive_url":"https://api.github.com/repos/offirgolan/ember-light-table/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/offirgolan/ember-light-table/downloads","issues_url":"https://api.github.com/repos/offirgolan/ember-light-table/issues{/number}","pulls_url":"https://api.github.com/repos/offirgolan/ember-light-table/pulls{/number}","milestones_url":"https://api.github.com/repos/offirgolan/ember-light-table/milestones{/number}","notifications_url":"https://api.github.com/repos/offirgolan/ember-light-table/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/offirgolan/ember-light-table/labels{/name}","releases_url":"https://api.github.com/repos/offirgolan/ember-light-table/releases{/id}","deployments_url":"https://api.github.com/repos/offirgolan/ember-light-table/deployments","created_at":"2016-02-18T00:25:49Z","updated_at":"2017-02-24T02:57:03Z","pushed_at":"2017-02-27T18:43:29Z","git_url":"git://github.com/offirgolan/ember-light-table.git","ssh_url":"git@github.com:offirgolan/ember-light-table.git","clone_url":"https://github.com/offirgolan/ember-light-table.git","svn_url":"https://github.com/offirgolan/ember-light-table","homepage":"http://offirgolan.github.io/ember-light-table/","size":8988,"stargazers_count":205,"watchers_count":205,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":47,"mirror_url":null,"open_issues_count":41,"forks":47,"open_issues":41,"watchers":205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/347"},"html":{"href":"https://github.com/offirgolan/ember-light-table/pull/347"},"issue":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/issues/347"},"comments":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/issues/347/comments"},"review_comments":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/347/comments"},"review_comment":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/pulls/347/commits"},"statuses":{"href":"https://api.github.com/repos/offirgolan/ember-light-table/statuses/6544f912d4f9a0720d6d8a5f450eeb8d56475c65"}}}}
{"actor":{"display_login":"offirgolan"}}