{"action":"created","comment":{"url":"https://api.github.com/repos/cozy/cozy-collect/pulls/comments/147917573","pull_request_review_id":73071552,"id":147917573,"diff_hunk":"@@ -36,23 +37,32 @@ export default class IntentService extends Component {\n           disableSuccessTimeout: !!data.disableSuccessTimeout\n         })\n \n-        if (!data || !data.slug) {\n+        if (!data) {\n           throw new Error('Unexpected data from intent')\n         }\n \n-        return this.store.fetchKonnectorInfos(data.slug)\n+        if (data.slug) {\n+          return this.store.fetchKonnectorInfos(data.slug)","path":"src/containers/IntentService.jsx","position":19,"original_position":19,"commit_id":"14181ac0b2dc27695ab8e033c81b78dfad0668af","original_commit_id":"14181ac0b2dc27695ab8e033c81b78dfad0668af","user":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars3.githubusercontent.com/u/776764?v=4","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"body":"To always return an array of konnectors, I suggest to do here:\r\n```js\r\nreturn this.store.fetchKonnectorInfos(data.slug).then(konnector => [konnector])\r\n```\r\nWhat do you think ?","created_at":"2017-10-31T08:09:44Z","updated_at":"2017-10-31T08:26:11Z","html_url":"https://github.com/cozy/cozy-collect/pull/324#discussion_r147917573","pull_request_url":"https://api.github.com/repos/cozy/cozy-collect/pulls/324","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-collect/pulls/comments/147917573"},"html":{"href":"https://github.com/cozy/cozy-collect/pull/324#discussion_r147917573"},"pull_request":{"href":"https://api.github.com/repos/cozy/cozy-collect/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/cozy/cozy-collect/pulls/324","id":148443710,"html_url":"https://github.com/cozy/cozy-collect/pull/324","diff_url":"https://github.com/cozy/cozy-collect/pull/324.diff","patch_url":"https://github.com/cozy/cozy-collect/pull/324.patch","issue_url":"https://api.github.com/repos/cozy/cozy-collect/issues/324","number":324,"state":"open","locked":false,"title":"feat: add a filter by dataType","user":{"login":"Narkfr","id":5773538,"avatar_url":"https://avatars2.githubusercontent.com/u/5773538?v=4","gravatar_id":"","url":"https://api.github.com/users/Narkfr","html_url":"https://github.com/Narkfr","followers_url":"https://api.github.com/users/Narkfr/followers","following_url":"https://api.github.com/users/Narkfr/following{/other_user}","gists_url":"https://api.github.com/users/Narkfr/gists{/gist_id}","starred_url":"https://api.github.com/users/Narkfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narkfr/subscriptions","organizations_url":"https://api.github.com/users/Narkfr/orgs","repos_url":"https://api.github.com/users/Narkfr/repos","events_url":"https://api.github.com/users/Narkfr/events{/privacy}","received_events_url":"https://api.github.com/users/Narkfr/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-24T16:09:23Z","updated_at":"2017-10-31T08:26:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0520669dc8366f5cce6afe4318d4fdceba25124","assignee":{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars3.githubusercontent.com/u/776764?v=4","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},"assignees":[{"login":"gregorylegarec","id":776764,"avatar_url":"https://avatars3.githubusercontent.com/u/776764?v=4","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false},{"login":"Narkfr","id":5773538,"avatar_url":"https://avatars2.githubusercontent.com/u/5773538?v=4","gravatar_id":"","url":"https://api.github.com/users/Narkfr","html_url":"https://github.com/Narkfr","followers_url":"https://api.github.com/users/Narkfr/followers","following_url":"https://api.github.com/users/Narkfr/following{/other_user}","gists_url":"https://api.github.com/users/Narkfr/gists{/gist_id}","starred_url":"https://api.github.com/users/Narkfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narkfr/subscriptions","organizations_url":"https://api.github.com/users/Narkfr/orgs","repos_url":"https://api.github.com/users/Narkfr/repos","events_url":"https://api.github.com/users/Narkfr/events{/privacy}","received_events_url":"https://api.github.com/users/Narkfr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cozy/cozy-collect/pulls/324/commits","review_comments_url":"https://api.github.com/repos/cozy/cozy-collect/pulls/324/comments","review_comment_url":"https://api.github.com/repos/cozy/cozy-collect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cozy/cozy-collect/issues/324/comments","statuses_url":"https://api.github.com/repos/cozy/cozy-collect/statuses/14181ac0b2dc27695ab8e033c81b78dfad0668af","head":{"label":"Narkfr:add-dataType-service","ref":"add-dataType-service","sha":"14181ac0b2dc27695ab8e033c81b78dfad0668af","user":{"login":"Narkfr","id":5773538,"avatar_url":"https://avatars2.githubusercontent.com/u/5773538?v=4","gravatar_id":"","url":"https://api.github.com/users/Narkfr","html_url":"https://github.com/Narkfr","followers_url":"https://api.github.com/users/Narkfr/followers","following_url":"https://api.github.com/users/Narkfr/following{/other_user}","gists_url":"https://api.github.com/users/Narkfr/gists{/gist_id}","starred_url":"https://api.github.com/users/Narkfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narkfr/subscriptions","organizations_url":"https://api.github.com/users/Narkfr/orgs","repos_url":"https://api.github.com/users/Narkfr/repos","events_url":"https://api.github.com/users/Narkfr/events{/privacy}","received_events_url":"https://api.github.com/users/Narkfr/received_events","type":"User","site_admin":false},"repo":{"id":104747993,"name":"cozy-collect","full_name":"Narkfr/cozy-collect","owner":{"login":"Narkfr","id":5773538,"avatar_url":"https://avatars2.githubusercontent.com/u/5773538?v=4","gravatar_id":"","url":"https://api.github.com/users/Narkfr","html_url":"https://github.com/Narkfr","followers_url":"https://api.github.com/users/Narkfr/followers","following_url":"https://api.github.com/users/Narkfr/following{/other_user}","gists_url":"https://api.github.com/users/Narkfr/gists{/gist_id}","starred_url":"https://api.github.com/users/Narkfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Narkfr/subscriptions","organizations_url":"https://api.github.com/users/Narkfr/orgs","repos_url":"https://api.github.com/users/Narkfr/repos","events_url":"https://api.github.com/users/Narkfr/events{/privacy}","received_events_url":"https://api.github.com/users/Narkfr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Narkfr/cozy-collect","description":"A cozy client application to configure and run cozy konnectors","fork":true,"url":"https://api.github.com/repos/Narkfr/cozy-collect","forks_url":"https://api.github.com/repos/Narkfr/cozy-collect/forks","keys_url":"https://api.github.com/repos/Narkfr/cozy-collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Narkfr/cozy-collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Narkfr/cozy-collect/teams","hooks_url":"https://api.github.com/repos/Narkfr/cozy-collect/hooks","issue_events_url":"https://api.github.com/repos/Narkfr/cozy-collect/issues/events{/number}","events_url":"https://api.github.com/repos/Narkfr/cozy-collect/events","assignees_url":"https://api.github.com/repos/Narkfr/cozy-collect/assignees{/user}","branches_url":"https://api.github.com/repos/Narkfr/cozy-collect/branches{/branch}","tags_url":"https://api.github.com/repos/Narkfr/cozy-collect/tags","blobs_url":"https://api.github.com/repos/Narkfr/cozy-collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Narkfr/cozy-collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Narkfr/cozy-collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/Narkfr/cozy-collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Narkfr/cozy-collect/statuses/{sha}","languages_url":"https://api.github.com/repos/Narkfr/cozy-collect/languages","stargazers_url":"https://api.github.com/repos/Narkfr/cozy-collect/stargazers","contributors_url":"https://api.github.com/repos/Narkfr/cozy-collect/contributors","subscribers_url":"https://api.github.com/repos/Narkfr/cozy-collect/subscribers","subscription_url":"https://api.github.com/repos/Narkfr/cozy-collect/subscription","commits_url":"https://api.github.com/repos/Narkfr/cozy-collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/Narkfr/cozy-collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/Narkfr/cozy-collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/Narkfr/cozy-collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/Narkfr/cozy-collect/contents/{+path}","compare_url":"https://api.github.com/repos/Narkfr/cozy-collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Narkfr/cozy-collect/merges","archive_url":"https://api.github.com/repos/Narkfr/cozy-collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Narkfr/cozy-collect/downloads","issues_url":"https://api.github.com/repos/Narkfr/cozy-collect/issues{/number}","pulls_url":"https://api.github.com/repos/Narkfr/cozy-collect/pulls{/number}","milestones_url":"https://api.github.com/repos/Narkfr/cozy-collect/milestones{/number}","notifications_url":"https://api.github.com/repos/Narkfr/cozy-collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Narkfr/cozy-collect/labels{/name}","releases_url":"https://api.github.com/repos/Narkfr/cozy-collect/releases{/id}","deployments_url":"https://api.github.com/repos/Narkfr/cozy-collect/deployments","created_at":"2017-09-25T12:37:51Z","updated_at":"2017-09-25T12:37:53Z","pushed_at":"2017-10-30T14:48:03Z","git_url":"git://github.com/Narkfr/cozy-collect.git","ssh_url":"git@github.com:Narkfr/cozy-collect.git","clone_url":"https://github.com/Narkfr/cozy-collect.git","svn_url":"https://github.com/Narkfr/cozy-collect","homepage":"","size":18115,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cozy:master","ref":"master","sha":"9b0ce8ad3cc08cffbee9ac284562ea8b636520b2","user":{"login":"cozy","id":7690525,"avatar_url":"https://avatars0.githubusercontent.com/u/7690525?v=4","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"repo":{"id":87829743,"name":"cozy-collect","full_name":"cozy/cozy-collect","owner":{"login":"cozy","id":7690525,"avatar_url":"https://avatars0.githubusercontent.com/u/7690525?v=4","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cozy/cozy-collect","description":"A cozy client application to configure and run cozy konnectors","fork":false,"url":"https://api.github.com/repos/cozy/cozy-collect","forks_url":"https://api.github.com/repos/cozy/cozy-collect/forks","keys_url":"https://api.github.com/repos/cozy/cozy-collect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cozy/cozy-collect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cozy/cozy-collect/teams","hooks_url":"https://api.github.com/repos/cozy/cozy-collect/hooks","issue_events_url":"https://api.github.com/repos/cozy/cozy-collect/issues/events{/number}","events_url":"https://api.github.com/repos/cozy/cozy-collect/events","assignees_url":"https://api.github.com/repos/cozy/cozy-collect/assignees{/user}","branches_url":"https://api.github.com/repos/cozy/cozy-collect/branches{/branch}","tags_url":"https://api.github.com/repos/cozy/cozy-collect/tags","blobs_url":"https://api.github.com/repos/cozy/cozy-collect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cozy/cozy-collect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cozy/cozy-collect/git/refs{/sha}","trees_url":"https://api.github.com/repos/cozy/cozy-collect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cozy/cozy-collect/statuses/{sha}","languages_url":"https://api.github.com/repos/cozy/cozy-collect/languages","stargazers_url":"https://api.github.com/repos/cozy/cozy-collect/stargazers","contributors_url":"https://api.github.com/repos/cozy/cozy-collect/contributors","subscribers_url":"https://api.github.com/repos/cozy/cozy-collect/subscribers","subscription_url":"https://api.github.com/repos/cozy/cozy-collect/subscription","commits_url":"https://api.github.com/repos/cozy/cozy-collect/commits{/sha}","git_commits_url":"https://api.github.com/repos/cozy/cozy-collect/git/commits{/sha}","comments_url":"https://api.github.com/repos/cozy/cozy-collect/comments{/number}","issue_comment_url":"https://api.github.com/repos/cozy/cozy-collect/issues/comments{/number}","contents_url":"https://api.github.com/repos/cozy/cozy-collect/contents/{+path}","compare_url":"https://api.github.com/repos/cozy/cozy-collect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cozy/cozy-collect/merges","archive_url":"https://api.github.com/repos/cozy/cozy-collect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cozy/cozy-collect/downloads","issues_url":"https://api.github.com/repos/cozy/cozy-collect/issues{/number}","pulls_url":"https://api.github.com/repos/cozy/cozy-collect/pulls{/number}","milestones_url":"https://api.github.com/repos/cozy/cozy-collect/milestones{/number}","notifications_url":"https://api.github.com/repos/cozy/cozy-collect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cozy/cozy-collect/labels{/name}","releases_url":"https://api.github.com/repos/cozy/cozy-collect/releases{/id}","deployments_url":"https://api.github.com/repos/cozy/cozy-collect/deployments","created_at":"2017-04-10T15:52:53Z","updated_at":"2017-09-12T13:36:54Z","pushed_at":"2017-10-31T07:17:43Z","git_url":"git://github.com/cozy/cozy-collect.git","ssh_url":"git@github.com:cozy/cozy-collect.git","clone_url":"https://github.com/cozy/cozy-collect.git","svn_url":"https://github.com/cozy/cozy-collect","homepage":"","size":30039,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":16,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-collect/pulls/324"},"html":{"href":"https://github.com/cozy/cozy-collect/pull/324"},"issue":{"href":"https://api.github.com/repos/cozy/cozy-collect/issues/324"},"comments":{"href":"https://api.github.com/repos/cozy/cozy-collect/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/cozy/cozy-collect/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/cozy/cozy-collect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cozy/cozy-collect/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/cozy/cozy-collect/statuses/14181ac0b2dc27695ab8e033c81b78dfad0668af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gregorylegarec"}}