{"action":"created","issue":{"url":"https://api.github.com/repos/PaulStanley/oscola-biblatex/issues/5","repository_url":"https://api.github.com/repos/PaulStanley/oscola-biblatex","labels_url":"https://api.github.com/repos/PaulStanley/oscola-biblatex/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/PaulStanley/oscola-biblatex/issues/5/comments","events_url":"https://api.github.com/repos/PaulStanley/oscola-biblatex/issues/5/events","html_url":"https://github.com/PaulStanley/oscola-biblatex/issues/5","id":217312959,"number":5,"title":"A few comments","user":{"login":"moewew","id":6755835,"avatar_url":"https://avatars0.githubusercontent.com/u/6755835?v=3","gravatar_id":"","url":"https://api.github.com/users/moewew","html_url":"https://github.com/moewew","followers_url":"https://api.github.com/users/moewew/followers","following_url":"https://api.github.com/users/moewew/following{/other_user}","gists_url":"https://api.github.com/users/moewew/gists{/gist_id}","starred_url":"https://api.github.com/users/moewew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moewew/subscriptions","organizations_url":"https://api.github.com/users/moewew/orgs","repos_url":"https://api.github.com/users/moewew/repos","events_url":"https://api.github.com/users/moewew/events{/privacy}","received_events_url":"https://api.github.com/users/moewew/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-27T17:08:25Z","updated_at":"2017-04-07T21:03:01Z","closed_at":null,"body":"Your `biblatex` guide sparked my interest in your other `biblatex` project, and so I thought I might leave a few nit-picking remarks here as well.\r\n\r\nThe name macro in https://github.com/PaulStanley/oscola-biblatex/blob/master/oscola.bbx#L74 uses the outdated command `\\ifpunctmark{'}` which has been superseded by `\\ifprefchar`. You also use `\\ifblank`, but the version of `name:family-given` in `biblatex.def` uses `\\ifdefvoid` (this is necessary due to changes to name handling and the type of the arguments passes to the macros). I might be mistaken, but your definition looks just like the normal definition except that you deleted `\\revsdnamepunct`. So you should get the same result if you don't redefine the macro and instead do `\\renewcommand*{\\revsdnamepunct}{}`.\r\n\r\nThe code you use starting from https://github.com/PaulStanley/oscola-biblatex/blob/master/oscola.bbx#L98 to obtain terse initials could *probably* just be replaced with the `terseinits=true` option. (I did not compare output, but in theory it should do the same.)\r\n\r\nIt might be a matter of taste, but I would not use commands in string comparisons as in https://github.com/PaulStanley/oscola-biblatex/blob/master/oscola.bbx#L213 (`\\newcommand*\\subtypesecondarylegislation{secondary}` and then `\\iffieldequals{entrysubtype}{\\subtypesecondarylegislation}`), as I explained in http://tex.stackexchange.com/a/290935/ I prefer `\\iffieldequalstr` instead of `\\iffieldequals` for fixed strings. That does not create the overhead of macros, and I don't need to think about `\\long` commands (i.e. using `\\newcommand*` so I don't get `\\long`).\r\n\r\nIs there a reason why there is a literal comma in https://github.com/PaulStanley/oscola-biblatex/blob/master/oscola.bbx#L296's `\\newcommand{\\extracitedelim}{,\\space}`?"},"comment":{"url":"https://api.github.com/repos/PaulStanley/oscola-biblatex/issues/comments/292651074","html_url":"https://github.com/PaulStanley/oscola-biblatex/issues/5#issuecomment-292651074","issue_url":"https://api.github.com/repos/PaulStanley/oscola-biblatex/issues/5","id":292651074,"user":{"login":"PaulStanley","id":2206007,"avatar_url":"https://avatars3.githubusercontent.com/u/2206007?v=3","gravatar_id":"","url":"https://api.github.com/users/PaulStanley","html_url":"https://github.com/PaulStanley","followers_url":"https://api.github.com/users/PaulStanley/followers","following_url":"https://api.github.com/users/PaulStanley/following{/other_user}","gists_url":"https://api.github.com/users/PaulStanley/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulStanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulStanley/subscriptions","organizations_url":"https://api.github.com/users/PaulStanley/orgs","repos_url":"https://api.github.com/users/PaulStanley/repos","events_url":"https://api.github.com/users/PaulStanley/events{/privacy}","received_events_url":"https://api.github.com/users/PaulStanley/received_events","type":"User","site_admin":false},"created_at":"2017-04-07T21:03:01Z","updated_at":"2017-04-07T21:03:01Z","body":"@moewew I have experimented with the initials, and found the method in my madness.\r\n\r\n`terseinits=true` is *fine* for the bibliography. But in the text, if I have a name like `Williams, John J.`, I need to print `Williams, John J` --- *not* terse, but no dot. If I just have `terseinits=true` I don't have a problem making the in-text citations full and the bibliographical ones terse, but the in-text citations acquire a dot. So what (IIRC) all this code is doing is preventing those dots being printed!"}}
{"actor":{"display_login":"PaulStanley"}}