{"action":"created","comment":{"url":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/comments/127162699","pull_request_review_id":49716567,"id":127162699,"diff_hunk":"@@ -6,9 +6,12 @@ USER=vagrant\n HOME=/home/${USER}\n \n echo 'Modifying environment'\n-chown -R ${USER}:${USER} ${HOME}\n+chown -R ${USER}:${USER} ${HOME}/go/src/github.com/kinvolk/kube-spawn/k8s\n chmod +x ${HOME}/build.sh\n-setenforce 0\n+\n+# setenforce always returns 1 when selinux is disabled.\n+# we should ignore the error value to continue to rest commands.","path":"scripts/vagrant-mod-env.sh","position":10,"original_position":10,"commit_id":"fe7253bd669a7ed30c66d023785891e0813834d8","original_commit_id":"fe7253bd669a7ed30c66d023785891e0813834d8","user":{"login":"schu","id":366468,"avatar_url":"https://avatars1.githubusercontent.com/u/366468?v=3","gravatar_id":"","url":"https://api.github.com/users/schu","html_url":"https://github.com/schu","followers_url":"https://api.github.com/users/schu/followers","following_url":"https://api.github.com/users/schu/following{/other_user}","gists_url":"https://api.github.com/users/schu/gists{/gist_id}","starred_url":"https://api.github.com/users/schu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schu/subscriptions","organizations_url":"https://api.github.com/users/schu/orgs","repos_url":"https://api.github.com/users/schu/repos","events_url":"https://api.github.com/users/schu/events{/privacy}","received_events_url":"https://api.github.com/users/schu/received_events","type":"User","site_admin":false},"body":"Nit: \"... to continue with the remaining commands\" or, simpler, just \"Ignore the error and continue\".","created_at":"2017-07-13T08:55:24Z","updated_at":"2017-07-13T08:55:45Z","html_url":"https://github.com/kinvolk/kube-spawn/pull/60#discussion_r127162699","pull_request_url":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/comments/127162699"},"html":{"href":"https://github.com/kinvolk/kube-spawn/pull/60#discussion_r127162699"},"pull_request":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/60","id":130184671,"html_url":"https://github.com/kinvolk/kube-spawn/pull/60","diff_url":"https://github.com/kinvolk/kube-spawn/pull/60.diff","patch_url":"https://github.com/kinvolk/kube-spawn/pull/60.patch","issue_url":"https://api.github.com/repos/kinvolk/kube-spawn/issues/60","number":60,"state":"open","locked":false,"title":"Vagrantfile, scripts: assign 2 CPUs and fix setup scripts","user":{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars3.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false},"body":"In Vagrantfile, assign 2 CPUs for each VM to be able to build large source trees.\r\nAlso fix minor bugs in `vagrant-mod-env.sh`: Ignore return value of `setenforce`, as it always returns 1 if selinux is disabled. Also make sure that chmod runs only for a necessary directory k8s, instead of the whole home directory.","created_at":"2017-07-12T16:39:47Z","updated_at":"2017-07-13T08:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4e2cdcc9ec174d67441d8d8a1f5cf9ae95eb857","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/60/commits","review_comments_url":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/60/comments","review_comment_url":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kinvolk/kube-spawn/issues/60/comments","statuses_url":"https://api.github.com/repos/kinvolk/kube-spawn/statuses/fe7253bd669a7ed30c66d023785891e0813834d8","head":{"label":"kinvolk:dongsu/fix-init-script","ref":"dongsu/fix-init-script","sha":"fe7253bd669a7ed30c66d023785891e0813834d8","user":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars3.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":78522032,"name":"kube-spawn","full_name":"kinvolk/kube-spawn","owner":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars3.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinvolk/kube-spawn","description":"A tool to create a multi-node Kubernetes cluster on a Linux machine using kubeadm & OS containers running on systemd-nspawn","fork":false,"url":"https://api.github.com/repos/kinvolk/kube-spawn","forks_url":"https://api.github.com/repos/kinvolk/kube-spawn/forks","keys_url":"https://api.github.com/repos/kinvolk/kube-spawn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/kube-spawn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/kube-spawn/teams","hooks_url":"https://api.github.com/repos/kinvolk/kube-spawn/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/kube-spawn/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/kube-spawn/events","assignees_url":"https://api.github.com/repos/kinvolk/kube-spawn/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/kube-spawn/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/kube-spawn/tags","blobs_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/kube-spawn/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/kube-spawn/languages","stargazers_url":"https://api.github.com/repos/kinvolk/kube-spawn/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/kube-spawn/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/kube-spawn/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/kube-spawn/subscription","commits_url":"https://api.github.com/repos/kinvolk/kube-spawn/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/kube-spawn/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/kube-spawn/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/kube-spawn/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/kube-spawn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/kube-spawn/merges","archive_url":"https://api.github.com/repos/kinvolk/kube-spawn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/kube-spawn/downloads","issues_url":"https://api.github.com/repos/kinvolk/kube-spawn/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/kube-spawn/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/kube-spawn/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/kube-spawn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/kube-spawn/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/kube-spawn/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/kube-spawn/deployments","created_at":"2017-01-10T10:16:39Z","updated_at":"2017-07-12T17:55:35Z","pushed_at":"2017-07-12T16:39:47Z","git_url":"git://github.com/kinvolk/kube-spawn.git","ssh_url":"git@github.com:kinvolk/kube-spawn.git","clone_url":"https://github.com/kinvolk/kube-spawn.git","svn_url":"https://github.com/kinvolk/kube-spawn","homepage":"","size":192,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":8,"default_branch":"master"}},"base":{"label":"kinvolk:master","ref":"master","sha":"124a45e65f1e5bac0b41b41281862d7c96a812fb","user":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars3.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":78522032,"name":"kube-spawn","full_name":"kinvolk/kube-spawn","owner":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars3.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinvolk/kube-spawn","description":"A tool to create a multi-node Kubernetes cluster on a Linux machine using kubeadm & OS containers running on systemd-nspawn","fork":false,"url":"https://api.github.com/repos/kinvolk/kube-spawn","forks_url":"https://api.github.com/repos/kinvolk/kube-spawn/forks","keys_url":"https://api.github.com/repos/kinvolk/kube-spawn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/kube-spawn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/kube-spawn/teams","hooks_url":"https://api.github.com/repos/kinvolk/kube-spawn/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/kube-spawn/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/kube-spawn/events","assignees_url":"https://api.github.com/repos/kinvolk/kube-spawn/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/kube-spawn/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/kube-spawn/tags","blobs_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/kube-spawn/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/kube-spawn/languages","stargazers_url":"https://api.github.com/repos/kinvolk/kube-spawn/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/kube-spawn/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/kube-spawn/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/kube-spawn/subscription","commits_url":"https://api.github.com/repos/kinvolk/kube-spawn/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/kube-spawn/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/kube-spawn/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/kube-spawn/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/kube-spawn/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/kube-spawn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/kube-spawn/merges","archive_url":"https://api.github.com/repos/kinvolk/kube-spawn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/kube-spawn/downloads","issues_url":"https://api.github.com/repos/kinvolk/kube-spawn/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/kube-spawn/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/kube-spawn/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/kube-spawn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/kube-spawn/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/kube-spawn/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/kube-spawn/deployments","created_at":"2017-01-10T10:16:39Z","updated_at":"2017-07-12T17:55:35Z","pushed_at":"2017-07-12T16:39:47Z","git_url":"git://github.com/kinvolk/kube-spawn.git","ssh_url":"git@github.com:kinvolk/kube-spawn.git","clone_url":"https://github.com/kinvolk/kube-spawn.git","svn_url":"https://github.com/kinvolk/kube-spawn","homepage":"","size":192,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/60"},"html":{"href":"https://github.com/kinvolk/kube-spawn/pull/60"},"issue":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/issues/60"},"comments":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/kinvolk/kube-spawn/statuses/fe7253bd669a7ed30c66d023785891e0813834d8"}}}}
{"actor":{"display_login":"schu"}}