{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/38664","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/38664/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/38664/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/38664/events","html_url":"https://github.com/saltstack/salt/pull/38664","id":199886295,"number":38664,"title":"X509 Improvements. Expose setting permissions, encrypted private keys, and combined key and cert management in one state","user":{"login":"clinta","id":3177437,"avatar_url":"https://avatars.githubusercontent.com/u/3177437?v=3","gravatar_id":"","url":"https://api.github.com/users/clinta","html_url":"https://github.com/clinta","followers_url":"https://api.github.com/users/clinta/followers","following_url":"https://api.github.com/users/clinta/following{/other_user}","gists_url":"https://api.github.com/users/clinta/gists{/gist_id}","starred_url":"https://api.github.com/users/clinta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clinta/subscriptions","organizations_url":"https://api.github.com/users/clinta/orgs","repos_url":"https://api.github.com/users/clinta/repos","events_url":"https://api.github.com/users/clinta/events{/privacy}","received_events_url":"https://api.github.com/users/clinta/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-10T17:37:52Z","updated_at":"2017-01-15T14:46:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/38664","html_url":"https://github.com/saltstack/salt/pull/38664","diff_url":"https://github.com/saltstack/salt/pull/38664.diff","patch_url":"https://github.com/saltstack/salt/pull/38664.patch"},"body":"### X509 permissions, private key encryption and unified cert/key management\r\n\r\n### What issues does this PR fix or reference?\r\n#38528 \r\n#38081 \r\n\r\n### Previous Behavior\r\nThe x509 module handled writing files on it's own, which requried users who want to set custom permissions to add an additional file.managed state to the file.\r\n\r\nPrivate keys and certificates were only exposed as two separate states, so to manage a certificate with a rotating private key a complicated series of requisites was required.\r\n\r\nThere was no functionality to generate passphrase encrypted private keys.\r\n\r\n### New Behavior\r\n\r\nThe x509 state now takes advantage of cross calling the file.managed states and pass along arguments that would be useful to that state. This allows setting `mode`, `user`, and `group` right in the x509 state.\r\n\r\nThere is a new `managed_private_key` option in the `certificate.managed` state which allows managing a private key and cert together, even in the same file if desired. Additionally there is a new `append_certs` option which allows appending intermediate certificates to a managed certificate.\r\n\r\nA new `passphrase` option is exposed for generating and managing encrypted private keys.\r\n\r\n### Tests written?\r\n\r\nNo"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/272699673","html_url":"https://github.com/saltstack/salt/pull/38664#issuecomment-272699673","issue_url":"https://api.github.com/repos/saltstack/salt/issues/38664","id":272699673,"user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"created_at":"2017-01-15T14:46:34Z","updated_at":"2017-01-15T14:46:34Z","body":"Go Go Jenkins!"}}
{"actor":{"display_login":"cachedout"}}