{"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/godot/pulls/comments/147762291","pull_request_review_id":72903800,"id":147762291,"diff_hunk":"@@ -2963,18 +2963,37 @@ void GDParser::_parse_extends(ClassNode *p_class) {\n \t}\n \n \twhile (true) {\n-\t\tif (tokenizer->get_token() != GDTokenizer::TK_IDENTIFIER) {\n \n-\t\t\t_set_error(\"Invalid 'extends' syntax, expected string constant (path) and/or identifier (parent class).\");\n-\t\t\treturn;\n-\t\t}\n+\t\tswitch (tokenizer->get_token()) {\n+\n+\t\t\tcase GDTokenizer::TK_IDENTIFIER: {\n+\n+\t\t\t\t\tStringName identifier = tokenizer->get_token_identifier();\n+\t\t\t\t\tp_class->extends_class.push_back(identifier);\n+\t\t\t\t}\n+\t\t\t\tbreak;","path":"modules/gdscript/gd_parser.cpp","position":16,"original_position":16,"commit_id":"c8e95054b381f0dcae7695ed5eb2d91a2876ce0c","original_commit_id":"c8e95054b381f0dcae7695ed5eb2d91a2876ce0c","user":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"body":"It looks like clang-format doesn't like the indentation style you used: https://travis-ci.org/godotengine/godot/jobs/294820735","created_at":"2017-10-30T16:42:48Z","updated_at":"2017-10-30T16:42:48Z","html_url":"https://github.com/godotengine/godot/pull/12507#discussion_r147762291","pull_request_url":"https://api.github.com/repos/godotengine/godot/pulls/12507","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments/147762291"},"html":{"href":"https://github.com/godotengine/godot/pull/12507#discussion_r147762291"},"pull_request":{"href":"https://api.github.com/repos/godotengine/godot/pulls/12507"}}},"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/12507","id":149503656,"html_url":"https://github.com/godotengine/godot/pull/12507","diff_url":"https://github.com/godotengine/godot/pull/12507.diff","patch_url":"https://github.com/godotengine/godot/pull/12507.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/12507","number":12507,"state":"open","locked":false,"title":"Allow to extends constant variable(master)","user":{"login":"sanikoyes","id":6880378,"avatar_url":"https://avatars0.githubusercontent.com/u/6880378?v=4","gravatar_id":"","url":"https://api.github.com/users/sanikoyes","html_url":"https://github.com/sanikoyes","followers_url":"https://api.github.com/users/sanikoyes/followers","following_url":"https://api.github.com/users/sanikoyes/following{/other_user}","gists_url":"https://api.github.com/users/sanikoyes/gists{/gist_id}","starred_url":"https://api.github.com/users/sanikoyes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanikoyes/subscriptions","organizations_url":"https://api.github.com/users/sanikoyes/orgs","repos_url":"https://api.github.com/users/sanikoyes/repos","events_url":"https://api.github.com/users/sanikoyes/events{/privacy}","received_events_url":"https://api.github.com/users/sanikoyes/received_events","type":"User","site_admin":false},"body":"this pr same to : https://github.com/godotengine/godot/pull/12506","created_at":"2017-10-30T12:00:31Z","updated_at":"2017-10-30T16:42:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b84c6fc8205d70a706cb0df30886d332c312d7a9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/4","html_url":"https://github.com/godotengine/godot/milestone/4","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/4/labels","id":1449702,"number":4,"title":"3.0","description":"","creator":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":362,"closed_issues":3265,"state":"open","created_at":"2015-12-08T11:42:08Z","updated_at":"2017-10-30T16:41:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/12507/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/12507/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/12507/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/c8e95054b381f0dcae7695ed5eb2d91a2876ce0c","head":{"label":"sanikoyes:pr-extends-enhance","ref":"pr-extends-enhance","sha":"c8e95054b381f0dcae7695ed5eb2d91a2876ce0c","user":{"login":"sanikoyes","id":6880378,"avatar_url":"https://avatars0.githubusercontent.com/u/6880378?v=4","gravatar_id":"","url":"https://api.github.com/users/sanikoyes","html_url":"https://github.com/sanikoyes","followers_url":"https://api.github.com/users/sanikoyes/followers","following_url":"https://api.github.com/users/sanikoyes/following{/other_user}","gists_url":"https://api.github.com/users/sanikoyes/gists{/gist_id}","starred_url":"https://api.github.com/users/sanikoyes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanikoyes/subscriptions","organizations_url":"https://api.github.com/users/sanikoyes/orgs","repos_url":"https://api.github.com/users/sanikoyes/repos","events_url":"https://api.github.com/users/sanikoyes/events{/privacy}","received_events_url":"https://api.github.com/users/sanikoyes/received_events","type":"User","site_admin":false},"repo":{"id":17619219,"name":"godot","full_name":"sanikoyes/godot","owner":{"login":"sanikoyes","id":6880378,"avatar_url":"https://avatars0.githubusercontent.com/u/6880378?v=4","gravatar_id":"","url":"https://api.github.com/users/sanikoyes","html_url":"https://github.com/sanikoyes","followers_url":"https://api.github.com/users/sanikoyes/followers","following_url":"https://api.github.com/users/sanikoyes/following{/other_user}","gists_url":"https://api.github.com/users/sanikoyes/gists{/gist_id}","starred_url":"https://api.github.com/users/sanikoyes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanikoyes/subscriptions","organizations_url":"https://api.github.com/users/sanikoyes/orgs","repos_url":"https://api.github.com/users/sanikoyes/repos","events_url":"https://api.github.com/users/sanikoyes/events{/privacy}","received_events_url":"https://api.github.com/users/sanikoyes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sanikoyes/godot","description":"Godot Game Engine","fork":true,"url":"https://api.github.com/repos/sanikoyes/godot","forks_url":"https://api.github.com/repos/sanikoyes/godot/forks","keys_url":"https://api.github.com/repos/sanikoyes/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanikoyes/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanikoyes/godot/teams","hooks_url":"https://api.github.com/repos/sanikoyes/godot/hooks","issue_events_url":"https://api.github.com/repos/sanikoyes/godot/issues/events{/number}","events_url":"https://api.github.com/repos/sanikoyes/godot/events","assignees_url":"https://api.github.com/repos/sanikoyes/godot/assignees{/user}","branches_url":"https://api.github.com/repos/sanikoyes/godot/branches{/branch}","tags_url":"https://api.github.com/repos/sanikoyes/godot/tags","blobs_url":"https://api.github.com/repos/sanikoyes/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanikoyes/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanikoyes/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanikoyes/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanikoyes/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/sanikoyes/godot/languages","stargazers_url":"https://api.github.com/repos/sanikoyes/godot/stargazers","contributors_url":"https://api.github.com/repos/sanikoyes/godot/contributors","subscribers_url":"https://api.github.com/repos/sanikoyes/godot/subscribers","subscription_url":"https://api.github.com/repos/sanikoyes/godot/subscription","commits_url":"https://api.github.com/repos/sanikoyes/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanikoyes/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanikoyes/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanikoyes/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanikoyes/godot/contents/{+path}","compare_url":"https://api.github.com/repos/sanikoyes/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanikoyes/godot/merges","archive_url":"https://api.github.com/repos/sanikoyes/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanikoyes/godot/downloads","issues_url":"https://api.github.com/repos/sanikoyes/godot/issues{/number}","pulls_url":"https://api.github.com/repos/sanikoyes/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/sanikoyes/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/sanikoyes/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanikoyes/godot/labels{/name}","releases_url":"https://api.github.com/repos/sanikoyes/godot/releases{/id}","deployments_url":"https://api.github.com/repos/sanikoyes/godot/deployments","created_at":"2014-03-11T05:13:41Z","updated_at":"2017-10-18T06:05:45Z","pushed_at":"2017-10-30T12:21:07Z","git_url":"git://github.com/sanikoyes/godot.git","ssh_url":"git@github.com:sanikoyes/godot.git","clone_url":"https://github.com/sanikoyes/godot.git","svn_url":"https://github.com/sanikoyes/godot","homepage":null,"size":217105,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":15,"open_issues":0,"watchers":60,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"62a3dcdc72be939c5b8a31d035bce5a576397fb4","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"name":"godot","full_name":"godotengine/godot","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2017-10-30T15:20:01Z","pushed_at":"2017-10-30T15:14:18Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":198822,"stargazers_count":11028,"watchers_count":11028,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2485,"mirror_url":null,"archived":false,"open_issues_count":2405,"forks":2485,"open_issues":2405,"watchers":11028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/12507"},"html":{"href":"https://github.com/godotengine/godot/pull/12507"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/12507"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/12507/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/12507/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/12507/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/c8e95054b381f0dcae7695ed5eb2d91a2876ce0c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"akien-mga"}}