{"action":"created","comment":{"url":"https://api.github.com/repos/lxc/lxd/pulls/comments/101408860","pull_request_review_id":22136995,"id":101408860,"diff_hunk":"@@ -571,23 +571,23 @@ func (s *storageBtrfs) ContainerCreateFromImage(container container, fingerprint\n \t// ${LXD_DIR}/images/<fingerprint>\n \timageMntPoint := getImageMountPoint(s.pool.Name, fingerprint)\n \timageStoragePoolLockID := fmt.Sprintf(\"%s/%s\", s.pool.Name, fingerprint)\n-\timageCreationInPoolLock.Lock()\n-\tif waitChannel, ok := imageCreationInPool[imageStoragePoolLockID]; ok {\n-\t\timageCreationInPoolLock.Unlock()\n+\tlxdStorageLock.Lock()\n+\tif waitChannel, ok := lxdStorageLockMap[imageStoragePoolLockID]; ok {\n+\t\tlxdStorageLock.Unlock()\n \t\tif _, ok := <-waitChannel; ok {\n \t\t\tshared.LogWarnf(\"Value transmitted over image lock semaphore?\")\n \t\t}\n \t} else {\n-\t\timageCreationInPool[imageStoragePoolLockID] = make(chan bool)\n+\t\tlxdStorageLockMap[imageStoragePoolLockID] = make(chan bool)","path":"lxd/storage_btrfs.go","position":15,"original_position":15,"commit_id":"6ffb19874dba013736107363f69acf9abac4c02d","original_commit_id":"881869ccda2da58b7509235fe1d0f63f4e3f74a7","user":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"body":"Should unlock after that","created_at":"2017-02-15T23:17:44Z","updated_at":"2017-02-15T23:17:44Z","html_url":"https://github.com/lxc/lxd/pull/2890#discussion_r101408860","pull_request_url":"https://api.github.com/repos/lxc/lxd/pulls/2890","_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments/101408860"},"html":{"href":"https://github.com/lxc/lxd/pull/2890#discussion_r101408860"},"pull_request":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2890"}}},"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/2890","id":106349560,"html_url":"https://github.com/lxc/lxd/pull/2890","diff_url":"https://github.com/lxc/lxd/pull/2890.diff","patch_url":"https://github.com/lxc/lxd/pull/2890.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/2890","number":2890,"state":"open","locked":false,"title":"storage: lock Container{U,M}ount for zfs, lvm","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>","created_at":"2017-02-15T16:40:30Z","updated_at":"2017-02-15T23:17:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bfce6d5fc5892b3917a8381666e63fc6817bfdd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/2890/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/2890/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/2890/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/6ffb19874dba013736107363f69acf9abac4c02d","head":{"label":"brauner:2017-02-15/storage_fixes","ref":"2017-02-15/storage_fixes","sha":"6ffb19874dba013736107363f69acf9abac4c02d","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"repo":{"id":67736764,"name":"lxd","full_name":"brauner/lxd","owner":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brauner/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":true,"url":"https://api.github.com/repos/brauner/lxd","forks_url":"https://api.github.com/repos/brauner/lxd/forks","keys_url":"https://api.github.com/repos/brauner/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brauner/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brauner/lxd/teams","hooks_url":"https://api.github.com/repos/brauner/lxd/hooks","issue_events_url":"https://api.github.com/repos/brauner/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/brauner/lxd/events","assignees_url":"https://api.github.com/repos/brauner/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/brauner/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/brauner/lxd/tags","blobs_url":"https://api.github.com/repos/brauner/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brauner/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brauner/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/brauner/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brauner/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/brauner/lxd/languages","stargazers_url":"https://api.github.com/repos/brauner/lxd/stargazers","contributors_url":"https://api.github.com/repos/brauner/lxd/contributors","subscribers_url":"https://api.github.com/repos/brauner/lxd/subscribers","subscription_url":"https://api.github.com/repos/brauner/lxd/subscription","commits_url":"https://api.github.com/repos/brauner/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/brauner/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/brauner/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/brauner/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/brauner/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/brauner/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brauner/lxd/merges","archive_url":"https://api.github.com/repos/brauner/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brauner/lxd/downloads","issues_url":"https://api.github.com/repos/brauner/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/brauner/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/brauner/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/brauner/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brauner/lxd/labels{/name}","releases_url":"https://api.github.com/repos/brauner/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/brauner/lxd/deployments","created_at":"2016-09-08T20:11:08Z","updated_at":"2016-09-08T20:11:10Z","pushed_at":"2017-02-15T23:12:52Z","git_url":"git://github.com/brauner/lxd.git","ssh_url":"git@github.com:brauner/lxd.git","clone_url":"https://github.com/brauner/lxd.git","svn_url":"https://github.com/brauner/lxd","homepage":"https://linuxcontainers.org/lxd","size":9271,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"3bed44e9ce5aad783bdb5f16fbb20b5f732c855a","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxd/deployments","created_at":"2014-11-04T22:40:52Z","updated_at":"2017-02-15T10:52:03Z","pushed_at":"2017-02-15T23:12:54Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org/lxd","size":9240,"stargazers_count":1251,"watchers_count":1251,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":76,"forks":277,"open_issues":76,"watchers":1251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2890"},"html":{"href":"https://github.com/lxc/lxd/pull/2890"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/2890"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/2890/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2890/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2890/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/6ffb19874dba013736107363f69acf9abac4c02d"}}}}
{"actor":{"display_login":"stgraber"}}