{"action":"created","issue":{"url":"https://api.github.com/repos/raiden-network/raiden/issues/748","repository_url":"https://api.github.com/repos/raiden-network/raiden","labels_url":"https://api.github.com/repos/raiden-network/raiden/issues/748/labels{/name}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/748/comments","events_url":"https://api.github.com/repos/raiden-network/raiden/issues/748/events","html_url":"https://github.com/raiden-network/raiden/issues/748","id":243136128,"number":748,"title":"Missing return in RestAPI connect() and leave()","user":{"login":"ulope","id":55078,"avatar_url":"https://avatars4.githubusercontent.com/u/55078?v=4","gravatar_id":"","url":"https://api.github.com/users/ulope","html_url":"https://github.com/ulope","followers_url":"https://api.github.com/users/ulope/followers","following_url":"https://api.github.com/users/ulope/following{/other_user}","gists_url":"https://api.github.com/users/ulope/gists{/gist_id}","starred_url":"https://api.github.com/users/ulope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulope/subscriptions","organizations_url":"https://api.github.com/users/ulope/orgs","repos_url":"https://api.github.com/users/ulope/repos","events_url":"https://api.github.com/users/ulope/events{/privacy}","received_events_url":"https://api.github.com/users/ulope/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-07-14T23:37:01Z","updated_at":"2017-07-17T10:05:30Z","closed_at":null,"body":"## Problem Definition\r\n\r\nBoth `RestAPI.connect()` and `RestAPI.leave()` are missing `return` statements to return a HTTP response.\r\n\r\n## Solution\r\n\r\nReturn appropriate values from both methods.\r\n\r\n## Tasklist\r\n\r\n- [ ] Return Rest response from `RestAPI.connect()`\r\n- [ ] Return Rest response from `RestAPI.leave()`\r\n"},"comment":{"url":"https://api.github.com/repos/raiden-network/raiden/issues/comments/315714752","html_url":"https://github.com/raiden-network/raiden/issues/748#issuecomment-315714752","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/748","id":315714752,"user":{"login":"ulope","id":55078,"avatar_url":"https://avatars4.githubusercontent.com/u/55078?v=4","gravatar_id":"","url":"https://api.github.com/users/ulope","html_url":"https://github.com/ulope","followers_url":"https://api.github.com/users/ulope/followers","following_url":"https://api.github.com/users/ulope/following{/other_user}","gists_url":"https://api.github.com/users/ulope/gists{/gist_id}","starred_url":"https://api.github.com/users/ulope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulope/subscriptions","organizations_url":"https://api.github.com/users/ulope/orgs","repos_url":"https://api.github.com/users/ulope/repos","events_url":"https://api.github.com/users/ulope/events{/privacy}","received_events_url":"https://api.github.com/users/ulope/received_events","type":"User","site_admin":false},"created_at":"2017-07-17T10:05:30Z","updated_at":"2017-07-17T10:05:30Z","body":"@LefterisJP Right it does return code 200 but also the string `null`. Which doesn't make much sense IMO. I'd argue those methods should return `204 No Content` and no response body."}}
{"actor":{"display_login":"ulope"}}