{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls/5","id":149947711,"html_url":"https://github.com/voxpupuli/puppet-webhook/pull/5","diff_url":"https://github.com/voxpupuli/puppet-webhook/pull/5.diff","patch_url":"https://github.com/voxpupuli/puppet-webhook/pull/5.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/issues/5","number":5,"state":"closed","locked":false,"title":"Get rack/parser working","user":{"login":"dhollinger","id":2914211,"avatar_url":"https://avatars1.githubusercontent.com/u/2914211?v=4","gravatar_id":"","url":"https://api.github.com/users/dhollinger","html_url":"https://github.com/dhollinger","followers_url":"https://api.github.com/users/dhollinger/followers","following_url":"https://api.github.com/users/dhollinger/following{/other_user}","gists_url":"https://api.github.com/users/dhollinger/gists{/gist_id}","starred_url":"https://api.github.com/users/dhollinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhollinger/subscriptions","organizations_url":"https://api.github.com/users/dhollinger/orgs","repos_url":"https://api.github.com/users/dhollinger/repos","events_url":"https://api.github.com/users/dhollinger/events{/privacy}","received_events_url":"https://api.github.com/users/dhollinger/received_events","type":"User","site_admin":false},"body":"Got the Rack::Parser code and custom parser working. Moved the branch\r\nname parsing into its own method that is call from the call method.\r\nAdded a parse_deleted? method as well. The Sinatra params will now\r\ncontain params called branch(String) and deleted(Boolean). Code in the\r\npayload POST route has been updated to use these params instead of\r\nrunning the parsing logic itself.\r\n\r\nI also created a new directory call \"parsers\" under \"lib\" and moved\r\nwebhook_json_parser.rb there. The class's namespace has been updated to\r\nSinatra::Parsers::WebhookJsonParser. All calls into that file/class have\r\nbeen updated as well.\r\n\r\nAll \"puts\" in the code have been removed as they were there for Dev\r\ntroubleshooting purposes.\r\n\r\nUpdated .gitignore to ignore the .log files in the logs directory,\r\nbut also added a .keep file inside the logs directory so users/devs\r\ndon't have to create it themselves.\r\n\r\nGemfile.lock was updated after a bundle install and bin/puppet_webhook\r\nhad its permissions changed to 755.\r\n\r\nAll other work is related to the JSON parsing with Rack::Parser","created_at":"2017-11-01T02:15:38Z","updated_at":"2017-11-01T11:33:27Z","closed_at":"2017-11-01T11:33:27Z","merged_at":"2017-11-01T11:33:27Z","merge_commit_sha":"c16ad2d667a19b7265a9e2cb2c421eb68d885909","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexjfisher","id":146471,"avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},{"login":"bastelfreak","id":341866,"avatar_url":"https://avatars0.githubusercontent.com/u/341866?v=4","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},{"login":"binford2k","id":1392917,"avatar_url":"https://avatars0.githubusercontent.com/u/1392917?v=4","gravatar_id":"","url":"https://api.github.com/users/binford2k","html_url":"https://github.com/binford2k","followers_url":"https://api.github.com/users/binford2k/followers","following_url":"https://api.github.com/users/binford2k/following{/other_user}","gists_url":"https://api.github.com/users/binford2k/gists{/gist_id}","starred_url":"https://api.github.com/users/binford2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binford2k/subscriptions","organizations_url":"https://api.github.com/users/binford2k/orgs","repos_url":"https://api.github.com/users/binford2k/repos","events_url":"https://api.github.com/users/binford2k/events{/privacy}","received_events_url":"https://api.github.com/users/binford2k/received_events","type":"User","site_admin":false},{"login":"rnelson0","id":1898351,"avatar_url":"https://avatars3.githubusercontent.com/u/1898351?v=4","gravatar_id":"","url":"https://api.github.com/users/rnelson0","html_url":"https://github.com/rnelson0","followers_url":"https://api.github.com/users/rnelson0/followers","following_url":"https://api.github.com/users/rnelson0/following{/other_user}","gists_url":"https://api.github.com/users/rnelson0/gists{/gist_id}","starred_url":"https://api.github.com/users/rnelson0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnelson0/subscriptions","organizations_url":"https://api.github.com/users/rnelson0/orgs","repos_url":"https://api.github.com/users/rnelson0/repos","events_url":"https://api.github.com/users/rnelson0/events{/privacy}","received_events_url":"https://api.github.com/users/rnelson0/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls/5/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls/5/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/issues/5/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/statuses/63a06ed2537a9e204761025cefe21dfd6c607165","head":{"label":"dhollinger:json_parsing","ref":"json_parsing","sha":"63a06ed2537a9e204761025cefe21dfd6c607165","user":{"login":"dhollinger","id":2914211,"avatar_url":"https://avatars1.githubusercontent.com/u/2914211?v=4","gravatar_id":"","url":"https://api.github.com/users/dhollinger","html_url":"https://github.com/dhollinger","followers_url":"https://api.github.com/users/dhollinger/followers","following_url":"https://api.github.com/users/dhollinger/following{/other_user}","gists_url":"https://api.github.com/users/dhollinger/gists{/gist_id}","starred_url":"https://api.github.com/users/dhollinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhollinger/subscriptions","organizations_url":"https://api.github.com/users/dhollinger/orgs","repos_url":"https://api.github.com/users/dhollinger/repos","events_url":"https://api.github.com/users/dhollinger/events{/privacy}","received_events_url":"https://api.github.com/users/dhollinger/received_events","type":"User","site_admin":false},"repo":{"id":109018225,"name":"puppet-webhook","full_name":"dhollinger/puppet-webhook","owner":{"login":"dhollinger","id":2914211,"avatar_url":"https://avatars1.githubusercontent.com/u/2914211?v=4","gravatar_id":"","url":"https://api.github.com/users/dhollinger","html_url":"https://github.com/dhollinger","followers_url":"https://api.github.com/users/dhollinger/followers","following_url":"https://api.github.com/users/dhollinger/following{/other_user}","gists_url":"https://api.github.com/users/dhollinger/gists{/gist_id}","starred_url":"https://api.github.com/users/dhollinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhollinger/subscriptions","organizations_url":"https://api.github.com/users/dhollinger/orgs","repos_url":"https://api.github.com/users/dhollinger/repos","events_url":"https://api.github.com/users/dhollinger/events{/privacy}","received_events_url":"https://api.github.com/users/dhollinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhollinger/puppet-webhook","description":"Sinatra-based application that triggers puppet-related commands from VCS Webhook calss","fork":true,"url":"https://api.github.com/repos/dhollinger/puppet-webhook","forks_url":"https://api.github.com/repos/dhollinger/puppet-webhook/forks","keys_url":"https://api.github.com/repos/dhollinger/puppet-webhook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhollinger/puppet-webhook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhollinger/puppet-webhook/teams","hooks_url":"https://api.github.com/repos/dhollinger/puppet-webhook/hooks","issue_events_url":"https://api.github.com/repos/dhollinger/puppet-webhook/issues/events{/number}","events_url":"https://api.github.com/repos/dhollinger/puppet-webhook/events","assignees_url":"https://api.github.com/repos/dhollinger/puppet-webhook/assignees{/user}","branches_url":"https://api.github.com/repos/dhollinger/puppet-webhook/branches{/branch}","tags_url":"https://api.github.com/repos/dhollinger/puppet-webhook/tags","blobs_url":"https://api.github.com/repos/dhollinger/puppet-webhook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhollinger/puppet-webhook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhollinger/puppet-webhook/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhollinger/puppet-webhook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhollinger/puppet-webhook/statuses/{sha}","languages_url":"https://api.github.com/repos/dhollinger/puppet-webhook/languages","stargazers_url":"https://api.github.com/repos/dhollinger/puppet-webhook/stargazers","contributors_url":"https://api.github.com/repos/dhollinger/puppet-webhook/contributors","subscribers_url":"https://api.github.com/repos/dhollinger/puppet-webhook/subscribers","subscription_url":"https://api.github.com/repos/dhollinger/puppet-webhook/subscription","commits_url":"https://api.github.com/repos/dhollinger/puppet-webhook/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhollinger/puppet-webhook/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhollinger/puppet-webhook/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhollinger/puppet-webhook/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhollinger/puppet-webhook/contents/{+path}","compare_url":"https://api.github.com/repos/dhollinger/puppet-webhook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhollinger/puppet-webhook/merges","archive_url":"https://api.github.com/repos/dhollinger/puppet-webhook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhollinger/puppet-webhook/downloads","issues_url":"https://api.github.com/repos/dhollinger/puppet-webhook/issues{/number}","pulls_url":"https://api.github.com/repos/dhollinger/puppet-webhook/pulls{/number}","milestones_url":"https://api.github.com/repos/dhollinger/puppet-webhook/milestones{/number}","notifications_url":"https://api.github.com/repos/dhollinger/puppet-webhook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhollinger/puppet-webhook/labels{/name}","releases_url":"https://api.github.com/repos/dhollinger/puppet-webhook/releases{/id}","deployments_url":"https://api.github.com/repos/dhollinger/puppet-webhook/deployments","created_at":"2017-10-31T15:50:23Z","updated_at":"2017-10-31T15:50:25Z","pushed_at":"2017-11-01T11:31:59Z","git_url":"git://github.com/dhollinger/puppet-webhook.git","ssh_url":"git@github.com:dhollinger/puppet-webhook.git","clone_url":"https://github.com/dhollinger/puppet-webhook.git","svn_url":"https://github.com/dhollinger/puppet-webhook","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"94fd5bbba0be6bf85be240e4dbaa77b0c59ef8f9","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":108903620,"name":"puppet-webhook","full_name":"voxpupuli/puppet-webhook","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-webhook","description":"Sinatra-based application that triggers puppet-related commands from VCS Webhook calss","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-webhook","forks_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-webhook/deployments","created_at":"2017-10-30T20:16:39Z","updated_at":"2017-10-31T16:53:30Z","pushed_at":"2017-11-01T11:33:27Z","git_url":"git://github.com/voxpupuli/puppet-webhook.git","ssh_url":"git@github.com:voxpupuli/puppet-webhook.git","clone_url":"https://github.com/voxpupuli/puppet-webhook.git","svn_url":"https://github.com/voxpupuli/puppet-webhook","homepage":null,"size":21,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls/5"},"html":{"href":"https://github.com/voxpupuli/puppet-webhook/pull/5"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-webhook/issues/5"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-webhook/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-webhook/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-webhook/statuses/63a06ed2537a9e204761025cefe21dfd6c607165"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alexjfisher","id":146471,"avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"comments":0,"review_comments":10,"maintainer_can_modify":false,"commits":1,"additions":104,"deletions":48,"changed_files":9}}
{"actor":{"display_login":"alexjfisher"}}