{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/137062239","pull_request_review_id":60681857,"id":137062239,"diff_hunk":"@@ -1,5 +1,8 @@\n { stdenv, fetchurl, writeScript, pkgconfig, cmake, qtbase, qttools\n-, seafile-shared, ccnet, makeWrapper }:\n+, seafile-shared, ccnet, makeWrapper\n+, withShibboleth ? false, qtwebengine }:","path":"pkgs/applications/networking/seafile-client/default.nix","position":4,"original_position":4,"commit_id":"132f4aad4155a60e907629a196128a0feafd3cfa","original_commit_id":"132f4aad4155a60e907629a196128a0feafd3cfa","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"You can default to `true`, if this feature does not introduce a regression.","created_at":"2017-09-05T17:30:37Z","updated_at":"2017-09-05T17:30:37Z","html_url":"https://github.com/NixOS/nixpkgs/pull/29025#discussion_r137062239","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29025","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/137062239"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/29025#discussion_r137062239"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29025"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29025","id":139364555,"html_url":"https://github.com/NixOS/nixpkgs/pull/29025","diff_url":"https://github.com/NixOS/nixpkgs/pull/29025.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/29025.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/29025","number":29025,"state":"open","locked":false,"title":"seafile-client: add optional Shibboleth support","user":{"login":"dotlambda","id":6806011,"avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nThis is used by some universities.\r\n\r\n###### Things done\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\ncc @Calrama \r\n","created_at":"2017-09-05T16:15:20Z","updated_at":"2017-09-05T17:30:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7095b28d5b9ebb997d7e484d561a91613d176514","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29025/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29025/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/29025/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/132f4aad4155a60e907629a196128a0feafd3cfa","head":{"label":"dotlambda:seafile-client","ref":"seafile-client","sha":"132f4aad4155a60e907629a196128a0feafd3cfa","user":{"login":"dotlambda","id":6806011,"avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"repo":{"id":95651842,"name":"nixpkgs","full_name":"dotlambda/nixpkgs","owner":{"login":"dotlambda","id":6806011,"avatar_url":"https://avatars2.githubusercontent.com/u/6806011?v=4","gravatar_id":"","url":"https://api.github.com/users/dotlambda","html_url":"https://github.com/dotlambda","followers_url":"https://api.github.com/users/dotlambda/followers","following_url":"https://api.github.com/users/dotlambda/following{/other_user}","gists_url":"https://api.github.com/users/dotlambda/gists{/gist_id}","starred_url":"https://api.github.com/users/dotlambda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotlambda/subscriptions","organizations_url":"https://api.github.com/users/dotlambda/orgs","repos_url":"https://api.github.com/users/dotlambda/repos","events_url":"https://api.github.com/users/dotlambda/events{/privacy}","received_events_url":"https://api.github.com/users/dotlambda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dotlambda/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dotlambda/nixpkgs","forks_url":"https://api.github.com/repos/dotlambda/nixpkgs/forks","keys_url":"https://api.github.com/repos/dotlambda/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotlambda/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotlambda/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dotlambda/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dotlambda/nixpkgs/events","assignees_url":"https://api.github.com/repos/dotlambda/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dotlambda/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dotlambda/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotlambda/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotlambda/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dotlambda/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dotlambda/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dotlambda/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dotlambda/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dotlambda/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotlambda/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotlambda/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotlambda/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dotlambda/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotlambda/nixpkgs/merges","archive_url":"https://api.github.com/repos/dotlambda/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotlambda/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dotlambda/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dotlambda/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotlambda/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotlambda/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotlambda/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dotlambda/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dotlambda/nixpkgs/deployments","created_at":"2017-06-28T09:21:37Z","updated_at":"2017-06-28T09:22:05Z","pushed_at":"2017-09-05T16:13:08Z","git_url":"git://github.com/dotlambda/nixpkgs.git","ssh_url":"git@github.com:dotlambda/nixpkgs.git","clone_url":"https://github.com/dotlambda/nixpkgs.git","svn_url":"https://github.com/dotlambda/nixpkgs","homepage":null,"size":559909,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"59bed53f3c8e570157f28a35807bb665390e0a83","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-09-05T15:54:57Z","pushed_at":"2017-09-05T17:22:16Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":565555,"stargazers_count":1850,"watchers_count":1850,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2215,"mirror_url":null,"open_issues_count":2264,"forks":2215,"open_issues":2264,"watchers":1850,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29025"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/29025"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/29025"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/29025/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29025/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29025/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/132f4aad4155a60e907629a196128a0feafd3cfa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mic92"}}