{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments/112390976","pull_request_review_id":33699835,"id":112390976,"diff_hunk":"@@ -0,0 +1,58 @@\n+rules:\n+  ## Job Manager ##\n+  # Example: org.apache.flink.metrics<key0=127.0.0.1, key1=jobmanager, name=taskSlotsTotal><>Value\n+  - pattern: org.apache.flink.metrics<key0=(.*), key1=jobmanager, name=([a-z].*)><>Value\n+    name: flink_jobmanager_$2\n+    labels:\n+      ip: $1\n+\n+  # Example: org.apache.flink.metrics<key0=127.0.0.1, key1=jobmanager, key2=My_Job, name=lastCheckpointDuration><>Value\n+  - pattern: org.apache.flink.metrics<key0=(.*), key1=jobmanager, key2=(.*), name=([a-z].*)><>Value\n+    name: flink_jobmanager_$3\n+    labels:\n+      ip: $1\n+      job: $2\n+\n+  ## Task Manager ##\n+  # Example: org.apache.flink.metrics<key0=debian-8, key1=taskmanager, key2=407401ecfef1f050d3dcc83af9cbfb74, key3=My_Job, key4=Map, key6=1, name=numRecordsIn><>Count\n+  - pattern: org.apache.flink.metrics<key0=(.*), key1=taskmanager, key2=(.*), key3=(.*), key4=(.*), key5=([0-9]*), name=([a-z].*)><>Count\n+    name: flink_taskmanager_$6","path":"example_configs/flink.yml","position":19,"original_position":19,"commit_id":"e33fe16a38d70e4d43ee73ae033c8a12c166ef35","original_commit_id":"e33fe16a38d70e4d43ee73ae033c8a12c166ef35","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars3.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"these are counters, so should be suffixed with _total","created_at":"2017-04-20T08:11:58Z","updated_at":"2017-04-20T08:13:29Z","html_url":"https://github.com/prometheus/jmx_exporter/pull/135#discussion_r112390976","pull_request_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments/112390976"},"html":{"href":"https://github.com/prometheus/jmx_exporter/pull/135#discussion_r112390976"},"pull_request":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/135","id":116663399,"html_url":"https://github.com/prometheus/jmx_exporter/pull/135","diff_url":"https://github.com/prometheus/jmx_exporter/pull/135.diff","patch_url":"https://github.com/prometheus/jmx_exporter/pull/135.patch","issue_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/135","number":135,"state":"open","locked":false,"title":"Add Apache flink example.","user":{"login":"mindprince","id":695290,"avatar_url":"https://avatars1.githubusercontent.com/u/695290?v=3","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},"body":"We have this config running in production. We use Flink 1.1.4","created_at":"2017-04-19T23:35:13Z","updated_at":"2017-04-20T08:13:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be2a981d90dc2ad81c5708f9f3cb7b89a18c7018","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/135/commits","review_comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/135/comments","review_comment_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/135/comments","statuses_url":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/e33fe16a38d70e4d43ee73ae033c8a12c166ef35","head":{"label":"mindprince:flink-example","ref":"flink-example","sha":"e33fe16a38d70e4d43ee73ae033c8a12c166ef35","user":{"login":"mindprince","id":695290,"avatar_url":"https://avatars1.githubusercontent.com/u/695290?v=3","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},"repo":{"id":66129155,"name":"jmx_exporter","full_name":"mindprince/jmx_exporter","owner":{"login":"mindprince","id":695290,"avatar_url":"https://avatars1.githubusercontent.com/u/695290?v=3","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mindprince/jmx_exporter","description":"A process for exposing JMX Beans via HTTP for Prometheus consumption","fork":true,"url":"https://api.github.com/repos/mindprince/jmx_exporter","forks_url":"https://api.github.com/repos/mindprince/jmx_exporter/forks","keys_url":"https://api.github.com/repos/mindprince/jmx_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mindprince/jmx_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mindprince/jmx_exporter/teams","hooks_url":"https://api.github.com/repos/mindprince/jmx_exporter/hooks","issue_events_url":"https://api.github.com/repos/mindprince/jmx_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/mindprince/jmx_exporter/events","assignees_url":"https://api.github.com/repos/mindprince/jmx_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/mindprince/jmx_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/mindprince/jmx_exporter/tags","blobs_url":"https://api.github.com/repos/mindprince/jmx_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mindprince/jmx_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mindprince/jmx_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/mindprince/jmx_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mindprince/jmx_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/mindprince/jmx_exporter/languages","stargazers_url":"https://api.github.com/repos/mindprince/jmx_exporter/stargazers","contributors_url":"https://api.github.com/repos/mindprince/jmx_exporter/contributors","subscribers_url":"https://api.github.com/repos/mindprince/jmx_exporter/subscribers","subscription_url":"https://api.github.com/repos/mindprince/jmx_exporter/subscription","commits_url":"https://api.github.com/repos/mindprince/jmx_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/mindprince/jmx_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/mindprince/jmx_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/mindprince/jmx_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/mindprince/jmx_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/mindprince/jmx_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mindprince/jmx_exporter/merges","archive_url":"https://api.github.com/repos/mindprince/jmx_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mindprince/jmx_exporter/downloads","issues_url":"https://api.github.com/repos/mindprince/jmx_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/mindprince/jmx_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/mindprince/jmx_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/mindprince/jmx_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mindprince/jmx_exporter/labels{/name}","releases_url":"https://api.github.com/repos/mindprince/jmx_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/mindprince/jmx_exporter/deployments","created_at":"2016-08-20T04:58:19Z","updated_at":"2016-08-20T04:58:20Z","pushed_at":"2017-04-19T23:34:57Z","git_url":"git://github.com/mindprince/jmx_exporter.git","ssh_url":"git@github.com:mindprince/jmx_exporter.git","clone_url":"https://github.com/mindprince/jmx_exporter.git","svn_url":"https://github.com/mindprince/jmx_exporter","homepage":"","size":949,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"da4966875122fa9804a41b4ba0174fc8cc399a3c","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars0.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":17170044,"name":"jmx_exporter","full_name":"prometheus/jmx_exporter","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars0.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/jmx_exporter","description":"A process for exposing JMX Beans via HTTP for Prometheus consumption","fork":false,"url":"https://api.github.com/repos/prometheus/jmx_exporter","forks_url":"https://api.github.com/repos/prometheus/jmx_exporter/forks","keys_url":"https://api.github.com/repos/prometheus/jmx_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/jmx_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/jmx_exporter/teams","hooks_url":"https://api.github.com/repos/prometheus/jmx_exporter/hooks","issue_events_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/jmx_exporter/events","assignees_url":"https://api.github.com/repos/prometheus/jmx_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/jmx_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/jmx_exporter/tags","blobs_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/jmx_exporter/languages","stargazers_url":"https://api.github.com/repos/prometheus/jmx_exporter/stargazers","contributors_url":"https://api.github.com/repos/prometheus/jmx_exporter/contributors","subscribers_url":"https://api.github.com/repos/prometheus/jmx_exporter/subscribers","subscription_url":"https://api.github.com/repos/prometheus/jmx_exporter/subscription","commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/jmx_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/jmx_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/jmx_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/jmx_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/jmx_exporter/merges","archive_url":"https://api.github.com/repos/prometheus/jmx_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/jmx_exporter/downloads","issues_url":"https://api.github.com/repos/prometheus/jmx_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/jmx_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/jmx_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/jmx_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/jmx_exporter/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/jmx_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/jmx_exporter/deployments","created_at":"2014-02-25T10:55:39Z","updated_at":"2017-04-20T02:05:38Z","pushed_at":"2017-04-19T23:35:13Z","git_url":"git://github.com/prometheus/jmx_exporter.git","ssh_url":"git@github.com:prometheus/jmx_exporter.git","clone_url":"https://github.com/prometheus/jmx_exporter.git","svn_url":"https://github.com/prometheus/jmx_exporter","homepage":"","size":948,"stargazers_count":154,"watchers_count":154,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":15,"forks":112,"open_issues":15,"watchers":154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/135"},"html":{"href":"https://github.com/prometheus/jmx_exporter/pull/135"},"issue":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/issues/135"},"comments":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/jmx_exporter/statuses/e33fe16a38d70e4d43ee73ae033c8a12c166ef35"}}}}
{"actor":{"display_login":"brian-brazil"}}