{"action":"created","comment":{"url":"https://api.github.com/repos/OData/odata.net/pulls/comments/145852397","pull_request_review_id":70715177,"id":145852397,"diff_hunk":"@@ -802,55 +643,139 @@ private void VerifyCallAllowed(bool synchronousCall)\n         }\r\n \r\n         /// <summary>\r\n-        /// Catch any exception thrown by the action passed in; in the exception case move the writer into\r\n-        /// state ExceptionThrown and then rethrow the exception.\r\n+        /// Verifies that calling CreateOperationRequestMessage is valid.\r\n         /// </summary>\r\n-        /// <param name=\"action\">The action to execute.</param>\r\n-        private void InterceptException(Action action)\r\n+        /// <param name=\"synchronousCall\">true if the call is to be synchronous; false otherwise.</param>\r\n+        /// <param name=\"method\">The Http method to be used for this request operation.</param>\r\n+        /// <param name=\"uri\">The Uri to be used for this request operation.</param>\r\n+        /// <param name=\"contentId\">The Content-ID value to write in ChangeSet head.</param>\r\n+        private void VerifyCanCreateOperationRequestMessage(bool synchronousCall, string method, Uri uri,\r\n+            string contentId)\r\n         {\r\n-            try\r\n+            // Common verification.\r\n+            this.ValidateWriterReady();\r\n+            this.VerifyCallAllowed(synchronousCall);\r\n+\r\n+            if (this.outputContext.WritingResponse)\r\n             {\r\n-                action();\r\n+                this.ThrowODataException(Strings.ODataBatchWriter_CannotCreateRequestOperationWhenWritingResponse);\r\n             }\r\n-            catch\r\n+\r\n+            ExceptionUtils.CheckArgumentStringNotNullOrEmpty(method, \"method\");\r\n+\r\n+            ExceptionUtils.CheckArgumentNotNull(uri, \"uri\");\r","path":"src/Microsoft.OData.Core/ODataBatchWriter.cs","position":862,"original_position":862,"commit_id":"15a2fb14ab77198e8bc79fb40361f58c70896a9c","original_commit_id":"15a2fb14ab77198e8bc79fb40361f58c70896a9c","user":{"login":"mikepizzo","id":8660830,"avatar_url":"https://avatars2.githubusercontent.com/u/8660830?v=4","gravatar_id":"","url":"https://api.github.com/users/mikepizzo","html_url":"https://github.com/mikepizzo","followers_url":"https://api.github.com/users/mikepizzo/followers","following_url":"https://api.github.com/users/mikepizzo/following{/other_user}","gists_url":"https://api.github.com/users/mikepizzo/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepizzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepizzo/subscriptions","organizations_url":"https://api.github.com/users/mikepizzo/orgs","repos_url":"https://api.github.com/users/mikepizzo/repos","events_url":"https://api.github.com/users/mikepizzo/events{/privacy}","received_events_url":"https://api.github.com/users/mikepizzo/received_events","type":"User","site_admin":false},"body":"Not a big deal, but these normally go first in the method.","created_at":"2017-10-19T23:58:07Z","updated_at":"2017-10-19T23:58:07Z","html_url":"https://github.com/OData/odata.net/pull/960#discussion_r145852397","pull_request_url":"https://api.github.com/repos/OData/odata.net/pulls/960","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OData/odata.net/pulls/comments/145852397"},"html":{"href":"https://github.com/OData/odata.net/pull/960#discussion_r145852397"},"pull_request":{"href":"https://api.github.com/repos/OData/odata.net/pulls/960"}}},"pull_request":{"url":"https://api.github.com/repos/OData/odata.net/pulls/960","id":142464234,"html_url":"https://github.com/OData/odata.net/pull/960","diff_url":"https://github.com/OData/odata.net/pull/960.diff","patch_url":"https://github.com/OData/odata.net/pull/960.patch","issue_url":"https://api.github.com/repos/OData/odata.net/issues/960","number":960,"state":"open","locked":false,"title":"porting to master branch: multipart/mixed refactoring","user":{"login":"biaol-odata","id":24885233,"avatar_url":"https://avatars2.githubusercontent.com/u/24885233?v=4","gravatar_id":"","url":"https://api.github.com/users/biaol-odata","html_url":"https://github.com/biaol-odata","followers_url":"https://api.github.com/users/biaol-odata/followers","following_url":"https://api.github.com/users/biaol-odata/following{/other_user}","gists_url":"https://api.github.com/users/biaol-odata/gists{/gist_id}","starred_url":"https://api.github.com/users/biaol-odata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biaol-odata/subscriptions","organizations_url":"https://api.github.com/users/biaol-odata/orgs","repos_url":"https://api.github.com/users/biaol-odata/repos","events_url":"https://api.github.com/users/biaol-odata/events{/privacy}","received_events_url":"https://api.github.com/users/biaol-odata/received_events","type":"User","site_admin":false},"body":"<!-- markdownlint-disable MD002 MD041 -->\r\n\r\n### Issues\r\n\r\n*This pull request is for porting the JsonBatch feature work from the maintenance-6.x branch. As the first step, it includes the refactoring of Multipart/Mixed reader & write into base + derived classes. The base class ODataBatchReader and ODataBatchWriter will be the the base class for JsonBatch format specific reader & writer as well.*\r\n\r\n### Description\r\n\r\n*Refactoring of Multipart/Mixed reader & writer with tests.*\r\n\r\n### Checklist (Uncheck if it is not completed)\r\n\r\n- [ x ] Test cases added\r\n- [ x ] Build and test with one-click build and test script passed\r\n\r\n### Additional work necessary\r\n\r\n*If documentation update is needed, please add \"Docs Needed\" label to the issue and provide details about the required document change in the issue.*\r\n","created_at":"2017-09-21T22:58:01Z","updated_at":"2017-10-19T23:58:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7516c66845cdc4e83577e93263feb225b0649743","assignee":null,"assignees":[],"requested_reviewers":[{"login":"xuzhg","id":9426627,"avatar_url":"https://avatars0.githubusercontent.com/u/9426627?v=4","gravatar_id":"","url":"https://api.github.com/users/xuzhg","html_url":"https://github.com/xuzhg","followers_url":"https://api.github.com/users/xuzhg/followers","following_url":"https://api.github.com/users/xuzhg/following{/other_user}","gists_url":"https://api.github.com/users/xuzhg/gists{/gist_id}","starred_url":"https://api.github.com/users/xuzhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuzhg/subscriptions","organizations_url":"https://api.github.com/users/xuzhg/orgs","repos_url":"https://api.github.com/users/xuzhg/repos","events_url":"https://api.github.com/users/xuzhg/events{/privacy}","received_events_url":"https://api.github.com/users/xuzhg/received_events","type":"User","site_admin":false},{"login":"AlanWong-MS","id":22382722,"avatar_url":"https://avatars1.githubusercontent.com/u/22382722?v=4","gravatar_id":"","url":"https://api.github.com/users/AlanWong-MS","html_url":"https://github.com/AlanWong-MS","followers_url":"https://api.github.com/users/AlanWong-MS/followers","following_url":"https://api.github.com/users/AlanWong-MS/following{/other_user}","gists_url":"https://api.github.com/users/AlanWong-MS/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanWong-MS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanWong-MS/subscriptions","organizations_url":"https://api.github.com/users/AlanWong-MS/orgs","repos_url":"https://api.github.com/users/AlanWong-MS/repos","events_url":"https://api.github.com/users/AlanWong-MS/events{/privacy}","received_events_url":"https://api.github.com/users/AlanWong-MS/received_events","type":"User","site_admin":false},{"login":"manivannanse","id":24596673,"avatar_url":"https://avatars3.githubusercontent.com/u/24596673?v=4","gravatar_id":"","url":"https://api.github.com/users/manivannanse","html_url":"https://github.com/manivannanse","followers_url":"https://api.github.com/users/manivannanse/followers","following_url":"https://api.github.com/users/manivannanse/following{/other_user}","gists_url":"https://api.github.com/users/manivannanse/gists{/gist_id}","starred_url":"https://api.github.com/users/manivannanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manivannanse/subscriptions","organizations_url":"https://api.github.com/users/manivannanse/orgs","repos_url":"https://api.github.com/users/manivannanse/repos","events_url":"https://api.github.com/users/manivannanse/events{/privacy}","received_events_url":"https://api.github.com/users/manivannanse/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OData/odata.net/pulls/960/commits","review_comments_url":"https://api.github.com/repos/OData/odata.net/pulls/960/comments","review_comment_url":"https://api.github.com/repos/OData/odata.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OData/odata.net/issues/960/comments","statuses_url":"https://api.github.com/repos/OData/odata.net/statuses/15a2fb14ab77198e8bc79fb40361f58c70896a9c","head":{"label":"biaol-odata:master_JsonFormatBatch-A","ref":"master_JsonFormatBatch-A","sha":"15a2fb14ab77198e8bc79fb40361f58c70896a9c","user":{"login":"biaol-odata","id":24885233,"avatar_url":"https://avatars2.githubusercontent.com/u/24885233?v=4","gravatar_id":"","url":"https://api.github.com/users/biaol-odata","html_url":"https://github.com/biaol-odata","followers_url":"https://api.github.com/users/biaol-odata/followers","following_url":"https://api.github.com/users/biaol-odata/following{/other_user}","gists_url":"https://api.github.com/users/biaol-odata/gists{/gist_id}","starred_url":"https://api.github.com/users/biaol-odata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biaol-odata/subscriptions","organizations_url":"https://api.github.com/users/biaol-odata/orgs","repos_url":"https://api.github.com/users/biaol-odata/repos","events_url":"https://api.github.com/users/biaol-odata/events{/privacy}","received_events_url":"https://api.github.com/users/biaol-odata/received_events","type":"User","site_admin":false},"repo":{"id":78298453,"name":"odata.net","full_name":"biaol-odata/odata.net","owner":{"login":"biaol-odata","id":24885233,"avatar_url":"https://avatars2.githubusercontent.com/u/24885233?v=4","gravatar_id":"","url":"https://api.github.com/users/biaol-odata","html_url":"https://github.com/biaol-odata","followers_url":"https://api.github.com/users/biaol-odata/followers","following_url":"https://api.github.com/users/biaol-odata/following{/other_user}","gists_url":"https://api.github.com/users/biaol-odata/gists{/gist_id}","starred_url":"https://api.github.com/users/biaol-odata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biaol-odata/subscriptions","organizations_url":"https://api.github.com/users/biaol-odata/orgs","repos_url":"https://api.github.com/users/biaol-odata/repos","events_url":"https://api.github.com/users/biaol-odata/events{/privacy}","received_events_url":"https://api.github.com/users/biaol-odata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/biaol-odata/odata.net","description":"ODataLib: Open Data Protocol - .NET/Silverlight/WP8.1 Libraries and Frameworks","fork":true,"url":"https://api.github.com/repos/biaol-odata/odata.net","forks_url":"https://api.github.com/repos/biaol-odata/odata.net/forks","keys_url":"https://api.github.com/repos/biaol-odata/odata.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biaol-odata/odata.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biaol-odata/odata.net/teams","hooks_url":"https://api.github.com/repos/biaol-odata/odata.net/hooks","issue_events_url":"https://api.github.com/repos/biaol-odata/odata.net/issues/events{/number}","events_url":"https://api.github.com/repos/biaol-odata/odata.net/events","assignees_url":"https://api.github.com/repos/biaol-odata/odata.net/assignees{/user}","branches_url":"https://api.github.com/repos/biaol-odata/odata.net/branches{/branch}","tags_url":"https://api.github.com/repos/biaol-odata/odata.net/tags","blobs_url":"https://api.github.com/repos/biaol-odata/odata.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biaol-odata/odata.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biaol-odata/odata.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/biaol-odata/odata.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biaol-odata/odata.net/statuses/{sha}","languages_url":"https://api.github.com/repos/biaol-odata/odata.net/languages","stargazers_url":"https://api.github.com/repos/biaol-odata/odata.net/stargazers","contributors_url":"https://api.github.com/repos/biaol-odata/odata.net/contributors","subscribers_url":"https://api.github.com/repos/biaol-odata/odata.net/subscribers","subscription_url":"https://api.github.com/repos/biaol-odata/odata.net/subscription","commits_url":"https://api.github.com/repos/biaol-odata/odata.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/biaol-odata/odata.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/biaol-odata/odata.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/biaol-odata/odata.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/biaol-odata/odata.net/contents/{+path}","compare_url":"https://api.github.com/repos/biaol-odata/odata.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biaol-odata/odata.net/merges","archive_url":"https://api.github.com/repos/biaol-odata/odata.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biaol-odata/odata.net/downloads","issues_url":"https://api.github.com/repos/biaol-odata/odata.net/issues{/number}","pulls_url":"https://api.github.com/repos/biaol-odata/odata.net/pulls{/number}","milestones_url":"https://api.github.com/repos/biaol-odata/odata.net/milestones{/number}","notifications_url":"https://api.github.com/repos/biaol-odata/odata.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biaol-odata/odata.net/labels{/name}","releases_url":"https://api.github.com/repos/biaol-odata/odata.net/releases{/id}","deployments_url":"https://api.github.com/repos/biaol-odata/odata.net/deployments","created_at":"2017-01-07T19:15:03Z","updated_at":"2017-01-07T19:15:30Z","pushed_at":"2017-10-19T21:48:28Z","git_url":"git://github.com/biaol-odata/odata.net.git","ssh_url":"git@github.com:biaol-odata/odata.net.git","clone_url":"https://github.com/biaol-odata/odata.net.git","svn_url":"https://github.com/biaol-odata/odata.net","homepage":"http://odata.github.io/odata.net","size":47504,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"maintenance-6.x_JsonFormatBatch-A"}},"base":{"label":"OData:master","ref":"master","sha":"c89f72dacc983319220cf68994bb1aae57f96cce","user":{"login":"OData","id":916520,"avatar_url":"https://avatars1.githubusercontent.com/u/916520?v=4","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"repo":{"id":23308338,"name":"odata.net","full_name":"OData/odata.net","owner":{"login":"OData","id":916520,"avatar_url":"https://avatars1.githubusercontent.com/u/916520?v=4","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OData/odata.net","description":"ODataLib: Open Data Protocol - .NET/Silverlight/WP8.1 Libraries and Frameworks","fork":false,"url":"https://api.github.com/repos/OData/odata.net","forks_url":"https://api.github.com/repos/OData/odata.net/forks","keys_url":"https://api.github.com/repos/OData/odata.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OData/odata.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OData/odata.net/teams","hooks_url":"https://api.github.com/repos/OData/odata.net/hooks","issue_events_url":"https://api.github.com/repos/OData/odata.net/issues/events{/number}","events_url":"https://api.github.com/repos/OData/odata.net/events","assignees_url":"https://api.github.com/repos/OData/odata.net/assignees{/user}","branches_url":"https://api.github.com/repos/OData/odata.net/branches{/branch}","tags_url":"https://api.github.com/repos/OData/odata.net/tags","blobs_url":"https://api.github.com/repos/OData/odata.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OData/odata.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OData/odata.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/OData/odata.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OData/odata.net/statuses/{sha}","languages_url":"https://api.github.com/repos/OData/odata.net/languages","stargazers_url":"https://api.github.com/repos/OData/odata.net/stargazers","contributors_url":"https://api.github.com/repos/OData/odata.net/contributors","subscribers_url":"https://api.github.com/repos/OData/odata.net/subscribers","subscription_url":"https://api.github.com/repos/OData/odata.net/subscription","commits_url":"https://api.github.com/repos/OData/odata.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/OData/odata.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/OData/odata.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/OData/odata.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/OData/odata.net/contents/{+path}","compare_url":"https://api.github.com/repos/OData/odata.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OData/odata.net/merges","archive_url":"https://api.github.com/repos/OData/odata.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OData/odata.net/downloads","issues_url":"https://api.github.com/repos/OData/odata.net/issues{/number}","pulls_url":"https://api.github.com/repos/OData/odata.net/pulls{/number}","milestones_url":"https://api.github.com/repos/OData/odata.net/milestones{/number}","notifications_url":"https://api.github.com/repos/OData/odata.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OData/odata.net/labels{/name}","releases_url":"https://api.github.com/repos/OData/odata.net/releases{/id}","deployments_url":"https://api.github.com/repos/OData/odata.net/deployments","created_at":"2014-08-25T09:15:23Z","updated_at":"2017-10-13T02:11:20Z","pushed_at":"2017-10-19T21:48:30Z","git_url":"git://github.com/OData/odata.net.git","ssh_url":"git@github.com:OData/odata.net.git","clone_url":"https://github.com/OData/odata.net.git","svn_url":"https://github.com/OData/odata.net","homepage":"http://odata.github.io/odata.net","size":50052,"stargazers_count":275,"watchers_count":275,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":161,"mirror_url":null,"open_issues_count":199,"forks":161,"open_issues":199,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OData/odata.net/pulls/960"},"html":{"href":"https://github.com/OData/odata.net/pull/960"},"issue":{"href":"https://api.github.com/repos/OData/odata.net/issues/960"},"comments":{"href":"https://api.github.com/repos/OData/odata.net/issues/960/comments"},"review_comments":{"href":"https://api.github.com/repos/OData/odata.net/pulls/960/comments"},"review_comment":{"href":"https://api.github.com/repos/OData/odata.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OData/odata.net/pulls/960/commits"},"statuses":{"href":"https://api.github.com/repos/OData/odata.net/statuses/15a2fb14ab77198e8bc79fb40361f58c70896a9c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikepizzo"}}