{"action":"closed","number":78,"pull_request":{"url":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls/78","id":152835460,"html_url":"https://github.com/we-learn-js/js-training-practice/pull/78","diff_url":"https://github.com/we-learn-js/js-training-practice/pull/78.diff","patch_url":"https://github.com/we-learn-js/js-training-practice/pull/78.patch","issue_url":"https://api.github.com/repos/we-learn-js/js-training-practice/issues/78","number":78,"state":"closed","locked":false,"title":"Functions \\m/","user":{"login":"joaoqalves","id":843454,"avatar_url":"https://avatars0.githubusercontent.com/u/843454?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoqalves","html_url":"https://github.com/joaoqalves","followers_url":"https://api.github.com/users/joaoqalves/followers","following_url":"https://api.github.com/users/joaoqalves/following{/other_user}","gists_url":"https://api.github.com/users/joaoqalves/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoqalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoqalves/subscriptions","organizations_url":"https://api.github.com/users/joaoqalves/orgs","repos_url":"https://api.github.com/users/joaoqalves/repos","events_url":"https://api.github.com/users/joaoqalves/events{/privacy}","received_events_url":"https://api.github.com/users/joaoqalves/received_events","type":"User","site_admin":false},"body":"**What knowledge was applied in this changeset ?**\r\n<!--- Describe your changes in detail -->\r\n\r\n+ A lot of functions (not all  are pure)\r\n+ Separate `UI` from `Storage`. A better separation of concerns is needed but the PR is too big already\r\n+ Strategy pattern\r\n\r\n**Additional info**\r\n<!--- Any comment that could be usefull to the reader -->\r\n\r\n👎 I tried to do too much here. A lots of improvements are coming in future PRs :) For instance, I'd like to construct HTML as follows:\r\n\r\n```javascript\r\nbody(div(form({name: \"myform\", click: func, classes: [\"red-form\"]})))\r\n```\r\n\r\nBut I'd need to do a lot of work and to separate pure HTML creation from jQuery. I had this in mind when I started but I gave up :) ","created_at":"2017-11-15T17:18:13Z","updated_at":"2017-11-29T20:06:53Z","closed_at":"2017-11-29T20:06:53Z","merged_at":null,"merge_commit_sha":"f8b8ca1d05c70d499632bc9f747ede951bf22b02","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls/78/commits","review_comments_url":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls/78/comments","review_comment_url":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/we-learn-js/js-training-practice/issues/78/comments","statuses_url":"https://api.github.com/repos/we-learn-js/js-training-practice/statuses/73ef23057914e18dfb32ba7e8445c45e438fd099","head":{"label":"joaoqalves:refactor/functions","ref":"refactor/functions","sha":"73ef23057914e18dfb32ba7e8445c45e438fd099","user":{"login":"joaoqalves","id":843454,"avatar_url":"https://avatars0.githubusercontent.com/u/843454?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoqalves","html_url":"https://github.com/joaoqalves","followers_url":"https://api.github.com/users/joaoqalves/followers","following_url":"https://api.github.com/users/joaoqalves/following{/other_user}","gists_url":"https://api.github.com/users/joaoqalves/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoqalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoqalves/subscriptions","organizations_url":"https://api.github.com/users/joaoqalves/orgs","repos_url":"https://api.github.com/users/joaoqalves/repos","events_url":"https://api.github.com/users/joaoqalves/events{/privacy}","received_events_url":"https://api.github.com/users/joaoqalves/received_events","type":"User","site_admin":false},"repo":{"id":109150079,"name":"js-training-practice","full_name":"joaoqalves/js-training-practice","owner":{"login":"joaoqalves","id":843454,"avatar_url":"https://avatars0.githubusercontent.com/u/843454?v=4","gravatar_id":"","url":"https://api.github.com/users/joaoqalves","html_url":"https://github.com/joaoqalves","followers_url":"https://api.github.com/users/joaoqalves/followers","following_url":"https://api.github.com/users/joaoqalves/following{/other_user}","gists_url":"https://api.github.com/users/joaoqalves/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoqalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoqalves/subscriptions","organizations_url":"https://api.github.com/users/joaoqalves/orgs","repos_url":"https://api.github.com/users/joaoqalves/repos","events_url":"https://api.github.com/users/joaoqalves/events{/privacy}","received_events_url":"https://api.github.com/users/joaoqalves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joaoqalves/js-training-practice","description":"JS Training practice project","fork":true,"url":"https://api.github.com/repos/joaoqalves/js-training-practice","forks_url":"https://api.github.com/repos/joaoqalves/js-training-practice/forks","keys_url":"https://api.github.com/repos/joaoqalves/js-training-practice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joaoqalves/js-training-practice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joaoqalves/js-training-practice/teams","hooks_url":"https://api.github.com/repos/joaoqalves/js-training-practice/hooks","issue_events_url":"https://api.github.com/repos/joaoqalves/js-training-practice/issues/events{/number}","events_url":"https://api.github.com/repos/joaoqalves/js-training-practice/events","assignees_url":"https://api.github.com/repos/joaoqalves/js-training-practice/assignees{/user}","branches_url":"https://api.github.com/repos/joaoqalves/js-training-practice/branches{/branch}","tags_url":"https://api.github.com/repos/joaoqalves/js-training-practice/tags","blobs_url":"https://api.github.com/repos/joaoqalves/js-training-practice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joaoqalves/js-training-practice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joaoqalves/js-training-practice/git/refs{/sha}","trees_url":"https://api.github.com/repos/joaoqalves/js-training-practice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joaoqalves/js-training-practice/statuses/{sha}","languages_url":"https://api.github.com/repos/joaoqalves/js-training-practice/languages","stargazers_url":"https://api.github.com/repos/joaoqalves/js-training-practice/stargazers","contributors_url":"https://api.github.com/repos/joaoqalves/js-training-practice/contributors","subscribers_url":"https://api.github.com/repos/joaoqalves/js-training-practice/subscribers","subscription_url":"https://api.github.com/repos/joaoqalves/js-training-practice/subscription","commits_url":"https://api.github.com/repos/joaoqalves/js-training-practice/commits{/sha}","git_commits_url":"https://api.github.com/repos/joaoqalves/js-training-practice/git/commits{/sha}","comments_url":"https://api.github.com/repos/joaoqalves/js-training-practice/comments{/number}","issue_comment_url":"https://api.github.com/repos/joaoqalves/js-training-practice/issues/comments{/number}","contents_url":"https://api.github.com/repos/joaoqalves/js-training-practice/contents/{+path}","compare_url":"https://api.github.com/repos/joaoqalves/js-training-practice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joaoqalves/js-training-practice/merges","archive_url":"https://api.github.com/repos/joaoqalves/js-training-practice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joaoqalves/js-training-practice/downloads","issues_url":"https://api.github.com/repos/joaoqalves/js-training-practice/issues{/number}","pulls_url":"https://api.github.com/repos/joaoqalves/js-training-practice/pulls{/number}","milestones_url":"https://api.github.com/repos/joaoqalves/js-training-practice/milestones{/number}","notifications_url":"https://api.github.com/repos/joaoqalves/js-training-practice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joaoqalves/js-training-practice/labels{/name}","releases_url":"https://api.github.com/repos/joaoqalves/js-training-practice/releases{/id}","deployments_url":"https://api.github.com/repos/joaoqalves/js-training-practice/deployments","created_at":"2017-11-01T15:40:41Z","updated_at":"2017-11-01T15:40:43Z","pushed_at":"2017-11-15T17:20:03Z","git_url":"git://github.com/joaoqalves/js-training-practice.git","ssh_url":"git@github.com:joaoqalves/js-training-practice.git","clone_url":"https://github.com/joaoqalves/js-training-practice.git","svn_url":"https://github.com/joaoqalves/js-training-practice","homepage":"https://js-training.now.sh/","size":327,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"we-learn-js:refactor/functions","ref":"refactor/functions","sha":"c0374e453961ae9cb34c0d474da6f9e5344b5cb4","user":{"login":"we-learn-js","id":33056060,"avatar_url":"https://avatars0.githubusercontent.com/u/33056060?v=4","gravatar_id":"","url":"https://api.github.com/users/we-learn-js","html_url":"https://github.com/we-learn-js","followers_url":"https://api.github.com/users/we-learn-js/followers","following_url":"https://api.github.com/users/we-learn-js/following{/other_user}","gists_url":"https://api.github.com/users/we-learn-js/gists{/gist_id}","starred_url":"https://api.github.com/users/we-learn-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/we-learn-js/subscriptions","organizations_url":"https://api.github.com/users/we-learn-js/orgs","repos_url":"https://api.github.com/users/we-learn-js/repos","events_url":"https://api.github.com/users/we-learn-js/events{/privacy}","received_events_url":"https://api.github.com/users/we-learn-js/received_events","type":"Organization","site_admin":false},"repo":{"id":68214280,"name":"js-training-practice","full_name":"we-learn-js/js-training-practice","owner":{"login":"we-learn-js","id":33056060,"avatar_url":"https://avatars0.githubusercontent.com/u/33056060?v=4","gravatar_id":"","url":"https://api.github.com/users/we-learn-js","html_url":"https://github.com/we-learn-js","followers_url":"https://api.github.com/users/we-learn-js/followers","following_url":"https://api.github.com/users/we-learn-js/following{/other_user}","gists_url":"https://api.github.com/users/we-learn-js/gists{/gist_id}","starred_url":"https://api.github.com/users/we-learn-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/we-learn-js/subscriptions","organizations_url":"https://api.github.com/users/we-learn-js/orgs","repos_url":"https://api.github.com/users/we-learn-js/repos","events_url":"https://api.github.com/users/we-learn-js/events{/privacy}","received_events_url":"https://api.github.com/users/we-learn-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/we-learn-js/js-training-practice","description":"JS Training practice project","fork":false,"url":"https://api.github.com/repos/we-learn-js/js-training-practice","forks_url":"https://api.github.com/repos/we-learn-js/js-training-practice/forks","keys_url":"https://api.github.com/repos/we-learn-js/js-training-practice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/we-learn-js/js-training-practice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/we-learn-js/js-training-practice/teams","hooks_url":"https://api.github.com/repos/we-learn-js/js-training-practice/hooks","issue_events_url":"https://api.github.com/repos/we-learn-js/js-training-practice/issues/events{/number}","events_url":"https://api.github.com/repos/we-learn-js/js-training-practice/events","assignees_url":"https://api.github.com/repos/we-learn-js/js-training-practice/assignees{/user}","branches_url":"https://api.github.com/repos/we-learn-js/js-training-practice/branches{/branch}","tags_url":"https://api.github.com/repos/we-learn-js/js-training-practice/tags","blobs_url":"https://api.github.com/repos/we-learn-js/js-training-practice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/we-learn-js/js-training-practice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/we-learn-js/js-training-practice/git/refs{/sha}","trees_url":"https://api.github.com/repos/we-learn-js/js-training-practice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/we-learn-js/js-training-practice/statuses/{sha}","languages_url":"https://api.github.com/repos/we-learn-js/js-training-practice/languages","stargazers_url":"https://api.github.com/repos/we-learn-js/js-training-practice/stargazers","contributors_url":"https://api.github.com/repos/we-learn-js/js-training-practice/contributors","subscribers_url":"https://api.github.com/repos/we-learn-js/js-training-practice/subscribers","subscription_url":"https://api.github.com/repos/we-learn-js/js-training-practice/subscription","commits_url":"https://api.github.com/repos/we-learn-js/js-training-practice/commits{/sha}","git_commits_url":"https://api.github.com/repos/we-learn-js/js-training-practice/git/commits{/sha}","comments_url":"https://api.github.com/repos/we-learn-js/js-training-practice/comments{/number}","issue_comment_url":"https://api.github.com/repos/we-learn-js/js-training-practice/issues/comments{/number}","contents_url":"https://api.github.com/repos/we-learn-js/js-training-practice/contents/{+path}","compare_url":"https://api.github.com/repos/we-learn-js/js-training-practice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/we-learn-js/js-training-practice/merges","archive_url":"https://api.github.com/repos/we-learn-js/js-training-practice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/we-learn-js/js-training-practice/downloads","issues_url":"https://api.github.com/repos/we-learn-js/js-training-practice/issues{/number}","pulls_url":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls{/number}","milestones_url":"https://api.github.com/repos/we-learn-js/js-training-practice/milestones{/number}","notifications_url":"https://api.github.com/repos/we-learn-js/js-training-practice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/we-learn-js/js-training-practice/labels{/name}","releases_url":"https://api.github.com/repos/we-learn-js/js-training-practice/releases{/id}","deployments_url":"https://api.github.com/repos/we-learn-js/js-training-practice/deployments","created_at":"2016-09-14T14:39:22Z","updated_at":"2017-11-04T20:06:31Z","pushed_at":"2017-11-29T17:09:14Z","git_url":"git://github.com/we-learn-js/js-training-practice.git","ssh_url":"git@github.com:we-learn-js/js-training-practice.git","clone_url":"https://github.com/we-learn-js/js-training-practice.git","svn_url":"https://github.com/we-learn-js/js-training-practice","homepage":"https://js-training.now.sh/","size":357,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":4,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls/78"},"html":{"href":"https://github.com/we-learn-js/js-training-practice/pull/78"},"issue":{"href":"https://api.github.com/repos/we-learn-js/js-training-practice/issues/78"},"comments":{"href":"https://api.github.com/repos/we-learn-js/js-training-practice/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/we-learn-js/js-training-practice/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/we-learn-js/js-training-practice/statuses/73ef23057914e18dfb32ba7e8445c45e438fd099"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":2,"additions":171,"deletions":160,"changed_files":1}}
{"actor":{"display_login":"davidbarna"}}