{"action":"created","comment":{"url":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/comments/109917305","pull_request_review_id":30840056,"id":109917305,"diff_hunk":"@@ -63,13 +64,8 @@ def extract_populations_cql_map\n           criteria_def = population_def.at_xpath(\"cda:#{criteria_element_name}\", HQMF2::Document::NAMESPACES)\n           if criteria_def\n             cql_statement = criteria_def.at_xpath(\"*/*/cda:id\", HQMF2::Document::NAMESPACES).attribute('extension').to_s.match(/\"([^\"]*)\"/)\n-            if @populations_cql_map[criteria_id].nil?\n-              @populations_cql_map[criteria_id] = []\n-            end\n-            cql_statement = cql_statement.to_s.delete('\\\\\"')\n-            unless @populations_cql_map[criteria_id].include? cql_statement\n-              @populations_cql_map[criteria_id].push(cql_statement)\n-            end\n+            @populations_cql_map[criteria_id] = cql_statement.to_s\n+            @populations_cql_map[criteria_id] = cql_statement.to_s.delete('\\\\\"')","path":"lib/hqmf-parser/cql/document.rb","position":20,"original_position":20,"commit_id":"e3105668577d2de1e593b6a3cc913d0b1e009e52","original_commit_id":"e3105668577d2de1e593b6a3cc913d0b1e009e52","user":{"login":"edeyoung","id":11574199,"avatar_url":"https://avatars2.githubusercontent.com/u/11574199?v=3","gravatar_id":"","url":"https://api.github.com/users/edeyoung","html_url":"https://github.com/edeyoung","followers_url":"https://api.github.com/users/edeyoung/followers","following_url":"https://api.github.com/users/edeyoung/following{/other_user}","gists_url":"https://api.github.com/users/edeyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/edeyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edeyoung/subscriptions","organizations_url":"https://api.github.com/users/edeyoung/orgs","repos_url":"https://api.github.com/users/edeyoung/repos","events_url":"https://api.github.com/users/edeyoung/events{/privacy}","received_events_url":"https://api.github.com/users/edeyoung/received_events","type":"User","site_admin":false},"body":"was this necessary for your changes or a simplification that you noticed could be implemented? if a simplification, please revert and include in another PR so we can test any effects of this separately. if necessary, please explain. the code looks like it removes some checks and default behavior that may be important.","created_at":"2017-04-05T13:38:24Z","updated_at":"2017-04-05T13:40:19Z","html_url":"https://github.com/projectcypress/health-data-standards/pull/483#discussion_r109917305","pull_request_url":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/483","_links":{"self":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/comments/109917305"},"html":{"href":"https://github.com/projectcypress/health-data-standards/pull/483#discussion_r109917305"},"pull_request":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/483"}}},"pull_request":{"url":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/483","id":113262397,"html_url":"https://github.com/projectcypress/health-data-standards/pull/483","diff_url":"https://github.com/projectcypress/health-data-standards/pull/483.diff","patch_url":"https://github.com/projectcypress/health-data-standards/pull/483.patch","issue_url":"https://api.github.com/repos/projectcypress/health-data-standards/issues/483","number":483,"state":"open","locked":false,"title":"Qdm 5.01 cql","user":{"login":"mayerm94","id":3967953,"avatar_url":"https://avatars0.githubusercontent.com/u/3967953?v=3","gravatar_id":"","url":"https://api.github.com/users/mayerm94","html_url":"https://github.com/mayerm94","followers_url":"https://api.github.com/users/mayerm94/followers","following_url":"https://api.github.com/users/mayerm94/following{/other_user}","gists_url":"https://api.github.com/users/mayerm94/gists{/gist_id}","starred_url":"https://api.github.com/users/mayerm94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayerm94/subscriptions","organizations_url":"https://api.github.com/users/mayerm94/orgs","repos_url":"https://api.github.com/users/mayerm94/repos","events_url":"https://api.github.com/users/mayerm94/events{/privacy}","received_events_url":"https://api.github.com/users/mayerm94/received_events","type":"User","site_admin":false},"body":"These include the addition of the components attribute added in the QDM 5.01 document.","created_at":"2017-03-29T18:22:01Z","updated_at":"2017-04-05T13:40:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"648012c5895216fd145d46fd01157de4f9608f17","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/483/commits","review_comments_url":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/483/comments","review_comment_url":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcypress/health-data-standards/issues/483/comments","statuses_url":"https://api.github.com/repos/projectcypress/health-data-standards/statuses/e3105668577d2de1e593b6a3cc913d0b1e009e52","head":{"label":"projectcypress:QDM-5.02-CQL","ref":"QDM-5.02-CQL","sha":"e3105668577d2de1e593b6a3cc913d0b1e009e52","user":{"login":"projectcypress","id":1188796,"avatar_url":"https://avatars1.githubusercontent.com/u/1188796?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcypress","html_url":"https://github.com/projectcypress","followers_url":"https://api.github.com/users/projectcypress/followers","following_url":"https://api.github.com/users/projectcypress/following{/other_user}","gists_url":"https://api.github.com/users/projectcypress/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcypress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcypress/subscriptions","organizations_url":"https://api.github.com/users/projectcypress/orgs","repos_url":"https://api.github.com/users/projectcypress/repos","events_url":"https://api.github.com/users/projectcypress/events{/privacy}","received_events_url":"https://api.github.com/users/projectcypress/received_events","type":"Organization","site_admin":false},"repo":{"id":2980040,"name":"health-data-standards","full_name":"projectcypress/health-data-standards","owner":{"login":"projectcypress","id":1188796,"avatar_url":"https://avatars1.githubusercontent.com/u/1188796?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcypress","html_url":"https://github.com/projectcypress","followers_url":"https://api.github.com/users/projectcypress/followers","following_url":"https://api.github.com/users/projectcypress/following{/other_user}","gists_url":"https://api.github.com/users/projectcypress/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcypress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcypress/subscriptions","organizations_url":"https://api.github.com/users/projectcypress/orgs","repos_url":"https://api.github.com/users/projectcypress/repos","events_url":"https://api.github.com/users/projectcypress/events{/privacy}","received_events_url":"https://api.github.com/users/projectcypress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcypress/health-data-standards","description":null,"fork":false,"url":"https://api.github.com/repos/projectcypress/health-data-standards","forks_url":"https://api.github.com/repos/projectcypress/health-data-standards/forks","keys_url":"https://api.github.com/repos/projectcypress/health-data-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcypress/health-data-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcypress/health-data-standards/teams","hooks_url":"https://api.github.com/repos/projectcypress/health-data-standards/hooks","issue_events_url":"https://api.github.com/repos/projectcypress/health-data-standards/issues/events{/number}","events_url":"https://api.github.com/repos/projectcypress/health-data-standards/events","assignees_url":"https://api.github.com/repos/projectcypress/health-data-standards/assignees{/user}","branches_url":"https://api.github.com/repos/projectcypress/health-data-standards/branches{/branch}","tags_url":"https://api.github.com/repos/projectcypress/health-data-standards/tags","blobs_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcypress/health-data-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcypress/health-data-standards/languages","stargazers_url":"https://api.github.com/repos/projectcypress/health-data-standards/stargazers","contributors_url":"https://api.github.com/repos/projectcypress/health-data-standards/contributors","subscribers_url":"https://api.github.com/repos/projectcypress/health-data-standards/subscribers","subscription_url":"https://api.github.com/repos/projectcypress/health-data-standards/subscription","commits_url":"https://api.github.com/repos/projectcypress/health-data-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcypress/health-data-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcypress/health-data-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcypress/health-data-standards/contents/{+path}","compare_url":"https://api.github.com/repos/projectcypress/health-data-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcypress/health-data-standards/merges","archive_url":"https://api.github.com/repos/projectcypress/health-data-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcypress/health-data-standards/downloads","issues_url":"https://api.github.com/repos/projectcypress/health-data-standards/issues{/number}","pulls_url":"https://api.github.com/repos/projectcypress/health-data-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcypress/health-data-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcypress/health-data-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcypress/health-data-standards/labels{/name}","releases_url":"https://api.github.com/repos/projectcypress/health-data-standards/releases{/id}","deployments_url":"https://api.github.com/repos/projectcypress/health-data-standards/deployments","created_at":"2011-12-14T13:26:30Z","updated_at":"2017-02-09T14:55:08Z","pushed_at":"2017-04-04T18:22:09Z","git_url":"git://github.com/projectcypress/health-data-standards.git","ssh_url":"git@github.com:projectcypress/health-data-standards.git","clone_url":"https://github.com/projectcypress/health-data-standards.git","svn_url":"https://github.com/projectcypress/health-data-standards","homepage":"https://rubygems.org/gems/health-data-standards","size":26494,"stargazers_count":71,"watchers_count":71,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":29,"forks":77,"open_issues":29,"watchers":71,"default_branch":"master"}},"base":{"label":"projectcypress:cql4bonnie","ref":"cql4bonnie","sha":"1198237a119919359dad1bd712fb83ca9bb32b34","user":{"login":"projectcypress","id":1188796,"avatar_url":"https://avatars1.githubusercontent.com/u/1188796?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcypress","html_url":"https://github.com/projectcypress","followers_url":"https://api.github.com/users/projectcypress/followers","following_url":"https://api.github.com/users/projectcypress/following{/other_user}","gists_url":"https://api.github.com/users/projectcypress/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcypress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcypress/subscriptions","organizations_url":"https://api.github.com/users/projectcypress/orgs","repos_url":"https://api.github.com/users/projectcypress/repos","events_url":"https://api.github.com/users/projectcypress/events{/privacy}","received_events_url":"https://api.github.com/users/projectcypress/received_events","type":"Organization","site_admin":false},"repo":{"id":2980040,"name":"health-data-standards","full_name":"projectcypress/health-data-standards","owner":{"login":"projectcypress","id":1188796,"avatar_url":"https://avatars1.githubusercontent.com/u/1188796?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcypress","html_url":"https://github.com/projectcypress","followers_url":"https://api.github.com/users/projectcypress/followers","following_url":"https://api.github.com/users/projectcypress/following{/other_user}","gists_url":"https://api.github.com/users/projectcypress/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcypress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcypress/subscriptions","organizations_url":"https://api.github.com/users/projectcypress/orgs","repos_url":"https://api.github.com/users/projectcypress/repos","events_url":"https://api.github.com/users/projectcypress/events{/privacy}","received_events_url":"https://api.github.com/users/projectcypress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcypress/health-data-standards","description":null,"fork":false,"url":"https://api.github.com/repos/projectcypress/health-data-standards","forks_url":"https://api.github.com/repos/projectcypress/health-data-standards/forks","keys_url":"https://api.github.com/repos/projectcypress/health-data-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcypress/health-data-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcypress/health-data-standards/teams","hooks_url":"https://api.github.com/repos/projectcypress/health-data-standards/hooks","issue_events_url":"https://api.github.com/repos/projectcypress/health-data-standards/issues/events{/number}","events_url":"https://api.github.com/repos/projectcypress/health-data-standards/events","assignees_url":"https://api.github.com/repos/projectcypress/health-data-standards/assignees{/user}","branches_url":"https://api.github.com/repos/projectcypress/health-data-standards/branches{/branch}","tags_url":"https://api.github.com/repos/projectcypress/health-data-standards/tags","blobs_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcypress/health-data-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcypress/health-data-standards/languages","stargazers_url":"https://api.github.com/repos/projectcypress/health-data-standards/stargazers","contributors_url":"https://api.github.com/repos/projectcypress/health-data-standards/contributors","subscribers_url":"https://api.github.com/repos/projectcypress/health-data-standards/subscribers","subscription_url":"https://api.github.com/repos/projectcypress/health-data-standards/subscription","commits_url":"https://api.github.com/repos/projectcypress/health-data-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcypress/health-data-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcypress/health-data-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcypress/health-data-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcypress/health-data-standards/contents/{+path}","compare_url":"https://api.github.com/repos/projectcypress/health-data-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcypress/health-data-standards/merges","archive_url":"https://api.github.com/repos/projectcypress/health-data-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcypress/health-data-standards/downloads","issues_url":"https://api.github.com/repos/projectcypress/health-data-standards/issues{/number}","pulls_url":"https://api.github.com/repos/projectcypress/health-data-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcypress/health-data-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcypress/health-data-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcypress/health-data-standards/labels{/name}","releases_url":"https://api.github.com/repos/projectcypress/health-data-standards/releases{/id}","deployments_url":"https://api.github.com/repos/projectcypress/health-data-standards/deployments","created_at":"2011-12-14T13:26:30Z","updated_at":"2017-02-09T14:55:08Z","pushed_at":"2017-04-04T18:22:09Z","git_url":"git://github.com/projectcypress/health-data-standards.git","ssh_url":"git@github.com:projectcypress/health-data-standards.git","clone_url":"https://github.com/projectcypress/health-data-standards.git","svn_url":"https://github.com/projectcypress/health-data-standards","homepage":"https://rubygems.org/gems/health-data-standards","size":26494,"stargazers_count":71,"watchers_count":71,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":29,"forks":77,"open_issues":29,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/483"},"html":{"href":"https://github.com/projectcypress/health-data-standards/pull/483"},"issue":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/issues/483"},"comments":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/projectcypress/health-data-standards/statuses/e3105668577d2de1e593b6a3cc913d0b1e009e52"}}}}
{"actor":{"display_login":"edeyoung"}}