{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/119495085","pull_request_review_id":41380499,"id":119495085,"diff_hunk":"@@ -0,0 +1,54 @@\n+// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System.Data;\n+using JetBrains.Annotations;\n+\n+namespace Microsoft.EntityFrameworkCore.Storage\n+{\n+    /// <summary>\n+    ///     <para>\n+    ///         Represents the mapping between a specified .NET type and a database type.\n+    ///     </para>\n+    ///     <para>\n+    ///         This type is typically used by database providers (and other extensions). It is generally\n+    ///         not used in application code.\n+    ///     </para>\n+    /// </summary>\n+    public abstract class RelationalTypeMapping<T> : RelationalTypeMapping\n+    {\n+        /// <summary>\n+        ///     Initializes a new instance of the <see cref=\"RelationalTypeMapping\" /> class.\n+        /// </summary>\n+        /// <param name=\"storeType\"> The name of the database type. </param>\n+        /// <param name=\"dbType\"> The <see cref=\"System.Data.DbType\" /> to be used. </param>\n+        /// <param name=\"unicode\"> A value indicating whether the type should handle Unicode data or not. </param>\n+        /// <param name=\"size\"> The size of data the property is configured to store, or null if no size is configured. </param>\n+        /// <param name=\"hasNonDefaultUnicode\"> A value indicating whether the Unicode setting has been manually configured to a non-default value. </param>\n+        /// <param name=\"hasNonDefaultSize\"> A value indicating whether the size setting has been manually configured to a non-default value. </param>\n+        public RelationalTypeMapping(\n+            [NotNull] string storeType,\n+            [CanBeNull] DbType? dbType,\n+            bool unicode,\n+            int? size,\n+            bool hasNonDefaultUnicode = false,\n+            bool hasNonDefaultSize = false)\n+            : base(storeType, typeof(T), dbType, unicode, size, hasNonDefaultUnicode, hasNonDefaultSize)\n+        {\n+        }\n+\n+        /// <summary>\n+        ///     Generates the SQL representation of a literal value.\n+        /// </summary>\n+        /// <param name=\"value\">The literal value.</param>\n+        /// <returns>\n+        ///     The generated string.\n+        /// </returns>\n+        public override string GenerateSqlLiteral([CanBeNull]object value)\n+        {\n+            return value == null\n+                ? base.GenerateSqlLiteral(value)\n+                : GenerateNonNullSqlLiteral((T)value);","path":"src/EFCore.Relational/Storage/RelationalTypeMapping`.cs","position":51,"original_position":51,"commit_id":"e94c26b799ac02d43dd5ff921d245a212f8ac324","original_commit_id":"e94c26b799ac02d43dd5ff921d245a212f8ac324","user":{"login":"ajcvickers","id":1430078,"avatar_url":"https://avatars2.githubusercontent.com/u/1430078?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcvickers","html_url":"https://github.com/ajcvickers","followers_url":"https://api.github.com/users/ajcvickers/followers","following_url":"https://api.github.com/users/ajcvickers/following{/other_user}","gists_url":"https://api.github.com/users/ajcvickers/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcvickers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcvickers/subscriptions","organizations_url":"https://api.github.com/users/ajcvickers/orgs","repos_url":"https://api.github.com/users/ajcvickers/repos","events_url":"https://api.github.com/users/ajcvickers/events{/privacy}","received_events_url":"https://api.github.com/users/ajcvickers/received_events","type":"User","site_admin":false},"body":"Is this override needed?","created_at":"2017-05-31T23:02:39Z","updated_at":"2017-05-31T23:02:39Z","html_url":"https://github.com/aspnet/EntityFramework/pull/8631#discussion_r119495085","pull_request_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8631","_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments/119495085"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/8631#discussion_r119495085"},"pull_request":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8631"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8631","id":122814756,"html_url":"https://github.com/aspnet/EntityFramework/pull/8631","diff_url":"https://github.com/aspnet/EntityFramework/pull/8631.diff","patch_url":"https://github.com/aspnet/EntityFramework/pull/8631.patch","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/8631","number":8631,"state":"open","locked":false,"title":"Replace existing double-dispatch method by using individual TypeMapping classes","user":{"login":"lajones","id":1915927,"avatar_url":"https://avatars1.githubusercontent.com/u/1915927?v=3","gravatar_id":"","url":"https://api.github.com/users/lajones","html_url":"https://github.com/lajones","followers_url":"https://api.github.com/users/lajones/followers","following_url":"https://api.github.com/users/lajones/following{/other_user}","gists_url":"https://api.github.com/users/lajones/gists{/gist_id}","starred_url":"https://api.github.com/users/lajones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lajones/subscriptions","organizations_url":"https://api.github.com/users/lajones/orgs","repos_url":"https://api.github.com/users/lajones/repos","events_url":"https://api.github.com/users/lajones/events{/privacy}","received_events_url":"https://api.github.com/users/lajones/received_events","type":"User","site_admin":false},"body":"... for each C# type.\r\n\r\nThis is the replacement for PR #8612. Removing the double-dispatch method we had and using separate TypeMapping classes for each C# type. Sets us up to better address issue #7434 in the future.","created_at":"2017-05-29T00:25:23Z","updated_at":"2017-05-31T23:02:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8631/commits","review_comments_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8631/comments","review_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/8631/comments","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/e94c26b799ac02d43dd5ff921d245a212f8ac324","head":{"label":"aspnet:170528_7434_SeparateTypeMappings_04","ref":"170528_7434_SeparateTypeMappings_04","sha":"e94c26b799ac02d43dd5ff921d245a212f8ac324","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16157746,"name":"EntityFramework","full_name":"aspnet/EntityFramework","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/EntityFramework","description":"Entity Framework Core is a lightweight and extensible version of the popular Entity Framework data access technology","fork":false,"url":"https://api.github.com/repos/aspnet/EntityFramework","forks_url":"https://api.github.com/repos/aspnet/EntityFramework/forks","keys_url":"https://api.github.com/repos/aspnet/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/EntityFramework/teams","hooks_url":"https://api.github.com/repos/aspnet/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/EntityFramework/events","assignees_url":"https://api.github.com/repos/aspnet/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/EntityFramework/tags","blobs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/aspnet/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/aspnet/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/aspnet/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/aspnet/EntityFramework/subscription","commits_url":"https://api.github.com/repos/aspnet/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/EntityFramework/merges","archive_url":"https://api.github.com/repos/aspnet/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/EntityFramework/downloads","issues_url":"https://api.github.com/repos/aspnet/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/EntityFramework/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/EntityFramework/deployments","created_at":"2014-01-23T00:52:01Z","updated_at":"2017-05-31T07:07:44Z","pushed_at":"2017-05-31T22:51:29Z","git_url":"git://github.com/aspnet/EntityFramework.git","ssh_url":"git@github.com:aspnet/EntityFramework.git","clone_url":"https://github.com/aspnet/EntityFramework.git","svn_url":"https://github.com/aspnet/EntityFramework","homepage":"https://docs.microsoft.com/ef/","size":49418,"stargazers_count":4607,"watchers_count":4607,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1355,"mirror_url":null,"open_issues_count":575,"forks":1355,"open_issues":575,"watchers":4607,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"4ea6a93a25f3d061db005a67ac3b5ef9f4c55b4f","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":16157746,"name":"EntityFramework","full_name":"aspnet/EntityFramework","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars0.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/EntityFramework","description":"Entity Framework Core is a lightweight and extensible version of the popular Entity Framework data access technology","fork":false,"url":"https://api.github.com/repos/aspnet/EntityFramework","forks_url":"https://api.github.com/repos/aspnet/EntityFramework/forks","keys_url":"https://api.github.com/repos/aspnet/EntityFramework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/EntityFramework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/EntityFramework/teams","hooks_url":"https://api.github.com/repos/aspnet/EntityFramework/hooks","issue_events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/EntityFramework/events","assignees_url":"https://api.github.com/repos/aspnet/EntityFramework/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/EntityFramework/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/EntityFramework/tags","blobs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/EntityFramework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/EntityFramework/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/EntityFramework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/EntityFramework/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/EntityFramework/languages","stargazers_url":"https://api.github.com/repos/aspnet/EntityFramework/stargazers","contributors_url":"https://api.github.com/repos/aspnet/EntityFramework/contributors","subscribers_url":"https://api.github.com/repos/aspnet/EntityFramework/subscribers","subscription_url":"https://api.github.com/repos/aspnet/EntityFramework/subscription","commits_url":"https://api.github.com/repos/aspnet/EntityFramework/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/EntityFramework/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/EntityFramework/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/EntityFramework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/EntityFramework/merges","archive_url":"https://api.github.com/repos/aspnet/EntityFramework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/EntityFramework/downloads","issues_url":"https://api.github.com/repos/aspnet/EntityFramework/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/EntityFramework/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/EntityFramework/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/EntityFramework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/EntityFramework/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/EntityFramework/deployments","created_at":"2014-01-23T00:52:01Z","updated_at":"2017-05-31T07:07:44Z","pushed_at":"2017-05-31T22:51:29Z","git_url":"git://github.com/aspnet/EntityFramework.git","ssh_url":"git@github.com:aspnet/EntityFramework.git","clone_url":"https://github.com/aspnet/EntityFramework.git","svn_url":"https://github.com/aspnet/EntityFramework","homepage":"https://docs.microsoft.com/ef/","size":49418,"stargazers_count":4607,"watchers_count":4607,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1355,"mirror_url":null,"open_issues_count":575,"forks":1355,"open_issues":575,"watchers":4607,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8631"},"html":{"href":"https://github.com/aspnet/EntityFramework/pull/8631"},"issue":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/8631"},"comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/issues/8631/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8631/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/EntityFramework/pulls/8631/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/EntityFramework/statuses/e94c26b799ac02d43dd5ff921d245a212f8ac324"}}}}
{"actor":{"display_login":"ajcvickers"}}