{"action":"closed","number":16649,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16649","id":132836932,"html_url":"https://github.com/Automattic/wp-calypso/pull/16649","diff_url":"https://github.com/Automattic/wp-calypso/pull/16649.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/16649.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16649","number":16649,"state":"closed","locked":false,"title":"Search component: add aria-label","user":{"login":"bluefuton","id":17325,"avatar_url":"https://avatars2.githubusercontent.com/u/17325?v=4","gravatar_id":"","url":"https://api.github.com/users/bluefuton","html_url":"https://github.com/bluefuton","followers_url":"https://api.github.com/users/bluefuton/followers","following_url":"https://api.github.com/users/bluefuton/following{/other_user}","gists_url":"https://api.github.com/users/bluefuton/gists{/gist_id}","starred_url":"https://api.github.com/users/bluefuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluefuton/subscriptions","organizations_url":"https://api.github.com/users/bluefuton/orgs","repos_url":"https://api.github.com/users/bluefuton/repos","events_url":"https://api.github.com/users/bluefuton/events{/privacy}","received_events_url":"https://api.github.com/users/bluefuton/received_events","type":"User","site_admin":false},"body":"The main search input for the Search component does not currently have a `label` element or `aria-label` attribute.\r\n\r\nhttps://github.com/GoogleChrome/accessibility-developer-tools/wiki/Audit-Rules#ax_text_01\r\n\r\nThis PR adds a default `aria-label` of \"Search\" and allows the developer to specify a custom label with the `inputLabel` prop.\r\n\r\nThere are also some minor formatting changes introduced by Prettier. The component needs modernising/ES6-ifying, but I suggest we do that in a followup PR.\r\n\r\n## To test \r\n\r\nhttp://calypso.localhost:3000/devdocs/design/search","created_at":"2017-07-27T20:21:22Z","updated_at":"2017-07-28T16:09:39Z","closed_at":"2017-07-28T16:09:39Z","merged_at":"2017-07-28T16:09:39Z","merge_commit_sha":"8851666af8255d76b80ddbc95f380768b41f8a25","assignee":{"login":"bluefuton","id":17325,"avatar_url":"https://avatars2.githubusercontent.com/u/17325?v=4","gravatar_id":"","url":"https://api.github.com/users/bluefuton","html_url":"https://github.com/bluefuton","followers_url":"https://api.github.com/users/bluefuton/followers","following_url":"https://api.github.com/users/bluefuton/following{/other_user}","gists_url":"https://api.github.com/users/bluefuton/gists{/gist_id}","starred_url":"https://api.github.com/users/bluefuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluefuton/subscriptions","organizations_url":"https://api.github.com/users/bluefuton/orgs","repos_url":"https://api.github.com/users/bluefuton/repos","events_url":"https://api.github.com/users/bluefuton/events{/privacy}","received_events_url":"https://api.github.com/users/bluefuton/received_events","type":"User","site_admin":false},"assignees":[{"login":"bluefuton","id":17325,"avatar_url":"https://avatars2.githubusercontent.com/u/17325?v=4","gravatar_id":"","url":"https://api.github.com/users/bluefuton","html_url":"https://github.com/bluefuton","followers_url":"https://api.github.com/users/bluefuton/followers","following_url":"https://api.github.com/users/bluefuton/following{/other_user}","gists_url":"https://api.github.com/users/bluefuton/gists{/gist_id}","starred_url":"https://api.github.com/users/bluefuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluefuton/subscriptions","organizations_url":"https://api.github.com/users/bluefuton/orgs","repos_url":"https://api.github.com/users/bluefuton/repos","events_url":"https://api.github.com/users/bluefuton/events{/privacy}","received_events_url":"https://api.github.com/users/bluefuton/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"samouri","id":4656974,"avatar_url":"https://avatars1.githubusercontent.com/u/4656974?v=4","gravatar_id":"","url":"https://api.github.com/users/samouri","html_url":"https://github.com/samouri","followers_url":"https://api.github.com/users/samouri/followers","following_url":"https://api.github.com/users/samouri/following{/other_user}","gists_url":"https://api.github.com/users/samouri/gists{/gist_id}","starred_url":"https://api.github.com/users/samouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samouri/subscriptions","organizations_url":"https://api.github.com/users/samouri/orgs","repos_url":"https://api.github.com/users/samouri/repos","events_url":"https://api.github.com/users/samouri/events{/privacy}","received_events_url":"https://api.github.com/users/samouri/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16649/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16649/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16649/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/b478364f85feece76132087ab70b121644ef0c53","head":{"label":"Automattic:add/search-label","ref":"add/search-label","sha":"b478364f85feece76132087ab70b121644ef0c53","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-07-28T10:23:08Z","pushed_at":"2017-07-28T16:09:39Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":69920,"stargazers_count":8968,"watchers_count":8968,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1195,"mirror_url":null,"open_issues_count":2160,"forks":1195,"open_issues":2160,"watchers":8968,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"578c6b776330658ed6948cc8eb0732bfe26d8568","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-07-28T10:23:08Z","pushed_at":"2017-07-28T16:09:39Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":69920,"stargazers_count":8968,"watchers_count":8968,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1195,"mirror_url":null,"open_issues_count":2160,"forks":1195,"open_issues":2160,"watchers":8968,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16649"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/16649"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/16649"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/16649/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16649/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16649/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/b478364f85feece76132087ab70b121644ef0c53"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bluefuton","id":17325,"avatar_url":"https://avatars2.githubusercontent.com/u/17325?v=4","gravatar_id":"","url":"https://api.github.com/users/bluefuton","html_url":"https://github.com/bluefuton","followers_url":"https://api.github.com/users/bluefuton/followers","following_url":"https://api.github.com/users/bluefuton/following{/other_user}","gists_url":"https://api.github.com/users/bluefuton/gists{/gist_id}","starred_url":"https://api.github.com/users/bluefuton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluefuton/subscriptions","organizations_url":"https://api.github.com/users/bluefuton/orgs","repos_url":"https://api.github.com/users/bluefuton/repos","events_url":"https://api.github.com/users/bluefuton/events{/privacy}","received_events_url":"https://api.github.com/users/bluefuton/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":46,"deletions":35,"changed_files":2}}
{"actor":{"display_login":"bluefuton"}}