{"action":"created","comment":{"url":"https://api.github.com/repos/zetavm/zetavm/pulls/comments/137067615","pull_request_review_id":60687771,"id":137067615,"diff_hunk":"@@ -137,3 +137,24 @@ exports.floor = function (x)\n         \"unhandled type in floor function\"\n     );\n };\n+\n+exports.ceil = function (x)\n+{\n+    if (typeof x == \"int32\")\n+    {\n+        return x;\n+    }\n+\n+    if (typeof x == \"float32\")\n+    {\n+        var xi = $f32_to_i32(x);\n+        if (x <= xi)\n+            return xi;\n+        return xi + 1;\n+    }\n+\n+    assert(\n+        false,\n+        \"unhandled type in floor function\"","path":"plush/math.pls","position":22,"original_position":22,"commit_id":"5b3a759345a960ef37e1cd22787ea4324142d82a","original_commit_id":"5b3a759345a960ef37e1cd22787ea4324142d82a","user":{"login":"ashwanidausodia","id":16511336,"avatar_url":"https://avatars2.githubusercontent.com/u/16511336?v=4","gravatar_id":"","url":"https://api.github.com/users/ashwanidausodia","html_url":"https://github.com/ashwanidausodia","followers_url":"https://api.github.com/users/ashwanidausodia/followers","following_url":"https://api.github.com/users/ashwanidausodia/following{/other_user}","gists_url":"https://api.github.com/users/ashwanidausodia/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwanidausodia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwanidausodia/subscriptions","organizations_url":"https://api.github.com/users/ashwanidausodia/orgs","repos_url":"https://api.github.com/users/ashwanidausodia/repos","events_url":"https://api.github.com/users/ashwanidausodia/events{/privacy}","received_events_url":"https://api.github.com/users/ashwanidausodia/received_events","type":"User","site_admin":false},"body":"@Maaarcocr Yeah you are right. Its is copy paste mistake.","created_at":"2017-09-05T17:49:57Z","updated_at":"2017-09-05T17:49:57Z","html_url":"https://github.com/zetavm/zetavm/pull/98#discussion_r137067615","pull_request_url":"https://api.github.com/repos/zetavm/zetavm/pulls/98","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zetavm/zetavm/pulls/comments/137067615"},"html":{"href":"https://github.com/zetavm/zetavm/pull/98#discussion_r137067615"},"pull_request":{"href":"https://api.github.com/repos/zetavm/zetavm/pulls/98"}},"in_reply_to_id":137056839},"pull_request":{"url":"https://api.github.com/repos/zetavm/zetavm/pulls/98","id":139370845,"html_url":"https://github.com/zetavm/zetavm/pull/98","diff_url":"https://github.com/zetavm/zetavm/pull/98.diff","patch_url":"https://github.com/zetavm/zetavm/pull/98.patch","issue_url":"https://api.github.com/repos/zetavm/zetavm/issues/98","number":98,"state":"open","locked":false,"title":"Initial implementation of std/map","user":{"login":"ashwanidausodia","id":16511336,"avatar_url":"https://avatars2.githubusercontent.com/u/16511336?v=4","gravatar_id":"","url":"https://api.github.com/users/ashwanidausodia","html_url":"https://github.com/ashwanidausodia","followers_url":"https://api.github.com/users/ashwanidausodia/followers","following_url":"https://api.github.com/users/ashwanidausodia/following{/other_user}","gists_url":"https://api.github.com/users/ashwanidausodia/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwanidausodia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwanidausodia/subscriptions","organizations_url":"https://api.github.com/users/ashwanidausodia/orgs","repos_url":"https://api.github.com/users/ashwanidausodia/repos","events_url":"https://api.github.com/users/ashwanidausodia/events{/privacy}","received_events_url":"https://api.github.com/users/ashwanidausodia/received_events","type":"User","site_admin":false},"body":"* See https://github.com/zetavm/zetavm/issues/83#issuecomment-326764511 for details.  \r\n* I have also added `math.ceil`","created_at":"2017-09-05T16:45:42Z","updated_at":"2017-09-05T17:49:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"876c893e32e4d4c2e1a7b0370ffd14504d76d372","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zetavm/zetavm/pulls/98/commits","review_comments_url":"https://api.github.com/repos/zetavm/zetavm/pulls/98/comments","review_comment_url":"https://api.github.com/repos/zetavm/zetavm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zetavm/zetavm/issues/98/comments","statuses_url":"https://api.github.com/repos/zetavm/zetavm/statuses/5b3a759345a960ef37e1cd22787ea4324142d82a","head":{"label":"ashwanidausodia:map","ref":"map","sha":"5b3a759345a960ef37e1cd22787ea4324142d82a","user":{"login":"ashwanidausodia","id":16511336,"avatar_url":"https://avatars2.githubusercontent.com/u/16511336?v=4","gravatar_id":"","url":"https://api.github.com/users/ashwanidausodia","html_url":"https://github.com/ashwanidausodia","followers_url":"https://api.github.com/users/ashwanidausodia/followers","following_url":"https://api.github.com/users/ashwanidausodia/following{/other_user}","gists_url":"https://api.github.com/users/ashwanidausodia/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwanidausodia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwanidausodia/subscriptions","organizations_url":"https://api.github.com/users/ashwanidausodia/orgs","repos_url":"https://api.github.com/users/ashwanidausodia/repos","events_url":"https://api.github.com/users/ashwanidausodia/events{/privacy}","received_events_url":"https://api.github.com/users/ashwanidausodia/received_events","type":"User","site_admin":false},"repo":{"id":98688804,"name":"zetavm","full_name":"ashwanidausodia/zetavm","owner":{"login":"ashwanidausodia","id":16511336,"avatar_url":"https://avatars2.githubusercontent.com/u/16511336?v=4","gravatar_id":"","url":"https://api.github.com/users/ashwanidausodia","html_url":"https://github.com/ashwanidausodia","followers_url":"https://api.github.com/users/ashwanidausodia/followers","following_url":"https://api.github.com/users/ashwanidausodia/following{/other_user}","gists_url":"https://api.github.com/users/ashwanidausodia/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwanidausodia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwanidausodia/subscriptions","organizations_url":"https://api.github.com/users/ashwanidausodia/orgs","repos_url":"https://api.github.com/users/ashwanidausodia/repos","events_url":"https://api.github.com/users/ashwanidausodia/events{/privacy}","received_events_url":"https://api.github.com/users/ashwanidausodia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashwanidausodia/zetavm","description":"Multi-Language Platform for Dynamic Programming Languages","fork":true,"url":"https://api.github.com/repos/ashwanidausodia/zetavm","forks_url":"https://api.github.com/repos/ashwanidausodia/zetavm/forks","keys_url":"https://api.github.com/repos/ashwanidausodia/zetavm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashwanidausodia/zetavm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashwanidausodia/zetavm/teams","hooks_url":"https://api.github.com/repos/ashwanidausodia/zetavm/hooks","issue_events_url":"https://api.github.com/repos/ashwanidausodia/zetavm/issues/events{/number}","events_url":"https://api.github.com/repos/ashwanidausodia/zetavm/events","assignees_url":"https://api.github.com/repos/ashwanidausodia/zetavm/assignees{/user}","branches_url":"https://api.github.com/repos/ashwanidausodia/zetavm/branches{/branch}","tags_url":"https://api.github.com/repos/ashwanidausodia/zetavm/tags","blobs_url":"https://api.github.com/repos/ashwanidausodia/zetavm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashwanidausodia/zetavm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashwanidausodia/zetavm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashwanidausodia/zetavm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashwanidausodia/zetavm/statuses/{sha}","languages_url":"https://api.github.com/repos/ashwanidausodia/zetavm/languages","stargazers_url":"https://api.github.com/repos/ashwanidausodia/zetavm/stargazers","contributors_url":"https://api.github.com/repos/ashwanidausodia/zetavm/contributors","subscribers_url":"https://api.github.com/repos/ashwanidausodia/zetavm/subscribers","subscription_url":"https://api.github.com/repos/ashwanidausodia/zetavm/subscription","commits_url":"https://api.github.com/repos/ashwanidausodia/zetavm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashwanidausodia/zetavm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashwanidausodia/zetavm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashwanidausodia/zetavm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashwanidausodia/zetavm/contents/{+path}","compare_url":"https://api.github.com/repos/ashwanidausodia/zetavm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashwanidausodia/zetavm/merges","archive_url":"https://api.github.com/repos/ashwanidausodia/zetavm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashwanidausodia/zetavm/downloads","issues_url":"https://api.github.com/repos/ashwanidausodia/zetavm/issues{/number}","pulls_url":"https://api.github.com/repos/ashwanidausodia/zetavm/pulls{/number}","milestones_url":"https://api.github.com/repos/ashwanidausodia/zetavm/milestones{/number}","notifications_url":"https://api.github.com/repos/ashwanidausodia/zetavm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashwanidausodia/zetavm/labels{/name}","releases_url":"https://api.github.com/repos/ashwanidausodia/zetavm/releases{/id}","deployments_url":"https://api.github.com/repos/ashwanidausodia/zetavm/deployments","created_at":"2017-07-28T21:15:33Z","updated_at":"2017-07-28T21:15:35Z","pushed_at":"2017-09-05T16:43:36Z","git_url":"git://github.com/ashwanidausodia/zetavm.git","ssh_url":"git@github.com:ashwanidausodia/zetavm.git","clone_url":"https://github.com/ashwanidausodia/zetavm.git","svn_url":"https://github.com/ashwanidausodia/zetavm","homepage":"https://pointersgonewild.com/category/zeta/","size":1418,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zetavm:master","ref":"master","sha":"f74c02a582d7b781e0f64192f487d642ddce15e8","user":{"login":"zetavm","id":29269338,"avatar_url":"https://avatars0.githubusercontent.com/u/29269338?v=4","gravatar_id":"","url":"https://api.github.com/users/zetavm","html_url":"https://github.com/zetavm","followers_url":"https://api.github.com/users/zetavm/followers","following_url":"https://api.github.com/users/zetavm/following{/other_user}","gists_url":"https://api.github.com/users/zetavm/gists{/gist_id}","starred_url":"https://api.github.com/users/zetavm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetavm/subscriptions","organizations_url":"https://api.github.com/users/zetavm/orgs","repos_url":"https://api.github.com/users/zetavm/repos","events_url":"https://api.github.com/users/zetavm/events{/privacy}","received_events_url":"https://api.github.com/users/zetavm/received_events","type":"Organization","site_admin":false},"repo":{"id":89325203,"name":"zetavm","full_name":"zetavm/zetavm","owner":{"login":"zetavm","id":29269338,"avatar_url":"https://avatars0.githubusercontent.com/u/29269338?v=4","gravatar_id":"","url":"https://api.github.com/users/zetavm","html_url":"https://github.com/zetavm","followers_url":"https://api.github.com/users/zetavm/followers","following_url":"https://api.github.com/users/zetavm/following{/other_user}","gists_url":"https://api.github.com/users/zetavm/gists{/gist_id}","starred_url":"https://api.github.com/users/zetavm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zetavm/subscriptions","organizations_url":"https://api.github.com/users/zetavm/orgs","repos_url":"https://api.github.com/users/zetavm/repos","events_url":"https://api.github.com/users/zetavm/events{/privacy}","received_events_url":"https://api.github.com/users/zetavm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zetavm/zetavm","description":"Multi-Language Platform for Dynamic Programming Languages","fork":false,"url":"https://api.github.com/repos/zetavm/zetavm","forks_url":"https://api.github.com/repos/zetavm/zetavm/forks","keys_url":"https://api.github.com/repos/zetavm/zetavm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zetavm/zetavm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zetavm/zetavm/teams","hooks_url":"https://api.github.com/repos/zetavm/zetavm/hooks","issue_events_url":"https://api.github.com/repos/zetavm/zetavm/issues/events{/number}","events_url":"https://api.github.com/repos/zetavm/zetavm/events","assignees_url":"https://api.github.com/repos/zetavm/zetavm/assignees{/user}","branches_url":"https://api.github.com/repos/zetavm/zetavm/branches{/branch}","tags_url":"https://api.github.com/repos/zetavm/zetavm/tags","blobs_url":"https://api.github.com/repos/zetavm/zetavm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zetavm/zetavm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zetavm/zetavm/git/refs{/sha}","trees_url":"https://api.github.com/repos/zetavm/zetavm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zetavm/zetavm/statuses/{sha}","languages_url":"https://api.github.com/repos/zetavm/zetavm/languages","stargazers_url":"https://api.github.com/repos/zetavm/zetavm/stargazers","contributors_url":"https://api.github.com/repos/zetavm/zetavm/contributors","subscribers_url":"https://api.github.com/repos/zetavm/zetavm/subscribers","subscription_url":"https://api.github.com/repos/zetavm/zetavm/subscription","commits_url":"https://api.github.com/repos/zetavm/zetavm/commits{/sha}","git_commits_url":"https://api.github.com/repos/zetavm/zetavm/git/commits{/sha}","comments_url":"https://api.github.com/repos/zetavm/zetavm/comments{/number}","issue_comment_url":"https://api.github.com/repos/zetavm/zetavm/issues/comments{/number}","contents_url":"https://api.github.com/repos/zetavm/zetavm/contents/{+path}","compare_url":"https://api.github.com/repos/zetavm/zetavm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zetavm/zetavm/merges","archive_url":"https://api.github.com/repos/zetavm/zetavm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zetavm/zetavm/downloads","issues_url":"https://api.github.com/repos/zetavm/zetavm/issues{/number}","pulls_url":"https://api.github.com/repos/zetavm/zetavm/pulls{/number}","milestones_url":"https://api.github.com/repos/zetavm/zetavm/milestones{/number}","notifications_url":"https://api.github.com/repos/zetavm/zetavm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zetavm/zetavm/labels{/name}","releases_url":"https://api.github.com/repos/zetavm/zetavm/releases{/id}","deployments_url":"https://api.github.com/repos/zetavm/zetavm/deployments","created_at":"2017-04-25T06:26:09Z","updated_at":"2017-09-05T13:05:24Z","pushed_at":"2017-09-05T16:45:43Z","git_url":"git://github.com/zetavm/zetavm.git","ssh_url":"git@github.com:zetavm/zetavm.git","clone_url":"https://github.com/zetavm/zetavm.git","svn_url":"https://github.com/zetavm/zetavm","homepage":"https://pointersgonewild.com/category/zeta/","size":910,"stargazers_count":452,"watchers_count":452,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":10,"forks":31,"open_issues":10,"watchers":452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zetavm/zetavm/pulls/98"},"html":{"href":"https://github.com/zetavm/zetavm/pull/98"},"issue":{"href":"https://api.github.com/repos/zetavm/zetavm/issues/98"},"comments":{"href":"https://api.github.com/repos/zetavm/zetavm/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/zetavm/zetavm/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/zetavm/zetavm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zetavm/zetavm/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/zetavm/zetavm/statuses/5b3a759345a960ef37e1cd22787ea4324142d82a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ashwanidausodia"}}