{"action":"opened","number":4624,"pull_request":{"url":"https://api.github.com/repos/bbatsov/rubocop/pulls/4624","id":131941328,"html_url":"https://github.com/bbatsov/rubocop/pull/4624","diff_url":"https://github.com/bbatsov/rubocop/pull/4624.diff","patch_url":"https://github.com/bbatsov/rubocop/pull/4624.patch","issue_url":"https://api.github.com/repos/bbatsov/rubocop/issues/4624","number":4624,"state":"open","locked":false,"title":"Fix #4593 support for Case, Logical AND & Logical OR","user":{"login":"theRealNG","id":5243592,"avatar_url":"https://avatars0.githubusercontent.com/u/5243592?v=4","gravatar_id":"","url":"https://api.github.com/users/theRealNG","html_url":"https://github.com/theRealNG","followers_url":"https://api.github.com/users/theRealNG/followers","following_url":"https://api.github.com/users/theRealNG/following{/other_user}","gists_url":"https://api.github.com/users/theRealNG/gists{/gist_id}","starred_url":"https://api.github.com/users/theRealNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theRealNG/subscriptions","organizations_url":"https://api.github.com/users/theRealNG/orgs","repos_url":"https://api.github.com/users/theRealNG/repos","events_url":"https://api.github.com/users/theRealNG/events{/privacy}","received_events_url":"https://api.github.com/users/theRealNG/received_events","type":"User","site_admin":false},"body":"Add support for 'Case', 'Logical AND' & 'Logical OR' for the\r\nsave_bang cop conditional check\r\n\r\n**Replace this text with a summary of the changes in your PR.\r\nThe more detailed you are, the better.**\r\n\r\n-----------------\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [ ] Wrote [good commit messages][1].\r\n* [ ] Commit message starts with `[Fix #issue-number]` (if the related issue exists).\r\n* [ ] Used the same coding conventions as the rest of the project.\r\n* [ ] Feature branch is up-to-date with `master` (if not - rebase it).\r\n* [ ] Squashed related commits together.\r\n* [ ] Added tests.\r\n* [ ] Added an entry to the [Changelog](../blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [ ] All tests(`rake spec`) are passing.\r\n* [ ] The new code doesn't generate RuboCop offenses that are checked by `rake internal_investigation`.\r\n* [ ] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n* [ ] Updated cop documentation with `rake generate_cops_documentation` (required only when you've added a new cop or changed the configuration/documentation of an existing cop).\r\n\r\n[1]: http://chris.beams.io/posts/git-commit/\r\n","created_at":"2017-07-23T17:07:25Z","updated_at":"2017-07-23T17:07:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/4624/commits","review_comments_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/4624/comments","review_comment_url":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/issues/4624/comments","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/4d3ff29f7794848e5488045980328691c0f4389a","head":{"label":"theRealNG:save_bang_cop_fix","ref":"save_bang_cop_fix","sha":"4d3ff29f7794848e5488045980328691c0f4389a","user":{"login":"theRealNG","id":5243592,"avatar_url":"https://avatars0.githubusercontent.com/u/5243592?v=4","gravatar_id":"","url":"https://api.github.com/users/theRealNG","html_url":"https://github.com/theRealNG","followers_url":"https://api.github.com/users/theRealNG/followers","following_url":"https://api.github.com/users/theRealNG/following{/other_user}","gists_url":"https://api.github.com/users/theRealNG/gists{/gist_id}","starred_url":"https://api.github.com/users/theRealNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theRealNG/subscriptions","organizations_url":"https://api.github.com/users/theRealNG/orgs","repos_url":"https://api.github.com/users/theRealNG/repos","events_url":"https://api.github.com/users/theRealNG/events{/privacy}","received_events_url":"https://api.github.com/users/theRealNG/received_events","type":"User","site_admin":false},"repo":{"id":98060900,"name":"rubocop","full_name":"theRealNG/rubocop","owner":{"login":"theRealNG","id":5243592,"avatar_url":"https://avatars0.githubusercontent.com/u/5243592?v=4","gravatar_id":"","url":"https://api.github.com/users/theRealNG","html_url":"https://github.com/theRealNG","followers_url":"https://api.github.com/users/theRealNG/followers","following_url":"https://api.github.com/users/theRealNG/following{/other_user}","gists_url":"https://api.github.com/users/theRealNG/gists{/gist_id}","starred_url":"https://api.github.com/users/theRealNG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theRealNG/subscriptions","organizations_url":"https://api.github.com/users/theRealNG/orgs","repos_url":"https://api.github.com/users/theRealNG/repos","events_url":"https://api.github.com/users/theRealNG/events{/privacy}","received_events_url":"https://api.github.com/users/theRealNG/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theRealNG/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/theRealNG/rubocop","forks_url":"https://api.github.com/repos/theRealNG/rubocop/forks","keys_url":"https://api.github.com/repos/theRealNG/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theRealNG/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theRealNG/rubocop/teams","hooks_url":"https://api.github.com/repos/theRealNG/rubocop/hooks","issue_events_url":"https://api.github.com/repos/theRealNG/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/theRealNG/rubocop/events","assignees_url":"https://api.github.com/repos/theRealNG/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/theRealNG/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/theRealNG/rubocop/tags","blobs_url":"https://api.github.com/repos/theRealNG/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theRealNG/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theRealNG/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/theRealNG/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theRealNG/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/theRealNG/rubocop/languages","stargazers_url":"https://api.github.com/repos/theRealNG/rubocop/stargazers","contributors_url":"https://api.github.com/repos/theRealNG/rubocop/contributors","subscribers_url":"https://api.github.com/repos/theRealNG/rubocop/subscribers","subscription_url":"https://api.github.com/repos/theRealNG/rubocop/subscription","commits_url":"https://api.github.com/repos/theRealNG/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/theRealNG/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/theRealNG/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/theRealNG/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/theRealNG/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/theRealNG/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theRealNG/rubocop/merges","archive_url":"https://api.github.com/repos/theRealNG/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theRealNG/rubocop/downloads","issues_url":"https://api.github.com/repos/theRealNG/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/theRealNG/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/theRealNG/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/theRealNG/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theRealNG/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/theRealNG/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/theRealNG/rubocop/deployments","created_at":"2017-07-22T22:19:03Z","updated_at":"2017-07-22T22:19:08Z","pushed_at":"2017-07-23T17:06:42Z","git_url":"git://github.com/theRealNG/rubocop.git","ssh_url":"git@github.com:theRealNG/rubocop.git","clone_url":"https://github.com/theRealNG/rubocop.git","svn_url":"https://github.com/theRealNG/rubocop","homepage":"http://rubocop.readthedocs.io","size":16521,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bbatsov:master","ref":"master","sha":"f38aa50e9654f69ee13b9cd6f81c9c70aba05eff","user":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"repo":{"id":4095287,"name":"rubocop","full_name":"bbatsov/rubocop","owner":{"login":"bbatsov","id":103882,"avatar_url":"https://avatars0.githubusercontent.com/u/103882?v=4","gravatar_id":"","url":"https://api.github.com/users/bbatsov","html_url":"https://github.com/bbatsov","followers_url":"https://api.github.com/users/bbatsov/followers","following_url":"https://api.github.com/users/bbatsov/following{/other_user}","gists_url":"https://api.github.com/users/bbatsov/gists{/gist_id}","starred_url":"https://api.github.com/users/bbatsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbatsov/subscriptions","organizations_url":"https://api.github.com/users/bbatsov/orgs","repos_url":"https://api.github.com/users/bbatsov/repos","events_url":"https://api.github.com/users/bbatsov/events{/privacy}","received_events_url":"https://api.github.com/users/bbatsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbatsov/rubocop","description":"A Ruby static code analyzer, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/bbatsov/rubocop","forks_url":"https://api.github.com/repos/bbatsov/rubocop/forks","keys_url":"https://api.github.com/repos/bbatsov/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbatsov/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbatsov/rubocop/teams","hooks_url":"https://api.github.com/repos/bbatsov/rubocop/hooks","issue_events_url":"https://api.github.com/repos/bbatsov/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/bbatsov/rubocop/events","assignees_url":"https://api.github.com/repos/bbatsov/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/bbatsov/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/bbatsov/rubocop/tags","blobs_url":"https://api.github.com/repos/bbatsov/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbatsov/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbatsov/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbatsov/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbatsov/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/bbatsov/rubocop/languages","stargazers_url":"https://api.github.com/repos/bbatsov/rubocop/stargazers","contributors_url":"https://api.github.com/repos/bbatsov/rubocop/contributors","subscribers_url":"https://api.github.com/repos/bbatsov/rubocop/subscribers","subscription_url":"https://api.github.com/repos/bbatsov/rubocop/subscription","commits_url":"https://api.github.com/repos/bbatsov/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbatsov/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbatsov/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbatsov/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbatsov/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/bbatsov/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbatsov/rubocop/merges","archive_url":"https://api.github.com/repos/bbatsov/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbatsov/rubocop/downloads","issues_url":"https://api.github.com/repos/bbatsov/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/bbatsov/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/bbatsov/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/bbatsov/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbatsov/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/bbatsov/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/bbatsov/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2017-07-23T14:43:40Z","pushed_at":"2017-07-23T05:32:23Z","git_url":"git://github.com/bbatsov/rubocop.git","ssh_url":"git@github.com:bbatsov/rubocop.git","clone_url":"https://github.com/bbatsov/rubocop.git","svn_url":"https://github.com/bbatsov/rubocop","homepage":"http://rubocop.readthedocs.io","size":16602,"stargazers_count":7862,"watchers_count":7862,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1396,"mirror_url":null,"open_issues_count":242,"forks":1396,"open_issues":242,"watchers":7862,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/4624"},"html":{"href":"https://github.com/bbatsov/rubocop/pull/4624"},"issue":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/4624"},"comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/issues/4624/comments"},"review_comments":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/4624/comments"},"review_comment":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbatsov/rubocop/pulls/4624/commits"},"statuses":{"href":"https://api.github.com/repos/bbatsov/rubocop/statuses/4d3ff29f7794848e5488045980328691c0f4389a"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":47,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"theRealNG"}}