{"action":"created","issue":{"url":"https://api.github.com/repos/UUPharmacometrics/xpose/issues/72","repository_url":"https://api.github.com/repos/UUPharmacometrics/xpose","labels_url":"https://api.github.com/repos/UUPharmacometrics/xpose/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/UUPharmacometrics/xpose/issues/72/comments","events_url":"https://api.github.com/repos/UUPharmacometrics/xpose/issues/72/events","html_url":"https://github.com/UUPharmacometrics/xpose/pull/72","id":275436156,"number":72,"title":"remove ggforce dependency","user":{"login":"dpastoor","id":3196313,"avatar_url":"https://avatars0.githubusercontent.com/u/3196313?v=4","gravatar_id":"","url":"https://api.github.com/users/dpastoor","html_url":"https://github.com/dpastoor","followers_url":"https://api.github.com/users/dpastoor/followers","following_url":"https://api.github.com/users/dpastoor/following{/other_user}","gists_url":"https://api.github.com/users/dpastoor/gists{/gist_id}","starred_url":"https://api.github.com/users/dpastoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpastoor/subscriptions","organizations_url":"https://api.github.com/users/dpastoor/orgs","repos_url":"https://api.github.com/users/dpastoor/repos","events_url":"https://api.github.com/users/dpastoor/events{/privacy}","received_events_url":"https://api.github.com/users/dpastoor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-20T17:26:08Z","updated_at":"2017-11-20T17:50:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/UUPharmacometrics/xpose/pulls/72","html_url":"https://github.com/UUPharmacometrics/xpose/pull/72","diff_url":"https://github.com/UUPharmacometrics/xpose/pull/72.diff","patch_url":"https://github.com/UUPharmacometrics/xpose/pull/72.patch"},"body":"ggforce is actually a pretty huge dependency. On top of that, it that is a blocker for larger organizations with HPC's with older R versions (eg AZ is on 3.2.4).\r\n\r\nThe ggforce dependency tree ends up introducing system dependencies such as V8 (due to concaveman), R 3.3 (sf) and the list goes on. Given the only need for ggforce is the pagination functions, these can instead be factored out and placed directly in this package to remove the dependency.\r\n\r\nThis PR lowers the R dependency requirement to below 3.3, and also completely removes the ggforce dep tree.\r\n\r\nRerunning the pagination tests shows all still pass."},"comment":{"url":"https://api.github.com/repos/UUPharmacometrics/xpose/issues/comments/345774334","html_url":"https://github.com/UUPharmacometrics/xpose/pull/72#issuecomment-345774334","issue_url":"https://api.github.com/repos/UUPharmacometrics/xpose/issues/72","id":345774334,"user":{"login":"mattfidler","id":514778,"avatar_url":"https://avatars1.githubusercontent.com/u/514778?v=4","gravatar_id":"","url":"https://api.github.com/users/mattfidler","html_url":"https://github.com/mattfidler","followers_url":"https://api.github.com/users/mattfidler/followers","following_url":"https://api.github.com/users/mattfidler/following{/other_user}","gists_url":"https://api.github.com/users/mattfidler/gists{/gist_id}","starred_url":"https://api.github.com/users/mattfidler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattfidler/subscriptions","organizations_url":"https://api.github.com/users/mattfidler/orgs","repos_url":"https://api.github.com/users/mattfidler/repos","events_url":"https://api.github.com/users/mattfidler/events{/privacy}","received_events_url":"https://api.github.com/users/mattfidler/received_events","type":"User","site_admin":false},"created_at":"2017-11-20T17:50:43Z","updated_at":"2017-11-20T17:50:43Z","author_association":"NONE","body":"Novartis also uses 3.2, I think that is would be good to remove ggforce"}}
{"actor":{"display_login":"mattfidler"}}