{"action":"created","comment":{"url":"https://api.github.com/repos/goldshtn/etrace/pulls/comments/96115809","pull_request_review_id":16694088,"id":96115809,"diff_hunk":"@@ -87,6 +87,9 @@ public string Usage()\n             help.AddPostOptionsLine(\"  etrace --file trace.etl --stats\");\n             help.AddPostOptionsLine(\"  etrace --clr GC --event GC/Start --field PID,TID,Reason[12],Type\");\n             help.AddPostOptionsLine(\"  etrace --kernel Process --event Process/Start --where ImageFileName=myapp\");\n+            help.AddPostOptionsLine(\"  etrace --kernel Process --event --where ProcessId=4\");\n+            help.AddPostOptionsLine(\"  etrace --kernel Process --event --where ProcessName=myProcessName\");","path":"etrace/Options.cs","position":5,"original_position":5,"commit_id":"a7d6309a14225068b1ac079cf8b403eea86dc4ac","original_commit_id":"a7d6309a14225068b1ac079cf8b403eea86dc4ac","user":{"login":"goldshtn","id":1685437,"avatar_url":"https://avatars.githubusercontent.com/u/1685437?v=3","gravatar_id":"","url":"https://api.github.com/users/goldshtn","html_url":"https://github.com/goldshtn","followers_url":"https://api.github.com/users/goldshtn/followers","following_url":"https://api.github.com/users/goldshtn/following{/other_user}","gists_url":"https://api.github.com/users/goldshtn/gists{/gist_id}","starred_url":"https://api.github.com/users/goldshtn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldshtn/subscriptions","organizations_url":"https://api.github.com/users/goldshtn/orgs","repos_url":"https://api.github.com/users/goldshtn/repos","events_url":"https://api.github.com/users/goldshtn/events{/privacy}","received_events_url":"https://api.github.com/users/goldshtn/received_events","type":"User","site_admin":false},"body":"Same comment here.","created_at":"2017-01-14T13:37:11Z","updated_at":"2017-01-14T13:37:19Z","html_url":"https://github.com/goldshtn/etrace/pull/6#discussion_r96115809","pull_request_url":"https://api.github.com/repos/goldshtn/etrace/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/goldshtn/etrace/pulls/comments/96115809"},"html":{"href":"https://github.com/goldshtn/etrace/pull/6#discussion_r96115809"},"pull_request":{"href":"https://api.github.com/repos/goldshtn/etrace/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/goldshtn/etrace/pulls/6","id":101554085,"html_url":"https://github.com/goldshtn/etrace/pull/6","diff_url":"https://github.com/goldshtn/etrace/pull/6.diff","patch_url":"https://github.com/goldshtn/etrace/pull/6.patch","issue_url":"https://api.github.com/repos/goldshtn/etrace/issues/6","number":6,"state":"open","locked":false,"title":"Issue#1 - Add filtering by process id or thread id","user":{"login":"Pavel-Durov","id":6065236,"avatar_url":"https://avatars.githubusercontent.com/u/6065236?v=3","gravatar_id":"","url":"https://api.github.com/users/Pavel-Durov","html_url":"https://github.com/Pavel-Durov","followers_url":"https://api.github.com/users/Pavel-Durov/followers","following_url":"https://api.github.com/users/Pavel-Durov/following{/other_user}","gists_url":"https://api.github.com/users/Pavel-Durov/gists{/gist_id}","starred_url":"https://api.github.com/users/Pavel-Durov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pavel-Durov/subscriptions","organizations_url":"https://api.github.com/users/Pavel-Durov/orgs","repos_url":"https://api.github.com/users/Pavel-Durov/repos","events_url":"https://api.github.com/users/Pavel-Durov/events{/privacy}","received_events_url":"https://api.github.com/users/Pavel-Durov/received_events","type":"User","site_admin":false},"body":"Added support for event filtering using --where verb, example:\r\n \r\n--kernel Process --event --where ProcessName=\"<your-process-name>\" \r\n --kernel Process --event --where ThreadId=\"<your-thread-Id>\"\r\n --kernel Process --event --where ProcessId=\"<your-process-Id>\"\r\n \r\nHowever, the filters doesn't depend one on another, for exmple:\r\n --kernel Process --event --where ProcessId=\"<your-process-Id>\" ThreadId=\"<threadId>\"\r\nwill generate the same output as \r\n --kernel Process --event --where ProcessId=\"<your-process-Id>\"\r\n* Because it will match ProcessId is both filters.\r\n\r\nDoes this functionality required?\r\n","created_at":"2017-01-14T07:51:22Z","updated_at":"2017-01-14T13:37:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84b152b55f96809b20abc2b704b7e3beca95f2ab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/goldshtn/etrace/pulls/6/commits","review_comments_url":"https://api.github.com/repos/goldshtn/etrace/pulls/6/comments","review_comment_url":"https://api.github.com/repos/goldshtn/etrace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goldshtn/etrace/issues/6/comments","statuses_url":"https://api.github.com/repos/goldshtn/etrace/statuses/a7d6309a14225068b1ac079cf8b403eea86dc4ac","head":{"label":"Pavel-Durov:master","ref":"master","sha":"a7d6309a14225068b1ac079cf8b403eea86dc4ac","user":{"login":"Pavel-Durov","id":6065236,"avatar_url":"https://avatars.githubusercontent.com/u/6065236?v=3","gravatar_id":"","url":"https://api.github.com/users/Pavel-Durov","html_url":"https://github.com/Pavel-Durov","followers_url":"https://api.github.com/users/Pavel-Durov/followers","following_url":"https://api.github.com/users/Pavel-Durov/following{/other_user}","gists_url":"https://api.github.com/users/Pavel-Durov/gists{/gist_id}","starred_url":"https://api.github.com/users/Pavel-Durov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pavel-Durov/subscriptions","organizations_url":"https://api.github.com/users/Pavel-Durov/orgs","repos_url":"https://api.github.com/users/Pavel-Durov/repos","events_url":"https://api.github.com/users/Pavel-Durov/events{/privacy}","received_events_url":"https://api.github.com/users/Pavel-Durov/received_events","type":"User","site_admin":false},"repo":{"id":77612240,"name":"etrace","full_name":"Pavel-Durov/etrace","owner":{"login":"Pavel-Durov","id":6065236,"avatar_url":"https://avatars.githubusercontent.com/u/6065236?v=3","gravatar_id":"","url":"https://api.github.com/users/Pavel-Durov","html_url":"https://github.com/Pavel-Durov","followers_url":"https://api.github.com/users/Pavel-Durov/followers","following_url":"https://api.github.com/users/Pavel-Durov/following{/other_user}","gists_url":"https://api.github.com/users/Pavel-Durov/gists{/gist_id}","starred_url":"https://api.github.com/users/Pavel-Durov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pavel-Durov/subscriptions","organizations_url":"https://api.github.com/users/Pavel-Durov/orgs","repos_url":"https://api.github.com/users/Pavel-Durov/repos","events_url":"https://api.github.com/users/Pavel-Durov/events{/privacy}","received_events_url":"https://api.github.com/users/Pavel-Durov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Pavel-Durov/etrace","description":"Command-line tool for ETW tracing on files and real-time events","fork":true,"url":"https://api.github.com/repos/Pavel-Durov/etrace","forks_url":"https://api.github.com/repos/Pavel-Durov/etrace/forks","keys_url":"https://api.github.com/repos/Pavel-Durov/etrace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Pavel-Durov/etrace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Pavel-Durov/etrace/teams","hooks_url":"https://api.github.com/repos/Pavel-Durov/etrace/hooks","issue_events_url":"https://api.github.com/repos/Pavel-Durov/etrace/issues/events{/number}","events_url":"https://api.github.com/repos/Pavel-Durov/etrace/events","assignees_url":"https://api.github.com/repos/Pavel-Durov/etrace/assignees{/user}","branches_url":"https://api.github.com/repos/Pavel-Durov/etrace/branches{/branch}","tags_url":"https://api.github.com/repos/Pavel-Durov/etrace/tags","blobs_url":"https://api.github.com/repos/Pavel-Durov/etrace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Pavel-Durov/etrace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Pavel-Durov/etrace/git/refs{/sha}","trees_url":"https://api.github.com/repos/Pavel-Durov/etrace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Pavel-Durov/etrace/statuses/{sha}","languages_url":"https://api.github.com/repos/Pavel-Durov/etrace/languages","stargazers_url":"https://api.github.com/repos/Pavel-Durov/etrace/stargazers","contributors_url":"https://api.github.com/repos/Pavel-Durov/etrace/contributors","subscribers_url":"https://api.github.com/repos/Pavel-Durov/etrace/subscribers","subscription_url":"https://api.github.com/repos/Pavel-Durov/etrace/subscription","commits_url":"https://api.github.com/repos/Pavel-Durov/etrace/commits{/sha}","git_commits_url":"https://api.github.com/repos/Pavel-Durov/etrace/git/commits{/sha}","comments_url":"https://api.github.com/repos/Pavel-Durov/etrace/comments{/number}","issue_comment_url":"https://api.github.com/repos/Pavel-Durov/etrace/issues/comments{/number}","contents_url":"https://api.github.com/repos/Pavel-Durov/etrace/contents/{+path}","compare_url":"https://api.github.com/repos/Pavel-Durov/etrace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Pavel-Durov/etrace/merges","archive_url":"https://api.github.com/repos/Pavel-Durov/etrace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Pavel-Durov/etrace/downloads","issues_url":"https://api.github.com/repos/Pavel-Durov/etrace/issues{/number}","pulls_url":"https://api.github.com/repos/Pavel-Durov/etrace/pulls{/number}","milestones_url":"https://api.github.com/repos/Pavel-Durov/etrace/milestones{/number}","notifications_url":"https://api.github.com/repos/Pavel-Durov/etrace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Pavel-Durov/etrace/labels{/name}","releases_url":"https://api.github.com/repos/Pavel-Durov/etrace/releases{/id}","deployments_url":"https://api.github.com/repos/Pavel-Durov/etrace/deployments","created_at":"2016-12-29T12:56:44Z","updated_at":"2016-12-29T12:56:46Z","pushed_at":"2017-01-14T11:38:06Z","git_url":"git://github.com/Pavel-Durov/etrace.git","ssh_url":"git@github.com:Pavel-Durov/etrace.git","clone_url":"https://github.com/Pavel-Durov/etrace.git","svn_url":"https://github.com/Pavel-Durov/etrace","homepage":null,"size":19,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"goldshtn:master","ref":"master","sha":"b33e36859fcfd84549bf313baf8db037a18f60c7","user":{"login":"goldshtn","id":1685437,"avatar_url":"https://avatars.githubusercontent.com/u/1685437?v=3","gravatar_id":"","url":"https://api.github.com/users/goldshtn","html_url":"https://github.com/goldshtn","followers_url":"https://api.github.com/users/goldshtn/followers","following_url":"https://api.github.com/users/goldshtn/following{/other_user}","gists_url":"https://api.github.com/users/goldshtn/gists{/gist_id}","starred_url":"https://api.github.com/users/goldshtn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldshtn/subscriptions","organizations_url":"https://api.github.com/users/goldshtn/orgs","repos_url":"https://api.github.com/users/goldshtn/repos","events_url":"https://api.github.com/users/goldshtn/events{/privacy}","received_events_url":"https://api.github.com/users/goldshtn/received_events","type":"User","site_admin":false},"repo":{"id":68438975,"name":"etrace","full_name":"goldshtn/etrace","owner":{"login":"goldshtn","id":1685437,"avatar_url":"https://avatars.githubusercontent.com/u/1685437?v=3","gravatar_id":"","url":"https://api.github.com/users/goldshtn","html_url":"https://github.com/goldshtn","followers_url":"https://api.github.com/users/goldshtn/followers","following_url":"https://api.github.com/users/goldshtn/following{/other_user}","gists_url":"https://api.github.com/users/goldshtn/gists{/gist_id}","starred_url":"https://api.github.com/users/goldshtn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goldshtn/subscriptions","organizations_url":"https://api.github.com/users/goldshtn/orgs","repos_url":"https://api.github.com/users/goldshtn/repos","events_url":"https://api.github.com/users/goldshtn/events{/privacy}","received_events_url":"https://api.github.com/users/goldshtn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goldshtn/etrace","description":"Command-line tool for ETW tracing on files and real-time events","fork":false,"url":"https://api.github.com/repos/goldshtn/etrace","forks_url":"https://api.github.com/repos/goldshtn/etrace/forks","keys_url":"https://api.github.com/repos/goldshtn/etrace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goldshtn/etrace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goldshtn/etrace/teams","hooks_url":"https://api.github.com/repos/goldshtn/etrace/hooks","issue_events_url":"https://api.github.com/repos/goldshtn/etrace/issues/events{/number}","events_url":"https://api.github.com/repos/goldshtn/etrace/events","assignees_url":"https://api.github.com/repos/goldshtn/etrace/assignees{/user}","branches_url":"https://api.github.com/repos/goldshtn/etrace/branches{/branch}","tags_url":"https://api.github.com/repos/goldshtn/etrace/tags","blobs_url":"https://api.github.com/repos/goldshtn/etrace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goldshtn/etrace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goldshtn/etrace/git/refs{/sha}","trees_url":"https://api.github.com/repos/goldshtn/etrace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goldshtn/etrace/statuses/{sha}","languages_url":"https://api.github.com/repos/goldshtn/etrace/languages","stargazers_url":"https://api.github.com/repos/goldshtn/etrace/stargazers","contributors_url":"https://api.github.com/repos/goldshtn/etrace/contributors","subscribers_url":"https://api.github.com/repos/goldshtn/etrace/subscribers","subscription_url":"https://api.github.com/repos/goldshtn/etrace/subscription","commits_url":"https://api.github.com/repos/goldshtn/etrace/commits{/sha}","git_commits_url":"https://api.github.com/repos/goldshtn/etrace/git/commits{/sha}","comments_url":"https://api.github.com/repos/goldshtn/etrace/comments{/number}","issue_comment_url":"https://api.github.com/repos/goldshtn/etrace/issues/comments{/number}","contents_url":"https://api.github.com/repos/goldshtn/etrace/contents/{+path}","compare_url":"https://api.github.com/repos/goldshtn/etrace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goldshtn/etrace/merges","archive_url":"https://api.github.com/repos/goldshtn/etrace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goldshtn/etrace/downloads","issues_url":"https://api.github.com/repos/goldshtn/etrace/issues{/number}","pulls_url":"https://api.github.com/repos/goldshtn/etrace/pulls{/number}","milestones_url":"https://api.github.com/repos/goldshtn/etrace/milestones{/number}","notifications_url":"https://api.github.com/repos/goldshtn/etrace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goldshtn/etrace/labels{/name}","releases_url":"https://api.github.com/repos/goldshtn/etrace/releases{/id}","deployments_url":"https://api.github.com/repos/goldshtn/etrace/deployments","created_at":"2016-09-17T07:44:56Z","updated_at":"2017-01-08T02:51:49Z","pushed_at":"2017-01-14T11:38:08Z","git_url":"git://github.com/goldshtn/etrace.git","ssh_url":"git@github.com:goldshtn/etrace.git","clone_url":"https://github.com/goldshtn/etrace.git","svn_url":"https://github.com/goldshtn/etrace","homepage":null,"size":16,"stargazers_count":55,"watchers_count":55,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":7,"forks":12,"open_issues":7,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goldshtn/etrace/pulls/6"},"html":{"href":"https://github.com/goldshtn/etrace/pull/6"},"issue":{"href":"https://api.github.com/repos/goldshtn/etrace/issues/6"},"comments":{"href":"https://api.github.com/repos/goldshtn/etrace/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/goldshtn/etrace/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/goldshtn/etrace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goldshtn/etrace/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/goldshtn/etrace/statuses/a7d6309a14225068b1ac079cf8b403eea86dc4ac"}}}}
{"actor":{"display_login":"goldshtn"}}