{"action":"created","comment":{"url":"https://api.github.com/repos/0xProject/0x.js/pulls/comments/136011109","pull_request_review_id":59489114,"id":136011109,"diff_hunk":"@@ -163,6 +163,12 @@ export class ZeroEx {\n      * @return  An instance of the 0x.js ZeroEx class.\n      */\n     constructor(provider: Web3Provider, config?: ZeroExConfig) {\n+        if (_.isUndefined((provider as any).sendAsync)) {","path":"src/0x.ts","position":4,"original_position":4,"commit_id":"130a7967aa9c0e4fba5147e5a9c78516b91f78a8","original_commit_id":"a98bb1f7ac2ab02115a28ace15e94ed14d2cf861","user":{"login":"fabioberger","id":2151492,"avatar_url":"https://avatars2.githubusercontent.com/u/2151492?v=4","gravatar_id":"","url":"https://api.github.com/users/fabioberger","html_url":"https://github.com/fabioberger","followers_url":"https://api.github.com/users/fabioberger/followers","following_url":"https://api.github.com/users/fabioberger/following{/other_user}","gists_url":"https://api.github.com/users/fabioberger/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioberger/subscriptions","organizations_url":"https://api.github.com/users/fabioberger/orgs","repos_url":"https://api.github.com/users/fabioberger/repos","events_url":"https://api.github.com/users/fabioberger/events{/privacy}","received_events_url":"https://api.github.com/users/fabioberger/received_events","type":"User","site_admin":false},"body":"If the user passes in something that is **not** a provider, it also won't have the `sendAsync` method. It will also not have the `send` method. We need to also check if it has the `send` method, otherwise we want to throw a helpful error message about how an invalid provider was supplied. Maybe:\r\n\r\n```\r\nInvalid `provider` supplied to ZeroEx constructor. A provider must have a `send` or `sendAsync` method in order to be valid.\r\n```","created_at":"2017-08-30T08:59:57Z","updated_at":"2017-08-30T09:03:19Z","html_url":"https://github.com/0xProject/0x.js/pull/142#discussion_r136011109","pull_request_url":"https://api.github.com/repos/0xProject/0x.js/pulls/142","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/comments/136011109"},"html":{"href":"https://github.com/0xProject/0x.js/pull/142#discussion_r136011109"},"pull_request":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/0xProject/0x.js/pulls/142","id":138367081,"html_url":"https://github.com/0xProject/0x.js/pull/142","diff_url":"https://github.com/0xProject/0x.js/pull/142.diff","patch_url":"https://github.com/0xProject/0x.js/pull/142.patch","issue_url":"https://api.github.com/repos/0xProject/0x.js/issues/142","number":142,"state":"open","locked":false,"title":"Feature/support web3@1.0 provider","user":{"login":"LogvinovLeon","id":6204356,"avatar_url":"https://avatars1.githubusercontent.com/u/6204356?v=4","gravatar_id":"","url":"https://api.github.com/users/LogvinovLeon","html_url":"https://github.com/LogvinovLeon","followers_url":"https://api.github.com/users/LogvinovLeon/followers","following_url":"https://api.github.com/users/LogvinovLeon/following{/other_user}","gists_url":"https://api.github.com/users/LogvinovLeon/gists{/gist_id}","starred_url":"https://api.github.com/users/LogvinovLeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LogvinovLeon/subscriptions","organizations_url":"https://api.github.com/users/LogvinovLeon/orgs","repos_url":"https://api.github.com/users/LogvinovLeon/repos","events_url":"https://api.github.com/users/LogvinovLeon/events{/privacy}","received_events_url":"https://api.github.com/users/LogvinovLeon/received_events","type":"User","site_admin":false},"body":"This PR:\r\n* Starts supporting web3@1.0 providers and adds a test for it.\r\n","created_at":"2017-08-30T08:38:41Z","updated_at":"2017-08-30T09:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0efe56583968ad232ac93336c94973020fceb0a1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/0xProject/0x.js/pulls/142/commits","review_comments_url":"https://api.github.com/repos/0xProject/0x.js/pulls/142/comments","review_comment_url":"https://api.github.com/repos/0xProject/0x.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xProject/0x.js/issues/142/comments","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/130a7967aa9c0e4fba5147e5a9c78516b91f78a8","head":{"label":"0xProject:feature/support_web3@1.0_provider","ref":"feature/support_web3@1.0_provider","sha":"130a7967aa9c0e4fba5147e5a9c78516b91f78a8","user":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"name":"0x.js","full_name":"0xProject/0x.js","owner":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/0x.js","description":"A JavaScript library for interacting with the 0x protocol","fork":false,"url":"https://api.github.com/repos/0xProject/0x.js","forks_url":"https://api.github.com/repos/0xProject/0x.js/forks","keys_url":"https://api.github.com/repos/0xProject/0x.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x.js/teams","hooks_url":"https://api.github.com/repos/0xProject/0x.js/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x.js/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x.js/events","assignees_url":"https://api.github.com/repos/0xProject/0x.js/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x.js/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x.js/tags","blobs_url":"https://api.github.com/repos/0xProject/0x.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x.js/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x.js/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x.js/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x.js/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x.js/subscription","commits_url":"https://api.github.com/repos/0xProject/0x.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x.js/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x.js/merges","archive_url":"https://api.github.com/repos/0xProject/0x.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x.js/downloads","issues_url":"https://api.github.com/repos/0xProject/0x.js/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x.js/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x.js/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x.js/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x.js/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x.js/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2017-08-28T18:03:48Z","pushed_at":"2017-08-30T08:56:53Z","git_url":"git://github.com/0xProject/0x.js.git","ssh_url":"git@github.com:0xProject/0x.js.git","clone_url":"https://github.com/0xProject/0x.js.git","svn_url":"https://github.com/0xProject/0x.js","homepage":"","size":1341,"stargazers_count":97,"watchers_count":97,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":8,"forks":11,"open_issues":8,"watchers":97,"default_branch":"development"}},"base":{"label":"0xProject:development","ref":"development","sha":"6e34cf2c3bdba83460fc4356ec2e62e712119ec9","user":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"name":"0x.js","full_name":"0xProject/0x.js","owner":{"login":"0xProject","id":24832717,"avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/0xProject/0x.js","description":"A JavaScript library for interacting with the 0x protocol","fork":false,"url":"https://api.github.com/repos/0xProject/0x.js","forks_url":"https://api.github.com/repos/0xProject/0x.js/forks","keys_url":"https://api.github.com/repos/0xProject/0x.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x.js/teams","hooks_url":"https://api.github.com/repos/0xProject/0x.js/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x.js/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x.js/events","assignees_url":"https://api.github.com/repos/0xProject/0x.js/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x.js/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x.js/tags","blobs_url":"https://api.github.com/repos/0xProject/0x.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x.js/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x.js/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x.js/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x.js/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x.js/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x.js/subscription","commits_url":"https://api.github.com/repos/0xProject/0x.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x.js/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x.js/merges","archive_url":"https://api.github.com/repos/0xProject/0x.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x.js/downloads","issues_url":"https://api.github.com/repos/0xProject/0x.js/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x.js/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x.js/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x.js/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x.js/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x.js/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2017-08-28T18:03:48Z","pushed_at":"2017-08-30T08:56:53Z","git_url":"git://github.com/0xProject/0x.js.git","ssh_url":"git@github.com:0xProject/0x.js.git","clone_url":"https://github.com/0xProject/0x.js.git","svn_url":"https://github.com/0xProject/0x.js","homepage":"","size":1341,"stargazers_count":97,"watchers_count":97,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":8,"forks":11,"open_issues":8,"watchers":97,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/142"},"html":{"href":"https://github.com/0xProject/0x.js/pull/142"},"issue":{"href":"https://api.github.com/repos/0xProject/0x.js/issues/142"},"comments":{"href":"https://api.github.com/repos/0xProject/0x.js/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xProject/0x.js/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/0xProject/0x.js/statuses/130a7967aa9c0e4fba5147e5a9c78516b91f78a8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fabioberger"}}