{"action":"created","issue":{"url":"https://api.github.com/repos/mirage/mirage-platform/issues/128","repository_url":"https://api.github.com/repos/mirage/mirage-platform","labels_url":"https://api.github.com/repos/mirage/mirage-platform/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/mirage/mirage-platform/issues/128/comments","events_url":"https://api.github.com/repos/mirage/mirage-platform/issues/128/events","html_url":"https://github.com/mirage/mirage-platform/issues/128","id":62811293,"number":128,"title":"CFLAGS confusion","user":{"login":"hannesm","id":228456,"avatar_url":"https://avatars1.githubusercontent.com/u/228456?v=4","gravatar_id":"","url":"https://api.github.com/users/hannesm","html_url":"https://github.com/hannesm","followers_url":"https://api.github.com/users/hannesm/followers","following_url":"https://api.github.com/users/hannesm/following{/other_user}","gists_url":"https://api.github.com/users/hannesm/gists{/gist_id}","starred_url":"https://api.github.com/users/hannesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannesm/subscriptions","organizations_url":"https://api.github.com/users/hannesm/orgs","repos_url":"https://api.github.com/users/hannesm/repos","events_url":"https://api.github.com/users/hannesm/events{/privacy}","received_events_url":"https://api.github.com/users/hannesm/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2015-03-18T21:48:19Z","updated_at":"2017-11-18T00:51:03Z","closed_at":"2017-11-18T00:51:03Z","author_association":"OWNER","body":"MiniOS exports (via `pkg-config`) some [CFLAGS](https://github.com/talex5/xen/blob/8a5fbc92726858a965ca485ce40b72215f79b3c3/extras/mini-os/libminios-xen.pc.in#L10) (using `ARCH_CFLAGS`) -- more precisely [x86](https://github.com/talex5/xen/blob/8a5fbc92726858a965ca485ce40b72215f79b3c3/extras/mini-os/arch/x86/arch.mk) and [arm](https://github.com/talex5/xen/blob/8a5fbc92726858a965ca485ce40b72215f79b3c3/extras/mini-os/arch/arm/arch.mk)\n- [ ] MiniOS is built with `DEF_FLAGS`, which does not include any optimization level\n- [ ] [bindings](https://github.com/mirage/mirage-platform/blob/master/bindings/build.sh#L12), [xen-ocaml](https://github.com/mirage/mirage-platform/blob/master/xen-ocaml/build.sh#L7-L22), and [xen-posix](https://github.com/mirage/mirage-platform/blob/master/xen-posix/build.sh#L7-L27) repeat parts of the logic (esp `-fno-stack-protector`, which should be exported from MiniOS) and define some custom CFLAGS... shouldn't this be more unified (and use `pkg-config`)?\n- [ ] we should use a good optimization level (or does something not compile with -O3?)\n"},"comment":{"url":"https://api.github.com/repos/mirage/mirage-platform/issues/comments/345403966","html_url":"https://github.com/mirage/mirage-platform/issues/128#issuecomment-345403966","issue_url":"https://api.github.com/repos/mirage/mirage-platform/issues/128","id":345403966,"user":{"login":"yomimono","id":4086825,"avatar_url":"https://avatars2.githubusercontent.com/u/4086825?v=4","gravatar_id":"","url":"https://api.github.com/users/yomimono","html_url":"https://github.com/yomimono","followers_url":"https://api.github.com/users/yomimono/followers","following_url":"https://api.github.com/users/yomimono/following{/other_user}","gists_url":"https://api.github.com/users/yomimono/gists{/gist_id}","starred_url":"https://api.github.com/users/yomimono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomimono/subscriptions","organizations_url":"https://api.github.com/users/yomimono/orgs","repos_url":"https://api.github.com/users/yomimono/repos","events_url":"https://api.github.com/users/yomimono/events{/privacy}","received_events_url":"https://api.github.com/users/yomimono/received_events","type":"User","site_admin":false},"created_at":"2017-11-18T00:51:03Z","updated_at":"2017-11-18T00:51:03Z","author_association":"OWNER","body":"I'm going to close this out although I'm not sure whether it has any outstanding items for action or discussion; please feel free to reopen it if there's something that isn't addressed."}}
{"actor":{"display_login":"yomimono"}}