{"action":"created","issue":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/372","repository_url":"https://api.github.com/repos/sxs-collaboration/spectre","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/372/labels{/name}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/372/comments","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/372/events","html_url":"https://github.com/sxs-collaboration/spectre/pull/372","id":274763729,"number":372,"title":"Add compute inverse spacetime metric, derivs of metric and christoffel. ","user":{"login":"osheamonn","id":13049958,"avatar_url":"https://avatars0.githubusercontent.com/u/13049958?v=4","gravatar_id":"","url":"https://api.github.com/users/osheamonn","html_url":"https://github.com/osheamonn","followers_url":"https://api.github.com/users/osheamonn/followers","following_url":"https://api.github.com/users/osheamonn/following{/other_user}","gists_url":"https://api.github.com/users/osheamonn/gists{/gist_id}","starred_url":"https://api.github.com/users/osheamonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheamonn/subscriptions","organizations_url":"https://api.github.com/users/osheamonn/orgs","repos_url":"https://api.github.com/users/osheamonn/repos","events_url":"https://api.github.com/users/osheamonn/events{/privacy}","received_events_url":"https://api.github.com/users/osheamonn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-17T06:24:02Z","updated_at":"2017-11-23T00:55:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/372","html_url":"https://github.com/sxs-collaboration/spectre/pull/372","diff_url":"https://github.com/sxs-collaboration/spectre/pull/372.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/372.patch"},"body":"## Proposed changes\r\n\r\n<!--\r\nAt a high level, describe what this PR does.\r\n-->\r\n\r\n### Types of changes:\r\n\r\n- [ ] Bugfix\r\n- [x] New feature\r\n\r\n### Component:\r\n\r\n- [x] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- [ ] Follows [code review guidelines](https://sxs-collaboration.github.io/spectre/code_review_guide.html)\r\n- [ ] Code has documentation and unit tests\r\n- [ ] Private member variables have a trailing underscore\r\n- [ ] Do not use [Hungarian notation](https://en.wikipedia.org/wiki/Hungarian_notation), e.g. `double* pd_blah` is bad\r\n- [ ] Header order:\r\n  1. hpp corresponding to cpp (only in cpp files)\r\n  2. Blank line (only in cpp files)\r\n  3. STL and externals (in alphabetical order)\r\n  4. Blank line\r\n  5. SpECTRE includes (in alphabetical order)\r\n- [ ] File lists in CMake are alphabetical\r\n- [ ] Correct `noexcept` specification for functions (if unsure, mark `noexcept`)\r\n- [ ] Mark objects `const` whenever possible\r\n- [ ] Almost always `auto`, except with expression templates, i.e. `DataVector`\r\n- [ ] All commits for performance changes provide quantitative evidence and the tests used to obtain said evidence.\r\n- [ ] Make sure error messages are helpful, e.g. \"The number of grid points in the matrix 'F' is not the same as the number of grid points in the determinant.\"\r\n\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments/346511100","html_url":"https://github.com/sxs-collaboration/spectre/pull/372#issuecomment-346511100","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/372","id":346511100,"user":{"login":"kidder","id":1264082,"avatar_url":"https://avatars3.githubusercontent.com/u/1264082?v=4","gravatar_id":"","url":"https://api.github.com/users/kidder","html_url":"https://github.com/kidder","followers_url":"https://api.github.com/users/kidder/followers","following_url":"https://api.github.com/users/kidder/following{/other_user}","gists_url":"https://api.github.com/users/kidder/gists{/gist_id}","starred_url":"https://api.github.com/users/kidder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidder/subscriptions","organizations_url":"https://api.github.com/users/kidder/orgs","repos_url":"https://api.github.com/users/kidder/repos","events_url":"https://api.github.com/users/kidder/events{/privacy}","received_events_url":"https://api.github.com/users/kidder/received_events","type":"User","site_admin":false},"created_at":"2017-11-23T00:55:27Z","updated_at":"2017-11-23T00:55:27Z","author_association":"CONTRIBUTOR","body":"If you rebase, the clang-tidy errors should be fixed"}}
{"actor":{"display_login":"kidder"}}