{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/10646","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/10646/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/10646/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/10646/events","html_url":"https://github.com/elastic/kibana/pull/10646","id":211281050,"number":10646,"title":"[UI Framework] Create Button React components in UI Framework.","user":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars1.githubusercontent.com/u/1238659?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"labels":[{"id":271062529,"url":"https://api.github.com/repos/elastic/kibana/labels/:Design","name":":Design","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-03-02T03:45:08Z","updated_at":"2017-03-22T22:25:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/10646","html_url":"https://github.com/elastic/kibana/pull/10646","diff_url":"https://github.com/elastic/kibana/pull/10646.diff","patch_url":"https://github.com/elastic/kibana/pull/10646.patch"},"body":"To-do:\r\n\r\n- [x] ~~Add `LoadingButton` abstraction~~\r\n- [x] Add `SubmitButton` abstraction\r\n- [x] Add Jest tests for Button.\r\n- [x] Test ButtonGroup and ButtonIcon.\r\n- [x] Show HTML examples for React components (for people who aren't using React and need to use CSS)\r\n- [x] Update README for instructions on how to import the components.\r\n- [x] Update README for instructions on how to write unit tests.\r\n\r\nTo-do in other PRs:\r\n\r\n- [ ] Add support for tooltip, possibly using CSS only (e.g. http://ubnt-css.herokuapp.com/#/app/tooltip)\r\n- [ ] Add `aria-label` property, based on tooltip or directly configurable.\r\n- [ ] Include UI Framework in linting task."},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/288559022","html_url":"https://github.com/elastic/kibana/pull/10646#issuecomment-288559022","issue_url":"https://api.github.com/repos/elastic/kibana/issues/10646","id":288559022,"user":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars1.githubusercontent.com/u/1238659?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"created_at":"2017-03-22T22:25:45Z","updated_at":"2017-03-22T22:25:45Z","body":"@Stacey-Gammon @kjbekkelund I renamed `testSubject` to `data-test-subj` so we have consistency if people want to apply this attribute to both native components and custom components. But I couldn't figure out an elegant way to allow it to pass-through to the rendered element. Any suggestions?"}}
{"actor":{"display_login":"cjcenizal"}}