{"action":"created","comment":{"url":"https://api.github.com/repos/RackHD/on-http/pulls/comments/102118459","pull_request_review_id":22864087,"id":102118459,"diff_hunk":"@@ -1,11 +1,23 @@\n echo Starting CentOS/RHEL <%=version%> installer for ${hostidentifier}\n+\n+# The progress notification is just something nice-to-have, so progress notification failure should\n+# never impact the normal installation process\n+<% if( typeof progressMilestones !== 'undefined' && progressMilestones.enterProfileUri ) { %>","path":"data/profiles/install-centos.ipxe","position":5,"original_position":5,"commit_id":"8828985bbfdd9aa75f8d62f208065449242cb117","original_commit_id":"8828985bbfdd9aa75f8d62f208065449242cb117","user":{"login":"anhou","id":14013330,"avatar_url":"https://avatars.githubusercontent.com/u/14013330?v=3","gravatar_id":"","url":"https://api.github.com/users/anhou","html_url":"https://github.com/anhou","followers_url":"https://api.github.com/users/anhou/followers","following_url":"https://api.github.com/users/anhou/following{/other_user}","gists_url":"https://api.github.com/users/anhou/gists{/gist_id}","starred_url":"https://api.github.com/users/anhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anhou/subscriptions","organizations_url":"https://api.github.com/users/anhou/orgs","repos_url":"https://api.github.com/users/anhou/repos","events_url":"https://api.github.com/users/anhou/events{/privacy}","received_events_url":"https://api.github.com/users/anhou/received_events","type":"User","site_admin":false},"body":"this code line is mixed in comments, the comments below could be indented","created_at":"2017-02-21T01:49:00Z","updated_at":"2017-02-21T01:49:00Z","html_url":"https://github.com/RackHD/on-http/pull/591#discussion_r102118459","pull_request_url":"https://api.github.com/repos/RackHD/on-http/pulls/591","_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/comments/102118459"},"html":{"href":"https://github.com/RackHD/on-http/pull/591#discussion_r102118459"},"pull_request":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/591"}}},"pull_request":{"url":"https://api.github.com/repos/RackHD/on-http/pulls/591","id":106694319,"html_url":"https://github.com/RackHD/on-http/pull/591","diff_url":"https://github.com/RackHD/on-http/pull/591.diff","patch_url":"https://github.com/RackHD/on-http/pull/591.patch","issue_url":"https://api.github.com/repos/RackHD/on-http/issues/591","number":591,"state":"open","locked":false,"title":"Refactor OS installation progress","user":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"body":"1. Directly reference the milestone definition rather than the raw value.\r\n2. Change all progress notification to be sent via URI /notification/progress\r\n3. Explain the strange implemention for GET /notification/progress\r\n4. Remove totalSteps/currentStep, always use the typic variable maximum/value\r\n\r\njenkins: depends on https://github.com/RackHD/on-tasks/pull/407\r\n\r\n@pengz1 @lanchongyizu ","created_at":"2017-02-17T09:18:49Z","updated_at":"2017-02-21T01:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5a95b791678ab902cb6f194e743126f04f4f060","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RackHD/on-http/pulls/591/commits","review_comments_url":"https://api.github.com/repos/RackHD/on-http/pulls/591/comments","review_comment_url":"https://api.github.com/repos/RackHD/on-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RackHD/on-http/issues/591/comments","statuses_url":"https://api.github.com/repos/RackHD/on-http/statuses/8828985bbfdd9aa75f8d62f208065449242cb117","head":{"label":"yyscamper:refactor-os-progress","ref":"refactor-os-progress","sha":"8828985bbfdd9aa75f8d62f208065449242cb117","user":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"repo":{"id":45547902,"name":"on-http","full_name":"yyscamper/on-http","owner":{"login":"yyscamper","id":511378,"avatar_url":"https://avatars.githubusercontent.com/u/511378?v=3","gravatar_id":"","url":"https://api.github.com/users/yyscamper","html_url":"https://github.com/yyscamper","followers_url":"https://api.github.com/users/yyscamper/followers","following_url":"https://api.github.com/users/yyscamper/following{/other_user}","gists_url":"https://api.github.com/users/yyscamper/gists{/gist_id}","starred_url":"https://api.github.com/users/yyscamper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyscamper/subscriptions","organizations_url":"https://api.github.com/users/yyscamper/orgs","repos_url":"https://api.github.com/users/yyscamper/repos","events_url":"https://api.github.com/users/yyscamper/events{/privacy}","received_events_url":"https://api.github.com/users/yyscamper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yyscamper/on-http","description":null,"fork":true,"url":"https://api.github.com/repos/yyscamper/on-http","forks_url":"https://api.github.com/repos/yyscamper/on-http/forks","keys_url":"https://api.github.com/repos/yyscamper/on-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yyscamper/on-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yyscamper/on-http/teams","hooks_url":"https://api.github.com/repos/yyscamper/on-http/hooks","issue_events_url":"https://api.github.com/repos/yyscamper/on-http/issues/events{/number}","events_url":"https://api.github.com/repos/yyscamper/on-http/events","assignees_url":"https://api.github.com/repos/yyscamper/on-http/assignees{/user}","branches_url":"https://api.github.com/repos/yyscamper/on-http/branches{/branch}","tags_url":"https://api.github.com/repos/yyscamper/on-http/tags","blobs_url":"https://api.github.com/repos/yyscamper/on-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yyscamper/on-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yyscamper/on-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/yyscamper/on-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yyscamper/on-http/statuses/{sha}","languages_url":"https://api.github.com/repos/yyscamper/on-http/languages","stargazers_url":"https://api.github.com/repos/yyscamper/on-http/stargazers","contributors_url":"https://api.github.com/repos/yyscamper/on-http/contributors","subscribers_url":"https://api.github.com/repos/yyscamper/on-http/subscribers","subscription_url":"https://api.github.com/repos/yyscamper/on-http/subscription","commits_url":"https://api.github.com/repos/yyscamper/on-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/yyscamper/on-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/yyscamper/on-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/yyscamper/on-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/yyscamper/on-http/contents/{+path}","compare_url":"https://api.github.com/repos/yyscamper/on-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yyscamper/on-http/merges","archive_url":"https://api.github.com/repos/yyscamper/on-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yyscamper/on-http/downloads","issues_url":"https://api.github.com/repos/yyscamper/on-http/issues{/number}","pulls_url":"https://api.github.com/repos/yyscamper/on-http/pulls{/number}","milestones_url":"https://api.github.com/repos/yyscamper/on-http/milestones{/number}","notifications_url":"https://api.github.com/repos/yyscamper/on-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yyscamper/on-http/labels{/name}","releases_url":"https://api.github.com/repos/yyscamper/on-http/releases{/id}","deployments_url":"https://api.github.com/repos/yyscamper/on-http/deployments","created_at":"2015-11-04T15:25:46Z","updated_at":"2016-12-02T08:53:43Z","pushed_at":"2017-02-17T09:23:03Z","git_url":"git://github.com/yyscamper/on-http.git","ssh_url":"git@github.com:yyscamper/on-http.git","clone_url":"https://github.com/yyscamper/on-http.git","svn_url":"https://github.com/yyscamper/on-http","homepage":null,"size":4291,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"RackHD:master","ref":"master","sha":"af9ab3b7b1f11df58a7e035f099baeebcccfb4fe","user":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"repo":{"id":41690081,"name":"on-http","full_name":"RackHD/on-http","owner":{"login":"RackHD","id":13982662,"avatar_url":"https://avatars.githubusercontent.com/u/13982662?v=3","gravatar_id":"","url":"https://api.github.com/users/RackHD","html_url":"https://github.com/RackHD","followers_url":"https://api.github.com/users/RackHD/followers","following_url":"https://api.github.com/users/RackHD/following{/other_user}","gists_url":"https://api.github.com/users/RackHD/gists{/gist_id}","starred_url":"https://api.github.com/users/RackHD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RackHD/subscriptions","organizations_url":"https://api.github.com/users/RackHD/orgs","repos_url":"https://api.github.com/users/RackHD/repos","events_url":"https://api.github.com/users/RackHD/events{/privacy}","received_events_url":"https://api.github.com/users/RackHD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RackHD/on-http","description":null,"fork":false,"url":"https://api.github.com/repos/RackHD/on-http","forks_url":"https://api.github.com/repos/RackHD/on-http/forks","keys_url":"https://api.github.com/repos/RackHD/on-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RackHD/on-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RackHD/on-http/teams","hooks_url":"https://api.github.com/repos/RackHD/on-http/hooks","issue_events_url":"https://api.github.com/repos/RackHD/on-http/issues/events{/number}","events_url":"https://api.github.com/repos/RackHD/on-http/events","assignees_url":"https://api.github.com/repos/RackHD/on-http/assignees{/user}","branches_url":"https://api.github.com/repos/RackHD/on-http/branches{/branch}","tags_url":"https://api.github.com/repos/RackHD/on-http/tags","blobs_url":"https://api.github.com/repos/RackHD/on-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RackHD/on-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RackHD/on-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/RackHD/on-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RackHD/on-http/statuses/{sha}","languages_url":"https://api.github.com/repos/RackHD/on-http/languages","stargazers_url":"https://api.github.com/repos/RackHD/on-http/stargazers","contributors_url":"https://api.github.com/repos/RackHD/on-http/contributors","subscribers_url":"https://api.github.com/repos/RackHD/on-http/subscribers","subscription_url":"https://api.github.com/repos/RackHD/on-http/subscription","commits_url":"https://api.github.com/repos/RackHD/on-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/RackHD/on-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/RackHD/on-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/RackHD/on-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/RackHD/on-http/contents/{+path}","compare_url":"https://api.github.com/repos/RackHD/on-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RackHD/on-http/merges","archive_url":"https://api.github.com/repos/RackHD/on-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RackHD/on-http/downloads","issues_url":"https://api.github.com/repos/RackHD/on-http/issues{/number}","pulls_url":"https://api.github.com/repos/RackHD/on-http/pulls{/number}","milestones_url":"https://api.github.com/repos/RackHD/on-http/milestones{/number}","notifications_url":"https://api.github.com/repos/RackHD/on-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RackHD/on-http/labels{/name}","releases_url":"https://api.github.com/repos/RackHD/on-http/releases{/id}","deployments_url":"https://api.github.com/repos/RackHD/on-http/deployments","created_at":"2015-08-31T17:29:08Z","updated_at":"2017-02-04T02:55:27Z","pushed_at":"2017-02-20T19:37:41Z","git_url":"git://github.com/RackHD/on-http.git","ssh_url":"git@github.com:RackHD/on-http.git","clone_url":"https://github.com/RackHD/on-http.git","svn_url":"https://github.com/RackHD/on-http","homepage":null,"size":4313,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":11,"forks":61,"open_issues":11,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/591"},"html":{"href":"https://github.com/RackHD/on-http/pull/591"},"issue":{"href":"https://api.github.com/repos/RackHD/on-http/issues/591"},"comments":{"href":"https://api.github.com/repos/RackHD/on-http/issues/591/comments"},"review_comments":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/591/comments"},"review_comment":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RackHD/on-http/pulls/591/commits"},"statuses":{"href":"https://api.github.com/repos/RackHD/on-http/statuses/8828985bbfdd9aa75f8d62f208065449242cb117"}}}}
{"actor":{"display_login":"anhou"}}