{"action":"created","comment":{"url":"https://api.github.com/repos/jonathandturner/rls/pulls/comments/97412541","pull_request_review_id":18021374,"id":97412541,"diff_hunk":"@@ -167,6 +180,17 @@ impl ActionHandler {\n         }\n     }\n \n+    fn clear_build_results(&self) {\n+        {","path":"src/actions.rs","position":141,"original_position":141,"commit_id":"237ec4560dcdc791d5b975ef3556a46767ef7276","original_commit_id":"237ec4560dcdc791d5b975ef3556a46767ef7276","user":{"login":"KalitaAlexey","id":11215191,"avatar_url":"https://avatars.githubusercontent.com/u/11215191?v=3","gravatar_id":"","url":"https://api.github.com/users/KalitaAlexey","html_url":"https://github.com/KalitaAlexey","followers_url":"https://api.github.com/users/KalitaAlexey/followers","following_url":"https://api.github.com/users/KalitaAlexey/following{/other_user}","gists_url":"https://api.github.com/users/KalitaAlexey/gists{/gist_id}","starred_url":"https://api.github.com/users/KalitaAlexey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KalitaAlexey/subscriptions","organizations_url":"https://api.github.com/users/KalitaAlexey/orgs","repos_url":"https://api.github.com/users/KalitaAlexey/repos","events_url":"https://api.github.com/users/KalitaAlexey/events{/privacy}","received_events_url":"https://api.github.com/users/KalitaAlexey/received_events","type":"User","site_admin":false},"body":"@nrc,\r\nRight.\r\nDidn't see.","created_at":"2017-01-23T20:50:47Z","updated_at":"2017-01-23T20:50:47Z","html_url":"https://github.com/jonathandturner/rls/pull/152#discussion_r97412541","pull_request_url":"https://api.github.com/repos/jonathandturner/rls/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/jonathandturner/rls/pulls/comments/97412541"},"html":{"href":"https://github.com/jonathandturner/rls/pull/152#discussion_r97412541"},"pull_request":{"href":"https://api.github.com/repos/jonathandturner/rls/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/jonathandturner/rls/pulls/152","id":102709152,"html_url":"https://github.com/jonathandturner/rls/pull/152","diff_url":"https://github.com/jonathandturner/rls/pull/152.diff","patch_url":"https://github.com/jonathandturner/rls/pull/152.patch","issue_url":"https://api.github.com/repos/jonathandturner/rls/issues/152","number":152,"state":"open","locked":false,"title":"Extracted some pieces of code into functions","user":{"login":"KalitaAlexey","id":11215191,"avatar_url":"https://avatars.githubusercontent.com/u/11215191?v=3","gravatar_id":"","url":"https://api.github.com/users/KalitaAlexey","html_url":"https://github.com/KalitaAlexey","followers_url":"https://api.github.com/users/KalitaAlexey/followers","following_url":"https://api.github.com/users/KalitaAlexey/following{/other_user}","gists_url":"https://api.github.com/users/KalitaAlexey/gists{/gist_id}","starred_url":"https://api.github.com/users/KalitaAlexey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KalitaAlexey/subscriptions","organizations_url":"https://api.github.com/users/KalitaAlexey/orgs","repos_url":"https://api.github.com/users/KalitaAlexey/repos","events_url":"https://api.github.com/users/KalitaAlexey/events{/privacy}","received_events_url":"https://api.github.com/users/KalitaAlexey/received_events","type":"User","site_admin":false},"body":"Since git can't properly show what exactly I did I am writing that here:\r\n\r\nThe code from 89 to 95 was extracted into `clear_build_results`.\r\n\r\nThe code from 96 to 128 was extracted into `parse_compiler_messages`.\r\nBefore the code locked the mutex for each addition. I did that it lock before.\r\nIt there was some motivation please let me know and I will revert it.\r\n\r\nThe code from 130 to 145 was extracted into `convert_build_results_to_notifications`.\r\n\r\n@jonathandturner,\r\nWhy do you use `.iter()` in `for`?","created_at":"2017-01-23T12:25:42Z","updated_at":"2017-01-23T20:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adb2c40ad6eb8b41911b9cbf0c81ee7d82238080","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jonathandturner/rls/pulls/152/commits","review_comments_url":"https://api.github.com/repos/jonathandturner/rls/pulls/152/comments","review_comment_url":"https://api.github.com/repos/jonathandturner/rls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jonathandturner/rls/issues/152/comments","statuses_url":"https://api.github.com/repos/jonathandturner/rls/statuses/237ec4560dcdc791d5b975ef3556a46767ef7276","head":{"label":"KalitaAlexey:refactoring","ref":"refactoring","sha":"237ec4560dcdc791d5b975ef3556a46767ef7276","user":{"login":"KalitaAlexey","id":11215191,"avatar_url":"https://avatars.githubusercontent.com/u/11215191?v=3","gravatar_id":"","url":"https://api.github.com/users/KalitaAlexey","html_url":"https://github.com/KalitaAlexey","followers_url":"https://api.github.com/users/KalitaAlexey/followers","following_url":"https://api.github.com/users/KalitaAlexey/following{/other_user}","gists_url":"https://api.github.com/users/KalitaAlexey/gists{/gist_id}","starred_url":"https://api.github.com/users/KalitaAlexey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KalitaAlexey/subscriptions","organizations_url":"https://api.github.com/users/KalitaAlexey/orgs","repos_url":"https://api.github.com/users/KalitaAlexey/repos","events_url":"https://api.github.com/users/KalitaAlexey/events{/privacy}","received_events_url":"https://api.github.com/users/KalitaAlexey/received_events","type":"User","site_admin":false},"repo":{"id":79801748,"name":"rls","full_name":"KalitaAlexey/rls","owner":{"login":"KalitaAlexey","id":11215191,"avatar_url":"https://avatars.githubusercontent.com/u/11215191?v=3","gravatar_id":"","url":"https://api.github.com/users/KalitaAlexey","html_url":"https://github.com/KalitaAlexey","followers_url":"https://api.github.com/users/KalitaAlexey/followers","following_url":"https://api.github.com/users/KalitaAlexey/following{/other_user}","gists_url":"https://api.github.com/users/KalitaAlexey/gists{/gist_id}","starred_url":"https://api.github.com/users/KalitaAlexey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KalitaAlexey/subscriptions","organizations_url":"https://api.github.com/users/KalitaAlexey/orgs","repos_url":"https://api.github.com/users/KalitaAlexey/repos","events_url":"https://api.github.com/users/KalitaAlexey/events{/privacy}","received_events_url":"https://api.github.com/users/KalitaAlexey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KalitaAlexey/rls","description":"Repository for the Rust Language Server (aka RLS)","fork":true,"url":"https://api.github.com/repos/KalitaAlexey/rls","forks_url":"https://api.github.com/repos/KalitaAlexey/rls/forks","keys_url":"https://api.github.com/repos/KalitaAlexey/rls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KalitaAlexey/rls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KalitaAlexey/rls/teams","hooks_url":"https://api.github.com/repos/KalitaAlexey/rls/hooks","issue_events_url":"https://api.github.com/repos/KalitaAlexey/rls/issues/events{/number}","events_url":"https://api.github.com/repos/KalitaAlexey/rls/events","assignees_url":"https://api.github.com/repos/KalitaAlexey/rls/assignees{/user}","branches_url":"https://api.github.com/repos/KalitaAlexey/rls/branches{/branch}","tags_url":"https://api.github.com/repos/KalitaAlexey/rls/tags","blobs_url":"https://api.github.com/repos/KalitaAlexey/rls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KalitaAlexey/rls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KalitaAlexey/rls/git/refs{/sha}","trees_url":"https://api.github.com/repos/KalitaAlexey/rls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KalitaAlexey/rls/statuses/{sha}","languages_url":"https://api.github.com/repos/KalitaAlexey/rls/languages","stargazers_url":"https://api.github.com/repos/KalitaAlexey/rls/stargazers","contributors_url":"https://api.github.com/repos/KalitaAlexey/rls/contributors","subscribers_url":"https://api.github.com/repos/KalitaAlexey/rls/subscribers","subscription_url":"https://api.github.com/repos/KalitaAlexey/rls/subscription","commits_url":"https://api.github.com/repos/KalitaAlexey/rls/commits{/sha}","git_commits_url":"https://api.github.com/repos/KalitaAlexey/rls/git/commits{/sha}","comments_url":"https://api.github.com/repos/KalitaAlexey/rls/comments{/number}","issue_comment_url":"https://api.github.com/repos/KalitaAlexey/rls/issues/comments{/number}","contents_url":"https://api.github.com/repos/KalitaAlexey/rls/contents/{+path}","compare_url":"https://api.github.com/repos/KalitaAlexey/rls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KalitaAlexey/rls/merges","archive_url":"https://api.github.com/repos/KalitaAlexey/rls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KalitaAlexey/rls/downloads","issues_url":"https://api.github.com/repos/KalitaAlexey/rls/issues{/number}","pulls_url":"https://api.github.com/repos/KalitaAlexey/rls/pulls{/number}","milestones_url":"https://api.github.com/repos/KalitaAlexey/rls/milestones{/number}","notifications_url":"https://api.github.com/repos/KalitaAlexey/rls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KalitaAlexey/rls/labels{/name}","releases_url":"https://api.github.com/repos/KalitaAlexey/rls/releases{/id}","deployments_url":"https://api.github.com/repos/KalitaAlexey/rls/deployments","created_at":"2017-01-23T12:20:19Z","updated_at":"2017-01-23T12:20:22Z","pushed_at":"2017-01-23T12:20:46Z","git_url":"git://github.com/KalitaAlexey/rls.git","ssh_url":"git@github.com:KalitaAlexey/rls.git","clone_url":"https://github.com/KalitaAlexey/rls.git","svn_url":"https://github.com/KalitaAlexey/rls","homepage":"","size":366,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jonathandturner:master","ref":"master","sha":"a054b8eb85c6a2563dece10b734b83dbe03a9cd9","user":{"login":"jonathandturner","id":547158,"avatar_url":"https://avatars.githubusercontent.com/u/547158?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathandturner","html_url":"https://github.com/jonathandturner","followers_url":"https://api.github.com/users/jonathandturner/followers","following_url":"https://api.github.com/users/jonathandturner/following{/other_user}","gists_url":"https://api.github.com/users/jonathandturner/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathandturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathandturner/subscriptions","organizations_url":"https://api.github.com/users/jonathandturner/orgs","repos_url":"https://api.github.com/users/jonathandturner/repos","events_url":"https://api.github.com/users/jonathandturner/events{/privacy}","received_events_url":"https://api.github.com/users/jonathandturner/received_events","type":"User","site_admin":false},"repo":{"id":66979953,"name":"rls","full_name":"jonathandturner/rls","owner":{"login":"jonathandturner","id":547158,"avatar_url":"https://avatars.githubusercontent.com/u/547158?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathandturner","html_url":"https://github.com/jonathandturner","followers_url":"https://api.github.com/users/jonathandturner/followers","following_url":"https://api.github.com/users/jonathandturner/following{/other_user}","gists_url":"https://api.github.com/users/jonathandturner/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathandturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathandturner/subscriptions","organizations_url":"https://api.github.com/users/jonathandturner/orgs","repos_url":"https://api.github.com/users/jonathandturner/repos","events_url":"https://api.github.com/users/jonathandturner/events{/privacy}","received_events_url":"https://api.github.com/users/jonathandturner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonathandturner/rls","description":"Repository for the Rust Language Server (aka RLS)","fork":false,"url":"https://api.github.com/repos/jonathandturner/rls","forks_url":"https://api.github.com/repos/jonathandturner/rls/forks","keys_url":"https://api.github.com/repos/jonathandturner/rls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonathandturner/rls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonathandturner/rls/teams","hooks_url":"https://api.github.com/repos/jonathandturner/rls/hooks","issue_events_url":"https://api.github.com/repos/jonathandturner/rls/issues/events{/number}","events_url":"https://api.github.com/repos/jonathandturner/rls/events","assignees_url":"https://api.github.com/repos/jonathandturner/rls/assignees{/user}","branches_url":"https://api.github.com/repos/jonathandturner/rls/branches{/branch}","tags_url":"https://api.github.com/repos/jonathandturner/rls/tags","blobs_url":"https://api.github.com/repos/jonathandturner/rls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonathandturner/rls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonathandturner/rls/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonathandturner/rls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonathandturner/rls/statuses/{sha}","languages_url":"https://api.github.com/repos/jonathandturner/rls/languages","stargazers_url":"https://api.github.com/repos/jonathandturner/rls/stargazers","contributors_url":"https://api.github.com/repos/jonathandturner/rls/contributors","subscribers_url":"https://api.github.com/repos/jonathandturner/rls/subscribers","subscription_url":"https://api.github.com/repos/jonathandturner/rls/subscription","commits_url":"https://api.github.com/repos/jonathandturner/rls/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonathandturner/rls/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonathandturner/rls/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonathandturner/rls/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonathandturner/rls/contents/{+path}","compare_url":"https://api.github.com/repos/jonathandturner/rls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonathandturner/rls/merges","archive_url":"https://api.github.com/repos/jonathandturner/rls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonathandturner/rls/downloads","issues_url":"https://api.github.com/repos/jonathandturner/rls/issues{/number}","pulls_url":"https://api.github.com/repos/jonathandturner/rls/pulls{/number}","milestones_url":"https://api.github.com/repos/jonathandturner/rls/milestones{/number}","notifications_url":"https://api.github.com/repos/jonathandturner/rls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonathandturner/rls/labels{/name}","releases_url":"https://api.github.com/repos/jonathandturner/rls/releases{/id}","deployments_url":"https://api.github.com/repos/jonathandturner/rls/deployments","created_at":"2016-08-30T21:42:03Z","updated_at":"2017-01-23T16:17:16Z","pushed_at":"2017-01-23T20:48:26Z","git_url":"git://github.com/jonathandturner/rls.git","ssh_url":"git@github.com:jonathandturner/rls.git","clone_url":"https://github.com/jonathandturner/rls.git","svn_url":"https://github.com/jonathandturner/rls","homepage":"","size":359,"stargazers_count":506,"watchers_count":506,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":52,"forks":21,"open_issues":52,"watchers":506,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jonathandturner/rls/pulls/152"},"html":{"href":"https://github.com/jonathandturner/rls/pull/152"},"issue":{"href":"https://api.github.com/repos/jonathandturner/rls/issues/152"},"comments":{"href":"https://api.github.com/repos/jonathandturner/rls/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/jonathandturner/rls/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/jonathandturner/rls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jonathandturner/rls/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/jonathandturner/rls/statuses/237ec4560dcdc791d5b975ef3556a46767ef7276"}}}}
{"actor":{"display_login":"KalitaAlexey"}}