{"action":"created","issue":{"url":"https://api.github.com/repos/molgenis/molgenis/issues/6341","repository_url":"https://api.github.com/repos/molgenis/molgenis","labels_url":"https://api.github.com/repos/molgenis/molgenis/issues/6341/labels{/name}","comments_url":"https://api.github.com/repos/molgenis/molgenis/issues/6341/comments","events_url":"https://api.github.com/repos/molgenis/molgenis/issues/6341/events","html_url":"https://github.com/molgenis/molgenis/issues/6341","id":240584092,"number":6341,"title":"MolgenisChangePasswordFilter creates a database transaction for each servlet request it filters","user":{"login":"fdlk","id":1523838,"avatar_url":"https://avatars2.githubusercontent.com/u/1523838?v=4","gravatar_id":"","url":"https://api.github.com/users/fdlk","html_url":"https://github.com/fdlk","followers_url":"https://api.github.com/users/fdlk/followers","following_url":"https://api.github.com/users/fdlk/following{/other_user}","gists_url":"https://api.github.com/users/fdlk/gists{/gist_id}","starred_url":"https://api.github.com/users/fdlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdlk/subscriptions","organizations_url":"https://api.github.com/users/fdlk/orgs","repos_url":"https://api.github.com/users/fdlk/repos","events_url":"https://api.github.com/users/fdlk/events{/privacy}","received_events_url":"https://api.github.com/users/fdlk/received_events","type":"User","site_admin":false},"labels":[{"id":645341949,"url":"https://api.github.com/repos/molgenis/molgenis/labels/5.0","name":"5.0","color":"0052cc","default":false},{"id":27272398,"url":"https://api.github.com/repos/molgenis/molgenis/labels/enhancement","name":"enhancement","color":"d4c5f9","default":true},{"id":43318350,"url":"https://api.github.com/repos/molgenis/molgenis/labels/mod:security","name":"mod:security","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-05T09:03:09Z","updated_at":"2017-08-01T11:07:13Z","closed_at":null,"body":"### How to Reproduce\r\nI noticed a lot of transactions when I put logging for org.molgenis.data.index package on DEBUG.\r\nIf I put a breakpoint in the IndexActionRegisterService I see what causes the transaction to be created.\r\n\r\n### Expected behavior\r\nFilters shouldn't make expensive database calls for each request.\r\n\r\n### Observed behavior\r\nThe MolgenisChangePasswordFilter does a call to `userService.getUser(authentication.getName())` to check if the user's password needs to be changed."},"comment":{"url":"https://api.github.com/repos/molgenis/molgenis/issues/comments/319340329","html_url":"https://github.com/molgenis/molgenis/issues/6341#issuecomment-319340329","issue_url":"https://api.github.com/repos/molgenis/molgenis/issues/6341","id":319340329,"user":{"login":"dennishendriksen","id":2477186,"avatar_url":"https://avatars1.githubusercontent.com/u/2477186?v=4","gravatar_id":"","url":"https://api.github.com/users/dennishendriksen","html_url":"https://github.com/dennishendriksen","followers_url":"https://api.github.com/users/dennishendriksen/followers","following_url":"https://api.github.com/users/dennishendriksen/following{/other_user}","gists_url":"https://api.github.com/users/dennishendriksen/gists{/gist_id}","starred_url":"https://api.github.com/users/dennishendriksen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennishendriksen/subscriptions","organizations_url":"https://api.github.com/users/dennishendriksen/orgs","repos_url":"https://api.github.com/users/dennishendriksen/repos","events_url":"https://api.github.com/users/dennishendriksen/events{/privacy}","received_events_url":"https://api.github.com/users/dennishendriksen/received_events","type":"User","site_admin":false},"created_at":"2017-08-01T11:07:13Z","updated_at":"2017-08-01T11:07:13Z","body":"Probably a read-only transaction which is applied on a generic code path. Having read-only transactions here is useful when requesting entities requires multiple database queries.\r\n\r\n@fdlk Do you have benchmarks for this performance issue?"}}
{"actor":{"display_login":"dennishendriksen"}}