{"action":"created","comment":{"url":"https://api.github.com/repos/alisw/AliPhysics/pulls/comments/151423900","pull_request_review_id":77128107,"id":151423900,"diff_hunk":"@@ -0,0 +1,297 @@\n+//\n+// Basic analysis task.\n+//\n+// Basic analysis task template for analysis jets storing information in both tree\n+// branches and histograms \n+\n+#include <TClonesArray.h>\n+#include <TH1F.h>\n+#include <TH2F.h>\n+#include <TH3F.h>\n+#include <TCanvas.h>\n+#include <THnSparse.h>\n+#include <TTree.h>\n+#include <TList.h>\n+#include <TLorentzVector.h>\n+#include <TProfile.h>\n+#include <TChain.h>\n+#include <TSystem.h>\n+#include <TFile.h>\n+#include <TKey.h>\n+#include <AliAnalysisDataSlot.h>\n+#include <AliAnalysisDataContainer.h>\n+#include \"TMatrixD.h\"\n+#include \"TMatrixDSym.h\"\n+#include \"TMatrixDSymEigen.h\"\n+#include \"TVector3.h\"\n+#include \"TVector2.h\"\n+#include \"AliVCluster.h\"\n+#include \"AliVTrack.h\"\n+#include \"AliEmcalJet.h\"\n+#include \"AliRhoParameter.h\"\n+#include \"AliLog.h\"\n+#include \"AliEmcalParticle.h\"\n+#include \"AliMCEvent.h\"\n+#include \"AliGenPythiaEventHeader.h\"\n+#include \"AliAODMCHeader.h\"\n+#include \"AliMCEvent.h\"\n+#include \"AliAnalysisManager.h\"\n+#include \"AliJetContainer.h\"\n+#include \"AliParticleContainer.h\"\n+//#include \"AliPythiaInfo.h\"\n+#include \"TRandom3.h\"\n+#include \"AliPicoTrack.h\"\n+#include \"AliEmcalJetFinder.h\"\n+#include \"AliAODEvent.h\"\n+#include \"AliAnalysisTaskRecursiveSoftDrop.h\"\n+\n+#include \"FJ_includes.h\"\n+\n+//Globals\n+using std::cout;\n+using std::endl;\n+\n+ClassImp(AliAnalysisTaskRecursiveSoftDrop)\n+\n+//________________________________________________________________________\n+AliAnalysisTaskRecursiveSoftDrop::AliAnalysisTaskRecursiveSoftDrop() : \n+  AliAnalysisTaskEmcalJet(\"AliAnalysisTaskRecursiveSoftDrop\", kTRUE),\n+  fContainer(0),\n+  fJetShapeSub(kNoSub),\n+  fPtThreshold(-9999.),\n+  fCentSelectOn(kTRUE),\n+  fCentMin(0),\n+  fCentMax(10),\n+  fJetRadius(0.4),\n+  fhJetPt(0x0),\n+  fhJetPhi(0x0),\n+  fhJetEta(0x0),\n+  fTreeRecursive_Det(0),\n+  fTreeRecursive_True(0)\n+\n+{\n+  for(Int_t i=0;i<nBranches;i++){\n+    fShapesVar_Det[i]=0;\n+    fShapesVar_True[i]=0;\n+  }\n+  SetMakeGeneralHistograms(kTRUE);\n+  DefineOutput(1, TList::Class());\n+  DefineOutput(2, TTree::Class());\n+  DefineOutput(3, TTree::Class());\n+}\n+\n+//________________________________________________________________________\n+AliAnalysisTaskRecursiveSoftDrop::AliAnalysisTaskRecursiveSoftDrop(const char *name) : \n+  AliAnalysisTaskEmcalJet(name, kTRUE),\n+  fContainer(0),\n+  fJetShapeSub(kNoSub),\n+  fPtThreshold(-9999.),\n+  fCentSelectOn(kTRUE),\n+  fCentMin(0),\n+  fCentMax(10),\n+  fJetRadius(0.4),\n+  fhJetPt(0x0),\n+  fhJetPhi(0x0),\n+  fhJetEta(0x0),\n+  fTreeRecursive_Det(0),\n+  fTreeRecursive_True(0)\n+{\n+  // Standard constructor.\n+  for(Int_t i=0;i<nBranches;i++){\n+    fShapesVar_Det[i]=0;\n+    fShapesVar_True[i]=0;\n+  }\n+  SetMakeGeneralHistograms(kTRUE);\n+  DefineOutput(1, TList::Class());\n+  DefineOutput(2, TTree::Class());\n+  DefineOutput(3, TTree::Class());\n+}\n+\n+//________________________________________________________________________\n+AliAnalysisTaskRecursiveSoftDrop::~AliAnalysisTaskRecursiveSoftDrop()\n+{\n+  // Destructor.\n+}\n+\n+//________________________________________________________________________\n+ void AliAnalysisTaskRecursiveSoftDrop::UserCreateOutputObjects()\n+{\n+  // Create user output.\n+\n+  AliAnalysisTaskEmcalJet::UserCreateOutputObjects();\n+\n+  Bool_t oldStatus = TH1::AddDirectoryStatus();\n+  TH1::AddDirectory(kFALSE);\n+  TH1::AddDirectory(oldStatus);\n+  //create a tree used for the MC data and making a 4D response matrix\n+  const char* nameoutput = GetOutputSlot(2)->GetContainer()->GetName();\n+  fTreeRecursive_Det = new TTree(nameoutput, nameoutput);\n+  TString *fShapesVarNames_Det = new TString [nBranches];\n+  const char* nameoutput2 = GetOutputSlot(3)->GetContainer()->GetName();\n+  fTreeRecursive_True = new TTree(nameoutput2, nameoutput2);\n+  TString *fShapesVarNames_True = new TString [nBranches];\n+  ","path":"PWGJE/EMCALJetTasks/UserTasks/AliAnalysisTaskRecursiveSoftDrop.cxx","position":133,"original_position":133,"commit_id":"d474001622be2687cc8d28f539c8067bf2983a9b","original_commit_id":"d474001622be2687cc8d28f539c8067bf2983a9b","user":{"login":"mfasDa","id":6999982,"avatar_url":"https://avatars0.githubusercontent.com/u/6999982?v=4","gravatar_id":"","url":"https://api.github.com/users/mfasDa","html_url":"https://github.com/mfasDa","followers_url":"https://api.github.com/users/mfasDa/followers","following_url":"https://api.github.com/users/mfasDa/following{/other_user}","gists_url":"https://api.github.com/users/mfasDa/gists{/gist_id}","starred_url":"https://api.github.com/users/mfasDa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfasDa/subscriptions","organizations_url":"https://api.github.com/users/mfasDa/orgs","repos_url":"https://api.github.com/users/mfasDa/repos","events_url":"https://api.github.com/users/mfasDa/events{/privacy}","received_events_url":"https://api.github.com/users/mfasDa/received_events","type":"User","site_admin":false},"body":"Here you allocate memory without freeing it. I recommend replacing by\r\nstd::vector<TString> fShapeVarNames_Det(nBranches), nShapeVarNames_True(nBranches);","created_at":"2017-11-16T14:16:47Z","updated_at":"2017-11-16T14:16:47Z","html_url":"https://github.com/alisw/AliPhysics/pull/3317#discussion_r151423900","pull_request_url":"https://api.github.com/repos/alisw/AliPhysics/pulls/3317","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/comments/151423900"},"html":{"href":"https://github.com/alisw/AliPhysics/pull/3317#discussion_r151423900"},"pull_request":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/3317"}}},"pull_request":{"url":"https://api.github.com/repos/alisw/AliPhysics/pulls/3317","id":153050062,"html_url":"https://github.com/alisw/AliPhysics/pull/3317","diff_url":"https://github.com/alisw/AliPhysics/pull/3317.diff","patch_url":"https://github.com/alisw/AliPhysics/pull/3317.patch","issue_url":"https://api.github.com/repos/alisw/AliPhysics/issues/3317","number":3317,"state":"open","locked":false,"title":"New task to recursively store jet splittings","user":{"login":"haandrew","id":26716221,"avatar_url":"https://avatars3.githubusercontent.com/u/26716221?v=4","gravatar_id":"","url":"https://api.github.com/users/haandrew","html_url":"https://github.com/haandrew","followers_url":"https://api.github.com/users/haandrew/followers","following_url":"https://api.github.com/users/haandrew/following{/other_user}","gists_url":"https://api.github.com/users/haandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/haandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haandrew/subscriptions","organizations_url":"https://api.github.com/users/haandrew/orgs","repos_url":"https://api.github.com/users/haandrew/repos","events_url":"https://api.github.com/users/haandrew/events{/privacy}","received_events_url":"https://api.github.com/users/haandrew/received_events","type":"User","site_admin":false},"body":"New task to run over data jets to store iteratively the jet splitting information","created_at":"2017-11-16T14:09:20Z","updated_at":"2017-11-16T14:16:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ed837b8b7d0c9ea6f01ffaff2e53035e6e8878b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alisw/AliPhysics/pulls/3317/commits","review_comments_url":"https://api.github.com/repos/alisw/AliPhysics/pulls/3317/comments","review_comment_url":"https://api.github.com/repos/alisw/AliPhysics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alisw/AliPhysics/issues/3317/comments","statuses_url":"https://api.github.com/repos/alisw/AliPhysics/statuses/d474001622be2687cc8d28f539c8067bf2983a9b","head":{"label":"haandrew:master","ref":"master","sha":"d474001622be2687cc8d28f539c8067bf2983a9b","user":{"login":"haandrew","id":26716221,"avatar_url":"https://avatars3.githubusercontent.com/u/26716221?v=4","gravatar_id":"","url":"https://api.github.com/users/haandrew","html_url":"https://github.com/haandrew","followers_url":"https://api.github.com/users/haandrew/followers","following_url":"https://api.github.com/users/haandrew/following{/other_user}","gists_url":"https://api.github.com/users/haandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/haandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haandrew/subscriptions","organizations_url":"https://api.github.com/users/haandrew/orgs","repos_url":"https://api.github.com/users/haandrew/repos","events_url":"https://api.github.com/users/haandrew/events{/privacy}","received_events_url":"https://api.github.com/users/haandrew/received_events","type":"User","site_admin":false},"repo":{"id":86343414,"name":"AliPhysics","full_name":"haandrew/AliPhysics","owner":{"login":"haandrew","id":26716221,"avatar_url":"https://avatars3.githubusercontent.com/u/26716221?v=4","gravatar_id":"","url":"https://api.github.com/users/haandrew","html_url":"https://github.com/haandrew","followers_url":"https://api.github.com/users/haandrew/followers","following_url":"https://api.github.com/users/haandrew/following{/other_user}","gists_url":"https://api.github.com/users/haandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/haandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haandrew/subscriptions","organizations_url":"https://api.github.com/users/haandrew/orgs","repos_url":"https://api.github.com/users/haandrew/repos","events_url":"https://api.github.com/users/haandrew/events{/privacy}","received_events_url":"https://api.github.com/users/haandrew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haandrew/AliPhysics","description":"ALICE Analysis Repository","fork":true,"url":"https://api.github.com/repos/haandrew/AliPhysics","forks_url":"https://api.github.com/repos/haandrew/AliPhysics/forks","keys_url":"https://api.github.com/repos/haandrew/AliPhysics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haandrew/AliPhysics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haandrew/AliPhysics/teams","hooks_url":"https://api.github.com/repos/haandrew/AliPhysics/hooks","issue_events_url":"https://api.github.com/repos/haandrew/AliPhysics/issues/events{/number}","events_url":"https://api.github.com/repos/haandrew/AliPhysics/events","assignees_url":"https://api.github.com/repos/haandrew/AliPhysics/assignees{/user}","branches_url":"https://api.github.com/repos/haandrew/AliPhysics/branches{/branch}","tags_url":"https://api.github.com/repos/haandrew/AliPhysics/tags","blobs_url":"https://api.github.com/repos/haandrew/AliPhysics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haandrew/AliPhysics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haandrew/AliPhysics/git/refs{/sha}","trees_url":"https://api.github.com/repos/haandrew/AliPhysics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haandrew/AliPhysics/statuses/{sha}","languages_url":"https://api.github.com/repos/haandrew/AliPhysics/languages","stargazers_url":"https://api.github.com/repos/haandrew/AliPhysics/stargazers","contributors_url":"https://api.github.com/repos/haandrew/AliPhysics/contributors","subscribers_url":"https://api.github.com/repos/haandrew/AliPhysics/subscribers","subscription_url":"https://api.github.com/repos/haandrew/AliPhysics/subscription","commits_url":"https://api.github.com/repos/haandrew/AliPhysics/commits{/sha}","git_commits_url":"https://api.github.com/repos/haandrew/AliPhysics/git/commits{/sha}","comments_url":"https://api.github.com/repos/haandrew/AliPhysics/comments{/number}","issue_comment_url":"https://api.github.com/repos/haandrew/AliPhysics/issues/comments{/number}","contents_url":"https://api.github.com/repos/haandrew/AliPhysics/contents/{+path}","compare_url":"https://api.github.com/repos/haandrew/AliPhysics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haandrew/AliPhysics/merges","archive_url":"https://api.github.com/repos/haandrew/AliPhysics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haandrew/AliPhysics/downloads","issues_url":"https://api.github.com/repos/haandrew/AliPhysics/issues{/number}","pulls_url":"https://api.github.com/repos/haandrew/AliPhysics/pulls{/number}","milestones_url":"https://api.github.com/repos/haandrew/AliPhysics/milestones{/number}","notifications_url":"https://api.github.com/repos/haandrew/AliPhysics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haandrew/AliPhysics/labels{/name}","releases_url":"https://api.github.com/repos/haandrew/AliPhysics/releases{/id}","deployments_url":"https://api.github.com/repos/haandrew/AliPhysics/deployments","created_at":"2017-03-27T14:09:32Z","updated_at":"2017-03-27T14:10:09Z","pushed_at":"2017-11-15T14:09:39Z","git_url":"git://github.com/haandrew/AliPhysics.git","ssh_url":"git@github.com:haandrew/AliPhysics.git","clone_url":"https://github.com/haandrew/AliPhysics.git","svn_url":"https://github.com/haandrew/AliPhysics","homepage":"https://alisw.github.io/git-tutorial","size":468824,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alisw:master","ref":"master","sha":"4c03d104bbc81b515731ae200b692d4915f2821d","user":{"login":"alisw","id":12711103,"avatar_url":"https://avatars2.githubusercontent.com/u/12711103?v=4","gravatar_id":"","url":"https://api.github.com/users/alisw","html_url":"https://github.com/alisw","followers_url":"https://api.github.com/users/alisw/followers","following_url":"https://api.github.com/users/alisw/following{/other_user}","gists_url":"https://api.github.com/users/alisw/gists{/gist_id}","starred_url":"https://api.github.com/users/alisw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisw/subscriptions","organizations_url":"https://api.github.com/users/alisw/orgs","repos_url":"https://api.github.com/users/alisw/repos","events_url":"https://api.github.com/users/alisw/events{/privacy}","received_events_url":"https://api.github.com/users/alisw/received_events","type":"Organization","site_admin":false},"repo":{"id":61661378,"name":"AliPhysics","full_name":"alisw/AliPhysics","owner":{"login":"alisw","id":12711103,"avatar_url":"https://avatars2.githubusercontent.com/u/12711103?v=4","gravatar_id":"","url":"https://api.github.com/users/alisw","html_url":"https://github.com/alisw","followers_url":"https://api.github.com/users/alisw/followers","following_url":"https://api.github.com/users/alisw/following{/other_user}","gists_url":"https://api.github.com/users/alisw/gists{/gist_id}","starred_url":"https://api.github.com/users/alisw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisw/subscriptions","organizations_url":"https://api.github.com/users/alisw/orgs","repos_url":"https://api.github.com/users/alisw/repos","events_url":"https://api.github.com/users/alisw/events{/privacy}","received_events_url":"https://api.github.com/users/alisw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alisw/AliPhysics","description":"ALICE Analysis Repository","fork":false,"url":"https://api.github.com/repos/alisw/AliPhysics","forks_url":"https://api.github.com/repos/alisw/AliPhysics/forks","keys_url":"https://api.github.com/repos/alisw/AliPhysics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alisw/AliPhysics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alisw/AliPhysics/teams","hooks_url":"https://api.github.com/repos/alisw/AliPhysics/hooks","issue_events_url":"https://api.github.com/repos/alisw/AliPhysics/issues/events{/number}","events_url":"https://api.github.com/repos/alisw/AliPhysics/events","assignees_url":"https://api.github.com/repos/alisw/AliPhysics/assignees{/user}","branches_url":"https://api.github.com/repos/alisw/AliPhysics/branches{/branch}","tags_url":"https://api.github.com/repos/alisw/AliPhysics/tags","blobs_url":"https://api.github.com/repos/alisw/AliPhysics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alisw/AliPhysics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alisw/AliPhysics/git/refs{/sha}","trees_url":"https://api.github.com/repos/alisw/AliPhysics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alisw/AliPhysics/statuses/{sha}","languages_url":"https://api.github.com/repos/alisw/AliPhysics/languages","stargazers_url":"https://api.github.com/repos/alisw/AliPhysics/stargazers","contributors_url":"https://api.github.com/repos/alisw/AliPhysics/contributors","subscribers_url":"https://api.github.com/repos/alisw/AliPhysics/subscribers","subscription_url":"https://api.github.com/repos/alisw/AliPhysics/subscription","commits_url":"https://api.github.com/repos/alisw/AliPhysics/commits{/sha}","git_commits_url":"https://api.github.com/repos/alisw/AliPhysics/git/commits{/sha}","comments_url":"https://api.github.com/repos/alisw/AliPhysics/comments{/number}","issue_comment_url":"https://api.github.com/repos/alisw/AliPhysics/issues/comments{/number}","contents_url":"https://api.github.com/repos/alisw/AliPhysics/contents/{+path}","compare_url":"https://api.github.com/repos/alisw/AliPhysics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alisw/AliPhysics/merges","archive_url":"https://api.github.com/repos/alisw/AliPhysics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alisw/AliPhysics/downloads","issues_url":"https://api.github.com/repos/alisw/AliPhysics/issues{/number}","pulls_url":"https://api.github.com/repos/alisw/AliPhysics/pulls{/number}","milestones_url":"https://api.github.com/repos/alisw/AliPhysics/milestones{/number}","notifications_url":"https://api.github.com/repos/alisw/AliPhysics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alisw/AliPhysics/labels{/name}","releases_url":"https://api.github.com/repos/alisw/AliPhysics/releases{/id}","deployments_url":"https://api.github.com/repos/alisw/AliPhysics/deployments","created_at":"2016-06-21T19:31:29Z","updated_at":"2017-11-06T01:52:21Z","pushed_at":"2017-11-16T14:13:49Z","git_url":"git://github.com/alisw/AliPhysics.git","ssh_url":"git@github.com:alisw/AliPhysics.git","clone_url":"https://github.com/alisw/AliPhysics.git","svn_url":"https://github.com/alisw/AliPhysics","homepage":"https://alisw.github.io/git-tutorial","size":476003,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":349,"open_issues":5,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/3317"},"html":{"href":"https://github.com/alisw/AliPhysics/pull/3317"},"issue":{"href":"https://api.github.com/repos/alisw/AliPhysics/issues/3317"},"comments":{"href":"https://api.github.com/repos/alisw/AliPhysics/issues/3317/comments"},"review_comments":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/3317/comments"},"review_comment":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alisw/AliPhysics/pulls/3317/commits"},"statuses":{"href":"https://api.github.com/repos/alisw/AliPhysics/statuses/d474001622be2687cc8d28f539c8067bf2983a9b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mfasDa"}}