{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/4986","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/4986/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/4986/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/4986/events","html_url":"https://github.com/minetest/minetest/pull/4986","id":198386433,"number":4986,"title":"Hardware node coloring","user":{"login":"juhdanad","id":20600448,"avatar_url":"https://avatars.githubusercontent.com/u/20600448?v=3","gravatar_id":"","url":"https://api.github.com/users/juhdanad","html_url":"https://github.com/juhdanad","followers_url":"https://api.github.com/users/juhdanad/followers","following_url":"https://api.github.com/users/juhdanad/following{/other_user}","gists_url":"https://api.github.com/users/juhdanad/gists{/gist_id}","starred_url":"https://api.github.com/users/juhdanad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhdanad/subscriptions","organizations_url":"https://api.github.com/users/juhdanad/orgs","repos_url":"https://api.github.com/users/juhdanad/repos","events_url":"https://api.github.com/users/juhdanad/events{/privacy}","received_events_url":"https://api.github.com/users/juhdanad/received_events","type":"User","site_admin":false},"labels":[{"id":73369003,"url":"https://api.github.com/repos/minetest/minetest/labels/@%20Client%20/%20Audiovisuals","name":"@ Client / Audiovisuals","color":"009800","default":false},{"id":471238548,"url":"https://api.github.com/repos/minetest/minetest/labels/Feature","name":"Feature","color":"f9d0c4","default":false},{"id":39497728,"url":"https://api.github.com/repos/minetest/minetest/labels/Rebase%20needed","name":"Rebase needed","color":"eb6420","default":false},{"id":110411003,"url":"https://api.github.com/repos/minetest/minetest/labels/WIP","name":"WIP","color":"aa3000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":27,"created_at":"2017-01-02T22:23:05Z","updated_at":"2017-01-09T20:45:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/4986","html_url":"https://github.com/minetest/minetest/pull/4986","diff_url":"https://github.com/minetest/minetest/pull/4986.diff","patch_url":"https://github.com/minetest/minetest/pull/4986.patch"},"body":"This request adds to possibility to colorize nodes dynamically, using hardware coloring.\r\n\r\n**How to use:**\r\nAdd `color = {r = <?>, g = <?>, b = <?>}` to your node definition to get static color\r\nor add `paramtype2 = \"color\"` to let Minetest colorize the node dynamically based on the `param2`.\r\nYou can add `color = <?>` to any tile too, to overwrite any global behavior (for example to only allow dynamic color for the top tile of grass).\r\n\r\n**Advantages:**\r\nModders will be able to create colored nodes, while Minetest will not create new textures for them in the memory (unlike texture modifiers). This may make framerate higher on worlds that use a lot of colored blocks for buildings.\r\nMakes modders able to colorize nodes based on their `param2`.\r\n\r\n**Disadvantage:**\r\nOld clients are \"colorblind\". They see the textures without colorization.\r\nWhen shaders are disabled, memory usage is increased (Minetest has to store colors as well).\r\n\r\n**To do:**\r\n- [x] Allow nodes in the world to be colored\r\n- [x] Allow wield nodes to be colored\r\n- [x] Add paramtype2=\"color\" for nodes that can have any color\r\n- [x] ~Add smooth color, which is similar to smooth lighting, but with colors (not a setting, it is per node type)~ EDIT: canceled, this would not look good\r\n- [x] ~Add biome-based coloring (requires the biome information to be exposed)~ EDIT: canceled, biome information is not exposed to the client."},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/271402298","html_url":"https://github.com/minetest/minetest/pull/4986#issuecomment-271402298","issue_url":"https://api.github.com/repos/minetest/minetest/issues/4986","id":271402298,"user":{"login":"juhdanad","id":20600448,"avatar_url":"https://avatars.githubusercontent.com/u/20600448?v=3","gravatar_id":"","url":"https://api.github.com/users/juhdanad","html_url":"https://github.com/juhdanad","followers_url":"https://api.github.com/users/juhdanad/followers","following_url":"https://api.github.com/users/juhdanad/following{/other_user}","gists_url":"https://api.github.com/users/juhdanad/gists{/gist_id}","starred_url":"https://api.github.com/users/juhdanad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juhdanad/subscriptions","organizations_url":"https://api.github.com/users/juhdanad/orgs","repos_url":"https://api.github.com/users/juhdanad/repos","events_url":"https://api.github.com/users/juhdanad/events{/privacy}","received_events_url":"https://api.github.com/users/juhdanad/received_events","type":"User","site_admin":false},"created_at":"2017-01-09T20:45:17Z","updated_at":"2017-01-09T20:45:17Z","body":"No, @paramat everything works with and without shaders.\r\nThe only limitation is that old clients will not see the colors."}}
{"actor":{"display_login":"juhdanad"}}