{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/139290433","pull_request_review_id":63207281,"id":139290433,"diff_hunk":"@@ -740,7 +740,7 @@ ShaderCode GeneratePixelShaderCode(APIType ApiType, const ShaderHostConfig& host\n   }\n   else\n   {\n-    if (ApiType == APIType::D3D || ApiType == APIType::Vulkan)\n+    if (ApiType == APIType::D3D || !g_ActiveConfig.backend_info.bSupportsReversedDepthRange)","path":"Source/Core/VideoCommon/PixelShaderGen.cpp","position":5,"original_position":5,"commit_id":"230be26bb742acb7c32baa081b220a4a1ab8d142","original_commit_id":"230be26bb742acb7c32baa081b220a4a1ab8d142","user":{"login":"iwubcode","id":15224722,"avatar_url":"https://avatars1.githubusercontent.com/u/15224722?v=4","gravatar_id":"","url":"https://api.github.com/users/iwubcode","html_url":"https://github.com/iwubcode","followers_url":"https://api.github.com/users/iwubcode/followers","following_url":"https://api.github.com/users/iwubcode/following{/other_user}","gists_url":"https://api.github.com/users/iwubcode/gists{/gist_id}","starred_url":"https://api.github.com/users/iwubcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwubcode/subscriptions","organizations_url":"https://api.github.com/users/iwubcode/orgs","repos_url":"https://api.github.com/users/iwubcode/repos","events_url":"https://api.github.com/users/iwubcode/events{/privacy}","received_events_url":"https://api.github.com/users/iwubcode/received_events","type":"User","site_admin":false},"body":"Would it be cleaner to just set D3D to have no reversed depth range?  Maybe that's another PR..","created_at":"2017-09-16T16:43:55Z","updated_at":"2017-09-16T16:43:55Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/6067#discussion_r139290433","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6067","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/139290433"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/6067#discussion_r139290433"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6067"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6067","id":141436317,"html_url":"https://github.com/dolphin-emu/dolphin/pull/6067","diff_url":"https://github.com/dolphin-emu/dolphin/pull/6067.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/6067.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6067","number":6067,"state":"open","locked":false,"title":"Vulkan: Use reversed depth range in viewport","user":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars2.githubusercontent.com/u/11288319?v=4","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"body":"Matches OpenGL behavior and accuracy, fixes a few of these bugs. Still seems to be an issue rendering Gecko OS that I need to look into.\r\n\r\n**We need to verify that this works correctly on all drivers before merging.**\r\n\r\nI've tested the latest NV dev driver, 383.12, and it's fine here. But we should check older versions, AMD, and Intel, and add DriverDetails bugs if it does not work there.","created_at":"2017-09-16T07:01:13Z","updated_at":"2017-09-16T16:43:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc71e9c01c79cd593c5d28763336e16fee415068","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6067/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6067/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6067/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/230be26bb742acb7c32baa081b220a4a1ab8d142","head":{"label":"stenzek:vulkan-reversed-depth","ref":"vulkan-reversed-depth","sha":"230be26bb742acb7c32baa081b220a4a1ab8d142","user":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars2.githubusercontent.com/u/11288319?v=4","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"repo":{"id":46777992,"name":"dolphin","full_name":"stenzek/dolphin","owner":{"login":"stenzek","id":11288319,"avatar_url":"https://avatars2.githubusercontent.com/u/11288319?v=4","gravatar_id":"","url":"https://api.github.com/users/stenzek","html_url":"https://github.com/stenzek","followers_url":"https://api.github.com/users/stenzek/followers","following_url":"https://api.github.com/users/stenzek/following{/other_user}","gists_url":"https://api.github.com/users/stenzek/gists{/gist_id}","starred_url":"https://api.github.com/users/stenzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stenzek/subscriptions","organizations_url":"https://api.github.com/users/stenzek/orgs","repos_url":"https://api.github.com/users/stenzek/repos","events_url":"https://api.github.com/users/stenzek/events{/privacy}","received_events_url":"https://api.github.com/users/stenzek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stenzek/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/stenzek/dolphin","forks_url":"https://api.github.com/repos/stenzek/dolphin/forks","keys_url":"https://api.github.com/repos/stenzek/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stenzek/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stenzek/dolphin/teams","hooks_url":"https://api.github.com/repos/stenzek/dolphin/hooks","issue_events_url":"https://api.github.com/repos/stenzek/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/stenzek/dolphin/events","assignees_url":"https://api.github.com/repos/stenzek/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/stenzek/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/stenzek/dolphin/tags","blobs_url":"https://api.github.com/repos/stenzek/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stenzek/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stenzek/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/stenzek/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stenzek/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/stenzek/dolphin/languages","stargazers_url":"https://api.github.com/repos/stenzek/dolphin/stargazers","contributors_url":"https://api.github.com/repos/stenzek/dolphin/contributors","subscribers_url":"https://api.github.com/repos/stenzek/dolphin/subscribers","subscription_url":"https://api.github.com/repos/stenzek/dolphin/subscription","commits_url":"https://api.github.com/repos/stenzek/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/stenzek/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/stenzek/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/stenzek/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/stenzek/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/stenzek/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stenzek/dolphin/merges","archive_url":"https://api.github.com/repos/stenzek/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stenzek/dolphin/downloads","issues_url":"https://api.github.com/repos/stenzek/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/stenzek/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/stenzek/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/stenzek/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stenzek/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/stenzek/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/stenzek/dolphin/deployments","created_at":"2015-11-24T08:34:41Z","updated_at":"2017-05-30T22:35:50Z","pushed_at":"2017-09-16T07:00:53Z","git_url":"git://github.com/stenzek/dolphin.git","ssh_url":"git@github.com:stenzek/dolphin.git","clone_url":"https://github.com/stenzek/dolphin.git","svn_url":"https://github.com/stenzek/dolphin","homepage":"https://dolphin-emu.org/","size":313197,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"68baf7d8fc59f16e57040dd74c351d50cc1a039a","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-09-16T09:19:46Z","pushed_at":"2017-09-16T14:48:03Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":348844,"stargazers_count":3685,"watchers_count":3685,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":925,"mirror_url":null,"open_issues_count":135,"forks":925,"open_issues":135,"watchers":3685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6067"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/6067"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6067"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6067/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6067/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6067/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/230be26bb742acb7c32baa081b220a4a1ab8d142"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"iwubcode"}}