{"action":"created","issue":{"url":"https://api.github.com/repos/jwilder/nginx-proxy/issues/439","repository_url":"https://api.github.com/repos/jwilder/nginx-proxy","labels_url":"https://api.github.com/repos/jwilder/nginx-proxy/issues/439/labels{/name}","comments_url":"https://api.github.com/repos/jwilder/nginx-proxy/issues/439/comments","events_url":"https://api.github.com/repos/jwilder/nginx-proxy/issues/439/events","html_url":"https://github.com/jwilder/nginx-proxy/issues/439","id":152718320,"number":439,"title":"HTTP Connection header is not really cleared","user":{"login":"julianxhokaxhiu","id":1237070,"avatar_url":"https://avatars1.githubusercontent.com/u/1237070?v=3","gravatar_id":"","url":"https://api.github.com/users/julianxhokaxhiu","html_url":"https://github.com/julianxhokaxhiu","followers_url":"https://api.github.com/users/julianxhokaxhiu/followers","following_url":"https://api.github.com/users/julianxhokaxhiu/following{/other_user}","gists_url":"https://api.github.com/users/julianxhokaxhiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianxhokaxhiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianxhokaxhiu/subscriptions","organizations_url":"https://api.github.com/users/julianxhokaxhiu/orgs","repos_url":"https://api.github.com/users/julianxhokaxhiu/repos","events_url":"https://api.github.com/users/julianxhokaxhiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianxhokaxhiu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-05-03T07:51:09Z","updated_at":"2017-07-02T16:26:31Z","closed_at":null,"body":"Hi,\n\nI'm having a question related to this line:\n\nhttps://github.com/jwilder/nginx-proxy/blob/master/nginx.tmpl#L31\n\nReading the related comment on top, you're saying that if we're not getting an `Upgrade` header, we just clear them. But in fact you're not clearing it, you're just throwing `Close`.\n\nIs this on purpose? Actually this issue affects UI-for-Docker project. See https://github.com/kevana/ui-for-docker/issues/204\n\nI tested it and if I patch that line like this:\n\n```\n# If we receive Upgrade, set Connection to \"upgrade\"; otherwise, delete any\n# Connection header that may have been passed to this server\nmap $http_upgrade $proxy_connection {\n  default upgrade;\n  '' ''; # before: '' close;\n}\n```\n\nThen it works just fine. And it should exactly met the purpose of HTTP 1.1.\n\nI'm just trying to understand the drawbacks of this, if any. Thanks in advance for any help!\n"},"comment":{"url":"https://api.github.com/repos/jwilder/nginx-proxy/issues/comments/312501895","html_url":"https://github.com/jwilder/nginx-proxy/issues/439#issuecomment-312501895","issue_url":"https://api.github.com/repos/jwilder/nginx-proxy/issues/439","id":312501895,"user":{"login":"julianxhokaxhiu","id":1237070,"avatar_url":"https://avatars1.githubusercontent.com/u/1237070?v=3","gravatar_id":"","url":"https://api.github.com/users/julianxhokaxhiu","html_url":"https://github.com/julianxhokaxhiu","followers_url":"https://api.github.com/users/julianxhokaxhiu/followers","following_url":"https://api.github.com/users/julianxhokaxhiu/following{/other_user}","gists_url":"https://api.github.com/users/julianxhokaxhiu/gists{/gist_id}","starred_url":"https://api.github.com/users/julianxhokaxhiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianxhokaxhiu/subscriptions","organizations_url":"https://api.github.com/users/julianxhokaxhiu/orgs","repos_url":"https://api.github.com/users/julianxhokaxhiu/repos","events_url":"https://api.github.com/users/julianxhokaxhiu/events{/privacy}","received_events_url":"https://api.github.com/users/julianxhokaxhiu/received_events","type":"User","site_admin":false},"created_at":"2017-07-02T16:26:31Z","updated_at":"2017-07-02T16:26:31Z","body":"Any update on this? I still see that it has not been fixed. Why?"}}
{"actor":{"display_login":"julianxhokaxhiu"}}