{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/buildah/pulls/comments/150814107","pull_request_review_id":76418077,"id":150814107,"diff_hunk":"@@ -79,10 +79,12 @@ func runCmd(c *cli.Context) error {\n \t\tArgs:     c.StringSlice(\"runtime-flag\"),\n \t}\n \n-\tif c.Bool(\"tty\") {\n+\toptions.Terminal = buildah.DefaultTerminal\n+\tif c.IsSet(\"tty\") {\n \t\toptions.Terminal = buildah.WithTerminal\n-\t} else {\n-\t\toptions.Terminal = buildah.WithoutTerminal\n+\t\tif !c.Bool(\"tty\") {","path":"cmd/buildah/run.go","position":null,"original_position":10,"commit_id":"22a9e22e5fd38a34fdf9c8e97b840eaef06e65a7","original_commit_id":"91a7383e06ae327c089231618872fa4e1868a130","user":{"login":"TomSweeneyRedHat","id":25613829,"avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"body":"fixed, new version inc.","created_at":"2017-11-14T12:04:01Z","updated_at":"2017-11-14T12:04:01Z","html_url":"https://github.com/projectatomic/buildah/pull/323#discussion_r150814107","pull_request_url":"https://api.github.com/repos/projectatomic/buildah/pulls/323","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/comments/150814107"},"html":{"href":"https://github.com/projectatomic/buildah/pull/323#discussion_r150814107"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/323"}},"in_reply_to_id":150407449},"pull_request":{"url":"https://api.github.com/repos/projectatomic/buildah/pulls/323","id":152082452,"html_url":"https://github.com/projectatomic/buildah/pull/323","diff_url":"https://github.com/projectatomic/buildah/pull/323.diff","patch_url":"https://github.com/projectatomic/buildah/pull/323.patch","issue_url":"https://api.github.com/repos/projectatomic/buildah/issues/323","number":323,"state":"open","locked":false,"title":"Set option.terminal appropriately in run","user":{"login":"TomSweeneyRedHat","id":25613829,"avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"body":"Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>\r\n\r\nThe options.terminal field was never set to DefaultTerminal.  Unless the --tty was specified, the options.terminal field defaults to \"WithoutTerminal\" or the --tty=false value.  It should instead use the current terminal unless --tty is specified to use a pseudo terminal (or not).\r\n\r\nThis behaviour follows the man page description.\r\n\r\nTesting results.  Notice in the --tty=false case, there is not a prompt from the container.  Prior to this change that prompt was not present when the --tty parameter was not specified.  It is now present as illustrated in the fourth example.\r\n```\r\n[root@localhost buildah]# ./buildah run $container bash --tty=false\r\nexit\r\n[root@localhost buildah]# ./buildah run $container bash --tty=true\r\n[root@mrsdalloway /]# exit\r\nexit\r\n[root@localhost buildah]# ./buildah run $container bash --tty\r\n[root@mrsdalloway /]# exit\r\nexit\r\n[root@localhost buildah]# ./buildah run $container bash\r\n[root@mrsdalloway /]# exit\r\n```","created_at":"2017-11-12T00:43:15Z","updated_at":"2017-11-14T12:04:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"975d21a020e23ab092de35c5931b280513f5ea03","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/buildah/pulls/323/commits","review_comments_url":"https://api.github.com/repos/projectatomic/buildah/pulls/323/comments","review_comment_url":"https://api.github.com/repos/projectatomic/buildah/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/buildah/issues/323/comments","statuses_url":"https://api.github.com/repos/projectatomic/buildah/statuses/22a9e22e5fd38a34fdf9c8e97b840eaef06e65a7","head":{"label":"TomSweeneyRedHat:dev/tsweeney/termfix","ref":"dev/tsweeney/termfix","sha":"22a9e22e5fd38a34fdf9c8e97b840eaef06e65a7","user":{"login":"TomSweeneyRedHat","id":25613829,"avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"repo":{"id":85838433,"name":"buildah","full_name":"TomSweeneyRedHat/buildah","owner":{"login":"TomSweeneyRedHat","id":25613829,"avatar_url":"https://avatars3.githubusercontent.com/u/25613829?v=4","gravatar_id":"","url":"https://api.github.com/users/TomSweeneyRedHat","html_url":"https://github.com/TomSweeneyRedHat","followers_url":"https://api.github.com/users/TomSweeneyRedHat/followers","following_url":"https://api.github.com/users/TomSweeneyRedHat/following{/other_user}","gists_url":"https://api.github.com/users/TomSweeneyRedHat/gists{/gist_id}","starred_url":"https://api.github.com/users/TomSweeneyRedHat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomSweeneyRedHat/subscriptions","organizations_url":"https://api.github.com/users/TomSweeneyRedHat/orgs","repos_url":"https://api.github.com/users/TomSweeneyRedHat/repos","events_url":"https://api.github.com/users/TomSweeneyRedHat/events{/privacy}","received_events_url":"https://api.github.com/users/TomSweeneyRedHat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomSweeneyRedHat/buildah","description":"A tool which facilitates building OCI images","fork":true,"url":"https://api.github.com/repos/TomSweeneyRedHat/buildah","forks_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/forks","keys_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/teams","hooks_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/hooks","issue_events_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/issues/events{/number}","events_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/events","assignees_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/assignees{/user}","branches_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/branches{/branch}","tags_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/tags","blobs_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/statuses/{sha}","languages_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/languages","stargazers_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/stargazers","contributors_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/contributors","subscribers_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/subscribers","subscription_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/subscription","commits_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/contents/{+path}","compare_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/merges","archive_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/downloads","issues_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/issues{/number}","pulls_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/pulls{/number}","milestones_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/milestones{/number}","notifications_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/labels{/name}","releases_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/releases{/id}","deployments_url":"https://api.github.com/repos/TomSweeneyRedHat/buildah/deployments","created_at":"2017-03-22T14:34:57Z","updated_at":"2017-03-22T14:34:59Z","pushed_at":"2017-11-14T12:03:46Z","git_url":"git://github.com/TomSweeneyRedHat/buildah.git","ssh_url":"git@github.com:TomSweeneyRedHat/buildah.git","clone_url":"https://github.com/TomSweeneyRedHat/buildah.git","svn_url":"https://github.com/TomSweeneyRedHat/buildah","homepage":"","size":7888,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"d03123204dd59c6b760567e5b1d79def312cf441","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":80134675,"name":"buildah","full_name":"projectatomic/buildah","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/buildah","description":"A tool which facilitates building OCI images","fork":false,"url":"https://api.github.com/repos/projectatomic/buildah","forks_url":"https://api.github.com/repos/projectatomic/buildah/forks","keys_url":"https://api.github.com/repos/projectatomic/buildah/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/buildah/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/buildah/teams","hooks_url":"https://api.github.com/repos/projectatomic/buildah/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/buildah/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/buildah/events","assignees_url":"https://api.github.com/repos/projectatomic/buildah/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/buildah/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/buildah/tags","blobs_url":"https://api.github.com/repos/projectatomic/buildah/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/buildah/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/buildah/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/buildah/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/buildah/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/buildah/languages","stargazers_url":"https://api.github.com/repos/projectatomic/buildah/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/buildah/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/buildah/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/buildah/subscription","commits_url":"https://api.github.com/repos/projectatomic/buildah/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/buildah/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/buildah/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/buildah/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/buildah/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/buildah/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/buildah/merges","archive_url":"https://api.github.com/repos/projectatomic/buildah/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/buildah/downloads","issues_url":"https://api.github.com/repos/projectatomic/buildah/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/buildah/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/buildah/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/buildah/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/buildah/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/buildah/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/buildah/deployments","created_at":"2017-01-26T16:59:13Z","updated_at":"2017-11-14T09:47:56Z","pushed_at":"2017-11-14T12:03:47Z","git_url":"git://github.com/projectatomic/buildah.git","ssh_url":"git@github.com:projectatomic/buildah.git","clone_url":"https://github.com/projectatomic/buildah.git","svn_url":"https://github.com/projectatomic/buildah","homepage":"","size":7841,"stargazers_count":240,"watchers_count":240,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":35,"forks":36,"open_issues":35,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/323"},"html":{"href":"https://github.com/projectatomic/buildah/pull/323"},"issue":{"href":"https://api.github.com/repos/projectatomic/buildah/issues/323"},"comments":{"href":"https://api.github.com/repos/projectatomic/buildah/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/buildah/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/buildah/statuses/22a9e22e5fd38a34fdf9c8e97b840eaef06e65a7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"TomSweeneyRedHat"}}