{"action":"created","issue":{"url":"https://api.github.com/repos/keroserene/go-webrtc/issues/69","repository_url":"https://api.github.com/repos/keroserene/go-webrtc","labels_url":"https://api.github.com/repos/keroserene/go-webrtc/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/keroserene/go-webrtc/issues/69/comments","events_url":"https://api.github.com/repos/keroserene/go-webrtc/issues/69/events","html_url":"https://github.com/keroserene/go-webrtc/pull/69","id":262251727,"number":69,"title":"Webrtc win","user":{"login":"asicerik","id":5590257,"avatar_url":"https://avatars0.githubusercontent.com/u/5590257?v=4","gravatar_id":"","url":"https://api.github.com/users/asicerik","html_url":"https://github.com/asicerik","followers_url":"https://api.github.com/users/asicerik/followers","following_url":"https://api.github.com/users/asicerik/following{/other_user}","gists_url":"https://api.github.com/users/asicerik/gists{/gist_id}","starred_url":"https://api.github.com/users/asicerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asicerik/subscriptions","organizations_url":"https://api.github.com/users/asicerik/orgs","repos_url":"https://api.github.com/users/asicerik/repos","events_url":"https://api.github.com/users/asicerik/events{/privacy}","received_events_url":"https://api.github.com/users/asicerik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-02T22:44:17Z","updated_at":"2017-10-18T17:50:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/keroserene/go-webrtc/pulls/69","html_url":"https://github.com/keroserene/go-webrtc/pull/69","diff_url":"https://github.com/keroserene/go-webrtc/pull/69.diff","patch_url":"https://github.com/keroserene/go-webrtc/pull/69.patch"},"body":"Hey there! We needed a version of this to run under Windows, so I put in all the work to get DLL linkage in. Sooner or later, hopefully Google or MSFT will get their act together and get Go / CGO to work properly in Windows using Visual Studio.\r\n\r\nThe DLL approach is not the cleanest since we have to do: Go -> CGO -> Go -> DLL. I did not want to change your Go code to be able to access the DLL directly, so there is an extra layer of CGO there that we don't need. If we put an abstraction layer in the Go code, we could get rid of the CGO layer for Windows, but it introduces another layer in the POSIX code. So, I don't recommend that.\r\n\r\nWe are going to be working on Video and Audio with this library, so I hope to be able to continue to contribute to the project. If you are not happy with something here, let me know how you would like to see it done.\r\n\r\nI also made some changes to the test programs. It seems the enums were backwards w.r.t. expected vs. actual.\r\n\r\nThe DLL build in Visual Studio right now, but we could move that to a command line system if you wish.\r\nThanks!\r\nErik"},"comment":{"url":"https://api.github.com/repos/keroserene/go-webrtc/issues/comments/337673300","html_url":"https://github.com/keroserene/go-webrtc/pull/69#issuecomment-337673300","issue_url":"https://api.github.com/repos/keroserene/go-webrtc/issues/69","id":337673300,"user":{"login":"blizzardplus","id":1223784,"avatar_url":"https://avatars0.githubusercontent.com/u/1223784?v=4","gravatar_id":"","url":"https://api.github.com/users/blizzardplus","html_url":"https://github.com/blizzardplus","followers_url":"https://api.github.com/users/blizzardplus/followers","following_url":"https://api.github.com/users/blizzardplus/following{/other_user}","gists_url":"https://api.github.com/users/blizzardplus/gists{/gist_id}","starred_url":"https://api.github.com/users/blizzardplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blizzardplus/subscriptions","organizations_url":"https://api.github.com/users/blizzardplus/orgs","repos_url":"https://api.github.com/users/blizzardplus/repos","events_url":"https://api.github.com/users/blizzardplus/events{/privacy}","received_events_url":"https://api.github.com/users/blizzardplus/received_events","type":"User","site_admin":false},"created_at":"2017-10-18T17:50:20Z","updated_at":"2017-10-18T17:50:20Z","author_association":"NONE","body":"@asicerik:  In the latest commit, build_win.bat is removed, so how can I reproduce the build for webrtc.dll?\r\nWas it removed because it breaks the Linux build?\r\nAlso, we should not have the headers in the \"include\" folder in git. It should be generated as part of the build process."}}
{"actor":{"display_login":"blizzardplus"}}