{"action":"created","comment":{"url":"https://api.github.com/repos/typemytype/drawbot/pulls/comments/156662949","pull_request_review_id":83175466,"id":156662949,"diff_hunk":"@@ -152,19 +152,19 @@ def _testMultipage(self, extension, expectedMultipageCount):\n                 os.remove(path)\n \n     def test_multipage_png(self):\n-        self._testMultipage(\".png\", 5)\n+        self._testMultipage(\".png\", numFrames=5, expectedMultipageCount=5)\n \n     def test_multipage_jpg(self):\n-        self._testMultipage(\".jpg\", 5)\n+        self._testMultipage(\".jpg\", numFrames=5, expectedMultipageCount=5)\n \n     def test_multipage_svg(self):\n-        self._testMultipage(\".svg\", 5)\n+        self._testMultipage(\".svg\", numFrames=5, expectedMultipageCount=5)\n \n     def test_multipage_gif(self):\n-        self._testMultipage(\".gif\", 0)\n+        self._testMultipage(\".gif\", numFrames=5, expectedMultipageCount=0)\n \n     def test_multipage_pdf(self):\n-        self._testMultipage(\".pdf\", 0)\n+        self._testMultipage(\".pdf\", numFrames=5, expectedMultipageCount=0)","path":"tests/testExport.py","position":null,"original_position":32,"commit_id":"6fa90125a25c17ea5535b9ffeb42ce344a99003f","original_commit_id":"fe8645806c7f9a16f044dd3e679bc7fd46b16a50","user":{"login":"justvanrossum","id":4246121,"avatar_url":"https://avatars0.githubusercontent.com/u/4246121?v=4","gravatar_id":"","url":"https://api.github.com/users/justvanrossum","html_url":"https://github.com/justvanrossum","followers_url":"https://api.github.com/users/justvanrossum/followers","following_url":"https://api.github.com/users/justvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/justvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/justvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justvanrossum/subscriptions","organizations_url":"https://api.github.com/users/justvanrossum/orgs","repos_url":"https://api.github.com/users/justvanrossum/repos","events_url":"https://api.github.com/users/justvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/justvanrossum/received_events","type":"User","site_admin":false},"body":"What is being fixed in this commit?","created_at":"2017-12-13T13:49:15Z","updated_at":"2017-12-13T13:49:15Z","html_url":"https://github.com/typemytype/drawbot/pull/138#discussion_r156662949","pull_request_url":"https://api.github.com/repos/typemytype/drawbot/pulls/138","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/typemytype/drawbot/pulls/comments/156662949"},"html":{"href":"https://github.com/typemytype/drawbot/pull/138#discussion_r156662949"},"pull_request":{"href":"https://api.github.com/repos/typemytype/drawbot/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/typemytype/drawbot/pulls/138","id":157911359,"html_url":"https://github.com/typemytype/drawbot/pull/138","diff_url":"https://github.com/typemytype/drawbot/pull/138.diff","patch_url":"https://github.com/typemytype/drawbot/pull/138.patch","issue_url":"https://api.github.com/repos/typemytype/drawbot/issues/138","number":138,"state":"open","locked":false,"title":"Adding context-specific options to the saveImage() function","user":{"login":"justvanrossum","id":4246121,"avatar_url":"https://avatars0.githubusercontent.com/u/4246121?v=4","gravatar_id":"","url":"https://api.github.com/users/justvanrossum","html_url":"https://github.com/justvanrossum","followers_url":"https://api.github.com/users/justvanrossum/followers","following_url":"https://api.github.com/users/justvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/justvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/justvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justvanrossum/subscriptions","organizations_url":"https://api.github.com/users/justvanrossum/orgs","repos_url":"https://api.github.com/users/justvanrossum/repos","events_url":"https://api.github.com/users/justvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/justvanrossum/received_events","type":"User","site_admin":false},"body":"This PR (which is work in progress) adds the possibility to pass context-specific options via the saveImage() function.\r\n\r\nDocumentation needs to be done!\r\n\r\nRight now there are the following options:\r\n- `imageResolution`: specifies which resolution to render when creating pixel output (default is still at 72)\r\n\r\nSome properties from NSImage are mapped, see https://developer.apple.com/documentation/appkit/nsbitmapimagereppropertykey?language=objc\r\n- `imageColorSyncProfileData`\r\n- `imageJPEGCompressionFactor`\r\n- `imageTIFFCompressionMethod`\r\n- `imageGIFDitherTransparency`\r\n- `imageFallbackBackgroundColor`\r\n- `imagePNGGamma`\r\n- `imagePNGInterlaced`\r\n- `imageJPEGProgressive`\r\n- `imageGIFRGBColorTable`\r\n\r\nAnd there's (so far) one ffmpeg-specific option:\r\n- `ffmpegCodec`: specify which codec to use when making mp4 with ffmpeg\r\n","created_at":"2017-12-12T18:59:41Z","updated_at":"2017-12-13T13:49:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a743f87c8ff42997f58d32da4ad7760671bb46b0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/typemytype/drawbot/pulls/138/commits","review_comments_url":"https://api.github.com/repos/typemytype/drawbot/pulls/138/comments","review_comment_url":"https://api.github.com/repos/typemytype/drawbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/typemytype/drawbot/issues/138/comments","statuses_url":"https://api.github.com/repos/typemytype/drawbot/statuses/6fa90125a25c17ea5535b9ffeb42ce344a99003f","head":{"label":"typemytype:save-image-options","ref":"save-image-options","sha":"6fa90125a25c17ea5535b9ffeb42ce344a99003f","user":{"login":"typemytype","id":1190358,"avatar_url":"https://avatars1.githubusercontent.com/u/1190358?v=4","gravatar_id":"","url":"https://api.github.com/users/typemytype","html_url":"https://github.com/typemytype","followers_url":"https://api.github.com/users/typemytype/followers","following_url":"https://api.github.com/users/typemytype/following{/other_user}","gists_url":"https://api.github.com/users/typemytype/gists{/gist_id}","starred_url":"https://api.github.com/users/typemytype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typemytype/subscriptions","organizations_url":"https://api.github.com/users/typemytype/orgs","repos_url":"https://api.github.com/users/typemytype/repos","events_url":"https://api.github.com/users/typemytype/events{/privacy}","received_events_url":"https://api.github.com/users/typemytype/received_events","type":"User","site_admin":false},"repo":{"id":9649178,"name":"drawbot","full_name":"typemytype/drawbot","owner":{"login":"typemytype","id":1190358,"avatar_url":"https://avatars1.githubusercontent.com/u/1190358?v=4","gravatar_id":"","url":"https://api.github.com/users/typemytype","html_url":"https://github.com/typemytype","followers_url":"https://api.github.com/users/typemytype/followers","following_url":"https://api.github.com/users/typemytype/following{/other_user}","gists_url":"https://api.github.com/users/typemytype/gists{/gist_id}","starred_url":"https://api.github.com/users/typemytype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typemytype/subscriptions","organizations_url":"https://api.github.com/users/typemytype/orgs","repos_url":"https://api.github.com/users/typemytype/repos","events_url":"https://api.github.com/users/typemytype/events{/privacy}","received_events_url":"https://api.github.com/users/typemytype/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/typemytype/drawbot","description":null,"fork":false,"url":"https://api.github.com/repos/typemytype/drawbot","forks_url":"https://api.github.com/repos/typemytype/drawbot/forks","keys_url":"https://api.github.com/repos/typemytype/drawbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typemytype/drawbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typemytype/drawbot/teams","hooks_url":"https://api.github.com/repos/typemytype/drawbot/hooks","issue_events_url":"https://api.github.com/repos/typemytype/drawbot/issues/events{/number}","events_url":"https://api.github.com/repos/typemytype/drawbot/events","assignees_url":"https://api.github.com/repos/typemytype/drawbot/assignees{/user}","branches_url":"https://api.github.com/repos/typemytype/drawbot/branches{/branch}","tags_url":"https://api.github.com/repos/typemytype/drawbot/tags","blobs_url":"https://api.github.com/repos/typemytype/drawbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typemytype/drawbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typemytype/drawbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/typemytype/drawbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typemytype/drawbot/statuses/{sha}","languages_url":"https://api.github.com/repos/typemytype/drawbot/languages","stargazers_url":"https://api.github.com/repos/typemytype/drawbot/stargazers","contributors_url":"https://api.github.com/repos/typemytype/drawbot/contributors","subscribers_url":"https://api.github.com/repos/typemytype/drawbot/subscribers","subscription_url":"https://api.github.com/repos/typemytype/drawbot/subscription","commits_url":"https://api.github.com/repos/typemytype/drawbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/typemytype/drawbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/typemytype/drawbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/typemytype/drawbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/typemytype/drawbot/contents/{+path}","compare_url":"https://api.github.com/repos/typemytype/drawbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typemytype/drawbot/merges","archive_url":"https://api.github.com/repos/typemytype/drawbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typemytype/drawbot/downloads","issues_url":"https://api.github.com/repos/typemytype/drawbot/issues{/number}","pulls_url":"https://api.github.com/repos/typemytype/drawbot/pulls{/number}","milestones_url":"https://api.github.com/repos/typemytype/drawbot/milestones{/number}","notifications_url":"https://api.github.com/repos/typemytype/drawbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typemytype/drawbot/labels{/name}","releases_url":"https://api.github.com/repos/typemytype/drawbot/releases{/id}","deployments_url":"https://api.github.com/repos/typemytype/drawbot/deployments","created_at":"2013-04-24T14:08:44Z","updated_at":"2017-11-23T15:18:11Z","pushed_at":"2017-12-13T10:45:38Z","git_url":"git://github.com/typemytype/drawbot.git","ssh_url":"git@github.com:typemytype/drawbot.git","clone_url":"https://github.com/typemytype/drawbot.git","svn_url":"https://github.com/typemytype/drawbot","homepage":"http://www.drawbot.com","size":20190,"stargazers_count":102,"watchers_count":102,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":23,"open_issues":28,"watchers":102,"default_branch":"master"}},"base":{"label":"typemytype:master","ref":"master","sha":"c7d61e1767c185de53bc660e05daa727bcf2cc34","user":{"login":"typemytype","id":1190358,"avatar_url":"https://avatars1.githubusercontent.com/u/1190358?v=4","gravatar_id":"","url":"https://api.github.com/users/typemytype","html_url":"https://github.com/typemytype","followers_url":"https://api.github.com/users/typemytype/followers","following_url":"https://api.github.com/users/typemytype/following{/other_user}","gists_url":"https://api.github.com/users/typemytype/gists{/gist_id}","starred_url":"https://api.github.com/users/typemytype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typemytype/subscriptions","organizations_url":"https://api.github.com/users/typemytype/orgs","repos_url":"https://api.github.com/users/typemytype/repos","events_url":"https://api.github.com/users/typemytype/events{/privacy}","received_events_url":"https://api.github.com/users/typemytype/received_events","type":"User","site_admin":false},"repo":{"id":9649178,"name":"drawbot","full_name":"typemytype/drawbot","owner":{"login":"typemytype","id":1190358,"avatar_url":"https://avatars1.githubusercontent.com/u/1190358?v=4","gravatar_id":"","url":"https://api.github.com/users/typemytype","html_url":"https://github.com/typemytype","followers_url":"https://api.github.com/users/typemytype/followers","following_url":"https://api.github.com/users/typemytype/following{/other_user}","gists_url":"https://api.github.com/users/typemytype/gists{/gist_id}","starred_url":"https://api.github.com/users/typemytype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typemytype/subscriptions","organizations_url":"https://api.github.com/users/typemytype/orgs","repos_url":"https://api.github.com/users/typemytype/repos","events_url":"https://api.github.com/users/typemytype/events{/privacy}","received_events_url":"https://api.github.com/users/typemytype/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/typemytype/drawbot","description":null,"fork":false,"url":"https://api.github.com/repos/typemytype/drawbot","forks_url":"https://api.github.com/repos/typemytype/drawbot/forks","keys_url":"https://api.github.com/repos/typemytype/drawbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/typemytype/drawbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/typemytype/drawbot/teams","hooks_url":"https://api.github.com/repos/typemytype/drawbot/hooks","issue_events_url":"https://api.github.com/repos/typemytype/drawbot/issues/events{/number}","events_url":"https://api.github.com/repos/typemytype/drawbot/events","assignees_url":"https://api.github.com/repos/typemytype/drawbot/assignees{/user}","branches_url":"https://api.github.com/repos/typemytype/drawbot/branches{/branch}","tags_url":"https://api.github.com/repos/typemytype/drawbot/tags","blobs_url":"https://api.github.com/repos/typemytype/drawbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/typemytype/drawbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/typemytype/drawbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/typemytype/drawbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/typemytype/drawbot/statuses/{sha}","languages_url":"https://api.github.com/repos/typemytype/drawbot/languages","stargazers_url":"https://api.github.com/repos/typemytype/drawbot/stargazers","contributors_url":"https://api.github.com/repos/typemytype/drawbot/contributors","subscribers_url":"https://api.github.com/repos/typemytype/drawbot/subscribers","subscription_url":"https://api.github.com/repos/typemytype/drawbot/subscription","commits_url":"https://api.github.com/repos/typemytype/drawbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/typemytype/drawbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/typemytype/drawbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/typemytype/drawbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/typemytype/drawbot/contents/{+path}","compare_url":"https://api.github.com/repos/typemytype/drawbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/typemytype/drawbot/merges","archive_url":"https://api.github.com/repos/typemytype/drawbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/typemytype/drawbot/downloads","issues_url":"https://api.github.com/repos/typemytype/drawbot/issues{/number}","pulls_url":"https://api.github.com/repos/typemytype/drawbot/pulls{/number}","milestones_url":"https://api.github.com/repos/typemytype/drawbot/milestones{/number}","notifications_url":"https://api.github.com/repos/typemytype/drawbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/typemytype/drawbot/labels{/name}","releases_url":"https://api.github.com/repos/typemytype/drawbot/releases{/id}","deployments_url":"https://api.github.com/repos/typemytype/drawbot/deployments","created_at":"2013-04-24T14:08:44Z","updated_at":"2017-11-23T15:18:11Z","pushed_at":"2017-12-13T10:45:38Z","git_url":"git://github.com/typemytype/drawbot.git","ssh_url":"git@github.com:typemytype/drawbot.git","clone_url":"https://github.com/typemytype/drawbot.git","svn_url":"https://github.com/typemytype/drawbot","homepage":"http://www.drawbot.com","size":20190,"stargazers_count":102,"watchers_count":102,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":23,"open_issues":28,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/typemytype/drawbot/pulls/138"},"html":{"href":"https://github.com/typemytype/drawbot/pull/138"},"issue":{"href":"https://api.github.com/repos/typemytype/drawbot/issues/138"},"comments":{"href":"https://api.github.com/repos/typemytype/drawbot/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/typemytype/drawbot/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/typemytype/drawbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/typemytype/drawbot/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/typemytype/drawbot/statuses/6fa90125a25c17ea5535b9ffeb42ce344a99003f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"justvanrossum"}}