{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/105148389","pull_request_review_id":26012680,"id":105148389,"diff_hunk":"@@ -414,23 +414,16 @@ impl HTMLImageElement {\n     pub fn areas(&self) -> Option<Vec<Root<HTMLAreaElement>>> {\n         let elem = self.upcast::<Element>();\n         let usemap_attr;\n-        if elem.has_attribute(&LocalName::from(\"usemap\")) {\n-            usemap_attr = elem.get_string_attribute(&local_name!(\"usemap\"));\n-        } else {\n-            return None;\n+        if !elem.has_attribute(&LocalName::from(\"usemap\")) {\n+            return None\n         }\n+        usemap_attr = elem.get_string_attribute(&local_name!(\"usemap\"));\n \n         let (first, last) = usemap_attr.split_at(1);\n \n-        match first {\n-            \"#\" => {},\n-            _ => return None,\n-        };\n-\n-        match last.len() {\n-            0 => return None,\n-            _ => {},\n-        };\n+        if (first != \"#\") || (last.len() != 0) {","path":"components/script/dom/htmlimageelement.rs","position":24,"original_position":24,"commit_id":"7680b65e3f9a4e51161e6f9b8965be306c889bd3","original_commit_id":"7680b65e3f9a4e51161e6f9b8965be306c889bd3","user":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars2.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"body":"Let's drop the parentheses.","created_at":"2017-03-09T12:04:55Z","updated_at":"2017-03-09T12:05:12Z","html_url":"https://github.com/servo/servo/pull/15882#discussion_r105148389","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/15882","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/105148389"},"html":{"href":"https://github.com/servo/servo/pull/15882#discussion_r105148389"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/15882"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/15882","id":109896994,"html_url":"https://github.com/servo/servo/pull/15882","diff_url":"https://github.com/servo/servo/pull/15882.diff","patch_url":"https://github.com/servo/servo/pull/15882.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/15882","number":15882,"state":"open","locked":false,"title":"Clean up HTMLImageElement::areas","user":{"login":"ak1t0","id":6167442,"avatar_url":"https://avatars3.githubusercontent.com/u/6167442?v=3","gravatar_id":"","url":"https://api.github.com/users/ak1t0","html_url":"https://github.com/ak1t0","followers_url":"https://api.github.com/users/ak1t0/followers","following_url":"https://api.github.com/users/ak1t0/following{/other_user}","gists_url":"https://api.github.com/users/ak1t0/gists{/gist_id}","starred_url":"https://api.github.com/users/ak1t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak1t0/subscriptions","organizations_url":"https://api.github.com/users/ak1t0/orgs","repos_url":"https://api.github.com/users/ak1t0/repos","events_url":"https://api.github.com/users/ak1t0/events{/privacy}","received_events_url":"https://api.github.com/users/ak1t0/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #15835 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [X] These changes do not require tests because github issue says no tests needed.\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/15882)\n<!-- Reviewable:end -->\n","created_at":"2017-03-09T11:51:40Z","updated_at":"2017-03-09T12:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7890c1f8d5cc97c0dc98546636f8aede5ee5e142","assignee":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars1.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"assignees":[{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars1.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/15882/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/15882/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/15882/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/7680b65e3f9a4e51161e6f9b8965be306c889bd3","head":{"label":"ak1t0:clean-up-htmlimageelement","ref":"clean-up-htmlimageelement","sha":"7680b65e3f9a4e51161e6f9b8965be306c889bd3","user":{"login":"ak1t0","id":6167442,"avatar_url":"https://avatars3.githubusercontent.com/u/6167442?v=3","gravatar_id":"","url":"https://api.github.com/users/ak1t0","html_url":"https://github.com/ak1t0","followers_url":"https://api.github.com/users/ak1t0/followers","following_url":"https://api.github.com/users/ak1t0/following{/other_user}","gists_url":"https://api.github.com/users/ak1t0/gists{/gist_id}","starred_url":"https://api.github.com/users/ak1t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak1t0/subscriptions","organizations_url":"https://api.github.com/users/ak1t0/orgs","repos_url":"https://api.github.com/users/ak1t0/repos","events_url":"https://api.github.com/users/ak1t0/events{/privacy}","received_events_url":"https://api.github.com/users/ak1t0/received_events","type":"User","site_admin":false},"repo":{"id":84176649,"name":"servo","full_name":"ak1t0/servo","owner":{"login":"ak1t0","id":6167442,"avatar_url":"https://avatars3.githubusercontent.com/u/6167442?v=3","gravatar_id":"","url":"https://api.github.com/users/ak1t0","html_url":"https://github.com/ak1t0","followers_url":"https://api.github.com/users/ak1t0/followers","following_url":"https://api.github.com/users/ak1t0/following{/other_user}","gists_url":"https://api.github.com/users/ak1t0/gists{/gist_id}","starred_url":"https://api.github.com/users/ak1t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak1t0/subscriptions","organizations_url":"https://api.github.com/users/ak1t0/orgs","repos_url":"https://api.github.com/users/ak1t0/repos","events_url":"https://api.github.com/users/ak1t0/events{/privacy}","received_events_url":"https://api.github.com/users/ak1t0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ak1t0/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/ak1t0/servo","forks_url":"https://api.github.com/repos/ak1t0/servo/forks","keys_url":"https://api.github.com/repos/ak1t0/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ak1t0/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ak1t0/servo/teams","hooks_url":"https://api.github.com/repos/ak1t0/servo/hooks","issue_events_url":"https://api.github.com/repos/ak1t0/servo/issues/events{/number}","events_url":"https://api.github.com/repos/ak1t0/servo/events","assignees_url":"https://api.github.com/repos/ak1t0/servo/assignees{/user}","branches_url":"https://api.github.com/repos/ak1t0/servo/branches{/branch}","tags_url":"https://api.github.com/repos/ak1t0/servo/tags","blobs_url":"https://api.github.com/repos/ak1t0/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ak1t0/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ak1t0/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ak1t0/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ak1t0/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/ak1t0/servo/languages","stargazers_url":"https://api.github.com/repos/ak1t0/servo/stargazers","contributors_url":"https://api.github.com/repos/ak1t0/servo/contributors","subscribers_url":"https://api.github.com/repos/ak1t0/servo/subscribers","subscription_url":"https://api.github.com/repos/ak1t0/servo/subscription","commits_url":"https://api.github.com/repos/ak1t0/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ak1t0/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ak1t0/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ak1t0/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ak1t0/servo/contents/{+path}","compare_url":"https://api.github.com/repos/ak1t0/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ak1t0/servo/merges","archive_url":"https://api.github.com/repos/ak1t0/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ak1t0/servo/downloads","issues_url":"https://api.github.com/repos/ak1t0/servo/issues{/number}","pulls_url":"https://api.github.com/repos/ak1t0/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/ak1t0/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/ak1t0/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ak1t0/servo/labels{/name}","releases_url":"https://api.github.com/repos/ak1t0/servo/releases{/id}","deployments_url":"https://api.github.com/repos/ak1t0/servo/deployments","created_at":"2017-03-07T08:52:38Z","updated_at":"2017-03-07T07:22:13Z","pushed_at":"2017-03-09T11:13:36Z","git_url":"git://github.com/ak1t0/servo.git","ssh_url":"git@github.com:ak1t0/servo.git","clone_url":"https://github.com/ak1t0/servo.git","svn_url":"https://github.com/ak1t0/servo","homepage":"https://servo.org/","size":243597,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"1794c6673a80209e77c0c4205de072deac741b1f","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars2.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars2.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2017-03-09T11:39:01Z","pushed_at":"2017-03-09T11:52:07Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":300596,"stargazers_count":8927,"watchers_count":8927,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1514,"mirror_url":null,"open_issues_count":2129,"forks":1514,"open_issues":2129,"watchers":8927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/15882"},"html":{"href":"https://github.com/servo/servo/pull/15882"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/15882"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/15882/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/15882/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/15882/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/7680b65e3f9a4e51161e6f9b8965be306c889bd3"}}}}
{"actor":{"display_login":"Ms2ger"}}