{"action":"created","issue":{"url":"https://api.github.com/repos/fable-compiler/Fable/issues/795","repository_url":"https://api.github.com/repos/fable-compiler/Fable","labels_url":"https://api.github.com/repos/fable-compiler/Fable/issues/795/labels{/name}","comments_url":"https://api.github.com/repos/fable-compiler/Fable/issues/795/comments","events_url":"https://api.github.com/repos/fable-compiler/Fable/issues/795/events","html_url":"https://github.com/fable-compiler/Fable/pull/795","id":218828349,"number":795,"title":"[WIP] Tail-rec transformExpr","user":{"login":"cloudRoutine","id":680051,"avatar_url":"https://avatars0.githubusercontent.com/u/680051?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudRoutine","html_url":"https://github.com/cloudRoutine","followers_url":"https://api.github.com/users/cloudRoutine/followers","following_url":"https://api.github.com/users/cloudRoutine/following{/other_user}","gists_url":"https://api.github.com/users/cloudRoutine/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudRoutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudRoutine/subscriptions","organizations_url":"https://api.github.com/users/cloudRoutine/orgs","repos_url":"https://api.github.com/users/cloudRoutine/repos","events_url":"https://api.github.com/users/cloudRoutine/events{/privacy}","received_events_url":"https://api.github.com/users/cloudRoutine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-03T04:37:37Z","updated_at":"2017-04-03T08:03:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fable-compiler/Fable/pulls/795","html_url":"https://github.com/fable-compiler/Fable/pull/795","diff_url":"https://github.com/fable-compiler/Fable/pull/795.diff","patch_url":"https://github.com/fable-compiler/Fable/pull/795.patch"},"body":"I've been having all kinds of issues trying to get the tests to run properly, and the build to work but it just doesn't seem to be going right.\r\n\r\nThere are tail calls in the function body IL, but it's really complicated so I'm not totally sure this is enough to  prevent the stackoverflow.  \r\n\r\nI tried running the `ReproSO` target on the `repro-so` branch but it failed with\r\n\r\n```log\r\n> @ build C:\\Users\\jared\\Github\\Forks\\Fable\\src\\dotnet\\Fable.Client.Browser\\demo\r\n> node ../../../../node_modules/webpack/bin/webpack.js -p\r\n\r\nFable loader sent: C:\\Users\\jared\\Github\\Forks\\Fable\\src\\dotnet\\Fable.Client.Browser\\Fable.Client.Browser.fsproj\r\nHash: 3bbaa81f3b37d487b4aa\r\nVersion: webpack 2.3.2\r\nTime: 2183ms\r\n        Asset       Size  Chunks             Chunk Names\r\nbundle.min.js  844 bytes       0  [emitted]  main\r\n   [0] ../Fable.Client.Browser.fsproj 324 bytes {0} [built] [failed] [1 error]\r\n\r\nERROR in ../Fable.Client.Browser.fsproj\r\nModule build failed: Error: connect ECONNREFUSED 127.0.0.1:61225\r\nMake sure Fable server is running on port 61225\r\n    at client.send.then.catch.err (C:\\Users\\jared\\Github\\Forks\\Fable\\src\\typescript\\fable-loader\\index.js:85:22)\r\n    at process._tickCallback (internal/process/next_tick.js:109:7)\r\n\r\nnpm ERR! Windows_NT 10.0.15058\r\nnpm ERR! argv \"C:\\\\Program Files\\\\nodejs\\\\node.exe\" \"C:\\\\Users\\\\jared\\\\AppData\\\\Roaming\\\\npm\\\\node_modules\\\\npm\\\\bin\\\\npm-cli.js\" \"run\" \"build\"\r\nnpm ERR! node v7.8.0\r\nnpm ERR! npm  v3.10.9\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! @ build: `node ../../../../node_modules/webpack/bin/webpack.js -p`\r\nnpm ERR! Exit status 2\r\nnpm ERR!\r\nnpm ERR! Failed at the @ build script 'node ../../../../node_modules/webpack/bin/webpack.js -p'.\r\nnpm ERR! Make sure you have the latest version of node.js and npm installed.\r\nnpm ERR! If you do, this is most likely a problem with the  package,\r\nnpm ERR! not with npm itself.\r\nnpm ERR! Tell the author that this fails on your system:\r\nnpm ERR!     node ../../../../node_modules/webpack/bin/webpack.js -p\r\nnpm ERR! You can get information on how to open an issue for this project with:\r\nnpm ERR!     npm bugs\r\nnpm ERR! Or if that isn't available, you can get their info via:\r\nnpm ERR!     npm owner ls\r\nnpm ERR! There is likely additional logging output above.\r\nnpm WARN Local package.json exists, but node_modules missing, did you mean to install?\r\n\r\nnpm ERR! Please include the following file with any support request:\r\nnpm ERR!     C:\\Users\\jared\\Github\\Forks\\Fable\\src\\dotnet\\Fable.Client.Browser\\demo\\npm-debug.log\r\n```\r\n\r\n@alfonsogarciacaro could you give this a shot to see if it made a difference?\r\n\r\nIf it's still broken it'd be a huge help if you could setup a reproSO target on this branch, then I can get back to fixing it.\r\n "},"comment":{"url":"https://api.github.com/repos/fable-compiler/Fable/issues/comments/291074451","html_url":"https://github.com/fable-compiler/Fable/pull/795#issuecomment-291074451","issue_url":"https://api.github.com/repos/fable-compiler/Fable/issues/795","id":291074451,"user":{"login":"ncave","id":777696,"avatar_url":"https://avatars3.githubusercontent.com/u/777696?v=3","gravatar_id":"","url":"https://api.github.com/users/ncave","html_url":"https://github.com/ncave","followers_url":"https://api.github.com/users/ncave/followers","following_url":"https://api.github.com/users/ncave/following{/other_user}","gists_url":"https://api.github.com/users/ncave/gists{/gist_id}","starred_url":"https://api.github.com/users/ncave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncave/subscriptions","organizations_url":"https://api.github.com/users/ncave/orgs","repos_url":"https://api.github.com/users/ncave/repos","events_url":"https://api.github.com/users/ncave/events{/privacy}","received_events_url":"https://api.github.com/users/ncave/received_events","type":"User","site_admin":false},"created_at":"2017-04-03T08:03:39Z","updated_at":"2017-04-03T08:03:39Z","body":"@cloudRoutine If I copy the FSharp2Fable.fs changes from the PR to master and run the main build target (build \"All\") it fails some of the tests, so there may be something missing even if it fixes the SO (but the approach looks good)."}}
{"actor":{"display_login":"ncave"}}