{"action":"created","comment":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments/155237613","pull_request_review_id":81522283,"id":155237613,"diff_hunk":"@@ -14,7 +15,76 @@ import (\n \t\"golang.org/x/sys/unix\"\n )\n \n+type rng struct {\n+\trngName  string\n+\trngDev   string\n+\tdisabled bool","path":"pkg/rngd/cmd/rngd/main.go","position":15,"original_position":15,"commit_id":"839666a29d99f8e4343886c353c6a3fbd768d1ca","original_commit_id":"839666a29d99f8e4343886c353c6a3fbd768d1ca","user":{"login":"deitch","id":282526,"avatar_url":"https://avatars3.githubusercontent.com/u/282526?v=4","gravatar_id":"","url":"https://api.github.com/users/deitch","html_url":"https://github.com/deitch","followers_url":"https://api.github.com/users/deitch/followers","following_url":"https://api.github.com/users/deitch/following{/other_user}","gists_url":"https://api.github.com/users/deitch/gists{/gist_id}","starred_url":"https://api.github.com/users/deitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deitch/subscriptions","organizations_url":"https://api.github.com/users/deitch/orgs","repos_url":"https://api.github.com/users/deitch/repos","events_url":"https://api.github.com/users/deitch/events{/privacy}","received_events_url":"https://api.github.com/users/deitch/received_events","type":"User","site_admin":false},"body":"Should this not be `enabled`, so the default is false, and then you can enable it when an `init` succeeds?","created_at":"2017-12-06T13:37:28Z","updated_at":"2017-12-06T13:37:29Z","html_url":"https://github.com/linuxkit/linuxkit/pull/2785#discussion_r155237613","pull_request_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments/155237613"},"html":{"href":"https://github.com/linuxkit/linuxkit/pull/2785#discussion_r155237613"},"pull_request":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785"}}},"pull_request":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785","id":155527125,"html_url":"https://github.com/linuxkit/linuxkit/pull/2785","diff_url":"https://github.com/linuxkit/linuxkit/pull/2785.diff","patch_url":"https://github.com/linuxkit/linuxkit/pull/2785.patch","issue_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785","number":2785,"state":"open","locked":false,"title":"pkg: rngd service support on AArch64","user":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"body":"Enable the rngd service in case of a real hardware RNG\r\ndevice is available on AArch64 platform\r\n\r\nSigned-off-by: Dennis Chen <dennis.chen@arm.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/linuxkit/linuxkit/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nEnable the `rngd` service on AArch64 in case of a hardware RNG device available\r\n**- How I did it**\r\nCheck the `/dev/hwrng` and use it as the entropy source to feed the `/dev/random` if `/dev/hwrng` is the real character device of a RNG hardware.\r\n**- How to verify it**\r\n1. `linuxkit pkg build -org m1130 rngd/`\r\n2.  `docker run --privileged --rm --device /dev/hwrng m1130/rngd:842e5e8ece7934f0cab9fd0027b595ff3471e5b9-dirty`\r\n3. On an AArch64 platform which has a real RNG device such as Cavium ThunderX, we can see the `/sbin/rngd` is running inside the docker.\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![summit](https://user-images.githubusercontent.com/29669302/33416678-d033975e-d5d8-11e7-9c82-48a80afded73.jpg)\r\n","created_at":"2017-11-30T06:16:42Z","updated_at":"2017-12-06T13:37:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5b87917204b5d75cbdaf50b46eb29ef5500c649","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785/commits","review_comments_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785/comments","review_comment_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785/comments","statuses_url":"https://api.github.com/repos/linuxkit/linuxkit/statuses/839666a29d99f8e4343886c353c6a3fbd768d1ca","head":{"label":"arm64b:rngd-aarch64","ref":"rngd-aarch64","sha":"839666a29d99f8e4343886c353c6a3fbd768d1ca","user":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"repo":{"id":96370585,"name":"linuxkit-arm64","full_name":"arm64b/linuxkit-arm64","owner":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arm64b/linuxkit-arm64","description":"A toolkit for building secure, portable and lean operating systems for containers on ARM64 platforms.","fork":true,"url":"https://api.github.com/repos/arm64b/linuxkit-arm64","forks_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/forks","keys_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/teams","hooks_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/hooks","issue_events_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/issues/events{/number}","events_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/events","assignees_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/assignees{/user}","branches_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/branches{/branch}","tags_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/tags","blobs_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/git/refs{/sha}","trees_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/statuses/{sha}","languages_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/languages","stargazers_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/stargazers","contributors_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/contributors","subscribers_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/subscribers","subscription_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/subscription","commits_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/commits{/sha}","git_commits_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/git/commits{/sha}","comments_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/comments{/number}","issue_comment_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/issues/comments{/number}","contents_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/contents/{+path}","compare_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/merges","archive_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/downloads","issues_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/issues{/number}","pulls_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/pulls{/number}","milestones_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/milestones{/number}","notifications_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/labels{/name}","releases_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/releases{/id}","deployments_url":"https://api.github.com/repos/arm64b/linuxkit-arm64/deployments","created_at":"2017-07-05T23:58:56Z","updated_at":"2017-11-20T05:54:39Z","pushed_at":"2017-12-04T06:20:25Z","git_url":"git://github.com/arm64b/linuxkit-arm64.git","ssh_url":"git@github.com:arm64b/linuxkit-arm64.git","clone_url":"https://github.com/arm64b/linuxkit-arm64.git","svn_url":"https://github.com/arm64b/linuxkit-arm64","homepage":"","size":24630,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"linuxkit:master","ref":"master","sha":"090abf3254ce8a50decad089d8aa9dff4e2299df","user":{"login":"linuxkit","id":27256246,"avatar_url":"https://avatars2.githubusercontent.com/u/27256246?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxkit","html_url":"https://github.com/linuxkit","followers_url":"https://api.github.com/users/linuxkit/followers","following_url":"https://api.github.com/users/linuxkit/following{/other_user}","gists_url":"https://api.github.com/users/linuxkit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxkit/subscriptions","organizations_url":"https://api.github.com/users/linuxkit/orgs","repos_url":"https://api.github.com/users/linuxkit/repos","events_url":"https://api.github.com/users/linuxkit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxkit/received_events","type":"Organization","site_admin":false},"repo":{"id":46932243,"name":"linuxkit","full_name":"linuxkit/linuxkit","owner":{"login":"linuxkit","id":27256246,"avatar_url":"https://avatars2.githubusercontent.com/u/27256246?v=4","gravatar_id":"","url":"https://api.github.com/users/linuxkit","html_url":"https://github.com/linuxkit","followers_url":"https://api.github.com/users/linuxkit/followers","following_url":"https://api.github.com/users/linuxkit/following{/other_user}","gists_url":"https://api.github.com/users/linuxkit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxkit/subscriptions","organizations_url":"https://api.github.com/users/linuxkit/orgs","repos_url":"https://api.github.com/users/linuxkit/repos","events_url":"https://api.github.com/users/linuxkit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linuxkit/linuxkit","description":"A toolkit for building secure, portable and lean operating systems for containers","fork":false,"url":"https://api.github.com/repos/linuxkit/linuxkit","forks_url":"https://api.github.com/repos/linuxkit/linuxkit/forks","keys_url":"https://api.github.com/repos/linuxkit/linuxkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linuxkit/linuxkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linuxkit/linuxkit/teams","hooks_url":"https://api.github.com/repos/linuxkit/linuxkit/hooks","issue_events_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/events{/number}","events_url":"https://api.github.com/repos/linuxkit/linuxkit/events","assignees_url":"https://api.github.com/repos/linuxkit/linuxkit/assignees{/user}","branches_url":"https://api.github.com/repos/linuxkit/linuxkit/branches{/branch}","tags_url":"https://api.github.com/repos/linuxkit/linuxkit/tags","blobs_url":"https://api.github.com/repos/linuxkit/linuxkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linuxkit/linuxkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linuxkit/linuxkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/linuxkit/linuxkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linuxkit/linuxkit/statuses/{sha}","languages_url":"https://api.github.com/repos/linuxkit/linuxkit/languages","stargazers_url":"https://api.github.com/repos/linuxkit/linuxkit/stargazers","contributors_url":"https://api.github.com/repos/linuxkit/linuxkit/contributors","subscribers_url":"https://api.github.com/repos/linuxkit/linuxkit/subscribers","subscription_url":"https://api.github.com/repos/linuxkit/linuxkit/subscription","commits_url":"https://api.github.com/repos/linuxkit/linuxkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/linuxkit/linuxkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/linuxkit/linuxkit/contents/{+path}","compare_url":"https://api.github.com/repos/linuxkit/linuxkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linuxkit/linuxkit/merges","archive_url":"https://api.github.com/repos/linuxkit/linuxkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linuxkit/linuxkit/downloads","issues_url":"https://api.github.com/repos/linuxkit/linuxkit/issues{/number}","pulls_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls{/number}","milestones_url":"https://api.github.com/repos/linuxkit/linuxkit/milestones{/number}","notifications_url":"https://api.github.com/repos/linuxkit/linuxkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linuxkit/linuxkit/labels{/name}","releases_url":"https://api.github.com/repos/linuxkit/linuxkit/releases{/id}","deployments_url":"https://api.github.com/repos/linuxkit/linuxkit/deployments","created_at":"2015-11-26T14:48:52Z","updated_at":"2017-12-05T16:10:23Z","pushed_at":"2017-12-06T13:23:47Z","git_url":"git://github.com/linuxkit/linuxkit.git","ssh_url":"git@github.com:linuxkit/linuxkit.git","clone_url":"https://github.com/linuxkit/linuxkit.git","svn_url":"https://github.com/linuxkit/linuxkit","homepage":"","size":24670,"stargazers_count":3608,"watchers_count":3608,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":424,"mirror_url":null,"archived":false,"open_issues_count":179,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":424,"open_issues":179,"watchers":3608,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785"},"html":{"href":"https://github.com/linuxkit/linuxkit/pull/2785"},"issue":{"href":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785"},"comments":{"href":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785/comments"},"review_comments":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785/comments"},"review_comment":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785/commits"},"statuses":{"href":"https://api.github.com/repos/linuxkit/linuxkit/statuses/839666a29d99f8e4343886c353c6a3fbd768d1ca"}},"author_association":"NONE"}}
{"actor":{"display_login":"deitch"}}