{"action":"created","issue":{"url":"https://api.github.com/repos/resin-io/etcher/issues/1597","repository_url":"https://api.github.com/repos/resin-io/etcher","labels_url":"https://api.github.com/repos/resin-io/etcher/issues/1597/labels{/name}","comments_url":"https://api.github.com/repos/resin-io/etcher/issues/1597/comments","events_url":"https://api.github.com/repos/resin-io/etcher/issues/1597/events","html_url":"https://github.com/resin-io/etcher/pull/1597","id":242836834,"number":1597,"title":"refactor(GUI): make settings model setter asynchronous","user":{"login":"jviotti","id":2192773,"avatar_url":"https://avatars0.githubusercontent.com/u/2192773?v=4","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-07-13T21:32:17Z","updated_at":"2017-08-01T14:25:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/resin-io/etcher/pulls/1597","html_url":"https://github.com/resin-io/etcher/pull/1597","diff_url":"https://github.com/resin-io/etcher/pull/1597.diff","patch_url":"https://github.com/resin-io/etcher/pull/1597.patch"},"body":"This is part of the process of implementing support for a configuration\nfile. We previously decoupled the Redux store from localStorage by\nmoving the logic that actually persists the data to localStorage to a\nlocal-settings.js file, however the localStorage API is synchronous, so\nit follows that at the moment, all functions that interact with are also\nsynchronous.\n\nMoving to storing the settings to a file means turning all these\nfunctions to promises, which we do in this commit, in order to not mix\nthe addition of the configuration file feature with the huge amount of\nrefactoring it requires.\n\nSee: https://github.com/resin-io/etcher/issues/1356\nChange-Type: patch\nSigned-off-by: Juan Cruz Viotti <jv@jviotti.com>"},"comment":{"url":"https://api.github.com/repos/resin-io/etcher/issues/comments/319385821","html_url":"https://github.com/resin-io/etcher/pull/1597#issuecomment-319385821","issue_url":"https://api.github.com/repos/resin-io/etcher/issues/1597","id":319385821,"user":{"login":"jviotti","id":2192773,"avatar_url":"https://avatars0.githubusercontent.com/u/2192773?v=4","gravatar_id":"","url":"https://api.github.com/users/jviotti","html_url":"https://github.com/jviotti","followers_url":"https://api.github.com/users/jviotti/followers","following_url":"https://api.github.com/users/jviotti/following{/other_user}","gists_url":"https://api.github.com/users/jviotti/gists{/gist_id}","starred_url":"https://api.github.com/users/jviotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviotti/subscriptions","organizations_url":"https://api.github.com/users/jviotti/orgs","repos_url":"https://api.github.com/users/jviotti/repos","events_url":"https://api.github.com/users/jviotti/events{/privacy}","received_events_url":"https://api.github.com/users/jviotti/received_events","type":"User","site_admin":false},"created_at":"2017-08-01T14:25:13Z","updated_at":"2017-08-01T14:25:13Z","body":"Is this good to merge?"}}
{"actor":{"display_login":"jviotti"}}