{"action":"created","comment":{"url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/comments/140438006","pull_request_review_id":64512600,"id":140438006,"diff_hunk":"@@ -9,5 +9,6 @@ target*\n .externalToolBuilders\n datasources/\n files.txz\n+scripts.txz","path":".gitignore","position":4,"original_position":4,"commit_id":"5721872ebb5db68dce60c16fbae634a3d9fe17d7","original_commit_id":"5721872ebb5db68dce60c16fbae634a3d9fe17d7","user":{"login":"fanf","id":44649,"avatar_url":"https://avatars1.githubusercontent.com/u/44649?v=4","gravatar_id":"","url":"https://api.github.com/users/fanf","html_url":"https://github.com/fanf","followers_url":"https://api.github.com/users/fanf/followers","following_url":"https://api.github.com/users/fanf/following{/other_user}","gists_url":"https://api.github.com/users/fanf/gists{/gist_id}","starred_url":"https://api.github.com/users/fanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanf/subscriptions","organizations_url":"https://api.github.com/users/fanf/orgs","repos_url":"https://api.github.com/users/fanf/repos","events_url":"https://api.github.com/users/fanf/events{/privacy}","received_events_url":"https://api.github.com/users/fanf/received_events","type":"User","site_admin":false},"body":"because it was not included in the gitignore but is a side product of compilation. It must not be commited. ","created_at":"2017-09-22T08:31:26Z","updated_at":"2017-09-22T08:31:26Z","html_url":"https://github.com/Normation/rudder-plugin-datasources/pull/29#discussion_r140438006","pull_request_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/29","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/comments/140438006"},"html":{"href":"https://github.com/Normation/rudder-plugin-datasources/pull/29#discussion_r140438006"},"pull_request":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/29"}},"in_reply_to_id":140434761},"pull_request":{"url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/29","id":142381030,"html_url":"https://github.com/Normation/rudder-plugin-datasources/pull/29","diff_url":"https://github.com/Normation/rudder-plugin-datasources/pull/29.diff","patch_url":"https://github.com/Normation/rudder-plugin-datasources/pull/29.patch","issue_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/issues/29","number":29,"state":"open","locked":false,"title":"Fixes #11412: Can not delete a node property set by datasources","user":{"login":"fanf","id":44649,"avatar_url":"https://avatars1.githubusercontent.com/u/44649?v=4","gravatar_id":"","url":"https://api.github.com/users/fanf","html_url":"https://github.com/fanf","followers_url":"https://api.github.com/users/fanf/followers","following_url":"https://api.github.com/users/fanf/following{/other_user}","gists_url":"https://api.github.com/users/fanf/gists{/gist_id}","starred_url":"https://api.github.com/users/fanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanf/subscriptions","organizations_url":"https://api.github.com/users/fanf/orgs","repos_url":"https://api.github.com/users/fanf/repos","events_url":"https://api.github.com/users/fanf/events{/privacy}","received_events_url":"https://api.github.com/users/fanf/received_events","type":"User","site_admin":false},"body":"https://www.rudder-project.org/redmine/issues/11412","created_at":"2017-09-21T15:53:09Z","updated_at":"2017-09-22T08:31:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e40b352a50757cb685fec79a532d669f47df5b8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/29/commits","review_comments_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/29/comments","review_comment_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/issues/29/comments","statuses_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/statuses/5721872ebb5db68dce60c16fbae634a3d9fe17d7","head":{"label":"fanf:bug_11412/can_not_delete_a_node_property_set_by_datasources","ref":"bug_11412/can_not_delete_a_node_property_set_by_datasources","sha":"5721872ebb5db68dce60c16fbae634a3d9fe17d7","user":{"login":"fanf","id":44649,"avatar_url":"https://avatars1.githubusercontent.com/u/44649?v=4","gravatar_id":"","url":"https://api.github.com/users/fanf","html_url":"https://github.com/fanf","followers_url":"https://api.github.com/users/fanf/followers","following_url":"https://api.github.com/users/fanf/following{/other_user}","gists_url":"https://api.github.com/users/fanf/gists{/gist_id}","starred_url":"https://api.github.com/users/fanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanf/subscriptions","organizations_url":"https://api.github.com/users/fanf/orgs","repos_url":"https://api.github.com/users/fanf/repos","events_url":"https://api.github.com/users/fanf/events{/privacy}","received_events_url":"https://api.github.com/users/fanf/received_events","type":"User","site_admin":false},"repo":{"id":81084699,"name":"rudder-plugin-datasources","full_name":"fanf/rudder-plugin-datasources","owner":{"login":"fanf","id":44649,"avatar_url":"https://avatars1.githubusercontent.com/u/44649?v=4","gravatar_id":"","url":"https://api.github.com/users/fanf","html_url":"https://github.com/fanf","followers_url":"https://api.github.com/users/fanf/followers","following_url":"https://api.github.com/users/fanf/following{/other_user}","gists_url":"https://api.github.com/users/fanf/gists{/gist_id}","starred_url":"https://api.github.com/users/fanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanf/subscriptions","organizations_url":"https://api.github.com/users/fanf/orgs","repos_url":"https://api.github.com/users/fanf/repos","events_url":"https://api.github.com/users/fanf/events{/privacy}","received_events_url":"https://api.github.com/users/fanf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fanf/rudder-plugin-datasources","description":"This plugin allows to retrieve information from REST server and use them as Node Properties","fork":true,"url":"https://api.github.com/repos/fanf/rudder-plugin-datasources","forks_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/forks","keys_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/teams","hooks_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/hooks","issue_events_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/issues/events{/number}","events_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/events","assignees_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/assignees{/user}","branches_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/branches{/branch}","tags_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/tags","blobs_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/statuses/{sha}","languages_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/languages","stargazers_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/stargazers","contributors_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/contributors","subscribers_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/subscribers","subscription_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/subscription","commits_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/contents/{+path}","compare_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/merges","archive_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/downloads","issues_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/issues{/number}","pulls_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/pulls{/number}","milestones_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/milestones{/number}","notifications_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/labels{/name}","releases_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/releases{/id}","deployments_url":"https://api.github.com/repos/fanf/rudder-plugin-datasources/deployments","created_at":"2017-02-06T12:25:27Z","updated_at":"2017-02-06T12:25:28Z","pushed_at":"2017-09-21T15:53:07Z","git_url":"git://github.com/fanf/rudder-plugin-datasources.git","ssh_url":"git@github.com:fanf/rudder-plugin-datasources.git","clone_url":"https://github.com/fanf/rudder-plugin-datasources.git","svn_url":"https://github.com/fanf/rudder-plugin-datasources","homepage":null,"size":141,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"branches/rudder/4.1"}},"base":{"label":"Normation:branches/rudder/4.1","ref":"branches/rudder/4.1","sha":"03f01b2277788019fb8f8c46ac2acfdb2cb7e3a6","user":{"login":"Normation","id":695105,"avatar_url":"https://avatars3.githubusercontent.com/u/695105?v=4","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"repo":{"id":80202601,"name":"rudder-plugin-datasources","full_name":"Normation/rudder-plugin-datasources","owner":{"login":"Normation","id":695105,"avatar_url":"https://avatars3.githubusercontent.com/u/695105?v=4","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Normation/rudder-plugin-datasources","description":"This plugin allows to retrieve information from REST server and use them as Node Properties","fork":false,"url":"https://api.github.com/repos/Normation/rudder-plugin-datasources","forks_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/forks","keys_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/teams","hooks_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/hooks","issue_events_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/issues/events{/number}","events_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/events","assignees_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/assignees{/user}","branches_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/branches{/branch}","tags_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/tags","blobs_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/git/refs{/sha}","trees_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/statuses/{sha}","languages_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/languages","stargazers_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/stargazers","contributors_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/contributors","subscribers_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/subscribers","subscription_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/subscription","commits_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/commits{/sha}","git_commits_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/git/commits{/sha}","comments_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/comments{/number}","issue_comment_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/issues/comments{/number}","contents_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/contents/{+path}","compare_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/merges","archive_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/downloads","issues_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/issues{/number}","pulls_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls{/number}","milestones_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/milestones{/number}","notifications_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/labels{/name}","releases_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/releases{/id}","deployments_url":"https://api.github.com/repos/Normation/rudder-plugin-datasources/deployments","created_at":"2017-01-27T11:35:37Z","updated_at":"2017-03-20T15:32:21Z","pushed_at":"2017-09-21T15:53:09Z","git_url":"git://github.com/Normation/rudder-plugin-datasources.git","ssh_url":"git@github.com:Normation/rudder-plugin-datasources.git","clone_url":"https://github.com/Normation/rudder-plugin-datasources.git","svn_url":"https://github.com/Normation/rudder-plugin-datasources","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":0,"default_branch":"branches/rudder/4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/29"},"html":{"href":"https://github.com/Normation/rudder-plugin-datasources/pull/29"},"issue":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/issues/29"},"comments":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/Normation/rudder-plugin-datasources/statuses/5721872ebb5db68dce60c16fbae634a3d9fe17d7"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fanf"}}