{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/146142981","pull_request_review_id":71043845,"id":146142981,"diff_hunk":"@@ -446,8 +446,11 @@ describe('systemlist()', function()\n     after_each(delete_file(fname))\n \n     it('replaces NULs by newline characters', function()\n-      if helpers.pending_win32(pending) then return end\n-      eq({'part1\\npart2\\npart3'}, eval('systemlist(\"cat '..fname..'\")'))\n+      if iswin() then\n+        eq({'part1\\npart2\\npart3\\r'}, eval('systemlist(\"type '..fname..'\")'))","path":"test/functional/eval/system_spec.lua","position":7,"original_position":7,"commit_id":"c58f779741f9882632ebfebe771aa939efd5e0df","original_commit_id":"c58f779741f9882632ebfebe771aa939efd5e0df","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars0.githubusercontent.com/u/1359421?v=4","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":"can't we use `cat` on windows?","created_at":"2017-10-22T20:21:30Z","updated_at":"2017-10-22T20:21:30Z","html_url":"https://github.com/neovim/neovim/pull/7412#discussion_r146142981","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/7412","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/146142981"},"html":{"href":"https://github.com/neovim/neovim/pull/7412#discussion_r146142981"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/7412"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/7412","id":147464680,"html_url":"https://github.com/neovim/neovim/pull/7412","diff_url":"https://github.com/neovim/neovim/pull/7412.diff","patch_url":"https://github.com/neovim/neovim/pull/7412.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/7412","number":7412,"state":"open","locked":false,"title":"[RDY] Enable more tests in Windows","user":{"login":"janlazo","id":8740057,"avatar_url":"https://avatars0.githubusercontent.com/u/8740057?v=4","gravatar_id":"","url":"https://api.github.com/users/janlazo","html_url":"https://github.com/janlazo","followers_url":"https://api.github.com/users/janlazo/followers","following_url":"https://api.github.com/users/janlazo/following{/other_user}","gists_url":"https://api.github.com/users/janlazo/gists{/gist_id}","starred_url":"https://api.github.com/users/janlazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janlazo/subscriptions","organizations_url":"https://api.github.com/users/janlazo/orgs","repos_url":"https://api.github.com/users/janlazo/repos","events_url":"https://api.github.com/users/janlazo/events{/privacy}","received_events_url":"https://api.github.com/users/janlazo/received_events","type":"User","site_admin":false},"body":"Unlike https://github.com/neovim/neovim/pull/7343, this PR focuses on tests only.\r\n\r\nThe following types of tests cannot be enabled:\r\n- jobstart + jobsend/jobpid/jobclose\r\n   - desync with cat.exe so testing is limited to jobstart only\r\n   - `jobpid(jobstart(['cat', '-'))` is unreliable\r\n- nested terminals (or nvim)\r\n  - fails with `\"-u NONE --cmd '\" .. nvim_set .. \"'\"` (how?)\r\n  - screen highlight\r\n- autocmd + (terminal or jobstart)\r\n  - possible race condition\r\n- screen with highlights\r\n  - cannot enable `ui/` with tests that expect `{4:~`\r\n- xterm codes (what about winpty?)\r\n- errors for opening a directory\r\n  - Vim outputs the expected message from the shortmess test\r\n  - Neovim attempts to edit it (?) and gets read errors.\r\n- os.remove()\r\n   - does not work with directories and read-only files in Windows\r\n   - need a helper function to run on cmd.exe (perhaps os.execute()?)\r\n- delete()\r\n  - do not use with working directories in Windows\r\n\r\nI don't know why the Appveyor builds hang when I use `helpers.get_pathsep()` so I hardcode the value of `pathsep` local variable in tests that check filepaths such as test/functional/ex_cmds/cd_spec.lua\r\n\r\n~~To minimize diffs, I use `set fileformat=unix` or the `++opt` variant.~~ `\\r\\n` as eol in Windows is enough for shada on BufWriteCmd, FileAppendCmd, and FileWriteCmd. For some reason, `:w!` is required in FileWriteCmd after os.remove in before_each() and teardown().","created_at":"2017-10-19T04:25:29Z","updated_at":"2017-10-22T20:21:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42ea5dc58ff0fc5c87cd25684ba96b6b74a22df2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/7412/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/7412/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/7412/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/c58f779741f9882632ebfebe771aa939efd5e0df","head":{"label":"janlazo:win_test_enable","ref":"win_test_enable","sha":"c58f779741f9882632ebfebe771aa939efd5e0df","user":{"login":"janlazo","id":8740057,"avatar_url":"https://avatars0.githubusercontent.com/u/8740057?v=4","gravatar_id":"","url":"https://api.github.com/users/janlazo","html_url":"https://github.com/janlazo","followers_url":"https://api.github.com/users/janlazo/followers","following_url":"https://api.github.com/users/janlazo/following{/other_user}","gists_url":"https://api.github.com/users/janlazo/gists{/gist_id}","starred_url":"https://api.github.com/users/janlazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janlazo/subscriptions","organizations_url":"https://api.github.com/users/janlazo/orgs","repos_url":"https://api.github.com/users/janlazo/repos","events_url":"https://api.github.com/users/janlazo/events{/privacy}","received_events_url":"https://api.github.com/users/janlazo/received_events","type":"User","site_admin":false},"repo":{"id":89661200,"name":"neovim","full_name":"janlazo/neovim","owner":{"login":"janlazo","id":8740057,"avatar_url":"https://avatars0.githubusercontent.com/u/8740057?v=4","gravatar_id":"","url":"https://api.github.com/users/janlazo","html_url":"https://github.com/janlazo","followers_url":"https://api.github.com/users/janlazo/followers","following_url":"https://api.github.com/users/janlazo/following{/other_user}","gists_url":"https://api.github.com/users/janlazo/gists{/gist_id}","starred_url":"https://api.github.com/users/janlazo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janlazo/subscriptions","organizations_url":"https://api.github.com/users/janlazo/orgs","repos_url":"https://api.github.com/users/janlazo/repos","events_url":"https://api.github.com/users/janlazo/events{/privacy}","received_events_url":"https://api.github.com/users/janlazo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janlazo/neovim","description":"Vim-fork focused on extensibility and usability.","fork":true,"url":"https://api.github.com/repos/janlazo/neovim","forks_url":"https://api.github.com/repos/janlazo/neovim/forks","keys_url":"https://api.github.com/repos/janlazo/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janlazo/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janlazo/neovim/teams","hooks_url":"https://api.github.com/repos/janlazo/neovim/hooks","issue_events_url":"https://api.github.com/repos/janlazo/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/janlazo/neovim/events","assignees_url":"https://api.github.com/repos/janlazo/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/janlazo/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/janlazo/neovim/tags","blobs_url":"https://api.github.com/repos/janlazo/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janlazo/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janlazo/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/janlazo/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janlazo/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/janlazo/neovim/languages","stargazers_url":"https://api.github.com/repos/janlazo/neovim/stargazers","contributors_url":"https://api.github.com/repos/janlazo/neovim/contributors","subscribers_url":"https://api.github.com/repos/janlazo/neovim/subscribers","subscription_url":"https://api.github.com/repos/janlazo/neovim/subscription","commits_url":"https://api.github.com/repos/janlazo/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/janlazo/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/janlazo/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/janlazo/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/janlazo/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/janlazo/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janlazo/neovim/merges","archive_url":"https://api.github.com/repos/janlazo/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janlazo/neovim/downloads","issues_url":"https://api.github.com/repos/janlazo/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/janlazo/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/janlazo/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/janlazo/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janlazo/neovim/labels{/name}","releases_url":"https://api.github.com/repos/janlazo/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/janlazo/neovim/deployments","created_at":"2017-04-28T02:53:31Z","updated_at":"2017-04-28T02:53:39Z","pushed_at":"2017-10-21T18:32:08Z","git_url":"git://github.com/janlazo/neovim.git","ssh_url":"git@github.com:janlazo/neovim.git","clone_url":"https://github.com/janlazo/neovim.git","svn_url":"https://github.com/janlazo/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":60525,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"d7594f9c33d1a855a5a071e6191e3ccd0a0b44ee","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars3.githubusercontent.com/u/6471485?v=4","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars3.githubusercontent.com/u/6471485?v=4","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and usability","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2017-10-22T19:20:06Z","pushed_at":"2017-10-22T20:21:21Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":60632,"stargazers_count":24491,"watchers_count":24491,"language":"Vim script","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1767,"mirror_url":null,"archived":false,"open_issues_count":864,"forks":1767,"open_issues":864,"watchers":24491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/7412"},"html":{"href":"https://github.com/neovim/neovim/pull/7412"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/7412"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/7412/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/7412/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/7412/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/c58f779741f9882632ebfebe771aa939efd5e0df"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"justinmk"}}