{"action":"opened","number":421,"pull_request":{"url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls/421","id":107988768,"html_url":"https://github.com/szepeviktor/w3-total-cache-fixed/pull/421","diff_url":"https://github.com/szepeviktor/w3-total-cache-fixed/pull/421.diff","patch_url":"https://github.com/szepeviktor/w3-total-cache-fixed/pull/421.patch","issue_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/issues/421","number":421,"state":"open","locked":false,"title":"This allows you to specify a Minify/Cache directory outside of the WP…","user":{"login":"klhurley","id":1320023,"avatar_url":"https://avatars.githubusercontent.com/u/1320023?v=3","gravatar_id":"","url":"https://api.github.com/users/klhurley","html_url":"https://github.com/klhurley","followers_url":"https://api.github.com/users/klhurley/followers","following_url":"https://api.github.com/users/klhurley/following{/other_user}","gists_url":"https://api.github.com/users/klhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/klhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klhurley/subscriptions","organizations_url":"https://api.github.com/users/klhurley/orgs","repos_url":"https://api.github.com/users/klhurley/repos","events_url":"https://api.github.com/users/klhurley/events{/privacy}","received_events_url":"https://api.github.com/users/klhurley/received_events","type":"User","site_admin":false},"body":"…_CONTENT_DIR.  Very useful for locking down WordPress except for this directory outside of WordPress.\r\n\r\nThank you for proposing a fix!  Please make sure you describe the issue, provide a use case, and elaborate on why your solution is an adequate one.\r\n\r\nIn Summary:\r\n\r\n1. What is the problem?\r\n  You can't specify a directory for the cached files outside of WP_CONTENT_DIR it will return \"\" if you do.  It is beneficial to have this be able to so you can store minified and cached content outside the WordPress directory.  Useful to Lock down Wordpress directory.  Also, if you put Wordpress files in a subdirectory, i.e. /var/www/html/wp and have the index.html in /var/www/html and want to put the files in /var/www/html/resources the old code wouldn't let you.\r\n\r\n2. Where is the cause?\r\n  The current code checks if you are specifying a a file in WP_CONTENT_DIR.  If not, it returns \"\" empty string.\r\n3. How was it solved?\r\n\r\nBy using document_root() trimming the filename, and mapping that to the network_home_url path.  This should work for multi-site as well, because the returned URL will NOT contain the single site blog i.e. /blog1/ path just like the original code\r\n","created_at":"2017-02-26T03:41:24Z","updated_at":"2017-02-26T03:41:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls/421/commits","review_comments_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls/421/comments","review_comment_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/issues/421/comments","statuses_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/statuses/410efda74d2a01b490b492ca37c17140f91dcea8","head":{"label":"klhurley:Dont_Force_WP_CONTENT_DIR","ref":"Dont_Force_WP_CONTENT_DIR","sha":"410efda74d2a01b490b492ca37c17140f91dcea8","user":{"login":"klhurley","id":1320023,"avatar_url":"https://avatars.githubusercontent.com/u/1320023?v=3","gravatar_id":"","url":"https://api.github.com/users/klhurley","html_url":"https://github.com/klhurley","followers_url":"https://api.github.com/users/klhurley/followers","following_url":"https://api.github.com/users/klhurley/following{/other_user}","gists_url":"https://api.github.com/users/klhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/klhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klhurley/subscriptions","organizations_url":"https://api.github.com/users/klhurley/orgs","repos_url":"https://api.github.com/users/klhurley/repos","events_url":"https://api.github.com/users/klhurley/events{/privacy}","received_events_url":"https://api.github.com/users/klhurley/received_events","type":"User","site_admin":false},"repo":{"id":83174467,"name":"w3-total-cache-fixed","full_name":"klhurley/w3-total-cache-fixed","owner":{"login":"klhurley","id":1320023,"avatar_url":"https://avatars.githubusercontent.com/u/1320023?v=3","gravatar_id":"","url":"https://api.github.com/users/klhurley","html_url":"https://github.com/klhurley","followers_url":"https://api.github.com/users/klhurley/followers","following_url":"https://api.github.com/users/klhurley/following{/other_user}","gists_url":"https://api.github.com/users/klhurley/gists{/gist_id}","starred_url":"https://api.github.com/users/klhurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klhurley/subscriptions","organizations_url":"https://api.github.com/users/klhurley/orgs","repos_url":"https://api.github.com/users/klhurley/repos","events_url":"https://api.github.com/users/klhurley/events{/privacy}","received_events_url":"https://api.github.com/users/klhurley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klhurley/w3-total-cache-fixed","description":"A community driven build of W3 Total Cache. The aim is to continuously incorporate fixes, improvements, and enhancements over the official WordPress release of W3 Total Cache.","fork":true,"url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed","forks_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/forks","keys_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/teams","hooks_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/hooks","issue_events_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/issues/events{/number}","events_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/events","assignees_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/assignees{/user}","branches_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/branches{/branch}","tags_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/tags","blobs_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/git/refs{/sha}","trees_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/statuses/{sha}","languages_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/languages","stargazers_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/stargazers","contributors_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/contributors","subscribers_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/subscribers","subscription_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/subscription","commits_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/commits{/sha}","git_commits_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/git/commits{/sha}","comments_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/comments{/number}","issue_comment_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/issues/comments{/number}","contents_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/contents/{+path}","compare_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/merges","archive_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/downloads","issues_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/issues{/number}","pulls_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/pulls{/number}","milestones_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/milestones{/number}","notifications_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/labels{/name}","releases_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/releases{/id}","deployments_url":"https://api.github.com/repos/klhurley/w3-total-cache-fixed/deployments","created_at":"2017-02-26T01:19:01Z","updated_at":"2017-02-26T01:19:04Z","pushed_at":"2017-02-26T03:39:55Z","git_url":"git://github.com/klhurley/w3-total-cache-fixed.git","ssh_url":"git@github.com:klhurley/w3-total-cache-fixed.git","clone_url":"https://github.com/klhurley/w3-total-cache-fixed.git","svn_url":"https://github.com/klhurley/w3-total-cache-fixed","homepage":"https://github.com/szepeviktor/w3-total-cache-fixed/releases","size":3701,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0.9.5.x"}},"base":{"label":"szepeviktor:v0.9.5.x","ref":"v0.9.5.x","sha":"b6ecf21d9dd11e4fde47fdfbccd95f7e2b6e1870","user":{"login":"szepeviktor","id":952007,"avatar_url":"https://avatars.githubusercontent.com/u/952007?v=3","gravatar_id":"","url":"https://api.github.com/users/szepeviktor","html_url":"https://github.com/szepeviktor","followers_url":"https://api.github.com/users/szepeviktor/followers","following_url":"https://api.github.com/users/szepeviktor/following{/other_user}","gists_url":"https://api.github.com/users/szepeviktor/gists{/gist_id}","starred_url":"https://api.github.com/users/szepeviktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szepeviktor/subscriptions","organizations_url":"https://api.github.com/users/szepeviktor/orgs","repos_url":"https://api.github.com/users/szepeviktor/repos","events_url":"https://api.github.com/users/szepeviktor/events{/privacy}","received_events_url":"https://api.github.com/users/szepeviktor/received_events","type":"User","site_admin":false},"repo":{"id":64881012,"name":"w3-total-cache-fixed","full_name":"szepeviktor/w3-total-cache-fixed","owner":{"login":"szepeviktor","id":952007,"avatar_url":"https://avatars.githubusercontent.com/u/952007?v=3","gravatar_id":"","url":"https://api.github.com/users/szepeviktor","html_url":"https://github.com/szepeviktor","followers_url":"https://api.github.com/users/szepeviktor/followers","following_url":"https://api.github.com/users/szepeviktor/following{/other_user}","gists_url":"https://api.github.com/users/szepeviktor/gists{/gist_id}","starred_url":"https://api.github.com/users/szepeviktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szepeviktor/subscriptions","organizations_url":"https://api.github.com/users/szepeviktor/orgs","repos_url":"https://api.github.com/users/szepeviktor/repos","events_url":"https://api.github.com/users/szepeviktor/events{/privacy}","received_events_url":"https://api.github.com/users/szepeviktor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szepeviktor/w3-total-cache-fixed","description":"A community driven build of W3 Total Cache. The aim is to continuously incorporate fixes, improvements, and enhancements over the official WordPress release of W3 Total Cache.","fork":false,"url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed","forks_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/forks","keys_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/teams","hooks_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/hooks","issue_events_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/issues/events{/number}","events_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/events","assignees_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/assignees{/user}","branches_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/branches{/branch}","tags_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/tags","blobs_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/git/refs{/sha}","trees_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/statuses/{sha}","languages_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/languages","stargazers_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/stargazers","contributors_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/contributors","subscribers_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/subscribers","subscription_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/subscription","commits_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/commits{/sha}","git_commits_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/git/commits{/sha}","comments_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/comments{/number}","issue_comment_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/issues/comments{/number}","contents_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/contents/{+path}","compare_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/merges","archive_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/downloads","issues_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/issues{/number}","pulls_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls{/number}","milestones_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/milestones{/number}","notifications_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/labels{/name}","releases_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/releases{/id}","deployments_url":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/deployments","created_at":"2016-08-03T21:35:54Z","updated_at":"2017-02-21T22:56:17Z","pushed_at":"2017-02-26T01:03:08Z","git_url":"git://github.com/szepeviktor/w3-total-cache-fixed.git","ssh_url":"git@github.com:szepeviktor/w3-total-cache-fixed.git","clone_url":"https://github.com/szepeviktor/w3-total-cache-fixed.git","svn_url":"https://github.com/szepeviktor/w3-total-cache-fixed","homepage":"https://github.com/szepeviktor/w3-total-cache-fixed/releases","size":3712,"stargazers_count":156,"watchers_count":156,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":8,"forks":33,"open_issues":8,"watchers":156,"default_branch":"v0.9.5.x"}},"_links":{"self":{"href":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls/421"},"html":{"href":"https://github.com/szepeviktor/w3-total-cache-fixed/pull/421"},"issue":{"href":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/issues/421"},"comments":{"href":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/szepeviktor/w3-total-cache-fixed/statuses/410efda74d2a01b490b492ca37c17140f91dcea8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"klhurley"}}