{"action":"opened","number":187,"pull_request":{"url":"https://api.github.com/repos/Logitech/slimserver/pulls/187","id":160661881,"html_url":"https://github.com/Logitech/slimserver/pull/187","diff_url":"https://github.com/Logitech/slimserver/pull/187.diff","patch_url":"https://github.com/Logitech/slimserver/pull/187.patch","issue_url":"https://api.github.com/repos/Logitech/slimserver/issues/187","number":187,"state":"open","locked":false,"title":"pluginData works with undef","user":{"login":"philippe44","id":9712599,"avatar_url":"https://avatars3.githubusercontent.com/u/9712599?v=4","gravatar_id":"","url":"https://api.github.com/users/philippe44","html_url":"https://github.com/philippe44","followers_url":"https://api.github.com/users/philippe44/followers","following_url":"https://api.github.com/users/philippe44/following{/other_user}","gists_url":"https://api.github.com/users/philippe44/gists{/gist_id}","starred_url":"https://api.github.com/users/philippe44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippe44/subscriptions","organizations_url":"https://api.github.com/users/philippe44/orgs","repos_url":"https://api.github.com/users/philippe44/repos","events_url":"https://api.github.com/users/philippe44/events{/privacy}","received_events_url":"https://api.github.com/users/philippe44/received_events","type":"User","site_admin":false},"body":"https://github.com/Logitech/slimserver/blob/3625c6d3f2cc77a00e64d2ba7ef803538d998af2/Slim/Plugin/SongScanner/Plugin.pm#L278\r\n\r\nI've seen a few times some plugins doing that and looking at the pluginData method in Slim::Player::Client.pm, I don't understand how it can work because if the value parameter is undef, then the function returns the current value, doesn't it? I needed to do that same on my Groups plugin but could not. This (I think) sets the key to whatever the caller asks, even undef but still returns the value if no $value parameter is given","created_at":"2018-01-01T22:02:18Z","updated_at":"2018-01-01T22:02:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Logitech/slimserver/pulls/187/commits","review_comments_url":"https://api.github.com/repos/Logitech/slimserver/pulls/187/comments","review_comment_url":"https://api.github.com/repos/Logitech/slimserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Logitech/slimserver/issues/187/comments","statuses_url":"https://api.github.com/repos/Logitech/slimserver/statuses/259aef43891b16d1f38c1f14fa9dc77404c38528","head":{"label":"philippe44:public/7.9","ref":"public/7.9","sha":"259aef43891b16d1f38c1f14fa9dc77404c38528","user":{"login":"philippe44","id":9712599,"avatar_url":"https://avatars3.githubusercontent.com/u/9712599?v=4","gravatar_id":"","url":"https://api.github.com/users/philippe44","html_url":"https://github.com/philippe44","followers_url":"https://api.github.com/users/philippe44/followers","following_url":"https://api.github.com/users/philippe44/following{/other_user}","gists_url":"https://api.github.com/users/philippe44/gists{/gist_id}","starred_url":"https://api.github.com/users/philippe44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippe44/subscriptions","organizations_url":"https://api.github.com/users/philippe44/orgs","repos_url":"https://api.github.com/users/philippe44/repos","events_url":"https://api.github.com/users/philippe44/events{/privacy}","received_events_url":"https://api.github.com/users/philippe44/received_events","type":"User","site_admin":false},"repo":{"id":115950389,"name":"slimserver","full_name":"philippe44/slimserver","owner":{"login":"philippe44","id":9712599,"avatar_url":"https://avatars3.githubusercontent.com/u/9712599?v=4","gravatar_id":"","url":"https://api.github.com/users/philippe44","html_url":"https://github.com/philippe44","followers_url":"https://api.github.com/users/philippe44/followers","following_url":"https://api.github.com/users/philippe44/following{/other_user}","gists_url":"https://api.github.com/users/philippe44/gists{/gist_id}","starred_url":"https://api.github.com/users/philippe44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippe44/subscriptions","organizations_url":"https://api.github.com/users/philippe44/orgs","repos_url":"https://api.github.com/users/philippe44/repos","events_url":"https://api.github.com/users/philippe44/events{/privacy}","received_events_url":"https://api.github.com/users/philippe44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philippe44/slimserver","description":"Server for Logitech Squeezebox players. This server is also called Logitech Media Server","fork":true,"url":"https://api.github.com/repos/philippe44/slimserver","forks_url":"https://api.github.com/repos/philippe44/slimserver/forks","keys_url":"https://api.github.com/repos/philippe44/slimserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philippe44/slimserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philippe44/slimserver/teams","hooks_url":"https://api.github.com/repos/philippe44/slimserver/hooks","issue_events_url":"https://api.github.com/repos/philippe44/slimserver/issues/events{/number}","events_url":"https://api.github.com/repos/philippe44/slimserver/events","assignees_url":"https://api.github.com/repos/philippe44/slimserver/assignees{/user}","branches_url":"https://api.github.com/repos/philippe44/slimserver/branches{/branch}","tags_url":"https://api.github.com/repos/philippe44/slimserver/tags","blobs_url":"https://api.github.com/repos/philippe44/slimserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philippe44/slimserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philippe44/slimserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/philippe44/slimserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philippe44/slimserver/statuses/{sha}","languages_url":"https://api.github.com/repos/philippe44/slimserver/languages","stargazers_url":"https://api.github.com/repos/philippe44/slimserver/stargazers","contributors_url":"https://api.github.com/repos/philippe44/slimserver/contributors","subscribers_url":"https://api.github.com/repos/philippe44/slimserver/subscribers","subscription_url":"https://api.github.com/repos/philippe44/slimserver/subscription","commits_url":"https://api.github.com/repos/philippe44/slimserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/philippe44/slimserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/philippe44/slimserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/philippe44/slimserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/philippe44/slimserver/contents/{+path}","compare_url":"https://api.github.com/repos/philippe44/slimserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philippe44/slimserver/merges","archive_url":"https://api.github.com/repos/philippe44/slimserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philippe44/slimserver/downloads","issues_url":"https://api.github.com/repos/philippe44/slimserver/issues{/number}","pulls_url":"https://api.github.com/repos/philippe44/slimserver/pulls{/number}","milestones_url":"https://api.github.com/repos/philippe44/slimserver/milestones{/number}","notifications_url":"https://api.github.com/repos/philippe44/slimserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philippe44/slimserver/labels{/name}","releases_url":"https://api.github.com/repos/philippe44/slimserver/releases{/id}","deployments_url":"https://api.github.com/repos/philippe44/slimserver/deployments","created_at":"2018-01-01T21:49:43Z","updated_at":"2018-01-01T21:49:56Z","pushed_at":"2018-01-01T22:00:18Z","git_url":"git://github.com/philippe44/slimserver.git","ssh_url":"git@github.com:philippe44/slimserver.git","clone_url":"https://github.com/philippe44/slimserver.git","svn_url":"https://github.com/philippe44/slimserver","homepage":null,"size":752437,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"public/7.9"}},"base":{"label":"Logitech:public/7.9","ref":"public/7.9","sha":"3625c6d3f2cc77a00e64d2ba7ef803538d998af2","user":{"login":"Logitech","id":1508962,"avatar_url":"https://avatars0.githubusercontent.com/u/1508962?v=4","gravatar_id":"","url":"https://api.github.com/users/Logitech","html_url":"https://github.com/Logitech","followers_url":"https://api.github.com/users/Logitech/followers","following_url":"https://api.github.com/users/Logitech/following{/other_user}","gists_url":"https://api.github.com/users/Logitech/gists{/gist_id}","starred_url":"https://api.github.com/users/Logitech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Logitech/subscriptions","organizations_url":"https://api.github.com/users/Logitech/orgs","repos_url":"https://api.github.com/users/Logitech/repos","events_url":"https://api.github.com/users/Logitech/events{/privacy}","received_events_url":"https://api.github.com/users/Logitech/received_events","type":"Organization","site_admin":false},"repo":{"id":4259480,"name":"slimserver","full_name":"Logitech/slimserver","owner":{"login":"Logitech","id":1508962,"avatar_url":"https://avatars0.githubusercontent.com/u/1508962?v=4","gravatar_id":"","url":"https://api.github.com/users/Logitech","html_url":"https://github.com/Logitech","followers_url":"https://api.github.com/users/Logitech/followers","following_url":"https://api.github.com/users/Logitech/following{/other_user}","gists_url":"https://api.github.com/users/Logitech/gists{/gist_id}","starred_url":"https://api.github.com/users/Logitech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Logitech/subscriptions","organizations_url":"https://api.github.com/users/Logitech/orgs","repos_url":"https://api.github.com/users/Logitech/repos","events_url":"https://api.github.com/users/Logitech/events{/privacy}","received_events_url":"https://api.github.com/users/Logitech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Logitech/slimserver","description":"Server for Logitech Squeezebox players. This server is also called Logitech Media Server","fork":false,"url":"https://api.github.com/repos/Logitech/slimserver","forks_url":"https://api.github.com/repos/Logitech/slimserver/forks","keys_url":"https://api.github.com/repos/Logitech/slimserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Logitech/slimserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Logitech/slimserver/teams","hooks_url":"https://api.github.com/repos/Logitech/slimserver/hooks","issue_events_url":"https://api.github.com/repos/Logitech/slimserver/issues/events{/number}","events_url":"https://api.github.com/repos/Logitech/slimserver/events","assignees_url":"https://api.github.com/repos/Logitech/slimserver/assignees{/user}","branches_url":"https://api.github.com/repos/Logitech/slimserver/branches{/branch}","tags_url":"https://api.github.com/repos/Logitech/slimserver/tags","blobs_url":"https://api.github.com/repos/Logitech/slimserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Logitech/slimserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Logitech/slimserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/Logitech/slimserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Logitech/slimserver/statuses/{sha}","languages_url":"https://api.github.com/repos/Logitech/slimserver/languages","stargazers_url":"https://api.github.com/repos/Logitech/slimserver/stargazers","contributors_url":"https://api.github.com/repos/Logitech/slimserver/contributors","subscribers_url":"https://api.github.com/repos/Logitech/slimserver/subscribers","subscription_url":"https://api.github.com/repos/Logitech/slimserver/subscription","commits_url":"https://api.github.com/repos/Logitech/slimserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/Logitech/slimserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/Logitech/slimserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/Logitech/slimserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/Logitech/slimserver/contents/{+path}","compare_url":"https://api.github.com/repos/Logitech/slimserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Logitech/slimserver/merges","archive_url":"https://api.github.com/repos/Logitech/slimserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Logitech/slimserver/downloads","issues_url":"https://api.github.com/repos/Logitech/slimserver/issues{/number}","pulls_url":"https://api.github.com/repos/Logitech/slimserver/pulls{/number}","milestones_url":"https://api.github.com/repos/Logitech/slimserver/milestones{/number}","notifications_url":"https://api.github.com/repos/Logitech/slimserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Logitech/slimserver/labels{/name}","releases_url":"https://api.github.com/repos/Logitech/slimserver/releases{/id}","deployments_url":"https://api.github.com/repos/Logitech/slimserver/deployments","created_at":"2012-05-08T10:22:04Z","updated_at":"2017-12-31T08:37:12Z","pushed_at":"2017-12-22T14:02:53Z","git_url":"git://github.com/Logitech/slimserver.git","ssh_url":"git@github.com:Logitech/slimserver.git","clone_url":"https://github.com/Logitech/slimserver.git","svn_url":"https://github.com/Logitech/slimserver","homepage":null,"size":752437,"stargazers_count":361,"watchers_count":361,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":119,"open_issues":21,"watchers":361,"default_branch":"public/7.9"}},"_links":{"self":{"href":"https://api.github.com/repos/Logitech/slimserver/pulls/187"},"html":{"href":"https://github.com/Logitech/slimserver/pull/187"},"issue":{"href":"https://api.github.com/repos/Logitech/slimserver/issues/187"},"comments":{"href":"https://api.github.com/repos/Logitech/slimserver/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/Logitech/slimserver/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/Logitech/slimserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Logitech/slimserver/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/Logitech/slimserver/statuses/259aef43891b16d1f38c1f14fa9dc77404c38528"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"philippe44"}}