{"action":"opened","number":519,"pull_request":{"url":"https://api.github.com/repos/rodjek/rspec-puppet/pulls/519","id":121945632,"html_url":"https://github.com/rodjek/rspec-puppet/pull/519","diff_url":"https://github.com/rodjek/rspec-puppet/pull/519.diff","patch_url":"https://github.com/rodjek/rspec-puppet/pull/519.patch","issue_url":"https://api.github.com/repos/rodjek/rspec-puppet/issues/519","number":519,"state":"open","locked":false,"title":"Support setting node parameters","user":{"login":"tdevelioglu","id":2796632,"avatar_url":"https://avatars0.githubusercontent.com/u/2796632?v=3","gravatar_id":"","url":"https://api.github.com/users/tdevelioglu","html_url":"https://github.com/tdevelioglu","followers_url":"https://api.github.com/users/tdevelioglu/followers","following_url":"https://api.github.com/users/tdevelioglu/following{/other_user}","gists_url":"https://api.github.com/users/tdevelioglu/gists{/gist_id}","starred_url":"https://api.github.com/users/tdevelioglu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdevelioglu/subscriptions","organizations_url":"https://api.github.com/users/tdevelioglu/orgs","repos_url":"https://api.github.com/users/tdevelioglu/repos","events_url":"https://api.github.com/users/tdevelioglu/events{/privacy}","received_events_url":"https://api.github.com/users/tdevelioglu/received_events","type":"User","site_admin":false},"body":"This commit adds a support for setting a node's parameters. It adds a\r\nnew helper, :node_params, that is a hash with members that are passed to\r\nthe instantiated node object to become its top-scope parameters.\r\n\r\nCurrently the only ways to set top scope parameters in an example is to\r\nspecify them as facts (which isn't technically really correct and also sets\r\nthe same values in the facts hash) or set them as a :pre_condition which,\r\nas a string, is a pain to work with when you'd like to override things\r\nin individual examples.\r\n\r\nAdding support for :node_params, makes it possible to set top-scope\r\nvariables for a node the same way you would when using an ENC.","created_at":"2017-05-23T08:58:54Z","updated_at":"2017-05-23T08:58:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rodjek/rspec-puppet/pulls/519/commits","review_comments_url":"https://api.github.com/repos/rodjek/rspec-puppet/pulls/519/comments","review_comment_url":"https://api.github.com/repos/rodjek/rspec-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rodjek/rspec-puppet/issues/519/comments","statuses_url":"https://api.github.com/repos/rodjek/rspec-puppet/statuses/86fc6073802d8320ef4d5857468c3b0b9c4b0837","head":{"label":"tdevelioglu:add_support_for_node_params","ref":"add_support_for_node_params","sha":"86fc6073802d8320ef4d5857468c3b0b9c4b0837","user":{"login":"tdevelioglu","id":2796632,"avatar_url":"https://avatars0.githubusercontent.com/u/2796632?v=3","gravatar_id":"","url":"https://api.github.com/users/tdevelioglu","html_url":"https://github.com/tdevelioglu","followers_url":"https://api.github.com/users/tdevelioglu/followers","following_url":"https://api.github.com/users/tdevelioglu/following{/other_user}","gists_url":"https://api.github.com/users/tdevelioglu/gists{/gist_id}","starred_url":"https://api.github.com/users/tdevelioglu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdevelioglu/subscriptions","organizations_url":"https://api.github.com/users/tdevelioglu/orgs","repos_url":"https://api.github.com/users/tdevelioglu/repos","events_url":"https://api.github.com/users/tdevelioglu/events{/privacy}","received_events_url":"https://api.github.com/users/tdevelioglu/received_events","type":"User","site_admin":false},"repo":{"id":71894778,"name":"rspec-puppet","full_name":"tdevelioglu/rspec-puppet","owner":{"login":"tdevelioglu","id":2796632,"avatar_url":"https://avatars0.githubusercontent.com/u/2796632?v=3","gravatar_id":"","url":"https://api.github.com/users/tdevelioglu","html_url":"https://github.com/tdevelioglu","followers_url":"https://api.github.com/users/tdevelioglu/followers","following_url":"https://api.github.com/users/tdevelioglu/following{/other_user}","gists_url":"https://api.github.com/users/tdevelioglu/gists{/gist_id}","starred_url":"https://api.github.com/users/tdevelioglu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdevelioglu/subscriptions","organizations_url":"https://api.github.com/users/tdevelioglu/orgs","repos_url":"https://api.github.com/users/tdevelioglu/repos","events_url":"https://api.github.com/users/tdevelioglu/events{/privacy}","received_events_url":"https://api.github.com/users/tdevelioglu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdevelioglu/rspec-puppet","description":"RSpec tests for your Puppet manifests","fork":true,"url":"https://api.github.com/repos/tdevelioglu/rspec-puppet","forks_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/forks","keys_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/teams","hooks_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/hooks","issue_events_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/events","assignees_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/tags","blobs_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/languages","stargazers_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/stargazers","contributors_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/contributors","subscribers_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/subscribers","subscription_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/subscription","commits_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/merges","archive_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/downloads","issues_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/labels{/name}","releases_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/tdevelioglu/rspec-puppet/deployments","created_at":"2016-10-25T12:28:47Z","updated_at":"2016-10-25T12:28:48Z","pushed_at":"2017-05-23T08:31:27Z","git_url":"git://github.com/tdevelioglu/rspec-puppet.git","ssh_url":"git@github.com:tdevelioglu/rspec-puppet.git","clone_url":"https://github.com/tdevelioglu/rspec-puppet.git","svn_url":"https://github.com/tdevelioglu/rspec-puppet","homepage":"http://rspec-puppet.com","size":674,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rodjek:master","ref":"master","sha":"34c9e2cb85d09418613af59bd9529a7c24c74ed5","user":{"login":"rodjek","id":80629,"avatar_url":"https://avatars1.githubusercontent.com/u/80629?v=3","gravatar_id":"","url":"https://api.github.com/users/rodjek","html_url":"https://github.com/rodjek","followers_url":"https://api.github.com/users/rodjek/followers","following_url":"https://api.github.com/users/rodjek/following{/other_user}","gists_url":"https://api.github.com/users/rodjek/gists{/gist_id}","starred_url":"https://api.github.com/users/rodjek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodjek/subscriptions","organizations_url":"https://api.github.com/users/rodjek/orgs","repos_url":"https://api.github.com/users/rodjek/repos","events_url":"https://api.github.com/users/rodjek/events{/privacy}","received_events_url":"https://api.github.com/users/rodjek/received_events","type":"User","site_admin":false},"repo":{"id":2063660,"name":"rspec-puppet","full_name":"rodjek/rspec-puppet","owner":{"login":"rodjek","id":80629,"avatar_url":"https://avatars1.githubusercontent.com/u/80629?v=3","gravatar_id":"","url":"https://api.github.com/users/rodjek","html_url":"https://github.com/rodjek","followers_url":"https://api.github.com/users/rodjek/followers","following_url":"https://api.github.com/users/rodjek/following{/other_user}","gists_url":"https://api.github.com/users/rodjek/gists{/gist_id}","starred_url":"https://api.github.com/users/rodjek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodjek/subscriptions","organizations_url":"https://api.github.com/users/rodjek/orgs","repos_url":"https://api.github.com/users/rodjek/repos","events_url":"https://api.github.com/users/rodjek/events{/privacy}","received_events_url":"https://api.github.com/users/rodjek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rodjek/rspec-puppet","description":"RSpec tests for your Puppet manifests","fork":false,"url":"https://api.github.com/repos/rodjek/rspec-puppet","forks_url":"https://api.github.com/repos/rodjek/rspec-puppet/forks","keys_url":"https://api.github.com/repos/rodjek/rspec-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rodjek/rspec-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rodjek/rspec-puppet/teams","hooks_url":"https://api.github.com/repos/rodjek/rspec-puppet/hooks","issue_events_url":"https://api.github.com/repos/rodjek/rspec-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/rodjek/rspec-puppet/events","assignees_url":"https://api.github.com/repos/rodjek/rspec-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/rodjek/rspec-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/rodjek/rspec-puppet/tags","blobs_url":"https://api.github.com/repos/rodjek/rspec-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rodjek/rspec-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rodjek/rspec-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/rodjek/rspec-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rodjek/rspec-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/rodjek/rspec-puppet/languages","stargazers_url":"https://api.github.com/repos/rodjek/rspec-puppet/stargazers","contributors_url":"https://api.github.com/repos/rodjek/rspec-puppet/contributors","subscribers_url":"https://api.github.com/repos/rodjek/rspec-puppet/subscribers","subscription_url":"https://api.github.com/repos/rodjek/rspec-puppet/subscription","commits_url":"https://api.github.com/repos/rodjek/rspec-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/rodjek/rspec-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/rodjek/rspec-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/rodjek/rspec-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/rodjek/rspec-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/rodjek/rspec-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rodjek/rspec-puppet/merges","archive_url":"https://api.github.com/repos/rodjek/rspec-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rodjek/rspec-puppet/downloads","issues_url":"https://api.github.com/repos/rodjek/rspec-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/rodjek/rspec-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/rodjek/rspec-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/rodjek/rspec-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rodjek/rspec-puppet/labels{/name}","releases_url":"https://api.github.com/repos/rodjek/rspec-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/rodjek/rspec-puppet/deployments","created_at":"2011-07-17T23:32:11Z","updated_at":"2017-05-15T08:08:01Z","pushed_at":"2017-05-17T14:46:54Z","git_url":"git://github.com/rodjek/rspec-puppet.git","ssh_url":"git@github.com:rodjek/rspec-puppet.git","clone_url":"https://github.com/rodjek/rspec-puppet.git","svn_url":"https://github.com/rodjek/rspec-puppet","homepage":"http://rspec-puppet.com","size":705,"stargazers_count":349,"watchers_count":349,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":165,"mirror_url":null,"open_issues_count":64,"forks":165,"open_issues":64,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rodjek/rspec-puppet/pulls/519"},"html":{"href":"https://github.com/rodjek/rspec-puppet/pull/519"},"issue":{"href":"https://api.github.com/repos/rodjek/rspec-puppet/issues/519"},"comments":{"href":"https://api.github.com/repos/rodjek/rspec-puppet/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/rodjek/rspec-puppet/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/rodjek/rspec-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rodjek/rspec-puppet/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/rodjek/rspec-puppet/statuses/86fc6073802d8320ef4d5857468c3b0b9c4b0837"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":75,"deletions":3,"changed_files":4}}
{"actor":{"display_login":"tdevelioglu"}}