{"action":"created","comment":{"url":"https://api.github.com/repos/coq/coq/pulls/comments/116930280","pull_request_review_id":38590821,"id":116930280,"diff_hunk":"@@ -631,6 +631,16 @@ let unfold_entry cst = Hints.HintsUnfoldEntry [EvalConstRef cst]\n let add_hint local prg cst =\n   Hints.add_hints local [Id.to_string prg.prg_name] (unfold_entry cst)\n \n+let it_mkLambda_or_LetIn_or_clean t ctx =","path":"vernac/obligations.ml","position":4,"original_position":4,"commit_id":"fa530442ba05e9b60efff9c726616ae00d6d09e7","original_commit_id":"fa530442ba05e9b60efff9c726616ae00d6d09e7","user":{"login":"maximedenes","id":647105,"avatar_url":"https://avatars2.githubusercontent.com/u/647105?v=3","gravatar_id":"","url":"https://api.github.com/users/maximedenes","html_url":"https://github.com/maximedenes","followers_url":"https://api.github.com/users/maximedenes/followers","following_url":"https://api.github.com/users/maximedenes/following{/other_user}","gists_url":"https://api.github.com/users/maximedenes/gists{/gist_id}","starred_url":"https://api.github.com/users/maximedenes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximedenes/subscriptions","organizations_url":"https://api.github.com/users/maximedenes/orgs","repos_url":"https://api.github.com/users/maximedenes/repos","events_url":"https://api.github.com/users/maximedenes/events{/privacy}","received_events_url":"https://api.github.com/users/maximedenes/received_events","type":"User","site_admin":false},"body":"Also, is it really the right place for such a function?","created_at":"2017-05-17T07:43:37Z","updated_at":"2017-05-17T07:43:37Z","html_url":"https://github.com/coq/coq/pull/627#discussion_r116930280","pull_request_url":"https://api.github.com/repos/coq/coq/pulls/627","_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/comments/116930280"},"html":{"href":"https://github.com/coq/coq/pull/627#discussion_r116930280"},"pull_request":{"href":"https://api.github.com/repos/coq/coq/pulls/627"}}},"pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/627","id":120112718,"html_url":"https://github.com/coq/coq/pull/627","diff_url":"https://github.com/coq/coq/pull/627.diff","patch_url":"https://github.com/coq/coq/pull/627.patch","issue_url":"https://api.github.com/repos/coq/coq/issues/627","number":627,"state":"open","locked":false,"title":"Obligations shrinking: shrink abstraction too","user":{"login":"mattam82","id":98373,"avatar_url":"https://avatars2.githubusercontent.com/u/98373?v=3","gravatar_id":"","url":"https://api.github.com/users/mattam82","html_url":"https://github.com/mattam82","followers_url":"https://api.github.com/users/mattam82/followers","following_url":"https://api.github.com/users/mattam82/following{/other_user}","gists_url":"https://api.github.com/users/mattam82/gists{/gist_id}","starred_url":"https://api.github.com/users/mattam82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattam82/subscriptions","organizations_url":"https://api.github.com/users/mattam82/orgs","repos_url":"https://api.github.com/users/mattam82/repos","events_url":"https://api.github.com/users/mattam82/events{/privacy}","received_events_url":"https://api.github.com/users/mattam82/received_events","type":"User","site_admin":false},"body":"This is a fix to the obligation shrinking option which was repeating lets in the abstraction even when thoses were not used by the obligation, defeating the shrinking phase and resulting in very poor behavior when evaluating programs in call-by-value fashion. It changes the terms produced by Program for the better.","created_at":"2017-05-11T13:55:43Z","updated_at":"2017-05-17T07:43:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afd16e3fd44f01f9656545a752918cb0bf7598a2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coq/coq/pulls/627/commits","review_comments_url":"https://api.github.com/repos/coq/coq/pulls/627/comments","review_comment_url":"https://api.github.com/repos/coq/coq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coq/coq/issues/627/comments","statuses_url":"https://api.github.com/repos/coq/coq/statuses/fa530442ba05e9b60efff9c726616ae00d6d09e7","head":{"label":"mattam82:shrinklet","ref":"shrinklet","sha":"fa530442ba05e9b60efff9c726616ae00d6d09e7","user":{"login":"mattam82","id":98373,"avatar_url":"https://avatars2.githubusercontent.com/u/98373?v=3","gravatar_id":"","url":"https://api.github.com/users/mattam82","html_url":"https://github.com/mattam82","followers_url":"https://api.github.com/users/mattam82/followers","following_url":"https://api.github.com/users/mattam82/following{/other_user}","gists_url":"https://api.github.com/users/mattam82/gists{/gist_id}","starred_url":"https://api.github.com/users/mattam82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattam82/subscriptions","organizations_url":"https://api.github.com/users/mattam82/orgs","repos_url":"https://api.github.com/users/mattam82/repos","events_url":"https://api.github.com/users/mattam82/events{/privacy}","received_events_url":"https://api.github.com/users/mattam82/received_events","type":"User","site_admin":false},"repo":{"id":2227625,"name":"coq","full_name":"mattam82/coq","owner":{"login":"mattam82","id":98373,"avatar_url":"https://avatars2.githubusercontent.com/u/98373?v=3","gravatar_id":"","url":"https://api.github.com/users/mattam82","html_url":"https://github.com/mattam82","followers_url":"https://api.github.com/users/mattam82/followers","following_url":"https://api.github.com/users/mattam82/following{/other_user}","gists_url":"https://api.github.com/users/mattam82/gists{/gist_id}","starred_url":"https://api.github.com/users/mattam82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattam82/subscriptions","organizations_url":"https://api.github.com/users/mattam82/orgs","repos_url":"https://api.github.com/users/mattam82/repos","events_url":"https://api.github.com/users/mattam82/events{/privacy}","received_events_url":"https://api.github.com/users/mattam82/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattam82/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":true,"url":"https://api.github.com/repos/mattam82/coq","forks_url":"https://api.github.com/repos/mattam82/coq/forks","keys_url":"https://api.github.com/repos/mattam82/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattam82/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattam82/coq/teams","hooks_url":"https://api.github.com/repos/mattam82/coq/hooks","issue_events_url":"https://api.github.com/repos/mattam82/coq/issues/events{/number}","events_url":"https://api.github.com/repos/mattam82/coq/events","assignees_url":"https://api.github.com/repos/mattam82/coq/assignees{/user}","branches_url":"https://api.github.com/repos/mattam82/coq/branches{/branch}","tags_url":"https://api.github.com/repos/mattam82/coq/tags","blobs_url":"https://api.github.com/repos/mattam82/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattam82/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattam82/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattam82/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattam82/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/mattam82/coq/languages","stargazers_url":"https://api.github.com/repos/mattam82/coq/stargazers","contributors_url":"https://api.github.com/repos/mattam82/coq/contributors","subscribers_url":"https://api.github.com/repos/mattam82/coq/subscribers","subscription_url":"https://api.github.com/repos/mattam82/coq/subscription","commits_url":"https://api.github.com/repos/mattam82/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattam82/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattam82/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattam82/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattam82/coq/contents/{+path}","compare_url":"https://api.github.com/repos/mattam82/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattam82/coq/merges","archive_url":"https://api.github.com/repos/mattam82/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattam82/coq/downloads","issues_url":"https://api.github.com/repos/mattam82/coq/issues{/number}","pulls_url":"https://api.github.com/repos/mattam82/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/mattam82/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/mattam82/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattam82/coq/labels{/name}","releases_url":"https://api.github.com/repos/mattam82/coq/releases{/id}","deployments_url":"https://api.github.com/repos/mattam82/coq/deployments","created_at":"2011-08-18T12:07:36Z","updated_at":"2017-03-22T16:42:42Z","pushed_at":"2017-05-16T15:33:42Z","git_url":"git://github.com/mattam82/coq.git","ssh_url":"git@github.com:mattam82/coq.git","clone_url":"https://github.com/mattam82/coq.git","svn_url":"https://github.com/mattam82/coq","homepage":"http://coq.inria.fr/","size":79703,"stargazers_count":3,"watchers_count":3,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"genreweqwip"}},"base":{"label":"coq:trunk","ref":"trunk","sha":"8e6d03830e9c53f641626e29886eb07c705f7608","user":{"login":"coq","id":621198,"avatar_url":"https://avatars2.githubusercontent.com/u/621198?v=3","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"repo":{"id":1377159,"name":"coq","full_name":"coq/coq","owner":{"login":"coq","id":621198,"avatar_url":"https://avatars2.githubusercontent.com/u/621198?v=3","gravatar_id":"","url":"https://api.github.com/users/coq","html_url":"https://github.com/coq","followers_url":"https://api.github.com/users/coq/followers","following_url":"https://api.github.com/users/coq/following{/other_user}","gists_url":"https://api.github.com/users/coq/gists{/gist_id}","starred_url":"https://api.github.com/users/coq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coq/subscriptions","organizations_url":"https://api.github.com/users/coq/orgs","repos_url":"https://api.github.com/users/coq/repos","events_url":"https://api.github.com/users/coq/events{/privacy}","received_events_url":"https://api.github.com/users/coq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coq/coq","description":"Coq is a formal proof management system. It provides a formal language to write mathematical definitions, executable algorithms and theorems together with an environment for semi-interactive development of machine-checked proofs. ","fork":false,"url":"https://api.github.com/repos/coq/coq","forks_url":"https://api.github.com/repos/coq/coq/forks","keys_url":"https://api.github.com/repos/coq/coq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coq/coq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coq/coq/teams","hooks_url":"https://api.github.com/repos/coq/coq/hooks","issue_events_url":"https://api.github.com/repos/coq/coq/issues/events{/number}","events_url":"https://api.github.com/repos/coq/coq/events","assignees_url":"https://api.github.com/repos/coq/coq/assignees{/user}","branches_url":"https://api.github.com/repos/coq/coq/branches{/branch}","tags_url":"https://api.github.com/repos/coq/coq/tags","blobs_url":"https://api.github.com/repos/coq/coq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coq/coq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coq/coq/git/refs{/sha}","trees_url":"https://api.github.com/repos/coq/coq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coq/coq/statuses/{sha}","languages_url":"https://api.github.com/repos/coq/coq/languages","stargazers_url":"https://api.github.com/repos/coq/coq/stargazers","contributors_url":"https://api.github.com/repos/coq/coq/contributors","subscribers_url":"https://api.github.com/repos/coq/coq/subscribers","subscription_url":"https://api.github.com/repos/coq/coq/subscription","commits_url":"https://api.github.com/repos/coq/coq/commits{/sha}","git_commits_url":"https://api.github.com/repos/coq/coq/git/commits{/sha}","comments_url":"https://api.github.com/repos/coq/coq/comments{/number}","issue_comment_url":"https://api.github.com/repos/coq/coq/issues/comments{/number}","contents_url":"https://api.github.com/repos/coq/coq/contents/{+path}","compare_url":"https://api.github.com/repos/coq/coq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coq/coq/merges","archive_url":"https://api.github.com/repos/coq/coq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coq/coq/downloads","issues_url":"https://api.github.com/repos/coq/coq/issues{/number}","pulls_url":"https://api.github.com/repos/coq/coq/pulls{/number}","milestones_url":"https://api.github.com/repos/coq/coq/milestones{/number}","notifications_url":"https://api.github.com/repos/coq/coq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coq/coq/labels{/name}","releases_url":"https://api.github.com/repos/coq/coq/releases{/id}","deployments_url":"https://api.github.com/repos/coq/coq/deployments","created_at":"2011-02-17T05:49:37Z","updated_at":"2017-05-17T06:22:00Z","pushed_at":"2017-05-17T07:40:09Z","git_url":"git://github.com/coq/coq.git","ssh_url":"git@github.com:coq/coq.git","clone_url":"https://github.com/coq/coq.git","svn_url":"https://github.com/coq/coq","homepage":"http://coq.inria.fr/","size":90451,"stargazers_count":623,"watchers_count":623,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":"https://scm.gforge.inria.fr/anonscm/git/coq/coq.git/","open_issues_count":96,"forks":161,"open_issues":96,"watchers":623,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/coq/coq/pulls/627"},"html":{"href":"https://github.com/coq/coq/pull/627"},"issue":{"href":"https://api.github.com/repos/coq/coq/issues/627"},"comments":{"href":"https://api.github.com/repos/coq/coq/issues/627/comments"},"review_comments":{"href":"https://api.github.com/repos/coq/coq/pulls/627/comments"},"review_comment":{"href":"https://api.github.com/repos/coq/coq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coq/coq/pulls/627/commits"},"statuses":{"href":"https://api.github.com/repos/coq/coq/statuses/fa530442ba05e9b60efff9c726616ae00d6d09e7"}}}}
{"actor":{"display_login":"maximedenes"}}