{"action":"created","comment":{"url":"https://api.github.com/repos/coveo/search-ui/pulls/comments/125517570","pull_request_review_id":47911296,"id":125517570,"diff_hunk":"@@ -0,0 +1,181 @@\n+import * as Mock from '../MockEnvironment';\n+import { ISimpleFilterOptions, SimpleFilter } from '../../src/ui/SimpleFilter/SimpleFilter';\n+import { Simulate } from '../Simulate';\n+import { $$ } from '../../src/utils/Dom';\n+import { BreadcrumbEvents, IPopulateBreadcrumbEventArgs } from '../../src/events/BreadcrumbEvents';\n+import { FakeResults } from '../Fake';\n+\n+export function SimpleFilterTest() {\n+  describe('SimpleFilter', () => {\n+    let test: Mock.IBasicComponentSetup<SimpleFilter>;\n+    let test2: Mock.IBasicComponentSetup<SimpleFilter>;\n+    let test3: Mock.IBasicComponentSetup<SimpleFilter>;\n+\n+    beforeEach(() => {\n+      test = Mock.optionsComponentSetup<SimpleFilter, ISimpleFilterOptions>(SimpleFilter, <ISimpleFilterOptions>{","path":"test/ui/SimpleFilterTest.ts","position":15,"original_position":15,"commit_id":"7a93b17277a39563a4ec14b43050eedeb370f486","original_commit_id":"7a93b17277a39563a4ec14b43050eedeb370f486","user":{"login":"dms1lva","id":6422665,"avatar_url":"https://avatars1.githubusercontent.com/u/6422665?v=3","gravatar_id":"","url":"https://api.github.com/users/dms1lva","html_url":"https://github.com/dms1lva","followers_url":"https://api.github.com/users/dms1lva/followers","following_url":"https://api.github.com/users/dms1lva/following{/other_user}","gists_url":"https://api.github.com/users/dms1lva/gists{/gist_id}","starred_url":"https://api.github.com/users/dms1lva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dms1lva/subscriptions","organizations_url":"https://api.github.com/users/dms1lva/orgs","repos_url":"https://api.github.com/users/dms1lva/repos","events_url":"https://api.github.com/users/dms1lva/events{/privacy}","received_events_url":"https://api.github.com/users/dms1lva/received_events","type":"User","site_admin":false},"body":"I disagree with the naming here. Do you really need three instance of this mock? ","created_at":"2017-07-04T18:20:23Z","updated_at":"2017-07-04T18:30:01Z","html_url":"https://github.com/coveo/search-ui/pull/535#discussion_r125517570","pull_request_url":"https://api.github.com/repos/coveo/search-ui/pulls/535","_links":{"self":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/comments/125517570"},"html":{"href":"https://github.com/coveo/search-ui/pull/535#discussion_r125517570"},"pull_request":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/535"}}},"pull_request":{"url":"https://api.github.com/repos/coveo/search-ui/pulls/535","id":128838949,"html_url":"https://github.com/coveo/search-ui/pull/535","diff_url":"https://github.com/coveo/search-ui/pull/535.diff","patch_url":"https://github.com/coveo/search-ui/pull/535.patch","issue_url":"https://api.github.com/repos/coveo/search-ui/issues/535","number":535,"state":"open","locked":false,"title":"New SimpleFilter component","user":{"login":"pmongeau174","id":28260398,"avatar_url":"https://avatars2.githubusercontent.com/u/28260398?v=3","gravatar_id":"","url":"https://api.github.com/users/pmongeau174","html_url":"https://github.com/pmongeau174","followers_url":"https://api.github.com/users/pmongeau174/followers","following_url":"https://api.github.com/users/pmongeau174/following{/other_user}","gists_url":"https://api.github.com/users/pmongeau174/gists{/gist_id}","starred_url":"https://api.github.com/users/pmongeau174/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmongeau174/subscriptions","organizations_url":"https://api.github.com/users/pmongeau174/orgs","repos_url":"https://api.github.com/users/pmongeau174/repos","events_url":"https://api.github.com/users/pmongeau174/events{/privacy}","received_events_url":"https://api.github.com/users/pmongeau174/received_events","type":"User","site_admin":false},"body":"https://coveord.atlassian.net/browse/JSUI-1608","created_at":"2017-07-04T17:07:39Z","updated_at":"2017-07-04T18:30:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f04fac5cbf423fe64378fdfd03ce25d275d2a23","assignee":null,"assignees":[],"requested_reviewers":[{"login":"olamothe","id":1591893,"avatar_url":"https://avatars2.githubusercontent.com/u/1591893?v=3","gravatar_id":"","url":"https://api.github.com/users/olamothe","html_url":"https://github.com/olamothe","followers_url":"https://api.github.com/users/olamothe/followers","following_url":"https://api.github.com/users/olamothe/following{/other_user}","gists_url":"https://api.github.com/users/olamothe/gists{/gist_id}","starred_url":"https://api.github.com/users/olamothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olamothe/subscriptions","organizations_url":"https://api.github.com/users/olamothe/orgs","repos_url":"https://api.github.com/users/olamothe/repos","events_url":"https://api.github.com/users/olamothe/events{/privacy}","received_events_url":"https://api.github.com/users/olamothe/received_events","type":"User","site_admin":false},{"login":"fbeaudoincoveo","id":23503066,"avatar_url":"https://avatars3.githubusercontent.com/u/23503066?v=3","gravatar_id":"","url":"https://api.github.com/users/fbeaudoincoveo","html_url":"https://github.com/fbeaudoincoveo","followers_url":"https://api.github.com/users/fbeaudoincoveo/followers","following_url":"https://api.github.com/users/fbeaudoincoveo/following{/other_user}","gists_url":"https://api.github.com/users/fbeaudoincoveo/gists{/gist_id}","starred_url":"https://api.github.com/users/fbeaudoincoveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbeaudoincoveo/subscriptions","organizations_url":"https://api.github.com/users/fbeaudoincoveo/orgs","repos_url":"https://api.github.com/users/fbeaudoincoveo/repos","events_url":"https://api.github.com/users/fbeaudoincoveo/events{/privacy}","received_events_url":"https://api.github.com/users/fbeaudoincoveo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coveo/search-ui/pulls/535/commits","review_comments_url":"https://api.github.com/repos/coveo/search-ui/pulls/535/comments","review_comment_url":"https://api.github.com/repos/coveo/search-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coveo/search-ui/issues/535/comments","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/7a93b17277a39563a4ec14b43050eedeb370f486","head":{"label":"coveo:JSUI-1608","ref":"JSUI-1608","sha":"7a93b17277a39563a4ec14b43050eedeb370f486","user":{"login":"coveo","id":8632328,"avatar_url":"https://avatars1.githubusercontent.com/u/8632328?v=3","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"repo":{"id":58133471,"name":"search-ui","full_name":"coveo/search-ui","owner":{"login":"coveo","id":8632328,"avatar_url":"https://avatars1.githubusercontent.com/u/8632328?v=3","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coveo/search-ui","description":"Coveo Search UI framework","fork":false,"url":"https://api.github.com/repos/coveo/search-ui","forks_url":"https://api.github.com/repos/coveo/search-ui/forks","keys_url":"https://api.github.com/repos/coveo/search-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coveo/search-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coveo/search-ui/teams","hooks_url":"https://api.github.com/repos/coveo/search-ui/hooks","issue_events_url":"https://api.github.com/repos/coveo/search-ui/issues/events{/number}","events_url":"https://api.github.com/repos/coveo/search-ui/events","assignees_url":"https://api.github.com/repos/coveo/search-ui/assignees{/user}","branches_url":"https://api.github.com/repos/coveo/search-ui/branches{/branch}","tags_url":"https://api.github.com/repos/coveo/search-ui/tags","blobs_url":"https://api.github.com/repos/coveo/search-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coveo/search-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coveo/search-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/coveo/search-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/coveo/search-ui/languages","stargazers_url":"https://api.github.com/repos/coveo/search-ui/stargazers","contributors_url":"https://api.github.com/repos/coveo/search-ui/contributors","subscribers_url":"https://api.github.com/repos/coveo/search-ui/subscribers","subscription_url":"https://api.github.com/repos/coveo/search-ui/subscription","commits_url":"https://api.github.com/repos/coveo/search-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/coveo/search-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/coveo/search-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/coveo/search-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/coveo/search-ui/contents/{+path}","compare_url":"https://api.github.com/repos/coveo/search-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coveo/search-ui/merges","archive_url":"https://api.github.com/repos/coveo/search-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coveo/search-ui/downloads","issues_url":"https://api.github.com/repos/coveo/search-ui/issues{/number}","pulls_url":"https://api.github.com/repos/coveo/search-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/coveo/search-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/coveo/search-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coveo/search-ui/labels{/name}","releases_url":"https://api.github.com/repos/coveo/search-ui/releases{/id}","deployments_url":"https://api.github.com/repos/coveo/search-ui/deployments","created_at":"2016-05-05T13:41:09Z","updated_at":"2017-06-26T12:11:39Z","pushed_at":"2017-07-04T17:16:18Z","git_url":"git://github.com/coveo/search-ui.git","ssh_url":"git@github.com:coveo/search-ui.git","clone_url":"https://github.com/coveo/search-ui.git","svn_url":"https://github.com/coveo/search-ui","homepage":null,"size":76639,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":3,"forks":23,"open_issues":3,"watchers":27,"default_branch":"master"}},"base":{"label":"coveo:master","ref":"master","sha":"9212c45439b7a0c4dc1851d08518e642070eb2d8","user":{"login":"coveo","id":8632328,"avatar_url":"https://avatars1.githubusercontent.com/u/8632328?v=3","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"repo":{"id":58133471,"name":"search-ui","full_name":"coveo/search-ui","owner":{"login":"coveo","id":8632328,"avatar_url":"https://avatars1.githubusercontent.com/u/8632328?v=3","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coveo/search-ui","description":"Coveo Search UI framework","fork":false,"url":"https://api.github.com/repos/coveo/search-ui","forks_url":"https://api.github.com/repos/coveo/search-ui/forks","keys_url":"https://api.github.com/repos/coveo/search-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coveo/search-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coveo/search-ui/teams","hooks_url":"https://api.github.com/repos/coveo/search-ui/hooks","issue_events_url":"https://api.github.com/repos/coveo/search-ui/issues/events{/number}","events_url":"https://api.github.com/repos/coveo/search-ui/events","assignees_url":"https://api.github.com/repos/coveo/search-ui/assignees{/user}","branches_url":"https://api.github.com/repos/coveo/search-ui/branches{/branch}","tags_url":"https://api.github.com/repos/coveo/search-ui/tags","blobs_url":"https://api.github.com/repos/coveo/search-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coveo/search-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coveo/search-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/coveo/search-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coveo/search-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/coveo/search-ui/languages","stargazers_url":"https://api.github.com/repos/coveo/search-ui/stargazers","contributors_url":"https://api.github.com/repos/coveo/search-ui/contributors","subscribers_url":"https://api.github.com/repos/coveo/search-ui/subscribers","subscription_url":"https://api.github.com/repos/coveo/search-ui/subscription","commits_url":"https://api.github.com/repos/coveo/search-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/coveo/search-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/coveo/search-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/coveo/search-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/coveo/search-ui/contents/{+path}","compare_url":"https://api.github.com/repos/coveo/search-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coveo/search-ui/merges","archive_url":"https://api.github.com/repos/coveo/search-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coveo/search-ui/downloads","issues_url":"https://api.github.com/repos/coveo/search-ui/issues{/number}","pulls_url":"https://api.github.com/repos/coveo/search-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/coveo/search-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/coveo/search-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coveo/search-ui/labels{/name}","releases_url":"https://api.github.com/repos/coveo/search-ui/releases{/id}","deployments_url":"https://api.github.com/repos/coveo/search-ui/deployments","created_at":"2016-05-05T13:41:09Z","updated_at":"2017-06-26T12:11:39Z","pushed_at":"2017-07-04T17:16:18Z","git_url":"git://github.com/coveo/search-ui.git","ssh_url":"git@github.com:coveo/search-ui.git","clone_url":"https://github.com/coveo/search-ui.git","svn_url":"https://github.com/coveo/search-ui","homepage":null,"size":76639,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":3,"forks":23,"open_issues":3,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/535"},"html":{"href":"https://github.com/coveo/search-ui/pull/535"},"issue":{"href":"https://api.github.com/repos/coveo/search-ui/issues/535"},"comments":{"href":"https://api.github.com/repos/coveo/search-ui/issues/535/comments"},"review_comments":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/535/comments"},"review_comment":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coveo/search-ui/pulls/535/commits"},"statuses":{"href":"https://api.github.com/repos/coveo/search-ui/statuses/7a93b17277a39563a4ec14b43050eedeb370f486"}}}}
{"actor":{"display_login":"dms1lva"}}