{"action":"created","comment":{"url":"https://api.github.com/repos/pilosa/pilosa/pulls/comments/145423495","pull_request_review_id":70212941,"id":145423495,"diff_hunk":"@@ -47,26 +43,21 @@ type Executor struct {\n \tHost    string\n \tCluster *Cluster\n \n-\t// Client used for remote HTTP requests.\n-\tHTTPClient *http.Client\n+\t// Client used for remote requests.\n+\tclient InternalClient\n \n \t// Maximum number of SetBit() or ClearBit() commands per request.\n \tMaxWritesPerRequest int\n }\n \n // NewExecutor returns a new instance of Executor.\n-func NewExecutor(clientOptions *ClientOptions) *Executor {\n+func NewExecutor(clientOptions *ClientOptions) (*Executor, error) {","path":"executor.go","position":32,"original_position":32,"commit_id":"838d56011cb411ea98fb7919a385b07cc446a8ab","original_commit_id":"838d56011cb411ea98fb7919a385b07cc446a8ab","user":{"login":"travisturner","id":410544,"avatar_url":"https://avatars3.githubusercontent.com/u/410544?v=4","gravatar_id":"","url":"https://api.github.com/users/travisturner","html_url":"https://github.com/travisturner","followers_url":"https://api.github.com/users/travisturner/followers","following_url":"https://api.github.com/users/travisturner/following{/other_user}","gists_url":"https://api.github.com/users/travisturner/gists{/gist_id}","starred_url":"https://api.github.com/users/travisturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisturner/subscriptions","organizations_url":"https://api.github.com/users/travisturner/orgs","repos_url":"https://api.github.com/users/travisturner/repos","events_url":"https://api.github.com/users/travisturner/events{/privacy}","received_events_url":"https://api.github.com/users/travisturner/received_events","type":"User","site_admin":false},"body":"why did you add an `error` to the return here?","created_at":"2017-10-18T14:01:23Z","updated_at":"2017-10-18T14:03:33Z","html_url":"https://github.com/pilosa/pilosa/pull/892#discussion_r145423495","pull_request_url":"https://api.github.com/repos/pilosa/pilosa/pulls/892","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/comments/145423495"},"html":{"href":"https://github.com/pilosa/pilosa/pull/892#discussion_r145423495"},"pull_request":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/892"}}},"pull_request":{"url":"https://api.github.com/repos/pilosa/pilosa/pulls/892","id":147032698,"html_url":"https://github.com/pilosa/pilosa/pull/892","diff_url":"https://github.com/pilosa/pilosa/pull/892.diff","patch_url":"https://github.com/pilosa/pilosa/pull/892.patch","issue_url":"https://api.github.com/repos/pilosa/pilosa/issues/892","number":892,"state":"open","locked":false,"title":"Internal Client refactoring","user":{"login":"yuce","id":513114,"avatar_url":"https://avatars2.githubusercontent.com/u/513114?v=4","gravatar_id":"","url":"https://api.github.com/users/yuce","html_url":"https://github.com/yuce","followers_url":"https://api.github.com/users/yuce/followers","following_url":"https://api.github.com/users/yuce/following{/other_user}","gists_url":"https://api.github.com/users/yuce/gists{/gist_id}","starred_url":"https://api.github.com/users/yuce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuce/subscriptions","organizations_url":"https://api.github.com/users/yuce/orgs","repos_url":"https://api.github.com/users/yuce/repos","events_url":"https://api.github.com/users/yuce/events{/privacy}","received_events_url":"https://api.github.com/users/yuce/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nRefactored all client code into InternalHTTPClient struct which implements InternalClient interface. This allowed us to get rid of some duplicate code and enables us to use another transport other than HTTP in the future.\r\n\r\n## Pull request checklist\r\n\r\n- [x] I have read the [contributing guide](https://github.com/pilosa/pilosa/blob/master/CONTRIBUTING.md).\r\n- [x] I have agreed to the [Contributor License Agreement](https://cla-assistant.io/pilosa/pilosa).\r\n- [ ] I have updated the [documentation](https://github.com/pilosa/pilosa/tree/master/docs).\r\n- [x] I have resolved any merge conflicts.\r\n- [ ] I have included tests that cover my changes.\r\n- [x] All new and existing tests pass.\r\n\r\n## Code review checklist\r\nThis is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.\r\n\r\n- [ ] Ensure that any changes to external docs have been included in this pull request.\r\n- [ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.\r\n- [ ] Ensure the new code is [properly commented](https://github.com/golang/go/wiki/CodeReviewComments#doc-comments) and follows [Idiomatic Go](https://dmitri.shuralyov.com/idiomatic-go).\r\n- [ ] Check that tests have been written and that they cover the new functionality.\r\n- [ ] Run tests and ensure they pass.\r\n- [ ] Build and run the code, performing any applicable integration testing.\r\n","created_at":"2017-10-17T13:06:39Z","updated_at":"2017-10-18T14:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7720027bfc81f1684595682aa34e934855712b6a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pilosa/pilosa/pulls/892/commits","review_comments_url":"https://api.github.com/repos/pilosa/pilosa/pulls/892/comments","review_comment_url":"https://api.github.com/repos/pilosa/pilosa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pilosa/pilosa/issues/892/comments","statuses_url":"https://api.github.com/repos/pilosa/pilosa/statuses/838d56011cb411ea98fb7919a385b07cc446a8ab","head":{"label":"yuce:client-refactoring","ref":"client-refactoring","sha":"838d56011cb411ea98fb7919a385b07cc446a8ab","user":{"login":"yuce","id":513114,"avatar_url":"https://avatars2.githubusercontent.com/u/513114?v=4","gravatar_id":"","url":"https://api.github.com/users/yuce","html_url":"https://github.com/yuce","followers_url":"https://api.github.com/users/yuce/followers","following_url":"https://api.github.com/users/yuce/following{/other_user}","gists_url":"https://api.github.com/users/yuce/gists{/gist_id}","starred_url":"https://api.github.com/users/yuce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuce/subscriptions","organizations_url":"https://api.github.com/users/yuce/orgs","repos_url":"https://api.github.com/users/yuce/repos","events_url":"https://api.github.com/users/yuce/events{/privacy}","received_events_url":"https://api.github.com/users/yuce/received_events","type":"User","site_admin":false},"repo":{"id":89878328,"name":"pilosa","full_name":"yuce/pilosa","owner":{"login":"yuce","id":513114,"avatar_url":"https://avatars2.githubusercontent.com/u/513114?v=4","gravatar_id":"","url":"https://api.github.com/users/yuce","html_url":"https://github.com/yuce","followers_url":"https://api.github.com/users/yuce/followers","following_url":"https://api.github.com/users/yuce/following{/other_user}","gists_url":"https://api.github.com/users/yuce/gists{/gist_id}","starred_url":"https://api.github.com/users/yuce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuce/subscriptions","organizations_url":"https://api.github.com/users/yuce/orgs","repos_url":"https://api.github.com/users/yuce/repos","events_url":"https://api.github.com/users/yuce/events{/privacy}","received_events_url":"https://api.github.com/users/yuce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuce/pilosa","description":"Pilosa is an open source, distributed bitmap index that dramatically accelerates queries across multiple, massive data sets.","fork":true,"url":"https://api.github.com/repos/yuce/pilosa","forks_url":"https://api.github.com/repos/yuce/pilosa/forks","keys_url":"https://api.github.com/repos/yuce/pilosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuce/pilosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuce/pilosa/teams","hooks_url":"https://api.github.com/repos/yuce/pilosa/hooks","issue_events_url":"https://api.github.com/repos/yuce/pilosa/issues/events{/number}","events_url":"https://api.github.com/repos/yuce/pilosa/events","assignees_url":"https://api.github.com/repos/yuce/pilosa/assignees{/user}","branches_url":"https://api.github.com/repos/yuce/pilosa/branches{/branch}","tags_url":"https://api.github.com/repos/yuce/pilosa/tags","blobs_url":"https://api.github.com/repos/yuce/pilosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuce/pilosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuce/pilosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuce/pilosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuce/pilosa/statuses/{sha}","languages_url":"https://api.github.com/repos/yuce/pilosa/languages","stargazers_url":"https://api.github.com/repos/yuce/pilosa/stargazers","contributors_url":"https://api.github.com/repos/yuce/pilosa/contributors","subscribers_url":"https://api.github.com/repos/yuce/pilosa/subscribers","subscription_url":"https://api.github.com/repos/yuce/pilosa/subscription","commits_url":"https://api.github.com/repos/yuce/pilosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuce/pilosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuce/pilosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuce/pilosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuce/pilosa/contents/{+path}","compare_url":"https://api.github.com/repos/yuce/pilosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuce/pilosa/merges","archive_url":"https://api.github.com/repos/yuce/pilosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuce/pilosa/downloads","issues_url":"https://api.github.com/repos/yuce/pilosa/issues{/number}","pulls_url":"https://api.github.com/repos/yuce/pilosa/pulls{/number}","milestones_url":"https://api.github.com/repos/yuce/pilosa/milestones{/number}","notifications_url":"https://api.github.com/repos/yuce/pilosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuce/pilosa/labels{/name}","releases_url":"https://api.github.com/repos/yuce/pilosa/releases{/id}","deployments_url":"https://api.github.com/repos/yuce/pilosa/deployments","created_at":"2017-04-30T21:28:32Z","updated_at":"2017-04-30T21:28:34Z","pushed_at":"2017-10-18T00:41:36Z","git_url":"git://github.com/yuce/pilosa.git","ssh_url":"git@github.com:yuce/pilosa.git","clone_url":"https://github.com/yuce/pilosa.git","svn_url":"https://github.com/yuce/pilosa","homepage":"https://www.pilosa.com","size":3817,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pilosa:master","ref":"master","sha":"4bebc9b9c44a5d16860e8598f37e66d26f6c2ddd","user":{"login":"pilosa","id":24233787,"avatar_url":"https://avatars1.githubusercontent.com/u/24233787?v=4","gravatar_id":"","url":"https://api.github.com/users/pilosa","html_url":"https://github.com/pilosa","followers_url":"https://api.github.com/users/pilosa/followers","following_url":"https://api.github.com/users/pilosa/following{/other_user}","gists_url":"https://api.github.com/users/pilosa/gists{/gist_id}","starred_url":"https://api.github.com/users/pilosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilosa/subscriptions","organizations_url":"https://api.github.com/users/pilosa/orgs","repos_url":"https://api.github.com/users/pilosa/repos","events_url":"https://api.github.com/users/pilosa/events{/privacy}","received_events_url":"https://api.github.com/users/pilosa/received_events","type":"Organization","site_admin":false},"repo":{"id":40127179,"name":"pilosa","full_name":"pilosa/pilosa","owner":{"login":"pilosa","id":24233787,"avatar_url":"https://avatars1.githubusercontent.com/u/24233787?v=4","gravatar_id":"","url":"https://api.github.com/users/pilosa","html_url":"https://github.com/pilosa","followers_url":"https://api.github.com/users/pilosa/followers","following_url":"https://api.github.com/users/pilosa/following{/other_user}","gists_url":"https://api.github.com/users/pilosa/gists{/gist_id}","starred_url":"https://api.github.com/users/pilosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilosa/subscriptions","organizations_url":"https://api.github.com/users/pilosa/orgs","repos_url":"https://api.github.com/users/pilosa/repos","events_url":"https://api.github.com/users/pilosa/events{/privacy}","received_events_url":"https://api.github.com/users/pilosa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pilosa/pilosa","description":"Pilosa is an open source, distributed bitmap index that dramatically accelerates queries across multiple, massive data sets.","fork":false,"url":"https://api.github.com/repos/pilosa/pilosa","forks_url":"https://api.github.com/repos/pilosa/pilosa/forks","keys_url":"https://api.github.com/repos/pilosa/pilosa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pilosa/pilosa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pilosa/pilosa/teams","hooks_url":"https://api.github.com/repos/pilosa/pilosa/hooks","issue_events_url":"https://api.github.com/repos/pilosa/pilosa/issues/events{/number}","events_url":"https://api.github.com/repos/pilosa/pilosa/events","assignees_url":"https://api.github.com/repos/pilosa/pilosa/assignees{/user}","branches_url":"https://api.github.com/repos/pilosa/pilosa/branches{/branch}","tags_url":"https://api.github.com/repos/pilosa/pilosa/tags","blobs_url":"https://api.github.com/repos/pilosa/pilosa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pilosa/pilosa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pilosa/pilosa/git/refs{/sha}","trees_url":"https://api.github.com/repos/pilosa/pilosa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pilosa/pilosa/statuses/{sha}","languages_url":"https://api.github.com/repos/pilosa/pilosa/languages","stargazers_url":"https://api.github.com/repos/pilosa/pilosa/stargazers","contributors_url":"https://api.github.com/repos/pilosa/pilosa/contributors","subscribers_url":"https://api.github.com/repos/pilosa/pilosa/subscribers","subscription_url":"https://api.github.com/repos/pilosa/pilosa/subscription","commits_url":"https://api.github.com/repos/pilosa/pilosa/commits{/sha}","git_commits_url":"https://api.github.com/repos/pilosa/pilosa/git/commits{/sha}","comments_url":"https://api.github.com/repos/pilosa/pilosa/comments{/number}","issue_comment_url":"https://api.github.com/repos/pilosa/pilosa/issues/comments{/number}","contents_url":"https://api.github.com/repos/pilosa/pilosa/contents/{+path}","compare_url":"https://api.github.com/repos/pilosa/pilosa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pilosa/pilosa/merges","archive_url":"https://api.github.com/repos/pilosa/pilosa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pilosa/pilosa/downloads","issues_url":"https://api.github.com/repos/pilosa/pilosa/issues{/number}","pulls_url":"https://api.github.com/repos/pilosa/pilosa/pulls{/number}","milestones_url":"https://api.github.com/repos/pilosa/pilosa/milestones{/number}","notifications_url":"https://api.github.com/repos/pilosa/pilosa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pilosa/pilosa/labels{/name}","releases_url":"https://api.github.com/repos/pilosa/pilosa/releases{/id}","deployments_url":"https://api.github.com/repos/pilosa/pilosa/deployments","created_at":"2015-08-03T13:48:08Z","updated_at":"2017-10-17T13:57:51Z","pushed_at":"2017-10-17T18:50:36Z","git_url":"git://github.com/pilosa/pilosa.git","ssh_url":"git@github.com:pilosa/pilosa.git","clone_url":"https://github.com/pilosa/pilosa.git","svn_url":"https://github.com/pilosa/pilosa","homepage":"https://www.pilosa.com","size":3762,"stargazers_count":1136,"watchers_count":1136,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":108,"forks":70,"open_issues":108,"watchers":1136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/892"},"html":{"href":"https://github.com/pilosa/pilosa/pull/892"},"issue":{"href":"https://api.github.com/repos/pilosa/pilosa/issues/892"},"comments":{"href":"https://api.github.com/repos/pilosa/pilosa/issues/892/comments"},"review_comments":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/892/comments"},"review_comment":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pilosa/pilosa/pulls/892/commits"},"statuses":{"href":"https://api.github.com/repos/pilosa/pilosa/statuses/838d56011cb411ea98fb7919a385b07cc446a8ab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"travisturner"}}