{"action":"created","issue":{"url":"https://api.github.com/repos/ome/ome-common-java/issues/16","repository_url":"https://api.github.com/repos/ome/ome-common-java","labels_url":"https://api.github.com/repos/ome/ome-common-java/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/ome/ome-common-java/issues/16/comments","events_url":"https://api.github.com/repos/ome/ome-common-java/issues/16/events","html_url":"https://github.com/ome/ome-common-java/pull/16","id":260233484,"number":16,"title":"Java 9 build support","user":{"login":"rleigh-codelibre","id":9640520,"avatar_url":"https://avatars1.githubusercontent.com/u/9640520?v=4","gravatar_id":"","url":"https://api.github.com/users/rleigh-codelibre","html_url":"https://github.com/rleigh-codelibre","followers_url":"https://api.github.com/users/rleigh-codelibre/followers","following_url":"https://api.github.com/users/rleigh-codelibre/following{/other_user}","gists_url":"https://api.github.com/users/rleigh-codelibre/gists{/gist_id}","starred_url":"https://api.github.com/users/rleigh-codelibre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rleigh-codelibre/subscriptions","organizations_url":"https://api.github.com/users/rleigh-codelibre/orgs","repos_url":"https://api.github.com/users/rleigh-codelibre/repos","events_url":"https://api.github.com/users/rleigh-codelibre/events{/privacy}","received_events_url":"https://api.github.com/users/rleigh-codelibre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-09-25T10:55:09Z","updated_at":"2017-10-03T07:42:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ome/ome-common-java/pulls/16","html_url":"https://github.com/ome/ome-common-java/pull/16","diff_url":"https://github.com/ome/ome-common-java/pull/16.diff","patch_url":"https://github.com/ome/ome-common-java/pull/16.patch"},"body":"Add support for building with Java 9.\r\n\r\n- Update all maven modules (newer versions have support for Java 9; the old versions we use are broken)\r\n- Bump minimum maven version (required for the new plugin versions)\r\n- Add travis support for building with oraclejdk9 and a recent maven (needed to support Java 9)\r\n\r\nTesting: Check travis builds are all green, including the new Java 9 build.  Check plugin updates are sane with e.g. `mvn versions:display-plugin-updates`"},"comment":{"url":"https://api.github.com/repos/ome/ome-common-java/issues/comments/333765324","html_url":"https://github.com/ome/ome-common-java/pull/16#issuecomment-333765324","issue_url":"https://api.github.com/repos/ome/ome-common-java/issues/16","id":333765324,"user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars1.githubusercontent.com/u/1355463?v=4","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"created_at":"2017-10-03T07:42:45Z","updated_at":"2017-10-03T07:42:45Z","author_association":"OWNER","body":"Thanks for providing https://github.com/ome/ome-common-java/pull/16#issuecomment-332859611. I will look at the release notes as soon as I get some time. A current unknown as discussed last Wednesday are more about the timeline for the `maven-javadoc-plugin` 3.0.0 release.\r\n\r\nIn terms of stack integration, this set of PR  distributed across low-level Java components echo the interrogations raised by @melissalinkert in https://github.com/ome/ome-codecs/pull/8#issue-258943807 i.e. how to integrate PRs opened against decoupled repositories and test them down the stack before we cut releases. As an initial point of discussion, a couple of suggestions ranging from the simplest to the more complex:\r\n\r\n- provide a single `Makefile` or equivalent allowing to create a reproducible build from all the SNAPSHOT and perform some manual testing\r\n- discussed with @melissalinkert, a more systematic approach amending the existing infrastructure could be to script this logic into https://ci.openmicroscopy.org/job/BIOFORMATS-DEV-merge-repository-subset/ and have job additionally merge and build low-level Maven projects before running the automated tests against a subset of the data repository\r\n- a more involved but thorough solution might be to create an ephemerous Continuous Integration server based on the existing [devspace](https://github.com/openmicroscopy/devspace) including Maven jobs for the low-level components and propagating and testing the changes up to the OMERO level.\r\n\r\nOther thoughts welcome on how to review our process to facilitate this integration especially if we want this effort to be coordinated with the upcoming work on Java 9."}}
{"actor":{"display_login":"sbesson"}}