{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/291","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/291/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/291/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/291/events","html_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/291","id":229447725,"number":291,"title":"Build pipeline base image","user":{"login":"chingor13","id":32483,"avatar_url":"https://avatars3.githubusercontent.com/u/32483?v=3","gravatar_id":"","url":"https://api.github.com/users/chingor13","html_url":"https://github.com/chingor13","followers_url":"https://api.github.com/users/chingor13/followers","following_url":"https://api.github.com/users/chingor13/following{/other_user}","gists_url":"https://api.github.com/users/chingor13/gists{/gist_id}","starred_url":"https://api.github.com/users/chingor13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chingor13/subscriptions","organizations_url":"https://api.github.com/users/chingor13/orgs","repos_url":"https://api.github.com/users/chingor13/repos","events_url":"https://api.github.com/users/chingor13/events{/privacy}","received_events_url":"https://api.github.com/users/chingor13/received_events","type":"User","site_admin":false},"labels":[{"id":345339030,"url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/labels/cla:%20yes","name":"cla: yes","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-17T18:30:50Z","updated_at":"2017-05-17T19:49:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/291","html_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/291","diff_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/291.diff","patch_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/291.patch"},"body":"The php-base image no longer has php installed, so we need to specify a versioned (non-on-build) image until gen-dockerfile is updated to detect eh php version and pick the correct base image.\r\n\r\nAlso adds a test that we install the correct php version as we're using the php71 image in the builder pipeline.\r\n\r\nAdditionally, we will have to publish the php versioned images in gcr.io/google-appengine namespace."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/comments/302212441","html_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/291#issuecomment-302212441","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/291","id":302212441,"user":{"login":"tmatsuo","id":41815,"avatar_url":"https://avatars1.githubusercontent.com/u/41815?v=3","gravatar_id":"","url":"https://api.github.com/users/tmatsuo","html_url":"https://github.com/tmatsuo","followers_url":"https://api.github.com/users/tmatsuo/followers","following_url":"https://api.github.com/users/tmatsuo/following{/other_user}","gists_url":"https://api.github.com/users/tmatsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/tmatsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmatsuo/subscriptions","organizations_url":"https://api.github.com/users/tmatsuo/orgs","repos_url":"https://api.github.com/users/tmatsuo/repos","events_url":"https://api.github.com/users/tmatsuo/events{/privacy}","received_events_url":"https://api.github.com/users/tmatsuo/received_events","type":"User","site_admin":false},"created_at":"2017-05-17T19:49:19Z","updated_at":"2017-05-17T19:49:19Z","body":"LGTM\r\n\r\nMy only concern is since there are many deployments happening, so if we run our test cases simultaneously (like for PR and for push, or on circle and on our jenkins), it will fail. Let's have it as it is now, but eventually it's better to have tests only for the builder part."}}
{"actor":{"display_login":"tmatsuo"}}