{"action":"created","issue":{"url":"https://api.github.com/repos/ReactTraining/react-router/issues/5733","repository_url":"https://api.github.com/repos/ReactTraining/react-router","labels_url":"https://api.github.com/repos/ReactTraining/react-router/issues/5733/labels{/name}","comments_url":"https://api.github.com/repos/ReactTraining/react-router/issues/5733/comments","events_url":"https://api.github.com/repos/ReactTraining/react-router/issues/5733/events","html_url":"https://github.com/ReactTraining/react-router/issues/5733","id":274456795,"number":5733,"title":"Clarify react-router-redux' relationship to react-router-dom","user":{"login":"fatso83","id":618076,"avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-16T09:59:25Z","updated_at":"2017-11-16T15:42:09Z","closed_at":"2017-11-16T14:02:46Z","author_association":"NONE","body":"This is more of a feature/bug? request on the docs for `react-router-redux`. The current docs explicitly use imports from `react-router`, while the docs for react-router explicitly tells people _not_ to depend on the base package, but rather either the `react-router-dom` package or its native equivalent. That makes for confusion.\r\n\r\nIf the current approach is due to wanting to stress this package works for both native and dom, I'd rather see you have _two_ examples, rather than one example that contradicts advice given elsewhere in the other packages. So for the normal dom approach, go with  `var Route = require('react-router-dom').Route`.\r\n\r\nedit: Updated to reflect that this is with reference to the `react-router-redux` package. Biproduct of sharing an issue tracker for multiple products :)"},"comment":{"url":"https://api.github.com/repos/ReactTraining/react-router/issues/comments/344962314","html_url":"https://github.com/ReactTraining/react-router/issues/5733#issuecomment-344962314","issue_url":"https://api.github.com/repos/ReactTraining/react-router/issues/5733","id":344962314,"user":{"login":"fatso83","id":618076,"avatar_url":"https://avatars2.githubusercontent.com/u/618076?v=4","gravatar_id":"","url":"https://api.github.com/users/fatso83","html_url":"https://github.com/fatso83","followers_url":"https://api.github.com/users/fatso83/followers","following_url":"https://api.github.com/users/fatso83/following{/other_user}","gists_url":"https://api.github.com/users/fatso83/gists{/gist_id}","starred_url":"https://api.github.com/users/fatso83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatso83/subscriptions","organizations_url":"https://api.github.com/users/fatso83/orgs","repos_url":"https://api.github.com/users/fatso83/repos","events_url":"https://api.github.com/users/fatso83/events{/privacy}","received_events_url":"https://api.github.com/users/fatso83/received_events","type":"User","site_admin":false},"created_at":"2017-11-16T15:42:09Z","updated_at":"2017-11-16T15:42:09Z","author_association":"NONE","body":"I'll try to find the time to push a PR. Was just unsure of what it actually would contain, but now I do. thanks."}}
{"actor":{"display_login":"fatso83"}}