{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls/1","id":156008063,"html_url":"https://github.com/jenkinsci/convert-to-pipeline-plugin/pull/1","diff_url":"https://github.com/jenkinsci/convert-to-pipeline-plugin/pull/1.diff","patch_url":"https://github.com/jenkinsci/convert-to-pipeline-plugin/pull/1.patch","issue_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/issues/1","number":1,"state":"open","locked":false,"title":"Fix conversion of shell script step","user":{"login":"arichardson","id":4019307,"avatar_url":"https://avatars0.githubusercontent.com/u/4019307?v=4","gravatar_id":"","url":"https://api.github.com/users/arichardson","html_url":"https://github.com/arichardson","followers_url":"https://api.github.com/users/arichardson/followers","following_url":"https://api.github.com/users/arichardson/following{/other_user}","gists_url":"https://api.github.com/users/arichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/arichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichardson/subscriptions","organizations_url":"https://api.github.com/users/arichardson/orgs","repos_url":"https://api.github.com/users/arichardson/repos","events_url":"https://api.github.com/users/arichardson/events{/privacy}","received_events_url":"https://api.github.com/users/arichardson/received_events","type":"User","site_admin":false},"body":"Currently the sh step uses `\"\"\"` so groovy attempt to expand any `${FOO}` variables but they should actually be parsed by the shell instead. To fix this I changed it to use a `'''` string.\r\nAlso inserting a newline before the script contents will break any `#!` interpreter selection. I fixed this by only adding a newline if the script doesn't start with `#!`","created_at":"2017-12-02T10:09:04Z","updated_at":"2017-12-02T10:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/issues/1/comments","statuses_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/statuses/a2c99f1145632ba049a41cfe52ac65d922f047e3","head":{"label":"arichardson:fix-sh-conversion","ref":"fix-sh-conversion","sha":"a2c99f1145632ba049a41cfe52ac65d922f047e3","user":{"login":"arichardson","id":4019307,"avatar_url":"https://avatars0.githubusercontent.com/u/4019307?v=4","gravatar_id":"","url":"https://api.github.com/users/arichardson","html_url":"https://github.com/arichardson","followers_url":"https://api.github.com/users/arichardson/followers","following_url":"https://api.github.com/users/arichardson/following{/other_user}","gists_url":"https://api.github.com/users/arichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/arichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichardson/subscriptions","organizations_url":"https://api.github.com/users/arichardson/orgs","repos_url":"https://api.github.com/users/arichardson/repos","events_url":"https://api.github.com/users/arichardson/events{/privacy}","received_events_url":"https://api.github.com/users/arichardson/received_events","type":"User","site_admin":false},"repo":{"id":112733428,"name":"convert-to-pipeline-plugin","full_name":"arichardson/convert-to-pipeline-plugin","owner":{"login":"arichardson","id":4019307,"avatar_url":"https://avatars0.githubusercontent.com/u/4019307?v=4","gravatar_id":"","url":"https://api.github.com/users/arichardson","html_url":"https://github.com/arichardson","followers_url":"https://api.github.com/users/arichardson/followers","following_url":"https://api.github.com/users/arichardson/following{/other_user}","gists_url":"https://api.github.com/users/arichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/arichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arichardson/subscriptions","organizations_url":"https://api.github.com/users/arichardson/orgs","repos_url":"https://api.github.com/users/arichardson/repos","events_url":"https://api.github.com/users/arichardson/events{/privacy}","received_events_url":"https://api.github.com/users/arichardson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arichardson/convert-to-pipeline-plugin","description":"This plugin converts freestyle jobs to Pipeline jobs.","fork":true,"url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin","forks_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/forks","keys_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/teams","hooks_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/hooks","issue_events_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/events","assignees_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/tags","blobs_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/languages","stargazers_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/stargazers","contributors_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/contributors","subscribers_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/subscribers","subscription_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/subscription","commits_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/merges","archive_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/downloads","issues_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/labels{/name}","releases_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/arichardson/convert-to-pipeline-plugin/deployments","created_at":"2017-12-01T11:39:09Z","updated_at":"2017-12-01T11:39:11Z","pushed_at":"2017-12-02T10:05:53Z","git_url":"git://github.com/arichardson/convert-to-pipeline-plugin.git","ssh_url":"git@github.com:arichardson/convert-to-pipeline-plugin.git","clone_url":"https://github.com/arichardson/convert-to-pipeline-plugin.git","svn_url":"https://github.com/arichardson/convert-to-pipeline-plugin","homepage":"","size":139,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"8615b12230996c29b98dbec90b9ae6fb388d389d","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":107170627,"name":"convert-to-pipeline-plugin","full_name":"jenkinsci/convert-to-pipeline-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/convert-to-pipeline-plugin","description":"This plugin converts freestyle jobs to Pipeline jobs.","fork":false,"url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin","forks_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/deployments","created_at":"2017-10-16T19:00:00Z","updated_at":"2017-11-24T07:47:53Z","pushed_at":"2017-10-17T09:56:04Z","git_url":"git://github.com/jenkinsci/convert-to-pipeline-plugin.git","ssh_url":"git@github.com:jenkinsci/convert-to-pipeline-plugin.git","clone_url":"https://github.com/jenkinsci/convert-to-pipeline-plugin.git","svn_url":"https://github.com/jenkinsci/convert-to-pipeline-plugin","homepage":"","size":139,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls/1"},"html":{"href":"https://github.com/jenkinsci/convert-to-pipeline-plugin/pull/1"},"issue":{"href":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/issues/1"},"comments":{"href":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/convert-to-pipeline-plugin/statuses/a2c99f1145632ba049a41cfe52ac65d922f047e3"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":7,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"arichardson"}}