{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/121758195","pull_request_review_id":43812536,"id":121758195,"diff_hunk":"@@ -33,7 +33,13 @@\n // Ensures the user is logged in, and parses the config file.\n require_once \"NDB_Client.class.inc\";\n $client = new NDB_Client();\n-if ($client->initialize(\"../project/config.xml\") == false) {\n+\n+$configFile = getenv('LORIS_DB_CONFIG');","path":"htdocs/GetStatic.php","position":6,"original_position":6,"commit_id":"0c76a518b66c9e60f1eb289558ab858765b4b015","original_commit_id":"0c76a518b66c9e60f1eb289558ab858765b4b015","user":{"login":"driusan","id":498329,"avatar_url":"https://avatars3.githubusercontent.com/u/498329?v=3","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"body":"There's more situations than this to take into account.\r\n\r\nI was going to suggest moving https://github.com/aces/Loris/blob/17.1-dev/php/libraries/NDB_Config.class.inc#L71 into a helper function, but now that I'm looking at it.. wouldn't this work if you just changed it to `$client->initialize(null)`?","created_at":"2017-06-13T18:23:55Z","updated_at":"2017-06-13T18:23:55Z","html_url":"https://github.com/aces/Loris/pull/2827#discussion_r121758195","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/2827","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/121758195"},"html":{"href":"https://github.com/aces/Loris/pull/2827#discussion_r121758195"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/2827"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/2827","id":122093715,"html_url":"https://github.com/aces/Loris/pull/2827","diff_url":"https://github.com/aces/Loris/pull/2827.diff","patch_url":"https://github.com/aces/Loris/pull/2827.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/2827","number":2827,"state":"open","locked":false,"title":"Unbreak Docker tests","user":{"login":"jacobpenny","id":808988,"avatar_url":"https://avatars2.githubusercontent.com/u/808988?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobpenny","html_url":"https://github.com/jacobpenny","followers_url":"https://api.github.com/users/jacobpenny/followers","following_url":"https://api.github.com/users/jacobpenny/following{/other_user}","gists_url":"https://api.github.com/users/jacobpenny/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobpenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobpenny/subscriptions","organizations_url":"https://api.github.com/users/jacobpenny/orgs","repos_url":"https://api.github.com/users/jacobpenny/repos","events_url":"https://api.github.com/users/jacobpenny/events{/privacy}","received_events_url":"https://api.github.com/users/jacobpenny/received_events","type":"User","site_admin":false},"body":"Our tests on Travis and the Docker based test suite got out of sync, this brings them to parity. This PR also changes our travis.yml so that it uses Docker.\r\n\r\n- Disables sandbox mode (as it is in Travis)\r\n- Added a my.conf in order use the same settings as Travis mysql does (The docker mysql image has stricter defaults). This was causing some tests to fail.\r\n- Update TestUser insert statement (Password_MD5 -> Password_hash)","created_at":"2017-05-23T20:57:13Z","updated_at":"2017-06-13T18:23:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49cf0786b41c85d0c32b1c341d40c2ed89bf2d9d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/aces/Loris/milestones/14","html_url":"https://github.com/aces/Loris/milestone/14","labels_url":"https://api.github.com/repos/aces/Loris/milestones/14/labels","id":2062428,"number":14,"title":"17.1","description":"","creator":{"login":"driusan","id":498329,"avatar_url":"https://avatars3.githubusercontent.com/u/498329?v=3","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":268,"state":"open","created_at":"2016-10-11T14:50:29Z","updated_at":"2017-06-12T20:02:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aces/Loris/pulls/2827/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/2827/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/2827/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/0c76a518b66c9e60f1eb289558ab858765b4b015","head":{"label":"jacobpenny:unbreak-docker-tests","ref":"unbreak-docker-tests","sha":"0c76a518b66c9e60f1eb289558ab858765b4b015","user":{"login":"jacobpenny","id":808988,"avatar_url":"https://avatars2.githubusercontent.com/u/808988?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobpenny","html_url":"https://github.com/jacobpenny","followers_url":"https://api.github.com/users/jacobpenny/followers","following_url":"https://api.github.com/users/jacobpenny/following{/other_user}","gists_url":"https://api.github.com/users/jacobpenny/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobpenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobpenny/subscriptions","organizations_url":"https://api.github.com/users/jacobpenny/orgs","repos_url":"https://api.github.com/users/jacobpenny/repos","events_url":"https://api.github.com/users/jacobpenny/events{/privacy}","received_events_url":"https://api.github.com/users/jacobpenny/received_events","type":"User","site_admin":false},"repo":{"id":69995518,"name":"Loris","full_name":"jacobpenny/Loris","owner":{"login":"jacobpenny","id":808988,"avatar_url":"https://avatars2.githubusercontent.com/u/808988?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobpenny","html_url":"https://github.com/jacobpenny","followers_url":"https://api.github.com/users/jacobpenny/followers","following_url":"https://api.github.com/users/jacobpenny/following{/other_user}","gists_url":"https://api.github.com/users/jacobpenny/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobpenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobpenny/subscriptions","organizations_url":"https://api.github.com/users/jacobpenny/orgs","repos_url":"https://api.github.com/users/jacobpenny/repos","events_url":"https://api.github.com/users/jacobpenny/events{/privacy}","received_events_url":"https://api.github.com/users/jacobpenny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacobpenny/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":true,"url":"https://api.github.com/repos/jacobpenny/Loris","forks_url":"https://api.github.com/repos/jacobpenny/Loris/forks","keys_url":"https://api.github.com/repos/jacobpenny/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacobpenny/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacobpenny/Loris/teams","hooks_url":"https://api.github.com/repos/jacobpenny/Loris/hooks","issue_events_url":"https://api.github.com/repos/jacobpenny/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/jacobpenny/Loris/events","assignees_url":"https://api.github.com/repos/jacobpenny/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/jacobpenny/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/jacobpenny/Loris/tags","blobs_url":"https://api.github.com/repos/jacobpenny/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacobpenny/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacobpenny/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacobpenny/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacobpenny/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/jacobpenny/Loris/languages","stargazers_url":"https://api.github.com/repos/jacobpenny/Loris/stargazers","contributors_url":"https://api.github.com/repos/jacobpenny/Loris/contributors","subscribers_url":"https://api.github.com/repos/jacobpenny/Loris/subscribers","subscription_url":"https://api.github.com/repos/jacobpenny/Loris/subscription","commits_url":"https://api.github.com/repos/jacobpenny/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacobpenny/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacobpenny/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacobpenny/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacobpenny/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/jacobpenny/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacobpenny/Loris/merges","archive_url":"https://api.github.com/repos/jacobpenny/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacobpenny/Loris/downloads","issues_url":"https://api.github.com/repos/jacobpenny/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/jacobpenny/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/jacobpenny/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/jacobpenny/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacobpenny/Loris/labels{/name}","releases_url":"https://api.github.com/repos/jacobpenny/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/jacobpenny/Loris/deployments","created_at":"2016-10-04T18:46:09Z","updated_at":"2016-10-04T18:46:12Z","pushed_at":"2017-06-13T17:10:00Z","git_url":"git://github.com/jacobpenny/Loris.git","ssh_url":"git@github.com:jacobpenny/Loris.git","clone_url":"https://github.com/jacobpenny/Loris.git","svn_url":"https://github.com/jacobpenny/Loris","homepage":"","size":70384,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"17.0-dev"}},"base":{"label":"aces:17.1-dev","ref":"17.1-dev","sha":"1006de6e7dabd03fd98363af41ed2a8a3c00204f","user":{"login":"aces","id":472868,"avatar_url":"https://avatars1.githubusercontent.com/u/472868?v=3","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"name":"Loris","full_name":"aces/Loris","owner":{"login":"aces","id":472868,"avatar_url":"https://avatars1.githubusercontent.com/u/472868?v=3","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2017-06-08T20:08:46Z","pushed_at":"2017-06-13T17:10:02Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":69922,"stargazers_count":48,"watchers_count":48,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":66,"forks":76,"open_issues":66,"watchers":48,"default_branch":"17.1-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/2827"},"html":{"href":"https://github.com/aces/Loris/pull/2827"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/2827"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/2827/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/2827/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/2827/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/0c76a518b66c9e60f1eb289558ab858765b4b015"}}}}
{"actor":{"display_login":"driusan"}}