{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/17596","repository_url":"https://api.github.com/repos/odoo/odoo","labels_url":"https://api.github.com/repos/odoo/odoo/issues/17596/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/17596/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/17596/events","html_url":"https://github.com/odoo/odoo/pull/17596","id":235776179,"number":17596,"title":"[ADD] New method to build the key when grouping data for product account move line creation","user":{"login":"benwillig","id":27724417,"avatar_url":"https://avatars0.githubusercontent.com/u/27724417?v=3","gravatar_id":"","url":"https://api.github.com/users/benwillig","html_url":"https://github.com/benwillig","followers_url":"https://api.github.com/users/benwillig/followers","following_url":"https://api.github.com/users/benwillig/following{/other_user}","gists_url":"https://api.github.com/users/benwillig/gists{/gist_id}","starred_url":"https://api.github.com/users/benwillig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwillig/subscriptions","organizations_url":"https://api.github.com/users/benwillig/orgs","repos_url":"https://api.github.com/users/benwillig/repos","events_url":"https://api.github.com/users/benwillig/events{/privacy}","received_events_url":"https://api.github.com/users/benwillig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mart-e","id":564822,"avatar_url":"https://avatars0.githubusercontent.com/u/564822?v=3","gravatar_id":"","url":"https://api.github.com/users/mart-e","html_url":"https://github.com/mart-e","followers_url":"https://api.github.com/users/mart-e/followers","following_url":"https://api.github.com/users/mart-e/following{/other_user}","gists_url":"https://api.github.com/users/mart-e/gists{/gist_id}","starred_url":"https://api.github.com/users/mart-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mart-e/subscriptions","organizations_url":"https://api.github.com/users/mart-e/orgs","repos_url":"https://api.github.com/users/mart-e/repos","events_url":"https://api.github.com/users/mart-e/events{/privacy}","received_events_url":"https://api.github.com/users/mart-e/received_events","type":"User","site_admin":false},"assignees":[{"login":"mart-e","id":564822,"avatar_url":"https://avatars0.githubusercontent.com/u/564822?v=3","gravatar_id":"","url":"https://api.github.com/users/mart-e","html_url":"https://github.com/mart-e","followers_url":"https://api.github.com/users/mart-e/followers","following_url":"https://api.github.com/users/mart-e/following{/other_user}","gists_url":"https://api.github.com/users/mart-e/gists{/gist_id}","starred_url":"https://api.github.com/users/mart-e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mart-e/subscriptions","organizations_url":"https://api.github.com/users/mart-e/orgs","repos_url":"https://api.github.com/users/mart-e/repos","events_url":"https://api.github.com/users/mart-e/events{/privacy}","received_events_url":"https://api.github.com/users/mart-e/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-06-14T06:35:59Z","updated_at":"2017-06-14T09:53:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/17596","html_url":"https://github.com/odoo/odoo/pull/17596","diff_url":"https://github.com/odoo/odoo/pull/17596.diff","patch_url":"https://github.com/odoo/odoo/pull/17596.patch"},"body":"Description of the issue/feature this PR addresses:\r\nAllow inheritance when grouping the product of a POS order by a key.\r\n\r\nCurrent behavior before PR:\r\nNo way to change the grouping method.\r\n\r\nDesired behavior after PR is merged:\r\nAllow to inherit _get_account_move_line_product_key to change the grouping method.\r\n\r\nOPW 747345\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n"},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/308383185","html_url":"https://github.com/odoo/odoo/pull/17596#issuecomment-308383185","issue_url":"https://api.github.com/repos/odoo/odoo/issues/17596","id":308383185,"user":{"login":"benwillig","id":27724417,"avatar_url":"https://avatars0.githubusercontent.com/u/27724417?v=3","gravatar_id":"","url":"https://api.github.com/users/benwillig","html_url":"https://github.com/benwillig","followers_url":"https://api.github.com/users/benwillig/followers","following_url":"https://api.github.com/users/benwillig/following{/other_user}","gists_url":"https://api.github.com/users/benwillig/gists{/gist_id}","starred_url":"https://api.github.com/users/benwillig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwillig/subscriptions","organizations_url":"https://api.github.com/users/benwillig/orgs","repos_url":"https://api.github.com/users/benwillig/repos","events_url":"https://api.github.com/users/benwillig/events{/privacy}","received_events_url":"https://api.github.com/users/benwillig/received_events","type":"User","site_admin":false},"created_at":"2017-06-14T09:53:40Z","updated_at":"2017-06-14T09:53:40Z","body":"I can add 2 others method to handle tax and counter part key. But if we create a single method, I still think it's better to have a specific method for each key. Then the global method would call the method corresponding to the data type.\r\n\r\nI understand this PR is not a true fix, but in my opinion this is an \"inheritance fix\"."}}
{"actor":{"display_login":"benwillig"}}