{"action":"created","comment":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/96128706","pull_request_review_id":16706221,"id":96128706,"diff_hunk":"@@ -116,13 +139,19 @@ var mathit = function(value, mode, options, classes) {\n     if (/[0-9]/.test(value.charAt(0)) ||\n             // glyphs for \\imath and \\jmath do not exist in Math-Italic so we\n             // need to use Main-Italic instead\n-            utils.contains(mainitLetters, value) ||\n-            utils.contains(greekCapitals, value)) {\n-        return makeSymbol(\n-            value, \"Main-Italic\", mode, options, classes.concat([\"mainit\"]));\n+            utils.contains(mainitLetters, value)) {\n+            // For greek capitals, we have a choice, but Math-Italic\n+            // seems closer to LaTeX.\n+            //|| utils.contains(greekCapitals, value)) {\n+        return {\n+            fontName: \"Main-Italic\",\n+            fontClass: \"mainit\"\n+        };\n     } else {\n-        return makeSymbol(\n-            value, \"Math-Italic\", mode, options, classes.concat([\"mathit\"]));\n+        return {\n+            fontName: \"Math-Italic\",\n+            fontClass: \"mathit\"\n+        };\n     }\n };","path":"src/buildCommon.js","position":115,"original_position":106,"commit_id":"5b318e9a3e14821e23cd4d2f2bf725b6daaf1ef9","original_commit_id":"2386a750360445e55a6304b68f1bbfbc6736aafa","user":{"login":"edemaine","id":2218736,"avatar_url":"https://avatars.githubusercontent.com/u/2218736?v=3","gravatar_id":"","url":"https://api.github.com/users/edemaine","html_url":"https://github.com/edemaine","followers_url":"https://api.github.com/users/edemaine/followers","following_url":"https://api.github.com/users/edemaine/following{/other_user}","gists_url":"https://api.github.com/users/edemaine/gists{/gist_id}","starred_url":"https://api.github.com/users/edemaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edemaine/subscriptions","organizations_url":"https://api.github.com/users/edemaine/orgs","repos_url":"https://api.github.com/users/edemaine/repos","events_url":"https://api.github.com/users/edemaine/events{/privacy}","received_events_url":"https://api.github.com/users/edemaine/received_events","type":"User","site_admin":false},"body":"Fixed, thanks!","created_at":"2017-01-15T02:26:21Z","updated_at":"2017-01-15T02:26:21Z","html_url":"https://github.com/Khan/KaTeX/pull/618#discussion_r96128706","pull_request_url":"https://api.github.com/repos/Khan/KaTeX/pulls/618","_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments/96128706"},"html":{"href":"https://github.com/Khan/KaTeX/pull/618#discussion_r96128706"},"pull_request":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/Khan/KaTeX/pulls/618","id":100958985,"html_url":"https://github.com/Khan/KaTeX/pull/618","diff_url":"https://github.com/Khan/KaTeX/pull/618.diff","patch_url":"https://github.com/Khan/KaTeX/pull/618.patch","issue_url":"https://api.github.com/repos/Khan/KaTeX/issues/618","number":618,"state":"open","locked":false,"title":"Fix all AMS mathord symbols","user":{"login":"edemaine","id":2218736,"avatar_url":"https://avatars.githubusercontent.com/u/2218736?v=3","gravatar_id":"","url":"https://api.github.com/users/edemaine","html_url":"https://github.com/edemaine","followers_url":"https://api.github.com/users/edemaine/followers","following_url":"https://api.github.com/users/edemaine/following{/other_user}","gists_url":"https://api.github.com/users/edemaine/gists{/gist_id}","starred_url":"https://api.github.com/users/edemaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edemaine/subscriptions","organizations_url":"https://api.github.com/users/edemaine/orgs","repos_url":"https://api.github.com/users/edemaine/repos","events_url":"https://api.github.com/users/edemaine/events{/privacy}","received_events_url":"https://api.github.com/users/edemaine/received_events","type":"User","site_admin":false},"body":"Here is a fix for #600 (and #609 and #512 and #374).  In fact, all AMS textord symbols were similarly broken.  Here is a complete list of symbols fixed by this PR:\r\n\r\n`\\hslash,\r\n\\triangledown,\r\n\\lozenge,\r\n\\circledS,\r\n\\circledR,\r\n\\measuredangle,\r\n\\nexists,\r\n\\mho,\r\n\\Finv,\r\n\\Game,\r\n\\Bbbk,\r\n\\backprime,\r\n\\blacktriangle,\r\n\\blacktriangledown,\r\n\\blacksquare,\r\n\\blacklozenge,\r\n\\bigstar,\r\n\\sphericalangle,\r\n\\complement,\r\n\\eth,\r\n\\diagup,\r\n\\diagdown,\r\n\\square,\r\n\\Box,\r\n\\Diamond,\r\n\\yen,\r\n\\checkmark,\r\n\\beth,\r\n\\daleth,\r\n\\gimel,\r\n\\digamma,\r\n\\varkappa,\r\n\\varnothing,\r\n\\maltese`\r\n\r\nBasically, in `buildCommon.js`, `mathsym` had logic for choosing between font families `Main-Regular` and `AMS-Regular`, but this applies to types `rel, bin, open, close, inner, punct` only.  `makeOrd` is used specifically for `mathord` and `textord`, and needed similar logic.  To complicate things, `makeOrd` was also losing track of the original macro name and thus AMS vs. Main, replacing it with the unicode symbol.  So I had to refactor code a bit so that `mathDefault` could figure it out.","created_at":"2017-01-10T21:40:40Z","updated_at":"2017-01-15T02:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"026a85431a916c0412b6af8c356a343b01b5a2a8","assignee":{"login":"kevinbarabash","id":1044413,"avatar_url":"https://avatars.githubusercontent.com/u/1044413?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinbarabash","html_url":"https://github.com/kevinbarabash","followers_url":"https://api.github.com/users/kevinbarabash/followers","following_url":"https://api.github.com/users/kevinbarabash/following{/other_user}","gists_url":"https://api.github.com/users/kevinbarabash/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbarabash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbarabash/subscriptions","organizations_url":"https://api.github.com/users/kevinbarabash/orgs","repos_url":"https://api.github.com/users/kevinbarabash/repos","events_url":"https://api.github.com/users/kevinbarabash/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbarabash/received_events","type":"User","site_admin":false},"assignees":[{"login":"kevinbarabash","id":1044413,"avatar_url":"https://avatars.githubusercontent.com/u/1044413?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinbarabash","html_url":"https://github.com/kevinbarabash","followers_url":"https://api.github.com/users/kevinbarabash/followers","following_url":"https://api.github.com/users/kevinbarabash/following{/other_user}","gists_url":"https://api.github.com/users/kevinbarabash/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinbarabash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinbarabash/subscriptions","organizations_url":"https://api.github.com/users/kevinbarabash/orgs","repos_url":"https://api.github.com/users/kevinbarabash/repos","events_url":"https://api.github.com/users/kevinbarabash/events{/privacy}","received_events_url":"https://api.github.com/users/kevinbarabash/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Khan/KaTeX/pulls/618/commits","review_comments_url":"https://api.github.com/repos/Khan/KaTeX/pulls/618/comments","review_comment_url":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Khan/KaTeX/issues/618/comments","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/5b318e9a3e14821e23cd4d2f2bf725b6daaf1ef9","head":{"label":"edemaine:box","ref":"box","sha":"5b318e9a3e14821e23cd4d2f2bf725b6daaf1ef9","user":{"login":"edemaine","id":2218736,"avatar_url":"https://avatars.githubusercontent.com/u/2218736?v=3","gravatar_id":"","url":"https://api.github.com/users/edemaine","html_url":"https://github.com/edemaine","followers_url":"https://api.github.com/users/edemaine/followers","following_url":"https://api.github.com/users/edemaine/following{/other_user}","gists_url":"https://api.github.com/users/edemaine/gists{/gist_id}","starred_url":"https://api.github.com/users/edemaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edemaine/subscriptions","organizations_url":"https://api.github.com/users/edemaine/orgs","repos_url":"https://api.github.com/users/edemaine/repos","events_url":"https://api.github.com/users/edemaine/events{/privacy}","received_events_url":"https://api.github.com/users/edemaine/received_events","type":"User","site_admin":false},"repo":{"id":77924636,"name":"KaTeX","full_name":"edemaine/KaTeX","owner":{"login":"edemaine","id":2218736,"avatar_url":"https://avatars.githubusercontent.com/u/2218736?v=3","gravatar_id":"","url":"https://api.github.com/users/edemaine","html_url":"https://github.com/edemaine","followers_url":"https://api.github.com/users/edemaine/followers","following_url":"https://api.github.com/users/edemaine/following{/other_user}","gists_url":"https://api.github.com/users/edemaine/gists{/gist_id}","starred_url":"https://api.github.com/users/edemaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edemaine/subscriptions","organizations_url":"https://api.github.com/users/edemaine/orgs","repos_url":"https://api.github.com/users/edemaine/repos","events_url":"https://api.github.com/users/edemaine/events{/privacy}","received_events_url":"https://api.github.com/users/edemaine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edemaine/KaTeX","description":"Fast math typesetting for the web.","fork":true,"url":"https://api.github.com/repos/edemaine/KaTeX","forks_url":"https://api.github.com/repos/edemaine/KaTeX/forks","keys_url":"https://api.github.com/repos/edemaine/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edemaine/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edemaine/KaTeX/teams","hooks_url":"https://api.github.com/repos/edemaine/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/edemaine/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/edemaine/KaTeX/events","assignees_url":"https://api.github.com/repos/edemaine/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/edemaine/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/edemaine/KaTeX/tags","blobs_url":"https://api.github.com/repos/edemaine/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edemaine/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edemaine/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/edemaine/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edemaine/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/edemaine/KaTeX/languages","stargazers_url":"https://api.github.com/repos/edemaine/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/edemaine/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/edemaine/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/edemaine/KaTeX/subscription","commits_url":"https://api.github.com/repos/edemaine/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/edemaine/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/edemaine/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/edemaine/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/edemaine/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/edemaine/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edemaine/KaTeX/merges","archive_url":"https://api.github.com/repos/edemaine/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edemaine/KaTeX/downloads","issues_url":"https://api.github.com/repos/edemaine/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/edemaine/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/edemaine/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/edemaine/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edemaine/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/edemaine/KaTeX/releases{/id}","deployments_url":"https://api.github.com/repos/edemaine/KaTeX/deployments","created_at":"2017-01-03T14:34:12Z","updated_at":"2017-01-03T14:34:14Z","pushed_at":"2017-01-15T02:26:05Z","git_url":"git://github.com/edemaine/KaTeX.git","ssh_url":"git@github.com:edemaine/KaTeX.git","clone_url":"https://github.com/edemaine/KaTeX.git","svn_url":"https://github.com/edemaine/KaTeX","homepage":"https://khan.github.io/KaTeX/","size":14673,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Khan:master","ref":"master","sha":"677290336a130f7b6573dd8ac9b5eec273a6de82","user":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"repo":{"id":11195700,"name":"KaTeX","full_name":"Khan/KaTeX","owner":{"login":"Khan","id":15455,"avatar_url":"https://avatars.githubusercontent.com/u/15455?v=3","gravatar_id":"","url":"https://api.github.com/users/Khan","html_url":"https://github.com/Khan","followers_url":"https://api.github.com/users/Khan/followers","following_url":"https://api.github.com/users/Khan/following{/other_user}","gists_url":"https://api.github.com/users/Khan/gists{/gist_id}","starred_url":"https://api.github.com/users/Khan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Khan/subscriptions","organizations_url":"https://api.github.com/users/Khan/orgs","repos_url":"https://api.github.com/users/Khan/repos","events_url":"https://api.github.com/users/Khan/events{/privacy}","received_events_url":"https://api.github.com/users/Khan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Khan/KaTeX","description":"Fast math typesetting for the web.","fork":false,"url":"https://api.github.com/repos/Khan/KaTeX","forks_url":"https://api.github.com/repos/Khan/KaTeX/forks","keys_url":"https://api.github.com/repos/Khan/KaTeX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Khan/KaTeX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Khan/KaTeX/teams","hooks_url":"https://api.github.com/repos/Khan/KaTeX/hooks","issue_events_url":"https://api.github.com/repos/Khan/KaTeX/issues/events{/number}","events_url":"https://api.github.com/repos/Khan/KaTeX/events","assignees_url":"https://api.github.com/repos/Khan/KaTeX/assignees{/user}","branches_url":"https://api.github.com/repos/Khan/KaTeX/branches{/branch}","tags_url":"https://api.github.com/repos/Khan/KaTeX/tags","blobs_url":"https://api.github.com/repos/Khan/KaTeX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Khan/KaTeX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Khan/KaTeX/git/refs{/sha}","trees_url":"https://api.github.com/repos/Khan/KaTeX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Khan/KaTeX/statuses/{sha}","languages_url":"https://api.github.com/repos/Khan/KaTeX/languages","stargazers_url":"https://api.github.com/repos/Khan/KaTeX/stargazers","contributors_url":"https://api.github.com/repos/Khan/KaTeX/contributors","subscribers_url":"https://api.github.com/repos/Khan/KaTeX/subscribers","subscription_url":"https://api.github.com/repos/Khan/KaTeX/subscription","commits_url":"https://api.github.com/repos/Khan/KaTeX/commits{/sha}","git_commits_url":"https://api.github.com/repos/Khan/KaTeX/git/commits{/sha}","comments_url":"https://api.github.com/repos/Khan/KaTeX/comments{/number}","issue_comment_url":"https://api.github.com/repos/Khan/KaTeX/issues/comments{/number}","contents_url":"https://api.github.com/repos/Khan/KaTeX/contents/{+path}","compare_url":"https://api.github.com/repos/Khan/KaTeX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Khan/KaTeX/merges","archive_url":"https://api.github.com/repos/Khan/KaTeX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Khan/KaTeX/downloads","issues_url":"https://api.github.com/repos/Khan/KaTeX/issues{/number}","pulls_url":"https://api.github.com/repos/Khan/KaTeX/pulls{/number}","milestones_url":"https://api.github.com/repos/Khan/KaTeX/milestones{/number}","notifications_url":"https://api.github.com/repos/Khan/KaTeX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Khan/KaTeX/labels{/name}","releases_url":"https://api.github.com/repos/Khan/KaTeX/releases{/id}","deployments_url":"https://api.github.com/repos/Khan/KaTeX/deployments","created_at":"2013-07-05T09:01:54Z","updated_at":"2017-01-14T22:28:51Z","pushed_at":"2017-01-15T02:26:07Z","git_url":"git://github.com/Khan/KaTeX.git","ssh_url":"git@github.com:Khan/KaTeX.git","clone_url":"https://github.com/Khan/KaTeX.git","svn_url":"https://github.com/Khan/KaTeX","homepage":"https://khan.github.io/KaTeX/","size":14494,"stargazers_count":5398,"watchers_count":5398,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":369,"mirror_url":null,"open_issues_count":166,"forks":369,"open_issues":166,"watchers":5398,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/618"},"html":{"href":"https://github.com/Khan/KaTeX/pull/618"},"issue":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/618"},"comments":{"href":"https://api.github.com/repos/Khan/KaTeX/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Khan/KaTeX/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/Khan/KaTeX/statuses/5b318e9a3e14821e23cd4d2f2bf725b6daaf1ef9"}}}}
{"actor":{"display_login":"edemaine"}}