{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/testpilot/issues/2357","repository_url":"https://api.github.com/repos/mozilla/testpilot","labels_url":"https://api.github.com/repos/mozilla/testpilot/issues/2357/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/testpilot/issues/2357/comments","events_url":"https://api.github.com/repos/mozilla/testpilot/issues/2357/events","html_url":"https://github.com/mozilla/testpilot/pull/2357","id":217681594,"number":2357,"title":"add legal-docs as a dependency w/ symlinks; fixes #738","user":{"login":"clouserw","id":80098,"avatar_url":"https://avatars0.githubusercontent.com/u/80098?v=3","gravatar_id":"","url":"https://api.github.com/users/clouserw","html_url":"https://github.com/clouserw","followers_url":"https://api.github.com/users/clouserw/followers","following_url":"https://api.github.com/users/clouserw/following{/other_user}","gists_url":"https://api.github.com/users/clouserw/gists{/gist_id}","starred_url":"https://api.github.com/users/clouserw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clouserw/subscriptions","organizations_url":"https://api.github.com/users/clouserw/orgs","repos_url":"https://api.github.com/users/clouserw/repos","events_url":"https://api.github.com/users/clouserw/events{/privacy}","received_events_url":"https://api.github.com/users/clouserw/received_events","type":"User","site_admin":false},"labels":[{"id":538648329,"url":"https://api.github.com/repos/mozilla/testpilot/labels/status:inreview","name":"status:inreview","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-03-28T20:24:26Z","updated_at":"2017-03-29T17:14:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/testpilot/pulls/2357","html_url":"https://github.com/mozilla/testpilot/pull/2357","diff_url":"https://github.com/mozilla/testpilot/pull/2357.diff","patch_url":"https://github.com/mozilla/testpilot/pull/2357.patch"},"body":"@pdehaan mentioned that the legal-docs repository has a package.json file in it so we can include it as a dependency.  This would make the patch super easy and is what I've done below.\r\n\r\nr? @fzzzy for the overall patch.  One thing I noticed is that the old file was named de.md and the one in the legal-docs repo is de-DE.md.  I remember the bugs where de-DE content wouldn't show up for de, and we might be hitting that again here.  I'll check with legal.\r\n\r\nr? @eleemoz In case you're reading github-mail:  The German Test Pilot legal docs (terms and privacy policies) are specifying they are German for Germany (de-DE) instead of just German (de).  Is that on purpose?  If not, I'd like to change it.\r\n\r\nr? @relud because I want to make sure symlinks will work like this when we deploy.  Any concerns with this?  Also, does our environment get recreated with each deploy so it would re-download these fresh or do we have to think about stale content here?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/testpilot/issues/comments/290158758","html_url":"https://github.com/mozilla/testpilot/pull/2357#issuecomment-290158758","issue_url":"https://api.github.com/repos/mozilla/testpilot/issues/2357","id":290158758,"user":{"login":"clouserw","id":80098,"avatar_url":"https://avatars0.githubusercontent.com/u/80098?v=3","gravatar_id":"","url":"https://api.github.com/users/clouserw","html_url":"https://github.com/clouserw","followers_url":"https://api.github.com/users/clouserw/followers","following_url":"https://api.github.com/users/clouserw/following{/other_user}","gists_url":"https://api.github.com/users/clouserw/gists{/gist_id}","starred_url":"https://api.github.com/users/clouserw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clouserw/subscriptions","organizations_url":"https://api.github.com/users/clouserw/orgs","repos_url":"https://api.github.com/users/clouserw/repos","events_url":"https://api.github.com/users/clouserw/events{/privacy}","received_events_url":"https://api.github.com/users/clouserw/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T17:14:33Z","updated_at":"2017-03-29T17:14:33Z","body":"Thanks for the updates, @relud.\r\n\r\nRegarding that npm error, the legal-docs repository doesn't have an index.json so it can't be require()'d, but we're not doing that, so it should be fine.  It looks like the browser-resolve package (part of browserify?) is iterating all the packages and apparently trying to load them?  That's a guess and this is a bit out of my depth.  @fzzzy (or anyone) is this something you've seen before and/or easy to fix?  \r\n\r\n(side note) It looks like we're only using browserify in one place - do we need it?"}}
{"actor":{"display_login":"clouserw"}}