{"action":"created","comment":{"url":"https://api.github.com/repos/framgia/fdms_ios/pulls/comments/114710144","pull_request_review_id":36197477,"id":114710144,"diff_hunk":"@@ -27,15 +29,25 @@ enum DeviceResult {\n     case failure(Error)\n }\n \n+enum OtherObjectResult {\n+    case success([OtherObject])\n+    case failure(Error)\n+}\n+\n class DeviceService {\n     \n     static let shared: DeviceService = DeviceService()\n     fileprivate lazy var totalPages: Int = 0\n+    fileprivate lazy var responseMessage: String = \"\"","path":"FDMS/Service/DeviceService.swift","position":22,"original_position":22,"commit_id":"aca8283011b249250978b5bc51f60f75d7da0f58","original_commit_id":"aca8283011b249250978b5bc51f60f75d7da0f58","user":{"login":"tienbm92","id":15138667,"avatar_url":"https://avatars3.githubusercontent.com/u/15138667?v=3","gravatar_id":"","url":"https://api.github.com/users/tienbm92","html_url":"https://github.com/tienbm92","followers_url":"https://api.github.com/users/tienbm92/followers","following_url":"https://api.github.com/users/tienbm92/following{/other_user}","gists_url":"https://api.github.com/users/tienbm92/gists{/gist_id}","starred_url":"https://api.github.com/users/tienbm92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tienbm92/subscriptions","organizations_url":"https://api.github.com/users/tienbm92/orgs","repos_url":"https://api.github.com/users/tienbm92/repos","events_url":"https://api.github.com/users/tienbm92/events{/privacy}","received_events_url":"https://api.github.com/users/tienbm92/received_events","type":"User","site_admin":false},"body":"vì không phải API nào cũng có 2 tham số này, nên em để như vậy nhằm tránh việc phải khởi tạo luôn từ lúc đầu, mà khi nào nó được gọi tới thì mới được khởi tạo ạ ","created_at":"2017-05-04T07:07:38Z","updated_at":"2017-05-04T07:07:38Z","html_url":"https://github.com/framgia/fdms_ios/pull/15#discussion_r114710144","pull_request_url":"https://api.github.com/repos/framgia/fdms_ios/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/framgia/fdms_ios/pulls/comments/114710144"},"html":{"href":"https://github.com/framgia/fdms_ios/pull/15#discussion_r114710144"},"pull_request":{"href":"https://api.github.com/repos/framgia/fdms_ios/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/framgia/fdms_ios/pulls/15","id":118720316,"html_url":"https://github.com/framgia/fdms_ios/pull/15","diff_url":"https://github.com/framgia/fdms_ios/pull/15.diff","patch_url":"https://github.com/framgia/fdms_ios/pull/15.patch","issue_url":"https://api.github.com/repos/framgia/fdms_ios/issues/15","number":15,"state":"open","locked":false,"title":"add logic code","user":{"login":"tienbm92","id":15138667,"avatar_url":"https://avatars3.githubusercontent.com/u/15138667?v=3","gravatar_id":"","url":"https://api.github.com/users/tienbm92","html_url":"https://github.com/tienbm92","followers_url":"https://api.github.com/users/tienbm92/followers","following_url":"https://api.github.com/users/tienbm92/following{/other_user}","gists_url":"https://api.github.com/users/tienbm92/gists{/gist_id}","starred_url":"https://api.github.com/users/tienbm92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tienbm92/subscriptions","organizations_url":"https://api.github.com/users/tienbm92/orgs","repos_url":"https://api.github.com/users/tienbm92/repos","events_url":"https://api.github.com/users/tienbm92/events{/privacy}","received_events_url":"https://api.github.com/users/tienbm92/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-03T09:22:34Z","updated_at":"2017-05-04T07:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67b0325ccd416bf0010e13c0a37a29f4fe277ad8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/framgia/fdms_ios/pulls/15/commits","review_comments_url":"https://api.github.com/repos/framgia/fdms_ios/pulls/15/comments","review_comment_url":"https://api.github.com/repos/framgia/fdms_ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/framgia/fdms_ios/issues/15/comments","statuses_url":"https://api.github.com/repos/framgia/fdms_ios/statuses/aca8283011b249250978b5bc51f60f75d7da0f58","head":{"label":"tienbm92:113801_Create_Model_And_Service","ref":"113801_Create_Model_And_Service","sha":"aca8283011b249250978b5bc51f60f75d7da0f58","user":{"login":"tienbm92","id":15138667,"avatar_url":"https://avatars3.githubusercontent.com/u/15138667?v=3","gravatar_id":"","url":"https://api.github.com/users/tienbm92","html_url":"https://github.com/tienbm92","followers_url":"https://api.github.com/users/tienbm92/followers","following_url":"https://api.github.com/users/tienbm92/following{/other_user}","gists_url":"https://api.github.com/users/tienbm92/gists{/gist_id}","starred_url":"https://api.github.com/users/tienbm92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tienbm92/subscriptions","organizations_url":"https://api.github.com/users/tienbm92/orgs","repos_url":"https://api.github.com/users/tienbm92/repos","events_url":"https://api.github.com/users/tienbm92/events{/privacy}","received_events_url":"https://api.github.com/users/tienbm92/received_events","type":"User","site_admin":false},"repo":{"id":87250702,"name":"fdms_ios","full_name":"tienbm92/fdms_ios","owner":{"login":"tienbm92","id":15138667,"avatar_url":"https://avatars3.githubusercontent.com/u/15138667?v=3","gravatar_id":"","url":"https://api.github.com/users/tienbm92","html_url":"https://github.com/tienbm92","followers_url":"https://api.github.com/users/tienbm92/followers","following_url":"https://api.github.com/users/tienbm92/following{/other_user}","gists_url":"https://api.github.com/users/tienbm92/gists{/gist_id}","starred_url":"https://api.github.com/users/tienbm92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tienbm92/subscriptions","organizations_url":"https://api.github.com/users/tienbm92/orgs","repos_url":"https://api.github.com/users/tienbm92/repos","events_url":"https://api.github.com/users/tienbm92/events{/privacy}","received_events_url":"https://api.github.com/users/tienbm92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tienbm92/fdms_ios","description":"FDMS iOS App","fork":true,"url":"https://api.github.com/repos/tienbm92/fdms_ios","forks_url":"https://api.github.com/repos/tienbm92/fdms_ios/forks","keys_url":"https://api.github.com/repos/tienbm92/fdms_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tienbm92/fdms_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tienbm92/fdms_ios/teams","hooks_url":"https://api.github.com/repos/tienbm92/fdms_ios/hooks","issue_events_url":"https://api.github.com/repos/tienbm92/fdms_ios/issues/events{/number}","events_url":"https://api.github.com/repos/tienbm92/fdms_ios/events","assignees_url":"https://api.github.com/repos/tienbm92/fdms_ios/assignees{/user}","branches_url":"https://api.github.com/repos/tienbm92/fdms_ios/branches{/branch}","tags_url":"https://api.github.com/repos/tienbm92/fdms_ios/tags","blobs_url":"https://api.github.com/repos/tienbm92/fdms_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tienbm92/fdms_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tienbm92/fdms_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/tienbm92/fdms_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tienbm92/fdms_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/tienbm92/fdms_ios/languages","stargazers_url":"https://api.github.com/repos/tienbm92/fdms_ios/stargazers","contributors_url":"https://api.github.com/repos/tienbm92/fdms_ios/contributors","subscribers_url":"https://api.github.com/repos/tienbm92/fdms_ios/subscribers","subscription_url":"https://api.github.com/repos/tienbm92/fdms_ios/subscription","commits_url":"https://api.github.com/repos/tienbm92/fdms_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/tienbm92/fdms_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/tienbm92/fdms_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/tienbm92/fdms_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/tienbm92/fdms_ios/contents/{+path}","compare_url":"https://api.github.com/repos/tienbm92/fdms_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tienbm92/fdms_ios/merges","archive_url":"https://api.github.com/repos/tienbm92/fdms_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tienbm92/fdms_ios/downloads","issues_url":"https://api.github.com/repos/tienbm92/fdms_ios/issues{/number}","pulls_url":"https://api.github.com/repos/tienbm92/fdms_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/tienbm92/fdms_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/tienbm92/fdms_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tienbm92/fdms_ios/labels{/name}","releases_url":"https://api.github.com/repos/tienbm92/fdms_ios/releases{/id}","deployments_url":"https://api.github.com/repos/tienbm92/fdms_ios/deployments","created_at":"2017-04-05T01:09:42Z","updated_at":"2017-03-30T07:24:24Z","pushed_at":"2017-05-04T04:47:36Z","git_url":"git://github.com/tienbm92/fdms_ios.git","ssh_url":"git@github.com:tienbm92/fdms_ios.git","clone_url":"https://github.com/tienbm92/fdms_ios.git","svn_url":"https://github.com/tienbm92/fdms_ios","homepage":null,"size":715,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"framgia:develop","ref":"develop","sha":"632bc88e91986c1e90ab74e7a0332a66b55a890f","user":{"login":"framgia","id":2322183,"avatar_url":"https://avatars0.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"repo":{"id":86671996,"name":"fdms_ios","full_name":"framgia/fdms_ios","owner":{"login":"framgia","id":2322183,"avatar_url":"https://avatars0.githubusercontent.com/u/2322183?v=3","gravatar_id":"","url":"https://api.github.com/users/framgia","html_url":"https://github.com/framgia","followers_url":"https://api.github.com/users/framgia/followers","following_url":"https://api.github.com/users/framgia/following{/other_user}","gists_url":"https://api.github.com/users/framgia/gists{/gist_id}","starred_url":"https://api.github.com/users/framgia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgia/subscriptions","organizations_url":"https://api.github.com/users/framgia/orgs","repos_url":"https://api.github.com/users/framgia/repos","events_url":"https://api.github.com/users/framgia/events{/privacy}","received_events_url":"https://api.github.com/users/framgia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/framgia/fdms_ios","description":"FDMS iOS App","fork":false,"url":"https://api.github.com/repos/framgia/fdms_ios","forks_url":"https://api.github.com/repos/framgia/fdms_ios/forks","keys_url":"https://api.github.com/repos/framgia/fdms_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/framgia/fdms_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/framgia/fdms_ios/teams","hooks_url":"https://api.github.com/repos/framgia/fdms_ios/hooks","issue_events_url":"https://api.github.com/repos/framgia/fdms_ios/issues/events{/number}","events_url":"https://api.github.com/repos/framgia/fdms_ios/events","assignees_url":"https://api.github.com/repos/framgia/fdms_ios/assignees{/user}","branches_url":"https://api.github.com/repos/framgia/fdms_ios/branches{/branch}","tags_url":"https://api.github.com/repos/framgia/fdms_ios/tags","blobs_url":"https://api.github.com/repos/framgia/fdms_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/framgia/fdms_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/framgia/fdms_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/framgia/fdms_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/framgia/fdms_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/framgia/fdms_ios/languages","stargazers_url":"https://api.github.com/repos/framgia/fdms_ios/stargazers","contributors_url":"https://api.github.com/repos/framgia/fdms_ios/contributors","subscribers_url":"https://api.github.com/repos/framgia/fdms_ios/subscribers","subscription_url":"https://api.github.com/repos/framgia/fdms_ios/subscription","commits_url":"https://api.github.com/repos/framgia/fdms_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/framgia/fdms_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/framgia/fdms_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/framgia/fdms_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/framgia/fdms_ios/contents/{+path}","compare_url":"https://api.github.com/repos/framgia/fdms_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/framgia/fdms_ios/merges","archive_url":"https://api.github.com/repos/framgia/fdms_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/framgia/fdms_ios/downloads","issues_url":"https://api.github.com/repos/framgia/fdms_ios/issues{/number}","pulls_url":"https://api.github.com/repos/framgia/fdms_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/framgia/fdms_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/framgia/fdms_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/framgia/fdms_ios/labels{/name}","releases_url":"https://api.github.com/repos/framgia/fdms_ios/releases{/id}","deployments_url":"https://api.github.com/repos/framgia/fdms_ios/deployments","created_at":"2017-03-30T07:23:42Z","updated_at":"2017-03-30T07:24:24Z","pushed_at":"2017-05-04T04:47:37Z","git_url":"git://github.com/framgia/fdms_ios.git","ssh_url":"git@github.com:framgia/fdms_ios.git","clone_url":"https://github.com/framgia/fdms_ios.git","svn_url":"https://github.com/framgia/fdms_ios","homepage":null,"size":670,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/framgia/fdms_ios/pulls/15"},"html":{"href":"https://github.com/framgia/fdms_ios/pull/15"},"issue":{"href":"https://api.github.com/repos/framgia/fdms_ios/issues/15"},"comments":{"href":"https://api.github.com/repos/framgia/fdms_ios/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/framgia/fdms_ios/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/framgia/fdms_ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/framgia/fdms_ios/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/framgia/fdms_ios/statuses/aca8283011b249250978b5bc51f60f75d7da0f58"}}}}
{"actor":{"display_login":"tienbm92"}}