{"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/comments/142766152","pull_request_review_id":67176069,"id":142766152,"diff_hunk":"@@ -159,8 +159,8 @@ func (eg *encoderGRPC) bytes() []byte {\n \treturn eg.buf[:eg.writeIdx]\n }\n \n-// EncodeToFullSignature will encode the tagSet to []byte.\n-func EncodeToFullSignature(ts *TagSet) []byte {\n+// Encode will encode the tag set into a []byte.","path":"tags/tag_set_codec.go","position":6,"original_position":6,"commit_id":"d23272c248d915c4b89fedf508761c88e934ba42","original_commit_id":"813041e8bf2e3a8edc3e3b18dc33952d88ee8cb9","user":{"login":"hyangah","id":4999471,"avatar_url":"https://avatars0.githubusercontent.com/u/4999471?v=4","gravatar_id":"","url":"https://api.github.com/users/hyangah","html_url":"https://github.com/hyangah","followers_url":"https://api.github.com/users/hyangah/followers","following_url":"https://api.github.com/users/hyangah/following{/other_user}","gists_url":"https://api.github.com/users/hyangah/gists{/gist_id}","starred_url":"https://api.github.com/users/hyangah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyangah/subscriptions","organizations_url":"https://api.github.com/users/hyangah/orgs","repos_url":"https://api.github.com/users/hyangah/repos","events_url":"https://api.github.com/users/hyangah/events{/privacy}","received_events_url":"https://api.github.com/users/hyangah/received_events","type":"User","site_admin":false},"body":"What I meant is the comment in the current form doesn't add any value and should explain more about what the output is for. I also wanted to highlight that the appearance of grpc in this package doesn't look right (and it seems that succeeded. :-))\r\n","created_at":"2017-10-04T19:13:51Z","updated_at":"2017-10-04T19:13:51Z","html_url":"https://github.com/census-instrumentation/opencensus-go/pull/25#discussion_r142766152","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/comments/142766152"},"html":{"href":"https://github.com/census-instrumentation/opencensus-go/pull/25#discussion_r142766152"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/25"}},"in_reply_to_id":142681776},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/25","id":144546316,"html_url":"https://github.com/census-instrumentation/opencensus-go/pull/25","diff_url":"https://github.com/census-instrumentation/opencensus-go/pull/25.diff","patch_url":"https://github.com/census-instrumentation/opencensus-go/pull/25.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/25","number":25,"state":"open","locked":false,"title":"Use simpler names for binary encoder/decoder","user":{"login":"rakyll","id":108380,"avatar_url":"https://avatars0.githubusercontent.com/u/108380?v=4","gravatar_id":"","url":"https://api.github.com/users/rakyll","html_url":"https://github.com/rakyll","followers_url":"https://api.github.com/users/rakyll/followers","following_url":"https://api.github.com/users/rakyll/following{/other_user}","gists_url":"https://api.github.com/users/rakyll/gists{/gist_id}","starred_url":"https://api.github.com/users/rakyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakyll/subscriptions","organizations_url":"https://api.github.com/users/rakyll/orgs","repos_url":"https://api.github.com/users/rakyll/repos","events_url":"https://api.github.com/users/rakyll/events{/privacy}","received_events_url":"https://api.github.com/users/rakyll/received_events","type":"User","site_admin":false},"body":"Fixes #23.","created_at":"2017-10-03T22:42:28Z","updated_at":"2017-10-04T19:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22453e13cd5ea33e268d538837e17d0e42937e8d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"acetechnologist","id":1875649,"avatar_url":"https://avatars3.githubusercontent.com/u/1875649?v=4","gravatar_id":"","url":"https://api.github.com/users/acetechnologist","html_url":"https://github.com/acetechnologist","followers_url":"https://api.github.com/users/acetechnologist/followers","following_url":"https://api.github.com/users/acetechnologist/following{/other_user}","gists_url":"https://api.github.com/users/acetechnologist/gists{/gist_id}","starred_url":"https://api.github.com/users/acetechnologist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acetechnologist/subscriptions","organizations_url":"https://api.github.com/users/acetechnologist/orgs","repos_url":"https://api.github.com/users/acetechnologist/repos","events_url":"https://api.github.com/users/acetechnologist/events{/privacy}","received_events_url":"https://api.github.com/users/acetechnologist/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/25/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/25/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/25/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/statuses/d23272c248d915c4b89fedf508761c88e934ba42","head":{"label":"rakyll:encodedecode","ref":"encodedecode","sha":"d23272c248d915c4b89fedf508761c88e934ba42","user":{"login":"rakyll","id":108380,"avatar_url":"https://avatars0.githubusercontent.com/u/108380?v=4","gravatar_id":"","url":"https://api.github.com/users/rakyll","html_url":"https://github.com/rakyll","followers_url":"https://api.github.com/users/rakyll/followers","following_url":"https://api.github.com/users/rakyll/following{/other_user}","gists_url":"https://api.github.com/users/rakyll/gists{/gist_id}","starred_url":"https://api.github.com/users/rakyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakyll/subscriptions","organizations_url":"https://api.github.com/users/rakyll/orgs","repos_url":"https://api.github.com/users/rakyll/repos","events_url":"https://api.github.com/users/rakyll/events{/privacy}","received_events_url":"https://api.github.com/users/rakyll/received_events","type":"User","site_admin":false},"repo":{"id":101118715,"name":"opencensus-go","full_name":"rakyll/opencensus-go","owner":{"login":"rakyll","id":108380,"avatar_url":"https://avatars0.githubusercontent.com/u/108380?v=4","gravatar_id":"","url":"https://api.github.com/users/rakyll","html_url":"https://github.com/rakyll","followers_url":"https://api.github.com/users/rakyll/followers","following_url":"https://api.github.com/users/rakyll/following{/other_user}","gists_url":"https://api.github.com/users/rakyll/gists{/gist_id}","starred_url":"https://api.github.com/users/rakyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakyll/subscriptions","organizations_url":"https://api.github.com/users/rakyll/orgs","repos_url":"https://api.github.com/users/rakyll/repos","events_url":"https://api.github.com/users/rakyll/events{/privacy}","received_events_url":"https://api.github.com/users/rakyll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rakyll/opencensus-go","description":null,"fork":true,"url":"https://api.github.com/repos/rakyll/opencensus-go","forks_url":"https://api.github.com/repos/rakyll/opencensus-go/forks","keys_url":"https://api.github.com/repos/rakyll/opencensus-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rakyll/opencensus-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rakyll/opencensus-go/teams","hooks_url":"https://api.github.com/repos/rakyll/opencensus-go/hooks","issue_events_url":"https://api.github.com/repos/rakyll/opencensus-go/issues/events{/number}","events_url":"https://api.github.com/repos/rakyll/opencensus-go/events","assignees_url":"https://api.github.com/repos/rakyll/opencensus-go/assignees{/user}","branches_url":"https://api.github.com/repos/rakyll/opencensus-go/branches{/branch}","tags_url":"https://api.github.com/repos/rakyll/opencensus-go/tags","blobs_url":"https://api.github.com/repos/rakyll/opencensus-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rakyll/opencensus-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rakyll/opencensus-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/rakyll/opencensus-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rakyll/opencensus-go/statuses/{sha}","languages_url":"https://api.github.com/repos/rakyll/opencensus-go/languages","stargazers_url":"https://api.github.com/repos/rakyll/opencensus-go/stargazers","contributors_url":"https://api.github.com/repos/rakyll/opencensus-go/contributors","subscribers_url":"https://api.github.com/repos/rakyll/opencensus-go/subscribers","subscription_url":"https://api.github.com/repos/rakyll/opencensus-go/subscription","commits_url":"https://api.github.com/repos/rakyll/opencensus-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/rakyll/opencensus-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/rakyll/opencensus-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/rakyll/opencensus-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/rakyll/opencensus-go/contents/{+path}","compare_url":"https://api.github.com/repos/rakyll/opencensus-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rakyll/opencensus-go/merges","archive_url":"https://api.github.com/repos/rakyll/opencensus-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rakyll/opencensus-go/downloads","issues_url":"https://api.github.com/repos/rakyll/opencensus-go/issues{/number}","pulls_url":"https://api.github.com/repos/rakyll/opencensus-go/pulls{/number}","milestones_url":"https://api.github.com/repos/rakyll/opencensus-go/milestones{/number}","notifications_url":"https://api.github.com/repos/rakyll/opencensus-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rakyll/opencensus-go/labels{/name}","releases_url":"https://api.github.com/repos/rakyll/opencensus-go/releases{/id}","deployments_url":"https://api.github.com/repos/rakyll/opencensus-go/deployments","created_at":"2017-08-23T00:15:29Z","updated_at":"2017-08-23T00:15:30Z","pushed_at":"2017-10-04T18:55:03Z","git_url":"git://github.com/rakyll/opencensus-go.git","ssh_url":"git@github.com:rakyll/opencensus-go.git","clone_url":"https://github.com/rakyll/opencensus-go.git","svn_url":"https://github.com/rakyll/opencensus-go","homepage":null,"size":188,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"8d0c0088315802ec15cfce4557de6b2aa40ff25c","user":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":81387692,"name":"opencensus-go","full_name":"census-instrumentation/opencensus-go","owner":{"login":"census-instrumentation","id":26944525,"avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/census-instrumentation/opencensus-go","description":"A stats collection and distributed tracing framework","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-go","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-go/deployments","created_at":"2017-02-08T23:40:07Z","updated_at":"2017-10-03T04:52:04Z","pushed_at":"2017-10-04T18:55:04Z","git_url":"git://github.com/census-instrumentation/opencensus-go.git","ssh_url":"git@github.com:census-instrumentation/opencensus-go.git","clone_url":"https://github.com/census-instrumentation/opencensus-go.git","svn_url":"https://github.com/census-instrumentation/opencensus-go","homepage":"","size":86,"stargazers_count":55,"watchers_count":55,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/25"},"html":{"href":"https://github.com/census-instrumentation/opencensus-go/pull/25"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/25"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-go/statuses/d23272c248d915c4b89fedf508761c88e934ba42"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hyangah"}}