{"action":"created","issue":{"url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1927","repository_url":"https://api.github.com/repos/phoenixframework/phoenix","labels_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1927/labels{/name}","comments_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1927/comments","events_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1927/events","html_url":"https://github.com/phoenixframework/phoenix/pull/1927","id":178180515,"number":1927,"title":"Enhance new generators","user":{"login":"chrismccord","id":576796,"avatar_url":"https://avatars.githubusercontent.com/u/576796?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismccord","html_url":"https://github.com/chrismccord","followers_url":"https://api.github.com/users/chrismccord/followers","following_url":"https://api.github.com/users/chrismccord/following{/other_user}","gists_url":"https://api.github.com/users/chrismccord/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismccord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismccord/subscriptions","organizations_url":"https://api.github.com/users/chrismccord/orgs","repos_url":"https://api.github.com/users/chrismccord/repos","events_url":"https://api.github.com/users/chrismccord/events{/privacy}","received_events_url":"https://api.github.com/users/chrismccord/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2016-09-20T21:07:45Z","updated_at":"2017-02-16T13:29:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phoenixframework/phoenix/pulls/1927","html_url":"https://github.com/phoenixframework/phoenix/pull/1927","diff_url":"https://github.com/phoenixframework/phoenix/pull/1927.diff","patch_url":"https://github.com/phoenixframework/phoenix/pull/1927.patch"},"body":"WIP\r\n- [x] Add MyApp.Application\r\n- [x] ensure all model references are gone\r\n- [x] remove errors_on\r\n- [x] add `cd assets` to npm install instructions\r\n- [x] `mix phoenix.routes` should check for `MyApp.Web.Router` and fallback to `MyApp.Router` \r\n- [x] ensure repo is added to ecto_repos, in apps/my_app_web\r\n- [x] add phx.new.web / phx.new.ecto\r\n- [x] add phx.gen.schema (needs docs)\r\n- [x] add phx.gen.html (needs docs)\r\n- [x] add mix phx.gen.json\r\n- [x] add action_fallback\r\n- [x] add function plug support to action_fallback\r\n- [x] normalize MyApp.Web app module across single and umbrella apps\r\n- [x] ensure gen.\\* cannot run from umbrella root\r\n- [ ] Remove shortdoc + deprecate 1.2 generators\r\n- [ ] reconcile --module and --app options when combined with --umbrella\r\n- [ ] remove `new/2` from generated json controller"},"comment":{"url":"https://api.github.com/repos/phoenixframework/phoenix/issues/comments/280330362","html_url":"https://github.com/phoenixframework/phoenix/pull/1927#issuecomment-280330362","issue_url":"https://api.github.com/repos/phoenixframework/phoenix/issues/1927","id":280330362,"user":{"login":"chrismccord","id":576796,"avatar_url":"https://avatars.githubusercontent.com/u/576796?v=3","gravatar_id":"","url":"https://api.github.com/users/chrismccord","html_url":"https://github.com/chrismccord","followers_url":"https://api.github.com/users/chrismccord/followers","following_url":"https://api.github.com/users/chrismccord/following{/other_user}","gists_url":"https://api.github.com/users/chrismccord/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismccord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismccord/subscriptions","organizations_url":"https://api.github.com/users/chrismccord/orgs","repos_url":"https://api.github.com/users/chrismccord/repos","events_url":"https://api.github.com/users/chrismccord/events{/privacy}","received_events_url":"https://api.github.com/users/chrismccord/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T13:29:37Z","updated_at":"2017-02-16T13:29:37Z","body":"@olivermt the generators will check your apps priv dir for the template before using phoenix's, but it's not something that is well documented. It's also going to be brittle so I am okay improving the docs on how to override but we should make the docs clear that it's not something we will ensure backwards compatibility for."}}
{"actor":{"display_login":"chrismccord"}}