{"action":"created","issue":{"url":"https://api.github.com/repos/Originate/recouple/issues/55","repository_url":"https://api.github.com/repos/Originate/recouple","labels_url":"https://api.github.com/repos/Originate/recouple/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/Originate/recouple/issues/55/comments","events_url":"https://api.github.com/repos/Originate/recouple/issues/55/events","html_url":"https://github.com/Originate/recouple/pull/55","id":280644809,"number":55,"title":"Serialize nums in query params with type reps","user":{"login":"ArcherWheeler","id":4099799,"avatar_url":"https://avatars2.githubusercontent.com/u/4099799?v=4","gravatar_id":"","url":"https://api.github.com/users/ArcherWheeler","html_url":"https://github.com/ArcherWheeler","followers_url":"https://api.github.com/users/ArcherWheeler/followers","following_url":"https://api.github.com/users/ArcherWheeler/following{/other_user}","gists_url":"https://api.github.com/users/ArcherWheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/ArcherWheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArcherWheeler/subscriptions","organizations_url":"https://api.github.com/users/ArcherWheeler/orgs","repos_url":"https://api.github.com/users/ArcherWheeler/repos","events_url":"https://api.github.com/users/ArcherWheeler/events{/privacy}","received_events_url":"https://api.github.com/users/ArcherWheeler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-08T23:14:34Z","updated_at":"2017-12-11T17:53:34Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Originate/recouple/pulls/55","html_url":"https://github.com/Originate/recouple/pull/55","diff_url":"https://github.com/Originate/recouple/pull/55.diff","patch_url":"https://github.com/Originate/recouple/pull/55.patch"},"body":"This adds numbers to type reps and allows them to be used for query params. In order to implement this we had to add `deserialize` to TypeRep so that numbers are interpreted as such and not as strings. I imagine there will be some discussion about wether TypeRep should contain logic. For now, we _only_ use TypeRep for things to be deserialized. If in the future we have a need to then we should refactor and split `Serializable` apart from `TypeRep`. \r\n\r\nToDo: Use allow number to be used for capture params.\r\n\r\n#23 "},"comment":{"url":"https://api.github.com/repos/Originate/recouple/issues/comments/350803476","html_url":"https://github.com/Originate/recouple/pull/55#issuecomment-350803476","issue_url":"https://api.github.com/repos/Originate/recouple/issues/55","id":350803476,"user":{"login":"ArcherWheeler","id":4099799,"avatar_url":"https://avatars2.githubusercontent.com/u/4099799?v=4","gravatar_id":"","url":"https://api.github.com/users/ArcherWheeler","html_url":"https://github.com/ArcherWheeler","followers_url":"https://api.github.com/users/ArcherWheeler/followers","following_url":"https://api.github.com/users/ArcherWheeler/following{/other_user}","gists_url":"https://api.github.com/users/ArcherWheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/ArcherWheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArcherWheeler/subscriptions","organizations_url":"https://api.github.com/users/ArcherWheeler/orgs","repos_url":"https://api.github.com/users/ArcherWheeler/repos","events_url":"https://api.github.com/users/ArcherWheeler/events{/privacy}","received_events_url":"https://api.github.com/users/ArcherWheeler/received_events","type":"User","site_admin":false},"created_at":"2017-12-11T17:53:34Z","updated_at":"2017-12-11T17:53:34Z","author_association":"COLLABORATOR","body":"@sleexyz Yeah before this everything was a string. So if you sent a number `?x=47`, it would be assumed to be a string. "}}
{"actor":{"display_login":"ArcherWheeler"}}