{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka-http/pulls/comments/128949826","pull_request_review_id":51673667,"id":128949826,"diff_hunk":"@@ -1,9 +1,14 @@\n # Pluggable Client Transports / HTTPS Proxy Support\n \n The client side infrastructure has (unstable) support to plug different transport mechanisms underneath. A client side\n-transport is represented by an instance of @scaladoc[akka.http.scaladsl.ClientTransport](akka.http.scaladsl.ClientTransport):\n+transport is represented by an instance of\n+@scala[@scaladoc[akka.http.scaladsl.ClientTransport](akka.http.scaladsl.ClientTransport)]@java[@javadoc[akka.http.javadsl.ClientTransport](akka.http.javadsl.ClientTransport)]:\n \n-@@snip [ClientTransport.scala](../../../../../../../akka-http-core/src/main/scala/akka/http/scaladsl/ClientTransport.scala) { #client-transport-definition }\n+Scala\n+:  @@snip [ClientTransport.scala](../../../../../../../akka-http-core/src/main/scala/akka/http/scaladsl/ClientTransport.scala) { #client-transport-definition }\n+\n+Java\n+:  @@snip [ClientTransport.scala](../../../../../../../akka-http-core/src/main/scala/akka/http/javadsl/ClientTransport.scala) { #client-transport-definition }","path":"docs/src/main/paradox/scala/http/client-side/client-transport.md","position":13,"original_position":13,"commit_id":"74428741b42d05d7a1301b9457ee0f9639004d18","original_commit_id":"c582692bcff3fc505f91b87a971549c5e20d7a26","user":{"login":"jonas","id":8417,"avatar_url":"https://avatars2.githubusercontent.com/u/8417?v=4","gravatar_id":"","url":"https://api.github.com/users/jonas","html_url":"https://github.com/jonas","followers_url":"https://api.github.com/users/jonas/followers","following_url":"https://api.github.com/users/jonas/following{/other_user}","gists_url":"https://api.github.com/users/jonas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas/subscriptions","organizations_url":"https://api.github.com/users/jonas/orgs","repos_url":"https://api.github.com/users/jonas/repos","events_url":"https://api.github.com/users/jonas/events{/privacy}","received_events_url":"https://api.github.com/users/jonas/received_events","type":"User","site_admin":false},"body":"Here I don't think quoting the API is necessary since the Scaladoc and Javadoc links provides a way to dig deeper.","created_at":"2017-07-24T05:03:13Z","updated_at":"2017-07-24T05:03:13Z","html_url":"https://github.com/akka/akka-http/pull/1298#discussion_r128949826","pull_request_url":"https://api.github.com/repos/akka/akka-http/pulls/1298","_links":{"self":{"href":"https://api.github.com/repos/akka/akka-http/pulls/comments/128949826"},"html":{"href":"https://github.com/akka/akka-http/pull/1298#discussion_r128949826"},"pull_request":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1298"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka-http/pulls/1298","id":131836939,"html_url":"https://github.com/akka/akka-http/pull/1298","diff_url":"https://github.com/akka/akka-http/pull/1298.diff","patch_url":"https://github.com/akka/akka-http/pull/1298.patch","issue_url":"https://api.github.com/repos/akka/akka-http/issues/1298","number":1298,"state":"open","locked":false,"title":"Merge common/timeouts.md and a few client-side pages","user":{"login":"jonas","id":8417,"avatar_url":"https://avatars2.githubusercontent.com/u/8417?v=4","gravatar_id":"","url":"https://api.github.com/users/jonas","html_url":"https://github.com/jonas","followers_url":"https://api.github.com/users/jonas/followers","following_url":"https://api.github.com/users/jonas/following{/other_user}","gists_url":"https://api.github.com/users/jonas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas/subscriptions","organizations_url":"https://api.github.com/users/jonas/orgs","repos_url":"https://api.github.com/users/jonas/repos","events_url":"https://api.github.com/users/jonas/events{/privacy}","received_events_url":"https://api.github.com/users/jonas/received_events","type":"User","site_admin":false},"body":"Part of #1290 \r\n\r\n- client-side/client-https-support.md\r\n- client-side/client-transport.md\r\n- client-side/connection-level.md\r\n- common/timeouts.md ","created_at":"2017-07-21T18:54:50Z","updated_at":"2017-07-24T05:03:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34d4a2ef78b1b33770ee246475ee88b9fdc0302c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka-http/pulls/1298/commits","review_comments_url":"https://api.github.com/repos/akka/akka-http/pulls/1298/comments","review_comment_url":"https://api.github.com/repos/akka/akka-http/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka-http/issues/1298/comments","statuses_url":"https://api.github.com/repos/akka/akka-http/statuses/74428741b42d05d7a1301b9457ee0f9639004d18","head":{"label":"jonas:doc-merge","ref":"doc-merge","sha":"74428741b42d05d7a1301b9457ee0f9639004d18","user":{"login":"jonas","id":8417,"avatar_url":"https://avatars2.githubusercontent.com/u/8417?v=4","gravatar_id":"","url":"https://api.github.com/users/jonas","html_url":"https://github.com/jonas","followers_url":"https://api.github.com/users/jonas/followers","following_url":"https://api.github.com/users/jonas/following{/other_user}","gists_url":"https://api.github.com/users/jonas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas/subscriptions","organizations_url":"https://api.github.com/users/jonas/orgs","repos_url":"https://api.github.com/users/jonas/repos","events_url":"https://api.github.com/users/jonas/events{/privacy}","received_events_url":"https://api.github.com/users/jonas/received_events","type":"User","site_admin":false},"repo":{"id":68075800,"name":"akka-http","full_name":"jonas/akka-http","owner":{"login":"jonas","id":8417,"avatar_url":"https://avatars2.githubusercontent.com/u/8417?v=4","gravatar_id":"","url":"https://api.github.com/users/jonas","html_url":"https://github.com/jonas","followers_url":"https://api.github.com/users/jonas/followers","following_url":"https://api.github.com/users/jonas/following{/other_user}","gists_url":"https://api.github.com/users/jonas/gists{/gist_id}","starred_url":"https://api.github.com/users/jonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonas/subscriptions","organizations_url":"https://api.github.com/users/jonas/orgs","repos_url":"https://api.github.com/users/jonas/repos","events_url":"https://api.github.com/users/jonas/events{/privacy}","received_events_url":"https://api.github.com/users/jonas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonas/akka-http","description":null,"fork":true,"url":"https://api.github.com/repos/jonas/akka-http","forks_url":"https://api.github.com/repos/jonas/akka-http/forks","keys_url":"https://api.github.com/repos/jonas/akka-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonas/akka-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonas/akka-http/teams","hooks_url":"https://api.github.com/repos/jonas/akka-http/hooks","issue_events_url":"https://api.github.com/repos/jonas/akka-http/issues/events{/number}","events_url":"https://api.github.com/repos/jonas/akka-http/events","assignees_url":"https://api.github.com/repos/jonas/akka-http/assignees{/user}","branches_url":"https://api.github.com/repos/jonas/akka-http/branches{/branch}","tags_url":"https://api.github.com/repos/jonas/akka-http/tags","blobs_url":"https://api.github.com/repos/jonas/akka-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonas/akka-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonas/akka-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonas/akka-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonas/akka-http/statuses/{sha}","languages_url":"https://api.github.com/repos/jonas/akka-http/languages","stargazers_url":"https://api.github.com/repos/jonas/akka-http/stargazers","contributors_url":"https://api.github.com/repos/jonas/akka-http/contributors","subscribers_url":"https://api.github.com/repos/jonas/akka-http/subscribers","subscription_url":"https://api.github.com/repos/jonas/akka-http/subscription","commits_url":"https://api.github.com/repos/jonas/akka-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonas/akka-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonas/akka-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonas/akka-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonas/akka-http/contents/{+path}","compare_url":"https://api.github.com/repos/jonas/akka-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonas/akka-http/merges","archive_url":"https://api.github.com/repos/jonas/akka-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonas/akka-http/downloads","issues_url":"https://api.github.com/repos/jonas/akka-http/issues{/number}","pulls_url":"https://api.github.com/repos/jonas/akka-http/pulls{/number}","milestones_url":"https://api.github.com/repos/jonas/akka-http/milestones{/number}","notifications_url":"https://api.github.com/repos/jonas/akka-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonas/akka-http/labels{/name}","releases_url":"https://api.github.com/repos/jonas/akka-http/releases{/id}","deployments_url":"https://api.github.com/repos/jonas/akka-http/deployments","created_at":"2016-09-13T05:01:47Z","updated_at":"2016-12-09T12:49:58Z","pushed_at":"2017-07-21T18:51:09Z","git_url":"git://github.com/jonas/akka-http.git","ssh_url":"git@github.com:jonas/akka-http.git","clone_url":"https://github.com/jonas/akka-http.git","svn_url":"https://github.com/jonas/akka-http","homepage":null,"size":17843,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"d680b4d6eb9050dc5f30bec39be09b0bffb70d4e","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":66077955,"name":"akka-http","full_name":"akka/akka-http","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka-http","description":"The Streaming-first HTTP server/module of Akka","fork":false,"url":"https://api.github.com/repos/akka/akka-http","forks_url":"https://api.github.com/repos/akka/akka-http/forks","keys_url":"https://api.github.com/repos/akka/akka-http/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka-http/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka-http/teams","hooks_url":"https://api.github.com/repos/akka/akka-http/hooks","issue_events_url":"https://api.github.com/repos/akka/akka-http/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka-http/events","assignees_url":"https://api.github.com/repos/akka/akka-http/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka-http/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka-http/tags","blobs_url":"https://api.github.com/repos/akka/akka-http/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka-http/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka-http/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka-http/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka-http/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka-http/languages","stargazers_url":"https://api.github.com/repos/akka/akka-http/stargazers","contributors_url":"https://api.github.com/repos/akka/akka-http/contributors","subscribers_url":"https://api.github.com/repos/akka/akka-http/subscribers","subscription_url":"https://api.github.com/repos/akka/akka-http/subscription","commits_url":"https://api.github.com/repos/akka/akka-http/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka-http/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka-http/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka-http/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka-http/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka-http/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka-http/merges","archive_url":"https://api.github.com/repos/akka/akka-http/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka-http/downloads","issues_url":"https://api.github.com/repos/akka/akka-http/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka-http/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka-http/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka-http/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka-http/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka-http/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka-http/deployments","created_at":"2016-08-19T11:33:36Z","updated_at":"2017-07-23T16:35:45Z","pushed_at":"2017-07-23T13:07:28Z","git_url":"git://github.com/akka/akka-http.git","ssh_url":"git@github.com:akka/akka-http.git","clone_url":"https://github.com/akka/akka-http.git","svn_url":"https://github.com/akka/akka-http","homepage":"http://akka.io","size":7967,"stargazers_count":397,"watchers_count":397,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":183,"mirror_url":null,"open_issues_count":427,"forks":183,"open_issues":427,"watchers":397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1298"},"html":{"href":"https://github.com/akka/akka-http/pull/1298"},"issue":{"href":"https://api.github.com/repos/akka/akka-http/issues/1298"},"comments":{"href":"https://api.github.com/repos/akka/akka-http/issues/1298/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1298/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka-http/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka-http/pulls/1298/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka-http/statuses/74428741b42d05d7a1301b9457ee0f9639004d18"}}}}
{"actor":{"display_login":"jonas"}}