{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/118174192","pull_request_review_id":39938893,"id":118174192,"diff_hunk":"@@ -0,0 +1,72 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.kafka.common;\n+\n+import java.util.HashSet;\n+import java.util.Set;\n+\n+import org.apache.kafka.common.utils.Utils;\n+\n+/**\n+ *         A template for a MetricName. It contains a name, group, and\n+ *         description, as well as all the tags that will be used to create the\n+ *         mBean name. Tag values are omitted from the template, but are filled\n+ *         in at runtime with their specified values.\n+ */\n+public class MetricNameTemplate {","path":"clients/src/main/java/org/apache/kafka/common/MetricNameTemplate.java","position":null,"original_position":30,"commit_id":"1eeff2f43e5c9b9f9f09d9515b900b32abde3466","original_commit_id":"e0c28c28f13cffae0d2d46e9a84466844f3a00a7","user":{"login":"wushujames","id":677529,"avatar_url":"https://avatars2.githubusercontent.com/u/677529?v=3","gravatar_id":"","url":"https://api.github.com/users/wushujames","html_url":"https://github.com/wushujames","followers_url":"https://api.github.com/users/wushujames/followers","following_url":"https://api.github.com/users/wushujames/following{/other_user}","gists_url":"https://api.github.com/users/wushujames/gists{/gist_id}","starred_url":"https://api.github.com/users/wushujames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wushujames/subscriptions","organizations_url":"https://api.github.com/users/wushujames/orgs","repos_url":"https://api.github.com/users/wushujames/repos","events_url":"https://api.github.com/users/wushujames/events{/privacy}","received_events_url":"https://api.github.com/users/wushujames/received_events","type":"User","site_admin":false},"body":"There's some background discussion on this, in https://issues.apache.org/jira/browse/KAFKA-3480","created_at":"2017-05-24T06:49:43Z","updated_at":"2017-05-24T06:49:43Z","html_url":"https://github.com/apache/kafka/pull/2993#discussion_r118174192","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/2993","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/118174192"},"html":{"href":"https://github.com/apache/kafka/pull/2993#discussion_r118174192"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/2993"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/2993","id":119378524,"html_url":"https://github.com/apache/kafka/pull/2993","diff_url":"https://github.com/apache/kafka/pull/2993.diff","patch_url":"https://github.com/apache/kafka/pull/2993.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/2993","number":2993,"state":"open","locked":false,"title":"KAFKA-5191: Autogenerate Consumer Fetcher metrics","user":{"login":"wushujames","id":677529,"avatar_url":"https://avatars2.githubusercontent.com/u/677529?v=3","gravatar_id":"","url":"https://api.github.com/users/wushujames","html_url":"https://github.com/wushujames","followers_url":"https://api.github.com/users/wushujames/followers","following_url":"https://api.github.com/users/wushujames/following{/other_user}","gists_url":"https://api.github.com/users/wushujames/gists{/gist_id}","starred_url":"https://api.github.com/users/wushujames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wushujames/subscriptions","organizations_url":"https://api.github.com/users/wushujames/orgs","repos_url":"https://api.github.com/users/wushujames/repos","events_url":"https://api.github.com/users/wushujames/events{/privacy}","received_events_url":"https://api.github.com/users/wushujames/received_events","type":"User","site_admin":false},"body":"Autogenerate docs for the Consumer Fetcher's metrics. This is a smaller subset of the original PR https://github.com/apache/kafka/pull/1202.\r\n\r\nCC @ijuma @benstopford @hachikuji ","created_at":"2017-05-08T05:17:05Z","updated_at":"2017-05-24T06:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36fee4f75fdae4807e243d77ea2362e7bc761ddb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/2993/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/2993/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/2993/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/1eeff2f43e5c9b9f9f09d9515b900b32abde3466","head":{"label":"wushujames:fetcher_metrics_docs","ref":"fetcher_metrics_docs","sha":"1eeff2f43e5c9b9f9f09d9515b900b32abde3466","user":{"login":"wushujames","id":677529,"avatar_url":"https://avatars2.githubusercontent.com/u/677529?v=3","gravatar_id":"","url":"https://api.github.com/users/wushujames","html_url":"https://github.com/wushujames","followers_url":"https://api.github.com/users/wushujames/followers","following_url":"https://api.github.com/users/wushujames/following{/other_user}","gists_url":"https://api.github.com/users/wushujames/gists{/gist_id}","starred_url":"https://api.github.com/users/wushujames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wushujames/subscriptions","organizations_url":"https://api.github.com/users/wushujames/orgs","repos_url":"https://api.github.com/users/wushujames/repos","events_url":"https://api.github.com/users/wushujames/events{/privacy}","received_events_url":"https://api.github.com/users/wushujames/received_events","type":"User","site_admin":false},"repo":{"id":50275204,"name":"kafka","full_name":"wushujames/kafka","owner":{"login":"wushujames","id":677529,"avatar_url":"https://avatars2.githubusercontent.com/u/677529?v=3","gravatar_id":"","url":"https://api.github.com/users/wushujames","html_url":"https://github.com/wushujames","followers_url":"https://api.github.com/users/wushujames/followers","following_url":"https://api.github.com/users/wushujames/following{/other_user}","gists_url":"https://api.github.com/users/wushujames/gists{/gist_id}","starred_url":"https://api.github.com/users/wushujames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wushujames/subscriptions","organizations_url":"https://api.github.com/users/wushujames/orgs","repos_url":"https://api.github.com/users/wushujames/repos","events_url":"https://api.github.com/users/wushujames/events{/privacy}","received_events_url":"https://api.github.com/users/wushujames/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wushujames/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/wushujames/kafka","forks_url":"https://api.github.com/repos/wushujames/kafka/forks","keys_url":"https://api.github.com/repos/wushujames/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wushujames/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wushujames/kafka/teams","hooks_url":"https://api.github.com/repos/wushujames/kafka/hooks","issue_events_url":"https://api.github.com/repos/wushujames/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/wushujames/kafka/events","assignees_url":"https://api.github.com/repos/wushujames/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/wushujames/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/wushujames/kafka/tags","blobs_url":"https://api.github.com/repos/wushujames/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wushujames/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wushujames/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/wushujames/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wushujames/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/wushujames/kafka/languages","stargazers_url":"https://api.github.com/repos/wushujames/kafka/stargazers","contributors_url":"https://api.github.com/repos/wushujames/kafka/contributors","subscribers_url":"https://api.github.com/repos/wushujames/kafka/subscribers","subscription_url":"https://api.github.com/repos/wushujames/kafka/subscription","commits_url":"https://api.github.com/repos/wushujames/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/wushujames/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/wushujames/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/wushujames/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/wushujames/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/wushujames/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wushujames/kafka/merges","archive_url":"https://api.github.com/repos/wushujames/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wushujames/kafka/downloads","issues_url":"https://api.github.com/repos/wushujames/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/wushujames/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/wushujames/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/wushujames/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wushujames/kafka/labels{/name}","releases_url":"https://api.github.com/repos/wushujames/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/wushujames/kafka/deployments","created_at":"2016-01-24T06:22:52Z","updated_at":"2016-01-24T06:22:56Z","pushed_at":"2017-05-24T06:48:08Z","git_url":"git://github.com/wushujames/kafka.git","ssh_url":"git@github.com:wushujames/kafka.git","clone_url":"https://github.com/wushujames/kafka.git","svn_url":"https://github.com/wushujames/kafka","homepage":null,"size":48575,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"1bf64833168e81015e1f30a30c64eb6849c15422","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-05-24T06:20:30Z","pushed_at":"2017-05-24T06:48:10Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":48577,"stargazers_count":5248,"watchers_count":5248,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3254,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":362,"forks":3254,"open_issues":362,"watchers":5248,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/2993"},"html":{"href":"https://github.com/apache/kafka/pull/2993"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/2993"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/2993/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/2993/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/2993/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/1eeff2f43e5c9b9f9f09d9515b900b32abde3466"}}}}
{"actor":{"display_login":"wushujames"}}