{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41912","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41912/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41912/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41912/events","html_url":"https://github.com/kubernetes/kubernetes/pull/41912","id":209545021,"number":41912,"title":"Rotate kubelet client certificate.","user":{"login":"jcbsmpsn","id":20646565,"avatar_url":"https://avatars2.githubusercontent.com/u/20646565?v=3","gravatar_id":"","url":"https://api.github.com/users/jcbsmpsn","html_url":"https://github.com/jcbsmpsn","followers_url":"https://api.github.com/users/jcbsmpsn/followers","following_url":"https://api.github.com/users/jcbsmpsn/following{/other_user}","gists_url":"https://api.github.com/users/jcbsmpsn/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbsmpsn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbsmpsn/subscriptions","organizations_url":"https://api.github.com/users/jcbsmpsn/orgs","repos_url":"https://api.github.com/users/jcbsmpsn/repos","events_url":"https://api.github.com/users/jcbsmpsn/events{/privacy}","received_events_url":"https://api.github.com/users/jcbsmpsn/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars3.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"liggitt","id":980082,"avatar_url":"https://avatars3.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars0.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},{"login":"timstclair","id":3272040,"avatar_url":"https://avatars2.githubusercontent.com/u/3272040?v=3","gravatar_id":"","url":"https://api.github.com/users/timstclair","html_url":"https://github.com/timstclair","followers_url":"https://api.github.com/users/timstclair/followers","following_url":"https://api.github.com/users/timstclair/following{/other_user}","gists_url":"https://api.github.com/users/timstclair/gists{/gist_id}","starred_url":"https://api.github.com/users/timstclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstclair/subscriptions","organizations_url":"https://api.github.com/users/timstclair/orgs","repos_url":"https://api.github.com/users/timstclair/repos","events_url":"https://api.github.com/users/timstclair/events{/privacy}","received_events_url":"https://api.github.com/users/timstclair/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2017-02-22T18:47:54Z","updated_at":"2017-05-08T22:33:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41912","html_url":"https://github.com/kubernetes/kubernetes/pull/41912","diff_url":"https://github.com/kubernetes/kubernetes/pull/41912.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/41912.patch"},"body":"Changes the kubelet so it bootstraps off the cert/key specified in the\r\nconfig file and uses those to request new cert/key pairs from the\r\nCertificate Signing Request API, as well as rotating client certificates\r\nwhen they approach expiration.\r\n\r\nDefault behavior is for client certificate rotation to be disabled. If enabled\r\nusing a command line flag, the kubelet exits each time the certificate is\r\nrotated. I tried to use `GetCertificate` in [tls.Config](https://golang.org/pkg/crypto/tls/#Config) but it is only called\r\non the server side of connections. Then I tried `GetClientCertificate`,\r\nbut it is new in 1.8.\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/300009693","html_url":"https://github.com/kubernetes/kubernetes/pull/41912#issuecomment-300009693","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41912","id":300009693,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars3.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-05-08T22:33:08Z","updated_at":"2017-05-08T22:33:08Z","body":"@jcbsmpsn: The following test(s) **failed**:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nJenkins GCE Node e2e | ee93d1d9aa07cce694163ee522b6deb963a2e77c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/41912/pull-kubernetes-node-e2e/28864/) | `@k8s-bot node e2e test this`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/41912). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/jcbsmpsn). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-request-commands.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}