{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls/36","id":123158975,"html_url":"https://github.com/NodeRedis/node-redis-parser/pull/36","diff_url":"https://github.com/NodeRedis/node-redis-parser/pull/36.diff","patch_url":"https://github.com/NodeRedis/node-redis-parser/pull/36.patch","issue_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/issues/36","number":36,"state":"closed","locked":false,"title":"Update Package.json - Move hiredis to dependencies","user":{"login":"christianpv","id":6967580,"avatar_url":"https://avatars0.githubusercontent.com/u/6967580?v=3","gravatar_id":"","url":"https://api.github.com/users/christianpv","html_url":"https://github.com/christianpv","followers_url":"https://api.github.com/users/christianpv/followers","following_url":"https://api.github.com/users/christianpv/following{/other_user}","gists_url":"https://api.github.com/users/christianpv/gists{/gist_id}","starred_url":"https://api.github.com/users/christianpv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianpv/subscriptions","organizations_url":"https://api.github.com/users/christianpv/orgs","repos_url":"https://api.github.com/users/christianpv/repos","events_url":"https://api.github.com/users/christianpv/events{/privacy}","received_events_url":"https://api.github.com/users/christianpv/received_events","type":"User","site_admin":false},"body":"Installing `redis-parser` with `yarn` does not install `hiredis`. I believe build is passing because we are running `npm install hiredis` in .travis.yml\r\n\r\nNevermind, I think it was another issue upstream. Thanks a lot for your time.","created_at":"2017-05-30T22:40:23Z","updated_at":"2017-05-30T22:57:18Z","closed_at":"2017-05-30T22:57:18Z","merged_at":null,"merge_commit_sha":"59946933cc333ba457a7f0c3bc1edb7f67400721","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls/36/commits","review_comments_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls/36/comments","review_comment_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/issues/36/comments","statuses_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/statuses/d283818bc2d2ff03cb1499ee149cd0f2c2631ef5","head":{"label":"christianpv:master","ref":"master","sha":"d283818bc2d2ff03cb1499ee149cd0f2c2631ef5","user":{"login":"christianpv","id":6967580,"avatar_url":"https://avatars0.githubusercontent.com/u/6967580?v=3","gravatar_id":"","url":"https://api.github.com/users/christianpv","html_url":"https://github.com/christianpv","followers_url":"https://api.github.com/users/christianpv/followers","following_url":"https://api.github.com/users/christianpv/following{/other_user}","gists_url":"https://api.github.com/users/christianpv/gists{/gist_id}","starred_url":"https://api.github.com/users/christianpv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianpv/subscriptions","organizations_url":"https://api.github.com/users/christianpv/orgs","repos_url":"https://api.github.com/users/christianpv/repos","events_url":"https://api.github.com/users/christianpv/events{/privacy}","received_events_url":"https://api.github.com/users/christianpv/received_events","type":"User","site_admin":false},"repo":{"id":92881719,"name":"node-redis-parser","full_name":"christianpv/node-redis-parser","owner":{"login":"christianpv","id":6967580,"avatar_url":"https://avatars0.githubusercontent.com/u/6967580?v=3","gravatar_id":"","url":"https://api.github.com/users/christianpv","html_url":"https://github.com/christianpv","followers_url":"https://api.github.com/users/christianpv/followers","following_url":"https://api.github.com/users/christianpv/following{/other_user}","gists_url":"https://api.github.com/users/christianpv/gists{/gist_id}","starred_url":"https://api.github.com/users/christianpv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianpv/subscriptions","organizations_url":"https://api.github.com/users/christianpv/orgs","repos_url":"https://api.github.com/users/christianpv/repos","events_url":"https://api.github.com/users/christianpv/events{/privacy}","received_events_url":"https://api.github.com/users/christianpv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christianpv/node-redis-parser","description":"Javascript Redis protocol (RESP) parser ","fork":true,"url":"https://api.github.com/repos/christianpv/node-redis-parser","forks_url":"https://api.github.com/repos/christianpv/node-redis-parser/forks","keys_url":"https://api.github.com/repos/christianpv/node-redis-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christianpv/node-redis-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christianpv/node-redis-parser/teams","hooks_url":"https://api.github.com/repos/christianpv/node-redis-parser/hooks","issue_events_url":"https://api.github.com/repos/christianpv/node-redis-parser/issues/events{/number}","events_url":"https://api.github.com/repos/christianpv/node-redis-parser/events","assignees_url":"https://api.github.com/repos/christianpv/node-redis-parser/assignees{/user}","branches_url":"https://api.github.com/repos/christianpv/node-redis-parser/branches{/branch}","tags_url":"https://api.github.com/repos/christianpv/node-redis-parser/tags","blobs_url":"https://api.github.com/repos/christianpv/node-redis-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christianpv/node-redis-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christianpv/node-redis-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/christianpv/node-redis-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christianpv/node-redis-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/christianpv/node-redis-parser/languages","stargazers_url":"https://api.github.com/repos/christianpv/node-redis-parser/stargazers","contributors_url":"https://api.github.com/repos/christianpv/node-redis-parser/contributors","subscribers_url":"https://api.github.com/repos/christianpv/node-redis-parser/subscribers","subscription_url":"https://api.github.com/repos/christianpv/node-redis-parser/subscription","commits_url":"https://api.github.com/repos/christianpv/node-redis-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/christianpv/node-redis-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/christianpv/node-redis-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/christianpv/node-redis-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/christianpv/node-redis-parser/contents/{+path}","compare_url":"https://api.github.com/repos/christianpv/node-redis-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christianpv/node-redis-parser/merges","archive_url":"https://api.github.com/repos/christianpv/node-redis-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christianpv/node-redis-parser/downloads","issues_url":"https://api.github.com/repos/christianpv/node-redis-parser/issues{/number}","pulls_url":"https://api.github.com/repos/christianpv/node-redis-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/christianpv/node-redis-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/christianpv/node-redis-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christianpv/node-redis-parser/labels{/name}","releases_url":"https://api.github.com/repos/christianpv/node-redis-parser/releases{/id}","deployments_url":"https://api.github.com/repos/christianpv/node-redis-parser/deployments","created_at":"2017-05-30T22:30:41Z","updated_at":"2017-05-30T22:30:43Z","pushed_at":"2017-05-30T22:31:32Z","git_url":"git://github.com/christianpv/node-redis-parser.git","ssh_url":"git@github.com:christianpv/node-redis-parser.git","clone_url":"https://github.com/christianpv/node-redis-parser.git","svn_url":"https://github.com/christianpv/node-redis-parser","homepage":null,"size":206,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NodeRedis:master","ref":"master","sha":"701655430f5f7d9ca00892a02f7eefcbc1193a98","user":{"login":"NodeRedis","id":5845577,"avatar_url":"https://avatars1.githubusercontent.com/u/5845577?v=3","gravatar_id":"","url":"https://api.github.com/users/NodeRedis","html_url":"https://github.com/NodeRedis","followers_url":"https://api.github.com/users/NodeRedis/followers","following_url":"https://api.github.com/users/NodeRedis/following{/other_user}","gists_url":"https://api.github.com/users/NodeRedis/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeRedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeRedis/subscriptions","organizations_url":"https://api.github.com/users/NodeRedis/orgs","repos_url":"https://api.github.com/users/NodeRedis/repos","events_url":"https://api.github.com/users/NodeRedis/events{/privacy}","received_events_url":"https://api.github.com/users/NodeRedis/received_events","type":"Organization","site_admin":false},"repo":{"id":44634462,"name":"node-redis-parser","full_name":"NodeRedis/node-redis-parser","owner":{"login":"NodeRedis","id":5845577,"avatar_url":"https://avatars1.githubusercontent.com/u/5845577?v=3","gravatar_id":"","url":"https://api.github.com/users/NodeRedis","html_url":"https://github.com/NodeRedis","followers_url":"https://api.github.com/users/NodeRedis/followers","following_url":"https://api.github.com/users/NodeRedis/following{/other_user}","gists_url":"https://api.github.com/users/NodeRedis/gists{/gist_id}","starred_url":"https://api.github.com/users/NodeRedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NodeRedis/subscriptions","organizations_url":"https://api.github.com/users/NodeRedis/orgs","repos_url":"https://api.github.com/users/NodeRedis/repos","events_url":"https://api.github.com/users/NodeRedis/events{/privacy}","received_events_url":"https://api.github.com/users/NodeRedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NodeRedis/node-redis-parser","description":"Javascript Redis protocol (RESP) parser ","fork":false,"url":"https://api.github.com/repos/NodeRedis/node-redis-parser","forks_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/forks","keys_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/teams","hooks_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/hooks","issue_events_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/issues/events{/number}","events_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/events","assignees_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/assignees{/user}","branches_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/branches{/branch}","tags_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/tags","blobs_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/languages","stargazers_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/stargazers","contributors_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/contributors","subscribers_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/subscribers","subscription_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/subscription","commits_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/contents/{+path}","compare_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/merges","archive_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/downloads","issues_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/issues{/number}","pulls_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/labels{/name}","releases_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/releases{/id}","deployments_url":"https://api.github.com/repos/NodeRedis/node-redis-parser/deployments","created_at":"2015-10-20T20:55:59Z","updated_at":"2017-05-20T09:08:36Z","pushed_at":"2017-05-30T22:40:24Z","git_url":"git://github.com/NodeRedis/node-redis-parser.git","ssh_url":"git@github.com:NodeRedis/node-redis-parser.git","clone_url":"https://github.com/NodeRedis/node-redis-parser.git","svn_url":"https://github.com/NodeRedis/node-redis-parser","homepage":null,"size":206,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":0,"forks":15,"open_issues":0,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls/36"},"html":{"href":"https://github.com/NodeRedis/node-redis-parser/pull/36"},"issue":{"href":"https://api.github.com/repos/NodeRedis/node-redis-parser/issues/36"},"comments":{"href":"https://api.github.com/repos/NodeRedis/node-redis-parser/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NodeRedis/node-redis-parser/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/NodeRedis/node-redis-parser/statuses/d283818bc2d2ff03cb1499ee149cd0f2c2631ef5"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"christianpv"}}