{"action":"created","issue":{"url":"https://api.github.com/repos/ForestryMC/Binnie/issues/277","repository_url":"https://api.github.com/repos/ForestryMC/Binnie","labels_url":"https://api.github.com/repos/ForestryMC/Binnie/issues/277/labels{/name}","comments_url":"https://api.github.com/repos/ForestryMC/Binnie/issues/277/comments","events_url":"https://api.github.com/repos/ForestryMC/Binnie/issues/277/events","html_url":"https://github.com/ForestryMC/Binnie/pull/277","id":251303072,"number":277,"title":"Fix the generation of Hives #274","user":{"login":"p-schneider","id":2636101,"avatar_url":"https://avatars3.githubusercontent.com/u/2636101?v=4","gravatar_id":"","url":"https://api.github.com/users/p-schneider","html_url":"https://github.com/p-schneider","followers_url":"https://api.github.com/users/p-schneider/followers","following_url":"https://api.github.com/users/p-schneider/following{/other_user}","gists_url":"https://api.github.com/users/p-schneider/gists{/gist_id}","starred_url":"https://api.github.com/users/p-schneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p-schneider/subscriptions","organizations_url":"https://api.github.com/users/p-schneider/orgs","repos_url":"https://api.github.com/users/p-schneider/repos","events_url":"https://api.github.com/users/p-schneider/events{/privacy}","received_events_url":"https://api.github.com/users/p-schneider/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-18T16:57:59Z","updated_at":"2017-08-22T04:47:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ForestryMC/Binnie/pulls/277","html_url":"https://github.com/ForestryMC/Binnie/pull/277","diff_url":"https://github.com/ForestryMC/Binnie/pull/277.diff","patch_url":"https://github.com/ForestryMC/Binnie/pull/277.patch"},"body":"Fixes the conditions when or when not to generate a rocky or marble hive.\r\n\r\nregarding the generation of Marble Hives:\r\nI think marble was generating before but *very* rare depending on how marble veins are generated.\r\nIf no mods are installed that provide stoneMarble (oredict) then Marble Hives won't generate anyway.\r\n\r\nUntil now (before this commit / PR) Marble Hives genreated like this:\r\n1. abort if the randomly selected block is not in the list of allowed blocks (currently oredict stoneMarble <- mods like chisel add marble, vanilla MC + forestry + binnies by itself don't include a stoneMarble block)\r\n2. abort if more than one of the 6 adjacent blocks is different from the block itself\r\n3. generate Marble Hive\r\n(so at least 5 adjacent blocks have to be the same marble block in order to generate a hive)\r\n\r\nWith this PR marble genreates like this:\r\n1. (same as before) abort if the randomly selected block is not in the list of allowed blocks\r\n2. if more than one (at least two) of the 6 adjacent blocks is different from the block itself generate the Hive\r\n\r\n| # of adjacent marble blocks (same block) | before | after |\r\n| ---:| --- | --- |\r\n| 0 | ✘ | ✔ |\r\n| 1 | ✘ | ✔ |\r\n| 2 | ✘ | ✔ |\r\n| 3 | ✘ | ✔ |\r\n| 4 | ✘ | ✔ |\r\n| 5 | ✔ | ✘ |\r\n| 6 | ✔ | ✘ |\r\n\r\nMaybe my change to the marble hive generation doesn't make much sense or should be done differently. It's just that to me the logic behind the generation like it was before felt wrong.\r\n\r\nThe fix to rocky hive generation however seems necessary in one way or another."},"comment":{"url":"https://api.github.com/repos/ForestryMC/Binnie/issues/comments/323918053","html_url":"https://github.com/ForestryMC/Binnie/pull/277#issuecomment-323918053","issue_url":"https://api.github.com/repos/ForestryMC/Binnie/issues/277","id":323918053,"user":{"login":"mezz","id":916092,"avatar_url":"https://avatars1.githubusercontent.com/u/916092?v=4","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"created_at":"2017-08-22T04:47:14Z","updated_at":"2017-08-22T04:47:14Z","body":"I looked into it more and marble bees are not essential to the progression for anything except the Classical branch, so they should only exist when marble is generated by another mod.\r\n\r\nThey should have lots of marble around. This is why they want lots of  adjacent marble blocks, so they look like this:\r\n![marble_hive](https://user-images.githubusercontent.com/916092/29549001-313eef12-86ba-11e7-8d90-0a106ccb499f.jpg)"}}
{"actor":{"display_login":"mezz"}}