{"action":"closed","number":2241,"pull_request":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2241","id":141384815,"html_url":"https://github.com/sqlcollaborative/dbatools/pull/2241","diff_url":"https://github.com/sqlcollaborative/dbatools/pull/2241.diff","patch_url":"https://github.com/sqlcollaborative/dbatools/pull/2241.patch","issue_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/2241","number":2241,"state":"closed","locked":false,"title":"Resolve-DbaNetworkName, stricter resolution","user":{"login":"niphlod","id":122119,"avatar_url":"https://avatars2.githubusercontent.com/u/122119?v=4","gravatar_id":"","url":"https://api.github.com/users/niphlod","html_url":"https://github.com/niphlod","followers_url":"https://api.github.com/users/niphlod/followers","following_url":"https://api.github.com/users/niphlod/following{/other_user}","gists_url":"https://api.github.com/users/niphlod/gists{/gist_id}","starred_url":"https://api.github.com/users/niphlod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niphlod/subscriptions","organizations_url":"https://api.github.com/users/niphlod/orgs","repos_url":"https://api.github.com/users/niphlod/repos","events_url":"https://api.github.com/users/niphlod/events{/privacy}","received_events_url":"https://api.github.com/users/niphlod/received_events","type":"User","site_admin":false},"body":"This is a more stricter resolution\r\n\r\n<!-- Below information IS REQUIRED with every PR -->\r\n## Type of Change\r\n<!-- What type of change does your code introduce -->\r\n - [x] Bug fix (non-breaking change, fixes name resolution in corner-cases)\r\n - [ ] New feature (non-breaking change, adds functionality)\r\n - [ ] Breaking change (effects multiple commands or functionality)\r\n - [ ] Ran manual Pester test and has passed (`.\\tests\\manual.pester.ps1)\r\n - [ ] Adding code coverage to existing functionality\r\n - [ ] Pester test is included\r\n - [ ] Nunit test is included\r\n - [ ] Documentation\r\n - [ ] Build system\r\n \r\n### Purpose\r\nThis checks for the proper domain name for the host EVEN if it doesn't match the default resolution configured on the host itself (i.e. it's more correctly returning how to qualify the domain name for clients connecting to the host even if the host is set to resolve names using a different domain)\r\n\r\n\r\n@potatoqualitee: we discussed this while you were full deep in audit ^_^\r\n","created_at":"2017-09-15T19:29:39Z","updated_at":"2017-09-17T17:28:12Z","closed_at":"2017-09-17T17:28:12Z","merged_at":"2017-09-17T17:28:12Z","merge_commit_sha":"f52769d623669f3e150a39923e09b75ee2e3813f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"potatoqualitee","id":8278033,"avatar_url":"https://avatars1.githubusercontent.com/u/8278033?v=4","gravatar_id":"","url":"https://api.github.com/users/potatoqualitee","html_url":"https://github.com/potatoqualitee","followers_url":"https://api.github.com/users/potatoqualitee/followers","following_url":"https://api.github.com/users/potatoqualitee/following{/other_user}","gists_url":"https://api.github.com/users/potatoqualitee/gists{/gist_id}","starred_url":"https://api.github.com/users/potatoqualitee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potatoqualitee/subscriptions","organizations_url":"https://api.github.com/users/potatoqualitee/orgs","repos_url":"https://api.github.com/users/potatoqualitee/repos","events_url":"https://api.github.com/users/potatoqualitee/events{/privacy}","received_events_url":"https://api.github.com/users/potatoqualitee/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2241/commits","review_comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2241/comments","review_comment_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/2241/comments","statuses_url":"https://api.github.com/repos/sqlcollaborative/dbatools/statuses/28d91332d8ff613fcbfac3b9264981f12f36806b","head":{"label":"niphlod:enhancement/Resolve-DbaNetworkName","ref":"enhancement/Resolve-DbaNetworkName","sha":"28d91332d8ff613fcbfac3b9264981f12f36806b","user":{"login":"niphlod","id":122119,"avatar_url":"https://avatars2.githubusercontent.com/u/122119?v=4","gravatar_id":"","url":"https://api.github.com/users/niphlod","html_url":"https://github.com/niphlod","followers_url":"https://api.github.com/users/niphlod/followers","following_url":"https://api.github.com/users/niphlod/following{/other_user}","gists_url":"https://api.github.com/users/niphlod/gists{/gist_id}","starred_url":"https://api.github.com/users/niphlod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niphlod/subscriptions","organizations_url":"https://api.github.com/users/niphlod/orgs","repos_url":"https://api.github.com/users/niphlod/repos","events_url":"https://api.github.com/users/niphlod/events{/privacy}","received_events_url":"https://api.github.com/users/niphlod/received_events","type":"User","site_admin":false},"repo":{"id":75013850,"name":"dbatools","full_name":"niphlod/dbatools","owner":{"login":"niphlod","id":122119,"avatar_url":"https://avatars2.githubusercontent.com/u/122119?v=4","gravatar_id":"","url":"https://api.github.com/users/niphlod","html_url":"https://github.com/niphlod","followers_url":"https://api.github.com/users/niphlod/followers","following_url":"https://api.github.com/users/niphlod/following{/other_user}","gists_url":"https://api.github.com/users/niphlod/gists{/gist_id}","starred_url":"https://api.github.com/users/niphlod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niphlod/subscriptions","organizations_url":"https://api.github.com/users/niphlod/orgs","repos_url":"https://api.github.com/users/niphlod/repos","events_url":"https://api.github.com/users/niphlod/events{/privacy}","received_events_url":"https://api.github.com/users/niphlod/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niphlod/dbatools","description":"PowerShell module to help dbas be more productive","fork":true,"url":"https://api.github.com/repos/niphlod/dbatools","forks_url":"https://api.github.com/repos/niphlod/dbatools/forks","keys_url":"https://api.github.com/repos/niphlod/dbatools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niphlod/dbatools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niphlod/dbatools/teams","hooks_url":"https://api.github.com/repos/niphlod/dbatools/hooks","issue_events_url":"https://api.github.com/repos/niphlod/dbatools/issues/events{/number}","events_url":"https://api.github.com/repos/niphlod/dbatools/events","assignees_url":"https://api.github.com/repos/niphlod/dbatools/assignees{/user}","branches_url":"https://api.github.com/repos/niphlod/dbatools/branches{/branch}","tags_url":"https://api.github.com/repos/niphlod/dbatools/tags","blobs_url":"https://api.github.com/repos/niphlod/dbatools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niphlod/dbatools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niphlod/dbatools/git/refs{/sha}","trees_url":"https://api.github.com/repos/niphlod/dbatools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niphlod/dbatools/statuses/{sha}","languages_url":"https://api.github.com/repos/niphlod/dbatools/languages","stargazers_url":"https://api.github.com/repos/niphlod/dbatools/stargazers","contributors_url":"https://api.github.com/repos/niphlod/dbatools/contributors","subscribers_url":"https://api.github.com/repos/niphlod/dbatools/subscribers","subscription_url":"https://api.github.com/repos/niphlod/dbatools/subscription","commits_url":"https://api.github.com/repos/niphlod/dbatools/commits{/sha}","git_commits_url":"https://api.github.com/repos/niphlod/dbatools/git/commits{/sha}","comments_url":"https://api.github.com/repos/niphlod/dbatools/comments{/number}","issue_comment_url":"https://api.github.com/repos/niphlod/dbatools/issues/comments{/number}","contents_url":"https://api.github.com/repos/niphlod/dbatools/contents/{+path}","compare_url":"https://api.github.com/repos/niphlod/dbatools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niphlod/dbatools/merges","archive_url":"https://api.github.com/repos/niphlod/dbatools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niphlod/dbatools/downloads","issues_url":"https://api.github.com/repos/niphlod/dbatools/issues{/number}","pulls_url":"https://api.github.com/repos/niphlod/dbatools/pulls{/number}","milestones_url":"https://api.github.com/repos/niphlod/dbatools/milestones{/number}","notifications_url":"https://api.github.com/repos/niphlod/dbatools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niphlod/dbatools/labels{/name}","releases_url":"https://api.github.com/repos/niphlod/dbatools/releases{/id}","deployments_url":"https://api.github.com/repos/niphlod/dbatools/deployments","created_at":"2016-11-28T21:01:53Z","updated_at":"2016-11-28T21:01:54Z","pushed_at":"2017-09-15T19:25:45Z","git_url":"git://github.com/niphlod/dbatools.git","ssh_url":"git@github.com:niphlod/dbatools.git","clone_url":"https://github.com/niphlod/dbatools.git","svn_url":"https://github.com/niphlod/dbatools","homepage":"https://dbatools.io","size":27446,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sqlcollaborative:master","ref":"master","sha":"c76977f0eb2ea7a971eee038d35c1a6c944eba10","user":{"login":"sqlcollaborative","id":22203347,"avatar_url":"https://avatars3.githubusercontent.com/u/22203347?v=4","gravatar_id":"","url":"https://api.github.com/users/sqlcollaborative","html_url":"https://github.com/sqlcollaborative","followers_url":"https://api.github.com/users/sqlcollaborative/followers","following_url":"https://api.github.com/users/sqlcollaborative/following{/other_user}","gists_url":"https://api.github.com/users/sqlcollaborative/gists{/gist_id}","starred_url":"https://api.github.com/users/sqlcollaborative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqlcollaborative/subscriptions","organizations_url":"https://api.github.com/users/sqlcollaborative/orgs","repos_url":"https://api.github.com/users/sqlcollaborative/repos","events_url":"https://api.github.com/users/sqlcollaborative/events{/privacy}","received_events_url":"https://api.github.com/users/sqlcollaborative/received_events","type":"Organization","site_admin":false},"repo":{"id":30215226,"name":"dbatools","full_name":"sqlcollaborative/dbatools","owner":{"login":"sqlcollaborative","id":22203347,"avatar_url":"https://avatars3.githubusercontent.com/u/22203347?v=4","gravatar_id":"","url":"https://api.github.com/users/sqlcollaborative","html_url":"https://github.com/sqlcollaborative","followers_url":"https://api.github.com/users/sqlcollaborative/followers","following_url":"https://api.github.com/users/sqlcollaborative/following{/other_user}","gists_url":"https://api.github.com/users/sqlcollaborative/gists{/gist_id}","starred_url":"https://api.github.com/users/sqlcollaborative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqlcollaborative/subscriptions","organizations_url":"https://api.github.com/users/sqlcollaborative/orgs","repos_url":"https://api.github.com/users/sqlcollaborative/repos","events_url":"https://api.github.com/users/sqlcollaborative/events{/privacy}","received_events_url":"https://api.github.com/users/sqlcollaborative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sqlcollaborative/dbatools","description":"PowerShell module to help SQL Server Pros be more productive","fork":false,"url":"https://api.github.com/repos/sqlcollaborative/dbatools","forks_url":"https://api.github.com/repos/sqlcollaborative/dbatools/forks","keys_url":"https://api.github.com/repos/sqlcollaborative/dbatools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sqlcollaborative/dbatools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sqlcollaborative/dbatools/teams","hooks_url":"https://api.github.com/repos/sqlcollaborative/dbatools/hooks","issue_events_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/events{/number}","events_url":"https://api.github.com/repos/sqlcollaborative/dbatools/events","assignees_url":"https://api.github.com/repos/sqlcollaborative/dbatools/assignees{/user}","branches_url":"https://api.github.com/repos/sqlcollaborative/dbatools/branches{/branch}","tags_url":"https://api.github.com/repos/sqlcollaborative/dbatools/tags","blobs_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/refs{/sha}","trees_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sqlcollaborative/dbatools/statuses/{sha}","languages_url":"https://api.github.com/repos/sqlcollaborative/dbatools/languages","stargazers_url":"https://api.github.com/repos/sqlcollaborative/dbatools/stargazers","contributors_url":"https://api.github.com/repos/sqlcollaborative/dbatools/contributors","subscribers_url":"https://api.github.com/repos/sqlcollaborative/dbatools/subscribers","subscription_url":"https://api.github.com/repos/sqlcollaborative/dbatools/subscription","commits_url":"https://api.github.com/repos/sqlcollaborative/dbatools/commits{/sha}","git_commits_url":"https://api.github.com/repos/sqlcollaborative/dbatools/git/commits{/sha}","comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/comments{/number}","issue_comment_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/comments{/number}","contents_url":"https://api.github.com/repos/sqlcollaborative/dbatools/contents/{+path}","compare_url":"https://api.github.com/repos/sqlcollaborative/dbatools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sqlcollaborative/dbatools/merges","archive_url":"https://api.github.com/repos/sqlcollaborative/dbatools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sqlcollaborative/dbatools/downloads","issues_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues{/number}","pulls_url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls{/number}","milestones_url":"https://api.github.com/repos/sqlcollaborative/dbatools/milestones{/number}","notifications_url":"https://api.github.com/repos/sqlcollaborative/dbatools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sqlcollaborative/dbatools/labels{/name}","releases_url":"https://api.github.com/repos/sqlcollaborative/dbatools/releases{/id}","deployments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/deployments","created_at":"2015-02-02T23:50:31Z","updated_at":"2017-09-16T10:55:16Z","pushed_at":"2017-09-17T17:28:12Z","git_url":"git://github.com/sqlcollaborative/dbatools.git","ssh_url":"git@github.com:sqlcollaborative/dbatools.git","clone_url":"https://github.com/sqlcollaborative/dbatools.git","svn_url":"https://github.com/sqlcollaborative/dbatools","homepage":"https://dbatools.io","size":27317,"stargazers_count":386,"watchers_count":386,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":233,"forks":222,"open_issues":233,"watchers":386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2241"},"html":{"href":"https://github.com/sqlcollaborative/dbatools/pull/2241"},"issue":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/2241"},"comments":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/2241/comments"},"review_comments":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2241/comments"},"review_comment":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/2241/commits"},"statuses":{"href":"https://api.github.com/repos/sqlcollaborative/dbatools/statuses/28d91332d8ff613fcbfac3b9264981f12f36806b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wsmelton","id":11204251,"avatar_url":"https://avatars2.githubusercontent.com/u/11204251?v=4","gravatar_id":"","url":"https://api.github.com/users/wsmelton","html_url":"https://github.com/wsmelton","followers_url":"https://api.github.com/users/wsmelton/followers","following_url":"https://api.github.com/users/wsmelton/following{/other_user}","gists_url":"https://api.github.com/users/wsmelton/gists{/gist_id}","starred_url":"https://api.github.com/users/wsmelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsmelton/subscriptions","organizations_url":"https://api.github.com/users/wsmelton/orgs","repos_url":"https://api.github.com/users/wsmelton/repos","events_url":"https://api.github.com/users/wsmelton/events{/privacy}","received_events_url":"https://api.github.com/users/wsmelton/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"wsmelton"}}