{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/150189603","pull_request_review_id":75703795,"id":150189603,"diff_hunk":"@@ -94,7 +94,7 @@ Bug Fixes\n Conversion\n ^^^^^^^^^^\n \n--\n+- Bug in :attr:`Timestamp.weekday_name` and :attr:`DatetimeIndex.weekday_name` not returning locale aware values (:issue:`12806`)","path":"doc/source/whatsnew/v0.22.0.txt","position":14,"original_position":14,"commit_id":"6f395788c970076e36bf49b527ab6a33e12afb6a","original_commit_id":"6f395788c970076e36bf49b527ab6a33e12afb6a","user":{"login":"jorisvandenbossche","id":1020496,"avatar_url":"https://avatars2.githubusercontent.com/u/1020496?v=4","gravatar_id":"","url":"https://api.github.com/users/jorisvandenbossche","html_url":"https://github.com/jorisvandenbossche","followers_url":"https://api.github.com/users/jorisvandenbossche/followers","following_url":"https://api.github.com/users/jorisvandenbossche/following{/other_user}","gists_url":"https://api.github.com/users/jorisvandenbossche/gists{/gist_id}","starred_url":"https://api.github.com/users/jorisvandenbossche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorisvandenbossche/subscriptions","organizations_url":"https://api.github.com/users/jorisvandenbossche/orgs","repos_url":"https://api.github.com/users/jorisvandenbossche/repos","events_url":"https://api.github.com/users/jorisvandenbossche/events{/privacy}","received_events_url":"https://api.github.com/users/jorisvandenbossche/received_events","type":"User","site_admin":false},"body":"I don't think we should this as a bug, it is rather an API change as we deliberately returned non-locale dependent values.\r\n\r\n(and to be honest, I am also not sure that I really like locale-dependent return values)","created_at":"2017-11-10T09:37:58Z","updated_at":"2017-11-10T09:37:58Z","html_url":"https://github.com/pandas-dev/pandas/pull/18164#discussion_r150189603","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/18164","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/150189603"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/18164#discussion_r150189603"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/18164"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/18164","id":151291297,"html_url":"https://github.com/pandas-dev/pandas/pull/18164","diff_url":"https://github.com/pandas-dev/pandas/pull/18164.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/18164.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/18164","number":18164,"state":"open","locked":false,"title":"ENH: Return locale based month_name and weekday_name values (#12805, #12806)","user":{"login":"mroeschke","id":10647082,"avatar_url":"https://avatars0.githubusercontent.com/u/10647082?v=4","gravatar_id":"","url":"https://api.github.com/users/mroeschke","html_url":"https://github.com/mroeschke","followers_url":"https://api.github.com/users/mroeschke/followers","following_url":"https://api.github.com/users/mroeschke/following{/other_user}","gists_url":"https://api.github.com/users/mroeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroeschke/subscriptions","organizations_url":"https://api.github.com/users/mroeschke/orgs","repos_url":"https://api.github.com/users/mroeschke/repos","events_url":"https://api.github.com/users/mroeschke/events{/privacy}","received_events_url":"https://api.github.com/users/mroeschke/received_events","type":"User","site_admin":false},"body":"- [x] closes #12805, #12806\r\n- [x] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [x] whatsnew entry\r\n\r\nI am not sure what locales are available on the CI machines, but the test will run all available locales. ","created_at":"2017-11-08T04:29:11Z","updated_at":"2017-11-10T09:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eece130c2dc57d3fc6f88fc898ef8a9b8c8beb90","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/18164/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/18164/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/18164/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/6f395788c970076e36bf49b527ab6a33e12afb6a","head":{"label":"mroeschke:add_localtime","ref":"add_localtime","sha":"6f395788c970076e36bf49b527ab6a33e12afb6a","user":{"login":"mroeschke","id":10647082,"avatar_url":"https://avatars0.githubusercontent.com/u/10647082?v=4","gravatar_id":"","url":"https://api.github.com/users/mroeschke","html_url":"https://github.com/mroeschke","followers_url":"https://api.github.com/users/mroeschke/followers","following_url":"https://api.github.com/users/mroeschke/following{/other_user}","gists_url":"https://api.github.com/users/mroeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroeschke/subscriptions","organizations_url":"https://api.github.com/users/mroeschke/orgs","repos_url":"https://api.github.com/users/mroeschke/repos","events_url":"https://api.github.com/users/mroeschke/events{/privacy}","received_events_url":"https://api.github.com/users/mroeschke/received_events","type":"User","site_admin":false},"repo":{"id":71015224,"name":"pandas","full_name":"mroeschke/pandas","owner":{"login":"mroeschke","id":10647082,"avatar_url":"https://avatars0.githubusercontent.com/u/10647082?v=4","gravatar_id":"","url":"https://api.github.com/users/mroeschke","html_url":"https://github.com/mroeschke","followers_url":"https://api.github.com/users/mroeschke/followers","following_url":"https://api.github.com/users/mroeschke/following{/other_user}","gists_url":"https://api.github.com/users/mroeschke/gists{/gist_id}","starred_url":"https://api.github.com/users/mroeschke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mroeschke/subscriptions","organizations_url":"https://api.github.com/users/mroeschke/orgs","repos_url":"https://api.github.com/users/mroeschke/repos","events_url":"https://api.github.com/users/mroeschke/events{/privacy}","received_events_url":"https://api.github.com/users/mroeschke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mroeschke/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/mroeschke/pandas","forks_url":"https://api.github.com/repos/mroeschke/pandas/forks","keys_url":"https://api.github.com/repos/mroeschke/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mroeschke/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mroeschke/pandas/teams","hooks_url":"https://api.github.com/repos/mroeschke/pandas/hooks","issue_events_url":"https://api.github.com/repos/mroeschke/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/mroeschke/pandas/events","assignees_url":"https://api.github.com/repos/mroeschke/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/mroeschke/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/mroeschke/pandas/tags","blobs_url":"https://api.github.com/repos/mroeschke/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mroeschke/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mroeschke/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/mroeschke/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mroeschke/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/mroeschke/pandas/languages","stargazers_url":"https://api.github.com/repos/mroeschke/pandas/stargazers","contributors_url":"https://api.github.com/repos/mroeschke/pandas/contributors","subscribers_url":"https://api.github.com/repos/mroeschke/pandas/subscribers","subscription_url":"https://api.github.com/repos/mroeschke/pandas/subscription","commits_url":"https://api.github.com/repos/mroeschke/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/mroeschke/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/mroeschke/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/mroeschke/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/mroeschke/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/mroeschke/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mroeschke/pandas/merges","archive_url":"https://api.github.com/repos/mroeschke/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mroeschke/pandas/downloads","issues_url":"https://api.github.com/repos/mroeschke/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/mroeschke/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/mroeschke/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/mroeschke/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mroeschke/pandas/labels{/name}","releases_url":"https://api.github.com/repos/mroeschke/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/mroeschke/pandas/deployments","created_at":"2016-10-15T21:46:32Z","updated_at":"2016-10-15T21:46:38Z","pushed_at":"2017-11-10T04:08:01Z","git_url":"git://github.com/mroeschke/pandas.git","ssh_url":"git@github.com:mroeschke/pandas.git","clone_url":"https://github.com/mroeschke/pandas.git","svn_url":"https://github.com/mroeschke/pandas","homepage":"http://pandas.pydata.org","size":107376,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"ca737aca8b73b10b617f7fcc7da35545f9ec0a89","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-11-10T09:20:42Z","pushed_at":"2017-11-10T08:59:54Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":107959,"stargazers_count":11630,"watchers_count":11630,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4540,"mirror_url":null,"archived":false,"open_issues_count":2182,"forks":4540,"open_issues":2182,"watchers":11630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/18164"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/18164"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/18164"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/18164/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/18164/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/18164/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/6f395788c970076e36bf49b527ab6a33e12afb6a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jorisvandenbossche"}}