{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/96897409","pull_request_review_id":17494952,"id":96897409,"diff_hunk":"@@ -2473,20 +2473,20 @@ bool ActivateBestChain(CValidationState &state, const CChainParams& chainparams,\n             pindexNewTip = chainActive.Tip();\n             pindexFork = chainActive.FindFork(pindexOldTip);\n             fInitialDownload = IsInitialBlockDownload();\n+\n+            // throw all transactions though the signal-interface\n+            // while _not_ holding the cs_main lock","path":"src/validation.cpp","position":6,"original_position":6,"commit_id":"f73bd2c3707d874397b8df461e3d783e410d6805","original_commit_id":"f73bd2c3707d874397b8df461e3d783e410d6805","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"body":"This comments seems outdated now.","created_at":"2017-01-19T16:24:07Z","updated_at":"2017-01-19T16:24:07Z","html_url":"https://github.com/bitcoin/bitcoin/pull/9583#discussion_r96897409","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9583","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/96897409"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/9583#discussion_r96897409"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9583"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9583","id":102295772,"html_url":"https://github.com/bitcoin/bitcoin/pull/9583","diff_url":"https://github.com/bitcoin/bitcoin/pull/9583.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/9583.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9583","number":9583,"state":"open","locked":false,"title":"Move wallet callbacks into cs_main (this effectively reverts #7946)","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars.githubusercontent.com/u/649246?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"body":"This is an alternative to #9570 as well as at least two other fixes which would be required to wallet consistency issues generated by #7946, none of which I believe are reasonable to make 0.14.","created_at":"2017-01-19T16:06:43Z","updated_at":"2017-01-19T16:24:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c4bf0f7bbe5e33830f07b6ce64d4f53ef0bed81","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9583/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9583/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9583/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/f73bd2c3707d874397b8df461e3d783e410d6805","head":{"label":"TheBlueMatt:2017-01-revert-7946","ref":"2017-01-revert-7946","sha":"f73bd2c3707d874397b8df461e3d783e410d6805","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars.githubusercontent.com/u/649246?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"repo":{"id":1443291,"name":"bitcoin","full_name":"TheBlueMatt/bitcoin","owner":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars.githubusercontent.com/u/649246?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheBlueMatt/bitcoin","description":"Bitcoin (dont fork from here, fork from bitcoin/bitcoin)","fork":true,"url":"https://api.github.com/repos/TheBlueMatt/bitcoin","forks_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/forks","keys_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/teams","hooks_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/events","assignees_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/tags","blobs_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/languages","stargazers_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/subscription","commits_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/merges","archive_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/downloads","issues_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/deployments","created_at":"2011-03-05T14:14:49Z","updated_at":"2017-01-17T02:35:33Z","pushed_at":"2017-01-19T16:07:08Z","git_url":"git://github.com/TheBlueMatt/bitcoin.git","ssh_url":"git@github.com:TheBlueMatt/bitcoin.git","clone_url":"https://github.com/TheBlueMatt/bitcoin.git","svn_url":"https://github.com/TheBlueMatt/bitcoin","homepage":"http://www.bitcoin.org/","size":78240,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":12,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"054d664215ca8d5f17d8aadbfc5b78a8dcd5115c","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2017-01-19T14:32:16Z","pushed_at":"2017-01-19T16:07:10Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":79404,"stargazers_count":11102,"watchers_count":11102,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7250,"mirror_url":null,"open_issues_count":586,"forks":7250,"open_issues":586,"watchers":11102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9583"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/9583"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/9583"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/9583/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9583/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9583/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/f73bd2c3707d874397b8df461e3d783e410d6805"}}}}
{"actor":{"display_login":"sipa"}}