{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/desktop/issues/456","repository_url":"https://api.github.com/repos/mattermost/desktop","labels_url":"https://api.github.com/repos/mattermost/desktop/issues/456/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/desktop/issues/456/comments","events_url":"https://api.github.com/repos/mattermost/desktop/issues/456/events","html_url":"https://github.com/mattermost/desktop/issues/456","id":210517098,"number":456,"title":"Settings not saved when changing tray icon theme","user":{"login":"CromFr","id":999188,"avatar_url":"https://avatars.githubusercontent.com/u/999188?v=3","gravatar_id":"","url":"https://api.github.com/users/CromFr","html_url":"https://github.com/CromFr","followers_url":"https://api.github.com/users/CromFr/followers","following_url":"https://api.github.com/users/CromFr/following{/other_user}","gists_url":"https://api.github.com/users/CromFr/gists{/gist_id}","starred_url":"https://api.github.com/users/CromFr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CromFr/subscriptions","organizations_url":"https://api.github.com/users/CromFr/orgs","repos_url":"https://api.github.com/users/CromFr/repos","events_url":"https://api.github.com/users/CromFr/events{/privacy}","received_events_url":"https://api.github.com/users/CromFr/received_events","type":"User","site_admin":false},"labels":[{"id":270931908,"url":"https://api.github.com/repos/mattermost/desktop/labels/Bug","name":"Bug","color":"fc2929","default":false},{"id":357466252,"url":"https://api.github.com/repos/mattermost/desktop/labels/Linux","name":"Linux","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-02-27T15:29:47Z","updated_at":"2017-02-28T12:59:20Z","closed_at":null,"body":"I confirm (by marking \"x\" in the [ ] below): \r\n\r\n- [x] This is not a troubleshooting question. [Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/](http://www.mattermost.org/troubleshoot/).\r\n- [x] This doesn't reproduce on web browsers (such as in Chrome). If it does, [issue reports go to the Mattermost Server repository](https://github.com/mattermost/platform/issues).\r\n- [x] I have read [contributing guidelines](https://github.com/mattermost/desktop/blob/master/CONTRIBUTING.md). \r\n\r\n---\r\n\r\n**Summary**\r\nSettings not saved when changing tray icon theme\r\n\r\n**Steps to reproduce**\r\n\r\n- Operating System: __Archlinux__\r\n- Mattermost Desktop App version __3.6.0__\r\n- Mattermost Server version: __3.6.0  (3.6.2)__\r\n- Clear steps to reproduce the issue\r\n  - Go to file/settings\r\n  - Try to change the tray icon theme\r\n\r\n**Expected behavior**\r\n\r\n\"Settings saved\" toast, and settings effective & saved (after restarting mattermost-desktop)\r\n\r\n**Observed behavior**\r\n\r\nTray icon theme is still on the last value set.\r\nAlso, if you change another setting after changing the tray icon, everything works as expected\r\n\r\n**Possible fixes**\r\n\r\nmaybe the save settings callback is not called with radio buttons?\r\n\r\n\r\n\r\n---\r\n\r\n_nice issue template btw :)_"},"comment":{"url":"https://api.github.com/repos/mattermost/desktop/issues/comments/283032438","html_url":"https://github.com/mattermost/desktop/issues/456#issuecomment-283032438","issue_url":"https://api.github.com/repos/mattermost/desktop/issues/456","id":283032438,"user":{"login":"yuya-oc","id":1412057,"avatar_url":"https://avatars.githubusercontent.com/u/1412057?v=3","gravatar_id":"","url":"https://api.github.com/users/yuya-oc","html_url":"https://github.com/yuya-oc","followers_url":"https://api.github.com/users/yuya-oc/followers","following_url":"https://api.github.com/users/yuya-oc/following{/other_user}","gists_url":"https://api.github.com/users/yuya-oc/gists{/gist_id}","starred_url":"https://api.github.com/users/yuya-oc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuya-oc/subscriptions","organizations_url":"https://api.github.com/users/yuya-oc/orgs","repos_url":"https://api.github.com/users/yuya-oc/repos","events_url":"https://api.github.com/users/yuya-oc/events{/privacy}","received_events_url":"https://api.github.com/users/yuya-oc/received_events","type":"User","site_admin":false},"created_at":"2017-02-28T12:59:20Z","updated_at":"2017-02-28T12:59:20Z","body":"@jasonblais Ah, I didn't think about that.\r\n\r\nAs far as I read the codes again, only theme doesn't start auto-saving. As reported in original observed behavior, fortunately the theme is saved by changing another app option. So I feel we **can** cut v3.6.1."}}
{"actor":{"display_login":"yuya-oc"}}