{"action":"created","issue":{"url":"https://api.github.com/repos/TextureGroup/Texture/issues/427","repository_url":"https://api.github.com/repos/TextureGroup/Texture","labels_url":"https://api.github.com/repos/TextureGroup/Texture/issues/427/labels{/name}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/issues/427/comments","events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/427/events","html_url":"https://github.com/TextureGroup/Texture/pull/427","id":241474030,"number":427,"title":"[Project clean up] Reorganize project dir #trivial","user":{"login":"nguyenhuy","id":587874,"avatar_url":"https://avatars2.githubusercontent.com/u/587874?v=3","gravatar_id":"","url":"https://api.github.com/users/nguyenhuy","html_url":"https://github.com/nguyenhuy","followers_url":"https://api.github.com/users/nguyenhuy/followers","following_url":"https://api.github.com/users/nguyenhuy/following{/other_user}","gists_url":"https://api.github.com/users/nguyenhuy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenhuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenhuy/subscriptions","organizations_url":"https://api.github.com/users/nguyenhuy/orgs","repos_url":"https://api.github.com/users/nguyenhuy/repos","events_url":"https://api.github.com/users/nguyenhuy/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenhuy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-08T19:16:03Z","updated_at":"2017-07-10T12:36:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/427","html_url":"https://github.com/TextureGroup/Texture/pull/427","diff_url":"https://github.com/TextureGroup/Texture/pull/427.diff","patch_url":"https://github.com/TextureGroup/Texture/pull/427.patch"},"body":"I found this neat tool called [Synx](https://github.com/venmo/synx) that updates the project dir to match XCode groups declared in `AsyncDisplayKit.xcodeproj`.  This is quite important because CocoaPods determines public headers by looking at the project directory.\r\n\r\nHere are the changes:\r\n- Rename `ASCollectionInternal` to `ASCollectionViewInternal`.\r\n- Move `ASCollectionViewInternal`, `ASWeakProxy`, `ASTraceEvent` and `_ASTransitionContext` to `Source/Private`, and thus don't expose them via CocoaPods.\r\n- Move `ASDisplayNode+Ancestry`, `ASPINRemoteImageDownloader` and `ASSectionContext` to `Source`.\r\n- Move `ASRunLoopQueue` to `Source/Details`.\r\n- Move files related to async collection layout to `Source/Details/Collection Layout`.\r\n- Move files related to `ASDataController` to `Source/Details/Data Controller`.\r\n- Move `ASSection` and `ASDelegateProxy` to `Source/Private/Data Controller`.\r\n- Move `AsyncDisplayKit.modulemap` and `Info.plist` to `Source/Supporting Files`.\r\n- Move tests-related files to the correct dirs.\r\n- Sort XCode entries and groups by name."},"comment":{"url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments/314092460","html_url":"https://github.com/TextureGroup/Texture/pull/427#issuecomment-314092460","issue_url":"https://api.github.com/repos/TextureGroup/Texture/issues/427","id":314092460,"user":{"login":"pinterest-ios","id":23365208,"avatar_url":"https://avatars0.githubusercontent.com/u/23365208?v=3","gravatar_id":"","url":"https://api.github.com/users/pinterest-ios","html_url":"https://github.com/pinterest-ios","followers_url":"https://api.github.com/users/pinterest-ios/followers","following_url":"https://api.github.com/users/pinterest-ios/following{/other_user}","gists_url":"https://api.github.com/users/pinterest-ios/gists{/gist_id}","starred_url":"https://api.github.com/users/pinterest-ios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinterest-ios/subscriptions","organizations_url":"https://api.github.com/users/pinterest-ios/orgs","repos_url":"https://api.github.com/users/pinterest-ios/repos","events_url":"https://api.github.com/users/pinterest-ios/events{/privacy}","received_events_url":"https://api.github.com/users/pinterest-ios/received_events","type":"User","site_admin":false},"created_at":"2017-07-10T12:36:29Z","updated_at":"2017-07-10T12:36:29Z","body":"<!--\n  0 Errors\n  1 Warning: This is a big PR, please consi...\n  0 Messages\n  0 Markdowns\n-->\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\" data-kind=\"Warning\">\n          1 Warning\n      </th>\n     </tr>\n  </thead>\n  <tbody>\n    <tr>\n      <td>:warning:</td>\n      <td data-sticky=\"false\">This is a big PR, please consider splitting it up to ease code review.</td>\n    </tr>\n  </tbody>\n</table>\n\n<p align=\"right\" data-meta=\"generated_by_danger\">\n  Generated by :no_entry_sign: <a href=\"http://danger.systems/\">Danger</a>\n</p>\n"}}
{"actor":{"display_login":"pinterest-ios"}}