{"action":"created","issue":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2068","repository_url":"https://api.github.com/repos/jitsi/jitsi-meet","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2068/labels{/name}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2068/comments","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2068/events","html_url":"https://github.com/jitsi/jitsi-meet/pull/2068","id":265422009,"number":2068,"title":"Fixes display name for incoming chat messages, sender doesn't have nick.","user":{"login":"damencho","id":3263098,"avatar_url":"https://avatars3.githubusercontent.com/u/3263098?v=4","gravatar_id":"","url":"https://api.github.com/users/damencho","html_url":"https://github.com/damencho","followers_url":"https://api.github.com/users/damencho/followers","following_url":"https://api.github.com/users/damencho/following{/other_user}","gists_url":"https://api.github.com/users/damencho/gists{/gist_id}","starred_url":"https://api.github.com/users/damencho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damencho/subscriptions","organizations_url":"https://api.github.com/users/damencho/orgs","repos_url":"https://api.github.com/users/damencho/repos","events_url":"https://api.github.com/users/damencho/events{/privacy}","received_events_url":"https://api.github.com/users/damencho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"yanas","id":3264676,"avatar_url":"https://avatars1.githubusercontent.com/u/3264676?v=4","gravatar_id":"","url":"https://api.github.com/users/yanas","html_url":"https://github.com/yanas","followers_url":"https://api.github.com/users/yanas/followers","following_url":"https://api.github.com/users/yanas/following{/other_user}","gists_url":"https://api.github.com/users/yanas/gists{/gist_id}","starred_url":"https://api.github.com/users/yanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanas/subscriptions","organizations_url":"https://api.github.com/users/yanas/orgs","repos_url":"https://api.github.com/users/yanas/repos","events_url":"https://api.github.com/users/yanas/events{/privacy}","received_events_url":"https://api.github.com/users/yanas/received_events","type":"User","site_admin":false},"assignees":[{"login":"yanas","id":3264676,"avatar_url":"https://avatars1.githubusercontent.com/u/3264676?v=4","gravatar_id":"","url":"https://api.github.com/users/yanas","html_url":"https://github.com/yanas","followers_url":"https://api.github.com/users/yanas/followers","following_url":"https://api.github.com/users/yanas/following{/other_user}","gists_url":"https://api.github.com/users/yanas/gists{/gist_id}","starred_url":"https://api.github.com/users/yanas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanas/subscriptions","organizations_url":"https://api.github.com/users/yanas/orgs","repos_url":"https://api.github.com/users/yanas/repos","events_url":"https://api.github.com/users/yanas/events{/privacy}","received_events_url":"https://api.github.com/users/yanas/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-10-13T21:19:45Z","updated_at":"2017-10-14T14:09:02Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/2068","html_url":"https://github.com/jitsi/jitsi-meet/pull/2068","diff_url":"https://github.com/jitsi/jitsi-meet/pull/2068.diff","patch_url":"https://github.com/jitsi/jitsi-meet/pull/2068.patch"},"body":"If we join in a conference and there are messages from user who left before us joining(or they do not have display name set, missing nick extenasion in presence), now we see this:\r\n<img width=\"274\" alt=\"screen shot 2017-10-13 at 15 22 32\" src=\"https://user-images.githubusercontent.com/3263098/31566819-ea33b110-b031-11e7-9f6f-dc8bd28a9a70.png\">\r\n\r\nThis PR fixes like this:\r\n<img width=\"282\" alt=\"screen shot 2017-10-13 at 15 22 06\" src=\"https://user-images.githubusercontent.com/3263098/31566827-f60faae8-b031-11e7-99a8-db0988781831.png\">\r\n\r\nIt adds the resource of the user that sent the message, cause there may be multiple people who left/rejoined and we need to at least see the difference between messages, like:\r\n<img width=\"302\" alt=\"screen shot 2017-10-13 at 15 23 00\" src=\"https://user-images.githubusercontent.com/3263098/31566843-10dcf63c-b032-11e7-909f-065aa13dec24.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments/336637158","html_url":"https://github.com/jitsi/jitsi-meet/pull/2068#issuecomment-336637158","issue_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/2068","id":336637158,"user":{"login":"damencho","id":3263098,"avatar_url":"https://avatars3.githubusercontent.com/u/3263098?v=4","gravatar_id":"","url":"https://api.github.com/users/damencho","html_url":"https://github.com/damencho","followers_url":"https://api.github.com/users/damencho/followers","following_url":"https://api.github.com/users/damencho/following{/other_user}","gists_url":"https://api.github.com/users/damencho/gists{/gist_id}","starred_url":"https://api.github.com/users/damencho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damencho/subscriptions","organizations_url":"https://api.github.com/users/damencho/orgs","repos_url":"https://api.github.com/users/damencho/repos","events_url":"https://api.github.com/users/damencho/events{/privacy}","received_events_url":"https://api.github.com/users/damencho/received_events","type":"User","site_admin":false},"created_at":"2017-10-14T14:09:02Z","updated_at":"2017-10-14T14:09:02Z","author_association":"OWNER","body":"But this is in no way user friendly, that's why in jitsi-meet you can save a normal display name and the other clients are showing it is in the thumbnails and for incoming chat messages. You can test on https://meet.jit.si and see there is no way to see the resource from the muc. This is just workaround for the chat in case display name is missing. For example in remote thumbnails when there is no display name, it is always written fellow jitster."}}
{"actor":{"display_login":"damencho"}}