{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/113921382","pull_request_review_id":35350249,"id":113921382,"diff_hunk":"@@ -28,42 +28,73 @@\n end\n \n monasca_api_url = MonascaHelper.api_public_url(monasca_server)\n-\n agent_dimensions = { service: \"monitoring\" }\n-service = \"monitoring\"\n-\n-monasca_reconfigure_file = \"/usr/sbin/monasca-reconfigure\"\n \n-template monasca_reconfigure_file do\n+# the monasca-reconfigure script. if you use that script, the chef settings\n+# will be overwritten and after the next chef-client run, the settings\n+# from monasca-reconfigure will be overwritten. So DO NOT USE IT!\n+template \"/usr/sbin/monasca-reconfigure\" do\n   source \"monasca-reconfigure.erb\"\n   owner \"root\"\n   group \"root\"\n-  mode 0o750\n+  mode \"0750\"\n   variables(\n     monasca_api_url: monasca_api_url,\n-    service: service,\n+    service: \"monitoring\",\n     agent_settings: agent_settings,\n     agent_keystone: agent_keystone,\n     keystone_settings: keystone_settings,\n     agent_dimensions: agent_dimensions,\n     install_plugins_only: false\n   )\n-  notifies :run, \"execute[monasca-setup detect services]\", :delayed\n end\n \n-execute \"monasca-setup detect services\" do\n-  command monasca_reconfigure_file\n-  user \"root\"\n-  group \"root\"\n-  action :nothing\n+# the monasca-agent configuration\n+template \"/etc/monasca/agent/agent.yaml\" do\n+  source \"monasca-agent_agent.yaml.erb\"\n+  owner agent_settings[:user]\n+  group agent_settings[:group]\n+  mode \"0640\"\n+  variables(\n+    hostname: node[:hostname],\n+    monasca_api_url: monasca_api_url,\n+    agent_dimensions: agent_dimensions,\n+    log_dir: agent_settings[\"log_dir\"],\n+    log_level: agent_settings[:debug] ? \"DEBUG\": \"INFO\",","path":"chef/cookbooks/monasca/recipes/agent.rb","position":49,"original_position":49,"commit_id":"50da005f61a90fcca4456e781f93610941f20b29","original_commit_id":"50da005f61a90fcca4456e781f93610941f20b29","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/SpaceAroundOperators: Surrounding space missing for operator :. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)","created_at":"2017-04-28T12:41:08Z","updated_at":"2017-04-28T12:41:09Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/938#discussion_r113921382","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/938","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/113921382"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/938#discussion_r113921382"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/938"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/938","id":118143820,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/938","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/938.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/938.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/938","number":938,"state":"open","locked":false,"title":"Monasca region","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars3.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-28T12:40:42Z","updated_at":"2017-04-28T12:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09739f83ab3b8f51a76b3648b87047bf57fda305","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/938/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/938/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/938/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/50da005f61a90fcca4456e781f93610941f20b29","head":{"label":"toabctl:monasca-region","ref":"monasca-region","sha":"50da005f61a90fcca4456e781f93610941f20b29","user":{"login":"toabctl","id":276317,"avatar_url":"https://avatars3.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"repo":{"id":40896453,"name":"crowbar-openstack","full_name":"toabctl/crowbar-openstack","owner":{"login":"toabctl","id":276317,"avatar_url":"https://avatars3.githubusercontent.com/u/276317?v=3","gravatar_id":"","url":"https://api.github.com/users/toabctl","html_url":"https://github.com/toabctl","followers_url":"https://api.github.com/users/toabctl/followers","following_url":"https://api.github.com/users/toabctl/following{/other_user}","gists_url":"https://api.github.com/users/toabctl/gists{/gist_id}","starred_url":"https://api.github.com/users/toabctl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toabctl/subscriptions","organizations_url":"https://api.github.com/users/toabctl/orgs","repos_url":"https://api.github.com/users/toabctl/repos","events_url":"https://api.github.com/users/toabctl/events{/privacy}","received_events_url":"https://api.github.com/users/toabctl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toabctl/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/toabctl/crowbar-openstack","forks_url":"https://api.github.com/repos/toabctl/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/toabctl/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toabctl/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toabctl/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/toabctl/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/toabctl/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/toabctl/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/toabctl/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/toabctl/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toabctl/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/toabctl/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/toabctl/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/toabctl/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/toabctl/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/toabctl/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/toabctl/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/toabctl/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/toabctl/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/toabctl/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/toabctl/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toabctl/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/toabctl/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toabctl/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/toabctl/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/toabctl/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/toabctl/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/toabctl/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toabctl/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/toabctl/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/toabctl/crowbar-openstack/deployments","created_at":"2015-08-17T13:21:21Z","updated_at":"2016-12-21T08:45:40Z","pushed_at":"2017-04-28T12:40:19Z","git_url":"git://github.com/toabctl/crowbar-openstack.git","ssh_url":"git@github.com:toabctl/crowbar-openstack.git","clone_url":"https://github.com/toabctl/crowbar-openstack.git","svn_url":"https://github.com/toabctl/crowbar-openstack","homepage":null,"size":18625,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"26ab71c6c7a584baa303612fe1972c65322840d4","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2017-03-24T11:40:40Z","pushed_at":"2017-04-28T12:40:42Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":18712,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":59,"forks":55,"open_issues":59,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/938"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/938"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/938"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/938/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/938/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/938/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/50da005f61a90fcca4456e781f93610941f20b29"}}}}
{"actor":{"display_login":"houndci-bot"}}