{"action":"opened","issue":{"url":"https://api.github.com/repos/jkphl/squeezr/issues/20","repository_url":"https://api.github.com/repos/jkphl/squeezr","labels_url":"https://api.github.com/repos/jkphl/squeezr/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/jkphl/squeezr/issues/20/comments","events_url":"https://api.github.com/repos/jkphl/squeezr/issues/20/events","html_url":"https://github.com/jkphl/squeezr/issues/20","id":242387250,"number":20,"title":"Changes to CSS Minification","user":{"login":"discotizer","id":2333108,"avatar_url":"https://avatars1.githubusercontent.com/u/2333108?v=3","gravatar_id":"","url":"https://api.github.com/users/discotizer","html_url":"https://github.com/discotizer","followers_url":"https://api.github.com/users/discotizer/followers","following_url":"https://api.github.com/users/discotizer/following{/other_user}","gists_url":"https://api.github.com/users/discotizer/gists{/gist_id}","starred_url":"https://api.github.com/users/discotizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discotizer/subscriptions","organizations_url":"https://api.github.com/users/discotizer/orgs","repos_url":"https://api.github.com/users/discotizer/repos","events_url":"https://api.github.com/users/discotizer/events{/privacy}","received_events_url":"https://api.github.com/users/discotizer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-12T13:50:43Z","updated_at":"2017-07-12T13:50:43Z","closed_at":null,"body":"Hi Joschi,\r\n\r\ni am currently integrating your fabulous tool with a bigger website and am testing the results with the AI script from Matt which is running right now on the website.\r\nSo far the results are very good, but i've ran into a situation where i would suggest a change in the way the CSS is minified:\r\n\r\nThe scenario:\r\nI've a CSS setup with following breakpoint:\r\n- up to 359px delivers a 320px version (many old Androids, all iPhones <6 in Portrait mode)\r\n- 360-479px delivers a 360px version (iPhone >6 Portrait mode)\r\n- 480-639px delivers a 480px version (Landscape mode of older Androids)\r\n- 640-767px delivers a 640px version  (iPhone >6 Landscape mode)\r\n- 768 and higher for iPad and Desktop, not relevant here\r\n\r\nNow when i open up the site on an iPhone 6, the delivered CSS is a stripped down version.\r\nIt contains only the main part and the first two definitions. The result is fine.\r\nBUT when i switch to landscape mode (by turning the phone) the needed breakpoint is missing.\r\n\r\nSo my idea is to keep all breakpoints that fit to both sides of the device's resolution.\r\nHere it would be the 667px height so this would result to keep the breakpoints 2, 3 and 4.\r\n\r\nThis scenarion is also valid for other MOBILE devices like tablets. Maybe you could ignore this on Desktop browsers and minify the CSS the old way, when pixelratio is 1.\r\n\r\nCheers,\r\nRumen"}}
{"actor":{"display_login":"discotizer"}}