{"action":"created","comment":{"url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/comments/120007395","pull_request_review_id":41938801,"id":120007395,"diff_hunk":"@@ -1,6 +1,7 @@\n import { SinonStub, stub } from 'sinon';\n \n-export const ProvidedDependencyToken = Symbol('providedDependency');\n+// Would use Symbol() in ES6, string in ES5","path":"test/mocks/providedDependency.mock.ts","position":4,"original_position":4,"commit_id":"82a516872ba0dfb83476050add97af20dab62797","original_commit_id":"82a516872ba0dfb83476050add97af20dab62797","user":{"login":"connorwyatt","id":9286228,"avatar_url":"https://avatars0.githubusercontent.com/u/9286228?v=3","gravatar_id":"","url":"https://api.github.com/users/connorwyatt","html_url":"https://github.com/connorwyatt","followers_url":"https://api.github.com/users/connorwyatt/followers","following_url":"https://api.github.com/users/connorwyatt/following{/other_user}","gists_url":"https://api.github.com/users/connorwyatt/gists{/gist_id}","starred_url":"https://api.github.com/users/connorwyatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorwyatt/subscriptions","organizations_url":"https://api.github.com/users/connorwyatt/orgs","repos_url":"https://api.github.com/users/connorwyatt/repos","events_url":"https://api.github.com/users/connorwyatt/events{/privacy}","received_events_url":"https://api.github.com/users/connorwyatt/received_events","type":"User","site_admin":false},"body":"Same again, the tests should be run on node so you shouldn't have to change this, I'd be happy for you to add a separate test for using strings but the primary use case is ES6 with node.","created_at":"2017-06-04T11:17:06Z","updated_at":"2017-06-04T11:17:16Z","html_url":"https://github.com/connorwyatt/Fluency-Injection/pull/5#discussion_r120007395","pull_request_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/comments/120007395"},"html":{"href":"https://github.com/connorwyatt/Fluency-Injection/pull/5#discussion_r120007395"},"pull_request":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/5","id":123873744,"html_url":"https://github.com/connorwyatt/Fluency-Injection/pull/5","diff_url":"https://github.com/connorwyatt/Fluency-Injection/pull/5.diff","patch_url":"https://github.com/connorwyatt/Fluency-Injection/pull/5.patch","issue_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/issues/5","number":5,"state":"open","locked":false,"title":"Require ES5 + minimal Map<> instead of ES6","user":{"login":"vbraun","id":888729,"avatar_url":"https://avatars1.githubusercontent.com/u/888729?v=3","gravatar_id":"","url":"https://api.github.com/users/vbraun","html_url":"https://github.com/vbraun","followers_url":"https://api.github.com/users/vbraun/followers","following_url":"https://api.github.com/users/vbraun/following{/other_user}","gists_url":"https://api.github.com/users/vbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/vbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbraun/subscriptions","organizations_url":"https://api.github.com/users/vbraun/orgs","repos_url":"https://api.github.com/users/vbraun/repos","events_url":"https://api.github.com/users/vbraun/events{/privacy}","received_events_url":"https://api.github.com/users/vbraun/received_events","type":"User","site_admin":false},"body":"Here is a stab at IE11 support. A minor annoyance is that arguments is not an array type in ES5, so requires extra cast for splat.","created_at":"2017-06-04T10:59:57Z","updated_at":"2017-06-04T11:17:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3305b65f9864b6cd3d4190685dea14e24b0846e5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/5/commits","review_comments_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/5/comments","review_comment_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/issues/5/comments","statuses_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/statuses/82a516872ba0dfb83476050add97af20dab62797","head":{"label":"vbraun:es5","ref":"es5","sha":"82a516872ba0dfb83476050add97af20dab62797","user":{"login":"vbraun","id":888729,"avatar_url":"https://avatars1.githubusercontent.com/u/888729?v=3","gravatar_id":"","url":"https://api.github.com/users/vbraun","html_url":"https://github.com/vbraun","followers_url":"https://api.github.com/users/vbraun/followers","following_url":"https://api.github.com/users/vbraun/following{/other_user}","gists_url":"https://api.github.com/users/vbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/vbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbraun/subscriptions","organizations_url":"https://api.github.com/users/vbraun/orgs","repos_url":"https://api.github.com/users/vbraun/repos","events_url":"https://api.github.com/users/vbraun/events{/privacy}","received_events_url":"https://api.github.com/users/vbraun/received_events","type":"User","site_admin":false},"repo":{"id":93305899,"name":"Fluency-Injection","full_name":"vbraun/Fluency-Injection","owner":{"login":"vbraun","id":888729,"avatar_url":"https://avatars1.githubusercontent.com/u/888729?v=3","gravatar_id":"","url":"https://api.github.com/users/vbraun","html_url":"https://github.com/vbraun","followers_url":"https://api.github.com/users/vbraun/followers","following_url":"https://api.github.com/users/vbraun/following{/other_user}","gists_url":"https://api.github.com/users/vbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/vbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbraun/subscriptions","organizations_url":"https://api.github.com/users/vbraun/orgs","repos_url":"https://api.github.com/users/vbraun/repos","events_url":"https://api.github.com/users/vbraun/events{/privacy}","received_events_url":"https://api.github.com/users/vbraun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vbraun/Fluency-Injection","description":"A TypeScript dependency injection framework, inspired by Angular2 dependency injection using decorators.","fork":true,"url":"https://api.github.com/repos/vbraun/Fluency-Injection","forks_url":"https://api.github.com/repos/vbraun/Fluency-Injection/forks","keys_url":"https://api.github.com/repos/vbraun/Fluency-Injection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vbraun/Fluency-Injection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vbraun/Fluency-Injection/teams","hooks_url":"https://api.github.com/repos/vbraun/Fluency-Injection/hooks","issue_events_url":"https://api.github.com/repos/vbraun/Fluency-Injection/issues/events{/number}","events_url":"https://api.github.com/repos/vbraun/Fluency-Injection/events","assignees_url":"https://api.github.com/repos/vbraun/Fluency-Injection/assignees{/user}","branches_url":"https://api.github.com/repos/vbraun/Fluency-Injection/branches{/branch}","tags_url":"https://api.github.com/repos/vbraun/Fluency-Injection/tags","blobs_url":"https://api.github.com/repos/vbraun/Fluency-Injection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vbraun/Fluency-Injection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vbraun/Fluency-Injection/git/refs{/sha}","trees_url":"https://api.github.com/repos/vbraun/Fluency-Injection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vbraun/Fluency-Injection/statuses/{sha}","languages_url":"https://api.github.com/repos/vbraun/Fluency-Injection/languages","stargazers_url":"https://api.github.com/repos/vbraun/Fluency-Injection/stargazers","contributors_url":"https://api.github.com/repos/vbraun/Fluency-Injection/contributors","subscribers_url":"https://api.github.com/repos/vbraun/Fluency-Injection/subscribers","subscription_url":"https://api.github.com/repos/vbraun/Fluency-Injection/subscription","commits_url":"https://api.github.com/repos/vbraun/Fluency-Injection/commits{/sha}","git_commits_url":"https://api.github.com/repos/vbraun/Fluency-Injection/git/commits{/sha}","comments_url":"https://api.github.com/repos/vbraun/Fluency-Injection/comments{/number}","issue_comment_url":"https://api.github.com/repos/vbraun/Fluency-Injection/issues/comments{/number}","contents_url":"https://api.github.com/repos/vbraun/Fluency-Injection/contents/{+path}","compare_url":"https://api.github.com/repos/vbraun/Fluency-Injection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vbraun/Fluency-Injection/merges","archive_url":"https://api.github.com/repos/vbraun/Fluency-Injection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vbraun/Fluency-Injection/downloads","issues_url":"https://api.github.com/repos/vbraun/Fluency-Injection/issues{/number}","pulls_url":"https://api.github.com/repos/vbraun/Fluency-Injection/pulls{/number}","milestones_url":"https://api.github.com/repos/vbraun/Fluency-Injection/milestones{/number}","notifications_url":"https://api.github.com/repos/vbraun/Fluency-Injection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vbraun/Fluency-Injection/labels{/name}","releases_url":"https://api.github.com/repos/vbraun/Fluency-Injection/releases{/id}","deployments_url":"https://api.github.com/repos/vbraun/Fluency-Injection/deployments","created_at":"2017-06-04T10:24:21Z","updated_at":"2017-06-04T10:24:23Z","pushed_at":"2017-06-04T10:55:31Z","git_url":"git://github.com/vbraun/Fluency-Injection.git","ssh_url":"git@github.com:vbraun/Fluency-Injection.git","clone_url":"https://github.com/vbraun/Fluency-Injection.git","svn_url":"https://github.com/vbraun/Fluency-Injection","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"connorwyatt:master","ref":"master","sha":"397f32bf745b5407b7203199f2862f46737c0153","user":{"login":"connorwyatt","id":9286228,"avatar_url":"https://avatars0.githubusercontent.com/u/9286228?v=3","gravatar_id":"","url":"https://api.github.com/users/connorwyatt","html_url":"https://github.com/connorwyatt","followers_url":"https://api.github.com/users/connorwyatt/followers","following_url":"https://api.github.com/users/connorwyatt/following{/other_user}","gists_url":"https://api.github.com/users/connorwyatt/gists{/gist_id}","starred_url":"https://api.github.com/users/connorwyatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorwyatt/subscriptions","organizations_url":"https://api.github.com/users/connorwyatt/orgs","repos_url":"https://api.github.com/users/connorwyatt/repos","events_url":"https://api.github.com/users/connorwyatt/events{/privacy}","received_events_url":"https://api.github.com/users/connorwyatt/received_events","type":"User","site_admin":false},"repo":{"id":59413215,"name":"Fluency-Injection","full_name":"connorwyatt/Fluency-Injection","owner":{"login":"connorwyatt","id":9286228,"avatar_url":"https://avatars0.githubusercontent.com/u/9286228?v=3","gravatar_id":"","url":"https://api.github.com/users/connorwyatt","html_url":"https://github.com/connorwyatt","followers_url":"https://api.github.com/users/connorwyatt/followers","following_url":"https://api.github.com/users/connorwyatt/following{/other_user}","gists_url":"https://api.github.com/users/connorwyatt/gists{/gist_id}","starred_url":"https://api.github.com/users/connorwyatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorwyatt/subscriptions","organizations_url":"https://api.github.com/users/connorwyatt/orgs","repos_url":"https://api.github.com/users/connorwyatt/repos","events_url":"https://api.github.com/users/connorwyatt/events{/privacy}","received_events_url":"https://api.github.com/users/connorwyatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/connorwyatt/Fluency-Injection","description":"A TypeScript dependency injection framework, inspired by Angular2 dependency injection using decorators.","fork":false,"url":"https://api.github.com/repos/connorwyatt/Fluency-Injection","forks_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/forks","keys_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/teams","hooks_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/hooks","issue_events_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/issues/events{/number}","events_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/events","assignees_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/assignees{/user}","branches_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/branches{/branch}","tags_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/tags","blobs_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/git/refs{/sha}","trees_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/statuses/{sha}","languages_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/languages","stargazers_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/stargazers","contributors_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/contributors","subscribers_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/subscribers","subscription_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/subscription","commits_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/commits{/sha}","git_commits_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/git/commits{/sha}","comments_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/comments{/number}","issue_comment_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/issues/comments{/number}","contents_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/contents/{+path}","compare_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/merges","archive_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/downloads","issues_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/issues{/number}","pulls_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls{/number}","milestones_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/milestones{/number}","notifications_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/labels{/name}","releases_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/releases{/id}","deployments_url":"https://api.github.com/repos/connorwyatt/Fluency-Injection/deployments","created_at":"2016-05-22T13:15:28Z","updated_at":"2016-11-30T08:33:27Z","pushed_at":"2017-06-04T10:59:58Z","git_url":"git://github.com/connorwyatt/Fluency-Injection.git","ssh_url":"git@github.com:connorwyatt/Fluency-Injection.git","clone_url":"https://github.com/connorwyatt/Fluency-Injection.git","svn_url":"https://github.com/connorwyatt/Fluency-Injection","homepage":null,"size":21,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/5"},"html":{"href":"https://github.com/connorwyatt/Fluency-Injection/pull/5"},"issue":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/issues/5"},"comments":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/connorwyatt/Fluency-Injection/statuses/82a516872ba0dfb83476050add97af20dab62797"}}}}
{"actor":{"display_login":"connorwyatt"}}