{"action":"created","comment":{"url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/comments/94682675","pull_request_review_id":15216259,"id":94682675,"diff_hunk":"@@ -105,8 +104,8 @@ class LocalBoundingBoxFunctor\n     {\n         for ( size_t d = 0; d < 3; ++d )\n         {\n-            dst[d] = std::numeric_limits<SC>::max();\n-            dst[d + 3] = -std::numeric_limits<SC>::max();\n+            dst[d] = KokkosHelpers::numericLimitsMax<SC>();\n+            dst[d + 3] = -KokkosHelpers::numericLimitsMax<SC>();","path":"packages/Kokkos/src/DTK_PointCloud_def.hpp","position":15,"original_position":15,"commit_id":"fe07c3a17f3dac5a0e9f669fcc18a235055dc7b0","original_commit_id":"fe07c3a17f3dac5a0e9f669fcc18a235055dc7b0","user":{"login":"sslattery","id":755901,"avatar_url":"https://avatars.githubusercontent.com/u/755901?v=3","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"body":"@dalg24 @Rombur @dalg24 should we rely on the Tpetra code in the Kokkos::Details namespace for the arithmetic traits or should we have our own? There's is complete and I would argue it should be moved into Kokkos and out of the Details namespace. I would prefer to use it.","created_at":"2017-01-04T22:52:34Z","updated_at":"2017-01-04T22:52:34Z","html_url":"https://github.com/ORNL-CEES/DataTransferKit/pull/179#discussion_r94682675","pull_request_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/comments/94682675"},"html":{"href":"https://github.com/ORNL-CEES/DataTransferKit/pull/179#discussion_r94682675"},"pull_request":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/179","id":100189795,"html_url":"https://github.com/ORNL-CEES/DataTransferKit/pull/179","diff_url":"https://github.com/ORNL-CEES/DataTransferKit/pull/179.diff","patch_url":"https://github.com/ORNL-CEES/DataTransferKit/pull/179.patch","issue_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/179","number":179,"state":"open","locked":false,"title":"Fix CUDA Errors","user":{"login":"sslattery","id":755901,"avatar_url":"https://avatars.githubusercontent.com/u/755901?v=3","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"body":"It was discovered non-portable code was added by #161. Some C++ STL functions were being called inside of functions defined as `KOKKOS_INLINE_FUNCTION` and therefore were not callable by the CUDA compiler. This PR fixes that behavior as well as other errors and adds a test.\r\n\r\nYet another reason to get CUDA in the docker image and CI server as soon as possible.","created_at":"2017-01-04T21:15:05Z","updated_at":"2017-01-04T22:52:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cceafb297334b0a7326d49400d49dbd7597ae489","assignee":{"login":"sslattery","id":755901,"avatar_url":"https://avatars.githubusercontent.com/u/755901?v=3","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"assignees":[{"login":"sslattery","id":755901,"avatar_url":"https://avatars.githubusercontent.com/u/755901?v=3","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/milestones/2","html_url":"https://github.com/ORNL-CEES/DataTransferKit/milestone/2","labels_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/milestones/2/labels","id":2208267,"number":2,"title":"LDRD-FY17-Q2","description":"","creator":{"login":"aprokop","id":7297887,"avatar_url":"https://avatars.githubusercontent.com/u/7297887?v=3","gravatar_id":"","url":"https://api.github.com/users/aprokop","html_url":"https://github.com/aprokop","followers_url":"https://api.github.com/users/aprokop/followers","following_url":"https://api.github.com/users/aprokop/following{/other_user}","gists_url":"https://api.github.com/users/aprokop/gists{/gist_id}","starred_url":"https://api.github.com/users/aprokop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aprokop/subscriptions","organizations_url":"https://api.github.com/users/aprokop/orgs","repos_url":"https://api.github.com/users/aprokop/repos","events_url":"https://api.github.com/users/aprokop/events{/privacy}","received_events_url":"https://api.github.com/users/aprokop/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2016-12-20T19:49:00Z","updated_at":"2017-01-04T21:15:05Z","due_on":"2017-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/179/commits","review_comments_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/179/comments","review_comment_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/179/comments","statuses_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/statuses/fe07c3a17f3dac5a0e9f669fcc18a235055dc7b0","head":{"label":"sslattery:fix_cuda_errors","ref":"fix_cuda_errors","sha":"fe07c3a17f3dac5a0e9f669fcc18a235055dc7b0","user":{"login":"sslattery","id":755901,"avatar_url":"https://avatars.githubusercontent.com/u/755901?v=3","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"repo":{"id":55519828,"name":"DataTransferKit","full_name":"sslattery/DataTransferKit","owner":{"login":"sslattery","id":755901,"avatar_url":"https://avatars.githubusercontent.com/u/755901?v=3","gravatar_id":"","url":"https://api.github.com/users/sslattery","html_url":"https://github.com/sslattery","followers_url":"https://api.github.com/users/sslattery/followers","following_url":"https://api.github.com/users/sslattery/following{/other_user}","gists_url":"https://api.github.com/users/sslattery/gists{/gist_id}","starred_url":"https://api.github.com/users/sslattery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sslattery/subscriptions","organizations_url":"https://api.github.com/users/sslattery/orgs","repos_url":"https://api.github.com/users/sslattery/repos","events_url":"https://api.github.com/users/sslattery/events{/privacy}","received_events_url":"https://api.github.com/users/sslattery/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sslattery/DataTransferKit","description":"A library for multiphysics solution transfer.","fork":true,"url":"https://api.github.com/repos/sslattery/DataTransferKit","forks_url":"https://api.github.com/repos/sslattery/DataTransferKit/forks","keys_url":"https://api.github.com/repos/sslattery/DataTransferKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sslattery/DataTransferKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sslattery/DataTransferKit/teams","hooks_url":"https://api.github.com/repos/sslattery/DataTransferKit/hooks","issue_events_url":"https://api.github.com/repos/sslattery/DataTransferKit/issues/events{/number}","events_url":"https://api.github.com/repos/sslattery/DataTransferKit/events","assignees_url":"https://api.github.com/repos/sslattery/DataTransferKit/assignees{/user}","branches_url":"https://api.github.com/repos/sslattery/DataTransferKit/branches{/branch}","tags_url":"https://api.github.com/repos/sslattery/DataTransferKit/tags","blobs_url":"https://api.github.com/repos/sslattery/DataTransferKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sslattery/DataTransferKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sslattery/DataTransferKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sslattery/DataTransferKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sslattery/DataTransferKit/statuses/{sha}","languages_url":"https://api.github.com/repos/sslattery/DataTransferKit/languages","stargazers_url":"https://api.github.com/repos/sslattery/DataTransferKit/stargazers","contributors_url":"https://api.github.com/repos/sslattery/DataTransferKit/contributors","subscribers_url":"https://api.github.com/repos/sslattery/DataTransferKit/subscribers","subscription_url":"https://api.github.com/repos/sslattery/DataTransferKit/subscription","commits_url":"https://api.github.com/repos/sslattery/DataTransferKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sslattery/DataTransferKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sslattery/DataTransferKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sslattery/DataTransferKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sslattery/DataTransferKit/contents/{+path}","compare_url":"https://api.github.com/repos/sslattery/DataTransferKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sslattery/DataTransferKit/merges","archive_url":"https://api.github.com/repos/sslattery/DataTransferKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sslattery/DataTransferKit/downloads","issues_url":"https://api.github.com/repos/sslattery/DataTransferKit/issues{/number}","pulls_url":"https://api.github.com/repos/sslattery/DataTransferKit/pulls{/number}","milestones_url":"https://api.github.com/repos/sslattery/DataTransferKit/milestones{/number}","notifications_url":"https://api.github.com/repos/sslattery/DataTransferKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sslattery/DataTransferKit/labels{/name}","releases_url":"https://api.github.com/repos/sslattery/DataTransferKit/releases{/id}","deployments_url":"https://api.github.com/repos/sslattery/DataTransferKit/deployments","created_at":"2016-04-05T15:31:13Z","updated_at":"2016-04-05T15:31:15Z","pushed_at":"2017-01-04T22:07:20Z","git_url":"git://github.com/sslattery/DataTransferKit.git","ssh_url":"git@github.com:sslattery/DataTransferKit.git","clone_url":"https://github.com/sslattery/DataTransferKit.git","svn_url":"https://github.com/sslattery/DataTransferKit","homepage":"ORNL-CEES.github.io/DataTransferKit","size":14646,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ORNL-CEES:master","ref":"master","sha":"4e92f259c00ebaf1a895d442757751f986195494","user":{"login":"ORNL-CEES","id":6653148,"avatar_url":"https://avatars.githubusercontent.com/u/6653148?v=3","gravatar_id":"","url":"https://api.github.com/users/ORNL-CEES","html_url":"https://github.com/ORNL-CEES","followers_url":"https://api.github.com/users/ORNL-CEES/followers","following_url":"https://api.github.com/users/ORNL-CEES/following{/other_user}","gists_url":"https://api.github.com/users/ORNL-CEES/gists{/gist_id}","starred_url":"https://api.github.com/users/ORNL-CEES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ORNL-CEES/subscriptions","organizations_url":"https://api.github.com/users/ORNL-CEES/orgs","repos_url":"https://api.github.com/users/ORNL-CEES/repos","events_url":"https://api.github.com/users/ORNL-CEES/events{/privacy}","received_events_url":"https://api.github.com/users/ORNL-CEES/received_events","type":"Organization","site_admin":false},"repo":{"id":25265743,"name":"DataTransferKit","full_name":"ORNL-CEES/DataTransferKit","owner":{"login":"ORNL-CEES","id":6653148,"avatar_url":"https://avatars.githubusercontent.com/u/6653148?v=3","gravatar_id":"","url":"https://api.github.com/users/ORNL-CEES","html_url":"https://github.com/ORNL-CEES","followers_url":"https://api.github.com/users/ORNL-CEES/followers","following_url":"https://api.github.com/users/ORNL-CEES/following{/other_user}","gists_url":"https://api.github.com/users/ORNL-CEES/gists{/gist_id}","starred_url":"https://api.github.com/users/ORNL-CEES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ORNL-CEES/subscriptions","organizations_url":"https://api.github.com/users/ORNL-CEES/orgs","repos_url":"https://api.github.com/users/ORNL-CEES/repos","events_url":"https://api.github.com/users/ORNL-CEES/events{/privacy}","received_events_url":"https://api.github.com/users/ORNL-CEES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ORNL-CEES/DataTransferKit","description":"A library for multiphysics solution transfer.","fork":false,"url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit","forks_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/forks","keys_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/teams","hooks_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/hooks","issue_events_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/events{/number}","events_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/events","assignees_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/assignees{/user}","branches_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/branches{/branch}","tags_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/tags","blobs_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/statuses/{sha}","languages_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/languages","stargazers_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/stargazers","contributors_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/contributors","subscribers_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/subscribers","subscription_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/subscription","commits_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/contents/{+path}","compare_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/merges","archive_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/downloads","issues_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues{/number}","pulls_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls{/number}","milestones_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/milestones{/number}","notifications_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/labels{/name}","releases_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/releases{/id}","deployments_url":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/deployments","created_at":"2014-10-15T17:35:07Z","updated_at":"2016-12-25T07:24:52Z","pushed_at":"2017-01-04T22:34:42Z","git_url":"git://github.com/ORNL-CEES/DataTransferKit.git","ssh_url":"git@github.com:ORNL-CEES/DataTransferKit.git","clone_url":"https://github.com/ORNL-CEES/DataTransferKit.git","svn_url":"https://github.com/ORNL-CEES/DataTransferKit","homepage":"https://ornl-cees.github.io/DataTransferKit","size":16257,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":18,"forks":11,"open_issues":18,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/179"},"html":{"href":"https://github.com/ORNL-CEES/DataTransferKit/pull/179"},"issue":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/179"},"comments":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/ORNL-CEES/DataTransferKit/statuses/fe07c3a17f3dac5a0e9f669fcc18a235055dc7b0"}}}}
{"actor":{"display_login":"sslattery"}}