{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/django/asgi_ipc/pulls/32","id":135654464,"html_url":"https://github.com/django/asgi_ipc/pull/32","diff_url":"https://github.com/django/asgi_ipc/pull/32.diff","patch_url":"https://github.com/django/asgi_ipc/pull/32.patch","issue_url":"https://api.github.com/repos/django/asgi_ipc/issues/32","number":32,"state":"closed","locked":false,"title":"catch key error that is result of non existing groups","user":{"login":"Bartzi","id":2399349,"avatar_url":"https://avatars3.githubusercontent.com/u/2399349?v=4","gravatar_id":"","url":"https://api.github.com/users/Bartzi","html_url":"https://github.com/Bartzi","followers_url":"https://api.github.com/users/Bartzi/followers","following_url":"https://api.github.com/users/Bartzi/following{/other_user}","gists_url":"https://api.github.com/users/Bartzi/gists{/gist_id}","starred_url":"https://api.github.com/users/Bartzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bartzi/subscriptions","organizations_url":"https://api.github.com/users/Bartzi/orgs","repos_url":"https://api.github.com/users/Bartzi/repos","events_url":"https://api.github.com/users/Bartzi/events{/privacy}","received_events_url":"https://api.github.com/users/Bartzi/received_events","type":"User","site_admin":false},"body":"We are using `channels` and `asgi_ipc` in our project for sending a live preview of a document to a group of users.\r\nWe recently updated all of our dependencies and found that the live preview sending via `asgi_ipc` does not work anymore.\r\n\r\nWe are basically sending html through the websocket to everyone interested and subscribed to that group. In previous releases it was no problem to send the message to a group without any members, but with the most current version of the code this is not possible anymore and our workers crash in `store.py` when they try to remove members from the non existing group. We are able to reproduce this error on a range of different Linux based systems in different configurations, I was not able to compile a small standalone code version, that reproduces this error, but I will provide with a step by step list on how to reproduce the error using our system, if there is anybody interested in reproducing the error.\r\n\r\nThis PR tries to fix this problem, but I'm really not sure whether this is the right way to go.\r\n\r\n### Steps to reproduce:\r\n\r\n1. Clone our [repository](https://github.com/fsr-itse/1327)\r\n2. Create a `Python 3` virtualenv\r\n3. Install all requirements from the files `requirements.txt`, and `requirements-deploy.txt`\r\n4. Create a file `localsettings.py` in the folder `_1327` and add the following:\r\n \r\n```\r\nCHANNEL_LAYERS = {\r\n\t\"default\": {\r\n\t\t\"BACKEND\": \"asgi_ipc.IPCChannelLayer\",\r\n\t\t\"ROUTING\": \"_1327.routing.channel_routing\",\r\n\t\t\"CONFIG\": {\r\n\t\t\t\"prefix\": \"1327\",\r\n\t\t},\r\n\t},\r\n}\r\n```\r\n5. run the command `python manage.py createsuperuser` to create a user\r\n6. run `daphne _1327.asgi:channel_layer`\r\n7. start a worker with `python manage.py runworker`\r\n8. open `localhost:8000` and login\r\n9. go to the menu and create a new `InformationPage`\r\n10. Enter some text in the text area and wait for the worker to crash with a `KeyError`\r\n\r\nI know these are quite some steps, but I'm really not sure why this is happening and maybe the reason is something else, than my quick and dirty fix.\r\n\r\nPlease also see the [ticket](https://github.com/fsr-itse/1327/issues/589) in our repository with the error message.\r\n\r\nPlease let me know if you need more information","created_at":"2017-08-14T18:13:41Z","updated_at":"2017-08-27T23:01:39Z","closed_at":"2017-08-27T23:01:39Z","merged_at":"2017-08-27T23:01:39Z","merge_commit_sha":"c10f4ae459e0a1c16eb3ce7e506f3fb0e2dc9752","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/django/asgi_ipc/pulls/32/commits","review_comments_url":"https://api.github.com/repos/django/asgi_ipc/pulls/32/comments","review_comment_url":"https://api.github.com/repos/django/asgi_ipc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/django/asgi_ipc/issues/32/comments","statuses_url":"https://api.github.com/repos/django/asgi_ipc/statuses/0c07510de95d4c34d5ede8891c4e7dc6d731e686","head":{"label":"Bartzi:fix_for_non_existing_groups","ref":"fix_for_non_existing_groups","sha":"0c07510de95d4c34d5ede8891c4e7dc6d731e686","user":{"login":"Bartzi","id":2399349,"avatar_url":"https://avatars3.githubusercontent.com/u/2399349?v=4","gravatar_id":"","url":"https://api.github.com/users/Bartzi","html_url":"https://github.com/Bartzi","followers_url":"https://api.github.com/users/Bartzi/followers","following_url":"https://api.github.com/users/Bartzi/following{/other_user}","gists_url":"https://api.github.com/users/Bartzi/gists{/gist_id}","starred_url":"https://api.github.com/users/Bartzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bartzi/subscriptions","organizations_url":"https://api.github.com/users/Bartzi/orgs","repos_url":"https://api.github.com/users/Bartzi/repos","events_url":"https://api.github.com/users/Bartzi/events{/privacy}","received_events_url":"https://api.github.com/users/Bartzi/received_events","type":"User","site_admin":false},"repo":{"id":100294547,"name":"asgi_ipc","full_name":"Bartzi/asgi_ipc","owner":{"login":"Bartzi","id":2399349,"avatar_url":"https://avatars3.githubusercontent.com/u/2399349?v=4","gravatar_id":"","url":"https://api.github.com/users/Bartzi","html_url":"https://github.com/Bartzi","followers_url":"https://api.github.com/users/Bartzi/followers","following_url":"https://api.github.com/users/Bartzi/following{/other_user}","gists_url":"https://api.github.com/users/Bartzi/gists{/gist_id}","starred_url":"https://api.github.com/users/Bartzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bartzi/subscriptions","organizations_url":"https://api.github.com/users/Bartzi/orgs","repos_url":"https://api.github.com/users/Bartzi/repos","events_url":"https://api.github.com/users/Bartzi/events{/privacy}","received_events_url":"https://api.github.com/users/Bartzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bartzi/asgi_ipc","description":"IPC-based ASGI channel layer","fork":true,"url":"https://api.github.com/repos/Bartzi/asgi_ipc","forks_url":"https://api.github.com/repos/Bartzi/asgi_ipc/forks","keys_url":"https://api.github.com/repos/Bartzi/asgi_ipc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bartzi/asgi_ipc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bartzi/asgi_ipc/teams","hooks_url":"https://api.github.com/repos/Bartzi/asgi_ipc/hooks","issue_events_url":"https://api.github.com/repos/Bartzi/asgi_ipc/issues/events{/number}","events_url":"https://api.github.com/repos/Bartzi/asgi_ipc/events","assignees_url":"https://api.github.com/repos/Bartzi/asgi_ipc/assignees{/user}","branches_url":"https://api.github.com/repos/Bartzi/asgi_ipc/branches{/branch}","tags_url":"https://api.github.com/repos/Bartzi/asgi_ipc/tags","blobs_url":"https://api.github.com/repos/Bartzi/asgi_ipc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bartzi/asgi_ipc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bartzi/asgi_ipc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bartzi/asgi_ipc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bartzi/asgi_ipc/statuses/{sha}","languages_url":"https://api.github.com/repos/Bartzi/asgi_ipc/languages","stargazers_url":"https://api.github.com/repos/Bartzi/asgi_ipc/stargazers","contributors_url":"https://api.github.com/repos/Bartzi/asgi_ipc/contributors","subscribers_url":"https://api.github.com/repos/Bartzi/asgi_ipc/subscribers","subscription_url":"https://api.github.com/repos/Bartzi/asgi_ipc/subscription","commits_url":"https://api.github.com/repos/Bartzi/asgi_ipc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bartzi/asgi_ipc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bartzi/asgi_ipc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bartzi/asgi_ipc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bartzi/asgi_ipc/contents/{+path}","compare_url":"https://api.github.com/repos/Bartzi/asgi_ipc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bartzi/asgi_ipc/merges","archive_url":"https://api.github.com/repos/Bartzi/asgi_ipc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bartzi/asgi_ipc/downloads","issues_url":"https://api.github.com/repos/Bartzi/asgi_ipc/issues{/number}","pulls_url":"https://api.github.com/repos/Bartzi/asgi_ipc/pulls{/number}","milestones_url":"https://api.github.com/repos/Bartzi/asgi_ipc/milestones{/number}","notifications_url":"https://api.github.com/repos/Bartzi/asgi_ipc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bartzi/asgi_ipc/labels{/name}","releases_url":"https://api.github.com/repos/Bartzi/asgi_ipc/releases{/id}","deployments_url":"https://api.github.com/repos/Bartzi/asgi_ipc/deployments","created_at":"2017-08-14T17:52:00Z","updated_at":"2017-08-14T17:52:01Z","pushed_at":"2017-08-14T17:55:44Z","git_url":"git://github.com/Bartzi/asgi_ipc.git","ssh_url":"git@github.com:Bartzi/asgi_ipc.git","clone_url":"https://github.com/Bartzi/asgi_ipc.git","svn_url":"https://github.com/Bartzi/asgi_ipc","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"django:master","ref":"master","sha":"028ed386323f7af6345a65a023a8af7d4b55f79e","user":{"login":"django","id":27804,"avatar_url":"https://avatars2.githubusercontent.com/u/27804?v=4","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"repo":{"id":58187705,"name":"asgi_ipc","full_name":"django/asgi_ipc","owner":{"login":"django","id":27804,"avatar_url":"https://avatars2.githubusercontent.com/u/27804?v=4","gravatar_id":"","url":"https://api.github.com/users/django","html_url":"https://github.com/django","followers_url":"https://api.github.com/users/django/followers","following_url":"https://api.github.com/users/django/following{/other_user}","gists_url":"https://api.github.com/users/django/gists{/gist_id}","starred_url":"https://api.github.com/users/django/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/django/subscriptions","organizations_url":"https://api.github.com/users/django/orgs","repos_url":"https://api.github.com/users/django/repos","events_url":"https://api.github.com/users/django/events{/privacy}","received_events_url":"https://api.github.com/users/django/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/django/asgi_ipc","description":"IPC-based ASGI channel layer","fork":false,"url":"https://api.github.com/repos/django/asgi_ipc","forks_url":"https://api.github.com/repos/django/asgi_ipc/forks","keys_url":"https://api.github.com/repos/django/asgi_ipc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/django/asgi_ipc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/django/asgi_ipc/teams","hooks_url":"https://api.github.com/repos/django/asgi_ipc/hooks","issue_events_url":"https://api.github.com/repos/django/asgi_ipc/issues/events{/number}","events_url":"https://api.github.com/repos/django/asgi_ipc/events","assignees_url":"https://api.github.com/repos/django/asgi_ipc/assignees{/user}","branches_url":"https://api.github.com/repos/django/asgi_ipc/branches{/branch}","tags_url":"https://api.github.com/repos/django/asgi_ipc/tags","blobs_url":"https://api.github.com/repos/django/asgi_ipc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/django/asgi_ipc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/django/asgi_ipc/git/refs{/sha}","trees_url":"https://api.github.com/repos/django/asgi_ipc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/django/asgi_ipc/statuses/{sha}","languages_url":"https://api.github.com/repos/django/asgi_ipc/languages","stargazers_url":"https://api.github.com/repos/django/asgi_ipc/stargazers","contributors_url":"https://api.github.com/repos/django/asgi_ipc/contributors","subscribers_url":"https://api.github.com/repos/django/asgi_ipc/subscribers","subscription_url":"https://api.github.com/repos/django/asgi_ipc/subscription","commits_url":"https://api.github.com/repos/django/asgi_ipc/commits{/sha}","git_commits_url":"https://api.github.com/repos/django/asgi_ipc/git/commits{/sha}","comments_url":"https://api.github.com/repos/django/asgi_ipc/comments{/number}","issue_comment_url":"https://api.github.com/repos/django/asgi_ipc/issues/comments{/number}","contents_url":"https://api.github.com/repos/django/asgi_ipc/contents/{+path}","compare_url":"https://api.github.com/repos/django/asgi_ipc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/django/asgi_ipc/merges","archive_url":"https://api.github.com/repos/django/asgi_ipc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/django/asgi_ipc/downloads","issues_url":"https://api.github.com/repos/django/asgi_ipc/issues{/number}","pulls_url":"https://api.github.com/repos/django/asgi_ipc/pulls{/number}","milestones_url":"https://api.github.com/repos/django/asgi_ipc/milestones{/number}","notifications_url":"https://api.github.com/repos/django/asgi_ipc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/django/asgi_ipc/labels{/name}","releases_url":"https://api.github.com/repos/django/asgi_ipc/releases{/id}","deployments_url":"https://api.github.com/repos/django/asgi_ipc/deployments","created_at":"2016-05-06T07:01:14Z","updated_at":"2017-07-16T06:50:31Z","pushed_at":"2017-08-27T23:01:39Z","git_url":"git://github.com/django/asgi_ipc.git","ssh_url":"git@github.com:django/asgi_ipc.git","clone_url":"https://github.com/django/asgi_ipc.git","svn_url":"https://github.com/django/asgi_ipc","homepage":null,"size":46,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/django/asgi_ipc/pulls/32"},"html":{"href":"https://github.com/django/asgi_ipc/pull/32"},"issue":{"href":"https://api.github.com/repos/django/asgi_ipc/issues/32"},"comments":{"href":"https://api.github.com/repos/django/asgi_ipc/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/django/asgi_ipc/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/django/asgi_ipc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/django/asgi_ipc/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/django/asgi_ipc/statuses/0c07510de95d4c34d5ede8891c4e7dc6d731e686"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"andrewgodwin","id":36182,"avatar_url":"https://avatars1.githubusercontent.com/u/36182?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewgodwin","html_url":"https://github.com/andrewgodwin","followers_url":"https://api.github.com/users/andrewgodwin/followers","following_url":"https://api.github.com/users/andrewgodwin/following{/other_user}","gists_url":"https://api.github.com/users/andrewgodwin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewgodwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewgodwin/subscriptions","organizations_url":"https://api.github.com/users/andrewgodwin/orgs","repos_url":"https://api.github.com/users/andrewgodwin/repos","events_url":"https://api.github.com/users/andrewgodwin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewgodwin/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"andrewgodwin"}}