{"action":"created","issue":{"url":"https://api.github.com/repos/drush-ops/drush/issues/3272","repository_url":"https://api.github.com/repos/drush-ops/drush","labels_url":"https://api.github.com/repos/drush-ops/drush/issues/3272/labels{/name}","comments_url":"https://api.github.com/repos/drush-ops/drush/issues/3272/comments","events_url":"https://api.github.com/repos/drush-ops/drush/issues/3272/events","html_url":"https://github.com/drush-ops/drush/pull/3272","id":284330758,"number":3272,"title":"WIP: Integrate composer/xdebug-handler","user":{"login":"webflo","id":123946,"avatar_url":"https://avatars1.githubusercontent.com/u/123946?v=4","gravatar_id":"","url":"https://api.github.com/users/webflo","html_url":"https://github.com/webflo","followers_url":"https://api.github.com/users/webflo/followers","following_url":"https://api.github.com/users/webflo/following{/other_user}","gists_url":"https://api.github.com/users/webflo/gists{/gist_id}","starred_url":"https://api.github.com/users/webflo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webflo/subscriptions","organizations_url":"https://api.github.com/users/webflo/orgs","repos_url":"https://api.github.com/users/webflo/repos","events_url":"https://api.github.com/users/webflo/events{/privacy}","received_events_url":"https://api.github.com/users/webflo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-12-23T22:45:47Z","updated_at":"2017-12-28T03:00:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/drush-ops/drush/pulls/3272","html_url":"https://github.com/drush-ops/drush/pull/3272","diff_url":"https://github.com/drush-ops/drush/pull/3272.diff","patch_url":"https://github.com/drush-ops/drush/pull/3272.patch"},"body":"[composer/xdebug-handler](https://github.com/composer/xdebug-handler) is a relatively new package. It has no stable release yet. The package provides the xdebug flag composer (COMPOSER_ALLOW_XEBUG) in a general fashion. It works seamlessly with symfony console.\r\n\r\nThis PR introduces the same feature for drush with DRUSH_ALLOW_XEBUG.\r\n\r\nSome non-scientific benchmarks on macOS with PHP 7.1\r\n\r\n ## Before (current default)\r\n\r\n```sh\r\n$ export DRUSH_ALLOW_XDEBUG=1 && time ~/Projects/drush9/drush cr\r\n [success] Cache rebuild complete.\r\n~/Projects/drush9/drush cr  3,72s user 0,40s system 86% cpu 4,773 total\r\n```\r\n\r\n**4,773s**\r\n\r\n\r\n## After (new default)\r\n\r\n```sh\r\n$ export DRUSH_ALLOW_XDEBUG=0 && time ~/Projects/drush9/drush cr\r\n [success] Cache rebuild complete.\r\n~/Projects/drush9/drush cr  1,12s user 0,35s system 70% cpu 2,091 total\r\n```\r\n\r\n**2,091s**\r\n\r\n---\r\n\r\nThis is a big BC break. I am not sure if this improves the DX in general, because i often want to use xdebug in conjunction with php-eval or while debugging update hooks. \r\n\r\nLets discuss :)"},"comment":{"url":"https://api.github.com/repos/drush-ops/drush/issues/comments/354219316","html_url":"https://github.com/drush-ops/drush/pull/3272#issuecomment-354219316","issue_url":"https://api.github.com/repos/drush-ops/drush/issues/3272","id":354219316,"user":{"login":"weitzman","id":7740,"avatar_url":"https://avatars0.githubusercontent.com/u/7740?v=4","gravatar_id":"","url":"https://api.github.com/users/weitzman","html_url":"https://github.com/weitzman","followers_url":"https://api.github.com/users/weitzman/followers","following_url":"https://api.github.com/users/weitzman/following{/other_user}","gists_url":"https://api.github.com/users/weitzman/gists{/gist_id}","starred_url":"https://api.github.com/users/weitzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weitzman/subscriptions","organizations_url":"https://api.github.com/users/weitzman/orgs","repos_url":"https://api.github.com/users/weitzman/repos","events_url":"https://api.github.com/users/weitzman/events{/privacy}","received_events_url":"https://api.github.com/users/weitzman/received_events","type":"User","site_admin":false},"created_at":"2017-12-28T03:00:05Z","updated_at":"2017-12-28T03:00:05Z","author_association":"OWNER","body":"Just tested this - got similarly impressive results. I think we need a stable release before we add this. Or else Composer users have minimum-stability hassles. here are some docs:\r\n\r\n\r\n> Drush, like Composer automatically disables Xdebug by default. This improves performance substantially. You may override this feature by setting an environment variable - `DRUSH_ALLOW_XDEBUG=1 drush [command]`. See https://github.com/drush-ops/drush/pull/3272.\r\n"}}
{"actor":{"display_login":"weitzman"}}