{"action":"created","issue":{"url":"https://api.github.com/repos/recastnavigation/recastnavigation/issues/278","repository_url":"https://api.github.com/repos/recastnavigation/recastnavigation","labels_url":"https://api.github.com/repos/recastnavigation/recastnavigation/issues/278/labels{/name}","comments_url":"https://api.github.com/repos/recastnavigation/recastnavigation/issues/278/comments","events_url":"https://api.github.com/repos/recastnavigation/recastnavigation/issues/278/events","html_url":"https://github.com/recastnavigation/recastnavigation/pull/278","id":243084191,"number":278,"title":"Added option to add rotated Box obstacle to TileCache.","user":{"login":"aymarfisherman","id":12876223,"avatar_url":"https://avatars2.githubusercontent.com/u/12876223?v=4","gravatar_id":"","url":"https://api.github.com/users/aymarfisherman","html_url":"https://github.com/aymarfisherman","followers_url":"https://api.github.com/users/aymarfisherman/followers","following_url":"https://api.github.com/users/aymarfisherman/following{/other_user}","gists_url":"https://api.github.com/users/aymarfisherman/gists{/gist_id}","starred_url":"https://api.github.com/users/aymarfisherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymarfisherman/subscriptions","organizations_url":"https://api.github.com/users/aymarfisherman/orgs","repos_url":"https://api.github.com/users/aymarfisherman/repos","events_url":"https://api.github.com/users/aymarfisherman/events{/privacy}","received_events_url":"https://api.github.com/users/aymarfisherman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-14T19:04:41Z","updated_at":"2017-07-21T14:23:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/recastnavigation/recastnavigation/pulls/278","html_url":"https://github.com/recastnavigation/recastnavigation/pull/278","diff_url":"https://github.com/recastnavigation/recastnavigation/pull/278.diff","patch_url":"https://github.com/recastnavigation/recastnavigation/pull/278.patch"},"body":"Added option to add rotated Box obstacle to TileCache (without messing with the existing box).\r\n\r\nVery useful when you have a obstacle with a big difference in x to z ratio and that could be rotated (not aligned), like a wall."},"comment":{"url":"https://api.github.com/repos/recastnavigation/recastnavigation/issues/comments/317014824","html_url":"https://github.com/recastnavigation/recastnavigation/pull/278#issuecomment-317014824","issue_url":"https://api.github.com/repos/recastnavigation/recastnavigation/issues/278","id":317014824,"user":{"login":"aymarfisherman","id":12876223,"avatar_url":"https://avatars2.githubusercontent.com/u/12876223?v=4","gravatar_id":"","url":"https://api.github.com/users/aymarfisherman","html_url":"https://github.com/aymarfisherman","followers_url":"https://api.github.com/users/aymarfisherman/followers","following_url":"https://api.github.com/users/aymarfisherman/following{/other_user}","gists_url":"https://api.github.com/users/aymarfisherman/gists{/gist_id}","starred_url":"https://api.github.com/users/aymarfisherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aymarfisherman/subscriptions","organizations_url":"https://api.github.com/users/aymarfisherman/orgs","repos_url":"https://api.github.com/users/aymarfisherman/repos","events_url":"https://api.github.com/users/aymarfisherman/events{/privacy}","received_events_url":"https://api.github.com/users/aymarfisherman/received_events","type":"User","site_admin":false},"created_at":"2017-07-21T14:23:49Z","updated_at":"2017-07-21T14:23:49Z","body":"I changed it to 'extents' and fixed the argument naming mismatch between .h and .cpp.\r\n\r\nThough I'd like to leave a suggestion: \r\n\r\nPlease, consider renaming all 'extents' to 'halfExtents', since 'extents' is misleading and ambiguous, especially when 'halfExtents' is  widely used in the industry. It's expected that people will pass 2x'halfExtents' if you ask for 'extents'.\r\n\r\nIt happened to me and maybe to other people: I thought 'extents' were the actual the full 'extents' of the box and I was wrongly using the library for years, passing 2.0*halfExtents everywhere it asked for 'extents'. I found out by accident (when implementing this PR) that the 'extents' variable actually meant 'halfExtents'.\r\n\r\nIf not for those reasons, you should still consider this change for shear disambiguation."}}
{"actor":{"display_login":"aymarfisherman"}}