{"action":"created","comment":{"url":"https://api.github.com/repos/pupil-labs/pupil/pulls/comments/153450145","pull_request_review_id":79454569,"id":153450145,"diff_hunk":"@@ -350,5 +366,4 @@ def deinit_ui(self):\n         if self.active:\n             self.stop()\n         if self._window:\n-            self.close_window()\n-        super().deinit_ui()","path":"pupil_src/shared_modules/calibration_routines/screen_marker_calibration.py","position":202,"original_position":202,"commit_id":"ef102ffbfcc2f43c3274fcce0f1c8e43225546e7","original_commit_id":"ef102ffbfcc2f43c3274fcce0f1c8e43225546e7","user":{"login":"mkassner","id":1433767,"avatar_url":"https://avatars0.githubusercontent.com/u/1433767?v=4","gravatar_id":"","url":"https://api.github.com/users/mkassner","html_url":"https://github.com/mkassner","followers_url":"https://api.github.com/users/mkassner/followers","following_url":"https://api.github.com/users/mkassner/following{/other_user}","gists_url":"https://api.github.com/users/mkassner/gists{/gist_id}","starred_url":"https://api.github.com/users/mkassner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkassner/subscriptions","organizations_url":"https://api.github.com/users/mkassner/orgs","repos_url":"https://api.github.com/users/mkassner/repos","events_url":"https://api.github.com/users/mkassner/events{/privacy}","received_events_url":"https://api.github.com/users/mkassner/received_events","type":"User","site_admin":false},"body":"check what needs to be done here.","created_at":"2017-11-28T10:26:50Z","updated_at":"2017-11-28T10:26:50Z","html_url":"https://github.com/pupil-labs/pupil/pull/961#discussion_r153450145","pull_request_url":"https://api.github.com/repos/pupil-labs/pupil/pulls/961","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/comments/153450145"},"html":{"href":"https://github.com/pupil-labs/pupil/pull/961#discussion_r153450145"},"pull_request":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/961"}}},"pull_request":{"url":"https://api.github.com/repos/pupil-labs/pupil/pulls/961","id":154860669,"html_url":"https://github.com/pupil-labs/pupil/pull/961","diff_url":"https://github.com/pupil-labs/pupil/pull/961.diff","patch_url":"https://github.com/pupil-labs/pupil/pull/961.patch","issue_url":"https://api.github.com/repos/pupil-labs/pupil/issues/961","number":961,"state":"open","locked":false,"title":"Improve the accuracy and efficiency of the marker detection","user":{"login":"ChingT","id":31063965,"avatar_url":"https://avatars3.githubusercontent.com/u/31063965?v=4","gravatar_id":"","url":"https://api.github.com/users/ChingT","html_url":"https://github.com/ChingT","followers_url":"https://api.github.com/users/ChingT/followers","following_url":"https://api.github.com/users/ChingT/following{/other_user}","gists_url":"https://api.github.com/users/ChingT/gists{/gist_id}","starred_url":"https://api.github.com/users/ChingT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChingT/subscriptions","organizations_url":"https://api.github.com/users/ChingT/orgs","repos_url":"https://api.github.com/users/ChingT/repos","events_url":"https://api.github.com/users/ChingT/events{/privacy}","received_events_url":"https://api.github.com/users/ChingT/received_events","type":"User","site_admin":false},"body":"- The [normal marker and stop marker](\r\nhttps://drive.google.com/a/pupil-labs.com/file/d/1IPLKOGF-A6k-hg3R7hkykjOEFBBsGxC3) are redesigned.\r\n- `CircleTracker` `update` function returns all detected markers and then the largest ellipse of them are specified.\r\n- If more than one markers are detected, there will be warning.","created_at":"2017-11-27T16:48:24Z","updated_at":"2017-11-28T10:26:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a2a3c92d491069e4347758d5aa30152bb07bca7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pupil-labs/pupil/pulls/961/commits","review_comments_url":"https://api.github.com/repos/pupil-labs/pupil/pulls/961/comments","review_comment_url":"https://api.github.com/repos/pupil-labs/pupil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pupil-labs/pupil/issues/961/comments","statuses_url":"https://api.github.com/repos/pupil-labs/pupil/statuses/ef102ffbfcc2f43c3274fcce0f1c8e43225546e7","head":{"label":"ChingT:marker_detection","ref":"marker_detection","sha":"ef102ffbfcc2f43c3274fcce0f1c8e43225546e7","user":{"login":"ChingT","id":31063965,"avatar_url":"https://avatars3.githubusercontent.com/u/31063965?v=4","gravatar_id":"","url":"https://api.github.com/users/ChingT","html_url":"https://github.com/ChingT","followers_url":"https://api.github.com/users/ChingT/followers","following_url":"https://api.github.com/users/ChingT/following{/other_user}","gists_url":"https://api.github.com/users/ChingT/gists{/gist_id}","starred_url":"https://api.github.com/users/ChingT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChingT/subscriptions","organizations_url":"https://api.github.com/users/ChingT/orgs","repos_url":"https://api.github.com/users/ChingT/repos","events_url":"https://api.github.com/users/ChingT/events{/privacy}","received_events_url":"https://api.github.com/users/ChingT/received_events","type":"User","site_admin":false},"repo":{"id":111800784,"name":"pupil","full_name":"ChingT/pupil","owner":{"login":"ChingT","id":31063965,"avatar_url":"https://avatars3.githubusercontent.com/u/31063965?v=4","gravatar_id":"","url":"https://api.github.com/users/ChingT","html_url":"https://github.com/ChingT","followers_url":"https://api.github.com/users/ChingT/followers","following_url":"https://api.github.com/users/ChingT/following{/other_user}","gists_url":"https://api.github.com/users/ChingT/gists{/gist_id}","starred_url":"https://api.github.com/users/ChingT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChingT/subscriptions","organizations_url":"https://api.github.com/users/ChingT/orgs","repos_url":"https://api.github.com/users/ChingT/repos","events_url":"https://api.github.com/users/ChingT/events{/privacy}","received_events_url":"https://api.github.com/users/ChingT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChingT/pupil","description":"Open source eye tracking ","fork":true,"url":"https://api.github.com/repos/ChingT/pupil","forks_url":"https://api.github.com/repos/ChingT/pupil/forks","keys_url":"https://api.github.com/repos/ChingT/pupil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChingT/pupil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChingT/pupil/teams","hooks_url":"https://api.github.com/repos/ChingT/pupil/hooks","issue_events_url":"https://api.github.com/repos/ChingT/pupil/issues/events{/number}","events_url":"https://api.github.com/repos/ChingT/pupil/events","assignees_url":"https://api.github.com/repos/ChingT/pupil/assignees{/user}","branches_url":"https://api.github.com/repos/ChingT/pupil/branches{/branch}","tags_url":"https://api.github.com/repos/ChingT/pupil/tags","blobs_url":"https://api.github.com/repos/ChingT/pupil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChingT/pupil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChingT/pupil/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChingT/pupil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChingT/pupil/statuses/{sha}","languages_url":"https://api.github.com/repos/ChingT/pupil/languages","stargazers_url":"https://api.github.com/repos/ChingT/pupil/stargazers","contributors_url":"https://api.github.com/repos/ChingT/pupil/contributors","subscribers_url":"https://api.github.com/repos/ChingT/pupil/subscribers","subscription_url":"https://api.github.com/repos/ChingT/pupil/subscription","commits_url":"https://api.github.com/repos/ChingT/pupil/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChingT/pupil/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChingT/pupil/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChingT/pupil/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChingT/pupil/contents/{+path}","compare_url":"https://api.github.com/repos/ChingT/pupil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChingT/pupil/merges","archive_url":"https://api.github.com/repos/ChingT/pupil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChingT/pupil/downloads","issues_url":"https://api.github.com/repos/ChingT/pupil/issues{/number}","pulls_url":"https://api.github.com/repos/ChingT/pupil/pulls{/number}","milestones_url":"https://api.github.com/repos/ChingT/pupil/milestones{/number}","notifications_url":"https://api.github.com/repos/ChingT/pupil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChingT/pupil/labels{/name}","releases_url":"https://api.github.com/repos/ChingT/pupil/releases{/id}","deployments_url":"https://api.github.com/repos/ChingT/pupil/deployments","created_at":"2017-11-23T11:21:24Z","updated_at":"2017-11-23T11:21:26Z","pushed_at":"2017-11-27T16:19:01Z","git_url":"git://github.com/ChingT/pupil.git","ssh_url":"git@github.com:ChingT/pupil.git","clone_url":"https://github.com/ChingT/pupil.git","svn_url":"https://github.com/ChingT/pupil","homepage":"https://pupil-labs.com","size":13345,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pupil-labs:master","ref":"master","sha":"2f188057adedf716aa7a14278d0a8e1d9168a78e","user":{"login":"pupil-labs","id":5248635,"avatar_url":"https://avatars1.githubusercontent.com/u/5248635?v=4","gravatar_id":"","url":"https://api.github.com/users/pupil-labs","html_url":"https://github.com/pupil-labs","followers_url":"https://api.github.com/users/pupil-labs/followers","following_url":"https://api.github.com/users/pupil-labs/following{/other_user}","gists_url":"https://api.github.com/users/pupil-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/pupil-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pupil-labs/subscriptions","organizations_url":"https://api.github.com/users/pupil-labs/orgs","repos_url":"https://api.github.com/users/pupil-labs/repos","events_url":"https://api.github.com/users/pupil-labs/events{/privacy}","received_events_url":"https://api.github.com/users/pupil-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":12173486,"name":"pupil","full_name":"pupil-labs/pupil","owner":{"login":"pupil-labs","id":5248635,"avatar_url":"https://avatars1.githubusercontent.com/u/5248635?v=4","gravatar_id":"","url":"https://api.github.com/users/pupil-labs","html_url":"https://github.com/pupil-labs","followers_url":"https://api.github.com/users/pupil-labs/followers","following_url":"https://api.github.com/users/pupil-labs/following{/other_user}","gists_url":"https://api.github.com/users/pupil-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/pupil-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pupil-labs/subscriptions","organizations_url":"https://api.github.com/users/pupil-labs/orgs","repos_url":"https://api.github.com/users/pupil-labs/repos","events_url":"https://api.github.com/users/pupil-labs/events{/privacy}","received_events_url":"https://api.github.com/users/pupil-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pupil-labs/pupil","description":"Open source eye tracking ","fork":false,"url":"https://api.github.com/repos/pupil-labs/pupil","forks_url":"https://api.github.com/repos/pupil-labs/pupil/forks","keys_url":"https://api.github.com/repos/pupil-labs/pupil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pupil-labs/pupil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pupil-labs/pupil/teams","hooks_url":"https://api.github.com/repos/pupil-labs/pupil/hooks","issue_events_url":"https://api.github.com/repos/pupil-labs/pupil/issues/events{/number}","events_url":"https://api.github.com/repos/pupil-labs/pupil/events","assignees_url":"https://api.github.com/repos/pupil-labs/pupil/assignees{/user}","branches_url":"https://api.github.com/repos/pupil-labs/pupil/branches{/branch}","tags_url":"https://api.github.com/repos/pupil-labs/pupil/tags","blobs_url":"https://api.github.com/repos/pupil-labs/pupil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pupil-labs/pupil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pupil-labs/pupil/git/refs{/sha}","trees_url":"https://api.github.com/repos/pupil-labs/pupil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pupil-labs/pupil/statuses/{sha}","languages_url":"https://api.github.com/repos/pupil-labs/pupil/languages","stargazers_url":"https://api.github.com/repos/pupil-labs/pupil/stargazers","contributors_url":"https://api.github.com/repos/pupil-labs/pupil/contributors","subscribers_url":"https://api.github.com/repos/pupil-labs/pupil/subscribers","subscription_url":"https://api.github.com/repos/pupil-labs/pupil/subscription","commits_url":"https://api.github.com/repos/pupil-labs/pupil/commits{/sha}","git_commits_url":"https://api.github.com/repos/pupil-labs/pupil/git/commits{/sha}","comments_url":"https://api.github.com/repos/pupil-labs/pupil/comments{/number}","issue_comment_url":"https://api.github.com/repos/pupil-labs/pupil/issues/comments{/number}","contents_url":"https://api.github.com/repos/pupil-labs/pupil/contents/{+path}","compare_url":"https://api.github.com/repos/pupil-labs/pupil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pupil-labs/pupil/merges","archive_url":"https://api.github.com/repos/pupil-labs/pupil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pupil-labs/pupil/downloads","issues_url":"https://api.github.com/repos/pupil-labs/pupil/issues{/number}","pulls_url":"https://api.github.com/repos/pupil-labs/pupil/pulls{/number}","milestones_url":"https://api.github.com/repos/pupil-labs/pupil/milestones{/number}","notifications_url":"https://api.github.com/repos/pupil-labs/pupil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pupil-labs/pupil/labels{/name}","releases_url":"https://api.github.com/repos/pupil-labs/pupil/releases{/id}","deployments_url":"https://api.github.com/repos/pupil-labs/pupil/deployments","created_at":"2013-08-17T04:40:25Z","updated_at":"2017-11-26T12:57:05Z","pushed_at":"2017-11-27T16:48:25Z","git_url":"git://github.com/pupil-labs/pupil.git","ssh_url":"git@github.com:pupil-labs/pupil.git","clone_url":"https://github.com/pupil-labs/pupil.git","svn_url":"https://github.com/pupil-labs/pupil","homepage":"https://pupil-labs.com","size":13299,"stargazers_count":430,"watchers_count":430,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":305,"mirror_url":null,"archived":false,"open_issues_count":42,"forks":305,"open_issues":42,"watchers":430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/961"},"html":{"href":"https://github.com/pupil-labs/pupil/pull/961"},"issue":{"href":"https://api.github.com/repos/pupil-labs/pupil/issues/961"},"comments":{"href":"https://api.github.com/repos/pupil-labs/pupil/issues/961/comments"},"review_comments":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/961/comments"},"review_comment":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pupil-labs/pupil/pulls/961/commits"},"statuses":{"href":"https://api.github.com/repos/pupil-labs/pupil/statuses/ef102ffbfcc2f43c3274fcce0f1c8e43225546e7"}},"author_association":"NONE"}}
{"actor":{"display_login":"mkassner"}}