{"action":"created","comment":{"url":"https://api.github.com/repos/xoreos/xoreos/pulls/comments/134123302","pull_request_review_id":57379548,"id":134123302,"diff_hunk":"@@ -0,0 +1,190 @@\n+/* xoreos - A reimplementation of BioWare's Aurora engine\n+ *\n+ * xoreos is the legal property of its developers, whose names\n+ * can be found in the AUTHORS file distributed with this source\n+ * distribution.\n+ *\n+ * xoreos is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU General Public License\n+ * as published by the Free Software Foundation; either version 3\n+ * of the License, or (at your option) any later version.\n+ *\n+ * xoreos is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with xoreos. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+\n+/**\n+ * @file\n+ * A quad for generating borders\n+ */\n+\n+#include <cfloat>\n+\n+#include \"borderquad.h\"\n+#include \"textureman.h\"\n+\n+namespace Graphics {\n+\n+namespace Aurora {\n+\n+BorderQuad::BorderQuad(Common::UString edge, Common::UString corner, float x, float y, float w, float h)\n+\t\t: Renderable(kRenderableTypeGUIFront),\n+\t\t  _edgeWidth(0), _edgeHeight(0), _cornerWidth(0), _cornerHeight(0),\n+\t\t  _x(x), _y(y), _w(w), _h(h) {\n+\t_edge = TextureMan.get(edge);\n+\t_corner = TextureMan.get(corner);\n+\n+\t_cornerWidth = _corner.getTexture().getWidth();\n+\t_cornerHeight = _corner.getTexture().getHeight();\n+\t_edgeWidth = _edge.getTexture().getWidth();\n+\t_edgeHeight = _edge.getTexture().getHeight();\n+\n+\t_distance = -FLT_MAX;\n+\n+\tassert(!_corner.empty());\n+\tassert(!_edge.empty());\n+}\n+\n+void BorderQuad::setPosition(float x, float y, float UNUSED(z)) {\n+\tlockFrameIfVisible();\n+\n+\t/**","path":"src/graphics/aurora/borderquad.cpp","position":56,"original_position":56,"commit_id":"598d194dba3d850d17f0b88f7247b9cdf4764d77","original_commit_id":"055181076fec133e88ff4ed68d9eba4ff712142a","user":{"login":"DrMcCoy","id":156130,"avatar_url":"https://avatars3.githubusercontent.com/u/156130?v=4","gravatar_id":"","url":"https://api.github.com/users/DrMcCoy","html_url":"https://github.com/DrMcCoy","followers_url":"https://api.github.com/users/DrMcCoy/followers","following_url":"https://api.github.com/users/DrMcCoy/following{/other_user}","gists_url":"https://api.github.com/users/DrMcCoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DrMcCoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrMcCoy/subscriptions","organizations_url":"https://api.github.com/users/DrMcCoy/orgs","repos_url":"https://api.github.com/users/DrMcCoy/repos","events_url":"https://api.github.com/users/DrMcCoy/events{/privacy}","received_events_url":"https://api.github.com/users/DrMcCoy/received_events","type":"User","site_admin":false},"body":"That shouldn't be a Doxygen comment. I.e. remove the second `*`.","created_at":"2017-08-20T18:44:00Z","updated_at":"2017-08-20T18:50:02Z","html_url":"https://github.com/xoreos/xoreos/pull/149#discussion_r134123302","pull_request_url":"https://api.github.com/repos/xoreos/xoreos/pulls/149","_links":{"self":{"href":"https://api.github.com/repos/xoreos/xoreos/pulls/comments/134123302"},"html":{"href":"https://github.com/xoreos/xoreos/pull/149#discussion_r134123302"},"pull_request":{"href":"https://api.github.com/repos/xoreos/xoreos/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/xoreos/xoreos/pulls/149","id":131911762,"html_url":"https://github.com/xoreos/xoreos/pull/149","diff_url":"https://github.com/xoreos/xoreos/pull/149.diff","patch_url":"https://github.com/xoreos/xoreos/pull/149.patch","issue_url":"https://api.github.com/repos/xoreos/xoreos/issues/149","number":149,"state":"open","locked":false,"title":"KOTOR: Widget borders","user":{"login":"Nostritius","id":17826813,"avatar_url":"https://avatars3.githubusercontent.com/u/17826813?v=4","gravatar_id":"","url":"https://api.github.com/users/Nostritius","html_url":"https://github.com/Nostritius","followers_url":"https://api.github.com/users/Nostritius/followers","following_url":"https://api.github.com/users/Nostritius/following{/other_user}","gists_url":"https://api.github.com/users/Nostritius/gists{/gist_id}","starred_url":"https://api.github.com/users/Nostritius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nostritius/subscriptions","organizations_url":"https://api.github.com/users/Nostritius/orgs","repos_url":"https://api.github.com/users/Nostritius/repos","events_url":"https://api.github.com/users/Nostritius/events{/privacy}","received_events_url":"https://api.github.com/users/Nostritius/received_events","type":"User","site_admin":false},"body":"I have investigated the missing borders around some KotOR widgets and found out, that they are defined in the .gui file. I implemented a new class for them named BorderQuad and integrated it into the KotORWidget class.","created_at":"2017-07-22T20:27:54Z","updated_at":"2017-08-20T18:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0856099e2d03f53be5793d2a762dad6dc77e0307","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/xoreos/xoreos/pulls/149/commits","review_comments_url":"https://api.github.com/repos/xoreos/xoreos/pulls/149/comments","review_comment_url":"https://api.github.com/repos/xoreos/xoreos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xoreos/xoreos/issues/149/comments","statuses_url":"https://api.github.com/repos/xoreos/xoreos/statuses/598d194dba3d850d17f0b88f7247b9cdf4764d77","head":{"label":"Nostritius:kotor_borders","ref":"kotor_borders","sha":"598d194dba3d850d17f0b88f7247b9cdf4764d77","user":{"login":"Nostritius","id":17826813,"avatar_url":"https://avatars3.githubusercontent.com/u/17826813?v=4","gravatar_id":"","url":"https://api.github.com/users/Nostritius","html_url":"https://github.com/Nostritius","followers_url":"https://api.github.com/users/Nostritius/followers","following_url":"https://api.github.com/users/Nostritius/following{/other_user}","gists_url":"https://api.github.com/users/Nostritius/gists{/gist_id}","starred_url":"https://api.github.com/users/Nostritius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nostritius/subscriptions","organizations_url":"https://api.github.com/users/Nostritius/orgs","repos_url":"https://api.github.com/users/Nostritius/repos","events_url":"https://api.github.com/users/Nostritius/events{/privacy}","received_events_url":"https://api.github.com/users/Nostritius/received_events","type":"User","site_admin":false},"repo":{"id":90493789,"name":"xoreos","full_name":"Nostritius/xoreos","owner":{"login":"Nostritius","id":17826813,"avatar_url":"https://avatars3.githubusercontent.com/u/17826813?v=4","gravatar_id":"","url":"https://api.github.com/users/Nostritius","html_url":"https://github.com/Nostritius","followers_url":"https://api.github.com/users/Nostritius/followers","following_url":"https://api.github.com/users/Nostritius/following{/other_user}","gists_url":"https://api.github.com/users/Nostritius/gists{/gist_id}","starred_url":"https://api.github.com/users/Nostritius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nostritius/subscriptions","organizations_url":"https://api.github.com/users/Nostritius/orgs","repos_url":"https://api.github.com/users/Nostritius/repos","events_url":"https://api.github.com/users/Nostritius/events{/privacy}","received_events_url":"https://api.github.com/users/Nostritius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nostritius/xoreos","description":"A reimplementation of BioWare's Aurora engine (and derivatives). Pre-pre-alpha :P","fork":true,"url":"https://api.github.com/repos/Nostritius/xoreos","forks_url":"https://api.github.com/repos/Nostritius/xoreos/forks","keys_url":"https://api.github.com/repos/Nostritius/xoreos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nostritius/xoreos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nostritius/xoreos/teams","hooks_url":"https://api.github.com/repos/Nostritius/xoreos/hooks","issue_events_url":"https://api.github.com/repos/Nostritius/xoreos/issues/events{/number}","events_url":"https://api.github.com/repos/Nostritius/xoreos/events","assignees_url":"https://api.github.com/repos/Nostritius/xoreos/assignees{/user}","branches_url":"https://api.github.com/repos/Nostritius/xoreos/branches{/branch}","tags_url":"https://api.github.com/repos/Nostritius/xoreos/tags","blobs_url":"https://api.github.com/repos/Nostritius/xoreos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nostritius/xoreos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nostritius/xoreos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nostritius/xoreos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nostritius/xoreos/statuses/{sha}","languages_url":"https://api.github.com/repos/Nostritius/xoreos/languages","stargazers_url":"https://api.github.com/repos/Nostritius/xoreos/stargazers","contributors_url":"https://api.github.com/repos/Nostritius/xoreos/contributors","subscribers_url":"https://api.github.com/repos/Nostritius/xoreos/subscribers","subscription_url":"https://api.github.com/repos/Nostritius/xoreos/subscription","commits_url":"https://api.github.com/repos/Nostritius/xoreos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nostritius/xoreos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nostritius/xoreos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nostritius/xoreos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nostritius/xoreos/contents/{+path}","compare_url":"https://api.github.com/repos/Nostritius/xoreos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nostritius/xoreos/merges","archive_url":"https://api.github.com/repos/Nostritius/xoreos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nostritius/xoreos/downloads","issues_url":"https://api.github.com/repos/Nostritius/xoreos/issues{/number}","pulls_url":"https://api.github.com/repos/Nostritius/xoreos/pulls{/number}","milestones_url":"https://api.github.com/repos/Nostritius/xoreos/milestones{/number}","notifications_url":"https://api.github.com/repos/Nostritius/xoreos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nostritius/xoreos/labels{/name}","releases_url":"https://api.github.com/repos/Nostritius/xoreos/releases{/id}","deployments_url":"https://api.github.com/repos/Nostritius/xoreos/deployments","created_at":"2017-05-06T22:04:26Z","updated_at":"2017-05-06T22:04:32Z","pushed_at":"2017-08-04T10:56:30Z","git_url":"git://github.com/Nostritius/xoreos.git","ssh_url":"git@github.com:Nostritius/xoreos.git","clone_url":"https://github.com/Nostritius/xoreos.git","svn_url":"https://github.com/Nostritius/xoreos","homepage":"https://xoreos.org/","size":23090,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xoreos:master","ref":"master","sha":"10a7842bd0e0c15557b3b1ec1bb947c446fbf935","user":{"login":"xoreos","id":4641510,"avatar_url":"https://avatars2.githubusercontent.com/u/4641510?v=4","gravatar_id":"","url":"https://api.github.com/users/xoreos","html_url":"https://github.com/xoreos","followers_url":"https://api.github.com/users/xoreos/followers","following_url":"https://api.github.com/users/xoreos/following{/other_user}","gists_url":"https://api.github.com/users/xoreos/gists{/gist_id}","starred_url":"https://api.github.com/users/xoreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoreos/subscriptions","organizations_url":"https://api.github.com/users/xoreos/orgs","repos_url":"https://api.github.com/users/xoreos/repos","events_url":"https://api.github.com/users/xoreos/events{/privacy}","received_events_url":"https://api.github.com/users/xoreos/received_events","type":"Organization","site_admin":false},"repo":{"id":827722,"name":"xoreos","full_name":"xoreos/xoreos","owner":{"login":"xoreos","id":4641510,"avatar_url":"https://avatars2.githubusercontent.com/u/4641510?v=4","gravatar_id":"","url":"https://api.github.com/users/xoreos","html_url":"https://github.com/xoreos","followers_url":"https://api.github.com/users/xoreos/followers","following_url":"https://api.github.com/users/xoreos/following{/other_user}","gists_url":"https://api.github.com/users/xoreos/gists{/gist_id}","starred_url":"https://api.github.com/users/xoreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoreos/subscriptions","organizations_url":"https://api.github.com/users/xoreos/orgs","repos_url":"https://api.github.com/users/xoreos/repos","events_url":"https://api.github.com/users/xoreos/events{/privacy}","received_events_url":"https://api.github.com/users/xoreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xoreos/xoreos","description":"A reimplementation of BioWare's Aurora engine (and derivatives). Pre-pre-alpha :P","fork":false,"url":"https://api.github.com/repos/xoreos/xoreos","forks_url":"https://api.github.com/repos/xoreos/xoreos/forks","keys_url":"https://api.github.com/repos/xoreos/xoreos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xoreos/xoreos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xoreos/xoreos/teams","hooks_url":"https://api.github.com/repos/xoreos/xoreos/hooks","issue_events_url":"https://api.github.com/repos/xoreos/xoreos/issues/events{/number}","events_url":"https://api.github.com/repos/xoreos/xoreos/events","assignees_url":"https://api.github.com/repos/xoreos/xoreos/assignees{/user}","branches_url":"https://api.github.com/repos/xoreos/xoreos/branches{/branch}","tags_url":"https://api.github.com/repos/xoreos/xoreos/tags","blobs_url":"https://api.github.com/repos/xoreos/xoreos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xoreos/xoreos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xoreos/xoreos/git/refs{/sha}","trees_url":"https://api.github.com/repos/xoreos/xoreos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xoreos/xoreos/statuses/{sha}","languages_url":"https://api.github.com/repos/xoreos/xoreos/languages","stargazers_url":"https://api.github.com/repos/xoreos/xoreos/stargazers","contributors_url":"https://api.github.com/repos/xoreos/xoreos/contributors","subscribers_url":"https://api.github.com/repos/xoreos/xoreos/subscribers","subscription_url":"https://api.github.com/repos/xoreos/xoreos/subscription","commits_url":"https://api.github.com/repos/xoreos/xoreos/commits{/sha}","git_commits_url":"https://api.github.com/repos/xoreos/xoreos/git/commits{/sha}","comments_url":"https://api.github.com/repos/xoreos/xoreos/comments{/number}","issue_comment_url":"https://api.github.com/repos/xoreos/xoreos/issues/comments{/number}","contents_url":"https://api.github.com/repos/xoreos/xoreos/contents/{+path}","compare_url":"https://api.github.com/repos/xoreos/xoreos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xoreos/xoreos/merges","archive_url":"https://api.github.com/repos/xoreos/xoreos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xoreos/xoreos/downloads","issues_url":"https://api.github.com/repos/xoreos/xoreos/issues{/number}","pulls_url":"https://api.github.com/repos/xoreos/xoreos/pulls{/number}","milestones_url":"https://api.github.com/repos/xoreos/xoreos/milestones{/number}","notifications_url":"https://api.github.com/repos/xoreos/xoreos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xoreos/xoreos/labels{/name}","releases_url":"https://api.github.com/repos/xoreos/xoreos/releases{/id}","deployments_url":"https://api.github.com/repos/xoreos/xoreos/deployments","created_at":"2010-08-10T00:39:01Z","updated_at":"2017-08-20T12:02:33Z","pushed_at":"2017-08-20T13:46:14Z","git_url":"git://github.com/xoreos/xoreos.git","ssh_url":"git@github.com:xoreos/xoreos.git","clone_url":"https://github.com/xoreos/xoreos.git","svn_url":"https://github.com/xoreos/xoreos","homepage":"https://xoreos.org/","size":23115,"stargazers_count":442,"watchers_count":442,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"open_issues_count":13,"forks":82,"open_issues":13,"watchers":442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xoreos/xoreos/pulls/149"},"html":{"href":"https://github.com/xoreos/xoreos/pull/149"},"issue":{"href":"https://api.github.com/repos/xoreos/xoreos/issues/149"},"comments":{"href":"https://api.github.com/repos/xoreos/xoreos/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/xoreos/xoreos/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/xoreos/xoreos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xoreos/xoreos/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/xoreos/xoreos/statuses/598d194dba3d850d17f0b88f7247b9cdf4764d77"}}}}
{"actor":{"display_login":"DrMcCoy"}}