{"action":"created","issue":{"url":"https://api.github.com/repos/ajjahn/puppet-dns/issues/210","repository_url":"https://api.github.com/repos/ajjahn/puppet-dns","labels_url":"https://api.github.com/repos/ajjahn/puppet-dns/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/ajjahn/puppet-dns/issues/210/comments","events_url":"https://api.github.com/repos/ajjahn/puppet-dns/issues/210/events","html_url":"https://github.com/ajjahn/puppet-dns/pull/210","id":212033581,"number":210,"title":"Add `forwarders` to `dns::zone`; deprecate `allow_forwarder`","user":{"login":"jearls","id":9756898,"avatar_url":"https://avatars2.githubusercontent.com/u/9756898?v=3","gravatar_id":"","url":"https://api.github.com/users/jearls","html_url":"https://github.com/jearls","followers_url":"https://api.github.com/users/jearls/followers","following_url":"https://api.github.com/users/jearls/following{/other_user}","gists_url":"https://api.github.com/users/jearls/gists{/gist_id}","starred_url":"https://api.github.com/users/jearls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jearls/subscriptions","organizations_url":"https://api.github.com/users/jearls/orgs","repos_url":"https://api.github.com/users/jearls/repos","events_url":"https://api.github.com/users/jearls/events{/privacy}","received_events_url":"https://api.github.com/users/jearls/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-06T06:20:29Z","updated_at":"2017-03-06T06:21:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ajjahn/puppet-dns/pulls/210","html_url":"https://github.com/ajjahn/puppet-dns/pull/210","diff_url":"https://github.com/ajjahn/puppet-dns/pull/210.diff","patch_url":"https://github.com/ajjahn/puppet-dns/pull/210.patch"},"body":"This change adds the `forwarders` parameter to `dns::zone`, deprecating\r\n`allow_forwarder` in favor of `forwarders`.  `forwarders` extends\r\n`allow_forwarder` by allowing both an *empty* forwarders list as well as\r\nan *undefined* forwarders list (the former meaning that the zone does not\r\nforward, while the latter leaves the global forwarders option in place):\r\n\r\n> [*forwarders*]\r\n> An array of IP addresses and optional port numbers to which queries\r\n> for this zone will be forwarded (based on the *forward_policy*\r\n> setting).  If the optional port number is included, it must be\r\n> separated from the IP address by the word `port` - for example,\r\n> `[ '192.168.100.102 port 1234' ]`.  If passed an empty array or the\r\n> boolean value `false`, the zone will not forward.  If passed `true`\r\n> or left undefined, the zone will use the global forwarders defined\r\n> in `dns::server::options`.\r\n> *Note* - this parameter deprecates and should be used in place of\r\n> the *allow_forwarder* parameter.  If both parameters are passed in,\r\n> only *forwarders* will take effect.\r\n\r\nThis addresses Issue #204"},"comment":{"url":"https://api.github.com/repos/ajjahn/puppet-dns/issues/comments/284312374","html_url":"https://github.com/ajjahn/puppet-dns/pull/210#issuecomment-284312374","issue_url":"https://api.github.com/repos/ajjahn/puppet-dns/issues/210","id":284312374,"user":{"login":"jearls","id":9756898,"avatar_url":"https://avatars2.githubusercontent.com/u/9756898?v=3","gravatar_id":"","url":"https://api.github.com/users/jearls","html_url":"https://github.com/jearls","followers_url":"https://api.github.com/users/jearls/followers","following_url":"https://api.github.com/users/jearls/following{/other_user}","gists_url":"https://api.github.com/users/jearls/gists{/gist_id}","starred_url":"https://api.github.com/users/jearls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jearls/subscriptions","organizations_url":"https://api.github.com/users/jearls/orgs","repos_url":"https://api.github.com/users/jearls/repos","events_url":"https://api.github.com/users/jearls/events{/privacy}","received_events_url":"https://api.github.com/users/jearls/received_events","type":"User","site_admin":false},"created_at":"2017-03-06T06:21:17Z","updated_at":"2017-03-06T06:21:17Z","body":"Note - as this PR deprecates a parameter, SemVer requires a minor version bump if/when this is published."}}
{"actor":{"display_login":"jearls"}}