{"action":"created","issue":{"url":"https://api.github.com/repos/digitalocean/go-openvswitch/issues/17","repository_url":"https://api.github.com/repos/digitalocean/go-openvswitch","labels_url":"https://api.github.com/repos/digitalocean/go-openvswitch/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/digitalocean/go-openvswitch/issues/17/comments","events_url":"https://api.github.com/repos/digitalocean/go-openvswitch/issues/17/events","html_url":"https://github.com/digitalocean/go-openvswitch/pull/17","id":279862778,"number":17,"title":" ovsdb: add ClientStats, fix callback leak","user":{"login":"mdlayher","id":1926905,"avatar_url":"https://avatars3.githubusercontent.com/u/1926905?v=4","gravatar_id":"","url":"https://api.github.com/users/mdlayher","html_url":"https://github.com/mdlayher","followers_url":"https://api.github.com/users/mdlayher/followers","following_url":"https://api.github.com/users/mdlayher/following{/other_user}","gists_url":"https://api.github.com/users/mdlayher/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlayher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlayher/subscriptions","organizations_url":"https://api.github.com/users/mdlayher/orgs","repos_url":"https://api.github.com/users/mdlayher/repos","events_url":"https://api.github.com/users/mdlayher/events{/privacy}","received_events_url":"https://api.github.com/users/mdlayher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-06T18:42:39Z","updated_at":"2017-12-06T21:26:39Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/digitalocean/go-openvswitch/pulls/17","html_url":"https://github.com/digitalocean/go-openvswitch/pull/17","diff_url":"https://github.com/digitalocean/go-openvswitch/pull/17.diff","patch_url":"https://github.com/digitalocean/go-openvswitch/pull/17.patch"},"body":"Could be used as a basis for future metrics and such.\r\n\r\nThe test shows that the callback leak is now fixed.  I didn't add a new method because it seemed easy enough to do it all in the rpc method.  If I had made a new one, I would have had to release the callback mutex in doCallback, and then re-acquire it to delete the finished callback, which seems inherently race condition prone."},"comment":{"url":"https://api.github.com/repos/digitalocean/go-openvswitch/issues/comments/349779945","html_url":"https://github.com/digitalocean/go-openvswitch/pull/17#issuecomment-349779945","issue_url":"https://api.github.com/repos/digitalocean/go-openvswitch/issues/17","id":349779945,"user":{"login":"mdlayher","id":1926905,"avatar_url":"https://avatars3.githubusercontent.com/u/1926905?v=4","gravatar_id":"","url":"https://api.github.com/users/mdlayher","html_url":"https://github.com/mdlayher","followers_url":"https://api.github.com/users/mdlayher/followers","following_url":"https://api.github.com/users/mdlayher/following{/other_user}","gists_url":"https://api.github.com/users/mdlayher/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlayher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlayher/subscriptions","organizations_url":"https://api.github.com/users/mdlayher/orgs","repos_url":"https://api.github.com/users/mdlayher/repos","events_url":"https://api.github.com/users/mdlayher/events{/privacy}","received_events_url":"https://api.github.com/users/mdlayher/received_events","type":"User","site_admin":false},"created_at":"2017-12-06T21:26:39Z","updated_at":"2017-12-06T21:26:39Z","author_association":"OWNER","body":"Just pushed a new commit that ensures the callback is cleaned up by the consumer.  The comment explains the rationale, and I think this approach is better and safer, and can be iterated on."}}
{"actor":{"display_login":"mdlayher"}}