{"action":"created","comment":{"url":"https://api.github.com/repos/guacml/guacml/pulls/comments/118884633","pull_request_review_id":40717932,"id":118884633,"diff_hunk":"@@ -18,8 +18,15 @@ def train(self, x, y, **kwargs):\n     def predict(self, x):\n         raise NotImplementedError()\n \n+    def feature_importances(self, x):\n+        raise NotImplementedError()\n+\n     @staticmethod\n     def to_int(value):\n         if value is None:\n             return None\n-        return int(value)\n\\ No newline at end of file\n+        return int(value)\n+\n+    @staticmethod\n+    def pos_int(value):\n+        return max(int(value), 0)","path":"guacml/models/base_model.py","position":17,"original_position":17,"commit_id":"f34a7cdbdf3baf9a5094922c576239242aabcb3f","original_commit_id":"f34a7cdbdf3baf9a5094922c576239242aabcb3f","user":{"login":"dan-tee","id":5971952,"avatar_url":"https://avatars3.githubusercontent.com/u/5971952?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-tee","html_url":"https://github.com/dan-tee","followers_url":"https://api.github.com/users/dan-tee/followers","following_url":"https://api.github.com/users/dan-tee/following{/other_user}","gists_url":"https://api.github.com/users/dan-tee/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-tee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-tee/subscriptions","organizations_url":"https://api.github.com/users/dan-tee/orgs","repos_url":"https://api.github.com/users/dan-tee/repos","events_url":"https://api.github.com/users/dan-tee/events{/privacy}","received_events_url":"https://api.github.com/users/dan-tee/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-05-29T08:00:41Z","updated_at":"2017-05-29T08:00:41Z","html_url":"https://github.com/guacml/guacml/pull/5#discussion_r118884633","pull_request_url":"https://api.github.com/repos/guacml/guacml/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/guacml/guacml/pulls/comments/118884633"},"html":{"href":"https://github.com/guacml/guacml/pull/5#discussion_r118884633"},"pull_request":{"href":"https://api.github.com/repos/guacml/guacml/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/guacml/guacml/pulls/5","id":122810866,"html_url":"https://github.com/guacml/guacml/pull/5","diff_url":"https://github.com/guacml/guacml/pull/5.diff","patch_url":"https://github.com/guacml/guacml/pull/5.patch","issue_url":"https://api.github.com/repos/guacml/guacml/issues/5","number":5,"state":"open","locked":false,"title":"Feature selection","user":{"login":"dan-tee","id":5971952,"avatar_url":"https://avatars3.githubusercontent.com/u/5971952?v=3","gravatar_id":"","url":"https://api.github.com/users/dan-tee","html_url":"https://github.com/dan-tee","followers_url":"https://api.github.com/users/dan-tee/followers","following_url":"https://api.github.com/users/dan-tee/following{/other_user}","gists_url":"https://api.github.com/users/dan-tee/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-tee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-tee/subscriptions","organizations_url":"https://api.github.com/users/dan-tee/orgs","repos_url":"https://api.github.com/users/dan-tee/repos","events_url":"https://api.github.com/users/dan-tee/events{/privacy}","received_events_url":"https://api.github.com/users/dan-tee/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-28T22:07:38Z","updated_at":"2017-05-29T08:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc5b0e0e4aa9a08d0ae1b3ea41b725742bd77bcd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/guacml/guacml/pulls/5/commits","review_comments_url":"https://api.github.com/repos/guacml/guacml/pulls/5/comments","review_comment_url":"https://api.github.com/repos/guacml/guacml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guacml/guacml/issues/5/comments","statuses_url":"https://api.github.com/repos/guacml/guacml/statuses/f34a7cdbdf3baf9a5094922c576239242aabcb3f","head":{"label":"guacml:feature-selection","ref":"feature-selection","sha":"f34a7cdbdf3baf9a5094922c576239242aabcb3f","user":{"login":"guacml","id":28510160,"avatar_url":"https://avatars3.githubusercontent.com/u/28510160?v=3","gravatar_id":"","url":"https://api.github.com/users/guacml","html_url":"https://github.com/guacml","followers_url":"https://api.github.com/users/guacml/followers","following_url":"https://api.github.com/users/guacml/following{/other_user}","gists_url":"https://api.github.com/users/guacml/gists{/gist_id}","starred_url":"https://api.github.com/users/guacml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guacml/subscriptions","organizations_url":"https://api.github.com/users/guacml/orgs","repos_url":"https://api.github.com/users/guacml/repos","events_url":"https://api.github.com/users/guacml/events{/privacy}","received_events_url":"https://api.github.com/users/guacml/received_events","type":"Organization","site_admin":false},"repo":{"id":90547153,"name":"guacml","full_name":"guacml/guacml","owner":{"login":"guacml","id":28510160,"avatar_url":"https://avatars3.githubusercontent.com/u/28510160?v=3","gravatar_id":"","url":"https://api.github.com/users/guacml","html_url":"https://github.com/guacml","followers_url":"https://api.github.com/users/guacml/followers","following_url":"https://api.github.com/users/guacml/following{/other_user}","gists_url":"https://api.github.com/users/guacml/gists{/gist_id}","starred_url":"https://api.github.com/users/guacml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guacml/subscriptions","organizations_url":"https://api.github.com/users/guacml/orgs","repos_url":"https://api.github.com/users/guacml/repos","events_url":"https://api.github.com/users/guacml/events{/privacy}","received_events_url":"https://api.github.com/users/guacml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guacml/guacml","description":"Guac ML","fork":false,"url":"https://api.github.com/repos/guacml/guacml","forks_url":"https://api.github.com/repos/guacml/guacml/forks","keys_url":"https://api.github.com/repos/guacml/guacml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guacml/guacml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guacml/guacml/teams","hooks_url":"https://api.github.com/repos/guacml/guacml/hooks","issue_events_url":"https://api.github.com/repos/guacml/guacml/issues/events{/number}","events_url":"https://api.github.com/repos/guacml/guacml/events","assignees_url":"https://api.github.com/repos/guacml/guacml/assignees{/user}","branches_url":"https://api.github.com/repos/guacml/guacml/branches{/branch}","tags_url":"https://api.github.com/repos/guacml/guacml/tags","blobs_url":"https://api.github.com/repos/guacml/guacml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guacml/guacml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guacml/guacml/git/refs{/sha}","trees_url":"https://api.github.com/repos/guacml/guacml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guacml/guacml/statuses/{sha}","languages_url":"https://api.github.com/repos/guacml/guacml/languages","stargazers_url":"https://api.github.com/repos/guacml/guacml/stargazers","contributors_url":"https://api.github.com/repos/guacml/guacml/contributors","subscribers_url":"https://api.github.com/repos/guacml/guacml/subscribers","subscription_url":"https://api.github.com/repos/guacml/guacml/subscription","commits_url":"https://api.github.com/repos/guacml/guacml/commits{/sha}","git_commits_url":"https://api.github.com/repos/guacml/guacml/git/commits{/sha}","comments_url":"https://api.github.com/repos/guacml/guacml/comments{/number}","issue_comment_url":"https://api.github.com/repos/guacml/guacml/issues/comments{/number}","contents_url":"https://api.github.com/repos/guacml/guacml/contents/{+path}","compare_url":"https://api.github.com/repos/guacml/guacml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guacml/guacml/merges","archive_url":"https://api.github.com/repos/guacml/guacml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guacml/guacml/downloads","issues_url":"https://api.github.com/repos/guacml/guacml/issues{/number}","pulls_url":"https://api.github.com/repos/guacml/guacml/pulls{/number}","milestones_url":"https://api.github.com/repos/guacml/guacml/milestones{/number}","notifications_url":"https://api.github.com/repos/guacml/guacml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guacml/guacml/labels{/name}","releases_url":"https://api.github.com/repos/guacml/guacml/releases{/id}","deployments_url":"https://api.github.com/repos/guacml/guacml/deployments","created_at":"2017-05-07T16:44:07Z","updated_at":"2017-05-07T21:03:42Z","pushed_at":"2017-05-28T22:07:39Z","git_url":"git://github.com/guacml/guacml.git","ssh_url":"git@github.com:guacml/guacml.git","clone_url":"https://github.com/guacml/guacml.git","svn_url":"https://github.com/guacml/guacml","homepage":null,"size":640,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"guacml:master","ref":"master","sha":"f4ca477996317a5e7a68f4cbf9a31c01369d02a4","user":{"login":"guacml","id":28510160,"avatar_url":"https://avatars3.githubusercontent.com/u/28510160?v=3","gravatar_id":"","url":"https://api.github.com/users/guacml","html_url":"https://github.com/guacml","followers_url":"https://api.github.com/users/guacml/followers","following_url":"https://api.github.com/users/guacml/following{/other_user}","gists_url":"https://api.github.com/users/guacml/gists{/gist_id}","starred_url":"https://api.github.com/users/guacml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guacml/subscriptions","organizations_url":"https://api.github.com/users/guacml/orgs","repos_url":"https://api.github.com/users/guacml/repos","events_url":"https://api.github.com/users/guacml/events{/privacy}","received_events_url":"https://api.github.com/users/guacml/received_events","type":"Organization","site_admin":false},"repo":{"id":90547153,"name":"guacml","full_name":"guacml/guacml","owner":{"login":"guacml","id":28510160,"avatar_url":"https://avatars3.githubusercontent.com/u/28510160?v=3","gravatar_id":"","url":"https://api.github.com/users/guacml","html_url":"https://github.com/guacml","followers_url":"https://api.github.com/users/guacml/followers","following_url":"https://api.github.com/users/guacml/following{/other_user}","gists_url":"https://api.github.com/users/guacml/gists{/gist_id}","starred_url":"https://api.github.com/users/guacml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guacml/subscriptions","organizations_url":"https://api.github.com/users/guacml/orgs","repos_url":"https://api.github.com/users/guacml/repos","events_url":"https://api.github.com/users/guacml/events{/privacy}","received_events_url":"https://api.github.com/users/guacml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guacml/guacml","description":"Guac ML","fork":false,"url":"https://api.github.com/repos/guacml/guacml","forks_url":"https://api.github.com/repos/guacml/guacml/forks","keys_url":"https://api.github.com/repos/guacml/guacml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guacml/guacml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guacml/guacml/teams","hooks_url":"https://api.github.com/repos/guacml/guacml/hooks","issue_events_url":"https://api.github.com/repos/guacml/guacml/issues/events{/number}","events_url":"https://api.github.com/repos/guacml/guacml/events","assignees_url":"https://api.github.com/repos/guacml/guacml/assignees{/user}","branches_url":"https://api.github.com/repos/guacml/guacml/branches{/branch}","tags_url":"https://api.github.com/repos/guacml/guacml/tags","blobs_url":"https://api.github.com/repos/guacml/guacml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guacml/guacml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guacml/guacml/git/refs{/sha}","trees_url":"https://api.github.com/repos/guacml/guacml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guacml/guacml/statuses/{sha}","languages_url":"https://api.github.com/repos/guacml/guacml/languages","stargazers_url":"https://api.github.com/repos/guacml/guacml/stargazers","contributors_url":"https://api.github.com/repos/guacml/guacml/contributors","subscribers_url":"https://api.github.com/repos/guacml/guacml/subscribers","subscription_url":"https://api.github.com/repos/guacml/guacml/subscription","commits_url":"https://api.github.com/repos/guacml/guacml/commits{/sha}","git_commits_url":"https://api.github.com/repos/guacml/guacml/git/commits{/sha}","comments_url":"https://api.github.com/repos/guacml/guacml/comments{/number}","issue_comment_url":"https://api.github.com/repos/guacml/guacml/issues/comments{/number}","contents_url":"https://api.github.com/repos/guacml/guacml/contents/{+path}","compare_url":"https://api.github.com/repos/guacml/guacml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guacml/guacml/merges","archive_url":"https://api.github.com/repos/guacml/guacml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guacml/guacml/downloads","issues_url":"https://api.github.com/repos/guacml/guacml/issues{/number}","pulls_url":"https://api.github.com/repos/guacml/guacml/pulls{/number}","milestones_url":"https://api.github.com/repos/guacml/guacml/milestones{/number}","notifications_url":"https://api.github.com/repos/guacml/guacml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guacml/guacml/labels{/name}","releases_url":"https://api.github.com/repos/guacml/guacml/releases{/id}","deployments_url":"https://api.github.com/repos/guacml/guacml/deployments","created_at":"2017-05-07T16:44:07Z","updated_at":"2017-05-07T21:03:42Z","pushed_at":"2017-05-28T22:07:39Z","git_url":"git://github.com/guacml/guacml.git","ssh_url":"git@github.com:guacml/guacml.git","clone_url":"https://github.com/guacml/guacml.git","svn_url":"https://github.com/guacml/guacml","homepage":null,"size":640,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":5,"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guacml/guacml/pulls/5"},"html":{"href":"https://github.com/guacml/guacml/pull/5"},"issue":{"href":"https://api.github.com/repos/guacml/guacml/issues/5"},"comments":{"href":"https://api.github.com/repos/guacml/guacml/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/guacml/guacml/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/guacml/guacml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guacml/guacml/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/guacml/guacml/statuses/f34a7cdbdf3baf9a5094922c576239242aabcb3f"}}}}
{"actor":{"display_login":"dan-tee"}}