{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/22469","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/22469/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/22469/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/22469/events","html_url":"https://github.com/symfony/symfony/pull/22469","id":222721915,"number":22469,"title":"WIP: [Form] Fix FormFactory guesses with property_path option.","user":{"login":"jlamur","id":7054317,"avatar_url":"https://avatars2.githubusercontent.com/u/7054317?v=3","gravatar_id":"","url":"https://api.github.com/users/jlamur","html_url":"https://github.com/jlamur","followers_url":"https://api.github.com/users/jlamur/followers","following_url":"https://api.github.com/users/jlamur/following{/other_user}","gists_url":"https://api.github.com/users/jlamur/gists{/gist_id}","starred_url":"https://api.github.com/users/jlamur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlamur/subscriptions","organizations_url":"https://api.github.com/users/jlamur/orgs","repos_url":"https://api.github.com/users/jlamur/repos","events_url":"https://api.github.com/users/jlamur/events{/privacy}","received_events_url":"https://api.github.com/users/jlamur/received_events","type":"User","site_admin":false},"labels":[{"id":100079,"url":"https://api.github.com/repos/symfony/symfony/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":99594,"url":"https://api.github.com/repos/symfony/symfony/labels/Form","name":"Form","color":"DDDDDD","default":false},{"id":237003792,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-04-19T12:30:24Z","updated_at":"2017-04-19T15:03:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/22469","html_url":"https://github.com/symfony/symfony/pull/22469","diff_url":"https://github.com/symfony/symfony/pull/22469.diff","patch_url":"https://github.com/symfony/symfony/pull/22469.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 2.7\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | none\r\n| License       | MIT\r\n| Doc PR        | none\r\n\r\nWhen the property_path option is set on the FormBuilder\r\nthe type, max length, required flag and pattern are\r\nnow guessed based on the property_path option.\r\n\r\nThey were guessed with the property variable before this\r\nfix."},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/295301617","html_url":"https://github.com/symfony/symfony/pull/22469#issuecomment-295301617","issue_url":"https://api.github.com/repos/symfony/symfony/issues/22469","id":295301617,"user":{"login":"sstok","id":904790,"avatar_url":"https://avatars2.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"created_at":"2017-04-19T15:03:40Z","updated_at":"2017-04-19T15:03:40Z","body":"Yes, I guess (no pun) that's the only way this can work, it shouldn't be a BC break as this has actually never worked.\r\n\r\nCurrent a property_path like `address.zipCode` is used as-is, and each guesser receives property name \"address.zipCode\" as-is, which unless they know how to handle cannot work as valid property name.\r\n\r\nTo change this overall, there is however one minor problem, only a guesser like Doctrine (or a PropertyInfo guesser) will know the class of property. So this will require an implementation for each guesser.\r\n\r\nIn practice a property (path) should be resolved to an actual class and property name, so `address.zipCode` resolves the class of `address` and uses the property `zipCode` of that child class.\r\n\r\nUnless someone else has a better idea? 😄"}}
{"actor":{"display_login":"sstok"}}