{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/194","repository_url":"https://api.github.com/repos/kubernetes/kube-state-metrics","labels_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/194/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/194/comments","events_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/194/events","html_url":"https://github.com/kubernetes/kube-state-metrics/pull/194","id":247006438,"number":194,"title":"prometheus client: disable metric consistency","user":{"login":"brancz","id":4546722,"avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"labels":[{"id":485759093,"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-08-01T09:20:23Z","updated_at":"2017-08-08T13:37:36Z","closed_at":"2017-08-01T09:57:26Z","pull_request":{"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/pulls/194","html_url":"https://github.com/kubernetes/kube-state-metrics/pull/194","diff_url":"https://github.com/kubernetes/kube-state-metrics/pull/194.diff","patch_url":"https://github.com/kubernetes/kube-state-metrics/pull/194.patch"},"body":"This reverts the client_golang library back to the state that we need and was previously released with `v0.5.0`. #185 updated the deps and I missed to note that we were overriding this manual patch.\r\n\r\nFixes #192\r\n\r\n@fabxc @andyxning @matthiasr \r\n\r\n@cofyc as you reported this, could you quickly try this out and report whether it fixes the behavior you were seeing?\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kube-state-metrics/194)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/comments/320958266","html_url":"https://github.com/kubernetes/kube-state-metrics/pull/194#issuecomment-320958266","issue_url":"https://api.github.com/repos/kubernetes/kube-state-metrics/issues/194","id":320958266,"user":{"login":"brancz","id":4546722,"avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"created_at":"2017-08-08T13:37:36Z","updated_at":"2017-08-08T13:37:36Z","body":"I understand your concern, but realistically, if you redeploy an application and the target ends up being the same, but because your new version adds a new label to a metric, Prometheus will reject it? Seems extreme. This is the same use case. As the change of the label-set can only happen when you \"re-deploy\" a Kubernetes object.\r\n\r\nTo be clear, when we did this initially, @fabxc and I discussed this use case with @brian-brazil and concluded that in this use case it's valid to do this. I would argue having the \"normal\" registry in Prometheus' client_golang to be more relaxed about this behavior and the \"pedantic\" registry to perform this check. Usually I agree this kind of behavior/usage is most likely incorrect, but I can see especially exporters requiring this."}}
{"actor":{"display_login":"brancz"}}