{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/145186756","pull_request_review_id":69949466,"id":145186756,"diff_hunk":"@@ -15,12 +15,15 @@ server.on('listening', common.mustCall(() => {\n   const client = h2.connect(`http://localhost:${server.address().port}`);\n \n   const req = client.request({ ':path': '/' });\n+  // make sure that destroy is called twice\n+  req._destroy = common.mustCall(req._destroy.bind(req), 2);","path":"test/parallel/test-http2-client-rststream-before-connect.js","position":5,"original_position":5,"commit_id":"810edb81d62aa0fd0cf607663afee5fca7219848","original_commit_id":"810edb81d62aa0fd0cf607663afee5fca7219848","user":{"login":"apapirovski","id":20809,"avatar_url":"https://avatars2.githubusercontent.com/u/20809?v=4","gravatar_id":"","url":"https://api.github.com/users/apapirovski","html_url":"https://github.com/apapirovski","followers_url":"https://api.github.com/users/apapirovski/followers","following_url":"https://api.github.com/users/apapirovski/following{/other_user}","gists_url":"https://api.github.com/users/apapirovski/gists{/gist_id}","starred_url":"https://api.github.com/users/apapirovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapirovski/subscriptions","organizations_url":"https://api.github.com/users/apapirovski/orgs","repos_url":"https://api.github.com/users/apapirovski/repos","events_url":"https://api.github.com/users/apapirovski/events{/privacy}","received_events_url":"https://api.github.com/users/apapirovski/received_events","type":"User","site_admin":false},"body":"I believe @mcollina is right. I think what's happening is that this line is accounting for the 2 triggers of _destroy:\r\n\r\nhttps://github.com/nodejs/node/blob/ff747e3fe8fc960bb6cd04185167bd6376940998/lib/internal/http2/core.js#L1494-L1498\r\n\r\nThe reason that it's different than before is because the declaration was moved before `client.rstStream()` instead of after. I think that `stream.destroy()` isn't even necessary and it should just be the empty `return;`.\r\n\r\nping @jasnell — any thoughts re: whether that `stream.destroy()` serves an actual purpose?","created_at":"2017-10-17T16:41:17Z","updated_at":"2017-10-17T16:41:17Z","html_url":"https://github.com/nodejs/node/pull/16217#discussion_r145186756","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/16217","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/145186756"},"html":{"href":"https://github.com/nodejs/node/pull/16217#discussion_r145186756"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/16217"}},"in_reply_to_id":145053867},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16217","id":146642335,"html_url":"https://github.com/nodejs/node/pull/16217","diff_url":"https://github.com/nodejs/node/pull/16217.diff","patch_url":"https://github.com/nodejs/node/pull/16217.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/16217","number":16217,"state":"open","locked":false,"title":"test: http2 rstStream duplicate call","user":{"login":"trivikr","id":16024985,"avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"body":"This commit fixes an issue with rstStream() which checked incorrect value of rst. It also adds a test case for this fix https://github.com/nodejs/node/blob/411695e1d26565c7498992be19731bbea6b6aa58/lib/internal/http2/core.js#L928-L933\r\n\r\nRefs: https://github.com/nodejs/node/issues/14985\r\n\r\n##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\ntest, http2\r\n","created_at":"2017-10-15T09:50:24Z","updated_at":"2017-10-17T16:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"932a435aeee89b5ec5c00a6cadbe45f5b81894d7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/16217/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/16217/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16217/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/810edb81d62aa0fd0cf607663afee5fca7219848","head":{"label":"trivikr:test-http2-client-rststream","ref":"test-http2-client-rststream","sha":"810edb81d62aa0fd0cf607663afee5fca7219848","user":{"login":"trivikr","id":16024985,"avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"repo":{"id":104234761,"name":"node","full_name":"trivikr/node","owner":{"login":"trivikr","id":16024985,"avatar_url":"https://avatars2.githubusercontent.com/u/16024985?v=4","gravatar_id":"","url":"https://api.github.com/users/trivikr","html_url":"https://github.com/trivikr","followers_url":"https://api.github.com/users/trivikr/followers","following_url":"https://api.github.com/users/trivikr/following{/other_user}","gists_url":"https://api.github.com/users/trivikr/gists{/gist_id}","starred_url":"https://api.github.com/users/trivikr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trivikr/subscriptions","organizations_url":"https://api.github.com/users/trivikr/orgs","repos_url":"https://api.github.com/users/trivikr/repos","events_url":"https://api.github.com/users/trivikr/events{/privacy}","received_events_url":"https://api.github.com/users/trivikr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trivikr/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/trivikr/node","forks_url":"https://api.github.com/repos/trivikr/node/forks","keys_url":"https://api.github.com/repos/trivikr/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trivikr/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trivikr/node/teams","hooks_url":"https://api.github.com/repos/trivikr/node/hooks","issue_events_url":"https://api.github.com/repos/trivikr/node/issues/events{/number}","events_url":"https://api.github.com/repos/trivikr/node/events","assignees_url":"https://api.github.com/repos/trivikr/node/assignees{/user}","branches_url":"https://api.github.com/repos/trivikr/node/branches{/branch}","tags_url":"https://api.github.com/repos/trivikr/node/tags","blobs_url":"https://api.github.com/repos/trivikr/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trivikr/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trivikr/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/trivikr/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trivikr/node/statuses/{sha}","languages_url":"https://api.github.com/repos/trivikr/node/languages","stargazers_url":"https://api.github.com/repos/trivikr/node/stargazers","contributors_url":"https://api.github.com/repos/trivikr/node/contributors","subscribers_url":"https://api.github.com/repos/trivikr/node/subscribers","subscription_url":"https://api.github.com/repos/trivikr/node/subscription","commits_url":"https://api.github.com/repos/trivikr/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/trivikr/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/trivikr/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/trivikr/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/trivikr/node/contents/{+path}","compare_url":"https://api.github.com/repos/trivikr/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trivikr/node/merges","archive_url":"https://api.github.com/repos/trivikr/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trivikr/node/downloads","issues_url":"https://api.github.com/repos/trivikr/node/issues{/number}","pulls_url":"https://api.github.com/repos/trivikr/node/pulls{/number}","milestones_url":"https://api.github.com/repos/trivikr/node/milestones{/number}","notifications_url":"https://api.github.com/repos/trivikr/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trivikr/node/labels{/name}","releases_url":"https://api.github.com/repos/trivikr/node/releases{/id}","deployments_url":"https://api.github.com/repos/trivikr/node/deployments","created_at":"2017-09-20T15:38:29Z","updated_at":"2017-09-20T15:39:05Z","pushed_at":"2017-10-17T16:22:32Z","git_url":"git://github.com/trivikr/node.git","ssh_url":"git@github.com:trivikr/node.git","clone_url":"https://github.com/trivikr/node.git","svn_url":"https://github.com/trivikr/node","homepage":"https://nodejs.org","size":321396,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"42479130a93b83f9422071fd4c1ad6c678ad6588","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-10-17T16:32:30Z","pushed_at":"2017-10-17T16:28:12Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":322254,"stargazers_count":40821,"watchers_count":40821,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8446,"mirror_url":null,"open_issues_count":781,"forks":8446,"open_issues":781,"watchers":40821,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/16217"},"html":{"href":"https://github.com/nodejs/node/pull/16217"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/16217"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/16217/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/16217/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/16217/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/810edb81d62aa0fd0cf607663afee5fca7219848"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apapirovski"}}