{"action":"closed","number":14709,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/14709","id":121658991,"html_url":"https://github.com/hashicorp/terraform/pull/14709","diff_url":"https://github.com/hashicorp/terraform/pull/14709.diff","patch_url":"https://github.com/hashicorp/terraform/pull/14709.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/14709","number":14709,"state":"closed","locked":false,"title":"provider/vcd: Add port mapping to DNAT rule","user":{"login":"ewypych","id":25039172,"avatar_url":"https://avatars3.githubusercontent.com/u/25039172?v=4","gravatar_id":"","url":"https://api.github.com/users/ewypych","html_url":"https://github.com/ewypych","followers_url":"https://api.github.com/users/ewypych/followers","following_url":"https://api.github.com/users/ewypych/following{/other_user}","gists_url":"https://api.github.com/users/ewypych/gists{/gist_id}","starred_url":"https://api.github.com/users/ewypych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewypych/subscriptions","organizations_url":"https://api.github.com/users/ewypych/orgs","repos_url":"https://api.github.com/users/ewypych/repos","events_url":"https://api.github.com/users/ewypych/events{/privacy}","received_events_url":"https://api.github.com/users/ewypych/received_events","type":"User","site_admin":false},"body":"Hello!\r\nProvider vDC allows to create a DNAT rule on the Edge Gateway, but now one can make only one to one port mapping. As a service provider employee, I know that people often use only one public IP address with many local subnets.  For example:\r\n\r\n```\r\nexternal_ip:3040 <-> 10.0.0.10:80\r\nexternal_ip:3041 <-> 10.0.0.11:80\r\nexternal_ip:3042 <-> 10.0.1.10:80\r\n```\r\nvCloud Air API bindings for Golang allows to create a full port mapping, so I made some changes and replaced one to one mapping with the full DNAT port mapping. Even if someone wants to create one to one mapping, it is still possible - one just needs to type two variables instead of one, but with the same value.\r\n\r\nI think it's a lot more useful with a full support for DNAT port mapping. :smile: ","created_at":"2017-05-21T12:29:41Z","updated_at":"2017-11-01T19:29:31Z","closed_at":"2017-11-01T19:29:31Z","merged_at":null,"merge_commit_sha":"368d31bb66599da10033990cbf1954f1193d7926","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform/pulls/14709/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform/pulls/14709/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/14709/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/46f09a4c0454efb9cd3f3d139ff8d04aaa02e183","head":{"label":"ewypych:p-vcd-dnat-mapping","ref":"p-vcd-dnat-mapping","sha":"46f09a4c0454efb9cd3f3d139ff8d04aaa02e183","user":{"login":"ewypych","id":25039172,"avatar_url":"https://avatars3.githubusercontent.com/u/25039172?v=4","gravatar_id":"","url":"https://api.github.com/users/ewypych","html_url":"https://github.com/ewypych","followers_url":"https://api.github.com/users/ewypych/followers","following_url":"https://api.github.com/users/ewypych/following{/other_user}","gists_url":"https://api.github.com/users/ewypych/gists{/gist_id}","starred_url":"https://api.github.com/users/ewypych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewypych/subscriptions","organizations_url":"https://api.github.com/users/ewypych/orgs","repos_url":"https://api.github.com/users/ewypych/repos","events_url":"https://api.github.com/users/ewypych/events{/privacy}","received_events_url":"https://api.github.com/users/ewypych/received_events","type":"User","site_admin":false},"repo":{"id":82403276,"name":"terraform","full_name":"ewypych/terraform","owner":{"login":"ewypych","id":25039172,"avatar_url":"https://avatars3.githubusercontent.com/u/25039172?v=4","gravatar_id":"","url":"https://api.github.com/users/ewypych","html_url":"https://github.com/ewypych","followers_url":"https://api.github.com/users/ewypych/followers","following_url":"https://api.github.com/users/ewypych/following{/other_user}","gists_url":"https://api.github.com/users/ewypych/gists{/gist_id}","starred_url":"https://api.github.com/users/ewypych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewypych/subscriptions","organizations_url":"https://api.github.com/users/ewypych/orgs","repos_url":"https://api.github.com/users/ewypych/repos","events_url":"https://api.github.com/users/ewypych/events{/privacy}","received_events_url":"https://api.github.com/users/ewypych/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ewypych/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":true,"url":"https://api.github.com/repos/ewypych/terraform","forks_url":"https://api.github.com/repos/ewypych/terraform/forks","keys_url":"https://api.github.com/repos/ewypych/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewypych/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewypych/terraform/teams","hooks_url":"https://api.github.com/repos/ewypych/terraform/hooks","issue_events_url":"https://api.github.com/repos/ewypych/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/ewypych/terraform/events","assignees_url":"https://api.github.com/repos/ewypych/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/ewypych/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/ewypych/terraform/tags","blobs_url":"https://api.github.com/repos/ewypych/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewypych/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewypych/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewypych/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewypych/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/ewypych/terraform/languages","stargazers_url":"https://api.github.com/repos/ewypych/terraform/stargazers","contributors_url":"https://api.github.com/repos/ewypych/terraform/contributors","subscribers_url":"https://api.github.com/repos/ewypych/terraform/subscribers","subscription_url":"https://api.github.com/repos/ewypych/terraform/subscription","commits_url":"https://api.github.com/repos/ewypych/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewypych/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewypych/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewypych/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewypych/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/ewypych/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewypych/terraform/merges","archive_url":"https://api.github.com/repos/ewypych/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewypych/terraform/downloads","issues_url":"https://api.github.com/repos/ewypych/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/ewypych/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/ewypych/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/ewypych/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewypych/terraform/labels{/name}","releases_url":"https://api.github.com/repos/ewypych/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/ewypych/terraform/deployments","created_at":"2017-02-18T17:21:02Z","updated_at":"2017-02-18T17:21:16Z","pushed_at":"2017-05-24T15:13:31Z","git_url":"git://github.com/ewypych/terraform.git","ssh_url":"git@github.com:ewypych/terraform.git","clone_url":"https://github.com/ewypych/terraform.git","svn_url":"https://github.com/ewypych/terraform","homepage":"https://www.terraform.io/","size":101642,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"8e6a0845c18a1502d1bfd7bcd5814c842c988120","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform/deployments","created_at":"2014-03-13T22:25:48Z","updated_at":"2017-11-01T17:28:10Z","pushed_at":"2017-11-01T17:48:36Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"https://www.terraform.io/","size":120809,"stargazers_count":9941,"watchers_count":9941,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3529,"mirror_url":null,"archived":false,"open_issues_count":1014,"forks":3529,"open_issues":1014,"watchers":9941,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/14709"},"html":{"href":"https://github.com/hashicorp/terraform/pull/14709"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/14709"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/14709/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/14709/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/14709/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform/statuses/46f09a4c0454efb9cd3f3d139ff8d04aaa02e183"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":31,"deletions":18,"changed_files":2}}
{"actor":{"display_login":"apparentlymart"}}