{"action":"opened","number":123,"pull_request":{"url":"https://api.github.com/repos/lihaoyi/utest/pulls/123","id":142486712,"html_url":"https://github.com/lihaoyi/utest/pull/123","diff_url":"https://github.com/lihaoyi/utest/pull/123.diff","patch_url":"https://github.com/lihaoyi/utest/pull/123.patch","issue_url":"https://api.github.com/repos/lihaoyi/utest/issues/123","number":123,"state":"open","locked":false,"title":"adds support for before/after each","user":{"login":"d1egoaz","id":950087,"avatar_url":"https://avatars3.githubusercontent.com/u/950087?v=4","gravatar_id":"","url":"https://api.github.com/users/d1egoaz","html_url":"https://github.com/d1egoaz","followers_url":"https://api.github.com/users/d1egoaz/followers","following_url":"https://api.github.com/users/d1egoaz/following{/other_user}","gists_url":"https://api.github.com/users/d1egoaz/gists{/gist_id}","starred_url":"https://api.github.com/users/d1egoaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d1egoaz/subscriptions","organizations_url":"https://api.github.com/users/d1egoaz/orgs","repos_url":"https://api.github.com/users/d1egoaz/repos","events_url":"https://api.github.com/users/d1egoaz/events{/privacy}","received_events_url":"https://api.github.com/users/d1egoaz/received_events","type":"User","site_admin":false},"body":"I wanted to check with you @lihaoyi before continue adding support to this.\r\nThis adds support for before/after each.\r\n\r\nI'm just wondering if you would like to have the methods returning a `Unit` or a `Future[Unit]`, current approach is similar to scalatest.\r\n\r\nalso I wasn't sure to add the path parameters to the current methods, as this methods seems to be more agnostic about what test is being called.\r\n\r\nJust let me know what do you think.\r\n\r\n```\r\n-------------------------------- Running Tests --------------------------------\r\nSetting up CustomFramework\r\nx before: 0\r\nx after: 1\r\n+ test.utest.examples.BeforeAfterEachTest.test1 46ms  \r\nx before: 1\r\nx after: 0\r\n+ test.utest.examples.BeforeAfterEachTest.test2.inner 1ms  \r\nx before: 0\r\nx after: 42\r\n+ test.utest.examples.BeforeAfterEachTest.test3 0ms  \r\nTearing down CustomFramework\r\n```","created_at":"2017-09-22T02:50:14Z","updated_at":"2017-09-22T02:50:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lihaoyi/utest/pulls/123/commits","review_comments_url":"https://api.github.com/repos/lihaoyi/utest/pulls/123/comments","review_comment_url":"https://api.github.com/repos/lihaoyi/utest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lihaoyi/utest/issues/123/comments","statuses_url":"https://api.github.com/repos/lihaoyi/utest/statuses/232cd803be958dc97ca629cea8eead82051b7f94","head":{"label":"d1egoaz:before_after_each_support","ref":"before_after_each_support","sha":"232cd803be958dc97ca629cea8eead82051b7f94","user":{"login":"d1egoaz","id":950087,"avatar_url":"https://avatars3.githubusercontent.com/u/950087?v=4","gravatar_id":"","url":"https://api.github.com/users/d1egoaz","html_url":"https://github.com/d1egoaz","followers_url":"https://api.github.com/users/d1egoaz/followers","following_url":"https://api.github.com/users/d1egoaz/following{/other_user}","gists_url":"https://api.github.com/users/d1egoaz/gists{/gist_id}","starred_url":"https://api.github.com/users/d1egoaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d1egoaz/subscriptions","organizations_url":"https://api.github.com/users/d1egoaz/orgs","repos_url":"https://api.github.com/users/d1egoaz/repos","events_url":"https://api.github.com/users/d1egoaz/events{/privacy}","received_events_url":"https://api.github.com/users/d1egoaz/received_events","type":"User","site_admin":false},"repo":{"id":104422785,"name":"utest","full_name":"d1egoaz/utest","owner":{"login":"d1egoaz","id":950087,"avatar_url":"https://avatars3.githubusercontent.com/u/950087?v=4","gravatar_id":"","url":"https://api.github.com/users/d1egoaz","html_url":"https://github.com/d1egoaz","followers_url":"https://api.github.com/users/d1egoaz/followers","following_url":"https://api.github.com/users/d1egoaz/following{/other_user}","gists_url":"https://api.github.com/users/d1egoaz/gists{/gist_id}","starred_url":"https://api.github.com/users/d1egoaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d1egoaz/subscriptions","organizations_url":"https://api.github.com/users/d1egoaz/orgs","repos_url":"https://api.github.com/users/d1egoaz/repos","events_url":"https://api.github.com/users/d1egoaz/events{/privacy}","received_events_url":"https://api.github.com/users/d1egoaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d1egoaz/utest","description":"A tiny, portable testing library for Scala","fork":true,"url":"https://api.github.com/repos/d1egoaz/utest","forks_url":"https://api.github.com/repos/d1egoaz/utest/forks","keys_url":"https://api.github.com/repos/d1egoaz/utest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d1egoaz/utest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d1egoaz/utest/teams","hooks_url":"https://api.github.com/repos/d1egoaz/utest/hooks","issue_events_url":"https://api.github.com/repos/d1egoaz/utest/issues/events{/number}","events_url":"https://api.github.com/repos/d1egoaz/utest/events","assignees_url":"https://api.github.com/repos/d1egoaz/utest/assignees{/user}","branches_url":"https://api.github.com/repos/d1egoaz/utest/branches{/branch}","tags_url":"https://api.github.com/repos/d1egoaz/utest/tags","blobs_url":"https://api.github.com/repos/d1egoaz/utest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d1egoaz/utest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d1egoaz/utest/git/refs{/sha}","trees_url":"https://api.github.com/repos/d1egoaz/utest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d1egoaz/utest/statuses/{sha}","languages_url":"https://api.github.com/repos/d1egoaz/utest/languages","stargazers_url":"https://api.github.com/repos/d1egoaz/utest/stargazers","contributors_url":"https://api.github.com/repos/d1egoaz/utest/contributors","subscribers_url":"https://api.github.com/repos/d1egoaz/utest/subscribers","subscription_url":"https://api.github.com/repos/d1egoaz/utest/subscription","commits_url":"https://api.github.com/repos/d1egoaz/utest/commits{/sha}","git_commits_url":"https://api.github.com/repos/d1egoaz/utest/git/commits{/sha}","comments_url":"https://api.github.com/repos/d1egoaz/utest/comments{/number}","issue_comment_url":"https://api.github.com/repos/d1egoaz/utest/issues/comments{/number}","contents_url":"https://api.github.com/repos/d1egoaz/utest/contents/{+path}","compare_url":"https://api.github.com/repos/d1egoaz/utest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d1egoaz/utest/merges","archive_url":"https://api.github.com/repos/d1egoaz/utest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d1egoaz/utest/downloads","issues_url":"https://api.github.com/repos/d1egoaz/utest/issues{/number}","pulls_url":"https://api.github.com/repos/d1egoaz/utest/pulls{/number}","milestones_url":"https://api.github.com/repos/d1egoaz/utest/milestones{/number}","notifications_url":"https://api.github.com/repos/d1egoaz/utest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d1egoaz/utest/labels{/name}","releases_url":"https://api.github.com/repos/d1egoaz/utest/releases{/id}","deployments_url":"https://api.github.com/repos/d1egoaz/utest/deployments","created_at":"2017-09-22T02:38:42Z","updated_at":"2017-09-22T02:38:43Z","pushed_at":"2017-09-22T02:44:03Z","git_url":"git://github.com/d1egoaz/utest.git","ssh_url":"git@github.com:d1egoaz/utest.git","clone_url":"https://github.com/d1egoaz/utest.git","svn_url":"https://github.com/d1egoaz/utest","homepage":null,"size":1065,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lihaoyi:master","ref":"master","sha":"93bf9002d1ffc35441295b4ac667f38d64aaf5b9","user":{"login":"lihaoyi","id":934140,"avatar_url":"https://avatars0.githubusercontent.com/u/934140?v=4","gravatar_id":"","url":"https://api.github.com/users/lihaoyi","html_url":"https://github.com/lihaoyi","followers_url":"https://api.github.com/users/lihaoyi/followers","following_url":"https://api.github.com/users/lihaoyi/following{/other_user}","gists_url":"https://api.github.com/users/lihaoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/lihaoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lihaoyi/subscriptions","organizations_url":"https://api.github.com/users/lihaoyi/orgs","repos_url":"https://api.github.com/users/lihaoyi/repos","events_url":"https://api.github.com/users/lihaoyi/events{/privacy}","received_events_url":"https://api.github.com/users/lihaoyi/received_events","type":"User","site_admin":false},"repo":{"id":16268021,"name":"utest","full_name":"lihaoyi/utest","owner":{"login":"lihaoyi","id":934140,"avatar_url":"https://avatars0.githubusercontent.com/u/934140?v=4","gravatar_id":"","url":"https://api.github.com/users/lihaoyi","html_url":"https://github.com/lihaoyi","followers_url":"https://api.github.com/users/lihaoyi/followers","following_url":"https://api.github.com/users/lihaoyi/following{/other_user}","gists_url":"https://api.github.com/users/lihaoyi/gists{/gist_id}","starred_url":"https://api.github.com/users/lihaoyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lihaoyi/subscriptions","organizations_url":"https://api.github.com/users/lihaoyi/orgs","repos_url":"https://api.github.com/users/lihaoyi/repos","events_url":"https://api.github.com/users/lihaoyi/events{/privacy}","received_events_url":"https://api.github.com/users/lihaoyi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lihaoyi/utest","description":"A tiny, portable testing library for Scala","fork":false,"url":"https://api.github.com/repos/lihaoyi/utest","forks_url":"https://api.github.com/repos/lihaoyi/utest/forks","keys_url":"https://api.github.com/repos/lihaoyi/utest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lihaoyi/utest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lihaoyi/utest/teams","hooks_url":"https://api.github.com/repos/lihaoyi/utest/hooks","issue_events_url":"https://api.github.com/repos/lihaoyi/utest/issues/events{/number}","events_url":"https://api.github.com/repos/lihaoyi/utest/events","assignees_url":"https://api.github.com/repos/lihaoyi/utest/assignees{/user}","branches_url":"https://api.github.com/repos/lihaoyi/utest/branches{/branch}","tags_url":"https://api.github.com/repos/lihaoyi/utest/tags","blobs_url":"https://api.github.com/repos/lihaoyi/utest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lihaoyi/utest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lihaoyi/utest/git/refs{/sha}","trees_url":"https://api.github.com/repos/lihaoyi/utest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lihaoyi/utest/statuses/{sha}","languages_url":"https://api.github.com/repos/lihaoyi/utest/languages","stargazers_url":"https://api.github.com/repos/lihaoyi/utest/stargazers","contributors_url":"https://api.github.com/repos/lihaoyi/utest/contributors","subscribers_url":"https://api.github.com/repos/lihaoyi/utest/subscribers","subscription_url":"https://api.github.com/repos/lihaoyi/utest/subscription","commits_url":"https://api.github.com/repos/lihaoyi/utest/commits{/sha}","git_commits_url":"https://api.github.com/repos/lihaoyi/utest/git/commits{/sha}","comments_url":"https://api.github.com/repos/lihaoyi/utest/comments{/number}","issue_comment_url":"https://api.github.com/repos/lihaoyi/utest/issues/comments{/number}","contents_url":"https://api.github.com/repos/lihaoyi/utest/contents/{+path}","compare_url":"https://api.github.com/repos/lihaoyi/utest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lihaoyi/utest/merges","archive_url":"https://api.github.com/repos/lihaoyi/utest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lihaoyi/utest/downloads","issues_url":"https://api.github.com/repos/lihaoyi/utest/issues{/number}","pulls_url":"https://api.github.com/repos/lihaoyi/utest/pulls{/number}","milestones_url":"https://api.github.com/repos/lihaoyi/utest/milestones{/number}","notifications_url":"https://api.github.com/repos/lihaoyi/utest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lihaoyi/utest/labels{/name}","releases_url":"https://api.github.com/repos/lihaoyi/utest/releases{/id}","deployments_url":"https://api.github.com/repos/lihaoyi/utest/deployments","created_at":"2014-01-27T03:12:39Z","updated_at":"2017-09-21T19:07:00Z","pushed_at":"2017-09-21T08:39:15Z","git_url":"git://github.com/lihaoyi/utest.git","ssh_url":"git@github.com:lihaoyi/utest.git","clone_url":"https://github.com/lihaoyi/utest.git","svn_url":"https://github.com/lihaoyi/utest","homepage":null,"size":1065,"stargazers_count":220,"watchers_count":220,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":8,"forks":37,"open_issues":8,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lihaoyi/utest/pulls/123"},"html":{"href":"https://github.com/lihaoyi/utest/pull/123"},"issue":{"href":"https://api.github.com/repos/lihaoyi/utest/issues/123"},"comments":{"href":"https://api.github.com/repos/lihaoyi/utest/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/lihaoyi/utest/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/lihaoyi/utest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lihaoyi/utest/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/lihaoyi/utest/statuses/232cd803be958dc97ca629cea8eead82051b7f94"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":47,"deletions":11,"changed_files":4}}
{"actor":{"display_login":"d1egoaz"}}