{"action":"created","issue":{"url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/130","repository_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal","labels_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/130/comments","events_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/130/events","html_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/130","id":275103453,"number":130,"title":"Implements adapter pattern to wallpappers","user":{"login":"samosaara","id":1809521,"avatar_url":"https://avatars0.githubusercontent.com/u/1809521?v=4","gravatar_id":"","url":"https://api.github.com/users/samosaara","html_url":"https://github.com/samosaara","followers_url":"https://api.github.com/users/samosaara/followers","following_url":"https://api.github.com/users/samosaara/following{/other_user}","gists_url":"https://api.github.com/users/samosaara/gists{/gist_id}","starred_url":"https://api.github.com/users/samosaara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samosaara/subscriptions","organizations_url":"https://api.github.com/users/samosaara/orgs","repos_url":"https://api.github.com/users/samosaara/repos","events_url":"https://api.github.com/users/samosaara/events{/privacy}","received_events_url":"https://api.github.com/users/samosaara/received_events","type":"User","site_admin":false},"labels":[{"id":586580870,"url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"samosaara","id":1809521,"avatar_url":"https://avatars0.githubusercontent.com/u/1809521?v=4","gravatar_id":"","url":"https://api.github.com/users/samosaara","html_url":"https://github.com/samosaara","followers_url":"https://api.github.com/users/samosaara/followers","following_url":"https://api.github.com/users/samosaara/following{/other_user}","gists_url":"https://api.github.com/users/samosaara/gists{/gist_id}","starred_url":"https://api.github.com/users/samosaara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samosaara/subscriptions","organizations_url":"https://api.github.com/users/samosaara/orgs","repos_url":"https://api.github.com/users/samosaara/repos","events_url":"https://api.github.com/users/samosaara/events{/privacy}","received_events_url":"https://api.github.com/users/samosaara/received_events","type":"User","site_admin":false},"assignees":[{"login":"samosaara","id":1809521,"avatar_url":"https://avatars0.githubusercontent.com/u/1809521?v=4","gravatar_id":"","url":"https://api.github.com/users/samosaara","html_url":"https://github.com/samosaara","followers_url":"https://api.github.com/users/samosaara/followers","following_url":"https://api.github.com/users/samosaara/following{/other_user}","gists_url":"https://api.github.com/users/samosaara/gists{/gist_id}","starred_url":"https://api.github.com/users/samosaara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samosaara/subscriptions","organizations_url":"https://api.github.com/users/samosaara/orgs","repos_url":"https://api.github.com/users/samosaara/repos","events_url":"https://api.github.com/users/samosaara/events{/privacy}","received_events_url":"https://api.github.com/users/samosaara/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-11-18T19:28:35Z","updated_at":"2017-11-19T22:07:37Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/130","html_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/130","diff_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/130.diff","patch_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/130.patch"},"body":"Continues the discussion from #129 \r\nSo I changed the structure a little to help with the reflection it's currently on the following structure\r\n```text\r\npokemonterminal/wallpaper\r\n├── adapters\r\n│   ├── darwin.py\r\n│   ├── gnome.py\r\n│   └── __init__.py\r\n└── __init__.py\r\n```\r\nIt is already 100% functional on Gnome, I tried my best not to break the Mac implementation but I can't really be sure since I don't have one to test... \r\n\r\nAlso I couldn't come up with no better tests than `assert constant == 'constant'`  any ideas on what to test? "},"comment":{"url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/comments/345553921","html_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/130#issuecomment-345553921","issue_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/130","id":345553921,"user":{"login":"LazoCoder","id":22990491,"avatar_url":"https://avatars0.githubusercontent.com/u/22990491?v=4","gravatar_id":"","url":"https://api.github.com/users/LazoCoder","html_url":"https://github.com/LazoCoder","followers_url":"https://api.github.com/users/LazoCoder/followers","following_url":"https://api.github.com/users/LazoCoder/following{/other_user}","gists_url":"https://api.github.com/users/LazoCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/LazoCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LazoCoder/subscriptions","organizations_url":"https://api.github.com/users/LazoCoder/orgs","repos_url":"https://api.github.com/users/LazoCoder/repos","events_url":"https://api.github.com/users/LazoCoder/events{/privacy}","received_events_url":"https://api.github.com/users/LazoCoder/received_events","type":"User","site_admin":false},"created_at":"2017-11-19T22:07:37Z","updated_at":"2017-11-19T22:07:37Z","author_association":"OWNER","body":"Oops. Looks like I tested the wrong version by mistake. I do actually get an error on mac:\r\n```\r\nMac:Pokemon-Terminal-b035b4f21269debe74b75c074570c6e4cb20a15b Laki$ ./pokemon -w pikachu\r\nA single pokemon matches the specified criteria:\r\nTraceback (most recent call last):\r\n  File \"./pokemon\", line 8, in <module>\r\n    main(sys.argv[1:])\r\n  File \"/Users/Laki/Downloads/Pokemon-Terminal-b035b4f21269debe74b75c074570c6e4cb20a15b/pokemonterminal/main.py\", line 130, in main\r\n    scripter.change_wallpaper(target.get_path())\r\n  File \"/Users/Laki/Downloads/Pokemon-Terminal-b035b4f21269debe74b75c074570c6e4cb20a15b/pokemonterminal/scripter.py\", line 27, in change_wallpaper\r\n    providers = get_current_adapters()\r\n  File \"/Users/Laki/Downloads/Pokemon-Terminal-b035b4f21269debe74b75c074570c6e4cb20a15b/pokemonterminal/wallpaper/__init__.py\", line 29, in get_current_adapters\r\n    return [x for x in arr if x.is_compatible()]\r\n  File \"/Users/Laki/Downloads/Pokemon-Terminal-b035b4f21269debe74b75c074570c6e4cb20a15b/pokemonterminal/wallpaper/__init__.py\", line 29, in <listcomp>\r\n    return [x for x in arr if x.is_compatible()]\r\n  File \"/Users/Laki/Downloads/Pokemon-Terminal-b035b4f21269debe74b75c074570c6e4cb20a15b/pokemonterminal/wallpaper/adapters/darwin.py\", line 25, in is_compatible\r\n    return __sys.platform == \"darwin\"\r\nNameError: name '_DarwinProvider__sys' is not defined\r\n```"}}
{"actor":{"display_login":"LazoCoder"}}