{"action":"reopened","number":123,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/123","id":119731377,"html_url":"https://github.com/jenkinsci/workflow-cps-plugin/pull/123","diff_url":"https://github.com/jenkinsci/workflow-cps-plugin/pull/123.diff","patch_url":"https://github.com/jenkinsci/workflow-cps-plugin/pull/123.patch","issue_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/123","number":123,"state":"open","locked":false,"title":"[JENKINS-43934] Flatten GString’s found in step arguments, even when present in nested collections","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars2.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"body":"[JENKINS-43934](https://issues.jenkins-ci.org/browse/JENKINS-43934)\r\n\r\nNever really posed a problem before, probably because there is no existing `StepDescriptor.newInstance` override which would be expecting evaluated `String`s in a collection type, but the previous behavior was at least potentially wrong…and this is needed for https://github.com/jenkinsci/workflow-cps-plugin/pull/98 so we might as well do it anyway.\r\n\r\n`DescribableModel` already has `GString` handling, which really should never have been there, but we cannot remove that compatibly.\r\n\r\n@reviewbybees","created_at":"2017-05-09T19:11:20Z","updated_at":"2017-05-09T20:54:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0d0ecb0a16fd218f8775b2c7bdd8e64c30df004","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/123/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/123/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/123/comments","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/statuses/549ae9bdcc83289c0af71db5cc9ed67878b6a6eb","head":{"label":"jglick:flattenGString","ref":"flattenGString","sha":"549ae9bdcc83289c0af71db5cc9ed67878b6a6eb","user":{"login":"jglick","id":154109,"avatar_url":"https://avatars2.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"repo":{"id":55635992,"name":"workflow-cps-plugin","full_name":"jglick/workflow-cps-plugin","owner":{"login":"jglick","id":154109,"avatar_url":"https://avatars2.githubusercontent.com/u/154109?v=3","gravatar_id":"","url":"https://api.github.com/users/jglick","html_url":"https://github.com/jglick","followers_url":"https://api.github.com/users/jglick/followers","following_url":"https://api.github.com/users/jglick/following{/other_user}","gists_url":"https://api.github.com/users/jglick/gists{/gist_id}","starred_url":"https://api.github.com/users/jglick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jglick/subscriptions","organizations_url":"https://api.github.com/users/jglick/orgs","repos_url":"https://api.github.com/users/jglick/repos","events_url":"https://api.github.com/users/jglick/events{/privacy}","received_events_url":"https://api.github.com/users/jglick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jglick/workflow-cps-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/jglick/workflow-cps-plugin","forks_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/forks","keys_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/teams","hooks_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/hooks","issue_events_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/events","assignees_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/tags","blobs_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/languages","stargazers_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/stargazers","contributors_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/contributors","subscribers_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/subscribers","subscription_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/subscription","commits_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/merges","archive_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/downloads","issues_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jglick/workflow-cps-plugin/deployments","created_at":"2016-04-06T19:49:35Z","updated_at":"2016-04-06T19:49:37Z","pushed_at":"2017-05-09T19:08:10Z","git_url":"git://github.com/jglick/workflow-cps-plugin.git","ssh_url":"git@github.com:jglick/workflow-cps-plugin.git","clone_url":"https://github.com/jglick/workflow-cps-plugin.git","svn_url":"https://github.com/jglick/workflow-cps-plugin","homepage":"","size":1644,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"66f27532e34195e4883caaefdec591ded2022500","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55543225,"name":"workflow-cps-plugin","full_name":"jenkinsci/workflow-cps-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/workflow-cps-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin","forks_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/deployments","created_at":"2016-04-05T20:24:40Z","updated_at":"2017-04-23T17:10:26Z","pushed_at":"2017-05-09T19:11:21Z","git_url":"git://github.com/jenkinsci/workflow-cps-plugin.git","ssh_url":"git@github.com:jenkinsci/workflow-cps-plugin.git","clone_url":"https://github.com/jenkinsci/workflow-cps-plugin.git","svn_url":"https://github.com/jenkinsci/workflow-cps-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Groovy+Plugin","size":2350,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":9,"forks":49,"open_issues":9,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/123"},"html":{"href":"https://github.com/jenkinsci/workflow-cps-plugin/pull/123"},"issue":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/123"},"comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/statuses/549ae9bdcc83289c0af71db5cc9ed67878b6a6eb"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":4,"maintainer_can_modify":true,"commits":1,"additions":90,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"jglick"}}