{"action":"created","comment":{"url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/comments/156915740","pull_request_review_id":83469172,"id":156915740,"diff_hunk":"@@ -85,15 +86,15 @@ public function load(core_kernel_classes_Resource $test)\n     public function deleteContent( core_kernel_classes_Resource $test)\n     {\n         /** @var \\core_kernel_classes_Literal $directoryId */\n-        $directoryId = $test->getOnePropertyValue($this->getProperty(TEST_TESTCONTENT_PROP));\n+        $directoryId = $test->getOnePropertyValue($this->getProperty(TestService::TEST_TESTCONTENT_PROP));\n         if(is_null($directoryId)){\n             throw new \\common_exception_FileSystemError(__('Unknown test directory'));\n         }\n \n         $directory = \\tao_models_classes_service_FileStorage::singleton()->getDirectoryById($directoryId->literal);\n         $directory->deleteSelf();\n \n-\t\t$test->removePropertyValues($this->getProperty(TEST_TESTCONTENT_PROP));\n+\t\t$test->removePropertyValues($this->getProperty(TestService::TEST_TESTCONTENT_PROP));","path":"model/storage/DeprecatedStorage.php","position":46,"original_position":46,"commit_id":"44f55ea8df0919896138deaf4f8948b73042d8e7","original_commit_id":"105386bd213a844ac7087758c9cb291149f31999","user":{"login":"zagovorichev","id":1445911,"avatar_url":"https://avatars3.githubusercontent.com/u/1445911?v=4","gravatar_id":"","url":"https://api.github.com/users/zagovorichev","html_url":"https://github.com/zagovorichev","followers_url":"https://api.github.com/users/zagovorichev/followers","following_url":"https://api.github.com/users/zagovorichev/following{/other_user}","gists_url":"https://api.github.com/users/zagovorichev/gists{/gist_id}","starred_url":"https://api.github.com/users/zagovorichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zagovorichev/subscriptions","organizations_url":"https://api.github.com/users/zagovorichev/orgs","repos_url":"https://api.github.com/users/zagovorichev/repos","events_url":"https://api.github.com/users/zagovorichev/events{/privacy}","received_events_url":"https://api.github.com/users/zagovorichev/received_events","type":"User","site_admin":false},"body":"what do I mean:\r\nhttps://github.com/oat-sa/extension-tao-test/blob/476db8e24a01aee6765da5de09da4908ceaeb255/models/classes/class.TestsService.php#L46\r\nit's deprecated, so you can just use\r\nTestService::PROPERTY_TEST_CONTENT","created_at":"2017-12-14T11:13:15Z","updated_at":"2017-12-14T11:13:15Z","html_url":"https://github.com/oat-sa/extension-tao-testlinear/pull/31#discussion_r156915740","pull_request_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/31","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/comments/156915740"},"html":{"href":"https://github.com/oat-sa/extension-tao-testlinear/pull/31#discussion_r156915740"},"pull_request":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/31"}},"in_reply_to_id":156655687},"pull_request":{"url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/31","id":157536191,"html_url":"https://github.com/oat-sa/extension-tao-testlinear/pull/31","diff_url":"https://github.com/oat-sa/extension-tao-testlinear/pull/31.diff","patch_url":"https://github.com/oat-sa/extension-tao-testlinear/pull/31.patch","issue_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues/31","number":31,"state":"open","locked":false,"title":"Refactoring/tao 5102/remove globals from core extension","user":{"login":"ionutpad","id":31656944,"avatar_url":"https://avatars2.githubusercontent.com/u/31656944?v=4","gravatar_id":"","url":"https://api.github.com/users/ionutpad","html_url":"https://github.com/ionutpad","followers_url":"https://api.github.com/users/ionutpad/followers","following_url":"https://api.github.com/users/ionutpad/following{/other_user}","gists_url":"https://api.github.com/users/ionutpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ionutpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionutpad/subscriptions","organizations_url":"https://api.github.com/users/ionutpad/orgs","repos_url":"https://api.github.com/users/ionutpad/repos","events_url":"https://api.github.com/users/ionutpad/events{/privacy}","received_events_url":"https://api.github.com/users/ionutpad/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-11T11:15:45Z","updated_at":"2017-12-14T11:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f193915babf54d60df89c2becb63e311d460fd45","assignee":{"login":"zagovorichev","id":1445911,"avatar_url":"https://avatars3.githubusercontent.com/u/1445911?v=4","gravatar_id":"","url":"https://api.github.com/users/zagovorichev","html_url":"https://github.com/zagovorichev","followers_url":"https://api.github.com/users/zagovorichev/followers","following_url":"https://api.github.com/users/zagovorichev/following{/other_user}","gists_url":"https://api.github.com/users/zagovorichev/gists{/gist_id}","starred_url":"https://api.github.com/users/zagovorichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zagovorichev/subscriptions","organizations_url":"https://api.github.com/users/zagovorichev/orgs","repos_url":"https://api.github.com/users/zagovorichev/repos","events_url":"https://api.github.com/users/zagovorichev/events{/privacy}","received_events_url":"https://api.github.com/users/zagovorichev/received_events","type":"User","site_admin":false},"assignees":[{"login":"zagovorichev","id":1445911,"avatar_url":"https://avatars3.githubusercontent.com/u/1445911?v=4","gravatar_id":"","url":"https://api.github.com/users/zagovorichev","html_url":"https://github.com/zagovorichev","followers_url":"https://api.github.com/users/zagovorichev/followers","following_url":"https://api.github.com/users/zagovorichev/following{/other_user}","gists_url":"https://api.github.com/users/zagovorichev/gists{/gist_id}","starred_url":"https://api.github.com/users/zagovorichev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zagovorichev/subscriptions","organizations_url":"https://api.github.com/users/zagovorichev/orgs","repos_url":"https://api.github.com/users/zagovorichev/repos","events_url":"https://api.github.com/users/zagovorichev/events{/privacy}","received_events_url":"https://api.github.com/users/zagovorichev/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/31/commits","review_comments_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/31/comments","review_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues/31/comments","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/statuses/44f55ea8df0919896138deaf4f8948b73042d8e7","head":{"label":"oat-sa:refactoring/TAO-5102/remove_globals_from_core_extension","ref":"refactoring/TAO-5102/remove_globals_from_core_extension","sha":"44f55ea8df0919896138deaf4f8948b73042d8e7","user":{"login":"oat-sa","id":7581081,"avatar_url":"https://avatars3.githubusercontent.com/u/7581081?v=4","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":28451452,"name":"extension-tao-testlinear","full_name":"oat-sa/extension-tao-testlinear","owner":{"login":"oat-sa","id":7581081,"avatar_url":"https://avatars3.githubusercontent.com/u/7581081?v=4","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oat-sa/extension-tao-testlinear","description":"A simple linear test runner for Tao","fork":false,"url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear","forks_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/forks","keys_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/teams","hooks_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/hooks","issue_events_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues/events{/number}","events_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/events","assignees_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/assignees{/user}","branches_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/branches{/branch}","tags_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/tags","blobs_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/refs{/sha}","trees_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/statuses/{sha}","languages_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/languages","stargazers_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/stargazers","contributors_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/contributors","subscribers_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/subscribers","subscription_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/subscription","commits_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/commits{/sha}","git_commits_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/commits{/sha}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/comments{/number}","issue_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues/comments{/number}","contents_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/contents/{+path}","compare_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/merges","archive_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/downloads","issues_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues{/number}","pulls_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls{/number}","milestones_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/milestones{/number}","notifications_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/labels{/name}","releases_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/releases{/id}","deployments_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/deployments","created_at":"2014-12-24T14:35:15Z","updated_at":"2016-04-11T16:52:42Z","pushed_at":"2017-12-14T11:09:35Z","git_url":"git://github.com/oat-sa/extension-tao-testlinear.git","ssh_url":"git@github.com:oat-sa/extension-tao-testlinear.git","clone_url":"https://github.com/oat-sa/extension-tao-testlinear.git","svn_url":"https://github.com/oat-sa/extension-tao-testlinear","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"oat-sa:develop","ref":"develop","sha":"63786fde4c499110bfcc733da57e35fef6f197f4","user":{"login":"oat-sa","id":7581081,"avatar_url":"https://avatars3.githubusercontent.com/u/7581081?v=4","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":28451452,"name":"extension-tao-testlinear","full_name":"oat-sa/extension-tao-testlinear","owner":{"login":"oat-sa","id":7581081,"avatar_url":"https://avatars3.githubusercontent.com/u/7581081?v=4","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oat-sa/extension-tao-testlinear","description":"A simple linear test runner for Tao","fork":false,"url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear","forks_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/forks","keys_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/teams","hooks_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/hooks","issue_events_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues/events{/number}","events_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/events","assignees_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/assignees{/user}","branches_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/branches{/branch}","tags_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/tags","blobs_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/refs{/sha}","trees_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/statuses/{sha}","languages_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/languages","stargazers_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/stargazers","contributors_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/contributors","subscribers_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/subscribers","subscription_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/subscription","commits_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/commits{/sha}","git_commits_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/git/commits{/sha}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/comments{/number}","issue_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues/comments{/number}","contents_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/contents/{+path}","compare_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/merges","archive_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/downloads","issues_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues{/number}","pulls_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls{/number}","milestones_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/milestones{/number}","notifications_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/labels{/name}","releases_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/releases{/id}","deployments_url":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/deployments","created_at":"2014-12-24T14:35:15Z","updated_at":"2016-04-11T16:52:42Z","pushed_at":"2017-12-14T11:09:35Z","git_url":"git://github.com/oat-sa/extension-tao-testlinear.git","ssh_url":"git@github.com:oat-sa/extension-tao-testlinear.git","clone_url":"https://github.com/oat-sa/extension-tao-testlinear.git","svn_url":"https://github.com/oat-sa/extension-tao-testlinear","homepage":null,"size":88,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/31"},"html":{"href":"https://github.com/oat-sa/extension-tao-testlinear/pull/31"},"issue":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues/31"},"comments":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/oat-sa/extension-tao-testlinear/statuses/44f55ea8df0919896138deaf4f8948b73042d8e7"}},"author_association":"NONE"}}
{"actor":{"display_login":"zagovorichev"}}