{"action":"created","comment":{"url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/comments/143747398","pull_request_review_id":68301717,"id":143747398,"diff_hunk":"@@ -92,6 +92,13 @@ class SelectAPIViewController: UIViewController {\n         giniConfiguration.debugModeOn = true\n         giniConfiguration.fileImportSupportedTypes = .pdf_and_images\n         giniConfiguration.navigationBarItemTintColor = UIColor.white\n+        giniConfiguration.customDocumentValidations = { document in","path":"Example/GiniVision/SelectAPIViewController.swift","position":4,"original_position":4,"commit_id":"0d272ff6ff450b6b68235cdd1c13287f723948e0","original_commit_id":"0d272ff6ff450b6b68235cdd1c13287f723948e0","user":{"login":"a-szotyori","id":13149498,"avatar_url":"https://avatars1.githubusercontent.com/u/13149498?v=4","gravatar_id":"","url":"https://api.github.com/users/a-szotyori","html_url":"https://github.com/a-szotyori","followers_url":"https://api.github.com/users/a-szotyori/followers","following_url":"https://api.github.com/users/a-szotyori/following{/other_user}","gists_url":"https://api.github.com/users/a-szotyori/gists{/gist_id}","starred_url":"https://api.github.com/users/a-szotyori/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-szotyori/subscriptions","organizations_url":"https://api.github.com/users/a-szotyori/orgs","repos_url":"https://api.github.com/users/a-szotyori/repos","events_url":"https://api.github.com/users/a-szotyori/events{/privacy}","received_events_url":"https://api.github.com/users/a-szotyori/received_events","type":"User","site_admin":false},"body":"Great idea! What if they want to do an async validation? For ex. doing some complex validation that would block the main thread?","created_at":"2017-10-10T14:36:55Z","updated_at":"2017-10-10T14:41:31Z","html_url":"https://github.com/gini/gini-vision-lib-ios/pull/83#discussion_r143747398","pull_request_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/83","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/comments/143747398"},"html":{"href":"https://github.com/gini/gini-vision-lib-ios/pull/83#discussion_r143747398"},"pull_request":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/83","id":145467856,"html_url":"https://github.com/gini/gini-vision-lib-ios/pull/83","diff_url":"https://github.com/gini/gini-vision-lib-ios/pull/83.diff","patch_url":"https://github.com/gini/gini-vision-lib-ios/pull/83.patch","issue_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/83","number":83,"state":"open","locked":false,"title":"Custom document validations","user":{"login":"kikettas","id":9082270,"avatar_url":"https://avatars2.githubusercontent.com/u/9082270?v=4","gravatar_id":"","url":"https://api.github.com/users/kikettas","html_url":"https://github.com/kikettas","followers_url":"https://api.github.com/users/kikettas/followers","following_url":"https://api.github.com/users/kikettas/following{/other_user}","gists_url":"https://api.github.com/users/kikettas/gists{/gist_id}","starred_url":"https://api.github.com/users/kikettas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikettas/subscriptions","organizations_url":"https://api.github.com/users/kikettas/orgs","repos_url":"https://api.github.com/users/kikettas/repos","events_url":"https://api.github.com/users/kikettas/events{/privacy}","received_events_url":"https://api.github.com/users/kikettas/received_events","type":"User","site_admin":false},"body":"Apart from the default document validations (file size, file type...), there should be possible to add custom validations.\r\n\r\n### How to test\r\nOpen the example app, go to the camera screen (either Screen or Component API) and try to import a file with a size higher than 5MB.\r\n\r\n### Merging\r\nAutomatic.\r\n\r\n### Ticket \r\nIssue #82       ","created_at":"2017-10-09T14:28:08Z","updated_at":"2017-10-10T14:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"187b52f774d66ad56f71d93d51a469c077e20074","assignee":{"login":"kikettas","id":9082270,"avatar_url":"https://avatars2.githubusercontent.com/u/9082270?v=4","gravatar_id":"","url":"https://api.github.com/users/kikettas","html_url":"https://github.com/kikettas","followers_url":"https://api.github.com/users/kikettas/followers","following_url":"https://api.github.com/users/kikettas/following{/other_user}","gists_url":"https://api.github.com/users/kikettas/gists{/gist_id}","starred_url":"https://api.github.com/users/kikettas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikettas/subscriptions","organizations_url":"https://api.github.com/users/kikettas/orgs","repos_url":"https://api.github.com/users/kikettas/repos","events_url":"https://api.github.com/users/kikettas/events{/privacy}","received_events_url":"https://api.github.com/users/kikettas/received_events","type":"User","site_admin":false},"assignees":[{"login":"kikettas","id":9082270,"avatar_url":"https://avatars2.githubusercontent.com/u/9082270?v=4","gravatar_id":"","url":"https://api.github.com/users/kikettas","html_url":"https://github.com/kikettas","followers_url":"https://api.github.com/users/kikettas/followers","following_url":"https://api.github.com/users/kikettas/following{/other_user}","gists_url":"https://api.github.com/users/kikettas/gists{/gist_id}","starred_url":"https://api.github.com/users/kikettas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikettas/subscriptions","organizations_url":"https://api.github.com/users/kikettas/orgs","repos_url":"https://api.github.com/users/kikettas/repos","events_url":"https://api.github.com/users/kikettas/events{/privacy}","received_events_url":"https://api.github.com/users/kikettas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/gini/gini-vision-lib-ios/milestones/2","html_url":"https://github.com/gini/gini-vision-lib-ios/milestone/2","labels_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/milestones/2/labels","id":2732618,"number":2,"title":"Camera Roll and PDF Import","description":"","creator":{"login":"kikettas","id":9082270,"avatar_url":"https://avatars2.githubusercontent.com/u/9082270?v=4","gravatar_id":"","url":"https://api.github.com/users/kikettas","html_url":"https://github.com/kikettas","followers_url":"https://api.github.com/users/kikettas/followers","following_url":"https://api.github.com/users/kikettas/following{/other_user}","gists_url":"https://api.github.com/users/kikettas/gists{/gist_id}","starred_url":"https://api.github.com/users/kikettas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kikettas/subscriptions","organizations_url":"https://api.github.com/users/kikettas/orgs","repos_url":"https://api.github.com/users/kikettas/repos","events_url":"https://api.github.com/users/kikettas/events{/privacy}","received_events_url":"https://api.github.com/users/kikettas/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":20,"state":"open","created_at":"2017-08-30T12:54:25Z","updated_at":"2017-10-10T12:16:46Z","due_on":"2017-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/83/commits","review_comments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/83/comments","review_comment_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/83/comments","statuses_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/statuses/0d272ff6ff450b6b68235cdd1c13287f723948e0","head":{"label":"gini:feature-custom-document-validations","ref":"feature-custom-document-validations","sha":"0d272ff6ff450b6b68235cdd1c13287f723948e0","user":{"login":"gini","id":701646,"avatar_url":"https://avatars0.githubusercontent.com/u/701646?v=4","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"repo":{"id":60536520,"name":"gini-vision-lib-ios","full_name":"gini/gini-vision-lib-ios","owner":{"login":"gini","id":701646,"avatar_url":"https://avatars0.githubusercontent.com/u/701646?v=4","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gini/gini-vision-lib-ios","description":"Swift library providing components for capturing, reviewing and analyzing photos of invoices and remittance slips.","fork":false,"url":"https://api.github.com/repos/gini/gini-vision-lib-ios","forks_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/forks","keys_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/teams","hooks_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/hooks","issue_events_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/events{/number}","events_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/events","assignees_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/assignees{/user}","branches_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/branches{/branch}","tags_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/tags","blobs_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/languages","stargazers_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/stargazers","contributors_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/contributors","subscribers_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/subscribers","subscription_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/subscription","commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/contents/{+path}","compare_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/merges","archive_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/downloads","issues_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues{/number}","pulls_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/labels{/name}","releases_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/releases{/id}","deployments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/deployments","created_at":"2016-06-06T14:55:22Z","updated_at":"2017-10-09T06:59:05Z","pushed_at":"2017-10-10T12:55:30Z","git_url":"git://github.com/gini/gini-vision-lib-ios.git","ssh_url":"git@github.com:gini/gini-vision-lib-ios.git","clone_url":"https://github.com/gini/gini-vision-lib-ios.git","svn_url":"https://github.com/gini/gini-vision-lib-ios","homepage":"https://www.gini.net/developers/","size":5822,"stargazers_count":7,"watchers_count":7,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":7,"default_branch":"master"}},"base":{"label":"gini:develop","ref":"develop","sha":"a7bde26627eafeba72f3a9b5fd01b2bd10750e14","user":{"login":"gini","id":701646,"avatar_url":"https://avatars0.githubusercontent.com/u/701646?v=4","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"repo":{"id":60536520,"name":"gini-vision-lib-ios","full_name":"gini/gini-vision-lib-ios","owner":{"login":"gini","id":701646,"avatar_url":"https://avatars0.githubusercontent.com/u/701646?v=4","gravatar_id":"","url":"https://api.github.com/users/gini","html_url":"https://github.com/gini","followers_url":"https://api.github.com/users/gini/followers","following_url":"https://api.github.com/users/gini/following{/other_user}","gists_url":"https://api.github.com/users/gini/gists{/gist_id}","starred_url":"https://api.github.com/users/gini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gini/subscriptions","organizations_url":"https://api.github.com/users/gini/orgs","repos_url":"https://api.github.com/users/gini/repos","events_url":"https://api.github.com/users/gini/events{/privacy}","received_events_url":"https://api.github.com/users/gini/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gini/gini-vision-lib-ios","description":"Swift library providing components for capturing, reviewing and analyzing photos of invoices and remittance slips.","fork":false,"url":"https://api.github.com/repos/gini/gini-vision-lib-ios","forks_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/forks","keys_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/teams","hooks_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/hooks","issue_events_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/events{/number}","events_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/events","assignees_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/assignees{/user}","branches_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/branches{/branch}","tags_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/tags","blobs_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/languages","stargazers_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/stargazers","contributors_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/contributors","subscribers_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/subscribers","subscription_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/subscription","commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/contents/{+path}","compare_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/merges","archive_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/downloads","issues_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues{/number}","pulls_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/labels{/name}","releases_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/releases{/id}","deployments_url":"https://api.github.com/repos/gini/gini-vision-lib-ios/deployments","created_at":"2016-06-06T14:55:22Z","updated_at":"2017-10-09T06:59:05Z","pushed_at":"2017-10-10T12:55:30Z","git_url":"git://github.com/gini/gini-vision-lib-ios.git","ssh_url":"git@github.com:gini/gini-vision-lib-ios.git","clone_url":"https://github.com/gini/gini-vision-lib-ios.git","svn_url":"https://github.com/gini/gini-vision-lib-ios","homepage":"https://www.gini.net/developers/","size":5822,"stargazers_count":7,"watchers_count":7,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/83"},"html":{"href":"https://github.com/gini/gini-vision-lib-ios/pull/83"},"issue":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/83"},"comments":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/gini/gini-vision-lib-ios/statuses/0d272ff6ff450b6b68235cdd1c13287f723948e0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"a-szotyori"}}