{"action":"created","comment":{"url":"https://api.github.com/repos/prismskylabs/connect/pulls/comments/106726317","pull_request_review_id":27657026,"id":106726317,"diff_hunk":"@@ -0,0 +1,43 @@\n+/*\n+ * Copyright (C) 2017 Prism Skylabs\n+ */\n+#ifndef PRISM_PRISMCONNECTSERVICE_H\n+#define PRISM_PRISMCONNECTSERVICE_H\n+\n+#include <client.h>\n+#include <boost/shared_ptr.hpp>\n+\n+namespace prism\n+{\n+namespace connect\n+{\n+\n+class PrismConnectService","path":"include/private/PrismConnectService.h","position":15,"original_position":15,"commit_id":"54ecd4f862a9ae3be8d1c2f1e71084ae06f671aa","original_commit_id":"54ecd4f862a9ae3be8d1c2f1e71084ae06f671aa","user":{"login":"dbus-prsm","id":24662211,"avatar_url":"https://avatars2.githubusercontent.com/u/24662211?v=3","gravatar_id":"","url":"https://api.github.com/users/dbus-prsm","html_url":"https://github.com/dbus-prsm","followers_url":"https://api.github.com/users/dbus-prsm/followers","following_url":"https://api.github.com/users/dbus-prsm/following{/other_user}","gists_url":"https://api.github.com/users/dbus-prsm/gists{/gist_id}","starred_url":"https://api.github.com/users/dbus-prsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbus-prsm/subscriptions","organizations_url":"https://api.github.com/users/dbus-prsm/orgs","repos_url":"https://api.github.com/users/dbus-prsm/repos","events_url":"https://api.github.com/users/dbus-prsm/events{/privacy}","received_events_url":"https://api.github.com/users/dbus-prsm/received_events","type":"User","site_admin":false},"body":"If all members/methods are public it should be a struct.\r\nThe class has no virtual methods, so no need for the destructor to be virtual.\r\nThis is not a part of the pull request, but I think it would be easier to fix it here since you are moving the file from another project.","created_at":"2017-03-17T19:14:30Z","updated_at":"2017-03-17T19:47:28Z","html_url":"https://github.com/prismskylabs/connect/pull/38#discussion_r106726317","pull_request_url":"https://api.github.com/repos/prismskylabs/connect/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/comments/106726317"},"html":{"href":"https://github.com/prismskylabs/connect/pull/38#discussion_r106726317"},"pull_request":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/prismskylabs/connect/pulls/38","id":110640099,"html_url":"https://github.com/prismskylabs/connect/pull/38","diff_url":"https://github.com/prismskylabs/connect/pull/38.diff","patch_url":"https://github.com/prismskylabs/connect/pull/38.patch","issue_url":"https://api.github.com/repos/prismskylabs/connect/issues/38","number":38,"state":"open","locked":false,"title":"Feature/edge 185","user":{"login":"ionyshch-prismsl","id":24312265,"avatar_url":"https://avatars3.githubusercontent.com/u/24312265?v=3","gravatar_id":"","url":"https://api.github.com/users/ionyshch-prismsl","html_url":"https://github.com/ionyshch-prismsl","followers_url":"https://api.github.com/users/ionyshch-prismsl/followers","following_url":"https://api.github.com/users/ionyshch-prismsl/following{/other_user}","gists_url":"https://api.github.com/users/ionyshch-prismsl/gists{/gist_id}","starred_url":"https://api.github.com/users/ionyshch-prismsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionyshch-prismsl/subscriptions","organizations_url":"https://api.github.com/users/ionyshch-prismsl/orgs","repos_url":"https://api.github.com/users/ionyshch-prismsl/repos","events_url":"https://api.github.com/users/ionyshch-prismsl/events{/privacy}","received_events_url":"https://api.github.com/users/ionyshch-prismsl/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-14T14:56:19Z","updated_at":"2017-03-17T19:47:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3399d233eb17e611b986aea729b611435fe27ecc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prismskylabs/connect/pulls/38/commits","review_comments_url":"https://api.github.com/repos/prismskylabs/connect/pulls/38/comments","review_comment_url":"https://api.github.com/repos/prismskylabs/connect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prismskylabs/connect/issues/38/comments","statuses_url":"https://api.github.com/repos/prismskylabs/connect/statuses/54ecd4f862a9ae3be8d1c2f1e71084ae06f671aa","head":{"label":"prismskylabs:feature/edge-185","ref":"feature/edge-185","sha":"54ecd4f862a9ae3be8d1c2f1e71084ae06f671aa","user":{"login":"prismskylabs","id":2381267,"avatar_url":"https://avatars0.githubusercontent.com/u/2381267?v=3","gravatar_id":"","url":"https://api.github.com/users/prismskylabs","html_url":"https://github.com/prismskylabs","followers_url":"https://api.github.com/users/prismskylabs/followers","following_url":"https://api.github.com/users/prismskylabs/following{/other_user}","gists_url":"https://api.github.com/users/prismskylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prismskylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismskylabs/subscriptions","organizations_url":"https://api.github.com/users/prismskylabs/orgs","repos_url":"https://api.github.com/users/prismskylabs/repos","events_url":"https://api.github.com/users/prismskylabs/events{/privacy}","received_events_url":"https://api.github.com/users/prismskylabs/received_events","type":"Organization","site_admin":false},"repo":{"id":65768540,"name":"connect","full_name":"prismskylabs/connect","owner":{"login":"prismskylabs","id":2381267,"avatar_url":"https://avatars0.githubusercontent.com/u/2381267?v=3","gravatar_id":"","url":"https://api.github.com/users/prismskylabs","html_url":"https://github.com/prismskylabs","followers_url":"https://api.github.com/users/prismskylabs/followers","following_url":"https://api.github.com/users/prismskylabs/following{/other_user}","gists_url":"https://api.github.com/users/prismskylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prismskylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismskylabs/subscriptions","organizations_url":"https://api.github.com/users/prismskylabs/orgs","repos_url":"https://api.github.com/users/prismskylabs/repos","events_url":"https://api.github.com/users/prismskylabs/events{/privacy}","received_events_url":"https://api.github.com/users/prismskylabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prismskylabs/connect","description":null,"fork":false,"url":"https://api.github.com/repos/prismskylabs/connect","forks_url":"https://api.github.com/repos/prismskylabs/connect/forks","keys_url":"https://api.github.com/repos/prismskylabs/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prismskylabs/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prismskylabs/connect/teams","hooks_url":"https://api.github.com/repos/prismskylabs/connect/hooks","issue_events_url":"https://api.github.com/repos/prismskylabs/connect/issues/events{/number}","events_url":"https://api.github.com/repos/prismskylabs/connect/events","assignees_url":"https://api.github.com/repos/prismskylabs/connect/assignees{/user}","branches_url":"https://api.github.com/repos/prismskylabs/connect/branches{/branch}","tags_url":"https://api.github.com/repos/prismskylabs/connect/tags","blobs_url":"https://api.github.com/repos/prismskylabs/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prismskylabs/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prismskylabs/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/prismskylabs/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prismskylabs/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/prismskylabs/connect/languages","stargazers_url":"https://api.github.com/repos/prismskylabs/connect/stargazers","contributors_url":"https://api.github.com/repos/prismskylabs/connect/contributors","subscribers_url":"https://api.github.com/repos/prismskylabs/connect/subscribers","subscription_url":"https://api.github.com/repos/prismskylabs/connect/subscription","commits_url":"https://api.github.com/repos/prismskylabs/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/prismskylabs/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/prismskylabs/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/prismskylabs/connect/issues/comments{/number}","contents_url":"https://api.github.com/repos/prismskylabs/connect/contents/{+path}","compare_url":"https://api.github.com/repos/prismskylabs/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prismskylabs/connect/merges","archive_url":"https://api.github.com/repos/prismskylabs/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prismskylabs/connect/downloads","issues_url":"https://api.github.com/repos/prismskylabs/connect/issues{/number}","pulls_url":"https://api.github.com/repos/prismskylabs/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/prismskylabs/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/prismskylabs/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prismskylabs/connect/labels{/name}","releases_url":"https://api.github.com/repos/prismskylabs/connect/releases{/id}","deployments_url":"https://api.github.com/repos/prismskylabs/connect/deployments","created_at":"2016-08-15T22:13:37Z","updated_at":"2017-02-22T16:37:53Z","pushed_at":"2017-03-17T10:52:45Z","git_url":"git://github.com/prismskylabs/connect.git","ssh_url":"git@github.com:prismskylabs/connect.git","clone_url":"https://github.com/prismskylabs/connect.git","svn_url":"https://github.com/prismskylabs/connect","homepage":null,"size":569,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"prismskylabs:master","ref":"master","sha":"e792ed98db672dfbcc1a32142d69452015f07405","user":{"login":"prismskylabs","id":2381267,"avatar_url":"https://avatars0.githubusercontent.com/u/2381267?v=3","gravatar_id":"","url":"https://api.github.com/users/prismskylabs","html_url":"https://github.com/prismskylabs","followers_url":"https://api.github.com/users/prismskylabs/followers","following_url":"https://api.github.com/users/prismskylabs/following{/other_user}","gists_url":"https://api.github.com/users/prismskylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prismskylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismskylabs/subscriptions","organizations_url":"https://api.github.com/users/prismskylabs/orgs","repos_url":"https://api.github.com/users/prismskylabs/repos","events_url":"https://api.github.com/users/prismskylabs/events{/privacy}","received_events_url":"https://api.github.com/users/prismskylabs/received_events","type":"Organization","site_admin":false},"repo":{"id":65768540,"name":"connect","full_name":"prismskylabs/connect","owner":{"login":"prismskylabs","id":2381267,"avatar_url":"https://avatars0.githubusercontent.com/u/2381267?v=3","gravatar_id":"","url":"https://api.github.com/users/prismskylabs","html_url":"https://github.com/prismskylabs","followers_url":"https://api.github.com/users/prismskylabs/followers","following_url":"https://api.github.com/users/prismskylabs/following{/other_user}","gists_url":"https://api.github.com/users/prismskylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prismskylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismskylabs/subscriptions","organizations_url":"https://api.github.com/users/prismskylabs/orgs","repos_url":"https://api.github.com/users/prismskylabs/repos","events_url":"https://api.github.com/users/prismskylabs/events{/privacy}","received_events_url":"https://api.github.com/users/prismskylabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prismskylabs/connect","description":null,"fork":false,"url":"https://api.github.com/repos/prismskylabs/connect","forks_url":"https://api.github.com/repos/prismskylabs/connect/forks","keys_url":"https://api.github.com/repos/prismskylabs/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prismskylabs/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prismskylabs/connect/teams","hooks_url":"https://api.github.com/repos/prismskylabs/connect/hooks","issue_events_url":"https://api.github.com/repos/prismskylabs/connect/issues/events{/number}","events_url":"https://api.github.com/repos/prismskylabs/connect/events","assignees_url":"https://api.github.com/repos/prismskylabs/connect/assignees{/user}","branches_url":"https://api.github.com/repos/prismskylabs/connect/branches{/branch}","tags_url":"https://api.github.com/repos/prismskylabs/connect/tags","blobs_url":"https://api.github.com/repos/prismskylabs/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prismskylabs/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prismskylabs/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/prismskylabs/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prismskylabs/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/prismskylabs/connect/languages","stargazers_url":"https://api.github.com/repos/prismskylabs/connect/stargazers","contributors_url":"https://api.github.com/repos/prismskylabs/connect/contributors","subscribers_url":"https://api.github.com/repos/prismskylabs/connect/subscribers","subscription_url":"https://api.github.com/repos/prismskylabs/connect/subscription","commits_url":"https://api.github.com/repos/prismskylabs/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/prismskylabs/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/prismskylabs/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/prismskylabs/connect/issues/comments{/number}","contents_url":"https://api.github.com/repos/prismskylabs/connect/contents/{+path}","compare_url":"https://api.github.com/repos/prismskylabs/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prismskylabs/connect/merges","archive_url":"https://api.github.com/repos/prismskylabs/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prismskylabs/connect/downloads","issues_url":"https://api.github.com/repos/prismskylabs/connect/issues{/number}","pulls_url":"https://api.github.com/repos/prismskylabs/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/prismskylabs/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/prismskylabs/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prismskylabs/connect/labels{/name}","releases_url":"https://api.github.com/repos/prismskylabs/connect/releases{/id}","deployments_url":"https://api.github.com/repos/prismskylabs/connect/deployments","created_at":"2016-08-15T22:13:37Z","updated_at":"2017-02-22T16:37:53Z","pushed_at":"2017-03-17T10:52:45Z","git_url":"git://github.com/prismskylabs/connect.git","ssh_url":"git@github.com:prismskylabs/connect.git","clone_url":"https://github.com/prismskylabs/connect.git","svn_url":"https://github.com/prismskylabs/connect","homepage":null,"size":569,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/38"},"html":{"href":"https://github.com/prismskylabs/connect/pull/38"},"issue":{"href":"https://api.github.com/repos/prismskylabs/connect/issues/38"},"comments":{"href":"https://api.github.com/repos/prismskylabs/connect/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/prismskylabs/connect/statuses/54ecd4f862a9ae3be8d1c2f1e71084ae06f671aa"}}}}
{"actor":{"display_login":"dbus-prsm"}}