{"action":"created","issue":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/1930","repository_url":"https://api.github.com/repos/MithrilJS/mithril.js","labels_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/1930/labels{/name}","comments_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/1930/comments","events_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/1930/events","html_url":"https://github.com/MithrilJS/mithril.js/pull/1930","id":248694064,"number":1930,"title":"Enable setting navigation options with m.route.link API","user":{"login":"orbitbot","id":2631164,"avatar_url":"https://avatars3.githubusercontent.com/u/2631164?v=4","gravatar_id":"","url":"https://api.github.com/users/orbitbot","html_url":"https://github.com/orbitbot","followers_url":"https://api.github.com/users/orbitbot/followers","following_url":"https://api.github.com/users/orbitbot/following{/other_user}","gists_url":"https://api.github.com/users/orbitbot/gists{/gist_id}","starred_url":"https://api.github.com/users/orbitbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbitbot/subscriptions","organizations_url":"https://api.github.com/users/orbitbot/orgs","repos_url":"https://api.github.com/users/orbitbot/repos","events_url":"https://api.github.com/users/orbitbot/events{/privacy}","received_events_url":"https://api.github.com/users/orbitbot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-08-08T12:10:49Z","updated_at":"2017-10-29T09:46:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/pulls/1930","html_url":"https://github.com/MithrilJS/mithril.js/pull/1930","diff_url":"https://github.com/MithrilJS/mithril.js/pull/1930.diff","patch_url":"https://github.com/MithrilJS/mithril.js/pull/1930.patch"},"body":"## Description\r\n\r\nSome refactoring to enable passing the `options` object to `m.route.set` using the `m.route.link` API in lifecycle methods.\r\n\r\n## Motivation and Context\r\n\r\nWith current functionality, there is no way to overwrite browser history entries and pass specific parameters to the history API with `m.route.link`, this always requires a custom method to be written.\r\n\r\nRelated issues #1807 #1810 \r\n\r\n## How Has This Been Tested?\r\n\r\n`npm t` with new test case.\r\n\r\n## Types of changes\r\n\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n- [ ] I have updated `docs/change-log.md`\r\n"},"comment":{"url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/comments/340249400","html_url":"https://github.com/MithrilJS/mithril.js/pull/1930#issuecomment-340249400","issue_url":"https://api.github.com/repos/MithrilJS/mithril.js/issues/1930","id":340249400,"user":{"login":"orbitbot","id":2631164,"avatar_url":"https://avatars3.githubusercontent.com/u/2631164?v=4","gravatar_id":"","url":"https://api.github.com/users/orbitbot","html_url":"https://github.com/orbitbot","followers_url":"https://api.github.com/users/orbitbot/followers","following_url":"https://api.github.com/users/orbitbot/following{/other_user}","gists_url":"https://api.github.com/users/orbitbot/gists{/gist_id}","starred_url":"https://api.github.com/users/orbitbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbitbot/subscriptions","organizations_url":"https://api.github.com/users/orbitbot/orgs","repos_url":"https://api.github.com/users/orbitbot/repos","events_url":"https://api.github.com/users/orbitbot/events{/privacy}","received_events_url":"https://api.github.com/users/orbitbot/received_events","type":"User","site_admin":false},"created_at":"2017-10-29T09:46:17Z","updated_at":"2017-10-29T09:46:17Z","author_association":"CONTRIBUTOR","body":"@isiahmeadows What's the proper heading to put a new `change-log.md` entry under? Is there going to be a `1.1.6`,  or should I just chuck a line somewhere in the `2.0.0` WIP section?"}}
{"actor":{"display_login":"orbitbot"}}