{"action":"created","comment":{"url":"https://api.github.com/repos/fission/fission/pulls/comments/118331649","pull_request_review_id":40110812,"id":118331649,"diff_hunk":"@@ -78,6 +105,7 @@ func (api *API) Serve(port int) {\n \tr.HandleFunc(\"/v1/functions/{function}\", api.FunctionApiGet).Methods(\"GET\")\n \tr.HandleFunc(\"/v1/functions/{function}\", api.FunctionApiUpdate).Methods(\"PUT\")\n \tr.HandleFunc(\"/v1/functions/{function}\", api.FunctionApiDelete).Methods(\"DELETE\")\n+\tr.HandleFunc(\"/v1/functions/{function}/logs/{dbType}\", api.FunctionLogsApiPost).Methods(\"POST\")","path":"controller/api.go","position":67,"original_position":67,"commit_id":"76a7ed296c40af6dedaa7efd0af1310838bcc271","original_commit_id":"76a7ed296c40af6dedaa7efd0af1310838bcc271","user":{"login":"soamvasani","id":16418446,"avatar_url":"https://avatars2.githubusercontent.com/u/16418446?v=3","gravatar_id":"","url":"https://api.github.com/users/soamvasani","html_url":"https://github.com/soamvasani","followers_url":"https://api.github.com/users/soamvasani/followers","following_url":"https://api.github.com/users/soamvasani/following{/other_user}","gists_url":"https://api.github.com/users/soamvasani/gists{/gist_id}","starred_url":"https://api.github.com/users/soamvasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soamvasani/subscriptions","organizations_url":"https://api.github.com/users/soamvasani/orgs","repos_url":"https://api.github.com/users/soamvasani/repos","events_url":"https://api.github.com/users/soamvasani/events{/privacy}","received_events_url":"https://api.github.com/users/soamvasani/received_events","type":"User","site_admin":false},"body":"Thinking about this path: It seems the `{function}` variable is not really being used? The query from the CLI has the function name. \r\n\r\nAlso this isn't really part of the versioned API. The API is still influxdb's, this is just a proxy.\r\n\r\nHow about simply `/proxy/{dbType}`?","created_at":"2017-05-24T18:34:02Z","updated_at":"2017-05-24T18:38:28Z","html_url":"https://github.com/fission/fission/pull/207#discussion_r118331649","pull_request_url":"https://api.github.com/repos/fission/fission/pulls/207","_links":{"self":{"href":"https://api.github.com/repos/fission/fission/pulls/comments/118331649"},"html":{"href":"https://github.com/fission/fission/pull/207#discussion_r118331649"},"pull_request":{"href":"https://api.github.com/repos/fission/fission/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/fission/fission/pulls/207","id":122278803,"html_url":"https://github.com/fission/fission/pull/207","diff_url":"https://github.com/fission/fission/pull/207.diff","patch_url":"https://github.com/fission/fission/pull/207.patch","issue_url":"https://api.github.com/repos/fission/fission/issues/207","number":207,"state":"open","locked":false,"title":"Retrieve function logs from controller","user":{"login":"life1347","id":202578,"avatar_url":"https://avatars2.githubusercontent.com/u/202578?v=3","gravatar_id":"","url":"https://api.github.com/users/life1347","html_url":"https://github.com/life1347","followers_url":"https://api.github.com/users/life1347/followers","following_url":"https://api.github.com/users/life1347/following{/other_user}","gists_url":"https://api.github.com/users/life1347/gists{/gist_id}","starred_url":"https://api.github.com/users/life1347/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/life1347/subscriptions","organizations_url":"https://api.github.com/users/life1347/orgs","repos_url":"https://api.github.com/users/life1347/repos","events_url":"https://api.github.com/users/life1347/events{/privacy}","received_events_url":"https://api.github.com/users/life1347/received_events","type":"User","site_admin":false},"body":"This PR tries to let controller establishes a reverse proxy to log database, and redirect query command send from client to database and then proxy back the db responses. So that we dont need to expose database to the public network.","created_at":"2017-05-24T17:08:01Z","updated_at":"2017-05-24T18:38:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dac58f841c3d77bc0c09ef889202ac1ab7e1589","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fission/fission/pulls/207/commits","review_comments_url":"https://api.github.com/repos/fission/fission/pulls/207/comments","review_comment_url":"https://api.github.com/repos/fission/fission/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fission/fission/issues/207/comments","statuses_url":"https://api.github.com/repos/fission/fission/statuses/76a7ed296c40af6dedaa7efd0af1310838bcc271","head":{"label":"life1347:proxy-streaming-log","ref":"proxy-streaming-log","sha":"76a7ed296c40af6dedaa7efd0af1310838bcc271","user":{"login":"life1347","id":202578,"avatar_url":"https://avatars2.githubusercontent.com/u/202578?v=3","gravatar_id":"","url":"https://api.github.com/users/life1347","html_url":"https://github.com/life1347","followers_url":"https://api.github.com/users/life1347/followers","following_url":"https://api.github.com/users/life1347/following{/other_user}","gists_url":"https://api.github.com/users/life1347/gists{/gist_id}","starred_url":"https://api.github.com/users/life1347/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/life1347/subscriptions","organizations_url":"https://api.github.com/users/life1347/orgs","repos_url":"https://api.github.com/users/life1347/repos","events_url":"https://api.github.com/users/life1347/events{/privacy}","received_events_url":"https://api.github.com/users/life1347/received_events","type":"User","site_admin":false},"repo":{"id":81588221,"name":"fission","full_name":"life1347/fission","owner":{"login":"life1347","id":202578,"avatar_url":"https://avatars2.githubusercontent.com/u/202578?v=3","gravatar_id":"","url":"https://api.github.com/users/life1347","html_url":"https://github.com/life1347","followers_url":"https://api.github.com/users/life1347/followers","following_url":"https://api.github.com/users/life1347/following{/other_user}","gists_url":"https://api.github.com/users/life1347/gists{/gist_id}","starred_url":"https://api.github.com/users/life1347/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/life1347/subscriptions","organizations_url":"https://api.github.com/users/life1347/orgs","repos_url":"https://api.github.com/users/life1347/repos","events_url":"https://api.github.com/users/life1347/events{/privacy}","received_events_url":"https://api.github.com/users/life1347/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/life1347/fission","description":"Fast Serverless Functions for Kubernetes","fork":true,"url":"https://api.github.com/repos/life1347/fission","forks_url":"https://api.github.com/repos/life1347/fission/forks","keys_url":"https://api.github.com/repos/life1347/fission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/life1347/fission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/life1347/fission/teams","hooks_url":"https://api.github.com/repos/life1347/fission/hooks","issue_events_url":"https://api.github.com/repos/life1347/fission/issues/events{/number}","events_url":"https://api.github.com/repos/life1347/fission/events","assignees_url":"https://api.github.com/repos/life1347/fission/assignees{/user}","branches_url":"https://api.github.com/repos/life1347/fission/branches{/branch}","tags_url":"https://api.github.com/repos/life1347/fission/tags","blobs_url":"https://api.github.com/repos/life1347/fission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/life1347/fission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/life1347/fission/git/refs{/sha}","trees_url":"https://api.github.com/repos/life1347/fission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/life1347/fission/statuses/{sha}","languages_url":"https://api.github.com/repos/life1347/fission/languages","stargazers_url":"https://api.github.com/repos/life1347/fission/stargazers","contributors_url":"https://api.github.com/repos/life1347/fission/contributors","subscribers_url":"https://api.github.com/repos/life1347/fission/subscribers","subscription_url":"https://api.github.com/repos/life1347/fission/subscription","commits_url":"https://api.github.com/repos/life1347/fission/commits{/sha}","git_commits_url":"https://api.github.com/repos/life1347/fission/git/commits{/sha}","comments_url":"https://api.github.com/repos/life1347/fission/comments{/number}","issue_comment_url":"https://api.github.com/repos/life1347/fission/issues/comments{/number}","contents_url":"https://api.github.com/repos/life1347/fission/contents/{+path}","compare_url":"https://api.github.com/repos/life1347/fission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/life1347/fission/merges","archive_url":"https://api.github.com/repos/life1347/fission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/life1347/fission/downloads","issues_url":"https://api.github.com/repos/life1347/fission/issues{/number}","pulls_url":"https://api.github.com/repos/life1347/fission/pulls{/number}","milestones_url":"https://api.github.com/repos/life1347/fission/milestones{/number}","notifications_url":"https://api.github.com/repos/life1347/fission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/life1347/fission/labels{/name}","releases_url":"https://api.github.com/repos/life1347/fission/releases{/id}","deployments_url":"https://api.github.com/repos/life1347/fission/deployments","created_at":"2017-02-10T17:17:58Z","updated_at":"2017-02-10T17:18:00Z","pushed_at":"2017-05-24T17:05:20Z","git_url":"git://github.com/life1347/fission.git","ssh_url":"git@github.com:life1347/fission.git","clone_url":"https://github.com/life1347/fission.git","svn_url":"https://github.com/life1347/fission","homepage":"http://fission.io","size":403,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fission:master","ref":"master","sha":"531f69a0374b7613132c60ca1953202422c961e7","user":{"login":"fission","id":24659215,"avatar_url":"https://avatars1.githubusercontent.com/u/24659215?v=3","gravatar_id":"","url":"https://api.github.com/users/fission","html_url":"https://github.com/fission","followers_url":"https://api.github.com/users/fission/followers","following_url":"https://api.github.com/users/fission/following{/other_user}","gists_url":"https://api.github.com/users/fission/gists{/gist_id}","starred_url":"https://api.github.com/users/fission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fission/subscriptions","organizations_url":"https://api.github.com/users/fission/orgs","repos_url":"https://api.github.com/users/fission/repos","events_url":"https://api.github.com/users/fission/events{/privacy}","received_events_url":"https://api.github.com/users/fission/received_events","type":"Organization","site_admin":false},"repo":{"id":66050533,"name":"fission","full_name":"fission/fission","owner":{"login":"fission","id":24659215,"avatar_url":"https://avatars1.githubusercontent.com/u/24659215?v=3","gravatar_id":"","url":"https://api.github.com/users/fission","html_url":"https://github.com/fission","followers_url":"https://api.github.com/users/fission/followers","following_url":"https://api.github.com/users/fission/following{/other_user}","gists_url":"https://api.github.com/users/fission/gists{/gist_id}","starred_url":"https://api.github.com/users/fission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fission/subscriptions","organizations_url":"https://api.github.com/users/fission/orgs","repos_url":"https://api.github.com/users/fission/repos","events_url":"https://api.github.com/users/fission/events{/privacy}","received_events_url":"https://api.github.com/users/fission/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fission/fission","description":"Fast Serverless Functions for Kubernetes","fork":false,"url":"https://api.github.com/repos/fission/fission","forks_url":"https://api.github.com/repos/fission/fission/forks","keys_url":"https://api.github.com/repos/fission/fission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fission/fission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fission/fission/teams","hooks_url":"https://api.github.com/repos/fission/fission/hooks","issue_events_url":"https://api.github.com/repos/fission/fission/issues/events{/number}","events_url":"https://api.github.com/repos/fission/fission/events","assignees_url":"https://api.github.com/repos/fission/fission/assignees{/user}","branches_url":"https://api.github.com/repos/fission/fission/branches{/branch}","tags_url":"https://api.github.com/repos/fission/fission/tags","blobs_url":"https://api.github.com/repos/fission/fission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fission/fission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fission/fission/git/refs{/sha}","trees_url":"https://api.github.com/repos/fission/fission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fission/fission/statuses/{sha}","languages_url":"https://api.github.com/repos/fission/fission/languages","stargazers_url":"https://api.github.com/repos/fission/fission/stargazers","contributors_url":"https://api.github.com/repos/fission/fission/contributors","subscribers_url":"https://api.github.com/repos/fission/fission/subscribers","subscription_url":"https://api.github.com/repos/fission/fission/subscription","commits_url":"https://api.github.com/repos/fission/fission/commits{/sha}","git_commits_url":"https://api.github.com/repos/fission/fission/git/commits{/sha}","comments_url":"https://api.github.com/repos/fission/fission/comments{/number}","issue_comment_url":"https://api.github.com/repos/fission/fission/issues/comments{/number}","contents_url":"https://api.github.com/repos/fission/fission/contents/{+path}","compare_url":"https://api.github.com/repos/fission/fission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fission/fission/merges","archive_url":"https://api.github.com/repos/fission/fission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fission/fission/downloads","issues_url":"https://api.github.com/repos/fission/fission/issues{/number}","pulls_url":"https://api.github.com/repos/fission/fission/pulls{/number}","milestones_url":"https://api.github.com/repos/fission/fission/milestones{/number}","notifications_url":"https://api.github.com/repos/fission/fission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fission/fission/labels{/name}","releases_url":"https://api.github.com/repos/fission/fission/releases{/id}","deployments_url":"https://api.github.com/repos/fission/fission/deployments","created_at":"2016-08-19T03:43:56Z","updated_at":"2017-05-24T17:23:00Z","pushed_at":"2017-05-24T17:08:02Z","git_url":"git://github.com/fission/fission.git","ssh_url":"git@github.com:fission/fission.git","clone_url":"https://github.com/fission/fission.git","svn_url":"https://github.com/fission/fission","homepage":"http://fission.io","size":398,"stargazers_count":1902,"watchers_count":1902,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":64,"forks":119,"open_issues":64,"watchers":1902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fission/fission/pulls/207"},"html":{"href":"https://github.com/fission/fission/pull/207"},"issue":{"href":"https://api.github.com/repos/fission/fission/issues/207"},"comments":{"href":"https://api.github.com/repos/fission/fission/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/fission/fission/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/fission/fission/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fission/fission/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/fission/fission/statuses/76a7ed296c40af6dedaa7efd0af1310838bcc271"}}}}
{"actor":{"display_login":"soamvasani"}}