{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/133648798","pull_request_review_id":56852844,"id":133648798,"diff_hunk":"@@ -52,6 +52,12 @@ func (k *VolumeMountController) mountMasterVolumes() ([]*Volume, error) {\n \t}\n \n \tfor _, v := range attached {\n+\t\t// Do not ever try to mount root devices\n+\t\tif v.LocalDevice == \"/dev/sda1\" || v.LocalDevice == \"/dev/xvda\" {","path":"protokube/pkg/protokube/volume_mounter.go","position":5,"original_position":5,"commit_id":"b5e96ae63baf843b806bef45618941b970e4625a","original_commit_id":"b5e96ae63baf843b806bef45618941b970e4625a","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"I think this is just going to bite us later and it shouldn't be needed anyway.  Also presumably the root volumes are always attached?","created_at":"2017-08-17T08:13:16Z","updated_at":"2017-08-17T08:18:04Z","html_url":"https://github.com/kubernetes/kops/pull/3208#discussion_r133648798","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/3208","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/133648798"},"html":{"href":"https://github.com/kubernetes/kops/pull/3208#discussion_r133648798"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3208"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/3208","id":135894022,"html_url":"https://github.com/kubernetes/kops/pull/3208","diff_url":"https://github.com/kubernetes/kops/pull/3208.diff","patch_url":"https://github.com/kubernetes/kops/pull/3208.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/3208","number":3208,"state":"open","locked":false,"title":"Improving etcd volume detection logic, ensuring that root volumes are not mounted","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/kubernetes/kops/issues/3167\r\n\r\nWhen an AWS account has functionality that adds an ec2 instance tags to a volume automatically, protokube can attempt to mount the root volume.  This PR tightens the logic for detecting etcd volumes.  Also, the two volumes that AWS defines as root volume devices are never mounted. Added a unit test, which required refactoring of the code into a separate method.","created_at":"2017-08-15T21:16:41Z","updated_at":"2017-08-17T08:18:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3f8d5a84f0c4a5c2e5d26b5a54b40ee985bc21b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/3208/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/3208/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/3208/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/b5e96ae63baf843b806bef45618941b970e4625a","head":{"label":"chrislovecnm:protokube-volume-mount-fixes","ref":"protokube-volume-mount-fixes","sha":"b5e96ae63baf843b806bef45618941b970e4625a","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"repo":{"id":64396897,"name":"kops","full_name":"chrislovecnm/kops","owner":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrislovecnm/kops","description":"kops deployment","fork":true,"url":"https://api.github.com/repos/chrislovecnm/kops","forks_url":"https://api.github.com/repos/chrislovecnm/kops/forks","keys_url":"https://api.github.com/repos/chrislovecnm/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrislovecnm/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrislovecnm/kops/teams","hooks_url":"https://api.github.com/repos/chrislovecnm/kops/hooks","issue_events_url":"https://api.github.com/repos/chrislovecnm/kops/issues/events{/number}","events_url":"https://api.github.com/repos/chrislovecnm/kops/events","assignees_url":"https://api.github.com/repos/chrislovecnm/kops/assignees{/user}","branches_url":"https://api.github.com/repos/chrislovecnm/kops/branches{/branch}","tags_url":"https://api.github.com/repos/chrislovecnm/kops/tags","blobs_url":"https://api.github.com/repos/chrislovecnm/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrislovecnm/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrislovecnm/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrislovecnm/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrislovecnm/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/chrislovecnm/kops/languages","stargazers_url":"https://api.github.com/repos/chrislovecnm/kops/stargazers","contributors_url":"https://api.github.com/repos/chrislovecnm/kops/contributors","subscribers_url":"https://api.github.com/repos/chrislovecnm/kops/subscribers","subscription_url":"https://api.github.com/repos/chrislovecnm/kops/subscription","commits_url":"https://api.github.com/repos/chrislovecnm/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrislovecnm/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrislovecnm/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrislovecnm/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrislovecnm/kops/contents/{+path}","compare_url":"https://api.github.com/repos/chrislovecnm/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrislovecnm/kops/merges","archive_url":"https://api.github.com/repos/chrislovecnm/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrislovecnm/kops/downloads","issues_url":"https://api.github.com/repos/chrislovecnm/kops/issues{/number}","pulls_url":"https://api.github.com/repos/chrislovecnm/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/chrislovecnm/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/chrislovecnm/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrislovecnm/kops/labels{/name}","releases_url":"https://api.github.com/repos/chrislovecnm/kops/releases{/id}","deployments_url":"https://api.github.com/repos/chrislovecnm/kops/deployments","created_at":"2016-07-28T13:14:34Z","updated_at":"2016-07-28T13:14:37Z","pushed_at":"2017-08-15T21:12:00Z","git_url":"git://github.com/chrislovecnm/kops.git","ssh_url":"git@github.com:chrislovecnm/kops.git","clone_url":"https://github.com/chrislovecnm/kops.git","svn_url":"https://github.com/chrislovecnm/kops","homepage":"","size":137088,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"fd7a6a301834ba1db3da296c04781644cee242eb","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2017-08-17T07:52:40Z","pushed_at":"2017-08-16T18:52:38Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":149169,"stargazers_count":2522,"watchers_count":2522,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":665,"mirror_url":null,"open_issues_count":846,"forks":665,"open_issues":846,"watchers":2522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3208"},"html":{"href":"https://github.com/kubernetes/kops/pull/3208"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/3208"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/3208/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3208/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3208/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/b5e96ae63baf843b806bef45618941b970e4625a"}}}}
{"actor":{"display_login":"justinsb"}}