{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/comments/124427960","pull_request_review_id":46714879,"id":124427960,"diff_hunk":"@@ -0,0 +1,122 @@\n+﻿// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the MIT License. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Reflection;\n+using System.Threading;\n+using System.Threading.Tasks;\n+using Microsoft.Extensions.Logging;\n+\n+namespace Microsoft.Azure.WebJobs.Host\n+{\n+    /// <summary>\n+    /// An invocation filter that invokes job methods\n+    /// </summary>\n+    [CLSCompliant(false)]\n+    [AttributeUsage(AttributeTargets.Class | AttributeTargets.Method, Inherited = true, AllowMultiple = true)]\n+    public sealed class InvokeFunctionFilterAttribute : InvocationFilterAttribute\n+    {\n+        /// <summary>\n+        /// When this attribute is used, take the name of the function to invoke\n+        /// </summary>\n+        /// <param name=\"executingFilter\"></param>\n+        /// <param name=\"executedFilter\"></param>\n+        public InvokeFunctionFilterAttribute(string executingFilter = null, string executedFilter = null)\n+        {\n+            ExecutingFilter = executingFilter;\n+            ExecutedFilter = executedFilter;\n+        }\n+\n+        /// <summary>\n+        /// Executing filter\n+        /// </summary>\n+        public string ExecutingFilter { get; }","path":"src/Microsoft.Azure.WebJobs.Host/InvokeFunctionFilterAttribute.cs","position":35,"original_position":35,"commit_id":"bb1c78dee5ba17b26271738d6d1f6646c9d9a5fa","original_commit_id":"bb1c78dee5ba17b26271738d6d1f6646c9d9a5fa","user":{"login":"mathewc","id":1056548,"avatar_url":"https://avatars0.githubusercontent.com/u/1056548?v=3","gravatar_id":"","url":"https://api.github.com/users/mathewc","html_url":"https://github.com/mathewc","followers_url":"https://api.github.com/users/mathewc/followers","following_url":"https://api.github.com/users/mathewc/following{/other_user}","gists_url":"https://api.github.com/users/mathewc/gists{/gist_id}","starred_url":"https://api.github.com/users/mathewc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathewc/subscriptions","organizations_url":"https://api.github.com/users/mathewc/orgs","repos_url":"https://api.github.com/users/mathewc/repos","events_url":"https://api.github.com/users/mathewc/events{/privacy}","received_events_url":"https://api.github.com/users/mathewc/received_events","type":"User","site_admin":false},"body":"Yes, I was thinking the same thing. Right now he's bee using just simple short names, but in cases where there may be multiple job classes with the same name (collisions), we'll need namespacing. I was thinking we should support both short and long names - e.g. if the name is \"Foo\", we return the first Foo function we find. If the name is \"Bar.Foo\" we look for type \"Bar\" in the type locator, and return its \"Foo\" function.","created_at":"2017-06-28T00:19:23Z","updated_at":"2017-06-28T00:19:23Z","html_url":"https://github.com/Azure/azure-webjobs-sdk/pull/1207#discussion_r124427960","pull_request_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1207","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/comments/124427960"},"html":{"href":"https://github.com/Azure/azure-webjobs-sdk/pull/1207#discussion_r124427960"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1207"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1207","id":127807188,"html_url":"https://github.com/Azure/azure-webjobs-sdk/pull/1207","diff_url":"https://github.com/Azure/azure-webjobs-sdk/pull/1207.diff","patch_url":"https://github.com/Azure/azure-webjobs-sdk/pull/1207.patch","issue_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/1207","number":1207,"state":"open","locked":false,"title":"Function Invocation Filters","user":{"login":"hhawkins","id":4063500,"avatar_url":"https://avatars0.githubusercontent.com/u/4063500?v=3","gravatar_id":"","url":"https://api.github.com/users/hhawkins","html_url":"https://github.com/hhawkins","followers_url":"https://api.github.com/users/hhawkins/followers","following_url":"https://api.github.com/users/hhawkins/following{/other_user}","gists_url":"https://api.github.com/users/hhawkins/gists{/gist_id}","starred_url":"https://api.github.com/users/hhawkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhawkins/subscriptions","organizations_url":"https://api.github.com/users/hhawkins/orgs","repos_url":"https://api.github.com/users/hhawkins/repos","events_url":"https://api.github.com/users/hhawkins/events{/privacy}","received_events_url":"https://api.github.com/users/hhawkins/received_events","type":"User","site_admin":false},"body":"For feature tracked here: #980. Sending out another pull request after making updates and changes from feedback from the first pull request #1189 ","created_at":"2017-06-27T22:32:46Z","updated_at":"2017-06-28T00:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"818787fa177cb72a28935f0dfbfe2fc276aca9c4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1207/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1207/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/1207/comments","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/statuses/bb1c78dee5ba17b26271738d6d1f6646c9d9a5fa","head":{"label":"hhawkins:InvocationFilterAttribute","ref":"InvocationFilterAttribute","sha":"bb1c78dee5ba17b26271738d6d1f6646c9d9a5fa","user":{"login":"hhawkins","id":4063500,"avatar_url":"https://avatars0.githubusercontent.com/u/4063500?v=3","gravatar_id":"","url":"https://api.github.com/users/hhawkins","html_url":"https://github.com/hhawkins","followers_url":"https://api.github.com/users/hhawkins/followers","following_url":"https://api.github.com/users/hhawkins/following{/other_user}","gists_url":"https://api.github.com/users/hhawkins/gists{/gist_id}","starred_url":"https://api.github.com/users/hhawkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhawkins/subscriptions","organizations_url":"https://api.github.com/users/hhawkins/orgs","repos_url":"https://api.github.com/users/hhawkins/repos","events_url":"https://api.github.com/users/hhawkins/events{/privacy}","received_events_url":"https://api.github.com/users/hhawkins/received_events","type":"User","site_admin":false},"repo":{"id":92422988,"name":"azure-webjobs-sdk","full_name":"hhawkins/azure-webjobs-sdk","owner":{"login":"hhawkins","id":4063500,"avatar_url":"https://avatars0.githubusercontent.com/u/4063500?v=3","gravatar_id":"","url":"https://api.github.com/users/hhawkins","html_url":"https://github.com/hhawkins","followers_url":"https://api.github.com/users/hhawkins/followers","following_url":"https://api.github.com/users/hhawkins/following{/other_user}","gists_url":"https://api.github.com/users/hhawkins/gists{/gist_id}","starred_url":"https://api.github.com/users/hhawkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhawkins/subscriptions","organizations_url":"https://api.github.com/users/hhawkins/orgs","repos_url":"https://api.github.com/users/hhawkins/repos","events_url":"https://api.github.com/users/hhawkins/events{/privacy}","received_events_url":"https://api.github.com/users/hhawkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hhawkins/azure-webjobs-sdk","description":"Azure WebJobs SDK","fork":true,"url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk","forks_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/forks","keys_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/teams","hooks_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/hooks","issue_events_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/events","assignees_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/tags","blobs_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/languages","stargazers_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/stargazers","contributors_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/contributors","subscribers_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/subscribers","subscription_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/subscription","commits_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/merges","archive_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/downloads","issues_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/labels{/name}","releases_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/hhawkins/azure-webjobs-sdk/deployments","created_at":"2017-05-25T16:31:22Z","updated_at":"2017-05-25T16:31:26Z","pushed_at":"2017-06-27T22:29:26Z","git_url":"git://github.com/hhawkins/azure-webjobs-sdk.git","ssh_url":"git@github.com:hhawkins/azure-webjobs-sdk.git","clone_url":"https://github.com/hhawkins/azure-webjobs-sdk.git","svn_url":"https://github.com/hhawkins/azure-webjobs-sdk","homepage":"","size":13219,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"ff15d0a7c4dd91370406111a7cc59f9c66637aa5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":21712185,"name":"azure-webjobs-sdk","full_name":"Azure/azure-webjobs-sdk","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-webjobs-sdk","description":"Azure WebJobs SDK","fork":false,"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk","forks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/forks","keys_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/teams","hooks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/events","assignees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/tags","blobs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/subscription","commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/merges","archive_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/downloads","issues_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/deployments","created_at":"2014-07-10T22:15:31Z","updated_at":"2017-06-21T17:30:28Z","pushed_at":"2017-06-27T22:32:46Z","git_url":"git://github.com/Azure/azure-webjobs-sdk.git","ssh_url":"git@github.com:Azure/azure-webjobs-sdk.git","clone_url":"https://github.com/Azure/azure-webjobs-sdk.git","svn_url":"https://github.com/Azure/azure-webjobs-sdk","homepage":"","size":13201,"stargazers_count":205,"watchers_count":205,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"open_issues_count":278,"forks":109,"open_issues":278,"watchers":205,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1207"},"html":{"href":"https://github.com/Azure/azure-webjobs-sdk/pull/1207"},"issue":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/1207"},"comments":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/1207/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1207/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1207/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/statuses/bb1c78dee5ba17b26271738d6d1f6646c9d9a5fa"}}}}
{"actor":{"display_login":"mathewc"}}