{"action":"created","issue":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1384","repository_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1384/labels{/name}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1384/comments","events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1384/events","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1384","id":198910481,"number":1384,"title":"[JBDS-4227] cleaning up code","user":{"login":"adietish","id":25126,"avatar_url":"https://avatars.githubusercontent.com/u/25126?v=3","gravatar_id":"","url":"https://api.github.com/users/adietish","html_url":"https://github.com/adietish","followers_url":"https://api.github.com/users/adietish/followers","following_url":"https://api.github.com/users/adietish/following{/other_user}","gists_url":"https://api.github.com/users/adietish/gists{/gist_id}","starred_url":"https://api.github.com/users/adietish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adietish/subscriptions","organizations_url":"https://api.github.com/users/adietish/orgs","repos_url":"https://api.github.com/users/adietish/repos","events_url":"https://api.github.com/users/adietish/events{/privacy}","received_events_url":"https://api.github.com/users/adietish/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-01-05T09:27:07Z","updated_at":"2017-01-05T11:04:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1384","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1384","diff_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1384.diff","patch_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1384.patch"},"body":"# Pull Request Checklist\r\n## General\r\n* Is this a blocking issue or new feature? If yes, QE needs to +1 this PR\r\n\r\n## Code\r\n* Are method-/class-/variable-names meaningful?\r\n* Are methods concise, not too long?\r\n* Are catch blocks catching precise Exceptions only (no catch all)?\r\n\r\n## Testing\r\n* Are there unit-tests?\r\n* Are there integration tests (or at least a jira to tackle these)?\r\n* Is the non-happy path working, too?\r\n* Are other parts that use the same component still working fine?\r\n\r\n## Function\r\n* Does it work?\r\n"},"comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/comments/270619381","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1384#issuecomment-270619381","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1384","id":270619381,"user":{"login":"adietish","id":25126,"avatar_url":"https://avatars.githubusercontent.com/u/25126?v=3","gravatar_id":"","url":"https://api.github.com/users/adietish","html_url":"https://github.com/adietish","followers_url":"https://api.github.com/users/adietish/followers","following_url":"https://api.github.com/users/adietish/following{/other_user}","gists_url":"https://api.github.com/users/adietish/gists{/gist_id}","starred_url":"https://api.github.com/users/adietish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adietish/subscriptions","organizations_url":"https://api.github.com/users/adietish/orgs","repos_url":"https://api.github.com/users/adietish/repos","events_url":"https://api.github.com/users/adietish/events{/privacy}","received_events_url":"https://api.github.com/users/adietish/received_events","type":"User","site_admin":false},"created_at":"2017-01-05T11:04:07Z","updated_at":"2017-01-05T11:04:07Z","body":"@bdshadow great, thx!\r\nmaybe you can have a look at this cleanup PR and accept/refuse it?"}}
{"actor":{"display_login":"adietish"}}