{"action":"created","comment":{"url":"https://api.github.com/repos/netsec-ethz/lfd/pulls/comments/143395918","pull_request_review_id":67900434,"id":143395918,"diff_hunk":"@@ -44,7 +44,7 @@ var (\n \n     // trace for testing\n     trace *TraceData\n-    pcapFilename = \"../resource/10K-test-pkts\"\n+    pcapFilename = \"../resource/equinix-chicago.dirA.20160406-125912.UTC.anon.pcap\"","path":"caida/caida_test.go","position":5,"original_position":5,"commit_id":"f44a38b6550b52e78876648eda0c4880c18c9830","original_commit_id":"f44a38b6550b52e78876648eda0c4880c18c9830","user":{"login":"haowu-uiuc","id":19209948,"avatar_url":"https://avatars0.githubusercontent.com/u/19209948?v=4","gravatar_id":"","url":"https://api.github.com/users/haowu-uiuc","html_url":"https://github.com/haowu-uiuc","followers_url":"https://api.github.com/users/haowu-uiuc/followers","following_url":"https://api.github.com/users/haowu-uiuc/following{/other_user}","gists_url":"https://api.github.com/users/haowu-uiuc/gists{/gist_id}","starred_url":"https://api.github.com/users/haowu-uiuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haowu-uiuc/subscriptions","organizations_url":"https://api.github.com/users/haowu-uiuc/orgs","repos_url":"https://api.github.com/users/haowu-uiuc/repos","events_url":"https://api.github.com/users/haowu-uiuc/events{/privacy}","received_events_url":"https://api.github.com/users/haowu-uiuc/received_events","type":"User","site_admin":false},"body":"this line should not be changed. (probably you haven't rebase to the newest master branch)","created_at":"2017-10-09T07:18:19Z","updated_at":"2017-10-09T07:18:19Z","html_url":"https://github.com/netsec-ethz/lfd/pull/7#discussion_r143395918","pull_request_url":"https://api.github.com/repos/netsec-ethz/lfd/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/netsec-ethz/lfd/pulls/comments/143395918"},"html":{"href":"https://github.com/netsec-ethz/lfd/pull/7#discussion_r143395918"},"pull_request":{"href":"https://api.github.com/repos/netsec-ethz/lfd/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/netsec-ethz/lfd/pulls/7","id":145383891,"html_url":"https://github.com/netsec-ethz/lfd/pull/7","diff_url":"https://github.com/netsec-ethz/lfd/pull/7.diff","patch_url":"https://github.com/netsec-ethz/lfd/pull/7.patch","issue_url":"https://api.github.com/repos/netsec-ethz/lfd/issues/7","number":7,"state":"open","locked":false,"title":"RLFD: fix logical error to avoid false positives","user":{"login":"simonschdev","id":14912464,"avatar_url":"https://avatars3.githubusercontent.com/u/14912464?v=4","gravatar_id":"","url":"https://api.github.com/users/simonschdev","html_url":"https://github.com/simonschdev","followers_url":"https://api.github.com/users/simonschdev/followers","following_url":"https://api.github.com/users/simonschdev/following{/other_user}","gists_url":"https://api.github.com/users/simonschdev/gists{/gist_id}","starred_url":"https://api.github.com/users/simonschdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonschdev/subscriptions","organizations_url":"https://api.github.com/users/simonschdev/orgs","repos_url":"https://api.github.com/users/simonschdev/repos","events_url":"https://api.github.com/users/simonschdev/events{/privacy}","received_events_url":"https://api.github.com/users/simonschdev/received_events","type":"User","site_admin":false},"body":"According to the paper, RLFD has no false positives by design. However, there were false positives when running the test for the RLFD detector. This was mostly due to a logical error in the thresholding at the lowest counter level: The counter at the alternative index (cf. Cuckoo hashing) was always checked, even when the currently checked flow was not hashed to that counter. If there was (another) misbehaving flow at that alternative index, RLFD would report that the currently checked flow was misbehaving, leading to false positives. However, there was an easy fix for that.\r\n\r\nMoreover, the allowed rate gamma was cut to zero (by converting it to uint32), leading to distortion of results.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/netsec-ethz/lfd/7)\n<!-- Reviewable:end -->\n","created_at":"2017-10-09T07:01:07Z","updated_at":"2017-10-09T07:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c68dbed04cca565f67940417b439c56de7094f09","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hosslen","id":16257508,"avatar_url":"https://avatars1.githubusercontent.com/u/16257508?v=4","gravatar_id":"","url":"https://api.github.com/users/hosslen","html_url":"https://github.com/hosslen","followers_url":"https://api.github.com/users/hosslen/followers","following_url":"https://api.github.com/users/hosslen/following{/other_user}","gists_url":"https://api.github.com/users/hosslen/gists{/gist_id}","starred_url":"https://api.github.com/users/hosslen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosslen/subscriptions","organizations_url":"https://api.github.com/users/hosslen/orgs","repos_url":"https://api.github.com/users/hosslen/repos","events_url":"https://api.github.com/users/hosslen/events{/privacy}","received_events_url":"https://api.github.com/users/hosslen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/netsec-ethz/lfd/pulls/7/commits","review_comments_url":"https://api.github.com/repos/netsec-ethz/lfd/pulls/7/comments","review_comment_url":"https://api.github.com/repos/netsec-ethz/lfd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netsec-ethz/lfd/issues/7/comments","statuses_url":"https://api.github.com/repos/netsec-ethz/lfd/statuses/f44a38b6550b52e78876648eda0c4880c18c9830","head":{"label":"netsec-ethz:simonsch","ref":"simonsch","sha":"f44a38b6550b52e78876648eda0c4880c18c9830","user":{"login":"netsec-ethz","id":8159976,"avatar_url":"https://avatars3.githubusercontent.com/u/8159976?v=4","gravatar_id":"","url":"https://api.github.com/users/netsec-ethz","html_url":"https://github.com/netsec-ethz","followers_url":"https://api.github.com/users/netsec-ethz/followers","following_url":"https://api.github.com/users/netsec-ethz/following{/other_user}","gists_url":"https://api.github.com/users/netsec-ethz/gists{/gist_id}","starred_url":"https://api.github.com/users/netsec-ethz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netsec-ethz/subscriptions","organizations_url":"https://api.github.com/users/netsec-ethz/orgs","repos_url":"https://api.github.com/users/netsec-ethz/repos","events_url":"https://api.github.com/users/netsec-ethz/events{/privacy}","received_events_url":"https://api.github.com/users/netsec-ethz/received_events","type":"Organization","site_admin":false},"repo":{"id":83812584,"name":"lfd","full_name":"netsec-ethz/lfd","owner":{"login":"netsec-ethz","id":8159976,"avatar_url":"https://avatars3.githubusercontent.com/u/8159976?v=4","gravatar_id":"","url":"https://api.github.com/users/netsec-ethz","html_url":"https://github.com/netsec-ethz","followers_url":"https://api.github.com/users/netsec-ethz/followers","following_url":"https://api.github.com/users/netsec-ethz/following{/other_user}","gists_url":"https://api.github.com/users/netsec-ethz/gists{/gist_id}","starred_url":"https://api.github.com/users/netsec-ethz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netsec-ethz/subscriptions","organizations_url":"https://api.github.com/users/netsec-ethz/orgs","repos_url":"https://api.github.com/users/netsec-ethz/repos","events_url":"https://api.github.com/users/netsec-ethz/events{/privacy}","received_events_url":"https://api.github.com/users/netsec-ethz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netsec-ethz/lfd","description":"Large Flow Detector","fork":false,"url":"https://api.github.com/repos/netsec-ethz/lfd","forks_url":"https://api.github.com/repos/netsec-ethz/lfd/forks","keys_url":"https://api.github.com/repos/netsec-ethz/lfd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netsec-ethz/lfd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netsec-ethz/lfd/teams","hooks_url":"https://api.github.com/repos/netsec-ethz/lfd/hooks","issue_events_url":"https://api.github.com/repos/netsec-ethz/lfd/issues/events{/number}","events_url":"https://api.github.com/repos/netsec-ethz/lfd/events","assignees_url":"https://api.github.com/repos/netsec-ethz/lfd/assignees{/user}","branches_url":"https://api.github.com/repos/netsec-ethz/lfd/branches{/branch}","tags_url":"https://api.github.com/repos/netsec-ethz/lfd/tags","blobs_url":"https://api.github.com/repos/netsec-ethz/lfd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netsec-ethz/lfd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netsec-ethz/lfd/git/refs{/sha}","trees_url":"https://api.github.com/repos/netsec-ethz/lfd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netsec-ethz/lfd/statuses/{sha}","languages_url":"https://api.github.com/repos/netsec-ethz/lfd/languages","stargazers_url":"https://api.github.com/repos/netsec-ethz/lfd/stargazers","contributors_url":"https://api.github.com/repos/netsec-ethz/lfd/contributors","subscribers_url":"https://api.github.com/repos/netsec-ethz/lfd/subscribers","subscription_url":"https://api.github.com/repos/netsec-ethz/lfd/subscription","commits_url":"https://api.github.com/repos/netsec-ethz/lfd/commits{/sha}","git_commits_url":"https://api.github.com/repos/netsec-ethz/lfd/git/commits{/sha}","comments_url":"https://api.github.com/repos/netsec-ethz/lfd/comments{/number}","issue_comment_url":"https://api.github.com/repos/netsec-ethz/lfd/issues/comments{/number}","contents_url":"https://api.github.com/repos/netsec-ethz/lfd/contents/{+path}","compare_url":"https://api.github.com/repos/netsec-ethz/lfd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netsec-ethz/lfd/merges","archive_url":"https://api.github.com/repos/netsec-ethz/lfd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netsec-ethz/lfd/downloads","issues_url":"https://api.github.com/repos/netsec-ethz/lfd/issues{/number}","pulls_url":"https://api.github.com/repos/netsec-ethz/lfd/pulls{/number}","milestones_url":"https://api.github.com/repos/netsec-ethz/lfd/milestones{/number}","notifications_url":"https://api.github.com/repos/netsec-ethz/lfd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netsec-ethz/lfd/labels{/name}","releases_url":"https://api.github.com/repos/netsec-ethz/lfd/releases{/id}","deployments_url":"https://api.github.com/repos/netsec-ethz/lfd/deployments","created_at":"2017-03-03T15:27:17Z","updated_at":"2017-08-08T14:28:48Z","pushed_at":"2017-10-09T07:01:13Z","git_url":"git://github.com/netsec-ethz/lfd.git","ssh_url":"git@github.com:netsec-ethz/lfd.git","clone_url":"https://github.com/netsec-ethz/lfd.git","svn_url":"https://github.com/netsec-ethz/lfd","homepage":null,"size":316,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"netsec-ethz:master","ref":"master","sha":"f83d09371e4eea916209e79bb33de7f857089c6d","user":{"login":"netsec-ethz","id":8159976,"avatar_url":"https://avatars3.githubusercontent.com/u/8159976?v=4","gravatar_id":"","url":"https://api.github.com/users/netsec-ethz","html_url":"https://github.com/netsec-ethz","followers_url":"https://api.github.com/users/netsec-ethz/followers","following_url":"https://api.github.com/users/netsec-ethz/following{/other_user}","gists_url":"https://api.github.com/users/netsec-ethz/gists{/gist_id}","starred_url":"https://api.github.com/users/netsec-ethz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netsec-ethz/subscriptions","organizations_url":"https://api.github.com/users/netsec-ethz/orgs","repos_url":"https://api.github.com/users/netsec-ethz/repos","events_url":"https://api.github.com/users/netsec-ethz/events{/privacy}","received_events_url":"https://api.github.com/users/netsec-ethz/received_events","type":"Organization","site_admin":false},"repo":{"id":83812584,"name":"lfd","full_name":"netsec-ethz/lfd","owner":{"login":"netsec-ethz","id":8159976,"avatar_url":"https://avatars3.githubusercontent.com/u/8159976?v=4","gravatar_id":"","url":"https://api.github.com/users/netsec-ethz","html_url":"https://github.com/netsec-ethz","followers_url":"https://api.github.com/users/netsec-ethz/followers","following_url":"https://api.github.com/users/netsec-ethz/following{/other_user}","gists_url":"https://api.github.com/users/netsec-ethz/gists{/gist_id}","starred_url":"https://api.github.com/users/netsec-ethz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netsec-ethz/subscriptions","organizations_url":"https://api.github.com/users/netsec-ethz/orgs","repos_url":"https://api.github.com/users/netsec-ethz/repos","events_url":"https://api.github.com/users/netsec-ethz/events{/privacy}","received_events_url":"https://api.github.com/users/netsec-ethz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netsec-ethz/lfd","description":"Large Flow Detector","fork":false,"url":"https://api.github.com/repos/netsec-ethz/lfd","forks_url":"https://api.github.com/repos/netsec-ethz/lfd/forks","keys_url":"https://api.github.com/repos/netsec-ethz/lfd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netsec-ethz/lfd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netsec-ethz/lfd/teams","hooks_url":"https://api.github.com/repos/netsec-ethz/lfd/hooks","issue_events_url":"https://api.github.com/repos/netsec-ethz/lfd/issues/events{/number}","events_url":"https://api.github.com/repos/netsec-ethz/lfd/events","assignees_url":"https://api.github.com/repos/netsec-ethz/lfd/assignees{/user}","branches_url":"https://api.github.com/repos/netsec-ethz/lfd/branches{/branch}","tags_url":"https://api.github.com/repos/netsec-ethz/lfd/tags","blobs_url":"https://api.github.com/repos/netsec-ethz/lfd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netsec-ethz/lfd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netsec-ethz/lfd/git/refs{/sha}","trees_url":"https://api.github.com/repos/netsec-ethz/lfd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netsec-ethz/lfd/statuses/{sha}","languages_url":"https://api.github.com/repos/netsec-ethz/lfd/languages","stargazers_url":"https://api.github.com/repos/netsec-ethz/lfd/stargazers","contributors_url":"https://api.github.com/repos/netsec-ethz/lfd/contributors","subscribers_url":"https://api.github.com/repos/netsec-ethz/lfd/subscribers","subscription_url":"https://api.github.com/repos/netsec-ethz/lfd/subscription","commits_url":"https://api.github.com/repos/netsec-ethz/lfd/commits{/sha}","git_commits_url":"https://api.github.com/repos/netsec-ethz/lfd/git/commits{/sha}","comments_url":"https://api.github.com/repos/netsec-ethz/lfd/comments{/number}","issue_comment_url":"https://api.github.com/repos/netsec-ethz/lfd/issues/comments{/number}","contents_url":"https://api.github.com/repos/netsec-ethz/lfd/contents/{+path}","compare_url":"https://api.github.com/repos/netsec-ethz/lfd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netsec-ethz/lfd/merges","archive_url":"https://api.github.com/repos/netsec-ethz/lfd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netsec-ethz/lfd/downloads","issues_url":"https://api.github.com/repos/netsec-ethz/lfd/issues{/number}","pulls_url":"https://api.github.com/repos/netsec-ethz/lfd/pulls{/number}","milestones_url":"https://api.github.com/repos/netsec-ethz/lfd/milestones{/number}","notifications_url":"https://api.github.com/repos/netsec-ethz/lfd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netsec-ethz/lfd/labels{/name}","releases_url":"https://api.github.com/repos/netsec-ethz/lfd/releases{/id}","deployments_url":"https://api.github.com/repos/netsec-ethz/lfd/deployments","created_at":"2017-03-03T15:27:17Z","updated_at":"2017-08-08T14:28:48Z","pushed_at":"2017-10-09T07:01:13Z","git_url":"git://github.com/netsec-ethz/lfd.git","ssh_url":"git@github.com:netsec-ethz/lfd.git","clone_url":"https://github.com/netsec-ethz/lfd.git","svn_url":"https://github.com/netsec-ethz/lfd","homepage":null,"size":316,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netsec-ethz/lfd/pulls/7"},"html":{"href":"https://github.com/netsec-ethz/lfd/pull/7"},"issue":{"href":"https://api.github.com/repos/netsec-ethz/lfd/issues/7"},"comments":{"href":"https://api.github.com/repos/netsec-ethz/lfd/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/netsec-ethz/lfd/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/netsec-ethz/lfd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netsec-ethz/lfd/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/netsec-ethz/lfd/statuses/f44a38b6550b52e78876648eda0c4880c18c9830"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"haowu-uiuc"}}