{"action":"created","comment":{"url":"https://api.github.com/repos/pfnet/chainercv/pulls/comments/114756703","pull_request_review_id":36248476,"id":114756703,"diff_hunk":"@@ -210,62 +78,30 @@ def __call__(self, trainer):\n         if not _available:\n             return\n \n-        for idx in self.indices:\n-            formated_filename_base = osp.join(trainer.out, self.filename_base)\n-            out_file = (formated_filename_base +\n-                        '_idx={}'.format(idx) +\n-                        '_iter={}'.format(trainer.updater.iteration) + '.jpg')\n-\n-            inputs = self.dataset[idx]\n-            self._check_type_dataset(inputs)\n+        label_names = getattr(self.dataset, 'labels', None)\n \n-            pred_bbox, pred_label = forward(self.target, inputs[0],\n-                                            forward_func=self.predict_func,\n-                                            expand_dim=True)\n-            if pred_bbox.ndim == 2:\n-                # force output to have batch axis\n-                pred_bbox = pred_bbox[None]\n-                pred_label = pred_label[None]\n-            self._check_type_model((pred_bbox, pred_label))\n-            pred_bbox = pred_bbox[0]  # (B, R, 5) -> (R, 5)\n+        for idx in six.moves.range(len(self.dataset)):\n+            out_file = self.filename.format(\n+                index=idx, iteration=trainer.updater.iteration)\n+            out_file = osp.join(trainer.out, out_file)\n \n-            vis_transformed = self.vis_transform(inputs)\n-            self._check_type_vis_transformed(vis_transformed)\n-            vis_img = vis_transformed[0]\n-            raw_bbox = vis_transformed[1]\n+            img, gt_bbox, gt_label = self.dataset[idx]","path":"chainercv/extensions/detection/detection_vis_report.py","position":252,"original_position":252,"commit_id":"f0b8fba7700a5e2a56b0d57af696118865e4b009","original_commit_id":"f0b8fba7700a5e2a56b0d57af696118865e4b009","user":{"login":"yuyu2172","id":2062128,"avatar_url":"https://avatars0.githubusercontent.com/u/2062128?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyu2172","html_url":"https://github.com/yuyu2172","followers_url":"https://api.github.com/users/yuyu2172/followers","following_url":"https://api.github.com/users/yuyu2172/following{/other_user}","gists_url":"https://api.github.com/users/yuyu2172/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyu2172/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyu2172/subscriptions","organizations_url":"https://api.github.com/users/yuyu2172/orgs","repos_url":"https://api.github.com/users/yuyu2172/repos","events_url":"https://api.github.com/users/yuyu2172/events{/privacy}","received_events_url":"https://api.github.com/users/yuyu2172/received_events","type":"User","site_admin":false},"body":"how about self.dataset[idx][:3]","created_at":"2017-05-04T12:08:14Z","updated_at":"2017-05-04T12:14:04Z","html_url":"https://github.com/pfnet/chainercv/pull/144#discussion_r114756703","pull_request_url":"https://api.github.com/repos/pfnet/chainercv/pulls/144","_links":{"self":{"href":"https://api.github.com/repos/pfnet/chainercv/pulls/comments/114756703"},"html":{"href":"https://github.com/pfnet/chainercv/pull/144#discussion_r114756703"},"pull_request":{"href":"https://api.github.com/repos/pfnet/chainercv/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/pfnet/chainercv/pulls/144","id":118897407,"html_url":"https://github.com/pfnet/chainercv/pull/144","diff_url":"https://github.com/pfnet/chainercv/pull/144.diff","patch_url":"https://github.com/pfnet/chainercv/pull/144.patch","issue_url":"https://api.github.com/repos/pfnet/chainercv/issues/144","number":144,"state":"open","locked":false,"title":"[WIP] Add abstract class for object detection","user":{"login":"Hakuyume","id":3014172,"avatar_url":"https://avatars0.githubusercontent.com/u/3014172?v=3","gravatar_id":"","url":"https://api.github.com/users/Hakuyume","html_url":"https://github.com/Hakuyume","followers_url":"https://api.github.com/users/Hakuyume/followers","following_url":"https://api.github.com/users/Hakuyume/following{/other_user}","gists_url":"https://api.github.com/users/Hakuyume/gists{/gist_id}","starred_url":"https://api.github.com/users/Hakuyume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hakuyume/subscriptions","organizations_url":"https://api.github.com/users/Hakuyume/orgs","repos_url":"https://api.github.com/users/Hakuyume/repos","events_url":"https://api.github.com/users/Hakuyume/events{/privacy}","received_events_url":"https://api.github.com/users/Hakuyume/received_events","type":"User","site_admin":false},"body":"- [x] Add `DetectionLink`\r\n- [x] Support `score` in `vis_bbox`\r\n- [x] Modify `DetectionVisReport` to use `DetectionLink`","created_at":"2017-05-04T04:14:18Z","updated_at":"2017-05-04T12:14:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b51feae11366fa0c19a78b37bb230741b524c73","assignee":{"login":"yuyu2172","id":2062128,"avatar_url":"https://avatars0.githubusercontent.com/u/2062128?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyu2172","html_url":"https://github.com/yuyu2172","followers_url":"https://api.github.com/users/yuyu2172/followers","following_url":"https://api.github.com/users/yuyu2172/following{/other_user}","gists_url":"https://api.github.com/users/yuyu2172/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyu2172/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyu2172/subscriptions","organizations_url":"https://api.github.com/users/yuyu2172/orgs","repos_url":"https://api.github.com/users/yuyu2172/repos","events_url":"https://api.github.com/users/yuyu2172/events{/privacy}","received_events_url":"https://api.github.com/users/yuyu2172/received_events","type":"User","site_admin":false},"assignees":[{"login":"yuyu2172","id":2062128,"avatar_url":"https://avatars0.githubusercontent.com/u/2062128?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyu2172","html_url":"https://github.com/yuyu2172","followers_url":"https://api.github.com/users/yuyu2172/followers","following_url":"https://api.github.com/users/yuyu2172/following{/other_user}","gists_url":"https://api.github.com/users/yuyu2172/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyu2172/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyu2172/subscriptions","organizations_url":"https://api.github.com/users/yuyu2172/orgs","repos_url":"https://api.github.com/users/yuyu2172/repos","events_url":"https://api.github.com/users/yuyu2172/events{/privacy}","received_events_url":"https://api.github.com/users/yuyu2172/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pfnet/chainercv/pulls/144/commits","review_comments_url":"https://api.github.com/repos/pfnet/chainercv/pulls/144/comments","review_comment_url":"https://api.github.com/repos/pfnet/chainercv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pfnet/chainercv/issues/144/comments","statuses_url":"https://api.github.com/repos/pfnet/chainercv/statuses/f0b8fba7700a5e2a56b0d57af696118865e4b009","head":{"label":"Hakuyume:detection-link","ref":"detection-link","sha":"f0b8fba7700a5e2a56b0d57af696118865e4b009","user":{"login":"Hakuyume","id":3014172,"avatar_url":"https://avatars0.githubusercontent.com/u/3014172?v=3","gravatar_id":"","url":"https://api.github.com/users/Hakuyume","html_url":"https://github.com/Hakuyume","followers_url":"https://api.github.com/users/Hakuyume/followers","following_url":"https://api.github.com/users/Hakuyume/following{/other_user}","gists_url":"https://api.github.com/users/Hakuyume/gists{/gist_id}","starred_url":"https://api.github.com/users/Hakuyume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hakuyume/subscriptions","organizations_url":"https://api.github.com/users/Hakuyume/orgs","repos_url":"https://api.github.com/users/Hakuyume/repos","events_url":"https://api.github.com/users/Hakuyume/events{/privacy}","received_events_url":"https://api.github.com/users/Hakuyume/received_events","type":"User","site_admin":false},"repo":{"id":84795454,"name":"chainercv","full_name":"Hakuyume/chainercv","owner":{"login":"Hakuyume","id":3014172,"avatar_url":"https://avatars0.githubusercontent.com/u/3014172?v=3","gravatar_id":"","url":"https://api.github.com/users/Hakuyume","html_url":"https://github.com/Hakuyume","followers_url":"https://api.github.com/users/Hakuyume/followers","following_url":"https://api.github.com/users/Hakuyume/following{/other_user}","gists_url":"https://api.github.com/users/Hakuyume/gists{/gist_id}","starred_url":"https://api.github.com/users/Hakuyume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hakuyume/subscriptions","organizations_url":"https://api.github.com/users/Hakuyume/orgs","repos_url":"https://api.github.com/users/Hakuyume/repos","events_url":"https://api.github.com/users/Hakuyume/events{/privacy}","received_events_url":"https://api.github.com/users/Hakuyume/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hakuyume/chainercv","description":"Versatile set of tools for Deep Learning based Computer Vision","fork":true,"url":"https://api.github.com/repos/Hakuyume/chainercv","forks_url":"https://api.github.com/repos/Hakuyume/chainercv/forks","keys_url":"https://api.github.com/repos/Hakuyume/chainercv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hakuyume/chainercv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hakuyume/chainercv/teams","hooks_url":"https://api.github.com/repos/Hakuyume/chainercv/hooks","issue_events_url":"https://api.github.com/repos/Hakuyume/chainercv/issues/events{/number}","events_url":"https://api.github.com/repos/Hakuyume/chainercv/events","assignees_url":"https://api.github.com/repos/Hakuyume/chainercv/assignees{/user}","branches_url":"https://api.github.com/repos/Hakuyume/chainercv/branches{/branch}","tags_url":"https://api.github.com/repos/Hakuyume/chainercv/tags","blobs_url":"https://api.github.com/repos/Hakuyume/chainercv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hakuyume/chainercv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hakuyume/chainercv/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hakuyume/chainercv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hakuyume/chainercv/statuses/{sha}","languages_url":"https://api.github.com/repos/Hakuyume/chainercv/languages","stargazers_url":"https://api.github.com/repos/Hakuyume/chainercv/stargazers","contributors_url":"https://api.github.com/repos/Hakuyume/chainercv/contributors","subscribers_url":"https://api.github.com/repos/Hakuyume/chainercv/subscribers","subscription_url":"https://api.github.com/repos/Hakuyume/chainercv/subscription","commits_url":"https://api.github.com/repos/Hakuyume/chainercv/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hakuyume/chainercv/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hakuyume/chainercv/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hakuyume/chainercv/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hakuyume/chainercv/contents/{+path}","compare_url":"https://api.github.com/repos/Hakuyume/chainercv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hakuyume/chainercv/merges","archive_url":"https://api.github.com/repos/Hakuyume/chainercv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hakuyume/chainercv/downloads","issues_url":"https://api.github.com/repos/Hakuyume/chainercv/issues{/number}","pulls_url":"https://api.github.com/repos/Hakuyume/chainercv/pulls{/number}","milestones_url":"https://api.github.com/repos/Hakuyume/chainercv/milestones{/number}","notifications_url":"https://api.github.com/repos/Hakuyume/chainercv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hakuyume/chainercv/labels{/name}","releases_url":"https://api.github.com/repos/Hakuyume/chainercv/releases{/id}","deployments_url":"https://api.github.com/repos/Hakuyume/chainercv/deployments","created_at":"2017-03-13T07:14:57Z","updated_at":"2017-03-13T07:14:59Z","pushed_at":"2017-05-04T07:19:42Z","git_url":"git://github.com/Hakuyume/chainercv.git","ssh_url":"git@github.com:Hakuyume/chainercv.git","clone_url":"https://github.com/Hakuyume/chainercv.git","svn_url":"https://github.com/Hakuyume/chainercv","homepage":"","size":468,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pfnet:master","ref":"master","sha":"69cee9e9057671519d5781e0b5ee3bb662034f4f","user":{"login":"pfnet","id":9739572,"avatar_url":"https://avatars1.githubusercontent.com/u/9739572?v=3","gravatar_id":"","url":"https://api.github.com/users/pfnet","html_url":"https://github.com/pfnet","followers_url":"https://api.github.com/users/pfnet/followers","following_url":"https://api.github.com/users/pfnet/following{/other_user}","gists_url":"https://api.github.com/users/pfnet/gists{/gist_id}","starred_url":"https://api.github.com/users/pfnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfnet/subscriptions","organizations_url":"https://api.github.com/users/pfnet/orgs","repos_url":"https://api.github.com/users/pfnet/repos","events_url":"https://api.github.com/users/pfnet/events{/privacy}","received_events_url":"https://api.github.com/users/pfnet/received_events","type":"Organization","site_admin":false},"repo":{"id":81784084,"name":"chainercv","full_name":"pfnet/chainercv","owner":{"login":"pfnet","id":9739572,"avatar_url":"https://avatars1.githubusercontent.com/u/9739572?v=3","gravatar_id":"","url":"https://api.github.com/users/pfnet","html_url":"https://github.com/pfnet","followers_url":"https://api.github.com/users/pfnet/followers","following_url":"https://api.github.com/users/pfnet/following{/other_user}","gists_url":"https://api.github.com/users/pfnet/gists{/gist_id}","starred_url":"https://api.github.com/users/pfnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfnet/subscriptions","organizations_url":"https://api.github.com/users/pfnet/orgs","repos_url":"https://api.github.com/users/pfnet/repos","events_url":"https://api.github.com/users/pfnet/events{/privacy}","received_events_url":"https://api.github.com/users/pfnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pfnet/chainercv","description":"Set of tools for Computer Vision using Chainer","fork":false,"url":"https://api.github.com/repos/pfnet/chainercv","forks_url":"https://api.github.com/repos/pfnet/chainercv/forks","keys_url":"https://api.github.com/repos/pfnet/chainercv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfnet/chainercv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfnet/chainercv/teams","hooks_url":"https://api.github.com/repos/pfnet/chainercv/hooks","issue_events_url":"https://api.github.com/repos/pfnet/chainercv/issues/events{/number}","events_url":"https://api.github.com/repos/pfnet/chainercv/events","assignees_url":"https://api.github.com/repos/pfnet/chainercv/assignees{/user}","branches_url":"https://api.github.com/repos/pfnet/chainercv/branches{/branch}","tags_url":"https://api.github.com/repos/pfnet/chainercv/tags","blobs_url":"https://api.github.com/repos/pfnet/chainercv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfnet/chainercv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfnet/chainercv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfnet/chainercv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfnet/chainercv/statuses/{sha}","languages_url":"https://api.github.com/repos/pfnet/chainercv/languages","stargazers_url":"https://api.github.com/repos/pfnet/chainercv/stargazers","contributors_url":"https://api.github.com/repos/pfnet/chainercv/contributors","subscribers_url":"https://api.github.com/repos/pfnet/chainercv/subscribers","subscription_url":"https://api.github.com/repos/pfnet/chainercv/subscription","commits_url":"https://api.github.com/repos/pfnet/chainercv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfnet/chainercv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfnet/chainercv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfnet/chainercv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfnet/chainercv/contents/{+path}","compare_url":"https://api.github.com/repos/pfnet/chainercv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfnet/chainercv/merges","archive_url":"https://api.github.com/repos/pfnet/chainercv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfnet/chainercv/downloads","issues_url":"https://api.github.com/repos/pfnet/chainercv/issues{/number}","pulls_url":"https://api.github.com/repos/pfnet/chainercv/pulls{/number}","milestones_url":"https://api.github.com/repos/pfnet/chainercv/milestones{/number}","notifications_url":"https://api.github.com/repos/pfnet/chainercv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfnet/chainercv/labels{/name}","releases_url":"https://api.github.com/repos/pfnet/chainercv/releases{/id}","deployments_url":"https://api.github.com/repos/pfnet/chainercv/deployments","created_at":"2017-02-13T04:15:10Z","updated_at":"2017-05-02T10:26:56Z","pushed_at":"2017-05-04T09:28:27Z","git_url":"git://github.com/pfnet/chainercv.git","ssh_url":"git@github.com:pfnet/chainercv.git","clone_url":"https://github.com/pfnet/chainercv.git","svn_url":"https://github.com/pfnet/chainercv","homepage":"","size":441,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":17,"forks":9,"open_issues":17,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pfnet/chainercv/pulls/144"},"html":{"href":"https://github.com/pfnet/chainercv/pull/144"},"issue":{"href":"https://api.github.com/repos/pfnet/chainercv/issues/144"},"comments":{"href":"https://api.github.com/repos/pfnet/chainercv/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/pfnet/chainercv/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/pfnet/chainercv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pfnet/chainercv/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/pfnet/chainercv/statuses/f0b8fba7700a5e2a56b0d57af696118865e4b009"}}}}
{"actor":{"display_login":"yuyu2172"}}