{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/comments/147287995","pull_request_review_id":72364285,"id":147287995,"diff_hunk":"@@ -147,13 +145,15 @@ class ContextParameterProcessor {\n         it.type in ['deploy', 'createServerGroup', 'cloneServerGroup', 'rollingPush'] && it.status == ExecutionStatus.SUCCEEDED\n       }.each { deployStage ->\n         if (deployStage.context.'deploy.server.groups') {\n-          Map deployDetails = [\n+          def deployDetails = [\n             account    : deployStage.context.account,\n             capacity   : deployStage.context.capacity,\n             parentStage: deployStage.parentStageId,\n             region     : deployStage.context.region ?: deployStage.context.availabilityZones.keySet().first(),\n           ]\n-          deployDetails.putAll(context.execution?.context?.deploymentDetails?.find { it.region == deployDetails.region } ?: [:])\n+          deployDetails.putAll(deployStage.context.deploymentDetails?.find {\n+            it.region == deployDetails.region\n+          } ?: [:])","path":"orca-core/src/main/groovy/com/netflix/spinnaker/orca/pipeline/util/ContextParameterProcessor.groovy","position":56,"original_position":56,"commit_id":"babebde19e1b2cab3d8f565a55adda7e97180fc6","original_commit_id":"babebde19e1b2cab3d8f565a55adda7e97180fc6","user":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars1.githubusercontent.com/u/95210?v=4","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"body":"Use the deploy stage's context to get `deploymentDetails` as it will chain back to the relevant find image/bake.","created_at":"2017-10-26T22:50:54Z","updated_at":"2017-10-26T22:50:54Z","html_url":"https://github.com/spinnaker/orca/pull/1742#discussion_r147287995","pull_request_url":"https://api.github.com/repos/spinnaker/orca/pulls/1742","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments/147287995"},"html":{"href":"https://github.com/spinnaker/orca/pull/1742#discussion_r147287995"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1742"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/orca/pulls/1742","id":149063993,"html_url":"https://github.com/spinnaker/orca/pull/1742","diff_url":"https://github.com/spinnaker/orca/pull/1742.diff","patch_url":"https://github.com/spinnaker/orca/pull/1742.patch","issue_url":"https://api.github.com/repos/spinnaker/orca/issues/1742","number":1742,"state":"open","locked":false,"title":"fix(deploy): avoid crossing the streams in parallelized deploys","user":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars1.githubusercontent.com/u/95210?v=4","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"body":"Ensure a deploy stage is getting deployment details from its ancestor and not from global context.\r\n","created_at":"2017-10-26T22:49:05Z","updated_at":"2017-10-26T22:50:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"423bc8361f823320fcc31e3aa8cf53db34dd7fbd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jeyrschabu","id":1572759,"avatar_url":"https://avatars3.githubusercontent.com/u/1572759?v=4","gravatar_id":"","url":"https://api.github.com/users/jeyrschabu","html_url":"https://github.com/jeyrschabu","followers_url":"https://api.github.com/users/jeyrschabu/followers","following_url":"https://api.github.com/users/jeyrschabu/following{/other_user}","gists_url":"https://api.github.com/users/jeyrschabu/gists{/gist_id}","starred_url":"https://api.github.com/users/jeyrschabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeyrschabu/subscriptions","organizations_url":"https://api.github.com/users/jeyrschabu/orgs","repos_url":"https://api.github.com/users/jeyrschabu/repos","events_url":"https://api.github.com/users/jeyrschabu/events{/privacy}","received_events_url":"https://api.github.com/users/jeyrschabu/received_events","type":"User","site_admin":false},{"login":"lwander","id":4874941,"avatar_url":"https://avatars3.githubusercontent.com/u/4874941?v=4","gravatar_id":"","url":"https://api.github.com/users/lwander","html_url":"https://github.com/lwander","followers_url":"https://api.github.com/users/lwander/followers","following_url":"https://api.github.com/users/lwander/following{/other_user}","gists_url":"https://api.github.com/users/lwander/gists{/gist_id}","starred_url":"https://api.github.com/users/lwander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwander/subscriptions","organizations_url":"https://api.github.com/users/lwander/orgs","repos_url":"https://api.github.com/users/lwander/repos","events_url":"https://api.github.com/users/lwander/events{/privacy}","received_events_url":"https://api.github.com/users/lwander/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/orca/pulls/1742/commits","review_comments_url":"https://api.github.com/repos/spinnaker/orca/pulls/1742/comments","review_comment_url":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/orca/issues/1742/comments","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/babebde19e1b2cab3d8f565a55adda7e97180fc6","head":{"label":"robfletcher:SPIN-3002","ref":"SPIN-3002","sha":"babebde19e1b2cab3d8f565a55adda7e97180fc6","user":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars1.githubusercontent.com/u/95210?v=4","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"repo":{"id":46739117,"name":"orca","full_name":"robfletcher/orca","owner":{"login":"robfletcher","id":95210,"avatar_url":"https://avatars1.githubusercontent.com/u/95210?v=4","gravatar_id":"","url":"https://api.github.com/users/robfletcher","html_url":"https://github.com/robfletcher","followers_url":"https://api.github.com/users/robfletcher/followers","following_url":"https://api.github.com/users/robfletcher/following{/other_user}","gists_url":"https://api.github.com/users/robfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/robfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfletcher/subscriptions","organizations_url":"https://api.github.com/users/robfletcher/orgs","repos_url":"https://api.github.com/users/robfletcher/repos","events_url":"https://api.github.com/users/robfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/robfletcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robfletcher/orca","description":"orchestration engine","fork":true,"url":"https://api.github.com/repos/robfletcher/orca","forks_url":"https://api.github.com/repos/robfletcher/orca/forks","keys_url":"https://api.github.com/repos/robfletcher/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robfletcher/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robfletcher/orca/teams","hooks_url":"https://api.github.com/repos/robfletcher/orca/hooks","issue_events_url":"https://api.github.com/repos/robfletcher/orca/issues/events{/number}","events_url":"https://api.github.com/repos/robfletcher/orca/events","assignees_url":"https://api.github.com/repos/robfletcher/orca/assignees{/user}","branches_url":"https://api.github.com/repos/robfletcher/orca/branches{/branch}","tags_url":"https://api.github.com/repos/robfletcher/orca/tags","blobs_url":"https://api.github.com/repos/robfletcher/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robfletcher/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robfletcher/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/robfletcher/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robfletcher/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/robfletcher/orca/languages","stargazers_url":"https://api.github.com/repos/robfletcher/orca/stargazers","contributors_url":"https://api.github.com/repos/robfletcher/orca/contributors","subscribers_url":"https://api.github.com/repos/robfletcher/orca/subscribers","subscription_url":"https://api.github.com/repos/robfletcher/orca/subscription","commits_url":"https://api.github.com/repos/robfletcher/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/robfletcher/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/robfletcher/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/robfletcher/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/robfletcher/orca/contents/{+path}","compare_url":"https://api.github.com/repos/robfletcher/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robfletcher/orca/merges","archive_url":"https://api.github.com/repos/robfletcher/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robfletcher/orca/downloads","issues_url":"https://api.github.com/repos/robfletcher/orca/issues{/number}","pulls_url":"https://api.github.com/repos/robfletcher/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/robfletcher/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/robfletcher/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robfletcher/orca/labels{/name}","releases_url":"https://api.github.com/repos/robfletcher/orca/releases{/id}","deployments_url":"https://api.github.com/repos/robfletcher/orca/deployments","created_at":"2015-11-23T18:15:19Z","updated_at":"2016-01-19T18:54:40Z","pushed_at":"2017-10-26T22:47:58Z","git_url":"git://github.com/robfletcher/orca.git","ssh_url":"git@github.com:robfletcher/orca.git","clone_url":"https://github.com/robfletcher/orca.git","svn_url":"https://github.com/robfletcher/orca","homepage":"","size":10270,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"7a8ef540f750b7faf03e252422af5624323ffda0","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":19834314,"name":"orca","full_name":"spinnaker/orca","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/orca","description":"orchestration engine","fork":false,"url":"https://api.github.com/repos/spinnaker/orca","forks_url":"https://api.github.com/repos/spinnaker/orca/forks","keys_url":"https://api.github.com/repos/spinnaker/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/orca/teams","hooks_url":"https://api.github.com/repos/spinnaker/orca/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/orca/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/orca/events","assignees_url":"https://api.github.com/repos/spinnaker/orca/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/orca/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/orca/tags","blobs_url":"https://api.github.com/repos/spinnaker/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/orca/languages","stargazers_url":"https://api.github.com/repos/spinnaker/orca/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/orca/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/orca/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/orca/subscription","commits_url":"https://api.github.com/repos/spinnaker/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/orca/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/orca/merges","archive_url":"https://api.github.com/repos/spinnaker/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/orca/downloads","issues_url":"https://api.github.com/repos/spinnaker/orca/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/orca/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/orca/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/orca/deployments","created_at":"2014-05-15T20:33:00Z","updated_at":"2017-10-25T10:19:21Z","pushed_at":"2017-10-26T22:49:05Z","git_url":"git://github.com/spinnaker/orca.git","ssh_url":"git@github.com:spinnaker/orca.git","clone_url":"https://github.com/spinnaker/orca.git","svn_url":"https://github.com/spinnaker/orca","homepage":"","size":9781,"stargazers_count":69,"watchers_count":69,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":53,"forks":120,"open_issues":53,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1742"},"html":{"href":"https://github.com/spinnaker/orca/pull/1742"},"issue":{"href":"https://api.github.com/repos/spinnaker/orca/issues/1742"},"comments":{"href":"https://api.github.com/repos/spinnaker/orca/issues/1742/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1742/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/orca/pulls/1742/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/orca/statuses/babebde19e1b2cab3d8f565a55adda7e97180fc6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robfletcher"}}