{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/comments/98713416","pull_request_review_id":19363212,"id":98713416,"diff_hunk":"@@ -1,22 +1,30 @@\n # Include the build file for calico/node (This also pulls in Makefile.calicoctl)\n include Makefile.calicoctl\n \n-###############################################################################\n-# URL for Calico binaries\n-# confd binary\n-CONFD_URL?=https://github.com/projectcalico/confd/releases/download/v0.10.0-scale/confd.static\n-# bird binaries\n-BIRD_URL?=https://github.com/projectcalico/calico-bird/releases/download/v0.2.0/bird\n-BIRD6_URL?=https://github.com/projectcalico/calico-bird/releases/download/v0.2.0/bird6\n-BIRDCL_URL?=https://github.com/projectcalico/calico-bird/releases/download/v0.2.0/birdcl\n-CALICO_BGP_DAEMON_URL?=https://github.com/projectcalico/calico-bgp-daemon/releases/download/v0.1.1/calico-bgp-daemon\n-GOBGP_URL?=https://github.com/projectcalico/calico-bgp-daemon/releases/download/v0.1.1/gobgp\n-\n # we can use \"custom\" build image and test image name\n-SYSTEMTEST_CONTAINER?=calico/test\n+SYSTEMTEST_CONTAINER?=calico/test:$(SYSTEMTEST_CONTAINER_VER)\n \n # calicoctl and calico/node current share a single version - this is it.\n CALICOCONTAINERS_VERSION?=$(shell git describe --tags --dirty --always)\n+###############################################################################\n+# Subcomponent versions:\n+BIRD_VER := v0.2.0\n+GOBGPD_VER := v0.1.1\n+FELIX_VER := 2.0.1-rc1","path":"Makefile.calico-node","position":25,"original_position":25,"commit_id":"800c8cc1d425f232f83a58874d05ef814f8c4481","original_commit_id":"800c8cc1d425f232f83a58874d05ef814f8c4481","user":{"login":"gunjan5","id":5966968,"avatar_url":"https://avatars.githubusercontent.com/u/5966968?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjan5","html_url":"https://github.com/gunjan5","followers_url":"https://api.github.com/users/gunjan5/followers","following_url":"https://api.github.com/users/gunjan5/following{/other_user}","gists_url":"https://api.github.com/users/gunjan5/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjan5/subscriptions","organizations_url":"https://api.github.com/users/gunjan5/orgs","repos_url":"https://api.github.com/users/gunjan5/repos","events_url":"https://api.github.com/users/gunjan5/events{/privacy}","received_events_url":"https://api.github.com/users/gunjan5/received_events","type":"User","site_admin":false},"body":"ah good point! ","created_at":"2017-01-31T16:47:15Z","updated_at":"2017-01-31T16:47:15Z","html_url":"https://github.com/projectcalico/calicoctl/pull/1474#discussion_r98713416","pull_request_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1474","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/comments/98713416"},"html":{"href":"https://github.com/projectcalico/calicoctl/pull/1474#discussion_r98713416"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1474"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1474","id":103788428,"html_url":"https://github.com/projectcalico/calicoctl/pull/1474","diff_url":"https://github.com/projectcalico/calicoctl/pull/1474.diff","patch_url":"https://github.com/projectcalico/calicoctl/pull/1474.patch","issue_url":"https://api.github.com/repos/projectcalico/calicoctl/issues/1474","number":1474,"state":"open","locked":false,"title":"Smoother release process take 2","user":{"login":"gunjan5","id":5966968,"avatar_url":"https://avatars.githubusercontent.com/u/5966968?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjan5","html_url":"https://github.com/gunjan5","followers_url":"https://api.github.com/users/gunjan5/followers","following_url":"https://api.github.com/users/gunjan5/following{/other_user}","gists_url":"https://api.github.com/users/gunjan5/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjan5/subscriptions","organizations_url":"https://api.github.com/users/gunjan5/orgs","repos_url":"https://api.github.com/users/gunjan5/repos","events_url":"https://api.github.com/users/gunjan5/events{/privacy}","received_events_url":"https://api.github.com/users/gunjan5/received_events","type":"User","site_admin":false},"body":"Fixes #1401","created_at":"2017-01-30T18:03:02Z","updated_at":"2017-01-31T16:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"610eb70bfe2e222e1b21247f0b4b119cc4cddda2","assignee":{"login":"fasaxc","id":469264,"avatar_url":"https://avatars.githubusercontent.com/u/469264?v=3","gravatar_id":"","url":"https://api.github.com/users/fasaxc","html_url":"https://github.com/fasaxc","followers_url":"https://api.github.com/users/fasaxc/followers","following_url":"https://api.github.com/users/fasaxc/following{/other_user}","gists_url":"https://api.github.com/users/fasaxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fasaxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fasaxc/subscriptions","organizations_url":"https://api.github.com/users/fasaxc/orgs","repos_url":"https://api.github.com/users/fasaxc/repos","events_url":"https://api.github.com/users/fasaxc/events{/privacy}","received_events_url":"https://api.github.com/users/fasaxc/received_events","type":"User","site_admin":false},"assignees":[{"login":"fasaxc","id":469264,"avatar_url":"https://avatars.githubusercontent.com/u/469264?v=3","gravatar_id":"","url":"https://api.github.com/users/fasaxc","html_url":"https://github.com/fasaxc","followers_url":"https://api.github.com/users/fasaxc/followers","following_url":"https://api.github.com/users/fasaxc/following{/other_user}","gists_url":"https://api.github.com/users/fasaxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fasaxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fasaxc/subscriptions","organizations_url":"https://api.github.com/users/fasaxc/orgs","repos_url":"https://api.github.com/users/fasaxc/repos","events_url":"https://api.github.com/users/fasaxc/events{/privacy}","received_events_url":"https://api.github.com/users/fasaxc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1474/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1474/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calicoctl/issues/1474/comments","statuses_url":"https://api.github.com/repos/projectcalico/calicoctl/statuses/800c8cc1d425f232f83a58874d05ef814f8c4481","head":{"label":"gunjan5:release-process-2","ref":"release-process-2","sha":"800c8cc1d425f232f83a58874d05ef814f8c4481","user":{"login":"gunjan5","id":5966968,"avatar_url":"https://avatars.githubusercontent.com/u/5966968?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjan5","html_url":"https://github.com/gunjan5","followers_url":"https://api.github.com/users/gunjan5/followers","following_url":"https://api.github.com/users/gunjan5/following{/other_user}","gists_url":"https://api.github.com/users/gunjan5/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjan5/subscriptions","organizations_url":"https://api.github.com/users/gunjan5/orgs","repos_url":"https://api.github.com/users/gunjan5/repos","events_url":"https://api.github.com/users/gunjan5/events{/privacy}","received_events_url":"https://api.github.com/users/gunjan5/received_events","type":"User","site_admin":false},"repo":{"id":72027121,"name":"calico-containers","full_name":"gunjan5/calico-containers","owner":{"login":"gunjan5","id":5966968,"avatar_url":"https://avatars.githubusercontent.com/u/5966968?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjan5","html_url":"https://github.com/gunjan5","followers_url":"https://api.github.com/users/gunjan5/followers","following_url":"https://api.github.com/users/gunjan5/following{/other_user}","gists_url":"https://api.github.com/users/gunjan5/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjan5/subscriptions","organizations_url":"https://api.github.com/users/gunjan5/orgs","repos_url":"https://api.github.com/users/gunjan5/repos","events_url":"https://api.github.com/users/gunjan5/events{/privacy}","received_events_url":"https://api.github.com/users/gunjan5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gunjan5/calico-containers","description":"Project Calico deployed in a containerized environment","fork":true,"url":"https://api.github.com/repos/gunjan5/calico-containers","forks_url":"https://api.github.com/repos/gunjan5/calico-containers/forks","keys_url":"https://api.github.com/repos/gunjan5/calico-containers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gunjan5/calico-containers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gunjan5/calico-containers/teams","hooks_url":"https://api.github.com/repos/gunjan5/calico-containers/hooks","issue_events_url":"https://api.github.com/repos/gunjan5/calico-containers/issues/events{/number}","events_url":"https://api.github.com/repos/gunjan5/calico-containers/events","assignees_url":"https://api.github.com/repos/gunjan5/calico-containers/assignees{/user}","branches_url":"https://api.github.com/repos/gunjan5/calico-containers/branches{/branch}","tags_url":"https://api.github.com/repos/gunjan5/calico-containers/tags","blobs_url":"https://api.github.com/repos/gunjan5/calico-containers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gunjan5/calico-containers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gunjan5/calico-containers/git/refs{/sha}","trees_url":"https://api.github.com/repos/gunjan5/calico-containers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gunjan5/calico-containers/statuses/{sha}","languages_url":"https://api.github.com/repos/gunjan5/calico-containers/languages","stargazers_url":"https://api.github.com/repos/gunjan5/calico-containers/stargazers","contributors_url":"https://api.github.com/repos/gunjan5/calico-containers/contributors","subscribers_url":"https://api.github.com/repos/gunjan5/calico-containers/subscribers","subscription_url":"https://api.github.com/repos/gunjan5/calico-containers/subscription","commits_url":"https://api.github.com/repos/gunjan5/calico-containers/commits{/sha}","git_commits_url":"https://api.github.com/repos/gunjan5/calico-containers/git/commits{/sha}","comments_url":"https://api.github.com/repos/gunjan5/calico-containers/comments{/number}","issue_comment_url":"https://api.github.com/repos/gunjan5/calico-containers/issues/comments{/number}","contents_url":"https://api.github.com/repos/gunjan5/calico-containers/contents/{+path}","compare_url":"https://api.github.com/repos/gunjan5/calico-containers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gunjan5/calico-containers/merges","archive_url":"https://api.github.com/repos/gunjan5/calico-containers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gunjan5/calico-containers/downloads","issues_url":"https://api.github.com/repos/gunjan5/calico-containers/issues{/number}","pulls_url":"https://api.github.com/repos/gunjan5/calico-containers/pulls{/number}","milestones_url":"https://api.github.com/repos/gunjan5/calico-containers/milestones{/number}","notifications_url":"https://api.github.com/repos/gunjan5/calico-containers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gunjan5/calico-containers/labels{/name}","releases_url":"https://api.github.com/repos/gunjan5/calico-containers/releases{/id}","deployments_url":"https://api.github.com/repos/gunjan5/calico-containers/deployments","created_at":"2016-10-26T17:26:01Z","updated_at":"2017-01-26T17:29:59Z","pushed_at":"2017-01-30T18:03:48Z","git_url":"git://github.com/gunjan5/calico-containers.git","ssh_url":"git@github.com:gunjan5/calico-containers.git","clone_url":"https://github.com/gunjan5/calico-containers.git","svn_url":"https://github.com/gunjan5/calico-containers","homepage":"http://www.projectcalico.org","size":45476,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"166e04b71be4e33e4cef7c71b377063cea577c11","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":29629333,"name":"calicoctl","full_name":"projectcalico/calicoctl","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calicoctl","description":"Calico CLI tool and calico/node container","fork":false,"url":"https://api.github.com/repos/projectcalico/calicoctl","forks_url":"https://api.github.com/repos/projectcalico/calicoctl/forks","keys_url":"https://api.github.com/repos/projectcalico/calicoctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calicoctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calicoctl/teams","hooks_url":"https://api.github.com/repos/projectcalico/calicoctl/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calicoctl/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calicoctl/events","assignees_url":"https://api.github.com/repos/projectcalico/calicoctl/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calicoctl/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calicoctl/tags","blobs_url":"https://api.github.com/repos/projectcalico/calicoctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calicoctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calicoctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calicoctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calicoctl/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calicoctl/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calicoctl/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calicoctl/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calicoctl/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calicoctl/subscription","commits_url":"https://api.github.com/repos/projectcalico/calicoctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calicoctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calicoctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calicoctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calicoctl/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calicoctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calicoctl/merges","archive_url":"https://api.github.com/repos/projectcalico/calicoctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calicoctl/downloads","issues_url":"https://api.github.com/repos/projectcalico/calicoctl/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calicoctl/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calicoctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calicoctl/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calicoctl/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/calicoctl/deployments","created_at":"2015-01-21T23:46:47Z","updated_at":"2017-01-31T13:10:53Z","pushed_at":"2017-01-31T09:17:14Z","git_url":"git://github.com/projectcalico/calicoctl.git","ssh_url":"git@github.com:projectcalico/calicoctl.git","clone_url":"https://github.com/projectcalico/calicoctl.git","svn_url":"https://github.com/projectcalico/calicoctl","homepage":"http://www.projectcalico.org","size":37064,"stargazers_count":589,"watchers_count":589,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":157,"mirror_url":null,"open_issues_count":101,"forks":157,"open_issues":101,"watchers":589,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1474"},"html":{"href":"https://github.com/projectcalico/calicoctl/pull/1474"},"issue":{"href":"https://api.github.com/repos/projectcalico/calicoctl/issues/1474"},"comments":{"href":"https://api.github.com/repos/projectcalico/calicoctl/issues/1474/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1474/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1474/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calicoctl/statuses/800c8cc1d425f232f83a58874d05ef814f8c4481"}}}}
{"actor":{"display_login":"gunjan5"}}