{"action":"opened","issue":{"url":"https://api.github.com/repos/aidanhs/rsroll/issues/7","repository_url":"https://api.github.com/repos/aidanhs/rsroll","labels_url":"https://api.github.com/repos/aidanhs/rsroll/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/aidanhs/rsroll/issues/7/comments","events_url":"https://api.github.com/repos/aidanhs/rsroll/issues/7/events","html_url":"https://github.com/aidanhs/rsroll/issues/7","id":245094492,"number":7,"title":"Slow creation of bup structs and other thoughts","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars1.githubusercontent.com/u/1050652?v=4","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-24T14:15:17Z","updated_at":"2017-07-24T14:15:17Z","closed_at":null,"body":"https://github.com/dpc/rdedup/commit/b1298e60e973683c6cc5aa3d24612114ac58660d seems to show a measurable performance improvement if you skip creating a new struct.\r\n\r\n1. this change does actually change splitting behaviour if you haven't set a minimum chunk size greater than the window size of the rollsum (since your content defined chunking now depends on the content of the *previous* chunk until you've rolled over the whole window)\r\n2. why is it so slow? It should just be a memcpy of 128 bytes\r\n3. maybe we should expose a reset method if rust can't make it fast\r\n4. maybe we should make an iterator with arguments for min size etc to handle the somewhat clever logic mentioned in https://github.com/dpc/rdedup/issues/88#issuecomment-317433109\r\n\r\ncc @dpc "}}
{"actor":{"display_login":"aidanhs"}}