{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/122598444","pull_request_review_id":44727915,"id":122598444,"diff_hunk":"@@ -485,6 +436,74 @@ public void NH1744()\n \t\t}\n \n \t\t[Test]\n+\t\tpublic void CanUseSessionWithManyScopes([Values(false, true)] bool explicitFlush)\n+\t\t{\n+\t\t\t// Note that this fails with ConnectionReleaseMode.OnClose and SqlServer:\n+\t\t\t// System.Data.SqlClient.SqlException : Microsoft Distributed Transaction Coordinator (MS DTC) has stopped this transaction.\n+\t\t\tusing (var s = OpenSession())\n+\t\t\t//using (var s = Sfi.WithOptions().ConnectionReleaseMode(ConnectionReleaseMode.OnClose).OpenSession())","path":"src/NHibernate.Test/SystemTransactions/DistributedTransactionFixture.cs","position":444,"original_position":93,"commit_id":"aea3577a0652a818975118fb11496867ee74e72b","original_commit_id":"aea3577a0652a818975118fb11496867ee74e72b","user":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars1.githubusercontent.com/u/12201973?v=3","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"body":"Yuck, one more trouble. I do not see anyway to fix that, excepted not using the old `OnClose` connection release mode. Since documentation advises against using it, I think we are fine not fixing that trouble.","created_at":"2017-06-18T18:58:51Z","updated_at":"2017-06-18T18:58:51Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/627#discussion_r122598444","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/627","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/122598444"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/627#discussion_r122598444"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/627"}}},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/627","id":121337779,"html_url":"https://github.com/nhibernate/nhibernate-core/pull/627","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/627.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/627.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/627","number":627,"state":"open","locked":false,"title":"NH-2176 - transaction scope failures","user":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars1.githubusercontent.com/u/12201973?v=3","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"body":"[NH-2176](https://nhibernate.jira.com/browse/NH-2176)\r\n\r\nSince the branch used in #410 is public and in the official NHibernate repository, rebasing  it is debatable.\r\n\r\nSo for going on with my tests, I have switched on a branch in my own repository.\r\n\r\nRebased, custom factory dropped, slightly squashed.\r\n\r\nDTC failure tests cleaned up and completed.\r\n\r\n~~PostgreSQL reactivated for DTC~~ in order to check what is going on with it.","created_at":"2017-05-18T17:32:16Z","updated_at":"2017-06-18T18:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ec34a37b0606ceb3fd86d3a2e63fc43335897fe","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/627/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/627/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/627/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/aea3577a0652a818975118fb11496867ee74e72b","head":{"label":"fredericDelaporte:NH-2176","ref":"NH-2176","sha":"aea3577a0652a818975118fb11496867ee74e72b","user":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars1.githubusercontent.com/u/12201973?v=3","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"repo":{"id":81663690,"name":"nhibernate-core","full_name":"fredericDelaporte/nhibernate-core","owner":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars1.githubusercontent.com/u/12201973?v=3","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fredericDelaporte/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core","forks_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/forks","keys_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/events","assignees_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/merges","archive_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/deployments","created_at":"2017-02-11T16:01:00Z","updated_at":"2017-02-11T16:01:12Z","pushed_at":"2017-06-18T18:57:28Z","git_url":"git://github.com/fredericDelaporte/nhibernate-core.git","ssh_url":"git@github.com:fredericDelaporte/nhibernate-core.git","clone_url":"https://github.com/fredericDelaporte/nhibernate-core.git","svn_url":"https://github.com/fredericDelaporte/nhibernate-core","homepage":"http://nhibernate.info","size":76770,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"40b5f392b5a1e45e6ace730f20208f1d12bbb5a4","user":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars0.githubusercontent.com/u/961041?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","owner":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars0.githubusercontent.com/u/961041?v=3","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/deployments","created_at":"2011-08-14T17:51:09Z","updated_at":"2017-06-15T21:47:49Z","pushed_at":"2017-06-18T18:57:30Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":77790,"stargazers_count":1131,"watchers_count":1131,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":693,"mirror_url":null,"open_issues_count":70,"forks":693,"open_issues":70,"watchers":1131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/627"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/627"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/627"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/627/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/627/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/627/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/aea3577a0652a818975118fb11496867ee74e72b"}}}}
{"actor":{"display_login":"fredericDelaporte"}}