{"action":"created","issue":{"url":"https://api.github.com/repos/golang/dep/issues/1226","repository_url":"https://api.github.com/repos/golang/dep","labels_url":"https://api.github.com/repos/golang/dep/issues/1226/labels{/name}","comments_url":"https://api.github.com/repos/golang/dep/issues/1226/comments","events_url":"https://api.github.com/repos/golang/dep/issues/1226/events","html_url":"https://github.com/golang/dep/pull/1226","id":261574266,"number":1226,"title":"[WIP] Add prune options to manifest","user":{"login":"ibrasho","id":188776,"avatar_url":"https://avatars2.githubusercontent.com/u/188776?v=4","gravatar_id":"","url":"https://api.github.com/users/ibrasho","html_url":"https://github.com/ibrasho","followers_url":"https://api.github.com/users/ibrasho/followers","following_url":"https://api.github.com/users/ibrasho/following{/other_user}","gists_url":"https://api.github.com/users/ibrasho/gists{/gist_id}","starred_url":"https://api.github.com/users/ibrasho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibrasho/subscriptions","organizations_url":"https://api.github.com/users/ibrasho/orgs","repos_url":"https://api.github.com/users/ibrasho/repos","events_url":"https://api.github.com/users/ibrasho/events{/privacy}","received_events_url":"https://api.github.com/users/ibrasho/received_events","type":"User","site_admin":false},"labels":[{"id":517733207,"url":"https://api.github.com/repos/golang/dep/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-09-29T08:54:34Z","updated_at":"2017-09-30T15:25:11Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/golang/dep/pulls/1226","html_url":"https://github.com/golang/dep/pull/1226","diff_url":"https://github.com/golang/dep/pull/1226.diff","patch_url":"https://github.com/golang/dep/pull/1226.patch"},"body":"### What does this do / why do we need it?\r\nAdd prune options to `dep.Manifest`.\r\nRemaining tasks:\r\n- [ ] Per-project prune options\r\n- [ ] Add more tests\r\n\r\n### What should your reviewer look out for in this PR?\r\nGeneric review.\r\n\r\n### Do you need help or clarification on anything?\r\nHow should prune options be defined for projects? \r\n\r\nHere is a list of suggestions:\r\n1. TOML table under prune:\r\n```toml\r\n[prune]\r\n  non-go = true\r\n  unused-packages = true\r\n\r\n  [\"github.com/golang/protobuf\"]\r\n    non-go = true\r\n    go-tests = true\r\n```\r\n\r\n2. `prune` table under constraints (what about overrides?)\r\n```toml\r\n[[constraint]]\r\n  name = \"github.com/jmank88/nuts\"\r\n  version = \"0.2.0\"\r\n  prune = { non-go = true, go-tests = true, unused-packages = true }\r\n```\r\nor \r\n```toml\r\n[[constraint]]\r\n  name = \"github.com/jmank88/nuts\"\r\n  version = \"0.2.0\"\r\n\r\n  [constraint.prune]\r\n    go-tests = true\r\n    unused-packages = true\r\n```\r\n\r\n\r\n### Which issue(s) does this PR fix?\r\n\r\nOne more step towards #944 "},"comment":{"url":"https://api.github.com/repos/golang/dep/issues/comments/333315632","html_url":"https://github.com/golang/dep/pull/1226#issuecomment-333315632","issue_url":"https://api.github.com/repos/golang/dep/issues/1226","id":333315632,"user":{"login":"jmank88","id":1194128,"avatar_url":"https://avatars2.githubusercontent.com/u/1194128?v=4","gravatar_id":"","url":"https://api.github.com/users/jmank88","html_url":"https://github.com/jmank88","followers_url":"https://api.github.com/users/jmank88/followers","following_url":"https://api.github.com/users/jmank88/following{/other_user}","gists_url":"https://api.github.com/users/jmank88/gists{/gist_id}","starred_url":"https://api.github.com/users/jmank88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmank88/subscriptions","organizations_url":"https://api.github.com/users/jmank88/orgs","repos_url":"https://api.github.com/users/jmank88/repos","events_url":"https://api.github.com/users/jmank88/events{/privacy}","received_events_url":"https://api.github.com/users/jmank88/received_events","type":"User","site_admin":false},"created_at":"2017-09-30T15:25:11Z","updated_at":"2017-09-30T15:25:11Z","author_association":"COLLABORATOR","body":"If overriding the global with a false is a necessary/useful feature, then this makes sense, and can be a `*bool` internally.\r\n\r\nif not, then using a list would remove the option."}}
{"actor":{"display_login":"jmank88"}}