{"action":"closed","number":1471,"pull_request":{"url":"https://api.github.com/repos/EventStore/EventStore/pulls/1471","id":147758642,"html_url":"https://github.com/EventStore/EventStore/pull/1471","diff_url":"https://github.com/EventStore/EventStore/pull/1471.diff","patch_url":"https://github.com/EventStore/EventStore/pull/1471.patch","issue_url":"https://api.github.com/repos/EventStore/EventStore/issues/1471","number":1471,"state":"closed","locked":false,"title":"Convert timeout of 0 to no timeout when loading config on startup.","user":{"login":"hayley-jean","id":5140165,"avatar_url":"https://avatars2.githubusercontent.com/u/5140165?v=4","gravatar_id":"","url":"https://api.github.com/users/hayley-jean","html_url":"https://github.com/hayley-jean","followers_url":"https://api.github.com/users/hayley-jean/followers","following_url":"https://api.github.com/users/hayley-jean/following{/other_user}","gists_url":"https://api.github.com/users/hayley-jean/gists{/gist_id}","starred_url":"https://api.github.com/users/hayley-jean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayley-jean/subscriptions","organizations_url":"https://api.github.com/users/hayley-jean/orgs","repos_url":"https://api.github.com/users/hayley-jean/repos","events_url":"https://api.github.com/users/hayley-jean/events{/privacy}","received_events_url":"https://api.github.com/users/hayley-jean/received_events","type":"User","site_admin":false},"body":"A timeout of 0 milliseconds is used to indicate that messages on the subscription should not time out, and was converted to `TimeSpan.MaxValue` when it was set.\r\n\r\nHowever, this same conversion did not happen when loading the config for the subscription.\r\nThis means that if a subscription with `DoNotTimeout()` is restarted, messages would timeout immediately after being sent.\r\n\r\nAlso removed unused block of code for loading config. ","created_at":"2017-10-20T09:41:42Z","updated_at":"2017-10-20T11:19:46Z","closed_at":"2017-10-20T11:19:46Z","merged_at":"2017-10-20T11:19:46Z","merge_commit_sha":"53e6ca7f240753dfdb25027233fa14fb3e7b7ab9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/EventStore/EventStore/pulls/1471/commits","review_comments_url":"https://api.github.com/repos/EventStore/EventStore/pulls/1471/comments","review_comment_url":"https://api.github.com/repos/EventStore/EventStore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EventStore/EventStore/issues/1471/comments","statuses_url":"https://api.github.com/repos/EventStore/EventStore/statuses/75442aeab4b232a81c7face7c6188c8dec7287c2","head":{"label":"EventStore:persistent-subscription-config","ref":"persistent-subscription-config","sha":"75442aeab4b232a81c7face7c6188c8dec7287c2","user":{"login":"EventStore","id":1628864,"avatar_url":"https://avatars1.githubusercontent.com/u/1628864?v=4","gravatar_id":"","url":"https://api.github.com/users/EventStore","html_url":"https://github.com/EventStore","followers_url":"https://api.github.com/users/EventStore/followers","following_url":"https://api.github.com/users/EventStore/following{/other_user}","gists_url":"https://api.github.com/users/EventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/EventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EventStore/subscriptions","organizations_url":"https://api.github.com/users/EventStore/orgs","repos_url":"https://api.github.com/users/EventStore/repos","events_url":"https://api.github.com/users/EventStore/events{/privacy}","received_events_url":"https://api.github.com/users/EventStore/received_events","type":"Organization","site_admin":false},"repo":{"id":5844474,"name":"EventStore","full_name":"EventStore/EventStore","owner":{"login":"EventStore","id":1628864,"avatar_url":"https://avatars1.githubusercontent.com/u/1628864?v=4","gravatar_id":"","url":"https://api.github.com/users/EventStore","html_url":"https://github.com/EventStore","followers_url":"https://api.github.com/users/EventStore/followers","following_url":"https://api.github.com/users/EventStore/following{/other_user}","gists_url":"https://api.github.com/users/EventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/EventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EventStore/subscriptions","organizations_url":"https://api.github.com/users/EventStore/orgs","repos_url":"https://api.github.com/users/EventStore/repos","events_url":"https://api.github.com/users/EventStore/events{/privacy}","received_events_url":"https://api.github.com/users/EventStore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EventStore/EventStore","description":"The open-source, functional database with Complex Event Processing in JavaScript.","fork":false,"url":"https://api.github.com/repos/EventStore/EventStore","forks_url":"https://api.github.com/repos/EventStore/EventStore/forks","keys_url":"https://api.github.com/repos/EventStore/EventStore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EventStore/EventStore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EventStore/EventStore/teams","hooks_url":"https://api.github.com/repos/EventStore/EventStore/hooks","issue_events_url":"https://api.github.com/repos/EventStore/EventStore/issues/events{/number}","events_url":"https://api.github.com/repos/EventStore/EventStore/events","assignees_url":"https://api.github.com/repos/EventStore/EventStore/assignees{/user}","branches_url":"https://api.github.com/repos/EventStore/EventStore/branches{/branch}","tags_url":"https://api.github.com/repos/EventStore/EventStore/tags","blobs_url":"https://api.github.com/repos/EventStore/EventStore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EventStore/EventStore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EventStore/EventStore/git/refs{/sha}","trees_url":"https://api.github.com/repos/EventStore/EventStore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EventStore/EventStore/statuses/{sha}","languages_url":"https://api.github.com/repos/EventStore/EventStore/languages","stargazers_url":"https://api.github.com/repos/EventStore/EventStore/stargazers","contributors_url":"https://api.github.com/repos/EventStore/EventStore/contributors","subscribers_url":"https://api.github.com/repos/EventStore/EventStore/subscribers","subscription_url":"https://api.github.com/repos/EventStore/EventStore/subscription","commits_url":"https://api.github.com/repos/EventStore/EventStore/commits{/sha}","git_commits_url":"https://api.github.com/repos/EventStore/EventStore/git/commits{/sha}","comments_url":"https://api.github.com/repos/EventStore/EventStore/comments{/number}","issue_comment_url":"https://api.github.com/repos/EventStore/EventStore/issues/comments{/number}","contents_url":"https://api.github.com/repos/EventStore/EventStore/contents/{+path}","compare_url":"https://api.github.com/repos/EventStore/EventStore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EventStore/EventStore/merges","archive_url":"https://api.github.com/repos/EventStore/EventStore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EventStore/EventStore/downloads","issues_url":"https://api.github.com/repos/EventStore/EventStore/issues{/number}","pulls_url":"https://api.github.com/repos/EventStore/EventStore/pulls{/number}","milestones_url":"https://api.github.com/repos/EventStore/EventStore/milestones{/number}","notifications_url":"https://api.github.com/repos/EventStore/EventStore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EventStore/EventStore/labels{/name}","releases_url":"https://api.github.com/repos/EventStore/EventStore/releases{/id}","deployments_url":"https://api.github.com/repos/EventStore/EventStore/deployments","created_at":"2012-09-17T17:22:49Z","updated_at":"2017-10-19T17:17:47Z","pushed_at":"2017-10-20T11:19:46Z","git_url":"git://github.com/EventStore/EventStore.git","ssh_url":"git@github.com:EventStore/EventStore.git","clone_url":"https://github.com/EventStore/EventStore.git","svn_url":"https://github.com/EventStore/EventStore","homepage":"https://eventstore.org","size":253019,"stargazers_count":2171,"watchers_count":2171,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":412,"mirror_url":null,"open_issues_count":115,"forks":412,"open_issues":115,"watchers":2171,"default_branch":"release-v4.0.4"}},"base":{"label":"EventStore:release-v4.0.4","ref":"release-v4.0.4","sha":"116e027c7b5f14286a31995461b64a689bd071c6","user":{"login":"EventStore","id":1628864,"avatar_url":"https://avatars1.githubusercontent.com/u/1628864?v=4","gravatar_id":"","url":"https://api.github.com/users/EventStore","html_url":"https://github.com/EventStore","followers_url":"https://api.github.com/users/EventStore/followers","following_url":"https://api.github.com/users/EventStore/following{/other_user}","gists_url":"https://api.github.com/users/EventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/EventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EventStore/subscriptions","organizations_url":"https://api.github.com/users/EventStore/orgs","repos_url":"https://api.github.com/users/EventStore/repos","events_url":"https://api.github.com/users/EventStore/events{/privacy}","received_events_url":"https://api.github.com/users/EventStore/received_events","type":"Organization","site_admin":false},"repo":{"id":5844474,"name":"EventStore","full_name":"EventStore/EventStore","owner":{"login":"EventStore","id":1628864,"avatar_url":"https://avatars1.githubusercontent.com/u/1628864?v=4","gravatar_id":"","url":"https://api.github.com/users/EventStore","html_url":"https://github.com/EventStore","followers_url":"https://api.github.com/users/EventStore/followers","following_url":"https://api.github.com/users/EventStore/following{/other_user}","gists_url":"https://api.github.com/users/EventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/EventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EventStore/subscriptions","organizations_url":"https://api.github.com/users/EventStore/orgs","repos_url":"https://api.github.com/users/EventStore/repos","events_url":"https://api.github.com/users/EventStore/events{/privacy}","received_events_url":"https://api.github.com/users/EventStore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EventStore/EventStore","description":"The open-source, functional database with Complex Event Processing in JavaScript.","fork":false,"url":"https://api.github.com/repos/EventStore/EventStore","forks_url":"https://api.github.com/repos/EventStore/EventStore/forks","keys_url":"https://api.github.com/repos/EventStore/EventStore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EventStore/EventStore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EventStore/EventStore/teams","hooks_url":"https://api.github.com/repos/EventStore/EventStore/hooks","issue_events_url":"https://api.github.com/repos/EventStore/EventStore/issues/events{/number}","events_url":"https://api.github.com/repos/EventStore/EventStore/events","assignees_url":"https://api.github.com/repos/EventStore/EventStore/assignees{/user}","branches_url":"https://api.github.com/repos/EventStore/EventStore/branches{/branch}","tags_url":"https://api.github.com/repos/EventStore/EventStore/tags","blobs_url":"https://api.github.com/repos/EventStore/EventStore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EventStore/EventStore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EventStore/EventStore/git/refs{/sha}","trees_url":"https://api.github.com/repos/EventStore/EventStore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EventStore/EventStore/statuses/{sha}","languages_url":"https://api.github.com/repos/EventStore/EventStore/languages","stargazers_url":"https://api.github.com/repos/EventStore/EventStore/stargazers","contributors_url":"https://api.github.com/repos/EventStore/EventStore/contributors","subscribers_url":"https://api.github.com/repos/EventStore/EventStore/subscribers","subscription_url":"https://api.github.com/repos/EventStore/EventStore/subscription","commits_url":"https://api.github.com/repos/EventStore/EventStore/commits{/sha}","git_commits_url":"https://api.github.com/repos/EventStore/EventStore/git/commits{/sha}","comments_url":"https://api.github.com/repos/EventStore/EventStore/comments{/number}","issue_comment_url":"https://api.github.com/repos/EventStore/EventStore/issues/comments{/number}","contents_url":"https://api.github.com/repos/EventStore/EventStore/contents/{+path}","compare_url":"https://api.github.com/repos/EventStore/EventStore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EventStore/EventStore/merges","archive_url":"https://api.github.com/repos/EventStore/EventStore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EventStore/EventStore/downloads","issues_url":"https://api.github.com/repos/EventStore/EventStore/issues{/number}","pulls_url":"https://api.github.com/repos/EventStore/EventStore/pulls{/number}","milestones_url":"https://api.github.com/repos/EventStore/EventStore/milestones{/number}","notifications_url":"https://api.github.com/repos/EventStore/EventStore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EventStore/EventStore/labels{/name}","releases_url":"https://api.github.com/repos/EventStore/EventStore/releases{/id}","deployments_url":"https://api.github.com/repos/EventStore/EventStore/deployments","created_at":"2012-09-17T17:22:49Z","updated_at":"2017-10-19T17:17:47Z","pushed_at":"2017-10-20T11:19:46Z","git_url":"git://github.com/EventStore/EventStore.git","ssh_url":"git@github.com:EventStore/EventStore.git","clone_url":"https://github.com/EventStore/EventStore.git","svn_url":"https://github.com/EventStore/EventStore","homepage":"https://eventstore.org","size":253019,"stargazers_count":2171,"watchers_count":2171,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":412,"mirror_url":null,"open_issues_count":115,"forks":412,"open_issues":115,"watchers":2171,"default_branch":"release-v4.0.4"}},"_links":{"self":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/1471"},"html":{"href":"https://github.com/EventStore/EventStore/pull/1471"},"issue":{"href":"https://api.github.com/repos/EventStore/EventStore/issues/1471"},"comments":{"href":"https://api.github.com/repos/EventStore/EventStore/issues/1471/comments"},"review_comments":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/1471/comments"},"review_comment":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/1471/commits"},"statuses":{"href":"https://api.github.com/repos/EventStore/EventStore/statuses/75442aeab4b232a81c7face7c6188c8dec7287c2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shaan1337","id":14981676,"avatar_url":"https://avatars3.githubusercontent.com/u/14981676?v=4","gravatar_id":"","url":"https://api.github.com/users/shaan1337","html_url":"https://github.com/shaan1337","followers_url":"https://api.github.com/users/shaan1337/followers","following_url":"https://api.github.com/users/shaan1337/following{/other_user}","gists_url":"https://api.github.com/users/shaan1337/gists{/gist_id}","starred_url":"https://api.github.com/users/shaan1337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaan1337/subscriptions","organizations_url":"https://api.github.com/users/shaan1337/orgs","repos_url":"https://api.github.com/users/shaan1337/repos","events_url":"https://api.github.com/users/shaan1337/events{/privacy}","received_events_url":"https://api.github.com/users/shaan1337/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":35,"changed_files":1}}
{"actor":{"display_login":"shaan1337"}}