{"action":"created","issue":{"url":"https://api.github.com/repos/wpengine/lostromos/issues/17","repository_url":"https://api.github.com/repos/wpengine/lostromos","labels_url":"https://api.github.com/repos/wpengine/lostromos/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/wpengine/lostromos/issues/17/comments","events_url":"https://api.github.com/repos/wpengine/lostromos/issues/17/events","html_url":"https://github.com/wpengine/lostromos/pull/17","id":268840901,"number":17,"title":"Add prometheus metrics endpoint to start command.","user":{"login":"jhyelton","id":9421517,"avatar_url":"https://avatars2.githubusercontent.com/u/9421517?v=4","gravatar_id":"","url":"https://api.github.com/users/jhyelton","html_url":"https://github.com/jhyelton","followers_url":"https://api.github.com/users/jhyelton/followers","following_url":"https://api.github.com/users/jhyelton/following{/other_user}","gists_url":"https://api.github.com/users/jhyelton/gists{/gist_id}","starred_url":"https://api.github.com/users/jhyelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhyelton/subscriptions","organizations_url":"https://api.github.com/users/jhyelton/orgs","repos_url":"https://api.github.com/users/jhyelton/repos","events_url":"https://api.github.com/users/jhyelton/events{/privacy}","received_events_url":"https://api.github.com/users/jhyelton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-26T17:11:22Z","updated_at":"2017-10-26T18:43:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/wpengine/lostromos/pulls/17","html_url":"https://github.com/wpengine/lostromos/pull/17","diff_url":"https://github.com/wpengine/lostromos/pull/17.diff","patch_url":"https://github.com/wpengine/lostromos/pull/17.patch"},"body":"Signed-off-by: Josh Yelton <josh.yelton@wpengine.com>\r\n\r\n# What Are We Doing Here\r\n\r\nAdding a /metrics endpoint that outputs metrics in the prometheus format.\r\n\r\n## How to Verify\r\n\r\n1. Check out this PR\r\n2. Setup kubectl against a cluster (minikube works just fine)\r\n3. kubectl apply -f test-data/crd.yml\r\n4. kubectl apply -f test-data/cr_things.yml\r\n5. go run main.go --config test-data/config.yaml start\r\n6. curl localhost:8080/metrics\r\n- Verify you see output in the prometheus format"},"comment":{"url":"https://api.github.com/repos/wpengine/lostromos/issues/comments/339761098","html_url":"https://github.com/wpengine/lostromos/pull/17#issuecomment-339761098","issue_url":"https://api.github.com/repos/wpengine/lostromos/issues/17","id":339761098,"user":{"login":"lvaughn","id":103400,"avatar_url":"https://avatars1.githubusercontent.com/u/103400?v=4","gravatar_id":"","url":"https://api.github.com/users/lvaughn","html_url":"https://github.com/lvaughn","followers_url":"https://api.github.com/users/lvaughn/followers","following_url":"https://api.github.com/users/lvaughn/following{/other_user}","gists_url":"https://api.github.com/users/lvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/lvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvaughn/subscriptions","organizations_url":"https://api.github.com/users/lvaughn/orgs","repos_url":"https://api.github.com/users/lvaughn/repos","events_url":"https://api.github.com/users/lvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/lvaughn/received_events","type":"User","site_admin":false},"created_at":"2017-10-26T18:43:24Z","updated_at":"2017-10-26T18:43:24Z","author_association":"OWNER","body":"@nicolerenee What are your thoughts on the reduction of code coverage on this? It's the only reason it's failing CI.\r\n\r\nThe code itself looks fine to me. We could perhaps, bump up coverage a bit, but most of what this code does is use the Promethius package, which I would assume has it's own tests."}}
{"actor":{"display_login":"lvaughn"}}