{"action":"created","issue":{"url":"https://api.github.com/repos/X2CommunityCore/X2CommunityHighlander/issues/200","repository_url":"https://api.github.com/repos/X2CommunityCore/X2CommunityHighlander","labels_url":"https://api.github.com/repos/X2CommunityCore/X2CommunityHighlander/issues/200/labels{/name}","comments_url":"https://api.github.com/repos/X2CommunityCore/X2CommunityHighlander/issues/200/comments","events_url":"https://api.github.com/repos/X2CommunityCore/X2CommunityHighlander/issues/200/events","html_url":"https://github.com/X2CommunityCore/X2CommunityHighlander/issues/200","id":213589217,"number":200,"title":"Environmental explosions ignore all effects","user":{"login":"bountygiver","id":5686197,"avatar_url":"https://avatars2.githubusercontent.com/u/5686197?v=3","gravatar_id":"","url":"https://api.github.com/users/bountygiver","html_url":"https://github.com/bountygiver","followers_url":"https://api.github.com/users/bountygiver/followers","following_url":"https://api.github.com/users/bountygiver/following{/other_user}","gists_url":"https://api.github.com/users/bountygiver/gists{/gist_id}","starred_url":"https://api.github.com/users/bountygiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bountygiver/subscriptions","organizations_url":"https://api.github.com/users/bountygiver/orgs","repos_url":"https://api.github.com/users/bountygiver/repos","events_url":"https://api.github.com/users/bountygiver/events{/privacy}","received_events_url":"https://api.github.com/users/bountygiver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-03-12T07:51:50Z","updated_at":"2017-03-15T04:45:48Z","closed_at":null,"body":"Environmental explosions currently just damage the affected unit for a set amount, ignoring all effects except armor and shields. This is due to damage reductions/immunities are only checked in `X2Effect_ApplyWeaponDamage` but not in `XCOmGameState_Unit.TakeDamage`, causing units with fortress to still take damage from exploding cars/gas canisters.\r\n\r\nFix: Instead of calling `TakeDamage()` directly, apply a `X2Effect_ApplyWeaponDamage` effect instead, dynamically generate an x2effect right before dealing damage should be OK as without references from template managers it should be garbage collected, otherwise extend the effect with a new effect that takes in the destructible source. The code is in `Explode()` function of `XComGameState_DestructionSphere`\r\n\r\ncode to apply effects without triggering ability can be found in `EverVigilantTurnEndListener` in `XComGameState_Ability`"},"comment":{"url":"https://api.github.com/repos/X2CommunityCore/X2CommunityHighlander/issues/comments/286639897","html_url":"https://github.com/X2CommunityCore/X2CommunityHighlander/issues/200#issuecomment-286639897","issue_url":"https://api.github.com/repos/X2CommunityCore/X2CommunityHighlander/issues/200","id":286639897,"user":{"login":"bountygiver","id":5686197,"avatar_url":"https://avatars2.githubusercontent.com/u/5686197?v=3","gravatar_id":"","url":"https://api.github.com/users/bountygiver","html_url":"https://github.com/bountygiver","followers_url":"https://api.github.com/users/bountygiver/followers","following_url":"https://api.github.com/users/bountygiver/following{/other_user}","gists_url":"https://api.github.com/users/bountygiver/gists{/gist_id}","starred_url":"https://api.github.com/users/bountygiver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bountygiver/subscriptions","organizations_url":"https://api.github.com/users/bountygiver/orgs","repos_url":"https://api.github.com/users/bountygiver/repos","events_url":"https://api.github.com/users/bountygiver/events{/privacy}","received_events_url":"https://api.github.com/users/bountygiver/received_events","type":"User","site_admin":false},"created_at":"2017-03-15T04:45:48Z","updated_at":"2017-03-15T04:45:48Z","body":"I will run a test with my scrapped mod project to trace which one is the actual one called"}}
{"actor":{"display_login":"bountygiver"}}