{"action":"created","issue":{"url":"https://api.github.com/repos/websdk/rhumb/issues/19","repository_url":"https://api.github.com/repos/websdk/rhumb","labels_url":"https://api.github.com/repos/websdk/rhumb/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/websdk/rhumb/issues/19/comments","events_url":"https://api.github.com/repos/websdk/rhumb/issues/19/events","html_url":"https://github.com/websdk/rhumb/pull/19","id":212484502,"number":19,"title":"WIP: update parse to support empty parts and detect leading or trailing slashes","user":{"login":"matthewdunsdon","id":100268,"avatar_url":"https://avatars3.githubusercontent.com/u/100268?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewdunsdon","html_url":"https://github.com/matthewdunsdon","followers_url":"https://api.github.com/users/matthewdunsdon/followers","following_url":"https://api.github.com/users/matthewdunsdon/following{/other_user}","gists_url":"https://api.github.com/users/matthewdunsdon/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewdunsdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewdunsdon/subscriptions","organizations_url":"https://api.github.com/users/matthewdunsdon/orgs","repos_url":"https://api.github.com/users/matthewdunsdon/repos","events_url":"https://api.github.com/users/matthewdunsdon/events{/privacy}","received_events_url":"https://api.github.com/users/matthewdunsdon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-07T16:26:15Z","updated_at":"2017-03-07T16:28:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/websdk/rhumb/pulls/19","html_url":"https://github.com/websdk/rhumb/pull/19","diff_url":"https://github.com/websdk/rhumb/pull/19.diff","patch_url":"https://github.com/websdk/rhumb/pull/19.patch"},"body":"In order to perform interpolation, we should be able to parse a path whilst keeping track of empty segments and detect leading or trailing slashes.  Rather than doing this work in _<https://github.com/websdk/rhumb/pull/18>_, it seemed better to pull this work out to here.\r\n\r\nThis is going to involve some big changes to how parse works.  I have updated the unit tests for parse (as the output is formatted differently, however I have only added tests to the routing code.\r\n\r\nAlso this allows us to review the parsing as a whole and explore how the edge cases are handled.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My change follows the style of this project\r\n- [ ] My change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [contribution guidelines](../CONTRIBUTING.md)\r\n- [ ] I have added tests to cover my changes\r\n- [ ] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/websdk/rhumb/issues/comments/284773694","html_url":"https://github.com/websdk/rhumb/pull/19#issuecomment-284773694","issue_url":"https://api.github.com/repos/websdk/rhumb/issues/19","id":284773694,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars2.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-03-07T16:28:57Z","updated_at":"2017-03-07T16:28:57Z","body":"\n[![Coverage Status](https://coveralls.io/builds/10473904/badge)](https://coveralls.io/builds/10473904)\n\nCoverage decreased (-0.7%) to 99.315% when pulling **b9125e021e51a4b6db8da35ea937c2d07b434dc1 on matthewdunsdon:allow-parse-to-return-empty-parts** into **ce8bda5993bb6c91cb6d37c5d05ce3b9119a4536 on websdk:master**.\n"}}
{"actor":{"display_login":"coveralls"}}