{"action":"opened","number":3031,"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/3031","id":139907565,"html_url":"https://github.com/aframevr/aframe/pull/3031","diff_url":"https://github.com/aframevr/aframe/pull/3031.diff","patch_url":"https://github.com/aframevr/aframe/pull/3031.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/3031","number":3031,"state":"open","locked":false,"title":"Do not resize the canvas while presenting (leads to resolution drop)","user":{"login":"olga-microsoft","id":31327535,"avatar_url":"https://avatars1.githubusercontent.com/u/31327535?v=4","gravatar_id":"","url":"https://api.github.com/users/olga-microsoft","html_url":"https://github.com/olga-microsoft","followers_url":"https://api.github.com/users/olga-microsoft/followers","following_url":"https://api.github.com/users/olga-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/olga-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/olga-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olga-microsoft/subscriptions","organizations_url":"https://api.github.com/users/olga-microsoft/orgs","repos_url":"https://api.github.com/users/olga-microsoft/repos","events_url":"https://api.github.com/users/olga-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/olga-microsoft/received_events","type":"User","site_admin":false},"body":"Do not resize canvas in VR mode (not only for mobile, but for desktop too)\r\nTested on Edge + WMR, Firefox + Vive and Gear VR\r\n\r\nResizing the browser window while presenting leads to the canvas being resized accordingly, which updates resolution in the headset, causing a bad experience. Since Aframe does not rely on Three.js built-in mechanism for resizing the canvas this needs to be handled explicitly in a-scene.js.","created_at":"2017-09-07T21:20:03Z","updated_at":"2017-09-07T21:20:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13c96d90c5e3ba369a3f9876a7fcbcac9d51a16e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/3031/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/3031/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/3031/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/c9a93b5b960c256c936698b621c3692f967a75a1","head":{"label":"olga-microsoft:msft/resize-resolution-drops","ref":"msft/resize-resolution-drops","sha":"c9a93b5b960c256c936698b621c3692f967a75a1","user":{"login":"olga-microsoft","id":31327535,"avatar_url":"https://avatars1.githubusercontent.com/u/31327535?v=4","gravatar_id":"","url":"https://api.github.com/users/olga-microsoft","html_url":"https://github.com/olga-microsoft","followers_url":"https://api.github.com/users/olga-microsoft/followers","following_url":"https://api.github.com/users/olga-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/olga-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/olga-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olga-microsoft/subscriptions","organizations_url":"https://api.github.com/users/olga-microsoft/orgs","repos_url":"https://api.github.com/users/olga-microsoft/repos","events_url":"https://api.github.com/users/olga-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/olga-microsoft/received_events","type":"User","site_admin":false},"repo":{"id":101350566,"name":"aframe","full_name":"olga-microsoft/aframe","owner":{"login":"olga-microsoft","id":31327535,"avatar_url":"https://avatars1.githubusercontent.com/u/31327535?v=4","gravatar_id":"","url":"https://api.github.com/users/olga-microsoft","html_url":"https://github.com/olga-microsoft","followers_url":"https://api.github.com/users/olga-microsoft/followers","following_url":"https://api.github.com/users/olga-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/olga-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/olga-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olga-microsoft/subscriptions","organizations_url":"https://api.github.com/users/olga-microsoft/orgs","repos_url":"https://api.github.com/users/olga-microsoft/repos","events_url":"https://api.github.com/users/olga-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/olga-microsoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olga-microsoft/aframe","description":":a: web framework for building virtual reality experiences.","fork":true,"url":"https://api.github.com/repos/olga-microsoft/aframe","forks_url":"https://api.github.com/repos/olga-microsoft/aframe/forks","keys_url":"https://api.github.com/repos/olga-microsoft/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olga-microsoft/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olga-microsoft/aframe/teams","hooks_url":"https://api.github.com/repos/olga-microsoft/aframe/hooks","issue_events_url":"https://api.github.com/repos/olga-microsoft/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/olga-microsoft/aframe/events","assignees_url":"https://api.github.com/repos/olga-microsoft/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/olga-microsoft/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/olga-microsoft/aframe/tags","blobs_url":"https://api.github.com/repos/olga-microsoft/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olga-microsoft/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olga-microsoft/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/olga-microsoft/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olga-microsoft/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/olga-microsoft/aframe/languages","stargazers_url":"https://api.github.com/repos/olga-microsoft/aframe/stargazers","contributors_url":"https://api.github.com/repos/olga-microsoft/aframe/contributors","subscribers_url":"https://api.github.com/repos/olga-microsoft/aframe/subscribers","subscription_url":"https://api.github.com/repos/olga-microsoft/aframe/subscription","commits_url":"https://api.github.com/repos/olga-microsoft/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/olga-microsoft/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/olga-microsoft/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/olga-microsoft/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/olga-microsoft/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/olga-microsoft/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olga-microsoft/aframe/merges","archive_url":"https://api.github.com/repos/olga-microsoft/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olga-microsoft/aframe/downloads","issues_url":"https://api.github.com/repos/olga-microsoft/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/olga-microsoft/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/olga-microsoft/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/olga-microsoft/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olga-microsoft/aframe/labels{/name}","releases_url":"https://api.github.com/repos/olga-microsoft/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/olga-microsoft/aframe/deployments","created_at":"2017-08-25T00:58:01Z","updated_at":"2017-08-25T00:58:04Z","pushed_at":"2017-09-07T21:19:12Z","git_url":"git://github.com/olga-microsoft/aframe.git","ssh_url":"git@github.com:olga-microsoft/aframe.git","clone_url":"https://github.com/olga-microsoft/aframe.git","svn_url":"https://github.com/olga-microsoft/aframe","homepage":"https://aframe.io/","size":191053,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"f4850f2906ae21790e1aca2904c637dac93808d7","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars0.githubusercontent.com/u/16024092?v=4","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars0.githubusercontent.com/u/16024092?v=4","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":":a: web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2017-09-07T21:11:52Z","pushed_at":"2017-09-07T21:20:04Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":199764,"stargazers_count":6372,"watchers_count":6372,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1391,"mirror_url":null,"open_issues_count":215,"forks":1391,"open_issues":215,"watchers":6372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3031"},"html":{"href":"https://github.com/aframevr/aframe/pull/3031"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/3031"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/3031/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3031/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3031/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/c9a93b5b960c256c936698b621c3692f967a75a1"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"olga-microsoft"}}