{"action":"closed","issue":{"url":"https://api.github.com/repos/rails/rails/issues/28908","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/28908/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/28908/comments","events_url":"https://api.github.com/repos/rails/rails/issues/28908/events","html_url":"https://github.com/rails/rails/issues/28908","id":224871298,"number":28908,"title":"Stack Level Too Deep - Circular Code Path with around_save + relation update, and has_one","user":{"login":"mordof-work","id":7644904,"avatar_url":"https://avatars2.githubusercontent.com/u/7644904?v=4","gravatar_id":"","url":"https://api.github.com/users/mordof-work","html_url":"https://github.com/mordof-work","followers_url":"https://api.github.com/users/mordof-work/followers","following_url":"https://api.github.com/users/mordof-work/following{/other_user}","gists_url":"https://api.github.com/users/mordof-work/gists{/gist_id}","starred_url":"https://api.github.com/users/mordof-work/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mordof-work/subscriptions","organizations_url":"https://api.github.com/users/mordof-work/orgs","repos_url":"https://api.github.com/users/mordof-work/repos","events_url":"https://api.github.com/users/mordof-work/events{/privacy}","received_events_url":"https://api.github.com/users/mordof-work/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-04-27T18:22:49Z","updated_at":"2017-09-01T14:41:29Z","closed_at":"2017-09-01T14:41:29Z","author_association":"NONE","body":"### Steps to reproduce\r\n\r\nI created a small environment program that demonstrates the problem. The README.md explains more about how to setup, and run the test environment.\r\n\r\nhttps://github.com/mordof-work/test_environment\r\n\r\n### Expected behavior\r\nI expect that when an agency record gets saved with a changed name/is_deleted flag, the associated node record has those fields set, and gets saved. Then everything moves on business as usual.\r\n\r\n### Actual behavior\r\nInstead of carrying on after node.save happens - node.save triggers another agency update. The <x>_changes? knowledge never gets resolved, which causes the node to always get saved again and again.\r\n\r\nThis causes a circular code path, resulting in a Stack Level Too Deep.\r\n\r\n### System configuration\r\n**Rails version**:\r\nActiveRecord / ActiveModel / ActiveSupport version 5.0.2\r\n\r\nProblem is not found in ActiveRecord / ActiveModel / ActiveSupport 4.1.5 (which is what I'm upgrading from)\r\n\r\n**Ruby version**:\r\n2.3.3"}}
{"actor":{"display_login":"mordof-work"}}