{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/comments/113977674","pull_request_review_id":35413630,"id":113977674,"diff_hunk":"@@ -1,17 +1,19 @@\n /* eslint import/no-extraneous-dependencies: [\"error\", {\"devDependencies\": true}] */\n-const deTranslations = require('../../lib/translations/de.js').messages;\n-const enTranslations = require('../../lib/translations/en.js').messages;\n-const enGBTranslations = require('../../lib/translations/en-GB.js').messages;\n-const enUSTranslations = require('../../lib/translations/en-US.js').messages;\n-const esTranslations = require('../../lib/translations/es.js').messages;\n-const fiFITranslations = require('../../lib/translations/fi-FI.js').messages;\n-const frTranslations = require('../../lib/translations/fr.js').messages;\n-const ptTranslations = require('../../lib/translations/pt.js').messages;\n+const screenshot = require('terra-toolkit').screenshot;\n+const fs = require('fs');\n+const path = require('path');\n+\n+const deTranslations = JSON.parse(fs.readFileSync(path.resolve(__dirname, '..', '..', 'translations', 'de.json'), 'utf8'));","path":"packages/terra-i18n/tests/nightwatch/i18n-spec.js","position":14,"original_position":14,"commit_id":"71addbd4096140cfda5aa0afe5a5ff2392126d68","original_commit_id":"71addbd4096140cfda5aa0afe5a5ff2392126d68","user":{"login":"ryanthemanuel","id":4873279,"avatar_url":"https://avatars0.githubusercontent.com/u/4873279?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false},"body":"Good call","created_at":"2017-04-28T17:13:26Z","updated_at":"2017-04-28T17:13:26Z","html_url":"https://github.com/cerner/terra-core/pull/272#discussion_r113977674","pull_request_url":"https://api.github.com/repos/cerner/terra-core/pulls/272","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments/113977674"},"html":{"href":"https://github.com/cerner/terra-core/pull/272#discussion_r113977674"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/272"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-core/pulls/272","id":118016042,"html_url":"https://github.com/cerner/terra-core/pull/272","diff_url":"https://github.com/cerner/terra-core/pull/272.diff","patch_url":"https://github.com/cerner/terra-core/pull/272.patch","issue_url":"https://api.github.com/repos/cerner/terra-core/issues/272","number":272,"state":"open","locked":false,"title":"I18n webpack plugin","user":{"login":"ryanthemanuel","id":4873279,"avatar_url":"https://avatars0.githubusercontent.com/u/4873279?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nBelow is a description of how the I18nAggregatorPlugin will be utilized.\r\n\r\n### I18nAggregatorPlugin\r\n\r\nThis plugin needs to be added to the list of plugins available in your webpack config with a required option of baseDirectory:\r\n\r\n```js\r\nnew I18nAggregatorPlugin({\r\n  baseDirectory: __dirname,\r\n}\r\n```\r\n\r\nBy including this plugin, all dependencies will be examined for translation files in a translation folder at the root of the directory for supported locales (e.g. de.js or en.js) formatted as follows:\r\n\r\n```js\r\nconst messages = {\r\n  'Terra.ajax.error': 'Inhalt konnte nicht geladen werden.',\r\n};\r\n\r\nmodule.exports = {\r\n  messages,\r\n};\r\n```\r\n\r\nThen all of the messages for a given language across all dependencies will be aggregated into an overall translation file for that language and placed into an aggregated-translations directory.  In order for these resulting files to be able to be loaded by terra-i18n, that directory then needs to be added to the list of directories that the webpack resolver looks into.","created_at":"2017-04-27T19:39:10Z","updated_at":"2017-04-28T17:13:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a8c67dbcc1cc9c7a9ebbf0896cd40ccfd1376c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-core/pulls/272/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-core/pulls/272/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-core/issues/272/comments","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/71addbd4096140cfda5aa0afe5a5ff2392126d68","head":{"label":"cerner:i18n_webpack_plugin","ref":"i18n_webpack_plugin","sha":"71addbd4096140cfda5aa0afe5a5ff2392126d68","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"name":"terra-core","full_name":"cerner/terra-core","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/terra-core","description":null,"fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2017-03-30T14:48:19Z","pushed_at":"2017-04-28T16:53:23Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"git@github.com:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":null,"size":6297,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":41,"forks":8,"open_issues":41,"watchers":15,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"6cadfba28d3be057f658b23a0773ada66caaee82","user":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":83073156,"name":"terra-core","full_name":"cerner/terra-core","owner":{"login":"cerner","id":1873208,"avatar_url":"https://avatars2.githubusercontent.com/u/1873208?v=3","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/terra-core","description":null,"fork":false,"url":"https://api.github.com/repos/cerner/terra-core","forks_url":"https://api.github.com/repos/cerner/terra-core/forks","keys_url":"https://api.github.com/repos/cerner/terra-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-core/teams","hooks_url":"https://api.github.com/repos/cerner/terra-core/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-core/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-core/events","assignees_url":"https://api.github.com/repos/cerner/terra-core/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-core/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-core/tags","blobs_url":"https://api.github.com/repos/cerner/terra-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-core/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-core/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-core/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-core/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-core/subscription","commits_url":"https://api.github.com/repos/cerner/terra-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-core/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-core/merges","archive_url":"https://api.github.com/repos/cerner/terra-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-core/downloads","issues_url":"https://api.github.com/repos/cerner/terra-core/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-core/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-core/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-core/deployments","created_at":"2017-02-24T18:57:33Z","updated_at":"2017-03-30T14:48:19Z","pushed_at":"2017-04-28T16:53:23Z","git_url":"git://github.com/cerner/terra-core.git","ssh_url":"git@github.com:cerner/terra-core.git","clone_url":"https://github.com/cerner/terra-core.git","svn_url":"https://github.com/cerner/terra-core","homepage":null,"size":6297,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":41,"forks":8,"open_issues":41,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/272"},"html":{"href":"https://github.com/cerner/terra-core/pull/272"},"issue":{"href":"https://api.github.com/repos/cerner/terra-core/issues/272"},"comments":{"href":"https://api.github.com/repos/cerner/terra-core/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-core/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-core/statuses/71addbd4096140cfda5aa0afe5a5ff2392126d68"}}}}
{"actor":{"display_login":"ryanthemanuel"}}