{"action":"closed","number":265,"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls/265","id":129544040,"html_url":"https://github.com/neo4j/neo4j-javascript-driver/pull/265","diff_url":"https://github.com/neo4j/neo4j-javascript-driver/pull/265.diff","patch_url":"https://github.com/neo4j/neo4j-javascript-driver/pull/265.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/issues/265","number":265,"state":"closed","locked":false,"title":"Extract load balancing logic in a separate class","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars1.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"body":"Previously load balancing logic for read and write servers was coupled with storage of server addresses in `RoundRobinArray` class. Such approach was problematic because it made hard to use different load balancing strategy.\r\n\r\nThis PR pulls load balancing in a separate class and removes `RoundRobinArray`. Instead addresses are stored in simple arrays and load balancing logic is applied to those arrays. Such approach makes it easy to plug a different load balancing strategy.","created_at":"2017-07-08T22:18:35Z","updated_at":"2017-07-11T16:11:00Z","closed_at":"2017-07-11T16:11:00Z","merged_at":"2017-07-11T16:11:00Z","merge_commit_sha":"963aeae7081a89e6e455fe85fb01eb55ac364b23","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls/265/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls/265/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/issues/265/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/statuses/094d25f27da644c60fd92aba4fb75409914f94ae","head":{"label":"lutovich:1.5-lb-infra","ref":"1.5-lb-infra","sha":"094d25f27da644c60fd92aba4fb75409914f94ae","user":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars1.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"repo":{"id":74575363,"name":"neo4j-javascript-driver","full_name":"lutovich/neo4j-javascript-driver","owner":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars1.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lutovich/neo4j-javascript-driver","description":"Neo4j Bolt driver for JavaScript","fork":true,"url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver","forks_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/forks","keys_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/teams","hooks_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/hooks","issue_events_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/issues/events{/number}","events_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/events","assignees_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/assignees{/user}","branches_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/branches{/branch}","tags_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/tags","blobs_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/languages","stargazers_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/stargazers","contributors_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/contributors","subscribers_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/subscribers","subscription_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/subscription","commits_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/contents/{+path}","compare_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/merges","archive_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/downloads","issues_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/issues{/number}","pulls_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/labels{/name}","releases_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/releases{/id}","deployments_url":"https://api.github.com/repos/lutovich/neo4j-javascript-driver/deployments","created_at":"2016-11-23T12:37:34Z","updated_at":"2016-11-23T12:37:36Z","pushed_at":"2017-07-11T10:27:04Z","git_url":"git://github.com/lutovich/neo4j-javascript-driver.git","ssh_url":"git@github.com:lutovich/neo4j-javascript-driver.git","clone_url":"https://github.com/lutovich/neo4j-javascript-driver.git","svn_url":"https://github.com/lutovich/neo4j-javascript-driver","homepage":"","size":20408,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.1"}},"base":{"label":"neo4j:1.5","ref":"1.5","sha":"622e4ec3bcc88e29a81f4d7bb86e2583c17959b1","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars0.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":39573021,"name":"neo4j-javascript-driver","full_name":"neo4j/neo4j-javascript-driver","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars0.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j-javascript-driver","description":"Neo4j Bolt driver for JavaScript","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver","forks_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/deployments","created_at":"2015-07-23T14:46:34Z","updated_at":"2017-07-07T23:26:59Z","pushed_at":"2017-07-11T16:11:00Z","git_url":"git://github.com/neo4j/neo4j-javascript-driver.git","ssh_url":"git@github.com:neo4j/neo4j-javascript-driver.git","clone_url":"https://github.com/neo4j/neo4j-javascript-driver.git","svn_url":"https://github.com/neo4j/neo4j-javascript-driver","homepage":"","size":20365,"stargazers_count":233,"watchers_count":233,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":12,"forks":54,"open_issues":12,"watchers":233,"default_branch":"1.5"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls/265"},"html":{"href":"https://github.com/neo4j/neo4j-javascript-driver/pull/265"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/issues/265"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j-javascript-driver/statuses/094d25f27da644c60fd92aba4fb75409914f94ae"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lutovich","id":1638145,"avatar_url":"https://avatars1.githubusercontent.com/u/1638145?v=3","gravatar_id":"","url":"https://api.github.com/users/lutovich","html_url":"https://github.com/lutovich","followers_url":"https://api.github.com/users/lutovich/followers","following_url":"https://api.github.com/users/lutovich/following{/other_user}","gists_url":"https://api.github.com/users/lutovich/gists{/gist_id}","starred_url":"https://api.github.com/users/lutovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lutovich/subscriptions","organizations_url":"https://api.github.com/users/lutovich/orgs","repos_url":"https://api.github.com/users/lutovich/repos","events_url":"https://api.github.com/users/lutovich/events{/privacy}","received_events_url":"https://api.github.com/users/lutovich/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":391,"deletions":368,"changed_files":17}}
{"actor":{"display_login":"lutovich"}}