{"action":"created","issue":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10232","repository_url":"https://api.github.com/repos/hazelcast/hazelcast","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10232/labels{/name}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10232/comments","events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10232/events","html_url":"https://github.com/hazelcast/hazelcast/pull/10232","id":219810900,"number":10232,"title":"Fixed wrong RAW_ESTIMATE number in DenseHyperLogLogEncoder","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars0.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"labels":[{"id":137752575,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team:%20Core","name":"Team: Core","color":"109def","default":false},{"id":1740690,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Defect","name":"Type: Defect","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars0.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"assignees":[{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars0.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/87","html_url":"https://github.com/hazelcast/hazelcast/milestone/87","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/87/labels","id":2165710,"number":87,"title":"3.9","description":"","creator":{"login":"degerhz","id":8373100,"avatar_url":"https://avatars0.githubusercontent.com/u/8373100?v=3","gravatar_id":"","url":"https://api.github.com/users/degerhz","html_url":"https://github.com/degerhz","followers_url":"https://api.github.com/users/degerhz/followers","following_url":"https://api.github.com/users/degerhz/following{/other_user}","gists_url":"https://api.github.com/users/degerhz/gists{/gist_id}","starred_url":"https://api.github.com/users/degerhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degerhz/subscriptions","organizations_url":"https://api.github.com/users/degerhz/orgs","repos_url":"https://api.github.com/users/degerhz/repos","events_url":"https://api.github.com/users/degerhz/events{/privacy}","received_events_url":"https://api.github.com/users/degerhz/received_events","type":"User","site_admin":false},"open_issues":119,"closed_issues":149,"state":"open","created_at":"2016-11-30T08:32:28Z","updated_at":"2017-04-06T07:35:05Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2017-04-06T07:35:05Z","updated_at":"2017-04-06T07:37:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/10232","html_url":"https://github.com/hazelcast/hazelcast/pull/10232","diff_url":"https://github.com/hazelcast/hazelcast/pull/10232.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/10232.patch"},"body":"I just found the reason for the super spurious failures of the DenseHyperLogLog tests.\r\nI had a suspicion and just compared the arrays with an older version:\r\n\r\n```java\r\npublic class OldDenseHyperLogLogEncoderTest {\r\n\r\n    private static final double DELTA = 0.0000000000001;\r\n\r\n    @Test\r\n    public void compareDenseHyperLogLogEncoderArraysWithOldRevision() {\r\n        assertArrayEquals(\"THRESHOLD\",\r\n            OldDenseHyperLogLogEncoder.THRESHOLD,\r\n            DenseHyperLogLogEncoder.THRESHOLD);\r\n        for (int i = 0; i < OldDenseHyperLogLogEncoder.RAW_ESTIMATE_DATA.length; i++) {\r\n            assertArrayEquals(\"RAW_ESTIMATE_DATA at index \" + i,\r\n                    OldDenseHyperLogLogEncoder.RAW_ESTIMATE_DATA[i],\r\n                    DenseHyperLogLogEncoder.RAW_ESTIMATE_DATA[i],\r\n                    DELTA);\r\n        }\r\n        for (int i = 0; i < OldDenseHyperLogLogEncoder.BIAS_DATA.length; i++) {\r\n            assertArrayEquals(\"BIAS_DATA at index \" + i,\r\n                    OldDenseHyperLogLogEncoder.BIAS_DATA[i],\r\n                    DenseHyperLogLogEncoder.BIAS_DATA[i],\r\n                    DELTA);\r\n        }\r\n    }\r\n}\r\n```\r\n\r\n```java\r\nRAW_ESTIMATE_DATA at index 14: arrays first differed at element [162]; \r\nExpected :1062476.184\r\nActual   :62476.184\r\n```\r\n\r\nWhen I fix the number, the test passes. So it was me who accidetally deleted that digit during a reformat. I used IDEA for the reformat, so there should be no human error. But I must have pressed [DEL] at the wrong time. And since the feature and tests are non-deterministic, it slipped through.\r\n\r\nLong story short, there is a `1` missing, and we should re-add it to the array to make our users happy. Sorry for that :("},"comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/292093792","html_url":"https://github.com/hazelcast/hazelcast/pull/10232#issuecomment-292093792","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10232","id":292093792,"user":{"login":"tkountis","id":3369598,"avatar_url":"https://avatars1.githubusercontent.com/u/3369598?v=3","gravatar_id":"","url":"https://api.github.com/users/tkountis","html_url":"https://github.com/tkountis","followers_url":"https://api.github.com/users/tkountis/followers","following_url":"https://api.github.com/users/tkountis/following{/other_user}","gists_url":"https://api.github.com/users/tkountis/gists{/gist_id}","starred_url":"https://api.github.com/users/tkountis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkountis/subscriptions","organizations_url":"https://api.github.com/users/tkountis/orgs","repos_url":"https://api.github.com/users/tkountis/repos","events_url":"https://api.github.com/users/tkountis/events{/privacy}","received_events_url":"https://api.github.com/users/tkountis/received_events","type":"User","site_admin":false},"created_at":"2017-04-06T07:37:29Z","updated_at":"2017-04-06T07:37:29Z","body":"Bloody hell :) - Nice catch!! :+1: "}}
{"actor":{"display_login":"tkountis"}}