{"action":"created","comment":{"url":"https://api.github.com/repos/apache/metron/pulls/comments/126689168","pull_request_review_id":49196007,"id":126689168,"diff_hunk":"@@ -0,0 +1,174 @@\n+<?xml version=\"1.0\"?>\n+<?xml-stylesheet type=\"text/xsl\" href=\"configuration.xsl\"?>\n+<!--\n+  Licensed to the Apache Software Foundation (ASF) under one\n+  or more contributor license agreements.  See the NOTICE file\n+  distributed with this work for additional information\n+  regarding copyright ownership.  The ASF licenses this file\n+  to you under the Apache License, Version 2.0 (the\n+  \"License\"); you may not use this file except in compliance\n+  with the License.  You may obtain a copy of the License at\n+\n+       http://www.apache.org/licenses/LICENSE-2.0\n+\n+  Unless required by applicable law or agreed to in writing, software\n+  distributed under the License is distributed on an \"AS IS\" BASIS,\n+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+  See the License for the specific language governing permissions and\n+  limitations under the License.\n+-->\n+<configuration supports_final=\"true\">\n+  <property>\n+    <name>geoip_url</name>\n+    <value>http://geolite.maxmind.com/download/geoip/database/GeoLite2-City.mmdb.gz</value>\n+    <description>Location of the GeoIP data to load.</description>\n+    <display-name>GEOIP Load Datafile URL</display-name>\n+  </property>\n+  <property>\n+    <name>enrichment_host_known_hosts</name>\n+    <description>List of Known Hosts for Host Enrichment</description>\n+    <value>[{\"ip\":\"10.1.128.236\", \"local\":\"YES\", \"type\":\"webserver\", \"asset_value\" : \"important\"},{\"ip\":\"10.1.128.237\", \"local\":\"UNKNOWN\", \"type\":\"unknown\", \"asset_value\" : \"important\"},{\"ip\":\"10.60.10.254\", \"local\":\"YES\", \"type\":\"printer\", \"asset_value\" : \"important\"}]</value>\n+    <display-name>Host Enrichment</display-name>\n+    <value-attributes>\n+      <type>content</type>\n+    </value-attributes>\n+  </property>\n+  <property>\n+    <name>enrichment_kafka_start</name>\n+    <description>Enrichment Topology Spout Offset</description>\n+    <value>UNCOMMITTED_EARLIEST</value>\n+    <display-name>Enrichment Offset</display-name>","path":"metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml","position":40,"original_position":40,"commit_id":"c64cd752869f49309b8bee17a1a8740e25b4d4a9","original_commit_id":"c64cd752869f49309b8bee17a1a8740e25b4d4a9","user":{"login":"nickwallen","id":2475409,"avatar_url":"https://avatars0.githubusercontent.com/u/2475409?v=3","gravatar_id":"","url":"https://api.github.com/users/nickwallen","html_url":"https://github.com/nickwallen","followers_url":"https://api.github.com/users/nickwallen/followers","following_url":"https://api.github.com/users/nickwallen/following{/other_user}","gists_url":"https://api.github.com/users/nickwallen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickwallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickwallen/subscriptions","organizations_url":"https://api.github.com/users/nickwallen/orgs","repos_url":"https://api.github.com/users/nickwallen/repos","events_url":"https://api.github.com/users/nickwallen/events{/privacy}","received_events_url":"https://api.github.com/users/nickwallen/received_events","type":"User","site_admin":false},"body":"With Ambari's drop down selector, all I can read is \"UNCOMMITTE\".  I can't actually tell if it is UNCOMITTED_EARLIEST or UNCOMMITTED_LATEST.  Is that a pre-existing condition?\r\n\r\n","created_at":"2017-07-11T13:34:31Z","updated_at":"2017-07-11T13:35:09Z","html_url":"https://github.com/apache/metron/pull/634#discussion_r126689168","pull_request_url":"https://api.github.com/repos/apache/metron/pulls/634","_links":{"self":{"href":"https://api.github.com/repos/apache/metron/pulls/comments/126689168"},"html":{"href":"https://github.com/apache/metron/pull/634#discussion_r126689168"},"pull_request":{"href":"https://api.github.com/repos/apache/metron/pulls/634"}}},"pull_request":{"url":"https://api.github.com/repos/apache/metron/pulls/634","id":129177143,"html_url":"https://github.com/apache/metron/pull/634","diff_url":"https://github.com/apache/metron/pull/634.diff","patch_url":"https://github.com/apache/metron/pull/634.patch","issue_url":"https://api.github.com/repos/apache/metron/issues/634","number":634,"state":"open","locked":false,"title":"METRON-1017: Ambari components should be separate","user":{"login":"merrimanr","id":311928,"avatar_url":"https://avatars3.githubusercontent.com/u/311928?v=3","gravatar_id":"","url":"https://api.github.com/users/merrimanr","html_url":"https://github.com/merrimanr","followers_url":"https://api.github.com/users/merrimanr/followers","following_url":"https://api.github.com/users/merrimanr/following{/other_user}","gists_url":"https://api.github.com/users/merrimanr/gists{/gist_id}","starred_url":"https://api.github.com/users/merrimanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merrimanr/subscriptions","organizations_url":"https://api.github.com/users/merrimanr/orgs","repos_url":"https://api.github.com/users/merrimanr/repos","events_url":"https://api.github.com/users/merrimanr/events{/privacy}","received_events_url":"https://api.github.com/users/merrimanr/received_events","type":"User","site_admin":false},"body":"## Contributor Comments\r\nThis PR separates the various configurations in Ambari into different *-env.xml files.  Doing this allows us to create more granular dependencies so that a configuration change only requires a restart of the affected components and not the whole service.  Previously any change to any configuration would require every Metron component to be restarted.  There was also a small amount of refactoring done to the enrichment and indexing topics in MPack scripts to make them more clear and consistent.\r\n\r\nThis can be tested by spinning up full dev and changing various configurations.  A configuration change should now only prompt to restart the affected components instead of all components.\r\n\r\n## Pull Request Checklist\r\n\r\nThank you for submitting a contribution to Apache Metron.  \r\nPlease refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  \r\nPlease refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  \r\n\r\n\r\nIn order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). \r\n- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n\r\n### For code changes:\r\n- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?\r\n- [x] Have you included steps or a guide to how the change may be verified and tested manually?\r\n- [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:\r\n  ```\r\n  mvn -q clean integration-test install && build_utils/verify_licenses.sh \r\n  ```\r\n\r\n- [x] Have you written or updated unit tests and or integration tests to verify your changes?\r\n- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?\r\n\r\n### For documentation related changes:\r\n- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:\r\n\r\n  ```\r\n  cd site-book\r\n  mvn site\r\n  ```\r\n\r\n#### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\nIt is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.\r\n\r\n","created_at":"2017-07-06T12:48:24Z","updated_at":"2017-07-11T13:35:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e423ec63786ee4c8e846813ab8b2789846fe3f8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/metron/pulls/634/commits","review_comments_url":"https://api.github.com/repos/apache/metron/pulls/634/comments","review_comment_url":"https://api.github.com/repos/apache/metron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/metron/issues/634/comments","statuses_url":"https://api.github.com/repos/apache/metron/statuses/c64cd752869f49309b8bee17a1a8740e25b4d4a9","head":{"label":"merrimanr:METRON-1017","ref":"METRON-1017","sha":"c64cd752869f49309b8bee17a1a8740e25b4d4a9","user":{"login":"merrimanr","id":311928,"avatar_url":"https://avatars3.githubusercontent.com/u/311928?v=3","gravatar_id":"","url":"https://api.github.com/users/merrimanr","html_url":"https://github.com/merrimanr","followers_url":"https://api.github.com/users/merrimanr/followers","following_url":"https://api.github.com/users/merrimanr/following{/other_user}","gists_url":"https://api.github.com/users/merrimanr/gists{/gist_id}","starred_url":"https://api.github.com/users/merrimanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merrimanr/subscriptions","organizations_url":"https://api.github.com/users/merrimanr/orgs","repos_url":"https://api.github.com/users/merrimanr/repos","events_url":"https://api.github.com/users/merrimanr/events{/privacy}","received_events_url":"https://api.github.com/users/merrimanr/received_events","type":"User","site_admin":false},"repo":{"id":62420865,"name":"incubator-metron","full_name":"merrimanr/incubator-metron","owner":{"login":"merrimanr","id":311928,"avatar_url":"https://avatars3.githubusercontent.com/u/311928?v=3","gravatar_id":"","url":"https://api.github.com/users/merrimanr","html_url":"https://github.com/merrimanr","followers_url":"https://api.github.com/users/merrimanr/followers","following_url":"https://api.github.com/users/merrimanr/following{/other_user}","gists_url":"https://api.github.com/users/merrimanr/gists{/gist_id}","starred_url":"https://api.github.com/users/merrimanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merrimanr/subscriptions","organizations_url":"https://api.github.com/users/merrimanr/orgs","repos_url":"https://api.github.com/users/merrimanr/repos","events_url":"https://api.github.com/users/merrimanr/events{/privacy}","received_events_url":"https://api.github.com/users/merrimanr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/merrimanr/incubator-metron","description":"Mirror of Apache Metron (Incubating)","fork":true,"url":"https://api.github.com/repos/merrimanr/incubator-metron","forks_url":"https://api.github.com/repos/merrimanr/incubator-metron/forks","keys_url":"https://api.github.com/repos/merrimanr/incubator-metron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/merrimanr/incubator-metron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/merrimanr/incubator-metron/teams","hooks_url":"https://api.github.com/repos/merrimanr/incubator-metron/hooks","issue_events_url":"https://api.github.com/repos/merrimanr/incubator-metron/issues/events{/number}","events_url":"https://api.github.com/repos/merrimanr/incubator-metron/events","assignees_url":"https://api.github.com/repos/merrimanr/incubator-metron/assignees{/user}","branches_url":"https://api.github.com/repos/merrimanr/incubator-metron/branches{/branch}","tags_url":"https://api.github.com/repos/merrimanr/incubator-metron/tags","blobs_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/refs{/sha}","trees_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/merrimanr/incubator-metron/statuses/{sha}","languages_url":"https://api.github.com/repos/merrimanr/incubator-metron/languages","stargazers_url":"https://api.github.com/repos/merrimanr/incubator-metron/stargazers","contributors_url":"https://api.github.com/repos/merrimanr/incubator-metron/contributors","subscribers_url":"https://api.github.com/repos/merrimanr/incubator-metron/subscribers","subscription_url":"https://api.github.com/repos/merrimanr/incubator-metron/subscription","commits_url":"https://api.github.com/repos/merrimanr/incubator-metron/commits{/sha}","git_commits_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/commits{/sha}","comments_url":"https://api.github.com/repos/merrimanr/incubator-metron/comments{/number}","issue_comment_url":"https://api.github.com/repos/merrimanr/incubator-metron/issues/comments{/number}","contents_url":"https://api.github.com/repos/merrimanr/incubator-metron/contents/{+path}","compare_url":"https://api.github.com/repos/merrimanr/incubator-metron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/merrimanr/incubator-metron/merges","archive_url":"https://api.github.com/repos/merrimanr/incubator-metron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/merrimanr/incubator-metron/downloads","issues_url":"https://api.github.com/repos/merrimanr/incubator-metron/issues{/number}","pulls_url":"https://api.github.com/repos/merrimanr/incubator-metron/pulls{/number}","milestones_url":"https://api.github.com/repos/merrimanr/incubator-metron/milestones{/number}","notifications_url":"https://api.github.com/repos/merrimanr/incubator-metron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/merrimanr/incubator-metron/labels{/name}","releases_url":"https://api.github.com/repos/merrimanr/incubator-metron/releases{/id}","deployments_url":"https://api.github.com/repos/merrimanr/incubator-metron/deployments","created_at":"2016-07-01T21:33:17Z","updated_at":"2016-07-01T21:33:20Z","pushed_at":"2017-07-10T19:40:35Z","git_url":"git://github.com/merrimanr/incubator-metron.git","ssh_url":"git@github.com:merrimanr/incubator-metron.git","clone_url":"https://github.com/merrimanr/incubator-metron.git","svn_url":"https://github.com/merrimanr/incubator-metron","homepage":null,"size":55388,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f7a94f2e631227f035c63ad258c124c0cd582189","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47607561,"name":"metron","full_name":"apache/metron","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/metron","description":"Mirror of Apache Metron","fork":false,"url":"https://api.github.com/repos/apache/metron","forks_url":"https://api.github.com/repos/apache/metron/forks","keys_url":"https://api.github.com/repos/apache/metron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/metron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/metron/teams","hooks_url":"https://api.github.com/repos/apache/metron/hooks","issue_events_url":"https://api.github.com/repos/apache/metron/issues/events{/number}","events_url":"https://api.github.com/repos/apache/metron/events","assignees_url":"https://api.github.com/repos/apache/metron/assignees{/user}","branches_url":"https://api.github.com/repos/apache/metron/branches{/branch}","tags_url":"https://api.github.com/repos/apache/metron/tags","blobs_url":"https://api.github.com/repos/apache/metron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/metron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/metron/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/metron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/metron/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/metron/languages","stargazers_url":"https://api.github.com/repos/apache/metron/stargazers","contributors_url":"https://api.github.com/repos/apache/metron/contributors","subscribers_url":"https://api.github.com/repos/apache/metron/subscribers","subscription_url":"https://api.github.com/repos/apache/metron/subscription","commits_url":"https://api.github.com/repos/apache/metron/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/metron/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/metron/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/metron/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/metron/contents/{+path}","compare_url":"https://api.github.com/repos/apache/metron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/metron/merges","archive_url":"https://api.github.com/repos/apache/metron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/metron/downloads","issues_url":"https://api.github.com/repos/apache/metron/issues{/number}","pulls_url":"https://api.github.com/repos/apache/metron/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/metron/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/metron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/metron/labels{/name}","releases_url":"https://api.github.com/repos/apache/metron/releases{/id}","deployments_url":"https://api.github.com/repos/apache/metron/deployments","created_at":"2015-12-08T08:00:05Z","updated_at":"2017-07-09T11:24:46Z","pushed_at":"2017-07-11T02:57:59Z","git_url":"git://github.com/apache/metron.git","ssh_url":"git@github.com:apache/metron.git","clone_url":"https://github.com/apache/metron.git","svn_url":"https://github.com/apache/metron","homepage":"","size":54345,"stargazers_count":327,"watchers_count":327,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":"git://git.apache.org/metron.git","open_issues_count":35,"forks":252,"open_issues":35,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/metron/pulls/634"},"html":{"href":"https://github.com/apache/metron/pull/634"},"issue":{"href":"https://api.github.com/repos/apache/metron/issues/634"},"comments":{"href":"https://api.github.com/repos/apache/metron/issues/634/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/metron/pulls/634/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/metron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/metron/pulls/634/commits"},"statuses":{"href":"https://api.github.com/repos/apache/metron/statuses/c64cd752869f49309b8bee17a1a8740e25b4d4a9"}}}}
{"actor":{"display_login":"nickwallen"}}