{"action":"created","issue":{"url":"https://api.github.com/repos/mitodl/micromasters/issues/2908","repository_url":"https://api.github.com/repos/mitodl/micromasters","labels_url":"https://api.github.com/repos/mitodl/micromasters/issues/2908/labels{/name}","comments_url":"https://api.github.com/repos/mitodl/micromasters/issues/2908/comments","events_url":"https://api.github.com/repos/mitodl/micromasters/issues/2908/events","html_url":"https://github.com/mitodl/micromasters/pull/2908","id":215102666,"number":2908,"title":"Added learner-learner search page (#2690)","user":{"login":"rhysyngsun","id":28598,"avatar_url":"https://avatars0.githubusercontent.com/u/28598?v=3","gravatar_id":"","url":"https://api.github.com/users/rhysyngsun","html_url":"https://github.com/rhysyngsun","followers_url":"https://api.github.com/users/rhysyngsun/followers","following_url":"https://api.github.com/users/rhysyngsun/following{/other_user}","gists_url":"https://api.github.com/users/rhysyngsun/gists{/gist_id}","starred_url":"https://api.github.com/users/rhysyngsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhysyngsun/subscriptions","organizations_url":"https://api.github.com/users/rhysyngsun/orgs","repos_url":"https://api.github.com/users/rhysyngsun/repos","events_url":"https://api.github.com/users/rhysyngsun/events{/privacy}","received_events_url":"https://api.github.com/users/rhysyngsun/received_events","type":"User","site_admin":false},"labels":[{"id":335628327,"url":"https://api.github.com/repos/mitodl/micromasters/labels/Needs%20Review","name":"Needs Review","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":{"login":"noisecapella","id":863262,"avatar_url":"https://avatars1.githubusercontent.com/u/863262?v=3","gravatar_id":"","url":"https://api.github.com/users/noisecapella","html_url":"https://github.com/noisecapella","followers_url":"https://api.github.com/users/noisecapella/followers","following_url":"https://api.github.com/users/noisecapella/following{/other_user}","gists_url":"https://api.github.com/users/noisecapella/gists{/gist_id}","starred_url":"https://api.github.com/users/noisecapella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisecapella/subscriptions","organizations_url":"https://api.github.com/users/noisecapella/orgs","repos_url":"https://api.github.com/users/noisecapella/repos","events_url":"https://api.github.com/users/noisecapella/events{/privacy}","received_events_url":"https://api.github.com/users/noisecapella/received_events","type":"User","site_admin":false},"assignees":[{"login":"noisecapella","id":863262,"avatar_url":"https://avatars1.githubusercontent.com/u/863262?v=3","gravatar_id":"","url":"https://api.github.com/users/noisecapella","html_url":"https://github.com/noisecapella","followers_url":"https://api.github.com/users/noisecapella/followers","following_url":"https://api.github.com/users/noisecapella/following{/other_user}","gists_url":"https://api.github.com/users/noisecapella/gists{/gist_id}","starred_url":"https://api.github.com/users/noisecapella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisecapella/subscriptions","organizations_url":"https://api.github.com/users/noisecapella/orgs","repos_url":"https://api.github.com/users/noisecapella/repos","events_url":"https://api.github.com/users/noisecapella/events{/privacy}","received_events_url":"https://api.github.com/users/noisecapella/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-03-17T19:37:20Z","updated_at":"2017-04-13T22:40:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mitodl/micromasters/pulls/2908","html_url":"https://github.com/mitodl/micromasters/pull/2908","diff_url":"https://github.com/mitodl/micromasters/pull/2908.diff","patch_url":"https://github.com/mitodl/micromasters/pull/2908.patch"},"body":"#### What are the relevant tickets?\r\nFixes #2512 \r\n\r\n#### What's this PR do?\r\nAdds a learner to learner search page.\r\n\r\n#### How should this be manually tested?\r\n\r\nYou'll need to run `./manage.py recreate_index`.\r\n\r\n- Staff search should work as it always has.\r\n- Learners should be able to search only on name and filter only on location, course, and semester.\r\n\r\n#### Where should the reviewer start?\r\n(Optional)\r\n\r\n#### Any background context you want to provide?\r\nOne of my main concerns around this work was ensuring we don't expose any sensitive profile data. The was accomplished by doing the following:\r\n\r\n- Added a new doctype that only indexes and stores non-sensitive profile information. Learner-learner search filters to this doctype. This prevents the possibility of inferring private information through filtering or aggregates and generally ensures that sensitive data doesn't end up in `_source`.\r\n- Added enforcement of filtering to non-privat eprofiles for the learner-learner search query.\r\n- Added enforcement of `_source` filtering on the learner-learner search query in case anything ever slipped through in the future.\r\n\r\n#### Screenshots (if appropriate)\r\n![selection_046](https://cloud.githubusercontent.com/assets/28598/24269361/51660e82-0fe7-11e7-8424-c5434881b44c.png)\r\n\r\n\r\n#### What GIF best describes this PR or how it makes you feel?\r\n![](http://media1.giphy.com/media/j3F9SdJo4lIsM/200w.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/mitodl/micromasters/issues/comments/294039962","html_url":"https://github.com/mitodl/micromasters/pull/2908#issuecomment-294039962","issue_url":"https://api.github.com/repos/mitodl/micromasters/issues/2908","id":294039962,"user":{"login":"rhysyngsun","id":28598,"avatar_url":"https://avatars0.githubusercontent.com/u/28598?v=3","gravatar_id":"","url":"https://api.github.com/users/rhysyngsun","html_url":"https://github.com/rhysyngsun","followers_url":"https://api.github.com/users/rhysyngsun/followers","following_url":"https://api.github.com/users/rhysyngsun/following{/other_user}","gists_url":"https://api.github.com/users/rhysyngsun/gists{/gist_id}","starred_url":"https://api.github.com/users/rhysyngsun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhysyngsun/subscriptions","organizations_url":"https://api.github.com/users/rhysyngsun/orgs","repos_url":"https://api.github.com/users/rhysyngsun/repos","events_url":"https://api.github.com/users/rhysyngsun/events{/privacy}","received_events_url":"https://api.github.com/users/rhysyngsun/received_events","type":"User","site_admin":false},"created_at":"2017-04-13T22:40:39Z","updated_at":"2017-04-13T22:40:39Z","body":"@noisecapella ready for re-review"}}
{"actor":{"display_login":"rhysyngsun"}}