{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/2382","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/2382/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/2382/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/2382/events","html_url":"https://github.com/apache/incubator-airflow/pull/2382","id":237165729,"number":2382,"title":"Contrib SparkSubmitOperator should preserve spaces in arguments","user":{"login":"ashb","id":34150,"avatar_url":"https://avatars1.githubusercontent.com/u/34150?v=3","gravatar_id":"","url":"https://api.github.com/users/ashb","html_url":"https://github.com/ashb","followers_url":"https://api.github.com/users/ashb/followers","following_url":"https://api.github.com/users/ashb/following{/other_user}","gists_url":"https://api.github.com/users/ashb/gists{/gist_id}","starred_url":"https://api.github.com/users/ashb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashb/subscriptions","organizations_url":"https://api.github.com/users/ashb/orgs","repos_url":"https://api.github.com/users/ashb/repos","events_url":"https://api.github.com/users/ashb/events{/privacy}","received_events_url":"https://api.github.com/users/ashb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-20T10:38:40Z","updated_at":"2017-06-22T16:11:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/2382","html_url":"https://github.com/apache/incubator-airflow/pull/2382","diff_url":"https://github.com/apache/incubator-airflow/pull/2382.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/2382.patch"},"body":"Dear Airflow maintainers,\r\n\r\nPlease accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!\r\n\r\n\r\n### JIRA\r\n- [[AIRFLOW-1326] Contrib Spark Submit Hook should be able to produce arguments containing spaces.](https://issues.apache.org/jira/browse/AIRFLOW-1326) \r\n\r\n\r\n### Description\r\nThis was broken in #2289/[AIRFLOW-1184](https://issues.apache.org/jira/browse/AIRFLOW-1184) and was a case of user error to me (probably caused by wrong/misleading tests).\r\n\r\nSince application_args was already an array the correct way of providing an flag and a value is in two items, not one. (i.e. the correct way is `['--option', 'value']`, not `['--option value']`) Otherwise there is no way to include an argument that includes a space.\r\n\r\n\r\n### Tests\r\n- [x] My PR updates the following unit tests: `tests/contrib/operators/test_spark_submit_operator.py` to be less confusing (i.e. split the args as stated in the previous paragraph. This has no functional difference to the tests but will be correct if someone goes to look at it). Update tests to `tests/contrib/hooks/test_spark_submit_hook.py` to cover this case explicitly.\r\n\r\n\r\n### Commits\r\n- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue."},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/310427872","html_url":"https://github.com/apache/incubator-airflow/pull/2382#issuecomment-310427872","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/2382","id":310427872,"user":{"login":"mistercrunch","id":487433,"avatar_url":"https://avatars2.githubusercontent.com/u/487433?v=3","gravatar_id":"","url":"https://api.github.com/users/mistercrunch","html_url":"https://github.com/mistercrunch","followers_url":"https://api.github.com/users/mistercrunch/followers","following_url":"https://api.github.com/users/mistercrunch/following{/other_user}","gists_url":"https://api.github.com/users/mistercrunch/gists{/gist_id}","starred_url":"https://api.github.com/users/mistercrunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mistercrunch/subscriptions","organizations_url":"https://api.github.com/users/mistercrunch/orgs","repos_url":"https://api.github.com/users/mistercrunch/repos","events_url":"https://api.github.com/users/mistercrunch/events{/privacy}","received_events_url":"https://api.github.com/users/mistercrunch/received_events","type":"User","site_admin":false},"created_at":"2017-06-22T16:11:11Z","updated_at":"2017-06-22T16:11:11Z","body":"The title of this PR should reference the Jira. We rely on this to join commits to JIRA in the dev tooling."}}
{"actor":{"display_login":"mistercrunch"}}