{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/156272998","pull_request_review_id":82721888,"id":156272998,"diff_hunk":"@@ -12,6 +12,44 @@ import tracing from \"../tracelib/trace.js\";\n import scheduler from './scheduler.js';\n import util from './recipe/util.js';\n \n+class InMemoryKey {\n+  constructor(key) {\n+    var parts = key.split(\"://\");\n+    this.protocol = parts[0];\n+    assert(this.protocol == 'in-memory');\n+    this.location = parts[1];\n+  }\n+  toString() {\n+    return this.protocol + '://' + this.location;\n+  }\n+}\n+\n+export class InMemoryStorage {\n+  constructor(arc) {\n+      this._arc = arc;\n+      this.memoryMap = {};","path":"runtime/in-memory-storage.js","position":19,"original_position":19,"commit_id":"4b5f4be3b1c203628871bdc64f66f9540926ae57","original_commit_id":"4b5f4be3b1c203628871bdc64f66f9540926ae57","user":{"login":"shans","id":329053,"avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-12-12T05:13:46Z","updated_at":"2017-12-12T05:13:46Z","html_url":"https://github.com/PolymerLabs/arcs/pull/557#discussion_r156272998","pull_request_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/557","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/156272998"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/557#discussion_r156272998"},"pull_request":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/557"}},"in_reply_to_id":156270712},"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/557","id":157734416,"html_url":"https://github.com/PolymerLabs/arcs/pull/557","diff_url":"https://github.com/PolymerLabs/arcs/pull/557.diff","patch_url":"https://github.com/PolymerLabs/arcs/pull/557.patch","issue_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/557","number":557,"state":"open","locked":false,"title":"A simple implementation of a StorageFactory and a Storage object for in-memory handles.","user":{"login":"shans","id":329053,"avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-12T04:27:53Z","updated_at":"2017-12-12T05:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c9b0feaf5d28ca585abec54d346d94ad79775f9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/PolymerLabs/arcs/milestones/11","html_url":"https://github.com/PolymerLabs/arcs/milestone/11","labels_url":"https://api.github.com/repos/PolymerLabs/arcs/milestones/11/labels","id":2947365,"number":11,"title":"Persistent Rock: Technical Debt","description":"","creator":{"login":"smalls","id":562883,"avatar_url":"https://avatars2.githubusercontent.com/u/562883?v=4","gravatar_id":"","url":"https://api.github.com/users/smalls","html_url":"https://github.com/smalls","followers_url":"https://api.github.com/users/smalls/followers","following_url":"https://api.github.com/users/smalls/following{/other_user}","gists_url":"https://api.github.com/users/smalls/gists{/gist_id}","starred_url":"https://api.github.com/users/smalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smalls/subscriptions","organizations_url":"https://api.github.com/users/smalls/orgs","repos_url":"https://api.github.com/users/smalls/repos","events_url":"https://api.github.com/users/smalls/events{/privacy}","received_events_url":"https://api.github.com/users/smalls/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2017-11-29T18:31:52Z","updated_at":"2017-12-12T05:02:29Z","due_on":"2017-11-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/557/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/557/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/557/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/4b5f4be3b1c203628871bdc64f66f9540926ae57","head":{"label":"shans:storage","ref":"storage","sha":"4b5f4be3b1c203628871bdc64f66f9540926ae57","user":{"login":"shans","id":329053,"avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"repo":{"id":89650587,"name":"arcs","full_name":"shans/arcs","owner":{"login":"shans","id":329053,"avatar_url":"https://avatars2.githubusercontent.com/u/329053?v=4","gravatar_id":"","url":"https://api.github.com/users/shans","html_url":"https://github.com/shans","followers_url":"https://api.github.com/users/shans/followers","following_url":"https://api.github.com/users/shans/following{/other_user}","gists_url":"https://api.github.com/users/shans/gists{/gist_id}","starred_url":"https://api.github.com/users/shans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shans/subscriptions","organizations_url":"https://api.github.com/users/shans/orgs","repos_url":"https://api.github.com/users/shans/repos","events_url":"https://api.github.com/users/shans/events{/privacy}","received_events_url":"https://api.github.com/users/shans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shans/arcs","description":null,"fork":true,"url":"https://api.github.com/repos/shans/arcs","forks_url":"https://api.github.com/repos/shans/arcs/forks","keys_url":"https://api.github.com/repos/shans/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shans/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shans/arcs/teams","hooks_url":"https://api.github.com/repos/shans/arcs/hooks","issue_events_url":"https://api.github.com/repos/shans/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/shans/arcs/events","assignees_url":"https://api.github.com/repos/shans/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/shans/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/shans/arcs/tags","blobs_url":"https://api.github.com/repos/shans/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shans/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shans/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/shans/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shans/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/shans/arcs/languages","stargazers_url":"https://api.github.com/repos/shans/arcs/stargazers","contributors_url":"https://api.github.com/repos/shans/arcs/contributors","subscribers_url":"https://api.github.com/repos/shans/arcs/subscribers","subscription_url":"https://api.github.com/repos/shans/arcs/subscription","commits_url":"https://api.github.com/repos/shans/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/shans/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/shans/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/shans/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/shans/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/shans/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shans/arcs/merges","archive_url":"https://api.github.com/repos/shans/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shans/arcs/downloads","issues_url":"https://api.github.com/repos/shans/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/shans/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/shans/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/shans/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shans/arcs/labels{/name}","releases_url":"https://api.github.com/repos/shans/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/shans/arcs/deployments","created_at":"2017-04-28T00:06:50Z","updated_at":"2017-04-28T00:07:36Z","pushed_at":"2017-12-12T04:26:55Z","git_url":"git://github.com/shans/arcs.git","ssh_url":"git@github.com:shans/arcs.git","clone_url":"https://github.com/shans/arcs.git","svn_url":"https://github.com/shans/arcs","homepage":null,"size":14426,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"20781519c5a4b3a901a95ba1d909666cf814cf90","user":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":80783122,"name":"arcs","full_name":"PolymerLabs/arcs","owner":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/arcs","description":null,"fork":false,"url":"https://api.github.com/repos/PolymerLabs/arcs","forks_url":"https://api.github.com/repos/PolymerLabs/arcs/forks","keys_url":"https://api.github.com/repos/PolymerLabs/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/arcs/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/arcs/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/arcs/events","assignees_url":"https://api.github.com/repos/PolymerLabs/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/arcs/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/arcs/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/arcs/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/arcs/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/arcs/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/arcs/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/arcs/merges","archive_url":"https://api.github.com/repos/PolymerLabs/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/arcs/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/arcs/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/arcs/deployments","created_at":"2017-02-03T00:32:19Z","updated_at":"2017-11-28T01:15:38Z","pushed_at":"2017-12-12T04:27:53Z","git_url":"git://github.com/PolymerLabs/arcs.git","ssh_url":"git@github.com:PolymerLabs/arcs.git","clone_url":"https://github.com/PolymerLabs/arcs.git","svn_url":"https://github.com/PolymerLabs/arcs","homepage":null,"size":14477,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":56,"license":null,"forks":11,"open_issues":56,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/557"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/557"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/557"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/arcs/statuses/4b5f4be3b1c203628871bdc64f66f9540926ae57"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"shans"}}