{"action":"created","issue":{"url":"https://api.github.com/repos/fstpackage/fst/issues/22","repository_url":"https://api.github.com/repos/fstpackage/fst","labels_url":"https://api.github.com/repos/fstpackage/fst/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/fstpackage/fst/issues/22/comments","events_url":"https://api.github.com/repos/fstpackage/fst/issues/22/events","html_url":"https://github.com/fstpackage/fst/issues/22","id":205633337,"number":22,"title":"Problem with dates","user":{"login":"derekholmes","id":978598,"avatar_url":"https://avatars0.githubusercontent.com/u/978598?v=3","gravatar_id":"","url":"https://api.github.com/users/derekholmes","html_url":"https://github.com/derekholmes","followers_url":"https://api.github.com/users/derekholmes/followers","following_url":"https://api.github.com/users/derekholmes/following{/other_user}","gists_url":"https://api.github.com/users/derekholmes/gists{/gist_id}","starred_url":"https://api.github.com/users/derekholmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekholmes/subscriptions","organizations_url":"https://api.github.com/users/derekholmes/orgs","repos_url":"https://api.github.com/users/derekholmes/repos","events_url":"https://api.github.com/users/derekholmes/events{/privacy}","received_events_url":"https://api.github.com/users/derekholmes/received_events","type":"User","site_admin":false},"labels":[{"id":515502354,"url":"https://api.github.com/repos/fstpackage/fst/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":{"login":"MarcusKlik","id":24658401,"avatar_url":"https://avatars0.githubusercontent.com/u/24658401?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcusKlik","html_url":"https://github.com/MarcusKlik","followers_url":"https://api.github.com/users/MarcusKlik/followers","following_url":"https://api.github.com/users/MarcusKlik/following{/other_user}","gists_url":"https://api.github.com/users/MarcusKlik/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusKlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusKlik/subscriptions","organizations_url":"https://api.github.com/users/MarcusKlik/orgs","repos_url":"https://api.github.com/users/MarcusKlik/repos","events_url":"https://api.github.com/users/MarcusKlik/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusKlik/received_events","type":"User","site_admin":false},"assignees":[{"login":"MarcusKlik","id":24658401,"avatar_url":"https://avatars0.githubusercontent.com/u/24658401?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcusKlik","html_url":"https://github.com/MarcusKlik","followers_url":"https://api.github.com/users/MarcusKlik/followers","following_url":"https://api.github.com/users/MarcusKlik/following{/other_user}","gists_url":"https://api.github.com/users/MarcusKlik/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusKlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusKlik/subscriptions","organizations_url":"https://api.github.com/users/MarcusKlik/orgs","repos_url":"https://api.github.com/users/MarcusKlik/repos","events_url":"https://api.github.com/users/MarcusKlik/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusKlik/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/fstpackage/fst/milestones/7","html_url":"https://github.com/fstpackage/fst/milestone/7","labels_url":"https://api.github.com/repos/fstpackage/fst/milestones/7/labels","id":2293525,"number":7,"title":"Fst package v0.8.0","description":"the `fst` format allows for:_\r\n\r\na) row binding of data frames\r\nb) column binding of data frames\r\nc) persisting (custom) column attributes\r\nd) persisting and indexing table keys\r\ne) a range of compression algorithms\r\nf) storing hashes for each data block (#49 )","creator":{"login":"fstpackage","id":20325912,"avatar_url":"https://avatars3.githubusercontent.com/u/20325912?v=3","gravatar_id":"","url":"https://api.github.com/users/fstpackage","html_url":"https://github.com/fstpackage","followers_url":"https://api.github.com/users/fstpackage/followers","following_url":"https://api.github.com/users/fstpackage/following{/other_user}","gists_url":"https://api.github.com/users/fstpackage/gists{/gist_id}","starred_url":"https://api.github.com/users/fstpackage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fstpackage/subscriptions","organizations_url":"https://api.github.com/users/fstpackage/orgs","repos_url":"https://api.github.com/users/fstpackage/repos","events_url":"https://api.github.com/users/fstpackage/events{/privacy}","received_events_url":"https://api.github.com/users/fstpackage/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":7,"state":"open","created_at":"2017-02-01T20:45:42Z","updated_at":"2017-06-26T21:11:23Z","due_on":"2017-06-20T07:00:00Z","closed_at":null},"comments":1,"created_at":"2017-02-06T16:14:59Z","updated_at":"2017-06-26T21:20:49Z","closed_at":"2017-06-26T21:11:22Z","body":"fst is not respecting dates.. I hope that is an easy fix\r\n\r\n```\r\n> u1=data.frame(DT=Sys.Date()-1:10,variable=rep(c(\"A\",\"B\"),5), value=1:10)\r\n> write.fst(u1,\"c:\\\\t\\\\u1.fst\")\r\n> u1\r\n           DT variable value\r\n1  2017-02-05        A     1\r\n2  2017-02-04        B     2\r\n3  2017-02-03        A     3\r\n4  2017-02-02        B     4\r\n5  2017-02-01        A     5\r\n6  2017-01-31        B     6\r\n7  2017-01-30        A     7\r\n8  2017-01-29        B     8\r\n9  2017-01-28        A     9\r\n10 2017-01-27        B    10\r\n> u2=read.fst(\"c:\\\\t\\\\u1.fst\")\r\n> u2\r\n      DT variable value\r\n1  17202        A     1\r\n2  17201        B     2\r\n3  17200        A     3\r\n4  17199        B     4\r\n5  17198        A     5\r\n6  17197        B     6\r\n7  17196        A     7\r\n8  17195        B     8\r\n9  17194        A     9\r\n10 17193        B    10\r\n> \r\n```"},"comment":{"url":"https://api.github.com/repos/fstpackage/fst/issues/comments/311185401","html_url":"https://github.com/fstpackage/fst/issues/22#issuecomment-311185401","issue_url":"https://api.github.com/repos/fstpackage/fst/issues/22","id":311185401,"user":{"login":"MarcusKlik","id":24658401,"avatar_url":"https://avatars0.githubusercontent.com/u/24658401?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcusKlik","html_url":"https://github.com/MarcusKlik","followers_url":"https://api.github.com/users/MarcusKlik/followers","following_url":"https://api.github.com/users/MarcusKlik/following{/other_user}","gists_url":"https://api.github.com/users/MarcusKlik/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcusKlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcusKlik/subscriptions","organizations_url":"https://api.github.com/users/MarcusKlik/orgs","repos_url":"https://api.github.com/users/MarcusKlik/repos","events_url":"https://api.github.com/users/MarcusKlik/events{/privacy}","received_events_url":"https://api.github.com/users/MarcusKlik/received_events","type":"User","site_admin":false},"created_at":"2017-06-26T21:20:49Z","updated_at":"2017-06-26T21:20:49Z","body":"Hi @derekholmes, the `Date` type should now be respected and your code example is added as a test in the package. I'm converting `Date` types which have a `double` type as base to `integer` internally as can be seen in [the test](https://github.com/fstpackage/fst/blob/develop/tests/testthat/test.date.R#L15-L19). This gives much better performance and higher compression ratio's (double's are very hard to compress effectively).\r\n\r\nThanks again for reporting the issue! "}}
{"actor":{"display_login":"MarcusKlik"}}