{"action":"created","comment":{"url":"https://api.github.com/repos/uber/AutoDispose/pulls/comments/151291506","pull_request_review_id":76976075,"id":151291506,"diff_hunk":"@@ -55,6 +55,8 @@\n \n           @Override public void onComplete() {\n             callMainSubscribeIfNecessary(d);","path":"autodispose/src/main/java/com/uber/autodispose/AutoDisposingObserverImpl.java","position":3,"original_position":3,"commit_id":"eae39d04c0b74c452a5646920d3638c0921b0351","original_commit_id":"eae39d04c0b74c452a5646920d3638c0921b0351","user":{"login":"duanbo1983","id":631469,"avatar_url":"https://avatars0.githubusercontent.com/u/631469?v=4","gravatar_id":"","url":"https://api.github.com/users/duanbo1983","html_url":"https://github.com/duanbo1983","followers_url":"https://api.github.com/users/duanbo1983/followers","following_url":"https://api.github.com/users/duanbo1983/following{/other_user}","gists_url":"https://api.github.com/users/duanbo1983/gists{/gist_id}","starred_url":"https://api.github.com/users/duanbo1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duanbo1983/subscriptions","organizations_url":"https://api.github.com/users/duanbo1983/orgs","repos_url":"https://api.github.com/users/duanbo1983/repos","events_url":"https://api.github.com/users/duanbo1983/events{/privacy}","received_events_url":"https://api.github.com/users/duanbo1983/received_events","type":"User","site_admin":false},"body":"When subscribing to a completed ScopeProvider, callMainSubscribeIfNecessary() might be called here before the main source is subscribed, which triggers the DoubleSubscriptoinsException.","created_at":"2017-11-16T00:20:42Z","updated_at":"2017-11-16T00:20:42Z","html_url":"https://github.com/uber/AutoDispose/pull/135#discussion_r151291506","pull_request_url":"https://api.github.com/repos/uber/AutoDispose/pulls/135","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/uber/AutoDispose/pulls/comments/151291506"},"html":{"href":"https://github.com/uber/AutoDispose/pull/135#discussion_r151291506"},"pull_request":{"href":"https://api.github.com/repos/uber/AutoDispose/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/uber/AutoDispose/pulls/135","id":152914882,"html_url":"https://github.com/uber/AutoDispose/pull/135","diff_url":"https://github.com/uber/AutoDispose/pull/135.diff","patch_url":"https://github.com/uber/AutoDispose/pull/135.patch","issue_url":"https://api.github.com/repos/uber/AutoDispose/issues/135","number":135,"state":"open","locked":false,"title":"Fix a racing condition when subscribing a completed ScopeProvider.","user":{"login":"duanbo1983","id":631469,"avatar_url":"https://avatars0.githubusercontent.com/u/631469?v=4","gravatar_id":"","url":"https://api.github.com/users/duanbo1983","html_url":"https://github.com/duanbo1983","followers_url":"https://api.github.com/users/duanbo1983/followers","following_url":"https://api.github.com/users/duanbo1983/following{/other_user}","gists_url":"https://api.github.com/users/duanbo1983/gists{/gist_id}","starred_url":"https://api.github.com/users/duanbo1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duanbo1983/subscriptions","organizations_url":"https://api.github.com/users/duanbo1983/orgs","repos_url":"https://api.github.com/users/duanbo1983/repos","events_url":"https://api.github.com/users/duanbo1983/events{/privacy}","received_events_url":"https://api.github.com/users/duanbo1983/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to AutoDispose. Before pressing the \"Create Pull Request\" button, please consider the following points.\r\nFeel free to remove any irrelevant parts that you know are not related to the issue.\r\nAny HTML comment like this will be stripped when rendering markdown, no need to delete them.\r\n-->\r\n\r\n<!-- Please give a description about what and why you are contributing, even if it's trivial. -->\r\n**Description**:\r\n\r\n<!-- Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those. -->\r\n**Related issue(s)**:\r\n\r\n<!-- Please include a reasonable set of unit tests if you contribute new code or change an existing one. -->\r\n","created_at":"2017-11-15T23:39:08Z","updated_at":"2017-11-16T00:20:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b2e5e2cc6051e9fc476bd85acd34251dbed213c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/AutoDispose/pulls/135/commits","review_comments_url":"https://api.github.com/repos/uber/AutoDispose/pulls/135/comments","review_comment_url":"https://api.github.com/repos/uber/AutoDispose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/AutoDispose/issues/135/comments","statuses_url":"https://api.github.com/repos/uber/AutoDispose/statuses/eae39d04c0b74c452a5646920d3638c0921b0351","head":{"label":"duanbo1983:bo_racing_condition","ref":"bo_racing_condition","sha":"eae39d04c0b74c452a5646920d3638c0921b0351","user":{"login":"duanbo1983","id":631469,"avatar_url":"https://avatars0.githubusercontent.com/u/631469?v=4","gravatar_id":"","url":"https://api.github.com/users/duanbo1983","html_url":"https://github.com/duanbo1983","followers_url":"https://api.github.com/users/duanbo1983/followers","following_url":"https://api.github.com/users/duanbo1983/following{/other_user}","gists_url":"https://api.github.com/users/duanbo1983/gists{/gist_id}","starred_url":"https://api.github.com/users/duanbo1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duanbo1983/subscriptions","organizations_url":"https://api.github.com/users/duanbo1983/orgs","repos_url":"https://api.github.com/users/duanbo1983/repos","events_url":"https://api.github.com/users/duanbo1983/events{/privacy}","received_events_url":"https://api.github.com/users/duanbo1983/received_events","type":"User","site_admin":false},"repo":{"id":110899120,"name":"AutoDispose","full_name":"duanbo1983/AutoDispose","owner":{"login":"duanbo1983","id":631469,"avatar_url":"https://avatars0.githubusercontent.com/u/631469?v=4","gravatar_id":"","url":"https://api.github.com/users/duanbo1983","html_url":"https://github.com/duanbo1983","followers_url":"https://api.github.com/users/duanbo1983/followers","following_url":"https://api.github.com/users/duanbo1983/following{/other_user}","gists_url":"https://api.github.com/users/duanbo1983/gists{/gist_id}","starred_url":"https://api.github.com/users/duanbo1983/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duanbo1983/subscriptions","organizations_url":"https://api.github.com/users/duanbo1983/orgs","repos_url":"https://api.github.com/users/duanbo1983/repos","events_url":"https://api.github.com/users/duanbo1983/events{/privacy}","received_events_url":"https://api.github.com/users/duanbo1983/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duanbo1983/AutoDispose","description":"Automatic binding+disposal of RxJava 2 streams.","fork":true,"url":"https://api.github.com/repos/duanbo1983/AutoDispose","forks_url":"https://api.github.com/repos/duanbo1983/AutoDispose/forks","keys_url":"https://api.github.com/repos/duanbo1983/AutoDispose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duanbo1983/AutoDispose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duanbo1983/AutoDispose/teams","hooks_url":"https://api.github.com/repos/duanbo1983/AutoDispose/hooks","issue_events_url":"https://api.github.com/repos/duanbo1983/AutoDispose/issues/events{/number}","events_url":"https://api.github.com/repos/duanbo1983/AutoDispose/events","assignees_url":"https://api.github.com/repos/duanbo1983/AutoDispose/assignees{/user}","branches_url":"https://api.github.com/repos/duanbo1983/AutoDispose/branches{/branch}","tags_url":"https://api.github.com/repos/duanbo1983/AutoDispose/tags","blobs_url":"https://api.github.com/repos/duanbo1983/AutoDispose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duanbo1983/AutoDispose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duanbo1983/AutoDispose/git/refs{/sha}","trees_url":"https://api.github.com/repos/duanbo1983/AutoDispose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duanbo1983/AutoDispose/statuses/{sha}","languages_url":"https://api.github.com/repos/duanbo1983/AutoDispose/languages","stargazers_url":"https://api.github.com/repos/duanbo1983/AutoDispose/stargazers","contributors_url":"https://api.github.com/repos/duanbo1983/AutoDispose/contributors","subscribers_url":"https://api.github.com/repos/duanbo1983/AutoDispose/subscribers","subscription_url":"https://api.github.com/repos/duanbo1983/AutoDispose/subscription","commits_url":"https://api.github.com/repos/duanbo1983/AutoDispose/commits{/sha}","git_commits_url":"https://api.github.com/repos/duanbo1983/AutoDispose/git/commits{/sha}","comments_url":"https://api.github.com/repos/duanbo1983/AutoDispose/comments{/number}","issue_comment_url":"https://api.github.com/repos/duanbo1983/AutoDispose/issues/comments{/number}","contents_url":"https://api.github.com/repos/duanbo1983/AutoDispose/contents/{+path}","compare_url":"https://api.github.com/repos/duanbo1983/AutoDispose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duanbo1983/AutoDispose/merges","archive_url":"https://api.github.com/repos/duanbo1983/AutoDispose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duanbo1983/AutoDispose/downloads","issues_url":"https://api.github.com/repos/duanbo1983/AutoDispose/issues{/number}","pulls_url":"https://api.github.com/repos/duanbo1983/AutoDispose/pulls{/number}","milestones_url":"https://api.github.com/repos/duanbo1983/AutoDispose/milestones{/number}","notifications_url":"https://api.github.com/repos/duanbo1983/AutoDispose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duanbo1983/AutoDispose/labels{/name}","releases_url":"https://api.github.com/repos/duanbo1983/AutoDispose/releases{/id}","deployments_url":"https://api.github.com/repos/duanbo1983/AutoDispose/deployments","created_at":"2017-11-15T23:34:04Z","updated_at":"2017-11-15T23:34:06Z","pushed_at":"2017-11-15T23:36:18Z","git_url":"git://github.com/duanbo1983/AutoDispose.git","ssh_url":"git@github.com:duanbo1983/AutoDispose.git","clone_url":"https://github.com/duanbo1983/AutoDispose.git","svn_url":"https://github.com/duanbo1983/AutoDispose","homepage":"https://uber.github.io/AutoDispose/","size":532,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"2ec7f8e7b62c47c34f3604f545234447a43ae8cf","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":77168103,"name":"AutoDispose","full_name":"uber/AutoDispose","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/AutoDispose","description":"Automatic binding+disposal of RxJava 2 streams.","fork":false,"url":"https://api.github.com/repos/uber/AutoDispose","forks_url":"https://api.github.com/repos/uber/AutoDispose/forks","keys_url":"https://api.github.com/repos/uber/AutoDispose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/AutoDispose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/AutoDispose/teams","hooks_url":"https://api.github.com/repos/uber/AutoDispose/hooks","issue_events_url":"https://api.github.com/repos/uber/AutoDispose/issues/events{/number}","events_url":"https://api.github.com/repos/uber/AutoDispose/events","assignees_url":"https://api.github.com/repos/uber/AutoDispose/assignees{/user}","branches_url":"https://api.github.com/repos/uber/AutoDispose/branches{/branch}","tags_url":"https://api.github.com/repos/uber/AutoDispose/tags","blobs_url":"https://api.github.com/repos/uber/AutoDispose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/AutoDispose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/AutoDispose/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/AutoDispose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/AutoDispose/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/AutoDispose/languages","stargazers_url":"https://api.github.com/repos/uber/AutoDispose/stargazers","contributors_url":"https://api.github.com/repos/uber/AutoDispose/contributors","subscribers_url":"https://api.github.com/repos/uber/AutoDispose/subscribers","subscription_url":"https://api.github.com/repos/uber/AutoDispose/subscription","commits_url":"https://api.github.com/repos/uber/AutoDispose/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/AutoDispose/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/AutoDispose/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/AutoDispose/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/AutoDispose/contents/{+path}","compare_url":"https://api.github.com/repos/uber/AutoDispose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/AutoDispose/merges","archive_url":"https://api.github.com/repos/uber/AutoDispose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/AutoDispose/downloads","issues_url":"https://api.github.com/repos/uber/AutoDispose/issues{/number}","pulls_url":"https://api.github.com/repos/uber/AutoDispose/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/AutoDispose/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/AutoDispose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/AutoDispose/labels{/name}","releases_url":"https://api.github.com/repos/uber/AutoDispose/releases{/id}","deployments_url":"https://api.github.com/repos/uber/AutoDispose/deployments","created_at":"2016-12-22T18:46:11Z","updated_at":"2017-11-16T00:00:52Z","pushed_at":"2017-11-15T23:39:09Z","git_url":"git://github.com/uber/AutoDispose.git","ssh_url":"git@github.com:uber/AutoDispose.git","clone_url":"https://github.com/uber/AutoDispose.git","svn_url":"https://github.com/uber/AutoDispose","homepage":"https://uber.github.io/AutoDispose/","size":532,"stargazers_count":685,"watchers_count":685,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":31,"open_issues":6,"watchers":685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/AutoDispose/pulls/135"},"html":{"href":"https://github.com/uber/AutoDispose/pull/135"},"issue":{"href":"https://api.github.com/repos/uber/AutoDispose/issues/135"},"comments":{"href":"https://api.github.com/repos/uber/AutoDispose/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/AutoDispose/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/AutoDispose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/AutoDispose/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/uber/AutoDispose/statuses/eae39d04c0b74c452a5646920d3638c0921b0351"}},"author_association":"NONE"}}
{"actor":{"display_login":"duanbo1983"}}