{"action":"created","issue":{"url":"https://api.github.com/repos/qbolec/Breadcrumbs/issues/3","repository_url":"https://api.github.com/repos/qbolec/Breadcrumbs","labels_url":"https://api.github.com/repos/qbolec/Breadcrumbs/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/qbolec/Breadcrumbs/issues/3/comments","events_url":"https://api.github.com/repos/qbolec/Breadcrumbs/issues/3/events","html_url":"https://github.com/qbolec/Breadcrumbs/pull/3","id":248108631,"number":3,"title":"Some features and suggestions","user":{"login":"braver","id":2543659,"avatar_url":"https://avatars1.githubusercontent.com/u/2543659?v=4","gravatar_id":"","url":"https://api.github.com/users/braver","html_url":"https://github.com/braver","followers_url":"https://api.github.com/users/braver/followers","following_url":"https://api.github.com/users/braver/following{/other_user}","gists_url":"https://api.github.com/users/braver/gists{/gist_id}","starred_url":"https://api.github.com/users/braver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braver/subscriptions","organizations_url":"https://api.github.com/users/braver/orgs","repos_url":"https://api.github.com/users/braver/repos","events_url":"https://api.github.com/users/braver/events{/privacy}","received_events_url":"https://api.github.com/users/braver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-08-04T20:25:22Z","updated_at":"2017-08-05T11:39:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/qbolec/Breadcrumbs/pulls/3","html_url":"https://github.com/qbolec/Breadcrumbs/pull/3","diff_url":"https://github.com/qbolec/Breadcrumbs/pull/3.diff","patch_url":"https://github.com/qbolec/Breadcrumbs/pull/3.patch"},"body":"I was looking for something like this and am super glad to find your plugin and not have to figure this all out myself. I would like to make some additions and changes, let me know if you're willing to perhaps pull this into your package.\r\n\r\n- a cleaner default separator `›`\r\n- the ability to strip stuff from each \"crumb\" with a regex\r\n- use `on_selection_modified_async`\r\n\r\nI already have quite some stuff in my statusbar, and need to deal with lengthy paths. So I would like to have the option to display the breadcrumbs inline using phantoms. Also to save on performance I would then disable updating the statusbar at all. It would be even better to not register anything on `on_selection_modified_async` if the statusbar shouldn't be updated, but I don't know how to make that work.\r\n\r\nThe breadcrumbs now always start with the separator because the regex also makes it possible to clip out some steps. For instance to only show anything that starts with `class` or `def`. And that would show up as  `› ›` which is also lame. I bet if I sleep on it I can improve on that, although it doesn't look that bad now.\r\n\r\nAnyway, let me know what you think or if you would like me to make some changes.\r\n\r\nEdit: the phantoms are too simple to fully address #1, but it’s a start. Correct highlighting seems impossible or at least highly impractical to me, but more could be done with this than just dumping a string into it. E.g. it could be a list."},"comment":{"url":"https://api.github.com/repos/qbolec/Breadcrumbs/issues/comments/320438898","html_url":"https://github.com/qbolec/Breadcrumbs/pull/3#issuecomment-320438898","issue_url":"https://api.github.com/repos/qbolec/Breadcrumbs/issues/3","id":320438898,"user":{"login":"braver","id":2543659,"avatar_url":"https://avatars1.githubusercontent.com/u/2543659?v=4","gravatar_id":"","url":"https://api.github.com/users/braver","html_url":"https://github.com/braver","followers_url":"https://api.github.com/users/braver/followers","following_url":"https://api.github.com/users/braver/following{/other_user}","gists_url":"https://api.github.com/users/braver/gists{/gist_id}","starred_url":"https://api.github.com/users/braver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/braver/subscriptions","organizations_url":"https://api.github.com/users/braver/orgs","repos_url":"https://api.github.com/users/braver/repos","events_url":"https://api.github.com/users/braver/events{/privacy}","received_events_url":"https://api.github.com/users/braver/received_events","type":"User","site_admin":false},"created_at":"2017-08-05T11:39:03Z","updated_at":"2017-08-05T11:39:03Z","body":"Awesome feedback thanks. Don't worry about the amount of feedback. I love collaborating like this and just went through a similar review on a package I maintain. Also, I don't really have that much experience with Sublime plugins or python, so I'm really looking to learn from this. "}}
{"actor":{"display_login":"braver"}}