{"push_id":1866176226,"size":1,"distinct_size":1,"ref":"refs/heads/net","head":"2aa536c1672a6dcc3d33937b876af9e09adb9dd1","before":"254e9cc5b878c4ea6f0f57459ed492d33be8f9c8","commits":[{"sha":"2aa536c1672a6dcc3d33937b876af9e09adb9dd1","author":{"name":"Rolf Neugebauer","email":"ffdf051cdfbc7a9ef30286ab2597c372b43cc681@docker.com"},"message":"Use netnscfg to configure the network interface\n\nAs pointed out in the previous commit, dealing with network namespaces\nin Go is iffy, at best. This commit moves the network configuration\nover to use the new utility introduced by the previous commit.\n\nNote, this changes the timing of when the network is configured.\nPreviously, 'eth0' would be configured in the root network\nnamespace during 'CreateContainer()' and then later moved to\nthe runc container network namespace in 'ExecProcess()'. With the\nnew approach, the network interface is configured directly inside\n'ExecProcess()' and 'eth0' remains down until then.\n\nThis not only makes the code simpler, but also removes the rather\nbrittle code, which tried to gather the network configuration in the\nroot network namespace and then replay it inside the new container\nnamespace.\n\n/etc/resolv.conf also needed special attention as it is added to\nbaselayer and with the change of ordering of network config the /etc\nmust exist before creating the overlay rootfs.\n\nSigned-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>","distinct":true,"url":"https://api.github.com/repos/rn/opengcs/commits/2aa536c1672a6dcc3d33937b876af9e09adb9dd1"}]}
{"actor":{"display_login":"rn"}}