{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/979","repository_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards","labels_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/979/labels{/name}","comments_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/979/comments","events_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/979/events","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/979","id":236668230,"number":979,"title":"DeprecatedFunctions sniff: update minimum WP version","user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars2.githubusercontent.com/u/663378?v=3","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"labels":[{"id":202582556,"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/labels/Status:%20Review%20Ready","name":"Status: Review Ready","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/milestones/12","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/milestone/12","labels_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/milestones/12/labels","id":2364139,"number":12,"title":"0.12.0","description":"","creator":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars2.githubusercontent.com/u/663378?v=3","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":73,"state":"open","created_at":"2017-03-06T00:05:08Z","updated_at":"2017-06-20T12:30:42Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2017-06-17T15:56:12Z","updated_at":"2017-06-21T12:07:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/pulls/979","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/979","diff_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/979.diff","patch_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/979.patch"},"body":"The version number in this property is supposed to be 3 versions before the current WP release and what with WP 4.8 having been released, should now be updated.\r\n\r\nI'm not aware of any deprecated functions in WP 4.8, but have to admit that I haven't followed this very closely.\r\n\r\nAccording to the official changelog, there are none: https://codex.wordpress.org/Version_4.8\r\nAnd I can't seem to get a one-page diff view using trac: https://core.trac.wordpress.org/changeset?old_path=%2Ftrunk&old=40888&new_path=%2Fbranches%2F4.7&new=39524&sfp_email=&sfph_mail= (aside: would be great if there was a way to only get the diff of PHP files at that)\r\n\r\nDoes anyone know of a clever way to check for newly deprecated functions between releases ?"},"comment":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/comments/310058654","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/979#issuecomment-310058654","issue_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/979","id":310058654,"user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars2.githubusercontent.com/u/663378?v=3","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"created_at":"2017-06-21T12:07:43Z","updated_at":"2017-06-21T12:07:43Z","body":">    When a function has an alternative that isn't a function (like \"the Loop\", for start_wp()), WordPress doesn't specify that as the third parameter of the _deprecated_function() call. So in the sniff it will currently have a value, but the generator will not detect the alternative.\r\n\r\nThis should be fine I think, though we might want to verify those instances & annotate in the sniff with a comment that it's ok.\r\n\r\n>    There are some cases where the alternative function in the sniff is incorrect. For example, it should be wp_editor() for tinymce_include(), but is listed as wp_tiny_mce(). I haven't checked other cases to be sure that they are correct.\r\n\r\nI'm wondering if some might have a different alternative function mentioned in the `@deprecated` tag compared to the `_deprecated_function()` call. Or the alternative may have been deprecated itself ?\r\n\r\nMaybe @grappler who originally created this PR can shed some light on this ? There might be a good reason for the difference.\r\n\r\n>    In some cases the spacing for the alternative functions is different. get_the_author_meta( \\'description\\' ) in the sniff vs get_the_author_meta(\\'description\\') from the generator.\r\n\r\nI'll adjust that one - it had a different quote style from what was used in the WP code previously, so I already adjusted it, just hadn't noticed the spaces. Will also check & adjust others for this if there are more.\r\n\r\n> It also appears that not all deprecated functions call _deprecated_function(), so the generator currently doesn't pick them up. I'll see about updating it so that it will check for the @deprecated dockblock annotation as well.\r\n\r\nThat would be awesome!\r\n\r\nOn that note and for future consideration if we want to start sniffing deprecated hooks as well:\r\nI know for a fact that most deprecated hooks do have a `@deprecated` tag, but hardly any have a `_deprecated_hook()` call. A patch for this has been untouched for nearly a year, see https://core.trac.wordpress.org/ticket/10441"}}
{"actor":{"display_login":"jrfnl"}}