{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/1286","repository_url":"https://api.github.com/repos/puppetlabs/puppet-agent","labels_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/1286/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/1286/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/1286/events","html_url":"https://github.com/puppetlabs/puppet-agent/pull/1286","id":282883688,"number":1286,"title":"(PA-673) PA-ENVIRONMENT should default to blank","user":{"login":"jcoconnor","id":13116231,"avatar_url":"https://avatars3.githubusercontent.com/u/13116231?v=4","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-12-18T13:45:55Z","updated_at":"2017-12-19T00:38:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/1286","html_url":"https://github.com/puppetlabs/puppet-agent/pull/1286","diff_url":"https://github.com/puppetlabs/puppet-agent/pull/1286.diff","patch_url":"https://github.com/puppetlabs/puppet-agent/pull/1286.patch"},"body":"This was addressed originallin in PA-286 (in Puppet for the Win), but\r\nthis particular change didn't make it into the reworked Vanagon code.\r\nSo - ensure that if no ENVIRONMENT is set for the install then it should\r\nnot be set in puppet.conf, i.e. desired behaviour is:\r\n- On a fresh install with PUPPET_AGENT_ENVIRONMENT not specified,\r\n  puppet.conf does not have an environment key.\r\n- On a fresh install with PUPPET_AGENT_ENVIRONMENT=foo specified,\r\n  puppet.conf does have a key of environment=foo.\r\n- On an upgrade where puppet.conf has an environment key, the value\r\n  stays the same.\r\n- On an upgrade where puppet.conf does not have an environment key,\r\n  the key remains out of puppet.conf."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/comments/352602865","html_url":"https://github.com/puppetlabs/puppet-agent/pull/1286#issuecomment-352602865","issue_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/1286","id":352602865,"user":{"login":"Iristyle","id":394081,"avatar_url":"https://avatars0.githubusercontent.com/u/394081?v=4","gravatar_id":"","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"created_at":"2017-12-19T00:38:52Z","updated_at":"2017-12-19T00:38:52Z","author_association":"MEMBER","body":"Looks like this matches the original PR merged in https://github.com/puppetlabs/puppet_for_the_win/pull/142/files"}}
{"actor":{"display_login":"Iristyle"}}