{"action":"created","issue":{"url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1108","repository_url":"https://api.github.com/repos/pi-hole/pi-hole","labels_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1108/labels{/name}","comments_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1108/comments","events_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1108/events","html_url":"https://github.com/pi-hole/pi-hole/issues/1108","id":199358173,"number":1108,"title":"Query logs show wrong year","user":{"login":"abaumfalk","id":19736255,"avatar_url":"https://avatars.githubusercontent.com/u/19736255?v=3","gravatar_id":"","url":"https://api.github.com/users/abaumfalk","html_url":"https://github.com/abaumfalk","followers_url":"https://api.github.com/users/abaumfalk/followers","following_url":"https://api.github.com/users/abaumfalk/following{/other_user}","gists_url":"https://api.github.com/users/abaumfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/abaumfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abaumfalk/subscriptions","organizations_url":"https://api.github.com/users/abaumfalk/orgs","repos_url":"https://api.github.com/users/abaumfalk/repos","events_url":"https://api.github.com/users/abaumfalk/events{/privacy}","received_events_url":"https://api.github.com/users/abaumfalk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-07T12:11:44Z","updated_at":"2017-01-15T09:20:53Z","closed_at":null,"body":"**In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:**\r\n\r\n- [x] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md).\r\n- [x] The issue I am reporting can be *replicated*\r\n- [x] The issue I'm reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/pi-hole/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/pi-hole/issues)).\r\n\r\n**How familiar are you with the codebase?:**\r\n\r\n_1_\r\n\r\n---\r\n**[BUG]:**\r\nQuery log date column shows all entries using current year instead of actual year of the entry.\r\n\r\n**[BUG] Expected Behaviour:**\r\nThe query log page translates the content of /var/log/pihole.log into a webpage. The timestamp is expected to reflect the actual time of the query.\r\n\r\n**[BUG] Actual Behaviour:**\r\nThe actual year of the event seems not part of the log. The query log page seems to add the current year to all of the events. This might be wrong. \r\n\r\n**[BUG] Steps to reproduce:**\r\n1. add following line to /var/log/pihole.log, which might be generated on 31st of December 2016:\r\n--\r\nDec 31 21:17:08 dnsmasq[462]: query[A] 0.debian.pool.ntp.org from 127.0.0.1\r\n--\r\n2. check query log page; it will show an entry dated:\r\n2017-12-31T21:17:08\r\n\r\n-\r\n-\r\n-\r\n-\r\n\r\n**(Optional) Debug token generated by `pihole -d`:**\r\n\r\n`<token>`\r\n\r\n_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._\r\n"},"comment":{"url":"https://api.github.com/repos/pi-hole/pi-hole/issues/comments/272683423","html_url":"https://github.com/pi-hole/pi-hole/issues/1108#issuecomment-272683423","issue_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1108","id":272683423,"user":{"login":"abaumfalk","id":19736255,"avatar_url":"https://avatars.githubusercontent.com/u/19736255?v=3","gravatar_id":"","url":"https://api.github.com/users/abaumfalk","html_url":"https://github.com/abaumfalk","followers_url":"https://api.github.com/users/abaumfalk/followers","following_url":"https://api.github.com/users/abaumfalk/following{/other_user}","gists_url":"https://api.github.com/users/abaumfalk/gists{/gist_id}","starred_url":"https://api.github.com/users/abaumfalk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abaumfalk/subscriptions","organizations_url":"https://api.github.com/users/abaumfalk/orgs","repos_url":"https://api.github.com/users/abaumfalk/repos","events_url":"https://api.github.com/users/abaumfalk/events{/privacy}","received_events_url":"https://api.github.com/users/abaumfalk/received_events","type":"User","site_admin":false},"created_at":"2017-01-15T09:20:53Z","updated_at":"2017-01-15T09:20:53Z","body":"There was no logrotate for the pihole logfile active. I wonder why...\r\nAnyhow, wouldn't it be better to omit the year from the logview instead of assuming it? For sorting purposes one could simply enmuerate the logentries when reading them from the file so that the position in the file is preserved. This enumeration column could be presented to the user and he could use it for sorting.\r\n"}}
{"actor":{"display_login":"abaumfalk"}}