{"action":"created","comment":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments/101787365","pull_request_review_id":22528737,"id":101787365,"diff_hunk":"@@ -36,25 +51,35 @@ Peer.prototype.accept = function (peer) {\n \t\tthis.ip = peer.ip;\n \t}\n \n-\tthis.port = this.parseInt(peer.port, 0);\n+\tthis.port = self.parseInt(peer.port, 0);\n \n-\tif (this.ip) {\n-\t\tthis.string = (this.ip + ':' + this.port || 'unknown');\n-\t} else {\n-\t\tthis.string = 'unknown';\n+\tif (this.ip && this.port) {\n+\t\tthis.string = this.ip + ':' + this.port;","path":"logic/peer.js","position":57,"original_position":57,"commit_id":"f41df57cc7e25a802a526f39b8a7ae368e170085","original_commit_id":"f41df57cc7e25a802a526f39b8a7ae368e170085","user":{"login":"MaciejBaj","id":6909553,"avatar_url":"https://avatars.githubusercontent.com/u/6909553?v=3","gravatar_id":"","url":"https://api.github.com/users/MaciejBaj","html_url":"https://github.com/MaciejBaj","followers_url":"https://api.github.com/users/MaciejBaj/followers","following_url":"https://api.github.com/users/MaciejBaj/following{/other_user}","gists_url":"https://api.github.com/users/MaciejBaj/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciejBaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciejBaj/subscriptions","organizations_url":"https://api.github.com/users/MaciejBaj/orgs","repos_url":"https://api.github.com/users/MaciejBaj/repos","events_url":"https://api.github.com/users/MaciejBaj/events{/privacy}","received_events_url":"https://api.github.com/users/MaciejBaj/received_events","type":"User","site_admin":false},"body":"string? maybe address better?","created_at":"2017-02-17T16:04:16Z","updated_at":"2017-02-17T16:04:16Z","html_url":"https://github.com/LiskHQ/lisk/pull/441#discussion_r101787365","pull_request_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments/101787365"},"html":{"href":"https://github.com/LiskHQ/lisk/pull/441#discussion_r101787365"},"pull_request":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/441","id":106722895,"html_url":"https://github.com/LiskHQ/lisk/pull/441","diff_url":"https://github.com/LiskHQ/lisk/pull/441.diff","patch_url":"https://github.com/LiskHQ/lisk/pull/441.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk/issues/441","number":441,"state":"open","locked":false,"title":"Rewrite peers module - Closes #409","user":{"login":"4miners","id":22824146,"avatar_url":"https://avatars.githubusercontent.com/u/22824146?v=3","gravatar_id":"","url":"https://api.github.com/users/4miners","html_url":"https://github.com/4miners","followers_url":"https://api.github.com/users/4miners/followers","following_url":"https://api.github.com/users/4miners/following{/other_user}","gists_url":"https://api.github.com/users/4miners/gists{/gist_id}","starred_url":"https://api.github.com/users/4miners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4miners/subscriptions","organizations_url":"https://api.github.com/users/4miners/orgs","repos_url":"https://api.github.com/users/4miners/repos","events_url":"https://api.github.com/users/4miners/events{/privacy}","received_events_url":"https://api.github.com/users/4miners/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-17T12:20:48Z","updated_at":"2017-02-17T16:04:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"893893f61dbb382a9546d752d6d47511da7a9a9b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/441/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/441/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/issues/441/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/f41df57cc7e25a802a526f39b8a7ae368e170085","head":{"label":"4miners:409_rewrite-peers-module","ref":"409_rewrite-peers-module","sha":"f41df57cc7e25a802a526f39b8a7ae368e170085","user":{"login":"4miners","id":22824146,"avatar_url":"https://avatars.githubusercontent.com/u/22824146?v=3","gravatar_id":"","url":"https://api.github.com/users/4miners","html_url":"https://github.com/4miners","followers_url":"https://api.github.com/users/4miners/followers","following_url":"https://api.github.com/users/4miners/following{/other_user}","gists_url":"https://api.github.com/users/4miners/gists{/gist_id}","starred_url":"https://api.github.com/users/4miners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4miners/subscriptions","organizations_url":"https://api.github.com/users/4miners/orgs","repos_url":"https://api.github.com/users/4miners/repos","events_url":"https://api.github.com/users/4miners/events{/privacy}","received_events_url":"https://api.github.com/users/4miners/received_events","type":"User","site_admin":false},"repo":{"id":74883233,"name":"lisk","full_name":"4miners/lisk","owner":{"login":"4miners","id":22824146,"avatar_url":"https://avatars.githubusercontent.com/u/22824146?v=3","gravatar_id":"","url":"https://api.github.com/users/4miners","html_url":"https://github.com/4miners","followers_url":"https://api.github.com/users/4miners/followers","following_url":"https://api.github.com/users/4miners/following{/other_user}","gists_url":"https://api.github.com/users/4miners/gists{/gist_id}","starred_url":"https://api.github.com/users/4miners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4miners/subscriptions","organizations_url":"https://api.github.com/users/4miners/orgs","repos_url":"https://api.github.com/users/4miners/repos","events_url":"https://api.github.com/users/4miners/events{/privacy}","received_events_url":"https://api.github.com/users/4miners/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/4miners/lisk","description":"Lisk blockchain application platform and crypto-currency","fork":true,"url":"https://api.github.com/repos/4miners/lisk","forks_url":"https://api.github.com/repos/4miners/lisk/forks","keys_url":"https://api.github.com/repos/4miners/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4miners/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4miners/lisk/teams","hooks_url":"https://api.github.com/repos/4miners/lisk/hooks","issue_events_url":"https://api.github.com/repos/4miners/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/4miners/lisk/events","assignees_url":"https://api.github.com/repos/4miners/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/4miners/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/4miners/lisk/tags","blobs_url":"https://api.github.com/repos/4miners/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4miners/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4miners/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/4miners/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4miners/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/4miners/lisk/languages","stargazers_url":"https://api.github.com/repos/4miners/lisk/stargazers","contributors_url":"https://api.github.com/repos/4miners/lisk/contributors","subscribers_url":"https://api.github.com/repos/4miners/lisk/subscribers","subscription_url":"https://api.github.com/repos/4miners/lisk/subscription","commits_url":"https://api.github.com/repos/4miners/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/4miners/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/4miners/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/4miners/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/4miners/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/4miners/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4miners/lisk/merges","archive_url":"https://api.github.com/repos/4miners/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4miners/lisk/downloads","issues_url":"https://api.github.com/repos/4miners/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/4miners/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/4miners/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/4miners/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4miners/lisk/labels{/name}","releases_url":"https://api.github.com/repos/4miners/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/4miners/lisk/deployments","created_at":"2016-11-27T11:23:58Z","updated_at":"2016-11-27T11:24:00Z","pushed_at":"2017-02-17T12:17:47Z","git_url":"git://github.com/4miners/lisk.git","ssh_url":"git@github.com:4miners/lisk.git","clone_url":"https://github.com/4miners/lisk.git","svn_url":"https://github.com/4miners/lisk","homepage":"https://lisk.io/","size":3696,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"LiskHQ:409_rewrite-peers-module","ref":"409_rewrite-peers-module","sha":"949aff6532df4d9ba0048230e0f843336a8d94b3","user":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars.githubusercontent.com/u/16600915?v=3","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"name":"lisk","full_name":"LiskHQ/lisk","owner":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars.githubusercontent.com/u/16600915?v=3","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiskHQ/lisk","description":"Lisk blockchain application platform and crypto-currency","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk","forks_url":"https://api.github.com/repos/LiskHQ/lisk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2017-02-17T07:53:23Z","pushed_at":"2017-02-17T12:29:31Z","git_url":"git://github.com/LiskHQ/lisk.git","ssh_url":"git@github.com:LiskHQ/lisk.git","clone_url":"https://github.com/LiskHQ/lisk.git","svn_url":"https://github.com/LiskHQ/lisk","homepage":"https://lisk.io/","size":3721,"stargazers_count":164,"watchers_count":164,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":67,"forks":67,"open_issues":67,"watchers":164,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/441"},"html":{"href":"https://github.com/LiskHQ/lisk/pull/441"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/441"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk/statuses/f41df57cc7e25a802a526f39b8a7ae368e170085"}}}}
{"actor":{"display_login":"MaciejBaj"}}