{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/1893","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/1893/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/1893/comments","events_url":"https://api.github.com/repos/istio/istio/issues/1893/events","html_url":"https://github.com/istio/istio/pull/1893","id":277503729,"number":1893,"title":"Stop using span pools for Mixer tracing.","user":{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"labels":[{"id":737751956,"url":"https://api.github.com/repos/istio/istio/labels/mixer","name":"mixer","color":"08bbdb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-28T19:11:29Z","updated_at":"2017-11-28T19:11:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/1893","html_url":"https://github.com/istio/istio/pull/1893","diff_url":"https://github.com/istio/istio/pull/1893.diff","patch_url":"https://github.com/istio/istio/pull/1893.patch"},"body":"**What this PR does / why we need it**:\n\nTurns span pooling off. Observing race conditions in post-submits related to spans. This will eliminate a potential source of those race conditions.\n\nNote: I have not been able to locally repro the span issues, but based on Mixer architecture and warnings surrounding `PoolSpans`, I believe this \nto be a likely source of the race.\n\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\n\n**Special notes for your reviewer**:\n\n**Release note**:\n<!--  Steps to write your release note:\n1. Use the release-note-* labels to set the release note state (if you have access)\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\n-->\n```release-note\n```"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/347631444","html_url":"https://github.com/istio/istio/pull/1893#issuecomment-347631444","issue_url":"https://api.github.com/repos/istio/istio/issues/1893","id":347631444,"user":{"login":"istio-testing","id":25311884,"avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2017-11-28T19:11:30Z","updated_at":"2017-11-28T19:11:30Z","author_association":"COLLABORATOR","body":"@douglas-reid: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.\n\n<details>\n\nOne of the following labels is required \"release-note\", \"release-note-action-required\", or \"release-note-none\".\nPlease see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>"}}
{"actor":{"display_login":"istio-testing"}}