{"action":"created","comment":{"url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/comments/151665804","pull_request_review_id":77409955,"id":151665804,"diff_hunk":"@@ -98,41 +169,46 @@\n  *      console.log('Down channels');\n  *      down.map(function(channel) {\n  *             console.log('Index:', channel.channelIndex);\n+ *             console.log('Direction:', channel.direction);\n  *             console.log('Name:', channel.name);\n  *             console.log('Size:', channel.size);\n  *      });\n  *\n  *      console.log('Up channels');\n  *      up.map(function(channel) {\n  *             console.log('Index:', channel.channelIndex);\n+ *             console.log('Direction:', channel.direction);\n  *             console.log('Name:', channel.name);\n  *             console.log('Size:', channel.size);\n  *      });\n  * });\n  *\n  * @param {integer} serialNumber The serial number of the device to start RTT on\n- * @param {integer} startOptions A plain object containing options about how to start RTT\n+ * @param {StartOptions} startOptions A plain object containing options about how to start RTT\n  * @param {Function} callback A callback function to handle the async response.\n- *   It shall expect three parameters: ({@link module:pc-nrfjprog-js~Error|Error}, Array of {@link module:pc-nrfjprog-js~Version|ChannelInfo},\n- *   Array of {@link module:pc-nrfjprog-js~Version|ChannelInfo})\n+ *   It shall expect three parameters: ({@link pc-nrfjprog-js.module:RTT~Error|Error}, Array of {@link pc-nrfjprog-js.module:RTT~ChannelInfo|ChannelInfo},\n+ *   Array of {@link pc-nrfjprog-js.module:RTT~ChannelInfo|ChannelInfo})\n  */\n export function start(serialnumber, startoptions, callback) {}\n \n /**\n- * Async function to stop RTT\n+ * Async function to stop RTT.\n  *\n  * @example\n  * RTT.stop(function(err){\n  *     if (err) console.error('Stopping RTT failed');\n  * });\n  *\n  * @param {Function} callback A callback function to handle the async response.\n- *   It shall expect one parameter: ({@link module:pc-nrfjprog-js~Error|Error})\n+ *   It shall expect one parameter: ({@link pc-nrfjprog-js.module:RTT~Error|Error})\n  */\n export function stop(callback) {}\n \n /**\n- * Async function to read RTT contents on a device.\n+ * Async function to read RTT contents from a up channel on the device. You read on the up channel specified by","path":"doc/rtt.js","position":null,"original_position":171,"commit_id":"9e643e7b9ac21fc393ac4d45b1274a608e9c8145","original_commit_id":"9e643e7b9ac21fc393ac4d45b1274a608e9c8145","user":{"login":"bihanssen","id":12543955,"avatar_url":"https://avatars1.githubusercontent.com/u/12543955?v=4","gravatar_id":"","url":"https://api.github.com/users/bihanssen","html_url":"https://github.com/bihanssen","followers_url":"https://api.github.com/users/bihanssen/followers","following_url":"https://api.github.com/users/bihanssen/following{/other_user}","gists_url":"https://api.github.com/users/bihanssen/gists{/gist_id}","starred_url":"https://api.github.com/users/bihanssen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bihanssen/subscriptions","organizations_url":"https://api.github.com/users/bihanssen/orgs","repos_url":"https://api.github.com/users/bihanssen/repos","events_url":"https://api.github.com/users/bihanssen/events{/privacy}","received_events_url":"https://api.github.com/users/bihanssen/received_events","type":"User","site_admin":false},"body":"s/ a / an /","created_at":"2017-11-17T11:41:11Z","updated_at":"2017-11-17T11:41:11Z","html_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js/pull/22#discussion_r151665804","pull_request_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/comments/151665804"},"html":{"href":"https://github.com/NordicSemiconductor/pc-nrfjprog-js/pull/22#discussion_r151665804"},"pull_request":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/22","id":153042932,"html_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js/pull/22","diff_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js/pull/22.diff","patch_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js/pull/22.patch","issue_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues/22","number":22,"state":"open","locked":false,"title":"Doc/rtt","user":{"login":"CoqRogue","id":5270291,"avatar_url":"https://avatars0.githubusercontent.com/u/5270291?v=4","gravatar_id":"","url":"https://api.github.com/users/CoqRogue","html_url":"https://github.com/CoqRogue","followers_url":"https://api.github.com/users/CoqRogue/followers","following_url":"https://api.github.com/users/CoqRogue/following{/other_user}","gists_url":"https://api.github.com/users/CoqRogue/gists{/gist_id}","starred_url":"https://api.github.com/users/CoqRogue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoqRogue/subscriptions","organizations_url":"https://api.github.com/users/CoqRogue/orgs","repos_url":"https://api.github.com/users/CoqRogue/repos","events_url":"https://api.github.com/users/CoqRogue/events{/privacy}","received_events_url":"https://api.github.com/users/CoqRogue/received_events","type":"User","site_admin":false},"body":"Updated documentation with RTT documentation.","created_at":"2017-11-16T13:39:06Z","updated_at":"2017-11-17T11:41:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7751ad335adf72d36a034a79fca7511237af615","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/22/commits","review_comments_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/22/comments","review_comment_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues/22/comments","statuses_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/statuses/9e643e7b9ac21fc393ac4d45b1274a608e9c8145","head":{"label":"NordicSemiconductor:doc/rtt","ref":"doc/rtt","sha":"9e643e7b9ac21fc393ac4d45b1274a608e9c8145","user":{"login":"NordicSemiconductor","id":33217104,"avatar_url":"https://avatars2.githubusercontent.com/u/33217104?v=4","gravatar_id":"","url":"https://api.github.com/users/NordicSemiconductor","html_url":"https://github.com/NordicSemiconductor","followers_url":"https://api.github.com/users/NordicSemiconductor/followers","following_url":"https://api.github.com/users/NordicSemiconductor/following{/other_user}","gists_url":"https://api.github.com/users/NordicSemiconductor/gists{/gist_id}","starred_url":"https://api.github.com/users/NordicSemiconductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NordicSemiconductor/subscriptions","organizations_url":"https://api.github.com/users/NordicSemiconductor/orgs","repos_url":"https://api.github.com/users/NordicSemiconductor/repos","events_url":"https://api.github.com/users/NordicSemiconductor/events{/privacy}","received_events_url":"https://api.github.com/users/NordicSemiconductor/received_events","type":"Organization","site_admin":false},"repo":{"id":60160809,"name":"pc-nrfjprog-js","full_name":"NordicSemiconductor/pc-nrfjprog-js","owner":{"login":"NordicSemiconductor","id":33217104,"avatar_url":"https://avatars2.githubusercontent.com/u/33217104?v=4","gravatar_id":"","url":"https://api.github.com/users/NordicSemiconductor","html_url":"https://github.com/NordicSemiconductor","followers_url":"https://api.github.com/users/NordicSemiconductor/followers","following_url":"https://api.github.com/users/NordicSemiconductor/following{/other_user}","gists_url":"https://api.github.com/users/NordicSemiconductor/gists{/gist_id}","starred_url":"https://api.github.com/users/NordicSemiconductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NordicSemiconductor/subscriptions","organizations_url":"https://api.github.com/users/NordicSemiconductor/orgs","repos_url":"https://api.github.com/users/NordicSemiconductor/repos","events_url":"https://api.github.com/users/NordicSemiconductor/events{/privacy}","received_events_url":"https://api.github.com/users/NordicSemiconductor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js","description":"Node.js library that exposes the functionality of the nRF5x Command-Line-Tools. API docs: http://nordicsemiconductor.github.io/pc-nrfjprog-js/","fork":false,"url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js","forks_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/forks","keys_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/teams","hooks_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/hooks","issue_events_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues/events{/number}","events_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/events","assignees_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/assignees{/user}","branches_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/branches{/branch}","tags_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/tags","blobs_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/statuses/{sha}","languages_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/languages","stargazers_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/stargazers","contributors_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/contributors","subscribers_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/subscribers","subscription_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/subscription","commits_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/contents/{+path}","compare_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/merges","archive_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/downloads","issues_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues{/number}","pulls_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls{/number}","milestones_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/milestones{/number}","notifications_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/labels{/name}","releases_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/releases{/id}","deployments_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/deployments","created_at":"2016-06-01T08:50:25Z","updated_at":"2017-11-01T18:01:17Z","pushed_at":"2017-11-17T10:19:32Z","git_url":"git://github.com/NordicSemiconductor/pc-nrfjprog-js.git","ssh_url":"git@github.com:NordicSemiconductor/pc-nrfjprog-js.git","clone_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js.git","svn_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js","homepage":"","size":66485,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"NordicSemiconductor:master","ref":"master","sha":"f9fd70c1e4e97369d6c312a9723879babef298fa","user":{"login":"NordicSemiconductor","id":33217104,"avatar_url":"https://avatars2.githubusercontent.com/u/33217104?v=4","gravatar_id":"","url":"https://api.github.com/users/NordicSemiconductor","html_url":"https://github.com/NordicSemiconductor","followers_url":"https://api.github.com/users/NordicSemiconductor/followers","following_url":"https://api.github.com/users/NordicSemiconductor/following{/other_user}","gists_url":"https://api.github.com/users/NordicSemiconductor/gists{/gist_id}","starred_url":"https://api.github.com/users/NordicSemiconductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NordicSemiconductor/subscriptions","organizations_url":"https://api.github.com/users/NordicSemiconductor/orgs","repos_url":"https://api.github.com/users/NordicSemiconductor/repos","events_url":"https://api.github.com/users/NordicSemiconductor/events{/privacy}","received_events_url":"https://api.github.com/users/NordicSemiconductor/received_events","type":"Organization","site_admin":false},"repo":{"id":60160809,"name":"pc-nrfjprog-js","full_name":"NordicSemiconductor/pc-nrfjprog-js","owner":{"login":"NordicSemiconductor","id":33217104,"avatar_url":"https://avatars2.githubusercontent.com/u/33217104?v=4","gravatar_id":"","url":"https://api.github.com/users/NordicSemiconductor","html_url":"https://github.com/NordicSemiconductor","followers_url":"https://api.github.com/users/NordicSemiconductor/followers","following_url":"https://api.github.com/users/NordicSemiconductor/following{/other_user}","gists_url":"https://api.github.com/users/NordicSemiconductor/gists{/gist_id}","starred_url":"https://api.github.com/users/NordicSemiconductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NordicSemiconductor/subscriptions","organizations_url":"https://api.github.com/users/NordicSemiconductor/orgs","repos_url":"https://api.github.com/users/NordicSemiconductor/repos","events_url":"https://api.github.com/users/NordicSemiconductor/events{/privacy}","received_events_url":"https://api.github.com/users/NordicSemiconductor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js","description":"Node.js library that exposes the functionality of the nRF5x Command-Line-Tools. API docs: http://nordicsemiconductor.github.io/pc-nrfjprog-js/","fork":false,"url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js","forks_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/forks","keys_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/teams","hooks_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/hooks","issue_events_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues/events{/number}","events_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/events","assignees_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/assignees{/user}","branches_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/branches{/branch}","tags_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/tags","blobs_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/statuses/{sha}","languages_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/languages","stargazers_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/stargazers","contributors_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/contributors","subscribers_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/subscribers","subscription_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/subscription","commits_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/contents/{+path}","compare_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/merges","archive_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/downloads","issues_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues{/number}","pulls_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls{/number}","milestones_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/milestones{/number}","notifications_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/labels{/name}","releases_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/releases{/id}","deployments_url":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/deployments","created_at":"2016-06-01T08:50:25Z","updated_at":"2017-11-01T18:01:17Z","pushed_at":"2017-11-17T10:19:32Z","git_url":"git://github.com/NordicSemiconductor/pc-nrfjprog-js.git","ssh_url":"git@github.com:NordicSemiconductor/pc-nrfjprog-js.git","clone_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js.git","svn_url":"https://github.com/NordicSemiconductor/pc-nrfjprog-js","homepage":"","size":66485,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/22"},"html":{"href":"https://github.com/NordicSemiconductor/pc-nrfjprog-js/pull/22"},"issue":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues/22"},"comments":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/NordicSemiconductor/pc-nrfjprog-js/statuses/9e643e7b9ac21fc393ac4d45b1274a608e9c8145"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bihanssen"}}