{"action":"created","issue":{"url":"https://api.github.com/repos/i3/i3/issues/2476","repository_url":"https://api.github.com/repos/i3/i3","labels_url":"https://api.github.com/repos/i3/i3/issues/2476/labels{/name}","comments_url":"https://api.github.com/repos/i3/i3/issues/2476/comments","events_url":"https://api.github.com/repos/i3/i3/issues/2476/events","html_url":"https://github.com/i3/i3/pull/2476","id":179096632,"number":2476,"title":"Add the option to toggle between stacked/tabbed layout","user":{"login":"BenoitAverty","id":17006335,"avatar_url":"https://avatars.githubusercontent.com/u/17006335?v=3","gravatar_id":"","url":"https://api.github.com/users/BenoitAverty","html_url":"https://github.com/BenoitAverty","followers_url":"https://api.github.com/users/BenoitAverty/followers","following_url":"https://api.github.com/users/BenoitAverty/following{/other_user}","gists_url":"https://api.github.com/users/BenoitAverty/gists{/gist_id}","starred_url":"https://api.github.com/users/BenoitAverty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenoitAverty/subscriptions","organizations_url":"https://api.github.com/users/BenoitAverty/orgs","repos_url":"https://api.github.com/users/BenoitAverty/repos","events_url":"https://api.github.com/users/BenoitAverty/events{/privacy}","received_events_url":"https://api.github.com/users/BenoitAverty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2016-09-25T17:09:01Z","updated_at":"2017-01-16T21:00:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/i3/i3/pulls/2476","html_url":"https://github.com/i3/i3/pull/2476","diff_url":"https://github.com/i3/i3/pull/2476.diff","patch_url":"https://github.com/i3/i3/pull/2476.patch"},"body":"This PR adds a parameter called \"stack_tab\" to the \"layout toggle\" command. This makes it possible to toggle between stacked and tabbed layouts, muck like the \"layout toggle split\" works for splitv/splith layouts.\n\nI don't like the name of the parameter very much, but I didn't have a better idea, so suggestions are welcome on that point :)\n\nA possible improvement would be to remember the last layout used between stacked and tabbed, so that running the layout toggle stack_tab command when the layout is neither of them sets the layout to the last one used (again, much like the layout toggle split works).\n\nI added test cases and documentation, but if I forgot anything feel free to tell me and I'll add what's missing.\n\nThanks for the work on i3, I'm falling in love with it :)\n"},"comment":{"url":"https://api.github.com/repos/i3/i3/issues/comments/272961015","html_url":"https://github.com/i3/i3/pull/2476#issuecomment-272961015","issue_url":"https://api.github.com/repos/i3/i3/issues/2476","id":272961015,"user":{"login":"Airblader","id":2392216,"avatar_url":"https://avatars.githubusercontent.com/u/2392216?v=3","gravatar_id":"","url":"https://api.github.com/users/Airblader","html_url":"https://github.com/Airblader","followers_url":"https://api.github.com/users/Airblader/followers","following_url":"https://api.github.com/users/Airblader/following{/other_user}","gists_url":"https://api.github.com/users/Airblader/gists{/gist_id}","starred_url":"https://api.github.com/users/Airblader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airblader/subscriptions","organizations_url":"https://api.github.com/users/Airblader/orgs","repos_url":"https://api.github.com/users/Airblader/repos","events_url":"https://api.github.com/users/Airblader/events{/privacy}","received_events_url":"https://api.github.com/users/Airblader/received_events","type":"User","site_admin":false},"created_at":"2017-01-16T21:00:36Z","updated_at":"2017-01-16T21:00:36Z","body":"> But having them commented out would still document the possible values and since there is no other purpose for it I think thats okay?\r\n\r\nAh, okay, I didn't think about partial matches either. No, in that case I'd prefer not to have commented-out code.\r\n\r\nI'm currently thinking that we should get the array-argument stuff in either with or prior to this PR. I don't like the manual parsing much. But that'll be up to @stapelberg; perhaps he'd be OK with it.\r\n\r\n> PS. I am not sure on how to contribute to this PR? Should I create an additional PR on @BenoitAverty's fork?\r\n\r\nYes, please create your own PR for this."}}
{"actor":{"display_login":"Airblader"}}