{"action":"created","issue":{"url":"https://api.github.com/repos/pvlib/pvlib-python/issues/340","repository_url":"https://api.github.com/repos/pvlib/pvlib-python","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/340/labels{/name}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/340/comments","events_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/340/events","html_url":"https://github.com/pvlib/pvlib-python/pull/340","id":236077752,"number":340,"title":"[WIP] Support ideal PV devices (#324)","user":{"login":"thunderfish24","id":1125363,"avatar_url":"https://avatars3.githubusercontent.com/u/1125363?v=4","gravatar_id":"","url":"https://api.github.com/users/thunderfish24","html_url":"https://github.com/thunderfish24","followers_url":"https://api.github.com/users/thunderfish24/followers","following_url":"https://api.github.com/users/thunderfish24/following{/other_user}","gists_url":"https://api.github.com/users/thunderfish24/gists{/gist_id}","starred_url":"https://api.github.com/users/thunderfish24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunderfish24/subscriptions","organizations_url":"https://api.github.com/users/thunderfish24/orgs","repos_url":"https://api.github.com/users/thunderfish24/repos","events_url":"https://api.github.com/users/thunderfish24/events{/privacy}","received_events_url":"https://api.github.com/users/thunderfish24/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-06-15T05:01:11Z","updated_at":"2017-07-27T04:33:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/340","html_url":"https://github.com/pvlib/pvlib-python/pull/340","diff_url":"https://github.com/pvlib/pvlib-python/pull/340.diff","patch_url":"https://github.com/pvlib/pvlib-python/pull/340.patch"},"body":"Here is an initial PR to get something concrete to discuss and move the conversation away from https://github.com/pvlib/pvlib-python/issues/324. I have added a pvsystem.i_from_v_alt() function for comparison purposes. Note that this algorithm intends to be robust as Rs->0^+ as well as at Rs=0. I consider accuracy as being more important than speed at this point.\r\n\r\nThere is one new unit test assertion that fails for a \"partially\" ideal device when Rsh=np.inf and Rs>0. I propose changing the shunt resistance parameter Rsh to a shunt conductance parameter Gsh=1./Rsh, which appears to be much better behaved numerically for ideal and near-ideal devices, i.e., Gsh is approaching/at zero. This should avoid a lot of logic bloat in considering yet another limiting case in pvsystem.i_from_v() where Rsh is so large that it is essentially infinite and the shunt term in the model must be dropped out. (Kudos to Paul Basore for recommending that I switch to Gsh in my early modeling days at NREL.)\r\n\r\n - [ ] Closes #324 \r\n - [ ] Tests added / passed\r\n - [ ] Passes ``git diff upstream/master -- pvlib | flake8 --diff``\r\n - [ ] Fully documented, including the appropriate `docs/sphinx/source/whatsnew` file for all changes and the `docs/sphinx/source/api.rst` for new API"},"comment":{"url":"https://api.github.com/repos/pvlib/pvlib-python/issues/comments/318255950","html_url":"https://github.com/pvlib/pvlib-python/pull/340#issuecomment-318255950","issue_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/340","id":318255950,"user":{"login":"thunderfish24","id":1125363,"avatar_url":"https://avatars3.githubusercontent.com/u/1125363?v=4","gravatar_id":"","url":"https://api.github.com/users/thunderfish24","html_url":"https://github.com/thunderfish24","followers_url":"https://api.github.com/users/thunderfish24/followers","following_url":"https://api.github.com/users/thunderfish24/following{/other_user}","gists_url":"https://api.github.com/users/thunderfish24/gists{/gist_id}","starred_url":"https://api.github.com/users/thunderfish24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thunderfish24/subscriptions","organizations_url":"https://api.github.com/users/thunderfish24/orgs","repos_url":"https://api.github.com/users/thunderfish24/repos","events_url":"https://api.github.com/users/thunderfish24/events{/privacy}","received_events_url":"https://api.github.com/users/thunderfish24/received_events","type":"User","site_admin":false},"created_at":"2017-07-27T04:33:40Z","updated_at":"2017-07-27T04:33:40Z","body":"@wholmgren \"Is return_meta_dict helpful for anything besides debugging? It seems to me that the few cases where someone would want that data could be better handled by manually computing it or using the debugger. Or did I miss something?\"\r\n\r\nThe `meta_dict` would probably be used largely for debugging, but I claim that reconstructing this info is not so easily done outside the function call. The default behavior is also the behavior the vast majority of users would want/expect."}}
{"actor":{"display_login":"thunderfish24"}}