{"action":"closed","issue":{"url":"https://api.github.com/repos/voidlinux/void-mklive/issues/99","repository_url":"https://api.github.com/repos/voidlinux/void-mklive","labels_url":"https://api.github.com/repos/voidlinux/void-mklive/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/voidlinux/void-mklive/issues/99/comments","events_url":"https://api.github.com/repos/voidlinux/void-mklive/issues/99/events","html_url":"https://github.com/voidlinux/void-mklive/issues/99","id":206969327,"number":99,"title":"mklive.sh script fails when there's a space in the name of one of its parent directory","user":{"login":"greygjhart","id":4245073,"avatar_url":"https://avatars3.githubusercontent.com/u/4245073?v=3","gravatar_id":"","url":"https://api.github.com/users/greygjhart","html_url":"https://github.com/greygjhart","followers_url":"https://api.github.com/users/greygjhart/followers","following_url":"https://api.github.com/users/greygjhart/following{/other_user}","gists_url":"https://api.github.com/users/greygjhart/gists{/gist_id}","starred_url":"https://api.github.com/users/greygjhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greygjhart/subscriptions","organizations_url":"https://api.github.com/users/greygjhart/orgs","repos_url":"https://api.github.com/users/greygjhart/repos","events_url":"https://api.github.com/users/greygjhart/events{/privacy}","received_events_url":"https://api.github.com/users/greygjhart/received_events","type":"User","site_admin":false},"labels":[{"id":6893141,"url":"https://api.github.com/repos/voidlinux/void-mklive/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-11T09:17:40Z","updated_at":"2017-06-24T08:00:30Z","closed_at":"2017-06-24T08:00:30Z","body":"Well, clearly a cosmetics issue, very easy to workaround but still, I think that kind of scripts ought to be robust enough to run no matter where it's installed.\r\n\r\nIt's very easy to reproduce, just clone into 'void mklive' instead of 'void-mklive' and you should see a 'void' directory appear next to it while running `./mklive.sh`. It's also very clear why this happen, almost all location variables appear unquoted in the script like so\r\n\r\n`mkdir -p $ROOTFS/$f`\r\n\r\nI've [forked](https://github.com/greygjhart/void-mklive) the project to work on the issue and I'll make a PR if that's fine with you guys (I could totally understand that you don't want the variables in your script to get massively double-quoted for such a minor gain as fixing the issue I'm reporting). I'm almost there but I think I may have been to quote-eager, now I get a weird ' /' getting created in the root of the new system being generated and step 4 fails with dracut not finding the tools it needs."}}
{"actor":{"display_login":"the-maldridge"}}