{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/100962794","pull_request_review_id":21679167,"id":100962794,"diff_hunk":"@@ -0,0 +1,27 @@\n+# coding: utf-8\n+#\n+# Copyright 2017 The Oppia Authors. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#      http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS-IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+\"\"\"Loads constants for backend use.\"\"\"\n+\n+import json\n+import os\n+\n+class Constants(dict):\n+    \"\"\"Transforms dict to object, attributes can be accesed by dot notation\"\"\"\n+    __getattr__ = dict.__getitem__\n+\n+with open(os.path.join('assets', 'constants.json'), 'r') as f:\n+    CONSTANTS = Constants(json.load(f))","path":"constants.py","position":27,"original_position":27,"commit_id":"c3b4587dd07b13d660ded255b6f85c9c24907eaf","original_commit_id":"c3b4587dd07b13d660ded255b6f85c9c24907eaf","user":{"login":"BenHenning","id":12983742,"avatar_url":"https://avatars.githubusercontent.com/u/12983742?v=3","gravatar_id":"","url":"https://api.github.com/users/BenHenning","html_url":"https://github.com/BenHenning","followers_url":"https://api.github.com/users/BenHenning/followers","following_url":"https://api.github.com/users/BenHenning/following{/other_user}","gists_url":"https://api.github.com/users/BenHenning/gists{/gist_id}","starred_url":"https://api.github.com/users/BenHenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenHenning/subscriptions","organizations_url":"https://api.github.com/users/BenHenning/orgs","repos_url":"https://api.github.com/users/BenHenning/repos","events_url":"https://api.github.com/users/BenHenning/events{/privacy}","received_events_url":"https://api.github.com/users/BenHenning/received_events","type":"User","site_admin":false},"body":"This feels like an abuse of uppercase naming. This isn't actually a constant, it's an object containing constants. Perhaps it should just be ``constants``. Thoughts? @seanlip thoughts?","created_at":"2017-02-14T05:30:26Z","updated_at":"2017-02-14T05:36:34Z","html_url":"https://github.com/oppia/oppia/pull/3033#discussion_r100962794","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/3033","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/100962794"},"html":{"href":"https://github.com/oppia/oppia/pull/3033#discussion_r100962794"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3033"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/3033","id":105050791,"html_url":"https://github.com/oppia/oppia/pull/3033","diff_url":"https://github.com/oppia/oppia/pull/3033.diff","patch_url":"https://github.com/oppia/oppia/pull/3033.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/3033","number":3033,"state":"open","locked":false,"title":"Fixes #1695: Way to automatically provide backend constants to the frontend.","user":{"login":"vojtechjelinek","id":10142938,"avatar_url":"https://avatars.githubusercontent.com/u/10142938?v=3","gravatar_id":"","url":"https://api.github.com/users/vojtechjelinek","html_url":"https://github.com/vojtechjelinek","followers_url":"https://api.github.com/users/vojtechjelinek/followers","following_url":"https://api.github.com/users/vojtechjelinek/following{/other_user}","gists_url":"https://api.github.com/users/vojtechjelinek/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechjelinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechjelinek/subscriptions","organizations_url":"https://api.github.com/users/vojtechjelinek/orgs","repos_url":"https://api.github.com/users/vojtechjelinek/repos","events_url":"https://api.github.com/users/vojtechjelinek/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechjelinek/received_events","type":"User","site_admin":false},"body":"Fixes #1695. All constants are in `assets/constants.json`. In the backend, they're loaded and transformed to an object (so values can be accessed by dot notation) in `constants.py`. In the frontend, they're synchronously loaded by vanilla JS and then passed to `angular.constants()` object.\r\n","created_at":"2017-02-07T17:10:28Z","updated_at":"2017-02-14T05:36:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b5599f93aeedc6671d4d95339f349dd18c68c85","assignee":{"login":"vojtechjelinek","id":10142938,"avatar_url":"https://avatars.githubusercontent.com/u/10142938?v=3","gravatar_id":"","url":"https://api.github.com/users/vojtechjelinek","html_url":"https://github.com/vojtechjelinek","followers_url":"https://api.github.com/users/vojtechjelinek/followers","following_url":"https://api.github.com/users/vojtechjelinek/following{/other_user}","gists_url":"https://api.github.com/users/vojtechjelinek/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechjelinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechjelinek/subscriptions","organizations_url":"https://api.github.com/users/vojtechjelinek/orgs","repos_url":"https://api.github.com/users/vojtechjelinek/repos","events_url":"https://api.github.com/users/vojtechjelinek/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechjelinek/received_events","type":"User","site_admin":false},"assignees":[{"login":"vojtechjelinek","id":10142938,"avatar_url":"https://avatars.githubusercontent.com/u/10142938?v=3","gravatar_id":"","url":"https://api.github.com/users/vojtechjelinek","html_url":"https://github.com/vojtechjelinek","followers_url":"https://api.github.com/users/vojtechjelinek/followers","following_url":"https://api.github.com/users/vojtechjelinek/following{/other_user}","gists_url":"https://api.github.com/users/vojtechjelinek/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechjelinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechjelinek/subscriptions","organizations_url":"https://api.github.com/users/vojtechjelinek/orgs","repos_url":"https://api.github.com/users/vojtechjelinek/repos","events_url":"https://api.github.com/users/vojtechjelinek/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechjelinek/received_events","type":"User","site_admin":false},{"login":"BenHenning","id":12983742,"avatar_url":"https://avatars.githubusercontent.com/u/12983742?v=3","gravatar_id":"","url":"https://api.github.com/users/BenHenning","html_url":"https://github.com/BenHenning","followers_url":"https://api.github.com/users/BenHenning/followers","following_url":"https://api.github.com/users/BenHenning/following{/other_user}","gists_url":"https://api.github.com/users/BenHenning/gists{/gist_id}","starred_url":"https://api.github.com/users/BenHenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenHenning/subscriptions","organizations_url":"https://api.github.com/users/BenHenning/orgs","repos_url":"https://api.github.com/users/BenHenning/repos","events_url":"https://api.github.com/users/BenHenning/events{/privacy}","received_events_url":"https://api.github.com/users/BenHenning/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/3033/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/3033/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/3033/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/c3b4587dd07b13d660ded255b6f85c9c24907eaf","head":{"label":"vojtechjelinek:constants","ref":"constants","sha":"c3b4587dd07b13d660ded255b6f85c9c24907eaf","user":{"login":"vojtechjelinek","id":10142938,"avatar_url":"https://avatars.githubusercontent.com/u/10142938?v=3","gravatar_id":"","url":"https://api.github.com/users/vojtechjelinek","html_url":"https://github.com/vojtechjelinek","followers_url":"https://api.github.com/users/vojtechjelinek/followers","following_url":"https://api.github.com/users/vojtechjelinek/following{/other_user}","gists_url":"https://api.github.com/users/vojtechjelinek/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechjelinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechjelinek/subscriptions","organizations_url":"https://api.github.com/users/vojtechjelinek/orgs","repos_url":"https://api.github.com/users/vojtechjelinek/repos","events_url":"https://api.github.com/users/vojtechjelinek/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechjelinek/received_events","type":"User","site_admin":false},"repo":{"id":71257604,"name":"oppia","full_name":"vojtechjelinek/oppia","owner":{"login":"vojtechjelinek","id":10142938,"avatar_url":"https://avatars.githubusercontent.com/u/10142938?v=3","gravatar_id":"","url":"https://api.github.com/users/vojtechjelinek","html_url":"https://github.com/vojtechjelinek","followers_url":"https://api.github.com/users/vojtechjelinek/followers","following_url":"https://api.github.com/users/vojtechjelinek/following{/other_user}","gists_url":"https://api.github.com/users/vojtechjelinek/gists{/gist_id}","starred_url":"https://api.github.com/users/vojtechjelinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vojtechjelinek/subscriptions","organizations_url":"https://api.github.com/users/vojtechjelinek/orgs","repos_url":"https://api.github.com/users/vojtechjelinek/repos","events_url":"https://api.github.com/users/vojtechjelinek/events{/privacy}","received_events_url":"https://api.github.com/users/vojtechjelinek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vojtechjelinek/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/vojtechjelinek/oppia","forks_url":"https://api.github.com/repos/vojtechjelinek/oppia/forks","keys_url":"https://api.github.com/repos/vojtechjelinek/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vojtechjelinek/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vojtechjelinek/oppia/teams","hooks_url":"https://api.github.com/repos/vojtechjelinek/oppia/hooks","issue_events_url":"https://api.github.com/repos/vojtechjelinek/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/vojtechjelinek/oppia/events","assignees_url":"https://api.github.com/repos/vojtechjelinek/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/vojtechjelinek/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/vojtechjelinek/oppia/tags","blobs_url":"https://api.github.com/repos/vojtechjelinek/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vojtechjelinek/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vojtechjelinek/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/vojtechjelinek/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vojtechjelinek/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/vojtechjelinek/oppia/languages","stargazers_url":"https://api.github.com/repos/vojtechjelinek/oppia/stargazers","contributors_url":"https://api.github.com/repos/vojtechjelinek/oppia/contributors","subscribers_url":"https://api.github.com/repos/vojtechjelinek/oppia/subscribers","subscription_url":"https://api.github.com/repos/vojtechjelinek/oppia/subscription","commits_url":"https://api.github.com/repos/vojtechjelinek/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/vojtechjelinek/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/vojtechjelinek/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/vojtechjelinek/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/vojtechjelinek/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/vojtechjelinek/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vojtechjelinek/oppia/merges","archive_url":"https://api.github.com/repos/vojtechjelinek/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vojtechjelinek/oppia/downloads","issues_url":"https://api.github.com/repos/vojtechjelinek/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/vojtechjelinek/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/vojtechjelinek/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/vojtechjelinek/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vojtechjelinek/oppia/labels{/name}","releases_url":"https://api.github.com/repos/vojtechjelinek/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/vojtechjelinek/oppia/deployments","created_at":"2016-10-18T14:36:03Z","updated_at":"2016-10-18T14:36:07Z","pushed_at":"2017-02-13T16:58:17Z","git_url":"git://github.com/vojtechjelinek/oppia.git","ssh_url":"git@github.com:vojtechjelinek/oppia.git","clone_url":"https://github.com/vojtechjelinek/oppia.git","svn_url":"https://github.com/vojtechjelinek/oppia","homepage":"https://www.oppia.org","size":49246,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"9e3eb9ac053a4c9c6aa03347465246c6ad5da6f1","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2017-02-11T07:04:44Z","pushed_at":"2017-02-13T19:59:14Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":49542,"stargazers_count":220,"watchers_count":220,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":352,"forks":339,"open_issues":352,"watchers":220,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3033"},"html":{"href":"https://github.com/oppia/oppia/pull/3033"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/3033"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/3033/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3033/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3033/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/c3b4587dd07b13d660ded255b6f85c9c24907eaf"}}}}
{"actor":{"display_login":"BenHenning"}}