{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/trident-project/trident/pulls/16","id":152894424,"html_url":"https://github.com/trident-project/trident/pull/16","diff_url":"https://github.com/trident-project/trident/pull/16.diff","patch_url":"https://github.com/trident-project/trident/pull/16.patch","issue_url":"https://api.github.com/repos/trident-project/trident/issues/16","number":16,"state":"closed","locked":false,"title":"Changes all internal instances of particle_type to sampling_type","user":{"login":"chummels","id":8250999,"avatar_url":"https://avatars2.githubusercontent.com/u/8250999?v=4","gravatar_id":"","url":"https://api.github.com/users/chummels","html_url":"https://github.com/chummels","followers_url":"https://api.github.com/users/chummels/followers","following_url":"https://api.github.com/users/chummels/following{/other_user}","gists_url":"https://api.github.com/users/chummels/gists{/gist_id}","starred_url":"https://api.github.com/users/chummels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chummels/subscriptions","organizations_url":"https://api.github.com/users/chummels/orgs","repos_url":"https://api.github.com/users/chummels/repos","events_url":"https://api.github.com/users/chummels/events{/privacy}","received_events_url":"https://api.github.com/users/chummels/received_events","type":"User","site_admin":false},"body":"Previously, if you used basic functionality in trident with particle datasets, it would default to using the `particle_type` flag, which is now deprecated.  So you'd get a warning and there was a bunch of extra logic to navigate internally.  This simplifies that by internally using `sampling_type`, although we still allow the user to use the deprecated `particle_type` kwarg when adding fields.\r\n\r\n","created_at":"2017-11-15T21:50:03Z","updated_at":"2017-11-15T22:49:24Z","closed_at":"2017-11-15T22:49:24Z","merged_at":"2017-11-15T22:49:24Z","merge_commit_sha":"19b7349e8ac4a2fb4328ab5a4e9c3dc9d1ae92b4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/trident-project/trident/pulls/16/commits","review_comments_url":"https://api.github.com/repos/trident-project/trident/pulls/16/comments","review_comment_url":"https://api.github.com/repos/trident-project/trident/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trident-project/trident/issues/16/comments","statuses_url":"https://api.github.com/repos/trident-project/trident/statuses/479f1ec7bed37639ff743869a1885f70998a9b42","head":{"label":"chummels:particle_type_fix","ref":"particle_type_fix","sha":"479f1ec7bed37639ff743869a1885f70998a9b42","user":{"login":"chummels","id":8250999,"avatar_url":"https://avatars2.githubusercontent.com/u/8250999?v=4","gravatar_id":"","url":"https://api.github.com/users/chummels","html_url":"https://github.com/chummels","followers_url":"https://api.github.com/users/chummels/followers","following_url":"https://api.github.com/users/chummels/following{/other_user}","gists_url":"https://api.github.com/users/chummels/gists{/gist_id}","starred_url":"https://api.github.com/users/chummels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chummels/subscriptions","organizations_url":"https://api.github.com/users/chummels/orgs","repos_url":"https://api.github.com/users/chummels/repos","events_url":"https://api.github.com/users/chummels/events{/privacy}","received_events_url":"https://api.github.com/users/chummels/received_events","type":"User","site_admin":false},"repo":{"id":103587621,"name":"trident","full_name":"chummels/trident","owner":{"login":"chummels","id":8250999,"avatar_url":"https://avatars2.githubusercontent.com/u/8250999?v=4","gravatar_id":"","url":"https://api.github.com/users/chummels","html_url":"https://github.com/chummels","followers_url":"https://api.github.com/users/chummels/followers","following_url":"https://api.github.com/users/chummels/following{/other_user}","gists_url":"https://api.github.com/users/chummels/gists{/gist_id}","starred_url":"https://api.github.com/users/chummels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chummels/subscriptions","organizations_url":"https://api.github.com/users/chummels/orgs","repos_url":"https://api.github.com/users/chummels/repos","events_url":"https://api.github.com/users/chummels/events{/privacy}","received_events_url":"https://api.github.com/users/chummels/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chummels/trident","description":"A Synthetic Spectra Generation Suite","fork":true,"url":"https://api.github.com/repos/chummels/trident","forks_url":"https://api.github.com/repos/chummels/trident/forks","keys_url":"https://api.github.com/repos/chummels/trident/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chummels/trident/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chummels/trident/teams","hooks_url":"https://api.github.com/repos/chummels/trident/hooks","issue_events_url":"https://api.github.com/repos/chummels/trident/issues/events{/number}","events_url":"https://api.github.com/repos/chummels/trident/events","assignees_url":"https://api.github.com/repos/chummels/trident/assignees{/user}","branches_url":"https://api.github.com/repos/chummels/trident/branches{/branch}","tags_url":"https://api.github.com/repos/chummels/trident/tags","blobs_url":"https://api.github.com/repos/chummels/trident/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chummels/trident/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chummels/trident/git/refs{/sha}","trees_url":"https://api.github.com/repos/chummels/trident/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chummels/trident/statuses/{sha}","languages_url":"https://api.github.com/repos/chummels/trident/languages","stargazers_url":"https://api.github.com/repos/chummels/trident/stargazers","contributors_url":"https://api.github.com/repos/chummels/trident/contributors","subscribers_url":"https://api.github.com/repos/chummels/trident/subscribers","subscription_url":"https://api.github.com/repos/chummels/trident/subscription","commits_url":"https://api.github.com/repos/chummels/trident/commits{/sha}","git_commits_url":"https://api.github.com/repos/chummels/trident/git/commits{/sha}","comments_url":"https://api.github.com/repos/chummels/trident/comments{/number}","issue_comment_url":"https://api.github.com/repos/chummels/trident/issues/comments{/number}","contents_url":"https://api.github.com/repos/chummels/trident/contents/{+path}","compare_url":"https://api.github.com/repos/chummels/trident/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chummels/trident/merges","archive_url":"https://api.github.com/repos/chummels/trident/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chummels/trident/downloads","issues_url":"https://api.github.com/repos/chummels/trident/issues{/number}","pulls_url":"https://api.github.com/repos/chummels/trident/pulls{/number}","milestones_url":"https://api.github.com/repos/chummels/trident/milestones{/number}","notifications_url":"https://api.github.com/repos/chummels/trident/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chummels/trident/labels{/name}","releases_url":"https://api.github.com/repos/chummels/trident/releases{/id}","deployments_url":"https://api.github.com/repos/chummels/trident/deployments","created_at":"2017-09-14T22:22:35Z","updated_at":"2017-09-14T22:22:37Z","pushed_at":"2017-11-15T21:35:36Z","git_url":"git://github.com/chummels/trident.git","ssh_url":"git@github.com:chummels/trident.git","clone_url":"https://github.com/chummels/trident.git","svn_url":"https://github.com/chummels/trident","homepage":"","size":4740,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trident-project:master","ref":"master","sha":"54441fb425bcc15c9b95f7c22ef5c3a208c57a7f","user":{"login":"trident-project","id":30848076,"avatar_url":"https://avatars1.githubusercontent.com/u/30848076?v=4","gravatar_id":"","url":"https://api.github.com/users/trident-project","html_url":"https://github.com/trident-project","followers_url":"https://api.github.com/users/trident-project/followers","following_url":"https://api.github.com/users/trident-project/following{/other_user}","gists_url":"https://api.github.com/users/trident-project/gists{/gist_id}","starred_url":"https://api.github.com/users/trident-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trident-project/subscriptions","organizations_url":"https://api.github.com/users/trident-project/orgs","repos_url":"https://api.github.com/users/trident-project/repos","events_url":"https://api.github.com/users/trident-project/events{/privacy}","received_events_url":"https://api.github.com/users/trident-project/received_events","type":"Organization","site_admin":false},"repo":{"id":103569132,"name":"trident","full_name":"trident-project/trident","owner":{"login":"trident-project","id":30848076,"avatar_url":"https://avatars1.githubusercontent.com/u/30848076?v=4","gravatar_id":"","url":"https://api.github.com/users/trident-project","html_url":"https://github.com/trident-project","followers_url":"https://api.github.com/users/trident-project/followers","following_url":"https://api.github.com/users/trident-project/following{/other_user}","gists_url":"https://api.github.com/users/trident-project/gists{/gist_id}","starred_url":"https://api.github.com/users/trident-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trident-project/subscriptions","organizations_url":"https://api.github.com/users/trident-project/orgs","repos_url":"https://api.github.com/users/trident-project/repos","events_url":"https://api.github.com/users/trident-project/events{/privacy}","received_events_url":"https://api.github.com/users/trident-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trident-project/trident","description":"A Synthetic Spectra Generation Suite","fork":false,"url":"https://api.github.com/repos/trident-project/trident","forks_url":"https://api.github.com/repos/trident-project/trident/forks","keys_url":"https://api.github.com/repos/trident-project/trident/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trident-project/trident/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trident-project/trident/teams","hooks_url":"https://api.github.com/repos/trident-project/trident/hooks","issue_events_url":"https://api.github.com/repos/trident-project/trident/issues/events{/number}","events_url":"https://api.github.com/repos/trident-project/trident/events","assignees_url":"https://api.github.com/repos/trident-project/trident/assignees{/user}","branches_url":"https://api.github.com/repos/trident-project/trident/branches{/branch}","tags_url":"https://api.github.com/repos/trident-project/trident/tags","blobs_url":"https://api.github.com/repos/trident-project/trident/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trident-project/trident/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trident-project/trident/git/refs{/sha}","trees_url":"https://api.github.com/repos/trident-project/trident/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trident-project/trident/statuses/{sha}","languages_url":"https://api.github.com/repos/trident-project/trident/languages","stargazers_url":"https://api.github.com/repos/trident-project/trident/stargazers","contributors_url":"https://api.github.com/repos/trident-project/trident/contributors","subscribers_url":"https://api.github.com/repos/trident-project/trident/subscribers","subscription_url":"https://api.github.com/repos/trident-project/trident/subscription","commits_url":"https://api.github.com/repos/trident-project/trident/commits{/sha}","git_commits_url":"https://api.github.com/repos/trident-project/trident/git/commits{/sha}","comments_url":"https://api.github.com/repos/trident-project/trident/comments{/number}","issue_comment_url":"https://api.github.com/repos/trident-project/trident/issues/comments{/number}","contents_url":"https://api.github.com/repos/trident-project/trident/contents/{+path}","compare_url":"https://api.github.com/repos/trident-project/trident/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trident-project/trident/merges","archive_url":"https://api.github.com/repos/trident-project/trident/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trident-project/trident/downloads","issues_url":"https://api.github.com/repos/trident-project/trident/issues{/number}","pulls_url":"https://api.github.com/repos/trident-project/trident/pulls{/number}","milestones_url":"https://api.github.com/repos/trident-project/trident/milestones{/number}","notifications_url":"https://api.github.com/repos/trident-project/trident/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trident-project/trident/labels{/name}","releases_url":"https://api.github.com/repos/trident-project/trident/releases{/id}","deployments_url":"https://api.github.com/repos/trident-project/trident/deployments","created_at":"2017-09-14T18:46:32Z","updated_at":"2017-09-14T22:19:47Z","pushed_at":"2017-11-15T22:49:24Z","git_url":"git://github.com/trident-project/trident.git","ssh_url":"git@github.com:trident-project/trident.git","clone_url":"https://github.com/trident-project/trident.git","svn_url":"https://github.com/trident-project/trident","homepage":"","size":4735,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trident-project/trident/pulls/16"},"html":{"href":"https://github.com/trident-project/trident/pull/16"},"issue":{"href":"https://api.github.com/repos/trident-project/trident/issues/16"},"comments":{"href":"https://api.github.com/repos/trident-project/trident/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/trident-project/trident/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/trident-project/trident/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trident-project/trident/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/trident-project/trident/statuses/479f1ec7bed37639ff743869a1885f70998a9b42"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"chummels","id":8250999,"avatar_url":"https://avatars2.githubusercontent.com/u/8250999?v=4","gravatar_id":"","url":"https://api.github.com/users/chummels","html_url":"https://github.com/chummels","followers_url":"https://api.github.com/users/chummels/followers","following_url":"https://api.github.com/users/chummels/following{/other_user}","gists_url":"https://api.github.com/users/chummels/gists{/gist_id}","starred_url":"https://api.github.com/users/chummels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chummels/subscriptions","organizations_url":"https://api.github.com/users/chummels/orgs","repos_url":"https://api.github.com/users/chummels/repos","events_url":"https://api.github.com/users/chummels/events{/privacy}","received_events_url":"https://api.github.com/users/chummels/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":51,"deletions":28,"changed_files":3}}
{"actor":{"display_login":"chummels"}}