{"action":"created","issue":{"url":"https://api.github.com/repos/alpinelinux/aports/issues/2302","repository_url":"https://api.github.com/repos/alpinelinux/aports","labels_url":"https://api.github.com/repos/alpinelinux/aports/issues/2302/labels{/name}","comments_url":"https://api.github.com/repos/alpinelinux/aports/issues/2302/comments","events_url":"https://api.github.com/repos/alpinelinux/aports/issues/2302/events","html_url":"https://github.com/alpinelinux/aports/pull/2302","id":257331392,"number":2302,"title":"main/mariadb: upgrade to 10.2.8, modernize","user":{"login":"TBK","id":858296,"avatar_url":"https://avatars0.githubusercontent.com/u/858296?v=4","gravatar_id":"","url":"https://api.github.com/users/TBK","html_url":"https://github.com/TBK","followers_url":"https://api.github.com/users/TBK/followers","following_url":"https://api.github.com/users/TBK/following{/other_user}","gists_url":"https://api.github.com/users/TBK/gists{/gist_id}","starred_url":"https://api.github.com/users/TBK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBK/subscriptions","organizations_url":"https://api.github.com/users/TBK/orgs","repos_url":"https://api.github.com/users/TBK/repos","events_url":"https://api.github.com/users/TBK/events{/privacy}","received_events_url":"https://api.github.com/users/TBK/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-13T10:26:27Z","updated_at":"2017-09-14T09:46:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alpinelinux/aports/pulls/2302","html_url":"https://github.com/alpinelinux/aports/pull/2302","diff_url":"https://github.com/alpinelinux/aports/pull/2302.diff","patch_url":"https://github.com/alpinelinux/aports/pull/2302.patch"},"body":"After a lot of fiddeling and 3 hours of compiling I think it is in a state where it is ready for some feedback.\r\n\r\nThings that I question:\r\n- Should the cmake flags be updated?\r\n- Related to the previous question - the official deb build uses quite a few more makedepends. Should more be added? (https://github.com/MariaDB/server/blob/10.2/debian/control)\r\n- All of the symlinks for the mariadb-client-libs are missing. I am not sure how to fix that:\r\n```\r\nlibmariadb.so -> libmariadb.so.3\r\nlibmariadb.so.3\r\nlibmysqlclient_r.so -> libmariadb.so.3\r\nlibmysqlclient.so -> libmariadb.so.3\r\n```\r\n- Should there be added a check function to run the test suite?"},"comment":{"url":"https://api.github.com/repos/alpinelinux/aports/issues/comments/329431497","html_url":"https://github.com/alpinelinux/aports/pull/2302#issuecomment-329431497","issue_url":"https://api.github.com/repos/alpinelinux/aports/issues/2302","id":329431497,"user":{"login":"ncopa","id":66357,"avatar_url":"https://avatars1.githubusercontent.com/u/66357?v=4","gravatar_id":"","url":"https://api.github.com/users/ncopa","html_url":"https://github.com/ncopa","followers_url":"https://api.github.com/users/ncopa/followers","following_url":"https://api.github.com/users/ncopa/following{/other_user}","gists_url":"https://api.github.com/users/ncopa/gists{/gist_id}","starred_url":"https://api.github.com/users/ncopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncopa/subscriptions","organizations_url":"https://api.github.com/users/ncopa/orgs","repos_url":"https://api.github.com/users/ncopa/repos","events_url":"https://api.github.com/users/ncopa/events{/privacy}","received_events_url":"https://api.github.com/users/ncopa/received_events","type":"User","site_admin":false},"created_at":"2017-09-14T09:46:31Z","updated_at":"2017-09-14T09:46:31Z","author_association":"CONTRIBUTOR","body":"> Should the cmake flags be updated?\r\n\r\nWhy? are the current flags broken or missing anything?\r\n\r\n> Related to the previous question - the official deb build uses quite a few more makedepends. Should more be added? (https://github.com/MariaDB/server/blob/10.2/debian/control)\r\n\r\nWhy should we add those if nobody asked for those features?\r\n\r\n> All of the symlinks for the mariadb-client-libs are missing. I am not sure how to fix that:\r\n\r\nThey are not missing. They are provided in the -dev subpackage. the client works just fine without those symlinks.\r\n\r\n> Should there be added a check function to run the test suite?\r\n\r\nThat would be good yes."}}
{"actor":{"display_login":"ncopa"}}