{"action":"created","issue":{"url":"https://api.github.com/repos/internetee/registry/issues/569","repository_url":"https://api.github.com/repos/internetee/registry","labels_url":"https://api.github.com/repos/internetee/registry/issues/569/labels{/name}","comments_url":"https://api.github.com/repos/internetee/registry/issues/569/comments","events_url":"https://api.github.com/repos/internetee/registry/issues/569/events","html_url":"https://github.com/internetee/registry/issues/569","id":240924693,"number":569,"title":"Activemodel not validating object throws wrong error","user":{"login":"teadur","id":6999979,"avatar_url":"https://avatars0.githubusercontent.com/u/6999979?v=4","gravatar_id":"","url":"https://api.github.com/users/teadur","html_url":"https://github.com/teadur","followers_url":"https://api.github.com/users/teadur/followers","following_url":"https://api.github.com/users/teadur/following{/other_user}","gists_url":"https://api.github.com/users/teadur/gists{/gist_id}","starred_url":"https://api.github.com/users/teadur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teadur/subscriptions","organizations_url":"https://api.github.com/users/teadur/orgs","repos_url":"https://api.github.com/users/teadur/repos","events_url":"https://api.github.com/users/teadur/events{/privacy}","received_events_url":"https://api.github.com/users/teadur/received_events","type":"User","site_admin":false},"labels":[{"id":103122571,"url":"https://api.github.com/repos/internetee/registry/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"vohmar","id":7734747,"avatar_url":"https://avatars2.githubusercontent.com/u/7734747?v=4","gravatar_id":"","url":"https://api.github.com/users/vohmar","html_url":"https://github.com/vohmar","followers_url":"https://api.github.com/users/vohmar/followers","following_url":"https://api.github.com/users/vohmar/following{/other_user}","gists_url":"https://api.github.com/users/vohmar/gists{/gist_id}","starred_url":"https://api.github.com/users/vohmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vohmar/subscriptions","organizations_url":"https://api.github.com/users/vohmar/orgs","repos_url":"https://api.github.com/users/vohmar/repos","events_url":"https://api.github.com/users/vohmar/events{/privacy}","received_events_url":"https://api.github.com/users/vohmar/received_events","type":"User","site_admin":false},"assignees":[{"login":"vohmar","id":7734747,"avatar_url":"https://avatars2.githubusercontent.com/u/7734747?v=4","gravatar_id":"","url":"https://api.github.com/users/vohmar","html_url":"https://github.com/vohmar","followers_url":"https://api.github.com/users/vohmar/followers","following_url":"https://api.github.com/users/vohmar/following{/other_user}","gists_url":"https://api.github.com/users/vohmar/gists{/gist_id}","starred_url":"https://api.github.com/users/vohmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vohmar/subscriptions","organizations_url":"https://api.github.com/users/vohmar/orgs","repos_url":"https://api.github.com/users/vohmar/repos","events_url":"https://api.github.com/users/vohmar/events{/privacy}","received_events_url":"https://api.github.com/users/vohmar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2017-07-06T11:21:16Z","updated_at":"2017-08-21T09:40:18Z","closed_at":null,"body":"Expected return is Activemodel errors shown in EPP.\r\n\r\nContact object validation fails:\r\n\r\nirb(main):009:0> a.validate\r\nUSER MSG: ACTIVEMODEL: Contact [ident] Required parameter missing - ident\r\nUSER MSG: ACTIVEMODEL: Contact [ident_type] is missing\r\nUSER MSG: ACTIVEMODEL: Contact [ident_type] Object status prohibits operation: ident_type of contact CID:XXXX:xxxx is invalid\r\nUSER MSG: ACTIVEMODEL: Contact [ident] Ident country code is not valid, should be in ISO_3166-1 alpha 2 format\r\nUSER MSG: ACTIVERECORD: Contact #117517 [\"Ident Required parameter missing - ident\", \"Ident Ident country code is not valid, should be in ISO_3166-1 alpha 2 format\", \"Ident type is missing\", \"Ident type Object status prohibits operation: ident_type of contact CID:XXXX:xxxx is invalid\"] []\r\n=> false\r\n\r\nWhen user wants to update that object over epp non clear error is thrown:\r\n\r\nRequest XML is\r\n\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n\r\n<epp xmlns=\"https://epp.tld.ee/schema/epp-ee-1.0.xsd\">\r\n\r\n       <command>\r\n\r\n              <update>\r\n\r\n                     <contact:update xmlns:contact=\"https://epp.tld.ee/schema/contact-ee-1.1.xsd\">\r\n\r\n                           <contact:id>CID:XXXXX:xxxxx</contact:id>\r\n\r\n                           <contact:chg>\r\n\r\n                                  <contact:postalInfo>\r\n\r\n                                         <contact:name>New Contact name</contact:name>\r\n\r\n                                  </contact:postalInfo>\r\n\r\n                                  <contact:voice>+327.12345/contact:voice>\r\n\r\n                                  <contact:email>email@domain.tld</contact:email>\r\n\r\n                           </contact:chg>\r\n\r\n                     </contact:update>\r\n\r\n              </update>\r\n\r\n              <extension>\r\n\r\n                     <eis:extdata xmlns:eis=\"https://epp.tld.ee/schema/eis-1.0.xsd\">\r\n\r\n                           <eis:ident cc=\"CH\" type=\"org\">CHE-XXXXX</eis:ident>\r\n\r\n                     </eis:extdata>\r\n\r\n              </extension>\r\n\r\n              <clTRID>XXXX:xxxx:784991809977051</clTRID>\r\n\r\n       </command>\r\n\r\n</epp>\r\n\r\n \r\n\r\nResponse XML is\r\n\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n\r\n<epp xmlns=\"https://epp.tld.ee/schema/epp-ee-1.0.xsd\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\r\n\r\n       xsi:schemaLocation=\"lib/schemas/epp-ee-1.0.xsd\">\r\n\r\n       <response>\r\n\r\n              <result code=\"1\">\r\n\r\n                     <msg lang=\"en\">handle_errors was executed when there were actually no errors</msg>\r\n\r\n              </result>\r\n\r\n              <trID>\r\n\r\n                     <clTRID>XXXX:xxxx:784991809977051</clTRID>\r\n\r\n                     <svTRID>ccReg-5352543179</svTRID>\r\n\r\n              </trID>\r\n\r\n       </response>\r\n\r\n</epp>\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/internetee/registry/issues/comments/323697201","html_url":"https://github.com/internetee/registry/issues/569#issuecomment-323697201","issue_url":"https://api.github.com/repos/internetee/registry/issues/569","id":323697201,"user":{"login":"artur-beljajev","id":22315378,"avatar_url":"https://avatars2.githubusercontent.com/u/22315378?v=4","gravatar_id":"","url":"https://api.github.com/users/artur-beljajev","html_url":"https://github.com/artur-beljajev","followers_url":"https://api.github.com/users/artur-beljajev/followers","following_url":"https://api.github.com/users/artur-beljajev/following{/other_user}","gists_url":"https://api.github.com/users/artur-beljajev/gists{/gist_id}","starred_url":"https://api.github.com/users/artur-beljajev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artur-beljajev/subscriptions","organizations_url":"https://api.github.com/users/artur-beljajev/orgs","repos_url":"https://api.github.com/users/artur-beljajev/repos","events_url":"https://api.github.com/users/artur-beljajev/events{/privacy}","received_events_url":"https://api.github.com/users/artur-beljajev/received_events","type":"User","site_admin":false},"created_at":"2017-08-21T09:40:18Z","updated_at":"2017-08-21T09:40:18Z","body":"https://github.com/internetee/registry/issues/569#issuecomment-316840687 is still actual. I guess it's also needed to document the fact, that a user must provide currently valid `ident` to be able to update invalid type or country."}}
{"actor":{"display_login":"artur-beljajev"}}