{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/326","repository_url":"https://api.github.com/repos/bazelbuild/rules_scala","labels_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/326/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/326/events","html_url":"https://github.com/bazelbuild/rules_scala/pull/326","id":269516591,"number":326,"title":"adding scala_import","user":{"login":"ittaiz","id":1378327,"avatar_url":"https://avatars2.githubusercontent.com/u/1378327?v=4","gravatar_id":"","url":"https://api.github.com/users/ittaiz","html_url":"https://github.com/ittaiz","followers_url":"https://api.github.com/users/ittaiz/followers","following_url":"https://api.github.com/users/ittaiz/following{/other_user}","gists_url":"https://api.github.com/users/ittaiz/gists{/gist_id}","starred_url":"https://api.github.com/users/ittaiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ittaiz/subscriptions","organizations_url":"https://api.github.com/users/ittaiz/orgs","repos_url":"https://api.github.com/users/ittaiz/repos","events_url":"https://api.github.com/users/ittaiz/events{/privacy}","received_events_url":"https://api.github.com/users/ittaiz/received_events","type":"User","site_admin":false},"labels":[{"id":330860803,"url":"https://api.github.com/repos/bazelbuild/rules_scala/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2017-10-30T08:30:48Z","updated_at":"2017-11-23T01:00:12Z","closed_at":"2017-11-21T23:43:33Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/pulls/326","html_url":"https://github.com/bazelbuild/rules_scala/pull/326","diff_url":"https://github.com/bazelbuild/rules_scala/pull/326.diff","patch_url":"https://github.com/bazelbuild/rules_scala/pull/326.patch"},"body":"Motivation:\r\nThe need for `scala_import` stems from the lack of support for scala's macros in ijar (see https://github.com/bazelbuild/bazel/issues/632 fro more details). This means we need a way to import external jars which doesn't pass through ijar. The current workaround is to use `maven_jar` and then use the `//jar:file` target which exposes a raw filegroup target.\r\nUnfortunately that doesn't play nicely with bazel-intellij plugin which needs metadata about the target.\r\nCurrent state:\r\nDoes:\r\nSupports intellij\r\nCreates java_provider\r\nhas deps and runtime_deps\r\nPartial support for \"aggregators\" (you can pass None)\r\n\r\nDoes not (yet):\r\nSupport neverlink\r\nSupport many code jars\r\nSupports exports (not sure will be supported)\r\nAllow to give a raw jar and have the rule create an ijar if needed for it. This will enable working against ijars of 3rd party. When supporting this we'll probably add another flag to say if to use ijar or not for scala macros. \r\nHave tests\r\n\r\nThis will hopefully take more form and especially get some coverage but in the meantime it's here for people to see, think and maybe even contribute tests"},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/comments/346511588","html_url":"https://github.com/bazelbuild/rules_scala/pull/326#issuecomment-346511588","issue_url":"https://api.github.com/repos/bazelbuild/rules_scala/issues/326","id":346511588,"user":{"login":"gkk-stripe","id":24235374,"avatar_url":"https://avatars0.githubusercontent.com/u/24235374?v=4","gravatar_id":"","url":"https://api.github.com/users/gkk-stripe","html_url":"https://github.com/gkk-stripe","followers_url":"https://api.github.com/users/gkk-stripe/followers","following_url":"https://api.github.com/users/gkk-stripe/following{/other_user}","gists_url":"https://api.github.com/users/gkk-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/gkk-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkk-stripe/subscriptions","organizations_url":"https://api.github.com/users/gkk-stripe/orgs","repos_url":"https://api.github.com/users/gkk-stripe/repos","events_url":"https://api.github.com/users/gkk-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/gkk-stripe/received_events","type":"User","site_admin":false},"created_at":"2017-11-23T01:00:12Z","updated_at":"2017-11-23T01:00:12Z","author_association":"CONTRIBUTOR","body":"Yes, it is with 0.6.1. I'm giving 0.7.0 a whirl.\n\nI tried to reproduce the problem in my small repo but the problem didn't\nshow up.\n\nOn Wed, Nov 22, 2017 at 9:13 AM P. Oscar Boykin <notifications@github.com>\nwrote:\n\n> It could also be a bazel version issue. @gkk-stripe\n> <https://github.com/gkk-stripe> can you share the version you tested\n> with? I guess 0.6.1?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/bazelbuild/rules_scala/pull/326#issuecomment-346416211>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AXHNbrg-_4TWSiZHJaYXjPe-kk56UhXhks5s5FZHgaJpZM4QK0ui>\n> .\n>\n"}}
{"actor":{"display_login":"gkk-stripe"}}