{"action":"closed","number":25999,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25999","id":121842617,"html_url":"https://github.com/NixOS/nixpkgs/pull/25999","diff_url":"https://github.com/NixOS/nixpkgs/pull/25999.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/25999.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25999","number":25999,"state":"closed","locked":false,"title":"swap: extend randomEncryption to plainOpen and ability to select cipher","user":{"login":"gentoofreak","id":9391658,"avatar_url":"https://avatars0.githubusercontent.com/u/9391658?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoofreak","html_url":"https://github.com/gentoofreak","followers_url":"https://api.github.com/users/gentoofreak/followers","following_url":"https://api.github.com/users/gentoofreak/following{/other_user}","gists_url":"https://api.github.com/users/gentoofreak/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoofreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoofreak/subscriptions","organizations_url":"https://api.github.com/users/gentoofreak/orgs","repos_url":"https://api.github.com/users/gentoofreak/repos","events_url":"https://api.github.com/users/gentoofreak/events{/privacy}","received_events_url":"https://api.github.com/users/gentoofreak/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nBased on https://github.com/NixOS/nixpkgs/pull/25900 I expanded the configuration of swapDevices.*.randomEncryption to a set of options to enable users to choose a cipher etc.\r\n\r\n```\r\nrandomEncryption = (true|false);\r\n```\r\n\r\nbecomes\r\n```\r\nrandomEncryption = {\r\n  enable = (true|false);\r\n  cipher = \"aes-xts-plain64\";\r\n  source = \"/dev/urandom\";\r\n};\r\n```\r\n\r\nOf course __this breaks all current user configurations__ when they already use randomEncryption.\r\n\r\n###### Things done\r\n\r\n- [X] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).","created_at":"2017-05-22T18:53:59Z","updated_at":"2017-07-26T17:59:12Z","closed_at":"2017-07-26T17:59:12Z","merged_at":null,"merge_commit_sha":"d6f85c92e5d56dad7ff803c72654e3acd0f6576c","assignee":{"login":"abbradar","id":1174810,"avatar_url":"https://avatars0.githubusercontent.com/u/1174810?v=4","gravatar_id":"","url":"https://api.github.com/users/abbradar","html_url":"https://github.com/abbradar","followers_url":"https://api.github.com/users/abbradar/followers","following_url":"https://api.github.com/users/abbradar/following{/other_user}","gists_url":"https://api.github.com/users/abbradar/gists{/gist_id}","starred_url":"https://api.github.com/users/abbradar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbradar/subscriptions","organizations_url":"https://api.github.com/users/abbradar/orgs","repos_url":"https://api.github.com/users/abbradar/repos","events_url":"https://api.github.com/users/abbradar/events{/privacy}","received_events_url":"https://api.github.com/users/abbradar/received_events","type":"User","site_admin":false},"assignees":[{"login":"abbradar","id":1174810,"avatar_url":"https://avatars0.githubusercontent.com/u/1174810?v=4","gravatar_id":"","url":"https://api.github.com/users/abbradar","html_url":"https://github.com/abbradar","followers_url":"https://api.github.com/users/abbradar/followers","following_url":"https://api.github.com/users/abbradar/following{/other_user}","gists_url":"https://api.github.com/users/abbradar/gists{/gist_id}","starred_url":"https://api.github.com/users/abbradar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbradar/subscriptions","organizations_url":"https://api.github.com/users/abbradar/orgs","repos_url":"https://api.github.com/users/abbradar/repos","events_url":"https://api.github.com/users/abbradar/events{/privacy}","received_events_url":"https://api.github.com/users/abbradar/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"abbradar","id":1174810,"avatar_url":"https://avatars0.githubusercontent.com/u/1174810?v=4","gravatar_id":"","url":"https://api.github.com/users/abbradar","html_url":"https://github.com/abbradar","followers_url":"https://api.github.com/users/abbradar/followers","following_url":"https://api.github.com/users/abbradar/following{/other_user}","gists_url":"https://api.github.com/users/abbradar/gists{/gist_id}","starred_url":"https://api.github.com/users/abbradar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abbradar/subscriptions","organizations_url":"https://api.github.com/users/abbradar/orgs","repos_url":"https://api.github.com/users/abbradar/repos","events_url":"https://api.github.com/users/abbradar/events{/privacy}","received_events_url":"https://api.github.com/users/abbradar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/NixOS/nixpkgs/milestones/11","html_url":"https://github.com/NixOS/nixpkgs/milestone/11","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones/11/labels","id":2222128,"number":11,"title":"17.09","description":"","creator":{"login":"grahamc","id":76716,"avatar_url":"https://avatars3.githubusercontent.com/u/76716?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamc","html_url":"https://github.com/grahamc","followers_url":"https://api.github.com/users/grahamc/followers","following_url":"https://api.github.com/users/grahamc/following{/other_user}","gists_url":"https://api.github.com/users/grahamc/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamc/subscriptions","organizations_url":"https://api.github.com/users/grahamc/orgs","repos_url":"https://api.github.com/users/grahamc/repos","events_url":"https://api.github.com/users/grahamc/events{/privacy}","received_events_url":"https://api.github.com/users/grahamc/received_events","type":"User","site_admin":false},"open_issues":100,"closed_issues":22,"state":"open","created_at":"2016-12-31T17:51:12Z","updated_at":"2017-07-26T17:59:12Z","due_on":"2017-09-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25999/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25999/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25999/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b3a259cfd9ac4df2fdf7812f31683760d59bfa85","head":{"label":"gentoofreak:swap-randomEncryption-options","ref":"swap-randomEncryption-options","sha":"b3a259cfd9ac4df2fdf7812f31683760d59bfa85","user":{"login":"gentoofreak","id":9391658,"avatar_url":"https://avatars0.githubusercontent.com/u/9391658?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoofreak","html_url":"https://github.com/gentoofreak","followers_url":"https://api.github.com/users/gentoofreak/followers","following_url":"https://api.github.com/users/gentoofreak/following{/other_user}","gists_url":"https://api.github.com/users/gentoofreak/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoofreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoofreak/subscriptions","organizations_url":"https://api.github.com/users/gentoofreak/orgs","repos_url":"https://api.github.com/users/gentoofreak/repos","events_url":"https://api.github.com/users/gentoofreak/events{/privacy}","received_events_url":"https://api.github.com/users/gentoofreak/received_events","type":"User","site_admin":false},"repo":{"id":91960746,"name":"nixpkgs","full_name":"gentoofreak/nixpkgs","owner":{"login":"gentoofreak","id":9391658,"avatar_url":"https://avatars0.githubusercontent.com/u/9391658?v=4","gravatar_id":"","url":"https://api.github.com/users/gentoofreak","html_url":"https://github.com/gentoofreak","followers_url":"https://api.github.com/users/gentoofreak/followers","following_url":"https://api.github.com/users/gentoofreak/following{/other_user}","gists_url":"https://api.github.com/users/gentoofreak/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoofreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoofreak/subscriptions","organizations_url":"https://api.github.com/users/gentoofreak/orgs","repos_url":"https://api.github.com/users/gentoofreak/repos","events_url":"https://api.github.com/users/gentoofreak/events{/privacy}","received_events_url":"https://api.github.com/users/gentoofreak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gentoofreak/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/gentoofreak/nixpkgs","forks_url":"https://api.github.com/repos/gentoofreak/nixpkgs/forks","keys_url":"https://api.github.com/repos/gentoofreak/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoofreak/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoofreak/nixpkgs/teams","hooks_url":"https://api.github.com/repos/gentoofreak/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/gentoofreak/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/gentoofreak/nixpkgs/events","assignees_url":"https://api.github.com/repos/gentoofreak/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/gentoofreak/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/gentoofreak/nixpkgs/tags","blobs_url":"https://api.github.com/repos/gentoofreak/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoofreak/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoofreak/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoofreak/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoofreak/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoofreak/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/gentoofreak/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/gentoofreak/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/gentoofreak/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/gentoofreak/nixpkgs/subscription","commits_url":"https://api.github.com/repos/gentoofreak/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoofreak/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoofreak/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoofreak/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoofreak/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/gentoofreak/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoofreak/nixpkgs/merges","archive_url":"https://api.github.com/repos/gentoofreak/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoofreak/nixpkgs/downloads","issues_url":"https://api.github.com/repos/gentoofreak/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/gentoofreak/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoofreak/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoofreak/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoofreak/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/gentoofreak/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/gentoofreak/nixpkgs/deployments","created_at":"2017-05-21T13:51:21Z","updated_at":"2017-05-21T13:56:35Z","pushed_at":"2017-07-26T13:59:33Z","git_url":"git://github.com/gentoofreak/nixpkgs.git","ssh_url":"git@github.com:gentoofreak/nixpkgs.git","clone_url":"https://github.com/gentoofreak/nixpkgs.git","svn_url":"https://github.com/gentoofreak/nixpkgs","homepage":null,"size":487658,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"157b5bd1f0ce284bc258c5442e98f56ff65829da","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-07-26T04:04:23Z","pushed_at":"2017-07-26T17:58:47Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":516461,"stargazers_count":1788,"watchers_count":1788,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2157,"mirror_url":null,"open_issues_count":2183,"forks":2157,"open_issues":2183,"watchers":1788,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25999"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/25999"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/25999"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/25999/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25999/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25999/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b3a259cfd9ac4df2fdf7812f31683760d59bfa85"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":13,"review_comments":2,"maintainer_can_modify":false,"commits":3270,"additions":74958,"deletions":43575,"changed_files":2484}}
{"actor":{"display_login":"abbradar"}}