{"action":"created","issue":{"url":"https://api.github.com/repos/ben1605/Soccer-match-outcome-prediction/issues/7","repository_url":"https://api.github.com/repos/ben1605/Soccer-match-outcome-prediction","labels_url":"https://api.github.com/repos/ben1605/Soccer-match-outcome-prediction/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/ben1605/Soccer-match-outcome-prediction/issues/7/comments","events_url":"https://api.github.com/repos/ben1605/Soccer-match-outcome-prediction/issues/7/events","html_url":"https://github.com/ben1605/Soccer-match-outcome-prediction/issues/7","id":280639435,"number":7,"title":"Final Project Peer Review","user":{"login":"jamescalixto","id":9909163,"avatar_url":"https://avatars2.githubusercontent.com/u/9909163?v=4","gravatar_id":"","url":"https://api.github.com/users/jamescalixto","html_url":"https://github.com/jamescalixto","followers_url":"https://api.github.com/users/jamescalixto/followers","following_url":"https://api.github.com/users/jamescalixto/following{/other_user}","gists_url":"https://api.github.com/users/jamescalixto/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescalixto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescalixto/subscriptions","organizations_url":"https://api.github.com/users/jamescalixto/orgs","repos_url":"https://api.github.com/users/jamescalixto/repos","events_url":"https://api.github.com/users/jamescalixto/events{/privacy}","received_events_url":"https://api.github.com/users/jamescalixto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-08T22:45:20Z","updated_at":"2017-12-08T23:25:06Z","closed_at":null,"author_association":"NONE","body":"This project collated data from three different sources - a database of 25,000 European soccer matches, betting odds for each match, and player and team attributes from FIFA. It used this data to perform an analysis on each player to determine the outcomes of soccer matches.\r\n\r\nComments on the project:\r\n- Although I really like LaTeX files I have to say that making this an .md file makes it very readable and I enjoyed reading it, aesthetically speaking.\r\n- For your data cleaning step, you deleted the matches that missed player's ID and position info. I would like to have seen an analysis of the dropped data, since it could arguably be correlated (ex. statistics aggregators may be more likely to make sure their information on popular players/matches is more accurate than data for low-ranked teams). Especially given that this is a significant amount of data (~20% of your full dataset), this analysis would have been great. Although in all honesty that's more me being curious because your assumption is not unreasonable to make.\r\n- Not an issue but I thought your categorizations of team positions into 35 different formations was great and I would have loved to see a full gallery of all 35.\r\n- I really liked the use of the correlation matrix as a sanity-check for your feature reduction; without it it wouldn't be particularly obvious that you can combine all of the columns into one for each team. I would have liked to see a variance plot showing the percentage of variance explained by each eigenvector for your dimensional reduction.\r\n- The structure of your approaches (linear regression to multiclass classification to perceptron to hinge loss to etc.) was great and showed how you thought through each step.\r\n- I would have liked to see the comparisons of your results versus the betting lines and the FIFA stats. Obviously the betting lines and FIFA stats are themselves aggregates of a lot of other data so I am curious to see how much of an improvement your method is over using that data on its own.\r\n- Along the lines of the previous point, I'd really like to see how much money you would win (or perhaps lose) if you used the results of your algorithm to make bets on every match in your dataset). This would be an interesting error metric and if your algorithm is good enough you could definitely make money from it.\r\n- Great use of gifs at the beginning and end of the project; they really emphasize how dynamic your findings are and the importance of this project to the sport of soccer. I would like a source on the soccer gif at the end of the paper though. \r\n- Did you perform cross-validation on your dataset? You had enough points to do so given the number of feature vectors you had and this could have let you choose a better regularizer or weights for your loss functions. This would be a great improvement to make in the future.\r\n\r\nOverall, I enjoyed this project a lot. The results are solid and backed up mathematically, and it has real-world applications. There are several extensions to this paper that would make good follow-up lines of investigation and there are also several things that I would like to see in this paper but on the whole it is a great final project and was fun to read."},"comment":{"url":"https://api.github.com/repos/ben1605/Soccer-match-outcome-prediction/issues/comments/350397446","html_url":"https://github.com/ben1605/Soccer-match-outcome-prediction/issues/7#issuecomment-350397446","issue_url":"https://api.github.com/repos/ben1605/Soccer-match-outcome-prediction/issues/7","id":350397446,"user":{"login":"ben1605","id":9272704,"avatar_url":"https://avatars1.githubusercontent.com/u/9272704?v=4","gravatar_id":"","url":"https://api.github.com/users/ben1605","html_url":"https://github.com/ben1605","followers_url":"https://api.github.com/users/ben1605/followers","following_url":"https://api.github.com/users/ben1605/following{/other_user}","gists_url":"https://api.github.com/users/ben1605/gists{/gist_id}","starred_url":"https://api.github.com/users/ben1605/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben1605/subscriptions","organizations_url":"https://api.github.com/users/ben1605/orgs","repos_url":"https://api.github.com/users/ben1605/repos","events_url":"https://api.github.com/users/ben1605/events{/privacy}","received_events_url":"https://api.github.com/users/ben1605/received_events","type":"User","site_admin":false},"created_at":"2017-12-08T23:25:06Z","updated_at":"2017-12-08T23:25:06Z","author_association":"OWNER","body":"Thank you very much for your advice, and here's the link for the gif: https://pa1.narvii.com/5740/adb11fd58f840ef5b650eead44c043fb5edb027a_hq.gif"}}
{"actor":{"display_login":"ben1605"}}