{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/117794817","pull_request_review_id":39531422,"id":117794817,"diff_hunk":"@@ -0,0 +1,22 @@\n+'use strict';\n+\n+const common = require('../common');\n+const net = require('net');\n+const assert = require('assert');\n+\n+const server = net.createServer();\n+server.listen(0, common.mustCall(function() {","path":"test/parallel/test-net-socket-destroy-send.js","position":8,"original_position":8,"commit_id":"17aebdf445402e25a2be9b51fff64d6c8a7e590f","original_commit_id":"c294477ec9e3a183c5f248b86ee3c4327da8b70a","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars3.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"body":"This is just a plain old ES5 function.","created_at":"2017-05-22T16:55:30Z","updated_at":"2017-05-22T16:55:31Z","html_url":"https://github.com/nodejs/node/pull/13156#discussion_r117794817","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/13156","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/117794817"},"html":{"href":"https://github.com/nodejs/node/pull/13156#discussion_r117794817"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/13156"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/13156","id":121813199,"html_url":"https://github.com/nodejs/node/pull/13156","diff_url":"https://github.com/nodejs/node/pull/13156.diff","patch_url":"https://github.com/nodejs/node/pull/13156.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/13156","number":13156,"state":"open","locked":false,"title":"stream: fix destroy(err, cb) regression","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars3.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"body":"Fixed a regression that caused the callback passed to destroy()\r\nto not be called if the stream was already destroyed.\r\nThis caused a regression on the ws module in CITGM, as discovered\r\nby @refack.\r\n\r\nFixes: https://github.com/websockets/ws/issues/1118\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n\r\nstream, net","created_at":"2017-05-22T16:07:59Z","updated_at":"2017-05-22T16:55:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b14e1099c29cccfb172c0bb316415ac7640ccda4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"calvinmetcalf","id":1128607,"avatar_url":"https://avatars3.githubusercontent.com/u/1128607?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinmetcalf","html_url":"https://github.com/calvinmetcalf","followers_url":"https://api.github.com/users/calvinmetcalf/followers","following_url":"https://api.github.com/users/calvinmetcalf/following{/other_user}","gists_url":"https://api.github.com/users/calvinmetcalf/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinmetcalf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinmetcalf/subscriptions","organizations_url":"https://api.github.com/users/calvinmetcalf/orgs","repos_url":"https://api.github.com/users/calvinmetcalf/repos","events_url":"https://api.github.com/users/calvinmetcalf/events{/privacy}","received_events_url":"https://api.github.com/users/calvinmetcalf/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/20","html_url":"https://github.com/nodejs/node/milestone/20","labels_url":"https://api.github.com/repos/nodejs/node/milestones/20/labels","id":1926639,"number":20,"title":"8.0.0","description":"Semver-major cutoff: May 9th\r\nScheduled Release date: May 30th","creator":{"login":"jasnell","id":439929,"avatar_url":"https://avatars1.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":53,"state":"open","created_at":"2016-08-06T08:04:39Z","updated_at":"2017-05-22T16:50:19Z","due_on":"2017-05-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nodejs/node/pulls/13156/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/13156/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/13156/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/17aebdf445402e25a2be9b51fff64d6c8a7e590f","head":{"label":"mcollina:double-destroy-callback","ref":"double-destroy-callback","sha":"17aebdf445402e25a2be9b51fff64d6c8a7e590f","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars3.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"repo":{"id":36234606,"name":"node","full_name":"mcollina/node","owner":{"login":"mcollina","id":52195,"avatar_url":"https://avatars3.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcollina/node","description":"My fork of node","fork":true,"url":"https://api.github.com/repos/mcollina/node","forks_url":"https://api.github.com/repos/mcollina/node/forks","keys_url":"https://api.github.com/repos/mcollina/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcollina/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcollina/node/teams","hooks_url":"https://api.github.com/repos/mcollina/node/hooks","issue_events_url":"https://api.github.com/repos/mcollina/node/issues/events{/number}","events_url":"https://api.github.com/repos/mcollina/node/events","assignees_url":"https://api.github.com/repos/mcollina/node/assignees{/user}","branches_url":"https://api.github.com/repos/mcollina/node/branches{/branch}","tags_url":"https://api.github.com/repos/mcollina/node/tags","blobs_url":"https://api.github.com/repos/mcollina/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcollina/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcollina/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcollina/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcollina/node/statuses/{sha}","languages_url":"https://api.github.com/repos/mcollina/node/languages","stargazers_url":"https://api.github.com/repos/mcollina/node/stargazers","contributors_url":"https://api.github.com/repos/mcollina/node/contributors","subscribers_url":"https://api.github.com/repos/mcollina/node/subscribers","subscription_url":"https://api.github.com/repos/mcollina/node/subscription","commits_url":"https://api.github.com/repos/mcollina/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcollina/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcollina/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcollina/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcollina/node/contents/{+path}","compare_url":"https://api.github.com/repos/mcollina/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcollina/node/merges","archive_url":"https://api.github.com/repos/mcollina/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcollina/node/downloads","issues_url":"https://api.github.com/repos/mcollina/node/issues{/number}","pulls_url":"https://api.github.com/repos/mcollina/node/pulls{/number}","milestones_url":"https://api.github.com/repos/mcollina/node/milestones{/number}","notifications_url":"https://api.github.com/repos/mcollina/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcollina/node/labels{/name}","releases_url":"https://api.github.com/repos/mcollina/node/releases{/id}","deployments_url":"https://api.github.com/repos/mcollina/node/deployments","created_at":"2015-05-25T14:06:50Z","updated_at":"2016-10-28T06:21:48Z","pushed_at":"2017-05-22T16:53:19Z","git_url":"git://github.com/mcollina/node.git","ssh_url":"git@github.com:mcollina/node.git","clone_url":"https://github.com/mcollina/node.git","svn_url":"https://github.com/mcollina/node","homepage":"","size":267683,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"06f62eb384f4f823bd224165c224da08d7dec0ab","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-05-22T16:45:37Z","pushed_at":"2017-05-22T16:53:22Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":287980,"stargazers_count":35106,"watchers_count":35106,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6736,"mirror_url":null,"open_issues_count":1054,"forks":6736,"open_issues":1054,"watchers":35106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/13156"},"html":{"href":"https://github.com/nodejs/node/pull/13156"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/13156"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/13156/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/13156/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/13156/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/17aebdf445402e25a2be9b51fff64d6c8a7e590f"}}}}
{"actor":{"display_login":"mcollina"}}