{"action":"created","comment":{"url":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/comments/143793644","pull_request_review_id":68355584,"id":143793644,"diff_hunk":"@@ -0,0 +1,21 @@\n+<?php\n+\n+namespace Drupal\\commerce_recurring\\Plugin\\Commerce\\SubscriptionType;\n+\n+/**\n+ * @CommerceSubscriptionType(\n+ *   id = \"license\",\n+ *   label = @translation(\"License\"),\n+ * )\n+ */\n+class License extends SubscriptionTypeBase {\n+\n+  /**\n+   * {@inheritdoc}\n+   */\n+  public function buildFieldDefinitions() {","path":"src/Plugin/Commerce/SubscriptionType/License.php","position":16,"original_position":16,"commit_id":"ae5d7f4f942f2bdcf099a51750a9926cead7d2a5","original_commit_id":"ae5d7f4f942f2bdcf099a51750a9926cead7d2a5","user":{"login":"bojanz","id":330162,"avatar_url":"https://avatars0.githubusercontent.com/u/330162?v=4","gravatar_id":"","url":"https://api.github.com/users/bojanz","html_url":"https://github.com/bojanz","followers_url":"https://api.github.com/users/bojanz/followers","following_url":"https://api.github.com/users/bojanz/following{/other_user}","gists_url":"https://api.github.com/users/bojanz/gists{/gist_id}","starred_url":"https://api.github.com/users/bojanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bojanz/subscriptions","organizations_url":"https://api.github.com/users/bojanz/orgs","repos_url":"https://api.github.com/users/bojanz/repos","events_url":"https://api.github.com/users/bojanz/events{/privacy}","received_events_url":"https://api.github.com/users/bojanz/received_events","type":"User","site_admin":false},"body":"Shouldn't we put buildFieldDefinitions() on the base class, to allow plugins to skip defining fields?","created_at":"2017-10-10T17:13:35Z","updated_at":"2017-10-10T17:15:19Z","html_url":"https://github.com/bojanz/commerce_recurring/pull/17#discussion_r143793644","pull_request_url":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/17","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/comments/143793644"},"html":{"href":"https://github.com/bojanz/commerce_recurring/pull/17#discussion_r143793644"},"pull_request":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/17","id":145748090,"html_url":"https://github.com/bojanz/commerce_recurring/pull/17","diff_url":"https://github.com/bojanz/commerce_recurring/pull/17.diff","patch_url":"https://github.com/bojanz/commerce_recurring/pull/17.patch","issue_url":"https://api.github.com/repos/bojanz/commerce_recurring/issues/17","number":17,"state":"open","locked":false,"title":"Initial subscription entity + bundle type","user":{"login":"dawehner","id":29678,"avatar_url":"https://avatars0.githubusercontent.com/u/29678?v=4","gravatar_id":"","url":"https://api.github.com/users/dawehner","html_url":"https://github.com/dawehner","followers_url":"https://api.github.com/users/dawehner/followers","following_url":"https://api.github.com/users/dawehner/following{/other_user}","gists_url":"https://api.github.com/users/dawehner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawehner/subscriptions","organizations_url":"https://api.github.com/users/dawehner/orgs","repos_url":"https://api.github.com/users/dawehner/repos","events_url":"https://api.github.com/users/dawehner/events{/privacy}","received_events_url":"https://api.github.com/users/dawehner/received_events","type":"User","site_admin":false},"body":"* [x] Should be reviewed\n* [ ] Should be merged\n\n* [x] Adds the subscription entity type\n* [x] Adds the subscription bundle plugin\n* [x] Adds the subscription CRUD UI\n* [x] Tests\n* [ ] Figure out what is needed as subscription type\n* [ ] Implement any concrete subscription type","created_at":"2017-10-10T16:58:57Z","updated_at":"2017-10-10T17:15:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2de514b844123b73332fab10a1eecc65a7c872ae","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/17/commits","review_comments_url":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/17/comments","review_comment_url":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bojanz/commerce_recurring/issues/17/comments","statuses_url":"https://api.github.com/repos/bojanz/commerce_recurring/statuses/ae5d7f4f942f2bdcf099a51750a9926cead7d2a5","head":{"label":"dawehner:subscription","ref":"subscription","sha":"ae5d7f4f942f2bdcf099a51750a9926cead7d2a5","user":{"login":"dawehner","id":29678,"avatar_url":"https://avatars0.githubusercontent.com/u/29678?v=4","gravatar_id":"","url":"https://api.github.com/users/dawehner","html_url":"https://github.com/dawehner","followers_url":"https://api.github.com/users/dawehner/followers","following_url":"https://api.github.com/users/dawehner/following{/other_user}","gists_url":"https://api.github.com/users/dawehner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawehner/subscriptions","organizations_url":"https://api.github.com/users/dawehner/orgs","repos_url":"https://api.github.com/users/dawehner/repos","events_url":"https://api.github.com/users/dawehner/events{/privacy}","received_events_url":"https://api.github.com/users/dawehner/received_events","type":"User","site_admin":false},"repo":{"id":106017472,"name":"commerce_recurring","full_name":"dawehner/commerce_recurring","owner":{"login":"dawehner","id":29678,"avatar_url":"https://avatars0.githubusercontent.com/u/29678?v=4","gravatar_id":"","url":"https://api.github.com/users/dawehner","html_url":"https://github.com/dawehner","followers_url":"https://api.github.com/users/dawehner/followers","following_url":"https://api.github.com/users/dawehner/following{/other_user}","gists_url":"https://api.github.com/users/dawehner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawehner/subscriptions","organizations_url":"https://api.github.com/users/dawehner/orgs","repos_url":"https://api.github.com/users/dawehner/repos","events_url":"https://api.github.com/users/dawehner/events{/privacy}","received_events_url":"https://api.github.com/users/dawehner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dawehner/commerce_recurring","description":null,"fork":true,"url":"https://api.github.com/repos/dawehner/commerce_recurring","forks_url":"https://api.github.com/repos/dawehner/commerce_recurring/forks","keys_url":"https://api.github.com/repos/dawehner/commerce_recurring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dawehner/commerce_recurring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dawehner/commerce_recurring/teams","hooks_url":"https://api.github.com/repos/dawehner/commerce_recurring/hooks","issue_events_url":"https://api.github.com/repos/dawehner/commerce_recurring/issues/events{/number}","events_url":"https://api.github.com/repos/dawehner/commerce_recurring/events","assignees_url":"https://api.github.com/repos/dawehner/commerce_recurring/assignees{/user}","branches_url":"https://api.github.com/repos/dawehner/commerce_recurring/branches{/branch}","tags_url":"https://api.github.com/repos/dawehner/commerce_recurring/tags","blobs_url":"https://api.github.com/repos/dawehner/commerce_recurring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dawehner/commerce_recurring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dawehner/commerce_recurring/git/refs{/sha}","trees_url":"https://api.github.com/repos/dawehner/commerce_recurring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dawehner/commerce_recurring/statuses/{sha}","languages_url":"https://api.github.com/repos/dawehner/commerce_recurring/languages","stargazers_url":"https://api.github.com/repos/dawehner/commerce_recurring/stargazers","contributors_url":"https://api.github.com/repos/dawehner/commerce_recurring/contributors","subscribers_url":"https://api.github.com/repos/dawehner/commerce_recurring/subscribers","subscription_url":"https://api.github.com/repos/dawehner/commerce_recurring/subscription","commits_url":"https://api.github.com/repos/dawehner/commerce_recurring/commits{/sha}","git_commits_url":"https://api.github.com/repos/dawehner/commerce_recurring/git/commits{/sha}","comments_url":"https://api.github.com/repos/dawehner/commerce_recurring/comments{/number}","issue_comment_url":"https://api.github.com/repos/dawehner/commerce_recurring/issues/comments{/number}","contents_url":"https://api.github.com/repos/dawehner/commerce_recurring/contents/{+path}","compare_url":"https://api.github.com/repos/dawehner/commerce_recurring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dawehner/commerce_recurring/merges","archive_url":"https://api.github.com/repos/dawehner/commerce_recurring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dawehner/commerce_recurring/downloads","issues_url":"https://api.github.com/repos/dawehner/commerce_recurring/issues{/number}","pulls_url":"https://api.github.com/repos/dawehner/commerce_recurring/pulls{/number}","milestones_url":"https://api.github.com/repos/dawehner/commerce_recurring/milestones{/number}","notifications_url":"https://api.github.com/repos/dawehner/commerce_recurring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dawehner/commerce_recurring/labels{/name}","releases_url":"https://api.github.com/repos/dawehner/commerce_recurring/releases{/id}","deployments_url":"https://api.github.com/repos/dawehner/commerce_recurring/deployments","created_at":"2017-10-06T14:59:44Z","updated_at":"2017-10-06T14:59:46Z","pushed_at":"2017-10-10T16:57:32Z","git_url":"git://github.com/dawehner/commerce_recurring.git","ssh_url":"git@github.com:dawehner/commerce_recurring.git","clone_url":"https://github.com/dawehner/commerce_recurring.git","svn_url":"https://github.com/dawehner/commerce_recurring","homepage":null,"size":84,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-2.x"}},"base":{"label":"bojanz:8.x-2.x","ref":"8.x-2.x","sha":"6ea4bff10056b578f929d7331cecd549b420eb4e","user":{"login":"bojanz","id":330162,"avatar_url":"https://avatars0.githubusercontent.com/u/330162?v=4","gravatar_id":"","url":"https://api.github.com/users/bojanz","html_url":"https://github.com/bojanz","followers_url":"https://api.github.com/users/bojanz/followers","following_url":"https://api.github.com/users/bojanz/following{/other_user}","gists_url":"https://api.github.com/users/bojanz/gists{/gist_id}","starred_url":"https://api.github.com/users/bojanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bojanz/subscriptions","organizations_url":"https://api.github.com/users/bojanz/orgs","repos_url":"https://api.github.com/users/bojanz/repos","events_url":"https://api.github.com/users/bojanz/events{/privacy}","received_events_url":"https://api.github.com/users/bojanz/received_events","type":"User","site_admin":false},"repo":{"id":105137135,"name":"commerce_recurring","full_name":"bojanz/commerce_recurring","owner":{"login":"bojanz","id":330162,"avatar_url":"https://avatars0.githubusercontent.com/u/330162?v=4","gravatar_id":"","url":"https://api.github.com/users/bojanz","html_url":"https://github.com/bojanz","followers_url":"https://api.github.com/users/bojanz/followers","following_url":"https://api.github.com/users/bojanz/following{/other_user}","gists_url":"https://api.github.com/users/bojanz/gists{/gist_id}","starred_url":"https://api.github.com/users/bojanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bojanz/subscriptions","organizations_url":"https://api.github.com/users/bojanz/orgs","repos_url":"https://api.github.com/users/bojanz/repos","events_url":"https://api.github.com/users/bojanz/events{/privacy}","received_events_url":"https://api.github.com/users/bojanz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bojanz/commerce_recurring","description":null,"fork":false,"url":"https://api.github.com/repos/bojanz/commerce_recurring","forks_url":"https://api.github.com/repos/bojanz/commerce_recurring/forks","keys_url":"https://api.github.com/repos/bojanz/commerce_recurring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bojanz/commerce_recurring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bojanz/commerce_recurring/teams","hooks_url":"https://api.github.com/repos/bojanz/commerce_recurring/hooks","issue_events_url":"https://api.github.com/repos/bojanz/commerce_recurring/issues/events{/number}","events_url":"https://api.github.com/repos/bojanz/commerce_recurring/events","assignees_url":"https://api.github.com/repos/bojanz/commerce_recurring/assignees{/user}","branches_url":"https://api.github.com/repos/bojanz/commerce_recurring/branches{/branch}","tags_url":"https://api.github.com/repos/bojanz/commerce_recurring/tags","blobs_url":"https://api.github.com/repos/bojanz/commerce_recurring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bojanz/commerce_recurring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bojanz/commerce_recurring/git/refs{/sha}","trees_url":"https://api.github.com/repos/bojanz/commerce_recurring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bojanz/commerce_recurring/statuses/{sha}","languages_url":"https://api.github.com/repos/bojanz/commerce_recurring/languages","stargazers_url":"https://api.github.com/repos/bojanz/commerce_recurring/stargazers","contributors_url":"https://api.github.com/repos/bojanz/commerce_recurring/contributors","subscribers_url":"https://api.github.com/repos/bojanz/commerce_recurring/subscribers","subscription_url":"https://api.github.com/repos/bojanz/commerce_recurring/subscription","commits_url":"https://api.github.com/repos/bojanz/commerce_recurring/commits{/sha}","git_commits_url":"https://api.github.com/repos/bojanz/commerce_recurring/git/commits{/sha}","comments_url":"https://api.github.com/repos/bojanz/commerce_recurring/comments{/number}","issue_comment_url":"https://api.github.com/repos/bojanz/commerce_recurring/issues/comments{/number}","contents_url":"https://api.github.com/repos/bojanz/commerce_recurring/contents/{+path}","compare_url":"https://api.github.com/repos/bojanz/commerce_recurring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bojanz/commerce_recurring/merges","archive_url":"https://api.github.com/repos/bojanz/commerce_recurring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bojanz/commerce_recurring/downloads","issues_url":"https://api.github.com/repos/bojanz/commerce_recurring/issues{/number}","pulls_url":"https://api.github.com/repos/bojanz/commerce_recurring/pulls{/number}","milestones_url":"https://api.github.com/repos/bojanz/commerce_recurring/milestones{/number}","notifications_url":"https://api.github.com/repos/bojanz/commerce_recurring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bojanz/commerce_recurring/labels{/name}","releases_url":"https://api.github.com/repos/bojanz/commerce_recurring/releases{/id}","deployments_url":"https://api.github.com/repos/bojanz/commerce_recurring/deployments","created_at":"2017-09-28T10:52:36Z","updated_at":"2017-10-02T00:10:53Z","pushed_at":"2017-10-10T16:58:58Z","git_url":"git://github.com/bojanz/commerce_recurring.git","ssh_url":"git@github.com:bojanz/commerce_recurring.git","clone_url":"https://github.com/bojanz/commerce_recurring.git","svn_url":"https://github.com/bojanz/commerce_recurring","homepage":null,"size":78,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":0,"default_branch":"8.x-2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/17"},"html":{"href":"https://github.com/bojanz/commerce_recurring/pull/17"},"issue":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/issues/17"},"comments":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/bojanz/commerce_recurring/statuses/ae5d7f4f942f2bdcf099a51750a9926cead7d2a5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bojanz"}}