{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/comments/125145324","pull_request_review_id":47512709,"id":125145324,"diff_hunk":"@@ -29,12 +29,12 @@\n });\n \n $app->post('/logging_standard', function (Request $request) {\n-    $logName = $request->get('log_name');\n-    $token = $request->get('token');\n+    $logName = $request->request->get('log_name');","path":"testapps/integration/web/index.php","position":6,"original_position":6,"commit_id":"073566011666c0d4ebafeccd70d0480257d88366","original_commit_id":"073566011666c0d4ebafeccd70d0480257d88366","user":{"login":"nkubala","id":5531168,"avatar_url":"https://avatars1.githubusercontent.com/u/5531168?v=3","gravatar_id":"","url":"https://api.github.com/users/nkubala","html_url":"https://github.com/nkubala","followers_url":"https://api.github.com/users/nkubala/followers","following_url":"https://api.github.com/users/nkubala/following{/other_user}","gists_url":"https://api.github.com/users/nkubala/gists{/gist_id}","starred_url":"https://api.github.com/users/nkubala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkubala/subscriptions","organizations_url":"https://api.github.com/users/nkubala/orgs","repos_url":"https://api.github.com/users/nkubala/repos","events_url":"https://api.github.com/users/nkubala/events{/privacy}","received_events_url":"https://api.github.com/users/nkubala/received_events","type":"User","site_admin":false},"body":"Ahh, sorry this is confusing. The `logging_standard` test doesn't make use of this field at all, even though it is actually provided by the client. I just combined the payloads of the two tests to simplify client code a bit. The standard logging tests should just be using the language's standard logging module to write the log entry, without specifying a name. Not all languages have this feature (not sure if PHP does; in python this is accomplished by simply doing `logging.info(token)`, for level `INFO`); if PHP doesn't have this, feel free to opt out of this test.","created_at":"2017-06-30T23:14:25Z","updated_at":"2017-06-30T23:14:25Z","html_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/324#discussion_r125145324","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/324","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/comments/125145324"},"html":{"href":"https://github.com/GoogleCloudPlatform/php-docker/pull/324#discussion_r125145324"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/324"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/324","id":128458569,"html_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/324","diff_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/324.diff","patch_url":"https://github.com/GoogleCloudPlatform/php-docker/pull/324.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/324","number":324,"state":"open","locked":false,"title":"Integration test fix","user":{"login":"tmatsuo","id":41815,"avatar_url":"https://avatars1.githubusercontent.com/u/41815?v=3","gravatar_id":"","url":"https://api.github.com/users/tmatsuo","html_url":"https://github.com/tmatsuo","followers_url":"https://api.github.com/users/tmatsuo/followers","following_url":"https://api.github.com/users/tmatsuo/following{/other_user}","gists_url":"https://api.github.com/users/tmatsuo/gists{/gist_id}","starred_url":"https://api.github.com/users/tmatsuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmatsuo/subscriptions","organizations_url":"https://api.github.com/users/tmatsuo/orgs","repos_url":"https://api.github.com/users/tmatsuo/repos","events_url":"https://api.github.com/users/tmatsuo/events{/privacy}","received_events_url":"https://api.github.com/users/tmatsuo/received_events","type":"User","site_admin":false},"body":"This needs `google/cloud` 0.33 release","created_at":"2017-06-30T22:07:28Z","updated_at":"2017-06-30T23:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af836d9d5268061335cfad8fefa614f5bee9d02c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/324/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/324/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/324/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/statuses/073566011666c0d4ebafeccd70d0480257d88366","head":{"label":"GoogleCloudPlatform:integration-test-fix","ref":"integration-test-fix","sha":"073566011666c0d4ebafeccd70d0480257d88366","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":45948472,"name":"php-docker","full_name":"GoogleCloudPlatform/php-docker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/php-docker","description":"Docker images for running PHP applications on the App Engine Flexible Runtime","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/deployments","created_at":"2015-11-10T23:57:21Z","updated_at":"2017-06-29T13:12:46Z","pushed_at":"2017-06-30T22:07:29Z","git_url":"git://github.com/GoogleCloudPlatform/php-docker.git","ssh_url":"git@github.com:GoogleCloudPlatform/php-docker.git","clone_url":"https://github.com/GoogleCloudPlatform/php-docker.git","svn_url":"https://github.com/GoogleCloudPlatform/php-docker","homepage":"","size":666,"stargazers_count":74,"watchers_count":74,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":12,"forks":27,"open_issues":12,"watchers":74,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"3e11d8eb0dd00c6d83532399c8a5af259f135185","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":45948472,"name":"php-docker","full_name":"GoogleCloudPlatform/php-docker","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/php-docker","description":"Docker images for running PHP applications on the App Engine Flexible Runtime","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/deployments","created_at":"2015-11-10T23:57:21Z","updated_at":"2017-06-29T13:12:46Z","pushed_at":"2017-06-30T22:07:29Z","git_url":"git://github.com/GoogleCloudPlatform/php-docker.git","ssh_url":"git@github.com:GoogleCloudPlatform/php-docker.git","clone_url":"https://github.com/GoogleCloudPlatform/php-docker.git","svn_url":"https://github.com/GoogleCloudPlatform/php-docker","homepage":"","size":666,"stargazers_count":74,"watchers_count":74,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":12,"forks":27,"open_issues":12,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/324"},"html":{"href":"https://github.com/GoogleCloudPlatform/php-docker/pull/324"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/324"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/issues/324/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/324/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/pulls/324/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/php-docker/statuses/073566011666c0d4ebafeccd70d0480257d88366"}}}}
{"actor":{"display_login":"nkubala"}}