{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/153512032","pull_request_review_id":79526888,"id":153512032,"diff_hunk":"@@ -1,32 +1,37 @@\n ========\n JMXFetch\n ========\n-{{- with .JMXStatus -}}\n-{{- if and (not .timestamp) (not .checks)}}\n-no JMX status available\n-{{- else }}\n-    initialized checks:\n-{{- range $check,$instances := .checks.initialized_checks }}\n-        {{ $check -}}\n-{{- range $instance := $instances }}\n-{{- range $k,$v := $instance }}\n-            {{ $k }} : {{ $v }}\n-{{- end -}}\n-{{- end -}}\n+{{ with .JMXStatus }}\n+  {{- if and (not .timestamp) (not .checks) }}\n+  no JMX status available\n+  {{- else }}\n+  Initialized checks:\n+  ===================","path":"pkg/status/dist/templates/jmxfetch.tmpl","position":21,"original_position":21,"commit_id":"b8c45e5e2893c93924b253ec460df58b1f4a34e9","original_commit_id":"b8c45e5e2893c93924b253ec460df58b1f4a34e9","user":{"login":"ISauve","id":11351618,"avatar_url":"https://avatars3.githubusercontent.com/u/11351618?v=4","gravatar_id":"","url":"https://api.github.com/users/ISauve","html_url":"https://github.com/ISauve","followers_url":"https://api.github.com/users/ISauve/followers","following_url":"https://api.github.com/users/ISauve/following{/other_user}","gists_url":"https://api.github.com/users/ISauve/gists{/gist_id}","starred_url":"https://api.github.com/users/ISauve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ISauve/subscriptions","organizations_url":"https://api.github.com/users/ISauve/orgs","repos_url":"https://api.github.com/users/ISauve/repos","events_url":"https://api.github.com/users/ISauve/events{/privacy}","received_events_url":"https://api.github.com/users/ISauve/received_events","type":"User","site_admin":false},"body":"Smallest nit ever, do you think you could take off the \":\" here? For consistency 😁","created_at":"2017-11-28T14:45:50Z","updated_at":"2017-11-28T14:56:42Z","html_url":"https://github.com/DataDog/datadog-agent/pull/869#discussion_r153512032","pull_request_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/869","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/153512032"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/869#discussion_r153512032"},"pull_request":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/869"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/869","id":155082430,"html_url":"https://github.com/DataDog/datadog-agent/pull/869","diff_url":"https://github.com/DataDog/datadog-agent/pull/869.diff","patch_url":"https://github.com/DataDog/datadog-agent/pull/869.patch","issue_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/869","number":869,"state":"open","locked":false,"title":"Fix status page output","user":{"login":"masci","id":7241,"avatar_url":"https://avatars3.githubusercontent.com/u/7241?v=4","gravatar_id":"","url":"https://api.github.com/users/masci","html_url":"https://github.com/masci","followers_url":"https://api.github.com/users/masci/followers","following_url":"https://api.github.com/users/masci/following{/other_user}","gists_url":"https://api.github.com/users/masci/gists{/gist_id}","starred_url":"https://api.github.com/users/masci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masci/subscriptions","organizations_url":"https://api.github.com/users/masci/orgs","repos_url":"https://api.github.com/users/masci/repos","events_url":"https://api.github.com/users/masci/events{/privacy}","received_events_url":"https://api.github.com/users/masci/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nFix status page cosmetics and reformat code for better readability.\r\n\r\n### Motivation\r\n\r\nBefore:\r\n```\r\n      Service Checks: 0, Total Service Checks: 0\r\n========\r\nJMXFetch\r\n========\r\n    initialized checks:\r\n\r\n    failed checks:\r\n        no failed checks\r\n=========\r\nForwarder\r\n=========\r\n  CheckRunsV1: 5\r\n  Dropped: 12\r\n  IntakeV1: 2\r\n  RetryQueueSize: 0\r\n  Success: 0\r\n  TimeseriesV1: 5\r\n\r\n  API Keys status\r\n  ---------------\r\n    https://6-0-0-app.agent.datadoghq.com,*************************32346: API Key invalid\r\n=========\r\nDogStatsD\r\n=========\r\n  Checks Metric Sample: 986\r\n  Event: 1\r\n  Events Flushed: 1\r\n  Number Of Flushes: 5\r\n  Series Flushed: 464\r\n  Service Check: 56\r\n  Service Checks Flushed: 50\r\n  Dogstatsd Metric Sample: 96\r\n```\r\n\r\nAfter:\r\n```\r\n        No module named process_agent\r\n        \r\n========\r\nJMXFetch\r\n========\r\n\r\n  Initialized checks:\r\n  ===================\r\n    no checks initialized\r\n    \r\n  Failed checks:\r\n  ==============\r\n    no failed checks\r\n    \r\n=========\r\nForwarder\r\n=========\r\n\r\n  RetryQueueSize: 0\r\n  Success: 0\r\n\r\n=========\r\nDogStatsD\r\n=========\r\n\r\n  Checks Metric Sample: 1\r\n  Event: 1\r\n  Service Check: 1\r\n```\r\n","created_at":"2017-11-28T14:15:50Z","updated_at":"2017-11-28T14:56:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bfb2c0a676e0b105bc2f812c3829eea15f7561b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/DataDog/datadog-agent/milestones/5","html_url":"https://github.com/DataDog/datadog-agent/milestone/5","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones/5/labels","id":2930911,"number":5,"title":"6.0.0-beta.5","description":null,"creator":{"login":"xvello","id":6241083,"avatar_url":"https://avatars2.githubusercontent.com/u/6241083?v=4","gravatar_id":"","url":"https://api.github.com/users/xvello","html_url":"https://github.com/xvello","followers_url":"https://api.github.com/users/xvello/followers","following_url":"https://api.github.com/users/xvello/following{/other_user}","gists_url":"https://api.github.com/users/xvello/gists{/gist_id}","starred_url":"https://api.github.com/users/xvello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xvello/subscriptions","organizations_url":"https://api.github.com/users/xvello/orgs","repos_url":"https://api.github.com/users/xvello/repos","events_url":"https://api.github.com/users/xvello/events{/privacy}","received_events_url":"https://api.github.com/users/xvello/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":16,"state":"open","created_at":"2017-11-22T12:04:32Z","updated_at":"2017-11-28T14:56:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/869/commits","review_comments_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/869/comments","review_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/869/comments","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/b8c45e5e2893c93924b253ec460df58b1f4a34e9","head":{"label":"DataDog:massi/status","ref":"massi/status","sha":"b8c45e5e2893c93924b253ec460df58b1f4a34e9","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2017-11-24T03:47:00Z","pushed_at":"2017-11-28T14:56:37Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":15134,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":34,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"ae48c75c5e1fad72aed0581ddf2d4379946bf416","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2017-11-24T03:47:00Z","pushed_at":"2017-11-28T14:56:37Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":15134,"stargazers_count":34,"watchers_count":34,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":5,"open_issues":25,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/869"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/869"},"issue":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/869"},"comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/869/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/869/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/869/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/datadog-agent/statuses/b8c45e5e2893c93924b253ec460df58b1f4a34e9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ISauve"}}