{"action":"created","issue":{"url":"https://api.github.com/repos/umpirsky/UmpirskyI18nRoutingBundle/issues/19","repository_url":"https://api.github.com/repos/umpirsky/UmpirskyI18nRoutingBundle","labels_url":"https://api.github.com/repos/umpirsky/UmpirskyI18nRoutingBundle/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/umpirsky/UmpirskyI18nRoutingBundle/issues/19/comments","events_url":"https://api.github.com/repos/umpirsky/UmpirskyI18nRoutingBundle/issues/19/events","html_url":"https://github.com/umpirsky/UmpirskyI18nRoutingBundle/issues/19","id":272959750,"number":19,"title":"Routing loader should implement the Symfony interface","user":{"login":"stof","id":439401,"avatar_url":"https://avatars0.githubusercontent.com/u/439401?v=4","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-10T15:01:49Z","updated_at":"2017-11-10T17:00:04Z","closed_at":null,"author_association":"NONE","body":"Currently, the I18nRouteLoader is implementing its own interface, with the same signature that the Symfony one (plus an explicit return type).\r\nAs the Symfony router receives the container to load the loader, things are working as there is no typehint to validate the type of the loader. But this could break in the future if Symfony refactors the way it lazy-loads the route loader.\r\n\r\nThe class should implement the Symfony interface instead."},"comment":{"url":"https://api.github.com/repos/umpirsky/UmpirskyI18nRoutingBundle/issues/comments/343528559","html_url":"https://github.com/umpirsky/UmpirskyI18nRoutingBundle/issues/19#issuecomment-343528559","issue_url":"https://api.github.com/repos/umpirsky/UmpirskyI18nRoutingBundle/issues/19","id":343528559,"user":{"login":"stof","id":439401,"avatar_url":"https://avatars0.githubusercontent.com/u/439401?v=4","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"created_at":"2017-11-10T17:00:04Z","updated_at":"2017-11-10T17:00:04Z","author_association":"NONE","body":"it should at least implement the interface"}}
{"actor":{"display_login":"stof"}}