{"action":"created","issue":{"url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/948","repository_url":"https://api.github.com/repos/pmmp/PocketMine-MP","labels_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/948/labels{/name}","comments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/948/comments","events_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/948/events","html_url":"https://github.com/pmmp/PocketMine-MP/pull/948","id":231791719,"number":948,"title":"Update core for PHP 7.1","user":{"login":"dktapps","id":14214667,"avatar_url":"https://avatars1.githubusercontent.com/u/14214667?v=3","gravatar_id":"","url":"https://api.github.com/users/dktapps","html_url":"https://github.com/dktapps","followers_url":"https://api.github.com/users/dktapps/followers","following_url":"https://api.github.com/users/dktapps/following{/other_user}","gists_url":"https://api.github.com/users/dktapps/gists{/gist_id}","starred_url":"https://api.github.com/users/dktapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dktapps/subscriptions","organizations_url":"https://api.github.com/users/dktapps/orgs","repos_url":"https://api.github.com/users/dktapps/repos","events_url":"https://api.github.com/users/dktapps/events{/privacy}","received_events_url":"https://api.github.com/users/dktapps/received_events","type":"User","site_admin":false},"labels":[{"id":454785701,"url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/Category:%20Core","name":"Category: Core","color":"00aa55","default":false},{"id":454787972,"url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/PR:%20Contribution","name":"PR: Contribution","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-27T10:10:27Z","updated_at":"2017-05-27T10:14:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/948","html_url":"https://github.com/pmmp/PocketMine-MP/pull/948","diff_url":"https://github.com/pmmp/PocketMine-MP/pull/948.diff","patch_url":"https://github.com/pmmp/PocketMine-MP/pull/948.patch"},"body":"## Introduction\r\nread the title\r\n\r\n## TODO\r\nfix Travis\r\n\r\n## Changes\r\n### API changes\r\nAlterations to `pocketmine\\Thread->start()` and `pocketmine\\Worker->start()` in accordance with pthreads 3.1.7-dev\r\n\r\n### Behavioural changes\r\nless performance because PHP 7.1 is distinctly slower than 7.0 for some reason.\r\n\r\n## Backwards compatibility\r\nThis is _not_ backwards-compatible with PHP 7.0, however most plugins won't be suffering breaking changes yet, at least until we start upgrading the core to use new features.\r\n\r\n## Follow-up\r\n- typehint all the things\r\n- nullable typehints and void return types\r\n"},"comment":{"url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/comments/304442904","html_url":"https://github.com/pmmp/PocketMine-MP/pull/948#issuecomment-304442904","issue_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/948","id":304442904,"user":{"login":"TheDiamondYT1","id":14148452,"avatar_url":"https://avatars1.githubusercontent.com/u/14148452?v=3","gravatar_id":"","url":"https://api.github.com/users/TheDiamondYT1","html_url":"https://github.com/TheDiamondYT1","followers_url":"https://api.github.com/users/TheDiamondYT1/followers","following_url":"https://api.github.com/users/TheDiamondYT1/following{/other_user}","gists_url":"https://api.github.com/users/TheDiamondYT1/gists{/gist_id}","starred_url":"https://api.github.com/users/TheDiamondYT1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheDiamondYT1/subscriptions","organizations_url":"https://api.github.com/users/TheDiamondYT1/orgs","repos_url":"https://api.github.com/users/TheDiamondYT1/repos","events_url":"https://api.github.com/users/TheDiamondYT1/events{/privacy}","received_events_url":"https://api.github.com/users/TheDiamondYT1/received_events","type":"User","site_admin":false},"created_at":"2017-05-27T10:14:47Z","updated_at":"2017-05-27T10:14:47Z","body":"If its slower, why use it?"}}
{"actor":{"display_login":"TheDiamondYT1"}}