{"action":"created","comment":{"url":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments/102235532","pull_request_review_id":22985637,"id":102235532,"diff_hunk":"@@ -371,31 +370,15 @@ def _log_avocado_datadir():\n         job_log.info('logs     ' + data_dir.get_logs_dir())\n         job_log.info('')\n \n-    def _log_variants_tree(self, variant):","path":"avocado/core/job.py","position":12,"original_position":12,"commit_id":"c6c2685eaa9ac1c5a10fa390fc94e8bb13b10b55","original_commit_id":"3cea23f8d8c66bbb171e59f4875e0ead75389407","user":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"body":"It was not a matter of difficulty of squashing commits.  Given the changes that were requested (which were pretty minor), it was a matter of changing the commits in a way that the review of the next version would be more difficult.\r\n\r\nAgain, the changes in a commit have to stand for themselves in the commit itself, and *also* in the context of the PR.","created_at":"2017-02-21T15:34:18Z","updated_at":"2017-02-21T15:34:18Z","html_url":"https://github.com/avocado-framework/avocado/pull/1763#discussion_r102235532","pull_request_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/1763","_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments/102235532"},"html":{"href":"https://github.com/avocado-framework/avocado/pull/1763#discussion_r102235532"},"pull_request":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/1763"}}},"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado/pulls/1763","id":105192107,"html_url":"https://github.com/avocado-framework/avocado/pull/1763","diff_url":"https://github.com/avocado-framework/avocado/pull/1763.diff","patch_url":"https://github.com/avocado-framework/avocado/pull/1763.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado/issues/1763","number":1763,"state":"open","locked":false,"title":"varianter: Make it properly pluggable [v2]","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"body":"This PR is inspired by https://github.com/avocado-framework/avocado/pull/1591 and is the next stage of https://github.com/avocado-framework/avocado/pull/1685 . First it adds necessary interfaces to the old `varianter`, then it makes the `varianter` pluggable in a dirty way and then it turns it into a proper plugin defined in `avocado.core.plugin_interfaces`. Along the way there are several fixes and enhancements and at the end there is the promised rewrite of the multiplexer documentation, which took me several days to put together and I hope it's understandable and clear enough.\r\n\r\nv1: https://github.com/avocado-framework/avocado/pull/1716\r\n\r\nChanges:\r\n\r\n```yaml\r\nv2: Just rebased to see whether the travis failures were false-negatives\r\n```","created_at":"2017-02-08T10:53:12Z","updated_at":"2017-02-21T15:34:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92d41478f9c66236ed535e1ba496cd1b890d6742","assignee":{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false},"assignees":[{"login":"clebergnu","id":447178,"avatar_url":"https://avatars.githubusercontent.com/u/447178?v=3","gravatar_id":"","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/1763/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/1763/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/issues/1763/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado/statuses/c6c2685eaa9ac1c5a10fa390fc94e8bb13b10b55","head":{"label":"ldoktor:mux-plugin2","ref":"mux-plugin2","sha":"c6c2685eaa9ac1c5a10fa390fc94e8bb13b10b55","user":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"repo":{"id":26808700,"name":"avocado","full_name":"ldoktor/avocado","owner":{"login":"ldoktor","id":1074021,"avatar_url":"https://avatars.githubusercontent.com/u/1074021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldoktor","html_url":"https://github.com/ldoktor","followers_url":"https://api.github.com/users/ldoktor/followers","following_url":"https://api.github.com/users/ldoktor/following{/other_user}","gists_url":"https://api.github.com/users/ldoktor/gists{/gist_id}","starred_url":"https://api.github.com/users/ldoktor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldoktor/subscriptions","organizations_url":"https://api.github.com/users/ldoktor/orgs","repos_url":"https://api.github.com/users/ldoktor/repos","events_url":"https://api.github.com/users/ldoktor/events{/privacy}","received_events_url":"https://api.github.com/users/ldoktor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldoktor/avocado","description":"Avocado Test Framework","fork":true,"url":"https://api.github.com/repos/ldoktor/avocado","forks_url":"https://api.github.com/repos/ldoktor/avocado/forks","keys_url":"https://api.github.com/repos/ldoktor/avocado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldoktor/avocado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldoktor/avocado/teams","hooks_url":"https://api.github.com/repos/ldoktor/avocado/hooks","issue_events_url":"https://api.github.com/repos/ldoktor/avocado/issues/events{/number}","events_url":"https://api.github.com/repos/ldoktor/avocado/events","assignees_url":"https://api.github.com/repos/ldoktor/avocado/assignees{/user}","branches_url":"https://api.github.com/repos/ldoktor/avocado/branches{/branch}","tags_url":"https://api.github.com/repos/ldoktor/avocado/tags","blobs_url":"https://api.github.com/repos/ldoktor/avocado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldoktor/avocado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldoktor/avocado/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldoktor/avocado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldoktor/avocado/statuses/{sha}","languages_url":"https://api.github.com/repos/ldoktor/avocado/languages","stargazers_url":"https://api.github.com/repos/ldoktor/avocado/stargazers","contributors_url":"https://api.github.com/repos/ldoktor/avocado/contributors","subscribers_url":"https://api.github.com/repos/ldoktor/avocado/subscribers","subscription_url":"https://api.github.com/repos/ldoktor/avocado/subscription","commits_url":"https://api.github.com/repos/ldoktor/avocado/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldoktor/avocado/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldoktor/avocado/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldoktor/avocado/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldoktor/avocado/contents/{+path}","compare_url":"https://api.github.com/repos/ldoktor/avocado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldoktor/avocado/merges","archive_url":"https://api.github.com/repos/ldoktor/avocado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldoktor/avocado/downloads","issues_url":"https://api.github.com/repos/ldoktor/avocado/issues{/number}","pulls_url":"https://api.github.com/repos/ldoktor/avocado/pulls{/number}","milestones_url":"https://api.github.com/repos/ldoktor/avocado/milestones{/number}","notifications_url":"https://api.github.com/repos/ldoktor/avocado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldoktor/avocado/labels{/name}","releases_url":"https://api.github.com/repos/ldoktor/avocado/releases{/id}","deployments_url":"https://api.github.com/repos/ldoktor/avocado/deployments","created_at":"2014-11-18T12:42:43Z","updated_at":"2014-11-18T12:42:43Z","pushed_at":"2017-02-21T15:04:32Z","git_url":"git://github.com/ldoktor/avocado.git","ssh_url":"git@github.com:ldoktor/avocado.git","clone_url":"https://github.com/ldoktor/avocado.git","svn_url":"https://github.com/ldoktor/avocado","homepage":"http://avocado-framework.readthedocs.org/en/latest/","size":10532,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"b0d7013a7e6f0765009d0b8ecaff1b569f2c4f73","user":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars.githubusercontent.com/u/7245719?v=3","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":17449498,"name":"avocado","full_name":"avocado-framework/avocado","owner":{"login":"avocado-framework","id":7245719,"avatar_url":"https://avatars.githubusercontent.com/u/7245719?v=3","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/avocado","description":"Avocado Test Framework","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado","forks_url":"https://api.github.com/repos/avocado-framework/avocado/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado/deployments","created_at":"2014-03-05T17:52:27Z","updated_at":"2017-02-18T10:12:54Z","pushed_at":"2017-02-21T15:06:00Z","git_url":"git://github.com/avocado-framework/avocado.git","ssh_url":"git@github.com:avocado-framework/avocado.git","clone_url":"https://github.com/avocado-framework/avocado.git","svn_url":"https://github.com/avocado-framework/avocado","homepage":"http://avocado-framework.github.io/","size":9985,"stargazers_count":80,"watchers_count":80,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":113,"mirror_url":null,"open_issues_count":18,"forks":113,"open_issues":18,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/1763"},"html":{"href":"https://github.com/avocado-framework/avocado/pull/1763"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado/issues/1763"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado/issues/1763/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/1763/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado/pulls/1763/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado/statuses/c6c2685eaa9ac1c5a10fa390fc94e8bb13b10b55"}}}}
{"actor":{"display_login":"clebergnu"}}