{"action":"opened","number":276,"pull_request":{"url":"https://api.github.com/repos/Kitware/kwiver/pulls/276","id":139398472,"html_url":"https://github.com/Kitware/kwiver/pull/276","diff_url":"https://github.com/Kitware/kwiver/pull/276.diff","patch_url":"https://github.com/Kitware/kwiver/pull/276.patch","issue_url":"https://api.github.com/repos/Kitware/kwiver/issues/276","number":276,"state":"open","locked":false,"title":"Don't return rotation quaternion by reference","user":{"login":"mwoehlke-kitware","id":6474409,"avatar_url":"https://avatars3.githubusercontent.com/u/6474409?v=4","gravatar_id":"","url":"https://api.github.com/users/mwoehlke-kitware","html_url":"https://github.com/mwoehlke-kitware","followers_url":"https://api.github.com/users/mwoehlke-kitware/followers","following_url":"https://api.github.com/users/mwoehlke-kitware/following{/other_user}","gists_url":"https://api.github.com/users/mwoehlke-kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/mwoehlke-kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwoehlke-kitware/subscriptions","organizations_url":"https://api.github.com/users/mwoehlke-kitware/orgs","repos_url":"https://api.github.com/users/mwoehlke-kitware/repos","events_url":"https://api.github.com/users/mwoehlke-kitware/events{/privacy}","received_events_url":"https://api.github.com/users/mwoehlke-kitware/received_events","type":"User","site_admin":false},"body":"Change `rotation::quaternion()` to return by value, rather than returning a reference to the internal data member. The latter is a subtle trap for anyone calling the method on a temporary object; if the caller also binds the return value to a reference, the resulting object will be invalidated before it can be used. (In particular, this was causing many of the VXL arrow tests to fail horribly because `arrows/vxl/camera.cxx` was running afoul of this!)\r\n\r\nThis is a backport of #270 to the release branch.","created_at":"2017-09-05T19:09:24Z","updated_at":"2017-09-05T19:09:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kitware/kwiver/pulls/276/commits","review_comments_url":"https://api.github.com/repos/Kitware/kwiver/pulls/276/comments","review_comment_url":"https://api.github.com/repos/Kitware/kwiver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kitware/kwiver/issues/276/comments","statuses_url":"https://api.github.com/repos/Kitware/kwiver/statuses/7f5cec1c4e411b20f534c8a415a9b5baa00b4230","head":{"label":"mwoehlke-kitware:dev/fix-ref-return-release","ref":"dev/fix-ref-return-release","sha":"7f5cec1c4e411b20f534c8a415a9b5baa00b4230","user":{"login":"mwoehlke-kitware","id":6474409,"avatar_url":"https://avatars3.githubusercontent.com/u/6474409?v=4","gravatar_id":"","url":"https://api.github.com/users/mwoehlke-kitware","html_url":"https://github.com/mwoehlke-kitware","followers_url":"https://api.github.com/users/mwoehlke-kitware/followers","following_url":"https://api.github.com/users/mwoehlke-kitware/following{/other_user}","gists_url":"https://api.github.com/users/mwoehlke-kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/mwoehlke-kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwoehlke-kitware/subscriptions","organizations_url":"https://api.github.com/users/mwoehlke-kitware/orgs","repos_url":"https://api.github.com/users/mwoehlke-kitware/repos","events_url":"https://api.github.com/users/mwoehlke-kitware/events{/privacy}","received_events_url":"https://api.github.com/users/mwoehlke-kitware/received_events","type":"User","site_admin":false},"repo":{"id":92326609,"name":"kwiver","full_name":"mwoehlke-kitware/kwiver","owner":{"login":"mwoehlke-kitware","id":6474409,"avatar_url":"https://avatars3.githubusercontent.com/u/6474409?v=4","gravatar_id":"","url":"https://api.github.com/users/mwoehlke-kitware","html_url":"https://github.com/mwoehlke-kitware","followers_url":"https://api.github.com/users/mwoehlke-kitware/followers","following_url":"https://api.github.com/users/mwoehlke-kitware/following{/other_user}","gists_url":"https://api.github.com/users/mwoehlke-kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/mwoehlke-kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwoehlke-kitware/subscriptions","organizations_url":"https://api.github.com/users/mwoehlke-kitware/orgs","repos_url":"https://api.github.com/users/mwoehlke-kitware/repos","events_url":"https://api.github.com/users/mwoehlke-kitware/events{/privacy}","received_events_url":"https://api.github.com/users/mwoehlke-kitware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwoehlke-kitware/kwiver","description":null,"fork":true,"url":"https://api.github.com/repos/mwoehlke-kitware/kwiver","forks_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/forks","keys_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/teams","hooks_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/hooks","issue_events_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/issues/events{/number}","events_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/events","assignees_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/assignees{/user}","branches_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/branches{/branch}","tags_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/tags","blobs_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/statuses/{sha}","languages_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/languages","stargazers_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/stargazers","contributors_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/contributors","subscribers_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/subscribers","subscription_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/subscription","commits_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/contents/{+path}","compare_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/merges","archive_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/downloads","issues_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/issues{/number}","pulls_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/pulls{/number}","milestones_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/milestones{/number}","notifications_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/labels{/name}","releases_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/releases{/id}","deployments_url":"https://api.github.com/repos/mwoehlke-kitware/kwiver/deployments","created_at":"2017-05-24T18:59:49Z","updated_at":"2017-05-24T18:59:59Z","pushed_at":"2017-09-05T19:08:13Z","git_url":"git://github.com/mwoehlke-kitware/kwiver.git","ssh_url":"git@github.com:mwoehlke-kitware/kwiver.git","clone_url":"https://github.com/mwoehlke-kitware/kwiver.git","svn_url":"https://github.com/mwoehlke-kitware/kwiver","homepage":null,"size":26688,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kitware:release","ref":"release","sha":"42ccccd063ba8be0a540c2d171b1a500b6436818","user":{"login":"Kitware","id":87549,"avatar_url":"https://avatars3.githubusercontent.com/u/87549?v=4","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"repo":{"id":23229909,"name":"kwiver","full_name":"Kitware/kwiver","owner":{"login":"Kitware","id":87549,"avatar_url":"https://avatars3.githubusercontent.com/u/87549?v=4","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kitware/kwiver","description":null,"fork":false,"url":"https://api.github.com/repos/Kitware/kwiver","forks_url":"https://api.github.com/repos/Kitware/kwiver/forks","keys_url":"https://api.github.com/repos/Kitware/kwiver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kitware/kwiver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kitware/kwiver/teams","hooks_url":"https://api.github.com/repos/Kitware/kwiver/hooks","issue_events_url":"https://api.github.com/repos/Kitware/kwiver/issues/events{/number}","events_url":"https://api.github.com/repos/Kitware/kwiver/events","assignees_url":"https://api.github.com/repos/Kitware/kwiver/assignees{/user}","branches_url":"https://api.github.com/repos/Kitware/kwiver/branches{/branch}","tags_url":"https://api.github.com/repos/Kitware/kwiver/tags","blobs_url":"https://api.github.com/repos/Kitware/kwiver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kitware/kwiver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kitware/kwiver/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kitware/kwiver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kitware/kwiver/statuses/{sha}","languages_url":"https://api.github.com/repos/Kitware/kwiver/languages","stargazers_url":"https://api.github.com/repos/Kitware/kwiver/stargazers","contributors_url":"https://api.github.com/repos/Kitware/kwiver/contributors","subscribers_url":"https://api.github.com/repos/Kitware/kwiver/subscribers","subscription_url":"https://api.github.com/repos/Kitware/kwiver/subscription","commits_url":"https://api.github.com/repos/Kitware/kwiver/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kitware/kwiver/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kitware/kwiver/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kitware/kwiver/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kitware/kwiver/contents/{+path}","compare_url":"https://api.github.com/repos/Kitware/kwiver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kitware/kwiver/merges","archive_url":"https://api.github.com/repos/Kitware/kwiver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kitware/kwiver/downloads","issues_url":"https://api.github.com/repos/Kitware/kwiver/issues{/number}","pulls_url":"https://api.github.com/repos/Kitware/kwiver/pulls{/number}","milestones_url":"https://api.github.com/repos/Kitware/kwiver/milestones{/number}","notifications_url":"https://api.github.com/repos/Kitware/kwiver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kitware/kwiver/labels{/name}","releases_url":"https://api.github.com/repos/Kitware/kwiver/releases{/id}","deployments_url":"https://api.github.com/repos/Kitware/kwiver/deployments","created_at":"2014-08-22T15:22:20Z","updated_at":"2017-08-17T02:29:05Z","pushed_at":"2017-09-05T18:31:54Z","git_url":"git://github.com/Kitware/kwiver.git","ssh_url":"git@github.com:Kitware/kwiver.git","clone_url":"https://github.com/Kitware/kwiver.git","svn_url":"https://github.com/Kitware/kwiver","homepage":null,"size":26996,"stargazers_count":51,"watchers_count":51,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":35,"forks":26,"open_issues":35,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kitware/kwiver/pulls/276"},"html":{"href":"https://github.com/Kitware/kwiver/pull/276"},"issue":{"href":"https://api.github.com/repos/Kitware/kwiver/issues/276"},"comments":{"href":"https://api.github.com/repos/Kitware/kwiver/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/Kitware/kwiver/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/Kitware/kwiver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kitware/kwiver/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/Kitware/kwiver/statuses/7f5cec1c4e411b20f534c8a415a9b5baa00b4230"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"mwoehlke-kitware"}}