{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/97556987","pull_request_review_id":18169329,"id":97556987,"diff_hunk":"@@ -171,9 +164,16 @@ public String toString() {\n                 + '}';\n     }\n \n+    DurableExecutorConfigReadOnly getAsReadOnly() {","path":"hazelcast/src/main/java/com/hazelcast/config/DurableExecutorConfig.java","position":18,"original_position":18,"commit_id":"aa7979700eeb69f81290c32646fe24a8f4ab27e5","original_commit_id":"aa7979700eeb69f81290c32646fe24a8f4ab27e5","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"private?","created_at":"2017-01-24T14:28:44Z","updated_at":"2017-01-24T14:28:44Z","html_url":"https://github.com/hazelcast/hazelcast/pull/9718#discussion_r97556987","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9718","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/97556987"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/9718#discussion_r97556987"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9718"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9718","id":102471711,"html_url":"https://github.com/hazelcast/hazelcast/pull/9718","diff_url":"https://github.com/hazelcast/hazelcast/pull/9718.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/9718.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9718","number":9718,"state":"open","locked":false,"title":"Deprecated getAsReadOnly() methods in configuration classes","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"* deprecated all `getAsReadOnly()` and `asReadOnly()` methods\r\n* made new `getAsReadOnly()` methods from 3.8 package private\r\n* moved package private methods down to the read-only class definition\r\n* moved `DurableExecutorConfigTest` to the config package","created_at":"2017-01-20T14:28:33Z","updated_at":"2017-01-24T14:28:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77649aeb269b2e16c76ae236955414d8ee0f8907","assignee":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"assignees":[{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76","html_url":"https://github.com/hazelcast/hazelcast/milestone/76","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/76/labels","id":1774122,"number":76,"title":"3.8","description":"","creator":{"login":"degerhz","id":8373100,"avatar_url":"https://avatars.githubusercontent.com/u/8373100?v=3","gravatar_id":"","url":"https://api.github.com/users/degerhz","html_url":"https://github.com/degerhz","followers_url":"https://api.github.com/users/degerhz/followers","following_url":"https://api.github.com/users/degerhz/following{/other_user}","gists_url":"https://api.github.com/users/degerhz/gists{/gist_id}","starred_url":"https://api.github.com/users/degerhz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degerhz/subscriptions","organizations_url":"https://api.github.com/users/degerhz/orgs","repos_url":"https://api.github.com/users/degerhz/repos","events_url":"https://api.github.com/users/degerhz/events{/privacy}","received_events_url":"https://api.github.com/users/degerhz/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":755,"state":"open","created_at":"2016-05-18T14:13:56Z","updated_at":"2017-01-24T14:27:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9718/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9718/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/9718/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/aa7979700eeb69f81290c32646fe24a8f4ab27e5","head":{"label":"Donnerbart:deprecateGetAsReadOnlyMethods","ref":"deprecateGetAsReadOnlyMethods","sha":"aa7979700eeb69f81290c32646fe24a8f4ab27e5","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"repo":{"id":13138412,"name":"hazelcast","full_name":"Donnerbart/hazelcast","owner":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Donnerbart/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/Donnerbart/hazelcast","forks_url":"https://api.github.com/repos/Donnerbart/hazelcast/forks","keys_url":"https://api.github.com/repos/Donnerbart/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Donnerbart/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Donnerbart/hazelcast/teams","hooks_url":"https://api.github.com/repos/Donnerbart/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/Donnerbart/hazelcast/events","assignees_url":"https://api.github.com/repos/Donnerbart/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/Donnerbart/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/Donnerbart/hazelcast/tags","blobs_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Donnerbart/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/Donnerbart/hazelcast/languages","stargazers_url":"https://api.github.com/repos/Donnerbart/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/Donnerbart/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/Donnerbart/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/Donnerbart/hazelcast/subscription","commits_url":"https://api.github.com/repos/Donnerbart/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/Donnerbart/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/Donnerbart/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/Donnerbart/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Donnerbart/hazelcast/merges","archive_url":"https://api.github.com/repos/Donnerbart/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Donnerbart/hazelcast/downloads","issues_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/Donnerbart/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/Donnerbart/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/Donnerbart/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Donnerbart/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/Donnerbart/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/Donnerbart/hazelcast/deployments","created_at":"2013-09-27T01:15:56Z","updated_at":"2015-05-08T12:56:05Z","pushed_at":"2017-01-20T14:44:38Z","git_url":"git://github.com/Donnerbart/hazelcast.git","ssh_url":"git@github.com:Donnerbart/hazelcast.git","clone_url":"https://github.com/Donnerbart/hazelcast.git","svn_url":"https://github.com/Donnerbart/hazelcast","homepage":"www.hazelcast.com","size":100985,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"99c2fd47c8afaea689af5a320aa2daf86ddb381e","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2017-01-24T07:14:20Z","pushed_at":"2017-01-24T14:28:20Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":102981,"stargazers_count":1888,"watchers_count":1888,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":854,"mirror_url":null,"open_issues_count":541,"forks":854,"open_issues":541,"watchers":1888,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9718"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/9718"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/9718"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/9718/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9718/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/9718/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/aa7979700eeb69f81290c32646fe24a8f4ab27e5"}}}}
{"actor":{"display_login":"pveentjer"}}