{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/150128801","pull_request_review_id":75635234,"id":150128801,"diff_hunk":"@@ -205,3 +205,8 @@ String getAssetBuildDirectory() {\n String getIosBuildDirectory() {\n   return fs.path.join(getBuildDirectory(), 'ios');\n }\n+\n+/// Returns directory used by incremental compiler to store cached artifacts.","path":"packages/flutter_tools/lib/src/build_info.dart","position":null,"original_position":5,"commit_id":"ccb5b53dff12075b7751bb7268e30697009297d8","original_commit_id":"fff28f3fe9cd66d60c476790d0a6cc190cd44eda","user":{"login":"aam","id":381137,"avatar_url":"https://avatars0.githubusercontent.com/u/381137?v=4","gravatar_id":"","url":"https://api.github.com/users/aam","html_url":"https://github.com/aam","followers_url":"https://api.github.com/users/aam/followers","following_url":"https://api.github.com/users/aam/following{/other_user}","gists_url":"https://api.github.com/users/aam/gists{/gist_id}","starred_url":"https://api.github.com/users/aam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam/subscriptions","organizations_url":"https://api.github.com/users/aam/orgs","repos_url":"https://api.github.com/users/aam/repos","events_url":"https://api.github.com/users/aam/events{/privacy}","received_events_url":"https://api.github.com/users/aam/received_events","type":"User","site_admin":false},"body":"Fixed the comment.","created_at":"2017-11-10T00:41:58Z","updated_at":"2017-11-10T00:41:58Z","html_url":"https://github.com/flutter/flutter/pull/12953#discussion_r150128801","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/12953","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/150128801"},"html":{"href":"https://github.com/flutter/flutter/pull/12953#discussion_r150128801"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/12953"}},"in_reply_to_id":150085676},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/12953","id":151757312,"html_url":"https://github.com/flutter/flutter/pull/12953","diff_url":"https://github.com/flutter/flutter/pull/12953.diff","patch_url":"https://github.com/flutter/flutter/pull/12953.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/12953","number":12953,"state":"open","locked":false,"title":"Use IKG for restarts, use IKG with ProtectedFileByteStore.","user":{"login":"aam","id":381137,"avatar_url":"https://avatars0.githubusercontent.com/u/381137?v=4","gravatar_id":"","url":"https://api.github.com/users/aam","html_url":"https://github.com/aam","followers_url":"https://api.github.com/users/aam/followers","following_url":"https://api.github.com/users/aam/following{/other_user}","gists_url":"https://api.github.com/users/aam/gists{/gist_id}","starred_url":"https://api.github.com/users/aam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam/subscriptions","organizations_url":"https://api.github.com/users/aam/orgs","repos_url":"https://api.github.com/users/aam/repos","events_url":"https://api.github.com/users/aam/events{/privacy}","received_events_url":"https://api.github.com/users/aam/received_events","type":"User","site_admin":false},"body":"With super mixin issue with IKG kernel files resolved, we can come back to using IKG for app restarts.\r\n\r\nAlso this PR switches on use of ProtectedFileByteStore for IKG, which should improve performance of incremental builds. Use of byte store is only enabled for debug builds('build flx') and hot runs('run'), not for aot builds('build aot'). This is because aot builds require `platform.dill` linked into resultant dill file, which IKG doesn't seem to support(yet? @scheglov @sigmundch)","created_at":"2017-11-09T20:42:16Z","updated_at":"2017-11-10T00:41:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fee9b1f07d96812e40ee426beaa3b7f81a4102ab","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/12953/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/12953/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/12953/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/ccb5b53dff12075b7751bb7268e30697009297d8","head":{"label":"aam:use-ikg-with-fbs-for-debug","ref":"use-ikg-with-fbs-for-debug","sha":"ccb5b53dff12075b7751bb7268e30697009297d8","user":{"login":"aam","id":381137,"avatar_url":"https://avatars0.githubusercontent.com/u/381137?v=4","gravatar_id":"","url":"https://api.github.com/users/aam","html_url":"https://github.com/aam","followers_url":"https://api.github.com/users/aam/followers","following_url":"https://api.github.com/users/aam/following{/other_user}","gists_url":"https://api.github.com/users/aam/gists{/gist_id}","starred_url":"https://api.github.com/users/aam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam/subscriptions","organizations_url":"https://api.github.com/users/aam/orgs","repos_url":"https://api.github.com/users/aam/repos","events_url":"https://api.github.com/users/aam/events{/privacy}","received_events_url":"https://api.github.com/users/aam/received_events","type":"User","site_admin":false},"repo":{"id":48006917,"name":"flutter","full_name":"aam/flutter","owner":{"login":"aam","id":381137,"avatar_url":"https://avatars0.githubusercontent.com/u/381137?v=4","gravatar_id":"","url":"https://api.github.com/users/aam","html_url":"https://github.com/aam","followers_url":"https://api.github.com/users/aam/followers","following_url":"https://api.github.com/users/aam/following{/other_user}","gists_url":"https://api.github.com/users/aam/gists{/gist_id}","starred_url":"https://api.github.com/users/aam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aam/subscriptions","organizations_url":"https://api.github.com/users/aam/orgs","repos_url":"https://api.github.com/users/aam/repos","events_url":"https://api.github.com/users/aam/events{/privacy}","received_events_url":"https://api.github.com/users/aam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aam/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":true,"url":"https://api.github.com/repos/aam/flutter","forks_url":"https://api.github.com/repos/aam/flutter/forks","keys_url":"https://api.github.com/repos/aam/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aam/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aam/flutter/teams","hooks_url":"https://api.github.com/repos/aam/flutter/hooks","issue_events_url":"https://api.github.com/repos/aam/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/aam/flutter/events","assignees_url":"https://api.github.com/repos/aam/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/aam/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/aam/flutter/tags","blobs_url":"https://api.github.com/repos/aam/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aam/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aam/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/aam/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aam/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/aam/flutter/languages","stargazers_url":"https://api.github.com/repos/aam/flutter/stargazers","contributors_url":"https://api.github.com/repos/aam/flutter/contributors","subscribers_url":"https://api.github.com/repos/aam/flutter/subscribers","subscription_url":"https://api.github.com/repos/aam/flutter/subscription","commits_url":"https://api.github.com/repos/aam/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/aam/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/aam/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/aam/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/aam/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/aam/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aam/flutter/merges","archive_url":"https://api.github.com/repos/aam/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aam/flutter/downloads","issues_url":"https://api.github.com/repos/aam/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/aam/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/aam/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/aam/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aam/flutter/labels{/name}","releases_url":"https://api.github.com/repos/aam/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/aam/flutter/deployments","created_at":"2015-12-14T23:14:18Z","updated_at":"2016-01-17T18:44:40Z","pushed_at":"2017-11-10T00:41:42Z","git_url":"git://github.com/aam/flutter.git","ssh_url":"git@github.com:aam/flutter.git","clone_url":"https://github.com/aam/flutter.git","svn_url":"https://github.com/aam/flutter","homepage":"http://flutter.io","size":31154,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"93c81ffc76ba3d67bc07ca7b603c22579ffe0171","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-11-10T00:34:46Z","pushed_at":"2017-11-10T00:41:43Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":31089,"stargazers_count":8295,"watchers_count":8295,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":775,"mirror_url":null,"archived":false,"open_issues_count":1961,"forks":775,"open_issues":1961,"watchers":8295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/12953"},"html":{"href":"https://github.com/flutter/flutter/pull/12953"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/12953"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/12953/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/12953/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/12953/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/ccb5b53dff12075b7751bb7268e30697009297d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aam"}}