{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments/111766241","pull_request_review_id":33030167,"id":111766241,"diff_hunk":"@@ -46,6 +46,13 @@ spec:\n     - --configure-cloud-routes=true\n     - --cluster-cidr={{ kube_pods_subnet }}\n {% endif %}\n+{% if controller_mgr_custom_flags is string %}\n+    - {{ controller_mgr_custom_flags }}\n+{% else % }","path":"roles/kubernetes/master/templates/manifests/kube-controller-manager.manifest.j2","position":6,"original_position":6,"commit_id":"04a769bb372b408c790725e23f5dbd0cf1599d7f","original_commit_id":"04a769bb372b408c790725e23f5dbd0cf1599d7f","user":{"login":"mattymo","id":1229061,"avatar_url":"https://avatars1.githubusercontent.com/u/1229061?v=3","gravatar_id":"","url":"https://api.github.com/users/mattymo","html_url":"https://github.com/mattymo","followers_url":"https://api.github.com/users/mattymo/followers","following_url":"https://api.github.com/users/mattymo/following{/other_user}","gists_url":"https://api.github.com/users/mattymo/gists{/gist_id}","starred_url":"https://api.github.com/users/mattymo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattymo/subscriptions","organizations_url":"https://api.github.com/users/mattymo/orgs","repos_url":"https://api.github.com/users/mattymo/repos","events_url":"https://api.github.com/users/mattymo/events{/privacy}","received_events_url":"https://api.github.com/users/mattymo/received_events","type":"User","site_admin":false},"body":"syntax error because of \"% }\" - remove the space","created_at":"2017-04-17T16:14:48Z","updated_at":"2017-04-17T16:14:48Z","html_url":"https://github.com/kubernetes-incubator/kargo/pull/1232#discussion_r111766241","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/1232","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments/111766241"},"html":{"href":"https://github.com/kubernetes-incubator/kargo/pull/1232#discussion_r111766241"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/1232"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/1232","id":115993635,"html_url":"https://github.com/kubernetes-incubator/kargo/pull/1232","diff_url":"https://github.com/kubernetes-incubator/kargo/pull/1232.diff","patch_url":"https://github.com/kubernetes-incubator/kargo/pull/1232.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/1232","number":1232,"state":"open","locked":false,"title":"add ability for custom flags","user":{"login":"rsmitty","id":1529818,"avatar_url":"https://avatars2.githubusercontent.com/u/1529818?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmitty","html_url":"https://github.com/rsmitty","followers_url":"https://api.github.com/users/rsmitty/followers","following_url":"https://api.github.com/users/rsmitty/following{/other_user}","gists_url":"https://api.github.com/users/rsmitty/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmitty/subscriptions","organizations_url":"https://api.github.com/users/rsmitty/orgs","repos_url":"https://api.github.com/users/rsmitty/repos","events_url":"https://api.github.com/users/rsmitty/events{/privacy}","received_events_url":"https://api.github.com/users/rsmitty/received_events","type":"User","site_admin":false},"body":"This addresses #899, as well as possibly addressing #1193. Would provide a good way to add flags that are more specific to a cluster's environment and size, but not useful for everyone.","created_at":"2017-04-14T21:39:48Z","updated_at":"2017-04-17T16:14:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b76f9bb17f4abbe28af052af4c890b9836607fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/1232/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/1232/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/1232/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/04a769bb372b408c790725e23f5dbd0cf1599d7f","head":{"label":"rsmitty:custom-flags","ref":"custom-flags","sha":"04a769bb372b408c790725e23f5dbd0cf1599d7f","user":{"login":"rsmitty","id":1529818,"avatar_url":"https://avatars2.githubusercontent.com/u/1529818?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmitty","html_url":"https://github.com/rsmitty","followers_url":"https://api.github.com/users/rsmitty/followers","following_url":"https://api.github.com/users/rsmitty/following{/other_user}","gists_url":"https://api.github.com/users/rsmitty/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmitty/subscriptions","organizations_url":"https://api.github.com/users/rsmitty/orgs","repos_url":"https://api.github.com/users/rsmitty/repos","events_url":"https://api.github.com/users/rsmitty/events{/privacy}","received_events_url":"https://api.github.com/users/rsmitty/received_events","type":"User","site_admin":false},"repo":{"id":76674591,"name":"kargo","full_name":"rsmitty/kargo","owner":{"login":"rsmitty","id":1529818,"avatar_url":"https://avatars2.githubusercontent.com/u/1529818?v=3","gravatar_id":"","url":"https://api.github.com/users/rsmitty","html_url":"https://github.com/rsmitty","followers_url":"https://api.github.com/users/rsmitty/followers","following_url":"https://api.github.com/users/rsmitty/following{/other_user}","gists_url":"https://api.github.com/users/rsmitty/gists{/gist_id}","starred_url":"https://api.github.com/users/rsmitty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsmitty/subscriptions","organizations_url":"https://api.github.com/users/rsmitty/orgs","repos_url":"https://api.github.com/users/rsmitty/repos","events_url":"https://api.github.com/users/rsmitty/events{/privacy}","received_events_url":"https://api.github.com/users/rsmitty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsmitty/kargo","description":"Setup a kubernetes cluster","fork":true,"url":"https://api.github.com/repos/rsmitty/kargo","forks_url":"https://api.github.com/repos/rsmitty/kargo/forks","keys_url":"https://api.github.com/repos/rsmitty/kargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsmitty/kargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsmitty/kargo/teams","hooks_url":"https://api.github.com/repos/rsmitty/kargo/hooks","issue_events_url":"https://api.github.com/repos/rsmitty/kargo/issues/events{/number}","events_url":"https://api.github.com/repos/rsmitty/kargo/events","assignees_url":"https://api.github.com/repos/rsmitty/kargo/assignees{/user}","branches_url":"https://api.github.com/repos/rsmitty/kargo/branches{/branch}","tags_url":"https://api.github.com/repos/rsmitty/kargo/tags","blobs_url":"https://api.github.com/repos/rsmitty/kargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsmitty/kargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsmitty/kargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsmitty/kargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsmitty/kargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rsmitty/kargo/languages","stargazers_url":"https://api.github.com/repos/rsmitty/kargo/stargazers","contributors_url":"https://api.github.com/repos/rsmitty/kargo/contributors","subscribers_url":"https://api.github.com/repos/rsmitty/kargo/subscribers","subscription_url":"https://api.github.com/repos/rsmitty/kargo/subscription","commits_url":"https://api.github.com/repos/rsmitty/kargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsmitty/kargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsmitty/kargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsmitty/kargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsmitty/kargo/contents/{+path}","compare_url":"https://api.github.com/repos/rsmitty/kargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsmitty/kargo/merges","archive_url":"https://api.github.com/repos/rsmitty/kargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsmitty/kargo/downloads","issues_url":"https://api.github.com/repos/rsmitty/kargo/issues{/number}","pulls_url":"https://api.github.com/repos/rsmitty/kargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rsmitty/kargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rsmitty/kargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsmitty/kargo/labels{/name}","releases_url":"https://api.github.com/repos/rsmitty/kargo/releases{/id}","deployments_url":"https://api.github.com/repos/rsmitty/kargo/deployments","created_at":"2016-12-16T18:01:40Z","updated_at":"2016-12-16T18:01:41Z","pushed_at":"2017-04-17T15:11:17Z","git_url":"git://github.com/rsmitty/kargo.git","ssh_url":"git@github.com:rsmitty/kargo.git","clone_url":"https://github.com/rsmitty/kargo.git","svn_url":"https://github.com/rsmitty/kargo","homepage":"","size":5503,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"5c4980c6e060f7d8added1d610f89bb5883d76d6","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":43613404,"name":"kargo","full_name":"kubernetes-incubator/kargo","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kargo","description":"Setup a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kargo","forks_url":"https://api.github.com/repos/kubernetes-incubator/kargo/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kargo/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kargo/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kargo/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kargo/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kargo/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kargo/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kargo/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kargo/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kargo/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kargo/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kargo/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kargo/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kargo/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kargo/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kargo/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kargo/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kargo/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kargo/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kargo/deployments","created_at":"2015-10-03T20:18:11Z","updated_at":"2017-04-17T16:10:55Z","pushed_at":"2017-04-17T15:11:18Z","git_url":"git://github.com/kubernetes-incubator/kargo.git","ssh_url":"git@github.com:kubernetes-incubator/kargo.git","clone_url":"https://github.com/kubernetes-incubator/kargo.git","svn_url":"https://github.com/kubernetes-incubator/kargo","homepage":"","size":5573,"stargazers_count":685,"watchers_count":685,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"open_issues_count":147,"forks":245,"open_issues":147,"watchers":685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/1232"},"html":{"href":"https://github.com/kubernetes-incubator/kargo/pull/1232"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/1232"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/issues/1232/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/1232/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/pulls/1232/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kargo/statuses/04a769bb372b408c790725e23f5dbd0cf1599d7f"}}}}
{"actor":{"display_login":"mattymo"}}