{"action":"created","comment":{"url":"https://api.github.com/repos/plotly/documentation/pulls/comments/143834396","pull_request_review_id":68405433,"id":143834396,"diff_hunk":"@@ -1,5 +1,5 @@\n ---\n-permalink: /products/dash/\n+permalink: /plot.ly/products/dash/","path":"_posts/python/fundamentals/2017-10-05-dash.html","position":null,"original_position":3,"commit_id":"ae0c437a559819476857c485d5d84549639638d4","original_commit_id":"cbff917f6e2b6223b79da075f814e7c2d7a16922","user":{"login":"chriddyp","id":1280389,"avatar_url":"https://avatars3.githubusercontent.com/u/1280389?v=4","gravatar_id":"","url":"https://api.github.com/users/chriddyp","html_url":"https://github.com/chriddyp","followers_url":"https://api.github.com/users/chriddyp/followers","following_url":"https://api.github.com/users/chriddyp/following{/other_user}","gists_url":"https://api.github.com/users/chriddyp/gists{/gist_id}","starred_url":"https://api.github.com/users/chriddyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriddyp/subscriptions","organizations_url":"https://api.github.com/users/chriddyp/orgs","repos_url":"https://api.github.com/users/chriddyp/repos","events_url":"https://api.github.com/users/chriddyp/events{/privacy}","received_events_url":"https://api.github.com/users/chriddyp/received_events","type":"User","site_admin":false},"body":"ah ok, that makes sense. I guess `{% if page.permalink contains 'http'` never worked then (or it only worked in old versions).\r\n\r\nWhat if instead we used `permalink: //plot.ly/dash/products` but we changed the logic to be:\r\n```\r\n{% if (page.permalink | slice: 0) == '//' %}\r\n    {{page.permalink}}\r\n{% else %}\r\n    /{{page.permalink}}\r\n{% endif %}\r\n```\r\n\r\nIf we _only_ change permalink to `//` without changing the logic then the link will end up being `///plot.ly/dash/products` which may work but isn't semanatically correct. This logic will keep it as `//plot.ly/dash/products` which is semantic.","created_at":"2017-10-10T19:53:05Z","updated_at":"2017-10-10T19:53:05Z","html_url":"https://github.com/plotly/documentation/pull/829#discussion_r143834396","pull_request_url":"https://api.github.com/repos/plotly/documentation/pulls/829","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/plotly/documentation/pulls/comments/143834396"},"html":{"href":"https://github.com/plotly/documentation/pull/829#discussion_r143834396"},"pull_request":{"href":"https://api.github.com/repos/plotly/documentation/pulls/829"}},"in_reply_to_id":143800029},"pull_request":{"url":"https://api.github.com/repos/plotly/documentation/pulls/829","id":145754248,"html_url":"https://github.com/plotly/documentation/pull/829","diff_url":"https://github.com/plotly/documentation/pull/829.diff","patch_url":"https://github.com/plotly/documentation/pull/829.patch","issue_url":"https://api.github.com/repos/plotly/documentation/issues/829","number":829,"state":"open","locked":false,"title":"fixed dash links in plotly/python","user":{"login":"Kully","id":10369095,"avatar_url":"https://avatars1.githubusercontent.com/u/10369095?v=4","gravatar_id":"","url":"https://api.github.com/users/Kully","html_url":"https://github.com/Kully","followers_url":"https://api.github.com/users/Kully/followers","following_url":"https://api.github.com/users/Kully/following{/other_user}","gists_url":"https://api.github.com/users/Kully/gists{/gist_id}","starred_url":"https://api.github.com/users/Kully/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kully/subscriptions","organizations_url":"https://api.github.com/users/Kully/orgs","repos_url":"https://api.github.com/users/Kully/repos","events_url":"https://api.github.com/users/Kully/events{/privacy}","received_events_url":"https://api.github.com/users/Kully/received_events","type":"User","site_admin":false},"body":"@chriddyp @cldougl \r\nResolves: https://github.com/plotly/documentation/issues/828","created_at":"2017-10-10T17:28:45Z","updated_at":"2017-10-10T19:53:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"644c61714b24030aeac5134d2d3cbe21152d96bd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/plotly/documentation/pulls/829/commits","review_comments_url":"https://api.github.com/repos/plotly/documentation/pulls/829/comments","review_comment_url":"https://api.github.com/repos/plotly/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plotly/documentation/issues/829/comments","statuses_url":"https://api.github.com/repos/plotly/documentation/statuses/ae0c437a559819476857c485d5d84549639638d4","head":{"label":"plotly:fix-dash-links","ref":"fix-dash-links","sha":"ae0c437a559819476857c485d5d84549639638d4","user":{"login":"plotly","id":5997976,"avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":18997629,"name":"documentation","full_name":"plotly/documentation","owner":{"login":"plotly","id":5997976,"avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/documentation","description":"Plotly's Documentation","fork":false,"url":"https://api.github.com/repos/plotly/documentation","forks_url":"https://api.github.com/repos/plotly/documentation/forks","keys_url":"https://api.github.com/repos/plotly/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/documentation/teams","hooks_url":"https://api.github.com/repos/plotly/documentation/hooks","issue_events_url":"https://api.github.com/repos/plotly/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/documentation/events","assignees_url":"https://api.github.com/repos/plotly/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/documentation/tags","blobs_url":"https://api.github.com/repos/plotly/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/documentation/languages","stargazers_url":"https://api.github.com/repos/plotly/documentation/stargazers","contributors_url":"https://api.github.com/repos/plotly/documentation/contributors","subscribers_url":"https://api.github.com/repos/plotly/documentation/subscribers","subscription_url":"https://api.github.com/repos/plotly/documentation/subscription","commits_url":"https://api.github.com/repos/plotly/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/documentation/merges","archive_url":"https://api.github.com/repos/plotly/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/documentation/downloads","issues_url":"https://api.github.com/repos/plotly/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/documentation/labels{/name}","releases_url":"https://api.github.com/repos/plotly/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/documentation/deployments","created_at":"2014-04-21T16:00:46Z","updated_at":"2017-07-10T15:32:15Z","pushed_at":"2017-10-10T19:43:04Z","git_url":"git://github.com/plotly/documentation.git","ssh_url":"git@github.com:plotly/documentation.git","clone_url":"https://github.com/plotly/documentation.git","svn_url":"https://github.com/plotly/documentation","homepage":"https://plot.ly/api","size":1026229,"stargazers_count":49,"watchers_count":49,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":72,"forks":41,"open_issues":72,"watchers":49,"default_branch":"master"}},"base":{"label":"plotly:source-design-merge","ref":"source-design-merge","sha":"976805f850793aadbb5522e48b41b370bb72f918","user":{"login":"plotly","id":5997976,"avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":18997629,"name":"documentation","full_name":"plotly/documentation","owner":{"login":"plotly","id":5997976,"avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/documentation","description":"Plotly's Documentation","fork":false,"url":"https://api.github.com/repos/plotly/documentation","forks_url":"https://api.github.com/repos/plotly/documentation/forks","keys_url":"https://api.github.com/repos/plotly/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/documentation/teams","hooks_url":"https://api.github.com/repos/plotly/documentation/hooks","issue_events_url":"https://api.github.com/repos/plotly/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/documentation/events","assignees_url":"https://api.github.com/repos/plotly/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/documentation/tags","blobs_url":"https://api.github.com/repos/plotly/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/documentation/languages","stargazers_url":"https://api.github.com/repos/plotly/documentation/stargazers","contributors_url":"https://api.github.com/repos/plotly/documentation/contributors","subscribers_url":"https://api.github.com/repos/plotly/documentation/subscribers","subscription_url":"https://api.github.com/repos/plotly/documentation/subscription","commits_url":"https://api.github.com/repos/plotly/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/documentation/merges","archive_url":"https://api.github.com/repos/plotly/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/documentation/downloads","issues_url":"https://api.github.com/repos/plotly/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/documentation/labels{/name}","releases_url":"https://api.github.com/repos/plotly/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/documentation/deployments","created_at":"2014-04-21T16:00:46Z","updated_at":"2017-07-10T15:32:15Z","pushed_at":"2017-10-10T19:43:04Z","git_url":"git://github.com/plotly/documentation.git","ssh_url":"git@github.com:plotly/documentation.git","clone_url":"https://github.com/plotly/documentation.git","svn_url":"https://github.com/plotly/documentation","homepage":"https://plot.ly/api","size":1026229,"stargazers_count":49,"watchers_count":49,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":72,"forks":41,"open_issues":72,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/documentation/pulls/829"},"html":{"href":"https://github.com/plotly/documentation/pull/829"},"issue":{"href":"https://api.github.com/repos/plotly/documentation/issues/829"},"comments":{"href":"https://api.github.com/repos/plotly/documentation/issues/829/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/documentation/pulls/829/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plotly/documentation/pulls/829/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/documentation/statuses/ae0c437a559819476857c485d5d84549639638d4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chriddyp"}}