{"action":"created","issue":{"url":"https://api.github.com/repos/openSUSE/open-build-service/issues/3666","repository_url":"https://api.github.com/repos/openSUSE/open-build-service","labels_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/3666/labels{/name}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/3666/comments","events_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/3666/events","html_url":"https://github.com/openSUSE/open-build-service/pull/3666","id":252547962,"number":3666,"title":"[frontend] Fix drop tags rolllback","user":{"login":"Ana06","id":16052290,"avatar_url":"https://avatars3.githubusercontent.com/u/16052290?v=4","gravatar_id":"","url":"https://api.github.com/users/Ana06","html_url":"https://github.com/Ana06","followers_url":"https://api.github.com/users/Ana06/followers","following_url":"https://api.github.com/users/Ana06/following{/other_user}","gists_url":"https://api.github.com/users/Ana06/gists{/gist_id}","starred_url":"https://api.github.com/users/Ana06/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ana06/subscriptions","organizations_url":"https://api.github.com/users/Ana06/orgs","repos_url":"https://api.github.com/users/Ana06/repos","events_url":"https://api.github.com/users/Ana06/events{/privacy}","received_events_url":"https://api.github.com/users/Ana06/received_events","type":"User","site_admin":false},"labels":[{"id":21922370,"url":"https://api.github.com/repos/openSUSE/open-build-service/labels/Frontend","name":"Frontend","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-24T09:50:45Z","updated_at":"2017-08-24T11:22:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3666","html_url":"https://github.com/openSUSE/open-build-service/pull/3666","diff_url":"https://github.com/openSUSE/open-build-service/pull/3666.diff","patch_url":"https://github.com/openSUSE/open-build-service/pull/3666.patch"},"body":"Tags where dropped in https://github.com/openSUSE/open-build-service/pull/3644\r\n\r\nThe problem is that from Rails 5.1 the default primary keys are BIGINT(20). That means that the references is trying to use BIGINT(20) while the old tables use INT(11). So we have to take this into account, otherwise the rollback will fail. :bowtie: \r\n\r\nWe are supposing that the last 3 migrations are always run together. If not we can not know if the `tags` table is using INT(11) or BIGINT(20). But that a really rare case. Otherwise the alternatives are complicating the last migration so the `id` in `tags` is always INT(11) or removing the foreign keys in the two other migrations over this field. But this is unused code, so I think we shouldn't complicate it that much.\r\n\r\nI also removed some duplicated indexes, as over some field we were creating an index and an unique index and I don't see any point on this. :confused: "},"comment":{"url":"https://api.github.com/repos/openSUSE/open-build-service/issues/comments/324608014","html_url":"https://github.com/openSUSE/open-build-service/pull/3666#issuecomment-324608014","issue_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/3666","id":324608014,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-08-24T11:22:57Z","updated_at":"2017-08-24T11:22:57Z","body":"# [Codecov](https://codecov.io/gh/openSUSE/open-build-service/pull/3666?src=pr&el=h1) Report\n> Merging [#3666](https://codecov.io/gh/openSUSE/open-build-service/pull/3666?src=pr&el=desc) into [master](https://codecov.io/gh/openSUSE/open-build-service/commit/ca6d3ca7cbb8e63bfdb71aa9484502ab21652095?src=pr&el=desc) will **decrease** coverage by `8.56%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/openSUSE/open-build-service/pull/3666/graphs/tree.svg?height=150&width=650&token=QcfA602fdC&src=pr)](https://codecov.io/gh/openSUSE/open-build-service/pull/3666?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #3666      +/-   ##\n==========================================\n- Coverage   88.78%   80.21%   -8.57%     \n==========================================\n  Files         290      290              \n  Lines       17922    18297     +375     \n==========================================\n- Hits        15912    14677    -1235     \n- Misses       2010     3620    +1610\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #api | `76.82% <ø> (-3.92%)` | :arrow_down: |\n| #rspec | `?` | |\n| #webui | `61.66% <ø> (ø)` | :arrow_up: |\n"}}
{"actor":{"display_login":"codecov"}}