{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls/1","id":148729297,"html_url":"https://github.com/shopgate/cart-integration-shopware/pull/1","diff_url":"https://github.com/shopgate/cart-integration-shopware/pull/1.diff","patch_url":"https://github.com/shopgate/cart-integration-shopware/pull/1.patch","issue_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues/1","number":1,"state":"closed","locked":false,"title":"SHOPWARE-841: added check to prevent attributes without group ids fro…","user":{"login":"aaron-martin","id":11764719,"avatar_url":"https://avatars0.githubusercontent.com/u/11764719?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-martin","html_url":"https://github.com/aaron-martin","followers_url":"https://api.github.com/users/aaron-martin/followers","following_url":"https://api.github.com/users/aaron-martin/following{/other_user}","gists_url":"https://api.github.com/users/aaron-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-martin/subscriptions","organizations_url":"https://api.github.com/users/aaron-martin/orgs","repos_url":"https://api.github.com/users/aaron-martin/repos","events_url":"https://api.github.com/users/aaron-martin/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-martin/received_events","type":"User","site_admin":false},"body":"I applied the fix Stephan R. wrote after testing in shopware version 4.0.1 and 5.3.0. Worked in both. I couldn't find a case when a legitimate attribute would not have a group id.","created_at":"2017-10-25T17:16:21Z","updated_at":"2017-10-26T11:08:30Z","closed_at":"2017-10-26T11:08:30Z","merged_at":"2017-10-26T11:08:30Z","merge_commit_sha":"ca9841d85657f7535c7ad70bea093b682a4bc955","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Rekhyt","id":1127756,"avatar_url":"https://avatars3.githubusercontent.com/u/1127756?v=4","gravatar_id":"","url":"https://api.github.com/users/Rekhyt","html_url":"https://github.com/Rekhyt","followers_url":"https://api.github.com/users/Rekhyt/followers","following_url":"https://api.github.com/users/Rekhyt/following{/other_user}","gists_url":"https://api.github.com/users/Rekhyt/gists{/gist_id}","starred_url":"https://api.github.com/users/Rekhyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rekhyt/subscriptions","organizations_url":"https://api.github.com/users/Rekhyt/orgs","repos_url":"https://api.github.com/users/Rekhyt/repos","events_url":"https://api.github.com/users/Rekhyt/events{/privacy}","received_events_url":"https://api.github.com/users/Rekhyt/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls/1/commits","review_comments_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls/1/comments","review_comment_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues/1/comments","statuses_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/statuses/ca1d7621b9875eca066014a845da54b3740e4eb5","head":{"label":"shopgate:SHOPWARE-841-get_items-faulty-attribute-data","ref":"SHOPWARE-841-get_items-faulty-attribute-data","sha":"ca1d7621b9875eca066014a845da54b3740e4eb5","user":{"login":"shopgate","id":7113393,"avatar_url":"https://avatars3.githubusercontent.com/u/7113393?v=4","gravatar_id":"","url":"https://api.github.com/users/shopgate","html_url":"https://github.com/shopgate","followers_url":"https://api.github.com/users/shopgate/followers","following_url":"https://api.github.com/users/shopgate/following{/other_user}","gists_url":"https://api.github.com/users/shopgate/gists{/gist_id}","starred_url":"https://api.github.com/users/shopgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopgate/subscriptions","organizations_url":"https://api.github.com/users/shopgate/orgs","repos_url":"https://api.github.com/users/shopgate/repos","events_url":"https://api.github.com/users/shopgate/events{/privacy}","received_events_url":"https://api.github.com/users/shopgate/received_events","type":"Organization","site_admin":false},"repo":{"id":99351633,"name":"cart-integration-shopware","full_name":"shopgate/cart-integration-shopware","owner":{"login":"shopgate","id":7113393,"avatar_url":"https://avatars3.githubusercontent.com/u/7113393?v=4","gravatar_id":"","url":"https://api.github.com/users/shopgate","html_url":"https://github.com/shopgate","followers_url":"https://api.github.com/users/shopgate/followers","following_url":"https://api.github.com/users/shopgate/following{/other_user}","gists_url":"https://api.github.com/users/shopgate/gists{/gist_id}","starred_url":"https://api.github.com/users/shopgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopgate/subscriptions","organizations_url":"https://api.github.com/users/shopgate/orgs","repos_url":"https://api.github.com/users/shopgate/repos","events_url":"https://api.github.com/users/shopgate/events{/privacy}","received_events_url":"https://api.github.com/users/shopgate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopgate/cart-integration-shopware","description":"Shopware to Shopgate Interface Plugin","fork":false,"url":"https://api.github.com/repos/shopgate/cart-integration-shopware","forks_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/forks","keys_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/teams","hooks_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/hooks","issue_events_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues/events{/number}","events_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/events","assignees_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/assignees{/user}","branches_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/branches{/branch}","tags_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/tags","blobs_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/languages","stargazers_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/stargazers","contributors_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/contributors","subscribers_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/subscribers","subscription_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/subscription","commits_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/contents/{+path}","compare_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/merges","archive_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/downloads","issues_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues{/number}","pulls_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/labels{/name}","releases_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/releases{/id}","deployments_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/deployments","created_at":"2017-08-04T14:37:18Z","updated_at":"2017-10-25T08:44:00Z","pushed_at":"2017-10-26T11:08:30Z","git_url":"git://github.com/shopgate/cart-integration-shopware.git","ssh_url":"git@github.com:shopgate/cart-integration-shopware.git","clone_url":"https://github.com/shopgate/cart-integration-shopware.git","svn_url":"https://github.com/shopgate/cart-integration-shopware","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shopgate:master","ref":"master","sha":"1f9f5b20b3c5bfc5639a969b23e83273e6a6810e","user":{"login":"shopgate","id":7113393,"avatar_url":"https://avatars3.githubusercontent.com/u/7113393?v=4","gravatar_id":"","url":"https://api.github.com/users/shopgate","html_url":"https://github.com/shopgate","followers_url":"https://api.github.com/users/shopgate/followers","following_url":"https://api.github.com/users/shopgate/following{/other_user}","gists_url":"https://api.github.com/users/shopgate/gists{/gist_id}","starred_url":"https://api.github.com/users/shopgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopgate/subscriptions","organizations_url":"https://api.github.com/users/shopgate/orgs","repos_url":"https://api.github.com/users/shopgate/repos","events_url":"https://api.github.com/users/shopgate/events{/privacy}","received_events_url":"https://api.github.com/users/shopgate/received_events","type":"Organization","site_admin":false},"repo":{"id":99351633,"name":"cart-integration-shopware","full_name":"shopgate/cart-integration-shopware","owner":{"login":"shopgate","id":7113393,"avatar_url":"https://avatars3.githubusercontent.com/u/7113393?v=4","gravatar_id":"","url":"https://api.github.com/users/shopgate","html_url":"https://github.com/shopgate","followers_url":"https://api.github.com/users/shopgate/followers","following_url":"https://api.github.com/users/shopgate/following{/other_user}","gists_url":"https://api.github.com/users/shopgate/gists{/gist_id}","starred_url":"https://api.github.com/users/shopgate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopgate/subscriptions","organizations_url":"https://api.github.com/users/shopgate/orgs","repos_url":"https://api.github.com/users/shopgate/repos","events_url":"https://api.github.com/users/shopgate/events{/privacy}","received_events_url":"https://api.github.com/users/shopgate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopgate/cart-integration-shopware","description":"Shopware to Shopgate Interface Plugin","fork":false,"url":"https://api.github.com/repos/shopgate/cart-integration-shopware","forks_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/forks","keys_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/teams","hooks_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/hooks","issue_events_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues/events{/number}","events_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/events","assignees_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/assignees{/user}","branches_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/branches{/branch}","tags_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/tags","blobs_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/languages","stargazers_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/stargazers","contributors_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/contributors","subscribers_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/subscribers","subscription_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/subscription","commits_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/contents/{+path}","compare_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/merges","archive_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/downloads","issues_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues{/number}","pulls_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/labels{/name}","releases_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/releases{/id}","deployments_url":"https://api.github.com/repos/shopgate/cart-integration-shopware/deployments","created_at":"2017-08-04T14:37:18Z","updated_at":"2017-10-25T08:44:00Z","pushed_at":"2017-10-26T11:08:30Z","git_url":"git://github.com/shopgate/cart-integration-shopware.git","ssh_url":"git@github.com:shopgate/cart-integration-shopware.git","clone_url":"https://github.com/shopgate/cart-integration-shopware.git","svn_url":"https://github.com/shopgate/cart-integration-shopware","homepage":null,"size":152,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls/1"},"html":{"href":"https://github.com/shopgate/cart-integration-shopware/pull/1"},"issue":{"href":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues/1"},"comments":{"href":"https://api.github.com/repos/shopgate/cart-integration-shopware/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopgate/cart-integration-shopware/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/shopgate/cart-integration-shopware/statuses/ca1d7621b9875eca066014a845da54b3740e4eb5"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aaron-martin","id":11764719,"avatar_url":"https://avatars0.githubusercontent.com/u/11764719?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-martin","html_url":"https://github.com/aaron-martin","followers_url":"https://api.github.com/users/aaron-martin/followers","following_url":"https://api.github.com/users/aaron-martin/following{/other_user}","gists_url":"https://api.github.com/users/aaron-martin/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-martin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-martin/subscriptions","organizations_url":"https://api.github.com/users/aaron-martin/orgs","repos_url":"https://api.github.com/users/aaron-martin/repos","events_url":"https://api.github.com/users/aaron-martin/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-martin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"aaron-martin"}}