{"push_id":1738795347,"size":24,"distinct_size":24,"ref":"refs/heads/fastpath-ascii-domains-2","head":"8233c343149d50b07b20b7e210a240fd170856b4","before":"cf38a91c50384fc1606328828f8c3dcc493540ad","commits":[{"sha":"bee250c2326dc9424ff4b940d34a5bd7017022c1","author":{"name":"Sebastian Plesciuc","email":"a31a62e4c775d52623dc5d022a5db9c43a5316cc@sendgrid.com"},"message":"test: dynamic port in cluster disconnect\n\nRemoved common.PORT from test-cluster-disconnect to eliminate the\npossibility that a port used in another test will collide\nwith common.PORT.\n\nPR-URL: https://github.com/nodejs/node/pull/12545\nRefs: https://github.com/nodejs/node/issues/12376\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/bee250c2326dc9424ff4b940d34a5bd7017022c1"},{"sha":"bb88caec0680d098f4de936e1b2d09756344fca1","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"build: fix ninja build failure\n\nWhen working on commit 6a09a69ec9d36b705e9bde2ac1a193566a702d96\n(\"build: enable cctest to use generated objects\") I did not take into\naccount building with ninja:\n\n$ ./configure\n$ tools/gyp_node.py -f ninja\n$ ninja -C out/Release\n$ ln -fs out/Release/node node\n\nWhen ninja generated the ninja build files, src files that are\nrelative to the src directory will be named with a dot instead of a\npath separator, for example:\n\nout/Release/obj/src/node/node.o\nwould instead become:\nout/Release/obj/src/node.node.o\n\nThis commit adds an additional variable for the type of object separator\nused for this case.\n\nCurrently the check for if ninja is being used is a normal if statement\nas are the following os checks (win and aix). But the win and aix ones\nshould only be evaluated if the build is not generated by ninja.\nThis commit turns this logic into an if ninja else statement.\n\nPR-URL: https://github.com/nodejs/node/pull/12484\nFixes: https://github.com/nodejs/node/issues/12448\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/bb88caec0680d098f4de936e1b2d09756344fca1"},{"sha":"9fd22bc4d4a90a5cdbf6db4d61eb94179f136a12","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"build: fix ninja build failure (GYP patch)\n\nCurrently the files specified in libraries in node.gyp `cctest` target are\ngetting a '.lib' extension on windows when generated with ninja.\nThis commit adds a check to see if a file has a '.obj' extension and in\nthat case no '.lib' extension will be added.\n\nAlso, the LIBS specified in the 'libraries' section are not\nbeing included in the --start-group --end-group section which\nmeans that these libraries will not be searched causing issue\nwith linkers where the order matters.\n\nPR-URL: https://github.com/nodejs/node/pull/12484\nFixes: https://github.com/nodejs/node/issues/12448\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/9fd22bc4d4a90a5cdbf6db4d61eb94179f136a12"},{"sha":"654afa2c195a68ce4959fe7f918d70da99d7ba05","author":{"name":"Michael Dawson","email":"0969a5765dd913d0b0517d963efbc007dbb147ad@devrus.com"},"message":"test: improve n-api array func coverage\n\n- add coverage for napi_has_element\n- add coverage for napi_create_array_with_length\n\nPR-URL: https://github.com/nodejs/node/pull/12890\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/654afa2c195a68ce4959fe7f918d70da99d7ba05"},{"sha":"631cb42b4e2e067d82bd0c11b9317caf3b47e14a","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"test: favor deepStrictEqual over deepEqual\n\ntest-http-mutable-headers uses assert.deepEqual() in three places but\nappears to only needs it in two of them. Replace one with\nassert.deepStrictEqual() and remove linting exception.\n\nPR-URL: https://github.com/nodejs/node/pull/12883\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/631cb42b4e2e067d82bd0c11b9317caf3b47e14a"},{"sha":"abfd4bf9dfbf4e9817fe2c0b08476f505c4012d1","author":{"name":"Beth Griggs","email":"b0576579b6ce78c69cee862d0067194d8a2d1bc0@uk.ibm.com"},"message":"doc: clarify node.js addons are c++\n\nPR-URL: https://github.com/nodejs/node/pull/12898\nFixes: https://github.com/nodejs/node/issues/7129\nReviewed-By: Sam Roberts <vieuxtech@gmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Timothy Gu <timothygu99@gmail.com>\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/abfd4bf9dfbf4e9817fe2c0b08476f505c4012d1"},{"sha":"9ce2271e813016685d1c8f9ab3e7ce6c85eee069","author":{"name":"cjihrig","email":"b0a62289a2635542c30e3402b36d8cbeb000fe3e@gmail.com"},"message":"https: support agent construction without new\n\nFixes: https://github.com/nodejs/node/issues/12918\nPR-URL: https://github.com/nodejs/node/pull/12927\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/9ce2271e813016685d1c8f9ab3e7ce6c85eee069"},{"sha":"b6001a2da5349de5eeddcc9e4cbcb930bfe6c29c","author":{"name":"cjihrig","email":"b0a62289a2635542c30e3402b36d8cbeb000fe3e@gmail.com"},"message":"src: make SIGPROF message a real warning\n\nThis commit replaces a fprintf() with a call to\nProcessEmitWarning().\n\nRefs: https://github.com/nodejs/node/issues/12706\nPR-URL: https://github.com/nodejs/node/pull/12709\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: Sam Roberts <vieuxtech@gmail.com>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/b6001a2da5349de5eeddcc9e4cbcb930bfe6c29c"},{"sha":"c79deaab8234d3d2fe44592c3ea2315b6a4a3fc7","author":{"name":"Michael Dawson","email":"0969a5765dd913d0b0517d963efbc007dbb147ad@devrus.com"},"message":"doc: update to add ref to supported platforms\n\nUpdate README.md to be consistent with changes made\nto earlier branches.\n\nPR-URL: https://github.com/nodejs/node/pull/12931\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: MichaëZasso <targos@protonmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/c79deaab8234d3d2fe44592c3ea2315b6a4a3fc7"},{"sha":"6f449db60fa9507e241402b92afa550cc508acf5","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"fs: refactor deprecated functions for readability\n\nThis is a small refactor to make an object more readable (IMO).\n\nYeah, I spent a bit longer looking at the code and misunderstanding it\nthan I care to admit right now.\n\nPR-URL: https://github.com/nodejs/node/pull/12910\nReviewed-By: Yuta Hiroto <hello@about-hiroppy.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/6f449db60fa9507e241402b92afa550cc508acf5"},{"sha":"a82e0e6f361ac0923539d2c47586159fff9c6573","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"benchmark: check for time precision in common.js\n\nSome benchmark tests are failing intermittently, possibly due to\nhrtime() imprecision on particular hosts. This change will confirm or\nrefute that as the root cause the next time the test fails on CI. Either\nway, it's a valid check.\n\nPR-URL: https://github.com/nodejs/node/pull/12934\nRef: https://github.com/nodejs/node/issues/12497\nRef: https://github.com/nodejs/node/issues/12433\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/a82e0e6f361ac0923539d2c47586159fff9c6573"},{"sha":"d7d16f7b8b4f0203f8e3128c37a1329061456c5d","author":{"name":"kysnm","email":"568983c2899df13269cbbaf8128d06695f737105@gmail.com"},"message":"doc: Change options at STEP 5 in CONTRIBUTING.md\n\nPR-URL: https://github.com/nodejs/node/pull/12830\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/d7d16f7b8b4f0203f8e3128c37a1329061456c5d"},{"sha":"9f8e030f1b41d3625cf36c282090c6a90c7a203e","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"src: add/move hasCrypto checks for async tests\n\nCurrently when configured --without-ssl these test will fail. In\ntest-crypto-pbkdf2.js and test-crypto-randomBytes.js the check exists\nbut just need to be moved before the require of crypto.\n\nThere was no check in test-async-wrap-uncaughtexception.js so one was\nadded.\n\nPR-URL: https://github.com/nodejs/node/pull/12968\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Luca Maraschi <luca.maraschi@gmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/9f8e030f1b41d3625cf36c282090c6a90c7a203e"},{"sha":"15410797f246acb9e2605e78b97b2757db30c5c3","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"src: add HAVE_OPENSSL guard to crypto providers\n\nWhen configured --without-ssl node_crypto.h will not be included but\nasync-wrap.h includes providers that are defined in node_crypto.h,\nnode_crypto.cc, and tls_wrap.cc:\nAsyncWrap::PROVIDER_CONNECTION\nAsyncWrap::PROVIDER_PBKDF2REQUEST\nAsyncWrap::PROVIDER_RANDOMBYTESREQUEST\nAsyncWrap::PROVIDER_TLSWRAP\n\nThese will be included as providers which will cause\ntest-async-wrap-getasyncid.js to fail.\n\nThis commit suggest adding a guard and exclude the providers that are\nnot available when configured --without-ssl\n\nPR-URL: https://github.com/nodejs/node/pull/12967\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Sam Roberts <vieuxtech@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/15410797f246acb9e2605e78b97b2757db30c5c3"},{"sha":"529e4f206aa16e53e19a6f03b3bfc5f07268149e","author":{"name":"Vse Mozhet Byt","email":"8b18ece5f7df404cbdf408917a461967b0b4a49d@gmail.com"},"message":"test: make a test path-independent\n\nparallel/test-spawn-cmd-named-pipe.js failed with spaces\nboth in node.exe and test paths.\n\nPR-URL: https://github.com/nodejs/node/pull/12945\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/529e4f206aa16e53e19a6f03b3bfc5f07268149e"},{"sha":"56812c81a370c4aa5937b79a40226b6fca060379","author":{"name":"Artur G Vieira","email":"23b590cc8742a728d480d41308c63e9e4f026327@gmail.com"},"message":"test: use dynamic port in test-https-connect-address-family\n\nRemove common.PORT from test-https-connect-address-family to eliminate\npossibility that a dynamic port used in another test will collide with\ncommon.PORT.\n\nPR-URL: https://github.com/nodejs/node/pull/12915\nRef: https://github.com/nodejs/node/issues/12376\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Yuta Hiroto <hello@about-hiroppy.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/56812c81a370c4aa5937b79a40226b6fca060379"},{"sha":"1d5f5aa7e1fb43d070fad137636d03ab2e9280fe","author":{"name":"morrme","email":"ec883fb49cd1d39ccfc94a58b6f37ccd18507dd9@users.noreply.github.com"},"message":"doc: update COLLABORATOR_GUIDE.md\n\nPR-URL: https://github.com/nodejs/node/pull/12555\nFixes: https://github.com/nodejs/node/issues/12021\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/1d5f5aa7e1fb43d070fad137636d03ab2e9280fe"},{"sha":"642bd4dd6dd16221f910538b03046542711361c3","author":{"name":"Sreepurna Jasti","email":"b907cbf102bd8ccbaaa387c06542553ee4859170@in.ibm.com"},"message":"test: add a simple abort check in windows\n\nraise(SIGABRT) or CRT abort causes exit code 3 and\nnull signal in windows. Looks like this simple assertion\nis not present in windows. Make this assertion.\n\nPR-URL: https://github.com/nodejs/node/pull/12914\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/642bd4dd6dd16221f910538b03046542711361c3"},{"sha":"7c3a23b9c121b816c551d2560df9ee2bc63f2555","author":{"name":"Eugene Ostroukhov","email":"2d583e09d823336f75ea9bdf125aef6fc62513f3@chromium.org"},"message":"inspector: handle socket close before close frame\n\nThis change handles clients that respond to close request with a TCP\nclose instead of close response.\n\nPR-URL: https://github.com/nodejs/node/pull/12937\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/7c3a23b9c121b816c551d2560df9ee2bc63f2555"},{"sha":"98609fc1c4635f02f8f6ef9dd079207a1204b9a1","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"timers: do not use user object call/apply\n\nTimers should work even if the user has monkey-patched `.call()` and\n`.apply()` to undesirable values.\n\nPR-URL: https://github.com/nodejs/node/pull/12960\nRef: https://github.com/nodejs/node/issues/12956\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>","distinct":true,"url":"https://api.github.com/repos/zimbabao/node/commits/98609fc1c4635f02f8f6ef9dd079207a1204b9a1"}]}
{"actor":{"display_login":"zimbabao"}}