{"action":"created","comment":{"url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments/126260548","pull_request_review_id":48734649,"id":126260548,"diff_hunk":"@@ -0,0 +1,50 @@\n+/* * *  *  * *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  * */\n+/* Copyright (c) 2017 Mobify Research & Development Inc. All rights reserved. */\n+/* * *  *  * *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  * */\n+\n+/* eslint-env jest */\n+import commands from './commands'\n+\n+export const testStubCommand = (command, ...args) => {\n+    it(`${command.name} executes without errors`, () => {\n+        const dispatch = () => Promise.resolve()","path":"web/app/connectors/_stub-connector/commands.test.js","position":10,"original_position":10,"commit_id":"dc3b0b9dc6d6f62970540b4e04173675edc30472","original_commit_id":"dc3b0b9dc6d6f62970540b4e04173675edc30472","user":{"login":"fractaltheory","id":1211726,"avatar_url":"https://avatars1.githubusercontent.com/u/1211726?v=3","gravatar_id":"","url":"https://api.github.com/users/fractaltheory","html_url":"https://github.com/fractaltheory","followers_url":"https://api.github.com/users/fractaltheory/followers","following_url":"https://api.github.com/users/fractaltheory/following{/other_user}","gists_url":"https://api.github.com/users/fractaltheory/gists{/gist_id}","starred_url":"https://api.github.com/users/fractaltheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fractaltheory/subscriptions","organizations_url":"https://api.github.com/users/fractaltheory/orgs","repos_url":"https://api.github.com/users/fractaltheory/repos","events_url":"https://api.github.com/users/fractaltheory/events{/privacy}","received_events_url":"https://api.github.com/users/fractaltheory/received_events","type":"User","site_admin":false},"body":"We could potentially use something like `redux-mock-store` to stub out these Redux arguments - but that's overkill here.","created_at":"2017-07-07T22:50:59Z","updated_at":"2017-07-07T22:53:27Z","html_url":"https://github.com/mobify/platform-scaffold/pull/849#discussion_r126260548","pull_request_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/849","_links":{"self":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments/126260548"},"html":{"href":"https://github.com/mobify/platform-scaffold/pull/849#discussion_r126260548"},"pull_request":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/849"}}},"pull_request":{"url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/849","id":128687434,"html_url":"https://github.com/mobify/platform-scaffold/pull/849","diff_url":"https://github.com/mobify/platform-scaffold/pull/849.diff","patch_url":"https://github.com/mobify/platform-scaffold/pull/849.patch","issue_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/849","number":849,"state":"open","locked":false,"title":"Add stub connector unit tests","user":{"login":"jeremywiebe","id":77138,"avatar_url":"https://avatars2.githubusercontent.com/u/77138?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremywiebe","html_url":"https://github.com/jeremywiebe","followers_url":"https://api.github.com/users/jeremywiebe/followers","following_url":"https://api.github.com/users/jeremywiebe/following{/other_user}","gists_url":"https://api.github.com/users/jeremywiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremywiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremywiebe/subscriptions","organizations_url":"https://api.github.com/users/jeremywiebe/orgs","repos_url":"https://api.github.com/users/jeremywiebe/repos","events_url":"https://api.github.com/users/jeremywiebe/events{/privacy}","received_events_url":"https://api.github.com/users/jeremywiebe/received_events","type":"User","site_admin":false},"body":"This PR introduces a very basic set of tests for the stub connector.\r\n\r\n **JIRA**: N/A\r\n **Linked PRs**: N/A\r\n\r\n## Changes\r\n- Uses a generator type function to test every command exported by the connector\r\n- Skips `fetchPageData` as that uses the `fetch` API which isn't supported in node\r\n\r\n## Todos\r\n~~- [ ] (if applicable) analytics events instrumented to measure impact of change~~\r\n\r\n## How to test-drive this PR\r\n- Run `npm test`\r\n","created_at":"2017-07-03T20:03:18Z","updated_at":"2017-07-07T22:53:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69c1aa6a3e6dd430fdcc4bc44d5c65352dd9e73f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/849/commits","review_comments_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/849/comments","review_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/849/comments","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/dc3b0b9dc6d6f62970540b4e04173675edc30472","head":{"label":"mobify:stub-connector-unit-tests","ref":"stub-connector-unit-tests","sha":"dc3b0b9dc6d6f62970540b4e04173675edc30472","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"platform-scaffold","full_name":"mobify/platform-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/platform-scaffold","description":"👉  Starter kit for the Mobify Platform","fork":false,"url":"https://api.github.com/repos/mobify/platform-scaffold","forks_url":"https://api.github.com/repos/mobify/platform-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/platform-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/platform-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/platform-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/platform-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/platform-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/platform-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/platform-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/platform-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/platform-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/platform-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/platform-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/platform-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/platform-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/platform-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/platform-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/platform-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/platform-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/platform-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/platform-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/platform-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/platform-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/platform-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/platform-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/platform-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/platform-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/platform-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/platform-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2017-05-10T17:51:05Z","pushed_at":"2017-07-07T22:53:16Z","git_url":"git://github.com/mobify/platform-scaffold.git","ssh_url":"git@github.com:mobify/platform-scaffold.git","clone_url":"https://github.com/mobify/platform-scaffold.git","svn_url":"https://github.com/mobify/platform-scaffold","homepage":"https://www.merlinspotions.com","size":50272,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"develop"}},"base":{"label":"mobify:develop","ref":"develop","sha":"2c1b0675e6dc0c328c328d8f1622d09948cd9797","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"platform-scaffold","full_name":"mobify/platform-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/platform-scaffold","description":"👉  Starter kit for the Mobify Platform","fork":false,"url":"https://api.github.com/repos/mobify/platform-scaffold","forks_url":"https://api.github.com/repos/mobify/platform-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/platform-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/platform-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/platform-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/platform-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/platform-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/platform-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/platform-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/platform-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/platform-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/platform-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/platform-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/platform-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/platform-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/platform-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/platform-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/platform-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/platform-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/platform-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/platform-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/platform-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/platform-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/platform-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/platform-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/platform-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/platform-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/platform-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/platform-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2017-05-10T17:51:05Z","pushed_at":"2017-07-07T22:53:16Z","git_url":"git://github.com/mobify/platform-scaffold.git","ssh_url":"git@github.com:mobify/platform-scaffold.git","clone_url":"https://github.com/mobify/platform-scaffold.git","svn_url":"https://github.com/mobify/platform-scaffold","homepage":"https://www.merlinspotions.com","size":50272,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":14,"forks":1,"open_issues":14,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/849"},"html":{"href":"https://github.com/mobify/platform-scaffold/pull/849"},"issue":{"href":"https://api.github.com/repos/mobify/platform-scaffold/issues/849"},"comments":{"href":"https://api.github.com/repos/mobify/platform-scaffold/issues/849/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/849/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/849/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/platform-scaffold/statuses/dc3b0b9dc6d6f62970540b4e04173675edc30472"}}}}
{"actor":{"display_login":"fractaltheory"}}