{"action":"created","issue":{"url":"https://api.github.com/repos/pvzig/SlackKit/issues/70","repository_url":"https://api.github.com/repos/pvzig/SlackKit","labels_url":"https://api.github.com/repos/pvzig/SlackKit/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/pvzig/SlackKit/issues/70/comments","events_url":"https://api.github.com/repos/pvzig/SlackKit/issues/70/events","html_url":"https://github.com/pvzig/SlackKit/pull/70","id":200023794,"number":70,"title":"Added EventType: \"desktop_notification\"","user":{"login":"sgr-ksmt","id":9350581,"avatar_url":"https://avatars.githubusercontent.com/u/9350581?v=3","gravatar_id":"","url":"https://api.github.com/users/sgr-ksmt","html_url":"https://github.com/sgr-ksmt","followers_url":"https://api.github.com/users/sgr-ksmt/followers","following_url":"https://api.github.com/users/sgr-ksmt/following{/other_user}","gists_url":"https://api.github.com/users/sgr-ksmt/gists{/gist_id}","starred_url":"https://api.github.com/users/sgr-ksmt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgr-ksmt/subscriptions","organizations_url":"https://api.github.com/users/sgr-ksmt/orgs","repos_url":"https://api.github.com/users/sgr-ksmt/repos","events_url":"https://api.github.com/users/sgr-ksmt/events{/privacy}","received_events_url":"https://api.github.com/users/sgr-ksmt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-11T07:43:23Z","updated_at":"2017-01-17T02:34:34Z","closed_at":"2017-01-17T02:34:34Z","pull_request":{"url":"https://api.github.com/repos/pvzig/SlackKit/pulls/70","html_url":"https://github.com/pvzig/SlackKit/pull/70","diff_url":"https://github.com/pvzig/SlackKit/pull/70.diff","patch_url":"https://github.com/pvzig/SlackKit/pull/70.patch"},"body":"- Add `EventType` \"desktop_notification\".\r\n\r\n**SlackKit** currently output error log when received as below:\r\n\r\n```\r\n{\r\n  \"content\": \"user: @bot abcdef\",\r\n  \"event_ts\": 1484119301.624465,\r\n  \"launchUri\": \"slack://channel?id=xxxxx&message=1484119301000012&team=xxxxx\",\r\n  \"subtitle\": \"#xxxxx\",\r\n  \"ssbFilename\": \"knock_brush.mp3\",\r\n  \"title\": \"xxxxx\",\r\n  \"channel\": \"xxxxx\",\r\n  \"avatarImage\": \"https://avatars.slack-edge.com/xxxxx.png\",\r\n  \"type\": \"desktop_notification\",\r\n  \"imageUri\": null,\r\n  \"msg\": 1484119301.000012\r\n}\r\n```\r\n\r\nthen output log: \r\n\r\n```bash\r\nError: SlackKit.Event\r\n```"},"comment":{"url":"https://api.github.com/repos/pvzig/SlackKit/issues/comments/273006959","html_url":"https://github.com/pvzig/SlackKit/pull/70#issuecomment-273006959","issue_url":"https://api.github.com/repos/pvzig/SlackKit/issues/70","id":273006959,"user":{"login":"pvzig","id":8311605,"avatar_url":"https://avatars.githubusercontent.com/u/8311605?v=3","gravatar_id":"","url":"https://api.github.com/users/pvzig","html_url":"https://github.com/pvzig","followers_url":"https://api.github.com/users/pvzig/followers","following_url":"https://api.github.com/users/pvzig/following{/other_user}","gists_url":"https://api.github.com/users/pvzig/gists{/gist_id}","starred_url":"https://api.github.com/users/pvzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvzig/subscriptions","organizations_url":"https://api.github.com/users/pvzig/orgs","repos_url":"https://api.github.com/users/pvzig/repos","events_url":"https://api.github.com/users/pvzig/events{/privacy}","received_events_url":"https://api.github.com/users/pvzig/received_events","type":"User","site_admin":false},"created_at":"2017-01-17T02:34:34Z","updated_at":"2017-01-17T02:34:34Z","body":"Thanks for the PR! \r\n\r\nSince this isn't [officially supported](https://api.slack.com/events) by Slack I don't think I want to specifically add it as an event type but unsupported events shouldn't be logged as errors either.\r\n\r\nFixed [here](https://github.com/pvzig/SlackKit/pull/72).\r\n"}}
{"actor":{"display_login":"pvzig"}}