{"action":"created","issue":{"url":"https://api.github.com/repos/LoopPerfect/buckaroo/issues/131","repository_url":"https://api.github.com/repos/LoopPerfect/buckaroo","labels_url":"https://api.github.com/repos/LoopPerfect/buckaroo/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/LoopPerfect/buckaroo/issues/131/comments","events_url":"https://api.github.com/repos/LoopPerfect/buckaroo/issues/131/events","html_url":"https://github.com/LoopPerfect/buckaroo/issues/131","id":251396814,"number":131,"title":".buckconfig options for libraries","user":{"login":"isundaylee","id":1572861,"avatar_url":"https://avatars1.githubusercontent.com/u/1572861?v=4","gravatar_id":"","url":"https://api.github.com/users/isundaylee","html_url":"https://github.com/isundaylee","followers_url":"https://api.github.com/users/isundaylee/followers","following_url":"https://api.github.com/users/isundaylee/following{/other_user}","gists_url":"https://api.github.com/users/isundaylee/gists{/gist_id}","starred_url":"https://api.github.com/users/isundaylee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isundaylee/subscriptions","organizations_url":"https://api.github.com/users/isundaylee/orgs","repos_url":"https://api.github.com/users/isundaylee/repos","events_url":"https://api.github.com/users/isundaylee/events{/privacy}","received_events_url":"https://api.github.com/users/isundaylee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-19T03:20:15Z","updated_at":"2017-08-19T06:46:04Z","closed_at":null,"body":"As @njlr already raised in https://github.com/facebook/buck/issues/1458, `buck` currently doesn't use the root project `.buckconfig` for the cells (i.e. libraries, in our case). \r\n\r\nWould it be useful to implement a workaround, that merges the root .buckconfig into the libraries' upon checking out the libraries? For me, it would allow me to define custom flavors (`#debug`, `#release`, etc.) in my .buckconfig. \r\n\r\nI'm willing to contribute code if this is something that people think are useful. "},"comment":{"url":"https://api.github.com/repos/LoopPerfect/buckaroo/issues/comments/323505098","html_url":"https://github.com/LoopPerfect/buckaroo/issues/131#issuecomment-323505098","issue_url":"https://api.github.com/repos/LoopPerfect/buckaroo/issues/131","id":323505098,"user":{"login":"njlr","id":1577531,"avatar_url":"https://avatars2.githubusercontent.com/u/1577531?v=4","gravatar_id":"","url":"https://api.github.com/users/njlr","html_url":"https://github.com/njlr","followers_url":"https://api.github.com/users/njlr/followers","following_url":"https://api.github.com/users/njlr/following{/other_user}","gists_url":"https://api.github.com/users/njlr/gists{/gist_id}","starred_url":"https://api.github.com/users/njlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njlr/subscriptions","organizations_url":"https://api.github.com/users/njlr/orgs","repos_url":"https://api.github.com/users/njlr/repos","events_url":"https://api.github.com/users/njlr/events{/privacy}","received_events_url":"https://api.github.com/users/njlr/received_events","type":"User","site_admin":false},"created_at":"2017-08-19T06:46:04Z","updated_at":"2017-08-19T06:46:04Z","body":"I think this requires some more investigation. If I define a flavour in the top level config and build the top level with that flavour, do the dependencies also get built with that flavour?\n\nIf build flavours carry through cells then that would be a good solution for doing debug builds etc across and entire project.  \n\n> On 19 Aug 2017, at 04:20, Jiahao Li <notifications@github.com> wrote:\n> \n> As @njlr already raised in facebook/buck#1458, buck currently doesn't use the root project .buckconfig for the cells (i.e. libraries, in our case).\n> \n> Would it be useful to implement a workaround, that merges the root .buckconfig into the libraries' upon checking out the libraries? For me, it would allow me to define custom flavors (#debug, #release, etc.) in my .buckconfig.\n> \n> I'm willing to contribute code if this is something that people think are useful.\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"njlr"}}