{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/100092137","pull_request_review_id":20787064,"id":100092137,"diff_hunk":"@@ -424,6 +424,14 @@ clean:\tlibclean\n \trm -fr $$i/*; \\\n \tdone\n \n+distclean: clean\n+\t-$(RM) `find . -type l -a \\! -path \"./.git/*\"`\n+\t$(RM) apps/CA.pl\n+\t$(RM) test/evptests.txt test/newkey.pem test/testkey.pem test/testreq.pem\n+\t$(RM) tools/c_rehash\n+\t$(RM) crypto/opensslconf.h\n+\t$(RM) Makefile Makefile.bak","path":"Makefile.org","position":10,"original_position":10,"commit_id":"b74f2f0a2dee1f9945a7d9bd41e06630f240142c","original_commit_id":"b74f2f0a2dee1f9945a7d9bd41e06630f240142c","user":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars.githubusercontent.com/u/9038069?v=3","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"body":"There is certain asymmetry in the way one can answer such questions. To dismiss something as non-universally available it's sufficient to find *one* system among supported ones that doesn't support a flag. But to confirm something as universally available it takes to test on *all* systems :-( But, as suggested alternative uses only flags from old Single Unix Specification it should be more portable in general. BTW, it seems that I was wrong calling -path as GNU-ism, as it is specified in latest SUS. But as already said/implied, we still support older systems...","created_at":"2017-02-08T15:33:04Z","updated_at":"2017-02-08T15:33:04Z","html_url":"https://github.com/openssl/openssl/pull/2554#discussion_r100092137","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/2554","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/100092137"},"html":{"href":"https://github.com/openssl/openssl/pull/2554#discussion_r100092137"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/2554"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/2554","id":104697189,"html_url":"https://github.com/openssl/openssl/pull/2554","diff_url":"https://github.com/openssl/openssl/pull/2554.diff","patch_url":"https://github.com/openssl/openssl/pull/2554.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/2554","number":2554,"state":"open","locked":false,"title":"Add a make distclean rule in the OpenSSL_1_0_2 branch","user":{"login":"bernd-edlinger","id":17638929,"avatar_url":"https://avatars.githubusercontent.com/u/17638929?v=3","gravatar_id":"","url":"https://api.github.com/users/bernd-edlinger","html_url":"https://github.com/bernd-edlinger","followers_url":"https://api.github.com/users/bernd-edlinger/followers","following_url":"https://api.github.com/users/bernd-edlinger/following{/other_user}","gists_url":"https://api.github.com/users/bernd-edlinger/gists{/gist_id}","starred_url":"https://api.github.com/users/bernd-edlinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernd-edlinger/subscriptions","organizations_url":"https://api.github.com/users/bernd-edlinger/orgs","repos_url":"https://api.github.com/users/bernd-edlinger/repos","events_url":"https://api.github.com/users/bernd-edlinger/events{/privacy}","received_events_url":"https://api.github.com/users/bernd-edlinger/received_events","type":"User","site_admin":false},"body":"This adds a make distclean rule that works like the distclean rule in the master branch,\r\nthat is useful if you often switch between 1_1_0 and 1_0_2 branches, as I do.\r\nThere is also a dclean target but I am not sure if it is really working, so I left it as is.","created_at":"2017-02-05T11:55:29Z","updated_at":"2017-02-08T15:33:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a60c0a70b32a5f28b6cc5fbc03248d29da6278c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/2554/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/2554/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/2554/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/b74f2f0a2dee1f9945a7d9bd41e06630f240142c","head":{"label":"bernd-edlinger:old_make_distclean","ref":"old_make_distclean","sha":"b74f2f0a2dee1f9945a7d9bd41e06630f240142c","user":{"login":"bernd-edlinger","id":17638929,"avatar_url":"https://avatars.githubusercontent.com/u/17638929?v=3","gravatar_id":"","url":"https://api.github.com/users/bernd-edlinger","html_url":"https://github.com/bernd-edlinger","followers_url":"https://api.github.com/users/bernd-edlinger/followers","following_url":"https://api.github.com/users/bernd-edlinger/following{/other_user}","gists_url":"https://api.github.com/users/bernd-edlinger/gists{/gist_id}","starred_url":"https://api.github.com/users/bernd-edlinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernd-edlinger/subscriptions","organizations_url":"https://api.github.com/users/bernd-edlinger/orgs","repos_url":"https://api.github.com/users/bernd-edlinger/repos","events_url":"https://api.github.com/users/bernd-edlinger/events{/privacy}","received_events_url":"https://api.github.com/users/bernd-edlinger/received_events","type":"User","site_admin":false},"repo":{"id":77028059,"name":"openssl","full_name":"bernd-edlinger/openssl","owner":{"login":"bernd-edlinger","id":17638929,"avatar_url":"https://avatars.githubusercontent.com/u/17638929?v=3","gravatar_id":"","url":"https://api.github.com/users/bernd-edlinger","html_url":"https://github.com/bernd-edlinger","followers_url":"https://api.github.com/users/bernd-edlinger/followers","following_url":"https://api.github.com/users/bernd-edlinger/following{/other_user}","gists_url":"https://api.github.com/users/bernd-edlinger/gists{/gist_id}","starred_url":"https://api.github.com/users/bernd-edlinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernd-edlinger/subscriptions","organizations_url":"https://api.github.com/users/bernd-edlinger/orgs","repos_url":"https://api.github.com/users/bernd-edlinger/repos","events_url":"https://api.github.com/users/bernd-edlinger/events{/privacy}","received_events_url":"https://api.github.com/users/bernd-edlinger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bernd-edlinger/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/bernd-edlinger/openssl","forks_url":"https://api.github.com/repos/bernd-edlinger/openssl/forks","keys_url":"https://api.github.com/repos/bernd-edlinger/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bernd-edlinger/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bernd-edlinger/openssl/teams","hooks_url":"https://api.github.com/repos/bernd-edlinger/openssl/hooks","issue_events_url":"https://api.github.com/repos/bernd-edlinger/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/bernd-edlinger/openssl/events","assignees_url":"https://api.github.com/repos/bernd-edlinger/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/bernd-edlinger/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/bernd-edlinger/openssl/tags","blobs_url":"https://api.github.com/repos/bernd-edlinger/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bernd-edlinger/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bernd-edlinger/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/bernd-edlinger/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bernd-edlinger/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/bernd-edlinger/openssl/languages","stargazers_url":"https://api.github.com/repos/bernd-edlinger/openssl/stargazers","contributors_url":"https://api.github.com/repos/bernd-edlinger/openssl/contributors","subscribers_url":"https://api.github.com/repos/bernd-edlinger/openssl/subscribers","subscription_url":"https://api.github.com/repos/bernd-edlinger/openssl/subscription","commits_url":"https://api.github.com/repos/bernd-edlinger/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/bernd-edlinger/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/bernd-edlinger/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/bernd-edlinger/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/bernd-edlinger/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/bernd-edlinger/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bernd-edlinger/openssl/merges","archive_url":"https://api.github.com/repos/bernd-edlinger/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bernd-edlinger/openssl/downloads","issues_url":"https://api.github.com/repos/bernd-edlinger/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/bernd-edlinger/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/bernd-edlinger/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/bernd-edlinger/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bernd-edlinger/openssl/labels{/name}","releases_url":"https://api.github.com/repos/bernd-edlinger/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/bernd-edlinger/openssl/deployments","created_at":"2016-12-21T07:18:44Z","updated_at":"2016-12-21T07:19:02Z","pushed_at":"2017-02-07T13:44:07Z","git_url":"git://github.com/bernd-edlinger/openssl.git","ssh_url":"git@github.com:bernd-edlinger/openssl.git","clone_url":"https://github.com/bernd-edlinger/openssl.git","svn_url":"https://github.com/bernd-edlinger/openssl","homepage":"https://www.openssl.org","size":115921,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:OpenSSL_1_0_2-stable","ref":"OpenSSL_1_0_2-stable","sha":"166e365ed84dfabec3274baf8a9ef8aa4e677891","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars.githubusercontent.com/u/3279138?v=3","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2017-02-08T14:53:18Z","pushed_at":"2017-02-08T11:45:48Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":116244,"stargazers_count":4123,"watchers_count":4123,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2192,"mirror_url":null,"open_issues_count":389,"forks":2192,"open_issues":389,"watchers":4123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/2554"},"html":{"href":"https://github.com/openssl/openssl/pull/2554"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/2554"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/2554/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/2554/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/2554/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/b74f2f0a2dee1f9945a7d9bd41e06630f240142c"}}}}
{"actor":{"display_login":"dot-asm"}}