{"action":"closed","number":2894,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/2894","id":155794943,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2894","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2894.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2894.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2894","number":2894,"state":"closed","locked":false,"title":"Delay the force node activation call on the edit report menu explorer","user":{"login":"skateman","id":649130,"avatar_url":"https://avatars1.githubusercontent.com/u/649130?v=4","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"body":"When refreshing an Edit Report Menu subpage (see the BZ for reproduction details) the right cell becomes empty because the angular-based tree is not rendered in the time the `ManageIQ.afterOnload` is being :angry: **eval**uated. Together with all the `miqTreeForceActivateNode` calls this is a good victim for :scissors: :toilet: refactoring in the future. In general this `afterOnload` seems to me as a big hack and the simplest way to fix this without making possible breaking changes was to wrap the tree activation in a `setTimeout`. The code seems ancient and as it is included inline in a template with interpolation, I don't think there's a meaningful way to test this.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1519644","created_at":"2017-12-01T06:57:15Z","updated_at":"2017-12-01T18:46:56Z","closed_at":"2017-12-01T18:46:56Z","merged_at":"2017-12-01T18:46:56Z","merge_commit_sha":"c0f787ff43c3227b28535ec54c4774f324674fa8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/2894/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/2894/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2894/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/cff6d56277ba98a9c3a832d08a63501dee31b85a","head":{"label":"skateman:edit-report-refresh","ref":"edit-report-refresh","sha":"cff6d56277ba98a9c3a832d08a63501dee31b85a","user":{"login":"skateman","id":649130,"avatar_url":"https://avatars1.githubusercontent.com/u/649130?v=4","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"repo":{"id":77148740,"name":"manageiq-ui-classic","full_name":"skateman/manageiq-ui-classic","owner":{"login":"skateman","id":649130,"avatar_url":"https://avatars1.githubusercontent.com/u/649130?v=4","gravatar_id":"","url":"https://api.github.com/users/skateman","html_url":"https://github.com/skateman","followers_url":"https://api.github.com/users/skateman/followers","following_url":"https://api.github.com/users/skateman/following{/other_user}","gists_url":"https://api.github.com/users/skateman/gists{/gist_id}","starred_url":"https://api.github.com/users/skateman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skateman/subscriptions","organizations_url":"https://api.github.com/users/skateman/orgs","repos_url":"https://api.github.com/users/skateman/repos","events_url":"https://api.github.com/users/skateman/events{/privacy}","received_events_url":"https://api.github.com/users/skateman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skateman/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/skateman/manageiq-ui-classic","forks_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/skateman/manageiq-ui-classic/deployments","created_at":"2016-12-22T13:57:59Z","updated_at":"2016-12-22T13:58:05Z","pushed_at":"2017-12-01T16:22:39Z","git_url":"git://github.com/skateman/manageiq-ui-classic.git","ssh_url":"git@github.com:skateman/manageiq-ui-classic.git","clone_url":"https://github.com/skateman/manageiq-ui-classic.git","svn_url":"https://github.com/skateman/manageiq-ui-classic","homepage":null,"size":52045,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2f270bb4f872d19559f348f8260186db1f2bfb45","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2017-11-30T18:46:03Z","pushed_at":"2017-12-01T18:46:56Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":54889,"stargazers_count":20,"watchers_count":20,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":302,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":188,"open_issues":302,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/2894"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2894"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2894"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2894/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/2894/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/2894/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/cff6d56277ba98a9c3a832d08a63501dee31b85a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"martinpovolny"}}