{"action":"created","comment":{"url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/comments/113662123","pull_request_review_id":35068732,"id":113662123,"diff_hunk":"@@ -5,9 +5,9 @@\n const webpack = require('webpack');\n const { resolve } = require('path');\n const ManifestPlugin = require('webpack-manifest-plugin');\n-const webpackConfigLoader = require('react-on-rails').default.webpackConfigLoader; // eslint-disable-line import/no-unresolved\n-\n-const { env, paths, publicPath } = webpackConfigLoader(resolve('..', 'config', 'webpack'));\n+const webpackConfigLoader = require('react-on-rails/node_package/lib/webpackConfigLoader').default;\n+const configPath = resolve('..', 'config', 'webpack');\n+const { env, paths, publicPath } = webpackConfigLoader(configPath);","path":"lib/generators/react_on_rails/templates/base/base/client/webpack.config.js","position":null,"original_position":9,"commit_id":"eb84ec5bccfdf94ce4d4f459ce6839bf4ce81880","original_commit_id":"791a68be65007c7c718e910d1ddacf308266ab8f","user":{"login":"justin808","id":1118459,"avatar_url":"https://avatars1.githubusercontent.com/u/1118459?v=3","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"body":"@alexfedoseev and @robwise I have no idea on what you're referring to. The only reason to modify the webpack configs is so that the webpacker_lite view helper will be able to go the public output directory and thus bypass the asset pipeline.\r\n","created_at":"2017-04-27T10:18:37Z","updated_at":"2017-04-27T10:18:38Z","html_url":"https://github.com/shakacode/react_on_rails/pull/822#discussion_r113662123","pull_request_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/822","_links":{"self":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/comments/113662123"},"html":{"href":"https://github.com/shakacode/react_on_rails/pull/822#discussion_r113662123"},"pull_request":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/822"}}},"pull_request":{"url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/822","id":117678201,"html_url":"https://github.com/shakacode/react_on_rails/pull/822","diff_url":"https://github.com/shakacode/react_on_rails/pull/822.diff","patch_url":"https://github.com/shakacode/react_on_rails/pull/822.patch","issue_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/822","number":822,"state":"open","locked":false,"title":"Justin808/webpacker integration","user":{"login":"justin808","id":1118459,"avatar_url":"https://avatars1.githubusercontent.com/u/1118459?v=3","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"body":"This builds on #811.\r\n\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/shakacode/react_on_rails/822)\r\n<!-- Reviewable:end -->\r\n","created_at":"2017-04-26T10:13:05Z","updated_at":"2017-04-27T10:18:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25441f0ea5a1a638046d3b3f464bc8d57cb2d5c1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/822/commits","review_comments_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/822/comments","review_comment_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/822/comments","statuses_url":"https://api.github.com/repos/shakacode/react_on_rails/statuses/eb84ec5bccfdf94ce4d4f459ce6839bf4ce81880","head":{"label":"shakacode:justin808/webpacker_integration","ref":"justin808/webpacker_integration","sha":"eb84ec5bccfdf94ce4d4f459ce6839bf4ce81880","user":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars0.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"repo":{"id":41117523,"name":"react_on_rails","full_name":"shakacode/react_on_rails","owner":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars0.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shakacode/react_on_rails","description":"Integration of React + Webpack + Rails to build Universal (Isomorphic) Apps","fork":false,"url":"https://api.github.com/repos/shakacode/react_on_rails","forks_url":"https://api.github.com/repos/shakacode/react_on_rails/forks","keys_url":"https://api.github.com/repos/shakacode/react_on_rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakacode/react_on_rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakacode/react_on_rails/teams","hooks_url":"https://api.github.com/repos/shakacode/react_on_rails/hooks","issue_events_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/events{/number}","events_url":"https://api.github.com/repos/shakacode/react_on_rails/events","assignees_url":"https://api.github.com/repos/shakacode/react_on_rails/assignees{/user}","branches_url":"https://api.github.com/repos/shakacode/react_on_rails/branches{/branch}","tags_url":"https://api.github.com/repos/shakacode/react_on_rails/tags","blobs_url":"https://api.github.com/repos/shakacode/react_on_rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakacode/react_on_rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakacode/react_on_rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakacode/react_on_rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakacode/react_on_rails/statuses/{sha}","languages_url":"https://api.github.com/repos/shakacode/react_on_rails/languages","stargazers_url":"https://api.github.com/repos/shakacode/react_on_rails/stargazers","contributors_url":"https://api.github.com/repos/shakacode/react_on_rails/contributors","subscribers_url":"https://api.github.com/repos/shakacode/react_on_rails/subscribers","subscription_url":"https://api.github.com/repos/shakacode/react_on_rails/subscription","commits_url":"https://api.github.com/repos/shakacode/react_on_rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakacode/react_on_rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakacode/react_on_rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakacode/react_on_rails/contents/{+path}","compare_url":"https://api.github.com/repos/shakacode/react_on_rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakacode/react_on_rails/merges","archive_url":"https://api.github.com/repos/shakacode/react_on_rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakacode/react_on_rails/downloads","issues_url":"https://api.github.com/repos/shakacode/react_on_rails/issues{/number}","pulls_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls{/number}","milestones_url":"https://api.github.com/repos/shakacode/react_on_rails/milestones{/number}","notifications_url":"https://api.github.com/repos/shakacode/react_on_rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakacode/react_on_rails/labels{/name}","releases_url":"https://api.github.com/repos/shakacode/react_on_rails/releases{/id}","deployments_url":"https://api.github.com/repos/shakacode/react_on_rails/deployments","created_at":"2015-08-20T20:31:54Z","updated_at":"2017-04-27T08:35:06Z","pushed_at":"2017-04-27T10:12:23Z","git_url":"git://github.com/shakacode/react_on_rails.git","ssh_url":"git@github.com:shakacode/react_on_rails.git","clone_url":"https://github.com/shakacode/react_on_rails.git","svn_url":"https://github.com/shakacode/react_on_rails","homepage":"https://shakacode.gitbooks.io/react-on-rails/content/","size":63265,"stargazers_count":2920,"watchers_count":2920,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"open_issues_count":42,"forks":333,"open_issues":42,"watchers":2920,"default_branch":"master"}},"base":{"label":"shakacode:master","ref":"master","sha":"2dcafd3e8da96ecbf45db6f23b4f3e285e9ec3a1","user":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars0.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"repo":{"id":41117523,"name":"react_on_rails","full_name":"shakacode/react_on_rails","owner":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars0.githubusercontent.com/u/13779463?v=3","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shakacode/react_on_rails","description":"Integration of React + Webpack + Rails to build Universal (Isomorphic) Apps","fork":false,"url":"https://api.github.com/repos/shakacode/react_on_rails","forks_url":"https://api.github.com/repos/shakacode/react_on_rails/forks","keys_url":"https://api.github.com/repos/shakacode/react_on_rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakacode/react_on_rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakacode/react_on_rails/teams","hooks_url":"https://api.github.com/repos/shakacode/react_on_rails/hooks","issue_events_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/events{/number}","events_url":"https://api.github.com/repos/shakacode/react_on_rails/events","assignees_url":"https://api.github.com/repos/shakacode/react_on_rails/assignees{/user}","branches_url":"https://api.github.com/repos/shakacode/react_on_rails/branches{/branch}","tags_url":"https://api.github.com/repos/shakacode/react_on_rails/tags","blobs_url":"https://api.github.com/repos/shakacode/react_on_rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakacode/react_on_rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakacode/react_on_rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakacode/react_on_rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakacode/react_on_rails/statuses/{sha}","languages_url":"https://api.github.com/repos/shakacode/react_on_rails/languages","stargazers_url":"https://api.github.com/repos/shakacode/react_on_rails/stargazers","contributors_url":"https://api.github.com/repos/shakacode/react_on_rails/contributors","subscribers_url":"https://api.github.com/repos/shakacode/react_on_rails/subscribers","subscription_url":"https://api.github.com/repos/shakacode/react_on_rails/subscription","commits_url":"https://api.github.com/repos/shakacode/react_on_rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakacode/react_on_rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakacode/react_on_rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakacode/react_on_rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakacode/react_on_rails/contents/{+path}","compare_url":"https://api.github.com/repos/shakacode/react_on_rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakacode/react_on_rails/merges","archive_url":"https://api.github.com/repos/shakacode/react_on_rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakacode/react_on_rails/downloads","issues_url":"https://api.github.com/repos/shakacode/react_on_rails/issues{/number}","pulls_url":"https://api.github.com/repos/shakacode/react_on_rails/pulls{/number}","milestones_url":"https://api.github.com/repos/shakacode/react_on_rails/milestones{/number}","notifications_url":"https://api.github.com/repos/shakacode/react_on_rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakacode/react_on_rails/labels{/name}","releases_url":"https://api.github.com/repos/shakacode/react_on_rails/releases{/id}","deployments_url":"https://api.github.com/repos/shakacode/react_on_rails/deployments","created_at":"2015-08-20T20:31:54Z","updated_at":"2017-04-27T08:35:06Z","pushed_at":"2017-04-27T10:12:23Z","git_url":"git://github.com/shakacode/react_on_rails.git","ssh_url":"git@github.com:shakacode/react_on_rails.git","clone_url":"https://github.com/shakacode/react_on_rails.git","svn_url":"https://github.com/shakacode/react_on_rails","homepage":"https://shakacode.gitbooks.io/react-on-rails/content/","size":63265,"stargazers_count":2920,"watchers_count":2920,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"open_issues_count":42,"forks":333,"open_issues":42,"watchers":2920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/822"},"html":{"href":"https://github.com/shakacode/react_on_rails/pull/822"},"issue":{"href":"https://api.github.com/repos/shakacode/react_on_rails/issues/822"},"comments":{"href":"https://api.github.com/repos/shakacode/react_on_rails/issues/822/comments"},"review_comments":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/822/comments"},"review_comment":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shakacode/react_on_rails/pulls/822/commits"},"statuses":{"href":"https://api.github.com/repos/shakacode/react_on_rails/statuses/eb84ec5bccfdf94ce4d4f459ce6839bf4ce81880"}}}}
{"actor":{"display_login":"justin808"}}