{"action":"created","issue":{"url":"https://api.github.com/repos/istio/pilot/issues/1213","repository_url":"https://api.github.com/repos/istio/pilot","labels_url":"https://api.github.com/repos/istio/pilot/issues/1213/labels{/name}","comments_url":"https://api.github.com/repos/istio/pilot/issues/1213/comments","events_url":"https://api.github.com/repos/istio/pilot/issues/1213/events","html_url":"https://github.com/istio/pilot/pull/1213","id":256387435,"number":1213,"title":"Make istioctl accept k8s format","user":{"login":"ayj","id":116378,"avatar_url":"https://avatars1.githubusercontent.com/u/116378?v=4","gravatar_id":"","url":"https://api.github.com/users/ayj","html_url":"https://github.com/ayj","followers_url":"https://api.github.com/users/ayj/followers","following_url":"https://api.github.com/users/ayj/following{/other_user}","gists_url":"https://api.github.com/users/ayj/gists{/gist_id}","starred_url":"https://api.github.com/users/ayj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayj/subscriptions","organizations_url":"https://api.github.com/users/ayj/orgs","repos_url":"https://api.github.com/users/ayj/repos","events_url":"https://api.github.com/users/ayj/events{/privacy}","received_events_url":"https://api.github.com/users/ayj/received_events","type":"User","site_admin":false},"labels":[{"id":671807050,"url":"https://api.github.com/repos/istio/pilot/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-08T22:32:17Z","updated_at":"2017-09-08T23:33:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/pilot/pulls/1213","html_url":"https://github.com/istio/pilot/pull/1213","diff_url":"https://github.com/istio/pilot/pull/1213.diff","patch_url":"https://github.com/istio/pilot/pull/1213.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nThis makes istioctl optionally accept proxy configuration in Kubernetes schema. It will first try to decode the input in the legacy schema and, if and only if that fails, will it try to decode as Kubernetes. Once istio/istio templates are fully updated we can remove the legacy support.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/istio/pilot/issues/comments/328236949","html_url":"https://github.com/istio/pilot/pull/1213#issuecomment-328236949","issue_url":"https://api.github.com/repos/istio/pilot/issues/1213","id":328236949,"user":{"login":"istio-testing","id":25311884,"avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2017-09-08T23:33:37Z","updated_at":"2017-09-08T23:33:37Z","author_association":"COLLABORATOR","body":"@ayj: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/pilot-presubmit.sh | 3d1d5955794dc9b5a2c7a4967f8b10dfb961ab10 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_pilot/1213/pilot-presubmit/989/) | `/test pilot-presubmit`\nprow/pilot-e2e-smoketest.sh | 37e422d12c24b52e80987a1458fdf73aa8d40ac6 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_pilot/1213/pilot-e2e-smoketest/333/) | `/test pilot-e2e-smoketest`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}