{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/108517330","pull_request_review_id":29553203,"id":108517330,"diff_hunk":"@@ -43,13 +46,13 @@ def test_select_distinct(self):\n \n     def test_fail_select_alot(self):\n         \"\"\"\n-        Tests that MultinomialWOReplacementFromUniform fails when asked to sample more\n+        Tests that ChoiceFromUniform fails when asked to sample more\n         elements than the actual number of elements\n         \"\"\"\n         p = tensor.fmatrix()\n         u = tensor.fvector()\n         n = tensor.iscalar()\n-        m = multinomial.MultinomialWOReplacementFromUniform('auto')(p, u, n)\n+        m = multinomial.ChoiceFromUniform('auto')(p, u, n)","path":"theano/sandbox/tests/test_multinomial_wo_replacement.py","position":21,"original_position":37,"commit_id":"b6dccdbf362dc31466ccd86bd1c163de0f8495b2","original_commit_id":"606871c23128fefcc0af09bebc83c0e54e61cc83","user":{"login":"laurent-dinh","id":1488894,"avatar_url":"https://avatars0.githubusercontent.com/u/1488894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurent-dinh","html_url":"https://github.com/laurent-dinh","followers_url":"https://api.github.com/users/laurent-dinh/followers","following_url":"https://api.github.com/users/laurent-dinh/following{/other_user}","gists_url":"https://api.github.com/users/laurent-dinh/gists{/gist_id}","starred_url":"https://api.github.com/users/laurent-dinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurent-dinh/subscriptions","organizations_url":"https://api.github.com/users/laurent-dinh/orgs","repos_url":"https://api.github.com/users/laurent-dinh/repos","events_url":"https://api.github.com/users/laurent-dinh/events{/privacy}","received_events_url":"https://api.github.com/users/laurent-dinh/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-03-28T19:36:12Z","updated_at":"2017-03-28T19:36:12Z","html_url":"https://github.com/Theano/Theano/pull/5751#discussion_r108517330","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/5751","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/108517330"},"html":{"href":"https://github.com/Theano/Theano/pull/5751#discussion_r108517330"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5751"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/5751","id":112110117,"html_url":"https://github.com/Theano/Theano/pull/5751","diff_url":"https://github.com/Theano/Theano/pull/5751.diff","patch_url":"https://github.com/Theano/Theano/pull/5751.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/5751","number":5751,"state":"open","locked":false,"title":"MultinomialWOReplacementFromUniform := ChoiceFromUniform","user":{"login":"laurent-dinh","id":1488894,"avatar_url":"https://avatars0.githubusercontent.com/u/1488894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurent-dinh","html_url":"https://github.com/laurent-dinh","followers_url":"https://api.github.com/users/laurent-dinh/followers","following_url":"https://api.github.com/users/laurent-dinh/following{/other_user}","gists_url":"https://api.github.com/users/laurent-dinh/gists{/gist_id}","starred_url":"https://api.github.com/users/laurent-dinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurent-dinh/subscriptions","organizations_url":"https://api.github.com/users/laurent-dinh/orgs","repos_url":"https://api.github.com/users/laurent-dinh/repos","events_url":"https://api.github.com/users/laurent-dinh/events{/privacy}","received_events_url":"https://api.github.com/users/laurent-dinh/received_events","type":"User","site_admin":false},"body":"Following instructions by @nouiz from issue #5408.","created_at":"2017-03-22T21:03:46Z","updated_at":"2017-03-28T19:36:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0df16df8251e30c3e7989785437cfddbd15743cc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/5751/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/5751/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/5751/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/b6dccdbf362dc31466ccd86bd1c163de0f8495b2","head":{"label":"laurent-dinh:to_choice","ref":"to_choice","sha":"b6dccdbf362dc31466ccd86bd1c163de0f8495b2","user":{"login":"laurent-dinh","id":1488894,"avatar_url":"https://avatars0.githubusercontent.com/u/1488894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurent-dinh","html_url":"https://github.com/laurent-dinh","followers_url":"https://api.github.com/users/laurent-dinh/followers","following_url":"https://api.github.com/users/laurent-dinh/following{/other_user}","gists_url":"https://api.github.com/users/laurent-dinh/gists{/gist_id}","starred_url":"https://api.github.com/users/laurent-dinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurent-dinh/subscriptions","organizations_url":"https://api.github.com/users/laurent-dinh/orgs","repos_url":"https://api.github.com/users/laurent-dinh/repos","events_url":"https://api.github.com/users/laurent-dinh/events{/privacy}","received_events_url":"https://api.github.com/users/laurent-dinh/received_events","type":"User","site_admin":false},"repo":{"id":17097068,"name":"Theano","full_name":"laurent-dinh/Theano","owner":{"login":"laurent-dinh","id":1488894,"avatar_url":"https://avatars0.githubusercontent.com/u/1488894?v=3","gravatar_id":"","url":"https://api.github.com/users/laurent-dinh","html_url":"https://github.com/laurent-dinh","followers_url":"https://api.github.com/users/laurent-dinh/followers","following_url":"https://api.github.com/users/laurent-dinh/following{/other_user}","gists_url":"https://api.github.com/users/laurent-dinh/gists{/gist_id}","starred_url":"https://api.github.com/users/laurent-dinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurent-dinh/subscriptions","organizations_url":"https://api.github.com/users/laurent-dinh/orgs","repos_url":"https://api.github.com/users/laurent-dinh/repos","events_url":"https://api.github.com/users/laurent-dinh/events{/privacy}","received_events_url":"https://api.github.com/users/laurent-dinh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laurent-dinh/Theano","description":"Optimizing GPU-meta-programming code generating array oriented optimizing math compiler in Python","fork":true,"url":"https://api.github.com/repos/laurent-dinh/Theano","forks_url":"https://api.github.com/repos/laurent-dinh/Theano/forks","keys_url":"https://api.github.com/repos/laurent-dinh/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laurent-dinh/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laurent-dinh/Theano/teams","hooks_url":"https://api.github.com/repos/laurent-dinh/Theano/hooks","issue_events_url":"https://api.github.com/repos/laurent-dinh/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/laurent-dinh/Theano/events","assignees_url":"https://api.github.com/repos/laurent-dinh/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/laurent-dinh/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/laurent-dinh/Theano/tags","blobs_url":"https://api.github.com/repos/laurent-dinh/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laurent-dinh/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laurent-dinh/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/laurent-dinh/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laurent-dinh/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/laurent-dinh/Theano/languages","stargazers_url":"https://api.github.com/repos/laurent-dinh/Theano/stargazers","contributors_url":"https://api.github.com/repos/laurent-dinh/Theano/contributors","subscribers_url":"https://api.github.com/repos/laurent-dinh/Theano/subscribers","subscription_url":"https://api.github.com/repos/laurent-dinh/Theano/subscription","commits_url":"https://api.github.com/repos/laurent-dinh/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/laurent-dinh/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/laurent-dinh/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/laurent-dinh/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/laurent-dinh/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/laurent-dinh/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laurent-dinh/Theano/merges","archive_url":"https://api.github.com/repos/laurent-dinh/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laurent-dinh/Theano/downloads","issues_url":"https://api.github.com/repos/laurent-dinh/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/laurent-dinh/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/laurent-dinh/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/laurent-dinh/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laurent-dinh/Theano/labels{/name}","releases_url":"https://api.github.com/repos/laurent-dinh/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/laurent-dinh/Theano/deployments","created_at":"2014-02-22T23:13:55Z","updated_at":"2014-06-25T03:55:26Z","pushed_at":"2017-03-27T22:55:19Z","git_url":"git://github.com/laurent-dinh/Theano.git","ssh_url":"git@github.com:laurent-dinh/Theano.git","clone_url":"https://github.com/laurent-dinh/Theano.git","svn_url":"https://github.com/laurent-dinh/Theano","homepage":"http://www.deeplearning.net/software/theano","size":60064,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"6c37dfc5e1c1e747f202a1401a539b30738cee00","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars1.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars1.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2017-03-28T14:37:33Z","pushed_at":"2017-03-28T19:08:16Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":60517,"stargazers_count":5979,"watchers_count":5979,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2064,"mirror_url":null,"open_issues_count":725,"forks":2064,"open_issues":725,"watchers":5979,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5751"},"html":{"href":"https://github.com/Theano/Theano/pull/5751"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/5751"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/5751/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5751/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5751/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/b6dccdbf362dc31466ccd86bd1c163de0f8495b2"}}}}
{"actor":{"display_login":"laurent-dinh"}}