{"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments/138984719","pull_request_review_id":62856267,"id":138984719,"diff_hunk":"@@ -298,7 +301,7 @@ function getRequire(j, constName, packagePath) {\n * @returns - nothing\n */\n \n-function checkIfExistsAndAddValue(j, node, key, value) {\n+function checkIfExistsAndAddValue(j: Ijscodeshit, node: IPath<IObjectExpression>, key: string, value: string): void {","path":"lib/transformations/utils.js","position":135,"original_position":135,"commit_id":"4f4bba1b3dbbf5da4655899d4fbc703206c96763","original_commit_id":"4f4bba1b3dbbf5da4655899d4fbc703206c96763","user":{"login":"ev1stensberg","id":16735925,"avatar_url":"https://avatars0.githubusercontent.com/u/16735925?v=4","gravatar_id":"","url":"https://api.github.com/users/ev1stensberg","html_url":"https://github.com/ev1stensberg","followers_url":"https://api.github.com/users/ev1stensberg/followers","following_url":"https://api.github.com/users/ev1stensberg/following{/other_user}","gists_url":"https://api.github.com/users/ev1stensberg/gists{/gist_id}","starred_url":"https://api.github.com/users/ev1stensberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev1stensberg/subscriptions","organizations_url":"https://api.github.com/users/ev1stensberg/orgs","repos_url":"https://api.github.com/users/ev1stensberg/repos","events_url":"https://api.github.com/users/ev1stensberg/events{/privacy}","received_events_url":"https://api.github.com/users/ev1stensberg/received_events","type":"User","site_admin":false},"body":"Line length seems long","created_at":"2017-09-14T19:08:29Z","updated_at":"2017-09-14T19:08:29Z","html_url":"https://github.com/webpack/webpack-cli/pull/174#discussion_r138984719","pull_request_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/174","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments/138984719"},"html":{"href":"https://github.com/webpack/webpack-cli/pull/174#discussion_r138984719"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack-cli/pulls/174","id":132146412,"html_url":"https://github.com/webpack/webpack-cli/pull/174","diff_url":"https://github.com/webpack/webpack-cli/pull/174.diff","patch_url":"https://github.com/webpack/webpack-cli/pull/174.patch","issue_url":"https://api.github.com/repos/webpack/webpack-cli/issues/174","number":174,"state":"open","locked":false,"title":"[Feature] Added support to Flow inside transformations","user":{"login":"ematipico","id":602478,"avatar_url":"https://avatars3.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n\r\n**What kind of change does this PR introduce?**\r\nIntroduction of Flow inside the 'transformations' folder\r\n<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->\r\n\r\n**Did you add tests for your changes?**\r\nNo\r\n\r\n**If relevant, did you update the documentation?**\r\nNot need at the moment \r\n\r\n**Summary**\r\nAdded support of flow to the codebase inside the transformations folder. Created interfaces to support the source code.  \r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n<!-- Try to link to an open issue for more information. -->\r\n\r\n**Does this PR introduce a breaking change?**\r\n<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->\r\nNo\r\n\r\n**Other information**\r\n\r\nPlease have some time to review this PR. Let me know what you think about the naming convention (I tend to punt the capital I to identify an interface). Please make sure that the functionality is not broken. This PR doesn't break the existing tests","created_at":"2017-07-24T21:12:24Z","updated_at":"2017-09-14T19:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e90f14cc035d64d2bfdceaef81b143d6c310673f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/174/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/174/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/issues/174/comments","statuses_url":"https://api.github.com/repos/webpack/webpack-cli/statuses/4f4bba1b3dbbf5da4655899d4fbc703206c96763","head":{"label":"ematipico:feature/AddFlow","ref":"feature/AddFlow","sha":"4f4bba1b3dbbf5da4655899d4fbc703206c96763","user":{"login":"ematipico","id":602478,"avatar_url":"https://avatars3.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","site_admin":false},"repo":{"id":96634725,"name":"webpack-cli","full_name":"ematipico/webpack-cli","owner":{"login":"ematipico","id":602478,"avatar_url":"https://avatars3.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ematipico/webpack-cli","description":"webpack CLI","fork":true,"url":"https://api.github.com/repos/ematipico/webpack-cli","forks_url":"https://api.github.com/repos/ematipico/webpack-cli/forks","keys_url":"https://api.github.com/repos/ematipico/webpack-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ematipico/webpack-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ematipico/webpack-cli/teams","hooks_url":"https://api.github.com/repos/ematipico/webpack-cli/hooks","issue_events_url":"https://api.github.com/repos/ematipico/webpack-cli/issues/events{/number}","events_url":"https://api.github.com/repos/ematipico/webpack-cli/events","assignees_url":"https://api.github.com/repos/ematipico/webpack-cli/assignees{/user}","branches_url":"https://api.github.com/repos/ematipico/webpack-cli/branches{/branch}","tags_url":"https://api.github.com/repos/ematipico/webpack-cli/tags","blobs_url":"https://api.github.com/repos/ematipico/webpack-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ematipico/webpack-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ematipico/webpack-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/ematipico/webpack-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ematipico/webpack-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/ematipico/webpack-cli/languages","stargazers_url":"https://api.github.com/repos/ematipico/webpack-cli/stargazers","contributors_url":"https://api.github.com/repos/ematipico/webpack-cli/contributors","subscribers_url":"https://api.github.com/repos/ematipico/webpack-cli/subscribers","subscription_url":"https://api.github.com/repos/ematipico/webpack-cli/subscription","commits_url":"https://api.github.com/repos/ematipico/webpack-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/ematipico/webpack-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/ematipico/webpack-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/ematipico/webpack-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/ematipico/webpack-cli/contents/{+path}","compare_url":"https://api.github.com/repos/ematipico/webpack-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ematipico/webpack-cli/merges","archive_url":"https://api.github.com/repos/ematipico/webpack-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ematipico/webpack-cli/downloads","issues_url":"https://api.github.com/repos/ematipico/webpack-cli/issues{/number}","pulls_url":"https://api.github.com/repos/ematipico/webpack-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/ematipico/webpack-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/ematipico/webpack-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ematipico/webpack-cli/labels{/name}","releases_url":"https://api.github.com/repos/ematipico/webpack-cli/releases{/id}","deployments_url":"https://api.github.com/repos/ematipico/webpack-cli/deployments","created_at":"2017-07-08T17:46:24Z","updated_at":"2017-07-08T17:46:25Z","pushed_at":"2017-09-13T22:14:35Z","git_url":"git://github.com/ematipico/webpack-cli.git","ssh_url":"git@github.com:ematipico/webpack-cli.git","clone_url":"https://github.com/ematipico/webpack-cli.git","svn_url":"https://github.com/ematipico/webpack-cli","homepage":"","size":361,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:master","ref":"master","sha":"b3186a9c27fb7fc203051748d7524c5701af081c","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":76603199,"name":"webpack-cli","full_name":"webpack/webpack-cli","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack-cli","description":"webpack CLI","fork":false,"url":"https://api.github.com/repos/webpack/webpack-cli","forks_url":"https://api.github.com/repos/webpack/webpack-cli/forks","keys_url":"https://api.github.com/repos/webpack/webpack-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack-cli/teams","hooks_url":"https://api.github.com/repos/webpack/webpack-cli/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack-cli/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack-cli/events","assignees_url":"https://api.github.com/repos/webpack/webpack-cli/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack-cli/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack-cli/tags","blobs_url":"https://api.github.com/repos/webpack/webpack-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack-cli/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack-cli/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack-cli/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack-cli/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack-cli/subscription","commits_url":"https://api.github.com/repos/webpack/webpack-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack-cli/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack-cli/merges","archive_url":"https://api.github.com/repos/webpack/webpack-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack-cli/downloads","issues_url":"https://api.github.com/repos/webpack/webpack-cli/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack-cli/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack-cli/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack-cli/deployments","created_at":"2016-12-15T23:05:08Z","updated_at":"2017-09-09T10:13:27Z","pushed_at":"2017-09-13T22:14:37Z","git_url":"git://github.com/webpack/webpack-cli.git","ssh_url":"git@github.com:webpack/webpack-cli.git","clone_url":"https://github.com/webpack/webpack-cli.git","svn_url":"https://github.com/webpack/webpack-cli","homepage":"","size":441,"stargazers_count":455,"watchers_count":455,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":40,"forks":47,"open_issues":40,"watchers":455,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/174"},"html":{"href":"https://github.com/webpack/webpack-cli/pull/174"},"issue":{"href":"https://api.github.com/repos/webpack/webpack-cli/issues/174"},"comments":{"href":"https://api.github.com/repos/webpack/webpack-cli/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack-cli/statuses/4f4bba1b3dbbf5da4655899d4fbc703206c96763"}},"author_association":"NONE"}}
{"actor":{"display_login":"ev1stensberg"}}