{"action":"closed","number":85,"pull_request":{"url":"https://api.github.com/repos/uiri/toml/pulls/85","id":113289691,"html_url":"https://github.com/uiri/toml/pull/85","diff_url":"https://github.com/uiri/toml/pull/85.diff","patch_url":"https://github.com/uiri/toml/pull/85.patch","issue_url":"https://api.github.com/repos/uiri/toml/issues/85","number":85,"state":"closed","locked":false,"title":"Refactor _dump method and replaced range(len) with enumerate","user":{"login":"Jackevansevo","id":4996338,"avatar_url":"https://avatars2.githubusercontent.com/u/4996338?v=3","gravatar_id":"","url":"https://api.github.com/users/Jackevansevo","html_url":"https://github.com/Jackevansevo","followers_url":"https://api.github.com/users/Jackevansevo/followers","following_url":"https://api.github.com/users/Jackevansevo/following{/other_user}","gists_url":"https://api.github.com/users/Jackevansevo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jackevansevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jackevansevo/subscriptions","organizations_url":"https://api.github.com/users/Jackevansevo/orgs","repos_url":"https://api.github.com/users/Jackevansevo/repos","events_url":"https://api.github.com/users/Jackevansevo/events{/privacy}","received_events_url":"https://api.github.com/users/Jackevansevo/received_events","type":"User","site_admin":false},"body":"Refactored the _dump method to lookup corresponding method based on the values current type. Prevents repeated type checks on a single variable.\r\n\r\nAlso replaced use of `_range(len(sl))` with `enumerate` to iterate over the list `sl` storing the current value in `item` and index in `i`. This prevent repeated lookups of `sl` with `sl[i]`.\r\n\r\nEverything seems to work okay on my end after running and comparing the output with that of the master branch using:\r\n\r\n  `python toml_test.py < examples/example-v0.4.0.toml`\r\n\r\nIt could be the case that the PR completely crashes and burns when running the tests properly. Let me konw if that's the case as I might need some guidance running them correctly.\r\n\r\nCheers, Jack ","created_at":"2017-03-29T20:40:44Z","updated_at":"2017-04-11T23:19:47Z","closed_at":"2017-04-11T23:19:47Z","merged_at":"2017-04-11T23:19:47Z","merge_commit_sha":"9083bfae759d91c133a57d341a193562d6fff049","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uiri/toml/pulls/85/commits","review_comments_url":"https://api.github.com/repos/uiri/toml/pulls/85/comments","review_comment_url":"https://api.github.com/repos/uiri/toml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uiri/toml/issues/85/comments","statuses_url":"https://api.github.com/repos/uiri/toml/statuses/0cba522df4de5140976348a3ed23c550971090f6","head":{"label":"Jackevansevo:Jackevansevo","ref":"Jackevansevo","sha":"0cba522df4de5140976348a3ed23c550971090f6","user":{"login":"Jackevansevo","id":4996338,"avatar_url":"https://avatars2.githubusercontent.com/u/4996338?v=3","gravatar_id":"","url":"https://api.github.com/users/Jackevansevo","html_url":"https://github.com/Jackevansevo","followers_url":"https://api.github.com/users/Jackevansevo/followers","following_url":"https://api.github.com/users/Jackevansevo/following{/other_user}","gists_url":"https://api.github.com/users/Jackevansevo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jackevansevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jackevansevo/subscriptions","organizations_url":"https://api.github.com/users/Jackevansevo/orgs","repos_url":"https://api.github.com/users/Jackevansevo/repos","events_url":"https://api.github.com/users/Jackevansevo/events{/privacy}","received_events_url":"https://api.github.com/users/Jackevansevo/received_events","type":"User","site_admin":false},"repo":{"id":86616626,"name":"toml","full_name":"Jackevansevo/toml","owner":{"login":"Jackevansevo","id":4996338,"avatar_url":"https://avatars2.githubusercontent.com/u/4996338?v=3","gravatar_id":"","url":"https://api.github.com/users/Jackevansevo","html_url":"https://github.com/Jackevansevo","followers_url":"https://api.github.com/users/Jackevansevo/followers","following_url":"https://api.github.com/users/Jackevansevo/following{/other_user}","gists_url":"https://api.github.com/users/Jackevansevo/gists{/gist_id}","starred_url":"https://api.github.com/users/Jackevansevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jackevansevo/subscriptions","organizations_url":"https://api.github.com/users/Jackevansevo/orgs","repos_url":"https://api.github.com/users/Jackevansevo/repos","events_url":"https://api.github.com/users/Jackevansevo/events{/privacy}","received_events_url":"https://api.github.com/users/Jackevansevo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jackevansevo/toml","description":"Python lib for TOML","fork":true,"url":"https://api.github.com/repos/Jackevansevo/toml","forks_url":"https://api.github.com/repos/Jackevansevo/toml/forks","keys_url":"https://api.github.com/repos/Jackevansevo/toml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jackevansevo/toml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jackevansevo/toml/teams","hooks_url":"https://api.github.com/repos/Jackevansevo/toml/hooks","issue_events_url":"https://api.github.com/repos/Jackevansevo/toml/issues/events{/number}","events_url":"https://api.github.com/repos/Jackevansevo/toml/events","assignees_url":"https://api.github.com/repos/Jackevansevo/toml/assignees{/user}","branches_url":"https://api.github.com/repos/Jackevansevo/toml/branches{/branch}","tags_url":"https://api.github.com/repos/Jackevansevo/toml/tags","blobs_url":"https://api.github.com/repos/Jackevansevo/toml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jackevansevo/toml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jackevansevo/toml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jackevansevo/toml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jackevansevo/toml/statuses/{sha}","languages_url":"https://api.github.com/repos/Jackevansevo/toml/languages","stargazers_url":"https://api.github.com/repos/Jackevansevo/toml/stargazers","contributors_url":"https://api.github.com/repos/Jackevansevo/toml/contributors","subscribers_url":"https://api.github.com/repos/Jackevansevo/toml/subscribers","subscription_url":"https://api.github.com/repos/Jackevansevo/toml/subscription","commits_url":"https://api.github.com/repos/Jackevansevo/toml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jackevansevo/toml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jackevansevo/toml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jackevansevo/toml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jackevansevo/toml/contents/{+path}","compare_url":"https://api.github.com/repos/Jackevansevo/toml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jackevansevo/toml/merges","archive_url":"https://api.github.com/repos/Jackevansevo/toml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jackevansevo/toml/downloads","issues_url":"https://api.github.com/repos/Jackevansevo/toml/issues{/number}","pulls_url":"https://api.github.com/repos/Jackevansevo/toml/pulls{/number}","milestones_url":"https://api.github.com/repos/Jackevansevo/toml/milestones{/number}","notifications_url":"https://api.github.com/repos/Jackevansevo/toml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jackevansevo/toml/labels{/name}","releases_url":"https://api.github.com/repos/Jackevansevo/toml/releases{/id}","deployments_url":"https://api.github.com/repos/Jackevansevo/toml/deployments","created_at":"2017-03-29T18:35:02Z","updated_at":"2017-03-29T18:35:04Z","pushed_at":"2017-04-11T23:16:58Z","git_url":"git://github.com/Jackevansevo/toml.git","ssh_url":"git@github.com:Jackevansevo/toml.git","clone_url":"https://github.com/Jackevansevo/toml.git","svn_url":"https://github.com/Jackevansevo/toml","homepage":null,"size":123,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uiri:master","ref":"master","sha":"e176ae93d6a7d130d260a3b1240141b8e31dfd8d","user":{"login":"uiri","id":364765,"avatar_url":"https://avatars0.githubusercontent.com/u/364765?v=3","gravatar_id":"","url":"https://api.github.com/users/uiri","html_url":"https://github.com/uiri","followers_url":"https://api.github.com/users/uiri/followers","following_url":"https://api.github.com/users/uiri/following{/other_user}","gists_url":"https://api.github.com/users/uiri/gists{/gist_id}","starred_url":"https://api.github.com/users/uiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uiri/subscriptions","organizations_url":"https://api.github.com/users/uiri/orgs","repos_url":"https://api.github.com/users/uiri/repos","events_url":"https://api.github.com/users/uiri/events{/privacy}","received_events_url":"https://api.github.com/users/uiri/received_events","type":"User","site_admin":false},"repo":{"id":8387179,"name":"toml","full_name":"uiri/toml","owner":{"login":"uiri","id":364765,"avatar_url":"https://avatars0.githubusercontent.com/u/364765?v=3","gravatar_id":"","url":"https://api.github.com/users/uiri","html_url":"https://github.com/uiri","followers_url":"https://api.github.com/users/uiri/followers","following_url":"https://api.github.com/users/uiri/following{/other_user}","gists_url":"https://api.github.com/users/uiri/gists{/gist_id}","starred_url":"https://api.github.com/users/uiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uiri/subscriptions","organizations_url":"https://api.github.com/users/uiri/orgs","repos_url":"https://api.github.com/users/uiri/repos","events_url":"https://api.github.com/users/uiri/events{/privacy}","received_events_url":"https://api.github.com/users/uiri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uiri/toml","description":"Python lib for TOML","fork":false,"url":"https://api.github.com/repos/uiri/toml","forks_url":"https://api.github.com/repos/uiri/toml/forks","keys_url":"https://api.github.com/repos/uiri/toml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uiri/toml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uiri/toml/teams","hooks_url":"https://api.github.com/repos/uiri/toml/hooks","issue_events_url":"https://api.github.com/repos/uiri/toml/issues/events{/number}","events_url":"https://api.github.com/repos/uiri/toml/events","assignees_url":"https://api.github.com/repos/uiri/toml/assignees{/user}","branches_url":"https://api.github.com/repos/uiri/toml/branches{/branch}","tags_url":"https://api.github.com/repos/uiri/toml/tags","blobs_url":"https://api.github.com/repos/uiri/toml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uiri/toml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uiri/toml/git/refs{/sha}","trees_url":"https://api.github.com/repos/uiri/toml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uiri/toml/statuses/{sha}","languages_url":"https://api.github.com/repos/uiri/toml/languages","stargazers_url":"https://api.github.com/repos/uiri/toml/stargazers","contributors_url":"https://api.github.com/repos/uiri/toml/contributors","subscribers_url":"https://api.github.com/repos/uiri/toml/subscribers","subscription_url":"https://api.github.com/repos/uiri/toml/subscription","commits_url":"https://api.github.com/repos/uiri/toml/commits{/sha}","git_commits_url":"https://api.github.com/repos/uiri/toml/git/commits{/sha}","comments_url":"https://api.github.com/repos/uiri/toml/comments{/number}","issue_comment_url":"https://api.github.com/repos/uiri/toml/issues/comments{/number}","contents_url":"https://api.github.com/repos/uiri/toml/contents/{+path}","compare_url":"https://api.github.com/repos/uiri/toml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uiri/toml/merges","archive_url":"https://api.github.com/repos/uiri/toml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uiri/toml/downloads","issues_url":"https://api.github.com/repos/uiri/toml/issues{/number}","pulls_url":"https://api.github.com/repos/uiri/toml/pulls{/number}","milestones_url":"https://api.github.com/repos/uiri/toml/milestones{/number}","notifications_url":"https://api.github.com/repos/uiri/toml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uiri/toml/labels{/name}","releases_url":"https://api.github.com/repos/uiri/toml/releases{/id}","deployments_url":"https://api.github.com/repos/uiri/toml/deployments","created_at":"2013-02-24T06:07:30Z","updated_at":"2017-04-11T19:18:12Z","pushed_at":"2017-04-11T23:19:47Z","git_url":"git://github.com/uiri/toml.git","ssh_url":"git@github.com:uiri/toml.git","clone_url":"https://github.com/uiri/toml.git","svn_url":"https://github.com/uiri/toml","homepage":null,"size":153,"stargazers_count":157,"watchers_count":157,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":8,"forks":37,"open_issues":8,"watchers":157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uiri/toml/pulls/85"},"html":{"href":"https://github.com/uiri/toml/pull/85"},"issue":{"href":"https://api.github.com/repos/uiri/toml/issues/85"},"comments":{"href":"https://api.github.com/repos/uiri/toml/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/uiri/toml/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/uiri/toml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uiri/toml/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/uiri/toml/statuses/0cba522df4de5140976348a3ed23c550971090f6"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"uiri","id":364765,"avatar_url":"https://avatars0.githubusercontent.com/u/364765?v=3","gravatar_id":"","url":"https://api.github.com/users/uiri","html_url":"https://github.com/uiri","followers_url":"https://api.github.com/users/uiri/followers","following_url":"https://api.github.com/users/uiri/following{/other_user}","gists_url":"https://api.github.com/users/uiri/gists{/gist_id}","starred_url":"https://api.github.com/users/uiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uiri/subscriptions","organizations_url":"https://api.github.com/users/uiri/orgs","repos_url":"https://api.github.com/users/uiri/repos","events_url":"https://api.github.com/users/uiri/events{/privacy}","received_events_url":"https://api.github.com/users/uiri/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":60,"deletions":49,"changed_files":1}}
{"actor":{"display_login":"uiri"}}