{"action":"created","comment":{"url":"https://api.github.com/repos/cython/cython/pulls/comments/147519749","pull_request_review_id":72633931,"id":147519749,"diff_hunk":"@@ -358,7 +358,9 @@ def generate_c_code(self, env, options, result):\n \n         code = globalstate['before_global_var']\n         code.putln('#define __Pyx_MODULE_NAME \"%s\"' % self.full_module_name)\n-        code.putln(\"int %s%s = 0;\" % (Naming.module_is_main, self.full_module_name.replace('.', '__')))\n+        module_is_main = \"%s%s\" % (Naming.module_is_main, self.full_module_name.replace('.', '__'))\n+        code.putln(\"extern int %s;\" % module_is_main)\n+        code.putln(\"int %s = 0;\" % module_is_main)","path":"Cython/Compiler/ModuleNode.py","position":7,"original_position":7,"commit_id":"32e305ae01738d8a925248b9d0f4a08e187ce45c","original_commit_id":"4f636ed61c7f144b3926ec5b12f475e25adef06a","user":{"login":"dalcinl","id":294981,"avatar_url":"https://avatars1.githubusercontent.com/u/294981?v=4","gravatar_id":"","url":"https://api.github.com/users/dalcinl","html_url":"https://github.com/dalcinl","followers_url":"https://api.github.com/users/dalcinl/followers","following_url":"https://api.github.com/users/dalcinl/following{/other_user}","gists_url":"https://api.github.com/users/dalcinl/gists{/gist_id}","starred_url":"https://api.github.com/users/dalcinl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalcinl/subscriptions","organizations_url":"https://api.github.com/users/dalcinl/orgs","repos_url":"https://api.github.com/users/dalcinl/repos","events_url":"https://api.github.com/users/dalcinl/events{/privacy}","received_events_url":"https://api.github.com/users/dalcinl/received_events","type":"User","site_admin":false},"body":"@scoder Maybe is not really required, but look at `bin/cython_freeze`. Are you 100% sure that making it `static` will not break things?","created_at":"2017-10-27T21:23:35Z","updated_at":"2017-10-27T21:23:35Z","html_url":"https://github.com/cython/cython/pull/1951#discussion_r147519749","pull_request_url":"https://api.github.com/repos/cython/cython/pulls/1951","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cython/cython/pulls/comments/147519749"},"html":{"href":"https://github.com/cython/cython/pull/1951#discussion_r147519749"},"pull_request":{"href":"https://api.github.com/repos/cython/cython/pulls/1951"}},"in_reply_to_id":147511351},"pull_request":{"url":"https://api.github.com/repos/cython/cython/pulls/1951","id":149187717,"html_url":"https://github.com/cython/cython/pull/1951","diff_url":"https://github.com/cython/cython/pull/1951.diff","patch_url":"https://github.com/cython/cython/pull/1951.patch","issue_url":"https://api.github.com/repos/cython/cython/issues/1951","number":1951,"state":"open","locked":false,"title":"Minor C code generation/utility fixes","user":{"login":"dalcinl","id":294981,"avatar_url":"https://avatars1.githubusercontent.com/u/294981?v=4","gravatar_id":"","url":"https://api.github.com/users/dalcinl","html_url":"https://github.com/dalcinl","followers_url":"https://api.github.com/users/dalcinl/followers","following_url":"https://api.github.com/users/dalcinl/following{/other_user}","gists_url":"https://api.github.com/users/dalcinl/gists{/gist_id}","starred_url":"https://api.github.com/users/dalcinl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalcinl/subscriptions","organizations_url":"https://api.github.com/users/dalcinl/orgs","repos_url":"https://api.github.com/users/dalcinl/repos","events_url":"https://api.github.com/users/dalcinl/events{/privacy}","received_events_url":"https://api.github.com/users/dalcinl/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-27T13:21:45Z","updated_at":"2017-10-27T21:23:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f2ab89c75cbe60e341e81eb061c25691f354d97","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cython/cython/pulls/1951/commits","review_comments_url":"https://api.github.com/repos/cython/cython/pulls/1951/comments","review_comment_url":"https://api.github.com/repos/cython/cython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cython/cython/issues/1951/comments","statuses_url":"https://api.github.com/repos/cython/cython/statuses/32e305ae01738d8a925248b9d0f4a08e187ce45c","head":{"label":"cython:dalcinl/fix-release","ref":"dalcinl/fix-release","sha":"32e305ae01738d8a925248b9d0f4a08e187ce45c","user":{"login":"cython","id":486082,"avatar_url":"https://avatars3.githubusercontent.com/u/486082?v=4","gravatar_id":"","url":"https://api.github.com/users/cython","html_url":"https://github.com/cython","followers_url":"https://api.github.com/users/cython/followers","following_url":"https://api.github.com/users/cython/following{/other_user}","gists_url":"https://api.github.com/users/cython/gists{/gist_id}","starred_url":"https://api.github.com/users/cython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cython/subscriptions","organizations_url":"https://api.github.com/users/cython/orgs","repos_url":"https://api.github.com/users/cython/repos","events_url":"https://api.github.com/users/cython/events{/privacy}","received_events_url":"https://api.github.com/users/cython/received_events","type":"Organization","site_admin":false},"repo":{"id":1099265,"name":"cython","full_name":"cython/cython","owner":{"login":"cython","id":486082,"avatar_url":"https://avatars3.githubusercontent.com/u/486082?v=4","gravatar_id":"","url":"https://api.github.com/users/cython","html_url":"https://github.com/cython","followers_url":"https://api.github.com/users/cython/followers","following_url":"https://api.github.com/users/cython/following{/other_user}","gists_url":"https://api.github.com/users/cython/gists{/gist_id}","starred_url":"https://api.github.com/users/cython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cython/subscriptions","organizations_url":"https://api.github.com/users/cython/orgs","repos_url":"https://api.github.com/users/cython/repos","events_url":"https://api.github.com/users/cython/events{/privacy}","received_events_url":"https://api.github.com/users/cython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cython/cython","description":"A Python to C compiler","fork":false,"url":"https://api.github.com/repos/cython/cython","forks_url":"https://api.github.com/repos/cython/cython/forks","keys_url":"https://api.github.com/repos/cython/cython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cython/cython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cython/cython/teams","hooks_url":"https://api.github.com/repos/cython/cython/hooks","issue_events_url":"https://api.github.com/repos/cython/cython/issues/events{/number}","events_url":"https://api.github.com/repos/cython/cython/events","assignees_url":"https://api.github.com/repos/cython/cython/assignees{/user}","branches_url":"https://api.github.com/repos/cython/cython/branches{/branch}","tags_url":"https://api.github.com/repos/cython/cython/tags","blobs_url":"https://api.github.com/repos/cython/cython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cython/cython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cython/cython/git/refs{/sha}","trees_url":"https://api.github.com/repos/cython/cython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cython/cython/statuses/{sha}","languages_url":"https://api.github.com/repos/cython/cython/languages","stargazers_url":"https://api.github.com/repos/cython/cython/stargazers","contributors_url":"https://api.github.com/repos/cython/cython/contributors","subscribers_url":"https://api.github.com/repos/cython/cython/subscribers","subscription_url":"https://api.github.com/repos/cython/cython/subscription","commits_url":"https://api.github.com/repos/cython/cython/commits{/sha}","git_commits_url":"https://api.github.com/repos/cython/cython/git/commits{/sha}","comments_url":"https://api.github.com/repos/cython/cython/comments{/number}","issue_comment_url":"https://api.github.com/repos/cython/cython/issues/comments{/number}","contents_url":"https://api.github.com/repos/cython/cython/contents/{+path}","compare_url":"https://api.github.com/repos/cython/cython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cython/cython/merges","archive_url":"https://api.github.com/repos/cython/cython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cython/cython/downloads","issues_url":"https://api.github.com/repos/cython/cython/issues{/number}","pulls_url":"https://api.github.com/repos/cython/cython/pulls{/number}","milestones_url":"https://api.github.com/repos/cython/cython/milestones{/number}","notifications_url":"https://api.github.com/repos/cython/cython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cython/cython/labels{/name}","releases_url":"https://api.github.com/repos/cython/cython/releases{/id}","deployments_url":"https://api.github.com/repos/cython/cython/deployments","created_at":"2010-11-21T07:44:20Z","updated_at":"2017-10-27T15:04:55Z","pushed_at":"2017-10-27T14:38:45Z","git_url":"git://github.com/cython/cython.git","ssh_url":"git@github.com:cython/cython.git","clone_url":"https://github.com/cython/cython.git","svn_url":"https://github.com/cython/cython","homepage":"http://cython.org","size":49054,"stargazers_count":2614,"watchers_count":2614,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":591,"mirror_url":null,"archived":false,"open_issues_count":440,"forks":591,"open_issues":440,"watchers":2614,"default_branch":"master"}},"base":{"label":"cython:release","ref":"release","sha":"0992c63ef803ae02d2d048f6b3097422dac89323","user":{"login":"cython","id":486082,"avatar_url":"https://avatars3.githubusercontent.com/u/486082?v=4","gravatar_id":"","url":"https://api.github.com/users/cython","html_url":"https://github.com/cython","followers_url":"https://api.github.com/users/cython/followers","following_url":"https://api.github.com/users/cython/following{/other_user}","gists_url":"https://api.github.com/users/cython/gists{/gist_id}","starred_url":"https://api.github.com/users/cython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cython/subscriptions","organizations_url":"https://api.github.com/users/cython/orgs","repos_url":"https://api.github.com/users/cython/repos","events_url":"https://api.github.com/users/cython/events{/privacy}","received_events_url":"https://api.github.com/users/cython/received_events","type":"Organization","site_admin":false},"repo":{"id":1099265,"name":"cython","full_name":"cython/cython","owner":{"login":"cython","id":486082,"avatar_url":"https://avatars3.githubusercontent.com/u/486082?v=4","gravatar_id":"","url":"https://api.github.com/users/cython","html_url":"https://github.com/cython","followers_url":"https://api.github.com/users/cython/followers","following_url":"https://api.github.com/users/cython/following{/other_user}","gists_url":"https://api.github.com/users/cython/gists{/gist_id}","starred_url":"https://api.github.com/users/cython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cython/subscriptions","organizations_url":"https://api.github.com/users/cython/orgs","repos_url":"https://api.github.com/users/cython/repos","events_url":"https://api.github.com/users/cython/events{/privacy}","received_events_url":"https://api.github.com/users/cython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cython/cython","description":"A Python to C compiler","fork":false,"url":"https://api.github.com/repos/cython/cython","forks_url":"https://api.github.com/repos/cython/cython/forks","keys_url":"https://api.github.com/repos/cython/cython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cython/cython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cython/cython/teams","hooks_url":"https://api.github.com/repos/cython/cython/hooks","issue_events_url":"https://api.github.com/repos/cython/cython/issues/events{/number}","events_url":"https://api.github.com/repos/cython/cython/events","assignees_url":"https://api.github.com/repos/cython/cython/assignees{/user}","branches_url":"https://api.github.com/repos/cython/cython/branches{/branch}","tags_url":"https://api.github.com/repos/cython/cython/tags","blobs_url":"https://api.github.com/repos/cython/cython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cython/cython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cython/cython/git/refs{/sha}","trees_url":"https://api.github.com/repos/cython/cython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cython/cython/statuses/{sha}","languages_url":"https://api.github.com/repos/cython/cython/languages","stargazers_url":"https://api.github.com/repos/cython/cython/stargazers","contributors_url":"https://api.github.com/repos/cython/cython/contributors","subscribers_url":"https://api.github.com/repos/cython/cython/subscribers","subscription_url":"https://api.github.com/repos/cython/cython/subscription","commits_url":"https://api.github.com/repos/cython/cython/commits{/sha}","git_commits_url":"https://api.github.com/repos/cython/cython/git/commits{/sha}","comments_url":"https://api.github.com/repos/cython/cython/comments{/number}","issue_comment_url":"https://api.github.com/repos/cython/cython/issues/comments{/number}","contents_url":"https://api.github.com/repos/cython/cython/contents/{+path}","compare_url":"https://api.github.com/repos/cython/cython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cython/cython/merges","archive_url":"https://api.github.com/repos/cython/cython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cython/cython/downloads","issues_url":"https://api.github.com/repos/cython/cython/issues{/number}","pulls_url":"https://api.github.com/repos/cython/cython/pulls{/number}","milestones_url":"https://api.github.com/repos/cython/cython/milestones{/number}","notifications_url":"https://api.github.com/repos/cython/cython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cython/cython/labels{/name}","releases_url":"https://api.github.com/repos/cython/cython/releases{/id}","deployments_url":"https://api.github.com/repos/cython/cython/deployments","created_at":"2010-11-21T07:44:20Z","updated_at":"2017-10-27T15:04:55Z","pushed_at":"2017-10-27T14:38:45Z","git_url":"git://github.com/cython/cython.git","ssh_url":"git@github.com:cython/cython.git","clone_url":"https://github.com/cython/cython.git","svn_url":"https://github.com/cython/cython","homepage":"http://cython.org","size":49054,"stargazers_count":2614,"watchers_count":2614,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":591,"mirror_url":null,"archived":false,"open_issues_count":440,"forks":591,"open_issues":440,"watchers":2614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cython/cython/pulls/1951"},"html":{"href":"https://github.com/cython/cython/pull/1951"},"issue":{"href":"https://api.github.com/repos/cython/cython/issues/1951"},"comments":{"href":"https://api.github.com/repos/cython/cython/issues/1951/comments"},"review_comments":{"href":"https://api.github.com/repos/cython/cython/pulls/1951/comments"},"review_comment":{"href":"https://api.github.com/repos/cython/cython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cython/cython/pulls/1951/commits"},"statuses":{"href":"https://api.github.com/repos/cython/cython/statuses/32e305ae01738d8a925248b9d0f4a08e187ce45c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dalcinl"}}