{"action":"created","comment":{"url":"https://api.github.com/repos/containerd/containerd/pulls/comments/133452435","pull_request_review_id":56632839,"id":133452435,"diff_hunk":"@@ -203,6 +222,24 @@ func (s *containerStore) Delete(ctx context.Context, id string) error {\n \treturn err\n }\n \n+func validateContainer(container *containers.Container) error {\n+\tif err := identifiers.Validate(container.ID); err != nil {\n+\t\treturn errors.Wrapf(err, \"container.ID validation error\")\n+\t}\n+\n+\t// labels and image have no validation\n+","path":"metadata/containers.go","position":112,"original_position":112,"commit_id":"6c864dc3fce060dd154a79e246c3770cc17dd39d","original_commit_id":"6c864dc3fce060dd154a79e246c3770cc17dd39d","user":{"login":"estesp","id":1397980,"avatar_url":"https://avatars0.githubusercontent.com/u/1397980?v=4","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"body":"nit: extra newline/blank space here?","created_at":"2017-08-16T13:42:06Z","updated_at":"2017-08-16T13:43:07Z","html_url":"https://github.com/containerd/containerd/pull/1366#discussion_r133452435","pull_request_url":"https://api.github.com/repos/containerd/containerd/pulls/1366","_links":{"self":{"href":"https://api.github.com/repos/containerd/containerd/pulls/comments/133452435"},"html":{"href":"https://github.com/containerd/containerd/pull/1366#discussion_r133452435"},"pull_request":{"href":"https://api.github.com/repos/containerd/containerd/pulls/1366"}}},"pull_request":{"url":"https://api.github.com/repos/containerd/containerd/pulls/1366","id":135924106,"html_url":"https://github.com/containerd/containerd/pull/1366","diff_url":"https://github.com/containerd/containerd/pull/1366.diff","patch_url":"https://github.com/containerd/containerd/pull/1366.patch","issue_url":"https://api.github.com/repos/containerd/containerd/issues/1366","number":1366,"state":"open","locked":false,"title":"metadata: ensure correct updates on Container","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars1.githubusercontent.com/u/120601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"body":"This fixes a few bugs in the container store related to reading and\r\nwriting fields. Specifically, on update, the full field set wasn't being\r\nreturned to the caller, making it appear that the store was corrupted.\r\nWe now return the correctly updated field and store the missing field\r\nthat was omitted in the original implementation. In course, we also have\r\ndefined the update semantics of each field, as well as whether or not\r\nthey are required.\r\n\r\nThe big addition here is really the container metadata testsuite. It\r\ncovers listing, filtering, creates, updates and deletes in a vareity of\r\nscenarios.\r\n\r\nSigned-off-by: Stephen J Day <stephen.day@docker.com>\r\n\r\nCovers part of #1357","created_at":"2017-08-16T01:27:51Z","updated_at":"2017-08-16T13:43:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"754651a7247a6d9beebc38e2f5077eda40fda212","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/containerd/containerd/milestones/9","html_url":"https://github.com/containerd/containerd/milestone/9","labels_url":"https://api.github.com/repos/containerd/containerd/milestones/9/labels","id":2632823,"number":9,"title":"containerd beta","description":"1.0 beta quality release","creator":{"login":"estesp","id":1397980,"avatar_url":"https://avatars0.githubusercontent.com/u/1397980?v=4","gravatar_id":"","url":"https://api.github.com/users/estesp","html_url":"https://github.com/estesp","followers_url":"https://api.github.com/users/estesp/followers","following_url":"https://api.github.com/users/estesp/following{/other_user}","gists_url":"https://api.github.com/users/estesp/gists{/gist_id}","starred_url":"https://api.github.com/users/estesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estesp/subscriptions","organizations_url":"https://api.github.com/users/estesp/orgs","repos_url":"https://api.github.com/users/estesp/repos","events_url":"https://api.github.com/users/estesp/events{/privacy}","received_events_url":"https://api.github.com/users/estesp/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":29,"state":"open","created_at":"2017-07-10T20:33:50Z","updated_at":"2017-08-16T01:28:53Z","due_on":"2017-08-16T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/containerd/containerd/pulls/1366/commits","review_comments_url":"https://api.github.com/repos/containerd/containerd/pulls/1366/comments","review_comment_url":"https://api.github.com/repos/containerd/containerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containerd/containerd/issues/1366/comments","statuses_url":"https://api.github.com/repos/containerd/containerd/statuses/6c864dc3fce060dd154a79e246c3770cc17dd39d","head":{"label":"stevvooe:containers-metadata-tests","ref":"containers-metadata-tests","sha":"6c864dc3fce060dd154a79e246c3770cc17dd39d","user":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars1.githubusercontent.com/u/120601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"repo":{"id":78895238,"name":"containerd","full_name":"stevvooe/containerd","owner":{"login":"stevvooe","id":120601,"avatar_url":"https://avatars1.githubusercontent.com/u/120601?v=4","gravatar_id":"","url":"https://api.github.com/users/stevvooe","html_url":"https://github.com/stevvooe","followers_url":"https://api.github.com/users/stevvooe/followers","following_url":"https://api.github.com/users/stevvooe/following{/other_user}","gists_url":"https://api.github.com/users/stevvooe/gists{/gist_id}","starred_url":"https://api.github.com/users/stevvooe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevvooe/subscriptions","organizations_url":"https://api.github.com/users/stevvooe/orgs","repos_url":"https://api.github.com/users/stevvooe/repos","events_url":"https://api.github.com/users/stevvooe/events{/privacy}","received_events_url":"https://api.github.com/users/stevvooe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevvooe/containerd","description":"An open and reliable container runtime, by Docker","fork":true,"url":"https://api.github.com/repos/stevvooe/containerd","forks_url":"https://api.github.com/repos/stevvooe/containerd/forks","keys_url":"https://api.github.com/repos/stevvooe/containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevvooe/containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevvooe/containerd/teams","hooks_url":"https://api.github.com/repos/stevvooe/containerd/hooks","issue_events_url":"https://api.github.com/repos/stevvooe/containerd/issues/events{/number}","events_url":"https://api.github.com/repos/stevvooe/containerd/events","assignees_url":"https://api.github.com/repos/stevvooe/containerd/assignees{/user}","branches_url":"https://api.github.com/repos/stevvooe/containerd/branches{/branch}","tags_url":"https://api.github.com/repos/stevvooe/containerd/tags","blobs_url":"https://api.github.com/repos/stevvooe/containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevvooe/containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevvooe/containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevvooe/containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevvooe/containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/stevvooe/containerd/languages","stargazers_url":"https://api.github.com/repos/stevvooe/containerd/stargazers","contributors_url":"https://api.github.com/repos/stevvooe/containerd/contributors","subscribers_url":"https://api.github.com/repos/stevvooe/containerd/subscribers","subscription_url":"https://api.github.com/repos/stevvooe/containerd/subscription","commits_url":"https://api.github.com/repos/stevvooe/containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevvooe/containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevvooe/containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevvooe/containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevvooe/containerd/contents/{+path}","compare_url":"https://api.github.com/repos/stevvooe/containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevvooe/containerd/merges","archive_url":"https://api.github.com/repos/stevvooe/containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevvooe/containerd/downloads","issues_url":"https://api.github.com/repos/stevvooe/containerd/issues{/number}","pulls_url":"https://api.github.com/repos/stevvooe/containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/stevvooe/containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/stevvooe/containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevvooe/containerd/labels{/name}","releases_url":"https://api.github.com/repos/stevvooe/containerd/releases{/id}","deployments_url":"https://api.github.com/repos/stevvooe/containerd/deployments","created_at":"2017-01-13T23:34:31Z","updated_at":"2017-01-13T23:35:38Z","pushed_at":"2017-08-16T01:35:57Z","git_url":"git://github.com/stevvooe/containerd.git","ssh_url":"git@github.com:stevvooe/containerd.git","clone_url":"https://github.com/stevvooe/containerd.git","svn_url":"https://github.com/stevvooe/containerd","homepage":"https://containerd.io","size":36296,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containerd:master","ref":"master","sha":"4703b99ac0df71c817d5d34ea9c33b960cb71a83","user":{"login":"containerd","id":14037953,"avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"repo":{"id":46089560,"name":"containerd","full_name":"containerd/containerd","owner":{"login":"containerd","id":14037953,"avatar_url":"https://avatars1.githubusercontent.com/u/14037953?v=4","gravatar_id":"","url":"https://api.github.com/users/containerd","html_url":"https://github.com/containerd","followers_url":"https://api.github.com/users/containerd/followers","following_url":"https://api.github.com/users/containerd/following{/other_user}","gists_url":"https://api.github.com/users/containerd/gists{/gist_id}","starred_url":"https://api.github.com/users/containerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containerd/subscriptions","organizations_url":"https://api.github.com/users/containerd/orgs","repos_url":"https://api.github.com/users/containerd/repos","events_url":"https://api.github.com/users/containerd/events{/privacy}","received_events_url":"https://api.github.com/users/containerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containerd/containerd","description":"An open and reliable container runtime","fork":false,"url":"https://api.github.com/repos/containerd/containerd","forks_url":"https://api.github.com/repos/containerd/containerd/forks","keys_url":"https://api.github.com/repos/containerd/containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containerd/containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containerd/containerd/teams","hooks_url":"https://api.github.com/repos/containerd/containerd/hooks","issue_events_url":"https://api.github.com/repos/containerd/containerd/issues/events{/number}","events_url":"https://api.github.com/repos/containerd/containerd/events","assignees_url":"https://api.github.com/repos/containerd/containerd/assignees{/user}","branches_url":"https://api.github.com/repos/containerd/containerd/branches{/branch}","tags_url":"https://api.github.com/repos/containerd/containerd/tags","blobs_url":"https://api.github.com/repos/containerd/containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containerd/containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containerd/containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/containerd/containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containerd/containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/containerd/containerd/languages","stargazers_url":"https://api.github.com/repos/containerd/containerd/stargazers","contributors_url":"https://api.github.com/repos/containerd/containerd/contributors","subscribers_url":"https://api.github.com/repos/containerd/containerd/subscribers","subscription_url":"https://api.github.com/repos/containerd/containerd/subscription","commits_url":"https://api.github.com/repos/containerd/containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/containerd/containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/containerd/containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/containerd/containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/containerd/containerd/contents/{+path}","compare_url":"https://api.github.com/repos/containerd/containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containerd/containerd/merges","archive_url":"https://api.github.com/repos/containerd/containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containerd/containerd/downloads","issues_url":"https://api.github.com/repos/containerd/containerd/issues{/number}","pulls_url":"https://api.github.com/repos/containerd/containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/containerd/containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/containerd/containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containerd/containerd/labels{/name}","releases_url":"https://api.github.com/repos/containerd/containerd/releases{/id}","deployments_url":"https://api.github.com/repos/containerd/containerd/deployments","created_at":"2015-11-13T00:27:43Z","updated_at":"2017-08-16T04:05:53Z","pushed_at":"2017-08-16T08:41:10Z","git_url":"git://github.com/containerd/containerd.git","ssh_url":"git@github.com:containerd/containerd.git","clone_url":"https://github.com/containerd/containerd.git","svn_url":"https://github.com/containerd/containerd","homepage":"https://containerd.io","size":36736,"stargazers_count":1631,"watchers_count":1631,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":333,"mirror_url":null,"open_issues_count":77,"forks":333,"open_issues":77,"watchers":1631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containerd/containerd/pulls/1366"},"html":{"href":"https://github.com/containerd/containerd/pull/1366"},"issue":{"href":"https://api.github.com/repos/containerd/containerd/issues/1366"},"comments":{"href":"https://api.github.com/repos/containerd/containerd/issues/1366/comments"},"review_comments":{"href":"https://api.github.com/repos/containerd/containerd/pulls/1366/comments"},"review_comment":{"href":"https://api.github.com/repos/containerd/containerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containerd/containerd/pulls/1366/commits"},"statuses":{"href":"https://api.github.com/repos/containerd/containerd/statuses/6c864dc3fce060dd154a79e246c3770cc17dd39d"}}}}
{"actor":{"display_login":"estesp"}}