{"action":"created","comment":{"url":"https://api.github.com/repos/Scribery/cockpit/pulls/comments/134952134","pull_request_review_id":58304467,"id":134952134,"diff_hunk":"@@ -340,7 +349,7 @@\n          * Set the cockpit location to point to the specified recording.\n          */\n         navigateToRecording(recording) {\n-            cockpit.location.go([recording.id]);\n+            cockpit.location.go([], $.extend(cockpit.location.options, { id: recording.id }));","path":"pkg/session_recording/recordings.jsx","position":41,"original_position":40,"commit_id":"0f3d66c49ab985cac4dbb857be03929bf33206e3","original_commit_id":"017fd820b22f94c8fafb390ba5e8948bbc28a520","user":{"login":"spbnick","id":549246,"avatar_url":"https://avatars3.githubusercontent.com/u/549246?v=4","gravatar_id":"","url":"https://api.github.com/users/spbnick","html_url":"https://github.com/spbnick","followers_url":"https://api.github.com/users/spbnick/followers","following_url":"https://api.github.com/users/spbnick/following{/other_user}","gists_url":"https://api.github.com/users/spbnick/gists{/gist_id}","starred_url":"https://api.github.com/users/spbnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spbnick/subscriptions","organizations_url":"https://api.github.com/users/spbnick/orgs","repos_url":"https://api.github.com/users/spbnick/repos","events_url":"https://api.github.com/users/spbnick/events{/privacy}","received_events_url":"https://api.github.com/users/spbnick/received_events","type":"User","site_admin":false},"body":"Yes, that's a good point. It would be useful to have the filtering options remembered and passed with the links.\r\n\r\nHowever, can't we combine the two, perhaps? Have the ID as part of the \"cockpit path\", in the \"fragment\" part of the [URL](https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Syntax), and the filters in \"cockpit options\", in the \"query\" part?","created_at":"2017-08-24T08:10:37Z","updated_at":"2017-08-24T08:10:37Z","html_url":"https://github.com/Scribery/cockpit/pull/21#discussion_r134952134","pull_request_url":"https://api.github.com/repos/Scribery/cockpit/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/comments/134952134"},"html":{"href":"https://github.com/Scribery/cockpit/pull/21#discussion_r134952134"},"pull_request":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/Scribery/cockpit/pulls/21","id":136463952,"html_url":"https://github.com/Scribery/cockpit/pull/21","diff_url":"https://github.com/Scribery/cockpit/pull/21.diff","patch_url":"https://github.com/Scribery/cockpit/pull/21.patch","issue_url":"https://api.github.com/repos/Scribery/cockpit/issues/21","number":21,"state":"open","locked":false,"title":"URL history and values saving","user":{"login":"sabbaka","id":5558501,"avatar_url":"https://avatars0.githubusercontent.com/u/5558501?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbaka","html_url":"https://github.com/sabbaka","followers_url":"https://api.github.com/users/sabbaka/followers","following_url":"https://api.github.com/users/sabbaka/following{/other_user}","gists_url":"https://api.github.com/users/sabbaka/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbaka/subscriptions","organizations_url":"https://api.github.com/users/sabbaka/orgs","repos_url":"https://api.github.com/users/sabbaka/repos","events_url":"https://api.github.com/users/sabbaka/events{/privacy}","received_events_url":"https://api.github.com/users/sabbaka/received_events","type":"User","site_admin":false},"body":"In this pull request issues #13 and #15 are both fixed.","created_at":"2017-08-18T12:03:48Z","updated_at":"2017-08-24T08:10:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"711f4b6913ce4ef621d0d79f0fd760552e8fe86f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Scribery/cockpit/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Scribery/cockpit/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Scribery/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Scribery/cockpit/issues/21/comments","statuses_url":"https://api.github.com/repos/Scribery/cockpit/statuses/0f3d66c49ab985cac4dbb857be03929bf33206e3","head":{"label":"sabbaka:url_history","ref":"url_history","sha":"0f3d66c49ab985cac4dbb857be03929bf33206e3","user":{"login":"sabbaka","id":5558501,"avatar_url":"https://avatars0.githubusercontent.com/u/5558501?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbaka","html_url":"https://github.com/sabbaka","followers_url":"https://api.github.com/users/sabbaka/followers","following_url":"https://api.github.com/users/sabbaka/following{/other_user}","gists_url":"https://api.github.com/users/sabbaka/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbaka/subscriptions","organizations_url":"https://api.github.com/users/sabbaka/orgs","repos_url":"https://api.github.com/users/sabbaka/repos","events_url":"https://api.github.com/users/sabbaka/events{/privacy}","received_events_url":"https://api.github.com/users/sabbaka/received_events","type":"User","site_admin":false},"repo":{"id":97018539,"name":"cockpit","full_name":"sabbaka/cockpit","owner":{"login":"sabbaka","id":5558501,"avatar_url":"https://avatars0.githubusercontent.com/u/5558501?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbaka","html_url":"https://github.com/sabbaka","followers_url":"https://api.github.com/users/sabbaka/followers","following_url":"https://api.github.com/users/sabbaka/following{/other_user}","gists_url":"https://api.github.com/users/sabbaka/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbaka/subscriptions","organizations_url":"https://api.github.com/users/sabbaka/orgs","repos_url":"https://api.github.com/users/sabbaka/repos","events_url":"https://api.github.com/users/sabbaka/events{/privacy}","received_events_url":"https://api.github.com/users/sabbaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sabbaka/cockpit","description":"Cockpit fork for work on Session Recording UI","fork":true,"url":"https://api.github.com/repos/sabbaka/cockpit","forks_url":"https://api.github.com/repos/sabbaka/cockpit/forks","keys_url":"https://api.github.com/repos/sabbaka/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sabbaka/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sabbaka/cockpit/teams","hooks_url":"https://api.github.com/repos/sabbaka/cockpit/hooks","issue_events_url":"https://api.github.com/repos/sabbaka/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/sabbaka/cockpit/events","assignees_url":"https://api.github.com/repos/sabbaka/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/sabbaka/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/sabbaka/cockpit/tags","blobs_url":"https://api.github.com/repos/sabbaka/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sabbaka/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sabbaka/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/sabbaka/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sabbaka/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/sabbaka/cockpit/languages","stargazers_url":"https://api.github.com/repos/sabbaka/cockpit/stargazers","contributors_url":"https://api.github.com/repos/sabbaka/cockpit/contributors","subscribers_url":"https://api.github.com/repos/sabbaka/cockpit/subscribers","subscription_url":"https://api.github.com/repos/sabbaka/cockpit/subscription","commits_url":"https://api.github.com/repos/sabbaka/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/sabbaka/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/sabbaka/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/sabbaka/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/sabbaka/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/sabbaka/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sabbaka/cockpit/merges","archive_url":"https://api.github.com/repos/sabbaka/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sabbaka/cockpit/downloads","issues_url":"https://api.github.com/repos/sabbaka/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/sabbaka/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/sabbaka/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/sabbaka/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sabbaka/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/sabbaka/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/sabbaka/cockpit/deployments","created_at":"2017-07-12T14:39:05Z","updated_at":"2017-07-12T14:39:11Z","pushed_at":"2017-08-23T07:40:41Z","git_url":"git://github.com/sabbaka/cockpit.git","ssh_url":"git@github.com:sabbaka/cockpit.git","clone_url":"https://github.com/sabbaka/cockpit.git","svn_url":"https://github.com/sabbaka/cockpit","homepage":"http://www.cockpit-project.org/","size":34453,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Scribery:scribery_poc","ref":"scribery_poc","sha":"f16b6f738dcf67dad4f532af69fd7a217bcbed93","user":{"login":"Scribery","id":17722920,"avatar_url":"https://avatars2.githubusercontent.com/u/17722920?v=4","gravatar_id":"","url":"https://api.github.com/users/Scribery","html_url":"https://github.com/Scribery","followers_url":"https://api.github.com/users/Scribery/followers","following_url":"https://api.github.com/users/Scribery/following{/other_user}","gists_url":"https://api.github.com/users/Scribery/gists{/gist_id}","starred_url":"https://api.github.com/users/Scribery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scribery/subscriptions","organizations_url":"https://api.github.com/users/Scribery/orgs","repos_url":"https://api.github.com/users/Scribery/repos","events_url":"https://api.github.com/users/Scribery/events{/privacy}","received_events_url":"https://api.github.com/users/Scribery/received_events","type":"Organization","site_admin":false},"repo":{"id":96337975,"name":"cockpit","full_name":"Scribery/cockpit","owner":{"login":"Scribery","id":17722920,"avatar_url":"https://avatars2.githubusercontent.com/u/17722920?v=4","gravatar_id":"","url":"https://api.github.com/users/Scribery","html_url":"https://github.com/Scribery","followers_url":"https://api.github.com/users/Scribery/followers","following_url":"https://api.github.com/users/Scribery/following{/other_user}","gists_url":"https://api.github.com/users/Scribery/gists{/gist_id}","starred_url":"https://api.github.com/users/Scribery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scribery/subscriptions","organizations_url":"https://api.github.com/users/Scribery/orgs","repos_url":"https://api.github.com/users/Scribery/repos","events_url":"https://api.github.com/users/Scribery/events{/privacy}","received_events_url":"https://api.github.com/users/Scribery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Scribery/cockpit","description":"Cockpit fork for work on Session Recording UI","fork":true,"url":"https://api.github.com/repos/Scribery/cockpit","forks_url":"https://api.github.com/repos/Scribery/cockpit/forks","keys_url":"https://api.github.com/repos/Scribery/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scribery/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scribery/cockpit/teams","hooks_url":"https://api.github.com/repos/Scribery/cockpit/hooks","issue_events_url":"https://api.github.com/repos/Scribery/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/Scribery/cockpit/events","assignees_url":"https://api.github.com/repos/Scribery/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/Scribery/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/Scribery/cockpit/tags","blobs_url":"https://api.github.com/repos/Scribery/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scribery/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scribery/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scribery/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scribery/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/Scribery/cockpit/languages","stargazers_url":"https://api.github.com/repos/Scribery/cockpit/stargazers","contributors_url":"https://api.github.com/repos/Scribery/cockpit/contributors","subscribers_url":"https://api.github.com/repos/Scribery/cockpit/subscribers","subscription_url":"https://api.github.com/repos/Scribery/cockpit/subscription","commits_url":"https://api.github.com/repos/Scribery/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scribery/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scribery/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scribery/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scribery/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/Scribery/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scribery/cockpit/merges","archive_url":"https://api.github.com/repos/Scribery/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scribery/cockpit/downloads","issues_url":"https://api.github.com/repos/Scribery/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/Scribery/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/Scribery/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/Scribery/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scribery/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/Scribery/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/Scribery/cockpit/deployments","created_at":"2017-07-05T16:08:47Z","updated_at":"2017-07-13T21:05:31Z","pushed_at":"2017-08-23T07:40:43Z","git_url":"git://github.com/Scribery/cockpit.git","ssh_url":"git@github.com:Scribery/cockpit.git","clone_url":"https://github.com/Scribery/cockpit.git","svn_url":"https://github.com/Scribery/cockpit","homepage":"http://www.cockpit-project.org/","size":34443,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/21"},"html":{"href":"https://github.com/Scribery/cockpit/pull/21"},"issue":{"href":"https://api.github.com/repos/Scribery/cockpit/issues/21"},"comments":{"href":"https://api.github.com/repos/Scribery/cockpit/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Scribery/cockpit/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Scribery/cockpit/statuses/0f3d66c49ab985cac4dbb857be03929bf33206e3"}}}}
{"actor":{"display_login":"spbnick"}}