{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/105078300","pull_request_review_id":25940367,"id":105078300,"diff_hunk":"@@ -1,6 +1,6 @@\n # Verify symbols from libswiftCore.dylib.\n \n-UNSUPPORTED: OS=linux\n+UNSUPPORTED: OS=linux-gnu","path":"validation-test/stdlib/RuntimeSymbols.swift","position":null,"original_position":4,"commit_id":"57efcf2a388fc2e6d6e7557651a91e04f30c496b","original_commit_id":"dd44011a420269f05a58a5ca4bcf348b99b69323","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars1.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"I'm not sure that's actually an improvement. We'll never use it anywhere else. It's probably okay to just have two tests.","created_at":"2017-03-09T03:07:13Z","updated_at":"2017-03-09T03:07:13Z","html_url":"https://github.com/apple/swift/pull/7989#discussion_r105078300","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/7989","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/105078300"},"html":{"href":"https://github.com/apple/swift/pull/7989#discussion_r105078300"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/7989"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/7989","id":109820199,"html_url":"https://github.com/apple/swift/pull/7989","diff_url":"https://github.com/apple/swift/pull/7989.diff","patch_url":"https://github.com/apple/swift/pull/7989.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/7989","number":7989,"state":"open","locked":false,"title":"[runtime] Don't use global operators new and delete. Don't allow C++ exports.","user":{"login":"gparker42","id":992218,"avatar_url":"https://avatars1.githubusercontent.com/u/992218?v=3","gravatar_id":"","url":"https://api.github.com/users/gparker42","html_url":"https://github.com/gparker42","followers_url":"https://api.github.com/users/gparker42/followers","following_url":"https://api.github.com/users/gparker42/following{/other_user}","gists_url":"https://api.github.com/users/gparker42/gists{/gist_id}","starred_url":"https://api.github.com/users/gparker42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparker42/subscriptions","organizations_url":"https://api.github.com/users/gparker42/orgs","repos_url":"https://api.github.com/users/gparker42/repos","events_url":"https://api.github.com/users/gparker42/events{/privacy}","received_events_url":"https://api.github.com/users/gparker42/received_events","type":"User","site_admin":false},"body":"Global operators new and delete can be overridden by app implementations,\nbut such implementations are historically untrustworthy. We instead use\nour own implementations in libswiftCore. We share no C++ objects with\nother code so we don't have interoperability problems with mismatched\noperator implementations.\n\nTest stdlib/RuntimeSymbols.swift verifies that operators new and delete\nwere not imported from libc++ and verifies that libswiftCore does not\nitself export any C++-mangled symbols.\n\nrdar://16891362","created_at":"2017-03-09T01:10:36Z","updated_at":"2017-03-09T03:07:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8eaa5111c19beea5939327e024a19512ad0a2768","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/7989/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/7989/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/7989/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/57efcf2a388fc2e6d6e7557651a91e04f30c496b","head":{"label":"gparker42:GrP-PR-80715313-BE2F-4C7F-837A-2127440EA3FD","ref":"GrP-PR-80715313-BE2F-4C7F-837A-2127440EA3FD","sha":"57efcf2a388fc2e6d6e7557651a91e04f30c496b","user":{"login":"gparker42","id":992218,"avatar_url":"https://avatars1.githubusercontent.com/u/992218?v=3","gravatar_id":"","url":"https://api.github.com/users/gparker42","html_url":"https://github.com/gparker42","followers_url":"https://api.github.com/users/gparker42/followers","following_url":"https://api.github.com/users/gparker42/following{/other_user}","gists_url":"https://api.github.com/users/gparker42/gists{/gist_id}","starred_url":"https://api.github.com/users/gparker42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparker42/subscriptions","organizations_url":"https://api.github.com/users/gparker42/orgs","repos_url":"https://api.github.com/users/gparker42/repos","events_url":"https://api.github.com/users/gparker42/events{/privacy}","received_events_url":"https://api.github.com/users/gparker42/received_events","type":"User","site_admin":false},"repo":{"id":56196595,"name":"swift","full_name":"gparker42/swift","owner":{"login":"gparker42","id":992218,"avatar_url":"https://avatars1.githubusercontent.com/u/992218?v=3","gravatar_id":"","url":"https://api.github.com/users/gparker42","html_url":"https://github.com/gparker42","followers_url":"https://api.github.com/users/gparker42/followers","following_url":"https://api.github.com/users/gparker42/following{/other_user}","gists_url":"https://api.github.com/users/gparker42/gists{/gist_id}","starred_url":"https://api.github.com/users/gparker42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gparker42/subscriptions","organizations_url":"https://api.github.com/users/gparker42/orgs","repos_url":"https://api.github.com/users/gparker42/repos","events_url":"https://api.github.com/users/gparker42/events{/privacy}","received_events_url":"https://api.github.com/users/gparker42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gparker42/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/gparker42/swift","forks_url":"https://api.github.com/repos/gparker42/swift/forks","keys_url":"https://api.github.com/repos/gparker42/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gparker42/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gparker42/swift/teams","hooks_url":"https://api.github.com/repos/gparker42/swift/hooks","issue_events_url":"https://api.github.com/repos/gparker42/swift/issues/events{/number}","events_url":"https://api.github.com/repos/gparker42/swift/events","assignees_url":"https://api.github.com/repos/gparker42/swift/assignees{/user}","branches_url":"https://api.github.com/repos/gparker42/swift/branches{/branch}","tags_url":"https://api.github.com/repos/gparker42/swift/tags","blobs_url":"https://api.github.com/repos/gparker42/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gparker42/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gparker42/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/gparker42/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gparker42/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/gparker42/swift/languages","stargazers_url":"https://api.github.com/repos/gparker42/swift/stargazers","contributors_url":"https://api.github.com/repos/gparker42/swift/contributors","subscribers_url":"https://api.github.com/repos/gparker42/swift/subscribers","subscription_url":"https://api.github.com/repos/gparker42/swift/subscription","commits_url":"https://api.github.com/repos/gparker42/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/gparker42/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/gparker42/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/gparker42/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/gparker42/swift/contents/{+path}","compare_url":"https://api.github.com/repos/gparker42/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gparker42/swift/merges","archive_url":"https://api.github.com/repos/gparker42/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gparker42/swift/downloads","issues_url":"https://api.github.com/repos/gparker42/swift/issues{/number}","pulls_url":"https://api.github.com/repos/gparker42/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/gparker42/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/gparker42/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gparker42/swift/labels{/name}","releases_url":"https://api.github.com/repos/gparker42/swift/releases{/id}","deployments_url":"https://api.github.com/repos/gparker42/swift/deployments","created_at":"2016-04-14T01:03:30Z","updated_at":"2016-12-10T05:00:31Z","pushed_at":"2017-03-09T02:47:07Z","git_url":"git://github.com/gparker42/swift.git","ssh_url":"git@github.com:gparker42/swift.git","clone_url":"https://github.com/gparker42/swift.git","svn_url":"https://github.com/gparker42/swift","homepage":"https://swift.org/","size":167358,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"d106001cc8ca339301ecc1e988cb05524ffb19fe","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-03-09T02:39:18Z","pushed_at":"2017-03-09T02:47:09Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":174289,"stargazers_count":37152,"watchers_count":37152,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5492,"mirror_url":null,"open_issues_count":129,"forks":5492,"open_issues":129,"watchers":37152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/7989"},"html":{"href":"https://github.com/apple/swift/pull/7989"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/7989"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/7989/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/7989/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/7989/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/57efcf2a388fc2e6d6e7557651a91e04f30c496b"}}}}
{"actor":{"display_login":"jrose-apple"}}