{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/106326901","pull_request_review_id":27243110,"id":106326901,"diff_hunk":"@@ -85,6 +85,7 @@\n       their output must be formattable in JSON (Ansible will take care of this). Test the\n       output of your scripts.\n       This option was added in Ansible 2.1.\n+    - the module used to be named 'setup', changed in version 2.4.","path":"lib/ansible/modules/system/gather_facts.py","position":15,"original_position":15,"commit_id":"7dd2eb456a47353f521168bee78ab2aa72b714de","original_commit_id":"7dd2eb456a47353f521168bee78ab2aa72b714de","user":{"login":"mattclay","id":806360,"avatar_url":"https://avatars3.githubusercontent.com/u/806360?v=3","gravatar_id":"","url":"https://api.github.com/users/mattclay","html_url":"https://github.com/mattclay","followers_url":"https://api.github.com/users/mattclay/followers","following_url":"https://api.github.com/users/mattclay/following{/other_user}","gists_url":"https://api.github.com/users/mattclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mattclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattclay/subscriptions","organizations_url":"https://api.github.com/users/mattclay/orgs","repos_url":"https://api.github.com/users/mattclay/repos","events_url":"https://api.github.com/users/mattclay/events{/privacy}","received_events_url":"https://api.github.com/users/mattclay/received_events","type":"User","site_admin":false},"body":"Capitalize the first letter of this sentence. Use `I(setup)` instead of `'setup'`.","created_at":"2017-03-16T02:22:53Z","updated_at":"2017-03-16T02:33:49Z","html_url":"https://github.com/ansible/ansible/pull/20717#discussion_r106326901","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/20717","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/106326901"},"html":{"href":"https://github.com/ansible/ansible/pull/20717#discussion_r106326901"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/20717"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/20717","id":103386395,"html_url":"https://github.com/ansible/ansible/pull/20717","diff_url":"https://github.com/ansible/ansible/pull/20717.diff","patch_url":"https://github.com/ansible/ansible/pull/20717.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/20717","number":20717,"state":"open","locked":false,"title":"rename setup to gather_facts, setup still an alias","user":{"login":"bcoca","id":836171,"avatar_url":"https://avatars2.githubusercontent.com/u/836171?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoca","html_url":"https://github.com/bcoca","followers_url":"https://api.github.com/users/bcoca/followers","following_url":"https://api.github.com/users/bcoca/following{/other_user}","gists_url":"https://api.github.com/users/bcoca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoca/subscriptions","organizations_url":"https://api.github.com/users/bcoca/orgs","repos_url":"https://api.github.com/users/bcoca/repos","events_url":"https://api.github.com/users/bcoca/events{/privacy}","received_events_url":"https://api.github.com/users/bcoca/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Pull Request\r\n\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the module/plugin/module/task -->\r\nsetup\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\n2.3\r\n```\r\n\r\n##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\nrename setup to gather_facts as it is both a more intuitive name and not a conflict with python tools.","created_at":"2017-01-26T20:49:05Z","updated_at":"2017-03-16T02:33:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab7b4e0b043b55e05c4cd8e95e486840f9821056","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ansible/ansible/milestones/10","html_url":"https://github.com/ansible/ansible/milestone/10","labels_url":"https://api.github.com/repos/ansible/ansible/milestones/10/labels","id":2338346,"number":10,"title":"2.4.0","description":"","creator":{"login":"thaumos","id":891871,"avatar_url":"https://avatars2.githubusercontent.com/u/891871?v=3","gravatar_id":"","url":"https://api.github.com/users/thaumos","html_url":"https://github.com/thaumos","followers_url":"https://api.github.com/users/thaumos/followers","following_url":"https://api.github.com/users/thaumos/following{/other_user}","gists_url":"https://api.github.com/users/thaumos/gists{/gist_id}","starred_url":"https://api.github.com/users/thaumos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaumos/subscriptions","organizations_url":"https://api.github.com/users/thaumos/orgs","repos_url":"https://api.github.com/users/thaumos/repos","events_url":"https://api.github.com/users/thaumos/events{/privacy}","received_events_url":"https://api.github.com/users/thaumos/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":1,"state":"open","created_at":"2017-02-21T17:24:56Z","updated_at":"2017-03-16T00:12:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/20717/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/20717/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/20717/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/7dd2eb456a47353f521168bee78ab2aa72b714de","head":{"label":"bcoca:gather_facts","ref":"gather_facts","sha":"7dd2eb456a47353f521168bee78ab2aa72b714de","user":{"login":"bcoca","id":836171,"avatar_url":"https://avatars2.githubusercontent.com/u/836171?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoca","html_url":"https://github.com/bcoca","followers_url":"https://api.github.com/users/bcoca/followers","following_url":"https://api.github.com/users/bcoca/following{/other_user}","gists_url":"https://api.github.com/users/bcoca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoca/subscriptions","organizations_url":"https://api.github.com/users/bcoca/orgs","repos_url":"https://api.github.com/users/bcoca/repos","events_url":"https://api.github.com/users/bcoca/events{/privacy}","received_events_url":"https://api.github.com/users/bcoca/received_events","type":"User","site_admin":false},"repo":{"id":6867903,"name":"ansible","full_name":"bcoca/ansible","owner":{"login":"bcoca","id":836171,"avatar_url":"https://avatars2.githubusercontent.com/u/836171?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoca","html_url":"https://github.com/bcoca","followers_url":"https://api.github.com/users/bcoca/followers","following_url":"https://api.github.com/users/bcoca/following{/other_user}","gists_url":"https://api.github.com/users/bcoca/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoca/subscriptions","organizations_url":"https://api.github.com/users/bcoca/orgs","repos_url":"https://api.github.com/users/bcoca/repos","events_url":"https://api.github.com/users/bcoca/events{/privacy}","received_events_url":"https://api.github.com/users/bcoca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcoca/ansible","description":"Model-driven configuration management, multi-node deployment, and remote task execution system.   Uses SSH by default, so there is no special software has to be installed on the nodes you manage.  Ansible can be extended in any language.  Note: The default branch is the development branch, if you need a stable version, see the release-XX branches, tags, or downloads.","fork":true,"url":"https://api.github.com/repos/bcoca/ansible","forks_url":"https://api.github.com/repos/bcoca/ansible/forks","keys_url":"https://api.github.com/repos/bcoca/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcoca/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcoca/ansible/teams","hooks_url":"https://api.github.com/repos/bcoca/ansible/hooks","issue_events_url":"https://api.github.com/repos/bcoca/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/bcoca/ansible/events","assignees_url":"https://api.github.com/repos/bcoca/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/bcoca/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/bcoca/ansible/tags","blobs_url":"https://api.github.com/repos/bcoca/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcoca/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcoca/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcoca/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcoca/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/bcoca/ansible/languages","stargazers_url":"https://api.github.com/repos/bcoca/ansible/stargazers","contributors_url":"https://api.github.com/repos/bcoca/ansible/contributors","subscribers_url":"https://api.github.com/repos/bcoca/ansible/subscribers","subscription_url":"https://api.github.com/repos/bcoca/ansible/subscription","commits_url":"https://api.github.com/repos/bcoca/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcoca/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcoca/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcoca/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcoca/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/bcoca/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcoca/ansible/merges","archive_url":"https://api.github.com/repos/bcoca/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcoca/ansible/downloads","issues_url":"https://api.github.com/repos/bcoca/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/bcoca/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/bcoca/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/bcoca/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcoca/ansible/labels{/name}","releases_url":"https://api.github.com/repos/bcoca/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/bcoca/ansible/deployments","created_at":"2012-11-26T15:56:50Z","updated_at":"2016-10-28T15:06:09Z","pushed_at":"2017-03-15T23:40:30Z","git_url":"git://github.com/bcoca/ansible.git","ssh_url":"git@github.com:bcoca/ansible.git","clone_url":"https://github.com/bcoca/ansible.git","svn_url":"https://github.com/bcoca/ansible","homepage":"http://ansible.cc","size":60314,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"9ffad27319632bc50b3e43216a74ba3b4fb79586","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars1.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars1.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2017-03-16T02:29:25Z","pushed_at":"2017-03-16T00:48:31Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":70138,"stargazers_count":21950,"watchers_count":21950,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7087,"mirror_url":null,"open_issues_count":2629,"forks":7087,"open_issues":2629,"watchers":21950,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/20717"},"html":{"href":"https://github.com/ansible/ansible/pull/20717"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/20717"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/20717/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/20717/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/20717/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/7dd2eb456a47353f521168bee78ab2aa72b714de"}}}}
{"actor":{"display_login":"mattclay"}}