{"action":"created","comment":{"url":"https://api.github.com/repos/dotCMS/core/pulls/comments/127875128","pull_request_review_id":50500562,"id":127875128,"diff_hunk":"@@ -1,44 +1,66 @@\n-/*\n- * Created on Sep 23, 2004\n- *\n- */\n package com.dotmarketing.portlets.languagesmanager.action;\n \n-\n-\n import java.sql.SQLException;\n \n+import javax.servlet.http.HttpServletRequest;\n+\n import com.dotcms.repackage.javax.portlet.ActionRequest;\n import com.dotcms.repackage.javax.portlet.ActionResponse;\n import com.dotcms.repackage.javax.portlet.PortletConfig;\n-import javax.servlet.http.HttpServletRequest;\n-\n import com.dotcms.repackage.org.apache.commons.beanutils.BeanUtils;\n import com.dotcms.repackage.org.apache.struts.action.ActionForm;\n import com.dotcms.repackage.org.apache.struts.action.ActionMapping;\n-\n import com.dotmarketing.business.APILocator;\n import com.dotmarketing.portal.struts.DotPortletAction;\n import com.dotmarketing.portlets.languagesmanager.business.LanguageAPI;\n import com.dotmarketing.portlets.languagesmanager.model.Language;\n import com.dotmarketing.util.Logger;\n+import com.dotmarketing.util.UtilMethods;\n import com.dotmarketing.util.Validator;\n import com.dotmarketing.util.WebKeys;\n+import com.google.common.annotations.VisibleForTesting;\n import com.liferay.portal.util.Constants;\n import com.liferay.portlet.ActionRequestImpl;\n+import com.liferay.util.StringPool;\n import com.liferay.util.servlet.SessionMessages;\n \n-\n /**\n+ * This Struts action will handle all the requests related to adding, updating or deleting a system\n+ * Language. This action is called from the Languages editing page.\n+ * \n  * @author alex\n  * @author davidtorresv\n+ * @version N/A\n+ * @since Mar 22, 2012\n  *\n  */\n public class EditLanguageAction extends DotPortletAction {\n \t\n-\tprivate LanguageAPI langAPI = APILocator.getLanguageAPI();\n-\t\n+\tprivate final LanguageAPI languageAPI;\n+\n+\t/**\n+\t * Default class constructor.\n+\t */\n+\tpublic EditLanguageAction() {\n+        this(APILocator.getLanguageAPI());\n+    }\n \t\n+\t@VisibleForTesting\n+    public EditLanguageAction(final LanguageAPI languageAPI) {","path":"dotCMS/src/main/java/com/dotmarketing/portlets/languagesmanager/action/EditLanguageAction.java","position":61,"original_position":61,"commit_id":"c5e2d08c2ed8cd66bc164e86ee0bdd3d8fc219aa","original_commit_id":"c5e2d08c2ed8cd66bc164e86ee0bdd3d8fc219aa","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused constructor parameters such as 'languageAPI'.](https://www.codacy.com/app/dotCMS/core/pullRequest?prid=778222)","created_at":"2017-07-18T03:21:58Z","updated_at":"2017-07-18T03:21:58Z","html_url":"https://github.com/dotCMS/core/pull/12082#discussion_r127875128","pull_request_url":"https://api.github.com/repos/dotCMS/core/pulls/12082","_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments/127875128"},"html":{"href":"https://github.com/dotCMS/core/pull/12082#discussion_r127875128"},"pull_request":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12082"}}},"pull_request":{"url":"https://api.github.com/repos/dotCMS/core/pulls/12082","id":129944144,"html_url":"https://github.com/dotCMS/core/pull/12082","diff_url":"https://github.com/dotCMS/core/pull/12082.diff","patch_url":"https://github.com/dotCMS/core/pull/12082.patch","issue_url":"https://api.github.com/repos/dotCMS/core/issues/12082","number":12082,"state":"open","locked":false,"title":"Issue 11921 create new key value base type","user":{"login":"jdotcms","id":19578350,"avatar_url":"https://avatars0.githubusercontent.com/u/19578350?v=4","gravatar_id":"","url":"https://api.github.com/users/jdotcms","html_url":"https://github.com/jdotcms","followers_url":"https://api.github.com/users/jdotcms/followers","following_url":"https://api.github.com/users/jdotcms/following{/other_user}","gists_url":"https://api.github.com/users/jdotcms/gists{/gist_id}","starred_url":"https://api.github.com/users/jdotcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdotcms/subscriptions","organizations_url":"https://api.github.com/users/jdotcms/orgs","repos_url":"https://api.github.com/users/jdotcms/repos","events_url":"https://api.github.com/users/jdotcms/events{/privacy}","received_events_url":"https://api.github.com/users/jdotcms/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-11T15:54:54Z","updated_at":"2017-07-18T03:21:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00d8b6f8f1223dad690d96f57f6f031301e78d5e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotCMS/core/pulls/12082/commits","review_comments_url":"https://api.github.com/repos/dotCMS/core/pulls/12082/comments","review_comment_url":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotCMS/core/issues/12082/comments","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/c5e2d08c2ed8cd66bc164e86ee0bdd3d8fc219aa","head":{"label":"dotCMS:issue-11921-create-new-KeyValue-BaseType","ref":"issue-11921-create-new-KeyValue-BaseType","sha":"c5e2d08c2ed8cd66bc164e86ee0bdd3d8fc219aa","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-07-17T05:46:29Z","pushed_at":"2017-07-18T03:09:53Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"git@github.com:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":284069,"stargazers_count":311,"watchers_count":311,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":1630,"forks":288,"open_issues":1630,"watchers":311,"default_branch":"master"}},"base":{"label":"dotCMS:master","ref":"master","sha":"d224d0dabc331d88cc9cda0121051337561057b9","user":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":3729629,"name":"core","full_name":"dotCMS/core","owner":{"login":"dotCMS","id":1005263,"avatar_url":"https://avatars3.githubusercontent.com/u/1005263?v=4","gravatar_id":"","url":"https://api.github.com/users/dotCMS","html_url":"https://github.com/dotCMS","followers_url":"https://api.github.com/users/dotCMS/followers","following_url":"https://api.github.com/users/dotCMS/following{/other_user}","gists_url":"https://api.github.com/users/dotCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/dotCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotCMS/subscriptions","organizations_url":"https://api.github.com/users/dotCMS/orgs","repos_url":"https://api.github.com/users/dotCMS/repos","events_url":"https://api.github.com/users/dotCMS/events{/privacy}","received_events_url":"https://api.github.com/users/dotCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotCMS/core","description":"Source Code for dotCMS Java Enterprise Content Management System","fork":false,"url":"https://api.github.com/repos/dotCMS/core","forks_url":"https://api.github.com/repos/dotCMS/core/forks","keys_url":"https://api.github.com/repos/dotCMS/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotCMS/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotCMS/core/teams","hooks_url":"https://api.github.com/repos/dotCMS/core/hooks","issue_events_url":"https://api.github.com/repos/dotCMS/core/issues/events{/number}","events_url":"https://api.github.com/repos/dotCMS/core/events","assignees_url":"https://api.github.com/repos/dotCMS/core/assignees{/user}","branches_url":"https://api.github.com/repos/dotCMS/core/branches{/branch}","tags_url":"https://api.github.com/repos/dotCMS/core/tags","blobs_url":"https://api.github.com/repos/dotCMS/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotCMS/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotCMS/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotCMS/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotCMS/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dotCMS/core/languages","stargazers_url":"https://api.github.com/repos/dotCMS/core/stargazers","contributors_url":"https://api.github.com/repos/dotCMS/core/contributors","subscribers_url":"https://api.github.com/repos/dotCMS/core/subscribers","subscription_url":"https://api.github.com/repos/dotCMS/core/subscription","commits_url":"https://api.github.com/repos/dotCMS/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotCMS/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotCMS/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotCMS/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotCMS/core/contents/{+path}","compare_url":"https://api.github.com/repos/dotCMS/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotCMS/core/merges","archive_url":"https://api.github.com/repos/dotCMS/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotCMS/core/downloads","issues_url":"https://api.github.com/repos/dotCMS/core/issues{/number}","pulls_url":"https://api.github.com/repos/dotCMS/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dotCMS/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dotCMS/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotCMS/core/labels{/name}","releases_url":"https://api.github.com/repos/dotCMS/core/releases{/id}","deployments_url":"https://api.github.com/repos/dotCMS/core/deployments","created_at":"2012-03-15T15:24:14Z","updated_at":"2017-07-17T05:46:29Z","pushed_at":"2017-07-18T03:09:53Z","git_url":"git://github.com/dotCMS/core.git","ssh_url":"git@github.com:dotCMS/core.git","clone_url":"https://github.com/dotCMS/core.git","svn_url":"https://github.com/dotCMS/core","homepage":"http://dotcms.com","size":284069,"stargazers_count":311,"watchers_count":311,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":1630,"forks":288,"open_issues":1630,"watchers":311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12082"},"html":{"href":"https://github.com/dotCMS/core/pull/12082"},"issue":{"href":"https://api.github.com/repos/dotCMS/core/issues/12082"},"comments":{"href":"https://api.github.com/repos/dotCMS/core/issues/12082/comments"},"review_comments":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12082/comments"},"review_comment":{"href":"https://api.github.com/repos/dotCMS/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotCMS/core/pulls/12082/commits"},"statuses":{"href":"https://api.github.com/repos/dotCMS/core/statuses/c5e2d08c2ed8cd66bc164e86ee0bdd3d8fc219aa"}}}}
{"actor":{"display_login":"codacy-bot"}}