{"action":"created","comment":{"url":"https://api.github.com/repos/INRIA/spoon/pulls/comments/125156399","pull_request_review_id":47524501,"id":125156399,"diff_hunk":"@@ -15,15 +15,15 @@ void invoke() {\n \t\r\n \t@Local\r\n \tpublic InvocationTemplate(CtTypeReference<?> ifaceType, String methodName) {\r\n-\t\tthis.ifaceType = ifaceType;\r\n-\t\tthis.methodName = methodName;\r\n+\t\tthis._IFace = ifaceType.getSimpleName();\r\n+\t\tthis._$method$ = methodName;\r\n \t}\r\n \r\n \t@Parameter(\"IFace\")\r\n-\tCtTypeReference<?> ifaceType;\r\n+\tString _IFace;\r","path":"src/test/java/spoon/test/template/testclasses/InvocationTemplate.java","position":12,"original_position":12,"commit_id":"b6c4d26a537d3c5f06f04d659d14b9cbf9a07bf4","original_commit_id":"b6c4d26a537d3c5f06f04d659d14b9cbf9a07bf4","user":{"login":"pvojtechovsky","id":23107345,"avatar_url":"https://avatars1.githubusercontent.com/u/23107345?v=3","gravatar_id":"","url":"https://api.github.com/users/pvojtechovsky","html_url":"https://github.com/pvojtechovsky","followers_url":"https://api.github.com/users/pvojtechovsky/followers","following_url":"https://api.github.com/users/pvojtechovsky/following{/other_user}","gists_url":"https://api.github.com/users/pvojtechovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/pvojtechovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pvojtechovsky/subscriptions","organizations_url":"https://api.github.com/users/pvojtechovsky/orgs","repos_url":"https://api.github.com/users/pvojtechovsky/repos","events_url":"https://api.github.com/users/pvojtechovsky/events{/privacy}","received_events_url":"https://api.github.com/users/pvojtechovsky/received_events","type":"User","site_admin":false},"body":"So please use\r\n\r\n@Parameter\r\nCtTypeReference<?> IFace;\r\n\r\nbecause otherwise it generates not compilable type - note that nested interface is already marked @Local.","created_at":"2017-07-01T07:08:34Z","updated_at":"2017-07-01T07:08:34Z","html_url":"https://github.com/INRIA/spoon/pull/1457#discussion_r125156399","pull_request_url":"https://api.github.com/repos/INRIA/spoon/pulls/1457","_links":{"self":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/comments/125156399"},"html":{"href":"https://github.com/INRIA/spoon/pull/1457#discussion_r125156399"},"pull_request":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/1457"}}},"pull_request":{"url":"https://api.github.com/repos/INRIA/spoon/pulls/1457","id":128429852,"html_url":"https://github.com/INRIA/spoon/pull/1457","diff_url":"https://github.com/INRIA/spoon/pull/1457.diff","patch_url":"https://github.com/INRIA/spoon/pull/1457.patch","issue_url":"https://api.github.com/repos/INRIA/spoon/issues/1457","number":1457,"state":"open","locked":false,"title":"fix: clarifies the contract of proxy template parameters","user":{"login":"monperrus","id":803666,"avatar_url":"https://avatars0.githubusercontent.com/u/803666?v=3","gravatar_id":"","url":"https://api.github.com/users/monperrus","html_url":"https://github.com/monperrus","followers_url":"https://api.github.com/users/monperrus/followers","following_url":"https://api.github.com/users/monperrus/following{/other_user}","gists_url":"https://api.github.com/users/monperrus/gists{/gist_id}","starred_url":"https://api.github.com/users/monperrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monperrus/subscriptions","organizations_url":"https://api.github.com/users/monperrus/orgs","repos_url":"https://api.github.com/users/monperrus/repos","events_url":"https://api.github.com/users/monperrus/events{/privacy}","received_events_url":"https://api.github.com/users/monperrus/received_events","type":"User","site_admin":false},"body":"@pvojtechovsky in #1444 has uncovered foggy parts in the template engine.\r\n\r\nthis PR is a first clarification about proxy template parameters (those with a value, eg `@Parameter(\"$name$\")`.\r\n ","created_at":"2017-06-30T18:52:13Z","updated_at":"2017-07-01T07:08:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c12e0060ae2b47fb0c00bed9333c1015786c209","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/INRIA/spoon/pulls/1457/commits","review_comments_url":"https://api.github.com/repos/INRIA/spoon/pulls/1457/comments","review_comment_url":"https://api.github.com/repos/INRIA/spoon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/INRIA/spoon/issues/1457/comments","statuses_url":"https://api.github.com/repos/INRIA/spoon/statuses/b6c4d26a537d3c5f06f04d659d14b9cbf9a07bf4","head":{"label":"monperrus:template-clarificarion-contract","ref":"template-clarificarion-contract","sha":"b6c4d26a537d3c5f06f04d659d14b9cbf9a07bf4","user":{"login":"monperrus","id":803666,"avatar_url":"https://avatars0.githubusercontent.com/u/803666?v=3","gravatar_id":"","url":"https://api.github.com/users/monperrus","html_url":"https://github.com/monperrus","followers_url":"https://api.github.com/users/monperrus/followers","following_url":"https://api.github.com/users/monperrus/following{/other_user}","gists_url":"https://api.github.com/users/monperrus/gists{/gist_id}","starred_url":"https://api.github.com/users/monperrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monperrus/subscriptions","organizations_url":"https://api.github.com/users/monperrus/orgs","repos_url":"https://api.github.com/users/monperrus/repos","events_url":"https://api.github.com/users/monperrus/events{/privacy}","received_events_url":"https://api.github.com/users/monperrus/received_events","type":"User","site_admin":false},"repo":{"id":24788221,"name":"spoon","full_name":"monperrus/spoon","owner":{"login":"monperrus","id":803666,"avatar_url":"https://avatars0.githubusercontent.com/u/803666?v=3","gravatar_id":"","url":"https://api.github.com/users/monperrus","html_url":"https://github.com/monperrus","followers_url":"https://api.github.com/users/monperrus/followers","following_url":"https://api.github.com/users/monperrus/following{/other_user}","gists_url":"https://api.github.com/users/monperrus/gists{/gist_id}","starred_url":"https://api.github.com/users/monperrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monperrus/subscriptions","organizations_url":"https://api.github.com/users/monperrus/orgs","repos_url":"https://api.github.com/users/monperrus/repos","events_url":"https://api.github.com/users/monperrus/events{/privacy}","received_events_url":"https://api.github.com/users/monperrus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monperrus/spoon","description":"Spoon is a library for analyzing and transforming Java source code.","fork":true,"url":"https://api.github.com/repos/monperrus/spoon","forks_url":"https://api.github.com/repos/monperrus/spoon/forks","keys_url":"https://api.github.com/repos/monperrus/spoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monperrus/spoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monperrus/spoon/teams","hooks_url":"https://api.github.com/repos/monperrus/spoon/hooks","issue_events_url":"https://api.github.com/repos/monperrus/spoon/issues/events{/number}","events_url":"https://api.github.com/repos/monperrus/spoon/events","assignees_url":"https://api.github.com/repos/monperrus/spoon/assignees{/user}","branches_url":"https://api.github.com/repos/monperrus/spoon/branches{/branch}","tags_url":"https://api.github.com/repos/monperrus/spoon/tags","blobs_url":"https://api.github.com/repos/monperrus/spoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monperrus/spoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monperrus/spoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/monperrus/spoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monperrus/spoon/statuses/{sha}","languages_url":"https://api.github.com/repos/monperrus/spoon/languages","stargazers_url":"https://api.github.com/repos/monperrus/spoon/stargazers","contributors_url":"https://api.github.com/repos/monperrus/spoon/contributors","subscribers_url":"https://api.github.com/repos/monperrus/spoon/subscribers","subscription_url":"https://api.github.com/repos/monperrus/spoon/subscription","commits_url":"https://api.github.com/repos/monperrus/spoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/monperrus/spoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/monperrus/spoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/monperrus/spoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/monperrus/spoon/contents/{+path}","compare_url":"https://api.github.com/repos/monperrus/spoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monperrus/spoon/merges","archive_url":"https://api.github.com/repos/monperrus/spoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monperrus/spoon/downloads","issues_url":"https://api.github.com/repos/monperrus/spoon/issues{/number}","pulls_url":"https://api.github.com/repos/monperrus/spoon/pulls{/number}","milestones_url":"https://api.github.com/repos/monperrus/spoon/milestones{/number}","notifications_url":"https://api.github.com/repos/monperrus/spoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monperrus/spoon/labels{/name}","releases_url":"https://api.github.com/repos/monperrus/spoon/releases{/id}","deployments_url":"https://api.github.com/repos/monperrus/spoon/deployments","created_at":"2014-10-04T11:52:56Z","updated_at":"2014-10-09T14:03:46Z","pushed_at":"2017-06-30T19:43:51Z","git_url":"git://github.com/monperrus/spoon.git","ssh_url":"git@github.com:monperrus/spoon.git","clone_url":"https://github.com/monperrus/spoon.git","svn_url":"https://github.com/monperrus/spoon","homepage":"http://spoon.gforge.inria.fr/","size":19366,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"empty"}},"base":{"label":"INRIA:master","ref":"master","sha":"7a01b5e2fc9a26791abfc72bca0e0411d148f926","user":{"login":"INRIA","id":2951919,"avatar_url":"https://avatars1.githubusercontent.com/u/2951919?v=3","gravatar_id":"","url":"https://api.github.com/users/INRIA","html_url":"https://github.com/INRIA","followers_url":"https://api.github.com/users/INRIA/followers","following_url":"https://api.github.com/users/INRIA/following{/other_user}","gists_url":"https://api.github.com/users/INRIA/gists{/gist_id}","starred_url":"https://api.github.com/users/INRIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INRIA/subscriptions","organizations_url":"https://api.github.com/users/INRIA/orgs","repos_url":"https://api.github.com/users/INRIA/repos","events_url":"https://api.github.com/users/INRIA/events{/privacy}","received_events_url":"https://api.github.com/users/INRIA/received_events","type":"Organization","site_admin":false},"repo":{"id":14176513,"name":"spoon","full_name":"INRIA/spoon","owner":{"login":"INRIA","id":2951919,"avatar_url":"https://avatars1.githubusercontent.com/u/2951919?v=3","gravatar_id":"","url":"https://api.github.com/users/INRIA","html_url":"https://github.com/INRIA","followers_url":"https://api.github.com/users/INRIA/followers","following_url":"https://api.github.com/users/INRIA/following{/other_user}","gists_url":"https://api.github.com/users/INRIA/gists{/gist_id}","starred_url":"https://api.github.com/users/INRIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INRIA/subscriptions","organizations_url":"https://api.github.com/users/INRIA/orgs","repos_url":"https://api.github.com/users/INRIA/repos","events_url":"https://api.github.com/users/INRIA/events{/privacy}","received_events_url":"https://api.github.com/users/INRIA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/INRIA/spoon","description":"Spoon is a library to analyze, transform, rewrite, transpile Java source code (incl Java 8). It parses source files to build a well-designed AST with powerful analysis and transformation API. Made at Inria with :heart:, :beers: and :sparkles:.","fork":false,"url":"https://api.github.com/repos/INRIA/spoon","forks_url":"https://api.github.com/repos/INRIA/spoon/forks","keys_url":"https://api.github.com/repos/INRIA/spoon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INRIA/spoon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INRIA/spoon/teams","hooks_url":"https://api.github.com/repos/INRIA/spoon/hooks","issue_events_url":"https://api.github.com/repos/INRIA/spoon/issues/events{/number}","events_url":"https://api.github.com/repos/INRIA/spoon/events","assignees_url":"https://api.github.com/repos/INRIA/spoon/assignees{/user}","branches_url":"https://api.github.com/repos/INRIA/spoon/branches{/branch}","tags_url":"https://api.github.com/repos/INRIA/spoon/tags","blobs_url":"https://api.github.com/repos/INRIA/spoon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INRIA/spoon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INRIA/spoon/git/refs{/sha}","trees_url":"https://api.github.com/repos/INRIA/spoon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INRIA/spoon/statuses/{sha}","languages_url":"https://api.github.com/repos/INRIA/spoon/languages","stargazers_url":"https://api.github.com/repos/INRIA/spoon/stargazers","contributors_url":"https://api.github.com/repos/INRIA/spoon/contributors","subscribers_url":"https://api.github.com/repos/INRIA/spoon/subscribers","subscription_url":"https://api.github.com/repos/INRIA/spoon/subscription","commits_url":"https://api.github.com/repos/INRIA/spoon/commits{/sha}","git_commits_url":"https://api.github.com/repos/INRIA/spoon/git/commits{/sha}","comments_url":"https://api.github.com/repos/INRIA/spoon/comments{/number}","issue_comment_url":"https://api.github.com/repos/INRIA/spoon/issues/comments{/number}","contents_url":"https://api.github.com/repos/INRIA/spoon/contents/{+path}","compare_url":"https://api.github.com/repos/INRIA/spoon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INRIA/spoon/merges","archive_url":"https://api.github.com/repos/INRIA/spoon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INRIA/spoon/downloads","issues_url":"https://api.github.com/repos/INRIA/spoon/issues{/number}","pulls_url":"https://api.github.com/repos/INRIA/spoon/pulls{/number}","milestones_url":"https://api.github.com/repos/INRIA/spoon/milestones{/number}","notifications_url":"https://api.github.com/repos/INRIA/spoon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INRIA/spoon/labels{/name}","releases_url":"https://api.github.com/repos/INRIA/spoon/releases{/id}","deployments_url":"https://api.github.com/repos/INRIA/spoon/deployments","created_at":"2013-11-06T15:29:59Z","updated_at":"2017-06-26T13:48:37Z","pushed_at":"2017-06-30T19:43:52Z","git_url":"git://github.com/INRIA/spoon.git","ssh_url":"git@github.com:INRIA/spoon.git","clone_url":"https://github.com/INRIA/spoon.git","svn_url":"https://github.com/INRIA/spoon","homepage":"http://spoon.gforge.inria.fr/","size":18889,"stargazers_count":353,"watchers_count":353,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":37,"forks":75,"open_issues":37,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/1457"},"html":{"href":"https://github.com/INRIA/spoon/pull/1457"},"issue":{"href":"https://api.github.com/repos/INRIA/spoon/issues/1457"},"comments":{"href":"https://api.github.com/repos/INRIA/spoon/issues/1457/comments"},"review_comments":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/1457/comments"},"review_comment":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/INRIA/spoon/pulls/1457/commits"},"statuses":{"href":"https://api.github.com/repos/INRIA/spoon/statuses/b6c4d26a537d3c5f06f04d659d14b9cbf9a07bf4"}}}}
{"actor":{"display_login":"pvojtechovsky"}}