{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/126819362","pull_request_review_id":49336769,"id":126819362,"diff_hunk":"@@ -306,6 +306,93 @@ describe('compiler (unbundled Angular)', () => {\n     expect(genSource.startsWith(genFilePreamble)).toBe(true);\n   });\n \n+  it('should still be able to handle animations', () => {","path":"packages/compiler/test/aot/compiler_spec.ts","position":4,"original_position":4,"commit_id":"c0899d74bf83ebb0466d8b82c8c28e43ef608dde","original_commit_id":"c0899d74bf83ebb0466d8b82c8c28e43ef608dde","user":{"login":"mhevery","id":111951,"avatar_url":"https://avatars3.githubusercontent.com/u/111951?v=3","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"could we change it from `should still` to something more explicit. It is not clear to me what this test is testing.","created_at":"2017-07-11T21:58:49Z","updated_at":"2017-07-11T22:03:11Z","html_url":"https://github.com/angular/angular/pull/18001#discussion_r126819362","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/18001","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/126819362"},"html":{"href":"https://github.com/angular/angular/pull/18001#discussion_r126819362"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/18001"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/18001","id":129505456,"html_url":"https://github.com/angular/angular/pull/18001","diff_url":"https://github.com/angular/angular/pull/18001.diff","patch_url":"https://github.com/angular/angular/pull/18001.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/18001","number":18001,"state":"open","locked":false,"title":"feat(compiler): do not evaluate metadata expressions that can use refences","user":{"login":"chuckjaz","id":372013,"avatar_url":"https://avatars2.githubusercontent.com/u/372013?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckjaz","html_url":"https://github.com/chuckjaz","followers_url":"https://api.github.com/users/chuckjaz/followers","following_url":"https://api.github.com/users/chuckjaz/following{/other_user}","gists_url":"https://api.github.com/users/chuckjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckjaz/subscriptions","organizations_url":"https://api.github.com/users/chuckjaz/orgs","repos_url":"https://api.github.com/users/chuckjaz/repos","events_url":"https://api.github.com/users/chuckjaz/events{/privacy}","received_events_url":"https://api.github.com/users/chuckjaz/received_events","type":"User","site_admin":false},"body":"## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Feature\r\n```\r\n\r\n## What is the current behavior?\r\n\r\nThe static reflector fully evaluated all metadata as it unknown which references can be left as references and which need the fully evaluated value.\r\n\r\n## What is the new behavior?\r\n\r\nUse a heuristic that if a value is references from a object literal with the keys of `useVaue`, `useFunction`, `animations` or `data` the value can contain references and the full value is not needed.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n","created_at":"2017-07-07T23:33:57Z","updated_at":"2017-07-11T22:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab359f463c29d2a45b57276ba2f56cddfe226f79","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/18001/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/18001/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/18001/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/c0899d74bf83ebb0466d8b82c8c28e43ef608dde","head":{"label":"chuckjaz:expression-lowering","ref":"expression-lowering","sha":"c0899d74bf83ebb0466d8b82c8c28e43ef608dde","user":{"login":"chuckjaz","id":372013,"avatar_url":"https://avatars2.githubusercontent.com/u/372013?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckjaz","html_url":"https://github.com/chuckjaz","followers_url":"https://api.github.com/users/chuckjaz/followers","following_url":"https://api.github.com/users/chuckjaz/following{/other_user}","gists_url":"https://api.github.com/users/chuckjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckjaz/subscriptions","organizations_url":"https://api.github.com/users/chuckjaz/orgs","repos_url":"https://api.github.com/users/chuckjaz/repos","events_url":"https://api.github.com/users/chuckjaz/events{/privacy}","received_events_url":"https://api.github.com/users/chuckjaz/received_events","type":"User","site_admin":false},"repo":{"id":50690962,"name":"angular","full_name":"chuckjaz/angular","owner":{"login":"chuckjaz","id":372013,"avatar_url":"https://avatars2.githubusercontent.com/u/372013?v=3","gravatar_id":"","url":"https://api.github.com/users/chuckjaz","html_url":"https://github.com/chuckjaz","followers_url":"https://api.github.com/users/chuckjaz/followers","following_url":"https://api.github.com/users/chuckjaz/following{/other_user}","gists_url":"https://api.github.com/users/chuckjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckjaz/subscriptions","organizations_url":"https://api.github.com/users/chuckjaz/orgs","repos_url":"https://api.github.com/users/chuckjaz/repos","events_url":"https://api.github.com/users/chuckjaz/events{/privacy}","received_events_url":"https://api.github.com/users/chuckjaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chuckjaz/angular","description":null,"fork":true,"url":"https://api.github.com/repos/chuckjaz/angular","forks_url":"https://api.github.com/repos/chuckjaz/angular/forks","keys_url":"https://api.github.com/repos/chuckjaz/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chuckjaz/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chuckjaz/angular/teams","hooks_url":"https://api.github.com/repos/chuckjaz/angular/hooks","issue_events_url":"https://api.github.com/repos/chuckjaz/angular/issues/events{/number}","events_url":"https://api.github.com/repos/chuckjaz/angular/events","assignees_url":"https://api.github.com/repos/chuckjaz/angular/assignees{/user}","branches_url":"https://api.github.com/repos/chuckjaz/angular/branches{/branch}","tags_url":"https://api.github.com/repos/chuckjaz/angular/tags","blobs_url":"https://api.github.com/repos/chuckjaz/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chuckjaz/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chuckjaz/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/chuckjaz/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chuckjaz/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/chuckjaz/angular/languages","stargazers_url":"https://api.github.com/repos/chuckjaz/angular/stargazers","contributors_url":"https://api.github.com/repos/chuckjaz/angular/contributors","subscribers_url":"https://api.github.com/repos/chuckjaz/angular/subscribers","subscription_url":"https://api.github.com/repos/chuckjaz/angular/subscription","commits_url":"https://api.github.com/repos/chuckjaz/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/chuckjaz/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/chuckjaz/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/chuckjaz/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/chuckjaz/angular/contents/{+path}","compare_url":"https://api.github.com/repos/chuckjaz/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chuckjaz/angular/merges","archive_url":"https://api.github.com/repos/chuckjaz/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chuckjaz/angular/downloads","issues_url":"https://api.github.com/repos/chuckjaz/angular/issues{/number}","pulls_url":"https://api.github.com/repos/chuckjaz/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/chuckjaz/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/chuckjaz/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chuckjaz/angular/labels{/name}","releases_url":"https://api.github.com/repos/chuckjaz/angular/releases{/id}","deployments_url":"https://api.github.com/repos/chuckjaz/angular/deployments","created_at":"2016-01-29T21:00:52Z","updated_at":"2016-01-29T21:01:07Z","pushed_at":"2017-07-10T23:39:13Z","git_url":"git://github.com/chuckjaz/angular.git","ssh_url":"git@github.com:chuckjaz/angular.git","clone_url":"https://github.com/chuckjaz/angular.git","svn_url":"https://github.com/chuckjaz/angular","homepage":"https://angular.io","size":174690,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"20556346a39bca946d2f9a4c97f5cc7441d24d55","user":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2017-07-11T21:25:41Z","pushed_at":"2017-07-11T21:04:38Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":536131,"stargazers_count":25723,"watchers_count":25723,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6553,"mirror_url":null,"open_issues_count":1759,"forks":6553,"open_issues":1759,"watchers":25723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/18001"},"html":{"href":"https://github.com/angular/angular/pull/18001"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/18001"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/18001/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/18001/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/18001/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/c0899d74bf83ebb0466d8b82c8c28e43ef608dde"}}}}
{"actor":{"display_login":"mhevery"}}