{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/110315933","pull_request_review_id":31480732,"id":110315933,"diff_hunk":"@@ -22,7 +22,7 @@ public class XmlDocument : XmlNode\n         private DomNameTable _domNameTable; // hash table of XmlName\n         private XmlLinkedNode _lastChild;\n         private XmlNamedNodeMap _entities;\n-\t\t// TODO: _htElementIdMap can be Dictionary<string, List<WeakReference<XmlElement>>>\n+        // TODO: _htElementIdMap can be Dictionary<string, List<WeakReference<XmlElement>>>","path":"src/System.Private.Xml/src/System/Xml/Dom/XmlDocument.cs","position":5,"original_position":5,"commit_id":"1b10f26d678c1aa8143233af72f215e286b2ac0e","original_commit_id":"1b10f26d678c1aa8143233af72f215e286b2ac0e","user":{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars0.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"body":"I looked through the others and none seem worth issues. I assume most carried over from years ago.\r\n\r\n---\r\nIn reply to: [110315858](https://github.com/dotnet/corefx/pull/18042#discussion_r110315858) [](ancestors = 110315858,110308973)","created_at":"2017-04-07T04:51:05Z","updated_at":"2017-04-07T04:51:06Z","html_url":"https://github.com/dotnet/corefx/pull/18042#discussion_r110315933","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/18042","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/110315933"},"html":{"href":"https://github.com/dotnet/corefx/pull/18042#discussion_r110315933"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18042"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/18042","id":114717610,"html_url":"https://github.com/dotnet/corefx/pull/18042","diff_url":"https://github.com/dotnet/corefx/pull/18042.diff","patch_url":"https://github.com/dotnet/corefx/pull/18042.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/18042","number":18042,"state":"open","locked":false,"title":"Remove dead code in System.Private.Xml","user":{"login":"sepidehMS","id":14284039,"avatar_url":"https://avatars2.githubusercontent.com/u/14284039?v=3","gravatar_id":"","url":"https://api.github.com/users/sepidehMS","html_url":"https://github.com/sepidehMS","followers_url":"https://api.github.com/users/sepidehMS/followers","following_url":"https://api.github.com/users/sepidehMS/following{/other_user}","gists_url":"https://api.github.com/users/sepidehMS/gists{/gist_id}","starred_url":"https://api.github.com/users/sepidehMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepidehMS/subscriptions","organizations_url":"https://api.github.com/users/sepidehMS/orgs","repos_url":"https://api.github.com/users/sepidehMS/repos","events_url":"https://api.github.com/users/sepidehMS/events{/privacy}","received_events_url":"https://api.github.com/users/sepidehMS/received_events","type":"User","site_admin":false},"body":"Unreachable implementations inside System.Private.Xml were discovered by BclRewriter and removed with help of the CodeRemover tool. There were also many public types in `System.Xml.Xsl.Runtime` namespace that were not exposed in the Xml contracts. All of those were made internal. (Related issue: https://github.com/dotnet/corefx/issues/16825)\r\n\r\nSystem.Private.Xml contains implementations from both System.Xml.dll and System.Data.SqlXml.dll on Desktop. Here's how the sizes look now:\r\n\r\n2,657,952 System.XML.dll\r\n734,416 System.Data.SqlXml.dll\r\n3,534,336 System.Private.Xml.dll \r\n\r\ncc: @danmosemsft @weshaggard","created_at":"2017-04-06T23:39:06Z","updated_at":"2017-04-07T04:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c72ef599476a2f788b2254f9391670274c8e1cc","assignee":{"login":"sepidehMS","id":14284039,"avatar_url":"https://avatars2.githubusercontent.com/u/14284039?v=3","gravatar_id":"","url":"https://api.github.com/users/sepidehMS","html_url":"https://github.com/sepidehMS","followers_url":"https://api.github.com/users/sepidehMS/followers","following_url":"https://api.github.com/users/sepidehMS/following{/other_user}","gists_url":"https://api.github.com/users/sepidehMS/gists{/gist_id}","starred_url":"https://api.github.com/users/sepidehMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepidehMS/subscriptions","organizations_url":"https://api.github.com/users/sepidehMS/orgs","repos_url":"https://api.github.com/users/sepidehMS/repos","events_url":"https://api.github.com/users/sepidehMS/events{/privacy}","received_events_url":"https://api.github.com/users/sepidehMS/received_events","type":"User","site_admin":false},"assignees":[{"login":"sepidehMS","id":14284039,"avatar_url":"https://avatars2.githubusercontent.com/u/14284039?v=3","gravatar_id":"","url":"https://api.github.com/users/sepidehMS","html_url":"https://github.com/sepidehMS","followers_url":"https://api.github.com/users/sepidehMS/followers","following_url":"https://api.github.com/users/sepidehMS/following{/other_user}","gists_url":"https://api.github.com/users/sepidehMS/gists{/gist_id}","starred_url":"https://api.github.com/users/sepidehMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepidehMS/subscriptions","organizations_url":"https://api.github.com/users/sepidehMS/orgs","repos_url":"https://api.github.com/users/sepidehMS/repos","events_url":"https://api.github.com/users/sepidehMS/events{/privacy}","received_events_url":"https://api.github.com/users/sepidehMS/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/18042/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/18042/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/18042/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/1b10f26d678c1aa8143233af72f215e286b2ac0e","head":{"label":"sepidehMS:RemoveXmlDeadCode","ref":"RemoveXmlDeadCode","sha":"1b10f26d678c1aa8143233af72f215e286b2ac0e","user":{"login":"sepidehMS","id":14284039,"avatar_url":"https://avatars2.githubusercontent.com/u/14284039?v=3","gravatar_id":"","url":"https://api.github.com/users/sepidehMS","html_url":"https://github.com/sepidehMS","followers_url":"https://api.github.com/users/sepidehMS/followers","following_url":"https://api.github.com/users/sepidehMS/following{/other_user}","gists_url":"https://api.github.com/users/sepidehMS/gists{/gist_id}","starred_url":"https://api.github.com/users/sepidehMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepidehMS/subscriptions","organizations_url":"https://api.github.com/users/sepidehMS/orgs","repos_url":"https://api.github.com/users/sepidehMS/repos","events_url":"https://api.github.com/users/sepidehMS/events{/privacy}","received_events_url":"https://api.github.com/users/sepidehMS/received_events","type":"User","site_admin":false},"repo":{"id":44568842,"name":"corefx","full_name":"sepidehMS/corefx","owner":{"login":"sepidehMS","id":14284039,"avatar_url":"https://avatars2.githubusercontent.com/u/14284039?v=3","gravatar_id":"","url":"https://api.github.com/users/sepidehMS","html_url":"https://github.com/sepidehMS","followers_url":"https://api.github.com/users/sepidehMS/followers","following_url":"https://api.github.com/users/sepidehMS/following{/other_user}","gists_url":"https://api.github.com/users/sepidehMS/gists{/gist_id}","starred_url":"https://api.github.com/users/sepidehMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepidehMS/subscriptions","organizations_url":"https://api.github.com/users/sepidehMS/orgs","repos_url":"https://api.github.com/users/sepidehMS/repos","events_url":"https://api.github.com/users/sepidehMS/events{/privacy}","received_events_url":"https://api.github.com/users/sepidehMS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sepidehMS/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/sepidehMS/corefx","forks_url":"https://api.github.com/repos/sepidehMS/corefx/forks","keys_url":"https://api.github.com/repos/sepidehMS/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sepidehMS/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sepidehMS/corefx/teams","hooks_url":"https://api.github.com/repos/sepidehMS/corefx/hooks","issue_events_url":"https://api.github.com/repos/sepidehMS/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/sepidehMS/corefx/events","assignees_url":"https://api.github.com/repos/sepidehMS/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/sepidehMS/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/sepidehMS/corefx/tags","blobs_url":"https://api.github.com/repos/sepidehMS/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sepidehMS/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sepidehMS/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sepidehMS/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sepidehMS/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/sepidehMS/corefx/languages","stargazers_url":"https://api.github.com/repos/sepidehMS/corefx/stargazers","contributors_url":"https://api.github.com/repos/sepidehMS/corefx/contributors","subscribers_url":"https://api.github.com/repos/sepidehMS/corefx/subscribers","subscription_url":"https://api.github.com/repos/sepidehMS/corefx/subscription","commits_url":"https://api.github.com/repos/sepidehMS/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sepidehMS/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sepidehMS/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sepidehMS/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sepidehMS/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/sepidehMS/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sepidehMS/corefx/merges","archive_url":"https://api.github.com/repos/sepidehMS/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sepidehMS/corefx/downloads","issues_url":"https://api.github.com/repos/sepidehMS/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/sepidehMS/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/sepidehMS/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/sepidehMS/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sepidehMS/corefx/labels{/name}","releases_url":"https://api.github.com/repos/sepidehMS/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/sepidehMS/corefx/deployments","created_at":"2015-10-19T22:55:13Z","updated_at":"2016-08-01T22:51:27Z","pushed_at":"2017-04-07T01:31:07Z","git_url":"git://github.com/sepidehMS/corefx.git","ssh_url":"git@github.com:sepidehMS/corefx.git","clone_url":"https://github.com/sepidehMS/corefx.git","svn_url":"https://github.com/sepidehMS/corefx","homepage":"http://dotnet.github.io/core/","size":135230,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c522ebe3753dac6b3dca60471cb52adc41f8d94f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-04-07T03:30:30Z","pushed_at":"2017-04-07T04:07:17Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":139222,"stargazers_count":11533,"watchers_count":11533,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3033,"mirror_url":null,"open_issues_count":1378,"forks":3033,"open_issues":1378,"watchers":11533,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18042"},"html":{"href":"https://github.com/dotnet/corefx/pull/18042"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/18042"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/18042/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18042/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/18042/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/1b10f26d678c1aa8143233af72f215e286b2ac0e"}}}}
{"actor":{"display_login":"danmosemsft"}}