{"action":"closed","number":1003,"pull_request":{"url":"https://api.github.com/repos/CMB2/CMB2/pulls/1003","id":133039702,"html_url":"https://github.com/CMB2/CMB2/pull/1003","diff_url":"https://github.com/CMB2/CMB2/pull/1003.diff","patch_url":"https://github.com/CMB2/CMB2/pull/1003.patch","issue_url":"https://api.github.com/repos/CMB2/CMB2/issues/1003","number":1003,"state":"closed","locked":false,"title":"Fix JS to prevent meta keys with | or / from breaking file fields","user":{"login":"lipemat","id":1688181,"avatar_url":"https://avatars0.githubusercontent.com/u/1688181?v=4","gravatar_id":"","url":"https://api.github.com/users/lipemat","html_url":"https://github.com/lipemat","followers_url":"https://api.github.com/users/lipemat/followers","following_url":"https://api.github.com/users/lipemat/following{/other_user}","gists_url":"https://api.github.com/users/lipemat/gists{/gist_id}","starred_url":"https://api.github.com/users/lipemat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lipemat/subscriptions","organizations_url":"https://api.github.com/users/lipemat/orgs","repos_url":"https://api.github.com/users/lipemat/repos","events_url":"https://api.github.com/users/lipemat/events{/privacy}","received_events_url":"https://api.github.com/users/lipemat/received_events","type":"User","site_admin":false},"body":"v2.2.4 as well as tested against trunk.\r\nTested a few WP versions with same results.\r\n\r\n**Issue**\r\nUsing a meta_key (id) for a field that is namespaced with / or | breaks the remove  JS (cmb.handleRemoveMedia()) for the file field.\r\n\r\n**To Recreate:**\r\n\r\n1.  Add a field with the type of file\r\n2. Use a / somewhere in the id (e.g. cmb2/meta/featured)\r\n3. Add a file to this field\r\n4. Click the remove icon\r\n5. View the browser console to see the error. Also notice that file is not removed. \r\n\r\n\r\n\r\n","created_at":"2017-07-28T19:48:37Z","updated_at":"2017-07-31T15:40:43Z","closed_at":"2017-07-31T15:40:43Z","merged_at":"2017-07-31T15:40:43Z","merge_commit_sha":"4f7c01bec4deb2cb6cb42de120f7c200a85dcbab","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CMB2/CMB2/pulls/1003/commits","review_comments_url":"https://api.github.com/repos/CMB2/CMB2/pulls/1003/comments","review_comment_url":"https://api.github.com/repos/CMB2/CMB2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CMB2/CMB2/issues/1003/comments","statuses_url":"https://api.github.com/repos/CMB2/CMB2/statuses/8f0a06bc1169f2dcbfb101bf162330f8e93faeaa","head":{"label":"lipemat:feature/support-characters-in-file-field-ids","ref":"feature/support-characters-in-file-field-ids","sha":"8f0a06bc1169f2dcbfb101bf162330f8e93faeaa","user":{"login":"lipemat","id":1688181,"avatar_url":"https://avatars0.githubusercontent.com/u/1688181?v=4","gravatar_id":"","url":"https://api.github.com/users/lipemat","html_url":"https://github.com/lipemat","followers_url":"https://api.github.com/users/lipemat/followers","following_url":"https://api.github.com/users/lipemat/following{/other_user}","gists_url":"https://api.github.com/users/lipemat/gists{/gist_id}","starred_url":"https://api.github.com/users/lipemat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lipemat/subscriptions","organizations_url":"https://api.github.com/users/lipemat/orgs","repos_url":"https://api.github.com/users/lipemat/repos","events_url":"https://api.github.com/users/lipemat/events{/privacy}","received_events_url":"https://api.github.com/users/lipemat/received_events","type":"User","site_admin":false},"repo":{"id":98680883,"name":"CMB2","full_name":"lipemat/CMB2","owner":{"login":"lipemat","id":1688181,"avatar_url":"https://avatars0.githubusercontent.com/u/1688181?v=4","gravatar_id":"","url":"https://api.github.com/users/lipemat","html_url":"https://github.com/lipemat","followers_url":"https://api.github.com/users/lipemat/followers","following_url":"https://api.github.com/users/lipemat/following{/other_user}","gists_url":"https://api.github.com/users/lipemat/gists{/gist_id}","starred_url":"https://api.github.com/users/lipemat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lipemat/subscriptions","organizations_url":"https://api.github.com/users/lipemat/orgs","repos_url":"https://api.github.com/users/lipemat/repos","events_url":"https://api.github.com/users/lipemat/events{/privacy}","received_events_url":"https://api.github.com/users/lipemat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lipemat/CMB2","description":"CMB2 is a developer's toolkit for building metaboxes, custom fields, and forms for WordPress that will blow your mind.","fork":true,"url":"https://api.github.com/repos/lipemat/CMB2","forks_url":"https://api.github.com/repos/lipemat/CMB2/forks","keys_url":"https://api.github.com/repos/lipemat/CMB2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lipemat/CMB2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lipemat/CMB2/teams","hooks_url":"https://api.github.com/repos/lipemat/CMB2/hooks","issue_events_url":"https://api.github.com/repos/lipemat/CMB2/issues/events{/number}","events_url":"https://api.github.com/repos/lipemat/CMB2/events","assignees_url":"https://api.github.com/repos/lipemat/CMB2/assignees{/user}","branches_url":"https://api.github.com/repos/lipemat/CMB2/branches{/branch}","tags_url":"https://api.github.com/repos/lipemat/CMB2/tags","blobs_url":"https://api.github.com/repos/lipemat/CMB2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lipemat/CMB2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lipemat/CMB2/git/refs{/sha}","trees_url":"https://api.github.com/repos/lipemat/CMB2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lipemat/CMB2/statuses/{sha}","languages_url":"https://api.github.com/repos/lipemat/CMB2/languages","stargazers_url":"https://api.github.com/repos/lipemat/CMB2/stargazers","contributors_url":"https://api.github.com/repos/lipemat/CMB2/contributors","subscribers_url":"https://api.github.com/repos/lipemat/CMB2/subscribers","subscription_url":"https://api.github.com/repos/lipemat/CMB2/subscription","commits_url":"https://api.github.com/repos/lipemat/CMB2/commits{/sha}","git_commits_url":"https://api.github.com/repos/lipemat/CMB2/git/commits{/sha}","comments_url":"https://api.github.com/repos/lipemat/CMB2/comments{/number}","issue_comment_url":"https://api.github.com/repos/lipemat/CMB2/issues/comments{/number}","contents_url":"https://api.github.com/repos/lipemat/CMB2/contents/{+path}","compare_url":"https://api.github.com/repos/lipemat/CMB2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lipemat/CMB2/merges","archive_url":"https://api.github.com/repos/lipemat/CMB2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lipemat/CMB2/downloads","issues_url":"https://api.github.com/repos/lipemat/CMB2/issues{/number}","pulls_url":"https://api.github.com/repos/lipemat/CMB2/pulls{/number}","milestones_url":"https://api.github.com/repos/lipemat/CMB2/milestones{/number}","notifications_url":"https://api.github.com/repos/lipemat/CMB2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lipemat/CMB2/labels{/name}","releases_url":"https://api.github.com/repos/lipemat/CMB2/releases{/id}","deployments_url":"https://api.github.com/repos/lipemat/CMB2/deployments","created_at":"2017-07-28T19:23:35Z","updated_at":"2017-07-28T19:23:37Z","pushed_at":"2017-07-28T19:47:59Z","git_url":"git://github.com/lipemat/CMB2.git","ssh_url":"git@github.com:lipemat/CMB2.git","clone_url":"https://github.com/lipemat/CMB2.git","svn_url":"https://github.com/lipemat/CMB2","homepage":"","size":5166,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"CMB2:master","ref":"master","sha":"badecc7f908781ac14b879c74526f9d055f4a41e","user":{"login":"CMB2","id":19478889,"avatar_url":"https://avatars3.githubusercontent.com/u/19478889?v=4","gravatar_id":"","url":"https://api.github.com/users/CMB2","html_url":"https://github.com/CMB2","followers_url":"https://api.github.com/users/CMB2/followers","following_url":"https://api.github.com/users/CMB2/following{/other_user}","gists_url":"https://api.github.com/users/CMB2/gists{/gist_id}","starred_url":"https://api.github.com/users/CMB2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMB2/subscriptions","organizations_url":"https://api.github.com/users/CMB2/orgs","repos_url":"https://api.github.com/users/CMB2/repos","events_url":"https://api.github.com/users/CMB2/events{/privacy}","received_events_url":"https://api.github.com/users/CMB2/received_events","type":"Organization","site_admin":false},"repo":{"id":23156260,"name":"CMB2","full_name":"CMB2/CMB2","owner":{"login":"CMB2","id":19478889,"avatar_url":"https://avatars3.githubusercontent.com/u/19478889?v=4","gravatar_id":"","url":"https://api.github.com/users/CMB2","html_url":"https://github.com/CMB2","followers_url":"https://api.github.com/users/CMB2/followers","following_url":"https://api.github.com/users/CMB2/following{/other_user}","gists_url":"https://api.github.com/users/CMB2/gists{/gist_id}","starred_url":"https://api.github.com/users/CMB2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMB2/subscriptions","organizations_url":"https://api.github.com/users/CMB2/orgs","repos_url":"https://api.github.com/users/CMB2/repos","events_url":"https://api.github.com/users/CMB2/events{/privacy}","received_events_url":"https://api.github.com/users/CMB2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CMB2/CMB2","description":"CMB2 is a developer's toolkit for building metaboxes, custom fields, and forms for WordPress that will blow your mind.","fork":false,"url":"https://api.github.com/repos/CMB2/CMB2","forks_url":"https://api.github.com/repos/CMB2/CMB2/forks","keys_url":"https://api.github.com/repos/CMB2/CMB2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMB2/CMB2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMB2/CMB2/teams","hooks_url":"https://api.github.com/repos/CMB2/CMB2/hooks","issue_events_url":"https://api.github.com/repos/CMB2/CMB2/issues/events{/number}","events_url":"https://api.github.com/repos/CMB2/CMB2/events","assignees_url":"https://api.github.com/repos/CMB2/CMB2/assignees{/user}","branches_url":"https://api.github.com/repos/CMB2/CMB2/branches{/branch}","tags_url":"https://api.github.com/repos/CMB2/CMB2/tags","blobs_url":"https://api.github.com/repos/CMB2/CMB2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMB2/CMB2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMB2/CMB2/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMB2/CMB2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMB2/CMB2/statuses/{sha}","languages_url":"https://api.github.com/repos/CMB2/CMB2/languages","stargazers_url":"https://api.github.com/repos/CMB2/CMB2/stargazers","contributors_url":"https://api.github.com/repos/CMB2/CMB2/contributors","subscribers_url":"https://api.github.com/repos/CMB2/CMB2/subscribers","subscription_url":"https://api.github.com/repos/CMB2/CMB2/subscription","commits_url":"https://api.github.com/repos/CMB2/CMB2/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMB2/CMB2/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMB2/CMB2/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMB2/CMB2/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMB2/CMB2/contents/{+path}","compare_url":"https://api.github.com/repos/CMB2/CMB2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMB2/CMB2/merges","archive_url":"https://api.github.com/repos/CMB2/CMB2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMB2/CMB2/downloads","issues_url":"https://api.github.com/repos/CMB2/CMB2/issues{/number}","pulls_url":"https://api.github.com/repos/CMB2/CMB2/pulls{/number}","milestones_url":"https://api.github.com/repos/CMB2/CMB2/milestones{/number}","notifications_url":"https://api.github.com/repos/CMB2/CMB2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMB2/CMB2/labels{/name}","releases_url":"https://api.github.com/repos/CMB2/CMB2/releases{/id}","deployments_url":"https://api.github.com/repos/CMB2/CMB2/deployments","created_at":"2014-08-20T16:49:33Z","updated_at":"2017-07-31T08:12:04Z","pushed_at":"2017-07-31T15:40:43Z","git_url":"git://github.com/CMB2/CMB2.git","ssh_url":"git@github.com:CMB2/CMB2.git","clone_url":"https://github.com/CMB2/CMB2.git","svn_url":"https://github.com/CMB2/CMB2","homepage":"","size":5280,"stargazers_count":1726,"watchers_count":1726,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":408,"mirror_url":null,"open_issues_count":154,"forks":408,"open_issues":154,"watchers":1726,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/CMB2/CMB2/pulls/1003"},"html":{"href":"https://github.com/CMB2/CMB2/pull/1003"},"issue":{"href":"https://api.github.com/repos/CMB2/CMB2/issues/1003"},"comments":{"href":"https://api.github.com/repos/CMB2/CMB2/issues/1003/comments"},"review_comments":{"href":"https://api.github.com/repos/CMB2/CMB2/pulls/1003/comments"},"review_comment":{"href":"https://api.github.com/repos/CMB2/CMB2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CMB2/CMB2/pulls/1003/commits"},"statuses":{"href":"https://api.github.com/repos/CMB2/CMB2/statuses/8f0a06bc1169f2dcbfb101bf162330f8e93faeaa"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jtsternberg","id":1098900,"avatar_url":"https://avatars2.githubusercontent.com/u/1098900?v=4","gravatar_id":"","url":"https://api.github.com/users/jtsternberg","html_url":"https://github.com/jtsternberg","followers_url":"https://api.github.com/users/jtsternberg/followers","following_url":"https://api.github.com/users/jtsternberg/following{/other_user}","gists_url":"https://api.github.com/users/jtsternberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jtsternberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtsternberg/subscriptions","organizations_url":"https://api.github.com/users/jtsternberg/orgs","repos_url":"https://api.github.com/users/jtsternberg/repos","events_url":"https://api.github.com/users/jtsternberg/events{/privacy}","received_events_url":"https://api.github.com/users/jtsternberg/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"jtsternberg"}}