{"action":"closed","number":16405,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16405","id":123334594,"html_url":"https://github.com/joomla/joomla-cms/pull/16405","diff_url":"https://github.com/joomla/joomla-cms/pull/16405.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/16405.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16405","number":16405,"state":"closed","locked":false,"title":"[4.0] Fix breadcrumbs module","user":{"login":"C-Lodder","id":2019801,"avatar_url":"https://avatars2.githubusercontent.com/u/2019801?v=3","gravatar_id":"","url":"https://api.github.com/users/C-Lodder","html_url":"https://github.com/C-Lodder","followers_url":"https://api.github.com/users/C-Lodder/followers","following_url":"https://api.github.com/users/C-Lodder/following{/other_user}","gists_url":"https://api.github.com/users/C-Lodder/gists{/gist_id}","starred_url":"https://api.github.com/users/C-Lodder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C-Lodder/subscriptions","organizations_url":"https://api.github.com/users/C-Lodder/orgs","repos_url":"https://api.github.com/users/C-Lodder/repos","events_url":"https://api.github.com/users/C-Lodder/events{/privacy}","received_events_url":"https://api.github.com/users/C-Lodder/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #16392\r\n\r\n### Summary of Changes\r\n\r\nThis PR fixes the breadcrumbs styling and also adds back in the parameters I accidentally removed months ago.\r\n\r\nI've also removed the `separator` parameter as BS4 breadcrumbs separators are now done using the `::before` pseudo selector.\r\n\r\n### Testing Instructions\r\n\r\nUse the breadcrumbs module and ensure the styling is ok.\r\n\r\n","created_at":"2017-05-31T18:10:12Z","updated_at":"2017-05-31T18:11:29Z","closed_at":"2017-05-31T18:11:29Z","merged_at":"2017-05-31T18:11:29Z","merge_commit_sha":"4ac65da04e03458ac24f3492e00317707f865bf3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16405/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16405/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16405/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/bc4d1cdec69231ab25642178f97c43556223ef12","head":{"label":"C-Lodder:breadcrumbs","ref":"breadcrumbs","sha":"bc4d1cdec69231ab25642178f97c43556223ef12","user":{"login":"C-Lodder","id":2019801,"avatar_url":"https://avatars2.githubusercontent.com/u/2019801?v=3","gravatar_id":"","url":"https://api.github.com/users/C-Lodder","html_url":"https://github.com/C-Lodder","followers_url":"https://api.github.com/users/C-Lodder/followers","following_url":"https://api.github.com/users/C-Lodder/following{/other_user}","gists_url":"https://api.github.com/users/C-Lodder/gists{/gist_id}","starred_url":"https://api.github.com/users/C-Lodder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C-Lodder/subscriptions","organizations_url":"https://api.github.com/users/C-Lodder/orgs","repos_url":"https://api.github.com/users/C-Lodder/repos","events_url":"https://api.github.com/users/C-Lodder/events{/privacy}","received_events_url":"https://api.github.com/users/C-Lodder/received_events","type":"User","site_admin":false},"repo":{"id":79846672,"name":"joomla-cms","full_name":"C-Lodder/joomla-cms","owner":{"login":"C-Lodder","id":2019801,"avatar_url":"https://avatars2.githubusercontent.com/u/2019801?v=3","gravatar_id":"","url":"https://api.github.com/users/C-Lodder","html_url":"https://github.com/C-Lodder","followers_url":"https://api.github.com/users/C-Lodder/followers","following_url":"https://api.github.com/users/C-Lodder/following{/other_user}","gists_url":"https://api.github.com/users/C-Lodder/gists{/gist_id}","starred_url":"https://api.github.com/users/C-Lodder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C-Lodder/subscriptions","organizations_url":"https://api.github.com/users/C-Lodder/orgs","repos_url":"https://api.github.com/users/C-Lodder/repos","events_url":"https://api.github.com/users/C-Lodder/events{/privacy}","received_events_url":"https://api.github.com/users/C-Lodder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/C-Lodder/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/C-Lodder/joomla-cms","forks_url":"https://api.github.com/repos/C-Lodder/joomla-cms/forks","keys_url":"https://api.github.com/repos/C-Lodder/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/C-Lodder/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/C-Lodder/joomla-cms/teams","hooks_url":"https://api.github.com/repos/C-Lodder/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/C-Lodder/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/C-Lodder/joomla-cms/events","assignees_url":"https://api.github.com/repos/C-Lodder/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/C-Lodder/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/C-Lodder/joomla-cms/tags","blobs_url":"https://api.github.com/repos/C-Lodder/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/C-Lodder/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/C-Lodder/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/C-Lodder/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/C-Lodder/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/C-Lodder/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/C-Lodder/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/C-Lodder/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/C-Lodder/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/C-Lodder/joomla-cms/subscription","commits_url":"https://api.github.com/repos/C-Lodder/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/C-Lodder/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/C-Lodder/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/C-Lodder/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/C-Lodder/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/C-Lodder/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/C-Lodder/joomla-cms/merges","archive_url":"https://api.github.com/repos/C-Lodder/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/C-Lodder/joomla-cms/downloads","issues_url":"https://api.github.com/repos/C-Lodder/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/C-Lodder/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/C-Lodder/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/C-Lodder/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/C-Lodder/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/C-Lodder/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/C-Lodder/joomla-cms/deployments","created_at":"2017-01-23T20:50:36Z","updated_at":"2017-01-23T20:50:54Z","pushed_at":"2017-05-31T18:07:33Z","git_url":"git://github.com/C-Lodder/joomla-cms.git","ssh_url":"git@github.com:C-Lodder/joomla-cms.git","clone_url":"https://github.com/C-Lodder/joomla-cms.git","svn_url":"https://github.com/C-Lodder/joomla-cms","homepage":"https://www.joomla.org","size":193783,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:4.0-dev","ref":"4.0-dev","sha":"25dc1d8bfabdec74da7147028ffe7d1c4c98b80f","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-05-30T11:35:58Z","pushed_at":"2017-05-31T18:11:29Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":194643,"stargazers_count":2386,"watchers_count":2386,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2489,"mirror_url":null,"open_issues_count":794,"forks":2489,"open_issues":794,"watchers":2386,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16405"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/16405"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/16405"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/16405/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16405/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16405/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/bc4d1cdec69231ab25642178f97c43556223ef12"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wilsonge","id":1986000,"avatar_url":"https://avatars1.githubusercontent.com/u/1986000?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonge","html_url":"https://github.com/wilsonge","followers_url":"https://api.github.com/users/wilsonge/followers","following_url":"https://api.github.com/users/wilsonge/following{/other_user}","gists_url":"https://api.github.com/users/wilsonge/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonge/subscriptions","organizations_url":"https://api.github.com/users/wilsonge/orgs","repos_url":"https://api.github.com/users/wilsonge/repos","events_url":"https://api.github.com/users/wilsonge/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonge/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":45,"deletions":26,"changed_files":4}}
{"actor":{"display_login":"wilsonge"}}