{"action":"created","comment":{"url":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/comments/115368955","pull_request_review_id":36901254,"id":115368955,"diff_hunk":"@@ -1270,23 +1270,32 @@ def make_url(path):\n         '''\n         TODO: get rid of this hardcoding!!!","path":"conductor/lib/downloader.py","position":20,"original_position":20,"commit_id":"08c4aa33b22f4a65267e0a0f2e99b176f677e0eb","original_commit_id":"08c4aa33b22f4a65267e0a0f2e99b176f677e0eb","user":{"login":"lawschlosser","id":10409070,"avatar_url":"https://avatars1.githubusercontent.com/u/10409070?v=3","gravatar_id":"","url":"https://api.github.com/users/lawschlosser","html_url":"https://github.com/lawschlosser","followers_url":"https://api.github.com/users/lawschlosser/followers","following_url":"https://api.github.com/users/lawschlosser/following{/other_user}","gists_url":"https://api.github.com/users/lawschlosser/gists{/gist_id}","starred_url":"https://api.github.com/users/lawschlosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lawschlosser/subscriptions","organizations_url":"https://api.github.com/users/lawschlosser/orgs","repos_url":"https://api.github.com/users/lawschlosser/repos","events_url":"https://api.github.com/users/lawschlosser/events{/privacy}","received_events_url":"https://api.github.com/users/lawschlosser/received_events","type":"User","site_admin":false},"body":"This **make_url** method feels like it's trying to figure out some core routing logic that I would think is applicable to a broader range of code, than just the downloader?  For instance, the uploader will need to use this same logic, yes?  Perhaps encapsulating this logic in api_client.py (or common.py) would be better?","created_at":"2017-05-08T22:28:28Z","updated_at":"2017-05-08T22:32:42Z","html_url":"https://github.com/AtomicConductor/conductor_client/pull/99#discussion_r115368955","pull_request_url":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/comments/115368955"},"html":{"href":"https://github.com/AtomicConductor/conductor_client/pull/99#discussion_r115368955"},"pull_request":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/99","id":118455147,"html_url":"https://github.com/AtomicConductor/conductor_client/pull/99","diff_url":"https://github.com/AtomicConductor/conductor_client/pull/99.diff","patch_url":"https://github.com/AtomicConductor/conductor_client/pull/99.patch","issue_url":"https://api.github.com/repos/AtomicConductor/conductor_client/issues/99","number":99,"state":"open","locked":false,"title":"Downlaoder alt switch","user":{"login":"jamesm-cio","id":18268857,"avatar_url":"https://avatars3.githubusercontent.com/u/18268857?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesm-cio","html_url":"https://github.com/jamesm-cio","followers_url":"https://api.github.com/users/jamesm-cio/followers","following_url":"https://api.github.com/users/jamesm-cio/following{/other_user}","gists_url":"https://api.github.com/users/jamesm-cio/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesm-cio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesm-cio/subscriptions","organizations_url":"https://api.github.com/users/jamesm-cio/orgs","repos_url":"https://api.github.com/users/jamesm-cio/repos","events_url":"https://api.github.com/users/jamesm-cio/events{/privacy}","received_events_url":"https://api.github.com/users/jamesm-cio/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-01T22:41:24Z","updated_at":"2017-05-08T22:32:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efedc1c2f6c3fe0d743dddd865710ae063c20cca","assignee":{"login":"sozawa","id":12239650,"avatar_url":"https://avatars3.githubusercontent.com/u/12239650?v=3","gravatar_id":"","url":"https://api.github.com/users/sozawa","html_url":"https://github.com/sozawa","followers_url":"https://api.github.com/users/sozawa/followers","following_url":"https://api.github.com/users/sozawa/following{/other_user}","gists_url":"https://api.github.com/users/sozawa/gists{/gist_id}","starred_url":"https://api.github.com/users/sozawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozawa/subscriptions","organizations_url":"https://api.github.com/users/sozawa/orgs","repos_url":"https://api.github.com/users/sozawa/repos","events_url":"https://api.github.com/users/sozawa/events{/privacy}","received_events_url":"https://api.github.com/users/sozawa/received_events","type":"User","site_admin":false},"assignees":[{"login":"sozawa","id":12239650,"avatar_url":"https://avatars3.githubusercontent.com/u/12239650?v=3","gravatar_id":"","url":"https://api.github.com/users/sozawa","html_url":"https://github.com/sozawa","followers_url":"https://api.github.com/users/sozawa/followers","following_url":"https://api.github.com/users/sozawa/following{/other_user}","gists_url":"https://api.github.com/users/sozawa/gists{/gist_id}","starred_url":"https://api.github.com/users/sozawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sozawa/subscriptions","organizations_url":"https://api.github.com/users/sozawa/orgs","repos_url":"https://api.github.com/users/sozawa/repos","events_url":"https://api.github.com/users/sozawa/events{/privacy}","received_events_url":"https://api.github.com/users/sozawa/received_events","type":"User","site_admin":false},{"login":"jamesm-cio","id":18268857,"avatar_url":"https://avatars3.githubusercontent.com/u/18268857?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesm-cio","html_url":"https://github.com/jamesm-cio","followers_url":"https://api.github.com/users/jamesm-cio/followers","following_url":"https://api.github.com/users/jamesm-cio/following{/other_user}","gists_url":"https://api.github.com/users/jamesm-cio/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesm-cio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesm-cio/subscriptions","organizations_url":"https://api.github.com/users/jamesm-cio/orgs","repos_url":"https://api.github.com/users/jamesm-cio/repos","events_url":"https://api.github.com/users/jamesm-cio/events{/privacy}","received_events_url":"https://api.github.com/users/jamesm-cio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/99/commits","review_comments_url":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/99/comments","review_comment_url":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AtomicConductor/conductor_client/issues/99/comments","statuses_url":"https://api.github.com/repos/AtomicConductor/conductor_client/statuses/08c4aa33b22f4a65267e0a0f2e99b176f677e0eb","head":{"label":"AtomicConductor:downlaoder-alt-switch","ref":"downlaoder-alt-switch","sha":"08c4aa33b22f4a65267e0a0f2e99b176f677e0eb","user":{"login":"AtomicConductor","id":10238641,"avatar_url":"https://avatars1.githubusercontent.com/u/10238641?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomicConductor","html_url":"https://github.com/AtomicConductor","followers_url":"https://api.github.com/users/AtomicConductor/followers","following_url":"https://api.github.com/users/AtomicConductor/following{/other_user}","gists_url":"https://api.github.com/users/AtomicConductor/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomicConductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomicConductor/subscriptions","organizations_url":"https://api.github.com/users/AtomicConductor/orgs","repos_url":"https://api.github.com/users/AtomicConductor/repos","events_url":"https://api.github.com/users/AtomicConductor/events{/privacy}","received_events_url":"https://api.github.com/users/AtomicConductor/received_events","type":"Organization","site_admin":false},"repo":{"id":34025453,"name":"conductor_client","full_name":"AtomicConductor/conductor_client","owner":{"login":"AtomicConductor","id":10238641,"avatar_url":"https://avatars1.githubusercontent.com/u/10238641?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomicConductor","html_url":"https://github.com/AtomicConductor","followers_url":"https://api.github.com/users/AtomicConductor/followers","following_url":"https://api.github.com/users/AtomicConductor/following{/other_user}","gists_url":"https://api.github.com/users/AtomicConductor/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomicConductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomicConductor/subscriptions","organizations_url":"https://api.github.com/users/AtomicConductor/orgs","repos_url":"https://api.github.com/users/AtomicConductor/repos","events_url":"https://api.github.com/users/AtomicConductor/events{/privacy}","received_events_url":"https://api.github.com/users/AtomicConductor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomicConductor/conductor_client","description":"Conductor Cloud Rendering Client","fork":false,"url":"https://api.github.com/repos/AtomicConductor/conductor_client","forks_url":"https://api.github.com/repos/AtomicConductor/conductor_client/forks","keys_url":"https://api.github.com/repos/AtomicConductor/conductor_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomicConductor/conductor_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomicConductor/conductor_client/teams","hooks_url":"https://api.github.com/repos/AtomicConductor/conductor_client/hooks","issue_events_url":"https://api.github.com/repos/AtomicConductor/conductor_client/issues/events{/number}","events_url":"https://api.github.com/repos/AtomicConductor/conductor_client/events","assignees_url":"https://api.github.com/repos/AtomicConductor/conductor_client/assignees{/user}","branches_url":"https://api.github.com/repos/AtomicConductor/conductor_client/branches{/branch}","tags_url":"https://api.github.com/repos/AtomicConductor/conductor_client/tags","blobs_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomicConductor/conductor_client/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomicConductor/conductor_client/languages","stargazers_url":"https://api.github.com/repos/AtomicConductor/conductor_client/stargazers","contributors_url":"https://api.github.com/repos/AtomicConductor/conductor_client/contributors","subscribers_url":"https://api.github.com/repos/AtomicConductor/conductor_client/subscribers","subscription_url":"https://api.github.com/repos/AtomicConductor/conductor_client/subscription","commits_url":"https://api.github.com/repos/AtomicConductor/conductor_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomicConductor/conductor_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomicConductor/conductor_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomicConductor/conductor_client/contents/{+path}","compare_url":"https://api.github.com/repos/AtomicConductor/conductor_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomicConductor/conductor_client/merges","archive_url":"https://api.github.com/repos/AtomicConductor/conductor_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomicConductor/conductor_client/downloads","issues_url":"https://api.github.com/repos/AtomicConductor/conductor_client/issues{/number}","pulls_url":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomicConductor/conductor_client/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomicConductor/conductor_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomicConductor/conductor_client/labels{/name}","releases_url":"https://api.github.com/repos/AtomicConductor/conductor_client/releases{/id}","deployments_url":"https://api.github.com/repos/AtomicConductor/conductor_client/deployments","created_at":"2015-04-16T00:23:04Z","updated_at":"2016-10-26T03:05:26Z","pushed_at":"2017-05-05T18:19:07Z","git_url":"git://github.com/AtomicConductor/conductor_client.git","ssh_url":"git@github.com:AtomicConductor/conductor_client.git","clone_url":"https://github.com/AtomicConductor/conductor_client.git","svn_url":"https://github.com/AtomicConductor/conductor_client","homepage":"","size":38648,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"AtomicConductor:master","ref":"master","sha":"565939a49d62e42210a29b872b692ea952a83784","user":{"login":"AtomicConductor","id":10238641,"avatar_url":"https://avatars1.githubusercontent.com/u/10238641?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomicConductor","html_url":"https://github.com/AtomicConductor","followers_url":"https://api.github.com/users/AtomicConductor/followers","following_url":"https://api.github.com/users/AtomicConductor/following{/other_user}","gists_url":"https://api.github.com/users/AtomicConductor/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomicConductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomicConductor/subscriptions","organizations_url":"https://api.github.com/users/AtomicConductor/orgs","repos_url":"https://api.github.com/users/AtomicConductor/repos","events_url":"https://api.github.com/users/AtomicConductor/events{/privacy}","received_events_url":"https://api.github.com/users/AtomicConductor/received_events","type":"Organization","site_admin":false},"repo":{"id":34025453,"name":"conductor_client","full_name":"AtomicConductor/conductor_client","owner":{"login":"AtomicConductor","id":10238641,"avatar_url":"https://avatars1.githubusercontent.com/u/10238641?v=3","gravatar_id":"","url":"https://api.github.com/users/AtomicConductor","html_url":"https://github.com/AtomicConductor","followers_url":"https://api.github.com/users/AtomicConductor/followers","following_url":"https://api.github.com/users/AtomicConductor/following{/other_user}","gists_url":"https://api.github.com/users/AtomicConductor/gists{/gist_id}","starred_url":"https://api.github.com/users/AtomicConductor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtomicConductor/subscriptions","organizations_url":"https://api.github.com/users/AtomicConductor/orgs","repos_url":"https://api.github.com/users/AtomicConductor/repos","events_url":"https://api.github.com/users/AtomicConductor/events{/privacy}","received_events_url":"https://api.github.com/users/AtomicConductor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AtomicConductor/conductor_client","description":"Conductor Cloud Rendering Client","fork":false,"url":"https://api.github.com/repos/AtomicConductor/conductor_client","forks_url":"https://api.github.com/repos/AtomicConductor/conductor_client/forks","keys_url":"https://api.github.com/repos/AtomicConductor/conductor_client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AtomicConductor/conductor_client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AtomicConductor/conductor_client/teams","hooks_url":"https://api.github.com/repos/AtomicConductor/conductor_client/hooks","issue_events_url":"https://api.github.com/repos/AtomicConductor/conductor_client/issues/events{/number}","events_url":"https://api.github.com/repos/AtomicConductor/conductor_client/events","assignees_url":"https://api.github.com/repos/AtomicConductor/conductor_client/assignees{/user}","branches_url":"https://api.github.com/repos/AtomicConductor/conductor_client/branches{/branch}","tags_url":"https://api.github.com/repos/AtomicConductor/conductor_client/tags","blobs_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/refs{/sha}","trees_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AtomicConductor/conductor_client/statuses/{sha}","languages_url":"https://api.github.com/repos/AtomicConductor/conductor_client/languages","stargazers_url":"https://api.github.com/repos/AtomicConductor/conductor_client/stargazers","contributors_url":"https://api.github.com/repos/AtomicConductor/conductor_client/contributors","subscribers_url":"https://api.github.com/repos/AtomicConductor/conductor_client/subscribers","subscription_url":"https://api.github.com/repos/AtomicConductor/conductor_client/subscription","commits_url":"https://api.github.com/repos/AtomicConductor/conductor_client/commits{/sha}","git_commits_url":"https://api.github.com/repos/AtomicConductor/conductor_client/git/commits{/sha}","comments_url":"https://api.github.com/repos/AtomicConductor/conductor_client/comments{/number}","issue_comment_url":"https://api.github.com/repos/AtomicConductor/conductor_client/issues/comments{/number}","contents_url":"https://api.github.com/repos/AtomicConductor/conductor_client/contents/{+path}","compare_url":"https://api.github.com/repos/AtomicConductor/conductor_client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AtomicConductor/conductor_client/merges","archive_url":"https://api.github.com/repos/AtomicConductor/conductor_client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AtomicConductor/conductor_client/downloads","issues_url":"https://api.github.com/repos/AtomicConductor/conductor_client/issues{/number}","pulls_url":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls{/number}","milestones_url":"https://api.github.com/repos/AtomicConductor/conductor_client/milestones{/number}","notifications_url":"https://api.github.com/repos/AtomicConductor/conductor_client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AtomicConductor/conductor_client/labels{/name}","releases_url":"https://api.github.com/repos/AtomicConductor/conductor_client/releases{/id}","deployments_url":"https://api.github.com/repos/AtomicConductor/conductor_client/deployments","created_at":"2015-04-16T00:23:04Z","updated_at":"2016-10-26T03:05:26Z","pushed_at":"2017-05-05T18:19:07Z","git_url":"git://github.com/AtomicConductor/conductor_client.git","ssh_url":"git@github.com:AtomicConductor/conductor_client.git","clone_url":"https://github.com/AtomicConductor/conductor_client.git","svn_url":"https://github.com/AtomicConductor/conductor_client","homepage":"","size":38648,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/99"},"html":{"href":"https://github.com/AtomicConductor/conductor_client/pull/99"},"issue":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/issues/99"},"comments":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/AtomicConductor/conductor_client/statuses/08c4aa33b22f4a65267e0a0f2e99b176f677e0eb"}}}}
{"actor":{"display_login":"lawschlosser"}}