{"action":"created","issue":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/2398","repository_url":"https://api.github.com/repos/facebookincubator/create-react-app","labels_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/2398/labels{/name}","comments_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/2398/comments","events_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/2398/events","html_url":"https://github.com/facebookincubator/create-react-app/issues/2398","id":231876449,"number":2398,"title":"Why was service worker merged into create react app?","user":{"login":"jantimon","id":4113649,"avatar_url":"https://avatars1.githubusercontent.com/u/4113649?v=3","gravatar_id":"","url":"https://api.github.com/users/jantimon","html_url":"https://github.com/jantimon","followers_url":"https://api.github.com/users/jantimon/followers","following_url":"https://api.github.com/users/jantimon/following{/other_user}","gists_url":"https://api.github.com/users/jantimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jantimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jantimon/subscriptions","organizations_url":"https://api.github.com/users/jantimon/orgs","repos_url":"https://api.github.com/users/jantimon/repos","events_url":"https://api.github.com/users/jantimon/events{/privacy}","received_events_url":"https://api.github.com/users/jantimon/received_events","type":"User","site_admin":false},"labels":[{"id":411265157,"url":"https://api.github.com/repos/facebookincubator/create-react-app/labels/issue:%20proposal","name":"issue: proposal","color":"fbca04","default":false},{"id":608169145,"url":"https://api.github.com/repos/facebookincubator/create-react-app/labels/issue:%20question%20%3E%20PWA","name":"issue: question > PWA","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/milestones/33","html_url":"https://github.com/facebookincubator/create-react-app/milestone/33","labels_url":"https://api.github.com/repos/facebookincubator/create-react-app/milestones/33/labels","id":2531874,"number":33,"title":"1.x","description":"","creator":{"login":"gaearon","id":810438,"avatar_url":"https://avatars3.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2017-05-19T16:06:34Z","updated_at":"2017-06-07T12:57:19Z","due_on":null,"closed_at":null},"comments":73,"created_at":"2017-05-28T15:39:19Z","updated_at":"2017-06-18T14:47:11Z","closed_at":null,"body":"I use create create app for teaching and I don't see the benefit in making stuff more complicated with adding so much advanced boilerplate code.\r\n\r\nYou probably know that service worker won't work on any iOS device (20% - 25% of all your users) and this is not about to change soon (maybe never). \r\n\r\nAdding service workers by default is about to create very different experiences and bug behaviour depending on the device. It also makes it way more complicated to get a create react app to work offline for all platforms. \r\n\r\nPlease don't turn cra into something like a Windows98 computer where you had to remove AOL and other preinstalled stuff before being able to be productive."},"comment":{"url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/comments/309281955","html_url":"https://github.com/facebookincubator/create-react-app/issues/2398#issuecomment-309281955","issue_url":"https://api.github.com/repos/facebookincubator/create-react-app/issues/2398","id":309281955,"user":{"login":"viankakrisna","id":9636410,"avatar_url":"https://avatars2.githubusercontent.com/u/9636410?v=3","gravatar_id":"","url":"https://api.github.com/users/viankakrisna","html_url":"https://github.com/viankakrisna","followers_url":"https://api.github.com/users/viankakrisna/followers","following_url":"https://api.github.com/users/viankakrisna/following{/other_user}","gists_url":"https://api.github.com/users/viankakrisna/gists{/gist_id}","starred_url":"https://api.github.com/users/viankakrisna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viankakrisna/subscriptions","organizations_url":"https://api.github.com/users/viankakrisna/orgs","repos_url":"https://api.github.com/users/viankakrisna/repos","events_url":"https://api.github.com/users/viankakrisna/events{/privacy}","received_events_url":"https://api.github.com/users/viankakrisna/received_events","type":"User","site_admin":false},"created_at":"2017-06-18T14:47:11Z","updated_at":"2017-06-18T14:47:11Z","body":"based on this http://www.phpied.com/create-react-app-sw-precache-pwa/ sw-precache can be added on the user space without the need of fiddling with webpack config. And I remember a long time ago I have made PWA compatible CRA generated project with adding a post-build command. I can't remember whether it's sw-precache or sw-toolbox."}}
{"actor":{"display_login":"viankakrisna"}}