{"action":"created","issue":{"url":"https://api.github.com/repos/OpenRA/OpenRA/issues/13553","repository_url":"https://api.github.com/repos/OpenRA/OpenRA","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/13553/labels{/name}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/13553/comments","events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/13553/events","html_url":"https://github.com/OpenRA/OpenRA/pull/13553","id":238416005,"number":13553,"title":"Refactor Building.Footprint, replace FootprintUtils, add untargetable cells","user":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars0.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"labels":[{"id":118143255,"url":"https://api.github.com/repos/OpenRA/OpenRA/labels/PR:%20Needs%20+2","name":"PR: Needs +2","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/OpenRA/OpenRA/milestones/23","html_url":"https://github.com/OpenRA/OpenRA/milestone/23","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones/23/labels","id":2556950,"number":23,"title":"Playtest featuring updated HitShapes","description":"...and updated weapon targeting.","creator":{"login":"reaperrr","id":2857877,"avatar_url":"https://avatars0.githubusercontent.com/u/2857877?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperrr","html_url":"https://github.com/reaperrr","followers_url":"https://api.github.com/users/reaperrr/followers","following_url":"https://api.github.com/users/reaperrr/following{/other_user}","gists_url":"https://api.github.com/users/reaperrr/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperrr/subscriptions","organizations_url":"https://api.github.com/users/reaperrr/orgs","repos_url":"https://api.github.com/users/reaperrr/repos","events_url":"https://api.github.com/users/reaperrr/events{/privacy}","received_events_url":"https://api.github.com/users/reaperrr/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":61,"state":"open","created_at":"2017-06-01T19:00:24Z","updated_at":"2017-07-09T19:58:22Z","due_on":"2017-07-23T07:00:00Z","closed_at":null},"comments":4,"created_at":"2017-06-26T00:00:45Z","updated_at":"2017-07-09T22:04:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/13553","html_url":"https://github.com/OpenRA/OpenRA/pull/13553","diff_url":"https://github.com/OpenRA/OpenRA/pull/13553.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/13553.patch"},"body":"Refactors `Building.Footprint` loading and replaces `FootprintUtils` with BuildingInfo equivalents.\r\n\r\nAdds a 'u' letter to Footprint that behaves like 'x', except that it is ignored by `HitShape.UseTargetableCellsOffsets = true`.\r\n\r\nWhile the amount of yaml lines and custom `TargetableOffsets` it saves in the shipping mods might fall into the *'nice, but is that really worth it?'* category, the savings in TS would be tremendous, so much that I'd refuse setting up custom `TargetableOffsets` in TS and just stick to occupied cells if this were rejected.\r\n\r\nApplied it to all shipping mods (TS will be adressed with #13464).\r\n\r\nDepends on #13561.\r\nCloses #13476.\r\nDependency for doing #13464 properly."},"comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments/313968580","html_url":"https://github.com/OpenRA/OpenRA/pull/13553#issuecomment-313968580","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/13553","id":313968580,"user":{"login":"ltem","id":20945684,"avatar_url":"https://avatars1.githubusercontent.com/u/20945684?v=3","gravatar_id":"","url":"https://api.github.com/users/ltem","html_url":"https://github.com/ltem","followers_url":"https://api.github.com/users/ltem/followers","following_url":"https://api.github.com/users/ltem/following{/other_user}","gists_url":"https://api.github.com/users/ltem/gists{/gist_id}","starred_url":"https://api.github.com/users/ltem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltem/subscriptions","organizations_url":"https://api.github.com/users/ltem/orgs","repos_url":"https://api.github.com/users/ltem/repos","events_url":"https://api.github.com/users/ltem/events{/privacy}","received_events_url":"https://api.github.com/users/ltem/received_events","type":"User","site_admin":false},"created_at":"2017-07-09T22:04:26Z","updated_at":"2017-07-09T22:04:26Z","body":"I found a small regression from #13561. The palace structure in d2k is a 3x3 building with a \"bib\" line at the bottom row. Right now it is a 3x4 building with a bib line like the heavy factory.\r\n\r\n([Line 1018](https://github.com/OpenRA/OpenRA/pull/13553/commits/9c44ce241741e705f93097cc4729b1200d1bad04#diff-76baa349824e533ba919e9780fa23362R1018))\r\n\r\n\r\n|Screenshot from Gruntmods|\r\n|:---:|\r\n|![screenie](https://user-images.githubusercontent.com/20945684/27997864-3dfe1b72-6501-11e7-82fc-2c904fd95172.png)|\r\n\r\n"}}
{"actor":{"display_login":"ltem"}}