{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/comments/153655685","pull_request_review_id":79684538,"id":153655685,"diff_hunk":"@@ -84,3 +329,15 @@ export function copyDir(fromDir: string, toDir: string) {\n     }\n   }\n }\n+\n+export async function assertDoesNotSettle(","path":"src/test/util.ts","position":271,"original_position":271,"commit_id":"3c606c4eab95076c8c2129fee4490ebe5ff59516","original_commit_id":"3c606c4eab95076c8c2129fee4490ebe5ff59516","user":{"login":"valdrinkoshi","id":6173664,"avatar_url":"https://avatars3.githubusercontent.com/u/6173664?v=4","gravatar_id":"","url":"https://api.github.com/users/valdrinkoshi","html_url":"https://github.com/valdrinkoshi","followers_url":"https://api.github.com/users/valdrinkoshi/followers","following_url":"https://api.github.com/users/valdrinkoshi/following{/other_user}","gists_url":"https://api.github.com/users/valdrinkoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/valdrinkoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valdrinkoshi/subscriptions","organizations_url":"https://api.github.com/users/valdrinkoshi/orgs","repos_url":"https://api.github.com/users/valdrinkoshi/repos","events_url":"https://api.github.com/users/valdrinkoshi/events{/privacy}","received_events_url":"https://api.github.com/users/valdrinkoshi/received_events","type":"User","site_admin":false},"body":"love the naming 👌 ","created_at":"2017-11-28T23:33:52Z","updated_at":"2017-11-28T23:34:16Z","html_url":"https://github.com/Polymer/polymer-editor-service/pull/81#discussion_r153655685","pull_request_url":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/81","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/comments/153655685"},"html":{"href":"https://github.com/Polymer/polymer-editor-service/pull/81#discussion_r153655685"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/81"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/81","id":154468059,"html_url":"https://github.com/Polymer/polymer-editor-service/pull/81","diff_url":"https://github.com/Polymer/polymer-editor-service/pull/81.diff","patch_url":"https://github.com/Polymer/polymer-editor-service/pull/81.patch","issue_url":"https://api.github.com/repos/Polymer/polymer-editor-service/issues/81","number":81,"state":"open","locked":false,"title":"Add a test client for integration testing.","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars3.githubusercontent.com/u/1659?v=4","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"<!--\r\n  Thanks for the PR!\r\n\r\n  If this change has a user visible change (including\r\n  bug fixes, new features, etc) please describe the change in\r\n  CHANGELOG.md.\r\n\r\n  If the change is an entirely package-internal reshuffling/refactoring\r\n  should the change not be described in the CHANGELOG.\r\n\r\n  Consider also updating the README.\r\n\r\n  More info: http://keepachangelog.com/en/0.3.0/\r\n -->\r\n\r\n - [x] CHANGELOG.md not updated, internal change.\r\n\r\nI'm moving code out of LocalEditorService and migrating its tests to be full integration tests of the server. This is a client based on the core JSON RPC interface, giving us the ability to assert about anything that the server can do, as well as test the server's full behavior, rather than just testing individual internal methods.\r\n\r\nThis follows my favorite testing perspective: [write tests, not too many, mostly integration](https://blog.kentcdodds.com/write-tests-not-too-many-mostly-integration-5e8c7fff591c).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/polymer/polymer-editor-service/81)\n<!-- Reviewable:end -->\n","created_at":"2017-11-24T03:24:17Z","updated_at":"2017-11-28T23:34:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eb919f278a381a47a27da30fe0b238a3b4f09e6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/81/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/81/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer-editor-service/issues/81/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer-editor-service/statuses/3c606c4eab95076c8c2129fee4490ebe5ff59516","head":{"label":"Polymer:refactoring-2.75-test-client","ref":"refactoring-2.75-test-client","sha":"3c606c4eab95076c8c2129fee4490ebe5ff59516","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":69617712,"name":"polymer-editor-service","full_name":"Polymer/polymer-editor-service","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-editor-service","description":"Static analysis for the web in your text editor","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-editor-service","forks_url":"https://api.github.com/repos/Polymer/polymer-editor-service/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-editor-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-editor-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-editor-service/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-editor-service/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-editor-service/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-editor-service/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-editor-service/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-editor-service/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-editor-service/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-editor-service/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-editor-service/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-editor-service/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-editor-service/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-editor-service/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-editor-service/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-editor-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-editor-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-editor-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-editor-service/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-editor-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-editor-service/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-editor-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-editor-service/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-editor-service/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-editor-service/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-editor-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-editor-service/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-editor-service/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-editor-service/deployments","created_at":"2016-09-30T00:03:56Z","updated_at":"2017-11-22T08:21:21Z","pushed_at":"2017-11-28T19:41:15Z","git_url":"git://github.com/Polymer/polymer-editor-service.git","ssh_url":"git@github.com:Polymer/polymer-editor-service.git","clone_url":"https://github.com/Polymer/polymer-editor-service.git","svn_url":"https://github.com/Polymer/polymer-editor-service","homepage":"","size":338,"stargazers_count":64,"watchers_count":64,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":8,"open_issues":48,"watchers":64,"default_branch":"master"}},"base":{"label":"Polymer:refactoring-2.5-synchronized-project-config","ref":"refactoring-2.5-synchronized-project-config","sha":"f0632678ab1e1cf274cc6cd2850df67b06482046","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":69617712,"name":"polymer-editor-service","full_name":"Polymer/polymer-editor-service","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-editor-service","description":"Static analysis for the web in your text editor","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-editor-service","forks_url":"https://api.github.com/repos/Polymer/polymer-editor-service/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-editor-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-editor-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-editor-service/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-editor-service/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-editor-service/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-editor-service/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-editor-service/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-editor-service/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-editor-service/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-editor-service/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-editor-service/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-editor-service/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-editor-service/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-editor-service/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-editor-service/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-editor-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-editor-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-editor-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-editor-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-editor-service/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-editor-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-editor-service/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-editor-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-editor-service/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-editor-service/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-editor-service/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-editor-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-editor-service/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-editor-service/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-editor-service/deployments","created_at":"2016-09-30T00:03:56Z","updated_at":"2017-11-22T08:21:21Z","pushed_at":"2017-11-28T19:41:15Z","git_url":"git://github.com/Polymer/polymer-editor-service.git","ssh_url":"git@github.com:Polymer/polymer-editor-service.git","clone_url":"https://github.com/Polymer/polymer-editor-service.git","svn_url":"https://github.com/Polymer/polymer-editor-service","homepage":"","size":338,"stargazers_count":64,"watchers_count":64,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":8,"open_issues":48,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/81"},"html":{"href":"https://github.com/Polymer/polymer-editor-service/pull/81"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/issues/81"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer-editor-service/statuses/3c606c4eab95076c8c2129fee4490ebe5ff59516"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"valdrinkoshi"}}