{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/117406072","pull_request_review_id":39112073,"id":117406072,"diff_hunk":"@@ -67,35 +69,41 @@ linter:\n     - always_specify_types\n     - annotate_overrides\n     - avoid_as\n+    # - avoid_function_literals_in_foreach_calls # not yet tested\n     - avoid_init_to_null\n     - avoid_return_types_on_setters\n     - await_only_futures\n     - camel_case_types\n+    # - cascade_invocations # not yet tested\n     # - constant_identifier_names # https://github.com/dart-lang/linter/issues/204\n     - directives_ordering\n     - empty_catches\n     - empty_constructor_bodies\n     - implementation_imports\n     - library_names\n     - library_prefixes\n-    - no_adjacent_strings_in_list\n-    - no_duplicate_case_values\n     - non_constant_identifier_names\n+    # - omit_local_variable_types # opposite of always_specify_types\n     # - one_member_abstracts # too many false positives\n     # - only_throw_errors # https://github.com/flutter/flutter/issues/5792\n-    # - overridden_fields\n+    # - overridden_fields # not yet tested\n     - package_api_docs\n     - package_prefixed_library_names\n     # - parameter_assignments # we do this commonly\n-    # - prefer_final_fields # https://github.com/dart-lang/sdk/issues/29197\n-    - prefer_collection_literal\n+    # - prefer_adjacent_string_concatenation # not yet tested\n+    - prefer_collection_literals\n     - prefer_const_constructors\n     - prefer_contains\n+    # - prefer_expression_function_bodies # not yet tested\n+    # - prefer_final_fields # https://github.com/dart-lang/linter/issues/506\n     - prefer_final_locals\n+    # - prefer_function_declarations_over_variables # not yet tested\n     - prefer_initializing_formals\n+    # - prefer_interpolation_to_compose_strings # not yet tested\n     - prefer_is_empty\n     - prefer_is_not_empty\n-    - public_member_api_docs # this is the only difference from .analysis_options\n+    # - public_member_api_docs # this is the only difference from .analysis_options_repo","path":".analysis_options_repo","position":56,"original_position":56,"commit_id":"25a9c9bc9b7f89430309d636714bdab0d98d387e","original_commit_id":"25a9c9bc9b7f89430309d636714bdab0d98d387e","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars1.githubusercontent.com/u/551196?v=3","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"Not a problem, I just wanted to let you know in case you edit that file again. :-)","created_at":"2017-05-19T05:32:54Z","updated_at":"2017-05-19T05:32:55Z","html_url":"https://github.com/flutter/flutter/pull/9330#discussion_r117406072","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/9330","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/117406072"},"html":{"href":"https://github.com/flutter/flutter/pull/9330#discussion_r117406072"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9330"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/9330","id":115362097,"html_url":"https://github.com/flutter/flutter/pull/9330","diff_url":"https://github.com/flutter/flutter/pull/9330.diff","patch_url":"https://github.com/flutter/flutter/pull/9330.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/9330","number":9330,"state":"closed","locked":false,"title":"comprehensive list of lints","user":{"login":"a14n","id":1206632,"avatar_url":"https://avatars2.githubusercontent.com/u/1206632?v=3","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"body":"All lints from linter-0.1.30 are now listed.","created_at":"2017-04-11T16:28:11Z","updated_at":"2017-05-19T05:32:55Z","closed_at":"2017-04-20T07:38:57Z","merged_at":"2017-04-20T07:38:57Z","merge_commit_sha":"35803c2297bb45045bda1c9079ade3181384ed6c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/9330/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/9330/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/9330/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/25a9c9bc9b7f89430309d636714bdab0d98d387e","head":{"label":"a14n:comprehensive-list-of-lints","ref":"comprehensive-list-of-lints","sha":"25a9c9bc9b7f89430309d636714bdab0d98d387e","user":{"login":"a14n","id":1206632,"avatar_url":"https://avatars2.githubusercontent.com/u/1206632?v=3","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"repo":{"id":50984105,"name":"flutter","full_name":"a14n/flutter","owner":{"login":"a14n","id":1206632,"avatar_url":"https://avatars2.githubusercontent.com/u/1206632?v=3","gravatar_id":"","url":"https://api.github.com/users/a14n","html_url":"https://github.com/a14n","followers_url":"https://api.github.com/users/a14n/followers","following_url":"https://api.github.com/users/a14n/following{/other_user}","gists_url":"https://api.github.com/users/a14n/gists{/gist_id}","starred_url":"https://api.github.com/users/a14n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a14n/subscriptions","organizations_url":"https://api.github.com/users/a14n/orgs","repos_url":"https://api.github.com/users/a14n/repos","events_url":"https://api.github.com/users/a14n/events{/privacy}","received_events_url":"https://api.github.com/users/a14n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a14n/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":true,"url":"https://api.github.com/repos/a14n/flutter","forks_url":"https://api.github.com/repos/a14n/flutter/forks","keys_url":"https://api.github.com/repos/a14n/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a14n/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a14n/flutter/teams","hooks_url":"https://api.github.com/repos/a14n/flutter/hooks","issue_events_url":"https://api.github.com/repos/a14n/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/a14n/flutter/events","assignees_url":"https://api.github.com/repos/a14n/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/a14n/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/a14n/flutter/tags","blobs_url":"https://api.github.com/repos/a14n/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a14n/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a14n/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/a14n/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a14n/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/a14n/flutter/languages","stargazers_url":"https://api.github.com/repos/a14n/flutter/stargazers","contributors_url":"https://api.github.com/repos/a14n/flutter/contributors","subscribers_url":"https://api.github.com/repos/a14n/flutter/subscribers","subscription_url":"https://api.github.com/repos/a14n/flutter/subscription","commits_url":"https://api.github.com/repos/a14n/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/a14n/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/a14n/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/a14n/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/a14n/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/a14n/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a14n/flutter/merges","archive_url":"https://api.github.com/repos/a14n/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a14n/flutter/downloads","issues_url":"https://api.github.com/repos/a14n/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/a14n/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/a14n/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/a14n/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a14n/flutter/labels{/name}","releases_url":"https://api.github.com/repos/a14n/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/a14n/flutter/deployments","created_at":"2016-02-03T08:04:00Z","updated_at":"2016-02-03T08:04:01Z","pushed_at":"2017-05-17T04:35:31Z","git_url":"git://github.com/a14n/flutter.git","ssh_url":"git@github.com:a14n/flutter.git","clone_url":"https://github.com/a14n/flutter.git","svn_url":"https://github.com/a14n/flutter","homepage":"http://flutter.io","size":26907,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"96d8a2a3ad49f365ee85f5d7ed15ba51c13bdf8c","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars0.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-05-19T03:35:46Z","pushed_at":"2017-05-19T05:32:20Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":26930,"stargazers_count":4724,"watchers_count":4724,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":491,"mirror_url":null,"open_issues_count":1522,"forks":491,"open_issues":1522,"watchers":4724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9330"},"html":{"href":"https://github.com/flutter/flutter/pull/9330"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/9330"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/9330/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9330/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/9330/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/25a9c9bc9b7f89430309d636714bdab0d98d387e"}}}}
{"actor":{"display_login":"Hixie"}}