{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/californium/pulls/comments/149295030","pull_request_review_id":74660973,"id":149295030,"diff_hunk":"@@ -154,22 +156,25 @@ public ClientHandshaker(DTLSSession session, RecordLayer recordLayer, SessionLis\n \t\tthis.preferredCipherSuites = config.getSupportedCipherSuites();\n \t\tthis.maxFragmentLengthCode = config.getMaxFragmentLengthCode();\n \t\tthis.supportedServerCertificateTypes = new ArrayList<>();\n-\t\tthis.supportedServerCertificateTypes.add(CertificateType.RAW_PUBLIC_KEY);\n-\t\tif (rootCertificates != null && rootCertificates.length > 0) {\n-\t\t\tint index = config.isSendRawKey() ? 1 : 0;\n-\t\t\tthis.supportedServerCertificateTypes.add(index, CertificateType.X_509);\n-\t\t}\n-\n \t\tthis.supportedClientCertificateTypes = new ArrayList<>();\n-\t\tif (privateKey != null && publicKey != null) {\n-\t\t\tif (certificateChain == null || certificateChain.length == 0) {\n-\t\t\t\tthis.supportedClientCertificateTypes.add(CertificateType.RAW_PUBLIC_KEY);\n-\t\t\t} else if (config.isSendRawKey()) {\n-\t\t\t\tthis.supportedClientCertificateTypes.add(CertificateType.RAW_PUBLIC_KEY);\n-\t\t\t\tthis.supportedClientCertificateTypes.add(CertificateType.X_509);\n-\t\t\t} else {\n-\t\t\t\tthis.supportedClientCertificateTypes.add(CertificateType.X_509);\n-\t\t\t\tthis.supportedClientCertificateTypes.add(CertificateType.RAW_PUBLIC_KEY);\n+\n+\t\tif (config.useEcdheEcdsa()) {","path":"scandium-core/src/main/java/org/eclipse/californium/scandium/dtls/ClientHandshaker.java","position":30,"original_position":30,"commit_id":"1040e821a36fe827ac845c200fd177cbca45e5d1","original_commit_id":"1040e821a36fe827ac845c200fd177cbca45e5d1","user":{"login":"sophokles73","id":5682135,"avatar_url":"https://avatars1.githubusercontent.com/u/5682135?v=4","gravatar_id":"","url":"https://api.github.com/users/sophokles73","html_url":"https://github.com/sophokles73","followers_url":"https://api.github.com/users/sophokles73/followers","following_url":"https://api.github.com/users/sophokles73/following{/other_user}","gists_url":"https://api.github.com/users/sophokles73/gists{/gist_id}","starred_url":"https://api.github.com/users/sophokles73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sophokles73/subscriptions","organizations_url":"https://api.github.com/users/sophokles73/orgs","repos_url":"https://api.github.com/users/sophokles73/repos","events_url":"https://api.github.com/users/sophokles73/events{/privacy}","received_events_url":"https://api.github.com/users/sophokles73/received_events","type":"User","site_admin":false},"body":"BTW the CLIENT_HELLO also includes extensions that are only relevant for ECC based ciphers. I think we should make inclusion of those also dependent on the support for ECC based ciphers ...","created_at":"2017-11-07T08:13:32Z","updated_at":"2017-11-07T08:13:40Z","html_url":"https://github.com/eclipse/californium/pull/468#discussion_r149295030","pull_request_url":"https://api.github.com/repos/eclipse/californium/pulls/468","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/californium/pulls/comments/149295030"},"html":{"href":"https://github.com/eclipse/californium/pull/468#discussion_r149295030"},"pull_request":{"href":"https://api.github.com/repos/eclipse/californium/pulls/468"}},"in_reply_to_id":149294901},"pull_request":{"url":"https://api.github.com/repos/eclipse/californium/pulls/468","id":150934286,"html_url":"https://github.com/eclipse/californium/pull/468","diff_url":"https://github.com/eclipse/californium/pull/468.diff","patch_url":"https://github.com/eclipse/californium/pull/468.patch","issue_url":"https://api.github.com/repos/eclipse/californium/issues/468","number":468,"state":"open","locked":false,"title":"Reduce CLIENT_HELLO, if TLS_ECDHE_ECDSA is not used.","user":{"login":"boaks","id":10937819,"avatar_url":"https://avatars2.githubusercontent.com/u/10937819?v=4","gravatar_id":"","url":"https://api.github.com/users/boaks","html_url":"https://github.com/boaks","followers_url":"https://api.github.com/users/boaks/followers","following_url":"https://api.github.com/users/boaks/following{/other_user}","gists_url":"https://api.github.com/users/boaks/gists{/gist_id}","starred_url":"https://api.github.com/users/boaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boaks/subscriptions","organizations_url":"https://api.github.com/users/boaks/orgs","repos_url":"https://api.github.com/users/boaks/repos","events_url":"https://api.github.com/users/boaks/events{/privacy}","received_events_url":"https://api.github.com/users/boaks/received_events","type":"User","site_admin":false},"body":"Don't send the EC extensions, if no TLS_ECDHE_ECDSA cipher suite is used.\r\n\r\nSigned-off-by: Achim Kraus <achim.kraus@bosch-si.com>","created_at":"2017-11-06T19:11:00Z","updated_at":"2017-11-07T08:13:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3fdef6eac556403c1cf9a92b304120c1ed005c8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/californium/pulls/468/commits","review_comments_url":"https://api.github.com/repos/eclipse/californium/pulls/468/comments","review_comment_url":"https://api.github.com/repos/eclipse/californium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/californium/issues/468/comments","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/1040e821a36fe827ac845c200fd177cbca45e5d1","head":{"label":"bsinno:reduce_client_hello_size","ref":"reduce_client_hello_size","sha":"1040e821a36fe827ac845c200fd177cbca45e5d1","user":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"repo":{"id":52429243,"name":"californium","full_name":"bsinno/californium","owner":{"login":"bsinno","id":9215699,"avatar_url":"https://avatars3.githubusercontent.com/u/9215699?v=4","gravatar_id":"","url":"https://api.github.com/users/bsinno","html_url":"https://github.com/bsinno","followers_url":"https://api.github.com/users/bsinno/followers","following_url":"https://api.github.com/users/bsinno/following{/other_user}","gists_url":"https://api.github.com/users/bsinno/gists{/gist_id}","starred_url":"https://api.github.com/users/bsinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsinno/subscriptions","organizations_url":"https://api.github.com/users/bsinno/orgs","repos_url":"https://api.github.com/users/bsinno/repos","events_url":"https://api.github.com/users/bsinno/events{/privacy}","received_events_url":"https://api.github.com/users/bsinno/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bsinno/californium","description":null,"fork":true,"url":"https://api.github.com/repos/bsinno/californium","forks_url":"https://api.github.com/repos/bsinno/californium/forks","keys_url":"https://api.github.com/repos/bsinno/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsinno/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsinno/californium/teams","hooks_url":"https://api.github.com/repos/bsinno/californium/hooks","issue_events_url":"https://api.github.com/repos/bsinno/californium/issues/events{/number}","events_url":"https://api.github.com/repos/bsinno/californium/events","assignees_url":"https://api.github.com/repos/bsinno/californium/assignees{/user}","branches_url":"https://api.github.com/repos/bsinno/californium/branches{/branch}","tags_url":"https://api.github.com/repos/bsinno/californium/tags","blobs_url":"https://api.github.com/repos/bsinno/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsinno/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsinno/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsinno/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsinno/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/bsinno/californium/languages","stargazers_url":"https://api.github.com/repos/bsinno/californium/stargazers","contributors_url":"https://api.github.com/repos/bsinno/californium/contributors","subscribers_url":"https://api.github.com/repos/bsinno/californium/subscribers","subscription_url":"https://api.github.com/repos/bsinno/californium/subscription","commits_url":"https://api.github.com/repos/bsinno/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsinno/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsinno/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsinno/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsinno/californium/contents/{+path}","compare_url":"https://api.github.com/repos/bsinno/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsinno/californium/merges","archive_url":"https://api.github.com/repos/bsinno/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsinno/californium/downloads","issues_url":"https://api.github.com/repos/bsinno/californium/issues{/number}","pulls_url":"https://api.github.com/repos/bsinno/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/bsinno/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/bsinno/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsinno/californium/labels{/name}","releases_url":"https://api.github.com/repos/bsinno/californium/releases{/id}","deployments_url":"https://api.github.com/repos/bsinno/californium/deployments","created_at":"2016-02-24T09:13:26Z","updated_at":"2017-09-28T14:18:05Z","pushed_at":"2017-11-07T07:57:13Z","git_url":"git://github.com/bsinno/californium.git","ssh_url":"git@github.com:bsinno/californium.git","clone_url":"https://github.com/bsinno/californium.git","svn_url":"https://github.com/bsinno/californium","homepage":null,"size":5680,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:2.0.x","ref":"2.0.x","sha":"065987464c9af434a0857a8c23f37d5a8353f604","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":43075480,"name":"californium","full_name":"eclipse/californium","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/californium","description":null,"fork":false,"url":"https://api.github.com/repos/eclipse/californium","forks_url":"https://api.github.com/repos/eclipse/californium/forks","keys_url":"https://api.github.com/repos/eclipse/californium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/californium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/californium/teams","hooks_url":"https://api.github.com/repos/eclipse/californium/hooks","issue_events_url":"https://api.github.com/repos/eclipse/californium/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/californium/events","assignees_url":"https://api.github.com/repos/eclipse/californium/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/californium/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/californium/tags","blobs_url":"https://api.github.com/repos/eclipse/californium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/californium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/californium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/californium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/californium/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/californium/languages","stargazers_url":"https://api.github.com/repos/eclipse/californium/stargazers","contributors_url":"https://api.github.com/repos/eclipse/californium/contributors","subscribers_url":"https://api.github.com/repos/eclipse/californium/subscribers","subscription_url":"https://api.github.com/repos/eclipse/californium/subscription","commits_url":"https://api.github.com/repos/eclipse/californium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/californium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/californium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/californium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/californium/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/californium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/californium/merges","archive_url":"https://api.github.com/repos/eclipse/californium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/californium/downloads","issues_url":"https://api.github.com/repos/eclipse/californium/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/californium/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/californium/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/californium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/californium/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/californium/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/californium/deployments","created_at":"2015-09-24T15:27:15Z","updated_at":"2017-11-06T05:05:06Z","pushed_at":"2017-11-07T08:00:56Z","git_url":"git://github.com/eclipse/californium.git","ssh_url":"git@github.com:eclipse/californium.git","clone_url":"https://github.com/eclipse/californium.git","svn_url":"https://github.com/eclipse/californium","homepage":null,"size":5639,"stargazers_count":164,"watchers_count":164,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":43,"forks":144,"open_issues":43,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/californium/pulls/468"},"html":{"href":"https://github.com/eclipse/californium/pull/468"},"issue":{"href":"https://api.github.com/repos/eclipse/californium/issues/468"},"comments":{"href":"https://api.github.com/repos/eclipse/californium/issues/468/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/californium/pulls/468/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/californium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/californium/pulls/468/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/californium/statuses/1040e821a36fe827ac845c200fd177cbca45e5d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sophokles73"}}