{"action":"created","comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/101904290","pull_request_review_id":22647977,"id":101904290,"diff_hunk":"@@ -441,44 +509,273 @@ public int getID()\n     }\n \n     /**\n-     * Increment the mobs killed by this colony.\n-     * <p>\n-     * Will award achievements for mobs killed.\n+     * Increment the statistic amount and trigger achievement.\n+     *\n+     * @param statistic the statistic.\n      */\n-    public void incrementMobsKilled()\n+    public void incrementStatistic(@NotNull String statistic)","path":"src/main/java/com/minecolonies/coremod/colony/Colony.java","position":145,"original_position":145,"commit_id":"d437de15e6671530077a65b0f8d671db89ceae7c","original_commit_id":"d437de15e6671530077a65b0f8d671db89ceae7c","user":{"login":"MinecoloniesSonar","id":19393044,"avatar_url":"https://avatars.githubusercontent.com/u/19393044?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecoloniesSonar","html_url":"https://github.com/MinecoloniesSonar","followers_url":"https://api.github.com/users/MinecoloniesSonar/followers","following_url":"https://api.github.com/users/MinecoloniesSonar/following{/other_user}","gists_url":"https://api.github.com/users/MinecoloniesSonar/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecoloniesSonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecoloniesSonar/subscriptions","organizations_url":"https://api.github.com/users/MinecoloniesSonar/orgs","repos_url":"https://api.github.com/users/MinecoloniesSonar/repos","events_url":"https://api.github.com/users/MinecoloniesSonar/events{/privacy}","received_events_url":"https://api.github.com/users/MinecoloniesSonar/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png 'Severity: MAJOR') This method has 228 lines, which is greater than the 100 lines authorized. Split it into smaller methods. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://home.kk-sc.de:9000/coding_rules#rule_key=squid%3AS138)\n![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png 'Severity: MAJOR') The Cyclomatic Complexity of this method \"incrementStatistic\" is 72 which is greater than 10 authorized. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](http://home.kk-sc.de:9000/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity)\n","created_at":"2017-02-18T22:39:22Z","updated_at":"2017-02-18T22:39:22Z","html_url":"https://github.com/Minecolonies/minecolonies/pull/629#discussion_r101904290","pull_request_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/629","_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/101904290"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/629#discussion_r101904290"},"pull_request":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/629"}}},"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/629","id":106870074,"html_url":"https://github.com/Minecolonies/minecolonies/pull/629","diff_url":"https://github.com/Minecolonies/minecolonies/pull/629.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/629.patch","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/629","number":629,"state":"open","locked":false,"title":"Feature/#476 new achievements","user":{"login":"nojo121","id":17111591,"avatar_url":"https://avatars.githubusercontent.com/u/17111591?v=3","gravatar_id":"","url":"https://api.github.com/users/nojo121","html_url":"https://github.com/nojo121","followers_url":"https://api.github.com/users/nojo121/followers","following_url":"https://api.github.com/users/nojo121/following{/other_user}","gists_url":"https://api.github.com/users/nojo121/gists{/gist_id}","starred_url":"https://api.github.com/users/nojo121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojo121/subscriptions","organizations_url":"https://api.github.com/users/nojo121/orgs","repos_url":"https://api.github.com/users/nojo121/repos","events_url":"https://api.github.com/users/nojo121/events{/privacy}","received_events_url":"https://api.github.com/users/nojo121/received_events","type":"User","site_admin":false},"body":"Closes #476 \r\n\r\n# Changes proposed in this pull request:\r\n-Added 56 Achievements\r\n-cleaned up achievement page\r\n","created_at":"2017-02-18T17:44:53Z","updated_at":"2017-02-18T22:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e687b5047dc8402701fa56839fedac2774af6f67","assignee":{"login":"nojo121","id":17111591,"avatar_url":"https://avatars.githubusercontent.com/u/17111591?v=3","gravatar_id":"","url":"https://api.github.com/users/nojo121","html_url":"https://github.com/nojo121","followers_url":"https://api.github.com/users/nojo121/followers","following_url":"https://api.github.com/users/nojo121/following{/other_user}","gists_url":"https://api.github.com/users/nojo121/gists{/gist_id}","starred_url":"https://api.github.com/users/nojo121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojo121/subscriptions","organizations_url":"https://api.github.com/users/nojo121/orgs","repos_url":"https://api.github.com/users/nojo121/repos","events_url":"https://api.github.com/users/nojo121/events{/privacy}","received_events_url":"https://api.github.com/users/nojo121/received_events","type":"User","site_admin":false},"assignees":[{"login":"nojo121","id":17111591,"avatar_url":"https://avatars.githubusercontent.com/u/17111591?v=3","gravatar_id":"","url":"https://api.github.com/users/nojo121","html_url":"https://github.com/nojo121","followers_url":"https://api.github.com/users/nojo121/followers","following_url":"https://api.github.com/users/nojo121/following{/other_user}","gists_url":"https://api.github.com/users/nojo121/gists{/gist_id}","starred_url":"https://api.github.com/users/nojo121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojo121/subscriptions","organizations_url":"https://api.github.com/users/nojo121/orgs","repos_url":"https://api.github.com/users/nojo121/repos","events_url":"https://api.github.com/users/nojo121/events{/privacy}","received_events_url":"https://api.github.com/users/nojo121/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/629/commits","review_comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/629/comments","review_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/629/comments","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/d437de15e6671530077a65b0f8d671db89ceae7c","head":{"label":"Minecolonies:feature/#476-new-achievements","ref":"feature/#476-new-achievements","sha":"d437de15e6671530077a65b0f8d671db89ceae7c","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-02-16T12:25:16Z","pushed_at":"2017-02-18T22:32:05Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"git@github.com:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":12818,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":125,"forks":34,"open_issues":125,"watchers":20,"default_branch":"develop"}},"base":{"label":"Minecolonies:develop","ref":"develop","sha":"abe5b364a759b5bcf34a5e0751c15aaebdcb59d4","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-02-16T12:25:16Z","pushed_at":"2017-02-18T22:32:05Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"git@github.com:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":12818,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":125,"forks":34,"open_issues":125,"watchers":20,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/629"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/629"},"issue":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/629"},"comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/629/comments"},"review_comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/629/comments"},"review_comment":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/629/commits"},"statuses":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/d437de15e6671530077a65b0f8d671db89ceae7c"}}}}
{"actor":{"display_login":"MinecoloniesSonar"}}