{"action":"created","comment":{"url":"https://api.github.com/repos/datastax/python-driver/pulls/comments/141924185","pull_request_review_id":66219470,"id":141924185,"diff_hunk":"@@ -126,8 +126,11 @@ def _cleanup(self):\n                     watcher.stop()\n \n         self.notify()  # wake the timer watcher\n-        log.debug(\"Waiting for event loop thread to join...\")\n-        self._thread.join(timeout=1.0)\n+        # PYTHON-752 Thread might have just been created and not started\n+        try:\n+            self._thread.join(timeout=1.0)\n+        except RuntimeError:\n+            pass","path":"cassandra/io/libevreactor.py","position":null,"original_position":10,"commit_id":"40ad47c51a6a1bf2f831cb573f69c86d382cdc4f","original_commit_id":"231f103aaa3d62441ed80032e627d4681c1f8dd3","user":{"login":"mambocab","id":3753769,"avatar_url":"https://avatars1.githubusercontent.com/u/3753769?v=4","gravatar_id":"","url":"https://api.github.com/users/mambocab","html_url":"https://github.com/mambocab","followers_url":"https://api.github.com/users/mambocab/followers","following_url":"https://api.github.com/users/mambocab/following{/other_user}","gists_url":"https://api.github.com/users/mambocab/gists{/gist_id}","starred_url":"https://api.github.com/users/mambocab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambocab/subscriptions","organizations_url":"https://api.github.com/users/mambocab/orgs","repos_url":"https://api.github.com/users/mambocab/repos","events_url":"https://api.github.com/users/mambocab/events{/privacy}","received_events_url":"https://api.github.com/users/mambocab/received_events","type":"User","site_admin":false},"body":"I don't think I object to the lock as much as you do, but works for me.","created_at":"2017-09-29T17:32:50Z","updated_at":"2017-09-29T17:32:50Z","html_url":"https://github.com/datastax/python-driver/pull/830#discussion_r141924185","pull_request_url":"https://api.github.com/repos/datastax/python-driver/pulls/830","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/datastax/python-driver/pulls/comments/141924185"},"html":{"href":"https://github.com/datastax/python-driver/pull/830#discussion_r141924185"},"pull_request":{"href":"https://api.github.com/repos/datastax/python-driver/pulls/830"}},"in_reply_to_id":141704711},"pull_request":{"url":"https://api.github.com/repos/datastax/python-driver/pulls/830","id":142660084,"html_url":"https://github.com/datastax/python-driver/pull/830","diff_url":"https://github.com/datastax/python-driver/pull/830.diff","patch_url":"https://github.com/datastax/python-driver/pull/830.patch","issue_url":"https://api.github.com/repos/datastax/python-driver/issues/830","number":830,"state":"open","locked":false,"title":"Catch exception in case the thread hasn't been started at cleanup","user":{"login":"bjmb","id":6793045,"avatar_url":"https://avatars3.githubusercontent.com/u/6793045?v=4","gravatar_id":"","url":"https://api.github.com/users/bjmb","html_url":"https://github.com/bjmb","followers_url":"https://api.github.com/users/bjmb/followers","following_url":"https://api.github.com/users/bjmb/following{/other_user}","gists_url":"https://api.github.com/users/bjmb/gists{/gist_id}","starred_url":"https://api.github.com/users/bjmb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjmb/subscriptions","organizations_url":"https://api.github.com/users/bjmb/orgs","repos_url":"https://api.github.com/users/bjmb/repos","events_url":"https://api.github.com/users/bjmb/events{/privacy}","received_events_url":"https://api.github.com/users/bjmb/received_events","type":"User","site_admin":false},"body":"I'd rather do this solution than add a lock around [this part](https://github.com/datastax/python-driver/blob/d3e960134f97198f244873aa1ce66078947c3a89/cassandra/io/libevreactor.py#L97) and the part where the thread is joined. It looks more simple to me.","created_at":"2017-09-22T20:13:15Z","updated_at":"2017-09-29T17:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ca4755f714bfd00f0e32403d00043cb67f24717","assignee":{"login":"mambocab","id":3753769,"avatar_url":"https://avatars1.githubusercontent.com/u/3753769?v=4","gravatar_id":"","url":"https://api.github.com/users/mambocab","html_url":"https://github.com/mambocab","followers_url":"https://api.github.com/users/mambocab/followers","following_url":"https://api.github.com/users/mambocab/following{/other_user}","gists_url":"https://api.github.com/users/mambocab/gists{/gist_id}","starred_url":"https://api.github.com/users/mambocab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambocab/subscriptions","organizations_url":"https://api.github.com/users/mambocab/orgs","repos_url":"https://api.github.com/users/mambocab/repos","events_url":"https://api.github.com/users/mambocab/events{/privacy}","received_events_url":"https://api.github.com/users/mambocab/received_events","type":"User","site_admin":false},"assignees":[{"login":"mambocab","id":3753769,"avatar_url":"https://avatars1.githubusercontent.com/u/3753769?v=4","gravatar_id":"","url":"https://api.github.com/users/mambocab","html_url":"https://github.com/mambocab","followers_url":"https://api.github.com/users/mambocab/followers","following_url":"https://api.github.com/users/mambocab/following{/other_user}","gists_url":"https://api.github.com/users/mambocab/gists{/gist_id}","starred_url":"https://api.github.com/users/mambocab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mambocab/subscriptions","organizations_url":"https://api.github.com/users/mambocab/orgs","repos_url":"https://api.github.com/users/mambocab/repos","events_url":"https://api.github.com/users/mambocab/events{/privacy}","received_events_url":"https://api.github.com/users/mambocab/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/datastax/python-driver/pulls/830/commits","review_comments_url":"https://api.github.com/repos/datastax/python-driver/pulls/830/comments","review_comment_url":"https://api.github.com/repos/datastax/python-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datastax/python-driver/issues/830/comments","statuses_url":"https://api.github.com/repos/datastax/python-driver/statuses/40ad47c51a6a1bf2f831cb573f69c86d382cdc4f","head":{"label":"datastax:python-752","ref":"python-752","sha":"40ad47c51a6a1bf2f831cb573f69c86d382cdc4f","user":{"login":"datastax","id":573369,"avatar_url":"https://avatars0.githubusercontent.com/u/573369?v=4","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":11262602,"name":"python-driver","full_name":"datastax/python-driver","owner":{"login":"datastax","id":573369,"avatar_url":"https://avatars0.githubusercontent.com/u/573369?v=4","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datastax/python-driver","description":"DataStax Python Driver for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/datastax/python-driver","forks_url":"https://api.github.com/repos/datastax/python-driver/forks","keys_url":"https://api.github.com/repos/datastax/python-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/python-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/python-driver/teams","hooks_url":"https://api.github.com/repos/datastax/python-driver/hooks","issue_events_url":"https://api.github.com/repos/datastax/python-driver/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/python-driver/events","assignees_url":"https://api.github.com/repos/datastax/python-driver/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/python-driver/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/python-driver/tags","blobs_url":"https://api.github.com/repos/datastax/python-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/python-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/python-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/python-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/python-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/python-driver/languages","stargazers_url":"https://api.github.com/repos/datastax/python-driver/stargazers","contributors_url":"https://api.github.com/repos/datastax/python-driver/contributors","subscribers_url":"https://api.github.com/repos/datastax/python-driver/subscribers","subscription_url":"https://api.github.com/repos/datastax/python-driver/subscription","commits_url":"https://api.github.com/repos/datastax/python-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/python-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/python-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/python-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/python-driver/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/python-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/python-driver/merges","archive_url":"https://api.github.com/repos/datastax/python-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/python-driver/downloads","issues_url":"https://api.github.com/repos/datastax/python-driver/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/python-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/python-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/python-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/python-driver/labels{/name}","releases_url":"https://api.github.com/repos/datastax/python-driver/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/python-driver/deployments","created_at":"2013-07-08T19:02:31Z","updated_at":"2017-09-29T01:07:11Z","pushed_at":"2017-09-29T17:17:37Z","git_url":"git://github.com/datastax/python-driver.git","ssh_url":"git@github.com:datastax/python-driver.git","clone_url":"https://github.com/datastax/python-driver.git","svn_url":"https://github.com/datastax/python-driver","homepage":"","size":16828,"stargazers_count":750,"watchers_count":750,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":340,"mirror_url":null,"open_issues_count":13,"forks":340,"open_issues":13,"watchers":750,"default_branch":"master"}},"base":{"label":"datastax:master","ref":"master","sha":"66dd315011b0ff8575bd398381ead96e5806636c","user":{"login":"datastax","id":573369,"avatar_url":"https://avatars0.githubusercontent.com/u/573369?v=4","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"repo":{"id":11262602,"name":"python-driver","full_name":"datastax/python-driver","owner":{"login":"datastax","id":573369,"avatar_url":"https://avatars0.githubusercontent.com/u/573369?v=4","gravatar_id":"","url":"https://api.github.com/users/datastax","html_url":"https://github.com/datastax","followers_url":"https://api.github.com/users/datastax/followers","following_url":"https://api.github.com/users/datastax/following{/other_user}","gists_url":"https://api.github.com/users/datastax/gists{/gist_id}","starred_url":"https://api.github.com/users/datastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datastax/subscriptions","organizations_url":"https://api.github.com/users/datastax/orgs","repos_url":"https://api.github.com/users/datastax/repos","events_url":"https://api.github.com/users/datastax/events{/privacy}","received_events_url":"https://api.github.com/users/datastax/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datastax/python-driver","description":"DataStax Python Driver for Apache Cassandra","fork":false,"url":"https://api.github.com/repos/datastax/python-driver","forks_url":"https://api.github.com/repos/datastax/python-driver/forks","keys_url":"https://api.github.com/repos/datastax/python-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datastax/python-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datastax/python-driver/teams","hooks_url":"https://api.github.com/repos/datastax/python-driver/hooks","issue_events_url":"https://api.github.com/repos/datastax/python-driver/issues/events{/number}","events_url":"https://api.github.com/repos/datastax/python-driver/events","assignees_url":"https://api.github.com/repos/datastax/python-driver/assignees{/user}","branches_url":"https://api.github.com/repos/datastax/python-driver/branches{/branch}","tags_url":"https://api.github.com/repos/datastax/python-driver/tags","blobs_url":"https://api.github.com/repos/datastax/python-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datastax/python-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datastax/python-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/datastax/python-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datastax/python-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/datastax/python-driver/languages","stargazers_url":"https://api.github.com/repos/datastax/python-driver/stargazers","contributors_url":"https://api.github.com/repos/datastax/python-driver/contributors","subscribers_url":"https://api.github.com/repos/datastax/python-driver/subscribers","subscription_url":"https://api.github.com/repos/datastax/python-driver/subscription","commits_url":"https://api.github.com/repos/datastax/python-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/datastax/python-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/datastax/python-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/datastax/python-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/datastax/python-driver/contents/{+path}","compare_url":"https://api.github.com/repos/datastax/python-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datastax/python-driver/merges","archive_url":"https://api.github.com/repos/datastax/python-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datastax/python-driver/downloads","issues_url":"https://api.github.com/repos/datastax/python-driver/issues{/number}","pulls_url":"https://api.github.com/repos/datastax/python-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/datastax/python-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/datastax/python-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datastax/python-driver/labels{/name}","releases_url":"https://api.github.com/repos/datastax/python-driver/releases{/id}","deployments_url":"https://api.github.com/repos/datastax/python-driver/deployments","created_at":"2013-07-08T19:02:31Z","updated_at":"2017-09-29T01:07:11Z","pushed_at":"2017-09-29T17:17:37Z","git_url":"git://github.com/datastax/python-driver.git","ssh_url":"git@github.com:datastax/python-driver.git","clone_url":"https://github.com/datastax/python-driver.git","svn_url":"https://github.com/datastax/python-driver","homepage":"","size":16828,"stargazers_count":750,"watchers_count":750,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":340,"mirror_url":null,"open_issues_count":13,"forks":340,"open_issues":13,"watchers":750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datastax/python-driver/pulls/830"},"html":{"href":"https://github.com/datastax/python-driver/pull/830"},"issue":{"href":"https://api.github.com/repos/datastax/python-driver/issues/830"},"comments":{"href":"https://api.github.com/repos/datastax/python-driver/issues/830/comments"},"review_comments":{"href":"https://api.github.com/repos/datastax/python-driver/pulls/830/comments"},"review_comment":{"href":"https://api.github.com/repos/datastax/python-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datastax/python-driver/pulls/830/commits"},"statuses":{"href":"https://api.github.com/repos/datastax/python-driver/statuses/40ad47c51a6a1bf2f831cb573f69c86d382cdc4f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mambocab"}}