{"push_id":1831772401,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"eedcbc64ccd7cce7fb9bb14a4866767b3e1cab7d","before":"fb7f43f1a8e669f791c311343952d05b82dbfd28","commits":[{"sha":"a4fadc596b219ad75837d97a1be3bc40e06d97ce","author":{"name":"Stephen J Day","email":"f612758db3805c4abe0d56243c03a33f3294af3f@docker.com"},"message":"errdefs: centralize error handling\n\nNow that we have most of the services required for use with containerd,\nit was found that common patterns were used throughout services. By\ndefining a central `errdefs` package, we ensure that services will map\nerrors to and from grpc consistently and cleanly. One can decorate an\nerror with as much context as necessary, using `pkg/errors` and still\nhave the error mapped correctly via grpc.\n\nWe make a few sacrifices. At this point, the common errors we use across\nthe repository all map directly to grpc error codes. While this seems\npositively crazy, it actually works out quite well. The error conditions\nthat were specific weren't super necessary and the ones that were\nnecessary now simply have better context information. We lose the\nability to add new codes, but this constraint may not be a bad thing.\n\nEffectively, as long as one uses the errors defined in `errdefs`, the\nerror class will be mapped correctly across the grpc boundary and\neverything will be good. If you don't use those definitions, the error\nmaps to \"unknown\" and the error message is preserved.\n\nSigned-off-by: Stephen J Day <stephen.day@docker.com>","distinct":true,"url":"https://api.github.com/repos/containerd/containerd/commits/a4fadc596b219ad75837d97a1be3bc40e06d97ce"},{"sha":"eedcbc64ccd7cce7fb9bb14a4866767b3e1cab7d","author":{"name":"Derek McGowan","email":"531d09ee7d717b1f1e7b50a061cdb4a1ea469b22@mcgstyle.net"},"message":"Merge pull request #1115 from stevvooe/consolidate-errors\n\nerrdefs: centralize error handling","distinct":true,"url":"https://api.github.com/repos/containerd/containerd/commits/eedcbc64ccd7cce7fb9bb14a4866767b3e1cab7d"}]}
{"actor":{"display_login":"dmcgowan"}}