{"action":"created","issue":{"url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/274","repository_url":"https://api.github.com/repos/fantasyland/fantasy-land","labels_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/274/comments","events_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/274/events","html_url":"https://github.com/fantasyland/fantasy-land/pull/274","id":263753719,"number":274,"title":"add Filterable algebra","user":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars2.githubusercontent.com/u/210406?v=4","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2017-10-08T21:32:27Z","updated_at":"2017-10-26T16:11:49Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/fantasyland/fantasy-land/pulls/274","html_url":"https://github.com/fantasyland/fantasy-land/pull/274","diff_url":"https://github.com/fantasyland/fantasy-land/pull/274.diff","patch_url":"https://github.com/fantasyland/fantasy-land/pull/274.patch"},"body":"Closes #33\r\n\r\nWhile working on this pull request I consulted both [Data.Witherable][1] and [Control.Compactable][2]. Neither definition is appropriate for Fantasy Land due to our decision not to rely on data types not provided by the language. We must use `a -> Boolean` rather than `a -> Maybe a`.\r\n\r\nWhile reviewing this pull request please consider the following questions:\r\n\r\n  - Should Filterable depend on any type classes other than <del>Monoid</del> <ins>Plus</ins>?\r\n  - Can we state any other laws?\r\n\r\nI'm requesting a review from you, @joneshf, as way back in sanctuary-js/sanctuary#10 you planted the seed that resulted in this pull request. :seedling:\r\n\r\n/cc @Fresheyeball\r\n\r\n\r\n[1]: https://hackage.haskell.org/package/witherable-0.1.3.4/docs/Data-Witherable.html\r\n[2]: https://hackage.haskell.org/package/compactable-0.1.0.2/docs/Control-Compactable.html\r\n"},"comment":{"url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/comments/339717873","html_url":"https://github.com/fantasyland/fantasy-land/pull/274#issuecomment-339717873","issue_url":"https://api.github.com/repos/fantasyland/fantasy-land/issues/274","id":339717873,"user":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars2.githubusercontent.com/u/210406?v=4","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"created_at":"2017-10-26T16:11:49Z","updated_at":"2017-10-26T16:11:49Z","author_association":"OWNER","body":"> @davidchambers what is wrong with `IntMap a` https://hackage.haskell.org/package/containers-0.5.10.2/docs/Data-IntMap-Strict.html to my understanding `IntMap` is infact a functor.\r\n\r\nAha! I've had something different in mind during this discussion. I was thinking of `IntMap` as an alias for `StrMap Integer`, the type comprising JavaScript objects whose strings are keys (naturally) and whose values are integers. This was no doubt confusing. I'm sorry for being unclear.\r\n\r\n[`IntMap a`][1] is certainly mappable and filterable. :)\r\n\r\n\r\n[1]: https://hackage.haskell.org/package/containers-0.5.10.2/docs/Data-IntMap-Strict.html\r\n"}}
{"actor":{"display_login":"davidchambers"}}