{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/147895609","pull_request_review_id":73054806,"id":147895609,"diff_hunk":"@@ -1173,8 +1173,18 @@ func buildSchema(p PhysicalPlan) {\n \tswitch x := p.(type) {\n \tcase *Limit, *TopN, *Sort, *Selection, *MaxOneRow, *SelectLock:\n \t\tp.SetSchema(p.Children()[0].Schema())\n-\tcase *PhysicalHashJoin, *PhysicalIndexJoin:\n+\tcase *PhysicalHashJoin:\n \t\tp.SetSchema(expression.MergeSchema(p.Children()[0].Schema(), p.Children()[1].Schema()))\n+\tcase *PhysicalIndexJoin:","path":"plan/physical_plans.go","position":16,"original_position":16,"commit_id":"feb948a92f4563794dfd9dcb31568b1be7221637","original_commit_id":"feb948a92f4563794dfd9dcb31568b1be7221637","user":{"login":"hanfei1991","id":20884546,"avatar_url":"https://avatars0.githubusercontent.com/u/20884546?v=4","gravatar_id":"","url":"https://api.github.com/users/hanfei1991","html_url":"https://github.com/hanfei1991","followers_url":"https://api.github.com/users/hanfei1991/followers","following_url":"https://api.github.com/users/hanfei1991/following{/other_user}","gists_url":"https://api.github.com/users/hanfei1991/gists{/gist_id}","starred_url":"https://api.github.com/users/hanfei1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanfei1991/subscriptions","organizations_url":"https://api.github.com/users/hanfei1991/orgs","repos_url":"https://api.github.com/users/hanfei1991/repos","events_url":"https://api.github.com/users/hanfei1991/events{/privacy}","received_events_url":"https://api.github.com/users/hanfei1991/received_events","type":"User","site_admin":false},"body":"This logic is the same as MergeJoin ?","created_at":"2017-10-31T04:53:09Z","updated_at":"2017-10-31T05:02:30Z","html_url":"https://github.com/pingcap/tidb/pull/4944#discussion_r147895609","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/4944","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/147895609"},"html":{"href":"https://github.com/pingcap/tidb/pull/4944#discussion_r147895609"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4944"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/4944","id":149431091,"html_url":"https://github.com/pingcap/tidb/pull/4944","diff_url":"https://github.com/pingcap/tidb/pull/4944.diff","patch_url":"https://github.com/pingcap/tidb/pull/4944.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/4944","number":4944,"state":"open","locked":false,"title":"plan, executor: improve index join to support all join types","user":{"login":"zz-jason","id":5268763,"avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"body":"fix #4901 ","created_at":"2017-10-30T03:47:37Z","updated_at":"2017-10-31T05:02:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"647518b4d207bc2e4a26b915747fc84311fb291d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/pingcap/tidb/milestones/10","html_url":"https://github.com/pingcap/tidb/milestone/10","labels_url":"https://api.github.com/repos/pingcap/tidb/milestones/10/labels","id":2839370,"number":10,"title":"1.1","description":"","creator":{"login":"shenli","id":1192573,"avatar_url":"https://avatars0.githubusercontent.com/u/1192573?v=4","gravatar_id":"","url":"https://api.github.com/users/shenli","html_url":"https://github.com/shenli","followers_url":"https://api.github.com/users/shenli/followers","following_url":"https://api.github.com/users/shenli/following{/other_user}","gists_url":"https://api.github.com/users/shenli/gists{/gist_id}","starred_url":"https://api.github.com/users/shenli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenli/subscriptions","organizations_url":"https://api.github.com/users/shenli/orgs","repos_url":"https://api.github.com/users/shenli/repos","events_url":"https://api.github.com/users/shenli/events{/privacy}","received_events_url":"https://api.github.com/users/shenli/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":35,"state":"open","created_at":"2017-10-16T08:41:02Z","updated_at":"2017-10-31T03:21:54Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/4944/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/4944/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/4944/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/feb948a92f4563794dfd9dcb31568b1be7221637","head":{"label":"zz-jason:dev/semijoin/indexjoin","ref":"dev/semijoin/indexjoin","sha":"feb948a92f4563794dfd9dcb31568b1be7221637","user":{"login":"zz-jason","id":5268763,"avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"repo":{"id":107492543,"name":"tidb","full_name":"zz-jason/tidb","owner":{"login":"zz-jason","id":5268763,"avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zz-jason/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/zz-jason/tidb","forks_url":"https://api.github.com/repos/zz-jason/tidb/forks","keys_url":"https://api.github.com/repos/zz-jason/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zz-jason/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zz-jason/tidb/teams","hooks_url":"https://api.github.com/repos/zz-jason/tidb/hooks","issue_events_url":"https://api.github.com/repos/zz-jason/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/zz-jason/tidb/events","assignees_url":"https://api.github.com/repos/zz-jason/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/zz-jason/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/zz-jason/tidb/tags","blobs_url":"https://api.github.com/repos/zz-jason/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zz-jason/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zz-jason/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/zz-jason/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zz-jason/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/zz-jason/tidb/languages","stargazers_url":"https://api.github.com/repos/zz-jason/tidb/stargazers","contributors_url":"https://api.github.com/repos/zz-jason/tidb/contributors","subscribers_url":"https://api.github.com/repos/zz-jason/tidb/subscribers","subscription_url":"https://api.github.com/repos/zz-jason/tidb/subscription","commits_url":"https://api.github.com/repos/zz-jason/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/zz-jason/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/zz-jason/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/zz-jason/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/zz-jason/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/zz-jason/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zz-jason/tidb/merges","archive_url":"https://api.github.com/repos/zz-jason/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zz-jason/tidb/downloads","issues_url":"https://api.github.com/repos/zz-jason/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/zz-jason/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/zz-jason/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/zz-jason/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zz-jason/tidb/labels{/name}","releases_url":"https://api.github.com/repos/zz-jason/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/zz-jason/tidb/deployments","created_at":"2017-10-19T03:14:19Z","updated_at":"2017-10-19T03:14:23Z","pushed_at":"2017-10-31T04:34:20Z","git_url":"git://github.com/zz-jason/tidb.git","ssh_url":"git@github.com:zz-jason/tidb.git","clone_url":"https://github.com/zz-jason/tidb.git","svn_url":"https://github.com/zz-jason/tidb","homepage":"https://pingcap.com","size":34174,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"c5efd20e812bdffb99cb9882fc53f1c73154516f","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2017-10-31T04:53:42Z","pushed_at":"2017-10-31T04:42:20Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":35456,"stargazers_count":10421,"watchers_count":10421,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1403,"mirror_url":null,"archived":false,"open_issues_count":355,"forks":1403,"open_issues":355,"watchers":10421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4944"},"html":{"href":"https://github.com/pingcap/tidb/pull/4944"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/4944"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/4944/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4944/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/4944/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/feb948a92f4563794dfd9dcb31568b1be7221637"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hanfei1991"}}