{"action":"created","comment":{"url":"https://api.github.com/repos/alter-ego/androidbound/pulls/comments/136275481","pull_request_review_id":59788436,"id":136275481,"diff_hunk":"@@ -45,10 +43,6 @@\n \n     private SparseArray<Class<?>> mObjectIndex;\n \n-    @Getter\n-    @Setter\n-    private RecyclerView.LayoutManager mLayoutManager;","path":"AndroidBound/src/main/java/solutions/alterego/androidbound/android/adapters/BindableRecyclerViewAdapter.java","position":22,"original_position":22,"commit_id":"073c4581975eb14f7e7b258e0f33da5d2e131a78","original_commit_id":"073c4581975eb14f7e7b258e0f33da5d2e131a78","user":{"login":"mrsasha","id":1850452,"avatar_url":"https://avatars0.githubusercontent.com/u/1850452?v=4","gravatar_id":"","url":"https://api.github.com/users/mrsasha","html_url":"https://github.com/mrsasha","followers_url":"https://api.github.com/users/mrsasha/followers","following_url":"https://api.github.com/users/mrsasha/following{/other_user}","gists_url":"https://api.github.com/users/mrsasha/gists{/gist_id}","starred_url":"https://api.github.com/users/mrsasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrsasha/subscriptions","organizations_url":"https://api.github.com/users/mrsasha/orgs","repos_url":"https://api.github.com/users/mrsasha/repos","events_url":"https://api.github.com/users/mrsasha/events{/privacy}","received_events_url":"https://api.github.com/users/mrsasha/received_events","type":"User","site_admin":false},"body":"you would need the setting of the `LayoutManager`? sure. I'm not sure it works correctly though, because trying to set it after instatiation doesn't change the layout, at least not in normal `BindableRV`.","created_at":"2017-08-31T08:30:59Z","updated_at":"2017-08-31T08:30:59Z","html_url":"https://github.com/alter-ego/androidbound/pull/148#discussion_r136275481","pull_request_url":"https://api.github.com/repos/alter-ego/androidbound/pulls/148","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/alter-ego/androidbound/pulls/comments/136275481"},"html":{"href":"https://github.com/alter-ego/androidbound/pull/148#discussion_r136275481"},"pull_request":{"href":"https://api.github.com/repos/alter-ego/androidbound/pulls/148"}},"in_reply_to_id":136272520},"pull_request":{"url":"https://api.github.com/repos/alter-ego/androidbound/pulls/148","id":138543858,"html_url":"https://github.com/alter-ego/androidbound/pull/148","diff_url":"https://github.com/alter-ego/androidbound/pull/148.diff","patch_url":"https://github.com/alter-ego/androidbound/pull/148.patch","issue_url":"https://api.github.com/repos/alter-ego/androidbound/issues/148","number":148,"state":"open","locked":false,"title":"Fix/rv layout manager bugs","user":{"login":"mrsasha","id":1850452,"avatar_url":"https://avatars0.githubusercontent.com/u/1850452?v=4","gravatar_id":"","url":"https://api.github.com/users/mrsasha","html_url":"https://github.com/mrsasha","followers_url":"https://api.github.com/users/mrsasha/followers","following_url":"https://api.github.com/users/mrsasha/following{/other_user}","gists_url":"https://api.github.com/users/mrsasha/gists{/gist_id}","starred_url":"https://api.github.com/users/mrsasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrsasha/subscriptions","organizations_url":"https://api.github.com/users/mrsasha/orgs","repos_url":"https://api.github.com/users/mrsasha/repos","events_url":"https://api.github.com/users/mrsasha/events{/privacy}","received_events_url":"https://api.github.com/users/mrsasha/received_events","type":"User","site_admin":false},"body":"@bblackbelt can you please test this? it fixes some of the bugs with the RV (like taking the LayoutParams from parent when it shouldn't have) but it should also increase the render speed. It looks fine on my side but it's nice to have another confirmation. :)","created_at":"2017-08-30T22:34:33Z","updated_at":"2017-08-31T08:30:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b84e39ebb28552846e534956744df68d23d14c8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/alter-ego/androidbound/milestones/4","html_url":"https://github.com/alter-ego/androidbound/milestone/4","labels_url":"https://api.github.com/repos/alter-ego/androidbound/milestones/4/labels","id":2348542,"number":4,"title":"0.8","description":"","creator":{"login":"mrsasha","id":1850452,"avatar_url":"https://avatars0.githubusercontent.com/u/1850452?v=4","gravatar_id":"","url":"https://api.github.com/users/mrsasha","html_url":"https://github.com/mrsasha","followers_url":"https://api.github.com/users/mrsasha/followers","following_url":"https://api.github.com/users/mrsasha/following{/other_user}","gists_url":"https://api.github.com/users/mrsasha/gists{/gist_id}","starred_url":"https://api.github.com/users/mrsasha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrsasha/subscriptions","organizations_url":"https://api.github.com/users/mrsasha/orgs","repos_url":"https://api.github.com/users/mrsasha/repos","events_url":"https://api.github.com/users/mrsasha/events{/privacy}","received_events_url":"https://api.github.com/users/mrsasha/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":14,"state":"open","created_at":"2017-02-26T18:11:57Z","updated_at":"2017-08-30T22:38:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/alter-ego/androidbound/pulls/148/commits","review_comments_url":"https://api.github.com/repos/alter-ego/androidbound/pulls/148/comments","review_comment_url":"https://api.github.com/repos/alter-ego/androidbound/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alter-ego/androidbound/issues/148/comments","statuses_url":"https://api.github.com/repos/alter-ego/androidbound/statuses/073c4581975eb14f7e7b258e0f33da5d2e131a78","head":{"label":"alter-ego:fix/RV_layout_manager_bugs","ref":"fix/RV_layout_manager_bugs","sha":"073c4581975eb14f7e7b258e0f33da5d2e131a78","user":{"login":"alter-ego","id":7290552,"avatar_url":"https://avatars2.githubusercontent.com/u/7290552?v=4","gravatar_id":"","url":"https://api.github.com/users/alter-ego","html_url":"https://github.com/alter-ego","followers_url":"https://api.github.com/users/alter-ego/followers","following_url":"https://api.github.com/users/alter-ego/following{/other_user}","gists_url":"https://api.github.com/users/alter-ego/gists{/gist_id}","starred_url":"https://api.github.com/users/alter-ego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alter-ego/subscriptions","organizations_url":"https://api.github.com/users/alter-ego/orgs","repos_url":"https://api.github.com/users/alter-ego/repos","events_url":"https://api.github.com/users/alter-ego/events{/privacy}","received_events_url":"https://api.github.com/users/alter-ego/received_events","type":"Organization","site_admin":false},"repo":{"id":32689578,"name":"androidbound","full_name":"alter-ego/androidbound","owner":{"login":"alter-ego","id":7290552,"avatar_url":"https://avatars2.githubusercontent.com/u/7290552?v=4","gravatar_id":"","url":"https://api.github.com/users/alter-ego","html_url":"https://github.com/alter-ego","followers_url":"https://api.github.com/users/alter-ego/followers","following_url":"https://api.github.com/users/alter-ego/following{/other_user}","gists_url":"https://api.github.com/users/alter-ego/gists{/gist_id}","starred_url":"https://api.github.com/users/alter-ego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alter-ego/subscriptions","organizations_url":"https://api.github.com/users/alter-ego/orgs","repos_url":"https://api.github.com/users/alter-ego/repos","events_url":"https://api.github.com/users/alter-ego/events{/privacy}","received_events_url":"https://api.github.com/users/alter-ego/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alter-ego/androidbound","description":"Two-way binding library for Android","fork":false,"url":"https://api.github.com/repos/alter-ego/androidbound","forks_url":"https://api.github.com/repos/alter-ego/androidbound/forks","keys_url":"https://api.github.com/repos/alter-ego/androidbound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alter-ego/androidbound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alter-ego/androidbound/teams","hooks_url":"https://api.github.com/repos/alter-ego/androidbound/hooks","issue_events_url":"https://api.github.com/repos/alter-ego/androidbound/issues/events{/number}","events_url":"https://api.github.com/repos/alter-ego/androidbound/events","assignees_url":"https://api.github.com/repos/alter-ego/androidbound/assignees{/user}","branches_url":"https://api.github.com/repos/alter-ego/androidbound/branches{/branch}","tags_url":"https://api.github.com/repos/alter-ego/androidbound/tags","blobs_url":"https://api.github.com/repos/alter-ego/androidbound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alter-ego/androidbound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alter-ego/androidbound/git/refs{/sha}","trees_url":"https://api.github.com/repos/alter-ego/androidbound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alter-ego/androidbound/statuses/{sha}","languages_url":"https://api.github.com/repos/alter-ego/androidbound/languages","stargazers_url":"https://api.github.com/repos/alter-ego/androidbound/stargazers","contributors_url":"https://api.github.com/repos/alter-ego/androidbound/contributors","subscribers_url":"https://api.github.com/repos/alter-ego/androidbound/subscribers","subscription_url":"https://api.github.com/repos/alter-ego/androidbound/subscription","commits_url":"https://api.github.com/repos/alter-ego/androidbound/commits{/sha}","git_commits_url":"https://api.github.com/repos/alter-ego/androidbound/git/commits{/sha}","comments_url":"https://api.github.com/repos/alter-ego/androidbound/comments{/number}","issue_comment_url":"https://api.github.com/repos/alter-ego/androidbound/issues/comments{/number}","contents_url":"https://api.github.com/repos/alter-ego/androidbound/contents/{+path}","compare_url":"https://api.github.com/repos/alter-ego/androidbound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alter-ego/androidbound/merges","archive_url":"https://api.github.com/repos/alter-ego/androidbound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alter-ego/androidbound/downloads","issues_url":"https://api.github.com/repos/alter-ego/androidbound/issues{/number}","pulls_url":"https://api.github.com/repos/alter-ego/androidbound/pulls{/number}","milestones_url":"https://api.github.com/repos/alter-ego/androidbound/milestones{/number}","notifications_url":"https://api.github.com/repos/alter-ego/androidbound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alter-ego/androidbound/labels{/name}","releases_url":"https://api.github.com/repos/alter-ego/androidbound/releases{/id}","deployments_url":"https://api.github.com/repos/alter-ego/androidbound/deployments","created_at":"2015-03-22T18:44:09Z","updated_at":"2017-05-20T09:25:09Z","pushed_at":"2017-08-30T22:34:33Z","git_url":"git://github.com/alter-ego/androidbound.git","ssh_url":"git@github.com:alter-ego/androidbound.git","clone_url":"https://github.com/alter-ego/androidbound.git","svn_url":"https://github.com/alter-ego/androidbound","homepage":"","size":26530,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":20,"forks":3,"open_issues":20,"watchers":31,"default_branch":"develop"}},"base":{"label":"alter-ego:develop","ref":"develop","sha":"33f8737502c2dca678db33c32ab7d4ed78609d40","user":{"login":"alter-ego","id":7290552,"avatar_url":"https://avatars2.githubusercontent.com/u/7290552?v=4","gravatar_id":"","url":"https://api.github.com/users/alter-ego","html_url":"https://github.com/alter-ego","followers_url":"https://api.github.com/users/alter-ego/followers","following_url":"https://api.github.com/users/alter-ego/following{/other_user}","gists_url":"https://api.github.com/users/alter-ego/gists{/gist_id}","starred_url":"https://api.github.com/users/alter-ego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alter-ego/subscriptions","organizations_url":"https://api.github.com/users/alter-ego/orgs","repos_url":"https://api.github.com/users/alter-ego/repos","events_url":"https://api.github.com/users/alter-ego/events{/privacy}","received_events_url":"https://api.github.com/users/alter-ego/received_events","type":"Organization","site_admin":false},"repo":{"id":32689578,"name":"androidbound","full_name":"alter-ego/androidbound","owner":{"login":"alter-ego","id":7290552,"avatar_url":"https://avatars2.githubusercontent.com/u/7290552?v=4","gravatar_id":"","url":"https://api.github.com/users/alter-ego","html_url":"https://github.com/alter-ego","followers_url":"https://api.github.com/users/alter-ego/followers","following_url":"https://api.github.com/users/alter-ego/following{/other_user}","gists_url":"https://api.github.com/users/alter-ego/gists{/gist_id}","starred_url":"https://api.github.com/users/alter-ego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alter-ego/subscriptions","organizations_url":"https://api.github.com/users/alter-ego/orgs","repos_url":"https://api.github.com/users/alter-ego/repos","events_url":"https://api.github.com/users/alter-ego/events{/privacy}","received_events_url":"https://api.github.com/users/alter-ego/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alter-ego/androidbound","description":"Two-way binding library for Android","fork":false,"url":"https://api.github.com/repos/alter-ego/androidbound","forks_url":"https://api.github.com/repos/alter-ego/androidbound/forks","keys_url":"https://api.github.com/repos/alter-ego/androidbound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alter-ego/androidbound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alter-ego/androidbound/teams","hooks_url":"https://api.github.com/repos/alter-ego/androidbound/hooks","issue_events_url":"https://api.github.com/repos/alter-ego/androidbound/issues/events{/number}","events_url":"https://api.github.com/repos/alter-ego/androidbound/events","assignees_url":"https://api.github.com/repos/alter-ego/androidbound/assignees{/user}","branches_url":"https://api.github.com/repos/alter-ego/androidbound/branches{/branch}","tags_url":"https://api.github.com/repos/alter-ego/androidbound/tags","blobs_url":"https://api.github.com/repos/alter-ego/androidbound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alter-ego/androidbound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alter-ego/androidbound/git/refs{/sha}","trees_url":"https://api.github.com/repos/alter-ego/androidbound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alter-ego/androidbound/statuses/{sha}","languages_url":"https://api.github.com/repos/alter-ego/androidbound/languages","stargazers_url":"https://api.github.com/repos/alter-ego/androidbound/stargazers","contributors_url":"https://api.github.com/repos/alter-ego/androidbound/contributors","subscribers_url":"https://api.github.com/repos/alter-ego/androidbound/subscribers","subscription_url":"https://api.github.com/repos/alter-ego/androidbound/subscription","commits_url":"https://api.github.com/repos/alter-ego/androidbound/commits{/sha}","git_commits_url":"https://api.github.com/repos/alter-ego/androidbound/git/commits{/sha}","comments_url":"https://api.github.com/repos/alter-ego/androidbound/comments{/number}","issue_comment_url":"https://api.github.com/repos/alter-ego/androidbound/issues/comments{/number}","contents_url":"https://api.github.com/repos/alter-ego/androidbound/contents/{+path}","compare_url":"https://api.github.com/repos/alter-ego/androidbound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alter-ego/androidbound/merges","archive_url":"https://api.github.com/repos/alter-ego/androidbound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alter-ego/androidbound/downloads","issues_url":"https://api.github.com/repos/alter-ego/androidbound/issues{/number}","pulls_url":"https://api.github.com/repos/alter-ego/androidbound/pulls{/number}","milestones_url":"https://api.github.com/repos/alter-ego/androidbound/milestones{/number}","notifications_url":"https://api.github.com/repos/alter-ego/androidbound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alter-ego/androidbound/labels{/name}","releases_url":"https://api.github.com/repos/alter-ego/androidbound/releases{/id}","deployments_url":"https://api.github.com/repos/alter-ego/androidbound/deployments","created_at":"2015-03-22T18:44:09Z","updated_at":"2017-05-20T09:25:09Z","pushed_at":"2017-08-30T22:34:33Z","git_url":"git://github.com/alter-ego/androidbound.git","ssh_url":"git@github.com:alter-ego/androidbound.git","clone_url":"https://github.com/alter-ego/androidbound.git","svn_url":"https://github.com/alter-ego/androidbound","homepage":"","size":26530,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":20,"forks":3,"open_issues":20,"watchers":31,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/alter-ego/androidbound/pulls/148"},"html":{"href":"https://github.com/alter-ego/androidbound/pull/148"},"issue":{"href":"https://api.github.com/repos/alter-ego/androidbound/issues/148"},"comments":{"href":"https://api.github.com/repos/alter-ego/androidbound/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/alter-ego/androidbound/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/alter-ego/androidbound/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alter-ego/androidbound/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/alter-ego/androidbound/statuses/073c4581975eb14f7e7b258e0f33da5d2e131a78"}},"author_association":"OWNER"}}
{"actor":{"display_login":"mrsasha"}}