{"action":"created","comment":{"url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/comments/147630962","pull_request_review_id":72750914,"id":147630962,"diff_hunk":"@@ -20,26 +23,57 @@ int canny_threshold;\n const int threshold_ratio = 2;\n const int sobel_kernel_size = 3;\n \n+int show_images_cli_arg = 0;\n \n int main(int argc, char** argv)\n {\n-    if(argc < 2)\n+    if(argc < 3)\n     {\n-        std::cout << \"Usage: ./hu_moments_gather <input_image> <init_canny_threshold>\\n\";\n+        std::cout << \"Usage: ./hu_moments_gather <input_images_list_file> <init_canny_threshold> [show_images]\\n\";\n         exit(1);\n     }\n \n-    if(argc == 3)\n+    if(argc >= 3)","path":"PC/hu_moments_gather/hu_moments_gather.cpp","position":null,"original_position":38,"commit_id":"d1454658c2d5ddb234646db995c891830e1b5773","original_commit_id":"d1454658c2d5ddb234646db995c891830e1b5773","user":{"login":"palucki","id":7307022,"avatar_url":"https://avatars1.githubusercontent.com/u/7307022?v=4","gravatar_id":"","url":"https://api.github.com/users/palucki","html_url":"https://github.com/palucki","followers_url":"https://api.github.com/users/palucki/followers","following_url":"https://api.github.com/users/palucki/following{/other_user}","gists_url":"https://api.github.com/users/palucki/gists{/gist_id}","starred_url":"https://api.github.com/users/palucki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palucki/subscriptions","organizations_url":"https://api.github.com/users/palucki/orgs","repos_url":"https://api.github.com/users/palucki/repos","events_url":"https://api.github.com/users/palucki/events{/privacy}","received_events_url":"https://api.github.com/users/palucki/received_events","type":"User","site_admin":false},"body":"Shouldn't be:\r\n`if(argc == 3)` ???\r\nHaving 4 arguments we will not initialize\r\n`show_images_cli_arg`, will we?","created_at":"2017-10-30T07:31:08Z","updated_at":"2017-10-30T07:40:53Z","html_url":"https://github.com/Qbicz/real-time-shape-detection/pull/9#discussion_r147630962","pull_request_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/9","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/comments/147630962"},"html":{"href":"https://github.com/Qbicz/real-time-shape-detection/pull/9#discussion_r147630962"},"pull_request":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/9","id":149329142,"html_url":"https://github.com/Qbicz/real-time-shape-detection/pull/9","diff_url":"https://github.com/Qbicz/real-time-shape-detection/pull/9.diff","patch_url":"https://github.com/Qbicz/real-time-shape-detection/pull/9.patch","issue_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues/9","number":9,"state":"open","locked":false,"title":"Feature/#6 harvest learning data","user":{"login":"Qbicz","id":5618209,"avatar_url":"https://avatars0.githubusercontent.com/u/5618209?v=4","gravatar_id":"","url":"https://api.github.com/users/Qbicz","html_url":"https://github.com/Qbicz","followers_url":"https://api.github.com/users/Qbicz/followers","following_url":"https://api.github.com/users/Qbicz/following{/other_user}","gists_url":"https://api.github.com/users/Qbicz/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbicz/subscriptions","organizations_url":"https://api.github.com/users/Qbicz/orgs","repos_url":"https://api.github.com/users/Qbicz/repos","events_url":"https://api.github.com/users/Qbicz/events{/privacy}","received_events_url":"https://api.github.com/users/Qbicz/received_events","type":"User","site_admin":false},"body":"Prepared a module which may be used in scripts for calculating Hu moments in learning phase.\r\n- we now compute Hu moments of a filled shape, not a contour","created_at":"2017-10-28T10:25:01Z","updated_at":"2017-10-30T07:40:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"569c544a3d58059d4834c14b7ffff8e2ecc3cb8c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues/9/comments","statuses_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/statuses/d1454658c2d5ddb234646db995c891830e1b5773","head":{"label":"Qbicz:feature/#6-harvest-learning-data","ref":"feature/#6-harvest-learning-data","sha":"d1454658c2d5ddb234646db995c891830e1b5773","user":{"login":"Qbicz","id":5618209,"avatar_url":"https://avatars0.githubusercontent.com/u/5618209?v=4","gravatar_id":"","url":"https://api.github.com/users/Qbicz","html_url":"https://github.com/Qbicz","followers_url":"https://api.github.com/users/Qbicz/followers","following_url":"https://api.github.com/users/Qbicz/following{/other_user}","gists_url":"https://api.github.com/users/Qbicz/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbicz/subscriptions","organizations_url":"https://api.github.com/users/Qbicz/orgs","repos_url":"https://api.github.com/users/Qbicz/repos","events_url":"https://api.github.com/users/Qbicz/events{/privacy}","received_events_url":"https://api.github.com/users/Qbicz/received_events","type":"User","site_admin":false},"repo":{"id":72664181,"name":"real-time-shape-detection","full_name":"Qbicz/real-time-shape-detection","owner":{"login":"Qbicz","id":5618209,"avatar_url":"https://avatars0.githubusercontent.com/u/5618209?v=4","gravatar_id":"","url":"https://api.github.com/users/Qbicz","html_url":"https://github.com/Qbicz","followers_url":"https://api.github.com/users/Qbicz/followers","following_url":"https://api.github.com/users/Qbicz/following{/other_user}","gists_url":"https://api.github.com/users/Qbicz/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbicz/subscriptions","organizations_url":"https://api.github.com/users/Qbicz/orgs","repos_url":"https://api.github.com/users/Qbicz/repos","events_url":"https://api.github.com/users/Qbicz/events{/privacy}","received_events_url":"https://api.github.com/users/Qbicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Qbicz/real-time-shape-detection","description":"use ARM Mali GPU on ODROID-XU4 and OpenCL acceleration to achieve real time shape and orientation detection of fast moving objects","fork":false,"url":"https://api.github.com/repos/Qbicz/real-time-shape-detection","forks_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/forks","keys_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/teams","hooks_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/hooks","issue_events_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues/events{/number}","events_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/events","assignees_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/assignees{/user}","branches_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/branches{/branch}","tags_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/tags","blobs_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/statuses/{sha}","languages_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/languages","stargazers_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/stargazers","contributors_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/contributors","subscribers_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/subscribers","subscription_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/subscription","commits_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/contents/{+path}","compare_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/merges","archive_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/downloads","issues_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues{/number}","pulls_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls{/number}","milestones_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/milestones{/number}","notifications_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/labels{/name}","releases_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/releases{/id}","deployments_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/deployments","created_at":"2016-11-02T17:26:04Z","updated_at":"2017-10-11T20:59:57Z","pushed_at":"2017-10-29T13:05:49Z","git_url":"git://github.com/Qbicz/real-time-shape-detection.git","ssh_url":"git@github.com:Qbicz/real-time-shape-detection.git","clone_url":"https://github.com/Qbicz/real-time-shape-detection.git","svn_url":"https://github.com/Qbicz/real-time-shape-detection","homepage":"","size":197599,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"Qbicz:master","ref":"master","sha":"62919bc071a399b07f7937a6f6a3fc98758d858a","user":{"login":"Qbicz","id":5618209,"avatar_url":"https://avatars0.githubusercontent.com/u/5618209?v=4","gravatar_id":"","url":"https://api.github.com/users/Qbicz","html_url":"https://github.com/Qbicz","followers_url":"https://api.github.com/users/Qbicz/followers","following_url":"https://api.github.com/users/Qbicz/following{/other_user}","gists_url":"https://api.github.com/users/Qbicz/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbicz/subscriptions","organizations_url":"https://api.github.com/users/Qbicz/orgs","repos_url":"https://api.github.com/users/Qbicz/repos","events_url":"https://api.github.com/users/Qbicz/events{/privacy}","received_events_url":"https://api.github.com/users/Qbicz/received_events","type":"User","site_admin":false},"repo":{"id":72664181,"name":"real-time-shape-detection","full_name":"Qbicz/real-time-shape-detection","owner":{"login":"Qbicz","id":5618209,"avatar_url":"https://avatars0.githubusercontent.com/u/5618209?v=4","gravatar_id":"","url":"https://api.github.com/users/Qbicz","html_url":"https://github.com/Qbicz","followers_url":"https://api.github.com/users/Qbicz/followers","following_url":"https://api.github.com/users/Qbicz/following{/other_user}","gists_url":"https://api.github.com/users/Qbicz/gists{/gist_id}","starred_url":"https://api.github.com/users/Qbicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qbicz/subscriptions","organizations_url":"https://api.github.com/users/Qbicz/orgs","repos_url":"https://api.github.com/users/Qbicz/repos","events_url":"https://api.github.com/users/Qbicz/events{/privacy}","received_events_url":"https://api.github.com/users/Qbicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Qbicz/real-time-shape-detection","description":"use ARM Mali GPU on ODROID-XU4 and OpenCL acceleration to achieve real time shape and orientation detection of fast moving objects","fork":false,"url":"https://api.github.com/repos/Qbicz/real-time-shape-detection","forks_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/forks","keys_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/teams","hooks_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/hooks","issue_events_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues/events{/number}","events_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/events","assignees_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/assignees{/user}","branches_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/branches{/branch}","tags_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/tags","blobs_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/statuses/{sha}","languages_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/languages","stargazers_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/stargazers","contributors_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/contributors","subscribers_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/subscribers","subscription_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/subscription","commits_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/contents/{+path}","compare_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/merges","archive_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/downloads","issues_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues{/number}","pulls_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls{/number}","milestones_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/milestones{/number}","notifications_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/labels{/name}","releases_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/releases{/id}","deployments_url":"https://api.github.com/repos/Qbicz/real-time-shape-detection/deployments","created_at":"2016-11-02T17:26:04Z","updated_at":"2017-10-11T20:59:57Z","pushed_at":"2017-10-29T13:05:49Z","git_url":"git://github.com/Qbicz/real-time-shape-detection.git","ssh_url":"git@github.com:Qbicz/real-time-shape-detection.git","clone_url":"https://github.com/Qbicz/real-time-shape-detection.git","svn_url":"https://github.com/Qbicz/real-time-shape-detection","homepage":"","size":197599,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/9"},"html":{"href":"https://github.com/Qbicz/real-time-shape-detection/pull/9"},"issue":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues/9"},"comments":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Qbicz/real-time-shape-detection/statuses/d1454658c2d5ddb234646db995c891830e1b5773"}},"author_association":"OWNER"}}
{"actor":{"display_login":"palucki"}}