{"action":"created","issue":{"url":"https://api.github.com/repos/google/mobly/issues/173","repository_url":"https://api.github.com/repos/google/mobly","labels_url":"https://api.github.com/repos/google/mobly/issues/173/labels{/name}","comments_url":"https://api.github.com/repos/google/mobly/issues/173/comments","events_url":"https://api.github.com/repos/google/mobly/issues/173/events","html_url":"https://github.com/google/mobly/pull/173","id":218116259,"number":173,"title":"Lock adb port management.","user":{"login":"adorokhine","id":2999402,"avatar_url":"https://avatars0.githubusercontent.com/u/2999402?v=3","gravatar_id":"","url":"https://api.github.com/users/adorokhine","html_url":"https://github.com/adorokhine","followers_url":"https://api.github.com/users/adorokhine/followers","following_url":"https://api.github.com/users/adorokhine/following{/other_user}","gists_url":"https://api.github.com/users/adorokhine/gists{/gist_id}","starred_url":"https://api.github.com/users/adorokhine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adorokhine/subscriptions","organizations_url":"https://api.github.com/users/adorokhine/orgs","repos_url":"https://api.github.com/users/adorokhine/repos","events_url":"https://api.github.com/users/adorokhine/events{/privacy}","received_events_url":"https://api.github.com/users/adorokhine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-30T08:18:31Z","updated_at":"2017-03-31T05:34:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/mobly/pulls/173","html_url":"https://github.com/google/mobly/pull/173","diff_url":"https://github.com/google/mobly/pull/173.diff","patch_url":"https://github.com/google/mobly/pull/173.patch"},"body":"adb gets very confused if you try to manage port forwarding concurrently on\r\nthe same server, leading to crashes like \"Socket error: no error\".\r\n\r\nAdding a lock around it seems to make the errors go away.\r\n\r\nIssue #102.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/mobly/173)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/google/mobly/issues/comments/290620406","html_url":"https://github.com/google/mobly/pull/173#issuecomment-290620406","issue_url":"https://api.github.com/repos/google/mobly/issues/173","id":290620406,"user":{"login":"xpconanfan","id":2242277,"avatar_url":"https://avatars0.githubusercontent.com/u/2242277?v=3","gravatar_id":"","url":"https://api.github.com/users/xpconanfan","html_url":"https://github.com/xpconanfan","followers_url":"https://api.github.com/users/xpconanfan/followers","following_url":"https://api.github.com/users/xpconanfan/following{/other_user}","gists_url":"https://api.github.com/users/xpconanfan/gists{/gist_id}","starred_url":"https://api.github.com/users/xpconanfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xpconanfan/subscriptions","organizations_url":"https://api.github.com/users/xpconanfan/orgs","repos_url":"https://api.github.com/users/xpconanfan/repos","events_url":"https://api.github.com/users/xpconanfan/events{/privacy}","received_events_url":"https://api.github.com/users/xpconanfan/received_events","type":"User","site_admin":false},"created_at":"2017-03-31T05:34:45Z","updated_at":"2017-03-31T05:34:45Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[mobly/controllers/android_device_lib/adb.py, line 150 at r1](https://reviewable.io:443/reviews/google/mobly/173#-KgXqS7ww1obpXts8UnZ:-KgXqS7ww1obpXts8Un_:b1z1by) ([raw file](https://github.com/google/mobly/blob/1a433aa94720cab9a1efcec438b530ffb870c104/mobly/controllers/android_device_lib/adb.py#L150)):*\n> ```Python\n> \n>     def forward(self, args=None, shell=False):\n>         with ADB_PORT_LOCK:\n> ```\n\nYou mean running two `adb forward` cmds concurrently is causing problems?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/google/mobly/173)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"xpconanfan"}}