{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/pinot/issues/1811","repository_url":"https://api.github.com/repos/linkedin/pinot","labels_url":"https://api.github.com/repos/linkedin/pinot/issues/1811/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/1811/comments","events_url":"https://api.github.com/repos/linkedin/pinot/issues/1811/events","html_url":"https://github.com/linkedin/pinot/pull/1811","id":251103940,"number":1811,"title":"Preparation for OffHeap config: Re-organizing parameters to RealtimeSegmentImpl","user":{"login":"mcvsubbu","id":2279037,"avatar_url":"https://avatars3.githubusercontent.com/u/2279037?v=4","gravatar_id":"","url":"https://api.github.com/users/mcvsubbu","html_url":"https://github.com/mcvsubbu","followers_url":"https://api.github.com/users/mcvsubbu/followers","following_url":"https://api.github.com/users/mcvsubbu/following{/other_user}","gists_url":"https://api.github.com/users/mcvsubbu/gists{/gist_id}","starred_url":"https://api.github.com/users/mcvsubbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcvsubbu/subscriptions","organizations_url":"https://api.github.com/users/mcvsubbu/orgs","repos_url":"https://api.github.com/users/mcvsubbu/repos","events_url":"https://api.github.com/users/mcvsubbu/events{/privacy}","received_events_url":"https://api.github.com/users/mcvsubbu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-17T23:53:51Z","updated_at":"2017-08-18T21:52:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/1811","html_url":"https://github.com/linkedin/pinot/pull/1811","diff_url":"https://github.com/linkedin/pinot/pull/1811.diff","patch_url":"https://github.com/linkedin/pinot/pull/1811.patch"},"body":"No new functionality added.\n\nThe class RealtimeSegmentImpl needs to have access to the configuration so it can determine\nwhether to allocate memory on-heap or off-heap. Until we turn the default to be off-heap\nallocation, this will be useful to configur on a per server or per use case basis.\n\nRe-factored the constructor for RealtimeSegmentImpl so that it has fewer arguments,\npreferring to pass in entire config objects as opposed to individual elements from the\nconfig.\n\nTurned out that InstanceDataManagerConfig can be null only for tests, so changed the tests to include a\nmock, so that this paramter can always be non-null when constructing IndexLoadingConfig.\n\nThe only behavior change in this check-in is that if IndexLoadingConfig is constructed with InstanceDataManagerConfig as null\n(never happens in non-test use cases), then we will now turn _enableDefaultColumns to false because the mock for these\ntests sets it to the default value.\n\nIn live situations, InstanceDataManagerConfig is never null, so the member variable _enableDefaultColumns is always taken\nfrom whatever is configured in InstanceDataManagerConfig"},"comment":{"url":"https://api.github.com/repos/linkedin/pinot/issues/comments/323469112","html_url":"https://github.com/linkedin/pinot/pull/1811#issuecomment-323469112","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/1811","id":323469112,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-08-18T21:52:54Z","updated_at":"2017-08-18T21:52:54Z","body":"# [Codecov](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=h1) Report\n> Merging [#1811](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=desc) into [master](https://codecov.io/gh/linkedin/pinot/commit/c9923dea428d6a1cac52b012b2ab8d12f3b7b518?src=pr&el=desc) will **decrease** coverage by `0.14%`.\n> The diff coverage is `80%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/linkedin/pinot/pull/1811/graphs/tree.svg?token=4ibza2ugkz&width=650&height=150&src=pr)](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1811      +/-   ##\n==========================================\n- Coverage   65.84%   65.69%   -0.15%     \n==========================================\n  Files         867      868       +1     \n  Lines       42128    42142      +14     \n  Branches     5552     5551       -1     \n==========================================\n- Hits        27738    27685      -53     \n- Misses      12517    12597      +80     \n+ Partials     1873     1860      -13\n```\n\n\n| [Impacted Files](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...server/starter/helix/HelixInstanceDataManager.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L3NlcnZlci9zdGFydGVyL2hlbGl4L0hlbGl4SW5zdGFuY2VEYXRhTWFuYWdlci5qYXZh) | `78.4% <ø> (+1.83%)` | :arrow_up: |\n| [.../pinot/core/realtime/impl/RealtimeSegmentImpl.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvUmVhbHRpbWVTZWdtZW50SW1wbC5qYXZh) | `64.81% <100%> (+0.37%)` | :arrow_up: |\n| [...ta/manager/offline/RealtimeSegmentDataManager.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9vZmZsaW5lL1JlYWx0aW1lU2VnbWVudERhdGFNYW5hZ2VyLmphdmE=) | `100% <100%> (ø)` | |\n| [.../core/segment/index/loader/IndexLoadingConfig.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvbG9hZGVyL0luZGV4TG9hZGluZ0NvbmZpZy5qYXZh) | `85.33% <72.5%> (+1.77%)` | :arrow_up: |\n| [...manager/realtime/HLRealtimeSegmentDataManager.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9ITFJlYWx0aW1lU2VnbWVudERhdGFNYW5hZ2VyLmphdmE=) | `77.41% <80%> (+0.07%)` | :arrow_up: |\n| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9MTFJlYWx0aW1lU2VnbWVudERhdGFNYW5hZ2VyLmphdmE=) | `70.22% <83.33%> (+0.09%)` | :arrow_up: |\n| [...ller/api/restlet/resources/LLCSegmentConsumed.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2FwaS9yZXN0bGV0L3Jlc291cmNlcy9MTENTZWdtZW50Q29uc3VtZWQuamF2YQ==) | `0% <0%> (-77.78%)` | :arrow_down: |\n| [...r/api/restlet/resources/LLCSegmentCommitStart.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2FwaS9yZXN0bGV0L3Jlc291cmNlcy9MTENTZWdtZW50Q29tbWl0U3RhcnQuamF2YQ==) | `0% <0%> (-77.78%)` | :arrow_down: |\n| [...ler/api/restlet/resources/LLCSegmentCommitEnd.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2FwaS9yZXN0bGV0L3Jlc291cmNlcy9MTENTZWdtZW50Q29tbWl0RW5kLmphdmE=) | `0% <0%> (-77.78%)` | :arrow_down: |\n| [...t/controller/api/restlet/resources/TableViews.java](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2FwaS9yZXN0bGV0L3Jlc291cmNlcy9UYWJsZVZpZXdzLmphdmE=) | `1.63% <0%> (-73.78%)` | :arrow_down: |\n| ... and [52 more](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=footer). Last update [c9923de...0daa75b](https://codecov.io/gh/linkedin/pinot/pull/1811?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}