{"action":"created","comment":{"url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/comments/138652572","pull_request_review_id":62476441,"id":138652572,"diff_hunk":"@@ -29,6 +29,35 @@ const getHome = async (req, res, next) => {\n   })\n }\n \n+const getPupils = async (req, res, next) => {\n+  res.locals.pageTitle = 'Pupil register'\n+  const { sortOrder } = req.params\n+  res.locals.sortOrder = sortOrder || 1","path":"admin/controllers/school.js","position":16,"original_position":16,"commit_id":"7823eb2cde668e700dc089d8c2ab5c2e40e2ee1a","original_commit_id":"7823eb2cde668e700dc089d8c2ab5c2e40e2ee1a","user":{"login":"jon-shipley","id":13945069,"avatar_url":"https://avatars0.githubusercontent.com/u/13945069?v=4","gravatar_id":"","url":"https://api.github.com/users/jon-shipley","html_url":"https://github.com/jon-shipley","followers_url":"https://api.github.com/users/jon-shipley/followers","following_url":"https://api.github.com/users/jon-shipley/following{/other_user}","gists_url":"https://api.github.com/users/jon-shipley/gists{/gist_id}","starred_url":"https://api.github.com/users/jon-shipley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon-shipley/subscriptions","organizations_url":"https://api.github.com/users/jon-shipley/orgs","repos_url":"https://api.github.com/users/jon-shipley/repos","events_url":"https://api.github.com/users/jon-shipley/events{/privacy}","received_events_url":"https://api.github.com/users/jon-shipley/received_events","type":"User","site_admin":false},"body":"I think sortOrder needs more validation - what if someone passes in unusual input?","created_at":"2017-09-13T15:21:25Z","updated_at":"2017-09-13T15:21:25Z","html_url":"https://github.com/DFEAGILEDEVOPS/MTC/pull/153#discussion_r138652572","pull_request_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/153","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/comments/138652572"},"html":{"href":"https://github.com/DFEAGILEDEVOPS/MTC/pull/153#discussion_r138652572"},"pull_request":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/153","id":139861326,"html_url":"https://github.com/DFEAGILEDEVOPS/MTC/pull/153","diff_url":"https://github.com/DFEAGILEDEVOPS/MTC/pull/153.diff","patch_url":"https://github.com/DFEAGILEDEVOPS/MTC/pull/153.patch","issue_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues/153","number":153,"state":"open","locked":false,"title":"13939 Overview page","user":{"login":"GeorgeChatzigiannis","id":4175503,"avatar_url":"https://avatars1.githubusercontent.com/u/4175503?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeChatzigiannis","html_url":"https://github.com/GeorgeChatzigiannis","followers_url":"https://api.github.com/users/GeorgeChatzigiannis/followers","following_url":"https://api.github.com/users/GeorgeChatzigiannis/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeChatzigiannis/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeChatzigiannis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeChatzigiannis/subscriptions","organizations_url":"https://api.github.com/users/GeorgeChatzigiannis/orgs","repos_url":"https://api.github.com/users/GeorgeChatzigiannis/repos","events_url":"https://api.github.com/users/GeorgeChatzigiannis/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeChatzigiannis/received_events","type":"User","site_admin":false},"body":"# WIP\r\n\r\n- Missing DoB reference on first column\r\n- Tests ","created_at":"2017-09-07T17:22:52Z","updated_at":"2017-09-13T15:21:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27adfc9ffe8a8f9a90d783c57152ad3b9b7ffcb3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pris54","id":5442972,"avatar_url":"https://avatars1.githubusercontent.com/u/5442972?v=4","gravatar_id":"","url":"https://api.github.com/users/pris54","html_url":"https://github.com/pris54","followers_url":"https://api.github.com/users/pris54/followers","following_url":"https://api.github.com/users/pris54/following{/other_user}","gists_url":"https://api.github.com/users/pris54/gists{/gist_id}","starred_url":"https://api.github.com/users/pris54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pris54/subscriptions","organizations_url":"https://api.github.com/users/pris54/orgs","repos_url":"https://api.github.com/users/pris54/repos","events_url":"https://api.github.com/users/pris54/events{/privacy}","received_events_url":"https://api.github.com/users/pris54/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/153/commits","review_comments_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/153/comments","review_comment_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues/153/comments","statuses_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/statuses/7823eb2cde668e700dc089d8c2ab5c2e40e2ee1a","head":{"label":"DFEAGILEDEVOPS:feature/13939-register-page","ref":"feature/13939-register-page","sha":"7823eb2cde668e700dc089d8c2ab5c2e40e2ee1a","user":{"login":"DFEAGILEDEVOPS","id":11753480,"avatar_url":"https://avatars0.githubusercontent.com/u/11753480?v=4","gravatar_id":"","url":"https://api.github.com/users/DFEAGILEDEVOPS","html_url":"https://github.com/DFEAGILEDEVOPS","followers_url":"https://api.github.com/users/DFEAGILEDEVOPS/followers","following_url":"https://api.github.com/users/DFEAGILEDEVOPS/following{/other_user}","gists_url":"https://api.github.com/users/DFEAGILEDEVOPS/gists{/gist_id}","starred_url":"https://api.github.com/users/DFEAGILEDEVOPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFEAGILEDEVOPS/subscriptions","organizations_url":"https://api.github.com/users/DFEAGILEDEVOPS/orgs","repos_url":"https://api.github.com/users/DFEAGILEDEVOPS/repos","events_url":"https://api.github.com/users/DFEAGILEDEVOPS/events{/privacy}","received_events_url":"https://api.github.com/users/DFEAGILEDEVOPS/received_events","type":"Organization","site_admin":false},"repo":{"id":79137062,"name":"MTC","full_name":"DFEAGILEDEVOPS/MTC","owner":{"login":"DFEAGILEDEVOPS","id":11753480,"avatar_url":"https://avatars0.githubusercontent.com/u/11753480?v=4","gravatar_id":"","url":"https://api.github.com/users/DFEAGILEDEVOPS","html_url":"https://github.com/DFEAGILEDEVOPS","followers_url":"https://api.github.com/users/DFEAGILEDEVOPS/followers","following_url":"https://api.github.com/users/DFEAGILEDEVOPS/following{/other_user}","gists_url":"https://api.github.com/users/DFEAGILEDEVOPS/gists{/gist_id}","starred_url":"https://api.github.com/users/DFEAGILEDEVOPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFEAGILEDEVOPS/subscriptions","organizations_url":"https://api.github.com/users/DFEAGILEDEVOPS/orgs","repos_url":"https://api.github.com/users/DFEAGILEDEVOPS/repos","events_url":"https://api.github.com/users/DFEAGILEDEVOPS/events{/privacy}","received_events_url":"https://api.github.com/users/DFEAGILEDEVOPS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DFEAGILEDEVOPS/MTC","description":"Multiplication Tables","fork":false,"url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC","forks_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/forks","keys_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/teams","hooks_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/hooks","issue_events_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues/events{/number}","events_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/events","assignees_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/assignees{/user}","branches_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/branches{/branch}","tags_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/tags","blobs_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/refs{/sha}","trees_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/statuses/{sha}","languages_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/languages","stargazers_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/stargazers","contributors_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/contributors","subscribers_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/subscribers","subscription_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/subscription","commits_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/commits{/sha}","git_commits_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/commits{/sha}","comments_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/comments{/number}","issue_comment_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues/comments{/number}","contents_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/contents/{+path}","compare_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/merges","archive_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/downloads","issues_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues{/number}","pulls_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls{/number}","milestones_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/milestones{/number}","notifications_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/labels{/name}","releases_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/releases{/id}","deployments_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/deployments","created_at":"2017-01-16T16:30:20Z","updated_at":"2017-09-06T11:54:48Z","pushed_at":"2017-09-13T15:14:00Z","git_url":"git://github.com/DFEAGILEDEVOPS/MTC.git","ssh_url":"git@github.com:DFEAGILEDEVOPS/MTC.git","clone_url":"https://github.com/DFEAGILEDEVOPS/MTC.git","svn_url":"https://github.com/DFEAGILEDEVOPS/MTC","homepage":null,"size":3945,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"DFEAGILEDEVOPS:master","ref":"master","sha":"3dfa220c1c1c4ce33a582a69f7637fbc007f17e5","user":{"login":"DFEAGILEDEVOPS","id":11753480,"avatar_url":"https://avatars0.githubusercontent.com/u/11753480?v=4","gravatar_id":"","url":"https://api.github.com/users/DFEAGILEDEVOPS","html_url":"https://github.com/DFEAGILEDEVOPS","followers_url":"https://api.github.com/users/DFEAGILEDEVOPS/followers","following_url":"https://api.github.com/users/DFEAGILEDEVOPS/following{/other_user}","gists_url":"https://api.github.com/users/DFEAGILEDEVOPS/gists{/gist_id}","starred_url":"https://api.github.com/users/DFEAGILEDEVOPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFEAGILEDEVOPS/subscriptions","organizations_url":"https://api.github.com/users/DFEAGILEDEVOPS/orgs","repos_url":"https://api.github.com/users/DFEAGILEDEVOPS/repos","events_url":"https://api.github.com/users/DFEAGILEDEVOPS/events{/privacy}","received_events_url":"https://api.github.com/users/DFEAGILEDEVOPS/received_events","type":"Organization","site_admin":false},"repo":{"id":79137062,"name":"MTC","full_name":"DFEAGILEDEVOPS/MTC","owner":{"login":"DFEAGILEDEVOPS","id":11753480,"avatar_url":"https://avatars0.githubusercontent.com/u/11753480?v=4","gravatar_id":"","url":"https://api.github.com/users/DFEAGILEDEVOPS","html_url":"https://github.com/DFEAGILEDEVOPS","followers_url":"https://api.github.com/users/DFEAGILEDEVOPS/followers","following_url":"https://api.github.com/users/DFEAGILEDEVOPS/following{/other_user}","gists_url":"https://api.github.com/users/DFEAGILEDEVOPS/gists{/gist_id}","starred_url":"https://api.github.com/users/DFEAGILEDEVOPS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFEAGILEDEVOPS/subscriptions","organizations_url":"https://api.github.com/users/DFEAGILEDEVOPS/orgs","repos_url":"https://api.github.com/users/DFEAGILEDEVOPS/repos","events_url":"https://api.github.com/users/DFEAGILEDEVOPS/events{/privacy}","received_events_url":"https://api.github.com/users/DFEAGILEDEVOPS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DFEAGILEDEVOPS/MTC","description":"Multiplication Tables","fork":false,"url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC","forks_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/forks","keys_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/teams","hooks_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/hooks","issue_events_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues/events{/number}","events_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/events","assignees_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/assignees{/user}","branches_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/branches{/branch}","tags_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/tags","blobs_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/refs{/sha}","trees_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/statuses/{sha}","languages_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/languages","stargazers_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/stargazers","contributors_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/contributors","subscribers_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/subscribers","subscription_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/subscription","commits_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/commits{/sha}","git_commits_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/git/commits{/sha}","comments_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/comments{/number}","issue_comment_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues/comments{/number}","contents_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/contents/{+path}","compare_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/merges","archive_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/downloads","issues_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues{/number}","pulls_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls{/number}","milestones_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/milestones{/number}","notifications_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/labels{/name}","releases_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/releases{/id}","deployments_url":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/deployments","created_at":"2017-01-16T16:30:20Z","updated_at":"2017-09-06T11:54:48Z","pushed_at":"2017-09-13T15:14:00Z","git_url":"git://github.com/DFEAGILEDEVOPS/MTC.git","ssh_url":"git@github.com:DFEAGILEDEVOPS/MTC.git","clone_url":"https://github.com/DFEAGILEDEVOPS/MTC.git","svn_url":"https://github.com/DFEAGILEDEVOPS/MTC","homepage":null,"size":3945,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/153"},"html":{"href":"https://github.com/DFEAGILEDEVOPS/MTC/pull/153"},"issue":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues/153"},"comments":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/DFEAGILEDEVOPS/MTC/statuses/7823eb2cde668e700dc089d8c2ab5c2e40e2ee1a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jon-shipley"}}