{"action":"closed","number":66,"pull_request":{"url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls/66","id":138902151,"html_url":"https://github.com/feedhenry-raincatcher/raincatcher-angularjs/pull/66","diff_url":"https://github.com/feedhenry-raincatcher/raincatcher-angularjs/pull/66.diff","patch_url":"https://github.com/feedhenry-raincatcher/raincatcher-angularjs/pull/66.patch","issue_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/issues/66","number":66,"state":"closed","locked":false,"title":"Passport JWT strategy for mobile","user":{"login":"JameelB","id":9078522,"avatar_url":"https://avatars2.githubusercontent.com/u/9078522?v=4","gravatar_id":"","url":"https://api.github.com/users/JameelB","html_url":"https://github.com/JameelB","followers_url":"https://api.github.com/users/JameelB/followers","following_url":"https://api.github.com/users/JameelB/following{/other_user}","gists_url":"https://api.github.com/users/JameelB/gists{/gist_id}","starred_url":"https://api.github.com/users/JameelB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JameelB/subscriptions","organizations_url":"https://api.github.com/users/JameelB/orgs","repos_url":"https://api.github.com/users/JameelB/repos","events_url":"https://api.github.com/users/JameelB/events{/privacy}","received_events_url":"https://api.github.com/users/JameelB/received_events","type":"User","site_admin":false},"body":"## Motivation\r\nThe current strategy that Passport is using for mobile is not working properly due to the implications listed on RAINCATCH-1192.\r\n\r\n## Description\r\nAdd Passport's JWT strategy for mobile authentication instead of cookies. \r\n\r\n## Progress\r\n- [x] Create a login auth module to be utilized by the mobile app. This will contain the login route, controllers and directives. \r\n- [x] Update the sync global network handler to add the token to the `Authorization` header for each request. Ensure to disable withCredentials for the mobile's $httpProvider.\r\n- [x] Update the login controller of the mobile app to follow the token based authentication flow upon login. Ensure that this sets the token and the userProfile to the localStorage. \r\n- [x] Update Passport's authService login to redirect to the appropriate login pages for each app.\r\n- [x] Update Passport's authService getProfile to get the userProfile data from the localStorage for the mobile app. \r\n- [x] Update Passport's authService logout to clear the localStorage upon logout. \r\n- [x] Clean up\r\n\r\n## Additional Notes\r\nhttps://issues.jboss.org/browse/RAINCATCH-1209\r\n","created_at":"2017-09-01T14:21:59Z","updated_at":"2017-09-11T10:13:42Z","closed_at":"2017-09-11T10:13:42Z","merged_at":"2017-09-11T10:13:42Z","merge_commit_sha":"69faac9b40b231e156ad65001209b6ba81347685","assignee":null,"assignees":[],"requested_reviewers":[{"login":"paolobueno","id":1294893,"avatar_url":"https://avatars0.githubusercontent.com/u/1294893?v=4","gravatar_id":"","url":"https://api.github.com/users/paolobueno","html_url":"https://github.com/paolobueno","followers_url":"https://api.github.com/users/paolobueno/followers","following_url":"https://api.github.com/users/paolobueno/following{/other_user}","gists_url":"https://api.github.com/users/paolobueno/gists{/gist_id}","starred_url":"https://api.github.com/users/paolobueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolobueno/subscriptions","organizations_url":"https://api.github.com/users/paolobueno/orgs","repos_url":"https://api.github.com/users/paolobueno/repos","events_url":"https://api.github.com/users/paolobueno/events{/privacy}","received_events_url":"https://api.github.com/users/paolobueno/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls/66/commits","review_comments_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls/66/comments","review_comment_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/issues/66/comments","statuses_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/statuses/75ac86ccc5c57a259062f2f310ef5c83a93aee11","head":{"label":"JameelB:offline-mobile-auth","ref":"offline-mobile-auth","sha":"75ac86ccc5c57a259062f2f310ef5c83a93aee11","user":{"login":"JameelB","id":9078522,"avatar_url":"https://avatars2.githubusercontent.com/u/9078522?v=4","gravatar_id":"","url":"https://api.github.com/users/JameelB","html_url":"https://github.com/JameelB","followers_url":"https://api.github.com/users/JameelB/followers","following_url":"https://api.github.com/users/JameelB/following{/other_user}","gists_url":"https://api.github.com/users/JameelB/gists{/gist_id}","starred_url":"https://api.github.com/users/JameelB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JameelB/subscriptions","organizations_url":"https://api.github.com/users/JameelB/orgs","repos_url":"https://api.github.com/users/JameelB/repos","events_url":"https://api.github.com/users/JameelB/events{/privacy}","received_events_url":"https://api.github.com/users/JameelB/received_events","type":"User","site_admin":false},"repo":{"id":96531484,"name":"raincatcher-angularjs","full_name":"JameelB/raincatcher-angularjs","owner":{"login":"JameelB","id":9078522,"avatar_url":"https://avatars2.githubusercontent.com/u/9078522?v=4","gravatar_id":"","url":"https://api.github.com/users/JameelB","html_url":"https://github.com/JameelB","followers_url":"https://api.github.com/users/JameelB/followers","following_url":"https://api.github.com/users/JameelB/following{/other_user}","gists_url":"https://api.github.com/users/JameelB/gists{/gist_id}","starred_url":"https://api.github.com/users/JameelB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JameelB/subscriptions","organizations_url":"https://api.github.com/users/JameelB/orgs","repos_url":"https://api.github.com/users/JameelB/repos","events_url":"https://api.github.com/users/JameelB/events{/privacy}","received_events_url":"https://api.github.com/users/JameelB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JameelB/raincatcher-angularjs","description":"Raincatcher example implementation in angularjs","fork":true,"url":"https://api.github.com/repos/JameelB/raincatcher-angularjs","forks_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/forks","keys_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/teams","hooks_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/hooks","issue_events_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/issues/events{/number}","events_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/events","assignees_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/assignees{/user}","branches_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/branches{/branch}","tags_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/tags","blobs_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/statuses/{sha}","languages_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/languages","stargazers_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/stargazers","contributors_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/contributors","subscribers_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/subscribers","subscription_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/subscription","commits_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/contents/{+path}","compare_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/merges","archive_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/downloads","issues_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/issues{/number}","pulls_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/pulls{/number}","milestones_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/milestones{/number}","notifications_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/labels{/name}","releases_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/releases{/id}","deployments_url":"https://api.github.com/repos/JameelB/raincatcher-angularjs/deployments","created_at":"2017-07-07T11:16:36Z","updated_at":"2017-07-07T11:16:38Z","pushed_at":"2017-09-09T14:18:31Z","git_url":"git://github.com/JameelB/raincatcher-angularjs.git","ssh_url":"git@github.com:JameelB/raincatcher-angularjs.git","clone_url":"https://github.com/JameelB/raincatcher-angularjs.git","svn_url":"https://github.com/JameelB/raincatcher-angularjs","homepage":"http://feedhenry-raincatcher.github.io","size":1794,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry-raincatcher:master","ref":"master","sha":"7a9e0691ab638a6bde4edc5a88a3febe6977717f","user":{"login":"feedhenry-raincatcher","id":19932793,"avatar_url":"https://avatars2.githubusercontent.com/u/19932793?v=4","gravatar_id":"","url":"https://api.github.com/users/feedhenry-raincatcher","html_url":"https://github.com/feedhenry-raincatcher","followers_url":"https://api.github.com/users/feedhenry-raincatcher/followers","following_url":"https://api.github.com/users/feedhenry-raincatcher/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry-raincatcher/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry-raincatcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry-raincatcher/subscriptions","organizations_url":"https://api.github.com/users/feedhenry-raincatcher/orgs","repos_url":"https://api.github.com/users/feedhenry-raincatcher/repos","events_url":"https://api.github.com/users/feedhenry-raincatcher/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry-raincatcher/received_events","type":"Organization","site_admin":false},"repo":{"id":95100694,"name":"raincatcher-angularjs","full_name":"feedhenry-raincatcher/raincatcher-angularjs","owner":{"login":"feedhenry-raincatcher","id":19932793,"avatar_url":"https://avatars2.githubusercontent.com/u/19932793?v=4","gravatar_id":"","url":"https://api.github.com/users/feedhenry-raincatcher","html_url":"https://github.com/feedhenry-raincatcher","followers_url":"https://api.github.com/users/feedhenry-raincatcher/followers","following_url":"https://api.github.com/users/feedhenry-raincatcher/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry-raincatcher/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry-raincatcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry-raincatcher/subscriptions","organizations_url":"https://api.github.com/users/feedhenry-raincatcher/orgs","repos_url":"https://api.github.com/users/feedhenry-raincatcher/repos","events_url":"https://api.github.com/users/feedhenry-raincatcher/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry-raincatcher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry-raincatcher/raincatcher-angularjs","description":":tada: Raincatcher example implementation in angularjs","fork":false,"url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs","forks_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/forks","keys_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/teams","hooks_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/hooks","issue_events_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/events","assignees_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/tags","blobs_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/languages","stargazers_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/stargazers","contributors_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/contributors","subscribers_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/subscribers","subscription_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/subscription","commits_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/merges","archive_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/downloads","issues_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/deployments","created_at":"2017-06-22T09:49:28Z","updated_at":"2017-08-17T08:44:36Z","pushed_at":"2017-09-11T10:13:42Z","git_url":"git://github.com/feedhenry-raincatcher/raincatcher-angularjs.git","ssh_url":"git@github.com:feedhenry-raincatcher/raincatcher-angularjs.git","clone_url":"https://github.com/feedhenry-raincatcher/raincatcher-angularjs.git","svn_url":"https://github.com/feedhenry-raincatcher/raincatcher-angularjs","homepage":"http://raincatcher.feedhenry.io","size":1711,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls/66"},"html":{"href":"https://github.com/feedhenry-raincatcher/raincatcher-angularjs/pull/66"},"issue":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/issues/66"},"comments":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry-raincatcher/raincatcher-angularjs/statuses/75ac86ccc5c57a259062f2f310ef5c83a93aee11"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars3.githubusercontent.com/u/981838?v=4","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"comments":2,"review_comments":12,"maintainer_can_modify":false,"commits":22,"additions":839,"deletions":363,"changed_files":178}}
{"actor":{"display_login":"wtrocki"}}