{"action":"created","comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/141524547","pull_request_review_id":65749946,"id":141524547,"diff_hunk":"@@ -78,6 +78,9 @@\n import org.slf4j.Logger;\n import org.slf4j.LoggerFactory;\n import org.springframework.aop.Advisor;\n+import org.springframework.context.ApplicationContext;\n+import org.springframework.context.support.ClassPathXmlApplicationContext;\n+import org.springframework.beans.factory.*;","path":"api/src/main/java/org/openmrs/api/context/Context.java","position":6,"original_position":6,"commit_id":"33354a0adefe7b92f6dd4459b66d22e0b5446f12","original_commit_id":"33354a0adefe7b92f6dd4459b66d22e0b5446f12","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Using the '.*' form of import should be avoided - org.springframework.beans.factory.*.](https://www.codacy.com/app/openmrs/openmrs-core/pullRequest?prid=948227)","created_at":"2017-09-28T04:33:52Z","updated_at":"2017-09-28T04:33:52Z","html_url":"https://github.com/openmrs/openmrs-core/pull/2258#discussion_r141524547","pull_request_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2258","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments/141524547"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/2258#discussion_r141524547"},"pull_request":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2258"}}},"pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2258","id":143552887,"html_url":"https://github.com/openmrs/openmrs-core/pull/2258","diff_url":"https://github.com/openmrs/openmrs-core/pull/2258.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/2258.patch","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2258","number":2258,"state":"open","locked":false,"title":"TRUNK-4988:  Convenience method to allow us to change the configuration more easily","user":{"login":"MalithaDilshan","id":19968541,"avatar_url":"https://avatars2.githubusercontent.com/u/19968541?v=4","gravatar_id":"","url":"https://api.github.com/users/MalithaDilshan","html_url":"https://github.com/MalithaDilshan","followers_url":"https://api.github.com/users/MalithaDilshan/followers","following_url":"https://api.github.com/users/MalithaDilshan/following{/other_user}","gists_url":"https://api.github.com/users/MalithaDilshan/gists{/gist_id}","starred_url":"https://api.github.com/users/MalithaDilshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalithaDilshan/subscriptions","organizations_url":"https://api.github.com/users/MalithaDilshan/orgs","repos_url":"https://api.github.com/users/MalithaDilshan/repos","events_url":"https://api.github.com/users/MalithaDilshan/events{/privacy}","received_events_url":"https://api.github.com/users/MalithaDilshan/received_events","type":"User","site_admin":false},"body":"## Description of what I changed\r\nI have implemented a method to do the easy configuration using dependency injection.\r\n\r\n## Issue I worked on\r\nTRUNK-4988: Convenience method to allow us to change the configuration more easily.\r\n\r\nIssues from TODOs\r\nLine 560 and 570 of Context.java contain the following TODO:\r\nLine 560: Ideally, we would be using Spring's method injection to set the dependencies for the message service.\r\nLine 570: See todo for message sender; that is, the one above.\r\n\r\n## Checklist: I completed these to help reviewers :)\r\n\r\n- [x] My pull request only contains **ONE single commit**\r\n(the number above, next to the 'Commits' tab is 1).\r\n\r\n\r\n\r\n- [x] My IDE is configured to follow the [**code style**](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project.\r\n\r\n \r\n- [x] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n\r\n- [x] My pull request is **based on the latest changes** of the master branch.\r\n\r\n ","created_at":"2017-09-28T04:26:46Z","updated_at":"2017-09-28T04:33:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cae9715991fdcab04120cd797eb0d051dcfa8776","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2258/commits","review_comments_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2258/comments","review_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2258/comments","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/33354a0adefe7b92f6dd4459b66d22e0b5446f12","head":{"label":"MalithaDilshan:master","ref":"master","sha":"33354a0adefe7b92f6dd4459b66d22e0b5446f12","user":{"login":"MalithaDilshan","id":19968541,"avatar_url":"https://avatars2.githubusercontent.com/u/19968541?v=4","gravatar_id":"","url":"https://api.github.com/users/MalithaDilshan","html_url":"https://github.com/MalithaDilshan","followers_url":"https://api.github.com/users/MalithaDilshan/followers","following_url":"https://api.github.com/users/MalithaDilshan/following{/other_user}","gists_url":"https://api.github.com/users/MalithaDilshan/gists{/gist_id}","starred_url":"https://api.github.com/users/MalithaDilshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalithaDilshan/subscriptions","organizations_url":"https://api.github.com/users/MalithaDilshan/orgs","repos_url":"https://api.github.com/users/MalithaDilshan/repos","events_url":"https://api.github.com/users/MalithaDilshan/events{/privacy}","received_events_url":"https://api.github.com/users/MalithaDilshan/received_events","type":"User","site_admin":false},"repo":{"id":105100353,"name":"openmrs-core","full_name":"MalithaDilshan/openmrs-core","owner":{"login":"MalithaDilshan","id":19968541,"avatar_url":"https://avatars2.githubusercontent.com/u/19968541?v=4","gravatar_id":"","url":"https://api.github.com/users/MalithaDilshan","html_url":"https://github.com/MalithaDilshan","followers_url":"https://api.github.com/users/MalithaDilshan/followers","following_url":"https://api.github.com/users/MalithaDilshan/following{/other_user}","gists_url":"https://api.github.com/users/MalithaDilshan/gists{/gist_id}","starred_url":"https://api.github.com/users/MalithaDilshan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalithaDilshan/subscriptions","organizations_url":"https://api.github.com/users/MalithaDilshan/orgs","repos_url":"https://api.github.com/users/MalithaDilshan/repos","events_url":"https://api.github.com/users/MalithaDilshan/events{/privacy}","received_events_url":"https://api.github.com/users/MalithaDilshan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MalithaDilshan/openmrs-core","description":"OpenMRS API and web application code","fork":true,"url":"https://api.github.com/repos/MalithaDilshan/openmrs-core","forks_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/forks","keys_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/teams","hooks_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/events","assignees_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/tags","blobs_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/subscription","commits_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/merges","archive_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/downloads","issues_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/MalithaDilshan/openmrs-core/deployments","created_at":"2017-09-28T03:58:02Z","updated_at":"2017-09-28T03:58:10Z","pushed_at":"2017-09-28T04:11:34Z","git_url":"git://github.com/MalithaDilshan/openmrs-core.git","ssh_url":"git@github.com:MalithaDilshan/openmrs-core.git","clone_url":"https://github.com/MalithaDilshan/openmrs-core.git","svn_url":"https://github.com/MalithaDilshan/openmrs-core","homepage":"http://openmrs.org","size":226103,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openmrs:master","ref":"master","sha":"42b4339fa95ddaad4918cbc4b976b93af218f414","user":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"repo":{"id":5187976,"name":"openmrs-core","full_name":"openmrs/openmrs-core","owner":{"login":"openmrs","id":860776,"avatar_url":"https://avatars3.githubusercontent.com/u/860776?v=4","gravatar_id":"","url":"https://api.github.com/users/openmrs","html_url":"https://github.com/openmrs","followers_url":"https://api.github.com/users/openmrs/followers","following_url":"https://api.github.com/users/openmrs/following{/other_user}","gists_url":"https://api.github.com/users/openmrs/gists{/gist_id}","starred_url":"https://api.github.com/users/openmrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmrs/subscriptions","organizations_url":"https://api.github.com/users/openmrs/orgs","repos_url":"https://api.github.com/users/openmrs/repos","events_url":"https://api.github.com/users/openmrs/events{/privacy}","received_events_url":"https://api.github.com/users/openmrs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmrs/openmrs-core","description":"OpenMRS API and web application code","fork":false,"url":"https://api.github.com/repos/openmrs/openmrs-core","forks_url":"https://api.github.com/repos/openmrs/openmrs-core/forks","keys_url":"https://api.github.com/repos/openmrs/openmrs-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmrs/openmrs-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmrs/openmrs-core/teams","hooks_url":"https://api.github.com/repos/openmrs/openmrs-core/hooks","issue_events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/events{/number}","events_url":"https://api.github.com/repos/openmrs/openmrs-core/events","assignees_url":"https://api.github.com/repos/openmrs/openmrs-core/assignees{/user}","branches_url":"https://api.github.com/repos/openmrs/openmrs-core/branches{/branch}","tags_url":"https://api.github.com/repos/openmrs/openmrs-core/tags","blobs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmrs/openmrs-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmrs/openmrs-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmrs/openmrs-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmrs/openmrs-core/statuses/{sha}","languages_url":"https://api.github.com/repos/openmrs/openmrs-core/languages","stargazers_url":"https://api.github.com/repos/openmrs/openmrs-core/stargazers","contributors_url":"https://api.github.com/repos/openmrs/openmrs-core/contributors","subscribers_url":"https://api.github.com/repos/openmrs/openmrs-core/subscribers","subscription_url":"https://api.github.com/repos/openmrs/openmrs-core/subscription","commits_url":"https://api.github.com/repos/openmrs/openmrs-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmrs/openmrs-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmrs/openmrs-core/contents/{+path}","compare_url":"https://api.github.com/repos/openmrs/openmrs-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmrs/openmrs-core/merges","archive_url":"https://api.github.com/repos/openmrs/openmrs-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmrs/openmrs-core/downloads","issues_url":"https://api.github.com/repos/openmrs/openmrs-core/issues{/number}","pulls_url":"https://api.github.com/repos/openmrs/openmrs-core/pulls{/number}","milestones_url":"https://api.github.com/repos/openmrs/openmrs-core/milestones{/number}","notifications_url":"https://api.github.com/repos/openmrs/openmrs-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/labels{/name}","releases_url":"https://api.github.com/repos/openmrs/openmrs-core/releases{/id}","deployments_url":"https://api.github.com/repos/openmrs/openmrs-core/deployments","created_at":"2012-07-26T04:54:29Z","updated_at":"2017-09-26T19:18:25Z","pushed_at":"2017-09-28T04:26:47Z","git_url":"git://github.com/openmrs/openmrs-core.git","ssh_url":"git@github.com:openmrs/openmrs-core.git","clone_url":"https://github.com/openmrs/openmrs-core.git","svn_url":"https://github.com/openmrs/openmrs-core","homepage":"http://openmrs.org","size":226103,"stargazers_count":523,"watchers_count":523,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1860,"mirror_url":null,"open_issues_count":13,"forks":1860,"open_issues":13,"watchers":523,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2258"},"html":{"href":"https://github.com/openmrs/openmrs-core/pull/2258"},"issue":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/2258"},"comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/issues/2258/comments"},"review_comments":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2258/comments"},"review_comment":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2258/commits"},"statuses":{"href":"https://api.github.com/repos/openmrs/openmrs-core/statuses/33354a0adefe7b92f6dd4459b66d22e0b5446f12"}},"author_association":"NONE"}}
{"actor":{"display_login":"codacy-bot"}}