{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/137120744","pull_request_review_id":60747523,"id":137120744,"diff_hunk":"@@ -337,8 +337,8 @@ public function loadMetadataForClass($className, ClassMetadata $metadata)\n                 $metadata->setSequenceGeneratorDefinition(\n                     [\n                         'sequenceName' => (string) $seqGenerator['sequence-name'],\n-                        'allocationSize' => (string) $seqGenerator['allocation-size'],\n-                        'initialValue' => (string) $seqGenerator['initial-value']\n+                        'allocationSize' => (int) $seqGenerator['allocation-size'],\n+                        'initialValue' => (int) $seqGenerator['initial-value']","path":"lib/Doctrine/ORM/Mapping/Driver/XmlDriver.php","position":7,"original_position":7,"commit_id":"c96fc5385ff4f51ed15b620e1ab3e3c9f4e66b0d","original_commit_id":"c96fc5385ff4f51ed15b620e1ab3e3c9f4e66b0d","user":{"login":"alextech","id":3820828,"avatar_url":"https://avatars1.githubusercontent.com/u/3820828?v=4","gravatar_id":"","url":"https://api.github.com/users/alextech","html_url":"https://github.com/alextech","followers_url":"https://api.github.com/users/alextech/followers","following_url":"https://api.github.com/users/alextech/following{/other_user}","gists_url":"https://api.github.com/users/alextech/gists{/gist_id}","starred_url":"https://api.github.com/users/alextech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alextech/subscriptions","organizations_url":"https://api.github.com/users/alextech/orgs","repos_url":"https://api.github.com/users/alextech/repos","events_url":"https://api.github.com/users/alextech/events{/privacy}","received_events_url":"https://api.github.com/users/alextech/received_events","type":"User","site_admin":false},"body":"sorry, discovered actual root cause. Thanks @Majkl578 for making me think further about it. Turns out xml driver is not supplying default values for optional fields when they are omitted in mapping file. This results in empty $definition keys, which causes \"non numeric value\" error during addition, *not* because it is a casting problem as I originally thought. \r\n\r\nWill redo the fix by either validating input in `ClassMetadataInfo::setSequenceGeneratorDefinition`  where it already does a little bit of parsing validation for sequence_name, but not the other parameters, or maybe I can find why XSD schema is not applied by XML driver.","created_at":"2017-09-05T21:33:12Z","updated_at":"2017-09-05T21:33:13Z","html_url":"https://github.com/doctrine/doctrine2/pull/6683#discussion_r137120744","pull_request_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6683","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/137120744"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/6683#discussion_r137120744"},"pull_request":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6683"}},"in_reply_to_id":136752245},"pull_request":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6683","id":139060977,"html_url":"https://github.com/doctrine/doctrine2/pull/6683","diff_url":"https://github.com/doctrine/doctrine2/pull/6683.diff","patch_url":"https://github.com/doctrine/doctrine2/pull/6683.patch","issue_url":"https://api.github.com/repos/doctrine/doctrine2/issues/6683","number":6683,"state":"open","locked":false,"title":"Cast sequence parameters as integers in XML driver.","user":{"login":"alextech","id":3820828,"avatar_url":"https://avatars1.githubusercontent.com/u/3820828?v=4","gravatar_id":"","url":"https://api.github.com/users/alextech","html_url":"https://github.com/alextech","followers_url":"https://api.github.com/users/alextech/followers","following_url":"https://api.github.com/users/alextech/following{/other_user}","gists_url":"https://api.github.com/users/alextech/gists{/gist_id}","starred_url":"https://api.github.com/users/alextech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alextech/subscriptions","organizations_url":"https://api.github.com/users/alextech/orgs","repos_url":"https://api.github.com/users/alextech/repos","events_url":"https://api.github.com/users/alextech/events{/privacy}","received_events_url":"https://api.github.com/users/alextech/received_events","type":"User","site_admin":false},"body":"Fix #6682\r\n~~Cannot figure out how to get XML to run properly from Ticket directory as in contributor guide. If this is a strict requirement will try again.~~ Figured out.","created_at":"2017-09-03T20:39:49Z","updated_at":"2017-09-05T21:33:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71455a9e8b898f5b57e209483df87573af899406","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6683/commits","review_comments_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/6683/comments","review_comment_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/issues/6683/comments","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/c96fc5385ff4f51ed15b620e1ab3e3c9f4e66b0d","head":{"label":"alextech:bugfix/xml_sequence_params","ref":"bugfix/xml_sequence_params","sha":"c96fc5385ff4f51ed15b620e1ab3e3c9f4e66b0d","user":{"login":"alextech","id":3820828,"avatar_url":"https://avatars1.githubusercontent.com/u/3820828?v=4","gravatar_id":"","url":"https://api.github.com/users/alextech","html_url":"https://github.com/alextech","followers_url":"https://api.github.com/users/alextech/followers","following_url":"https://api.github.com/users/alextech/following{/other_user}","gists_url":"https://api.github.com/users/alextech/gists{/gist_id}","starred_url":"https://api.github.com/users/alextech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alextech/subscriptions","organizations_url":"https://api.github.com/users/alextech/orgs","repos_url":"https://api.github.com/users/alextech/repos","events_url":"https://api.github.com/users/alextech/events{/privacy}","received_events_url":"https://api.github.com/users/alextech/received_events","type":"User","site_admin":false},"repo":{"id":102289458,"name":"doctrine2","full_name":"alextech/doctrine2","owner":{"login":"alextech","id":3820828,"avatar_url":"https://avatars1.githubusercontent.com/u/3820828?v=4","gravatar_id":"","url":"https://api.github.com/users/alextech","html_url":"https://github.com/alextech","followers_url":"https://api.github.com/users/alextech/followers","following_url":"https://api.github.com/users/alextech/following{/other_user}","gists_url":"https://api.github.com/users/alextech/gists{/gist_id}","starred_url":"https://api.github.com/users/alextech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alextech/subscriptions","organizations_url":"https://api.github.com/users/alextech/orgs","repos_url":"https://api.github.com/users/alextech/repos","events_url":"https://api.github.com/users/alextech/events{/privacy}","received_events_url":"https://api.github.com/users/alextech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alextech/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":true,"url":"https://api.github.com/repos/alextech/doctrine2","forks_url":"https://api.github.com/repos/alextech/doctrine2/forks","keys_url":"https://api.github.com/repos/alextech/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alextech/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alextech/doctrine2/teams","hooks_url":"https://api.github.com/repos/alextech/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/alextech/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/alextech/doctrine2/events","assignees_url":"https://api.github.com/repos/alextech/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/alextech/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/alextech/doctrine2/tags","blobs_url":"https://api.github.com/repos/alextech/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alextech/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alextech/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alextech/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alextech/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/alextech/doctrine2/languages","stargazers_url":"https://api.github.com/repos/alextech/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/alextech/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/alextech/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/alextech/doctrine2/subscription","commits_url":"https://api.github.com/repos/alextech/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alextech/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alextech/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alextech/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alextech/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/alextech/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alextech/doctrine2/merges","archive_url":"https://api.github.com/repos/alextech/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alextech/doctrine2/downloads","issues_url":"https://api.github.com/repos/alextech/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/alextech/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/alextech/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/alextech/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alextech/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/alextech/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/alextech/doctrine2/deployments","created_at":"2017-09-03T19:37:47Z","updated_at":"2017-09-03T19:37:53Z","pushed_at":"2017-09-03T21:07:25Z","git_url":"git://github.com/alextech/doctrine2.git","ssh_url":"git@github.com:alextech/doctrine2.git","clone_url":"https://github.com/alextech/doctrine2.git","svn_url":"https://github.com/alextech/doctrine2","homepage":"http://www.doctrine-project.org","size":32795,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"4bc29d1049bd7c2293771e844c787e0e07179e7a","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":597887,"name":"doctrine2","full_name":"doctrine/doctrine2","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars3.githubusercontent.com/u/209254?v=4","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":false,"url":"https://api.github.com/repos/doctrine/doctrine2","forks_url":"https://api.github.com/repos/doctrine/doctrine2/forks","keys_url":"https://api.github.com/repos/doctrine/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/doctrine2/teams","hooks_url":"https://api.github.com/repos/doctrine/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/doctrine/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/doctrine2/events","assignees_url":"https://api.github.com/repos/doctrine/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/doctrine2/tags","blobs_url":"https://api.github.com/repos/doctrine/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/doctrine2/languages","stargazers_url":"https://api.github.com/repos/doctrine/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/doctrine/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/doctrine/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/doctrine/doctrine2/subscription","commits_url":"https://api.github.com/repos/doctrine/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/doctrine2/merges","archive_url":"https://api.github.com/repos/doctrine/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/doctrine2/downloads","issues_url":"https://api.github.com/repos/doctrine/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/doctrine2/deployments","created_at":"2010-04-06T21:42:59Z","updated_at":"2017-09-04T10:21:29Z","pushed_at":"2017-09-04T09:40:07Z","git_url":"git://github.com/doctrine/doctrine2.git","ssh_url":"git@github.com:doctrine/doctrine2.git","clone_url":"https://github.com/doctrine/doctrine2.git","svn_url":"https://github.com/doctrine/doctrine2","homepage":"http://www.doctrine-project.org","size":32823,"stargazers_count":3729,"watchers_count":3729,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1792,"mirror_url":null,"open_issues_count":1165,"forks":1792,"open_issues":1165,"watchers":3729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6683"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/6683"},"issue":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/6683"},"comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/6683/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6683/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/6683/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/doctrine2/statuses/c96fc5385ff4f51ed15b620e1ab3e3c9f4e66b0d"}},"author_association":"NONE"}}
{"actor":{"display_login":"alextech"}}