{"action":"created","issue":{"url":"https://api.github.com/repos/caffe2/caffe2/issues/880","repository_url":"https://api.github.com/repos/caffe2/caffe2","labels_url":"https://api.github.com/repos/caffe2/caffe2/issues/880/labels{/name}","comments_url":"https://api.github.com/repos/caffe2/caffe2/issues/880/comments","events_url":"https://api.github.com/repos/caffe2/caffe2/issues/880/events","html_url":"https://github.com/caffe2/caffe2/pull/880","id":238938358,"number":880,"title":"Added Ninja generator support on Windows","user":{"login":"willyd","id":628693,"avatar_url":"https://avatars2.githubusercontent.com/u/628693?v=3","gravatar_id":"","url":"https://api.github.com/users/willyd","html_url":"https://github.com/willyd","followers_url":"https://api.github.com/users/willyd/followers","following_url":"https://api.github.com/users/willyd/following{/other_user}","gists_url":"https://api.github.com/users/willyd/gists{/gist_id}","starred_url":"https://api.github.com/users/willyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willyd/subscriptions","organizations_url":"https://api.github.com/users/willyd/orgs","repos_url":"https://api.github.com/users/willyd/repos","events_url":"https://api.github.com/users/willyd/events{/privacy}","received_events_url":"https://api.github.com/users/willyd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-27T18:17:30Z","updated_at":"2017-06-27T18:17:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/caffe2/caffe2/pulls/880","html_url":"https://github.com/caffe2/caffe2/pull/880","diff_url":"https://github.com/caffe2/caffe2/pull/880.diff","patch_url":"https://github.com/caffe2/caffe2/pull/880.patch"},"body":"I successfully built caffe2 using MSVC 2015 and the Ninja Generator. I use vcpkg to build glfags, glog, lmdb and protobuf. Here is my build procedure:\r\n\r\n1. Install vcpkg and set it up according to vcpkg docs\r\n2. Install dependencies\r\n```\r\n$> vcpkg install gflags glog lmdb protobuf eigen3 --triplet x64-windows-static\r\n```\r\n3. Run CMake with this batch file\r\n```Batch\r\n@setlocal\r\nif NOT DEFINED VCPKG_DIR ( echo \"Please defined VCPKG_DIR\" && exit /b 1 )\r\nif NOT DEFINED CMAKE_BUILD_TYPE set CMAKE_BUILD_TYPE=Release\r\nif NOT DEFINED BUILD_DIR set BUILD_DIR=build_%CMAKE_BUILD_TYPE%\r\nif NOT DEFINED USE_CUDA set USE_CUDA=OFF\r\n\r\ncall \"%VS140COMNTOOLS%\\..\\..\\VC\\vcvarsall.bat\" amd64\r\n\r\nif NOT EXIST %BUILD_DIR% (mkdir %BUILD_DIR%)\r\npushd %BUILD_DIR%\r\n\r\nset CMAKE_GENERATOR=Ninja\r\nset ZLIB_LIBRARY=%VCPKG_DIR%\\installed\\x64-windows-static\\lib\\zlib.lib\r\n\r\ncmake -G\"%CMAKE_GENERATOR%\" ^\r\n      -DBUILD_SHARED_LIBS=OFF ^\r\n      -DCMAKE_VERBOSE_MAKEFILE=1 ^\r\n      -DBUILD_TEST=OFF ^\r\n      -DBUILD_SHARED_LIBS=OFF ^\r\n      -DCMAKE_BUILD_TYPE=%CMAKE_BUILD_TYPE% ^\r\n      -DUSE_CUDA=%USE_CUDA% ^\r\n      -DZLIB_LIBRARY:FILEPATH=\"%ZLIB_LIBRARY%\" ^\r\n      -DVCPKG_TARGET_TRIPLET=x64-windows-static ^\r\n      -DVCPKG_APPLOCAL_DEPS:BOOL=OFF ^\r\n      -DCMAKE_TOOLCHAIN_FILE:FILEPATH=%VCPKG_DIR%\\scripts\\buildsystems\\vcpkg.cmake ^\r\n      -DPROTOBUF_PROTOC_EXECUTABLE:FILEPATH=%VCPKG_DIR%\\installed\\x64-windows-static\\tools\\protoc.exe ^\r\n      ..\\\r\n\r\nninja\r\npopd\r\n\r\n@endlocal\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/caffe2/caffe2/issues/comments/311441848","html_url":"https://github.com/caffe2/caffe2/pull/880#issuecomment-311441848","issue_url":"https://api.github.com/repos/caffe2/caffe2/issues/880","id":311441848,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars0.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2017-06-27T18:17:34Z","updated_at":"2017-06-27T18:17:34Z","body":"Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need the corporate CLA signed.\n\nIf you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!"}}
{"actor":{"display_login":"facebook-github-bot"}}