{"action":"created","comment":{"url":"https://api.github.com/repos/google/google-p12-pem/pulls/comments/147337040","pull_request_review_id":72419005,"id":147337040,"diff_hunk":"@@ -1,5 +1,5 @@\n language: node_js\n node_js:\n-  - \"node\"\n-  - \"7\"\n+  - \"4\"\n   - \"6\"\n+  - \"8\"","path":".travis.yml","position":7,"original_position":7,"commit_id":"3fb79e9b4d8658778215e01afd644c311ef63b9d","original_commit_id":"aed0f11d59c30bcd9db8d6db3a566320b7f9558f","user":{"login":"JustinBeckwith","id":534619,"avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"body":"added","created_at":"2017-10-27T07:12:57Z","updated_at":"2017-10-27T07:12:57Z","html_url":"https://github.com/google/google-p12-pem/pull/9#discussion_r147337040","pull_request_url":"https://api.github.com/repos/google/google-p12-pem/pulls/9","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/google-p12-pem/pulls/comments/147337040"},"html":{"href":"https://github.com/google/google-p12-pem/pull/9#discussion_r147337040"},"pull_request":{"href":"https://api.github.com/repos/google/google-p12-pem/pulls/9"}},"in_reply_to_id":147324146},"pull_request":{"url":"https://api.github.com/repos/google/google-p12-pem/pulls/9","id":149098714,"html_url":"https://github.com/google/google-p12-pem/pull/9","diff_url":"https://github.com/google/google-p12-pem/pull/9.diff","patch_url":"https://github.com/google/google-p12-pem/pull/9.patch","issue_url":"https://api.github.com/repos/google/google-p12-pem/issues/9","number":9,"state":"open","locked":false,"title":"Switch to TypeScript, break the API a bit","user":{"login":"JustinBeckwith","id":534619,"avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"body":"A few things happening in here:\r\n\r\n1. Switched the project to TypeScript, including gts.  Module now has a d.ts. \r\n2. Broke the API a bit.  Removed the sync version because I can't be convinced it's actually a good idea.\r\n3. Removed the factory pattern from the constructor because it was confusing and not really needed.\r\n4. Added support for promise/async style, while keeping callbacks. \r\n\r\nAre folks ok with the changing the API? \r\nAlso, curious what I should do for a changelog here with the breaking changes. \r\n","created_at":"2017-10-27T04:28:13Z","updated_at":"2017-10-27T07:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"019cb3de8a226d27314632355c7b148d8c242706","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/google-p12-pem/pulls/9/commits","review_comments_url":"https://api.github.com/repos/google/google-p12-pem/pulls/9/comments","review_comment_url":"https://api.github.com/repos/google/google-p12-pem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/google-p12-pem/issues/9/comments","statuses_url":"https://api.github.com/repos/google/google-p12-pem/statuses/3fb79e9b4d8658778215e01afd644c311ef63b9d","head":{"label":"JustinBeckwith:master","ref":"master","sha":"3fb79e9b4d8658778215e01afd644c311ef63b9d","user":{"login":"JustinBeckwith","id":534619,"avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"repo":{"id":108026524,"name":"google-p12-pem","full_name":"JustinBeckwith/google-p12-pem","owner":{"login":"JustinBeckwith","id":534619,"avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JustinBeckwith/google-p12-pem","description":"Convert Google .p12 keys to .pem keys.","fork":true,"url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem","forks_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/forks","keys_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/teams","hooks_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/hooks","issue_events_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/issues/events{/number}","events_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/events","assignees_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/assignees{/user}","branches_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/branches{/branch}","tags_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/tags","blobs_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/git/refs{/sha}","trees_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/statuses/{sha}","languages_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/languages","stargazers_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/stargazers","contributors_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/contributors","subscribers_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/subscribers","subscription_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/subscription","commits_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/commits{/sha}","git_commits_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/git/commits{/sha}","comments_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/comments{/number}","issue_comment_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/issues/comments{/number}","contents_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/contents/{+path}","compare_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/merges","archive_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/downloads","issues_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/issues{/number}","pulls_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/pulls{/number}","milestones_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/milestones{/number}","notifications_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/labels{/name}","releases_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/releases{/id}","deployments_url":"https://api.github.com/repos/JustinBeckwith/google-p12-pem/deployments","created_at":"2017-10-23T19:01:44Z","updated_at":"2017-10-27T04:22:19Z","pushed_at":"2017-10-27T07:11:50Z","git_url":"git://github.com/JustinBeckwith/google-p12-pem.git","ssh_url":"git@github.com:JustinBeckwith/google-p12-pem.git","clone_url":"https://github.com/JustinBeckwith/google-p12-pem.git","svn_url":"https://github.com/JustinBeckwith/google-p12-pem","homepage":"","size":25,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"8b3deb716199c6be6616a2241dca2c7c755548e5","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":26307906,"name":"google-p12-pem","full_name":"google/google-p12-pem","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/google-p12-pem","description":"Convert Google .p12 keys to .pem keys.","fork":false,"url":"https://api.github.com/repos/google/google-p12-pem","forks_url":"https://api.github.com/repos/google/google-p12-pem/forks","keys_url":"https://api.github.com/repos/google/google-p12-pem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/google-p12-pem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/google-p12-pem/teams","hooks_url":"https://api.github.com/repos/google/google-p12-pem/hooks","issue_events_url":"https://api.github.com/repos/google/google-p12-pem/issues/events{/number}","events_url":"https://api.github.com/repos/google/google-p12-pem/events","assignees_url":"https://api.github.com/repos/google/google-p12-pem/assignees{/user}","branches_url":"https://api.github.com/repos/google/google-p12-pem/branches{/branch}","tags_url":"https://api.github.com/repos/google/google-p12-pem/tags","blobs_url":"https://api.github.com/repos/google/google-p12-pem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/google-p12-pem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/google-p12-pem/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/google-p12-pem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/google-p12-pem/statuses/{sha}","languages_url":"https://api.github.com/repos/google/google-p12-pem/languages","stargazers_url":"https://api.github.com/repos/google/google-p12-pem/stargazers","contributors_url":"https://api.github.com/repos/google/google-p12-pem/contributors","subscribers_url":"https://api.github.com/repos/google/google-p12-pem/subscribers","subscription_url":"https://api.github.com/repos/google/google-p12-pem/subscription","commits_url":"https://api.github.com/repos/google/google-p12-pem/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/google-p12-pem/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/google-p12-pem/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/google-p12-pem/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/google-p12-pem/contents/{+path}","compare_url":"https://api.github.com/repos/google/google-p12-pem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/google-p12-pem/merges","archive_url":"https://api.github.com/repos/google/google-p12-pem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/google-p12-pem/downloads","issues_url":"https://api.github.com/repos/google/google-p12-pem/issues{/number}","pulls_url":"https://api.github.com/repos/google/google-p12-pem/pulls{/number}","milestones_url":"https://api.github.com/repos/google/google-p12-pem/milestones{/number}","notifications_url":"https://api.github.com/repos/google/google-p12-pem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/google-p12-pem/labels{/name}","releases_url":"https://api.github.com/repos/google/google-p12-pem/releases{/id}","deployments_url":"https://api.github.com/repos/google/google-p12-pem/deployments","created_at":"2014-11-07T06:59:00Z","updated_at":"2017-08-08T08:27:48Z","pushed_at":"2017-10-27T07:11:51Z","git_url":"git://github.com/google/google-p12-pem.git","ssh_url":"git@github.com:google/google-p12-pem.git","clone_url":"https://github.com/google/google-p12-pem.git","svn_url":"https://github.com/google/google-p12-pem","homepage":"","size":11,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/google-p12-pem/pulls/9"},"html":{"href":"https://github.com/google/google-p12-pem/pull/9"},"issue":{"href":"https://api.github.com/repos/google/google-p12-pem/issues/9"},"comments":{"href":"https://api.github.com/repos/google/google-p12-pem/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/google/google-p12-pem/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/google/google-p12-pem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/google-p12-pem/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/google/google-p12-pem/statuses/3fb79e9b4d8658778215e01afd644c311ef63b9d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JustinBeckwith"}}