{"action":"created","comment":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/131312421","pull_request_review_id":54280577,"id":131312421,"diff_hunk":"@@ -280,6 +280,10 @@ int AudioEngineImpl::play2d(const std::string &filePath ,bool loop ,float volume\n                 {\n                     _audioPlayers.erase(id);\n                 }\n+                if (_urlAudioPlayersNeedResume.find(id) != _urlAudioPlayersNeedResume.end())\n+                {\n+                    _urlAudioPlayersNeedResume.erase(id);","path":"cocos/audio/android/AudioEngine-inl.cpp","position":27,"original_position":27,"commit_id":"3d8a2b7a8e90d4744f30d0ec1731be3c75f1c686","original_commit_id":"3d8a2b7a8e90d4744f30d0ec1731be3c75f1c686","user":{"login":"zoxin","id":13944060,"avatar_url":"https://avatars3.githubusercontent.com/u/13944060?v=4","gravatar_id":"","url":"https://api.github.com/users/zoxin","html_url":"https://github.com/zoxin","followers_url":"https://api.github.com/users/zoxin/followers","following_url":"https://api.github.com/users/zoxin/following{/other_user}","gists_url":"https://api.github.com/users/zoxin/gists{/gist_id}","starred_url":"https://api.github.com/users/zoxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoxin/subscriptions","organizations_url":"https://api.github.com/users/zoxin/orgs","repos_url":"https://api.github.com/users/zoxin/repos","events_url":"https://api.github.com/users/zoxin/events{/privacy}","received_events_url":"https://api.github.com/users/zoxin/received_events","type":"User","site_admin":false},"body":"YES","created_at":"2017-08-04T05:03:47Z","updated_at":"2017-08-04T05:03:47Z","html_url":"https://github.com/cocos2d/cocos2d-x/pull/18124#discussion_r131312421","pull_request_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18124","_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments/131312421"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/18124#discussion_r131312421"},"pull_request":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18124"}}},"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18124","id":134054673,"html_url":"https://github.com/cocos2d/cocos2d-x/pull/18124","diff_url":"https://github.com/cocos2d/cocos2d-x/pull/18124.diff","patch_url":"https://github.com/cocos2d/cocos2d-x/pull/18124.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18124","number":18124,"state":"open","locked":false,"title":"*fix android AudioEngine Crash","user":{"login":"zoxin","id":13944060,"avatar_url":"https://avatars3.githubusercontent.com/u/13944060?v=4","gravatar_id":"","url":"https://api.github.com/users/zoxin","html_url":"https://github.com/zoxin","followers_url":"https://api.github.com/users/zoxin/followers","following_url":"https://api.github.com/users/zoxin/following{/other_user}","gists_url":"https://api.github.com/users/zoxin/gists{/gist_id}","starred_url":"https://api.github.com/users/zoxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoxin/subscriptions","organizations_url":"https://api.github.com/users/zoxin/orgs","repos_url":"https://api.github.com/users/zoxin/repos","events_url":"https://api.github.com/users/zoxin/events{/privacy}","received_events_url":"https://api.github.com/users/zoxin/received_events","type":"User","site_admin":false},"body":"switch to background when sound effect is about to end, then switch to foreground again, there is a crash may be occurred","created_at":"2017-08-03T22:22:50Z","updated_at":"2017-08-04T05:03:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af124ad6f09db27c16ae35d6107e12dd1d49bea5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18124/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18124/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18124/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/3d8a2b7a8e90d4744f30d0ec1731be3c75f1c686","head":{"label":"zoxin:v3","ref":"v3","sha":"3d8a2b7a8e90d4744f30d0ec1731be3c75f1c686","user":{"login":"zoxin","id":13944060,"avatar_url":"https://avatars3.githubusercontent.com/u/13944060?v=4","gravatar_id":"","url":"https://api.github.com/users/zoxin","html_url":"https://github.com/zoxin","followers_url":"https://api.github.com/users/zoxin/followers","following_url":"https://api.github.com/users/zoxin/following{/other_user}","gists_url":"https://api.github.com/users/zoxin/gists{/gist_id}","starred_url":"https://api.github.com/users/zoxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoxin/subscriptions","organizations_url":"https://api.github.com/users/zoxin/orgs","repos_url":"https://api.github.com/users/zoxin/repos","events_url":"https://api.github.com/users/zoxin/events{/privacy}","received_events_url":"https://api.github.com/users/zoxin/received_events","type":"User","site_admin":false},"repo":{"id":99235395,"name":"cocos2d-x","full_name":"zoxin/cocos2d-x","owner":{"login":"zoxin","id":13944060,"avatar_url":"https://avatars3.githubusercontent.com/u/13944060?v=4","gravatar_id":"","url":"https://api.github.com/users/zoxin","html_url":"https://github.com/zoxin","followers_url":"https://api.github.com/users/zoxin/followers","following_url":"https://api.github.com/users/zoxin/following{/other_user}","gists_url":"https://api.github.com/users/zoxin/gists{/gist_id}","starred_url":"https://api.github.com/users/zoxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoxin/subscriptions","organizations_url":"https://api.github.com/users/zoxin/orgs","repos_url":"https://api.github.com/users/zoxin/repos","events_url":"https://api.github.com/users/zoxin/events{/privacy}","received_events_url":"https://api.github.com/users/zoxin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zoxin/cocos2d-x","description":"Cocos2d-x is a suite of open-source, cross-platform, game-development tools used by millions of developers all over the world.","fork":true,"url":"https://api.github.com/repos/zoxin/cocos2d-x","forks_url":"https://api.github.com/repos/zoxin/cocos2d-x/forks","keys_url":"https://api.github.com/repos/zoxin/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zoxin/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zoxin/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/zoxin/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/zoxin/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/zoxin/cocos2d-x/events","assignees_url":"https://api.github.com/repos/zoxin/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/zoxin/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/zoxin/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/zoxin/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zoxin/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zoxin/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/zoxin/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zoxin/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/zoxin/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/zoxin/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/zoxin/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/zoxin/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/zoxin/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/zoxin/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/zoxin/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/zoxin/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/zoxin/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/zoxin/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/zoxin/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zoxin/cocos2d-x/merges","archive_url":"https://api.github.com/repos/zoxin/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zoxin/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/zoxin/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/zoxin/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/zoxin/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/zoxin/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zoxin/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/zoxin/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/zoxin/cocos2d-x/deployments","created_at":"2017-08-03T13:27:16Z","updated_at":"2017-08-03T13:27:38Z","pushed_at":"2017-08-03T22:16:36Z","git_url":"git://github.com/zoxin/cocos2d-x.git","ssh_url":"git@github.com:zoxin/cocos2d-x.git","clone_url":"https://github.com/zoxin/cocos2d-x.git","svn_url":"https://github.com/zoxin/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":905116,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"4be6eb532567f747ec2ad62e84893123e236e9f4","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":1093228,"name":"cocos2d-x","full_name":"cocos2d/cocos2d-x","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x","description":"Cocos2d-x is a suite of open-source, cross-platform, game-development tools used by millions of developers all over the world.","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x/deployments","created_at":"2010-11-18T23:17:00Z","updated_at":"2017-08-04T03:01:07Z","pushed_at":"2017-08-03T22:22:51Z","git_url":"git://github.com/cocos2d/cocos2d-x.git","ssh_url":"git@github.com:cocos2d/cocos2d-x.git","clone_url":"https://github.com/cocos2d/cocos2d-x.git","svn_url":"https://github.com/cocos2d/cocos2d-x","homepage":"http://www.cocos2d-x.org","size":905111,"stargazers_count":10644,"watchers_count":10644,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6239,"mirror_url":null,"open_issues_count":1129,"forks":6239,"open_issues":1129,"watchers":10644,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18124"},"html":{"href":"https://github.com/cocos2d/cocos2d-x/pull/18124"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18124"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/issues/18124/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18124/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/pulls/18124/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x/statuses/3d8a2b7a8e90d4744f30d0ec1731be3c75f1c686"}}}}
{"actor":{"display_login":"zoxin"}}