{"action":"created","comment":{"url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/comments/143832362","pull_request_review_id":68403127,"id":143832362,"diff_hunk":"@@ -452,4 +452,40 @@ environment is a very serious security issue.\n A value of `true` will improve a portal administrator's experience, and a value\n of `false` can be considered during performance tuning, if needed.\n \n+---------------------------------------\n+\n+### Users can have numeric screen names with no limitations, and sites can no longer have numeric friendly URLs\n+- **Date:** 2017-Oct-10\n+- **JIRA Ticket:** LPS-66460\n+\n+#### What changed?\n+\n+- The portal property `users.screen.name.allow.numeric` now defaults to **true**\n+- Numeric screen names are no longer limited by whether or not they correspond to an existing group ID.\n+- Groups are no longer allowed to set their group ID as their friendly URL\n+- Groups can no longer be accessed by using their group ID in the URL (this used to be reconciled automatically, even if it wasn't set that way)\n+- If a group is updated and no friendly URL is provided, the default friendly URL is now `/group-<groupId>`. If that is a duplicate of another friendly URL, the friendly URL will be incremented until a unique URL is found (such as `/group-<groupId>-1`)\n+\n+#### Who is affected?\n+\n+- Anyone who has set the friendly URL of their site to the group ID\n+- Anyone who uses a group ID to navigate or direct to a site\n+\n+#### How should I update my code?\n+\n+No code updates should be required, but if you are in one of the scenarios from the \"Who is affected?\" section, you should consider the following changes:\n+\n+- If you have set the friendly URL of a site to its group ID, you must update the friendly URL of that site.  This can be done by the site administrator through the Site Settings portlet.\n+- If you have hard-coded the group ID in any links, you will need to change them to match the updated friendly URL.\n+\n+#### Why was this change made?\n+\n+There as been a common complaint from customers who used LDAP to import users: if the users were given a numeric screen name during import, some imports would fail because those screen names conflicted with an existing group ID.  ","path":"readme/7.1/BREAKING_CHANGES.markdown","position":73,"original_position":32,"commit_id":"5fb6fb5806932305e30f9e791bc27306f170eb9d","original_commit_id":"5fb6fb5806932305e30f9e791bc27306f170eb9d","user":{"login":"pei-jung","id":5168351,"avatar_url":"https://avatars2.githubusercontent.com/u/5168351?v=4","gravatar_id":"","url":"https://api.github.com/users/pei-jung","html_url":"https://github.com/pei-jung","followers_url":"https://api.github.com/users/pei-jung/followers","following_url":"https://api.github.com/users/pei-jung/following{/other_user}","gists_url":"https://api.github.com/users/pei-jung/gists{/gist_id}","starred_url":"https://api.github.com/users/pei-jung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pei-jung/subscriptions","organizations_url":"https://api.github.com/users/pei-jung/orgs","repos_url":"https://api.github.com/users/pei-jung/repos","events_url":"https://api.github.com/users/pei-jung/events{/privacy}","received_events_url":"https://api.github.com/users/pei-jung/received_events","type":"User","site_admin":false},"body":"There as -> There *has","created_at":"2017-10-10T19:44:47Z","updated_at":"2017-10-10T19:44:47Z","html_url":"https://github.com/pei-jung/liferay-portal/pull/212#discussion_r143832362","pull_request_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/212","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/comments/143832362"},"html":{"href":"https://github.com/pei-jung/liferay-portal/pull/212#discussion_r143832362"},"pull_request":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/212"}}},"pull_request":{"url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/212","id":145776178,"html_url":"https://github.com/pei-jung/liferay-portal/pull/212","diff_url":"https://github.com/pei-jung/liferay-portal/pull/212.diff","patch_url":"https://github.com/pei-jung/liferay-portal/pull/212.patch","issue_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues/212","number":212,"state":"open","locked":false,"title":"LPS-66460 Allow for numeric user screen names without any limitations","user":{"login":"drewbrokke","id":6403097,"avatar_url":"https://avatars1.githubusercontent.com/u/6403097?v=4","gravatar_id":"","url":"https://api.github.com/users/drewbrokke","html_url":"https://github.com/drewbrokke","followers_url":"https://api.github.com/users/drewbrokke/followers","following_url":"https://api.github.com/users/drewbrokke/following{/other_user}","gists_url":"https://api.github.com/users/drewbrokke/gists{/gist_id}","starred_url":"https://api.github.com/users/drewbrokke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewbrokke/subscriptions","organizations_url":"https://api.github.com/users/drewbrokke/orgs","repos_url":"https://api.github.com/users/drewbrokke/repos","events_url":"https://api.github.com/users/drewbrokke/events{/privacy}","received_events_url":"https://api.github.com/users/drewbrokke/received_events","type":"User","site_admin":false},"body":"This is an update for [LPS-66460](https://issues.liferay.com/browse/LPS-66460).","created_at":"2017-10-10T19:09:18Z","updated_at":"2017-10-10T19:44:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2fe3d4b3194a1329780508ad3deb03c603569df","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/212/commits","review_comments_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/212/comments","review_comment_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues/212/comments","statuses_url":"https://api.github.com/repos/pei-jung/liferay-portal/statuses/5fb6fb5806932305e30f9e791bc27306f170eb9d","head":{"label":"drewbrokke:LPS-66460-readme","ref":"LPS-66460-readme","sha":"5fb6fb5806932305e30f9e791bc27306f170eb9d","user":{"login":"drewbrokke","id":6403097,"avatar_url":"https://avatars1.githubusercontent.com/u/6403097?v=4","gravatar_id":"","url":"https://api.github.com/users/drewbrokke","html_url":"https://github.com/drewbrokke","followers_url":"https://api.github.com/users/drewbrokke/followers","following_url":"https://api.github.com/users/drewbrokke/following{/other_user}","gists_url":"https://api.github.com/users/drewbrokke/gists{/gist_id}","starred_url":"https://api.github.com/users/drewbrokke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewbrokke/subscriptions","organizations_url":"https://api.github.com/users/drewbrokke/orgs","repos_url":"https://api.github.com/users/drewbrokke/repos","events_url":"https://api.github.com/users/drewbrokke/events{/privacy}","received_events_url":"https://api.github.com/users/drewbrokke/received_events","type":"User","site_admin":false},"repo":{"id":15917856,"name":"liferay-portal","full_name":"drewbrokke/liferay-portal","owner":{"login":"drewbrokke","id":6403097,"avatar_url":"https://avatars1.githubusercontent.com/u/6403097?v=4","gravatar_id":"","url":"https://api.github.com/users/drewbrokke","html_url":"https://github.com/drewbrokke","followers_url":"https://api.github.com/users/drewbrokke/followers","following_url":"https://api.github.com/users/drewbrokke/following{/other_user}","gists_url":"https://api.github.com/users/drewbrokke/gists{/gist_id}","starred_url":"https://api.github.com/users/drewbrokke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewbrokke/subscriptions","organizations_url":"https://api.github.com/users/drewbrokke/orgs","repos_url":"https://api.github.com/users/drewbrokke/repos","events_url":"https://api.github.com/users/drewbrokke/events{/privacy}","received_events_url":"https://api.github.com/users/drewbrokke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drewbrokke/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/drewbrokke/liferay-portal","forks_url":"https://api.github.com/repos/drewbrokke/liferay-portal/forks","keys_url":"https://api.github.com/repos/drewbrokke/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drewbrokke/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drewbrokke/liferay-portal/teams","hooks_url":"https://api.github.com/repos/drewbrokke/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/drewbrokke/liferay-portal/events","assignees_url":"https://api.github.com/repos/drewbrokke/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/drewbrokke/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/drewbrokke/liferay-portal/tags","blobs_url":"https://api.github.com/repos/drewbrokke/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drewbrokke/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drewbrokke/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/drewbrokke/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drewbrokke/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/drewbrokke/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/drewbrokke/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/drewbrokke/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/drewbrokke/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/drewbrokke/liferay-portal/subscription","commits_url":"https://api.github.com/repos/drewbrokke/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/drewbrokke/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/drewbrokke/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/drewbrokke/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/drewbrokke/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drewbrokke/liferay-portal/merges","archive_url":"https://api.github.com/repos/drewbrokke/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drewbrokke/liferay-portal/downloads","issues_url":"https://api.github.com/repos/drewbrokke/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/drewbrokke/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/drewbrokke/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/drewbrokke/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drewbrokke/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/drewbrokke/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/drewbrokke/liferay-portal/deployments","created_at":"2014-01-14T22:35:49Z","updated_at":"2016-10-26T14:13:02Z","pushed_at":"2017-10-10T19:21:59Z","git_url":"git://github.com/drewbrokke/liferay-portal.git","ssh_url":"git@github.com:drewbrokke/liferay-portal.git","clone_url":"https://github.com/drewbrokke/liferay-portal.git","svn_url":"https://github.com/drewbrokke/liferay-portal","homepage":"http://liferay.com","size":12300035,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"pei-jung:master","ref":"master","sha":"e5a935fb4666973af962fb879b1173af4420dd5c","user":{"login":"pei-jung","id":5168351,"avatar_url":"https://avatars2.githubusercontent.com/u/5168351?v=4","gravatar_id":"","url":"https://api.github.com/users/pei-jung","html_url":"https://github.com/pei-jung","followers_url":"https://api.github.com/users/pei-jung/followers","following_url":"https://api.github.com/users/pei-jung/following{/other_user}","gists_url":"https://api.github.com/users/pei-jung/gists{/gist_id}","starred_url":"https://api.github.com/users/pei-jung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pei-jung/subscriptions","organizations_url":"https://api.github.com/users/pei-jung/orgs","repos_url":"https://api.github.com/users/pei-jung/repos","events_url":"https://api.github.com/users/pei-jung/events{/privacy}","received_events_url":"https://api.github.com/users/pei-jung/received_events","type":"User","site_admin":false},"repo":{"id":11906688,"name":"liferay-portal","full_name":"pei-jung/liferay-portal","owner":{"login":"pei-jung","id":5168351,"avatar_url":"https://avatars2.githubusercontent.com/u/5168351?v=4","gravatar_id":"","url":"https://api.github.com/users/pei-jung","html_url":"https://github.com/pei-jung","followers_url":"https://api.github.com/users/pei-jung/followers","following_url":"https://api.github.com/users/pei-jung/following{/other_user}","gists_url":"https://api.github.com/users/pei-jung/gists{/gist_id}","starred_url":"https://api.github.com/users/pei-jung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pei-jung/subscriptions","organizations_url":"https://api.github.com/users/pei-jung/orgs","repos_url":"https://api.github.com/users/pei-jung/repos","events_url":"https://api.github.com/users/pei-jung/events{/privacy}","received_events_url":"https://api.github.com/users/pei-jung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pei-jung/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/pei-jung/liferay-portal","forks_url":"https://api.github.com/repos/pei-jung/liferay-portal/forks","keys_url":"https://api.github.com/repos/pei-jung/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pei-jung/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pei-jung/liferay-portal/teams","hooks_url":"https://api.github.com/repos/pei-jung/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/pei-jung/liferay-portal/events","assignees_url":"https://api.github.com/repos/pei-jung/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/pei-jung/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/pei-jung/liferay-portal/tags","blobs_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pei-jung/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/pei-jung/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/pei-jung/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/pei-jung/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/pei-jung/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/pei-jung/liferay-portal/subscription","commits_url":"https://api.github.com/repos/pei-jung/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/pei-jung/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/pei-jung/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/pei-jung/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pei-jung/liferay-portal/merges","archive_url":"https://api.github.com/repos/pei-jung/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pei-jung/liferay-portal/downloads","issues_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/pei-jung/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/pei-jung/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pei-jung/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/pei-jung/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/pei-jung/liferay-portal/deployments","created_at":"2013-08-05T19:22:22Z","updated_at":"2015-05-05T22:03:42Z","pushed_at":"2017-10-10T19:09:20Z","git_url":"git://github.com/pei-jung/liferay-portal.git","ssh_url":"git@github.com:pei-jung/liferay-portal.git","clone_url":"https://github.com/pei-jung/liferay-portal.git","svn_url":"https://github.com/pei-jung/liferay-portal","homepage":"http://liferay.com","size":12223739,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/212"},"html":{"href":"https://github.com/pei-jung/liferay-portal/pull/212"},"issue":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/issues/212"},"comments":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/statuses/5fb6fb5806932305e30f9e791bc27306f170eb9d"}},"author_association":"NONE"}}
{"actor":{"display_login":"pei-jung"}}