{"action":"created","issue":{"url":"https://api.github.com/repos/parro-it/electron-localshortcut/issues/32","repository_url":"https://api.github.com/repos/parro-it/electron-localshortcut","labels_url":"https://api.github.com/repos/parro-it/electron-localshortcut/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/parro-it/electron-localshortcut/issues/32/comments","events_url":"https://api.github.com/repos/parro-it/electron-localshortcut/issues/32/events","html_url":"https://github.com/parro-it/electron-localshortcut/issues/32","id":239687011,"number":32,"title":"memory leakage after calling unregisterAll","user":{"login":"gehuangyi20","id":3879058,"avatar_url":"https://avatars1.githubusercontent.com/u/3879058?v=3","gravatar_id":"","url":"https://api.github.com/users/gehuangyi20","html_url":"https://github.com/gehuangyi20","followers_url":"https://api.github.com/users/gehuangyi20/followers","following_url":"https://api.github.com/users/gehuangyi20/following{/other_user}","gists_url":"https://api.github.com/users/gehuangyi20/gists{/gist_id}","starred_url":"https://api.github.com/users/gehuangyi20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gehuangyi20/subscriptions","organizations_url":"https://api.github.com/users/gehuangyi20/orgs","repos_url":"https://api.github.com/users/gehuangyi20/repos","events_url":"https://api.github.com/users/gehuangyi20/events{/privacy}","received_events_url":"https://api.github.com/users/gehuangyi20/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"parro-it","id":11197111,"avatar_url":"https://avatars1.githubusercontent.com/u/11197111?v=3","gravatar_id":"","url":"https://api.github.com/users/parro-it","html_url":"https://github.com/parro-it","followers_url":"https://api.github.com/users/parro-it/followers","following_url":"https://api.github.com/users/parro-it/following{/other_user}","gists_url":"https://api.github.com/users/parro-it/gists{/gist_id}","starred_url":"https://api.github.com/users/parro-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parro-it/subscriptions","organizations_url":"https://api.github.com/users/parro-it/orgs","repos_url":"https://api.github.com/users/parro-it/repos","events_url":"https://api.github.com/users/parro-it/events{/privacy}","received_events_url":"https://api.github.com/users/parro-it/received_events","type":"User","site_admin":false},"assignees":[{"login":"parro-it","id":11197111,"avatar_url":"https://avatars1.githubusercontent.com/u/11197111?v=3","gravatar_id":"","url":"https://api.github.com/users/parro-it","html_url":"https://github.com/parro-it","followers_url":"https://api.github.com/users/parro-it/followers","following_url":"https://api.github.com/users/parro-it/following{/other_user}","gists_url":"https://api.github.com/users/parro-it/gists{/gist_id}","starred_url":"https://api.github.com/users/parro-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parro-it/subscriptions","organizations_url":"https://api.github.com/users/parro-it/orgs","repos_url":"https://api.github.com/users/parro-it/repos","events_url":"https://api.github.com/users/parro-it/events{/privacy}","received_events_url":"https://api.github.com/users/parro-it/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-06-30T06:17:38Z","updated_at":"2017-07-02T17:11:27Z","closed_at":null,"body":"In the first time of calling `register()`, the following code `line 167-177` register the event for the window\r\n\r\n```javascript\r\nif (win !== ANY_WINDOW) {\r\n    win.on('close', _unregister('the window was closed.'));\r\n\r\n    win.on('hide', _unregister('the window was hidden.'));\r\n\r\n    win.on('minimize', _unregister('the window was minimized.'));\r\n\r\n    win.on('restore', _register('the window was restored from minimized state.'));\r\n\r\n    win.on('show', _register('the window was showed.'));\r\n}\r\n```\r\n\r\nHowever, these registered event are not freed after calling `unregisterAll`. This will cause memory leakage.\r\n"},"comment":{"url":"https://api.github.com/repos/parro-it/electron-localshortcut/issues/comments/312504277","html_url":"https://github.com/parro-it/electron-localshortcut/issues/32#issuecomment-312504277","issue_url":"https://api.github.com/repos/parro-it/electron-localshortcut/issues/32","id":312504277,"user":{"login":"parro-it","id":11197111,"avatar_url":"https://avatars1.githubusercontent.com/u/11197111?v=3","gravatar_id":"","url":"https://api.github.com/users/parro-it","html_url":"https://github.com/parro-it","followers_url":"https://api.github.com/users/parro-it/followers","following_url":"https://api.github.com/users/parro-it/following{/other_user}","gists_url":"https://api.github.com/users/parro-it/gists{/gist_id}","starred_url":"https://api.github.com/users/parro-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parro-it/subscriptions","organizations_url":"https://api.github.com/users/parro-it/orgs","repos_url":"https://api.github.com/users/parro-it/repos","events_url":"https://api.github.com/users/parro-it/events{/privacy}","received_events_url":"https://api.github.com/users/parro-it/received_events","type":"User","site_admin":false},"created_at":"2017-07-02T17:11:27Z","updated_at":"2017-07-02T17:11:27Z","body":"Good catch @gehuangyi20, thank you! Would you mind doing a PR to correct this?"}}
{"actor":{"display_login":"parro-it"}}