{"action":"created","issue":{"url":"https://api.github.com/repos/gfx-rs/gfx/issues/1622","repository_url":"https://api.github.com/repos/gfx-rs/gfx","labels_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1622/labels{/name}","comments_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1622/comments","events_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1622/events","html_url":"https://github.com/gfx-rs/gfx/pull/1622","id":271170874,"number":1622,"title":"Push constants!","user":{"login":"AlphaModder","id":2100733,"avatar_url":"https://avatars0.githubusercontent.com/u/2100733?v=4","gravatar_id":"","url":"https://api.github.com/users/AlphaModder","html_url":"https://github.com/AlphaModder","followers_url":"https://api.github.com/users/AlphaModder/followers","following_url":"https://api.github.com/users/AlphaModder/following{/other_user}","gists_url":"https://api.github.com/users/AlphaModder/gists{/gist_id}","starred_url":"https://api.github.com/users/AlphaModder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlphaModder/subscriptions","organizations_url":"https://api.github.com/users/AlphaModder/orgs","repos_url":"https://api.github.com/users/AlphaModder/repos","events_url":"https://api.github.com/users/AlphaModder/events{/privacy}","received_events_url":"https://api.github.com/users/AlphaModder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-11-04T06:31:42Z","updated_at":"2017-11-25T02:19:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1622","html_url":"https://github.com/gfx-rs/gfx/pull/1622","diff_url":"https://github.com/gfx-rs/gfx/pull/1622.diff","patch_url":"https://github.com/gfx-rs/gfx/pull/1622.patch"},"body":"This PR adds support for the use of push constants in shaders. \r\nIt consists of three public api additions/changes: an extra parameter to `Device::create_pipeline_layout`, and the addition of `push_graphics_constants` and `push_compute_constants` to appropriate command buffers.\r\n\r\nThese can be easily implemented on Vulkan and ~~DX12~~ (nevermind, we need shader reflection it seems), I will see about other backends before this is merged, hopefully."},"comment":{"url":"https://api.github.com/repos/gfx-rs/gfx/issues/comments/346913401","html_url":"https://github.com/gfx-rs/gfx/pull/1622#issuecomment-346913401","issue_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1622","id":346913401,"user":{"login":"bors[bot]","id":26634292,"avatar_url":"https://avatars3.githubusercontent.com/in/1847?v=4","gravatar_id":"","url":"https://api.github.com/users/bors%5Bbot%5D","html_url":"https://github.com/apps/bors","followers_url":"https://api.github.com/users/bors%5Bbot%5D/followers","following_url":"https://api.github.com/users/bors%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/bors%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/bors%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/bors%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/bors%5Bbot%5D/repos","events_url":"https://api.github.com/users/bors%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/bors%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-11-25T02:19:26Z","updated_at":"2017-11-25T02:19:26Z","author_association":"NONE","body":"# Build succeeded\n  * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/kvark/gfx/build/1.0.1961)\n  * [continuous-integration/travis-ci/push](https://travis-ci.org/gfx-rs/gfx/builds/306998545?utm_source=github_status&utm_medium=notification)"}}
{"actor":{"display_login":"bors"}}