{"action":"created","issue":{"url":"https://api.github.com/repos/zanata/zanata-platform/issues/224","repository_url":"https://api.github.com/repos/zanata/zanata-platform","labels_url":"https://api.github.com/repos/zanata/zanata-platform/issues/224/labels{/name}","comments_url":"https://api.github.com/repos/zanata/zanata-platform/issues/224/comments","events_url":"https://api.github.com/repos/zanata/zanata-platform/issues/224/events","html_url":"https://github.com/zanata/zanata-platform/pull/224","id":212505673,"number":224,"title":"Combine frontend builds ZNTA-1531","user":{"login":"davidmason","id":482026,"avatar_url":"https://avatars0.githubusercontent.com/u/482026?v=3","gravatar_id":"","url":"https://api.github.com/users/davidmason","html_url":"https://github.com/davidmason","followers_url":"https://api.github.com/users/davidmason/followers","following_url":"https://api.github.com/users/davidmason/following{/other_user}","gists_url":"https://api.github.com/users/davidmason/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmason/subscriptions","organizations_url":"https://api.github.com/users/davidmason/orgs","repos_url":"https://api.github.com/users/davidmason/repos","events_url":"https://api.github.com/users/davidmason/events{/privacy}","received_events_url":"https://api.github.com/users/davidmason/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-03-07T17:37:50Z","updated_at":"2017-03-08T04:30:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-platform/pulls/224","html_url":"https://github.com/zanata/zanata-platform/pull/224","diff_url":"https://github.com/zanata/zanata-platform/pull/224.diff","patch_url":"https://github.com/zanata/zanata-platform/pull/224.patch"},"body":"JIRA issue URL: https://zanata.atlassian.net/browse/ZNTA-1531\r\n\r\nMove the editor under the frontend npm project so they both share npm/yarn config and webpack build.\r\n\r\n## Testing notes\r\n\r\nMajor potential impacting changes are:\r\n\r\n* css and javascript bundle names changed for react editor, frontend and legacy pages (potential to point to wrong bundle name)\r\n* css and javascript bundle builds combined for frontend and react editor (potential for them to be bundled wrong)\r\n\r\nso I would think a check that editor, explore and one of the 'legacy' pages look right and can do a couple of their usual behaviours would prove we didn't mess it up. I think dashboard is a legacy page, so it would do.\r\n\r\n\r\n## Reviewer tasks\r\n\r\nThe following is based on the\r\n[Zanata Development Guidelines](https://github.com/zanata/zanata-platform/wiki/Development-Guidelines).\r\nAs a reviewer, you should check the guidelines regularly for updates, and just\r\nto refresh your memory.\r\n\r\n\r\nThe reviewer can use this list for reference to make sure\r\nthey have considered all the important points.\r\n\r\nUse the checkboxes or not, whatever works best for you.\r\n\r\n - Code quality\r\n   - [ ] Code passes style check (checkstyle/eslint)\r\n   - [ ] Code is clear and concise\r\n   - [ ] UI code is internationalised\r\n   - [ ] Code has adequate comments where appropriate\r\n   - Code is in an appropriate place\r\n     - [ ] Classes are in appropriate packages\r\n     - [ ] Code fits with class's responsibilities (SRP)\r\n   - [ ] Configuration files are documented enough\r\n   - If code is removed\r\n     - [ ] No remaining code references the removed code\r\n       - [ ] No orphaned rewrite rules\r\n       - [ ] No orphaned config settings\r\n     - [ ] No remaining comments refer to the removed code\r\n     - [ ] Unused imports and libraries are removed\r\n - Testing\r\n   - [ ] New code has tests\r\n   - [ ] Changed code has tests\r\n   - [ ] All tests pass\r\n   - [ ] Test coverage stable or increased\r\n - Documentation\r\n   - [ ] New features are documented\r\n   - [ ] Docs removed for deleted features\r\n   - [ ] Docs updated for all changed features\r\n   - [ ] Developer/sysadmin docs updated if appropriate\r\n - If there are new dependencies\r\n   - [ ] Does each new dependency pass all the\r\n         [Considerations for new dependencies](https://github.com/zanata/zanata-platform/wiki/Development-Guidelines#new-technologies-and-dependencies)?\r\n\r\n\r\n----\r\n*This template can be updated in .github/PULL_REQUEST_TEMPLATE.md*\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/zanata/zanata-platform/224)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/zanata/zanata-platform/issues/comments/284943904","html_url":"https://github.com/zanata/zanata-platform/pull/224#issuecomment-284943904","issue_url":"https://api.github.com/repos/zanata/zanata-platform/issues/224","id":284943904,"user":{"login":"kathryngo","id":18179401,"avatar_url":"https://avatars2.githubusercontent.com/u/18179401?v=3","gravatar_id":"","url":"https://api.github.com/users/kathryngo","html_url":"https://github.com/kathryngo","followers_url":"https://api.github.com/users/kathryngo/followers","following_url":"https://api.github.com/users/kathryngo/following{/other_user}","gists_url":"https://api.github.com/users/kathryngo/gists{/gist_id}","starred_url":"https://api.github.com/users/kathryngo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kathryngo/subscriptions","organizations_url":"https://api.github.com/users/kathryngo/orgs","repos_url":"https://api.github.com/users/kathryngo/repos","events_url":"https://api.github.com/users/kathryngo/events{/privacy}","received_events_url":"https://api.github.com/users/kathryngo/received_events","type":"User","site_admin":false},"created_at":"2017-03-08T04:30:34Z","updated_at":"2017-03-08T04:30:34Z","body":"@davidmason, resolved. Was on the wrong branch"}}
{"actor":{"display_login":"kathryngo"}}