{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/117068020","pull_request_review_id":38741239,"id":117068020,"diff_hunk":"@@ -34,26 +36,49 @@ import (\n \t\"google.golang.org/grpc/naming\"\n )\n \n-// Global flags that affect all log instances.\n-var (\n-\tserverHostFlag    = flag.String(\"host\", \"localhost\", \"Address to serve CT log requests on\")\n-\tserverPortFlag    = flag.Int(\"port\", 6962, \"Port to serve CT log requests on\")\n-\trpcBackendFlag    = flag.String(\"log_rpc_server\", \"localhost:8090\", \"Backend specification; comma-separated list or etcd service name (if --etcd_servers specified)\")\n-\trpcDeadlineFlag   = flag.Duration(\"rpc_deadline\", time.Second*10, \"Deadline for backend RPC requests\")\n-\tlogConfigFlag     = flag.String(\"log_config\", \"\", \"File holding log config in JSON\")\n-\tmaxGetEntriesFlag = flag.Int64(\"maxGetEntriesAllowed\", 0, \"Max number of entries we allow in a get-entries request (default 50)\")\n-\tetcdServers       = flag.String(\"etcd_servers\", \"\", \"A comma-separated list of etcd servers\")\n-)\n+type config struct {\n+\tHost                 string","path":"examples/ct/ct_server/main.go","position":29,"original_position":29,"commit_id":"04b4c901f2a1dcb705eb264bd496ac551e678432","original_commit_id":"04b4c901f2a1dcb705eb264bd496ac551e678432","user":{"login":"rolandshoemaker","id":5080674,"avatar_url":"https://avatars0.githubusercontent.com/u/5080674?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"body":"The Golang JSON package [requires that fields be public if you want to unmarshal into them](https://godoc.org/encoding/json#Unmarshal).","created_at":"2017-05-17T17:47:54Z","updated_at":"2017-05-17T17:47:54Z","html_url":"https://github.com/google/trillian/pull/620#discussion_r117068020","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/620","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/117068020"},"html":{"href":"https://github.com/google/trillian/pull/620#discussion_r117068020"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/620","id":120960490,"html_url":"https://github.com/google/trillian/pull/620","diff_url":"https://github.com/google/trillian/pull/620.diff","patch_url":"https://github.com/google/trillian/pull/620.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/620","number":620,"state":"open","locked":false,"title":"Allow flag or file based configuration","user":{"login":"rolandshoemaker","id":5080674,"avatar_url":"https://avatars0.githubusercontent.com/u/5080674?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"body":"Initial implementation, slightly less hacky than I originally anticipated.\r\n\r\nFixes #578.","created_at":"2017-05-17T01:56:08Z","updated_at":"2017-05-17T17:47:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e39d2aff31d416e707401b3f7f3289912b2a68d7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/620/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/620/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/620/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/04b4c901f2a1dcb705eb264bd496ac551e678432","head":{"label":"rolandshoemaker:conf-files","ref":"conf-files","sha":"04b4c901f2a1dcb705eb264bd496ac551e678432","user":{"login":"rolandshoemaker","id":5080674,"avatar_url":"https://avatars0.githubusercontent.com/u/5080674?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"repo":{"id":76605770,"name":"trillian","full_name":"rolandshoemaker/trillian","owner":{"login":"rolandshoemaker","id":5080674,"avatar_url":"https://avatars0.githubusercontent.com/u/5080674?v=3","gravatar_id":"","url":"https://api.github.com/users/rolandshoemaker","html_url":"https://github.com/rolandshoemaker","followers_url":"https://api.github.com/users/rolandshoemaker/followers","following_url":"https://api.github.com/users/rolandshoemaker/following{/other_user}","gists_url":"https://api.github.com/users/rolandshoemaker/gists{/gist_id}","starred_url":"https://api.github.com/users/rolandshoemaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rolandshoemaker/subscriptions","organizations_url":"https://api.github.com/users/rolandshoemaker/orgs","repos_url":"https://api.github.com/users/rolandshoemaker/repos","events_url":"https://api.github.com/users/rolandshoemaker/events{/privacy}","received_events_url":"https://api.github.com/users/rolandshoemaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rolandshoemaker/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/rolandshoemaker/trillian","forks_url":"https://api.github.com/repos/rolandshoemaker/trillian/forks","keys_url":"https://api.github.com/repos/rolandshoemaker/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rolandshoemaker/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rolandshoemaker/trillian/teams","hooks_url":"https://api.github.com/repos/rolandshoemaker/trillian/hooks","issue_events_url":"https://api.github.com/repos/rolandshoemaker/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/rolandshoemaker/trillian/events","assignees_url":"https://api.github.com/repos/rolandshoemaker/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/rolandshoemaker/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/rolandshoemaker/trillian/tags","blobs_url":"https://api.github.com/repos/rolandshoemaker/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rolandshoemaker/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rolandshoemaker/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/rolandshoemaker/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rolandshoemaker/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/rolandshoemaker/trillian/languages","stargazers_url":"https://api.github.com/repos/rolandshoemaker/trillian/stargazers","contributors_url":"https://api.github.com/repos/rolandshoemaker/trillian/contributors","subscribers_url":"https://api.github.com/repos/rolandshoemaker/trillian/subscribers","subscription_url":"https://api.github.com/repos/rolandshoemaker/trillian/subscription","commits_url":"https://api.github.com/repos/rolandshoemaker/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/rolandshoemaker/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/rolandshoemaker/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/rolandshoemaker/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/rolandshoemaker/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/rolandshoemaker/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rolandshoemaker/trillian/merges","archive_url":"https://api.github.com/repos/rolandshoemaker/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rolandshoemaker/trillian/downloads","issues_url":"https://api.github.com/repos/rolandshoemaker/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/rolandshoemaker/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/rolandshoemaker/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/rolandshoemaker/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rolandshoemaker/trillian/labels{/name}","releases_url":"https://api.github.com/repos/rolandshoemaker/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/rolandshoemaker/trillian/deployments","created_at":"2016-12-15T23:58:52Z","updated_at":"2016-12-15T23:58:54Z","pushed_at":"2017-05-17T01:39:56Z","git_url":"git://github.com/rolandshoemaker/trillian.git","ssh_url":"git@github.com:rolandshoemaker/trillian.git","clone_url":"https://github.com/rolandshoemaker/trillian.git","svn_url":"https://github.com/rolandshoemaker/trillian","homepage":null,"size":6401,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"997c926b7f7e1187c7194e1a78c63e8d60fe12fd","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":"Trillian implements a Merkle tree whose contents are served from a data storage layer, to allow scalability to extremely large trees.","fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2017-05-17T02:49:55Z","pushed_at":"2017-05-17T02:47:36Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":"","size":6377,"stargazers_count":363,"watchers_count":363,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":49,"forks":61,"open_issues":49,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/620"},"html":{"href":"https://github.com/google/trillian/pull/620"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/620"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/04b4c901f2a1dcb705eb264bd496ac551e678432"}}}}
{"actor":{"display_login":"rolandshoemaker"}}