{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/21655","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/21655/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/21655/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/21655/events","html_url":"https://github.com/Microsoft/vscode/issues/21655","id":211219548,"number":21655,"title":"PATH issues are back","user":{"login":"NinoFloris","id":4218809,"avatar_url":"https://avatars3.githubusercontent.com/u/4218809?v=3","gravatar_id":"","url":"https://api.github.com/users/NinoFloris","html_url":"https://github.com/NinoFloris","followers_url":"https://api.github.com/users/NinoFloris/followers","following_url":"https://api.github.com/users/NinoFloris/following{/other_user}","gists_url":"https://api.github.com/users/NinoFloris/gists{/gist_id}","starred_url":"https://api.github.com/users/NinoFloris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NinoFloris/subscriptions","organizations_url":"https://api.github.com/users/NinoFloris/orgs","repos_url":"https://api.github.com/users/NinoFloris/repos","events_url":"https://api.github.com/users/NinoFloris/events{/privacy}","received_events_url":"https://api.github.com/users/NinoFloris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-01T21:51:50Z","updated_at":"2017-03-02T02:44:45Z","closed_at":null,"body":"So while having a problem PATH related I created an issue in the omnisharp vscode repo about this. However right after doing a quick `chsh /bin/bash` and a restart of vscode my suspicions were right and now I'm coming back to you guys.\r\n\r\nThe issue in omnisharp vscode: \r\nhttps://github.com/OmniSharp/omnisharp-vscode/issues/1259\r\n\r\nPrevious fix I'm pointing to:\r\nhttps://github.com/Microsoft/vscode/issues/8434\r\n\r\nSeems that somehow this fix regressed again. Or my shell does even more effort to break it...\r\n\r\nI'm still using fish with powerline as my shell and it seems to break the env (and in turn PATH) parsing again.\r\n\r\nI propose a change to the PATH resolution strategy for OSX:\r\n\r\n- Run `path_helper` for an initial view of an ok customizable PATH of an OSX installation. It gathers all paths from the file `/etc/paths` and paths in files in `/etc/paths.d` like the one for `dotnet`. It outputs a PATH string of these paths.\r\n- Do the hacky thing with reading out a login shell's env and parsing the PATH from it.\r\n- Use the hacky output if there is actually any. Every login shell runs `path_helper` but also includes all user customizations to PATH from say .bash_profile. \r\n- If the shell is so custom it breaks the hacky way of fishing out the PATH then just use the `path_helper` output.\r\n\r\nThis way the result will at least always be a working env (for say quite integrated things like spawning a `dotnet` process for doing a restore).\r\nBecause everyone should be able to expect that after installing a pkg like the dotnet cli vscode (and its extensions) can always find and work with it seamlessly.\r\n\r\n```\r\ndotnet --info output:\r\n.NET Command Line Tools (1.0.0-rc4-004849)\r\n\r\nProduct Information:\r\nVersion: 1.0.0-rc4-004849\r\nCommit SHA-1 hash: 7dcefb5076\r\n\r\nRuntime Environment:\r\nOS Name: Mac OS X\r\nOS Version: 10.12\r\nOS Platform: Darwin\r\nRID: osx.10.12-x64\r\nBase Path: /usr/local/share/dotnet/sdk/1.0.0-rc4-004849\r\nVS Code version: 1.10.0-insider\r\nC# Extension version: 1.7.0\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/283539777","html_url":"https://github.com/Microsoft/vscode/issues/21655#issuecomment-283539777","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/21655","id":283539777,"user":{"login":"gregg-miskelly","id":11078489,"avatar_url":"https://avatars3.githubusercontent.com/u/11078489?v=3","gravatar_id":"","url":"https://api.github.com/users/gregg-miskelly","html_url":"https://github.com/gregg-miskelly","followers_url":"https://api.github.com/users/gregg-miskelly/followers","following_url":"https://api.github.com/users/gregg-miskelly/following{/other_user}","gists_url":"https://api.github.com/users/gregg-miskelly/gists{/gist_id}","starred_url":"https://api.github.com/users/gregg-miskelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregg-miskelly/subscriptions","organizations_url":"https://api.github.com/users/gregg-miskelly/orgs","repos_url":"https://api.github.com/users/gregg-miskelly/repos","events_url":"https://api.github.com/users/gregg-miskelly/events{/privacy}","received_events_url":"https://api.github.com/users/gregg-miskelly/received_events","type":"User","site_admin":false},"created_at":"2017-03-02T02:44:45Z","updated_at":"2017-03-02T02:44:45Z","body":"@weinand @joaomoreno would I be correct in assuming that if VS Code fixes this issue, the extra environment settings will automatically propagate to the C# extension processes?"}}
{"actor":{"display_login":"gregg-miskelly"}}