{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/18562","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/18562/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/18562/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/18562/events","html_url":"https://github.com/cockroachdb/cockroach/pull/18562","id":258599524,"number":18562,"title":"cherrypick: build,sql,cli: reveal the CockroachDB version number","user":{"login":"knz","id":642886,"avatar_url":"https://avatars3.githubusercontent.com/u/642886?v=4","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-18T19:48:05Z","updated_at":"2017-09-18T19:59:17Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/18562","html_url":"https://github.com/cockroachdb/cockroach/pull/18562","diff_url":"https://github.com/cockroachdb/cockroach/pull/18562.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/18562.patch"},"body":"Previous to this patch, the vtable `crdb_internal.node_build_info`,\r\nthe built-in SQL function `version()` and the command-line utilities\r\nwould only print the build tag as a version number.\r\n\r\nThis patch augments this display by prefixing it by the\r\n`VersionPrefix()`, computed after the current branch.\r\n\r\nBefore:\r\n\r\n```\r\nCockroachDB CCL 9fcb2f35e (freebsd amd64, built 2017/09/18 18:27:19, go1.9)\r\n```\r\n\r\nAfter:\r\n\r\n```\r\nCockroachDB CCL v1.1-9fcb2f35e (freebsd amd64, built 2017/09/18 18:27:19, go1.9)\r\n```\r\n\r\ncc @cockroachdb/release "},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/330338635","html_url":"https://github.com/cockroachdb/cockroach/pull/18562#issuecomment-330338635","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/18562","id":330338635,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars1.githubusercontent.com/u/160562?v=4","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2017-09-18T19:59:17Z","updated_at":"2017-09-18T19:59:17Z","author_association":"OWNER","body":"\n\n\n\nReview status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.\n\n---\n\n*[pkg/build/info.go, line 81 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/18562#-KuLYzh8BKOENYXkVluy:-KuLYzh8BKOENYXkVluz:b-26g3dv) ([raw file](https://github.com/cockroachdb/cockroach/blob/b7e450ca5967e59be594fc0d73705623fe421a22/pkg/build/info.go#L81)):*\n> ```Go\n> // VersionedTag prefixes the tag with VersionPrefix.\n> func (b Info) VersionedTag() string {\n> \treturn VersionPrefix() + \"-\" + b.Tag\n> ```\n\nI don't think this is going to the right thing for release builds. In those builds, `b.Tag` is a tag and looks like `v1.0.6`, not a commit hash. \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/18562)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"bdarnell"}}