{"action":"created","comment":{"url":"https://api.github.com/repos/saroad2/units/pulls/comments/148781705","pull_request_review_id":74079035,"id":148781705,"diff_hunk":"@@ -0,0 +1,30 @@\n+/*\n+ * planetary_rotations.h\n+ *\n+ *  Created on: Nov 3, 2017\n+ *      Author: oriash93\n+ */\n+\n+#ifndef SRC_UNITS_HEADERS_UNITS_CONSTANTS_PLANETARY_ROTATIONS_H_\n+#define SRC_UNITS_HEADERS_UNITS_CONSTANTS_PLANETARY_ROTATIONS_H_\n+\n+#include <units/duration.h>\n+\n+namespace units {\n+namespace planetary_rotations\n+{\n+\n+constexpr duration::Seconds sunRotationPeriod{2192831.6};\n+constexpr duration::Seconds mercuryRotationPeriod{5067030};\n+constexpr duration::Seconds venusRotationPeriod{-20996760};","path":"units_cpp/src/units/headers/units/constants/planetary_rotations.h","position":19,"original_position":19,"commit_id":"edc66ef30c0db2e336411c8b99113265274ac325","original_commit_id":"edc66ef30c0db2e336411c8b99113265274ac325","user":{"login":"saroad2","id":19425795,"avatar_url":"https://avatars0.githubusercontent.com/u/19425795?v=4","gravatar_id":"","url":"https://api.github.com/users/saroad2","html_url":"https://github.com/saroad2","followers_url":"https://api.github.com/users/saroad2/followers","following_url":"https://api.github.com/users/saroad2/following{/other_user}","gists_url":"https://api.github.com/users/saroad2/gists{/gist_id}","starred_url":"https://api.github.com/users/saroad2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saroad2/subscriptions","organizations_url":"https://api.github.com/users/saroad2/orgs","repos_url":"https://api.github.com/users/saroad2/repos","events_url":"https://api.github.com/users/saroad2/events{/privacy}","received_events_url":"https://api.github.com/users/saroad2/received_events","type":"User","site_admin":false},"body":"Cool! didn't know that.\r\n\r\nthen it's ok :+1: ","created_at":"2017-11-03T13:32:33Z","updated_at":"2017-11-03T13:32:33Z","html_url":"https://github.com/saroad2/units/pull/62#discussion_r148781705","pull_request_url":"https://api.github.com/repos/saroad2/units/pulls/62","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/saroad2/units/pulls/comments/148781705"},"html":{"href":"https://github.com/saroad2/units/pull/62#discussion_r148781705"},"pull_request":{"href":"https://api.github.com/repos/saroad2/units/pulls/62"}},"in_reply_to_id":148775404},"pull_request":{"url":"https://api.github.com/repos/saroad2/units/pulls/62","id":150490761,"html_url":"https://github.com/saroad2/units/pull/62","diff_url":"https://github.com/saroad2/units/pull/62.diff","patch_url":"https://github.com/saroad2/units/pull/62.patch","issue_url":"https://api.github.com/repos/saroad2/units/issues/62","number":62,"state":"open","locked":false,"title":"Units_Cpp - add earth rotation MANUALLY","user":{"login":"oriash93","id":14019835,"avatar_url":"https://avatars0.githubusercontent.com/u/14019835?v=4","gravatar_id":"","url":"https://api.github.com/users/oriash93","html_url":"https://github.com/oriash93","followers_url":"https://api.github.com/users/oriash93/followers","following_url":"https://api.github.com/users/oriash93/following{/other_user}","gists_url":"https://api.github.com/users/oriash93/gists{/gist_id}","starred_url":"https://api.github.com/users/oriash93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriash93/subscriptions","organizations_url":"https://api.github.com/users/oriash93/orgs","repos_url":"https://api.github.com/users/oriash93/repos","events_url":"https://api.github.com/users/oriash93/events{/privacy}","received_events_url":"https://api.github.com/users/oriash93/received_events","type":"User","site_admin":false},"body":"later, we'll generate this constant\r\n\r\nrelated to #21","created_at":"2017-11-03T10:10:33Z","updated_at":"2017-11-03T13:32:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"768ecb758f8fd7f5a8d384de6703feb63a7449a9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/saroad2/units/pulls/62/commits","review_comments_url":"https://api.github.com/repos/saroad2/units/pulls/62/comments","review_comment_url":"https://api.github.com/repos/saroad2/units/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saroad2/units/issues/62/comments","statuses_url":"https://api.github.com/repos/saroad2/units/statuses/edc66ef30c0db2e336411c8b99113265274ac325","head":{"label":"oriash93:master","ref":"master","sha":"edc66ef30c0db2e336411c8b99113265274ac325","user":{"login":"oriash93","id":14019835,"avatar_url":"https://avatars0.githubusercontent.com/u/14019835?v=4","gravatar_id":"","url":"https://api.github.com/users/oriash93","html_url":"https://github.com/oriash93","followers_url":"https://api.github.com/users/oriash93/followers","following_url":"https://api.github.com/users/oriash93/following{/other_user}","gists_url":"https://api.github.com/users/oriash93/gists{/gist_id}","starred_url":"https://api.github.com/users/oriash93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriash93/subscriptions","organizations_url":"https://api.github.com/users/oriash93/orgs","repos_url":"https://api.github.com/users/oriash93/repos","events_url":"https://api.github.com/users/oriash93/events{/privacy}","received_events_url":"https://api.github.com/users/oriash93/received_events","type":"User","site_admin":false},"repo":{"id":106969813,"name":"units","full_name":"oriash93/units","owner":{"login":"oriash93","id":14019835,"avatar_url":"https://avatars0.githubusercontent.com/u/14019835?v=4","gravatar_id":"","url":"https://api.github.com/users/oriash93","html_url":"https://github.com/oriash93","followers_url":"https://api.github.com/users/oriash93/followers","following_url":"https://api.github.com/users/oriash93/following{/other_user}","gists_url":"https://api.github.com/users/oriash93/gists{/gist_id}","starred_url":"https://api.github.com/users/oriash93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oriash93/subscriptions","organizations_url":"https://api.github.com/users/oriash93/orgs","repos_url":"https://api.github.com/users/oriash93/repos","events_url":"https://api.github.com/users/oriash93/events{/privacy}","received_events_url":"https://api.github.com/users/oriash93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oriash93/units","description":"libraries for units conversions.","fork":true,"url":"https://api.github.com/repos/oriash93/units","forks_url":"https://api.github.com/repos/oriash93/units/forks","keys_url":"https://api.github.com/repos/oriash93/units/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oriash93/units/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oriash93/units/teams","hooks_url":"https://api.github.com/repos/oriash93/units/hooks","issue_events_url":"https://api.github.com/repos/oriash93/units/issues/events{/number}","events_url":"https://api.github.com/repos/oriash93/units/events","assignees_url":"https://api.github.com/repos/oriash93/units/assignees{/user}","branches_url":"https://api.github.com/repos/oriash93/units/branches{/branch}","tags_url":"https://api.github.com/repos/oriash93/units/tags","blobs_url":"https://api.github.com/repos/oriash93/units/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oriash93/units/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oriash93/units/git/refs{/sha}","trees_url":"https://api.github.com/repos/oriash93/units/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oriash93/units/statuses/{sha}","languages_url":"https://api.github.com/repos/oriash93/units/languages","stargazers_url":"https://api.github.com/repos/oriash93/units/stargazers","contributors_url":"https://api.github.com/repos/oriash93/units/contributors","subscribers_url":"https://api.github.com/repos/oriash93/units/subscribers","subscription_url":"https://api.github.com/repos/oriash93/units/subscription","commits_url":"https://api.github.com/repos/oriash93/units/commits{/sha}","git_commits_url":"https://api.github.com/repos/oriash93/units/git/commits{/sha}","comments_url":"https://api.github.com/repos/oriash93/units/comments{/number}","issue_comment_url":"https://api.github.com/repos/oriash93/units/issues/comments{/number}","contents_url":"https://api.github.com/repos/oriash93/units/contents/{+path}","compare_url":"https://api.github.com/repos/oriash93/units/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oriash93/units/merges","archive_url":"https://api.github.com/repos/oriash93/units/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oriash93/units/downloads","issues_url":"https://api.github.com/repos/oriash93/units/issues{/number}","pulls_url":"https://api.github.com/repos/oriash93/units/pulls{/number}","milestones_url":"https://api.github.com/repos/oriash93/units/milestones{/number}","notifications_url":"https://api.github.com/repos/oriash93/units/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oriash93/units/labels{/name}","releases_url":"https://api.github.com/repos/oriash93/units/releases{/id}","deployments_url":"https://api.github.com/repos/oriash93/units/deployments","created_at":"2017-10-14T23:20:38Z","updated_at":"2017-10-18T18:02:31Z","pushed_at":"2017-11-03T11:18:32Z","git_url":"git://github.com/oriash93/units.git","ssh_url":"git@github.com:oriash93/units.git","clone_url":"https://github.com/oriash93/units.git","svn_url":"https://github.com/oriash93/units","homepage":"","size":1130,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"saroad2:master","ref":"master","sha":"1b17430f3902066208d8285430c6240498e80ce2","user":{"login":"saroad2","id":19425795,"avatar_url":"https://avatars0.githubusercontent.com/u/19425795?v=4","gravatar_id":"","url":"https://api.github.com/users/saroad2","html_url":"https://github.com/saroad2","followers_url":"https://api.github.com/users/saroad2/followers","following_url":"https://api.github.com/users/saroad2/following{/other_user}","gists_url":"https://api.github.com/users/saroad2/gists{/gist_id}","starred_url":"https://api.github.com/users/saroad2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saroad2/subscriptions","organizations_url":"https://api.github.com/users/saroad2/orgs","repos_url":"https://api.github.com/users/saroad2/repos","events_url":"https://api.github.com/users/saroad2/events{/privacy}","received_events_url":"https://api.github.com/users/saroad2/received_events","type":"User","site_admin":false},"repo":{"id":94519070,"name":"units","full_name":"saroad2/units","owner":{"login":"saroad2","id":19425795,"avatar_url":"https://avatars0.githubusercontent.com/u/19425795?v=4","gravatar_id":"","url":"https://api.github.com/users/saroad2","html_url":"https://github.com/saroad2","followers_url":"https://api.github.com/users/saroad2/followers","following_url":"https://api.github.com/users/saroad2/following{/other_user}","gists_url":"https://api.github.com/users/saroad2/gists{/gist_id}","starred_url":"https://api.github.com/users/saroad2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saroad2/subscriptions","organizations_url":"https://api.github.com/users/saroad2/orgs","repos_url":"https://api.github.com/users/saroad2/repos","events_url":"https://api.github.com/users/saroad2/events{/privacy}","received_events_url":"https://api.github.com/users/saroad2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saroad2/units","description":"libraries for units conversions.","fork":false,"url":"https://api.github.com/repos/saroad2/units","forks_url":"https://api.github.com/repos/saroad2/units/forks","keys_url":"https://api.github.com/repos/saroad2/units/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saroad2/units/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saroad2/units/teams","hooks_url":"https://api.github.com/repos/saroad2/units/hooks","issue_events_url":"https://api.github.com/repos/saroad2/units/issues/events{/number}","events_url":"https://api.github.com/repos/saroad2/units/events","assignees_url":"https://api.github.com/repos/saroad2/units/assignees{/user}","branches_url":"https://api.github.com/repos/saroad2/units/branches{/branch}","tags_url":"https://api.github.com/repos/saroad2/units/tags","blobs_url":"https://api.github.com/repos/saroad2/units/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saroad2/units/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saroad2/units/git/refs{/sha}","trees_url":"https://api.github.com/repos/saroad2/units/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saroad2/units/statuses/{sha}","languages_url":"https://api.github.com/repos/saroad2/units/languages","stargazers_url":"https://api.github.com/repos/saroad2/units/stargazers","contributors_url":"https://api.github.com/repos/saroad2/units/contributors","subscribers_url":"https://api.github.com/repos/saroad2/units/subscribers","subscription_url":"https://api.github.com/repos/saroad2/units/subscription","commits_url":"https://api.github.com/repos/saroad2/units/commits{/sha}","git_commits_url":"https://api.github.com/repos/saroad2/units/git/commits{/sha}","comments_url":"https://api.github.com/repos/saroad2/units/comments{/number}","issue_comment_url":"https://api.github.com/repos/saroad2/units/issues/comments{/number}","contents_url":"https://api.github.com/repos/saroad2/units/contents/{+path}","compare_url":"https://api.github.com/repos/saroad2/units/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saroad2/units/merges","archive_url":"https://api.github.com/repos/saroad2/units/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saroad2/units/downloads","issues_url":"https://api.github.com/repos/saroad2/units/issues{/number}","pulls_url":"https://api.github.com/repos/saroad2/units/pulls{/number}","milestones_url":"https://api.github.com/repos/saroad2/units/milestones{/number}","notifications_url":"https://api.github.com/repos/saroad2/units/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saroad2/units/labels{/name}","releases_url":"https://api.github.com/repos/saroad2/units/releases{/id}","deployments_url":"https://api.github.com/repos/saroad2/units/deployments","created_at":"2017-06-16T07:45:19Z","updated_at":"2017-10-27T04:10:03Z","pushed_at":"2017-11-03T11:18:34Z","git_url":"git://github.com/saroad2/units.git","ssh_url":"git@github.com:saroad2/units.git","clone_url":"https://github.com/saroad2/units.git","svn_url":"https://github.com/saroad2/units","homepage":"","size":1129,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/saroad2/units/pulls/62"},"html":{"href":"https://github.com/saroad2/units/pull/62"},"issue":{"href":"https://api.github.com/repos/saroad2/units/issues/62"},"comments":{"href":"https://api.github.com/repos/saroad2/units/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/saroad2/units/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/saroad2/units/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saroad2/units/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/saroad2/units/statuses/edc66ef30c0db2e336411c8b99113265274ac325"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"saroad2"}}