{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/16438","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/16438/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/16438/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/16438/events","html_url":"https://github.com/openshift/origin/pull/16438","id":258908489,"number":16438,"title":"Prevent `oc rollout` panic when resource given is not a dc","user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"labels":[{"id":640548301,"url":"https://api.github.com/repos/openshift/origin/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"assignees":[{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-09-19T17:52:50Z","updated_at":"2017-10-12T20:02:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/16438","html_url":"https://github.com/openshift/origin/pull/16438","diff_url":"https://github.com/openshift/origin/pull/16438.diff","patch_url":"https://github.com/openshift/origin/pull/16438.patch"},"body":"Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1493071\r\n\r\nPrevents nil pointer dereference by skipping command logic\r\nwhen given resource is not of type *deployapi.DeploymentConfig.\r\n\r\n**Before**\r\n```\r\n$ oc rollout cancel rc/my-rc-1\r\npanic: runtime error: invalid memory address or nil pointer dereference\r\n[signal SIGSEGV: segmentation violation code=0x1 addr=0x189 pc=0x3821780]\r\n...\r\n```\r\n\r\n**After**\r\n```\r\n$ oc rollout cancel rc/my-rc-1\r\nerror: expected deployment configuration, got *api.ReplicationController\r\n```\r\n\r\ncc @openshift/cli-review "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/336249841","html_url":"https://github.com/openshift/origin/pull/16438#issuecomment-336249841","issue_url":"https://api.github.com/repos/openshift/origin/issues/16438","id":336249841,"user":{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},"created_at":"2017-10-12T20:02:49Z","updated_at":"2017-10-12T20:02:49Z","author_association":"MEMBER","body":"@mfojtik thanks for the feedback, review comments addressed"}}
{"actor":{"display_login":"juanvallejo"}}