{"action":"created","comment":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/110089837","pull_request_review_id":31235379,"id":110089837,"diff_hunk":"@@ -322,9 +329,19 @@ jerry_value_t jerry_get_object_keys (const jerry_value_t obj_val);\n jerry_value_t jerry_get_prototype (const jerry_value_t obj_val);\n jerry_value_t jerry_set_prototype (const jerry_value_t obj_val, const jerry_value_t proto_obj_val);\n \n+__attribute__((deprecated))\n bool jerry_get_object_native_handle (const jerry_value_t obj_val, uintptr_t *out_handle_p);\n+__attribute__((deprecated))\n void jerry_set_object_native_handle (const jerry_value_t obj_val, uintptr_t handle_p,\n                                      jerry_object_free_callback_t freecb_p);\n+\n+bool jerry_get_object_native_handle_ext (const jerry_value_t obj_val,","path":"jerry-core/jerryscript.h","position":24,"original_position":24,"commit_id":"7753bcc6fa1220e738d9241bed8ca008404596b8","original_commit_id":"7753bcc6fa1220e738d9241bed8ca008404596b8","user":{"login":"zherczeg","id":2270193,"avatar_url":"https://avatars1.githubusercontent.com/u/2270193?v=3","gravatar_id":"","url":"https://api.github.com/users/zherczeg","html_url":"https://github.com/zherczeg","followers_url":"https://api.github.com/users/zherczeg/followers","following_url":"https://api.github.com/users/zherczeg/following{/other_user}","gists_url":"https://api.github.com/users/zherczeg/gists{/gist_id}","starred_url":"https://api.github.com/users/zherczeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherczeg/subscriptions","organizations_url":"https://api.github.com/users/zherczeg/orgs","repos_url":"https://api.github.com/users/zherczeg/repos","events_url":"https://api.github.com/users/zherczeg/events{/privacy}","received_events_url":"https://api.github.com/users/zherczeg/received_events","type":"User","site_admin":false},"body":"Ok.","created_at":"2017-04-06T06:58:00Z","updated_at":"2017-04-06T06:58:00Z","html_url":"https://github.com/jerryscript-project/jerryscript/pull/1711#discussion_r110089837","pull_request_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1711","_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/110089837"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/1711#discussion_r110089837"},"pull_request":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1711"}}},"pull_request":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1711","id":113767843,"html_url":"https://github.com/jerryscript-project/jerryscript/pull/1711","diff_url":"https://github.com/jerryscript-project/jerryscript/pull/1711.diff","patch_url":"https://github.com/jerryscript-project/jerryscript/pull/1711.patch","issue_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/1711","number":1711,"state":"open","locked":false,"title":"Add 'type' argument to set/get native handle API","user":{"login":"jiangzidong","id":15059452,"avatar_url":"https://avatars2.githubusercontent.com/u/15059452?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangzidong","html_url":"https://github.com/jiangzidong","followers_url":"https://api.github.com/users/jiangzidong/followers","following_url":"https://api.github.com/users/jiangzidong/following{/other_user}","gists_url":"https://api.github.com/users/jiangzidong/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangzidong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangzidong/subscriptions","organizations_url":"https://api.github.com/users/jiangzidong/orgs","repos_url":"https://api.github.com/users/jiangzidong/repos","events_url":"https://api.github.com/users/jiangzidong/events{/privacy}","received_events_url":"https://api.github.com/users/jiangzidong/received_events","type":"User","site_admin":false},"body":"ecma-object have native handle type inside, so that binding code could use the type info to validate native handle's type.\r\n\r\n#1681 talks about the purpose of this patch,\r\n\r\n~~**Note:** This patch is not backward compatible, old binding code might cannot work after this patch. The easiest way is change  `jerry_get_object_native_handle` to `jerry_get_object_native_handle_deprecated`, and change `jerry_set_object_native_handle` to `jerry_set_object_native_handle_deprecated`.~~\r\n\r\n","created_at":"2017-04-01T07:11:35Z","updated_at":"2017-04-06T06:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43f33bd7e23c0b40d137c796ce044df846ddb680","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1711/commits","review_comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1711/comments","review_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/1711/comments","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/7753bcc6fa1220e738d9241bed8ca008404596b8","head":{"label":"jiangzidong:nativehandler","ref":"nativehandler","sha":"7753bcc6fa1220e738d9241bed8ca008404596b8","user":{"login":"jiangzidong","id":15059452,"avatar_url":"https://avatars2.githubusercontent.com/u/15059452?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangzidong","html_url":"https://github.com/jiangzidong","followers_url":"https://api.github.com/users/jiangzidong/followers","following_url":"https://api.github.com/users/jiangzidong/following{/other_user}","gists_url":"https://api.github.com/users/jiangzidong/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangzidong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangzidong/subscriptions","organizations_url":"https://api.github.com/users/jiangzidong/orgs","repos_url":"https://api.github.com/users/jiangzidong/repos","events_url":"https://api.github.com/users/jiangzidong/events{/privacy}","received_events_url":"https://api.github.com/users/jiangzidong/received_events","type":"User","site_admin":false},"repo":{"id":43999422,"name":"jerryscript","full_name":"jiangzidong/jerryscript","owner":{"login":"jiangzidong","id":15059452,"avatar_url":"https://avatars2.githubusercontent.com/u/15059452?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangzidong","html_url":"https://github.com/jiangzidong","followers_url":"https://api.github.com/users/jiangzidong/followers","following_url":"https://api.github.com/users/jiangzidong/following{/other_user}","gists_url":"https://api.github.com/users/jiangzidong/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangzidong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangzidong/subscriptions","organizations_url":"https://api.github.com/users/jiangzidong/orgs","repos_url":"https://api.github.com/users/jiangzidong/repos","events_url":"https://api.github.com/users/jiangzidong/events{/privacy}","received_events_url":"https://api.github.com/users/jiangzidong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiangzidong/jerryscript","description":"Ultra-lightweight JavaScript engine for Internet of Things. http://www.jerryscript.net","fork":true,"url":"https://api.github.com/repos/jiangzidong/jerryscript","forks_url":"https://api.github.com/repos/jiangzidong/jerryscript/forks","keys_url":"https://api.github.com/repos/jiangzidong/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiangzidong/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiangzidong/jerryscript/teams","hooks_url":"https://api.github.com/repos/jiangzidong/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jiangzidong/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jiangzidong/jerryscript/events","assignees_url":"https://api.github.com/repos/jiangzidong/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jiangzidong/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jiangzidong/jerryscript/tags","blobs_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiangzidong/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jiangzidong/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jiangzidong/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jiangzidong/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jiangzidong/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jiangzidong/jerryscript/subscription","commits_url":"https://api.github.com/repos/jiangzidong/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiangzidong/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiangzidong/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiangzidong/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jiangzidong/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiangzidong/jerryscript/merges","archive_url":"https://api.github.com/repos/jiangzidong/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiangzidong/jerryscript/downloads","issues_url":"https://api.github.com/repos/jiangzidong/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jiangzidong/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jiangzidong/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jiangzidong/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiangzidong/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jiangzidong/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jiangzidong/jerryscript/deployments","created_at":"2015-10-10T07:17:28Z","updated_at":"2016-11-25T06:26:19Z","pushed_at":"2017-04-06T05:03:47Z","git_url":"git://github.com/jiangzidong/jerryscript.git","ssh_url":"git@github.com:jiangzidong/jerryscript.git","clone_url":"https://github.com/jiangzidong/jerryscript.git","svn_url":"https://github.com/jiangzidong/jerryscript","homepage":"","size":12828,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jerryscript-project:master","ref":"master","sha":"5d950ccb057513993253e4530a0b83b6042bc31d","user":{"login":"jerryscript-project","id":23194380,"avatar_url":"https://avatars2.githubusercontent.com/u/23194380?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"jerryscript-project/jerryscript","owner":{"login":"jerryscript-project","id":23194380,"avatar_url":"https://avatars2.githubusercontent.com/u/23194380?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jerryscript-project/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":false,"url":"https://api.github.com/repos/jerryscript-project/jerryscript","forks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/forks","keys_url":"https://api.github.com/repos/jerryscript-project/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryscript-project/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryscript-project/jerryscript/teams","hooks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/events","assignees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jerryscript-project/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/tags","blobs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryscript-project/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscription","commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jerryscript-project/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryscript-project/jerryscript/merges","archive_url":"https://api.github.com/repos/jerryscript-project/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryscript-project/jerryscript/downloads","issues_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryscript-project/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryscript-project/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryscript-project/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jerryscript-project/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2017-04-06T06:43:53Z","pushed_at":"2017-04-06T05:03:49Z","git_url":"git://github.com/jerryscript-project/jerryscript.git","ssh_url":"git@github.com:jerryscript-project/jerryscript.git","clone_url":"https://github.com/jerryscript-project/jerryscript.git","svn_url":"https://github.com/jerryscript-project/jerryscript","homepage":"http://jerryscript.net","size":28400,"stargazers_count":2223,"watchers_count":2223,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":251,"mirror_url":null,"open_issues_count":30,"forks":251,"open_issues":30,"watchers":2223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1711"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/1711"},"issue":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/1711"},"comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/1711/comments"},"review_comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1711/comments"},"review_comment":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1711/commits"},"statuses":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/7753bcc6fa1220e738d9241bed8ca008404596b8"}}}}
{"actor":{"display_login":"zherczeg"}}