{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-gossip/pulls/comments/132834285","pull_request_review_id":55958679,"id":132834285,"diff_hunk":"@@ -0,0 +1,85 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.gossip.lock.vote;\n+\n+import java.util.List;\n+import java.util.Objects;\n+\n+public class Vote {\n+  private final String votingNode;\n+  private final Boolean voteValue; // TODO: 7/16/17  weight?\n+  private Boolean voteExchange;","path":"gossip-base/src/main/java/org/apache/gossip/lock/vote/Vote.java","position":26,"original_position":26,"commit_id":"9aae15e44a5a9fae3e8cc3db238a5e0aa760ec14","original_commit_id":"523f517cde52732bc9400fc3e5af27077b1332e1","user":{"login":"Mirage20","id":8376040,"avatar_url":"https://avatars1.githubusercontent.com/u/8376040?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirage20","html_url":"https://github.com/Mirage20","followers_url":"https://api.github.com/users/Mirage20/followers","following_url":"https://api.github.com/users/Mirage20/following{/other_user}","gists_url":"https://api.github.com/users/Mirage20/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirage20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirage20/subscriptions","organizations_url":"https://api.github.com/users/Mirage20/orgs","repos_url":"https://api.github.com/users/Mirage20/repos","events_url":"https://api.github.com/users/Mirage20/events{/privacy}","received_events_url":"https://api.github.com/users/Mirage20/received_events","type":"User","site_admin":false},"body":"Rather using true false to vote, I thought about adding some weight to each nodes vote as an improvement (Need to discuss whether this is required). \r\nFor example a leader node can have higher weight (say 10) than normal node (say 2). If the leader votes for node A and 3 normal node votes for node B, Node A is the winner.","created_at":"2017-08-13T07:35:01Z","updated_at":"2017-08-13T07:35:01Z","html_url":"https://github.com/apache/incubator-gossip/pull/62#discussion_r132834285","pull_request_url":"https://api.github.com/repos/apache/incubator-gossip/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/comments/132834285"},"html":{"href":"https://github.com/apache/incubator-gossip/pull/62#discussion_r132834285"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-gossip/pulls/62","id":130702402,"html_url":"https://github.com/apache/incubator-gossip/pull/62","diff_url":"https://github.com/apache/incubator-gossip/pull/62.diff","patch_url":"https://github.com/apache/incubator-gossip/pull/62.patch","issue_url":"https://api.github.com/repos/apache/incubator-gossip/issues/62","number":62,"state":"open","locked":false,"title":"[WIP] GOSSIP-75 Voting interface","user":{"login":"Mirage20","id":8376040,"avatar_url":"https://avatars1.githubusercontent.com/u/8376040?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirage20","html_url":"https://github.com/Mirage20","followers_url":"https://api.github.com/users/Mirage20/followers","following_url":"https://api.github.com/users/Mirage20/following{/other_user}","gists_url":"https://api.github.com/users/Mirage20/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirage20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirage20/subscriptions","organizations_url":"https://api.github.com/users/Mirage20/orgs","repos_url":"https://api.github.com/users/Mirage20/repos","events_url":"https://api.github.com/users/Mirage20/events{/privacy}","received_events_url":"https://api.github.com/users/Mirage20/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-15T03:56:43Z","updated_at":"2017-08-13T07:35:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02d9a32308cafaf31f56cf2ac559b2015f3696cb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-gossip/pulls/62/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-gossip/pulls/62/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-gossip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-gossip/issues/62/comments","statuses_url":"https://api.github.com/repos/apache/incubator-gossip/statuses/9aae15e44a5a9fae3e8cc3db238a5e0aa760ec14","head":{"label":"Mirage20:GOSSIP-75","ref":"GOSSIP-75","sha":"9aae15e44a5a9fae3e8cc3db238a5e0aa760ec14","user":{"login":"Mirage20","id":8376040,"avatar_url":"https://avatars1.githubusercontent.com/u/8376040?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirage20","html_url":"https://github.com/Mirage20","followers_url":"https://api.github.com/users/Mirage20/followers","following_url":"https://api.github.com/users/Mirage20/following{/other_user}","gists_url":"https://api.github.com/users/Mirage20/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirage20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirage20/subscriptions","organizations_url":"https://api.github.com/users/Mirage20/orgs","repos_url":"https://api.github.com/users/Mirage20/repos","events_url":"https://api.github.com/users/Mirage20/events{/privacy}","received_events_url":"https://api.github.com/users/Mirage20/received_events","type":"User","site_admin":false},"repo":{"id":84227985,"name":"incubator-gossip","full_name":"Mirage20/incubator-gossip","owner":{"login":"Mirage20","id":8376040,"avatar_url":"https://avatars1.githubusercontent.com/u/8376040?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirage20","html_url":"https://github.com/Mirage20","followers_url":"https://api.github.com/users/Mirage20/followers","following_url":"https://api.github.com/users/Mirage20/following{/other_user}","gists_url":"https://api.github.com/users/Mirage20/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirage20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirage20/subscriptions","organizations_url":"https://api.github.com/users/Mirage20/orgs","repos_url":"https://api.github.com/users/Mirage20/repos","events_url":"https://api.github.com/users/Mirage20/events{/privacy}","received_events_url":"https://api.github.com/users/Mirage20/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mirage20/incubator-gossip","description":"Mirror of Apache Gossip Incubator","fork":true,"url":"https://api.github.com/repos/Mirage20/incubator-gossip","forks_url":"https://api.github.com/repos/Mirage20/incubator-gossip/forks","keys_url":"https://api.github.com/repos/Mirage20/incubator-gossip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mirage20/incubator-gossip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mirage20/incubator-gossip/teams","hooks_url":"https://api.github.com/repos/Mirage20/incubator-gossip/hooks","issue_events_url":"https://api.github.com/repos/Mirage20/incubator-gossip/issues/events{/number}","events_url":"https://api.github.com/repos/Mirage20/incubator-gossip/events","assignees_url":"https://api.github.com/repos/Mirage20/incubator-gossip/assignees{/user}","branches_url":"https://api.github.com/repos/Mirage20/incubator-gossip/branches{/branch}","tags_url":"https://api.github.com/repos/Mirage20/incubator-gossip/tags","blobs_url":"https://api.github.com/repos/Mirage20/incubator-gossip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mirage20/incubator-gossip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mirage20/incubator-gossip/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mirage20/incubator-gossip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mirage20/incubator-gossip/statuses/{sha}","languages_url":"https://api.github.com/repos/Mirage20/incubator-gossip/languages","stargazers_url":"https://api.github.com/repos/Mirage20/incubator-gossip/stargazers","contributors_url":"https://api.github.com/repos/Mirage20/incubator-gossip/contributors","subscribers_url":"https://api.github.com/repos/Mirage20/incubator-gossip/subscribers","subscription_url":"https://api.github.com/repos/Mirage20/incubator-gossip/subscription","commits_url":"https://api.github.com/repos/Mirage20/incubator-gossip/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mirage20/incubator-gossip/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mirage20/incubator-gossip/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mirage20/incubator-gossip/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mirage20/incubator-gossip/contents/{+path}","compare_url":"https://api.github.com/repos/Mirage20/incubator-gossip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mirage20/incubator-gossip/merges","archive_url":"https://api.github.com/repos/Mirage20/incubator-gossip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mirage20/incubator-gossip/downloads","issues_url":"https://api.github.com/repos/Mirage20/incubator-gossip/issues{/number}","pulls_url":"https://api.github.com/repos/Mirage20/incubator-gossip/pulls{/number}","milestones_url":"https://api.github.com/repos/Mirage20/incubator-gossip/milestones{/number}","notifications_url":"https://api.github.com/repos/Mirage20/incubator-gossip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mirage20/incubator-gossip/labels{/name}","releases_url":"https://api.github.com/repos/Mirage20/incubator-gossip/releases{/id}","deployments_url":"https://api.github.com/repos/Mirage20/incubator-gossip/deployments","created_at":"2017-03-07T17:35:19Z","updated_at":"2017-03-07T17:35:21Z","pushed_at":"2017-08-13T07:20:51Z","git_url":"git://github.com/Mirage20/incubator-gossip.git","ssh_url":"git@github.com:Mirage20/incubator-gossip.git","clone_url":"https://github.com/Mirage20/incubator-gossip.git","svn_url":"https://github.com/Mirage20/incubator-gossip","homepage":null,"size":1409,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6ef0eb788fdda2fcc355fa832ec3a3aa7321e7de","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":59881768,"name":"incubator-gossip","full_name":"apache/incubator-gossip","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-gossip","description":"Mirror of Apache Gossip Incubator","fork":false,"url":"https://api.github.com/repos/apache/incubator-gossip","forks_url":"https://api.github.com/repos/apache/incubator-gossip/forks","keys_url":"https://api.github.com/repos/apache/incubator-gossip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-gossip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-gossip/teams","hooks_url":"https://api.github.com/repos/apache/incubator-gossip/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-gossip/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-gossip/events","assignees_url":"https://api.github.com/repos/apache/incubator-gossip/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-gossip/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-gossip/tags","blobs_url":"https://api.github.com/repos/apache/incubator-gossip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-gossip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-gossip/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-gossip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-gossip/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-gossip/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-gossip/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-gossip/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-gossip/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-gossip/subscription","commits_url":"https://api.github.com/repos/apache/incubator-gossip/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-gossip/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-gossip/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-gossip/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-gossip/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-gossip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-gossip/merges","archive_url":"https://api.github.com/repos/apache/incubator-gossip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-gossip/downloads","issues_url":"https://api.github.com/repos/apache/incubator-gossip/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-gossip/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-gossip/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-gossip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-gossip/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-gossip/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-gossip/deployments","created_at":"2016-05-28T07:00:05Z","updated_at":"2017-08-12T09:51:32Z","pushed_at":"2017-08-13T07:20:52Z","git_url":"git://github.com/apache/incubator-gossip.git","ssh_url":"git@github.com:apache/incubator-gossip.git","clone_url":"https://github.com/apache/incubator-gossip.git","svn_url":"https://github.com/apache/incubator-gossip","homepage":null,"size":1387,"stargazers_count":83,"watchers_count":83,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":"git://git.apache.org/incubator-gossip.git","open_issues_count":1,"forks":36,"open_issues":1,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/62"},"html":{"href":"https://github.com/apache/incubator-gossip/pull/62"},"issue":{"href":"https://api.github.com/repos/apache/incubator-gossip/issues/62"},"comments":{"href":"https://api.github.com/repos/apache/incubator-gossip/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-gossip/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-gossip/statuses/9aae15e44a5a9fae3e8cc3db238a5e0aa760ec14"}}}}
{"actor":{"display_login":"Mirage20"}}