{"action":"created","issue":{"url":"https://api.github.com/repos/sc-forks/solidity-coverage/issues/149","repository_url":"https://api.github.com/repos/sc-forks/solidity-coverage","labels_url":"https://api.github.com/repos/sc-forks/solidity-coverage/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/sc-forks/solidity-coverage/issues/149/comments","events_url":"https://api.github.com/repos/sc-forks/solidity-coverage/issues/149/events","html_url":"https://github.com/sc-forks/solidity-coverage/issues/149","id":272597626,"number":149,"title":"Safe transfer and not coverable assert() failure","user":{"login":"Adrion","id":5418815,"avatar_url":"https://avatars3.githubusercontent.com/u/5418815?v=4","gravatar_id":"","url":"https://api.github.com/users/Adrion","html_url":"https://github.com/Adrion","followers_url":"https://api.github.com/users/Adrion/followers","following_url":"https://api.github.com/users/Adrion/following{/other_user}","gists_url":"https://api.github.com/users/Adrion/gists{/gist_id}","starred_url":"https://api.github.com/users/Adrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adrion/subscriptions","organizations_url":"https://api.github.com/users/Adrion/orgs","repos_url":"https://api.github.com/users/Adrion/repos","events_url":"https://api.github.com/users/Adrion/events{/privacy}","received_events_url":"https://api.github.com/users/Adrion/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-11-09T15:08:42Z","updated_at":"2017-11-30T11:27:28Z","closed_at":"2017-11-26T20:53:34Z","author_association":"NONE","body":"Not really an issue but I'd like to know how to manage error case for these kind of lines : \r\n`assert(token.transfer(msg.sender, token.balanceOf(this)));` \r\nI added an assert to add extra security if something goes wrong.\r\n\r\nBut in my tests I can't make this fail. So I can't get 100% on branch coverage. \r\nIt's an example but I have some extra asserts for cases we can't reproduce in the test environnement.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sc-forks/solidity-coverage/issues/comments/348161543","html_url":"https://github.com/sc-forks/solidity-coverage/issues/149#issuecomment-348161543","issue_url":"https://api.github.com/repos/sc-forks/solidity-coverage/issues/149","id":348161543,"user":{"login":"area","id":311812,"avatar_url":"https://avatars3.githubusercontent.com/u/311812?v=4","gravatar_id":"","url":"https://api.github.com/users/area","html_url":"https://github.com/area","followers_url":"https://api.github.com/users/area/followers","following_url":"https://api.github.com/users/area/following{/other_user}","gists_url":"https://api.github.com/users/area/gists{/gist_id}","starred_url":"https://api.github.com/users/area/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/area/subscriptions","organizations_url":"https://api.github.com/users/area/orgs","repos_url":"https://api.github.com/users/area/repos","events_url":"https://api.github.com/users/area/events{/privacy}","received_events_url":"https://api.github.com/users/area/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T11:27:28Z","updated_at":"2017-11-30T11:27:28Z","author_association":"CONTRIBUTOR","body":"I'll also just say for people finding this later: code coverage is just a tool. 100% code coverage doesn't mean that your code is flawless, and less than 100% doesn't necessarily mean that your code (or tests) are bad. Striving for 100% coverage might be a waste of developer time. If you understand why you're failing to reach 100% coverage, and it doesn't imply poor code (as in this instance), then it's perfectly okay!"}}
{"actor":{"display_login":"area"}}