{"action":"created","comment":{"url":"https://api.github.com/repos/libp2p/specs/pulls/comments/103098189","pull_request_review_id":23876145,"id":103098189,"diff_hunk":"@@ -24,18 +24,25 @@ libp2p already has modules for NAT ([go-libp2p-nat](https://github.com/libp2p/go\n but these don't always do the job, just because NAT traversal is complicated.\n That's why it's useful to have a simple relay protocol.\n \n-One node asks a relay node to connect to another node on its behalf.\n-The relay node shortcircuits its streams to the two nodes,\n+Unlike a transparent **tunnel**, where a libp2p peer would just proxy a\n+communication stream to a destination (the destination being unaware of the\n+original source), a circuit-relay makes the destination aware of the original\n+source and the circuit followed to establish communication between the two.\n+This provides the destination side with full knowledge of the circuit which,\n+if needed, could be rebuilt in the opposite direction using","path":"relay/README.md","position":11,"original_position":11,"commit_id":"85d027881c33f4e5ea3d39872ebcc0ba68dfe067","original_commit_id":"85d027881c33f4e5ea3d39872ebcc0ba68dfe067","user":{"login":"dryajov","id":1094341,"avatar_url":"https://avatars.githubusercontent.com/u/1094341?v=3","gravatar_id":"","url":"https://api.github.com/users/dryajov","html_url":"https://github.com/dryajov","followers_url":"https://api.github.com/users/dryajov/followers","following_url":"https://api.github.com/users/dryajov/following{/other_user}","gists_url":"https://api.github.com/users/dryajov/gists{/gist_id}","starred_url":"https://api.github.com/users/dryajov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryajov/subscriptions","organizations_url":"https://api.github.com/users/dryajov/orgs","repos_url":"https://api.github.com/users/dryajov/repos","events_url":"https://api.github.com/users/dryajov/events{/privacy}","received_events_url":"https://api.github.com/users/dryajov/received_events","type":"User","site_admin":false},"body":"@hsanjuan Fair enough. Maybe leaving the mention that the connection could be rebuilt and leaving out the details could make it more readable. Perhaps, something like this:\r\n\r\n`This provides the destination side with full knowledge of the circuit which, if needed, could be rebuilt in the opposite direction.`","created_at":"2017-02-26T08:15:28Z","updated_at":"2017-02-26T08:15:28Z","html_url":"https://github.com/libp2p/specs/pull/8#discussion_r103098189","pull_request_url":"https://api.github.com/repos/libp2p/specs/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/libp2p/specs/pulls/comments/103098189"},"html":{"href":"https://github.com/libp2p/specs/pull/8#discussion_r103098189"},"pull_request":{"href":"https://api.github.com/repos/libp2p/specs/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/libp2p/specs/pulls/8","id":106465277,"html_url":"https://github.com/libp2p/specs/pull/8","diff_url":"https://github.com/libp2p/specs/pull/8.diff","patch_url":"https://github.com/libp2p/specs/pull/8.patch","issue_url":"https://api.github.com/repos/libp2p/specs/issues/8","number":8,"state":"open","locked":false,"title":"Clarify the difference between a tunnel and a relay","user":{"login":"hsanjuan","id":1027022,"avatar_url":"https://avatars.githubusercontent.com/u/1027022?v=3","gravatar_id":"","url":"https://api.github.com/users/hsanjuan","html_url":"https://github.com/hsanjuan","followers_url":"https://api.github.com/users/hsanjuan/followers","following_url":"https://api.github.com/users/hsanjuan/following{/other_user}","gists_url":"https://api.github.com/users/hsanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanjuan/subscriptions","organizations_url":"https://api.github.com/users/hsanjuan/orgs","repos_url":"https://api.github.com/users/hsanjuan/repos","events_url":"https://api.github.com/users/hsanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/hsanjuan/received_events","type":"User","site_admin":false},"body":"It took me a while to realize that a relay it's not just\r\ntunneling a stream to a destination through a proxy peer\r\nbut rather it is making a destination peer\r\naware that the source peer is reachable through the relaying\r\nnode. Hopefully this makes that more explicit.\r\n\r\nLicense: MIT\r\nSigned-off-by: Hector Sanjuan <code@hector.link>","created_at":"2017-02-16T06:52:58Z","updated_at":"2017-02-26T08:15:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"939fc2601a4e54e2313a739b7ad27b3933db00a9","assignee":{"login":"hsanjuan","id":1027022,"avatar_url":"https://avatars.githubusercontent.com/u/1027022?v=3","gravatar_id":"","url":"https://api.github.com/users/hsanjuan","html_url":"https://github.com/hsanjuan","followers_url":"https://api.github.com/users/hsanjuan/followers","following_url":"https://api.github.com/users/hsanjuan/following{/other_user}","gists_url":"https://api.github.com/users/hsanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanjuan/subscriptions","organizations_url":"https://api.github.com/users/hsanjuan/orgs","repos_url":"https://api.github.com/users/hsanjuan/repos","events_url":"https://api.github.com/users/hsanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/hsanjuan/received_events","type":"User","site_admin":false},"assignees":[{"login":"hsanjuan","id":1027022,"avatar_url":"https://avatars.githubusercontent.com/u/1027022?v=3","gravatar_id":"","url":"https://api.github.com/users/hsanjuan","html_url":"https://github.com/hsanjuan","followers_url":"https://api.github.com/users/hsanjuan/followers","following_url":"https://api.github.com/users/hsanjuan/following{/other_user}","gists_url":"https://api.github.com/users/hsanjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/hsanjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsanjuan/subscriptions","organizations_url":"https://api.github.com/users/hsanjuan/orgs","repos_url":"https://api.github.com/users/hsanjuan/repos","events_url":"https://api.github.com/users/hsanjuan/events{/privacy}","received_events_url":"https://api.github.com/users/hsanjuan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/libp2p/specs/pulls/8/commits","review_comments_url":"https://api.github.com/repos/libp2p/specs/pulls/8/comments","review_comment_url":"https://api.github.com/repos/libp2p/specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libp2p/specs/issues/8/comments","statuses_url":"https://api.github.com/repos/libp2p/specs/statuses/85d027881c33f4e5ea3d39872ebcc0ba68dfe067","head":{"label":"libp2p:relay-vs-tunnel","ref":"relay-vs-tunnel","sha":"85d027881c33f4e5ea3d39872ebcc0ba68dfe067","user":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":68122771,"name":"specs","full_name":"libp2p/specs","owner":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libp2p/specs","description":"The spec for libp2p and associated submodules.","fork":false,"url":"https://api.github.com/repos/libp2p/specs","forks_url":"https://api.github.com/repos/libp2p/specs/forks","keys_url":"https://api.github.com/repos/libp2p/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/specs/teams","hooks_url":"https://api.github.com/repos/libp2p/specs/hooks","issue_events_url":"https://api.github.com/repos/libp2p/specs/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/specs/events","assignees_url":"https://api.github.com/repos/libp2p/specs/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/specs/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/specs/tags","blobs_url":"https://api.github.com/repos/libp2p/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/specs/languages","stargazers_url":"https://api.github.com/repos/libp2p/specs/stargazers","contributors_url":"https://api.github.com/repos/libp2p/specs/contributors","subscribers_url":"https://api.github.com/repos/libp2p/specs/subscribers","subscription_url":"https://api.github.com/repos/libp2p/specs/subscription","commits_url":"https://api.github.com/repos/libp2p/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/specs/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/specs/merges","archive_url":"https://api.github.com/repos/libp2p/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/specs/downloads","issues_url":"https://api.github.com/repos/libp2p/specs/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/specs/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/specs/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/specs/deployments","created_at":"2016-09-13T15:45:30Z","updated_at":"2017-02-25T22:30:10Z","pushed_at":"2017-02-25T15:34:33Z","git_url":"git://github.com/libp2p/specs.git","ssh_url":"git@github.com:libp2p/specs.git","clone_url":"https://github.com/libp2p/specs.git","svn_url":"https://github.com/libp2p/specs","homepage":"https://libp2p.io","size":96,"stargazers_count":30,"watchers_count":30,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":30,"default_branch":"master"}},"base":{"label":"libp2p:master","ref":"master","sha":"ed2483dd8f1d2ab2b971816b5d6274eea9bc0d3d","user":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"repo":{"id":68122771,"name":"specs","full_name":"libp2p/specs","owner":{"login":"libp2p","id":14838238,"avatar_url":"https://avatars.githubusercontent.com/u/14838238?v=3","gravatar_id":"","url":"https://api.github.com/users/libp2p","html_url":"https://github.com/libp2p","followers_url":"https://api.github.com/users/libp2p/followers","following_url":"https://api.github.com/users/libp2p/following{/other_user}","gists_url":"https://api.github.com/users/libp2p/gists{/gist_id}","starred_url":"https://api.github.com/users/libp2p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libp2p/subscriptions","organizations_url":"https://api.github.com/users/libp2p/orgs","repos_url":"https://api.github.com/users/libp2p/repos","events_url":"https://api.github.com/users/libp2p/events{/privacy}","received_events_url":"https://api.github.com/users/libp2p/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libp2p/specs","description":"The spec for libp2p and associated submodules.","fork":false,"url":"https://api.github.com/repos/libp2p/specs","forks_url":"https://api.github.com/repos/libp2p/specs/forks","keys_url":"https://api.github.com/repos/libp2p/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libp2p/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libp2p/specs/teams","hooks_url":"https://api.github.com/repos/libp2p/specs/hooks","issue_events_url":"https://api.github.com/repos/libp2p/specs/issues/events{/number}","events_url":"https://api.github.com/repos/libp2p/specs/events","assignees_url":"https://api.github.com/repos/libp2p/specs/assignees{/user}","branches_url":"https://api.github.com/repos/libp2p/specs/branches{/branch}","tags_url":"https://api.github.com/repos/libp2p/specs/tags","blobs_url":"https://api.github.com/repos/libp2p/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libp2p/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libp2p/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/libp2p/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libp2p/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/libp2p/specs/languages","stargazers_url":"https://api.github.com/repos/libp2p/specs/stargazers","contributors_url":"https://api.github.com/repos/libp2p/specs/contributors","subscribers_url":"https://api.github.com/repos/libp2p/specs/subscribers","subscription_url":"https://api.github.com/repos/libp2p/specs/subscription","commits_url":"https://api.github.com/repos/libp2p/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/libp2p/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/libp2p/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/libp2p/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/libp2p/specs/contents/{+path}","compare_url":"https://api.github.com/repos/libp2p/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libp2p/specs/merges","archive_url":"https://api.github.com/repos/libp2p/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libp2p/specs/downloads","issues_url":"https://api.github.com/repos/libp2p/specs/issues{/number}","pulls_url":"https://api.github.com/repos/libp2p/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/libp2p/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/libp2p/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libp2p/specs/labels{/name}","releases_url":"https://api.github.com/repos/libp2p/specs/releases{/id}","deployments_url":"https://api.github.com/repos/libp2p/specs/deployments","created_at":"2016-09-13T15:45:30Z","updated_at":"2017-02-25T22:30:10Z","pushed_at":"2017-02-25T15:34:33Z","git_url":"git://github.com/libp2p/specs.git","ssh_url":"git@github.com:libp2p/specs.git","clone_url":"https://github.com/libp2p/specs.git","svn_url":"https://github.com/libp2p/specs","homepage":"https://libp2p.io","size":96,"stargazers_count":30,"watchers_count":30,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libp2p/specs/pulls/8"},"html":{"href":"https://github.com/libp2p/specs/pull/8"},"issue":{"href":"https://api.github.com/repos/libp2p/specs/issues/8"},"comments":{"href":"https://api.github.com/repos/libp2p/specs/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/libp2p/specs/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/libp2p/specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libp2p/specs/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/libp2p/specs/statuses/85d027881c33f4e5ea3d39872ebcc0ba68dfe067"}}}}
{"actor":{"display_login":"dryajov"}}