{"action":"created","comment":{"url":"https://api.github.com/repos/exponea/redis-py/pulls/comments/142609832","pull_request_review_id":66992413,"id":142609832,"diff_hunk":"@@ -123,18 +120,42 @@ def rotate_slaves(self):\n             yield self.get_master_address()\n         except MasterNotFoundError:\n             pass\n-        raise SlaveNotFoundError('No slave found for %r' % (self.service_name))\n-\n-    def _checkpid(self):\n-        if self.pid != os.getpid():\n-            self.disconnect()\n-            self.reset()\n-            self.__init__(self.service_name, self.sentinel_manager,\n-                          is_master=self.is_master,\n-                          check_connection=self.check_connection,\n-                          connection_class=self.connection_class,\n-                          max_connections=self.max_connections,\n-                          **self.connection_kwargs)\n+        raise SlaveNotFoundError('No slave found for %r' % (self.service_name,))\n+\n+    def _check_connection(self, connection):\n+        if connection.to_be_disconnected:\n+            connection.disconnect()\n+            self.get_master_address()\n+            return False\n+        if self.is_master:\n+            if self.master_address != (connection.host, connection.port):","path":"redis/sentinel.py","position":69,"original_position":69,"commit_id":"bbf553cb2e4cb034a91199e618cbc455cf3ca74c","original_commit_id":"bbf553cb2e4cb034a91199e618cbc455cf3ca74c","user":{"login":"ms7s","id":7591391,"avatar_url":"https://avatars0.githubusercontent.com/u/7591391?v=4","gravatar_id":"","url":"https://api.github.com/users/ms7s","html_url":"https://github.com/ms7s","followers_url":"https://api.github.com/users/ms7s/followers","following_url":"https://api.github.com/users/ms7s/following{/other_user}","gists_url":"https://api.github.com/users/ms7s/gists{/gist_id}","starred_url":"https://api.github.com/users/ms7s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms7s/subscriptions","organizations_url":"https://api.github.com/users/ms7s/orgs","repos_url":"https://api.github.com/users/ms7s/repos","events_url":"https://api.github.com/users/ms7s/events{/privacy}","received_events_url":"https://api.github.com/users/ms7s/received_events","type":"User","site_admin":false},"body":"Ah, okay then.","created_at":"2017-10-04T08:33:30Z","updated_at":"2017-10-04T08:33:31Z","html_url":"https://github.com/exponea/redis-py/pull/1#discussion_r142609832","pull_request_url":"https://api.github.com/repos/exponea/redis-py/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/exponea/redis-py/pulls/comments/142609832"},"html":{"href":"https://github.com/exponea/redis-py/pull/1#discussion_r142609832"},"pull_request":{"href":"https://api.github.com/repos/exponea/redis-py/pulls/1"}},"in_reply_to_id":142604531},"pull_request":{"url":"https://api.github.com/repos/exponea/redis-py/pulls/1","id":144061253,"html_url":"https://github.com/exponea/redis-py/pull/1","diff_url":"https://github.com/exponea/redis-py/pull/1.diff","patch_url":"https://github.com/exponea/redis-py/pull/1.patch","issue_url":"https://api.github.com/repos/exponea/redis-py/issues/1","number":1,"state":"open","locked":false,"title":"Thread safe sentinel","user":{"login":"lalinsky","id":220839,"avatar_url":"https://avatars0.githubusercontent.com/u/220839?v=4","gravatar_id":"","url":"https://api.github.com/users/lalinsky","html_url":"https://github.com/lalinsky","followers_url":"https://api.github.com/users/lalinsky/followers","following_url":"https://api.github.com/users/lalinsky/following{/other_user}","gists_url":"https://api.github.com/users/lalinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/lalinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lalinsky/subscriptions","organizations_url":"https://api.github.com/users/lalinsky/orgs","repos_url":"https://api.github.com/users/lalinsky/repos","events_url":"https://api.github.com/users/lalinsky/events{/privacy}","received_events_url":"https://api.github.com/users/lalinsky/received_events","type":"User","site_admin":false},"body":"https://github.com/andymccurdy/redis-py/pull/909","created_at":"2017-10-01T08:27:27Z","updated_at":"2017-10-04T08:33:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff1add9c4ce4718e5fc3eca696073c36b1cb4c8d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"capkovic","id":1078875,"avatar_url":"https://avatars0.githubusercontent.com/u/1078875?v=4","gravatar_id":"","url":"https://api.github.com/users/capkovic","html_url":"https://github.com/capkovic","followers_url":"https://api.github.com/users/capkovic/followers","following_url":"https://api.github.com/users/capkovic/following{/other_user}","gists_url":"https://api.github.com/users/capkovic/gists{/gist_id}","starred_url":"https://api.github.com/users/capkovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capkovic/subscriptions","organizations_url":"https://api.github.com/users/capkovic/orgs","repos_url":"https://api.github.com/users/capkovic/repos","events_url":"https://api.github.com/users/capkovic/events{/privacy}","received_events_url":"https://api.github.com/users/capkovic/received_events","type":"User","site_admin":false},{"login":"vetyy","id":6384043,"avatar_url":"https://avatars3.githubusercontent.com/u/6384043?v=4","gravatar_id":"","url":"https://api.github.com/users/vetyy","html_url":"https://github.com/vetyy","followers_url":"https://api.github.com/users/vetyy/followers","following_url":"https://api.github.com/users/vetyy/following{/other_user}","gists_url":"https://api.github.com/users/vetyy/gists{/gist_id}","starred_url":"https://api.github.com/users/vetyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vetyy/subscriptions","organizations_url":"https://api.github.com/users/vetyy/orgs","repos_url":"https://api.github.com/users/vetyy/repos","events_url":"https://api.github.com/users/vetyy/events{/privacy}","received_events_url":"https://api.github.com/users/vetyy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/exponea/redis-py/pulls/1/commits","review_comments_url":"https://api.github.com/repos/exponea/redis-py/pulls/1/comments","review_comment_url":"https://api.github.com/repos/exponea/redis-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exponea/redis-py/issues/1/comments","statuses_url":"https://api.github.com/repos/exponea/redis-py/statuses/bbf553cb2e4cb034a91199e618cbc455cf3ca74c","head":{"label":"lalinsky:thread-safe-sentinel","ref":"thread-safe-sentinel","sha":"bbf553cb2e4cb034a91199e618cbc455cf3ca74c","user":{"login":"lalinsky","id":220839,"avatar_url":"https://avatars0.githubusercontent.com/u/220839?v=4","gravatar_id":"","url":"https://api.github.com/users/lalinsky","html_url":"https://github.com/lalinsky","followers_url":"https://api.github.com/users/lalinsky/followers","following_url":"https://api.github.com/users/lalinsky/following{/other_user}","gists_url":"https://api.github.com/users/lalinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/lalinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lalinsky/subscriptions","organizations_url":"https://api.github.com/users/lalinsky/orgs","repos_url":"https://api.github.com/users/lalinsky/repos","events_url":"https://api.github.com/users/lalinsky/events{/privacy}","received_events_url":"https://api.github.com/users/lalinsky/received_events","type":"User","site_admin":false},"repo":{"id":105371098,"name":"redis-py","full_name":"lalinsky/redis-py","owner":{"login":"lalinsky","id":220839,"avatar_url":"https://avatars0.githubusercontent.com/u/220839?v=4","gravatar_id":"","url":"https://api.github.com/users/lalinsky","html_url":"https://github.com/lalinsky","followers_url":"https://api.github.com/users/lalinsky/followers","following_url":"https://api.github.com/users/lalinsky/following{/other_user}","gists_url":"https://api.github.com/users/lalinsky/gists{/gist_id}","starred_url":"https://api.github.com/users/lalinsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lalinsky/subscriptions","organizations_url":"https://api.github.com/users/lalinsky/orgs","repos_url":"https://api.github.com/users/lalinsky/repos","events_url":"https://api.github.com/users/lalinsky/events{/privacy}","received_events_url":"https://api.github.com/users/lalinsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lalinsky/redis-py","description":"Redis Python Client","fork":true,"url":"https://api.github.com/repos/lalinsky/redis-py","forks_url":"https://api.github.com/repos/lalinsky/redis-py/forks","keys_url":"https://api.github.com/repos/lalinsky/redis-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lalinsky/redis-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lalinsky/redis-py/teams","hooks_url":"https://api.github.com/repos/lalinsky/redis-py/hooks","issue_events_url":"https://api.github.com/repos/lalinsky/redis-py/issues/events{/number}","events_url":"https://api.github.com/repos/lalinsky/redis-py/events","assignees_url":"https://api.github.com/repos/lalinsky/redis-py/assignees{/user}","branches_url":"https://api.github.com/repos/lalinsky/redis-py/branches{/branch}","tags_url":"https://api.github.com/repos/lalinsky/redis-py/tags","blobs_url":"https://api.github.com/repos/lalinsky/redis-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lalinsky/redis-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lalinsky/redis-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/lalinsky/redis-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lalinsky/redis-py/statuses/{sha}","languages_url":"https://api.github.com/repos/lalinsky/redis-py/languages","stargazers_url":"https://api.github.com/repos/lalinsky/redis-py/stargazers","contributors_url":"https://api.github.com/repos/lalinsky/redis-py/contributors","subscribers_url":"https://api.github.com/repos/lalinsky/redis-py/subscribers","subscription_url":"https://api.github.com/repos/lalinsky/redis-py/subscription","commits_url":"https://api.github.com/repos/lalinsky/redis-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/lalinsky/redis-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/lalinsky/redis-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/lalinsky/redis-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/lalinsky/redis-py/contents/{+path}","compare_url":"https://api.github.com/repos/lalinsky/redis-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lalinsky/redis-py/merges","archive_url":"https://api.github.com/repos/lalinsky/redis-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lalinsky/redis-py/downloads","issues_url":"https://api.github.com/repos/lalinsky/redis-py/issues{/number}","pulls_url":"https://api.github.com/repos/lalinsky/redis-py/pulls{/number}","milestones_url":"https://api.github.com/repos/lalinsky/redis-py/milestones{/number}","notifications_url":"https://api.github.com/repos/lalinsky/redis-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lalinsky/redis-py/labels{/name}","releases_url":"https://api.github.com/repos/lalinsky/redis-py/releases{/id}","deployments_url":"https://api.github.com/repos/lalinsky/redis-py/deployments","created_at":"2017-09-30T13:17:18Z","updated_at":"2017-09-30T13:17:20Z","pushed_at":"2017-10-02T15:26:09Z","git_url":"git://github.com/lalinsky/redis-py.git","ssh_url":"git@github.com:lalinsky/redis-py.git","clone_url":"https://github.com/lalinsky/redis-py.git","svn_url":"https://github.com/lalinsky/redis-py","homepage":"","size":1496,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exponea:2.10.6-exponea","ref":"2.10.6-exponea","sha":"9858a090ad0c01f7fa00ba9e04a655f4f91598d6","user":{"login":"exponea","id":17175175,"avatar_url":"https://avatars3.githubusercontent.com/u/17175175?v=4","gravatar_id":"","url":"https://api.github.com/users/exponea","html_url":"https://github.com/exponea","followers_url":"https://api.github.com/users/exponea/followers","following_url":"https://api.github.com/users/exponea/following{/other_user}","gists_url":"https://api.github.com/users/exponea/gists{/gist_id}","starred_url":"https://api.github.com/users/exponea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exponea/subscriptions","organizations_url":"https://api.github.com/users/exponea/orgs","repos_url":"https://api.github.com/users/exponea/repos","events_url":"https://api.github.com/users/exponea/events{/privacy}","received_events_url":"https://api.github.com/users/exponea/received_events","type":"Organization","site_admin":false},"repo":{"id":87166798,"name":"redis-py","full_name":"exponea/redis-py","owner":{"login":"exponea","id":17175175,"avatar_url":"https://avatars3.githubusercontent.com/u/17175175?v=4","gravatar_id":"","url":"https://api.github.com/users/exponea","html_url":"https://github.com/exponea","followers_url":"https://api.github.com/users/exponea/followers","following_url":"https://api.github.com/users/exponea/following{/other_user}","gists_url":"https://api.github.com/users/exponea/gists{/gist_id}","starred_url":"https://api.github.com/users/exponea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exponea/subscriptions","organizations_url":"https://api.github.com/users/exponea/orgs","repos_url":"https://api.github.com/users/exponea/repos","events_url":"https://api.github.com/users/exponea/events{/privacy}","received_events_url":"https://api.github.com/users/exponea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exponea/redis-py","description":"Redis Python Client","fork":true,"url":"https://api.github.com/repos/exponea/redis-py","forks_url":"https://api.github.com/repos/exponea/redis-py/forks","keys_url":"https://api.github.com/repos/exponea/redis-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exponea/redis-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exponea/redis-py/teams","hooks_url":"https://api.github.com/repos/exponea/redis-py/hooks","issue_events_url":"https://api.github.com/repos/exponea/redis-py/issues/events{/number}","events_url":"https://api.github.com/repos/exponea/redis-py/events","assignees_url":"https://api.github.com/repos/exponea/redis-py/assignees{/user}","branches_url":"https://api.github.com/repos/exponea/redis-py/branches{/branch}","tags_url":"https://api.github.com/repos/exponea/redis-py/tags","blobs_url":"https://api.github.com/repos/exponea/redis-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exponea/redis-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exponea/redis-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/exponea/redis-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exponea/redis-py/statuses/{sha}","languages_url":"https://api.github.com/repos/exponea/redis-py/languages","stargazers_url":"https://api.github.com/repos/exponea/redis-py/stargazers","contributors_url":"https://api.github.com/repos/exponea/redis-py/contributors","subscribers_url":"https://api.github.com/repos/exponea/redis-py/subscribers","subscription_url":"https://api.github.com/repos/exponea/redis-py/subscription","commits_url":"https://api.github.com/repos/exponea/redis-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/exponea/redis-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/exponea/redis-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/exponea/redis-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/exponea/redis-py/contents/{+path}","compare_url":"https://api.github.com/repos/exponea/redis-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exponea/redis-py/merges","archive_url":"https://api.github.com/repos/exponea/redis-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exponea/redis-py/downloads","issues_url":"https://api.github.com/repos/exponea/redis-py/issues{/number}","pulls_url":"https://api.github.com/repos/exponea/redis-py/pulls{/number}","milestones_url":"https://api.github.com/repos/exponea/redis-py/milestones{/number}","notifications_url":"https://api.github.com/repos/exponea/redis-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exponea/redis-py/labels{/name}","releases_url":"https://api.github.com/repos/exponea/redis-py/releases{/id}","deployments_url":"https://api.github.com/repos/exponea/redis-py/deployments","created_at":"2017-04-04T09:05:00Z","updated_at":"2017-04-04T09:05:02Z","pushed_at":"2017-10-02T15:26:13Z","git_url":"git://github.com/exponea/redis-py.git","ssh_url":"git@github.com:exponea/redis-py.git","clone_url":"https://github.com/exponea/redis-py.git","svn_url":"https://github.com/exponea/redis-py","homepage":"","size":1497,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exponea/redis-py/pulls/1"},"html":{"href":"https://github.com/exponea/redis-py/pull/1"},"issue":{"href":"https://api.github.com/repos/exponea/redis-py/issues/1"},"comments":{"href":"https://api.github.com/repos/exponea/redis-py/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/exponea/redis-py/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/exponea/redis-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exponea/redis-py/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/exponea/redis-py/statuses/bbf553cb2e4cb034a91199e618cbc455cf3ca74c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ms7s"}}