{"action":"created","issue":{"url":"https://api.github.com/repos/jamesturk/jellyfish/issues/82","repository_url":"https://api.github.com/repos/jamesturk/jellyfish","labels_url":"https://api.github.com/repos/jamesturk/jellyfish/issues/82/labels{/name}","comments_url":"https://api.github.com/repos/jamesturk/jellyfish/issues/82/comments","events_url":"https://api.github.com/repos/jamesturk/jellyfish/issues/82/events","html_url":"https://github.com/jamesturk/jellyfish/pull/82","id":222867394,"number":82,"title":"Lists of strings as arguments","user":{"login":"J535D165","id":12981139,"avatar_url":"https://avatars2.githubusercontent.com/u/12981139?v=3","gravatar_id":"","url":"https://api.github.com/users/J535D165","html_url":"https://github.com/J535D165","followers_url":"https://api.github.com/users/J535D165/followers","following_url":"https://api.github.com/users/J535D165/following{/other_user}","gists_url":"https://api.github.com/users/J535D165/gists{/gist_id}","starred_url":"https://api.github.com/users/J535D165/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J535D165/subscriptions","organizations_url":"https://api.github.com/users/J535D165/orgs","repos_url":"https://api.github.com/users/J535D165/repos","events_url":"https://api.github.com/users/J535D165/events{/privacy}","received_events_url":"https://api.github.com/users/J535D165/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-19T20:50:08Z","updated_at":"2017-04-24T14:22:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jamesturk/jellyfish/pulls/82","html_url":"https://github.com/jamesturk/jellyfish/pull/82","diff_url":"https://github.com/jamesturk/jellyfish/pull/82.diff","patch_url":"https://github.com/jamesturk/jellyfish/pull/82.patch"},"body":"This pull request adds a new feature. Hope you like it. Lists of strings are now accepted as arguments for the distance and phonetic algorithms. This is also possible for the C implementation. \r\n\r\nAim: \r\n- Make it possible to compute large sets efficiently (in parallel). \r\n- Easier to add features. \r\n\r\n## Example\r\n\r\nPython version \r\n\r\n``` python \r\n>>> from jellyfish import _jellyfish as pyjf\r\n\r\n>>> pyjf.soundex(['jelly', 'jellyfish'])\r\n['J400', 'J412']\r\n>>> pyjf.soundex('jelly')\r\n'J400'\r\n\r\n>>> pyjf.jaro_winkler(['jelly', 'jellyfish'], ['jelly', 'jellyfihs'])\r\n[1.0, 0.9777777777777777]\r\n>>> pyjf.jaro_winkler('jellyfish', 'jellyfihs')\r\n0.9777777777777777\r\n```\r\n\r\nC version\r\n\r\n``` python\r\n>>> from jellyfish import _cjellyfish as cjf\r\n\r\n>>> cjf.soundex(['jelly', 'jellyfish'])\r\n['J400', 'J412']\r\n>>> cjf.soundex('jelly')\r\n'J400'\r\n\r\n>>> cjf.jaro_winkler(['jelly', 'jellyfish'], ['jelly', 'jellyfihs'])\r\n[1.0, 0.9777777777777777]\r\n>>> cjf.jaro_winkler('jellyfish', 'jellyfihs')\r\n0.9777777777777777\r\n```\r\n\r\n## API\r\n\r\nThe API is a bit changed. `import jellyfish` imports one of those: \r\n```\r\nfrom jellyfish import _cjellyfish\r\nfrom jellyfish import _jellyfish\r\n```\r\nIn fact, `from jellyfish import _cjellyfish` is no longer completely pure C. \r\n\r\nIt is possible to import the pure C version with `from jellyfish import cjellyfish`. List are not accepted then. \r\n"},"comment":{"url":"https://api.github.com/repos/jamesturk/jellyfish/issues/comments/296683910","html_url":"https://github.com/jamesturk/jellyfish/pull/82#issuecomment-296683910","issue_url":"https://api.github.com/repos/jamesturk/jellyfish/issues/82","id":296683910,"user":{"login":"J535D165","id":12981139,"avatar_url":"https://avatars2.githubusercontent.com/u/12981139?v=3","gravatar_id":"","url":"https://api.github.com/users/J535D165","html_url":"https://github.com/J535D165","followers_url":"https://api.github.com/users/J535D165/followers","following_url":"https://api.github.com/users/J535D165/following{/other_user}","gists_url":"https://api.github.com/users/J535D165/gists{/gist_id}","starred_url":"https://api.github.com/users/J535D165/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J535D165/subscriptions","organizations_url":"https://api.github.com/users/J535D165/orgs","repos_url":"https://api.github.com/users/J535D165/repos","events_url":"https://api.github.com/users/J535D165/events{/privacy}","received_events_url":"https://api.github.com/users/J535D165/received_events","type":"User","site_admin":false},"created_at":"2017-04-24T14:22:20Z","updated_at":"2017-04-24T14:22:20Z","body":"I don't see why this is 'a lot less flexible'. The functionality remains the same for everyone (except an extremely small performance decrease). \r\n\r\n"}}
{"actor":{"display_login":"J535D165"}}