{"action":"closed","issue":{"url":"https://api.github.com/repos/garethr/kubeval/issues/24","repository_url":"https://api.github.com/repos/garethr/kubeval","labels_url":"https://api.github.com/repos/garethr/kubeval/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/garethr/kubeval/issues/24/comments","events_url":"https://api.github.com/repos/garethr/kubeval/issues/24/events","html_url":"https://github.com/garethr/kubeval/issues/24","id":249066791,"number":24,"title":"Improperly validates DaemonSet","user":{"login":"rothgar","id":371796,"avatar_url":"https://avatars1.githubusercontent.com/u/371796?v=4","gravatar_id":"","url":"https://api.github.com/users/rothgar","html_url":"https://github.com/rothgar","followers_url":"https://api.github.com/users/rothgar/followers","following_url":"https://api.github.com/users/rothgar/following{/other_user}","gists_url":"https://api.github.com/users/rothgar/gists{/gist_id}","starred_url":"https://api.github.com/users/rothgar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rothgar/subscriptions","organizations_url":"https://api.github.com/users/rothgar/orgs","repos_url":"https://api.github.com/users/rothgar/repos","events_url":"https://api.github.com/users/rothgar/events{/privacy}","received_events_url":"https://api.github.com/users/rothgar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-08-09T15:18:33Z","updated_at":"2017-09-16T16:06:01Z","closed_at":"2017-09-16T16:06:01Z","author_association":"NONE","body":"Example\r\n```\r\napiVersion: extensions/v1beta1\r\nkind: DaemonSet\r\nmetadata:\r\n  name: nginx-ds\r\nspec:\r\n  replicas: 2\r\n  template:\r\n    spec:\r\n      containers:\r\n      - image: nginx\r\n        name: nginx\r\n```\r\nkubeval verifies the yaml\r\n```\r\nkubeval test.yaml\r\nThe document test.yaml contains a valid DaemonSet\r\n```\r\nreplicas is invalid for a DaemonSet\r\n```\r\nkubectl create -f test.yaml\r\nerror: error validating \"test.yaml\": error validating data: found invalid field replicas for v1beta1.DaemonSetSpec; if you choose to ignore these errors, turn validation off with --validate=false\r\n```\r\n\r\nI didn't look at the code (I'm assuming it a straight forward fix) but wanted to report it in case I don't get to it."}}
{"actor":{"display_login":"garethr"}}