{"action":"created","issue":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/258","repository_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/258/labels{/name}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/258/comments","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/258/events","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/issues/258","id":245980192,"number":258,"title":"Code style policy changes","user":{"login":"Aprogiena","id":30052221,"avatar_url":"https://avatars0.githubusercontent.com/u/30052221?v=4","gravatar_id":"","url":"https://api.github.com/users/Aprogiena","html_url":"https://github.com/Aprogiena","followers_url":"https://api.github.com/users/Aprogiena/followers","following_url":"https://api.github.com/users/Aprogiena/following{/other_user}","gists_url":"https://api.github.com/users/Aprogiena/gists{/gist_id}","starred_url":"https://api.github.com/users/Aprogiena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aprogiena/subscriptions","organizations_url":"https://api.github.com/users/Aprogiena/orgs","repos_url":"https://api.github.com/users/Aprogiena/repos","events_url":"https://api.github.com/users/Aprogiena/events{/privacy}","received_events_url":"https://api.github.com/users/Aprogiena/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":35,"created_at":"2017-07-27T09:31:31Z","updated_at":"2017-08-09T12:32:11Z","closed_at":null,"body":"The purpose if this issue is to open discussion about changing coding style - https://github.com/stratisproject/StratisBitcoinFullNode/blob/master/Documentation/coding-style.md\r\n\r\nCurrently we only ask contributors to follow the coding style, yet we do not have any rules on whether or not a code can be accepted if it violates the coding style. \r\n\r\nThe current code base uses different code styles and a lot of code violates many rules of the current style.\r\n\r\nI think we should define both - the rules we want (as the current rule set is not sufficient) as well as the policy about how this is or is not enforced - i.e. which rules are required and which are only recommended.\r\n\r\nThis issue is for StratisBitcoinFullNode project only at this moment, and once we converge to something here, other projects are welcome to follow the outcome as well.\r\n\r\nBesides the rules and the policies on their enforcement, we should also define the decision process of which rules will be applied should contributors disagree on some (i.e. who is the boss if any, are there any vetos, or is this just majority voting?).\r\n\r\n**PROPOSING RULE (NEW OR CHANGE)**: If you want to propose a new rule, or change the text of the current rule, please start your comment starting with **RULE PROPOSAL** and use three sections: _DEFINITION_ - in this first part just write the rule as you would like to see it; _RATIONALE_ - try to explain why you think this is a good idea to have; _POLICY_ - explain what kind of policy you would like to have on this rule (i.e. would you like it to have only as a general guideline/recommendation, or strictly enforced - i.e. not accepting new code violating it?). \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments/321241525","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/issues/258#issuecomment-321241525","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/258","id":321241525,"user":{"login":"dangershony","id":7487930,"avatar_url":"https://avatars2.githubusercontent.com/u/7487930?v=4","gravatar_id":"","url":"https://api.github.com/users/dangershony","html_url":"https://github.com/dangershony","followers_url":"https://api.github.com/users/dangershony/followers","following_url":"https://api.github.com/users/dangershony/following{/other_user}","gists_url":"https://api.github.com/users/dangershony/gists{/gist_id}","starred_url":"https://api.github.com/users/dangershony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dangershony/subscriptions","organizations_url":"https://api.github.com/users/dangershony/orgs","repos_url":"https://api.github.com/users/dangershony/repos","events_url":"https://api.github.com/users/dangershony/events{/privacy}","received_events_url":"https://api.github.com/users/dangershony/received_events","type":"User","site_admin":false},"created_at":"2017-08-09T12:32:11Z","updated_at":"2017-08-09T12:32:11Z","body":"hi @detroitpro would you like to make a recommendation?"}}
{"actor":{"display_login":"dangershony"}}