{"action":"created","issue":{"url":"https://api.github.com/repos/corda/corda/issues/644","repository_url":"https://api.github.com/repos/corda/corda","labels_url":"https://api.github.com/repos/corda/corda/issues/644/labels{/name}","comments_url":"https://api.github.com/repos/corda/corda/issues/644/comments","events_url":"https://api.github.com/repos/corda/corda/issues/644/events","html_url":"https://github.com/corda/corda/pull/644","id":227064689,"number":644,"title":"Fix issue #55","user":{"login":"exFalso","id":1042674,"avatar_url":"https://avatars3.githubusercontent.com/u/1042674?v=3","gravatar_id":"","url":"https://api.github.com/users/exFalso","html_url":"https://github.com/exFalso","followers_url":"https://api.github.com/users/exFalso/followers","following_url":"https://api.github.com/users/exFalso/following{/other_user}","gists_url":"https://api.github.com/users/exFalso/gists{/gist_id}","starred_url":"https://api.github.com/users/exFalso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exFalso/subscriptions","organizations_url":"https://api.github.com/users/exFalso/orgs","repos_url":"https://api.github.com/users/exFalso/repos","events_url":"https://api.github.com/users/exFalso/events{/privacy}","received_events_url":"https://api.github.com/users/exFalso/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-08T14:29:30Z","updated_at":"2017-05-09T09:47:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/644","html_url":"https://github.com/corda/corda/pull/644","diff_url":"https://github.com/corda/corda/pull/644.diff","patch_url":"https://github.com/corda/corda/pull/644.patch"},"body":"This PR aims to fix #55\r\n\r\nIt factors out the file locking into a separate class `EnforceSingleNodeIsRunning`, which is started before the logging is initialised.\r\n\r\nI added an integ test that checks that only a single node is writing to the logfile, though it's a bit brittle, it greps for \"Logs can be found in\". Thoughts?\r\n\r\nNote also that `EnforceSingleNodeIsRunning` itself does some logging - as the logging is not initialised by this time it will use the default slf4j settings. We could leave it like this or do some manual printing instead"},"comment":{"url":"https://api.github.com/repos/corda/corda/issues/comments/300115827","html_url":"https://github.com/corda/corda/pull/644#issuecomment-300115827","issue_url":"https://api.github.com/repos/corda/corda/issues/644","id":300115827,"user":{"login":"andr3ej","id":26927791,"avatar_url":"https://avatars0.githubusercontent.com/u/26927791?v=3","gravatar_id":"","url":"https://api.github.com/users/andr3ej","html_url":"https://github.com/andr3ej","followers_url":"https://api.github.com/users/andr3ej/followers","following_url":"https://api.github.com/users/andr3ej/following{/other_user}","gists_url":"https://api.github.com/users/andr3ej/gists{/gist_id}","starred_url":"https://api.github.com/users/andr3ej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andr3ej/subscriptions","organizations_url":"https://api.github.com/users/andr3ej/orgs","repos_url":"https://api.github.com/users/andr3ej/repos","events_url":"https://api.github.com/users/andr3ej/events{/privacy}","received_events_url":"https://api.github.com/users/andr3ej/received_events","type":"User","site_admin":false},"created_at":"2017-05-09T09:47:11Z","updated_at":"2017-05-09T09:47:11Z","body":"Looking good, I'll approve after I've seen what it will take to make the build succeed."}}
{"actor":{"display_login":"andr3ej"}}