{"action":"created","comment":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/110791347","pull_request_review_id":31989147,"id":110791347,"diff_hunk":"@@ -107,6 +108,43 @@ cc_oci_expand_net_device_cmdline(struct cc_oci_config *config, guint index) {\n \treturn g_strdup(\"\");\n }\n \n+/*\n+ *\n+ *\n+ */\n+#define DPDK_CMDLINE_OBJ \"memory-backend-file,id=dpdkmem,size=2048M,mem-path=/dev/hugepages,share=on,prealloc=on\"","path":"src/hypervisor.c","position":16,"original_position":16,"commit_id":"08a18d1fea5c4cf8a458bdc5f33d56022a972a2e","original_commit_id":"cca248822b1a6af2b2200678e91db6186af97b0e","user":{"login":"egernst","id":20174683,"avatar_url":"https://avatars2.githubusercontent.com/u/20174683?v=3","gravatar_id":"","url":"https://api.github.com/users/egernst","html_url":"https://github.com/egernst","followers_url":"https://api.github.com/users/egernst/followers","following_url":"https://api.github.com/users/egernst/following{/other_user}","gists_url":"https://api.github.com/users/egernst/gists{/gist_id}","starred_url":"https://api.github.com/users/egernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egernst/subscriptions","organizations_url":"https://api.github.com/users/egernst/orgs","repos_url":"https://api.github.com/users/egernst/repos","events_url":"https://api.github.com/users/egernst/events{/privacy}","received_events_url":"https://api.github.com/users/egernst/received_events","type":"User","site_admin":false},"body":"Will update to use VM_MEM and VM_MEM_MAX in a follow on PR, after submitting these changes to master.  Thanks for the good feedback","created_at":"2017-04-11T00:15:16Z","updated_at":"2017-04-11T00:15:16Z","html_url":"https://github.com/01org/cc-oci-runtime/pull/787#discussion_r110791347","pull_request_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/787","_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/110791347"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/787#discussion_r110791347"},"pull_request":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/787"}}},"pull_request":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/787","id":113540914,"html_url":"https://github.com/01org/cc-oci-runtime/pull/787","diff_url":"https://github.com/01org/cc-oci-runtime/pull/787.diff","patch_url":"https://github.com/01org/cc-oci-runtime/pull/787.patch","issue_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/787","number":787,"state":"open","locked":false,"title":"OVS DPDK enabling","user":{"login":"egernst","id":20174683,"avatar_url":"https://avatars2.githubusercontent.com/u/20174683?v=3","gravatar_id":"","url":"https://api.github.com/users/egernst","html_url":"https://github.com/egernst","followers_url":"https://api.github.com/users/egernst/followers","following_url":"https://api.github.com/users/egernst/following{/other_user}","gists_url":"https://api.github.com/users/egernst/gists{/gist_id}","starred_url":"https://api.github.com/users/egernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egernst/subscriptions","organizations_url":"https://api.github.com/users/egernst/orgs","repos_url":"https://api.github.com/users/egernst/repos","events_url":"https://api.github.com/users/egernst/events{/privacy}","received_events_url":"https://api.github.com/users/egernst/received_events","type":"User","site_admin":false},"body":"This pull request adds the cc-oci-runtime changes necessary for enabling host-based OVS-DPDK, as well as some documentation on setting up OVS-DPDK on the host.  Note, this is for ovs-dpdk-poc branch, not master.","created_at":"2017-03-30T22:46:21Z","updated_at":"2017-04-11T00:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc97d5a59a336135b37a796633f0e915c92099c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/787/commits","review_comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/787/comments","review_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/787/comments","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/08a18d1fea5c4cf8a458bdc5f33d56022a972a2e","head":{"label":"egernst:ovs-dpdk-wip","ref":"ovs-dpdk-wip","sha":"08a18d1fea5c4cf8a458bdc5f33d56022a972a2e","user":{"login":"egernst","id":20174683,"avatar_url":"https://avatars2.githubusercontent.com/u/20174683?v=3","gravatar_id":"","url":"https://api.github.com/users/egernst","html_url":"https://github.com/egernst","followers_url":"https://api.github.com/users/egernst/followers","following_url":"https://api.github.com/users/egernst/following{/other_user}","gists_url":"https://api.github.com/users/egernst/gists{/gist_id}","starred_url":"https://api.github.com/users/egernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egernst/subscriptions","organizations_url":"https://api.github.com/users/egernst/orgs","repos_url":"https://api.github.com/users/egernst/repos","events_url":"https://api.github.com/users/egernst/events{/privacy}","received_events_url":"https://api.github.com/users/egernst/received_events","type":"User","site_admin":false},"repo":{"id":82331275,"name":"cc-oci-runtime","full_name":"egernst/cc-oci-runtime","owner":{"login":"egernst","id":20174683,"avatar_url":"https://avatars2.githubusercontent.com/u/20174683?v=3","gravatar_id":"","url":"https://api.github.com/users/egernst","html_url":"https://github.com/egernst","followers_url":"https://api.github.com/users/egernst/followers","following_url":"https://api.github.com/users/egernst/following{/other_user}","gists_url":"https://api.github.com/users/egernst/gists{/gist_id}","starred_url":"https://api.github.com/users/egernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egernst/subscriptions","organizations_url":"https://api.github.com/users/egernst/orgs","repos_url":"https://api.github.com/users/egernst/repos","events_url":"https://api.github.com/users/egernst/events{/privacy}","received_events_url":"https://api.github.com/users/egernst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/egernst/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime for Intel® Architecture","fork":true,"url":"https://api.github.com/repos/egernst/cc-oci-runtime","forks_url":"https://api.github.com/repos/egernst/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/egernst/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egernst/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egernst/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/egernst/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/egernst/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/egernst/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/egernst/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/egernst/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/egernst/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/egernst/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egernst/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egernst/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/egernst/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egernst/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/egernst/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/egernst/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/egernst/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/egernst/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/egernst/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/egernst/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/egernst/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/egernst/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/egernst/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/egernst/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/egernst/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egernst/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/egernst/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egernst/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/egernst/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/egernst/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/egernst/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/egernst/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egernst/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/egernst/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/egernst/cc-oci-runtime/deployments","created_at":"2017-02-17T19:33:35Z","updated_at":"2017-02-17T19:33:37Z","pushed_at":"2017-04-11T00:11:10Z","git_url":"git://github.com/egernst/cc-oci-runtime.git","ssh_url":"git@github.com:egernst/cc-oci-runtime.git","clone_url":"https://github.com/egernst/cc-oci-runtime.git","svn_url":"https://github.com/egernst/cc-oci-runtime","homepage":"","size":2680,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:networking/ovs-dpdk-poc","ref":"networking/ovs-dpdk-poc","sha":"1778df4bd7660fdc72f19f2b6ef9b1451ebf12d5","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars2.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":62701840,"name":"cc-oci-runtime","full_name":"01org/cc-oci-runtime","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars2.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime for Intel® Architecture","fork":false,"url":"https://api.github.com/repos/01org/cc-oci-runtime","forks_url":"https://api.github.com/repos/01org/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/01org/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/01org/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/01org/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/01org/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/01org/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/01org/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/01org/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/01org/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/01org/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/01org/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/01org/cc-oci-runtime/deployments","created_at":"2016-07-06T07:48:26Z","updated_at":"2017-04-10T16:58:14Z","pushed_at":"2017-04-11T00:11:12Z","git_url":"git://github.com/01org/cc-oci-runtime.git","ssh_url":"git@github.com:01org/cc-oci-runtime.git","clone_url":"https://github.com/01org/cc-oci-runtime.git","svn_url":"https://github.com/01org/cc-oci-runtime","homepage":"","size":2645,"stargazers_count":105,"watchers_count":105,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":100,"forks":39,"open_issues":100,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/787"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/787"},"issue":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/787"},"comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/787/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/787/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/787/commits"},"statuses":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/08a18d1fea5c4cf8a458bdc5f33d56022a972a2e"}}}}
{"actor":{"display_login":"egernst"}}