{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/117458027","pull_request_review_id":39168813,"id":117458027,"diff_hunk":"@@ -828,12 +829,15 @@ createMainBlockFinish slotId pSk prevHeader = do\n         let convertTx (txId, (tx, _, _)) = WithHash tx txId\n         sortedTxs <- maybe onBrokenTopo pure $ topsortTxs convertTx localTxs\n         sk <- Ether.asks' npSecretKey\n-        -- for now let's be cautious and not generate blocks that are larger than\n-        -- maxBlockSize/4\n-        sizeLimit <- fromIntegral . toBytes . (`div` 4) <$> UDB.getMaxBlockSize\n+        -- 50 bytes is substracted to account for different unexpected\n+        -- overhead.  You can see that in bitcoin blocks are 1-2kB less\n+        -- than limit. So i guess it's fine in general.\n+        sizeLimit <-\n+            fromIntegral . toBytes . (\\x -> bool 0 (x - 100) (x > 100)) <$> UDB.getMaxBlockSize","path":"src/Pos/Block/Logic.hs","position":54,"original_position":55,"commit_id":"5e603fc869c1c4166989c06ab9dc052c68cd0846","original_commit_id":"8d541e0b796ea0a1d192a7ac49868907c91064d8","user":{"login":"volhovM","id":5604643,"avatar_url":"https://avatars3.githubusercontent.com/u/5604643?v=3","gravatar_id":"","url":"https://api.github.com/users/volhovM","html_url":"https://github.com/volhovM","followers_url":"https://api.github.com/users/volhovM/followers","following_url":"https://api.github.com/users/volhovM/following{/other_user}","gists_url":"https://api.github.com/users/volhovM/gists{/gist_id}","starred_url":"https://api.github.com/users/volhovM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volhovM/subscriptions","organizations_url":"https://api.github.com/users/volhovM/orgs","repos_url":"https://api.github.com/users/volhovM/repos","events_url":"https://api.github.com/users/volhovM/events{/privacy}","received_events_url":"https://api.github.com/users/volhovM/received_events","type":"User","site_admin":false},"body":"I guess I just blindly refactored something. Fixed.","created_at":"2017-05-19T11:13:41Z","updated_at":"2017-05-19T11:13:41Z","html_url":"https://github.com/input-output-hk/cardano-sl/pull/349#discussion_r117458027","pull_request_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments/117458027"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/349#discussion_r117458027"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/349","id":121283817,"html_url":"https://github.com/input-output-hk/cardano-sl/pull/349","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/349.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/349.patch","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/349","number":349,"state":"open","locked":false,"title":"Feature/csl695 block size limits refined","user":{"login":"volhovM","id":5604643,"avatar_url":"https://avatars3.githubusercontent.com/u/5604643?v=3","gravatar_id":"","url":"https://api.github.com/users/volhovM","html_url":"https://github.com/volhovM","followers_url":"https://api.github.com/users/volhovM/followers","following_url":"https://api.github.com/users/volhovM/following{/other_user}","gists_url":"https://api.github.com/users/volhovM/gists{/gist_id}","starred_url":"https://api.github.com/users/volhovM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volhovM/subscriptions","organizations_url":"https://api.github.com/users/volhovM/orgs","repos_url":"https://api.github.com/users/volhovM/repos","events_url":"https://api.github.com/users/volhovM/events{/privacy}","received_events_url":"https://api.github.com/users/volhovM/received_events","type":"User","site_admin":false},"body":"* Introduced ssc stripping function\r\n* Used it in `Block.Logic`\r\n* Add some tests on limits","created_at":"2017-05-18T13:30:44Z","updated_at":"2017-05-19T11:13:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6715c3d5e43eadcb5817457e8fab1d5171870769","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/349/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/349/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/349/comments","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/5e603fc869c1c4166989c06ab9dc052c68cd0846","head":{"label":"input-output-hk:feature/csl695-block-size-limits-refined","ref":"feature/csl695-block-size-limits-refined","sha":"5e603fc869c1c4166989c06ab9dc052c68cd0846","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2017-05-17T20:56:44Z","pushed_at":"2017-05-19T10:39:27Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":23765,"stargazers_count":158,"watchers_count":158,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":15,"forks":14,"open_issues":15,"watchers":158,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"5e91f0ce4f7690b1e774ed79b538e223f77b6482","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70913997,"name":"cardano-sl","full_name":"input-output-hk/cardano-sl","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/cardano-sl","description":"Cryptographic currency implementing Ouroboros PoS protocol","fork":false,"url":"https://api.github.com/repos/input-output-hk/cardano-sl","forks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/forks","keys_url":"https://api.github.com/repos/input-output-hk/cardano-sl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/cardano-sl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/cardano-sl/teams","hooks_url":"https://api.github.com/repos/input-output-hk/cardano-sl/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/events","assignees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/cardano-sl/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/tags","blobs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/cardano-sl/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/cardano-sl/subscription","commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/cardano-sl/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/cardano-sl/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/cardano-sl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/cardano-sl/merges","archive_url":"https://api.github.com/repos/input-output-hk/cardano-sl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/cardano-sl/downloads","issues_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/cardano-sl/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/cardano-sl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/cardano-sl/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/deployments","created_at":"2016-10-14T13:44:38Z","updated_at":"2017-05-17T20:56:44Z","pushed_at":"2017-05-19T10:39:27Z","git_url":"git://github.com/input-output-hk/cardano-sl.git","ssh_url":"git@github.com:input-output-hk/cardano-sl.git","clone_url":"https://github.com/input-output-hk/cardano-sl.git","svn_url":"https://github.com/input-output-hk/cardano-sl","homepage":"","size":23765,"stargazers_count":158,"watchers_count":158,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":15,"forks":14,"open_issues":15,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/349"},"html":{"href":"https://github.com/input-output-hk/cardano-sl/pull/349"},"issue":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/349"},"comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/cardano-sl/statuses/5e603fc869c1c4166989c06ab9dc052c68cd0846"}}}}
{"actor":{"display_login":"volhovM"}}