{"action":"created","issue":{"url":"https://api.github.com/repos/habitat-sh/habitat/issues/2901","repository_url":"https://api.github.com/repos/habitat-sh/habitat","labels_url":"https://api.github.com/repos/habitat-sh/habitat/issues/2901/labels{/name}","comments_url":"https://api.github.com/repos/habitat-sh/habitat/issues/2901/comments","events_url":"https://api.github.com/repos/habitat-sh/habitat/issues/2901/events","html_url":"https://github.com/habitat-sh/habitat/pull/2901","id":249159735,"number":2901,"title":"Corrected incorrect markdown handling added syntax highlighting","user":{"login":"eeyun","id":12615148,"avatar_url":"https://avatars1.githubusercontent.com/u/12615148?v=4","gravatar_id":"","url":"https://api.github.com/users/eeyun","html_url":"https://github.com/eeyun","followers_url":"https://api.github.com/users/eeyun/followers","following_url":"https://api.github.com/users/eeyun/following{/other_user}","gists_url":"https://api.github.com/users/eeyun/gists{/gist_id}","starred_url":"https://api.github.com/users/eeyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeyun/subscriptions","organizations_url":"https://api.github.com/users/eeyun/orgs","repos_url":"https://api.github.com/users/eeyun/repos","events_url":"https://api.github.com/users/eeyun/events{/privacy}","received_events_url":"https://api.github.com/users/eeyun/received_events","type":"User","site_admin":false},"labels":[{"id":621115430,"url":"https://api.github.com/repos/habitat-sh/habitat/labels/A-habitat.sh","name":"A-habitat.sh","color":"87B09A","default":false},{"id":621118748,"url":"https://api.github.com/repos/habitat-sh/habitat/labels/C-chore","name":"C-chore","color":"ff9012","default":false},{"id":621115721,"url":"https://api.github.com/repos/habitat-sh/habitat/labels/C-feature","name":"C-feature","color":"ff9012","default":false},{"id":621119535,"url":"https://api.github.com/repos/habitat-sh/habitat/labels/E-easy","name":"E-easy","color":"4296b4","default":false},{"id":621119793,"url":"https://api.github.com/repos/habitat-sh/habitat/labels/L-html-css","name":"L-html-css","color":"5c6670","default":false},{"id":621119801,"url":"https://api.github.com/repos/habitat-sh/habitat/labels/L-javascript","name":"L-javascript","color":"5c6670","default":false}],"state":"open","locked":false,"assignee":{"login":"eeyun","id":12615148,"avatar_url":"https://avatars1.githubusercontent.com/u/12615148?v=4","gravatar_id":"","url":"https://api.github.com/users/eeyun","html_url":"https://github.com/eeyun","followers_url":"https://api.github.com/users/eeyun/followers","following_url":"https://api.github.com/users/eeyun/following{/other_user}","gists_url":"https://api.github.com/users/eeyun/gists{/gist_id}","starred_url":"https://api.github.com/users/eeyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeyun/subscriptions","organizations_url":"https://api.github.com/users/eeyun/orgs","repos_url":"https://api.github.com/users/eeyun/repos","events_url":"https://api.github.com/users/eeyun/events{/privacy}","received_events_url":"https://api.github.com/users/eeyun/received_events","type":"User","site_admin":false},"assignees":[{"login":"eeyun","id":12615148,"avatar_url":"https://avatars1.githubusercontent.com/u/12615148?v=4","gravatar_id":"","url":"https://api.github.com/users/eeyun","html_url":"https://github.com/eeyun","followers_url":"https://api.github.com/users/eeyun/followers","following_url":"https://api.github.com/users/eeyun/following{/other_user}","gists_url":"https://api.github.com/users/eeyun/gists{/gist_id}","starred_url":"https://api.github.com/users/eeyun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeyun/subscriptions","organizations_url":"https://api.github.com/users/eeyun/orgs","repos_url":"https://api.github.com/users/eeyun/repos","events_url":"https://api.github.com/users/eeyun/events{/privacy}","received_events_url":"https://api.github.com/users/eeyun/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-08-09T20:59:15Z","updated_at":"2017-08-09T23:08:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/habitat-sh/habitat/pulls/2901","html_url":"https://github.com/habitat-sh/habitat/pull/2901","diff_url":"https://github.com/habitat-sh/habitat/pull/2901.diff","patch_url":"https://github.com/habitat-sh/habitat/pull/2901.patch"},"body":"This PR changes the markdown handling engine to redcarpet which has a more common syntax handling than kramdown.\r\n\r\nBecause of this, some of the new tutorial content had to be brought in line with redcarpet's syntax preferences.\r\n\r\nIt also adds in highlight.js for syntax highlighting over all of our codeblocks and no longer relies on middleman's syntax highlighter.\r\n\r\nSigned-off-by: Ian Henry <ihenry@chef.io>"},"comment":{"url":"https://api.github.com/repos/habitat-sh/habitat/issues/comments/321405866","html_url":"https://github.com/habitat-sh/habitat/pull/2901#issuecomment-321405866","issue_url":"https://api.github.com/repos/habitat-sh/habitat/issues/2901","id":321405866,"user":{"login":"apriofrost","id":9401459,"avatar_url":"https://avatars3.githubusercontent.com/u/9401459?v=4","gravatar_id":"","url":"https://api.github.com/users/apriofrost","html_url":"https://github.com/apriofrost","followers_url":"https://api.github.com/users/apriofrost/followers","following_url":"https://api.github.com/users/apriofrost/following{/other_user}","gists_url":"https://api.github.com/users/apriofrost/gists{/gist_id}","starred_url":"https://api.github.com/users/apriofrost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apriofrost/subscriptions","organizations_url":"https://api.github.com/users/apriofrost/orgs","repos_url":"https://api.github.com/users/apriofrost/repos","events_url":"https://api.github.com/users/apriofrost/events{/privacy}","received_events_url":"https://api.github.com/users/apriofrost/received_events","type":"User","site_admin":false},"created_at":"2017-08-09T23:08:20Z","updated_at":"2017-08-09T23:08:20Z","body":"Thanks for the awesome work, Ian! I have a few feedback on the colors:\r\n1. One thing we might need to pay attention to is the accessibility of the colors, especially for the single line command under the Interactive Demo section (http://www.acceptance.habitat.sh/tutorials/get-started/demo/). Because currently, a user has to read and type in the command manually (we hasn't implemented the copy pasting feature yet). It has to be very easy to read. The color contrast shown in the screenshot below doesn't satisfy that (I haven't tried with a color contrast checker, but it's unlikely to pass). I would suggest that we just use the current color on the production site.\r\n![image](https://user-images.githubusercontent.com/9401459/29147339-3a4ce3f0-7d1b-11e7-97d1-46ab0962d733.png)\r\n2. The background color of the simulated terminal doesn't match with the new background color of the command line. It's better to keep them the same color when they appear close together.  I would prefer to keep it as the current dark blue color (#283c4c) since it matches better with the current visual style across the site.\r\n![image](https://user-images.githubusercontent.com/9401459/29147605-f1960c84-7d1c-11e7-83f9-7aed8edb9baf.png)\r\n\r\n"}}
{"actor":{"display_login":"apriofrost"}}