{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/26021","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/26021/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/26021/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/26021/events","html_url":"https://github.com/owncloud/core/pull/26021","id":174801635,"number":26021,"title":"Precompiled handlebars template","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[{"id":17709833,"url":"https://api.github.com/repos/owncloud/core/labels/2%20-%20Developing","name":"2 - Developing","color":"ededed","default":false},{"id":752534740,"url":"https://api.github.com/repos/owncloud/core/labels/review%20carefully!","name":"review carefully!","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/11","html_url":"https://github.com/owncloud/core/milestone/11","labels_url":"https://api.github.com/repos/owncloud/core/milestones/11/labels","id":697149,"number":11,"title":"backlog","description":"","creator":{"login":"MTRichards","id":1818977,"avatar_url":"https://avatars2.githubusercontent.com/u/1818977?v=4","gravatar_id":"","url":"https://api.github.com/users/MTRichards","html_url":"https://github.com/MTRichards","followers_url":"https://api.github.com/users/MTRichards/followers","following_url":"https://api.github.com/users/MTRichards/following{/other_user}","gists_url":"https://api.github.com/users/MTRichards/gists{/gist_id}","starred_url":"https://api.github.com/users/MTRichards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MTRichards/subscriptions","organizations_url":"https://api.github.com/users/MTRichards/orgs","repos_url":"https://api.github.com/users/MTRichards/repos","events_url":"https://api.github.com/users/MTRichards/events{/privacy}","received_events_url":"https://api.github.com/users/MTRichards/received_events","type":"User","site_admin":false},"open_issues":1044,"closed_issues":885,"state":"open","created_at":"2014-06-20T19:52:03Z","updated_at":"2017-12-18T08:57:52Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2016-09-02T16:42:25Z","updated_at":"2017-12-18T11:17:45Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/26021","html_url":"https://github.com/owncloud/core/pull/26021","diff_url":"https://github.com/owncloud/core/pull/26021.diff","patch_url":"https://github.com/owncloud/core/pull/26021.patch"},"body":"<!--\nThanks for submitting a change to ownCloud!\n\nThis is the bug tracker for the Server component. Find other components at https://github.com/owncloud/core/blob/master/CONTRIBUTING.md#guidelines\n\nFor fixing potential security issues please see https://owncloud.org/security/\n\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\n\nPlease note that any kind of change first has to be submitted to the master branch which holds the next major version of ownCloud.\n\nWe will carefully discuss if your change can or has to be backported to stable branches.\n-->\n## Description\n\nIntroduce Makefile rule to build handlebars templates for every app in core, if applicable.\nIt compiles all templates from \"apps/$APP/templates/*.handlebars\" into a single JS file \"apps/$APP/js/compiled-templates.js\" that must be excluded from version control.\n\nAs an example, the template of the DetailsView in the files app has been ported to an external handlebars template file.\n## Related Issue\n\nFixes https://github.com/owncloud/core/issues/12848\n## Motivation and Context\n\nSee https://github.com/owncloud/core/issues/12848\n## How Has This Been Tested?\n\nRun `make clean` then `make test-js`. All tests will pass.\nDo a manual test in the files UI and see that the right sidebar still works.\n## Screenshots (if appropriate):\n## Types of changes\n\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\n- [ ] Bug fix (non-breaking change which fixes an issue)\n- [ ] New feature (non-breaking change which adds functionality)\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\n## Checklist:\n\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\n\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\n- [x] My code follows the code style of this project.\n- [ ] My change requires a change to the documentation.\n- [ ] I have updated the documentation accordingly.\n- [x] I have read the **CONTRIBUTING** document.\n- [ ] I have added tests to cover my changes.\n- [ ] All new and existing tests passed.\n## Some concerns\n- I'm not sure whether it's ok to have the template building instructions inside the main Makefile. I thought about having one Makefile per app instead, but could cause a bigger deal of redundancy.\n- Not sure if the location \"js/compiled-templates.js\" is ok. But can't put it inside a build dir since it won't be loadable by `addScript()`\n- Had to use a generic namespace name \"OC.template[appName][templateName]\" because we can't guess the app's JS namespace from outside (having a separate makefile per app could help)\n- If one forgets to run \"make build-apps\", the templates are not refreshed, might need some kind of watcher...\n\nPlease let me know what you think @DeepDiver1975 @butonic @jvillafanez @VicDeo \n"},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/352397856","html_url":"https://github.com/owncloud/core/pull/26021#issuecomment-352397856","issue_url":"https://api.github.com/repos/owncloud/core/issues/26021","id":352397856,"user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"created_at":"2017-12-18T11:17:45Z","updated_at":"2017-12-18T11:17:45Z","author_association":"COLLABORATOR","body":"also cc @patrickjahns as this is interesting from the general build perspective"}}
{"actor":{"display_login":"PVince81"}}