{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/94466965","pull_request_review_id":14994773,"id":94466965,"diff_hunk":"@@ -374,7 +374,7 @@ public static bool Parse(Action<CommandLineParser> parseBody, Action<CommandLine\n         /// parsable types (values are comma separated without space).\n         ///\n         /// Qualifiers that are defined BEFORE any parameter sets apply to ALL parameter sets.  qualifiers that\n-        /// are defined AFTER a parameter set will apply only the the parameter set that preceeds them.\n+        /// are defined AFTER a parameter set will apply only the the parameter set that precedes them.","path":"src/Run/CommandLine.cs","position":5,"original_position":5,"commit_id":"4f7086009a7c36310eb9545b8a9cebea2b57f1cf","original_commit_id":"4f7086009a7c36310eb9545b8a9cebea2b57f1cf","user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"body":"Thanks for fixing the typo's but given that this is a fork of the other commandline.cs file they will still exist there :( Part of the reason forks suck. ","created_at":"2017-01-03T19:29:20Z","updated_at":"2017-01-03T19:29:20Z","html_url":"https://github.com/dotnet/buildtools/pull/1285#discussion_r94466965","pull_request_url":"https://api.github.com/repos/dotnet/buildtools/pulls/1285","_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments/94466965"},"html":{"href":"https://github.com/dotnet/buildtools/pull/1285#discussion_r94466965"},"pull_request":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1285"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/buildtools/pulls/1285","id":99714082,"html_url":"https://github.com/dotnet/buildtools/pull/1285","diff_url":"https://github.com/dotnet/buildtools/pull/1285.diff","patch_url":"https://github.com/dotnet/buildtools/pull/1285.patch","issue_url":"https://api.github.com/repos/dotnet/buildtools/issues/1285","number":1285,"state":"open","locked":false,"title":"WIP: Adding support for --, / to Run.exe","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"body":"By checking qualifier length and changing the value for _qualifiersUseOnlyDash, we can support parameters using --, -, and / from run.exe.\r\n\r\nI attempted to get this to work by having the Executor set QualifiersUseOnlyDash but that will take a fair bit of refactoring to actually be able to use the property (due to the protection on its setter).\r\n\r\nI am still testing this, so please do not merge.\r\n\r\n@weshaggard \r\n\r\n","created_at":"2016-12-30T01:05:56Z","updated_at":"2017-01-03T19:29:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73847df9ff9c812d87461aea0f98b67aa30c61ce","assignee":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"assignees":[{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/buildtools/pulls/1285/commits","review_comments_url":"https://api.github.com/repos/dotnet/buildtools/pulls/1285/comments","review_comment_url":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/buildtools/issues/1285/comments","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/4f7086009a7c36310eb9545b8a9cebea2b57f1cf","head":{"label":"MattGal:Run_Arg_Changes","ref":"Run_Arg_Changes","sha":"4f7086009a7c36310eb9545b8a9cebea2b57f1cf","user":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"repo":{"id":53159521,"name":"buildtools","full_name":"MattGal/buildtools","owner":{"login":"MattGal","id":7862010,"avatar_url":"https://avatars.githubusercontent.com/u/7862010?v=3","gravatar_id":"","url":"https://api.github.com/users/MattGal","html_url":"https://github.com/MattGal","followers_url":"https://api.github.com/users/MattGal/followers","following_url":"https://api.github.com/users/MattGal/following{/other_user}","gists_url":"https://api.github.com/users/MattGal/gists{/gist_id}","starred_url":"https://api.github.com/users/MattGal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattGal/subscriptions","organizations_url":"https://api.github.com/users/MattGal/orgs","repos_url":"https://api.github.com/users/MattGal/repos","events_url":"https://api.github.com/users/MattGal/events{/privacy}","received_events_url":"https://api.github.com/users/MattGal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MattGal/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":true,"url":"https://api.github.com/repos/MattGal/buildtools","forks_url":"https://api.github.com/repos/MattGal/buildtools/forks","keys_url":"https://api.github.com/repos/MattGal/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MattGal/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MattGal/buildtools/teams","hooks_url":"https://api.github.com/repos/MattGal/buildtools/hooks","issue_events_url":"https://api.github.com/repos/MattGal/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/MattGal/buildtools/events","assignees_url":"https://api.github.com/repos/MattGal/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/MattGal/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/MattGal/buildtools/tags","blobs_url":"https://api.github.com/repos/MattGal/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MattGal/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MattGal/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/MattGal/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MattGal/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/MattGal/buildtools/languages","stargazers_url":"https://api.github.com/repos/MattGal/buildtools/stargazers","contributors_url":"https://api.github.com/repos/MattGal/buildtools/contributors","subscribers_url":"https://api.github.com/repos/MattGal/buildtools/subscribers","subscription_url":"https://api.github.com/repos/MattGal/buildtools/subscription","commits_url":"https://api.github.com/repos/MattGal/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/MattGal/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/MattGal/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/MattGal/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/MattGal/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/MattGal/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MattGal/buildtools/merges","archive_url":"https://api.github.com/repos/MattGal/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MattGal/buildtools/downloads","issues_url":"https://api.github.com/repos/MattGal/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/MattGal/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/MattGal/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/MattGal/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MattGal/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/MattGal/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/MattGal/buildtools/deployments","created_at":"2016-03-04T19:15:10Z","updated_at":"2016-03-04T19:15:12Z","pushed_at":"2017-01-03T19:01:00Z","git_url":"git://github.com/MattGal/buildtools.git","ssh_url":"git@github.com:MattGal/buildtools.git","clone_url":"https://github.com/MattGal/buildtools.git","svn_url":"https://github.com/MattGal/buildtools","homepage":"","size":4288,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0ef9ae2f266904e1e620f893e4ed210fd7562a8b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295349,"name":"buildtools","full_name":"dotnet/buildtools","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/buildtools","description":"Build tools that are necessary for building the .NET Core projects","fork":false,"url":"https://api.github.com/repos/dotnet/buildtools","forks_url":"https://api.github.com/repos/dotnet/buildtools/forks","keys_url":"https://api.github.com/repos/dotnet/buildtools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/buildtools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/buildtools/teams","hooks_url":"https://api.github.com/repos/dotnet/buildtools/hooks","issue_events_url":"https://api.github.com/repos/dotnet/buildtools/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/buildtools/events","assignees_url":"https://api.github.com/repos/dotnet/buildtools/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/buildtools/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/buildtools/tags","blobs_url":"https://api.github.com/repos/dotnet/buildtools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/buildtools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/buildtools/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/buildtools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/buildtools/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/buildtools/languages","stargazers_url":"https://api.github.com/repos/dotnet/buildtools/stargazers","contributors_url":"https://api.github.com/repos/dotnet/buildtools/contributors","subscribers_url":"https://api.github.com/repos/dotnet/buildtools/subscribers","subscription_url":"https://api.github.com/repos/dotnet/buildtools/subscription","commits_url":"https://api.github.com/repos/dotnet/buildtools/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/buildtools/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/buildtools/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/buildtools/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/buildtools/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/buildtools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/buildtools/merges","archive_url":"https://api.github.com/repos/dotnet/buildtools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/buildtools/downloads","issues_url":"https://api.github.com/repos/dotnet/buildtools/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/buildtools/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/buildtools/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/buildtools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/buildtools/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/buildtools/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/buildtools/deployments","created_at":"2014-11-06T23:43:05Z","updated_at":"2016-12-30T07:12:44Z","pushed_at":"2017-01-03T19:01:02Z","git_url":"git://github.com/dotnet/buildtools.git","ssh_url":"git@github.com:dotnet/buildtools.git","clone_url":"https://github.com/dotnet/buildtools.git","svn_url":"https://github.com/dotnet/buildtools","homepage":"","size":4277,"stargazers_count":438,"watchers_count":438,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":228,"mirror_url":null,"open_issues_count":148,"forks":228,"open_issues":148,"watchers":438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1285"},"html":{"href":"https://github.com/dotnet/buildtools/pull/1285"},"issue":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/1285"},"comments":{"href":"https://api.github.com/repos/dotnet/buildtools/issues/1285/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1285/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/buildtools/pulls/1285/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/buildtools/statuses/4f7086009a7c36310eb9545b8a9cebea2b57f1cf"}}}}
{"actor":{"display_login":"weshaggard"}}