{"action":"closed","number":564,"pull_request":{"url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/564","id":105542525,"html_url":"https://github.com/eirslett/frontend-maven-plugin/pull/564","diff_url":"https://github.com/eirslett/frontend-maven-plugin/pull/564.diff","patch_url":"https://github.com/eirslett/frontend-maven-plugin/pull/564.patch","issue_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/564","number":564,"state":"closed","locked":false,"title":"closes #534: Do not fail the Maven build for a failed test","user":{"login":"kaqqao","id":831171,"avatar_url":"https://avatars3.githubusercontent.com/u/831171?v=3","gravatar_id":"","url":"https://api.github.com/users/kaqqao","html_url":"https://github.com/kaqqao","followers_url":"https://api.github.com/users/kaqqao/followers","following_url":"https://api.github.com/users/kaqqao/following{/other_user}","gists_url":"https://api.github.com/users/kaqqao/gists{/gist_id}","starred_url":"https://api.github.com/users/kaqqao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaqqao/subscriptions","organizations_url":"https://api.github.com/users/kaqqao/orgs","repos_url":"https://api.github.com/users/kaqqao/repos","events_url":"https://api.github.com/users/kaqqao/events{/privacy}","received_events_url":"https://api.github.com/users/kaqqao/received_events","type":"User","site_admin":false},"body":"Added general support for `testFailureIgnore` (`maven.test.failure.ignore`) flag as in Surefire plugin (this closes #534). Currently only Karma mojo respects this flag, making it impossible to apply it to Protractor or any other tests.\r\nIn case this flag is set to `true`, a failure during `test` or `integration-test` phase will not fail the entire build, but just log the error.\r\n\r\n**Property name** (to add to the `<configuration>` block): `testFailureIgnore`\r\n**User property** (to add as command line argument, or the `<properties>` block): `maven.test.failure.ignore`\r\n\r\nThe change is minimal, and the flag itself, the behavior, and the implementation are all consistent with [Surefire plugin](https://github.com/apache/maven-surefire/blob/303cc8acdaf677bee9751da94de16e07083febb7/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java):\r\n\r\n**EDIT**\r\nSeems like a similar pull request already exists: https://github.com/eirslett/frontend-maven-plugin/pull/553","created_at":"2017-02-10T00:19:04Z","updated_at":"2017-03-01T12:59:01Z","closed_at":"2017-03-01T12:59:01Z","merged_at":null,"merge_commit_sha":"1024787721d1fcf8e7832f8bc1cdfb46879ca54f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/564/commits","review_comments_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/564/comments","review_comment_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/564/comments","statuses_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/statuses/48ffec60f58db563e895b2e3ef5614cadf692cf6","head":{"label":"kaqqao:support_testFailureIgnore","ref":"support_testFailureIgnore","sha":"48ffec60f58db563e895b2e3ef5614cadf692cf6","user":{"login":"kaqqao","id":831171,"avatar_url":"https://avatars3.githubusercontent.com/u/831171?v=3","gravatar_id":"","url":"https://api.github.com/users/kaqqao","html_url":"https://github.com/kaqqao","followers_url":"https://api.github.com/users/kaqqao/followers","following_url":"https://api.github.com/users/kaqqao/following{/other_user}","gists_url":"https://api.github.com/users/kaqqao/gists{/gist_id}","starred_url":"https://api.github.com/users/kaqqao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaqqao/subscriptions","organizations_url":"https://api.github.com/users/kaqqao/orgs","repos_url":"https://api.github.com/users/kaqqao/repos","events_url":"https://api.github.com/users/kaqqao/events{/privacy}","received_events_url":"https://api.github.com/users/kaqqao/received_events","type":"User","site_admin":false},"repo":{"id":81507183,"name":"frontend-maven-plugin","full_name":"kaqqao/frontend-maven-plugin","owner":{"login":"kaqqao","id":831171,"avatar_url":"https://avatars3.githubusercontent.com/u/831171?v=3","gravatar_id":"","url":"https://api.github.com/users/kaqqao","html_url":"https://github.com/kaqqao","followers_url":"https://api.github.com/users/kaqqao/followers","following_url":"https://api.github.com/users/kaqqao/following{/other_user}","gists_url":"https://api.github.com/users/kaqqao/gists{/gist_id}","starred_url":"https://api.github.com/users/kaqqao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaqqao/subscriptions","organizations_url":"https://api.github.com/users/kaqqao/orgs","repos_url":"https://api.github.com/users/kaqqao/repos","events_url":"https://api.github.com/users/kaqqao/events{/privacy}","received_events_url":"https://api.github.com/users/kaqqao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaqqao/frontend-maven-plugin","description":"\"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins.\" A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.","fork":true,"url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin","forks_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/forks","keys_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/teams","hooks_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/events","assignees_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/tags","blobs_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/subscription","commits_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/merges","archive_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/downloads","issues_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/kaqqao/frontend-maven-plugin/deployments","created_at":"2017-02-09T23:59:43Z","updated_at":"2017-02-09T23:59:44Z","pushed_at":"2017-02-10T00:38:37Z","git_url":"git://github.com/kaqqao/frontend-maven-plugin.git","ssh_url":"git@github.com:kaqqao/frontend-maven-plugin.git","clone_url":"https://github.com/kaqqao/frontend-maven-plugin.git","svn_url":"https://github.com/kaqqao/frontend-maven-plugin","homepage":"","size":631,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eirslett:master","ref":"master","sha":"7788bf4fb385159170a9de338522f614fabd19ce","user":{"login":"eirslett","id":1872593,"avatar_url":"https://avatars3.githubusercontent.com/u/1872593?v=3","gravatar_id":"","url":"https://api.github.com/users/eirslett","html_url":"https://github.com/eirslett","followers_url":"https://api.github.com/users/eirslett/followers","following_url":"https://api.github.com/users/eirslett/following{/other_user}","gists_url":"https://api.github.com/users/eirslett/gists{/gist_id}","starred_url":"https://api.github.com/users/eirslett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirslett/subscriptions","organizations_url":"https://api.github.com/users/eirslett/orgs","repos_url":"https://api.github.com/users/eirslett/repos","events_url":"https://api.github.com/users/eirslett/events{/privacy}","received_events_url":"https://api.github.com/users/eirslett/received_events","type":"User","site_admin":false},"repo":{"id":12488647,"name":"frontend-maven-plugin","full_name":"eirslett/frontend-maven-plugin","owner":{"login":"eirslett","id":1872593,"avatar_url":"https://avatars3.githubusercontent.com/u/1872593?v=3","gravatar_id":"","url":"https://api.github.com/users/eirslett","html_url":"https://github.com/eirslett","followers_url":"https://api.github.com/users/eirslett/followers","following_url":"https://api.github.com/users/eirslett/following{/other_user}","gists_url":"https://api.github.com/users/eirslett/gists{/gist_id}","starred_url":"https://api.github.com/users/eirslett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eirslett/subscriptions","organizations_url":"https://api.github.com/users/eirslett/orgs","repos_url":"https://api.github.com/users/eirslett/repos","events_url":"https://api.github.com/users/eirslett/events{/privacy}","received_events_url":"https://api.github.com/users/eirslett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eirslett/frontend-maven-plugin","description":"\"Maven-node-grunt-gulp-npm-node-plugin to end all maven-node-grunt-gulp-npm-plugins.\" A Maven plugin that downloads/installs Node and NPM locally, runs NPM install, Grunt, Gulp and/or Karma.","fork":false,"url":"https://api.github.com/repos/eirslett/frontend-maven-plugin","forks_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/forks","keys_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/teams","hooks_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/events","assignees_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/tags","blobs_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/subscription","commits_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/merges","archive_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/downloads","issues_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/eirslett/frontend-maven-plugin/deployments","created_at":"2013-08-30T14:44:38Z","updated_at":"2017-03-01T12:30:56Z","pushed_at":"2017-02-28T22:15:34Z","git_url":"git://github.com/eirslett/frontend-maven-plugin.git","ssh_url":"git@github.com:eirslett/frontend-maven-plugin.git","clone_url":"https://github.com/eirslett/frontend-maven-plugin.git","svn_url":"https://github.com/eirslett/frontend-maven-plugin","homepage":"","size":634,"stargazers_count":1605,"watchers_count":1605,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":400,"mirror_url":null,"open_issues_count":114,"forks":400,"open_issues":114,"watchers":1605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/564"},"html":{"href":"https://github.com/eirslett/frontend-maven-plugin/pull/564"},"issue":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/564"},"comments":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/eirslett/frontend-maven-plugin/statuses/48ffec60f58db563e895b2e3ef5614cadf692cf6"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":24,"deletions":21,"changed_files":2}}
{"actor":{"display_login":"kaqqao"}}