{"action":"created","comment":{"url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/comments/157779507","pull_request_review_id":84478186,"id":157779507,"diff_hunk":"@@ -252,6 +278,9 @@ class AccountOverview extends React.Component {\n             const canDepositWithdraw = !!this.props.backedCoins.get(\"OPEN\", []).find(a => a.symbol === asset.get(\"symbol\"));\n             const canWithdraw = canDepositWithdraw && (hasBalance && balanceObject.get(\"balance\") != 0);\n             const canBuy = !!this.props.bridgeCoins.get(symbol);\n+            const changeClass = !marketsCache[asset.get(\"id\")] ? \"\" : marketsCache[asset.get(\"id\")][1] == 0 ? \"\" : marketsCache[asset.get(\"id\")][1] < 0 ? marketsCache[asset.get(\"id\")][2] ? \"pulsate-down\" : \"change-down\" : marketsCache[asset.get(\"id\")][2] ? \"pulsate-up\" : \"change-up\";","path":"app/components/Account/AccountOverview.jsx","position":49,"original_position":49,"commit_id":"475e0acdfc50a955f694efc05f8a8299044f379c","original_commit_id":"475e0acdfc50a955f694efc05f8a8299044f379c","user":{"login":"svk31","id":6890015,"avatar_url":"https://avatars2.githubusercontent.com/u/6890015?v=4","gravatar_id":"","url":"https://api.github.com/users/svk31","html_url":"https://github.com/svk31","followers_url":"https://api.github.com/users/svk31/followers","following_url":"https://api.github.com/users/svk31/following{/other_user}","gists_url":"https://api.github.com/users/svk31/gists{/gist_id}","starred_url":"https://api.github.com/users/svk31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svk31/subscriptions","organizations_url":"https://api.github.com/users/svk31/orgs","repos_url":"https://api.github.com/users/svk31/repos","events_url":"https://api.github.com/users/svk31/events{/privacy}","received_events_url":"https://api.github.com/users/svk31/received_events","type":"User","site_admin":false},"body":"I don't think this line does what you think it does. The syntax is incorrect (too many : parts like here: `? \"pulsate-down\" : \"change-down\" : marketsCache[asset.get(\"id\")][2]`) and marketsCache[asset.get(\"id\")][1] is a string so you should parse it before comparing it to 0.","created_at":"2017-12-19T15:07:26Z","updated_at":"2017-12-19T15:12:54Z","html_url":"https://github.com/bitshares/bitshares-ui/pull/870#discussion_r157779507","pull_request_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/870","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/comments/157779507"},"html":{"href":"https://github.com/bitshares/bitshares-ui/pull/870#discussion_r157779507"},"pull_request":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/870"}}},"pull_request":{"url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/870","id":158422631,"html_url":"https://github.com/bitshares/bitshares-ui/pull/870","diff_url":"https://github.com/bitshares/bitshares-ui/pull/870.diff","patch_url":"https://github.com/bitshares/bitshares-ui/pull/870.patch","issue_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/870","number":870,"state":"open","locked":false,"title":"Fix Issue #691 - Flash on Price Change","user":{"login":"startailcoon","id":12114550,"avatar_url":"https://avatars1.githubusercontent.com/u/12114550?v=4","gravatar_id":"","url":"https://api.github.com/users/startailcoon","html_url":"https://github.com/startailcoon","followers_url":"https://api.github.com/users/startailcoon/followers","following_url":"https://api.github.com/users/startailcoon/following{/other_user}","gists_url":"https://api.github.com/users/startailcoon/gists{/gist_id}","starred_url":"https://api.github.com/users/startailcoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/startailcoon/subscriptions","organizations_url":"https://api.github.com/users/startailcoon/orgs","repos_url":"https://api.github.com/users/startailcoon/repos","events_url":"https://api.github.com/users/startailcoon/events{/privacy}","received_events_url":"https://api.github.com/users/startailcoon/received_events","type":"User","site_admin":false},"body":"Proposal for Issue #691 \r\n\r\nNot sure if this is the most efficient model, but it works when I try it.","created_at":"2017-12-14T17:50:43Z","updated_at":"2017-12-19T15:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b00a103e7f3d02c5abce415c5af95a111f1b3ef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/870/commits","review_comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/870/comments","review_comment_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/870/comments","statuses_url":"https://api.github.com/repos/bitshares/bitshares-ui/statuses/475e0acdfc50a955f694efc05f8a8299044f379c","head":{"label":"bitshares:691_FlashOnPriceChange","ref":"691_FlashOnPriceChange","sha":"475e0acdfc50a955f694efc05f8a8299044f379c","user":{"login":"bitshares","id":6914094,"avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":44123296,"name":"bitshares-ui","full_name":"bitshares/bitshares-ui","owner":{"login":"bitshares","id":6914094,"avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitshares/bitshares-ui","description":"Graphical User Interface for Bitshares","fork":false,"url":"https://api.github.com/repos/bitshares/bitshares-ui","forks_url":"https://api.github.com/repos/bitshares/bitshares-ui/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-ui/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-ui/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-ui/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-ui/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-ui/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-ui/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-ui/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-ui/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-ui/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-ui/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-ui/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-ui/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-ui/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-ui/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-ui/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-ui/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-ui/deployments","created_at":"2015-10-12T17:36:50Z","updated_at":"2017-12-19T09:01:33Z","pushed_at":"2017-12-19T02:50:32Z","git_url":"git://github.com/bitshares/bitshares-ui.git","ssh_url":"git@github.com:bitshares/bitshares-ui.git","clone_url":"https://github.com/bitshares/bitshares-ui.git","svn_url":"https://github.com/bitshares/bitshares-ui","homepage":"https://wallet.bitshares.org","size":20612,"stargazers_count":199,"watchers_count":199,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":163,"open_issues":125,"watchers":199,"default_branch":"staging"}},"base":{"label":"bitshares:staging","ref":"staging","sha":"ef3c99467619827cbfc0ec1434c5a2d59ae1ce73","user":{"login":"bitshares","id":6914094,"avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":44123296,"name":"bitshares-ui","full_name":"bitshares/bitshares-ui","owner":{"login":"bitshares","id":6914094,"avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitshares/bitshares-ui","description":"Graphical User Interface for Bitshares","fork":false,"url":"https://api.github.com/repos/bitshares/bitshares-ui","forks_url":"https://api.github.com/repos/bitshares/bitshares-ui/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-ui/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-ui/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-ui/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-ui/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-ui/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-ui/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-ui/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-ui/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-ui/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-ui/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-ui/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-ui/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-ui/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-ui/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-ui/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-ui/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-ui/deployments","created_at":"2015-10-12T17:36:50Z","updated_at":"2017-12-19T09:01:33Z","pushed_at":"2017-12-19T02:50:32Z","git_url":"git://github.com/bitshares/bitshares-ui.git","ssh_url":"git@github.com:bitshares/bitshares-ui.git","clone_url":"https://github.com/bitshares/bitshares-ui.git","svn_url":"https://github.com/bitshares/bitshares-ui","homepage":"https://wallet.bitshares.org","size":20612,"stargazers_count":199,"watchers_count":199,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":163,"open_issues":125,"watchers":199,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/870"},"html":{"href":"https://github.com/bitshares/bitshares-ui/pull/870"},"issue":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/issues/870"},"comments":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/issues/870/comments"},"review_comments":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/870/comments"},"review_comment":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/pulls/870/commits"},"statuses":{"href":"https://api.github.com/repos/bitshares/bitshares-ui/statuses/475e0acdfc50a955f694efc05f8a8299044f379c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"svk31"}}