{"action":"created","issue":{"url":"https://api.github.com/repos/Wikia/app/issues/13174","repository_url":"https://api.github.com/repos/Wikia/app","labels_url":"https://api.github.com/repos/Wikia/app/issues/13174/labels{/name}","comments_url":"https://api.github.com/repos/Wikia/app/issues/13174/comments","events_url":"https://api.github.com/repos/Wikia/app/issues/13174/events","html_url":"https://github.com/Wikia/app/pull/13174","id":238514965,"number":13174,"title":"SUS-2245: when Chat re-connections limit is reached reload the page","user":{"login":"macbre","id":1929317,"avatar_url":"https://avatars3.githubusercontent.com/u/1929317?v=3","gravatar_id":"","url":"https://api.github.com/users/macbre","html_url":"https://github.com/macbre","followers_url":"https://api.github.com/users/macbre/followers","following_url":"https://api.github.com/users/macbre/following{/other_user}","gists_url":"https://api.github.com/users/macbre/gists{/gist_id}","starred_url":"https://api.github.com/users/macbre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macbre/subscriptions","organizations_url":"https://api.github.com/users/macbre/orgs","repos_url":"https://api.github.com/users/macbre/repos","events_url":"https://api.github.com/users/macbre/events{/privacy}","received_events_url":"https://api.github.com/users/macbre/received_events","type":"User","site_admin":false},"labels":[{"id":406580186,"url":"https://api.github.com/repos/Wikia/app/labels/sus","name":"sus","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-26T11:31:59Z","updated_at":"2017-06-26T11:37:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/13174","html_url":"https://github.com/Wikia/app/pull/13174","diff_url":"https://github.com/Wikia/app/pull/13174.diff","patch_url":"https://github.com/Wikia/app/pull/13174.patch"},"body":"https://wikia-inc.atlassian.net/browse/SUS-2245\r\n\r\nRecent chat load problems were caused by \"cached\" socket.io 1.4.5 clients unable to properly talk to just deployed server running socket.io 2.0.3.\r\n\r\nThis change introduces the client reload when a certain amount of re-connection retries is reached. This will make sure that the client is up to date shortly after the app release (the recent Chat problems were caused by #13124).\r\n\r\nCurrently the Chat client sends dozens of small, handshake requests every second when `socket.io` versions do not match. The server sets new io cookie on each of these requests. Four re-connection tries equals ~500 HTTP requests sent to chat's backend and that equals :fire: on production."},"comment":{"url":"https://api.github.com/repos/Wikia/app/issues/comments/311034943","html_url":"https://github.com/Wikia/app/pull/13174#issuecomment-311034943","issue_url":"https://api.github.com/repos/Wikia/app/issues/13174","id":311034943,"user":{"login":"WikiaTech","id":13279985,"avatar_url":"https://avatars0.githubusercontent.com/u/13279985?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiaTech","html_url":"https://github.com/WikiaTech","followers_url":"https://api.github.com/users/WikiaTech/followers","following_url":"https://api.github.com/users/WikiaTech/following{/other_user}","gists_url":"https://api.github.com/users/WikiaTech/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiaTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiaTech/subscriptions","organizations_url":"https://api.github.com/users/WikiaTech/orgs","repos_url":"https://api.github.com/users/WikiaTech/repos","events_url":"https://api.github.com/users/WikiaTech/events{/privacy}","received_events_url":"https://api.github.com/users/WikiaTech/received_events","type":"User","site_admin":false},"created_at":"2017-06-26T11:37:41Z","updated_at":"2017-06-26T11:37:41Z","body":"SonarQube analysis reported 62 issues\n* ![MAJOR][MAJOR] 52 major\n* ![MINOR][MINOR] 2 minor\n* ![INFO][INFO] 8 info\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR][MAJOR] [ChatController.class.php#L106](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/ChatController.class.php#L106): Don't use an OnMakeGlobalVariablesScript hook handler to register JS variables. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=wikia-php-rules%3AOnMakeGlobalVariablesScript)\n1. ![MAJOR][MAJOR] [controllers.js](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js): File \"controllers.js\" has 1018 lines, which is greater than 1000 authorized. Split it into smaller files. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3AS104)\n1. ![MAJOR][MAJOR] [controllers.js#L83](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js#L83): Remove the unused function parameter \"transport\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3AUnusedFunctionArgument)\n1. ![MAJOR][MAJOR] [controllers.js#L110](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js#L110): Add a \"default\" clause to this \"switch\" statement. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3ASwitchWithoutDefault)\n1. ![MAJOR][MAJOR] [controllers.js#L156](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js#L156): Replace \"==\" with \"===\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3AEqEqEq)\n1. ![MAJOR][MAJOR] [controllers.js#L156](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js#L156): Replace \"!=\" with \"!==\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3AEqEqEq)\n1. ![MAJOR][MAJOR] [controllers.js#L160](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js#L160): Replace \"==\" with \"===\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3AEqEqEq)\n1. ![MAJOR][MAJOR] [controllers.js#L194](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js#L194): Replace \"!=\" with \"!==\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3AEqEqEq)\n1. ![MAJOR][MAJOR] [controllers.js#L265](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js#L265): Remove the unused function parameter \"index\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3AUnusedFunctionArgument)\n1. ![MAJOR][MAJOR] [controllers.js#L280](https://github.com/Wikia/app/blob/2c73ae8174248a1320074c637c64cd2cfd583da7/extensions/wikia/Chat2/js/controllers/controllers.js#L280): Restrict what this loop acts on by testing each property. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.wikia-inc.com/coding_rules#rule_key=javascript%3AForIn)\n\n[INFO]: https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"WikiaTech"}}