{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/14844","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/14844/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/14844/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/14844/events","html_url":"https://github.com/edx/edx-platform/pull/14844","id":220467465,"number":14844,"title":"Use platform_name instead of site_name in password reset email","user":{"login":"Salomari1987","id":19625384,"avatar_url":"https://avatars0.githubusercontent.com/u/19625384?v=3","gravatar_id":"","url":"https://api.github.com/users/Salomari1987","html_url":"https://github.com/Salomari1987","followers_url":"https://api.github.com/users/Salomari1987/followers","following_url":"https://api.github.com/users/Salomari1987/following{/other_user}","gists_url":"https://api.github.com/users/Salomari1987/gists{/gist_id}","starred_url":"https://api.github.com/users/Salomari1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Salomari1987/subscriptions","organizations_url":"https://api.github.com/users/Salomari1987/orgs","repos_url":"https://api.github.com/users/Salomari1987/repos","events_url":"https://api.github.com/users/Salomari1987/events{/privacy}","received_events_url":"https://api.github.com/users/Salomari1987/received_events","type":"User","site_admin":false},"labels":[{"id":128413102,"url":"https://api.github.com/repos/edx/edx-platform/labels/awaiting%20prioritization","name":"awaiting prioritization","color":"fad8c7","default":false},{"id":78051711,"url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-09T12:19:33Z","updated_at":"2017-04-12T13:28:14Z","closed_at":"2017-04-12T13:28:14Z","pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/14844","html_url":"https://github.com/edx/edx-platform/pull/14844","diff_url":"https://github.com/edx/edx-platform/pull/14844.diff","patch_url":"https://github.com/edx/edx-platform/pull/14844.patch"},"body":"# Overview\r\nWhen requesting a password reset, the email message part \"You're receiving this email because you requested a password reset at ....\" is addressed to the site_name, which will refer to courses.edx.org rather than www.edx.org, and a better solution would be to use edX or e.g. Edraak, and plays better with Arabic for example.\r\n\r\n## Steps to Reproduce on local machine\r\n1. Run devstack\r\n1. Add 'ar, en' to DarkLang in Admin\r\n1. Go to localhost:8000\r\n1. Login with staff@example.com\r\n1. Go to settings and change preference language to Arabic\r\n1. Go back to home page\r\n1. Click on Login\r\n1. Click on \"Forgot my password\" or \"نسيت كلمة السر\"\r\n1. Notice the email dump on terminal/CLI\r\n\r\nOn production you can repeat the step on edX platform without the first 2 steps.\r\n\r\n## Expected Results\r\n1. The email should read *You're receiving this e-mail because you requested a password reset for your user account at \"**platform_name**\"*\r\n\r\n## History\r\n* [Fix edX name hardcoded in password reset email #6278](https://github.com/edx/edx-platform/pull/6278) [OSPR-187](https://openedx.atlassian.net/browse/OSPR-187)\r\n\r\n## TODO\r\n[x] Test on devstack\r\n[x] Provide screenshots\r\n[ ] Review by Edraak member @OmarIthawi \r\n[ ] Translate after changes on edX transifex\r\n\r\n## Screenshots\r\n### Before\r\n![before](https://cloud.githubusercontent.com/assets/19625384/24837226/d9196a7e-1d37-11e7-8b29-affc9fdbe538.png)\r\n### After\r\n![after](https://cloud.githubusercontent.com/assets/19625384/24837225/d8f9db3c-1d37-11e7-85aa-5cbb39deaacd.png)\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/293575615","html_url":"https://github.com/edx/edx-platform/pull/14844#issuecomment-293575615","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/14844","id":293575615,"user":{"login":"Salomari1987","id":19625384,"avatar_url":"https://avatars0.githubusercontent.com/u/19625384?v=3","gravatar_id":"","url":"https://api.github.com/users/Salomari1987","html_url":"https://github.com/Salomari1987","followers_url":"https://api.github.com/users/Salomari1987/followers","following_url":"https://api.github.com/users/Salomari1987/following{/other_user}","gists_url":"https://api.github.com/users/Salomari1987/gists{/gist_id}","starred_url":"https://api.github.com/users/Salomari1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Salomari1987/subscriptions","organizations_url":"https://api.github.com/users/Salomari1987/orgs","repos_url":"https://api.github.com/users/Salomari1987/repos","events_url":"https://api.github.com/users/Salomari1987/events{/privacy}","received_events_url":"https://api.github.com/users/Salomari1987/received_events","type":"User","site_admin":false},"created_at":"2017-04-12T13:28:14Z","updated_at":"2017-04-12T13:28:14Z","body":"closing this PR as changes are now included in PR [#14845](https://github.com/edx/edx-platform/pull/14845)"}}
{"actor":{"display_login":"Salomari1987"}}