{"action":"created","issue":{"url":"https://api.github.com/repos/expressjs/express/issues/3390","repository_url":"https://api.github.com/repos/expressjs/express","labels_url":"https://api.github.com/repos/expressjs/express/issues/3390/labels{/name}","comments_url":"https://api.github.com/repos/expressjs/express/issues/3390/comments","events_url":"https://api.github.com/repos/expressjs/express/issues/3390/events","html_url":"https://github.com/expressjs/express/pull/3390","id":248680445,"number":3390,"title":"Initial support proposal for http2","user":{"login":"phouri","id":5173410,"avatar_url":"https://avatars3.githubusercontent.com/u/5173410?v=4","gravatar_id":"","url":"https://api.github.com/users/phouri","html_url":"https://github.com/phouri","followers_url":"https://api.github.com/users/phouri/followers","following_url":"https://api.github.com/users/phouri/following{/other_user}","gists_url":"https://api.github.com/users/phouri/gists{/gist_id}","starred_url":"https://api.github.com/users/phouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phouri/subscriptions","organizations_url":"https://api.github.com/users/phouri/orgs","repos_url":"https://api.github.com/users/phouri/repos","events_url":"https://api.github.com/users/phouri/events{/privacy}","received_events_url":"https://api.github.com/users/phouri/received_events","type":"User","site_admin":false},"labels":[{"id":98481977,"url":"https://api.github.com/repos/expressjs/express/labels/5.x","name":"5.x","color":"ededed","default":false},{"id":59148,"url":"https://api.github.com/repos/expressjs/express/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":55587817,"url":"https://api.github.com/repos/expressjs/express/labels/needs%20tests","name":"needs tests","color":"e11d21","default":false},{"id":133578713,"url":"https://api.github.com/repos/expressjs/express/labels/pr","name":"pr","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":60,"created_at":"2017-08-08T11:11:52Z","updated_at":"2017-09-26T23:25:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/expressjs/express/pulls/3390","html_url":"https://github.com/expressjs/express/pull/3390","diff_url":"https://github.com/expressjs/express/pull/3390.diff","patch_url":"https://github.com/expressjs/express/pull/3390.patch"},"body":"Hi,\r\n\r\nPiniH here - used wrong account before (work...).\r\n\r\nRegarding this issue: https://github.com/expressjs/express/issues/3388\r\n\r\nThis is an initial proposal for making http2 work, this requires node to expose the Http2ServerRequest/Response and creates both request/response on the app and attaches the correct one depending on the request.\r\n\r\nThis is just an initial proposal (and a working example if Http2ServerRequest/Response) is exposed. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/expressjs/express/issues/comments/332364370","html_url":"https://github.com/expressjs/express/pull/3390#issuecomment-332364370","issue_url":"https://api.github.com/repos/expressjs/express/issues/3390","id":332364370,"user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"created_at":"2017-09-26T23:25:36Z","updated_at":"2017-09-26T23:25:36Z","author_association":"NONE","body":"You might attach things to the Http2Stream of the core API. It should work the same as your current socket.\r\n\r\nWe added .socket to the compat layer, but it is not useful at all. We were unsure when we added that, but it might be easier to detect if a socket is not there in the first place.\r\nThe socket is one of the areas were the new protocol would leak through. It is impossible to provide the same functionality there (as for other details, unfortunately the protocol is different)."}}
{"actor":{"display_login":"mcollina"}}