{"push_id":1634003848,"size":1,"distinct_size":1,"ref":"refs/heads/proxy_reuse","head":"b6055a842c52f3f0823b4029caab5181c7d98e7e","before":"337ad474e58ffed2fef3849e8b3d26cba3173559","commits":[{"sha":"b6055a842c52f3f0823b4029caab5181c7d98e7e","author":{"name":"Isaac Boukris","email":"fa578b6a419a3c26ebb5f19df62a12dd4c49805e@gmail.com"},"message":"Fix proxy connection reuse with basic-auth\n\nWhen using basic-auth, connections and proxy connections\ncan be re-used with different Authorization headers since\nit does not authenticate the connection (like NTLM does).\n\nFor instance, the below command should re-use the proxy\nconnection, but it currently doesn't:\ncurl -v -U alice:a -x http://localhost:8181 http://localhost/\n  --next -U bob:b -x http://localhost:8181 http://localhost/\n\nThis is a regression since refactoring of ConnectionExists()\nas part of: cb4e2be7c6d42ca0780f8e0a747cecf9ba45f151\n\nFix the above by removing the username and password compare\nwhen re-using proxy connection at proxy_info_matches().\n\nHowever, this fix brings back another bug would make curl\nto re-print the old proxy-authorization header of previous\nproxy basic-auth connection because it wasn't cleared.\n\nFor instance, in the below command the second request should\nfail if the proxy requires authentication, but would succeed\nafter the above fix (and before aforementioned commit):\ncurl -v -U alice:a -x http://localhost:8181 http://localhost/\n  --next -x http://localhost:8181 http://localhost/\n\nFix this by clearing conn->allocptr.proxyuserpwd after use\nunconditionally, same as we do for conn->allocptr.userpwd.\n\nAlso fix test 540 to not expect digest auth header to be\nresent when connection is reused.\n\nSigned-off-by: Isaac Boukris <iboukris@gmail.com>","distinct":true,"url":"https://api.github.com/repos/frenche/curl/commits/b6055a842c52f3f0823b4029caab5181c7d98e7e"}]}
{"actor":{"display_login":"frenche"}}