{"action":"created","issue":{"url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2645","repository_url":"https://api.github.com/repos/TerriaJS/terriajs","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2645/labels{/name}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2645/comments","events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2645/events","html_url":"https://github.com/TerriaJS/terriajs/pull/2645","id":252794473,"number":2645,"title":"Datetime picker, splitter, item split, time-freeze","user":{"login":"RacingTadpole","id":1757858,"avatar_url":"https://avatars1.githubusercontent.com/u/1757858?v=4","gravatar_id":"","url":"https://api.github.com/users/RacingTadpole","html_url":"https://github.com/RacingTadpole","followers_url":"https://api.github.com/users/RacingTadpole/followers","following_url":"https://api.github.com/users/RacingTadpole/following{/other_user}","gists_url":"https://api.github.com/users/RacingTadpole/gists{/gist_id}","starred_url":"https://api.github.com/users/RacingTadpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RacingTadpole/subscriptions","organizations_url":"https://api.github.com/users/RacingTadpole/orgs","repos_url":"https://api.github.com/users/RacingTadpole/repos","events_url":"https://api.github.com/users/RacingTadpole/events{/privacy}","received_events_url":"https://api.github.com/users/RacingTadpole/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-08-25T04:16:01Z","updated_at":"2017-09-20T05:25:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2645","html_url":"https://github.com/TerriaJS/terriajs/pull/2645","diff_url":"https://github.com/TerriaJS/terriajs/pull/2645.diff","patch_url":"https://github.com/TerriaJS/terriajs/pull/2645.patch"},"body":"Fixes #2608 and #2609 .\r\n\r\nTo do re the datetime picker:\r\n\r\n- [x] I got this on \"Total Vegetation Cover\":\r\n![image](https://user-images.githubusercontent.com/1757858/29696885-f54ce216-898e-11e7-9e8f-4386f4123c54.png)\r\n- [x] It's not obvious that you can click on the datetime to bring up the picker\r\n- [x] Clicking off the picker should close it\r\n- [x] Default to the first time in the list once you've picked a date\r\n- [x] The width of the calendar icon and the date that replaces it are different, which makes the timeline change size when you pick a datetime.\r\n- [x] The back arrow on the year display does nothing - maybe remove?\r\n![image](https://user-images.githubusercontent.com/1757858/29699266-b75e5452-899e-11e7-9e1a-ba61c2721c96.png)\r\n- [x] When a year or month has no dates, should it still highlight the row and display the hand pointer, even though clicking it does nothing? \r\n![image](https://user-images.githubusercontent.com/1757858/29755781-5ad86d3c-8be0-11e7-9993-5b541a072283.png)\r\n- [x] Slightly weird display here: \r\n![image](https://user-images.githubusercontent.com/1757858/29755798-c1c109f0-8be0-11e7-9876-158b9a481ea9.png)\r\n- [ ] Test on Firefox, IE, Safari and Edge. (In particular is the backtick format going to work on IE?)\r\n- [x] Now the picker can appear in the workbench, it can appear more than once. Currently when opened, the datepicker panel can appear under the wrong date.\r\n- [x] Make the datepicker stateless, ie. when it is reopened, it uses the original time.\r\n- [x] When the datepicker is closed, show the calendar icon, not the date. Put the date somewhere else.\r\n- [x] Can you improve the look of the scroll bar here? \r\n![image](https://user-images.githubusercontent.com/1757858/29809119-3e8957aa-8cde-11e7-823f-2a0d4ce295ee.png)\r\n- [ ] When you reach a point where there only a limited number of possible choices (~5-30?), just show them in a list. If there are more, there should be a screen for it - eg. for hours, minutes, seconds (or centuries etc). - Done this with year, but not a lower level yet, it's getting too complicated, i propose we leave it here for now. - Chloe \r\n\r\nTo do re the split capability:\r\n- [x] The latest versions of Chrome, Firefox, Internet Explorer, and Edge on desktop Chrome on Android.\r\n- [x] Touch input on desktop and mobile in all the browsers above.\r\n- [x] Currently using a unicode character for the face of the splitter thumb that is apparently not available on Android, so it looks like a box with an X through it. We could swap this for an SVG, or maybe use a different font? @chloeleichen?\r\n- [x] Check Safari on desktop.\r\n- [x] Check on iOS.\r\n- [x] Check sharing (both per-layer split side and split position should be shared I'd say).\r\n- [ ] Fix sharing mini-preview window to also clip layers (currently ignores the splitter) - 2D.\r\n- [x] Fix sharing mini-preview window to also clip layers (currently ignores the splitter) - 3D.\r\n- [x] Merge in Chloe's new date-time picker\r\n- [ ] Check how stable item cloning really is when you click \"split\".\r\n- [x] Add a checkbox to unfreeze the datetime.\r\n- [ ] Improve the toggle-splitter icon (currently just a checkbox) @chloeleichen?\r\n- [x] In 2D, moving the splitter triggers a feature info request again (@kring?)\r\n- [x] When you open the datetime picker, then go back to the timeline, then when you go back to the datetime picker, the originally picked date is showing, not the latest one. Show the latest one.\r\n- [x] When you turn on the splitter and there is a layer that is not a time based layer, we still show the timestamp selector in the workbench for that layer (this is the bug) together with the left/both/right (not a bug).\r\n- [x] When you have the splitter active with an enabled layer in either the Left or Right configuration, using the new DateTimeControl in the workbench to select a new time shows the new imagery on Both sides. In order to get it back to just one side you have to press Both or the opposite side currently indicated, and then back to the side you want. (3D only.)\r\n- [x] The `Split` action in the workbench control doesn't work, and just returns this error message: `No layer found\r\nThe WMS dataset \"Total Vegetation Cover (PV + NPV) (copy)\" has no layers matching \"\".` (I've seen it work before, maybe this is just something wrong with my build?)\r\n- [x] When you resize the window (or do a window zoom in/out), the slider location and imagery gets out of sync.\r\n- [x] The option to \"split\" does not re-appear after you have removed one of the duplicate items.\r\n- [ ] Review.\r\n\r\nDeferred:\r\n- [ ] We could split region-mapped layers too.\r\n\r\n(Some tasks courtesy of https://github.com/TerriaJS/terriajs/pull/2627.)\r\n"},"comment":{"url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments/330748631","html_url":"https://github.com/TerriaJS/terriajs/pull/2645#issuecomment-330748631","issue_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2645","id":330748631,"user":{"login":"kring","id":924374,"avatar_url":"https://avatars0.githubusercontent.com/u/924374?v=4","gravatar_id":"","url":"https://api.github.com/users/kring","html_url":"https://github.com/kring","followers_url":"https://api.github.com/users/kring/followers","following_url":"https://api.github.com/users/kring/following{/other_user}","gists_url":"https://api.github.com/users/kring/gists{/gist_id}","starred_url":"https://api.github.com/users/kring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kring/subscriptions","organizations_url":"https://api.github.com/users/kring/orgs","repos_url":"https://api.github.com/users/kring/repos","events_url":"https://api.github.com/users/kring/events{/privacy}","received_events_url":"https://api.github.com/users/kring/received_events","type":"User","site_admin":false},"created_at":"2017-09-20T05:25:01Z","updated_at":"2017-09-20T05:25:01Z","author_association":"OWNER","body":"Some weirdness with the `Split` option in the workbench.  When I click Split, the Split option vanishes, but the new item that gets created has a Split option.  If I remove the item with the Split option, the Split option does not reappear on the other item."}}
{"actor":{"display_login":"kring"}}