{"action":"created","issue":{"url":"https://api.github.com/repos/biopython/biopython/issues/1309","repository_url":"https://api.github.com/repos/biopython/biopython","labels_url":"https://api.github.com/repos/biopython/biopython/issues/1309/labels{/name}","comments_url":"https://api.github.com/repos/biopython/biopython/issues/1309/comments","events_url":"https://api.github.com/repos/biopython/biopython/issues/1309/events","html_url":"https://github.com/biopython/biopython/pull/1309","id":240603244,"number":1309,"title":"Feature location equality","user":{"login":"kblin","id":76448,"avatar_url":"https://avatars3.githubusercontent.com/u/76448?v=3","gravatar_id":"","url":"https://api.github.com/users/kblin","html_url":"https://github.com/kblin","followers_url":"https://api.github.com/users/kblin/followers","following_url":"https://api.github.com/users/kblin/following{/other_user}","gists_url":"https://api.github.com/users/kblin/gists{/gist_id}","starred_url":"https://api.github.com/users/kblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblin/subscriptions","organizations_url":"https://api.github.com/users/kblin/orgs","repos_url":"https://api.github.com/users/kblin/repos","events_url":"https://api.github.com/users/kblin/events{/privacy}","received_events_url":"https://api.github.com/users/kblin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-05T10:14:07Z","updated_at":"2017-07-06T09:28:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/biopython/biopython/pulls/1309","html_url":"https://github.com/biopython/biopython/pull/1309","diff_url":"https://github.com/biopython/biopython/pull/1309.diff","patch_url":"https://github.com/biopython/biopython/pull/1309.patch"},"body":"As discussed with @peterjc on Twitter, it would be nice to have a strict* equality check for `FeatureLocation` and `CompoundLocation` objects. This allows to directly compare locations using `==` and `!=` instead of having to go via `list(loc_a) == list(loc_b)` or similar.\r\n\r\n\r\n* This is strict in as much as a `BeforePosition(x)` or `AfterPosition(x)` is assumed to be equal to an `ExactPosition(x)`, but this matches our other non-string conversions of fuzzy features. This can lead to a situation where `loc_a == loc_b` is `True` but `str(loc_a) == str(loc_b)` is `False`. It does match the behaviour for comparisons via a `list` conversion, though."},"comment":{"url":"https://api.github.com/repos/biopython/biopython/issues/comments/313345255","html_url":"https://github.com/biopython/biopython/pull/1309#issuecomment-313345255","issue_url":"https://api.github.com/repos/biopython/biopython/issues/1309","id":313345255,"user":{"login":"peterjc","id":63959,"avatar_url":"https://avatars1.githubusercontent.com/u/63959?v=3","gravatar_id":"","url":"https://api.github.com/users/peterjc","html_url":"https://github.com/peterjc","followers_url":"https://api.github.com/users/peterjc/followers","following_url":"https://api.github.com/users/peterjc/following{/other_user}","gists_url":"https://api.github.com/users/peterjc/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjc/subscriptions","organizations_url":"https://api.github.com/users/peterjc/orgs","repos_url":"https://api.github.com/users/peterjc/repos","events_url":"https://api.github.com/users/peterjc/events{/privacy}","received_events_url":"https://api.github.com/users/peterjc/received_events","type":"User","site_admin":false},"created_at":"2017-07-06T09:28:10Z","updated_at":"2017-07-06T09:28:10Z","body":"You can remove the ``identical`` variable now.\r\n\r\nYou are already in the ``CONTRIB.rst`` file, but we would add your name the ``NEWS.rst`` as contributing to Biopython 1.70.\r\n\r\nI'm happy to come back to this later today, merge it, and do that final tidying myself - but if you want to update the pull request now, please go ahead. Thanks."}}
{"actor":{"display_login":"peterjc"}}