{"action":"created","issue":{"url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide/issues/228","repository_url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide","labels_url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide/issues/228/comments","events_url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide/issues/228/events","html_url":"https://github.com/AmericanMedicalAssociation/AMA-style-guide/pull/228","id":259851762,"number":228,"title":"\"link\" is special to PatternLab, so change it.","user":{"login":"froboy","id":238201,"avatar_url":"https://avatars3.githubusercontent.com/u/238201?v=4","gravatar_id":"","url":"https://api.github.com/users/froboy","html_url":"https://github.com/froboy","followers_url":"https://api.github.com/users/froboy/followers","following_url":"https://api.github.com/users/froboy/following{/other_user}","gists_url":"https://api.github.com/users/froboy/gists{/gist_id}","starred_url":"https://api.github.com/users/froboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/froboy/subscriptions","organizations_url":"https://api.github.com/users/froboy/orgs","repos_url":"https://api.github.com/users/froboy/repos","events_url":"https://api.github.com/users/froboy/events{/privacy}","received_events_url":"https://api.github.com/users/froboy/received_events","type":"User","site_admin":false},"labels":[{"id":481426142,"url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"froboy","id":238201,"avatar_url":"https://avatars3.githubusercontent.com/u/238201?v=4","gravatar_id":"","url":"https://api.github.com/users/froboy","html_url":"https://github.com/froboy","followers_url":"https://api.github.com/users/froboy/followers","following_url":"https://api.github.com/users/froboy/following{/other_user}","gists_url":"https://api.github.com/users/froboy/gists{/gist_id}","starred_url":"https://api.github.com/users/froboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/froboy/subscriptions","organizations_url":"https://api.github.com/users/froboy/orgs","repos_url":"https://api.github.com/users/froboy/repos","events_url":"https://api.github.com/users/froboy/events{/privacy}","received_events_url":"https://api.github.com/users/froboy/received_events","type":"User","site_admin":false},"assignees":[{"login":"froboy","id":238201,"avatar_url":"https://avatars3.githubusercontent.com/u/238201?v=4","gravatar_id":"","url":"https://api.github.com/users/froboy","html_url":"https://github.com/froboy","followers_url":"https://api.github.com/users/froboy/followers","following_url":"https://api.github.com/users/froboy/following{/other_user}","gists_url":"https://api.github.com/users/froboy/gists{/gist_id}","starred_url":"https://api.github.com/users/froboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/froboy/subscriptions","organizations_url":"https://api.github.com/users/froboy/orgs","repos_url":"https://api.github.com/users/froboy/repos","events_url":"https://api.github.com/users/froboy/events{/privacy}","received_events_url":"https://api.github.com/users/froboy/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-09-22T15:26:29Z","updated_at":"2017-09-22T20:06:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide/pulls/228","html_url":"https://github.com/AmericanMedicalAssociation/AMA-style-guide/pull/228","diff_url":"https://github.com/AmericanMedicalAssociation/AMA-style-guide/pull/228.diff","patch_url":"https://github.com/AmericanMedicalAssociation/AMA-style-guide/pull/228.patch"},"body":"<!-- NOTE: Please just put \"N/A\" for any section below that isn't applicable to the work you've done, do not omit entirely. -->\r\n\r\n## Ticket(s)\r\n\r\nPlease do not submit a Pull Request without a relevant ticket! If you are creating a new pattern or feature, create an issue describing the need for this feature Github **first** and then link to it below.\r\n\r\n**Github Issue**\r\n\r\nNA\r\n\r\n**Jira Ticket**\r\n\r\nNA\r\n\r\n## Description\r\n\r\nI noticed that our releases have some bad errors in them https://github.com/AmericanMedicalAssociation/AMA-style-guide/commit/342eff381b741a738f8b300c8fe7650db5c00815#diff-054ec3338519b2035b678891aea1da52R37 and tracked it down to \"link\" being a special PatternLab variable http://patternlab.io/docs/data-link-variable.html. This rewrites all references of \"link\" to \"href\". It fixes those errors.\r\n\r\n## To Test\r\n\r\n- `gulp serve`\r\n- Observe fewer PHP errors (if any)\r\n- Observe the href in the updated patterns is a non-error string now.\r\n\r\n\r\n## Relevant Screenshots/GIFs\r\n\r\nUse something like [Skitch](https://evernote.com/skitch/) or [GIPHY Capture](https://giphy.com/apps/giphycapture) to capture images/gifs to demonstrate behaviors.\r\n\r\n\r\n## Remaining Tasks\r\n\r\nRemaining tasks?\r\n\r\n\r\n## Additional Notes\r\n\r\nAnything more to add?\r\n"},"comment":{"url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide/issues/comments/331548046","html_url":"https://github.com/AmericanMedicalAssociation/AMA-style-guide/pull/228#issuecomment-331548046","issue_url":"https://api.github.com/repos/AmericanMedicalAssociation/AMA-style-guide/issues/228","id":331548046,"user":{"login":"froboy","id":238201,"avatar_url":"https://avatars3.githubusercontent.com/u/238201?v=4","gravatar_id":"","url":"https://api.github.com/users/froboy","html_url":"https://github.com/froboy","followers_url":"https://api.github.com/users/froboy/followers","following_url":"https://api.github.com/users/froboy/following{/other_user}","gists_url":"https://api.github.com/users/froboy/gists{/gist_id}","starred_url":"https://api.github.com/users/froboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/froboy/subscriptions","organizations_url":"https://api.github.com/users/froboy/orgs","repos_url":"https://api.github.com/users/froboy/repos","events_url":"https://api.github.com/users/froboy/events{/privacy}","received_events_url":"https://api.github.com/users/froboy/received_events","type":"User","site_admin":false},"created_at":"2017-09-22T20:06:47Z","updated_at":"2017-09-22T20:06:47Z","author_association":"CONTRIBUTOR","body":"![bitmoji](https://render.bitstrips.com/v2/cpanel/9281517-136783776_2-s4-v1.png?transparent=1&palette=1&width=246)"}}
{"actor":{"display_login":"froboy"}}