{"action":"created","issue":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/2739","repository_url":"https://api.github.com/repos/supercollider/supercollider","labels_url":"https://api.github.com/repos/supercollider/supercollider/issues/2739/labels{/name}","comments_url":"https://api.github.com/repos/supercollider/supercollider/issues/2739/comments","events_url":"https://api.github.com/repos/supercollider/supercollider/issues/2739/events","html_url":"https://github.com/supercollider/supercollider/pull/2739","id":209248869,"number":2739,"title":"Win: avoid returning hidden and initial-dot-files in .pathMatch","user":{"login":"bagong","id":1502057,"avatar_url":"https://avatars.githubusercontent.com/u/1502057?v=3","gravatar_id":"","url":"https://api.github.com/users/bagong","html_url":"https://github.com/bagong","followers_url":"https://api.github.com/users/bagong/followers","following_url":"https://api.github.com/users/bagong/following{/other_user}","gists_url":"https://api.github.com/users/bagong/gists{/gist_id}","starred_url":"https://api.github.com/users/bagong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bagong/subscriptions","organizations_url":"https://api.github.com/users/bagong/orgs","repos_url":"https://api.github.com/users/bagong/repos","events_url":"https://api.github.com/users/bagong/events{/privacy}","received_events_url":"https://api.github.com/users/bagong/received_events","type":"User","site_admin":false},"labels":[{"id":190319001,"url":"https://api.github.com/repos/supercollider/supercollider/labels/API%20change","name":"API change","color":"fbca04","default":false},{"id":4477094,"url":"https://api.github.com/repos/supercollider/supercollider/labels/comp:%20sclang","name":"comp: sclang","color":"CFFF7D","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/supercollider/supercollider/milestones/11","html_url":"https://github.com/supercollider/supercollider/milestone/11","labels_url":"https://api.github.com/repos/supercollider/supercollider/milestones/11/labels","id":1702022,"number":11,"title":"3.9","description":"","creator":{"login":"crucialfelix","id":218738,"avatar_url":"https://avatars.githubusercontent.com/u/218738?v=3","gravatar_id":"","url":"https://api.github.com/users/crucialfelix","html_url":"https://github.com/crucialfelix","followers_url":"https://api.github.com/users/crucialfelix/followers","following_url":"https://api.github.com/users/crucialfelix/following{/other_user}","gists_url":"https://api.github.com/users/crucialfelix/gists{/gist_id}","starred_url":"https://api.github.com/users/crucialfelix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crucialfelix/subscriptions","organizations_url":"https://api.github.com/users/crucialfelix/orgs","repos_url":"https://api.github.com/users/crucialfelix/repos","events_url":"https://api.github.com/users/crucialfelix/events{/privacy}","received_events_url":"https://api.github.com/users/crucialfelix/received_events","type":"User","site_admin":false},"open_issues":126,"closed_issues":132,"state":"open","created_at":"2016-04-12T17:52:08Z","updated_at":"2017-02-23T17:48:58Z","due_on":"2017-04-01T07:00:00Z","closed_at":null},"comments":5,"created_at":"2017-02-21T19:31:27Z","updated_at":"2017-02-23T17:52:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/supercollider/supercollider/pulls/2739","html_url":"https://github.com/supercollider/supercollider/pull/2739","diff_url":"https://github.com/supercollider/supercollider/pull/2739.diff","patch_url":"https://github.com/supercollider/supercollider/pull/2739.patch"},"body":"Something tangible for #2738\r\n\r\nCurrently on Windows pathMatch shows normal files, hidden files, and dot-prepended paths. This PR excludes hidden files (that's the same in all platforms) and also dot-prepended paths (to align with unix) although they are not considered hidden on Windows."},"comment":{"url":"https://api.github.com/repos/supercollider/supercollider/issues/comments/282067949","html_url":"https://github.com/supercollider/supercollider/pull/2739#issuecomment-282067949","issue_url":"https://api.github.com/repos/supercollider/supercollider/issues/2739","id":282067949,"user":{"login":"bagong","id":1502057,"avatar_url":"https://avatars.githubusercontent.com/u/1502057?v=3","gravatar_id":"","url":"https://api.github.com/users/bagong","html_url":"https://github.com/bagong","followers_url":"https://api.github.com/users/bagong/followers","following_url":"https://api.github.com/users/bagong/following{/other_user}","gists_url":"https://api.github.com/users/bagong/gists{/gist_id}","starred_url":"https://api.github.com/users/bagong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bagong/subscriptions","organizations_url":"https://api.github.com/users/bagong/orgs","repos_url":"https://api.github.com/users/bagong/repos","events_url":"https://api.github.com/users/bagong/events{/privacy}","received_events_url":"https://api.github.com/users/bagong/received_events","type":"User","site_admin":false},"created_at":"2017-02-23T17:52:03Z","updated_at":"2017-02-23T17:52:03Z","body":"> The alternative I am proposing is exactly that. Give users one function that clobbers the Windows filesystem, and one that respects the native environment. The difference in effort between doing that, and making the changes you've made so far, is much less than you say it is.\r\n\r\nSorry, I have difficulties understanding this (maybe linguistic). The one that clobbers should return all files, regardless of how dangerous they are? (current on Windows) \"Native environment\" refers to unixy SC?\r\n\r\n> Also, I can find \"hidden\" files in root simply by asking for \"/.*\".pathMatch. This pathMatch also returns /./ and /../. Is that good or bad behavior? Again, another case where giving clear specifications with words like \"always\" and \"never\" would help a lot.\r\n\r\nI didn't realize that! That's difficult to reproduce with the current exclusion logic... :("}}
{"actor":{"display_login":"bagong"}}