{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/155255796","pull_request_review_id":81544112,"id":155255796,"diff_hunk":"@@ -256,6 +292,57 @@ class CarbonSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser) extends\n     }\n   }\n \n+  override def visitChangeColumn(ctx: ChangeColumnContext): LogicalPlan = {\n+\n+    val newColumn = visitColType(ctx.colType)\n+    if (!ctx.identifier.getText.equalsIgnoreCase(newColumn.name)) {\n+      throw new MalformedCarbonCommandException(\n+        \"Column names provided are different. Both the column names should be same\")\n+    }\n+\n+    val (typeString, values) : (String, Option[List[(Int, Int)]]) = newColumn.dataType match {\n+      case d:DecimalType => (\"decimal\", Some(List((d.precision, d.scale))))\n+      case _ => (newColumn.dataType.typeName.toLowerCase, None)\n+    }\n+\n+    val alterTableChangeDataTypeModel =\n+      AlterTableDataTypeChangeModel(new CarbonSpark2SqlParser().parseDataType(typeString, values),\n+        new CarbonSpark2SqlParser()\n+          .convertDbNameToLowerCase(Option(ctx.tableIdentifier().db).map(_.getText)),\n+        ctx.tableIdentifier().table.getText.toLowerCase,\n+        ctx.identifier.getText.toLowerCase,\n+        newColumn.name.toLowerCase)\n+\n+    CarbonAlterTableDataTypeChangeCommand(alterTableChangeDataTypeModel)\n+  }\n+\n+\n+  override def visitAddTableColumns(ctx: AddTableColumnsContext): LogicalPlan = {","path":"integration/spark2/src/main/spark2.2/CarbonSessionState.scala","position":138,"original_position":138,"commit_id":"6fe5feab2349d18eb82a9e2ab7fadcc7ac3bcdc8","original_commit_id":"6fe5feab2349d18eb82a9e2ab7fadcc7ac3bcdc8","user":{"login":"ravipesala","id":8134086,"avatar_url":"https://avatars2.githubusercontent.com/u/8134086?v=4","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"body":"Better you can catch the command at strategy rather than changing in parser","created_at":"2017-12-06T14:47:28Z","updated_at":"2017-12-06T14:47:28Z","html_url":"https://github.com/apache/carbondata/pull/1595#discussion_r155255796","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/1595","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/155255796"},"html":{"href":"https://github.com/apache/carbondata/pull/1595#discussion_r155255796"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/1595"}}},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/1595","id":155399242,"html_url":"https://github.com/apache/carbondata/pull/1595","diff_url":"https://github.com/apache/carbondata/pull/1595.diff","patch_url":"https://github.com/apache/carbondata/pull/1595.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/1595","number":1595,"state":"open","locked":false,"title":"[CARBONDATA-1868][Spark-2.2]Carbon-Spark2.2 Integration Phase 2","user":{"login":"sounakr","id":14341802,"avatar_url":"https://avatars3.githubusercontent.com/u/14341802?v=4","gravatar_id":"","url":"https://api.github.com/users/sounakr","html_url":"https://github.com/sounakr","followers_url":"https://api.github.com/users/sounakr/followers","following_url":"https://api.github.com/users/sounakr/following{/other_user}","gists_url":"https://api.github.com/users/sounakr/gists{/gist_id}","starred_url":"https://api.github.com/users/sounakr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sounakr/subscriptions","organizations_url":"https://api.github.com/users/sounakr/orgs","repos_url":"https://api.github.com/users/sounakr/repos","events_url":"https://api.github.com/users/sounakr/events{/privacy}","received_events_url":"https://api.github.com/users/sounakr/received_events","type":"User","site_admin":false},"body":"Enable Spark2.2 Integration for feature like \r\n1. Alter Table Add and Modify Columns\r\n2. Update | Delete \r\n3. SubQuery Handling \r\n4. SubqueryAlias Handling \r\n5. Preaggregate handling for Spark2.2\r\n6. Small Bug Fixes. \r\n\r\n - [ ] Any interfaces changed?\r\n No\r\n \r\n - [ ] Any backward compatibility impacted?\r\n No\r\n\r\n - [ ] Document update required?\r\n No\r\n\r\n - [ ] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n        - How it is tested? Please attach test report.\r\n        - Is it a performance related change? Please attach the performance test report.\r\n        - Any additional information to help reviewers in testing this change.\r\n NA\r\n       \r\n - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\nNA\r\n\r\n","created_at":"2017-11-29T17:07:44Z","updated_at":"2017-12-06T14:47:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d7e00ed20c0fde14f8935362afee30cd228b50f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/1595/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/1595/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/1595/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/6fe5feab2349d18eb82a9e2ab7fadcc7ac3bcdc8","head":{"label":"sounakr:Carbon-2.2-Alter","ref":"Carbon-2.2-Alter","sha":"6fe5feab2349d18eb82a9e2ab7fadcc7ac3bcdc8","user":{"login":"sounakr","id":14341802,"avatar_url":"https://avatars3.githubusercontent.com/u/14341802?v=4","gravatar_id":"","url":"https://api.github.com/users/sounakr","html_url":"https://github.com/sounakr","followers_url":"https://api.github.com/users/sounakr/followers","following_url":"https://api.github.com/users/sounakr/following{/other_user}","gists_url":"https://api.github.com/users/sounakr/gists{/gist_id}","starred_url":"https://api.github.com/users/sounakr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sounakr/subscriptions","organizations_url":"https://api.github.com/users/sounakr/orgs","repos_url":"https://api.github.com/users/sounakr/repos","events_url":"https://api.github.com/users/sounakr/events{/privacy}","received_events_url":"https://api.github.com/users/sounakr/received_events","type":"User","site_admin":false},"repo":{"id":77815028,"name":"incubator-carbondata","full_name":"sounakr/incubator-carbondata","owner":{"login":"sounakr","id":14341802,"avatar_url":"https://avatars3.githubusercontent.com/u/14341802?v=4","gravatar_id":"","url":"https://api.github.com/users/sounakr","html_url":"https://github.com/sounakr","followers_url":"https://api.github.com/users/sounakr/followers","following_url":"https://api.github.com/users/sounakr/following{/other_user}","gists_url":"https://api.github.com/users/sounakr/gists{/gist_id}","starred_url":"https://api.github.com/users/sounakr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sounakr/subscriptions","organizations_url":"https://api.github.com/users/sounakr/orgs","repos_url":"https://api.github.com/users/sounakr/repos","events_url":"https://api.github.com/users/sounakr/events{/privacy}","received_events_url":"https://api.github.com/users/sounakr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sounakr/incubator-carbondata","description":"Mirror of Apache CarbonData (Incubating)","fork":true,"url":"https://api.github.com/repos/sounakr/incubator-carbondata","forks_url":"https://api.github.com/repos/sounakr/incubator-carbondata/forks","keys_url":"https://api.github.com/repos/sounakr/incubator-carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sounakr/incubator-carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sounakr/incubator-carbondata/teams","hooks_url":"https://api.github.com/repos/sounakr/incubator-carbondata/hooks","issue_events_url":"https://api.github.com/repos/sounakr/incubator-carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/sounakr/incubator-carbondata/events","assignees_url":"https://api.github.com/repos/sounakr/incubator-carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/sounakr/incubator-carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/sounakr/incubator-carbondata/tags","blobs_url":"https://api.github.com/repos/sounakr/incubator-carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sounakr/incubator-carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sounakr/incubator-carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/sounakr/incubator-carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sounakr/incubator-carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/sounakr/incubator-carbondata/languages","stargazers_url":"https://api.github.com/repos/sounakr/incubator-carbondata/stargazers","contributors_url":"https://api.github.com/repos/sounakr/incubator-carbondata/contributors","subscribers_url":"https://api.github.com/repos/sounakr/incubator-carbondata/subscribers","subscription_url":"https://api.github.com/repos/sounakr/incubator-carbondata/subscription","commits_url":"https://api.github.com/repos/sounakr/incubator-carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/sounakr/incubator-carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/sounakr/incubator-carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/sounakr/incubator-carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/sounakr/incubator-carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/sounakr/incubator-carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sounakr/incubator-carbondata/merges","archive_url":"https://api.github.com/repos/sounakr/incubator-carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sounakr/incubator-carbondata/downloads","issues_url":"https://api.github.com/repos/sounakr/incubator-carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/sounakr/incubator-carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/sounakr/incubator-carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/sounakr/incubator-carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sounakr/incubator-carbondata/labels{/name}","releases_url":"https://api.github.com/repos/sounakr/incubator-carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/sounakr/incubator-carbondata/deployments","created_at":"2017-01-02T06:25:07Z","updated_at":"2017-01-02T06:25:13Z","pushed_at":"2017-12-06T12:59:19Z","git_url":"git://github.com/sounakr/incubator-carbondata.git","ssh_url":"git@github.com:sounakr/incubator-carbondata.git","clone_url":"https://github.com/sounakr/incubator-carbondata.git","svn_url":"https://github.com/sounakr/incubator-carbondata","homepage":null,"size":51542,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e2a2d99316de86144ae47b5e25759a658c19e927","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"name":"carbondata","full_name":"apache/carbondata","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2017-12-06T13:30:43Z","pushed_at":"2017-12-06T14:37:37Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":51656,"stargazers_count":534,"watchers_count":534,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":358,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":358,"open_issues":122,"watchers":534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/1595"},"html":{"href":"https://github.com/apache/carbondata/pull/1595"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/1595"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/1595/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/1595/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/1595/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/6fe5feab2349d18eb82a9e2ab7fadcc7ac3bcdc8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ravipesala"}}