{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/4629","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/4629/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/4629/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/4629/events","html_url":"https://github.com/qgis/QGIS/pull/4629","id":231009289,"number":4629,"title":"Add layer button","user":{"login":"elpaso","id":142164,"avatar_url":"https://avatars2.githubusercontent.com/u/142164?v=3","gravatar_id":"","url":"https://api.github.com/users/elpaso","html_url":"https://github.com/elpaso","followers_url":"https://api.github.com/users/elpaso/followers","following_url":"https://api.github.com/users/elpaso/following{/other_user}","gists_url":"https://api.github.com/users/elpaso/gists{/gist_id}","starred_url":"https://api.github.com/users/elpaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elpaso/subscriptions","organizations_url":"https://api.github.com/users/elpaso/orgs","repos_url":"https://api.github.com/users/elpaso/repos","events_url":"https://api.github.com/users/elpaso/events{/privacy}","received_events_url":"https://api.github.com/users/elpaso/received_events","type":"User","site_admin":false},"labels":[{"id":310142278,"url":"https://api.github.com/repos/qgis/QGIS/labels/Feature","name":"Feature","color":"bfd4f2","default":false},{"id":330645596,"url":"https://api.github.com/repos/qgis/QGIS/labels/Feedback","name":"Feedback","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":46,"created_at":"2017-05-24T11:34:25Z","updated_at":"2017-06-06T08:40:02Z","closed_at":"2017-06-02T17:26:08Z","pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/4629","html_url":"https://github.com/qgis/QGIS/pull/4629","diff_url":"https://github.com/qgis/QGIS/pull/4629.diff","patch_url":"https://github.com/qgis/QGIS/pull/4629.patch"},"body":"## Description\r\n\r\nThe unified add layers button and dialog as discussed in Essen (see: https://docs.google.com/document/d/1aMX9jOfl10q8oETRzOHSHnRpHCc7UJ1dDnCCq3VyTAY/edit )\r\n![unibutton-3](https://cloud.githubusercontent.com/assets/142164/26438850/af12a47c-4125-11e7-9d86-246397a27b2e.gif)\r\n\r\n## TODO\r\n\r\n- [x] Raster layers\r\n- [x] Virtual layers\r\n- [x] Delimited text layers\r\n- [x] GUI Styles\r\n- [x] Dialogs sizing\r\n- [x] Left icon bar collapsible\r\n- [x] Delimited text dialog refactoring (this is really too wide and a bit confusing)\r\n- [x] Vector layers dialog sizing (fixed width: does not adapt to widget container)\r\n- [x] Persist dialog status (active tab etc.)\r\n- [x] Settings option for modeless Dialog\r\n- [x] Methods and key bindings to open the dialog on a particular selection page\r\n~~Dockable? See questions below~~ <<< nobody wants it\r\n\r\n\r\n## Open questions\r\n\r\nThere are still some open questions where I'd like some feedback:\r\n\r\n~~1 Should the dialog be also available as a dockable panel? If yes, what's the best UX pattern to let the users choose what behavior they want (a global setting, a GUI checkbox inside the dialog, a push button ...) ?~~ <<< nobody wants it\r\n2. I would like to keep the current layers toolbar available (maybe disabled by default) power users may need it, in this case the unified button should probably stay in its own toolbar to allow for customization\r\n3. For the same reason I'd like to keep the menu entries and their shortcuts.\r\n4. for both 2 and 3, we can either keep the current behavior (they open the individual provider dialog) or turn it into opening the unified dialog wtith the correct \"tab\" open\r\n\r\n\r\nLooking forward to hear your feedback!\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/306420607","html_url":"https://github.com/qgis/QGIS/pull/4629#issuecomment-306420607","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/4629","id":306420607,"user":{"login":"shenriod","id":23653367,"avatar_url":"https://avatars2.githubusercontent.com/u/23653367?v=3","gravatar_id":"","url":"https://api.github.com/users/shenriod","html_url":"https://github.com/shenriod","followers_url":"https://api.github.com/users/shenriod/followers","following_url":"https://api.github.com/users/shenriod/following{/other_user}","gists_url":"https://api.github.com/users/shenriod/gists{/gist_id}","starred_url":"https://api.github.com/users/shenriod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shenriod/subscriptions","organizations_url":"https://api.github.com/users/shenriod/orgs","repos_url":"https://api.github.com/users/shenriod/repos","events_url":"https://api.github.com/users/shenriod/events{/privacy}","received_events_url":"https://api.github.com/users/shenriod/received_events","type":"User","site_admin":false},"created_at":"2017-06-06T08:40:02Z","updated_at":"2017-06-06T08:40:02Z","body":"Thanks all who contributed to this new feature!\r\n\r\nA few comments and requests for opinions after a few tests:\r\n\r\n**Behavior of the Raster provider**\r\nI agree with @nyalldawson and @nirvn  that the raster provider should not open directly the browser. A very simple UI (only with the browse button?) would probably be more intuitive for the users\r\n\r\n**DB2 Icon with non-transparent background**\r\nI checked the svg here https://github.com/qgis/QGIS/blob/master/images/themes/default/mIconDb2.svg and here https://github.com/qgis/QGIS/blob/master/images/themes/default/mActionAddDb2Layer.svg and they seem to have a transparent background. Thus not sure why it's not being rendered correctly?\r\n\r\n**Order of the icons**\r\nI would suggest a re-ordering of the icons (and slight renaming), so that all file-based types are together, all db-based together, etc...\r\n\r\nWhat about:\r\n- Browser\r\n- Vector (not _Vector files_)\r\n- Delimited Text\r\n_[separation line]_\r\n- PostgreSQL\r\n- Spatialite\r\n- MSSQL\r\n- DB2\r\n_[separation line]_\r\n- WMS\r\n- WFS\r\n- WCS\r\n- ArcGIS Map Server\r\n- ArcGIS Feature Server\r\n_[separation line]_\r\n- Virtual layer (not _Virtual_)\r\n\r\nAny opinion / objection on this?\r\n\r\nCheers!"}}
{"actor":{"display_login":"shenriod"}}