{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/112594954","pull_request_review_id":33922733,"id":112594954,"diff_hunk":"@@ -45,8 +46,14 @@ Clouds::Clouds(\n \tscene::ISceneNode(parent, mgr, id),\n \tm_seed(seed),\n \tm_camera_pos(0,0),\n-\tm_time(0),\n-\tm_camera_offset(0,0,0)\n+\tm_origin(0, 0),\n+\tm_speed(0, -2),\n+\tm_camera_offset(0,0,0),\n+\tm_density(0.4),\n+\tm_thickness(16 * BS),","path":"src/clouds.cpp","position":18,"original_position":18,"commit_id":"6431780e5bec5eb034b07e2de34f314a27d6bd07","original_commit_id":"6431780e5bec5eb034b07e2de34f314a27d6bd07","user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars3.githubusercontent.com/u/3686677?v=3","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"body":"16.0f * BS","created_at":"2017-04-21T01:48:52Z","updated_at":"2017-04-21T01:48:52Z","html_url":"https://github.com/minetest/minetest/pull/4524#discussion_r112594954","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/4524","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/112594954"},"html":{"href":"https://github.com/minetest/minetest/pull/4524#discussion_r112594954"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4524"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/4524","id":85519095,"html_url":"https://github.com/minetest/minetest/pull/4524","diff_url":"https://github.com/minetest/minetest/pull/4524.diff","patch_url":"https://github.com/minetest/minetest/pull/4524.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/4524","number":4524,"state":"open","locked":false,"title":"Clouds api","user":{"login":"bendeutsch","id":2880643,"avatar_url":"https://avatars1.githubusercontent.com/u/2880643?v=3","gravatar_id":"","url":"https://api.github.com/users/bendeutsch","html_url":"https://github.com/bendeutsch","followers_url":"https://api.github.com/users/bendeutsch/followers","following_url":"https://api.github.com/users/bendeutsch/following{/other_user}","gists_url":"https://api.github.com/users/bendeutsch/gists{/gist_id}","starred_url":"https://api.github.com/users/bendeutsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendeutsch/subscriptions","organizations_url":"https://api.github.com/users/bendeutsch/orgs","repos_url":"https://api.github.com/users/bendeutsch/repos","events_url":"https://api.github.com/users/bendeutsch/events{/privacy}","received_events_url":"https://api.github.com/users/bendeutsch/received_events","type":"User","site_admin":false},"body":"This is a first attempt at a cloud API for mods, allowing them to set the cloud density (between 0.0 and 1.0), the cloud color, and a cloud \"glow\", i.e. a minimal brightness, even at night.\n\nIncludes a Lua player method for setting all parameters (at once), a new network package type and some accessors on the Clouds and Sky classes.\n\nAt the time of writing, this is very much a work in progress. There is no way for mods to get the current settings, or to change just one aspect of clouds. The network protocol is also quite rigid and assumes a fixed set of fields, which could be a problem for forward compatibility.\n\nI'd also like to eventually rearrange the sky and cloud code a bit; at the moment, the Sky class holds the cloud color, because it's the only one that knows about dawn and transition times.\n\nComments welcome!\n","created_at":"2016-09-16T05:00:46Z","updated_at":"2017-04-21T01:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c013800e6da4feac686aff61b0abf28e3cdb12e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/minetest/minetest/milestones/8","html_url":"https://github.com/minetest/minetest/milestone/8","labels_url":"https://api.github.com/repos/minetest/minetest/milestones/8/labels","id":2252366,"number":8,"title":"0.4.16","description":"","creator":{"login":"est31","id":8872119,"avatar_url":"https://avatars1.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":26,"state":"open","created_at":"2017-01-15T04:12:46Z","updated_at":"2017-04-20T06:16:23Z","due_on":"2017-05-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/4524/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/4524/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/4524/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/6431780e5bec5eb034b07e2de34f314a27d6bd07","head":{"label":"bendeutsch:clouds-api","ref":"clouds-api","sha":"6431780e5bec5eb034b07e2de34f314a27d6bd07","user":{"login":"bendeutsch","id":2880643,"avatar_url":"https://avatars1.githubusercontent.com/u/2880643?v=3","gravatar_id":"","url":"https://api.github.com/users/bendeutsch","html_url":"https://github.com/bendeutsch","followers_url":"https://api.github.com/users/bendeutsch/followers","following_url":"https://api.github.com/users/bendeutsch/following{/other_user}","gists_url":"https://api.github.com/users/bendeutsch/gists{/gist_id}","starred_url":"https://api.github.com/users/bendeutsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendeutsch/subscriptions","organizations_url":"https://api.github.com/users/bendeutsch/orgs","repos_url":"https://api.github.com/users/bendeutsch/repos","events_url":"https://api.github.com/users/bendeutsch/events{/privacy}","received_events_url":"https://api.github.com/users/bendeutsch/received_events","type":"User","site_admin":false},"repo":{"id":45211041,"name":"minetest","full_name":"bendeutsch/minetest","owner":{"login":"bendeutsch","id":2880643,"avatar_url":"https://avatars1.githubusercontent.com/u/2880643?v=3","gravatar_id":"","url":"https://api.github.com/users/bendeutsch","html_url":"https://github.com/bendeutsch","followers_url":"https://api.github.com/users/bendeutsch/followers","following_url":"https://api.github.com/users/bendeutsch/following{/other_user}","gists_url":"https://api.github.com/users/bendeutsch/gists{/gist_id}","starred_url":"https://api.github.com/users/bendeutsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendeutsch/subscriptions","organizations_url":"https://api.github.com/users/bendeutsch/orgs","repos_url":"https://api.github.com/users/bendeutsch/repos","events_url":"https://api.github.com/users/bendeutsch/events{/privacy}","received_events_url":"https://api.github.com/users/bendeutsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bendeutsch/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/bendeutsch/minetest","forks_url":"https://api.github.com/repos/bendeutsch/minetest/forks","keys_url":"https://api.github.com/repos/bendeutsch/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bendeutsch/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bendeutsch/minetest/teams","hooks_url":"https://api.github.com/repos/bendeutsch/minetest/hooks","issue_events_url":"https://api.github.com/repos/bendeutsch/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/bendeutsch/minetest/events","assignees_url":"https://api.github.com/repos/bendeutsch/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/bendeutsch/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/bendeutsch/minetest/tags","blobs_url":"https://api.github.com/repos/bendeutsch/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bendeutsch/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bendeutsch/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/bendeutsch/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bendeutsch/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/bendeutsch/minetest/languages","stargazers_url":"https://api.github.com/repos/bendeutsch/minetest/stargazers","contributors_url":"https://api.github.com/repos/bendeutsch/minetest/contributors","subscribers_url":"https://api.github.com/repos/bendeutsch/minetest/subscribers","subscription_url":"https://api.github.com/repos/bendeutsch/minetest/subscription","commits_url":"https://api.github.com/repos/bendeutsch/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/bendeutsch/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/bendeutsch/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/bendeutsch/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/bendeutsch/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/bendeutsch/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bendeutsch/minetest/merges","archive_url":"https://api.github.com/repos/bendeutsch/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bendeutsch/minetest/downloads","issues_url":"https://api.github.com/repos/bendeutsch/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/bendeutsch/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/bendeutsch/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/bendeutsch/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bendeutsch/minetest/labels{/name}","releases_url":"https://api.github.com/repos/bendeutsch/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/bendeutsch/minetest/deployments","created_at":"2015-10-29T21:16:01Z","updated_at":"2016-06-12T20:08:30Z","pushed_at":"2017-04-20T20:28:53Z","git_url":"git://github.com/bendeutsch/minetest.git","ssh_url":"git@github.com:bendeutsch/minetest.git","clone_url":"https://github.com/bendeutsch/minetest.git","svn_url":"https://github.com/bendeutsch/minetest","homepage":"http://minetest.net/","size":46731,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"de5ecc9fa31d557e2d0ca638b1c98435707046b9","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars2.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars2.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2017-04-20T22:01:44Z","pushed_at":"2017-04-21T01:24:02Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":46508,"stargazers_count":2510,"watchers_count":2510,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":765,"mirror_url":null,"open_issues_count":1046,"forks":765,"open_issues":1046,"watchers":2510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4524"},"html":{"href":"https://github.com/minetest/minetest/pull/4524"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/4524"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/4524/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4524/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/4524/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/6431780e5bec5eb034b07e2de34f314a27d6bd07"}}}}
{"actor":{"display_login":"paramat"}}