{"action":"created","comment":{"url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/comments/99499796","pull_request_review_id":20178707,"id":99499796,"diff_hunk":"@@ -1,67 +1,48 @@\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n <LinearLayout xmlns:android=\"http://schemas.android.com/apk/res/android\"\n-    xmlns:app=\"http://schemas.android.com/apk/res-auto\"\n     android:layout_width=\"match_parent\"\n-              android:layout_height=\"wrap_content\"\n-              android:orientation=\"vertical\">\n+    android:layout_height=\"wrap_content\"\n+    android:orientation=\"vertical\">\n \n     <android.support.v7.widget.CardView\n         android:id=\"@+id/card_view\"\n         style=\"@style/CardViewContainer\"\n         android:layout_width=\"match_parent\"\n-        android:layout_height=\"wrap_content\"\n-        >\n+        android:layout_height=\"wrap_content\">\n \n         <LinearLayout\n             android:layout_width=\"match_parent\"\n-            android:layout_height=\"match_parent\"\n-            android:orientation=\"vertical\">\n+            android:layout_height=\"wrap_content\"\n+            android:orientation=\"vertical\"\n+            android:paddingBottom=\"4dp\"\n+            android:paddingLeft=\"8dp\"\n+            android:paddingRight=\"8dp\"\n+            android:paddingTop=\"4dp\">\n \n             <TextView\n                 android:id=\"@+id/item_repo_name\"\n-                style=\"@style/ViewBuildText.TwoLines.Title.NoImage\"\n+                style=\"@style/ViewBuildText.TwoLines.Big\"\n                 android:layout_width=\"wrap_content\"\n-                android:layout_height=\"wrap_content\"\n-                />\n+                android:layout_height=\"wrap_content\" />\n \n-            <LinearLayout\n+            <TextView\n+                android:id=\"@+id/item_repo_duration\"\n+                style=\"@style/ViewBuildText\"\n                 android:layout_width=\"match_parent\"\n                 android:layout_height=\"wrap_content\"\n-                android:orientation=\"horizontal\">\n-\n-                <ImageView\n-                    style=\"@style/ViewBuildImageIcon\"\n-                    app:srcCompat=\"@drawable/ic_duration_grey600_16dp\"\n-                    />\n+                android:drawableLeft=\"@drawable/ic_duration_grey600_16dp\"","path":"app/src/main/res/layout/item_repo.xml","position":46,"original_position":50,"commit_id":"b923d9105da518ed9e9575f8af2621338d0aaab9","original_commit_id":"8584c8dec85ca30ffbf8ce07254e851d8af473dc","user":{"login":"DreierF","id":5631865,"avatar_url":"https://avatars.githubusercontent.com/u/5631865?v=3","gravatar_id":"","url":"https://api.github.com/users/DreierF","html_url":"https://github.com/DreierF","followers_url":"https://api.github.com/users/DreierF/followers","following_url":"https://api.github.com/users/DreierF/following{/other_user}","gists_url":"https://api.github.com/users/DreierF/gists{/gist_id}","starred_url":"https://api.github.com/users/DreierF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DreierF/subscriptions","organizations_url":"https://api.github.com/users/DreierF/orgs","repos_url":"https://api.github.com/users/DreierF/repos","events_url":"https://api.github.com/users/DreierF/events{/privacy}","received_events_url":"https://api.github.com/users/DreierF/received_events","type":"User","site_admin":false},"body":"1. The drawableLeft ensures the text and the icon are nicely aligned. If you carefully look at the image at the top you can see that the icon is a little bit off in the old version.\r\n2. Much less views to inflate -> Faster performance\r\n3. Less code -> Easier to read\r\n4. If you want to change the alignment in the future again and it should not be possible with drawableLeft you can still go back to the ImageView TextView approach.","created_at":"2017-02-05T21:06:38Z","updated_at":"2017-02-05T21:06:38Z","html_url":"https://github.com/dkhmelenko/TravisClient-Android/pull/27#discussion_r99499796","pull_request_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/comments/99499796"},"html":{"href":"https://github.com/dkhmelenko/TravisClient-Android/pull/27#discussion_r99499796"},"pull_request":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/27","id":104712466,"html_url":"https://github.com/dkhmelenko/TravisClient-Android/pull/27","diff_url":"https://github.com/dkhmelenko/TravisClient-Android/pull/27.diff","patch_url":"https://github.com/dkhmelenko/TravisClient-Android/pull/27.patch","issue_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/issues/27","number":27,"state":"open","locked":false,"title":"Redesigned build items","user":{"login":"DreierF","id":5631865,"avatar_url":"https://avatars.githubusercontent.com/u/5631865?v=3","gravatar_id":"","url":"https://api.github.com/users/DreierF","html_url":"https://github.com/DreierF","followers_url":"https://api.github.com/users/DreierF/followers","following_url":"https://api.github.com/users/DreierF/following{/other_user}","gists_url":"https://api.github.com/users/DreierF/gists{/gist_id}","starred_url":"https://api.github.com/users/DreierF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DreierF/subscriptions","organizations_url":"https://api.github.com/users/DreierF/orgs","repos_url":"https://api.github.com/users/DreierF/repos","events_url":"https://api.github.com/users/DreierF/events{/privacy}","received_events_url":"https://api.github.com/users/DreierF/received_events","type":"User","site_admin":false},"body":"Hi, now last but not least the last portion of #23 the actual UI polish. I hope you also prefer it over the current look.\r\n<img src=\"https://cloud.githubusercontent.com/assets/5631865/22629363/d136dbae-ebe4-11e6-840f-279f8e10be92.png\" alt=\"Old\" width=\"49%\" > <img src=\"https://cloud.githubusercontent.com/assets/5631865/22629365/d30c5a44-ebe4-11e6-827d-29c2378aec1a.png\" alt=\"New\" width=\"49%\" >","created_at":"2017-02-05T19:55:51Z","updated_at":"2017-02-05T21:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba241b5abe70673f2ca8c068d2fea5d71a0a0b51","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/27/commits","review_comments_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/27/comments","review_comment_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/issues/27/comments","statuses_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/statuses/b923d9105da518ed9e9575f8af2621338d0aaab9","head":{"label":"DreierF:feature/item_redesign","ref":"feature/item_redesign","sha":"b923d9105da518ed9e9575f8af2621338d0aaab9","user":{"login":"DreierF","id":5631865,"avatar_url":"https://avatars.githubusercontent.com/u/5631865?v=3","gravatar_id":"","url":"https://api.github.com/users/DreierF","html_url":"https://github.com/DreierF","followers_url":"https://api.github.com/users/DreierF/followers","following_url":"https://api.github.com/users/DreierF/following{/other_user}","gists_url":"https://api.github.com/users/DreierF/gists{/gist_id}","starred_url":"https://api.github.com/users/DreierF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DreierF/subscriptions","organizations_url":"https://api.github.com/users/DreierF/orgs","repos_url":"https://api.github.com/users/DreierF/repos","events_url":"https://api.github.com/users/DreierF/events{/privacy}","received_events_url":"https://api.github.com/users/DreierF/received_events","type":"User","site_admin":false},"repo":{"id":80422037,"name":"TravisClient-Android","full_name":"DreierF/TravisClient-Android","owner":{"login":"DreierF","id":5631865,"avatar_url":"https://avatars.githubusercontent.com/u/5631865?v=3","gravatar_id":"","url":"https://api.github.com/users/DreierF","html_url":"https://github.com/DreierF","followers_url":"https://api.github.com/users/DreierF/followers","following_url":"https://api.github.com/users/DreierF/following{/other_user}","gists_url":"https://api.github.com/users/DreierF/gists{/gist_id}","starred_url":"https://api.github.com/users/DreierF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DreierF/subscriptions","organizations_url":"https://api.github.com/users/DreierF/orgs","repos_url":"https://api.github.com/users/DreierF/repos","events_url":"https://api.github.com/users/DreierF/events{/privacy}","received_events_url":"https://api.github.com/users/DreierF/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DreierF/TravisClient-Android","description":"Android client for Travis CI","fork":true,"url":"https://api.github.com/repos/DreierF/TravisClient-Android","forks_url":"https://api.github.com/repos/DreierF/TravisClient-Android/forks","keys_url":"https://api.github.com/repos/DreierF/TravisClient-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DreierF/TravisClient-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DreierF/TravisClient-Android/teams","hooks_url":"https://api.github.com/repos/DreierF/TravisClient-Android/hooks","issue_events_url":"https://api.github.com/repos/DreierF/TravisClient-Android/issues/events{/number}","events_url":"https://api.github.com/repos/DreierF/TravisClient-Android/events","assignees_url":"https://api.github.com/repos/DreierF/TravisClient-Android/assignees{/user}","branches_url":"https://api.github.com/repos/DreierF/TravisClient-Android/branches{/branch}","tags_url":"https://api.github.com/repos/DreierF/TravisClient-Android/tags","blobs_url":"https://api.github.com/repos/DreierF/TravisClient-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DreierF/TravisClient-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DreierF/TravisClient-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/DreierF/TravisClient-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DreierF/TravisClient-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/DreierF/TravisClient-Android/languages","stargazers_url":"https://api.github.com/repos/DreierF/TravisClient-Android/stargazers","contributors_url":"https://api.github.com/repos/DreierF/TravisClient-Android/contributors","subscribers_url":"https://api.github.com/repos/DreierF/TravisClient-Android/subscribers","subscription_url":"https://api.github.com/repos/DreierF/TravisClient-Android/subscription","commits_url":"https://api.github.com/repos/DreierF/TravisClient-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/DreierF/TravisClient-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/DreierF/TravisClient-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/DreierF/TravisClient-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/DreierF/TravisClient-Android/contents/{+path}","compare_url":"https://api.github.com/repos/DreierF/TravisClient-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DreierF/TravisClient-Android/merges","archive_url":"https://api.github.com/repos/DreierF/TravisClient-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DreierF/TravisClient-Android/downloads","issues_url":"https://api.github.com/repos/DreierF/TravisClient-Android/issues{/number}","pulls_url":"https://api.github.com/repos/DreierF/TravisClient-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/DreierF/TravisClient-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/DreierF/TravisClient-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DreierF/TravisClient-Android/labels{/name}","releases_url":"https://api.github.com/repos/DreierF/TravisClient-Android/releases{/id}","deployments_url":"https://api.github.com/repos/DreierF/TravisClient-Android/deployments","created_at":"2017-01-30T13:04:54Z","updated_at":"2017-01-30T13:04:56Z","pushed_at":"2017-02-05T21:00:32Z","git_url":"git://github.com/DreierF/TravisClient-Android.git","ssh_url":"git@github.com:DreierF/TravisClient-Android.git","clone_url":"https://github.com/DreierF/TravisClient-Android.git","svn_url":"https://github.com/DreierF/TravisClient-Android","homepage":"","size":9139,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"dkhmelenko:develop","ref":"develop","sha":"20f03d1f9e0692ab0cd1ce4b8844840f1de5ee7f","user":{"login":"dkhmelenko","id":4306809,"avatar_url":"https://avatars.githubusercontent.com/u/4306809?v=3","gravatar_id":"","url":"https://api.github.com/users/dkhmelenko","html_url":"https://github.com/dkhmelenko","followers_url":"https://api.github.com/users/dkhmelenko/followers","following_url":"https://api.github.com/users/dkhmelenko/following{/other_user}","gists_url":"https://api.github.com/users/dkhmelenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dkhmelenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkhmelenko/subscriptions","organizations_url":"https://api.github.com/users/dkhmelenko/orgs","repos_url":"https://api.github.com/users/dkhmelenko/repos","events_url":"https://api.github.com/users/dkhmelenko/events{/privacy}","received_events_url":"https://api.github.com/users/dkhmelenko/received_events","type":"User","site_admin":false},"repo":{"id":38716513,"name":"TravisClient-Android","full_name":"dkhmelenko/TravisClient-Android","owner":{"login":"dkhmelenko","id":4306809,"avatar_url":"https://avatars.githubusercontent.com/u/4306809?v=3","gravatar_id":"","url":"https://api.github.com/users/dkhmelenko","html_url":"https://github.com/dkhmelenko","followers_url":"https://api.github.com/users/dkhmelenko/followers","following_url":"https://api.github.com/users/dkhmelenko/following{/other_user}","gists_url":"https://api.github.com/users/dkhmelenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dkhmelenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkhmelenko/subscriptions","organizations_url":"https://api.github.com/users/dkhmelenko/orgs","repos_url":"https://api.github.com/users/dkhmelenko/repos","events_url":"https://api.github.com/users/dkhmelenko/events{/privacy}","received_events_url":"https://api.github.com/users/dkhmelenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkhmelenko/TravisClient-Android","description":"Android client for Travis CI","fork":false,"url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android","forks_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/forks","keys_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/teams","hooks_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/hooks","issue_events_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/issues/events{/number}","events_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/events","assignees_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/assignees{/user}","branches_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/branches{/branch}","tags_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/tags","blobs_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/languages","stargazers_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/stargazers","contributors_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/contributors","subscribers_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/subscribers","subscription_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/subscription","commits_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/contents/{+path}","compare_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/merges","archive_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/downloads","issues_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/issues{/number}","pulls_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/labels{/name}","releases_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/releases{/id}","deployments_url":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/deployments","created_at":"2015-07-07T21:43:55Z","updated_at":"2017-01-06T10:53:02Z","pushed_at":"2017-02-05T21:00:34Z","git_url":"git://github.com/dkhmelenko/TravisClient-Android.git","ssh_url":"git@github.com:dkhmelenko/TravisClient-Android.git","clone_url":"https://github.com/dkhmelenko/TravisClient-Android.git","svn_url":"https://github.com/dkhmelenko/TravisClient-Android","homepage":"","size":9100,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":5,"forks":14,"open_issues":5,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/27"},"html":{"href":"https://github.com/dkhmelenko/TravisClient-Android/pull/27"},"issue":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/issues/27"},"comments":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/dkhmelenko/TravisClient-Android/statuses/b923d9105da518ed9e9575f8af2621338d0aaab9"}}}}
{"actor":{"display_login":"DreierF"}}