{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/6075","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/6075/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/6075/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/6075/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/6075","id":215341820,"number":6075,"title":"Additional cleanup of UBL code","user":{"login":"thinkyhead","id":698003,"avatar_url":"https://avatars1.githubusercontent.com/u/698003?v=3","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"labels":[{"id":203482923,"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Coding%20Standards","name":"PR: Coding Standards","color":"bfe5bf","default":false},{"id":415002612,"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/U.B.L.","name":"U.B.L.","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-03-20T06:56:00Z","updated_at":"2017-03-23T01:58:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/6075","html_url":"https://github.com/MarlinFirmware/Marlin/pull/6075","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/6075.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/6075.patch"},"body":"Various cleanups and changes to conform to the latest code-base:\r\n\r\n- Use the `wait_for_user` flag for typical wait-for-click scenarios\r\n- Improved formatting correcting bad tab conversion\r\n- Lowercase variable names\r\n- Make longer comments foldable\r\n- Use `ELAPSED` macro and `millis_t` type, where needed\r\n- Use `const` where possible\r\n- Use 8-bit values for small loop indexes\r\n- Use `bool` where appropriate\r\n\r\n[Concise diff](https://github.com/MarlinFirmware/Marlin/pull/6075/files?w=1)"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/288594798","html_url":"https://github.com/MarlinFirmware/Marlin/pull/6075#issuecomment-288594798","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/6075","id":288594798,"user":{"login":"Roxy-3D","id":8404322,"avatar_url":"https://avatars3.githubusercontent.com/u/8404322?v=3","gravatar_id":"","url":"https://api.github.com/users/Roxy-3D","html_url":"https://github.com/Roxy-3D","followers_url":"https://api.github.com/users/Roxy-3D/followers","following_url":"https://api.github.com/users/Roxy-3D/following{/other_user}","gists_url":"https://api.github.com/users/Roxy-3D/gists{/gist_id}","starred_url":"https://api.github.com/users/Roxy-3D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Roxy-3D/subscriptions","organizations_url":"https://api.github.com/users/Roxy-3D/orgs","repos_url":"https://api.github.com/users/Roxy-3D/repos","events_url":"https://api.github.com/users/Roxy-3D/events{/privacy}","received_events_url":"https://api.github.com/users/Roxy-3D/received_events","type":"User","site_admin":false},"created_at":"2017-03-23T01:58:30Z","updated_at":"2017-03-23T01:58:30Z","body":"> If you direct-commit them, you will have to conform to the old code, then I would have to pull them down, rebase this branch onto them, re-write them in the process…. It takes a lot more of my time and effort.\r\n\r\n> Let me finish patching this PR and merge it, then you can just make a normal PR against RCBugFix.\r\n\r\nOK!   I don't want to make extra work for you!\r\n"}}
{"actor":{"display_login":"Roxy-3D"}}