{"action":"created","comment":{"url":"https://api.github.com/repos/iddan/react-native-canvas/pulls/comments/130359215","pull_request_review_id":53223170,"id":130359215,"diff_hunk":"@@ -78,16 +172,16 @@ export default class Canvas extends Component {\n \n   render() {\n     const {width, height} = this;\n+\n     return (\n-      <View style={{width, height, overflow: 'hidden'}}>\n-        <WebView\n-          ref={this.handleRef}\n-          style={{width, height, backgroundColor: 'transparent'}}\n-          source={require('./index.html')}\n-          onMessage={this.handleMessage}\n-          onLoad={this.handleLoad}\n-        />\n-      </View>\n+      <WebView\n+        ref={this.handleRef}\n+        style={{width, height, overflow: 'hidden', backgroundColor: 'transparent'}}\n+        source={{html, baseUrl: '/'}}","path":"src/Canvas.js","position":119,"original_position":119,"commit_id":"6399c2a84d4aa3bc53307030bea3441a94768d1c","original_commit_id":"6399c2a84d4aa3bc53307030bea3441a94768d1c","user":{"login":"iddan","id":12671072,"avatar_url":"https://avatars2.githubusercontent.com/u/12671072?v=4","gravatar_id":"","url":"https://api.github.com/users/iddan","html_url":"https://github.com/iddan","followers_url":"https://api.github.com/users/iddan/followers","following_url":"https://api.github.com/users/iddan/following{/other_user}","gists_url":"https://api.github.com/users/iddan/gists{/gist_id}","starred_url":"https://api.github.com/users/iddan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iddan/subscriptions","organizations_url":"https://api.github.com/users/iddan/orgs","repos_url":"https://api.github.com/users/iddan/repos","events_url":"https://api.github.com/users/iddan/events{/privacy}","received_events_url":"https://api.github.com/users/iddan/received_events","type":"User","site_admin":false},"body":"?","created_at":"2017-07-31T13:57:59Z","updated_at":"2017-07-31T13:59:04Z","html_url":"https://github.com/iddan/react-native-canvas/pull/14#discussion_r130359215","pull_request_url":"https://api.github.com/repos/iddan/react-native-canvas/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/iddan/react-native-canvas/pulls/comments/130359215"},"html":{"href":"https://github.com/iddan/react-native-canvas/pull/14#discussion_r130359215"},"pull_request":{"href":"https://api.github.com/repos/iddan/react-native-canvas/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/iddan/react-native-canvas/pulls/14","id":133185235,"html_url":"https://github.com/iddan/react-native-canvas/pull/14","diff_url":"https://github.com/iddan/react-native-canvas/pull/14.diff","patch_url":"https://github.com/iddan/react-native-canvas/pull/14.patch","issue_url":"https://api.github.com/repos/iddan/react-native-canvas/issues/14","number":14,"state":"open","locked":false,"title":"Allow base64 drawImage","user":{"login":"assertchris","id":200609,"avatar_url":"https://avatars1.githubusercontent.com/u/200609?v=4","gravatar_id":"","url":"https://api.github.com/users/assertchris","html_url":"https://github.com/assertchris","followers_url":"https://api.github.com/users/assertchris/followers","following_url":"https://api.github.com/users/assertchris/following{/other_user}","gists_url":"https://api.github.com/users/assertchris/gists{/gist_id}","starred_url":"https://api.github.com/users/assertchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assertchris/subscriptions","organizations_url":"https://api.github.com/users/assertchris/orgs","repos_url":"https://api.github.com/users/assertchris/repos","events_url":"https://api.github.com/users/assertchris/events{/privacy}","received_events_url":"https://api.github.com/users/assertchris/received_events","type":"User","site_admin":false},"body":"This introduces the ability to draw an image, on the canvas, from base64 data. It also addresses a strange race-condition with WebView and require (which can be reproduced by increasing the number of rendered canvases in the example app). It's an ugly solution to that problem, but it seems to be the trick quite nicely. :/\r\n\r\n![](https://user-images.githubusercontent.com/200609/28768043-801b5980-75d6-11e7-97ed-1c7108669ca3.png)\r\n","created_at":"2017-07-31T07:56:30Z","updated_at":"2017-07-31T13:59:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72a33b5dd0f7decf9a412cb7e8dd21997f56d6ff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/iddan/react-native-canvas/pulls/14/commits","review_comments_url":"https://api.github.com/repos/iddan/react-native-canvas/pulls/14/comments","review_comment_url":"https://api.github.com/repos/iddan/react-native-canvas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iddan/react-native-canvas/issues/14/comments","statuses_url":"https://api.github.com/repos/iddan/react-native-canvas/statuses/6399c2a84d4aa3bc53307030bea3441a94768d1c","head":{"label":"assertchris:feature/allow-base64-draw-image","ref":"feature/allow-base64-draw-image","sha":"6399c2a84d4aa3bc53307030bea3441a94768d1c","user":{"login":"assertchris","id":200609,"avatar_url":"https://avatars1.githubusercontent.com/u/200609?v=4","gravatar_id":"","url":"https://api.github.com/users/assertchris","html_url":"https://github.com/assertchris","followers_url":"https://api.github.com/users/assertchris/followers","following_url":"https://api.github.com/users/assertchris/following{/other_user}","gists_url":"https://api.github.com/users/assertchris/gists{/gist_id}","starred_url":"https://api.github.com/users/assertchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assertchris/subscriptions","organizations_url":"https://api.github.com/users/assertchris/orgs","repos_url":"https://api.github.com/users/assertchris/repos","events_url":"https://api.github.com/users/assertchris/events{/privacy}","received_events_url":"https://api.github.com/users/assertchris/received_events","type":"User","site_admin":false},"repo":{"id":98500390,"name":"react-native-canvas","full_name":"assertchris/react-native-canvas","owner":{"login":"assertchris","id":200609,"avatar_url":"https://avatars1.githubusercontent.com/u/200609?v=4","gravatar_id":"","url":"https://api.github.com/users/assertchris","html_url":"https://github.com/assertchris","followers_url":"https://api.github.com/users/assertchris/followers","following_url":"https://api.github.com/users/assertchris/following{/other_user}","gists_url":"https://api.github.com/users/assertchris/gists{/gist_id}","starred_url":"https://api.github.com/users/assertchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/assertchris/subscriptions","organizations_url":"https://api.github.com/users/assertchris/orgs","repos_url":"https://api.github.com/users/assertchris/repos","events_url":"https://api.github.com/users/assertchris/events{/privacy}","received_events_url":"https://api.github.com/users/assertchris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/assertchris/react-native-canvas","description":"A Canvas element for React Native","fork":true,"url":"https://api.github.com/repos/assertchris/react-native-canvas","forks_url":"https://api.github.com/repos/assertchris/react-native-canvas/forks","keys_url":"https://api.github.com/repos/assertchris/react-native-canvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/assertchris/react-native-canvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/assertchris/react-native-canvas/teams","hooks_url":"https://api.github.com/repos/assertchris/react-native-canvas/hooks","issue_events_url":"https://api.github.com/repos/assertchris/react-native-canvas/issues/events{/number}","events_url":"https://api.github.com/repos/assertchris/react-native-canvas/events","assignees_url":"https://api.github.com/repos/assertchris/react-native-canvas/assignees{/user}","branches_url":"https://api.github.com/repos/assertchris/react-native-canvas/branches{/branch}","tags_url":"https://api.github.com/repos/assertchris/react-native-canvas/tags","blobs_url":"https://api.github.com/repos/assertchris/react-native-canvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/assertchris/react-native-canvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/assertchris/react-native-canvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/assertchris/react-native-canvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/assertchris/react-native-canvas/statuses/{sha}","languages_url":"https://api.github.com/repos/assertchris/react-native-canvas/languages","stargazers_url":"https://api.github.com/repos/assertchris/react-native-canvas/stargazers","contributors_url":"https://api.github.com/repos/assertchris/react-native-canvas/contributors","subscribers_url":"https://api.github.com/repos/assertchris/react-native-canvas/subscribers","subscription_url":"https://api.github.com/repos/assertchris/react-native-canvas/subscription","commits_url":"https://api.github.com/repos/assertchris/react-native-canvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/assertchris/react-native-canvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/assertchris/react-native-canvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/assertchris/react-native-canvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/assertchris/react-native-canvas/contents/{+path}","compare_url":"https://api.github.com/repos/assertchris/react-native-canvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/assertchris/react-native-canvas/merges","archive_url":"https://api.github.com/repos/assertchris/react-native-canvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/assertchris/react-native-canvas/downloads","issues_url":"https://api.github.com/repos/assertchris/react-native-canvas/issues{/number}","pulls_url":"https://api.github.com/repos/assertchris/react-native-canvas/pulls{/number}","milestones_url":"https://api.github.com/repos/assertchris/react-native-canvas/milestones{/number}","notifications_url":"https://api.github.com/repos/assertchris/react-native-canvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/assertchris/react-native-canvas/labels{/name}","releases_url":"https://api.github.com/repos/assertchris/react-native-canvas/releases{/id}","deployments_url":"https://api.github.com/repos/assertchris/react-native-canvas/deployments","created_at":"2017-07-27T06:15:17Z","updated_at":"2017-07-27T06:15:18Z","pushed_at":"2017-07-31T07:55:05Z","git_url":"git://github.com/assertchris/react-native-canvas.git","ssh_url":"git@github.com:assertchris/react-native-canvas.git","clone_url":"https://github.com/assertchris/react-native-canvas.git","svn_url":"https://github.com/assertchris/react-native-canvas","homepage":"","size":259,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iddan:master","ref":"master","sha":"c4eb0a2f0d42e977d03bccc9a7c8078d1084e713","user":{"login":"iddan","id":12671072,"avatar_url":"https://avatars2.githubusercontent.com/u/12671072?v=4","gravatar_id":"","url":"https://api.github.com/users/iddan","html_url":"https://github.com/iddan","followers_url":"https://api.github.com/users/iddan/followers","following_url":"https://api.github.com/users/iddan/following{/other_user}","gists_url":"https://api.github.com/users/iddan/gists{/gist_id}","starred_url":"https://api.github.com/users/iddan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iddan/subscriptions","organizations_url":"https://api.github.com/users/iddan/orgs","repos_url":"https://api.github.com/users/iddan/repos","events_url":"https://api.github.com/users/iddan/events{/privacy}","received_events_url":"https://api.github.com/users/iddan/received_events","type":"User","site_admin":false},"repo":{"id":33655927,"name":"react-native-canvas","full_name":"iddan/react-native-canvas","owner":{"login":"iddan","id":12671072,"avatar_url":"https://avatars2.githubusercontent.com/u/12671072?v=4","gravatar_id":"","url":"https://api.github.com/users/iddan","html_url":"https://github.com/iddan","followers_url":"https://api.github.com/users/iddan/followers","following_url":"https://api.github.com/users/iddan/following{/other_user}","gists_url":"https://api.github.com/users/iddan/gists{/gist_id}","starred_url":"https://api.github.com/users/iddan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iddan/subscriptions","organizations_url":"https://api.github.com/users/iddan/orgs","repos_url":"https://api.github.com/users/iddan/repos","events_url":"https://api.github.com/users/iddan/events{/privacy}","received_events_url":"https://api.github.com/users/iddan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iddan/react-native-canvas","description":"A Canvas element for React Native","fork":false,"url":"https://api.github.com/repos/iddan/react-native-canvas","forks_url":"https://api.github.com/repos/iddan/react-native-canvas/forks","keys_url":"https://api.github.com/repos/iddan/react-native-canvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iddan/react-native-canvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iddan/react-native-canvas/teams","hooks_url":"https://api.github.com/repos/iddan/react-native-canvas/hooks","issue_events_url":"https://api.github.com/repos/iddan/react-native-canvas/issues/events{/number}","events_url":"https://api.github.com/repos/iddan/react-native-canvas/events","assignees_url":"https://api.github.com/repos/iddan/react-native-canvas/assignees{/user}","branches_url":"https://api.github.com/repos/iddan/react-native-canvas/branches{/branch}","tags_url":"https://api.github.com/repos/iddan/react-native-canvas/tags","blobs_url":"https://api.github.com/repos/iddan/react-native-canvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iddan/react-native-canvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iddan/react-native-canvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/iddan/react-native-canvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iddan/react-native-canvas/statuses/{sha}","languages_url":"https://api.github.com/repos/iddan/react-native-canvas/languages","stargazers_url":"https://api.github.com/repos/iddan/react-native-canvas/stargazers","contributors_url":"https://api.github.com/repos/iddan/react-native-canvas/contributors","subscribers_url":"https://api.github.com/repos/iddan/react-native-canvas/subscribers","subscription_url":"https://api.github.com/repos/iddan/react-native-canvas/subscription","commits_url":"https://api.github.com/repos/iddan/react-native-canvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/iddan/react-native-canvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/iddan/react-native-canvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/iddan/react-native-canvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/iddan/react-native-canvas/contents/{+path}","compare_url":"https://api.github.com/repos/iddan/react-native-canvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iddan/react-native-canvas/merges","archive_url":"https://api.github.com/repos/iddan/react-native-canvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iddan/react-native-canvas/downloads","issues_url":"https://api.github.com/repos/iddan/react-native-canvas/issues{/number}","pulls_url":"https://api.github.com/repos/iddan/react-native-canvas/pulls{/number}","milestones_url":"https://api.github.com/repos/iddan/react-native-canvas/milestones{/number}","notifications_url":"https://api.github.com/repos/iddan/react-native-canvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iddan/react-native-canvas/labels{/name}","releases_url":"https://api.github.com/repos/iddan/react-native-canvas/releases{/id}","deployments_url":"https://api.github.com/repos/iddan/react-native-canvas/deployments","created_at":"2015-04-09T07:53:25Z","updated_at":"2017-07-31T13:25:56Z","pushed_at":"2017-07-31T07:56:30Z","git_url":"git://github.com/iddan/react-native-canvas.git","ssh_url":"git@github.com:iddan/react-native-canvas.git","clone_url":"https://github.com/iddan/react-native-canvas.git","svn_url":"https://github.com/iddan/react-native-canvas","homepage":"","size":185,"stargazers_count":139,"watchers_count":139,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":3,"forks":23,"open_issues":3,"watchers":139,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iddan/react-native-canvas/pulls/14"},"html":{"href":"https://github.com/iddan/react-native-canvas/pull/14"},"issue":{"href":"https://api.github.com/repos/iddan/react-native-canvas/issues/14"},"comments":{"href":"https://api.github.com/repos/iddan/react-native-canvas/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/iddan/react-native-canvas/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/iddan/react-native-canvas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iddan/react-native-canvas/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/iddan/react-native-canvas/statuses/6399c2a84d4aa3bc53307030bea3441a94768d1c"}}}}
{"actor":{"display_login":"iddan"}}