{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/19376","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/19376/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/19376/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/19376/events","html_url":"https://github.com/mantidproject/mantid/pull/19376","id":221517288,"number":19376,"title":"Grey out masked bins in table view","user":{"login":"gvardany","id":16865759,"avatar_url":"https://avatars1.githubusercontent.com/u/16865759?v=3","gravatar_id":"","url":"https://api.github.com/users/gvardany","html_url":"https://github.com/gvardany","followers_url":"https://api.github.com/users/gvardany/followers","following_url":"https://api.github.com/users/gvardany/following{/other_user}","gists_url":"https://api.github.com/users/gvardany/gists{/gist_id}","starred_url":"https://api.github.com/users/gvardany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvardany/subscriptions","organizations_url":"https://api.github.com/users/gvardany/orgs","repos_url":"https://api.github.com/users/gvardany/repos","events_url":"https://api.github.com/users/gvardany/events{/privacy}","received_events_url":"https://api.github.com/users/gvardany/received_events","type":"User","site_admin":false},"labels":[{"id":172782247,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20GUI","name":"Component: GUI","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"AntonPiccardoSelg","id":8955784,"avatar_url":"https://avatars3.githubusercontent.com/u/8955784?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonPiccardoSelg","html_url":"https://github.com/AntonPiccardoSelg","followers_url":"https://api.github.com/users/AntonPiccardoSelg/followers","following_url":"https://api.github.com/users/AntonPiccardoSelg/following{/other_user}","gists_url":"https://api.github.com/users/AntonPiccardoSelg/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPiccardoSelg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPiccardoSelg/subscriptions","organizations_url":"https://api.github.com/users/AntonPiccardoSelg/orgs","repos_url":"https://api.github.com/users/AntonPiccardoSelg/repos","events_url":"https://api.github.com/users/AntonPiccardoSelg/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPiccardoSelg/received_events","type":"User","site_admin":false},"assignees":[{"login":"AntonPiccardoSelg","id":8955784,"avatar_url":"https://avatars3.githubusercontent.com/u/8955784?v=3","gravatar_id":"","url":"https://api.github.com/users/AntonPiccardoSelg","html_url":"https://github.com/AntonPiccardoSelg","followers_url":"https://api.github.com/users/AntonPiccardoSelg/followers","following_url":"https://api.github.com/users/AntonPiccardoSelg/following{/other_user}","gists_url":"https://api.github.com/users/AntonPiccardoSelg/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonPiccardoSelg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonPiccardoSelg/subscriptions","organizations_url":"https://api.github.com/users/AntonPiccardoSelg/orgs","repos_url":"https://api.github.com/users/AntonPiccardoSelg/repos","events_url":"https://api.github.com/users/AntonPiccardoSelg/events{/privacy}","received_events_url":"https://api.github.com/users/AntonPiccardoSelg/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/61","html_url":"https://github.com/mantidproject/mantid/milestone/61","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/61/labels","id":2064897,"number":61,"title":"Release 3.10","description":"","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars2.githubusercontent.com/u/1017173?v=3","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":275,"closed_issues":538,"state":"open","created_at":"2016-10-12T13:14:59Z","updated_at":"2017-04-21T08:36:57Z","due_on":"2017-06-12T07:00:00Z","closed_at":null},"comments":4,"created_at":"2017-04-13T10:08:16Z","updated_at":"2017-04-21T09:05:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/19376","html_url":"https://github.com/mantidproject/mantid/pull/19376","diff_url":"https://github.com/mantidproject/mantid/pull/19376.diff","patch_url":"https://github.com/mantidproject/mantid/pull/19376.patch"},"body":"This PR adds colour highlighting to masked bins in the table view of matrix workspaces.\r\nAlso optimises the caching of masked and monitor spectra by holding only the sets of indices, that are masked or monitor, instead of maps of spectra to boolean flags, no matter true or false.\r\n\r\n**To test:**\r\n\r\n<!-- Instructions for testing. -->\r\n1. Create sample workspace, mask some bins.\r\n2. See how they appear in table view, mouse hover to check the tooltip. \r\n3. Make some masked bins in a masked or monitor (or both) spectrum to see if the priority ordering makes sense.\r\n\r\nFixes #17820 .\r\n\r\n<!-- RELEASE NOTES\r\nEither edit the file in docs/source/release/... and it will be in your pull request or state\r\n*Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)? Is it well structured with small focussed classes/methods/functions?\r\n- [ ] Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] How do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant documentation been added/updated?\r\n- [ ] Is user-facing documentation written in a user-friendly manner?\r\n- [ ] Has developer documentation been updated if required?\r\n\r\n- Does everything look good? Comment with the ship it emoji but don't merge. A member of `@mantidproject/gatekeepers` will take care of it."},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/296135531","html_url":"https://github.com/mantidproject/mantid/pull/19376#issuecomment-296135531","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/19376","id":296135531,"user":{"login":"gvardany","id":16865759,"avatar_url":"https://avatars1.githubusercontent.com/u/16865759?v=3","gravatar_id":"","url":"https://api.github.com/users/gvardany","html_url":"https://github.com/gvardany","followers_url":"https://api.github.com/users/gvardany/followers","following_url":"https://api.github.com/users/gvardany/following{/other_user}","gists_url":"https://api.github.com/users/gvardany/gists{/gist_id}","starred_url":"https://api.github.com/users/gvardany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvardany/subscriptions","organizations_url":"https://api.github.com/users/gvardany/orgs","repos_url":"https://api.github.com/users/gvardany/repos","events_url":"https://api.github.com/users/gvardany/events{/privacy}","received_events_url":"https://api.github.com/users/gvardany/received_events","type":"User","site_admin":false},"created_at":"2017-04-21T09:05:42Z","updated_at":"2017-04-21T09:05:42Z","body":"I added the exception for event mode in release notes, and wiki.\r\nRegarding the partial masking, I think it is up to Rebin to handle if the bins stay masked after split/merge. Seems they still stay flagged as masked, if a masked bin is merged with a non-masked bin, and the highlighting just reflects that logic, which is sensible I think."}}
{"actor":{"display_login":"gvardany"}}