{"action":"created","issue":{"url":"https://api.github.com/repos/kontena/kontena/issues/2918","repository_url":"https://api.github.com/repos/kontena/kontena","labels_url":"https://api.github.com/repos/kontena/kontena/issues/2918/labels{/name}","comments_url":"https://api.github.com/repos/kontena/kontena/issues/2918/comments","events_url":"https://api.github.com/repos/kontena/kontena/issues/2918/events","html_url":"https://github.com/kontena/kontena/pull/2918","id":263673310,"number":2918,"title":"Support for stop_signal","user":{"login":"mikkopiu","id":5830147,"avatar_url":"https://avatars2.githubusercontent.com/u/5830147?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkopiu","html_url":"https://github.com/mikkopiu","followers_url":"https://api.github.com/users/mikkopiu/followers","following_url":"https://api.github.com/users/mikkopiu/following{/other_user}","gists_url":"https://api.github.com/users/mikkopiu/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkopiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkopiu/subscriptions","organizations_url":"https://api.github.com/users/mikkopiu/orgs","repos_url":"https://api.github.com/users/mikkopiu/repos","events_url":"https://api.github.com/users/mikkopiu/events{/privacy}","received_events_url":"https://api.github.com/users/mikkopiu/received_events","type":"User","site_admin":false},"labels":[{"id":213547699,"url":"https://api.github.com/repos/kontena/kontena/labels/agent","name":"agent","color":"0052cc","default":false},{"id":215033183,"url":"https://api.github.com/repos/kontena/kontena/labels/cli","name":"cli","color":"0052cc","default":false},{"id":190601902,"url":"https://api.github.com/repos/kontena/kontena/labels/enhancement","name":"enhancement","color":"bfdadc","default":true},{"id":710285298,"url":"https://api.github.com/repos/kontena/kontena/labels/hacktoberfest","name":"hacktoberfest","color":"f9d0c4","default":false},{"id":213547662,"url":"https://api.github.com/repos/kontena/kontena/labels/server","name":"server","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-07T21:26:31Z","updated_at":"2017-10-10T08:46:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kontena/kontena/pulls/2918","html_url":"https://github.com/kontena/kontena/pull/2918","diff_url":"https://github.com/kontena/kontena/pull/2918.diff","patch_url":"https://github.com/kontena/kontena/pull/2918.patch"},"body":"Closes #2878 \r\nBased implementation on #2767\r\n\r\nAdded support for `stop_signal`, as in <https://docs.docker.com/compose/compose-file/#stop_signal>\r\n\r\nAlso fixed apparent typo in `agent/spec/lib/kontena/models/service_pod_spec.rb` `Entrypoint` test case name.\r\n\r\nWhen I ran the specs, there were some errors in `agent` and `server`, but nothing that seemed to relate to this PR."},"comment":{"url":"https://api.github.com/repos/kontena/kontena/issues/comments/335404263","html_url":"https://github.com/kontena/kontena/pull/2918#issuecomment-335404263","issue_url":"https://api.github.com/repos/kontena/kontena/issues/2918","id":335404263,"user":{"login":"jnummelin","id":3205505,"avatar_url":"https://avatars0.githubusercontent.com/u/3205505?v=4","gravatar_id":"","url":"https://api.github.com/users/jnummelin","html_url":"https://github.com/jnummelin","followers_url":"https://api.github.com/users/jnummelin/followers","following_url":"https://api.github.com/users/jnummelin/following{/other_user}","gists_url":"https://api.github.com/users/jnummelin/gists{/gist_id}","starred_url":"https://api.github.com/users/jnummelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnummelin/subscriptions","organizations_url":"https://api.github.com/users/jnummelin/orgs","repos_url":"https://api.github.com/users/jnummelin/repos","events_url":"https://api.github.com/users/jnummelin/events{/privacy}","received_events_url":"https://api.github.com/users/jnummelin/received_events","type":"User","site_admin":false},"created_at":"2017-10-10T08:46:16Z","updated_at":"2017-10-10T08:46:16Z","author_association":"CONTRIBUTOR","body":"You should be able to inspect the running container and look at `StopSignal` property.\r\n```\r\nkontena container inspect twilight-lake-92/nginx-1 | jq .Config.StopSignal\r\n\"SIGTERM\"\r\n```\r\nIn the specs you should be able to get it with something like:\r\n```\r\nk = run \"kontena container inspect #{container}\"\r\nJSON.parse(k.out).dig('Config', 'StopSignal')\r\n```\r\n\r\nThe problem you are facing in your hacky spec is that the data you get in `Container.all` and with `Container.get('foobar')` are different. So if you want the full data of container, always do `Container.get('foobar')`.\r\n\r\nThere's also one other issue in that approach. One should be able to run the E2E tests in any environment, so the created service containers are not always running in your local docker. Hence getting the container data through docker API is not really an option."}}
{"actor":{"display_login":"jnummelin"}}