{"action":"created","comment":{"url":"https://api.github.com/repos/42shpimanmls/42sh/pulls/comments/112217634","pull_request_review_id":33514578,"id":112217634,"diff_hunk":"@@ -80,8 +81,10 @@ static void\t\t\t\t\tadd_substitution(t_strlist **strlist_addr\n \t\tspath = get_variable(\"PATH\");\n \t\tpath = ft_strsplit(spath, ':');\n \t\tft_strdel(&spath);\n-\t\texecute(argv, environ, path);\n+\t\tenv = get_variables_for_execution(NULL);\n+\t\texecute(argv, env, path);\n \t\tft_freetabchar(path);","path":"srcs/expansion/command_substitution.c","position":15,"original_position":15,"commit_id":"cea0679dd0a105d5e848dd23abc20b32ad359fe7","original_commit_id":"cea0679dd0a105d5e848dd23abc20b32ad359fe7","user":{"login":"M5oul","id":4758871,"avatar_url":"https://avatars2.githubusercontent.com/u/4758871?v=3","gravatar_id":"","url":"https://api.github.com/users/M5oul","html_url":"https://github.com/M5oul","followers_url":"https://api.github.com/users/M5oul/followers","following_url":"https://api.github.com/users/M5oul/following{/other_user}","gists_url":"https://api.github.com/users/M5oul/gists{/gist_id}","starred_url":"https://api.github.com/users/M5oul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M5oul/subscriptions","organizations_url":"https://api.github.com/users/M5oul/orgs","repos_url":"https://api.github.com/users/M5oul/repos","events_url":"https://api.github.com/users/M5oul/events{/privacy}","received_events_url":"https://api.github.com/users/M5oul/received_events","type":"User","site_admin":false},"body":"Ce parent free bien `env`.\r\nAprès, `execute()` fork et exit.\r\nTout est bon. Je vois pas de soucis et j’ai pas de fuites avec Valgrind.","created_at":"2017-04-19T14:28:00Z","updated_at":"2017-04-19T14:28:00Z","html_url":"https://github.com/42shpimanmls/42sh/pull/151#discussion_r112217634","pull_request_url":"https://api.github.com/repos/42shpimanmls/42sh/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/42shpimanmls/42sh/pulls/comments/112217634"},"html":{"href":"https://github.com/42shpimanmls/42sh/pull/151#discussion_r112217634"},"pull_request":{"href":"https://api.github.com/repos/42shpimanmls/42sh/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/42shpimanmls/42sh/pulls/151","id":116551883,"html_url":"https://github.com/42shpimanmls/42sh/pull/151","diff_url":"https://github.com/42shpimanmls/42sh/pull/151.diff","patch_url":"https://github.com/42shpimanmls/42sh/pull/151.patch","issue_url":"https://api.github.com/repos/42shpimanmls/42sh/issues/151","number":151,"state":"open","locked":false,"title":"[fix] #94: add missing env var.","user":{"login":"M5oul","id":4758871,"avatar_url":"https://avatars2.githubusercontent.com/u/4758871?v=3","gravatar_id":"","url":"https://api.github.com/users/M5oul","html_url":"https://github.com/M5oul","followers_url":"https://api.github.com/users/M5oul/followers","following_url":"https://api.github.com/users/M5oul/following{/other_user}","gists_url":"https://api.github.com/users/M5oul/gists{/gist_id}","starred_url":"https://api.github.com/users/M5oul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M5oul/subscriptions","organizations_url":"https://api.github.com/users/M5oul/orgs","repos_url":"https://api.github.com/users/M5oul/repos","events_url":"https://api.github.com/users/M5oul/events{/privacy}","received_events_url":"https://api.github.com/users/M5oul/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-19T13:46:34Z","updated_at":"2017-04-19T14:28:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bc91e6432f3ece90715a7779c2eb2c845b87beb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/42shpimanmls/42sh/pulls/151/commits","review_comments_url":"https://api.github.com/repos/42shpimanmls/42sh/pulls/151/comments","review_comment_url":"https://api.github.com/repos/42shpimanmls/42sh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/42shpimanmls/42sh/issues/151/comments","statuses_url":"https://api.github.com/repos/42shpimanmls/42sh/statuses/cea0679dd0a105d5e848dd23abc20b32ad359fe7","head":{"label":"42shpimanmls:94_fix_missing_env","ref":"94_fix_missing_env","sha":"cea0679dd0a105d5e848dd23abc20b32ad359fe7","user":{"login":"42shpimanmls","id":26278826,"avatar_url":"https://avatars2.githubusercontent.com/u/26278826?v=3","gravatar_id":"","url":"https://api.github.com/users/42shpimanmls","html_url":"https://github.com/42shpimanmls","followers_url":"https://api.github.com/users/42shpimanmls/followers","following_url":"https://api.github.com/users/42shpimanmls/following{/other_user}","gists_url":"https://api.github.com/users/42shpimanmls/gists{/gist_id}","starred_url":"https://api.github.com/users/42shpimanmls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/42shpimanmls/subscriptions","organizations_url":"https://api.github.com/users/42shpimanmls/orgs","repos_url":"https://api.github.com/users/42shpimanmls/repos","events_url":"https://api.github.com/users/42shpimanmls/events{/privacy}","received_events_url":"https://api.github.com/users/42shpimanmls/received_events","type":"Organization","site_admin":false},"repo":{"id":84322923,"name":"42sh","full_name":"42shpimanmls/42sh","owner":{"login":"42shpimanmls","id":26278826,"avatar_url":"https://avatars2.githubusercontent.com/u/26278826?v=3","gravatar_id":"","url":"https://api.github.com/users/42shpimanmls","html_url":"https://github.com/42shpimanmls","followers_url":"https://api.github.com/users/42shpimanmls/followers","following_url":"https://api.github.com/users/42shpimanmls/following{/other_user}","gists_url":"https://api.github.com/users/42shpimanmls/gists{/gist_id}","starred_url":"https://api.github.com/users/42shpimanmls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/42shpimanmls/subscriptions","organizations_url":"https://api.github.com/users/42shpimanmls/orgs","repos_url":"https://api.github.com/users/42shpimanmls/repos","events_url":"https://api.github.com/users/42shpimanmls/events{/privacy}","received_events_url":"https://api.github.com/users/42shpimanmls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/42shpimanmls/42sh","description":"Shell project at 42","fork":false,"url":"https://api.github.com/repos/42shpimanmls/42sh","forks_url":"https://api.github.com/repos/42shpimanmls/42sh/forks","keys_url":"https://api.github.com/repos/42shpimanmls/42sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/42shpimanmls/42sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/42shpimanmls/42sh/teams","hooks_url":"https://api.github.com/repos/42shpimanmls/42sh/hooks","issue_events_url":"https://api.github.com/repos/42shpimanmls/42sh/issues/events{/number}","events_url":"https://api.github.com/repos/42shpimanmls/42sh/events","assignees_url":"https://api.github.com/repos/42shpimanmls/42sh/assignees{/user}","branches_url":"https://api.github.com/repos/42shpimanmls/42sh/branches{/branch}","tags_url":"https://api.github.com/repos/42shpimanmls/42sh/tags","blobs_url":"https://api.github.com/repos/42shpimanmls/42sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/42shpimanmls/42sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/42shpimanmls/42sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/42shpimanmls/42sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/42shpimanmls/42sh/statuses/{sha}","languages_url":"https://api.github.com/repos/42shpimanmls/42sh/languages","stargazers_url":"https://api.github.com/repos/42shpimanmls/42sh/stargazers","contributors_url":"https://api.github.com/repos/42shpimanmls/42sh/contributors","subscribers_url":"https://api.github.com/repos/42shpimanmls/42sh/subscribers","subscription_url":"https://api.github.com/repos/42shpimanmls/42sh/subscription","commits_url":"https://api.github.com/repos/42shpimanmls/42sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/42shpimanmls/42sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/42shpimanmls/42sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/42shpimanmls/42sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/42shpimanmls/42sh/contents/{+path}","compare_url":"https://api.github.com/repos/42shpimanmls/42sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/42shpimanmls/42sh/merges","archive_url":"https://api.github.com/repos/42shpimanmls/42sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/42shpimanmls/42sh/downloads","issues_url":"https://api.github.com/repos/42shpimanmls/42sh/issues{/number}","pulls_url":"https://api.github.com/repos/42shpimanmls/42sh/pulls{/number}","milestones_url":"https://api.github.com/repos/42shpimanmls/42sh/milestones{/number}","notifications_url":"https://api.github.com/repos/42shpimanmls/42sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/42shpimanmls/42sh/labels{/name}","releases_url":"https://api.github.com/repos/42shpimanmls/42sh/releases{/id}","deployments_url":"https://api.github.com/repos/42shpimanmls/42sh/deployments","created_at":"2017-03-08T13:25:15Z","updated_at":"2017-04-18T08:16:29Z","pushed_at":"2017-04-19T13:54:39Z","git_url":"git://github.com/42shpimanmls/42sh.git","ssh_url":"git@github.com:42shpimanmls/42sh.git","clone_url":"https://github.com/42shpimanmls/42sh.git","svn_url":"https://github.com/42shpimanmls/42sh","homepage":"","size":1062,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":25,"forks":0,"open_issues":25,"watchers":3,"default_branch":"master"}},"base":{"label":"42shpimanmls:master","ref":"master","sha":"5bb8a4d49735c2f389b33cf617de4e35a3eb4ad1","user":{"login":"42shpimanmls","id":26278826,"avatar_url":"https://avatars2.githubusercontent.com/u/26278826?v=3","gravatar_id":"","url":"https://api.github.com/users/42shpimanmls","html_url":"https://github.com/42shpimanmls","followers_url":"https://api.github.com/users/42shpimanmls/followers","following_url":"https://api.github.com/users/42shpimanmls/following{/other_user}","gists_url":"https://api.github.com/users/42shpimanmls/gists{/gist_id}","starred_url":"https://api.github.com/users/42shpimanmls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/42shpimanmls/subscriptions","organizations_url":"https://api.github.com/users/42shpimanmls/orgs","repos_url":"https://api.github.com/users/42shpimanmls/repos","events_url":"https://api.github.com/users/42shpimanmls/events{/privacy}","received_events_url":"https://api.github.com/users/42shpimanmls/received_events","type":"Organization","site_admin":false},"repo":{"id":84322923,"name":"42sh","full_name":"42shpimanmls/42sh","owner":{"login":"42shpimanmls","id":26278826,"avatar_url":"https://avatars2.githubusercontent.com/u/26278826?v=3","gravatar_id":"","url":"https://api.github.com/users/42shpimanmls","html_url":"https://github.com/42shpimanmls","followers_url":"https://api.github.com/users/42shpimanmls/followers","following_url":"https://api.github.com/users/42shpimanmls/following{/other_user}","gists_url":"https://api.github.com/users/42shpimanmls/gists{/gist_id}","starred_url":"https://api.github.com/users/42shpimanmls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/42shpimanmls/subscriptions","organizations_url":"https://api.github.com/users/42shpimanmls/orgs","repos_url":"https://api.github.com/users/42shpimanmls/repos","events_url":"https://api.github.com/users/42shpimanmls/events{/privacy}","received_events_url":"https://api.github.com/users/42shpimanmls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/42shpimanmls/42sh","description":"Shell project at 42","fork":false,"url":"https://api.github.com/repos/42shpimanmls/42sh","forks_url":"https://api.github.com/repos/42shpimanmls/42sh/forks","keys_url":"https://api.github.com/repos/42shpimanmls/42sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/42shpimanmls/42sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/42shpimanmls/42sh/teams","hooks_url":"https://api.github.com/repos/42shpimanmls/42sh/hooks","issue_events_url":"https://api.github.com/repos/42shpimanmls/42sh/issues/events{/number}","events_url":"https://api.github.com/repos/42shpimanmls/42sh/events","assignees_url":"https://api.github.com/repos/42shpimanmls/42sh/assignees{/user}","branches_url":"https://api.github.com/repos/42shpimanmls/42sh/branches{/branch}","tags_url":"https://api.github.com/repos/42shpimanmls/42sh/tags","blobs_url":"https://api.github.com/repos/42shpimanmls/42sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/42shpimanmls/42sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/42shpimanmls/42sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/42shpimanmls/42sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/42shpimanmls/42sh/statuses/{sha}","languages_url":"https://api.github.com/repos/42shpimanmls/42sh/languages","stargazers_url":"https://api.github.com/repos/42shpimanmls/42sh/stargazers","contributors_url":"https://api.github.com/repos/42shpimanmls/42sh/contributors","subscribers_url":"https://api.github.com/repos/42shpimanmls/42sh/subscribers","subscription_url":"https://api.github.com/repos/42shpimanmls/42sh/subscription","commits_url":"https://api.github.com/repos/42shpimanmls/42sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/42shpimanmls/42sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/42shpimanmls/42sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/42shpimanmls/42sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/42shpimanmls/42sh/contents/{+path}","compare_url":"https://api.github.com/repos/42shpimanmls/42sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/42shpimanmls/42sh/merges","archive_url":"https://api.github.com/repos/42shpimanmls/42sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/42shpimanmls/42sh/downloads","issues_url":"https://api.github.com/repos/42shpimanmls/42sh/issues{/number}","pulls_url":"https://api.github.com/repos/42shpimanmls/42sh/pulls{/number}","milestones_url":"https://api.github.com/repos/42shpimanmls/42sh/milestones{/number}","notifications_url":"https://api.github.com/repos/42shpimanmls/42sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/42shpimanmls/42sh/labels{/name}","releases_url":"https://api.github.com/repos/42shpimanmls/42sh/releases{/id}","deployments_url":"https://api.github.com/repos/42shpimanmls/42sh/deployments","created_at":"2017-03-08T13:25:15Z","updated_at":"2017-04-18T08:16:29Z","pushed_at":"2017-04-19T13:54:39Z","git_url":"git://github.com/42shpimanmls/42sh.git","ssh_url":"git@github.com:42shpimanmls/42sh.git","clone_url":"https://github.com/42shpimanmls/42sh.git","svn_url":"https://github.com/42shpimanmls/42sh","homepage":"","size":1062,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":25,"forks":0,"open_issues":25,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/42shpimanmls/42sh/pulls/151"},"html":{"href":"https://github.com/42shpimanmls/42sh/pull/151"},"issue":{"href":"https://api.github.com/repos/42shpimanmls/42sh/issues/151"},"comments":{"href":"https://api.github.com/repos/42shpimanmls/42sh/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/42shpimanmls/42sh/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/42shpimanmls/42sh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/42shpimanmls/42sh/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/42shpimanmls/42sh/statuses/cea0679dd0a105d5e848dd23abc20b32ad359fe7"}}}}
{"actor":{"display_login":"M5oul"}}