{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/nvml/issues/1914","repository_url":"https://api.github.com/repos/pmem/nvml","labels_url":"https://api.github.com/repos/pmem/nvml/issues/1914/labels{/name}","comments_url":"https://api.github.com/repos/pmem/nvml/issues/1914/comments","events_url":"https://api.github.com/repos/pmem/nvml/issues/1914/events","html_url":"https://github.com/pmem/nvml/pull/1914","id":228814832,"number":1914,"title":"common: fix fetching Device DAX alignment","user":{"login":"krzycz","id":8184299,"avatar_url":"https://avatars1.githubusercontent.com/u/8184299?v=3","gravatar_id":"","url":"https://api.github.com/users/krzycz","html_url":"https://github.com/krzycz","followers_url":"https://api.github.com/users/krzycz/followers","following_url":"https://api.github.com/users/krzycz/following{/other_user}","gists_url":"https://api.github.com/users/krzycz/gists{/gist_id}","starred_url":"https://api.github.com/users/krzycz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzycz/subscriptions","organizations_url":"https://api.github.com/users/krzycz/orgs","repos_url":"https://api.github.com/users/krzycz/repos","events_url":"https://api.github.com/users/krzycz/events{/privacy}","received_events_url":"https://api.github.com/users/krzycz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-15T19:14:14Z","updated_at":"2017-05-15T20:06:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pmem/nvml/pulls/1914","html_url":"https://github.com/pmem/nvml/pull/1914","diff_url":"https://github.com/pmem/nvml/pull/1914.diff","patch_url":"https://github.com/pmem/nvml/pull/1914.patch"},"body":"In older kernels (4.8.x) Device DAX alignment was printed\r\nin hex format, so if the alignment value does not match any valid\r\nnumber (4K, 2M or 1G) in decimal format, try to interpret it as hex\r\nnumber.  This would make it work with both new and older kernels.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/nvml/1914)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/nvml/issues/comments/301589189","html_url":"https://github.com/pmem/nvml/pull/1914#issuecomment-301589189","issue_url":"https://api.github.com/repos/pmem/nvml/issues/1914","id":301589189,"user":{"login":"krzycz","id":8184299,"avatar_url":"https://avatars1.githubusercontent.com/u/8184299?v=3","gravatar_id":"","url":"https://api.github.com/users/krzycz","html_url":"https://github.com/krzycz","followers_url":"https://api.github.com/users/krzycz/followers","following_url":"https://api.github.com/users/krzycz/following{/other_user}","gists_url":"https://api.github.com/users/krzycz/gists{/gist_id}","starred_url":"https://api.github.com/users/krzycz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzycz/subscriptions","organizations_url":"https://api.github.com/users/krzycz/orgs","repos_url":"https://api.github.com/users/krzycz/repos","events_url":"https://api.github.com/users/krzycz/events{/privacy}","received_events_url":"https://api.github.com/users/krzycz/received_events","type":"User","site_admin":false},"created_at":"2017-05-15T20:06:05Z","updated_at":"2017-05-15T20:06:05Z","body":"\n\n\n\nReviewed 1 of 1 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[src/common/file_linux.c, line 229 at r1](https://reviewable.io:443/reviews/pmem/nvml/1914#-KkCX4fHrdL0eiq0UAvk-r1-229:-KkChOSwWnAhd9UAGMhO:b3g5emp) ([raw file](https://github.com/pmem/nvml/blob/42919216e47baf95b3ce53d3af3b7c4b8838e867/src/common/file_linux.c#L229)):*\n<details><summary><i>Previously, GBuella (Gabor Buella) wrote…</i></summary><blockquote>\n\nAlternatively one might write something like:\r\n`if ((size & (size - 1)) != 0)`\r\nand than no need to define MiB and GiB\n</blockquote></details>\n\nGood point. I'll change it.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/nvml/1914)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"krzycz"}}