{"action":"closed","number":1172,"pull_request":{"url":"https://api.github.com/repos/deployphp/deployer/pulls/1172","id":116348124,"html_url":"https://github.com/deployphp/deployer/pull/1172","diff_url":"https://github.com/deployphp/deployer/pull/1172.diff","patch_url":"https://github.com/deployphp/deployer/pull/1172.patch","issue_url":"https://api.github.com/repos/deployphp/deployer/issues/1172","number":1172,"state":"closed","locked":false,"title":"Feature/configurable ssh multiplexing","user":{"login":"mikeymike","id":2174476,"avatar_url":"https://avatars3.githubusercontent.com/u/2174476?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeymike","html_url":"https://github.com/mikeymike","followers_url":"https://api.github.com/users/mikeymike/followers","following_url":"https://api.github.com/users/mikeymike/following{/other_user}","gists_url":"https://api.github.com/users/mikeymike/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeymike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeymike/subscriptions","organizations_url":"https://api.github.com/users/mikeymike/orgs","repos_url":"https://api.github.com/users/mikeymike/repos","events_url":"https://api.github.com/users/mikeymike/events{/privacy}","received_events_url":"https://api.github.com/users/mikeymike/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | No\r\n| New feature?  | Yes\r\n| BC breaks?    | No\r\n| Deprecations? | No\r\n| Fixed tickets | #1165 \r\n\r\nI wanted more structure to the data and to be able to configure not just the options but all areas of the ssh flags/options as this really helps with debugging problems (and how I found the issue with #1155 )\r\n\r\nTo do this I created an immutable ssh arguments class that handles pretty much everything including the multiplex arguments. This was very important to me because these arguments may need to be used elsewhere and not just in the client, for example the `rsync` recipe will currently not be able to use the multiplexing unless the code is duplicated into that recipe. \r\n\r\nI also updated the tests where applicable including the yaml fixture with the new format I'm proposing. \r\n\r\nHopefully it makes sense, I'm open to feedback and I have some changes waiting to update the `rsync` recipe if this gets merged. \r\n\r\nAs a side note, IMO multiplexing should be enabled by default, but this is a separate discussion we can have. ","created_at":"2017-04-18T14:59:07Z","updated_at":"2017-05-04T05:24:50Z","closed_at":"2017-05-04T05:24:50Z","merged_at":"2017-05-04T05:24:50Z","merge_commit_sha":"a2c3f3fb1a47c95dfe54d65860338b8541f25ef0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/deployphp/deployer/pulls/1172/commits","review_comments_url":"https://api.github.com/repos/deployphp/deployer/pulls/1172/comments","review_comment_url":"https://api.github.com/repos/deployphp/deployer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deployphp/deployer/issues/1172/comments","statuses_url":"https://api.github.com/repos/deployphp/deployer/statuses/7ec8cfb9c2e48b290a2769cd2f12159d16e4821d","head":{"label":"mikeymike:feature/configurable-ssh-multiplexing","ref":"feature/configurable-ssh-multiplexing","sha":"7ec8cfb9c2e48b290a2769cd2f12159d16e4821d","user":{"login":"mikeymike","id":2174476,"avatar_url":"https://avatars3.githubusercontent.com/u/2174476?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeymike","html_url":"https://github.com/mikeymike","followers_url":"https://api.github.com/users/mikeymike/followers","following_url":"https://api.github.com/users/mikeymike/following{/other_user}","gists_url":"https://api.github.com/users/mikeymike/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeymike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeymike/subscriptions","organizations_url":"https://api.github.com/users/mikeymike/orgs","repos_url":"https://api.github.com/users/mikeymike/repos","events_url":"https://api.github.com/users/mikeymike/events{/privacy}","received_events_url":"https://api.github.com/users/mikeymike/received_events","type":"User","site_admin":false},"repo":{"id":88034999,"name":"deployer","full_name":"mikeymike/deployer","owner":{"login":"mikeymike","id":2174476,"avatar_url":"https://avatars3.githubusercontent.com/u/2174476?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeymike","html_url":"https://github.com/mikeymike","followers_url":"https://api.github.com/users/mikeymike/followers","following_url":"https://api.github.com/users/mikeymike/following{/other_user}","gists_url":"https://api.github.com/users/mikeymike/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeymike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeymike/subscriptions","organizations_url":"https://api.github.com/users/mikeymike/orgs","repos_url":"https://api.github.com/users/mikeymike/repos","events_url":"https://api.github.com/users/mikeymike/events{/privacy}","received_events_url":"https://api.github.com/users/mikeymike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikeymike/deployer","description":"A deployment tool written in PHP with support for popular frameworks out of the box","fork":true,"url":"https://api.github.com/repos/mikeymike/deployer","forks_url":"https://api.github.com/repos/mikeymike/deployer/forks","keys_url":"https://api.github.com/repos/mikeymike/deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikeymike/deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikeymike/deployer/teams","hooks_url":"https://api.github.com/repos/mikeymike/deployer/hooks","issue_events_url":"https://api.github.com/repos/mikeymike/deployer/issues/events{/number}","events_url":"https://api.github.com/repos/mikeymike/deployer/events","assignees_url":"https://api.github.com/repos/mikeymike/deployer/assignees{/user}","branches_url":"https://api.github.com/repos/mikeymike/deployer/branches{/branch}","tags_url":"https://api.github.com/repos/mikeymike/deployer/tags","blobs_url":"https://api.github.com/repos/mikeymike/deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikeymike/deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikeymike/deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikeymike/deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikeymike/deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/mikeymike/deployer/languages","stargazers_url":"https://api.github.com/repos/mikeymike/deployer/stargazers","contributors_url":"https://api.github.com/repos/mikeymike/deployer/contributors","subscribers_url":"https://api.github.com/repos/mikeymike/deployer/subscribers","subscription_url":"https://api.github.com/repos/mikeymike/deployer/subscription","commits_url":"https://api.github.com/repos/mikeymike/deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikeymike/deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikeymike/deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikeymike/deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikeymike/deployer/contents/{+path}","compare_url":"https://api.github.com/repos/mikeymike/deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikeymike/deployer/merges","archive_url":"https://api.github.com/repos/mikeymike/deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikeymike/deployer/downloads","issues_url":"https://api.github.com/repos/mikeymike/deployer/issues{/number}","pulls_url":"https://api.github.com/repos/mikeymike/deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/mikeymike/deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/mikeymike/deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikeymike/deployer/labels{/name}","releases_url":"https://api.github.com/repos/mikeymike/deployer/releases{/id}","deployments_url":"https://api.github.com/repos/mikeymike/deployer/deployments","created_at":"2017-04-12T09:35:45Z","updated_at":"2017-04-12T09:35:47Z","pushed_at":"2017-04-18T19:51:21Z","git_url":"git://github.com/mikeymike/deployer.git","ssh_url":"git@github.com:mikeymike/deployer.git","clone_url":"https://github.com/mikeymike/deployer.git","svn_url":"https://github.com/mikeymike/deployer","homepage":"https://deployer.org","size":1605,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deployphp:master","ref":"master","sha":"542e5f0dc279dbd2a21169c87c5f093a9cd2960e","user":{"login":"deployphp","id":8088857,"avatar_url":"https://avatars0.githubusercontent.com/u/8088857?v=3","gravatar_id":"","url":"https://api.github.com/users/deployphp","html_url":"https://github.com/deployphp","followers_url":"https://api.github.com/users/deployphp/followers","following_url":"https://api.github.com/users/deployphp/following{/other_user}","gists_url":"https://api.github.com/users/deployphp/gists{/gist_id}","starred_url":"https://api.github.com/users/deployphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deployphp/subscriptions","organizations_url":"https://api.github.com/users/deployphp/orgs","repos_url":"https://api.github.com/users/deployphp/repos","events_url":"https://api.github.com/users/deployphp/events{/privacy}","received_events_url":"https://api.github.com/users/deployphp/received_events","type":"Organization","site_admin":false},"repo":{"id":11340559,"name":"deployer","full_name":"deployphp/deployer","owner":{"login":"deployphp","id":8088857,"avatar_url":"https://avatars0.githubusercontent.com/u/8088857?v=3","gravatar_id":"","url":"https://api.github.com/users/deployphp","html_url":"https://github.com/deployphp","followers_url":"https://api.github.com/users/deployphp/followers","following_url":"https://api.github.com/users/deployphp/following{/other_user}","gists_url":"https://api.github.com/users/deployphp/gists{/gist_id}","starred_url":"https://api.github.com/users/deployphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deployphp/subscriptions","organizations_url":"https://api.github.com/users/deployphp/orgs","repos_url":"https://api.github.com/users/deployphp/repos","events_url":"https://api.github.com/users/deployphp/events{/privacy}","received_events_url":"https://api.github.com/users/deployphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/deployphp/deployer","description":"A deployment tool written in PHP with support for popular frameworks out of the box","fork":false,"url":"https://api.github.com/repos/deployphp/deployer","forks_url":"https://api.github.com/repos/deployphp/deployer/forks","keys_url":"https://api.github.com/repos/deployphp/deployer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deployphp/deployer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deployphp/deployer/teams","hooks_url":"https://api.github.com/repos/deployphp/deployer/hooks","issue_events_url":"https://api.github.com/repos/deployphp/deployer/issues/events{/number}","events_url":"https://api.github.com/repos/deployphp/deployer/events","assignees_url":"https://api.github.com/repos/deployphp/deployer/assignees{/user}","branches_url":"https://api.github.com/repos/deployphp/deployer/branches{/branch}","tags_url":"https://api.github.com/repos/deployphp/deployer/tags","blobs_url":"https://api.github.com/repos/deployphp/deployer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deployphp/deployer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deployphp/deployer/git/refs{/sha}","trees_url":"https://api.github.com/repos/deployphp/deployer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deployphp/deployer/statuses/{sha}","languages_url":"https://api.github.com/repos/deployphp/deployer/languages","stargazers_url":"https://api.github.com/repos/deployphp/deployer/stargazers","contributors_url":"https://api.github.com/repos/deployphp/deployer/contributors","subscribers_url":"https://api.github.com/repos/deployphp/deployer/subscribers","subscription_url":"https://api.github.com/repos/deployphp/deployer/subscription","commits_url":"https://api.github.com/repos/deployphp/deployer/commits{/sha}","git_commits_url":"https://api.github.com/repos/deployphp/deployer/git/commits{/sha}","comments_url":"https://api.github.com/repos/deployphp/deployer/comments{/number}","issue_comment_url":"https://api.github.com/repos/deployphp/deployer/issues/comments{/number}","contents_url":"https://api.github.com/repos/deployphp/deployer/contents/{+path}","compare_url":"https://api.github.com/repos/deployphp/deployer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deployphp/deployer/merges","archive_url":"https://api.github.com/repos/deployphp/deployer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deployphp/deployer/downloads","issues_url":"https://api.github.com/repos/deployphp/deployer/issues{/number}","pulls_url":"https://api.github.com/repos/deployphp/deployer/pulls{/number}","milestones_url":"https://api.github.com/repos/deployphp/deployer/milestones{/number}","notifications_url":"https://api.github.com/repos/deployphp/deployer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deployphp/deployer/labels{/name}","releases_url":"https://api.github.com/repos/deployphp/deployer/releases{/id}","deployments_url":"https://api.github.com/repos/deployphp/deployer/deployments","created_at":"2013-07-11T11:45:38Z","updated_at":"2017-05-04T03:26:42Z","pushed_at":"2017-05-04T05:24:50Z","git_url":"git://github.com/deployphp/deployer.git","ssh_url":"git@github.com:deployphp/deployer.git","clone_url":"https://github.com/deployphp/deployer.git","svn_url":"https://github.com/deployphp/deployer","homepage":"https://deployer.org","size":1597,"stargazers_count":4020,"watchers_count":4020,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":580,"mirror_url":null,"open_issues_count":25,"forks":580,"open_issues":25,"watchers":4020,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deployphp/deployer/pulls/1172"},"html":{"href":"https://github.com/deployphp/deployer/pull/1172"},"issue":{"href":"https://api.github.com/repos/deployphp/deployer/issues/1172"},"comments":{"href":"https://api.github.com/repos/deployphp/deployer/issues/1172/comments"},"review_comments":{"href":"https://api.github.com/repos/deployphp/deployer/pulls/1172/comments"},"review_comment":{"href":"https://api.github.com/repos/deployphp/deployer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deployphp/deployer/pulls/1172/commits"},"statuses":{"href":"https://api.github.com/repos/deployphp/deployer/statuses/7ec8cfb9c2e48b290a2769cd2f12159d16e4821d"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"antonmedv","id":141232,"avatar_url":"https://avatars3.githubusercontent.com/u/141232?v=3","gravatar_id":"","url":"https://api.github.com/users/antonmedv","html_url":"https://github.com/antonmedv","followers_url":"https://api.github.com/users/antonmedv/followers","following_url":"https://api.github.com/users/antonmedv/following{/other_user}","gists_url":"https://api.github.com/users/antonmedv/gists{/gist_id}","starred_url":"https://api.github.com/users/antonmedv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonmedv/subscriptions","organizations_url":"https://api.github.com/users/antonmedv/orgs","repos_url":"https://api.github.com/users/antonmedv/repos","events_url":"https://api.github.com/users/antonmedv/events{/privacy}","received_events_url":"https://api.github.com/users/antonmedv/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":6,"additions":346,"deletions":113,"changed_files":8}}
{"actor":{"display_login":"antonmedv"}}