{"action":"created","comment":{"url":"https://api.github.com/repos/reactjs/react-redux/pulls/comments/128318294","pull_request_review_id":50986951,"id":128318294,"diff_hunk":"@@ -56,6 +56,8 @@ It does not modify the component class passed to it; instead, it *returns* a new\n \n   If your `mapStateToProps` function is declared as taking two parameters, it will be called with the store state as the first parameter and the props passed to the connected component as the second parameter, and will also be re-invoked whenever the connected component receives new props as determined by shallow equality comparisons.  (The second parameter is normally referred to as `ownProps` by convention.)\n \n+  If an object is passed, each function inside it is assumed to be a Redux selector or a Factory function.","path":"docs/api.md","position":4,"original_position":4,"commit_id":"ead6fdefdc9f78dfaeb8aeb63748b53e8c3cf542","original_commit_id":"ead6fdefdc9f78dfaeb8aeb63748b53e8c3cf542","user":{"login":"pcwinters","id":1486022,"avatar_url":"https://avatars1.githubusercontent.com/u/1486022?v=4","gravatar_id":"","url":"https://api.github.com/users/pcwinters","html_url":"https://github.com/pcwinters","followers_url":"https://api.github.com/users/pcwinters/followers","following_url":"https://api.github.com/users/pcwinters/following{/other_user}","gists_url":"https://api.github.com/users/pcwinters/gists{/gist_id}","starred_url":"https://api.github.com/users/pcwinters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcwinters/subscriptions","organizations_url":"https://api.github.com/users/pcwinters/orgs","repos_url":"https://api.github.com/users/pcwinters/repos","events_url":"https://api.github.com/users/pcwinters/events{/privacy}","received_events_url":"https://api.github.com/users/pcwinters/received_events","type":"User","site_admin":false},"body":"don't forget on line 55 to document the argument as `[`mapStateToProps(state, [ownProps]): stateProps`] \\(*Object* or *Function*)`","created_at":"2017-07-19T17:49:11Z","updated_at":"2017-07-19T17:49:11Z","html_url":"https://github.com/reactjs/react-redux/pull/724#discussion_r128318294","pull_request_url":"https://api.github.com/repos/reactjs/react-redux/pulls/724","_links":{"self":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/comments/128318294"},"html":{"href":"https://github.com/reactjs/react-redux/pull/724#discussion_r128318294"},"pull_request":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/reactjs/react-redux/pulls/724","id":126642149,"html_url":"https://github.com/reactjs/react-redux/pull/724","diff_url":"https://github.com/reactjs/react-redux/pull/724.diff","patch_url":"https://github.com/reactjs/react-redux/pull/724.patch","issue_url":"https://api.github.com/repos/reactjs/react-redux/issues/724","number":724,"state":"open","locked":false,"title":"MapStateToProps shorthand syntax: Supporting factory selectors","user":{"login":"josepot","id":8620144,"avatar_url":"https://avatars1.githubusercontent.com/u/8620144?v=4","gravatar_id":"","url":"https://api.github.com/users/josepot","html_url":"https://github.com/josepot","followers_url":"https://api.github.com/users/josepot/followers","following_url":"https://api.github.com/users/josepot/following{/other_user}","gists_url":"https://api.github.com/users/josepot/gists{/gist_id}","starred_url":"https://api.github.com/users/josepot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josepot/subscriptions","organizations_url":"https://api.github.com/users/josepot/orgs","repos_url":"https://api.github.com/users/josepot/repos","events_url":"https://api.github.com/users/josepot/events{/privacy}","received_events_url":"https://api.github.com/users/josepot/received_events","type":"User","site_admin":false},"body":"Like #723 but supporting factory selectors... Because I'm of the opinion that the object-shorthand syntax should also [support factory selectors](https://github.com/reactjs/react-redux/pull/724/files#diff-b5fd7a42ea1b8efa382416b4a323003cR1953) like @jimbolla [suggested in the past](https://github.com/reactjs/react-redux/pull/323#issuecomment-272251764). 😄 \r\n\r\ncc: @gaearon, @jimbolla , @markerikson , @slorber, @timdorr","created_at":"2017-06-20T22:17:08Z","updated_at":"2017-07-19T17:49:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"305e3897bf4b0fdbdaf7451a5d47618c70a135f0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/react-redux/pulls/724/commits","review_comments_url":"https://api.github.com/repos/reactjs/react-redux/pulls/724/comments","review_comment_url":"https://api.github.com/repos/reactjs/react-redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactjs/react-redux/issues/724/comments","statuses_url":"https://api.github.com/repos/reactjs/react-redux/statuses/ead6fdefdc9f78dfaeb8aeb63748b53e8c3cf542","head":{"label":"josepot:feature/accept-object-in-mapStateToProps","ref":"feature/accept-object-in-mapStateToProps","sha":"ead6fdefdc9f78dfaeb8aeb63748b53e8c3cf542","user":{"login":"josepot","id":8620144,"avatar_url":"https://avatars1.githubusercontent.com/u/8620144?v=4","gravatar_id":"","url":"https://api.github.com/users/josepot","html_url":"https://github.com/josepot","followers_url":"https://api.github.com/users/josepot/followers","following_url":"https://api.github.com/users/josepot/following{/other_user}","gists_url":"https://api.github.com/users/josepot/gists{/gist_id}","starred_url":"https://api.github.com/users/josepot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josepot/subscriptions","organizations_url":"https://api.github.com/users/josepot/orgs","repos_url":"https://api.github.com/users/josepot/repos","events_url":"https://api.github.com/users/josepot/events{/privacy}","received_events_url":"https://api.github.com/users/josepot/received_events","type":"User","site_admin":false},"repo":{"id":62738182,"name":"react-redux","full_name":"josepot/react-redux","owner":{"login":"josepot","id":8620144,"avatar_url":"https://avatars1.githubusercontent.com/u/8620144?v=4","gravatar_id":"","url":"https://api.github.com/users/josepot","html_url":"https://github.com/josepot","followers_url":"https://api.github.com/users/josepot/followers","following_url":"https://api.github.com/users/josepot/following{/other_user}","gists_url":"https://api.github.com/users/josepot/gists{/gist_id}","starred_url":"https://api.github.com/users/josepot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josepot/subscriptions","organizations_url":"https://api.github.com/users/josepot/orgs","repos_url":"https://api.github.com/users/josepot/repos","events_url":"https://api.github.com/users/josepot/events{/privacy}","received_events_url":"https://api.github.com/users/josepot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josepot/react-redux","description":"Official React bindings for Redux","fork":true,"url":"https://api.github.com/repos/josepot/react-redux","forks_url":"https://api.github.com/repos/josepot/react-redux/forks","keys_url":"https://api.github.com/repos/josepot/react-redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josepot/react-redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josepot/react-redux/teams","hooks_url":"https://api.github.com/repos/josepot/react-redux/hooks","issue_events_url":"https://api.github.com/repos/josepot/react-redux/issues/events{/number}","events_url":"https://api.github.com/repos/josepot/react-redux/events","assignees_url":"https://api.github.com/repos/josepot/react-redux/assignees{/user}","branches_url":"https://api.github.com/repos/josepot/react-redux/branches{/branch}","tags_url":"https://api.github.com/repos/josepot/react-redux/tags","blobs_url":"https://api.github.com/repos/josepot/react-redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josepot/react-redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josepot/react-redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/josepot/react-redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josepot/react-redux/statuses/{sha}","languages_url":"https://api.github.com/repos/josepot/react-redux/languages","stargazers_url":"https://api.github.com/repos/josepot/react-redux/stargazers","contributors_url":"https://api.github.com/repos/josepot/react-redux/contributors","subscribers_url":"https://api.github.com/repos/josepot/react-redux/subscribers","subscription_url":"https://api.github.com/repos/josepot/react-redux/subscription","commits_url":"https://api.github.com/repos/josepot/react-redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/josepot/react-redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/josepot/react-redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/josepot/react-redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/josepot/react-redux/contents/{+path}","compare_url":"https://api.github.com/repos/josepot/react-redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josepot/react-redux/merges","archive_url":"https://api.github.com/repos/josepot/react-redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josepot/react-redux/downloads","issues_url":"https://api.github.com/repos/josepot/react-redux/issues{/number}","pulls_url":"https://api.github.com/repos/josepot/react-redux/pulls{/number}","milestones_url":"https://api.github.com/repos/josepot/react-redux/milestones{/number}","notifications_url":"https://api.github.com/repos/josepot/react-redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josepot/react-redux/labels{/name}","releases_url":"https://api.github.com/repos/josepot/react-redux/releases{/id}","deployments_url":"https://api.github.com/repos/josepot/react-redux/deployments","created_at":"2016-07-06T16:54:19Z","updated_at":"2016-07-06T16:54:21Z","pushed_at":"2017-06-21T01:23:00Z","git_url":"git://github.com/josepot/react-redux.git","ssh_url":"git@github.com:josepot/react-redux.git","clone_url":"https://github.com/josepot/react-redux.git","svn_url":"https://github.com/josepot/react-redux","homepage":"http://redux.js.org/docs/basics/UsageWithReact.html","size":637,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"65b7ccd008679dd116019cce6a790ba39d1fda10","user":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars3.githubusercontent.com/u/6412038?v=4","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":38934449,"name":"react-redux","full_name":"reactjs/react-redux","owner":{"login":"reactjs","id":6412038,"avatar_url":"https://avatars3.githubusercontent.com/u/6412038?v=4","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactjs/react-redux","description":"Official React bindings for Redux","fork":false,"url":"https://api.github.com/repos/reactjs/react-redux","forks_url":"https://api.github.com/repos/reactjs/react-redux/forks","keys_url":"https://api.github.com/repos/reactjs/react-redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/react-redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/react-redux/teams","hooks_url":"https://api.github.com/repos/reactjs/react-redux/hooks","issue_events_url":"https://api.github.com/repos/reactjs/react-redux/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/react-redux/events","assignees_url":"https://api.github.com/repos/reactjs/react-redux/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/react-redux/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/react-redux/tags","blobs_url":"https://api.github.com/repos/reactjs/react-redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/react-redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/react-redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/react-redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/react-redux/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/react-redux/languages","stargazers_url":"https://api.github.com/repos/reactjs/react-redux/stargazers","contributors_url":"https://api.github.com/repos/reactjs/react-redux/contributors","subscribers_url":"https://api.github.com/repos/reactjs/react-redux/subscribers","subscription_url":"https://api.github.com/repos/reactjs/react-redux/subscription","commits_url":"https://api.github.com/repos/reactjs/react-redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/react-redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/react-redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/react-redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/react-redux/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/react-redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/react-redux/merges","archive_url":"https://api.github.com/repos/reactjs/react-redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/react-redux/downloads","issues_url":"https://api.github.com/repos/reactjs/react-redux/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/react-redux/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/react-redux/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/react-redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/react-redux/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/react-redux/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/react-redux/deployments","created_at":"2015-07-11T17:32:01Z","updated_at":"2017-07-19T15:21:15Z","pushed_at":"2017-07-16T14:59:37Z","git_url":"git://github.com/reactjs/react-redux.git","ssh_url":"git@github.com:reactjs/react-redux.git","clone_url":"https://github.com/reactjs/react-redux.git","svn_url":"https://github.com/reactjs/react-redux","homepage":"http://redux.js.org/docs/basics/UsageWithReact.html","size":644,"stargazers_count":8527,"watchers_count":8527,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1368,"mirror_url":null,"open_issues_count":17,"forks":1368,"open_issues":17,"watchers":8527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/724"},"html":{"href":"https://github.com/reactjs/react-redux/pull/724"},"issue":{"href":"https://api.github.com/repos/reactjs/react-redux/issues/724"},"comments":{"href":"https://api.github.com/repos/reactjs/react-redux/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactjs/react-redux/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/react-redux/statuses/ead6fdefdc9f78dfaeb8aeb63748b53e8c3cf542"}}}}
{"actor":{"display_login":"pcwinters"}}