{"push_id":1616601894,"size":8,"distinct_size":8,"ref":"refs/heads/master","head":"9a15a70113b2859b0d9a425d662ba2aedc3a1254","before":"890ac81689d3e80dadf4d1bf450ce2107d80a8ba","commits":[{"sha":"2c290c1a987fa45bf16a8a9b2196fa3e5c114797","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@squareup.com"},"message":"Unconditionally install hooks on preparer startup.\n\nPrior to this commit the hook manifest (fetched from preparer manifest\nconfig) was compared to the current manifest written to disk for hooks.\nIf the manifests were the same, hook installation was skipped.\n\nThis commit removes this check and just unconditionally installs the\nhooks.\n\nThis is for two reasons:\n1) Installing is low-cost anyway. We don't redownload artifacts if\nthey're present on the disk, and the rest is just linking and writing of\nthe current manifest file.\n2) It's possible that the hooks might have been removed but the\ncurrent_manifest.yaml file for them was untouched, which will cause the\npreparer to incorrectly not install them.","distinct":true,"url":"https://api.github.com/repos/petertseng/p2/commits/2c290c1a987fa45bf16a8a9b2196fa3e5c114797"},{"sha":"b288cff30c271d0664a60b8d10cf1f0ad85c53a2","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@squareup.com"},"message":"Return special and testable error type when no labels are found.\n\nConsul has been known to return spurious 404s for data that is known to\nexist. As a result it makes sense to design our systems to discard\nresults for queries where data is expected to exist under all\nconditions.\n\nThis commit makes the label applicator return a special NoLabelsFound\nerror when listing all labels for a particular type. There are certain\nlabel types (e.g. replication controllers) for which we expect there to\nalways be labels. In this case clients seeing this error should discard\nthe results rather than attempt to use an empty label set.\n\nThis also affects the GetMatches() call on consul applicators because it\ncalls ListLabels under the hood and returns non-nil errors.","distinct":true,"url":"https://api.github.com/repos/petertseng/p2/commits/b288cff30c271d0664a60b8d10cf1f0ad85c53a2"},{"sha":"9b920269070b80434d1ea12d5d689f4fa9cbc71f","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@squareup.com"},"message":"Fix callsites of GetMatches() to use new label type where applicable.\n\nMost callsites of GetMatches pass labels.POD and labels.NODE as the call\nsites. We expect there to always be labels present for those types\nduring normal operation of P2, so it's good that these call sites will\nnow see errors when calling GetMatches if no labels of those types were\nfound in consul.\n\np2-label however takes a freeform label type on the command line, so now\nit prints different output to the user if no labels were found for the\nparticular type given.\n\nFurthermore, the label HTTP server will now return a 404 error if the\nselect endpoint is called for a particular label type and selector and\nno labels were found for the given label type. This is good since it\nallows clients to distinguish a selector matching 0 results from there\nbeing 0 results to begin with.","distinct":true,"url":"https://api.github.com/repos/petertseng/p2/commits/9b920269070b80434d1ea12d5d689f4fa9cbc71f"},{"sha":"3dba3b202c70ad37fd4ad3b4517e3f45823c53fa","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@squareup.com"},"message":"Fix callsites of ListLabels() to use new error type.\n\nThe only caller of ListLabels() is within the label http server. Now it\nwill return a 404 error instead of an unavailable error if the\nunderlying error was missing labels for the given label type. This will\nlet callers distinguish between transient server failures and failures\ndue to missing or apparently missing data.","distinct":true,"url":"https://api.github.com/repos/petertseng/p2/commits/3dba3b202c70ad37fd4ad3b4517e3f45823c53fa"},{"sha":"cf0fd12d9b8759d4d1d581bbc8f39a3502892f0d","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@squareup.com"},"message":"Make consul aggregator not propagate results based on zero labels.","distinct":true,"url":"https://api.github.com/repos/petertseng/p2/commits/cf0fd12d9b8759d4d1d581bbc8f39a3502892f0d"},{"sha":"a75e3a639390ec5ef078f71c9dda38a62718547b","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@squareup.com"},"message":"Add a pod label during integration test setup to allow RCs to function.","distinct":true,"url":"https://api.github.com/repos/petertseng/p2/commits/a75e3a639390ec5ef078f71c9dda38a62718547b"},{"sha":"0951a315328e6e836f25e5b02aa574fa6ecdc408","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@gmail.com"},"message":"Merge pull request #778 from mpuncel/mpuncel/label-404-error\n\nMpuncel/label 404 error","distinct":true,"url":"https://api.github.com/repos/petertseng/p2/commits/0951a315328e6e836f25e5b02aa574fa6ecdc408"},{"sha":"9a15a70113b2859b0d9a425d662ba2aedc3a1254","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@gmail.com"},"message":"Merge pull request #790 from mpuncel/mpuncel/always-install-hooks\n\nUnconditionally install hooks on preparer startup.","distinct":true,"url":"https://api.github.com/repos/petertseng/p2/commits/9a15a70113b2859b0d9a425d662ba2aedc3a1254"}]}
{"actor":{"display_login":"petertseng"}}