{"action":"closed","number":6024,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6024","id":139201085,"html_url":"https://github.com/dolphin-emu/dolphin/pull/6024","diff_url":"https://github.com/dolphin-emu/dolphin/pull/6024.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/6024.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6024","number":6024,"state":"closed","locked":false,"title":"Qt: use Settings::EmulationStateChanged","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"body":"**DolphinQt2 changes:**\r\n\r\nRemoves the soup of `connect(parent, &Parent::EmulationStarted, child, &Child::EmulationStarted)` that was needed to pass signals through multiple levels of widgets. Blegh.\r\n\r\nNow, it looks like:\r\n\r\n```c++\r\nconnect(&Settings::Instance(), &Settings::EmulationStateChanged, this,\r\n        [this](Core::State new_state) { ... });\r\n```\r\n\r\n**Core changes:**\r\n\r\nCurrently, `Core::SetOnStoppedCallback` informs the user when emulation has actually stopped (e.g. after pressing the power button). This PR replaces it with `Core::SetOnStateChangedCallback` which triggers on all state changes (whenever `Core::GetState()` would return a different value).\r\n\r\nAlso\r\n- Moves `Movie::DoFrameStep` into Core, since it doesn't depend on anything in Movie and changes emulation state.\r\n- Adds a new `Core::State::Starting` enum value. This seems to work fine. The only code other than GUI stuff that uses a catchall pattern like `state != Core::State::Uninitialized` is the GCAdapter code error-handling code, which I've updated to also check `state != Core::State::Starting`.","created_at":"2017-09-04T18:56:24Z","updated_at":"2017-09-15T16:45:18Z","closed_at":"2017-09-15T16:45:18Z","merged_at":"2017-09-15T16:45:18Z","merge_commit_sha":"0d078219358b04266206ea1e2622396db7724136","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6024/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6024/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6024/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3e1072b24dd8f60fd13b9aca3527066d478f9774","head":{"label":"ligfx:coreonstatechangedcallback","ref":"coreonstatechangedcallback","sha":"3e1072b24dd8f60fd13b9aca3527066d478f9774","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"repo":{"id":65220721,"name":"dolphin","full_name":"ligfx/dolphin","owner":{"login":"ligfx","id":594093,"avatar_url":"https://avatars2.githubusercontent.com/u/594093?v=4","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ligfx/dolphin","description":"Personal development branch of dolphin-emu/dolphin.","fork":true,"url":"https://api.github.com/repos/ligfx/dolphin","forks_url":"https://api.github.com/repos/ligfx/dolphin/forks","keys_url":"https://api.github.com/repos/ligfx/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligfx/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligfx/dolphin/teams","hooks_url":"https://api.github.com/repos/ligfx/dolphin/hooks","issue_events_url":"https://api.github.com/repos/ligfx/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/ligfx/dolphin/events","assignees_url":"https://api.github.com/repos/ligfx/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/ligfx/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/ligfx/dolphin/tags","blobs_url":"https://api.github.com/repos/ligfx/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligfx/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligfx/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligfx/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligfx/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/ligfx/dolphin/languages","stargazers_url":"https://api.github.com/repos/ligfx/dolphin/stargazers","contributors_url":"https://api.github.com/repos/ligfx/dolphin/contributors","subscribers_url":"https://api.github.com/repos/ligfx/dolphin/subscribers","subscription_url":"https://api.github.com/repos/ligfx/dolphin/subscription","commits_url":"https://api.github.com/repos/ligfx/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligfx/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligfx/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligfx/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligfx/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/ligfx/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligfx/dolphin/merges","archive_url":"https://api.github.com/repos/ligfx/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligfx/dolphin/downloads","issues_url":"https://api.github.com/repos/ligfx/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/ligfx/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/ligfx/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/ligfx/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligfx/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/ligfx/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/ligfx/dolphin/deployments","created_at":"2016-08-08T16:31:32Z","updated_at":"2017-05-17T22:06:54Z","pushed_at":"2017-09-15T00:28:44Z","git_url":"git://github.com/ligfx/dolphin.git","ssh_url":"git@github.com:ligfx/dolphin.git","clone_url":"https://github.com/ligfx/dolphin.git","svn_url":"https://github.com/ligfx/dolphin","homepage":"https://github.com/dolphin-emu/dolphin","size":311470,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ligfx"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"030dc11c6e31125cd03862f86815fe67d978f98d","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-09-15T13:40:05Z","pushed_at":"2017-09-15T16:45:17Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":348793,"stargazers_count":3685,"watchers_count":3685,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":925,"mirror_url":null,"open_issues_count":134,"forks":925,"open_issues":134,"watchers":3685,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6024"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/6024"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6024"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6024/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6024/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6024/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/3e1072b24dd8f60fd13b9aca3527066d478f9774"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"leoetlino","id":4209061,"avatar_url":"https://avatars2.githubusercontent.com/u/4209061?v=4","gravatar_id":"","url":"https://api.github.com/users/leoetlino","html_url":"https://github.com/leoetlino","followers_url":"https://api.github.com/users/leoetlino/followers","following_url":"https://api.github.com/users/leoetlino/following{/other_user}","gists_url":"https://api.github.com/users/leoetlino/gists{/gist_id}","starred_url":"https://api.github.com/users/leoetlino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leoetlino/subscriptions","organizations_url":"https://api.github.com/users/leoetlino/orgs","repos_url":"https://api.github.com/users/leoetlino/repos","events_url":"https://api.github.com/users/leoetlino/events{/privacy}","received_events_url":"https://api.github.com/users/leoetlino/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":156,"deletions":199,"changed_files":31}}
{"actor":{"display_login":"leoetlino"}}