{"action":"created","comment":{"url":"https://api.github.com/repos/uwescience/pulse2percept/pulls/comments/109996565","pull_request_review_id":31135897,"id":109996565,"diff_hunk":"@@ -113,6 +130,47 @@ def __init__(self, tsample, data):\n     def __getitem__(self, y):\r\n         return TimeSeries(self.tsample, self.data[y])\r\n \r\n+    def __add__(self, other):\r","path":"pulse2percept/utils.py","position":28,"original_position":28,"commit_id":"53ff0b1f7f5df4b14451e0f4c02c42c96144a47d","original_commit_id":"53ff0b1f7f5df4b14451e0f4c02c42c96144a47d","user":{"login":"mbeyeler","id":5214334,"avatar_url":"https://avatars1.githubusercontent.com/u/5214334?v=3","gravatar_id":"","url":"https://api.github.com/users/mbeyeler","html_url":"https://github.com/mbeyeler","followers_url":"https://api.github.com/users/mbeyeler/followers","following_url":"https://api.github.com/users/mbeyeler/following{/other_user}","gists_url":"https://api.github.com/users/mbeyeler/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeyeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeyeler/subscriptions","organizations_url":"https://api.github.com/users/mbeyeler/orgs","repos_url":"https://api.github.com/users/mbeyeler/repos","events_url":"https://api.github.com/users/mbeyeler/events{/privacy}","received_events_url":"https://api.github.com/users/mbeyeler/received_events","type":"User","site_admin":false},"body":"Sure, refactor into `append`.","created_at":"2017-04-05T18:43:13Z","updated_at":"2017-04-05T18:43:13Z","html_url":"https://github.com/uwescience/pulse2percept/pull/72#discussion_r109996565","pull_request_url":"https://api.github.com/repos/uwescience/pulse2percept/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/uwescience/pulse2percept/pulls/comments/109996565"},"html":{"href":"https://github.com/uwescience/pulse2percept/pull/72#discussion_r109996565"},"pull_request":{"href":"https://api.github.com/repos/uwescience/pulse2percept/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/uwescience/pulse2percept/pulls/72","id":111719181,"html_url":"https://github.com/uwescience/pulse2percept/pull/72","diff_url":"https://github.com/uwescience/pulse2percept/pull/72.diff","patch_url":"https://github.com/uwescience/pulse2percept/pull/72.patch","issue_url":"https://api.github.com/repos/uwescience/pulse2percept/issues/72","number":72,"state":"open","locked":false,"title":"[REVIEW] mb/video2pulsetrain","user":{"login":"mbeyeler","id":5214334,"avatar_url":"https://avatars1.githubusercontent.com/u/5214334?v=3","gravatar_id":"","url":"https://api.github.com/users/mbeyeler","html_url":"https://github.com/mbeyeler","followers_url":"https://api.github.com/users/mbeyeler/followers","following_url":"https://api.github.com/users/mbeyeler/following{/other_user}","gists_url":"https://api.github.com/users/mbeyeler/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeyeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeyeler/subscriptions","organizations_url":"https://api.github.com/users/mbeyeler/orgs","repos_url":"https://api.github.com/users/mbeyeler/repos","events_url":"https://api.github.com/users/mbeyeler/events{/privacy}","received_events_url":"https://api.github.com/users/mbeyeler/received_events","type":"User","site_admin":false},"body":"This PR adds a `video2pulsetrain` function to convert video files into stimuli. Videos can be loaded from file, and percepts can be stored to file. Uses Scikit-Video with either an `ffmpeg` or `libav` backend. Replaces some deprecated functionality such as `p2p.files.savemoviefiles` and `p2p.stimuli.Movie2Pulsetrain`.\r\n\r\n- [X] Add `video2pulsetrain`\r\n  - [X] processes every frame with `image2pulsetrain`\r\n  - [X] supports both amplitude and frequency modulation\r\n  - [X] makes `Movie2Pulsetrain`, `receptive_field`, and `retinalmovie2electrodtimeseries` obsolete\r\n- [X] Add load/save utilities to `files` module\r\n  - [X] `load_video` loads a video file either into a NumPy array or a TimeSeries object\r\n  - [X] `save_video` stores either a NumPy ndarray or a TimeSeries object in a video file\r\n  - [X] `save_video_sidebyside` stores both an input video and the `TimeSeries` output in a video file\r\n  - [X] makes `savemoviefiles` and `npy2movie` obsolete\r\n- [X] Add easy concatenation of pulse trains `pt = pt1 + pt2`\r\n- [X] Switch Travis build to `trusty` distro\r\n- [X] Fix `gap_size` issue in `image2pulsetrain`\r\n- [X] Fix `effectivecurrent` calculation when not all layers selected\r\n- [X] Add tests that process example images/videos from Scikit-Learn/Scikit-Video\r\n- [X] Complete documentation of new functionality","created_at":"2017-03-21T07:44:34Z","updated_at":"2017-04-05T18:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1648af291e241ebc8637324019c5b592c4a599b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/uwescience/pulse2percept/pulls/72/commits","review_comments_url":"https://api.github.com/repos/uwescience/pulse2percept/pulls/72/comments","review_comment_url":"https://api.github.com/repos/uwescience/pulse2percept/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uwescience/pulse2percept/issues/72/comments","statuses_url":"https://api.github.com/repos/uwescience/pulse2percept/statuses/53ff0b1f7f5df4b14451e0f4c02c42c96144a47d","head":{"label":"mbeyeler:mb/video2pulsetrain","ref":"mb/video2pulsetrain","sha":"53ff0b1f7f5df4b14451e0f4c02c42c96144a47d","user":{"login":"mbeyeler","id":5214334,"avatar_url":"https://avatars1.githubusercontent.com/u/5214334?v=3","gravatar_id":"","url":"https://api.github.com/users/mbeyeler","html_url":"https://github.com/mbeyeler","followers_url":"https://api.github.com/users/mbeyeler/followers","following_url":"https://api.github.com/users/mbeyeler/following{/other_user}","gists_url":"https://api.github.com/users/mbeyeler/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeyeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeyeler/subscriptions","organizations_url":"https://api.github.com/users/mbeyeler/orgs","repos_url":"https://api.github.com/users/mbeyeler/repos","events_url":"https://api.github.com/users/mbeyeler/events{/privacy}","received_events_url":"https://api.github.com/users/mbeyeler/received_events","type":"User","site_admin":false},"repo":{"id":66398832,"name":"pulse2percept","full_name":"mbeyeler/pulse2percept","owner":{"login":"mbeyeler","id":5214334,"avatar_url":"https://avatars1.githubusercontent.com/u/5214334?v=3","gravatar_id":"","url":"https://api.github.com/users/mbeyeler","html_url":"https://github.com/mbeyeler","followers_url":"https://api.github.com/users/mbeyeler/followers","following_url":"https://api.github.com/users/mbeyeler/following{/other_user}","gists_url":"https://api.github.com/users/mbeyeler/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeyeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeyeler/subscriptions","organizations_url":"https://api.github.com/users/mbeyeler/orgs","repos_url":"https://api.github.com/users/mbeyeler/repos","events_url":"https://api.github.com/users/mbeyeler/events{/privacy}","received_events_url":"https://api.github.com/users/mbeyeler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbeyeler/pulse2percept","description":"Models for retinal prosthetics","fork":true,"url":"https://api.github.com/repos/mbeyeler/pulse2percept","forks_url":"https://api.github.com/repos/mbeyeler/pulse2percept/forks","keys_url":"https://api.github.com/repos/mbeyeler/pulse2percept/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbeyeler/pulse2percept/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbeyeler/pulse2percept/teams","hooks_url":"https://api.github.com/repos/mbeyeler/pulse2percept/hooks","issue_events_url":"https://api.github.com/repos/mbeyeler/pulse2percept/issues/events{/number}","events_url":"https://api.github.com/repos/mbeyeler/pulse2percept/events","assignees_url":"https://api.github.com/repos/mbeyeler/pulse2percept/assignees{/user}","branches_url":"https://api.github.com/repos/mbeyeler/pulse2percept/branches{/branch}","tags_url":"https://api.github.com/repos/mbeyeler/pulse2percept/tags","blobs_url":"https://api.github.com/repos/mbeyeler/pulse2percept/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbeyeler/pulse2percept/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbeyeler/pulse2percept/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbeyeler/pulse2percept/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbeyeler/pulse2percept/statuses/{sha}","languages_url":"https://api.github.com/repos/mbeyeler/pulse2percept/languages","stargazers_url":"https://api.github.com/repos/mbeyeler/pulse2percept/stargazers","contributors_url":"https://api.github.com/repos/mbeyeler/pulse2percept/contributors","subscribers_url":"https://api.github.com/repos/mbeyeler/pulse2percept/subscribers","subscription_url":"https://api.github.com/repos/mbeyeler/pulse2percept/subscription","commits_url":"https://api.github.com/repos/mbeyeler/pulse2percept/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbeyeler/pulse2percept/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbeyeler/pulse2percept/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbeyeler/pulse2percept/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbeyeler/pulse2percept/contents/{+path}","compare_url":"https://api.github.com/repos/mbeyeler/pulse2percept/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbeyeler/pulse2percept/merges","archive_url":"https://api.github.com/repos/mbeyeler/pulse2percept/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbeyeler/pulse2percept/downloads","issues_url":"https://api.github.com/repos/mbeyeler/pulse2percept/issues{/number}","pulls_url":"https://api.github.com/repos/mbeyeler/pulse2percept/pulls{/number}","milestones_url":"https://api.github.com/repos/mbeyeler/pulse2percept/milestones{/number}","notifications_url":"https://api.github.com/repos/mbeyeler/pulse2percept/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbeyeler/pulse2percept/labels{/name}","releases_url":"https://api.github.com/repos/mbeyeler/pulse2percept/releases{/id}","deployments_url":"https://api.github.com/repos/mbeyeler/pulse2percept/deployments","created_at":"2016-08-23T20:00:30Z","updated_at":"2016-12-14T18:39:31Z","pushed_at":"2017-04-04T02:13:13Z","git_url":"git://github.com/mbeyeler/pulse2percept.git","ssh_url":"git@github.com:mbeyeler/pulse2percept.git","clone_url":"https://github.com/mbeyeler/pulse2percept.git","svn_url":"https://github.com/mbeyeler/pulse2percept","homepage":"","size":291994,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uwescience:master","ref":"master","sha":"5e87ddbda03ce89a3016697a3acfaf39fc8d9a28","user":{"login":"uwescience","id":2243113,"avatar_url":"https://avatars2.githubusercontent.com/u/2243113?v=3","gravatar_id":"","url":"https://api.github.com/users/uwescience","html_url":"https://github.com/uwescience","followers_url":"https://api.github.com/users/uwescience/followers","following_url":"https://api.github.com/users/uwescience/following{/other_user}","gists_url":"https://api.github.com/users/uwescience/gists{/gist_id}","starred_url":"https://api.github.com/users/uwescience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwescience/subscriptions","organizations_url":"https://api.github.com/users/uwescience/orgs","repos_url":"https://api.github.com/users/uwescience/repos","events_url":"https://api.github.com/users/uwescience/events{/privacy}","received_events_url":"https://api.github.com/users/uwescience/received_events","type":"Organization","site_admin":false},"repo":{"id":49095416,"name":"pulse2percept","full_name":"uwescience/pulse2percept","owner":{"login":"uwescience","id":2243113,"avatar_url":"https://avatars2.githubusercontent.com/u/2243113?v=3","gravatar_id":"","url":"https://api.github.com/users/uwescience","html_url":"https://github.com/uwescience","followers_url":"https://api.github.com/users/uwescience/followers","following_url":"https://api.github.com/users/uwescience/following{/other_user}","gists_url":"https://api.github.com/users/uwescience/gists{/gist_id}","starred_url":"https://api.github.com/users/uwescience/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwescience/subscriptions","organizations_url":"https://api.github.com/users/uwescience/orgs","repos_url":"https://api.github.com/users/uwescience/repos","events_url":"https://api.github.com/users/uwescience/events{/privacy}","received_events_url":"https://api.github.com/users/uwescience/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uwescience/pulse2percept","description":"Models for retinal prosthetics","fork":false,"url":"https://api.github.com/repos/uwescience/pulse2percept","forks_url":"https://api.github.com/repos/uwescience/pulse2percept/forks","keys_url":"https://api.github.com/repos/uwescience/pulse2percept/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uwescience/pulse2percept/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uwescience/pulse2percept/teams","hooks_url":"https://api.github.com/repos/uwescience/pulse2percept/hooks","issue_events_url":"https://api.github.com/repos/uwescience/pulse2percept/issues/events{/number}","events_url":"https://api.github.com/repos/uwescience/pulse2percept/events","assignees_url":"https://api.github.com/repos/uwescience/pulse2percept/assignees{/user}","branches_url":"https://api.github.com/repos/uwescience/pulse2percept/branches{/branch}","tags_url":"https://api.github.com/repos/uwescience/pulse2percept/tags","blobs_url":"https://api.github.com/repos/uwescience/pulse2percept/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uwescience/pulse2percept/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uwescience/pulse2percept/git/refs{/sha}","trees_url":"https://api.github.com/repos/uwescience/pulse2percept/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uwescience/pulse2percept/statuses/{sha}","languages_url":"https://api.github.com/repos/uwescience/pulse2percept/languages","stargazers_url":"https://api.github.com/repos/uwescience/pulse2percept/stargazers","contributors_url":"https://api.github.com/repos/uwescience/pulse2percept/contributors","subscribers_url":"https://api.github.com/repos/uwescience/pulse2percept/subscribers","subscription_url":"https://api.github.com/repos/uwescience/pulse2percept/subscription","commits_url":"https://api.github.com/repos/uwescience/pulse2percept/commits{/sha}","git_commits_url":"https://api.github.com/repos/uwescience/pulse2percept/git/commits{/sha}","comments_url":"https://api.github.com/repos/uwescience/pulse2percept/comments{/number}","issue_comment_url":"https://api.github.com/repos/uwescience/pulse2percept/issues/comments{/number}","contents_url":"https://api.github.com/repos/uwescience/pulse2percept/contents/{+path}","compare_url":"https://api.github.com/repos/uwescience/pulse2percept/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uwescience/pulse2percept/merges","archive_url":"https://api.github.com/repos/uwescience/pulse2percept/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uwescience/pulse2percept/downloads","issues_url":"https://api.github.com/repos/uwescience/pulse2percept/issues{/number}","pulls_url":"https://api.github.com/repos/uwescience/pulse2percept/pulls{/number}","milestones_url":"https://api.github.com/repos/uwescience/pulse2percept/milestones{/number}","notifications_url":"https://api.github.com/repos/uwescience/pulse2percept/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uwescience/pulse2percept/labels{/name}","releases_url":"https://api.github.com/repos/uwescience/pulse2percept/releases{/id}","deployments_url":"https://api.github.com/repos/uwescience/pulse2percept/deployments","created_at":"2016-01-05T22:01:46Z","updated_at":"2017-02-22T16:57:14Z","pushed_at":"2017-03-30T01:55:18Z","git_url":"git://github.com/uwescience/pulse2percept.git","ssh_url":"git@github.com:uwescience/pulse2percept.git","clone_url":"https://github.com/uwescience/pulse2percept.git","svn_url":"https://github.com/uwescience/pulse2percept","homepage":"http://uwescience.github.io/pulse2percept/","size":272292,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uwescience/pulse2percept/pulls/72"},"html":{"href":"https://github.com/uwescience/pulse2percept/pull/72"},"issue":{"href":"https://api.github.com/repos/uwescience/pulse2percept/issues/72"},"comments":{"href":"https://api.github.com/repos/uwescience/pulse2percept/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/uwescience/pulse2percept/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/uwescience/pulse2percept/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uwescience/pulse2percept/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/uwescience/pulse2percept/statuses/53ff0b1f7f5df4b14451e0f4c02c42c96144a47d"}}}}
{"actor":{"display_login":"mbeyeler"}}