{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/156694777","pull_request_review_id":83203376,"id":156694777,"diff_hunk":"@@ -124,9 +124,9 @@ class FormDescription(object):\n     ALLOWED_TYPES = [\"text\", \"email\", \"select\", \"textarea\", \"checkbox\", \"password\", \"hidden\"]\n \n     ALLOWED_RESTRICTIONS = {\n-        \"text\": [\"min_length\", \"max_length\"],\n-        \"password\": [\"min_length\", \"max_length\"],\n-        \"email\": [\"min_length\", \"max_length\"],\n+        \"text\": [\"min_length\", \"max_length\", \"readonly\"],\n+        \"password\": [\"min_length\", \"max_length\", \"readonly\"],\n+        \"email\": [\"min_length\", \"max_length\", \"readonly\"],","path":"openedx/core/djangoapps/user_api/helpers.py","position":9,"original_position":9,"commit_id":"2da3db604bb31b076148d7670cbbe8a6dd7e673e","original_commit_id":"2da3db604bb31b076148d7670cbbe8a6dd7e673e","user":{"login":"douglashall","id":224634,"avatar_url":"https://avatars2.githubusercontent.com/u/224634?v=4","gravatar_id":"","url":"https://api.github.com/users/douglashall","html_url":"https://github.com/douglashall","followers_url":"https://api.github.com/users/douglashall/followers","following_url":"https://api.github.com/users/douglashall/following{/other_user}","gists_url":"https://api.github.com/users/douglashall/gists{/gist_id}","starred_url":"https://api.github.com/users/douglashall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglashall/subscriptions","organizations_url":"https://api.github.com/users/douglashall/orgs","repos_url":"https://api.github.com/users/douglashall/repos","events_url":"https://api.github.com/users/douglashall/events{/privacy}","received_events_url":"https://api.github.com/users/douglashall/received_events","type":"User","site_admin":false},"body":"Revert these changes. They are not relevant to this story.","created_at":"2017-12-13T15:40:20Z","updated_at":"2017-12-13T16:02:10Z","html_url":"https://github.com/edx/edx-platform/pull/16691#discussion_r156694777","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/16691","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/156694777"},"html":{"href":"https://github.com/edx/edx-platform/pull/16691#discussion_r156694777"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/16691"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/16691","id":155052981,"html_url":"https://github.com/edx/edx-platform/pull/16691","diff_url":"https://github.com/edx/edx-platform/pull/16691.diff","patch_url":"https://github.com/edx/edx-platform/pull/16691.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/16691","number":16691,"state":"open","locked":false,"title":"[ENT-760]:  Disable linking of personal accounts to enterprise customers via SSO","user":{"login":"saleem-latif","id":7114956,"avatar_url":"https://avatars3.githubusercontent.com/u/7114956?v=4","gravatar_id":"","url":"https://api.github.com/users/saleem-latif","html_url":"https://github.com/saleem-latif","followers_url":"https://api.github.com/users/saleem-latif/followers","following_url":"https://api.github.com/users/saleem-latif/following{/other_user}","gists_url":"https://api.github.com/users/saleem-latif/gists{/gist_id}","starred_url":"https://api.github.com/users/saleem-latif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saleem-latif/subscriptions","organizations_url":"https://api.github.com/users/saleem-latif/orgs","repos_url":"https://api.github.com/users/saleem-latif/repos","events_url":"https://api.github.com/users/saleem-latif/events{/privacy}","received_events_url":"https://api.github.com/users/saleem-latif/received_events","type":"User","site_admin":false},"body":"**Background/Problem to solve:**\r\nCurrently when coming in via SSO, the learner has option to create account or sign in with existing account. The linking account becomes a bit problematic from a flow perspective and customers are unhappy with how the data appears as there are a lot of non-company email addresses, etc.\r\n\r\n**Request:**\r\nDisable ability to link account when coming in via SSO. Force user to create an account with whatever credentials are being pass over.\r\n\r\n**Considerations**\r\n1. If user already has account on edX with an email address that matches the email address provided via SSO, then link this account and update the profile with any new information passed from company provider (ref:   ENT-759 DEPLOYED TO STAGE (BUSINESS)  ). At the end of this workflow there should still be a single edX learner account, now linked to the IdP and Enterprise Customer. Need to allow learner to reset password in this workflow.\r\n2. Learner support may get requests to merge accounts. The statement will be until we have better messaging \"Your company prefers you have a separate account connected to your learning associated with your work at the company. All work done prior to your company's partnership with edX is unfortunately not included in your company's program. We recommend you reach out to your manager about the best way to incorporate prior learning into your company's specific learning system\" \r\n\r\n**Testing Instructions:**\r\n\r\n1. Go to user admin page at https://business.sandbox.edx.org/admin/auth/user/\r\n2. search for username `myself` (https://business.sandbox.edx.org/admin/auth/user/?q=myself) and delete the user that has this username if present.\r\n3. Now go to admin page for third party auth at https://business.sandbox.edx.org/admin/third_party_auth/samlproviderconfig/ and click update for `Pied Piper` IdP.\r\n4. Make suer `Sync learner profile data` is checked and `Skip registration form` is unchecked and hit save.\r\n5. Now open account registration page https://business.sandbox.edx.org/register in a browser that does not have an active session.\r\n6. Click on `Pied Piper` from `Create an account using` section\r\n7. On testshib login page add credentials for `myself` user\r\n8. Make sure you are redirected back to registration page of business sandbox and `email` and `Full Name`  fields are displayed and that `Full Name` field is grayed out and is not editable.\r\n9. Add an email address and hit save and make sure account is created.\r\n","created_at":"2017-11-28T12:03:27Z","updated_at":"2017-12-13T16:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f9bb5cdbe558442eb1cba2d073f7e65fe7ab179","assignee":{"login":"saleem-latif","id":7114956,"avatar_url":"https://avatars3.githubusercontent.com/u/7114956?v=4","gravatar_id":"","url":"https://api.github.com/users/saleem-latif","html_url":"https://github.com/saleem-latif","followers_url":"https://api.github.com/users/saleem-latif/followers","following_url":"https://api.github.com/users/saleem-latif/following{/other_user}","gists_url":"https://api.github.com/users/saleem-latif/gists{/gist_id}","starred_url":"https://api.github.com/users/saleem-latif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saleem-latif/subscriptions","organizations_url":"https://api.github.com/users/saleem-latif/orgs","repos_url":"https://api.github.com/users/saleem-latif/repos","events_url":"https://api.github.com/users/saleem-latif/events{/privacy}","received_events_url":"https://api.github.com/users/saleem-latif/received_events","type":"User","site_admin":false},"assignees":[{"login":"saleem-latif","id":7114956,"avatar_url":"https://avatars3.githubusercontent.com/u/7114956?v=4","gravatar_id":"","url":"https://api.github.com/users/saleem-latif","html_url":"https://github.com/saleem-latif","followers_url":"https://api.github.com/users/saleem-latif/followers","following_url":"https://api.github.com/users/saleem-latif/following{/other_user}","gists_url":"https://api.github.com/users/saleem-latif/gists{/gist_id}","starred_url":"https://api.github.com/users/saleem-latif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saleem-latif/subscriptions","organizations_url":"https://api.github.com/users/saleem-latif/orgs","repos_url":"https://api.github.com/users/saleem-latif/repos","events_url":"https://api.github.com/users/saleem-latif/events{/privacy}","received_events_url":"https://api.github.com/users/saleem-latif/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"georgebabey","id":1643389,"avatar_url":"https://avatars2.githubusercontent.com/u/1643389?v=4","gravatar_id":"","url":"https://api.github.com/users/georgebabey","html_url":"https://github.com/georgebabey","followers_url":"https://api.github.com/users/georgebabey/followers","following_url":"https://api.github.com/users/georgebabey/following{/other_user}","gists_url":"https://api.github.com/users/georgebabey/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebabey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebabey/subscriptions","organizations_url":"https://api.github.com/users/georgebabey/orgs","repos_url":"https://api.github.com/users/georgebabey/repos","events_url":"https://api.github.com/users/georgebabey/events{/privacy}","received_events_url":"https://api.github.com/users/georgebabey/received_events","type":"User","site_admin":false},{"login":"asadiqbal08","id":7334669,"avatar_url":"https://avatars2.githubusercontent.com/u/7334669?v=4","gravatar_id":"","url":"https://api.github.com/users/asadiqbal08","html_url":"https://github.com/asadiqbal08","followers_url":"https://api.github.com/users/asadiqbal08/followers","following_url":"https://api.github.com/users/asadiqbal08/following{/other_user}","gists_url":"https://api.github.com/users/asadiqbal08/gists{/gist_id}","starred_url":"https://api.github.com/users/asadiqbal08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asadiqbal08/subscriptions","organizations_url":"https://api.github.com/users/asadiqbal08/orgs","repos_url":"https://api.github.com/users/asadiqbal08/repos","events_url":"https://api.github.com/users/asadiqbal08/events{/privacy}","received_events_url":"https://api.github.com/users/asadiqbal08/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/16691/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/16691/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/16691/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/2da3db604bb31b076148d7670cbbe8a6dd7e673e","head":{"label":"edx:saleem-latif/ENT-760","ref":"saleem-latif/ENT-760","sha":"2da3db604bb31b076148d7670cbbe8a6dd7e673e","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-12-13T12:35:25Z","pushed_at":"2017-12-13T15:58:58Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":866878,"stargazers_count":3445,"watchers_count":3445,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1950,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1950,"open_issues":217,"watchers":3445,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"773b622efa2e0c36ddff8fb96209be48c08817de","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-12-13T12:35:25Z","pushed_at":"2017-12-13T15:58:58Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":866878,"stargazers_count":3445,"watchers_count":3445,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1950,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1950,"open_issues":217,"watchers":3445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/16691"},"html":{"href":"https://github.com/edx/edx-platform/pull/16691"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/16691"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/16691/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/16691/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/16691/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/2da3db604bb31b076148d7670cbbe8a6dd7e673e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"douglashall"}}