{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/2613","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/2613/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/2613/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/2613/events","html_url":"https://github.com/kubernetes/kops/pull/2613","id":230150113,"number":2613,"title":"WIP: Make Weave MTU configurable with default support for jumbo frames","user":{"login":"jordanjennings","id":1031913,"avatar_url":"https://avatars1.githubusercontent.com/u/1031913?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanjennings","html_url":"https://github.com/jordanjennings","followers_url":"https://api.github.com/users/jordanjennings/followers","following_url":"https://api.github.com/users/jordanjennings/following{/other_user}","gists_url":"https://api.github.com/users/jordanjennings/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanjennings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanjennings/subscriptions","organizations_url":"https://api.github.com/users/jordanjennings/orgs","repos_url":"https://api.github.com/users/jordanjennings/repos","events_url":"https://api.github.com/users/jordanjennings/events{/privacy}","received_events_url":"https://api.github.com/users/jordanjennings/received_events","type":"User","site_admin":false},"labels":[{"id":485059302,"url":"https://api.github.com/repos/kubernetes/kops/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2017-05-20T12:16:17Z","updated_at":"2017-05-24T02:36:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/2613","html_url":"https://github.com/kubernetes/kops/pull/2613","diff_url":"https://github.com/kubernetes/kops/pull/2613.diff","patch_url":"https://github.com/kubernetes/kops/pull/2613.patch"},"body":"Pull request for #2600 to make MTU configurable and to set a good default value.\r\n\r\nFrom the discussion in #1171 it looks like nonMasqueradeCIDR is meant for the overlay CIDR, so I added that to the configuration as well.\r\n\r\nNew config looks like:\r\n\r\n```\r\nspec:\r\n  networking:\r\n    weave:\r\n      mtu: 8912\r\n```\r\n\r\nI tested the following scenarios with this change:\r\n- Editing an existing cluster and adding `mtu: 8912`, then running update cluster. The ManagedFile for weave was updated as expected, however I am not sure what the process would be to actually get the settings rolled out.\r\n- Creating a new cluster with command line flags (it sets `mtu: 8912` as expected)\r\n- Creating a new cluster with `kops create -f mycluster.yml` based on https://github.com/kubernetes/kops/blob/master/tests/integration/privateweave/in-v1alpha2.yaml with minor edits\r\n\r\nTodo:\r\n- Update docs\r\n\r\nLet me know if there's anything else I need to do.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kops/2613)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kops/issues/comments/303601422","html_url":"https://github.com/kubernetes/kops/pull/2613#issuecomment-303601422","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/2613","id":303601422,"user":{"login":"jordanjennings","id":1031913,"avatar_url":"https://avatars1.githubusercontent.com/u/1031913?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanjennings","html_url":"https://github.com/jordanjennings","followers_url":"https://api.github.com/users/jordanjennings/followers","following_url":"https://api.github.com/users/jordanjennings/following{/other_user}","gists_url":"https://api.github.com/users/jordanjennings/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanjennings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanjennings/subscriptions","organizations_url":"https://api.github.com/users/jordanjennings/orgs","repos_url":"https://api.github.com/users/jordanjennings/repos","events_url":"https://api.github.com/users/jordanjennings/events{/privacy}","received_events_url":"https://api.github.com/users/jordanjennings/received_events","type":"User","site_admin":false},"created_at":"2017-05-24T02:36:37Z","updated_at":"2017-05-24T02:36:37Z","body":"@chrislovecnm Per AWS docs:\r\n\r\n> The following instances support jumbo frames:\r\n> \r\n> Compute optimized: C3, C4, CC2\r\n> General purpose: M3, M4, T2\r\n> Accelerated computing: CG1, F1, G2, P2\r\n> Memory optimized: CR1, R3, R4, X1\r\n> Storage optimized: D2, HI1, HS1, I2, I3\r\n\r\nAlso:\r\n\r\n> outside of a given AWS region (EC2-Classic), a single VPC, or a VPC peering connection, you will experience a maximum path of 1500 MTU\r\n\r\nShould we reduce potential issues by not trying to make this the default? I just want it to be configurable somehow, I don't really care personally about it being the default unless others agree that it's a sensible thing to do for everyone."}}
{"actor":{"display_login":"jordanjennings"}}