{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments/103787768","pull_request_review_id":24588386,"id":103787768,"diff_hunk":"@@ -31,6 +31,15 @@ def get_registry_conf(agentConfig):\n \n     return registry_conf\n \n+def get_windows_sdk_check(name):\n+    sdk_reg_path = \"SOFTWARE\\\\Datadog\\\\Datadog Agent\\\\Integrations\\\\{}\".format(name)\n+    try:\n+        with _winreg.OpenKey(_winreg.HKEY_LOCAL_MACHINE,sdk_reg_path) as reg_key:\n+            directory = _winreg.QueryValueEx(reg_key, \"InstallPath\")[0]\n+            return os.path.join(directory, 'Integrations', name, 'check.py')\n+    except WindowsError as e:","path":"utils/windows_configuration.py","position":10,"original_position":10,"commit_id":"c587b44cf0b3d2d9e7ee9ac2524382c8acc4593b","original_commit_id":"c587b44cf0b3d2d9e7ee9ac2524382c8acc4593b","user":{"login":"gmmeyer","id":3253673,"avatar_url":"https://avatars2.githubusercontent.com/u/3253673?v=3","gravatar_id":"","url":"https://api.github.com/users/gmmeyer","html_url":"https://github.com/gmmeyer","followers_url":"https://api.github.com/users/gmmeyer/followers","following_url":"https://api.github.com/users/gmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/gmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/gmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmmeyer/subscriptions","organizations_url":"https://api.github.com/users/gmmeyer/orgs","repos_url":"https://api.github.com/users/gmmeyer/repos","events_url":"https://api.github.com/users/gmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/gmmeyer/received_events","type":"User","site_admin":false},"body":"I know that's one time it does, I don't know about only. @derekwbrown?","created_at":"2017-03-01T21:02:05Z","updated_at":"2017-03-01T21:02:05Z","html_url":"https://github.com/DataDog/dd-agent/pull/3231#discussion_r103787768","pull_request_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/3231","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments/103787768"},"html":{"href":"https://github.com/DataDog/dd-agent/pull/3231#discussion_r103787768"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/3231"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-agent/pulls/3231","id":108582563,"html_url":"https://github.com/DataDog/dd-agent/pull/3231","diff_url":"https://github.com/DataDog/dd-agent/pull/3231.diff","patch_url":"https://github.com/DataDog/dd-agent/pull/3231.patch","issue_url":"https://api.github.com/repos/DataDog/dd-agent/issues/3231","number":3231,"state":"open","locked":false,"title":"adds logic for windows sdk check loading","user":{"login":"gmmeyer","id":3253673,"avatar_url":"https://avatars2.githubusercontent.com/u/3253673?v=3","gravatar_id":"","url":"https://api.github.com/users/gmmeyer","html_url":"https://github.com/gmmeyer","followers_url":"https://api.github.com/users/gmmeyer/followers","following_url":"https://api.github.com/users/gmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/gmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/gmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmmeyer/subscriptions","organizations_url":"https://api.github.com/users/gmmeyer/orgs","repos_url":"https://api.github.com/users/gmmeyer/repos","events_url":"https://api.github.com/users/gmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/gmmeyer/received_events","type":"User","site_admin":false},"body":"On Windows, the integrations installer will allow them to place an integration anywhere they want, and it will write that location in the registry.\r\n\r\nThis forces our sdk loader to act a differently than otherwise, it grabs the key from the registry, then it loads the check from it.","created_at":"2017-03-01T17:00:09Z","updated_at":"2017-03-01T21:02:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91af2f3f285c9eb8a8e897c7932151183cf195e7","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-agent/milestones/79","html_url":"https://github.com/DataDog/dd-agent/milestone/79","labels_url":"https://api.github.com/repos/DataDog/dd-agent/milestones/79/labels","id":2265876,"number":79,"title":"5.12.0","description":"","creator":{"login":"olivielpeau","id":4912500,"avatar_url":"https://avatars1.githubusercontent.com/u/4912500?v=3","gravatar_id":"","url":"https://api.github.com/users/olivielpeau","html_url":"https://github.com/olivielpeau","followers_url":"https://api.github.com/users/olivielpeau/followers","following_url":"https://api.github.com/users/olivielpeau/following{/other_user}","gists_url":"https://api.github.com/users/olivielpeau/gists{/gist_id}","starred_url":"https://api.github.com/users/olivielpeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivielpeau/subscriptions","organizations_url":"https://api.github.com/users/olivielpeau/orgs","repos_url":"https://api.github.com/users/olivielpeau/repos","events_url":"https://api.github.com/users/olivielpeau/events{/privacy}","received_events_url":"https://api.github.com/users/olivielpeau/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":103,"state":"open","created_at":"2017-01-20T00:57:56Z","updated_at":"2017-03-01T19:12:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/3231/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/3231/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/issues/3231/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/c587b44cf0b3d2d9e7ee9ac2524382c8acc4593b","head":{"label":"DataDog:greg/windows-loading","ref":"greg/windows-loading","sha":"c587b44cf0b3d2d9e7ee9ac2524382c8acc4593b","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars2.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":1210071,"name":"dd-agent","full_name":"DataDog/dd-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars2.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-agent","description":"Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/dd-agent","forks_url":"https://api.github.com/repos/DataDog/dd-agent/forks","keys_url":"https://api.github.com/repos/DataDog/dd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-agent/events","assignees_url":"https://api.github.com/repos/DataDog/dd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-agent/merges","archive_url":"https://api.github.com/repos/DataDog/dd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-agent/deployments","created_at":"2010-12-31T03:02:47Z","updated_at":"2017-03-01T02:53:07Z","pushed_at":"2017-03-01T20:28:29Z","git_url":"git://github.com/DataDog/dd-agent.git","ssh_url":"git@github.com:DataDog/dd-agent.git","clone_url":"https://github.com/DataDog/dd-agent.git","svn_url":"https://github.com/DataDog/dd-agent","homepage":"https://docs.datadoghq.com/","size":40627,"stargazers_count":747,"watchers_count":747,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":690,"mirror_url":null,"open_issues_count":225,"forks":690,"open_issues":225,"watchers":747,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"563f632dfc9f50ef6e2e230c5d88c2dabe4817f1","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars2.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":1210071,"name":"dd-agent","full_name":"DataDog/dd-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars2.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-agent","description":"Datadog Agent","fork":false,"url":"https://api.github.com/repos/DataDog/dd-agent","forks_url":"https://api.github.com/repos/DataDog/dd-agent/forks","keys_url":"https://api.github.com/repos/DataDog/dd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-agent/events","assignees_url":"https://api.github.com/repos/DataDog/dd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-agent/merges","archive_url":"https://api.github.com/repos/DataDog/dd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-agent/deployments","created_at":"2010-12-31T03:02:47Z","updated_at":"2017-03-01T02:53:07Z","pushed_at":"2017-03-01T20:28:29Z","git_url":"git://github.com/DataDog/dd-agent.git","ssh_url":"git@github.com:DataDog/dd-agent.git","clone_url":"https://github.com/DataDog/dd-agent.git","svn_url":"https://github.com/DataDog/dd-agent","homepage":"https://docs.datadoghq.com/","size":40627,"stargazers_count":747,"watchers_count":747,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":690,"mirror_url":null,"open_issues_count":225,"forks":690,"open_issues":225,"watchers":747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/3231"},"html":{"href":"https://github.com/DataDog/dd-agent/pull/3231"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-agent/issues/3231"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-agent/issues/3231/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/3231/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-agent/pulls/3231/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-agent/statuses/c587b44cf0b3d2d9e7ee9ac2524382c8acc4593b"}}}}
{"actor":{"display_login":"gmmeyer"}}