{"action":"created","comment":{"url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments/144445403","pull_request_review_id":69104028,"id":144445403,"diff_hunk":"@@ -366,32 +367,29 @@ case class RefreshIndex(\n         outputPath = outPutPath.toUri.getPath,\n         isAppend = false)\n \n-      // Hack Alert: @liyuanjian when append=true, previous implement has bug,\n-      // just simple skip it now for the refresh command before fixing the refresh logic.\n-      val indexWriter = IndexWriterFactory.getIndexWriter(indexColumns.toArray,\n-        keySchema,\n-        i.name,\n-        i.time,\n-        indexType,\n-        isAppend = true)\n-\n-      indexWriter.write(sparkSession = sparkSession,\n-        queryExecution = queryExecution,\n-        fileFormat = indexFileFormat,\n+      val options = Map(","path":"src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/indexPlans.scala","position":206,"original_position":206,"commit_id":"f33c87ad0d73c0c03e1f53205e4fe5e19836f678","original_commit_id":"f33c87ad0d73c0c03e1f53205e4fe5e19836f678","user":{"login":"linhong-intel","id":23625649,"avatar_url":"https://avatars2.githubusercontent.com/u/23625649?v=4","gravatar_id":"","url":"https://api.github.com/users/linhong-intel","html_url":"https://github.com/linhong-intel","followers_url":"https://api.github.com/users/linhong-intel/followers","following_url":"https://api.github.com/users/linhong-intel/following{/other_user}","gists_url":"https://api.github.com/users/linhong-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/linhong-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linhong-intel/subscriptions","organizations_url":"https://api.github.com/users/linhong-intel/orgs","repos_url":"https://api.github.com/users/linhong-intel/repos","events_url":"https://api.github.com/users/linhong-intel/events{/privacy}","received_events_url":"https://api.github.com/users/linhong-intel/received_events","type":"User","site_admin":false},"body":"sure","created_at":"2017-10-13T00:58:20Z","updated_at":"2017-10-13T00:58:20Z","html_url":"https://github.com/Intel-bigdata/OAP/pull/340#discussion_r144445403","pull_request_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/340","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments/144445403"},"html":{"href":"https://github.com/Intel-bigdata/OAP/pull/340#discussion_r144445403"},"pull_request":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/340"}},"in_reply_to_id":144211705},"pull_request":{"url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/340","id":145837259,"html_url":"https://github.com/Intel-bigdata/OAP/pull/340","diff_url":"https://github.com/Intel-bigdata/OAP/pull/340.diff","patch_url":"https://github.com/Intel-bigdata/OAP/pull/340.patch","issue_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/340","number":340,"state":"open","locked":false,"title":"Index Writer Refactor","user":{"login":"linhong-intel","id":23625649,"avatar_url":"https://avatars2.githubusercontent.com/u/23625649?v=4","gravatar_id":"","url":"https://api.github.com/users/linhong-intel","html_url":"https://github.com/linhong-intel","followers_url":"https://api.github.com/users/linhong-intel/followers","following_url":"https://api.github.com/users/linhong-intel/following{/other_user}","gists_url":"https://api.github.com/users/linhong-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/linhong-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linhong-intel/subscriptions","organizations_url":"https://api.github.com/users/linhong-intel/orgs","repos_url":"https://api.github.com/users/linhong-intel/repos","events_url":"https://api.github.com/users/linhong-intel/events{/privacy}","received_events_url":"https://api.github.com/users/linhong-intel/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nNew Version of Index Writer\r\nRemove changes of Spark code.\r\nUtilize the whole code logical in FileFormatWriter (previously known as WriterContainer)\r\nThis mechanism can prevent multiple tasks writing same file\r\n\r\n## How was this patch tested?\r\nunit test pass\r\n","created_at":"2017-10-11T01:25:03Z","updated_at":"2017-10-13T00:58:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"104d4a9a87bcc94b633f43b6ca366d487c87b7b8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/340/commits","review_comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/340/comments","review_comment_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/340/comments","statuses_url":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/f33c87ad0d73c0c03e1f53205e4fe5e19836f678","head":{"label":"linhong-intel:btree-write","ref":"btree-write","sha":"f33c87ad0d73c0c03e1f53205e4fe5e19836f678","user":{"login":"linhong-intel","id":23625649,"avatar_url":"https://avatars2.githubusercontent.com/u/23625649?v=4","gravatar_id":"","url":"https://api.github.com/users/linhong-intel","html_url":"https://github.com/linhong-intel","followers_url":"https://api.github.com/users/linhong-intel/followers","following_url":"https://api.github.com/users/linhong-intel/following{/other_user}","gists_url":"https://api.github.com/users/linhong-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/linhong-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linhong-intel/subscriptions","organizations_url":"https://api.github.com/users/linhong-intel/orgs","repos_url":"https://api.github.com/users/linhong-intel/repos","events_url":"https://api.github.com/users/linhong-intel/events{/privacy}","received_events_url":"https://api.github.com/users/linhong-intel/received_events","type":"User","site_admin":false},"repo":{"id":93349790,"name":"OAP","full_name":"linhong-intel/OAP","owner":{"login":"linhong-intel","id":23625649,"avatar_url":"https://avatars2.githubusercontent.com/u/23625649?v=4","gravatar_id":"","url":"https://api.github.com/users/linhong-intel","html_url":"https://github.com/linhong-intel","followers_url":"https://api.github.com/users/linhong-intel/followers","following_url":"https://api.github.com/users/linhong-intel/following{/other_user}","gists_url":"https://api.github.com/users/linhong-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/linhong-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linhong-intel/subscriptions","organizations_url":"https://api.github.com/users/linhong-intel/orgs","repos_url":"https://api.github.com/users/linhong-intel/repos","events_url":"https://api.github.com/users/linhong-intel/events{/privacy}","received_events_url":"https://api.github.com/users/linhong-intel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linhong-intel/OAP","description":"Optimized Analytics Package for Spark Platform","fork":true,"url":"https://api.github.com/repos/linhong-intel/OAP","forks_url":"https://api.github.com/repos/linhong-intel/OAP/forks","keys_url":"https://api.github.com/repos/linhong-intel/OAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linhong-intel/OAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linhong-intel/OAP/teams","hooks_url":"https://api.github.com/repos/linhong-intel/OAP/hooks","issue_events_url":"https://api.github.com/repos/linhong-intel/OAP/issues/events{/number}","events_url":"https://api.github.com/repos/linhong-intel/OAP/events","assignees_url":"https://api.github.com/repos/linhong-intel/OAP/assignees{/user}","branches_url":"https://api.github.com/repos/linhong-intel/OAP/branches{/branch}","tags_url":"https://api.github.com/repos/linhong-intel/OAP/tags","blobs_url":"https://api.github.com/repos/linhong-intel/OAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linhong-intel/OAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linhong-intel/OAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/linhong-intel/OAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linhong-intel/OAP/statuses/{sha}","languages_url":"https://api.github.com/repos/linhong-intel/OAP/languages","stargazers_url":"https://api.github.com/repos/linhong-intel/OAP/stargazers","contributors_url":"https://api.github.com/repos/linhong-intel/OAP/contributors","subscribers_url":"https://api.github.com/repos/linhong-intel/OAP/subscribers","subscription_url":"https://api.github.com/repos/linhong-intel/OAP/subscription","commits_url":"https://api.github.com/repos/linhong-intel/OAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/linhong-intel/OAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/linhong-intel/OAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/linhong-intel/OAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/linhong-intel/OAP/contents/{+path}","compare_url":"https://api.github.com/repos/linhong-intel/OAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linhong-intel/OAP/merges","archive_url":"https://api.github.com/repos/linhong-intel/OAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linhong-intel/OAP/downloads","issues_url":"https://api.github.com/repos/linhong-intel/OAP/issues{/number}","pulls_url":"https://api.github.com/repos/linhong-intel/OAP/pulls{/number}","milestones_url":"https://api.github.com/repos/linhong-intel/OAP/milestones{/number}","notifications_url":"https://api.github.com/repos/linhong-intel/OAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linhong-intel/OAP/labels{/name}","releases_url":"https://api.github.com/repos/linhong-intel/OAP/releases{/id}","deployments_url":"https://api.github.com/repos/linhong-intel/OAP/deployments","created_at":"2017-06-05T00:22:18Z","updated_at":"2017-06-05T00:22:21Z","pushed_at":"2017-10-11T02:02:24Z","git_url":"git://github.com/linhong-intel/OAP.git","ssh_url":"git@github.com:linhong-intel/OAP.git","clone_url":"https://github.com/linhong-intel/OAP.git","svn_url":"https://github.com/linhong-intel/OAP","homepage":"","size":135902,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Intel-bigdata:master","ref":"master","sha":"4793671d64160ebb1c69955469a2de0d9cad9803","user":{"login":"Intel-bigdata","id":8433081,"avatar_url":"https://avatars3.githubusercontent.com/u/8433081?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-bigdata","html_url":"https://github.com/Intel-bigdata","followers_url":"https://api.github.com/users/Intel-bigdata/followers","following_url":"https://api.github.com/users/Intel-bigdata/following{/other_user}","gists_url":"https://api.github.com/users/Intel-bigdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-bigdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-bigdata/subscriptions","organizations_url":"https://api.github.com/users/Intel-bigdata/orgs","repos_url":"https://api.github.com/users/Intel-bigdata/repos","events_url":"https://api.github.com/users/Intel-bigdata/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-bigdata/received_events","type":"Organization","site_admin":false},"repo":{"id":54008218,"name":"OAP","full_name":"Intel-bigdata/OAP","owner":{"login":"Intel-bigdata","id":8433081,"avatar_url":"https://avatars3.githubusercontent.com/u/8433081?v=4","gravatar_id":"","url":"https://api.github.com/users/Intel-bigdata","html_url":"https://github.com/Intel-bigdata","followers_url":"https://api.github.com/users/Intel-bigdata/followers","following_url":"https://api.github.com/users/Intel-bigdata/following{/other_user}","gists_url":"https://api.github.com/users/Intel-bigdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-bigdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-bigdata/subscriptions","organizations_url":"https://api.github.com/users/Intel-bigdata/orgs","repos_url":"https://api.github.com/users/Intel-bigdata/repos","events_url":"https://api.github.com/users/Intel-bigdata/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-bigdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Intel-bigdata/OAP","description":"Optimized Analytics Package for Spark Platform","fork":false,"url":"https://api.github.com/repos/Intel-bigdata/OAP","forks_url":"https://api.github.com/repos/Intel-bigdata/OAP/forks","keys_url":"https://api.github.com/repos/Intel-bigdata/OAP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel-bigdata/OAP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel-bigdata/OAP/teams","hooks_url":"https://api.github.com/repos/Intel-bigdata/OAP/hooks","issue_events_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/events{/number}","events_url":"https://api.github.com/repos/Intel-bigdata/OAP/events","assignees_url":"https://api.github.com/repos/Intel-bigdata/OAP/assignees{/user}","branches_url":"https://api.github.com/repos/Intel-bigdata/OAP/branches{/branch}","tags_url":"https://api.github.com/repos/Intel-bigdata/OAP/tags","blobs_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel-bigdata/OAP/languages","stargazers_url":"https://api.github.com/repos/Intel-bigdata/OAP/stargazers","contributors_url":"https://api.github.com/repos/Intel-bigdata/OAP/contributors","subscribers_url":"https://api.github.com/repos/Intel-bigdata/OAP/subscribers","subscription_url":"https://api.github.com/repos/Intel-bigdata/OAP/subscription","commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel-bigdata/OAP/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel-bigdata/OAP/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues/comments{/number}","contents_url":"https://api.github.com/repos/Intel-bigdata/OAP/contents/{+path}","compare_url":"https://api.github.com/repos/Intel-bigdata/OAP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel-bigdata/OAP/merges","archive_url":"https://api.github.com/repos/Intel-bigdata/OAP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel-bigdata/OAP/downloads","issues_url":"https://api.github.com/repos/Intel-bigdata/OAP/issues{/number}","pulls_url":"https://api.github.com/repos/Intel-bigdata/OAP/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel-bigdata/OAP/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel-bigdata/OAP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel-bigdata/OAP/labels{/name}","releases_url":"https://api.github.com/repos/Intel-bigdata/OAP/releases{/id}","deployments_url":"https://api.github.com/repos/Intel-bigdata/OAP/deployments","created_at":"2016-03-16T06:56:47Z","updated_at":"2017-10-12T06:05:34Z","pushed_at":"2017-10-13T00:57:11Z","git_url":"git://github.com/Intel-bigdata/OAP.git","ssh_url":"git@github.com:Intel-bigdata/OAP.git","clone_url":"https://github.com/Intel-bigdata/OAP.git","svn_url":"https://github.com/Intel-bigdata/OAP","homepage":"","size":135859,"stargazers_count":58,"watchers_count":58,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":28,"forks":20,"open_issues":28,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/340"},"html":{"href":"https://github.com/Intel-bigdata/OAP/pull/340"},"issue":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/issues/340"},"comments":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/issues/340/comments"},"review_comments":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/340/comments"},"review_comment":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/pulls/340/commits"},"statuses":{"href":"https://api.github.com/repos/Intel-bigdata/OAP/statuses/f33c87ad0d73c0c03e1f53205e4fe5e19836f678"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"linhong-intel"}}