{"action":"closed","number":1107,"pull_request":{"url":"https://api.github.com/repos/qunitjs/qunit/pulls/1107","id":110247722,"html_url":"https://github.com/qunitjs/qunit/pull/1107","diff_url":"https://github.com/qunitjs/qunit/pull/1107.diff","patch_url":"https://github.com/qunitjs/qunit/pull/1107.patch","issue_url":"https://api.github.com/repos/qunitjs/qunit/issues/1107","number":1107,"state":"closed","locked":false,"title":"All: Enable some ES2015-specific ESLint rules","user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars3.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"body":"Enabling nine fairly simple ES2015 ESLint rules for the repo, none of which required any code changes.\r\n\r\n* [arrow-spacing](http://eslint.org/docs/rules/arrow-spacing): Assuming arrow operators should always have spaces around them\r\n* [constructor-super](http://eslint.org/docs/rules/constructor-super): In a derived class with a constructor, ensure `super()` is called right away\r\n* [no-const-assign](http://eslint.org/docs/rules/no-const-assign): Forbid reassigning a const variable (would throw runtime error)\r\n* [no-dupe-class-members](http://eslint.org/docs/rules/no-dupe-class-members): Class members must be unique (otherwise latter definition would override former)\r\n* [no-duplicate-imports](http://eslint.org/docs/rules/no-duplicate-imports): Multiple imports from same module are not allowed, must combine specifiers\r\n* [no-this-before-super](http://eslint.org/docs/rules/no-this-before-super): In a derived class with a constructor, ensure `super()` is called before any use of `this` or `super`\r\n* [no-useless-constructor](http://eslint.org/docs/rules/no-useless-constructor): Warn on empty constructors (for classes with no superclass) or `super()`-only constructors that just forward arguments (for classes with a superclass).\r\n* [no-useless-rename](http://eslint.org/docs/rules/no-useless-rename): Forbid silly renames during import, export, and destructuring assignment.\r\n* [rest-spread-spacing](http://eslint.org/docs/rules/rest-spread-spacing): Ensure no spaces are used between rest or spread operator and its operand.\r\n\r\nHappy to remove anything that seems not terribly important, just let me know.","created_at":"2017-03-11T05:28:16Z","updated_at":"2017-03-11T15:54:56Z","closed_at":"2017-03-11T15:54:56Z","merged_at":"2017-03-11T15:54:56Z","merge_commit_sha":"2cc7e05a15218957173c1facb490463a44ee99b0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/qunitjs/qunit/pulls/1107/commits","review_comments_url":"https://api.github.com/repos/qunitjs/qunit/pulls/1107/comments","review_comment_url":"https://api.github.com/repos/qunitjs/qunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qunitjs/qunit/issues/1107/comments","statuses_url":"https://api.github.com/repos/qunitjs/qunit/statuses/6c8643c97faad03f21b253aca64f0d6973f0bee7","head":{"label":"platinumazure:eslint-es6","ref":"eslint-es6","sha":"6c8643c97faad03f21b253aca64f0d6973f0bee7","user":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars3.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"repo":{"id":34823614,"name":"qunit","full_name":"platinumazure/qunit","owner":{"login":"platinumazure","id":284282,"avatar_url":"https://avatars3.githubusercontent.com/u/284282?v=3","gravatar_id":"","url":"https://api.github.com/users/platinumazure","html_url":"https://github.com/platinumazure","followers_url":"https://api.github.com/users/platinumazure/followers","following_url":"https://api.github.com/users/platinumazure/following{/other_user}","gists_url":"https://api.github.com/users/platinumazure/gists{/gist_id}","starred_url":"https://api.github.com/users/platinumazure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platinumazure/subscriptions","organizations_url":"https://api.github.com/users/platinumazure/orgs","repos_url":"https://api.github.com/users/platinumazure/repos","events_url":"https://api.github.com/users/platinumazure/events{/privacy}","received_events_url":"https://api.github.com/users/platinumazure/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/platinumazure/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":true,"url":"https://api.github.com/repos/platinumazure/qunit","forks_url":"https://api.github.com/repos/platinumazure/qunit/forks","keys_url":"https://api.github.com/repos/platinumazure/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/platinumazure/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/platinumazure/qunit/teams","hooks_url":"https://api.github.com/repos/platinumazure/qunit/hooks","issue_events_url":"https://api.github.com/repos/platinumazure/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/platinumazure/qunit/events","assignees_url":"https://api.github.com/repos/platinumazure/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/platinumazure/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/platinumazure/qunit/tags","blobs_url":"https://api.github.com/repos/platinumazure/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/platinumazure/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/platinumazure/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/platinumazure/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/platinumazure/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/platinumazure/qunit/languages","stargazers_url":"https://api.github.com/repos/platinumazure/qunit/stargazers","contributors_url":"https://api.github.com/repos/platinumazure/qunit/contributors","subscribers_url":"https://api.github.com/repos/platinumazure/qunit/subscribers","subscription_url":"https://api.github.com/repos/platinumazure/qunit/subscription","commits_url":"https://api.github.com/repos/platinumazure/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/platinumazure/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/platinumazure/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/platinumazure/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/platinumazure/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/platinumazure/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/platinumazure/qunit/merges","archive_url":"https://api.github.com/repos/platinumazure/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/platinumazure/qunit/downloads","issues_url":"https://api.github.com/repos/platinumazure/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/platinumazure/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/platinumazure/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/platinumazure/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/platinumazure/qunit/labels{/name}","releases_url":"https://api.github.com/repos/platinumazure/qunit/releases{/id}","deployments_url":"https://api.github.com/repos/platinumazure/qunit/deployments","created_at":"2015-04-29T23:27:04Z","updated_at":"2016-03-28T02:08:24Z","pushed_at":"2017-03-11T05:47:00Z","git_url":"git://github.com/platinumazure/qunit.git","ssh_url":"git@github.com:platinumazure/qunit.git","clone_url":"https://github.com/platinumazure/qunit.git","svn_url":"https://github.com/platinumazure/qunit","homepage":"http://qunitjs.com","size":1727,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qunitjs:master","ref":"master","sha":"c45038f38554c9b88f0c9374a24417247bfa9040","user":{"login":"qunitjs","id":23195278,"avatar_url":"https://avatars0.githubusercontent.com/u/23195278?v=3","gravatar_id":"","url":"https://api.github.com/users/qunitjs","html_url":"https://github.com/qunitjs","followers_url":"https://api.github.com/users/qunitjs/followers","following_url":"https://api.github.com/users/qunitjs/following{/other_user}","gists_url":"https://api.github.com/users/qunitjs/gists{/gist_id}","starred_url":"https://api.github.com/users/qunitjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qunitjs/subscriptions","organizations_url":"https://api.github.com/users/qunitjs/orgs","repos_url":"https://api.github.com/users/qunitjs/repos","events_url":"https://api.github.com/users/qunitjs/events{/privacy}","received_events_url":"https://api.github.com/users/qunitjs/received_events","type":"Organization","site_admin":false},"repo":{"id":259691,"name":"qunit","full_name":"qunitjs/qunit","owner":{"login":"qunitjs","id":23195278,"avatar_url":"https://avatars0.githubusercontent.com/u/23195278?v=3","gravatar_id":"","url":"https://api.github.com/users/qunitjs","html_url":"https://github.com/qunitjs","followers_url":"https://api.github.com/users/qunitjs/followers","following_url":"https://api.github.com/users/qunitjs/following{/other_user}","gists_url":"https://api.github.com/users/qunitjs/gists{/gist_id}","starred_url":"https://api.github.com/users/qunitjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qunitjs/subscriptions","organizations_url":"https://api.github.com/users/qunitjs/orgs","repos_url":"https://api.github.com/users/qunitjs/repos","events_url":"https://api.github.com/users/qunitjs/events{/privacy}","received_events_url":"https://api.github.com/users/qunitjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qunitjs/qunit","description":"An easy-to-use JavaScript Unit Testing framework.","fork":false,"url":"https://api.github.com/repos/qunitjs/qunit","forks_url":"https://api.github.com/repos/qunitjs/qunit/forks","keys_url":"https://api.github.com/repos/qunitjs/qunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qunitjs/qunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qunitjs/qunit/teams","hooks_url":"https://api.github.com/repos/qunitjs/qunit/hooks","issue_events_url":"https://api.github.com/repos/qunitjs/qunit/issues/events{/number}","events_url":"https://api.github.com/repos/qunitjs/qunit/events","assignees_url":"https://api.github.com/repos/qunitjs/qunit/assignees{/user}","branches_url":"https://api.github.com/repos/qunitjs/qunit/branches{/branch}","tags_url":"https://api.github.com/repos/qunitjs/qunit/tags","blobs_url":"https://api.github.com/repos/qunitjs/qunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qunitjs/qunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qunitjs/qunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/qunitjs/qunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qunitjs/qunit/statuses/{sha}","languages_url":"https://api.github.com/repos/qunitjs/qunit/languages","stargazers_url":"https://api.github.com/repos/qunitjs/qunit/stargazers","contributors_url":"https://api.github.com/repos/qunitjs/qunit/contributors","subscribers_url":"https://api.github.com/repos/qunitjs/qunit/subscribers","subscription_url":"https://api.github.com/repos/qunitjs/qunit/subscription","commits_url":"https://api.github.com/repos/qunitjs/qunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/qunitjs/qunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/qunitjs/qunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/qunitjs/qunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/qunitjs/qunit/contents/{+path}","compare_url":"https://api.github.com/repos/qunitjs/qunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qunitjs/qunit/merges","archive_url":"https://api.github.com/repos/qunitjs/qunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qunitjs/qunit/downloads","issues_url":"https://api.github.com/repos/qunitjs/qunit/issues{/number}","pulls_url":"https://api.github.com/repos/qunitjs/qunit/pulls{/number}","milestones_url":"https://api.github.com/repos/qunitjs/qunit/milestones{/number}","notifications_url":"https://api.github.com/repos/qunitjs/qunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qunitjs/qunit/labels{/name}","releases_url":"https://api.github.com/repos/qunitjs/qunit/releases{/id}","deployments_url":"https://api.github.com/repos/qunitjs/qunit/deployments","created_at":"2009-07-24T16:26:23Z","updated_at":"2017-03-11T15:24:16Z","pushed_at":"2017-03-11T15:54:56Z","git_url":"git://github.com/qunitjs/qunit.git","ssh_url":"git@github.com:qunitjs/qunit.git","clone_url":"https://github.com/qunitjs/qunit.git","svn_url":"https://github.com/qunitjs/qunit","homepage":"http://qunitjs.com","size":1876,"stargazers_count":3598,"watchers_count":3598,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":734,"mirror_url":null,"open_issues_count":40,"forks":734,"open_issues":40,"watchers":3598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qunitjs/qunit/pulls/1107"},"html":{"href":"https://github.com/qunitjs/qunit/pull/1107"},"issue":{"href":"https://api.github.com/repos/qunitjs/qunit/issues/1107"},"comments":{"href":"https://api.github.com/repos/qunitjs/qunit/issues/1107/comments"},"review_comments":{"href":"https://api.github.com/repos/qunitjs/qunit/pulls/1107/comments"},"review_comment":{"href":"https://api.github.com/repos/qunitjs/qunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qunitjs/qunit/pulls/1107/commits"},"statuses":{"href":"https://api.github.com/repos/qunitjs/qunit/statuses/6c8643c97faad03f21b253aca64f0d6973f0bee7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"trentmwillis","id":3526753,"avatar_url":"https://avatars1.githubusercontent.com/u/3526753?v=3","gravatar_id":"","url":"https://api.github.com/users/trentmwillis","html_url":"https://github.com/trentmwillis","followers_url":"https://api.github.com/users/trentmwillis/followers","following_url":"https://api.github.com/users/trentmwillis/following{/other_user}","gists_url":"https://api.github.com/users/trentmwillis/gists{/gist_id}","starred_url":"https://api.github.com/users/trentmwillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trentmwillis/subscriptions","organizations_url":"https://api.github.com/users/trentmwillis/orgs","repos_url":"https://api.github.com/users/trentmwillis/repos","events_url":"https://api.github.com/users/trentmwillis/events{/privacy}","received_events_url":"https://api.github.com/users/trentmwillis/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"trentmwillis"}}