{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/233","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/233/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/233/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/233","id":202984722,"number":233,"title":"[WIP] [POC] Refactor controllers to use generic button methods","user":{"login":"hayesr","id":39493,"avatar_url":"https://avatars0.githubusercontent.com/u/39493?v=3","gravatar_id":"","url":"https://api.github.com/users/hayesr","html_url":"https://github.com/hayesr","followers_url":"https://api.github.com/users/hayesr/followers","following_url":"https://api.github.com/users/hayesr/following{/other_user}","gists_url":"https://api.github.com/users/hayesr/gists{/gist_id}","starred_url":"https://api.github.com/users/hayesr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayesr/subscriptions","organizations_url":"https://api.github.com/users/hayesr/orgs","repos_url":"https://api.github.com/users/hayesr/repos","events_url":"https://api.github.com/users/hayesr/events{/privacy}","received_events_url":"https://api.github.com/users/hayesr/received_events","type":"User","site_admin":false},"labels":[{"id":505531653,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-01-25T00:55:50Z","updated_at":"2017-03-07T19:43:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/233","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/233","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/233.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/233.patch"},"body":"This is a proof of concept to demonstrate refactoring controller button methods by [extracting small, composable methods](https://refactoring.com/catalog/extractMethod.html), rather than combine everything into one big method to rule them all.\r\n\r\n**Benefits:**\r\n- When debugging a problem or adding a new button to a screen it is preferable to see exactly what is happening in the related controller.\r\n- Find exactly what is generic and what is specific\r\n- Eases future refactorings because behavior is in small chunks\r\n\r\n**Why do it all at once?** Because I want to find the real common abstractions between all controllers rather than guess up front and squeeze everything into a pattern after. Also, the plan is to break this PR up with one for the generic mixin and separate ones for each controller. If I have one branch with all the changes, I can better test changes to the mixin if they are necessary later.\r\n\r\n**Progress**\r\n\r\n- [x] First pass of controllers with button methods\r\n- [ ] Extract button handlers\r\n  - [x] auth_key_pair_cloud_controller\r\n  - [x] availability_zone_controller\r\n  - [x] cloud_network_controller\r\n  - [x] cloud_object_store_container_controller\r\n  - [x] cloud_object_store_object_controller\r\n  - [x] cloud_subnet_controller\r\n  - [x] cloud_tenant_controller\r\n  - [x] cloud_volume_controller\r\n  - [x] configuration_controller\r\n  - [x] configuration_job_controller\r\n  - [x] floating_ip_controller\r\n  - [x] host_aggregate_controller\r\n  - [x] host_controller\r\n  - [x] infra_networking_controller\r\n  - [x] miq_ae_tools_controller\r\n  - [x] miq_policy_controller\r\n  - [x] miq_request_controller\r\n  - [x] network_router_controller\r\n  - [x] orchestration_stack_controller\r\n  - [x] resource_pool_controller\r\n  - [x] security_group_controller\r\n  - [x] storage_controller\r\n  - [x] storage_manager_controller\r\n  - [ ] vm_common\r\n  - [ ] ems_common\r\n  - [ ] containers_common_mixin\r\n  - [ ] ems_cluster_controller\r\n\r\n\r\n**Bonus:** I've implemented several pending specs so far."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/284836488","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/233#issuecomment-284836488","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/233","id":284836488,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars2.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2017-03-07T19:43:17Z","updated_at":"2017-03-07T19:43:17Z","body":"<rubocop />Checked commits https://github.com/hayesr/manageiq-ui-classic/compare/663219cf548632c8b4e8c885200970dd6e7d5ba4~...c513f5a7028cf9588848ead50bb38d0fb8590b3d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0\n58 files checked, 143 offenses detected\n\n**app/controllers/auth_key_pair_cloud_controller.rb**\n- [ ] :warning: - [Line 232](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/auth_key_pair_cloud_controller.rb#L232), Col 3 - [Lint/UselessAccessModifier](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Lint/UselessAccessModifier) - Useless `private` access modifier.\n- [ ] :grey_exclamation: - [Line 238](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/auth_key_pair_cloud_controller.rb#L238), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [127/120]\n\n**app/controllers/availability_zone_controller.rb**\n- [ ] :exclamation: - [Line 100](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/availability_zone_controller.rb#L100), Col 7 - [Style/IfInsideElse](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/IfInsideElse) - Convert `if` nested inside `else` to `elsif`.\n\n**app/controllers/cloud_network_controller.rb**\n- [ ] :grey_exclamation: - [Line 114](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_network_controller.rb#L114), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_cloud_network_delete is too high. [35.82/20]\n- [ ] :grey_exclamation: - [Line 114](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_network_controller.rb#L114), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_cloud_network_delete is too high. [14/6]\n- [ ] :grey_exclamation: - [Line 114](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_network_controller.rb#L114), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [36/25]\n- [ ] :grey_exclamation: - [Line 114](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_network_controller.rb#L114), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_cloud_network_delete is too high. [18/7]\n\n**app/controllers/cloud_subnet_controller.rb**\n- [ ] :grey_exclamation: - [Line 123](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_subnet_controller.rb#L123), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_cloud_subnet_delete is too high. [39.09/20]\n- [ ] :grey_exclamation: - [Line 123](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_subnet_controller.rb#L123), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_cloud_subnet_delete is too high. [15/6]\n- [ ] :grey_exclamation: - [Line 123](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_subnet_controller.rb#L123), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [35/25]\n- [ ] :grey_exclamation: - [Line 123](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_subnet_controller.rb#L123), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_cloud_subnet_delete is too high. [18/7]\n\n**app/controllers/cloud_tenant_controller.rb**\n- [ ] :grey_exclamation: - [Line 169](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_tenant_controller.rb#L169), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_cloud_tenant_delete is too high. [36.91/20]\n- [ ] :grey_exclamation: - [Line 169](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_tenant_controller.rb#L169), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_cloud_tenant_delete is too high. [12/6]\n- [ ] :grey_exclamation: - [Line 169](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_tenant_controller.rb#L169), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [33/25]\n- [ ] :grey_exclamation: - [Line 169](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_tenant_controller.rb#L169), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_cloud_tenant_delete is too high. [16/7]\n\n**app/controllers/cloud_volume_controller.rb**\n- [ ] :exclamation: - [Line 654](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_volume_controller.rb#L654), Col 15 - [Rails/DynamicFindBy](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/DynamicFindBy) - Use `find_by` instead of dynamic `find_by_id_filtered`.\n- [ ] :exclamation: - [Line 657](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_volume_controller.rb#L657), Col 20 - [Style/IndentHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/IndentHash) - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.\n- [ ] :exclamation: - [Line 659](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_volume_controller.rb#L659), Col 68 - [Style/MultilineHashBraceLayout](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/MultilineHashBraceLayout) - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.\n- [ ] :grey_exclamation: - [Line 339](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_volume_controller.rb#L339), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_cloud_volume_delete is too high. [68.62/20]\n- [ ] :grey_exclamation: - [Line 339](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_volume_controller.rb#L339), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_cloud_volume_delete is too high. [18/6]\n- [ ] :grey_exclamation: - [Line 339](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_volume_controller.rb#L339), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [56/25]\n- [ ] :grey_exclamation: - [Line 339](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/cloud_volume_controller.rb#L339), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_cloud_volume_delete is too high. [22/7]\n\n**app/controllers/configuration_controller.rb**\n- [ ] :grey_exclamation: - [Line 281](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/configuration_controller.rb#L281), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_tp_delete is too high. [50.58/20]\n- [ ] :grey_exclamation: - [Line 281](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/configuration_controller.rb#L281), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_tp_delete is too high. [8/6]\n- [ ] :grey_exclamation: - [Line 281](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/configuration_controller.rb#L281), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [29/25]\n- [ ] :grey_exclamation: - [Line 281](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/configuration_controller.rb#L281), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_tp_delete is too high. [10/7]\n\n**app/controllers/ems_cluster_controller.rb**\n- [ ] :exclamation: - [Line 122](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/ems_cluster_controller.rb#L122), Col 7 - [Style/IfInsideElse](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/IfInsideElse) - Convert `if` nested inside `else` to `elsif`.\n- [ ] :exclamation: - [Line 204](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/ems_cluster_controller.rb#L204), Col 5 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for an array of words.\n- [ ] :exclamation: - [Line 209](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/ems_cluster_controller.rb#L209), Col 5 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for an array of words.\n\n**app/controllers/ems_common.rb**\n- [ ] :exclamation: - [Line 1055](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/ems_common.rb#L1055), Col 5 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for an array of words.\n- [ ] :exclamation: - [Line 1059](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/ems_common.rb#L1059), Col 5 - [Style/WordArray](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/WordArray) - Use `%w` or `%W` for an array of words.\n- [ ] :exclamation: - [Line 469](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/ems_common.rb#L469), Col 7 - [Style/IfInsideElse](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/IfInsideElse) - Convert `if` nested inside `else` to `elsif`.\n- [ ] :grey_exclamation: - [Line 431](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/ems_common.rb#L431), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [121/120]\n\n**app/controllers/floating_ip_controller.rb**\n- [ ] :grey_exclamation: - [Line 83](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/floating_ip_controller.rb#L83), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_floating_ip_delete is too high. [31.42/20]\n- [ ] :grey_exclamation: - [Line 83](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/floating_ip_controller.rb#L83), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_floating_ip_delete is too high. [12/6]\n- [ ] :grey_exclamation: - [Line 83](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/floating_ip_controller.rb#L83), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [30/25]\n- [ ] :grey_exclamation: - [Line 83](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/floating_ip_controller.rb#L83), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_floating_ip_delete is too high. [16/7]\n\n**app/controllers/host_controller.rb**\n- [ ] :warning: - [Line 612](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/host_controller.rb#L612), Col 5 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `ctrlr_buttons`. Use just operator `+`.\n- [ ] :exclamation: - [Line 441](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/host_controller.rb#L441), Col 7 - [Style/IfInsideElse](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/IfInsideElse) - Convert `if` nested inside `else` to `elsif`.\n\n**app/controllers/miq_request_controller.rb**\n- [ ] :exclamation: - [Line 545](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L545), Col 25 - [Rails/DynamicFindBy](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/DynamicFindBy) - Use `find_by` instead of dynamic `find_by_id`.\n- [ ] :exclamation: - [Line 553](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L553), Col 25 - [Rails/DynamicFindBy](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/DynamicFindBy) - Use `find_by` instead of dynamic `find_by_id`.\n- [ ] :exclamation: - [Line 575](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L575), Col 7 - [Style/MultilineIfModifier](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/MultilineIfModifier) - Favor a normal unless-statement over a modifier clause in a multiline statement.\n- [ ] :exclamation: - [Line 578](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L578), Col 30 - [Rails/DynamicFindBy](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/DynamicFindBy) - Use `find_by` instead of dynamic `find_by_id`.\n- [ ] :exclamation: - [Line 585](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L585), Col 7 - [Style/MultilineIfModifier](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/MultilineIfModifier) - Favor a normal unless-statement over a modifier clause in a multiline statement.\n- [ ] :exclamation: - [Line 591](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L591), Col 5 - [Style/NegatedIf](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/NegatedIf) - Favor `unless` over `if` for negative conditions.\n- [ ] :exclamation: - [Line 610](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L610), Col 59 - [Style/ExtraSpacing](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/ExtraSpacing) - Unnecessary spacing detected.\n- [ ] :grey_exclamation: - [Line 566](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L566), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_miq_request_delete is too high. [43.14/20]\n- [ ] :grey_exclamation: - [Line 566](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L566), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_miq_request_delete is too high. [10/6]\n- [ ] :grey_exclamation: - [Line 566](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L566), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [26/25]\n- [ ] :grey_exclamation: - [Line 566](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L566), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_miq_request_delete is too high. [12/7]\n- [ ] :grey_exclamation: - [Line 592](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L592), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [127/120]\n- [ ] :grey_exclamation: - [Line 596](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/miq_request_controller.rb#L596), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_miq_request_reload is too high. [20.2/20]\n\n**app/controllers/mixins/generic_button_mixin.rb**\n- [ ] :warning: - [Line 131](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L131), Col 41 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `block`. If it's necessary, use `_` or `_block` as an argument name to indicate that it won't be used.\n- [ ] :warning: - [Line 140](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L140), Col 43 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `block`. If it's necessary, use `_` or `_block` as an argument name to indicate that it won't be used.\n- [ ] :warning: - [Line 148](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L148), Col 38 - [Lint/UnusedMethodArgument](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Lint/UnusedMethodArgument) - Unused method argument - `block`. If it's necessary, use `_` or `_block` as an argument name to indicate that it won't be used.\n- [ ] :warning: - [Line 546](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L546), Col 46 - [Lint/ShadowingOuterLocalVariable](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Lint/ShadowingOuterLocalVariable) - Shadowing outer local variable - `page`.\n- [ ] :exclamation: - [Line 133](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L133), Col 9 - [Style/RedundantSelf](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/RedundantSelf) - Redundant `self` detected.\n- [ ] :exclamation: - [Line 34](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L34), Col 1 - [Style/EmptyLines](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLines) - Extra blank line detected.\n- [ ] :exclamation: - [Line 584](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L584), Col 9 - [Style/IfInsideElse](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/IfInsideElse) - Convert `if` nested inside `else` to `elsif`.\n- [ ] :exclamation: - [Line 67](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L67), Col 1 - [Style/EmptyLinesAroundModuleBody](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLinesAroundModuleBody) - Extra empty line detected at module body beginning.\n- [ ] :exclamation: - [Line 696](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L696), Col 9 - [Style/IfInsideElse](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/IfInsideElse) - Convert `if` nested inside `else` to `elsif`.\n- [ ] :exclamation: - [Line 737](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L737), Col 63 - [Style/SpaceAfterComma](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/SpaceAfterComma) - Space missing after comma.\n- [ ] :exclamation: - [Line 741](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L741), Col 20 - [Rails/DynamicFindBy](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/DynamicFindBy) - Use `find_by` instead of dynamic `find_by_id_filtered`.\n- [ ] :exclamation: - [Line 745](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L745), Col 17 - [Style/IndentHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/IndentHash) - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.\n- [ ] :exclamation: - [Line 747](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L747), Col 65 - [Style/MultilineHashBraceLayout](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/MultilineHashBraceLayout) - Closing hash brace must be on the line after the last hash element when opening brace is on a separate line from the first hash element.\n- [ ] :grey_exclamation: - [Line 162](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L162), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for tag_for_pressed is too high. [31.24/20]\n- [ ] :grey_exclamation: - [Line 162](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L162), Col 5 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for tag_for_pressed is too high. [21/6]\n- [ ] :grey_exclamation: - [Line 514](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L514), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [129/120]\n- [ ] :grey_exclamation: - [Line 531](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L531), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [131/120]\n- [ ] :grey_exclamation: - [Line 549](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L549), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [129/120]\n- [ ] :grey_exclamation: - [Line 664](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L664), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [129/120]\n- [ ] :grey_exclamation: - [Line 667](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L667), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [151/120]\n- [ ] :grey_exclamation: - [Line 731](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L731), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for cloud_tenant_javascript_redirect is too high. [31.51/20]\n- [ ] :grey_exclamation: - [Line 752](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L752), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [125/120]\n- [ ] :grey_exclamation: - [Line 783](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L783), Col 5 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for process_vm_buttons is too high. [50.93/20]\n- [ ] :grey_exclamation: - [Line 783](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L783), Col 5 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for process_vm_buttons is too high. [36/6]\n- [ ] :grey_exclamation: - [Line 783](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L783), Col 5 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [37/25]\n- [ ] :grey_exclamation: - [Line 783](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/mixins/generic_button_mixin.rb#L783), Col 5 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for process_vm_buttons is too high. [9/7]\n\n**app/controllers/network_router_controller.rb**\n- [ ] :grey_exclamation: - [Line 113](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/network_router_controller.rb#L113), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_network_router_delete is too high. [43.74/20]\n- [ ] :grey_exclamation: - [Line 113](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/network_router_controller.rb#L113), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_network_router_delete is too high. [15/6]\n- [ ] :grey_exclamation: - [Line 113](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/network_router_controller.rb#L113), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [36/25]\n- [ ] :grey_exclamation: - [Line 113](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/network_router_controller.rb#L113), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_network_router_delete is too high. [18/7]\n\n**app/controllers/orchestration_stack_controller.rb**\n- [ ] :grey_exclamation: - [Line 144](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/orchestration_stack_controller.rb#L144), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_make_ot_orderable is too high. [31.32/20]\n\n**app/controllers/security_group_controller.rb**\n- [ ] :grey_exclamation: - [Line 101](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/security_group_controller.rb#L101), Col 3 - [Metrics/AbcSize](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/AbcSize) - Assignment Branch Condition size for handle_security_group_delete is too high. [37.34/20]\n- [ ] :grey_exclamation: - [Line 101](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/security_group_controller.rb#L101), Col 3 - [Metrics/CyclomaticComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/CyclomaticComplexity) - Cyclomatic complexity for handle_security_group_delete is too high. [13/6]\n- [ ] :grey_exclamation: - [Line 101](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/security_group_controller.rb#L101), Col 3 - [Metrics/MethodLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/MethodLength) - Method has too many lines. [35/25]\n- [ ] :grey_exclamation: - [Line 101](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/app/controllers/security_group_controller.rb#L101), Col 3 - [Metrics/PerceivedComplexity](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/PerceivedComplexity) - Perceived complexity for handle_security_group_delete is too high. [17/7]\n\n**spec/controllers/cloud_network_controller_spec.rb**\n- [ ] :exclamation: - [Line 164](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_network_controller_spec.rb#L164), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [29/25]\n- [ ] :exclamation: - [Line 32](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_network_controller_spec.rb#L32), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [38/25]\n\n**spec/controllers/cloud_object_store_container_controller_spec.rb**\n- [ ] :exclamation: - [Line 14](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_container_controller_spec.rb#L14), Col 7 - [Rails/HttpPositionalArguments](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/HttpPositionalArguments) - Use keyword arguments instead of positional arguments for http call: `post`.\n- [ ] :exclamation: - [Line 19](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_container_controller_spec.rb#L19), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [36/25]\n- [ ] :exclamation: - [Line 1](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_container_controller_spec.rb#L1), Col 1 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [103/25]\n- [ ] :exclamation: - [Line 49](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_container_controller_spec.rb#L49), Col 7 - [Rails/HttpPositionalArguments](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/HttpPositionalArguments) - Use keyword arguments instead of positional arguments for http call: `post`.\n- [ ] :exclamation: - [Line 56](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_container_controller_spec.rb#L56), Col 7 - [Rails/HttpPositionalArguments](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/HttpPositionalArguments) - Use keyword arguments instead of positional arguments for http call: `post`.\n- [ ] :exclamation: - [Line 62](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_container_controller_spec.rb#L62), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [49/25]\n\n**spec/controllers/cloud_object_store_object_controller_spec.rb**\n- [ ] :exclamation: - [Line 12](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_object_controller_spec.rb#L12), Col 7 - [Rails/HttpPositionalArguments](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/HttpPositionalArguments) - Use keyword arguments instead of positional arguments for http call: `post`.\n- [ ] :exclamation: - [Line 17](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_object_controller_spec.rb#L17), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [38/25]\n- [ ] :exclamation: - [Line 1](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_object_controller_spec.rb#L1), Col 1 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [53/25]\n- [ ] :exclamation: - [Line 48](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_object_controller_spec.rb#L48), Col 7 - [Rails/HttpPositionalArguments](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/HttpPositionalArguments) - Use keyword arguments instead of positional arguments for http call: `post`.\n- [ ] :exclamation: - [Line 55](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_object_store_object_controller_spec.rb#L55), Col 7 - [Rails/HttpPositionalArguments](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Rails/HttpPositionalArguments) - Use keyword arguments instead of positional arguments for http call: `post`.\n\n**spec/controllers/cloud_subnet_controller_spec.rb**\n- [ ] :exclamation: - [Line 165](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_subnet_controller_spec.rb#L165), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [28/25]\n- [ ] :exclamation: - [Line 33](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_subnet_controller_spec.rb#L33), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [36/25]\n\n**spec/controllers/cloud_tenant_controller_spec.rb**\n- [ ] :exclamation: - [Line 43](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_tenant_controller_spec.rb#L43), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [36/25]\n\n**spec/controllers/cloud_volume_controller_spec.rb**\n- [ ] :exclamation: - [Line 40](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_volume_controller_spec.rb#L40), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [37/25]\n- [ ] :grey_exclamation: - [Line 146](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/cloud_volume_controller_spec.rb#L146), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [129/120]\n\n**spec/controllers/configuration_controller_spec.rb**\n- [ ] :exclamation: - [Line 39](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/configuration_controller_spec.rb#L39), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [31/25]\n- [ ] :exclamation: - [Line 49](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/configuration_controller_spec.rb#L49), Col 9 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :exclamation: - [Line 50](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/configuration_controller_spec.rb#L50), Col 9 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :exclamation: - [Line 59](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/configuration_controller_spec.rb#L59), Col 9 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :exclamation: - [Line 60](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/configuration_controller_spec.rb#L60), Col 9 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :exclamation: - [Line 69](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/configuration_controller_spec.rb#L69), Col 9 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :exclamation: - [Line 70](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/configuration_controller_spec.rb#L70), Col 9 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n\n**spec/controllers/configuration_job_controller_spec.rb**\n- [ ] :exclamation: - [Line 52](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/configuration_job_controller_spec.rb#L52), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [37/25]\n\n**spec/controllers/ems_cluster_controller_spec.rb**\n- [ ] :exclamation: - [Line 51](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/ems_cluster_controller_spec.rb#L51), Col 47 - [Style/SpaceBeforeBlockBraces](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/SpaceBeforeBlockBraces) - Space missing to the left of {.\n- [ ] :exclamation: - [Line 9](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/ems_cluster_controller_spec.rb#L9), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [41/25]\n\n**spec/controllers/floating_ip_controller_spec.rb**\n- [ ] :warning: - [Line 81](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/floating_ip_controller_spec.rb#L81), Col 7 - [Lint/UselessAssignment](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Lint/UselessAssignment) - Useless assignment to variable - `flip`.\n- [ ] :exclamation: - [Line 32](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/floating_ip_controller_spec.rb#L32), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [37/25]\n\n**spec/controllers/host_controller_spec.rb**\n- [ ] :exclamation: - [Line 138](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L138), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [32/25]\n- [ ] :exclamation: - [Line 142](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L142), Col 1 - [Style/EmptyLines](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLines) - Extra blank line detected.\n- [ ] :exclamation: - [Line 161](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L161), Col 1 - [Style/EmptyLines](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLines) - Extra blank line detected.\n- [ ] :exclamation: - [Line 179](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L179), Col 1 - [Style/EmptyLines](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLines) - Extra blank line detected.\n- [ ] :exclamation: - [Line 181](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L181), Col 1 - [Style/EmptyLinesAroundBlockBody](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLinesAroundBlockBody) - Extra empty line detected at block body beginning.\n- [ ] :exclamation: - [Line 195](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L195), Col 1 - [Style/EmptyLines](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLines) - Extra blank line detected.\n- [ ] :exclamation: - [Line 197](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L197), Col 1 - [Style/EmptyLinesAroundBlockBody](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLinesAroundBlockBody) - Extra empty line detected at block body beginning.\n- [ ] :exclamation: - [Line 253](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L253), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [60/25]\n- [ ] :exclamation: - [Line 324](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L324), Col 1 - [Style/EmptyLinesAroundBlockBody](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/EmptyLinesAroundBlockBody) - Extra empty line detected at block body beginning.\n- [ ] :exclamation: - [Line 7](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/host_controller_spec.rb#L7), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [101/25]\n\n**spec/controllers/infra_network_controller_spec.rb**\n- [ ] :exclamation: - [Line 21](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/infra_network_controller_spec.rb#L21), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [29/25]\n- [ ] :exclamation: - [Line 70](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/infra_network_controller_spec.rb#L70), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [32/25]\n- [ ] :grey_exclamation: - [Line 54](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/infra_network_controller_spec.rb#L54), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [131/120]\n\n**spec/controllers/network_router_controller_spec.rb**\n- [ ] :exclamation: - [Line 62](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/network_router_controller_spec.rb#L62), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [37/25]\n- [ ] :grey_exclamation: - [Line 243](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/network_router_controller_spec.rb#L243), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [121/120]\n\n**spec/controllers/resource_pool_controller_spec.rb**\n- [ ] :exclamation: - [Line 2](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/resource_pool_controller_spec.rb#L2), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [55/25]\n\n**spec/controllers/security_group_controller_spec.rb**\n- [ ] :exclamation: - [Line 32](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/security_group_controller_spec.rb#L32), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [37/25]\n\n**spec/controllers/storage_controller_spec.rb**\n- [ ] :exclamation: - [Line 17](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/storage_controller_spec.rb#L17), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [41/25]\n\n**spec/controllers/storage_manager_controller_spec.rb**\n- [ ] :exclamation: - [Line 65](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/storage_manager_controller_spec.rb#L65), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [26/25]\n- [ ] :exclamation: - [Line 9](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/storage_manager_controller_spec.rb#L9), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [26/25]\n\n**spec/controllers/vm_common_spec.rb**\n- [ ] :exclamation: - [Line 114](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/vm_common_spec.rb#L114), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [89/25]\n- [ ] :exclamation: - [Line 257](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/vm_common_spec.rb#L257), Col 46 - [Style/BracesAroundHashParameters](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/BracesAroundHashParameters) - Redundant curly braces around a hash parameter.\n- [ ] :exclamation: - [Line 38](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/vm_common_spec.rb#L38), Col 3 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [40/25]\n- [ ] :exclamation: - [Line 47](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/vm_common_spec.rb#L47), Col 9 - [Style/AlignHash](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Style/AlignHash) - Align the elements of a hash literal if they span more than one line.\n- [ ] :grey_exclamation: - [Line 42](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/controllers/vm_common_spec.rb#L42), Col 121 - [Metrics/LineLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/LineLength) - Line is too long. [124/120]\n\n**spec/shared/controllers/vm_button_handlers.rb**\n- [ ] :exclamation: - [Line 1](https://github.com/hayesr/manageiq-ui-classic/blob/c513f5a7028cf9588848ead50bb38d0fb8590b3d/spec/shared/controllers/vm_button_handlers.rb#L1), Col 1 - [Metrics/BlockLength](http://rubydoc.info/gems/rubocop/0.47.1/RuboCop/Cop/Metrics/BlockLength) - Block has too many lines. [49/25]\n"}}
{"actor":{"display_login":"miq-bot"}}