{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls/18","id":158929995,"html_url":"https://github.com/DANS-KNAW/easy-solr4files-index/pull/18","diff_url":"https://github.com/DANS-KNAW/easy-solr4files-index/pull/18.diff","patch_url":"https://github.com/DANS-KNAW/easy-solr4files-index/pull/18.patch","issue_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/issues/18","number":18,"state":"closed","locked":false,"title":"HOT FIX: only active users, fixed resource leak (refactoring as in download)","user":{"login":"jo-pol","id":10553630,"avatar_url":"https://avatars3.githubusercontent.com/u/10553630?v=4","gravatar_id":"","url":"https://api.github.com/users/jo-pol","html_url":"https://github.com/jo-pol","followers_url":"https://api.github.com/users/jo-pol/followers","following_url":"https://api.github.com/users/jo-pol/following{/other_user}","gists_url":"https://api.github.com/users/jo-pol/gists{/gist_id}","starred_url":"https://api.github.com/users/jo-pol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jo-pol/subscriptions","organizations_url":"https://api.github.com/users/jo-pol/orgs","repos_url":"https://api.github.com/users/jo-pol/repos","events_url":"https://api.github.com/users/jo-pol/events{/privacy}","received_events_url":"https://api.github.com/users/jo-pol/received_events","type":"User","site_admin":false},"body":"Fixes EASY-\r\n\r\n#### When applied it will\r\n* Fixes an LDAP resource leak\r\n* Return 400-not-authenticated if a user has another dansState than ACTIVE\r\n* \r\n\r\n#### Where should the reviewer @DANS-KNAW/easy start?\r\n\r\n#### How should this be manually tested?\r\n\r\n* See previous PR's\r\n* Try a user with `dansState==BLOCKED` (update default user with apache directory studio)\r\n\r\n#### Related pull requests on github\r\nrepo                       | PR                | note\r\n-------------------------- | ----------------- | ----\r\neasy-                      | [PR#](PRlink)     | ..\r\n","created_at":"2017-12-18T14:40:26Z","updated_at":"2017-12-20T10:14:38Z","closed_at":"2017-12-20T10:14:38Z","merged_at":"2017-12-20T10:14:38Z","merge_commit_sha":"57e56e5aa7c2e03ab0e9e93e39c58c42df48d9ac","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls/18/commits","review_comments_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls/18/comments","review_comment_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/issues/18/comments","statuses_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/statuses/2f003eccc328c79d954b1147b5275f11a6928012","head":{"label":"DANS-KNAW-jp:ldap","ref":"ldap","sha":"2f003eccc328c79d954b1147b5275f11a6928012","user":{"login":"DANS-KNAW-jp","id":21305289,"avatar_url":"https://avatars1.githubusercontent.com/u/21305289?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW-jp","html_url":"https://github.com/DANS-KNAW-jp","followers_url":"https://api.github.com/users/DANS-KNAW-jp/followers","following_url":"https://api.github.com/users/DANS-KNAW-jp/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW-jp/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW-jp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW-jp/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW-jp/orgs","repos_url":"https://api.github.com/users/DANS-KNAW-jp/repos","events_url":"https://api.github.com/users/DANS-KNAW-jp/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW-jp/received_events","type":"Organization","site_admin":false},"repo":{"id":114221442,"name":"easy-solr4files-index","full_name":"DANS-KNAW-jp/easy-solr4files-index","owner":{"login":"DANS-KNAW-jp","id":21305289,"avatar_url":"https://avatars1.githubusercontent.com/u/21305289?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW-jp","html_url":"https://github.com/DANS-KNAW-jp","followers_url":"https://api.github.com/users/DANS-KNAW-jp/followers","following_url":"https://api.github.com/users/DANS-KNAW-jp/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW-jp/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW-jp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW-jp/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW-jp/orgs","repos_url":"https://api.github.com/users/DANS-KNAW-jp/repos","events_url":"https://api.github.com/users/DANS-KNAW-jp/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW-jp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DANS-KNAW-jp/easy-solr4files-index","description":"EASY SOLR Files Index Service","fork":true,"url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index","forks_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/forks","keys_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/teams","hooks_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/hooks","issue_events_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/issues/events{/number}","events_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/events","assignees_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/assignees{/user}","branches_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/branches{/branch}","tags_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/tags","blobs_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/git/refs{/sha}","trees_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/statuses/{sha}","languages_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/languages","stargazers_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/stargazers","contributors_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/contributors","subscribers_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/subscribers","subscription_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/subscription","commits_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/commits{/sha}","git_commits_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/git/commits{/sha}","comments_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/comments{/number}","issue_comment_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/issues/comments{/number}","contents_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/contents/{+path}","compare_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/merges","archive_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/downloads","issues_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/issues{/number}","pulls_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/pulls{/number}","milestones_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/milestones{/number}","notifications_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/labels{/name}","releases_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/releases{/id}","deployments_url":"https://api.github.com/repos/DANS-KNAW-jp/easy-solr4files-index/deployments","created_at":"2017-12-14T08:09:53Z","updated_at":"2017-12-14T08:09:55Z","pushed_at":"2017-12-19T12:21:27Z","git_url":"git://github.com/DANS-KNAW-jp/easy-solr4files-index.git","ssh_url":"git@github.com:DANS-KNAW-jp/easy-solr4files-index.git","clone_url":"https://github.com/DANS-KNAW-jp/easy-solr4files-index.git","svn_url":"https://github.com/DANS-KNAW-jp/easy-solr4files-index","homepage":"","size":21988,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DANS-KNAW:master","ref":"master","sha":"ece1d0c5a93bcaef6ddf2a4c0dab5c545c26b44b","user":{"login":"DANS-KNAW","id":7858446,"avatar_url":"https://avatars3.githubusercontent.com/u/7858446?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW","html_url":"https://github.com/DANS-KNAW","followers_url":"https://api.github.com/users/DANS-KNAW/followers","following_url":"https://api.github.com/users/DANS-KNAW/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW/orgs","repos_url":"https://api.github.com/users/DANS-KNAW/repos","events_url":"https://api.github.com/users/DANS-KNAW/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW/received_events","type":"Organization","site_admin":false},"repo":{"id":100683248,"name":"easy-solr4files-index","full_name":"DANS-KNAW/easy-solr4files-index","owner":{"login":"DANS-KNAW","id":7858446,"avatar_url":"https://avatars3.githubusercontent.com/u/7858446?v=4","gravatar_id":"","url":"https://api.github.com/users/DANS-KNAW","html_url":"https://github.com/DANS-KNAW","followers_url":"https://api.github.com/users/DANS-KNAW/followers","following_url":"https://api.github.com/users/DANS-KNAW/following{/other_user}","gists_url":"https://api.github.com/users/DANS-KNAW/gists{/gist_id}","starred_url":"https://api.github.com/users/DANS-KNAW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DANS-KNAW/subscriptions","organizations_url":"https://api.github.com/users/DANS-KNAW/orgs","repos_url":"https://api.github.com/users/DANS-KNAW/repos","events_url":"https://api.github.com/users/DANS-KNAW/events{/privacy}","received_events_url":"https://api.github.com/users/DANS-KNAW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DANS-KNAW/easy-solr4files-index","description":"EASY SOLR Files Index Service","fork":false,"url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index","forks_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/forks","keys_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/teams","hooks_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/hooks","issue_events_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/issues/events{/number}","events_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/events","assignees_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/assignees{/user}","branches_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/branches{/branch}","tags_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/tags","blobs_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/git/refs{/sha}","trees_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/statuses/{sha}","languages_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/languages","stargazers_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/stargazers","contributors_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/contributors","subscribers_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/subscribers","subscription_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/subscription","commits_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/commits{/sha}","git_commits_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/git/commits{/sha}","comments_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/comments{/number}","issue_comment_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/issues/comments{/number}","contents_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/contents/{+path}","compare_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/merges","archive_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/downloads","issues_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/issues{/number}","pulls_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls{/number}","milestones_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/milestones{/number}","notifications_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/labels{/name}","releases_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/releases{/id}","deployments_url":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/deployments","created_at":"2017-08-18T07:01:10Z","updated_at":"2017-12-06T09:37:51Z","pushed_at":"2017-12-20T10:14:38Z","git_url":"git://github.com/DANS-KNAW/easy-solr4files-index.git","ssh_url":"git@github.com:DANS-KNAW/easy-solr4files-index.git","clone_url":"https://github.com/DANS-KNAW/easy-solr4files-index.git","svn_url":"https://github.com/DANS-KNAW/easy-solr4files-index","homepage":"","size":21960,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls/18"},"html":{"href":"https://github.com/DANS-KNAW/easy-solr4files-index/pull/18"},"issue":{"href":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/issues/18"},"comments":{"href":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/DANS-KNAW/easy-solr4files-index/statuses/2f003eccc328c79d954b1147b5275f11a6928012"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"janvanmansum","id":3862694,"avatar_url":"https://avatars3.githubusercontent.com/u/3862694?v=4","gravatar_id":"","url":"https://api.github.com/users/janvanmansum","html_url":"https://github.com/janvanmansum","followers_url":"https://api.github.com/users/janvanmansum/followers","following_url":"https://api.github.com/users/janvanmansum/following{/other_user}","gists_url":"https://api.github.com/users/janvanmansum/gists{/gist_id}","starred_url":"https://api.github.com/users/janvanmansum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvanmansum/subscriptions","organizations_url":"https://api.github.com/users/janvanmansum/orgs","repos_url":"https://api.github.com/users/janvanmansum/repos","events_url":"https://api.github.com/users/janvanmansum/events{/privacy}","received_events_url":"https://api.github.com/users/janvanmansum/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":6,"additions":121,"deletions":170,"changed_files":13}}
{"actor":{"display_login":"janvanmansum"}}