{"action":"created","comment":{"url":"https://api.github.com/repos/coala/coala-bears/pulls/comments/154710417","pull_request_review_id":80914048,"id":154710417,"diff_hunk":"@@ -17,3 +26,23 @@\n HappinessLintBearTest = verify_local_bear(HappinessLintBear,\n                                           valid_files=(good_file,),\n                                           invalid_files=(bad_file,))\n+\n+\n+@generate_skip_decorator(HappinessLintBear)\n+class HappinessLintBearConfigTest(LocalBearTestHelper):\n+\n+    USE_SPACE_ERR_MSG = re.escape('\"use_spaces=True\" is incompatible with '\n+                                  'HappinessLintBear, set it to false.')\n+\n+    def test_validate_use_spaces(self):\n+        section = Section('name')\n+        section.append(Setting('use_spaces', True))\n+        bear = HappinessLintBear(section, Queue())\n+\n+        with self.assertRaisesRegex(AssertionError, self.USE_SPACE_ERR_MSG):\n+            content = bad_file.splitlines()\n+            with prepare_file(content, None) as (file, fname):\n+                with execute_bear(bear, fname, file) as results:\n+                    fdict = {fname: file}\n+                    results[0].apply(fdict)\n+                    self.assertEqual(''.join(fdict[fname]), good_file)","path":"tests/js/HappinessLintBearTest.py","position":38,"original_position":38,"commit_id":"7d9eb733405b8a54b21905ea64a8e34b30f3012a","original_commit_id":"7d9eb733405b8a54b21905ea64a8e34b30f3012a","user":{"login":"Makman2","id":6023916,"avatar_url":"https://avatars3.githubusercontent.com/u/6023916?v=4","gravatar_id":"","url":"https://api.github.com/users/Makman2","html_url":"https://github.com/Makman2","followers_url":"https://api.github.com/users/Makman2/followers","following_url":"https://api.github.com/users/Makman2/following{/other_user}","gists_url":"https://api.github.com/users/Makman2/gists{/gist_id}","starred_url":"https://api.github.com/users/Makman2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makman2/subscriptions","organizations_url":"https://api.github.com/users/Makman2/orgs","repos_url":"https://api.github.com/users/Makman2/repos","events_url":"https://api.github.com/users/Makman2/events{/privacy}","received_events_url":"https://api.github.com/users/Makman2/received_events","type":"User","site_admin":false},"body":"you have read my comment right? You just need to do `bear.execute` below the `with` statement. You don't need `prepare_file` or any other function you have here.","created_at":"2017-12-04T17:04:03Z","updated_at":"2017-12-04T17:04:04Z","html_url":"https://github.com/coala/coala-bears/pull/2125#discussion_r154710417","pull_request_url":"https://api.github.com/repos/coala/coala-bears/pulls/2125","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/comments/154710417"},"html":{"href":"https://github.com/coala/coala-bears/pull/2125#discussion_r154710417"},"pull_request":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/2125"}}},"pull_request":{"url":"https://api.github.com/repos/coala/coala-bears/pulls/2125","id":152429217,"html_url":"https://github.com/coala/coala-bears/pull/2125","diff_url":"https://github.com/coala/coala-bears/pull/2125.diff","patch_url":"https://github.com/coala/coala-bears/pull/2125.patch","issue_url":"https://api.github.com/repos/coala/coala-bears/issues/2125","number":2125,"state":"open","locked":false,"title":"HappinessLintBear: Throw exception when use_spaces","user":{"login":"newbazz","id":25884863,"avatar_url":"https://avatars1.githubusercontent.com/u/25884863?v=4","gravatar_id":"","url":"https://api.github.com/users/newbazz","html_url":"https://github.com/newbazz","followers_url":"https://api.github.com/users/newbazz/followers","following_url":"https://api.github.com/users/newbazz/following{/other_user}","gists_url":"https://api.github.com/users/newbazz/gists{/gist_id}","starred_url":"https://api.github.com/users/newbazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newbazz/subscriptions","organizations_url":"https://api.github.com/users/newbazz/orgs","repos_url":"https://api.github.com/users/newbazz/repos","events_url":"https://api.github.com/users/newbazz/events{/privacy}","received_events_url":"https://api.github.com/users/newbazz/received_events","type":"User","site_admin":false},"body":"Check the of use_spaces for HappinessLintBear\r\nas it requires tabbed indentation.\r\n\r\nCloses https://github.com/coala/coala-bears/issues/1754\r\n\r\n<!--\r\nThanks for your contribution!\r\n\r\nPlease take a quick look at those things down there. They're quite important.\r\nReally! We wrote them for you. Yes you! With utmost care. Read them.\r\n-->\r\n\r\n**For short term contributors:** we understand that getting your commits well\r\ndefined like we require is a hard task and takes some learning. If you\r\nlook to help without wanting to contribute long term there's no need\r\nfor you to learn this. Just drop us a message and we'll take care of brushing\r\nup your stuff for merge!\r\n\r\n### Checklist\r\n\r\n- [x] I read the [commit guidelines](http://coala.io/commit) and I've followed\r\n      them.\r\n- [ ] I ran coala over my code locally. (*All commits have to pass\r\n      individually.* It is not sufficient to have \"fixup commits\" on your PR,\r\n      our bot will still report the issues for the previous commit.) You will\r\n      likely receive a lot of bot comments and build failures if coala does not\r\n      pass on every single commit!\r\n\r\nAfter you submit your pull request, **DO NOT click the 'Update Branch' button.**\r\nWhen asked for a rebase, consult [coala.io/rebase](https://coala.io/rebase)\r\ninstead.\r\n\r\nPlease consider helping us by reviewing other peoples pull requests as well:\r\n\r\n- pick up any PR at <https://coala.io/review>\r\n- review it (check <https://coala.io/reviewing> for more info)\r\n- if you are sure that it needs work, use `cobot mark wip <URL>` to get it out\r\n  of the review queue.\r\n\r\nThe more you review, the more your score will grow at coala.io and we will\r\nreview your PRs faster!\r\n","created_at":"2017-11-14T07:15:02Z","updated_at":"2017-12-04T17:04:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa4e65402da9a5a0a9e58f291b885c6f38fdcf57","assignee":{"login":"newbazz","id":25884863,"avatar_url":"https://avatars1.githubusercontent.com/u/25884863?v=4","gravatar_id":"","url":"https://api.github.com/users/newbazz","html_url":"https://github.com/newbazz","followers_url":"https://api.github.com/users/newbazz/followers","following_url":"https://api.github.com/users/newbazz/following{/other_user}","gists_url":"https://api.github.com/users/newbazz/gists{/gist_id}","starred_url":"https://api.github.com/users/newbazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newbazz/subscriptions","organizations_url":"https://api.github.com/users/newbazz/orgs","repos_url":"https://api.github.com/users/newbazz/repos","events_url":"https://api.github.com/users/newbazz/events{/privacy}","received_events_url":"https://api.github.com/users/newbazz/received_events","type":"User","site_admin":false},"assignees":[{"login":"newbazz","id":25884863,"avatar_url":"https://avatars1.githubusercontent.com/u/25884863?v=4","gravatar_id":"","url":"https://api.github.com/users/newbazz","html_url":"https://github.com/newbazz","followers_url":"https://api.github.com/users/newbazz/followers","following_url":"https://api.github.com/users/newbazz/following{/other_user}","gists_url":"https://api.github.com/users/newbazz/gists{/gist_id}","starred_url":"https://api.github.com/users/newbazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newbazz/subscriptions","organizations_url":"https://api.github.com/users/newbazz/orgs","repos_url":"https://api.github.com/users/newbazz/repos","events_url":"https://api.github.com/users/newbazz/events{/privacy}","received_events_url":"https://api.github.com/users/newbazz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coala/coala-bears/pulls/2125/commits","review_comments_url":"https://api.github.com/repos/coala/coala-bears/pulls/2125/comments","review_comment_url":"https://api.github.com/repos/coala/coala-bears/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coala/coala-bears/issues/2125/comments","statuses_url":"https://api.github.com/repos/coala/coala-bears/statuses/7d9eb733405b8a54b21905ea64a8e34b30f3012a","head":{"label":"newbazz:happiness","ref":"happiness","sha":"7d9eb733405b8a54b21905ea64a8e34b30f3012a","user":{"login":"newbazz","id":25884863,"avatar_url":"https://avatars1.githubusercontent.com/u/25884863?v=4","gravatar_id":"","url":"https://api.github.com/users/newbazz","html_url":"https://github.com/newbazz","followers_url":"https://api.github.com/users/newbazz/followers","following_url":"https://api.github.com/users/newbazz/following{/other_user}","gists_url":"https://api.github.com/users/newbazz/gists{/gist_id}","starred_url":"https://api.github.com/users/newbazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newbazz/subscriptions","organizations_url":"https://api.github.com/users/newbazz/orgs","repos_url":"https://api.github.com/users/newbazz/repos","events_url":"https://api.github.com/users/newbazz/events{/privacy}","received_events_url":"https://api.github.com/users/newbazz/received_events","type":"User","site_admin":false},"repo":{"id":110653132,"name":"coala-bears","full_name":"newbazz/coala-bears","owner":{"login":"newbazz","id":25884863,"avatar_url":"https://avatars1.githubusercontent.com/u/25884863?v=4","gravatar_id":"","url":"https://api.github.com/users/newbazz","html_url":"https://github.com/newbazz","followers_url":"https://api.github.com/users/newbazz/followers","following_url":"https://api.github.com/users/newbazz/following{/other_user}","gists_url":"https://api.github.com/users/newbazz/gists{/gist_id}","starred_url":"https://api.github.com/users/newbazz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newbazz/subscriptions","organizations_url":"https://api.github.com/users/newbazz/orgs","repos_url":"https://api.github.com/users/newbazz/repos","events_url":"https://api.github.com/users/newbazz/events{/privacy}","received_events_url":"https://api.github.com/users/newbazz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/newbazz/coala-bears","description":"Bears for coala","fork":true,"url":"https://api.github.com/repos/newbazz/coala-bears","forks_url":"https://api.github.com/repos/newbazz/coala-bears/forks","keys_url":"https://api.github.com/repos/newbazz/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/newbazz/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/newbazz/coala-bears/teams","hooks_url":"https://api.github.com/repos/newbazz/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/newbazz/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/newbazz/coala-bears/events","assignees_url":"https://api.github.com/repos/newbazz/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/newbazz/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/newbazz/coala-bears/tags","blobs_url":"https://api.github.com/repos/newbazz/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/newbazz/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/newbazz/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/newbazz/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/newbazz/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/newbazz/coala-bears/languages","stargazers_url":"https://api.github.com/repos/newbazz/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/newbazz/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/newbazz/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/newbazz/coala-bears/subscription","commits_url":"https://api.github.com/repos/newbazz/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/newbazz/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/newbazz/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/newbazz/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/newbazz/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/newbazz/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/newbazz/coala-bears/merges","archive_url":"https://api.github.com/repos/newbazz/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/newbazz/coala-bears/downloads","issues_url":"https://api.github.com/repos/newbazz/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/newbazz/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/newbazz/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/newbazz/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/newbazz/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/newbazz/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/newbazz/coala-bears/deployments","created_at":"2017-11-14T07:01:48Z","updated_at":"2017-11-14T07:01:50Z","pushed_at":"2017-12-04T16:59:55Z","git_url":"git://github.com/newbazz/coala-bears.git","ssh_url":"git@github.com:newbazz/coala-bears.git","clone_url":"https://github.com/newbazz/coala-bears.git","svn_url":"https://github.com/newbazz/coala-bears","homepage":"https://coala.io/","size":1897,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coala:master","ref":"master","sha":"1a7c514aff65d804d86ca4df6ea2b51adc5403cc","user":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":51688289,"name":"coala-bears","full_name":"coala/coala-bears","owner":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coala/coala-bears","description":"Bears for coala","fork":false,"url":"https://api.github.com/repos/coala/coala-bears","forks_url":"https://api.github.com/repos/coala/coala-bears/forks","keys_url":"https://api.github.com/repos/coala/coala-bears/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/coala-bears/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/coala-bears/teams","hooks_url":"https://api.github.com/repos/coala/coala-bears/hooks","issue_events_url":"https://api.github.com/repos/coala/coala-bears/issues/events{/number}","events_url":"https://api.github.com/repos/coala/coala-bears/events","assignees_url":"https://api.github.com/repos/coala/coala-bears/assignees{/user}","branches_url":"https://api.github.com/repos/coala/coala-bears/branches{/branch}","tags_url":"https://api.github.com/repos/coala/coala-bears/tags","blobs_url":"https://api.github.com/repos/coala/coala-bears/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/coala-bears/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/coala-bears/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/coala-bears/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/coala-bears/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/coala-bears/languages","stargazers_url":"https://api.github.com/repos/coala/coala-bears/stargazers","contributors_url":"https://api.github.com/repos/coala/coala-bears/contributors","subscribers_url":"https://api.github.com/repos/coala/coala-bears/subscribers","subscription_url":"https://api.github.com/repos/coala/coala-bears/subscription","commits_url":"https://api.github.com/repos/coala/coala-bears/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/coala-bears/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/coala-bears/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/coala-bears/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/coala-bears/contents/{+path}","compare_url":"https://api.github.com/repos/coala/coala-bears/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/coala-bears/merges","archive_url":"https://api.github.com/repos/coala/coala-bears/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/coala-bears/downloads","issues_url":"https://api.github.com/repos/coala/coala-bears/issues{/number}","pulls_url":"https://api.github.com/repos/coala/coala-bears/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/coala-bears/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/coala-bears/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/coala-bears/labels{/name}","releases_url":"https://api.github.com/repos/coala/coala-bears/releases{/id}","deployments_url":"https://api.github.com/repos/coala/coala-bears/deployments","created_at":"2016-02-14T09:25:11Z","updated_at":"2017-11-29T21:55:31Z","pushed_at":"2017-12-04T16:59:57Z","git_url":"git://github.com/coala/coala-bears.git","ssh_url":"git@github.com:coala/coala-bears.git","clone_url":"https://github.com/coala/coala-bears.git","svn_url":"https://github.com/coala/coala-bears","homepage":"https://coala.io/","size":1904,"stargazers_count":148,"watchers_count":148,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":389,"mirror_url":null,"archived":false,"open_issues_count":565,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":389,"open_issues":565,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/2125"},"html":{"href":"https://github.com/coala/coala-bears/pull/2125"},"issue":{"href":"https://api.github.com/repos/coala/coala-bears/issues/2125"},"comments":{"href":"https://api.github.com/repos/coala/coala-bears/issues/2125/comments"},"review_comments":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/2125/comments"},"review_comment":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coala/coala-bears/pulls/2125/commits"},"statuses":{"href":"https://api.github.com/repos/coala/coala-bears/statuses/7d9eb733405b8a54b21905ea64a8e34b30f3012a"}},"author_association":"NONE"}}
{"actor":{"display_login":"Makman2"}}