{"action":"created","issue":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1582","repository_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf","labels_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1582/labels{/name}","comments_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1582/comments","events_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1582/events","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1582","id":200438542,"number":1582,"title":"fix(test): add rv-langs with French as default in index-fgp-fr.html","user":{"login":"ChrisLatRNCan","id":16193004,"avatar_url":"https://avatars.githubusercontent.com/u/16193004?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisLatRNCan","html_url":"https://github.com/ChrisLatRNCan","followers_url":"https://api.github.com/users/ChrisLatRNCan/followers","following_url":"https://api.github.com/users/ChrisLatRNCan/following{/other_user}","gists_url":"https://api.github.com/users/ChrisLatRNCan/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisLatRNCan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisLatRNCan/subscriptions","organizations_url":"https://api.github.com/users/ChrisLatRNCan/orgs","repos_url":"https://api.github.com/users/ChrisLatRNCan/repos","events_url":"https://api.github.com/users/ChrisLatRNCan/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisLatRNCan/received_events","type":"User","site_admin":false},"labels":[{"id":472536239,"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/labels/v1.5.0","name":"v1.5.0","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"assignees":[{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-01-12T18:03:19Z","updated_at":"2017-01-12T19:48:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/pulls/1582","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1582","diff_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1582.diff","patch_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1582.patch"},"body":"## Description\r\nLeft Sided Menu defaulted to English when loaded FGP Visualiser from index-fgp-fr.html #1539\r\n\r\n## Testing\r\nManual test with index-fgp-fr.html\r\n\r\n## Documentation\r\n<!-- Which areas of documentation have been changed: jsdoc, tutorials, samples, wiki -->\r\n\r\n## Checklist\r\n<!-- Quick checklist for items that are easy to miss -->\r\n\r\n- [x] commits messages follow the guidelines\r\n- [x] code passes unit tests\r\n- [x] release notes have been updated\r\n- [x] PR targets the correct release version\r\n\r\nCloses #1539\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fgpv-vpgf/fgpv-vpgf/1582)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/comments/272263429","html_url":"https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1582#issuecomment-272263429","issue_url":"https://api.github.com/repos/fgpv-vpgf/fgpv-vpgf/issues/1582","id":272263429,"user":{"login":"AleksueiR","id":2285779,"avatar_url":"https://avatars.githubusercontent.com/u/2285779?v=3","gravatar_id":"","url":"https://api.github.com/users/AleksueiR","html_url":"https://github.com/AleksueiR","followers_url":"https://api.github.com/users/AleksueiR/followers","following_url":"https://api.github.com/users/AleksueiR/following{/other_user}","gists_url":"https://api.github.com/users/AleksueiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AleksueiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AleksueiR/subscriptions","organizations_url":"https://api.github.com/users/AleksueiR/orgs","repos_url":"https://api.github.com/users/AleksueiR/repos","events_url":"https://api.github.com/users/AleksueiR/events{/privacy}","received_events_url":"https://api.github.com/users/AleksueiR/received_events","type":"User","site_admin":false},"created_at":"2017-01-12T19:48:22Z","updated_at":"2017-01-12T19:48:22Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[src/index-fgp-fr.html, line 453 at r1](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/1582#-KaJCo0gqiUIr9kwL4M0:-KaJCo0gqiUIr9kwL4M1:b-t3d8tl) ([raw file](https://github.com/fgpv-vpgf/fgpv-vpgf/blob/1c643918bb698155c6b941122cab1a5eefeb156a/src/index-fgp-fr.html#L453)):*\n> ```HTML\n>                         <button onclick=\"testBackToCart()\">backToCart</button>\n>                     </div>\n>                     <div id=\"fgpmap\" class=\"fgpv\" rv-config=\"config.rcs.fr-CA.json\" rv-langs='[\"fr-CA\",\"en-CA\"]' rv-service-endpoint=\"http://section917.cloudapp.net:8000/\" rv-wait>\n> ```\n\n`rv-langs` were previously removed in https://github.com/fgpv-vpgf/fgpv-vpgf/pull/1528/files trying to fix https://github.com/fgpv-vpgf/fgpv-vpgf/issues/1468. Aren't we re-introducing this bug again.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/fgpv-vpgf/fgpv-vpgf/1582)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"AleksueiR"}}