{"action":"created","comment":{"url":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/comments/103368431","pull_request_review_id":24151609,"id":103368431,"diff_hunk":"@@ -298,16 +298,16 @@ function diffArguments(thisType, otherType, thisField, otherField, options) {\n     let newArgsMap = getArgumentMap(otherField.args);\n     oldArgsMap.forEach(function(value, key) {\n         if (!newArgsMap.has(key)) {\n-            const description = format('Argument `\"{0} : {1}\"` on type {2}.{3} has been removed from {4}.', value, key, thisType, thisField.name, options.labelForThis);\n+            const description = format('Argument missing from {0} : `\"{1} : {2}\"` on field {3}.{4}.', options.labelForThis, key, value, thisType, thisField.name);","path":"index.js","position":null,"original_position":5,"commit_id":"86ce2d6d78bbdfdc3c0ec4a7030263bab9aab9a0","original_commit_id":"86ce2d6d78bbdfdc3c0ec4a7030263bab9aab9a0","user":{"login":"jarwol","id":1578302,"avatar_url":"https://avatars.githubusercontent.com/u/1578302?v=3","gravatar_id":"","url":"https://api.github.com/users/jarwol","html_url":"https://github.com/jarwol","followers_url":"https://api.github.com/users/jarwol/followers","following_url":"https://api.github.com/users/jarwol/following{/other_user}","gists_url":"https://api.github.com/users/jarwol/gists{/gist_id}","starred_url":"https://api.github.com/users/jarwol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarwol/subscriptions","organizations_url":"https://api.github.com/users/jarwol/orgs","repos_url":"https://api.github.com/users/jarwol/repos","events_url":"https://api.github.com/users/jarwol/events{/privacy}","received_events_url":"https://api.github.com/users/jarwol/received_events","type":"User","site_admin":false},"body":"Let's format it like this (fields substituted for readability):\r\nArgument missing from existing schema: `Query.VideoByGenre(genre: String!)`.\r\n\r\nThat makes it a bit more succinct.","created_at":"2017-02-28T03:13:58Z","updated_at":"2017-02-28T03:16:54Z","html_url":"https://github.com/jarwol/graphql-schema-utils/pull/1#discussion_r103368431","pull_request_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/comments/103368431"},"html":{"href":"https://github.com/jarwol/graphql-schema-utils/pull/1#discussion_r103368431"},"pull_request":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/1","id":108171207,"html_url":"https://github.com/jarwol/graphql-schema-utils/pull/1","diff_url":"https://github.com/jarwol/graphql-schema-utils/pull/1.diff","patch_url":"https://github.com/jarwol/graphql-schema-utils/pull/1.patch","issue_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/issues/1","number":1,"state":"open","locked":false,"title":"Added backwards compatibility boolean to GraphQLDiff","user":{"login":"echuchee","id":6951853,"avatar_url":"https://avatars.githubusercontent.com/u/6951853?v=3","gravatar_id":"","url":"https://api.github.com/users/echuchee","html_url":"https://github.com/echuchee","followers_url":"https://api.github.com/users/echuchee/followers","following_url":"https://api.github.com/users/echuchee/following{/other_user}","gists_url":"https://api.github.com/users/echuchee/gists{/gist_id}","starred_url":"https://api.github.com/users/echuchee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echuchee/subscriptions","organizations_url":"https://api.github.com/users/echuchee/orgs","repos_url":"https://api.github.com/users/echuchee/repos","events_url":"https://api.github.com/users/echuchee/events{/privacy}","received_events_url":"https://api.github.com/users/echuchee/received_events","type":"User","site_admin":false},"body":"**Changes**\r\nAdded backwards compatibility boolean to GraphQLDiff. It will return false if the change is not backwards compatible. \r\nFixed the enum logic. Changing the order of enums report false diffs. They are added to a map(enumValue, enum) and checked against one another now, so order won't matter.\r\nAdded diffArguments() which will compare the differences in arguments between two fields(this was a string comparison before).\r\nUpdated unit tests.\r\n**Testing**\r\nUnit tests pass.\r\n","created_at":"2017-02-27T18:16:52Z","updated_at":"2017-02-28T03:16:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76f472b7968dcf5fb8bed5570539d164d779a34a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/issues/1/comments","statuses_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/statuses/86ce2d6d78bbdfdc3c0ec4a7030263bab9aab9a0","head":{"label":"echuchee:zdev/aperez/backwards-compatibility","ref":"zdev/aperez/backwards-compatibility","sha":"86ce2d6d78bbdfdc3c0ec4a7030263bab9aab9a0","user":{"login":"echuchee","id":6951853,"avatar_url":"https://avatars.githubusercontent.com/u/6951853?v=3","gravatar_id":"","url":"https://api.github.com/users/echuchee","html_url":"https://github.com/echuchee","followers_url":"https://api.github.com/users/echuchee/followers","following_url":"https://api.github.com/users/echuchee/following{/other_user}","gists_url":"https://api.github.com/users/echuchee/gists{/gist_id}","starred_url":"https://api.github.com/users/echuchee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echuchee/subscriptions","organizations_url":"https://api.github.com/users/echuchee/orgs","repos_url":"https://api.github.com/users/echuchee/repos","events_url":"https://api.github.com/users/echuchee/events{/privacy}","received_events_url":"https://api.github.com/users/echuchee/received_events","type":"User","site_admin":false},"repo":{"id":83340929,"name":"graphql-schema-utils","full_name":"echuchee/graphql-schema-utils","owner":{"login":"echuchee","id":6951853,"avatar_url":"https://avatars.githubusercontent.com/u/6951853?v=3","gravatar_id":"","url":"https://api.github.com/users/echuchee","html_url":"https://github.com/echuchee","followers_url":"https://api.github.com/users/echuchee/followers","following_url":"https://api.github.com/users/echuchee/following{/other_user}","gists_url":"https://api.github.com/users/echuchee/gists{/gist_id}","starred_url":"https://api.github.com/users/echuchee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echuchee/subscriptions","organizations_url":"https://api.github.com/users/echuchee/orgs","repos_url":"https://api.github.com/users/echuchee/repos","events_url":"https://api.github.com/users/echuchee/events{/privacy}","received_events_url":"https://api.github.com/users/echuchee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/echuchee/graphql-schema-utils","description":"Extensions for graphql-js to support diffing and merging types and schemas.","fork":true,"url":"https://api.github.com/repos/echuchee/graphql-schema-utils","forks_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/forks","keys_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/teams","hooks_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/hooks","issue_events_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/issues/events{/number}","events_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/events","assignees_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/assignees{/user}","branches_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/branches{/branch}","tags_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/tags","blobs_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/languages","stargazers_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/stargazers","contributors_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/contributors","subscribers_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/subscribers","subscription_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/subscription","commits_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/contents/{+path}","compare_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/merges","archive_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/downloads","issues_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/issues{/number}","pulls_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/labels{/name}","releases_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/releases{/id}","deployments_url":"https://api.github.com/repos/echuchee/graphql-schema-utils/deployments","created_at":"2017-02-27T18:05:34Z","updated_at":"2017-02-27T18:05:37Z","pushed_at":"2017-02-27T23:38:20Z","git_url":"git://github.com/echuchee/graphql-schema-utils.git","ssh_url":"git@github.com:echuchee/graphql-schema-utils.git","clone_url":"https://github.com/echuchee/graphql-schema-utils.git","svn_url":"https://github.com/echuchee/graphql-schema-utils","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jarwol:master","ref":"master","sha":"baf6cd55b6560f090b84702ca7b7f6d7d026e5fc","user":{"login":"jarwol","id":1578302,"avatar_url":"https://avatars.githubusercontent.com/u/1578302?v=3","gravatar_id":"","url":"https://api.github.com/users/jarwol","html_url":"https://github.com/jarwol","followers_url":"https://api.github.com/users/jarwol/followers","following_url":"https://api.github.com/users/jarwol/following{/other_user}","gists_url":"https://api.github.com/users/jarwol/gists{/gist_id}","starred_url":"https://api.github.com/users/jarwol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarwol/subscriptions","organizations_url":"https://api.github.com/users/jarwol/orgs","repos_url":"https://api.github.com/users/jarwol/repos","events_url":"https://api.github.com/users/jarwol/events{/privacy}","received_events_url":"https://api.github.com/users/jarwol/received_events","type":"User","site_admin":false},"repo":{"id":78953908,"name":"graphql-schema-utils","full_name":"jarwol/graphql-schema-utils","owner":{"login":"jarwol","id":1578302,"avatar_url":"https://avatars.githubusercontent.com/u/1578302?v=3","gravatar_id":"","url":"https://api.github.com/users/jarwol","html_url":"https://github.com/jarwol","followers_url":"https://api.github.com/users/jarwol/followers","following_url":"https://api.github.com/users/jarwol/following{/other_user}","gists_url":"https://api.github.com/users/jarwol/gists{/gist_id}","starred_url":"https://api.github.com/users/jarwol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarwol/subscriptions","organizations_url":"https://api.github.com/users/jarwol/orgs","repos_url":"https://api.github.com/users/jarwol/repos","events_url":"https://api.github.com/users/jarwol/events{/privacy}","received_events_url":"https://api.github.com/users/jarwol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jarwol/graphql-schema-utils","description":"Extensions for graphql-js to support diffing and merging types and schemas.","fork":false,"url":"https://api.github.com/repos/jarwol/graphql-schema-utils","forks_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/forks","keys_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/teams","hooks_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/hooks","issue_events_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/issues/events{/number}","events_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/events","assignees_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/assignees{/user}","branches_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/branches{/branch}","tags_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/tags","blobs_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/languages","stargazers_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/stargazers","contributors_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/contributors","subscribers_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/subscribers","subscription_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/subscription","commits_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/contents/{+path}","compare_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/merges","archive_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/downloads","issues_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/issues{/number}","pulls_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/labels{/name}","releases_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/releases{/id}","deployments_url":"https://api.github.com/repos/jarwol/graphql-schema-utils/deployments","created_at":"2017-01-14T17:06:46Z","updated_at":"2017-01-26T20:34:03Z","pushed_at":"2017-02-27T23:38:21Z","git_url":"git://github.com/jarwol/graphql-schema-utils.git","ssh_url":"git@github.com:jarwol/graphql-schema-utils.git","clone_url":"https://github.com/jarwol/graphql-schema-utils.git","svn_url":"https://github.com/jarwol/graphql-schema-utils","homepage":null,"size":20,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/1"},"html":{"href":"https://github.com/jarwol/graphql-schema-utils/pull/1"},"issue":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/issues/1"},"comments":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jarwol/graphql-schema-utils/statuses/86ce2d6d78bbdfdc3c0ec4a7030263bab9aab9a0"}}}}
{"actor":{"display_login":"jarwol"}}