{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1981","repository_url":"https://api.github.com/repos/mozilla/fxa-auth-server","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1981/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1981/comments","events_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1981/events","html_url":"https://github.com/mozilla/fxa-auth-server/issues/1981","id":241665222,"number":1981,"title":"Eliminate token.tokenId?","user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars1.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"labels":[{"id":189718405,"url":"https://api.github.com/repos/mozilla/fxa-auth-server/labels/good-first-bug","name":"good-first-bug","color":"009800","default":false},{"id":596022789,"url":"https://api.github.com/repos/mozilla/fxa-auth-server/labels/P3","name":"P3","color":"ededed","default":false},{"id":246045378,"url":"https://api.github.com/repos/mozilla/fxa-auth-server/labels/waffle:backlog","name":"waffle:backlog","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/milestones/39","html_url":"https://github.com/mozilla/fxa-auth-server/milestone/39","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-server/milestones/39/labels","id":1265652,"number":39,"title":"FxA-0: quality","description":"general quality improvements","creator":{"login":"rfk","id":34695,"avatar_url":"https://avatars0.githubusercontent.com/u/34695?v=3","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":205,"state":"open","created_at":"2015-08-21T02:49:49Z","updated_at":"2017-07-13T11:41:06Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-07-10T10:18:11Z","updated_at":"2017-07-13T15:52:39Z","closed_at":null,"body":"Pre-#1950, token objects used to have an `id` property that was a hex string representation of their `tokenId` property, which was a `Buffer`. Post-#1950, `id` and `tokenId` are identical. Although it's essentially harmless, I predict this will cause a certain amount of head-scratching for future developers. Let's ditch `tokenId` and use `id` everywhere."},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/comments/315120567","html_url":"https://github.com/mozilla/fxa-auth-server/issues/1981#issuecomment-315120567","issue_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1981","id":315120567,"user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars1.githubusercontent.com/u/64367?v=3","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"created_at":"2017-07-13T15:52:39Z","updated_at":"2017-07-13T15:52:39Z","body":"> I don't like stuttering in my code, like `token.tokenId`, so I'd prefer if we used `token.id` instead.\r\n\r\nFwiw, that turns out to be a messier change because the property returned by the db is `tokenId`, so we have to map the array returned by `db.sessions` for example. How strong is your distaste for `token.tokenId`?"}}
{"actor":{"display_login":"philbooth"}}