{"action":"created","issue":{"url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3249","repository_url":"https://api.github.com/repos/endless-sky/endless-sky","labels_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3249/labels{/name}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3249/comments","events_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3249/events","html_url":"https://github.com/endless-sky/endless-sky/issues/3249","id":275854365,"number":3249,"title":"Request: add “medium freighter” category","user":{"login":"Nescio0","id":21634324,"avatar_url":"https://avatars1.githubusercontent.com/u/21634324?v=4","gravatar_id":"","url":"https://api.github.com/users/Nescio0","html_url":"https://github.com/Nescio0","followers_url":"https://api.github.com/users/Nescio0/followers","following_url":"https://api.github.com/users/Nescio0/following{/other_user}","gists_url":"https://api.github.com/users/Nescio0/gists{/gist_id}","starred_url":"https://api.github.com/users/Nescio0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nescio0/subscriptions","organizations_url":"https://api.github.com/users/Nescio0/orgs","repos_url":"https://api.github.com/users/Nescio0/repos","events_url":"https://api.github.com/users/Nescio0/events{/privacy}","received_events_url":"https://api.github.com/users/Nescio0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-11-21T20:46:49Z","updated_at":"2017-11-21T21:15:42Z","closed_at":null,"author_association":"NONE","body":"(Hopefully this is the correct place to post, I'm new to endless-sky.)\r\n\r\nCurrently warships are grouped under “light”, “medium”, or “heavy”, but freighters can only be either “light” or “heavy”, because “medium” does not exist. This leads to weird things, e.g. the Nest, Roost, and Skein are all medium warships, but for their freighter counterparts, the hauler is light and the hauler ii and hauler iii are heavy. Therefore I think a “medium frighter” category should be added.\r\n\r\nAfter looking at the available ships in human space it seems the criterion is the empty mass (i.e. hull plus outfits):\r\nlight: <500\r\nmedium: 500-1000\r\nheavy: >1000\r\n\r\nSo what I suggest is:\r\n* `source/Ship.cpp`: \r\n  * insert at line 49: `\"Medium Freighter\",`\r\n* `data/hai ships.txt`: \r\n  * change Water Bug category to \"Medium Freighter\"\r\n* `data/ships.txt`:\r\n  * change Argosy category to \"Medium Freighter\"\r\n  * change Bastion mass to 540 and outfit space to 450\r\n  * change Hauler category to \"Medium Freighter\"\r\n  * change Hauler II category to \"Medium Freighter\"\r\n  * change Hauler III category to \"Medium Freighter\"\r\n  * change Modified Argosy category to \"Medium Warship\"\r\n\r\n(If I had commit access I could push these changes myself.)"},"comment":{"url":"https://api.github.com/repos/endless-sky/endless-sky/issues/comments/346163356","html_url":"https://github.com/endless-sky/endless-sky/issues/3249#issuecomment-346163356","issue_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/3249","id":346163356,"user":{"login":"jafdy","id":15716454,"avatar_url":"https://avatars0.githubusercontent.com/u/15716454?v=4","gravatar_id":"","url":"https://api.github.com/users/jafdy","html_url":"https://github.com/jafdy","followers_url":"https://api.github.com/users/jafdy/followers","following_url":"https://api.github.com/users/jafdy/following{/other_user}","gists_url":"https://api.github.com/users/jafdy/gists{/gist_id}","starred_url":"https://api.github.com/users/jafdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafdy/subscriptions","organizations_url":"https://api.github.com/users/jafdy/orgs","repos_url":"https://api.github.com/users/jafdy/repos","events_url":"https://api.github.com/users/jafdy/events{/privacy}","received_events_url":"https://api.github.com/users/jafdy/received_events","type":"User","site_admin":false},"created_at":"2017-11-21T21:15:42Z","updated_at":"2017-11-21T21:15:42Z","author_association":"CONTRIBUTOR","body":"Close this then."}}
{"actor":{"display_login":"jafdy"}}