{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1130","repository_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards","labels_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1130/labels{/name}","comments_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1130/comments","events_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1130/events","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1130","id":256266544,"number":1130,"title":"Fix travis build: load PHPCS native bootstrap if available and test against PHP 7.2","user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars1.githubusercontent.com/u/663378?v=4","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"labels":[{"id":202582556,"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/labels/Status:%20Review%20Ready","name":"Status: Review Ready","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/milestones/14","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/milestone/14","labels_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/milestones/14/labels","id":2646516,"number":14,"title":"0.14.0","description":"","creator":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars1.githubusercontent.com/u/663378?v=4","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":32,"state":"open","created_at":"2017-07-18T03:03:09Z","updated_at":"2017-09-08T14:11:41Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-09-08T14:11:41Z","updated_at":"2017-09-08T14:28:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/pulls/1130","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1130","diff_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1130.diff","patch_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1130.patch"},"body":"The upstream PR to support PHPUnit 6.x has (finally) been merged and will be released in PHPCS 3.1.\r\n\r\nCurrently builds against PHPCS `master` are failing because of this as the final version of the PHPCS PHPUnit 6.x support PR includes a test bootstrap in PHPCS which is not being loaded as we use our own bootstrap.\r\n\r\nEasily solved though, by loading the upstream bootstrap - if the file exists - from our own PHPCS 3 bootstrap file. That way our unit testing will be compatible with all supported PHPCS 3.x versions.\r\n\r\nThe `beStrictAboutTestsThatDoNotTestAnything=\"false\"` addition to the `phpunit.xml.dist` file is needed to prevent PHPUnit from reporting there are no tests in our test files (as the tests are in the upstream test suite and our \"tests\" are basically only data providers).\r\n\r\nThe changes made in #873 should, for now, not be reverted as PHPCS < 3.1 is not compatible with PHPUnit 6.x and accounting for all the different situation with an `if` statement in the build script would get unnecessarily complicated. See the table below for more details.\r\n\r\nOnce PHPCS 2.x support is dropped and the minimum supported PHPCS version has gone up to 3.1, we should be able to revert the changes made in #873 without issues (except for HHVM).\r\n\r\nUpstream references:\r\n* squizlabs/PHP_CodeSniffer#1383\r\n* squizlabs/PHP_CodeSniffer#1384\r\n\r\nAdditionally:\r\n* While looking at the travis builds to fix this I noticed that `nightly` has gone up to PHP `7.3.0-dev`, so I've added PHP 7.2 to the build matrix.\r\n\r\n-----\r\n\r\n### Detail overview of Travis build info as of today (Sept 8 2017):\r\n\r\nPHP | Travis PHPUnit | PHPCS 2.x | PHPCS < 3.1 | PHPCS master | Notes\r\n--- | -------- | ---- | ---- | ---- | ----\r\n5.3 | 4.8.18 | :white_check_mark:  | :white_check_mark:  | :white_check_mark: |\r\n5.4 | 4.8.35 | :white_check_mark:  | :white_check_mark:  | :white_check_mark:  |\r\n5.5 | 4.8.27 | :white_check_mark:  | :white_check_mark:  | :white_check_mark:  |\r\n5.6 | 5.5.0 | :white_check_mark:  | :white_check_mark:  | :white_check_mark:  |\r\n7.0 | 6.3.0 / 5.3.4 | :x:  | :x: | :white_check_mark: | If PHPUnit 5.3.4 :white_check_mark: for the previous two, but no telling what the logic is about which PHPUnit version is loaded\r\n7.1 | 6.3.0 | :x:  | :x: | :white_check_mark: |\r\n7.2 | 6.3.0 | :x:  | :x:  | :white_check_mark: |\r\nnightly | 6.3.0 | :x: | :x:  | :white_check_mark: |\r\nHHVM | 6.3.0 | :x:  | :x:  | :x: | Hit and miss, sometimes it will work, sometimes it won't"},"comment":{"url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/comments/328118182","html_url":"https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1130#issuecomment-328118182","issue_url":"https://api.github.com/repos/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/1130","id":328118182,"user":{"login":"jrfnl","id":663378,"avatar_url":"https://avatars1.githubusercontent.com/u/663378?v=4","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"created_at":"2017-09-08T14:28:14Z","updated_at":"2017-09-08T14:28:14Z","author_association":"CONTRIBUTOR","body":"> Installing a different PHPUnit version should be as simple as adding composer global require \"phpunit/phpunit=5.3.4\" to the install steps. If that is needed.\r\n\r\nThat's what we are basically doing for all PHP 7 versions + HHVM now by downloading the PHPUnit `phar`. (= what was added in PR #873 )\r\nWe can't unconditionally require it via Composer as different PHP versions need different PHPUnit versions."}}
{"actor":{"display_login":"jrfnl"}}