{"action":"created","comment":{"url":"https://api.github.com/repos/atom/atom/pulls/comments/155881479","pull_request_review_id":82280755,"id":155881479,"diff_hunk":"@@ -66,4 +66,27 @@ describe('NotificationManager', () => {\n       expect(notification.getType()).toBe('success')\n     })\n   })\n+\n+  describe('clearing notifications', function () {","path":"spec/notification-manager-spec.js","position":5,"original_position":5,"commit_id":"fe4df885d650724e5f11ccbc024c518a6d34d0fd","original_commit_id":"fe4df885d650724e5f11ccbc024c518a6d34d0fd","user":{"login":"maxbrunsfeld","id":326587,"avatar_url":"https://avatars3.githubusercontent.com/u/326587?v=4","gravatar_id":"","url":"https://api.github.com/users/maxbrunsfeld","html_url":"https://github.com/maxbrunsfeld","followers_url":"https://api.github.com/users/maxbrunsfeld/followers","following_url":"https://api.github.com/users/maxbrunsfeld/following{/other_user}","gists_url":"https://api.github.com/users/maxbrunsfeld/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbrunsfeld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbrunsfeld/subscriptions","organizations_url":"https://api.github.com/users/maxbrunsfeld/orgs","repos_url":"https://api.github.com/users/maxbrunsfeld/repos","events_url":"https://api.github.com/users/maxbrunsfeld/events{/privacy}","received_events_url":"https://api.github.com/users/maxbrunsfeld/received_events","type":"User","site_admin":true},"body":"Could you use an arrow function here? That's the style we're using in the rest of the file.","created_at":"2017-12-08T21:38:47Z","updated_at":"2017-12-08T21:41:42Z","html_url":"https://github.com/atom/atom/pull/16074#discussion_r155881479","pull_request_url":"https://api.github.com/repos/atom/atom/pulls/16074","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/comments/155881479"},"html":{"href":"https://github.com/atom/atom/pull/16074#discussion_r155881479"},"pull_request":{"href":"https://api.github.com/repos/atom/atom/pulls/16074"}}},"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/16074","id":150329040,"html_url":"https://github.com/atom/atom/pull/16074","diff_url":"https://github.com/atom/atom/pull/16074.diff","patch_url":"https://github.com/atom/atom/pull/16074.patch","issue_url":"https://api.github.com/repos/atom/atom/issues/16074","number":16074,"state":"open","locked":false,"title":"Make notifications.clear public and emit event","user":{"login":"UziTech","id":97994,"avatar_url":"https://avatars3.githubusercontent.com/u/97994?v=4","gravatar_id":"","url":"https://api.github.com/users/UziTech","html_url":"https://github.com/UziTech","followers_url":"https://api.github.com/users/UziTech/followers","following_url":"https://api.github.com/users/UziTech/following{/other_user}","gists_url":"https://api.github.com/users/UziTech/gists{/gist_id}","starred_url":"https://api.github.com/users/UziTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UziTech/subscriptions","organizations_url":"https://api.github.com/users/UziTech/orgs","repos_url":"https://api.github.com/users/UziTech/repos","events_url":"https://api.github.com/users/UziTech/events{/privacy}","received_events_url":"https://api.github.com/users/UziTech/received_events","type":"User","site_admin":false},"body":"### Description of the Change\r\n\r\nmake `atom.notifications.clear()` public and emit a `did-clear-notifications` event\r\n\r\n<!--\r\n\r\nWe must be able to understand the design of your change from this description. If we can't get a good idea of what the code will be doing from the description here, the pull request may be closed at the maintainers' discretion. Keep in mind that the maintainer reviewing this PR may not be familiar with or have worked with the code here recently, so please walk us through the concepts.\r\n\r\n-->\r\n\r\n### Alternate Designs\r\n\r\n<!-- Explain what other alternates were considered and why the proposed version was selected -->\r\n\r\n### Why Should This Be In Core?\r\n\r\nNotificationsManager would need to emit the event\r\n\r\n<!-- Explain why this functionality should be in atom/atom as opposed to a package -->\r\n\r\n### Benefits\r\n\r\nCould let notifications packages know when to clear the notifications log\r\n\r\n<!-- What benefits will be realized by the code change? -->\r\n\r\n### Possible Drawbacks\r\n\r\nnone\r\n\r\n<!-- What are the possible side-effects or negative impacts of the code change? -->\r\n\r\n### Applicable Issues\r\n\r\nhttps://github.com/atom/notifications/pull/164#issuecomment-341341995\r\n\r\n<!-- Enter any applicable Issues here -->\r\n","created_at":"2017-11-02T15:47:27Z","updated_at":"2017-12-08T21:41:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b688ebb1a3d2de38618cc7982d33d6d89e9d5a3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom/pulls/16074/commits","review_comments_url":"https://api.github.com/repos/atom/atom/pulls/16074/comments","review_comment_url":"https://api.github.com/repos/atom/atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/atom/issues/16074/comments","statuses_url":"https://api.github.com/repos/atom/atom/statuses/fe4df885d650724e5f11ccbc024c518a6d34d0fd","head":{"label":"UziTech:patch-4","ref":"patch-4","sha":"fe4df885d650724e5f11ccbc024c518a6d34d0fd","user":{"login":"UziTech","id":97994,"avatar_url":"https://avatars3.githubusercontent.com/u/97994?v=4","gravatar_id":"","url":"https://api.github.com/users/UziTech","html_url":"https://github.com/UziTech","followers_url":"https://api.github.com/users/UziTech/followers","following_url":"https://api.github.com/users/UziTech/following{/other_user}","gists_url":"https://api.github.com/users/UziTech/gists{/gist_id}","starred_url":"https://api.github.com/users/UziTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UziTech/subscriptions","organizations_url":"https://api.github.com/users/UziTech/orgs","repos_url":"https://api.github.com/users/UziTech/repos","events_url":"https://api.github.com/users/UziTech/events{/privacy}","received_events_url":"https://api.github.com/users/UziTech/received_events","type":"User","site_admin":false},"repo":{"id":80894834,"name":"atom","full_name":"UziTech/atom","owner":{"login":"UziTech","id":97994,"avatar_url":"https://avatars3.githubusercontent.com/u/97994?v=4","gravatar_id":"","url":"https://api.github.com/users/UziTech","html_url":"https://github.com/UziTech","followers_url":"https://api.github.com/users/UziTech/followers","following_url":"https://api.github.com/users/UziTech/following{/other_user}","gists_url":"https://api.github.com/users/UziTech/gists{/gist_id}","starred_url":"https://api.github.com/users/UziTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UziTech/subscriptions","organizations_url":"https://api.github.com/users/UziTech/orgs","repos_url":"https://api.github.com/users/UziTech/repos","events_url":"https://api.github.com/users/UziTech/events{/privacy}","received_events_url":"https://api.github.com/users/UziTech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UziTech/atom","description":"The hackable text editor","fork":true,"url":"https://api.github.com/repos/UziTech/atom","forks_url":"https://api.github.com/repos/UziTech/atom/forks","keys_url":"https://api.github.com/repos/UziTech/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UziTech/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UziTech/atom/teams","hooks_url":"https://api.github.com/repos/UziTech/atom/hooks","issue_events_url":"https://api.github.com/repos/UziTech/atom/issues/events{/number}","events_url":"https://api.github.com/repos/UziTech/atom/events","assignees_url":"https://api.github.com/repos/UziTech/atom/assignees{/user}","branches_url":"https://api.github.com/repos/UziTech/atom/branches{/branch}","tags_url":"https://api.github.com/repos/UziTech/atom/tags","blobs_url":"https://api.github.com/repos/UziTech/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UziTech/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UziTech/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/UziTech/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UziTech/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/UziTech/atom/languages","stargazers_url":"https://api.github.com/repos/UziTech/atom/stargazers","contributors_url":"https://api.github.com/repos/UziTech/atom/contributors","subscribers_url":"https://api.github.com/repos/UziTech/atom/subscribers","subscription_url":"https://api.github.com/repos/UziTech/atom/subscription","commits_url":"https://api.github.com/repos/UziTech/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/UziTech/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/UziTech/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/UziTech/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/UziTech/atom/contents/{+path}","compare_url":"https://api.github.com/repos/UziTech/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UziTech/atom/merges","archive_url":"https://api.github.com/repos/UziTech/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UziTech/atom/downloads","issues_url":"https://api.github.com/repos/UziTech/atom/issues{/number}","pulls_url":"https://api.github.com/repos/UziTech/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/UziTech/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/UziTech/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UziTech/atom/labels{/name}","releases_url":"https://api.github.com/repos/UziTech/atom/releases{/id}","deployments_url":"https://api.github.com/repos/UziTech/atom/deployments","created_at":"2017-02-04T05:02:35Z","updated_at":"2017-02-04T05:02:51Z","pushed_at":"2017-11-16T06:29:29Z","git_url":"git://github.com/UziTech/atom.git","ssh_url":"git@github.com:UziTech/atom.git","clone_url":"https://github.com/UziTech/atom.git","svn_url":"https://github.com/UziTech/atom","homepage":"https://atom.io","size":295369,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"62774596919fdce190a1c5c6378f56535547aac3","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":3228505,"name":"atom","full_name":"atom/atom","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom","description":":atom: The hackable text editor","fork":false,"url":"https://api.github.com/repos/atom/atom","forks_url":"https://api.github.com/repos/atom/atom/forks","keys_url":"https://api.github.com/repos/atom/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom/teams","hooks_url":"https://api.github.com/repos/atom/atom/hooks","issue_events_url":"https://api.github.com/repos/atom/atom/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom/events","assignees_url":"https://api.github.com/repos/atom/atom/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom/tags","blobs_url":"https://api.github.com/repos/atom/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom/languages","stargazers_url":"https://api.github.com/repos/atom/atom/stargazers","contributors_url":"https://api.github.com/repos/atom/atom/contributors","subscribers_url":"https://api.github.com/repos/atom/atom/subscribers","subscription_url":"https://api.github.com/repos/atom/atom/subscription","commits_url":"https://api.github.com/repos/atom/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom/merges","archive_url":"https://api.github.com/repos/atom/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom/downloads","issues_url":"https://api.github.com/repos/atom/atom/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom/releases{/id}","deployments_url":"https://api.github.com/repos/atom/atom/deployments","created_at":"2012-01-20T18:18:21Z","updated_at":"2017-12-08T21:24:30Z","pushed_at":"2017-12-08T16:11:44Z","git_url":"git://github.com/atom/atom.git","ssh_url":"git@github.com:atom/atom.git","clone_url":"https://github.com/atom/atom.git","svn_url":"https://github.com/atom/atom","homepage":"https://atom.io","size":295583,"stargazers_count":42200,"watchers_count":42200,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8088,"mirror_url":null,"archived":false,"open_issues_count":961,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8088,"open_issues":961,"watchers":42200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/16074"},"html":{"href":"https://github.com/atom/atom/pull/16074"},"issue":{"href":"https://api.github.com/repos/atom/atom/issues/16074"},"comments":{"href":"https://api.github.com/repos/atom/atom/issues/16074/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom/pulls/16074/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/atom/pulls/16074/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom/statuses/fe4df885d650724e5f11ccbc024c518a6d34d0fd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maxbrunsfeld"}}