{"action":"created","issue":{"url":"https://api.github.com/repos/scanse/sweep-sdk/issues/78","repository_url":"https://api.github.com/repos/scanse/sweep-sdk","labels_url":"https://api.github.com/repos/scanse/sweep-sdk/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/scanse/sweep-sdk/issues/78/comments","events_url":"https://api.github.com/repos/scanse/sweep-sdk/issues/78/events","html_url":"https://github.com/scanse/sweep-sdk/pull/78","id":225317887,"number":78,"title":"Refactors Queue","user":{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars0.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-30T10:12:28Z","updated_at":"2017-05-01T18:15:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scanse/sweep-sdk/pulls/78","html_url":"https://github.com/scanse/sweep-sdk/pull/78","diff_url":"https://github.com/scanse/sweep-sdk/pull/78.diff","patch_url":"https://github.com/scanse/sweep-sdk/pull/78.patch"},"body":"- puts queue impl. into `queue.h`\r\n- makes it generic on its value type\r\n- marks thread safe members `mutable`\r\n- no need for a `unique_ptr<queue>`, just store by value"},"comment":{"url":"https://api.github.com/repos/scanse/sweep-sdk/issues/comments/298392102","html_url":"https://github.com/scanse/sweep-sdk/pull/78#issuecomment-298392102","issue_url":"https://api.github.com/repos/scanse/sweep-sdk/issues/78","id":298392102,"user":{"login":"dcyoung","id":7978433,"avatar_url":"https://avatars0.githubusercontent.com/u/7978433?v=3","gravatar_id":"","url":"https://api.github.com/users/dcyoung","html_url":"https://github.com/dcyoung","followers_url":"https://api.github.com/users/dcyoung/followers","following_url":"https://api.github.com/users/dcyoung/following{/other_user}","gists_url":"https://api.github.com/users/dcyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/dcyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcyoung/subscriptions","organizations_url":"https://api.github.com/users/dcyoung/orgs","repos_url":"https://api.github.com/users/dcyoung/repos","events_url":"https://api.github.com/users/dcyoung/events{/privacy}","received_events_url":"https://api.github.com/users/dcyoung/received_events","type":"User","site_admin":false},"created_at":"2017-05-01T18:15:49Z","updated_at":"2017-05-01T18:15:49Z","body":"I'll build this now and give it a proper review. Should we aim to change how we specify queue size as well, perhaps another version of `start_scanning(int max_queue_size)` that allows users to specify the max queue size? Or should we leave that for a later PR?"}}
{"actor":{"display_login":"dcyoung"}}