{"action":"created","comment":{"url":"https://api.github.com/repos/rathena/rathena/pulls/comments/125329391","pull_request_review_id":47707387,"id":125329391,"diff_hunk":"@@ -10862,15 +10921,60 @@ int status_change_start(struct block_list* src, struct block_list* bl,enum sc_ty\n \t\tcase SC_SHRIMP:\n \t\t\tval2 = 10; // BATK%, MATK%\n \t\t\tbreak;\n-\t\tcase SC_FRESHSHRIMP:\n-\t\t\tval4 = tick / (10000 - ((val1 - 1) * 1000));\n-\t\t\ttick_time = 10000 - ((val1 - 1) * 1000);\n-\t\t\tif (val4 <= 0) // Prevents a negeative value from happening\n-\t\t\t\tval4 = 0;\n+\t\tcase SC_FRESHSHRIMP: {\n+\t\t\t\tint min = 0, max = 0;\n+\n+#ifdef RENEWAL\n+\t\t\t\tmin = max = status_base_matk(src, status, status_get_lv(src));\n+\t\t\t\tif (status->rhw.matk > 0) {\n+\t\t\t\t\tint wMatk, variance;\n+\n+\t\t\t\t\twMatk = status->rhw.matk;\n+\t\t\t\t\tvariance = wMatk * status->rhw.wlv / 10;\n+\t\t\t\t\tmin += wMatk - variance;\n+\t\t\t\t\tmax += wMatk + variance;\n+\t\t\t\t}\n+#endif\n+\n+\t\t\t\tif (sd && sd->right_weapon.overrefine > 0) {\n+\t\t\t\t\tmin++;\n+\t\t\t\t\tmax += sd->right_weapon.overrefine - 1;\n+\t\t\t\t}\n+\n+\t\t\t\tif (max > min)\n+\t\t\t\t\tval2 += min + rnd() % (max - min) + 178; // Heal\n+\t\t\t\telse\n+\t\t\t\t\tval2 += min + 178; // Heal\n+","path":"src/map/status.c","position":368,"original_position":368,"commit_id":"8af14b6ca34a1dd380f093221c74bf742ffb0427","original_commit_id":"8af14b6ca34a1dd380f093221c74bf742ffb0427","user":{"login":"Lemongrass3110","id":3517879,"avatar_url":"https://avatars1.githubusercontent.com/u/3517879?v=3","gravatar_id":"","url":"https://api.github.com/users/Lemongrass3110","html_url":"https://github.com/Lemongrass3110","followers_url":"https://api.github.com/users/Lemongrass3110/followers","following_url":"https://api.github.com/users/Lemongrass3110/following{/other_user}","gists_url":"https://api.github.com/users/Lemongrass3110/gists{/gist_id}","starred_url":"https://api.github.com/users/Lemongrass3110/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lemongrass3110/subscriptions","organizations_url":"https://api.github.com/users/Lemongrass3110/orgs","repos_url":"https://api.github.com/users/Lemongrass3110/repos","events_url":"https://api.github.com/users/Lemongrass3110/events{/privacy}","received_events_url":"https://api.github.com/users/Lemongrass3110/received_events","type":"User","site_admin":false},"body":"```\r\nval2 += min + 178;\r\n\r\nif( max > min )\r\n    val2 += rnd() % (max-min); \r\n```","created_at":"2017-07-03T16:57:31Z","updated_at":"2017-07-03T17:02:43Z","html_url":"https://github.com/rathena/rathena/pull/1965#discussion_r125329391","pull_request_url":"https://api.github.com/repos/rathena/rathena/pulls/1965","_links":{"self":{"href":"https://api.github.com/repos/rathena/rathena/pulls/comments/125329391"},"html":{"href":"https://github.com/rathena/rathena/pull/1965#discussion_r125329391"},"pull_request":{"href":"https://api.github.com/repos/rathena/rathena/pulls/1965"}}},"pull_request":{"url":"https://api.github.com/repos/rathena/rathena/pulls/1965","id":106439664,"html_url":"https://github.com/rathena/rathena/pull/1965","diff_url":"https://github.com/rathena/rathena/pull/1965.diff","patch_url":"https://github.com/rathena/rathena/pull/1965.patch","issue_url":"https://api.github.com/repos/rathena/rathena/issues/1965","number":1965,"state":"open","locked":false,"title":"Updated Summoner class","user":{"login":"aleos89","id":3521753,"avatar_url":"https://avatars0.githubusercontent.com/u/3521753?v=3","gravatar_id":"","url":"https://api.github.com/users/aleos89","html_url":"https://github.com/aleos89","followers_url":"https://api.github.com/users/aleos89/followers","following_url":"https://api.github.com/users/aleos89/following{/other_user}","gists_url":"https://api.github.com/users/aleos89/gists{/gist_id}","starred_url":"https://api.github.com/users/aleos89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleos89/subscriptions","organizations_url":"https://api.github.com/users/aleos89/orgs","repos_url":"https://api.github.com/users/aleos89/repos","events_url":"https://api.github.com/users/aleos89/events{/privacy}","received_events_url":"https://api.github.com/users/aleos89/received_events","type":"User","site_admin":false},"body":"* **Addressed Issue(s)**: #1865\r\n\r\n* **Server Mode**: Renewal\r\n\r\n* **Description of Pull Request**: \r\n  * Added the missing Summoner skills.\r\n  * Information based on kRO patch notes.\r\n    * http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=1987966&curpage=1\r\n  * Updated previously implemented skills to better mimic official behavior.\r\nThanks to @RagnarokNova, Fyrus, and Jet for their hard work on gathering the information!\r\n\r\nTODO:\r\n- [x] Spirit of Life damage bonus.\r\n- [x] Spirit of Land, Hiss, and Chattering walk speed bonus.\r\n- [x] Spirit of Land + Catnip Meteor casting SVSP on magic damage success rate.\r\n- [x] Spirit of Sea + Tuna Party armor increase.\r\n- [x] Scratch bleed success rate and duration.\r\n- [ ] Scar of Tarou stun and bite success rate and duration.\r\n- [x] Bite Scar Max HP% damage rate.\r\n- [ ] Power of Flock freeze success rate and duration.\r\n- [x] Power of Flock fear success rate and duration.\r\n- [x] Need the success chance for the double attack skills (Picky Peck, Scratch, Scar of Tarou, and Stem Spear).\r\n- [ ] Fresh Shrimp heal rate.","created_at":"2017-02-16T01:52:17Z","updated_at":"2017-07-03T17:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9074c4f77aad33b132ede5167538c50abaca59c4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rathena/rathena/pulls/1965/commits","review_comments_url":"https://api.github.com/repos/rathena/rathena/pulls/1965/comments","review_comment_url":"https://api.github.com/repos/rathena/rathena/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rathena/rathena/issues/1965/comments","statuses_url":"https://api.github.com/repos/rathena/rathena/statuses/8af14b6ca34a1dd380f093221c74bf742ffb0427","head":{"label":"rathena:update/summoner_expanded","ref":"update/summoner_expanded","sha":"8af14b6ca34a1dd380f093221c74bf742ffb0427","user":{"login":"rathena","id":1776606,"avatar_url":"https://avatars1.githubusercontent.com/u/1776606?v=3","gravatar_id":"","url":"https://api.github.com/users/rathena","html_url":"https://github.com/rathena","followers_url":"https://api.github.com/users/rathena/followers","following_url":"https://api.github.com/users/rathena/following{/other_user}","gists_url":"https://api.github.com/users/rathena/gists{/gist_id}","starred_url":"https://api.github.com/users/rathena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathena/subscriptions","organizations_url":"https://api.github.com/users/rathena/orgs","repos_url":"https://api.github.com/users/rathena/repos","events_url":"https://api.github.com/users/rathena/events{/privacy}","received_events_url":"https://api.github.com/users/rathena/received_events","type":"Organization","site_admin":false},"repo":{"id":11489037,"name":"rathena","full_name":"rathena/rathena","owner":{"login":"rathena","id":1776606,"avatar_url":"https://avatars1.githubusercontent.com/u/1776606?v=3","gravatar_id":"","url":"https://api.github.com/users/rathena","html_url":"https://github.com/rathena","followers_url":"https://api.github.com/users/rathena/followers","following_url":"https://api.github.com/users/rathena/following{/other_user}","gists_url":"https://api.github.com/users/rathena/gists{/gist_id}","starred_url":"https://api.github.com/users/rathena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathena/subscriptions","organizations_url":"https://api.github.com/users/rathena/orgs","repos_url":"https://api.github.com/users/rathena/repos","events_url":"https://api.github.com/users/rathena/events{/privacy}","received_events_url":"https://api.github.com/users/rathena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rathena/rathena","description":"rAthena is an open-source cross-platform MMORPG server.","fork":false,"url":"https://api.github.com/repos/rathena/rathena","forks_url":"https://api.github.com/repos/rathena/rathena/forks","keys_url":"https://api.github.com/repos/rathena/rathena/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rathena/rathena/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rathena/rathena/teams","hooks_url":"https://api.github.com/repos/rathena/rathena/hooks","issue_events_url":"https://api.github.com/repos/rathena/rathena/issues/events{/number}","events_url":"https://api.github.com/repos/rathena/rathena/events","assignees_url":"https://api.github.com/repos/rathena/rathena/assignees{/user}","branches_url":"https://api.github.com/repos/rathena/rathena/branches{/branch}","tags_url":"https://api.github.com/repos/rathena/rathena/tags","blobs_url":"https://api.github.com/repos/rathena/rathena/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rathena/rathena/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rathena/rathena/git/refs{/sha}","trees_url":"https://api.github.com/repos/rathena/rathena/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rathena/rathena/statuses/{sha}","languages_url":"https://api.github.com/repos/rathena/rathena/languages","stargazers_url":"https://api.github.com/repos/rathena/rathena/stargazers","contributors_url":"https://api.github.com/repos/rathena/rathena/contributors","subscribers_url":"https://api.github.com/repos/rathena/rathena/subscribers","subscription_url":"https://api.github.com/repos/rathena/rathena/subscription","commits_url":"https://api.github.com/repos/rathena/rathena/commits{/sha}","git_commits_url":"https://api.github.com/repos/rathena/rathena/git/commits{/sha}","comments_url":"https://api.github.com/repos/rathena/rathena/comments{/number}","issue_comment_url":"https://api.github.com/repos/rathena/rathena/issues/comments{/number}","contents_url":"https://api.github.com/repos/rathena/rathena/contents/{+path}","compare_url":"https://api.github.com/repos/rathena/rathena/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rathena/rathena/merges","archive_url":"https://api.github.com/repos/rathena/rathena/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rathena/rathena/downloads","issues_url":"https://api.github.com/repos/rathena/rathena/issues{/number}","pulls_url":"https://api.github.com/repos/rathena/rathena/pulls{/number}","milestones_url":"https://api.github.com/repos/rathena/rathena/milestones{/number}","notifications_url":"https://api.github.com/repos/rathena/rathena/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rathena/rathena/labels{/name}","releases_url":"https://api.github.com/repos/rathena/rathena/releases{/id}","deployments_url":"https://api.github.com/repos/rathena/rathena/deployments","created_at":"2013-07-17T22:19:43Z","updated_at":"2017-07-03T05:20:20Z","pushed_at":"2017-07-03T06:36:56Z","git_url":"git://github.com/rathena/rathena.git","ssh_url":"git@github.com:rathena/rathena.git","clone_url":"https://github.com/rathena/rathena.git","svn_url":"https://github.com/rathena/rathena","homepage":"https://rathena.org/board/","size":136746,"stargazers_count":471,"watchers_count":471,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":626,"mirror_url":null,"open_issues_count":231,"forks":626,"open_issues":231,"watchers":471,"default_branch":"master"}},"base":{"label":"rathena:master","ref":"master","sha":"fa24b2134df5eadbab34e48369133187ffb63dd4","user":{"login":"rathena","id":1776606,"avatar_url":"https://avatars1.githubusercontent.com/u/1776606?v=3","gravatar_id":"","url":"https://api.github.com/users/rathena","html_url":"https://github.com/rathena","followers_url":"https://api.github.com/users/rathena/followers","following_url":"https://api.github.com/users/rathena/following{/other_user}","gists_url":"https://api.github.com/users/rathena/gists{/gist_id}","starred_url":"https://api.github.com/users/rathena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathena/subscriptions","organizations_url":"https://api.github.com/users/rathena/orgs","repos_url":"https://api.github.com/users/rathena/repos","events_url":"https://api.github.com/users/rathena/events{/privacy}","received_events_url":"https://api.github.com/users/rathena/received_events","type":"Organization","site_admin":false},"repo":{"id":11489037,"name":"rathena","full_name":"rathena/rathena","owner":{"login":"rathena","id":1776606,"avatar_url":"https://avatars1.githubusercontent.com/u/1776606?v=3","gravatar_id":"","url":"https://api.github.com/users/rathena","html_url":"https://github.com/rathena","followers_url":"https://api.github.com/users/rathena/followers","following_url":"https://api.github.com/users/rathena/following{/other_user}","gists_url":"https://api.github.com/users/rathena/gists{/gist_id}","starred_url":"https://api.github.com/users/rathena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rathena/subscriptions","organizations_url":"https://api.github.com/users/rathena/orgs","repos_url":"https://api.github.com/users/rathena/repos","events_url":"https://api.github.com/users/rathena/events{/privacy}","received_events_url":"https://api.github.com/users/rathena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rathena/rathena","description":"rAthena is an open-source cross-platform MMORPG server.","fork":false,"url":"https://api.github.com/repos/rathena/rathena","forks_url":"https://api.github.com/repos/rathena/rathena/forks","keys_url":"https://api.github.com/repos/rathena/rathena/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rathena/rathena/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rathena/rathena/teams","hooks_url":"https://api.github.com/repos/rathena/rathena/hooks","issue_events_url":"https://api.github.com/repos/rathena/rathena/issues/events{/number}","events_url":"https://api.github.com/repos/rathena/rathena/events","assignees_url":"https://api.github.com/repos/rathena/rathena/assignees{/user}","branches_url":"https://api.github.com/repos/rathena/rathena/branches{/branch}","tags_url":"https://api.github.com/repos/rathena/rathena/tags","blobs_url":"https://api.github.com/repos/rathena/rathena/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rathena/rathena/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rathena/rathena/git/refs{/sha}","trees_url":"https://api.github.com/repos/rathena/rathena/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rathena/rathena/statuses/{sha}","languages_url":"https://api.github.com/repos/rathena/rathena/languages","stargazers_url":"https://api.github.com/repos/rathena/rathena/stargazers","contributors_url":"https://api.github.com/repos/rathena/rathena/contributors","subscribers_url":"https://api.github.com/repos/rathena/rathena/subscribers","subscription_url":"https://api.github.com/repos/rathena/rathena/subscription","commits_url":"https://api.github.com/repos/rathena/rathena/commits{/sha}","git_commits_url":"https://api.github.com/repos/rathena/rathena/git/commits{/sha}","comments_url":"https://api.github.com/repos/rathena/rathena/comments{/number}","issue_comment_url":"https://api.github.com/repos/rathena/rathena/issues/comments{/number}","contents_url":"https://api.github.com/repos/rathena/rathena/contents/{+path}","compare_url":"https://api.github.com/repos/rathena/rathena/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rathena/rathena/merges","archive_url":"https://api.github.com/repos/rathena/rathena/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rathena/rathena/downloads","issues_url":"https://api.github.com/repos/rathena/rathena/issues{/number}","pulls_url":"https://api.github.com/repos/rathena/rathena/pulls{/number}","milestones_url":"https://api.github.com/repos/rathena/rathena/milestones{/number}","notifications_url":"https://api.github.com/repos/rathena/rathena/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rathena/rathena/labels{/name}","releases_url":"https://api.github.com/repos/rathena/rathena/releases{/id}","deployments_url":"https://api.github.com/repos/rathena/rathena/deployments","created_at":"2013-07-17T22:19:43Z","updated_at":"2017-07-03T05:20:20Z","pushed_at":"2017-07-03T06:36:56Z","git_url":"git://github.com/rathena/rathena.git","ssh_url":"git@github.com:rathena/rathena.git","clone_url":"https://github.com/rathena/rathena.git","svn_url":"https://github.com/rathena/rathena","homepage":"https://rathena.org/board/","size":136746,"stargazers_count":471,"watchers_count":471,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":626,"mirror_url":null,"open_issues_count":231,"forks":626,"open_issues":231,"watchers":471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rathena/rathena/pulls/1965"},"html":{"href":"https://github.com/rathena/rathena/pull/1965"},"issue":{"href":"https://api.github.com/repos/rathena/rathena/issues/1965"},"comments":{"href":"https://api.github.com/repos/rathena/rathena/issues/1965/comments"},"review_comments":{"href":"https://api.github.com/repos/rathena/rathena/pulls/1965/comments"},"review_comment":{"href":"https://api.github.com/repos/rathena/rathena/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rathena/rathena/pulls/1965/commits"},"statuses":{"href":"https://api.github.com/repos/rathena/rathena/statuses/8af14b6ca34a1dd380f093221c74bf742ffb0427"}}}}
{"actor":{"display_login":"Lemongrass3110"}}