{"action":"created","issue":{"url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/332","repository_url":"https://api.github.com/repos/lucyparsons/OpenOversight","labels_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/332/comments","events_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/332/events","html_url":"https://github.com/lucyparsons/OpenOversight/pull/332","id":282665934,"number":332,"title":"322 homepage design revamp","user":{"login":"furfreemi","id":9063936,"avatar_url":"https://avatars2.githubusercontent.com/u/9063936?v=4","gravatar_id":"","url":"https://api.github.com/users/furfreemi","html_url":"https://github.com/furfreemi","followers_url":"https://api.github.com/users/furfreemi/followers","following_url":"https://api.github.com/users/furfreemi/following{/other_user}","gists_url":"https://api.github.com/users/furfreemi/gists{/gist_id}","starred_url":"https://api.github.com/users/furfreemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furfreemi/subscriptions","organizations_url":"https://api.github.com/users/furfreemi/orgs","repos_url":"https://api.github.com/users/furfreemi/repos","events_url":"https://api.github.com/users/furfreemi/events{/privacy}","received_events_url":"https://api.github.com/users/furfreemi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-17T02:56:31Z","updated_at":"2017-12-17T03:24:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/lucyparsons/OpenOversight/pulls/332","html_url":"https://github.com/lucyparsons/OpenOversight/pull/332","diff_url":"https://github.com/lucyparsons/OpenOversight/pull/332.diff","patch_url":"https://github.com/lucyparsons/OpenOversight/pull/332.patch"},"body":"## Status\r\nIn progress: moves towards comp but isn't completed\r\n\r\n## Description of Changes\r\nAddresses #322 .\r\n\r\nChanges proposed in this pull request:\r\n - Styling updates for general button look and feel\r\n - Formatting changes to homepage to move towards comp\r\n - Formatting changes to volunteer info page to move towards comp\r\n - Enable login on volunteer page (unsure on this one: feels weird pulling auth stuff in to main. Should all login functionality be contained in auth? If so, can easily pull out login form for now and simply link to existing login page from Volunteer section)\r\n\r\n## Notes for Deployment\r\n\r\n## Screenshots (if appropriate)\r\nhome page:\r\n![prev_home](https://user-images.githubusercontent.com/9063936/34076175-d42d03fa-e2a2-11e7-8e79-52ea99bb32d4.jpg)\r\n\r\nvolunteer page:\r\n![prev_volunteer](https://user-images.githubusercontent.com/9063936/34076188-59537b7c-e2a3-11e7-9ee1-ad62a747810d.jpg)\r\n\r\n## Tests and linting\r\n \r\n- [x] I have rebased my changes on current `develop`\r\n \r\n- [x] pytests pass in the development environment on my local machine\r\n \r\n- [x] `flake8` checks pass\r\n"},"comment":{"url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/comments/352228959","html_url":"https://github.com/lucyparsons/OpenOversight/pull/332#issuecomment-352228959","issue_url":"https://api.github.com/repos/lucyparsons/OpenOversight/issues/332","id":352228959,"user":{"login":"r4v5","id":789416,"avatar_url":"https://avatars3.githubusercontent.com/u/789416?v=4","gravatar_id":"","url":"https://api.github.com/users/r4v5","html_url":"https://github.com/r4v5","followers_url":"https://api.github.com/users/r4v5/followers","following_url":"https://api.github.com/users/r4v5/following{/other_user}","gists_url":"https://api.github.com/users/r4v5/gists{/gist_id}","starred_url":"https://api.github.com/users/r4v5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r4v5/subscriptions","organizations_url":"https://api.github.com/users/r4v5/orgs","repos_url":"https://api.github.com/users/r4v5/repos","events_url":"https://api.github.com/users/r4v5/events{/privacy}","received_events_url":"https://api.github.com/users/r4v5/received_events","type":"User","site_admin":false},"created_at":"2017-12-17T03:24:45Z","updated_at":"2017-12-17T03:24:45Z","author_association":"CONTRIBUTOR","body":"Holy cow! I'm gonna take a closer look at the changes here later and give some more specific feedback (hopefully tomorrow) but I wanted to thank you for the work you've done here already. It's a very strong start!\r\n\r\nRe: your question in #322 (\"I might have missed a strings file when I looked, but if not are you all just keeping all the text in-line for now, vs planning to translate stuff in the immediate future?\") translation is important, and definitely something we want to do sooner than later for at least the home page and basic citizen flow (the volunteer flow probably can go later). That said, I won't ask that you do it as part of this work unless you want to :)"}}
{"actor":{"display_login":"r4v5"}}