{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/18913","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18913/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18913/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18913/events","html_url":"https://github.com/joomla/joomla-cms/pull/18913","id":277717183,"number":18913,"title":"Plugin Modal: Apply (save) button + normalize","user":{"login":"Ruud68","id":2733197,"avatar_url":"https://avatars1.githubusercontent.com/u/2733197?v=4","gravatar_id":"","url":"https://api.github.com/users/Ruud68","html_url":"https://github.com/Ruud68","followers_url":"https://api.github.com/users/Ruud68/followers","following_url":"https://api.github.com/users/Ruud68/following{/other_user}","gists_url":"https://api.github.com/users/Ruud68/gists{/gist_id}","starred_url":"https://api.github.com/users/Ruud68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ruud68/subscriptions","organizations_url":"https://api.github.com/users/Ruud68/orgs","repos_url":"https://api.github.com/users/Ruud68/repos","events_url":"https://api.github.com/users/Ruud68/events{/privacy}","received_events_url":"https://api.github.com/users/Ruud68/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-29T11:19:34Z","updated_at":"2017-11-30T20:06:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/18913","html_url":"https://github.com/joomla/joomla-cms/pull/18913","diff_url":"https://github.com/joomla/joomla-cms/pull/18913.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/18913.patch"},"body":"Pull Request for Issue # .\r\n\r\n### Summary of Changes\r\nThis PR normalizes the plugin modal as currently used in com_redirect. It also adds a [save] button to the modal footer.\r\n\r\n\r\n### Testing Instructions\r\n1. normalization:\r\n1.1 disable the plg_redirect\r\n1.2 go to component / Redirect\r\n1.3 in the error message click on the link: \"Redirect System Plugin\"\r\n[A]\r\n2. save button\r\n2.1 change plugin status in modal to 'enabled'\r\n2.2 change Collect URLs to 'disabled'\r\n2.3 click on [Save] button (the modal should stay open)\r\n2.4 click on [Close] button\r\n[B] \r\n\r\n### Expected result\r\n[A] The modal should open and should be same size / form / shape / etc. as other modals (like edit article in menu single article\r\n\r\n[B] after closing the modal, the com_redirect page should refresh and the error message must be replaced with a Notice 'The Redirect Plugin is enabled. The 'Collect URLs' option in the Redirect System Plugin is disabled. Error page URLs will not be collected by this component.'\r\nIf you did not change the Collect URLs vanlue to 'disabled' there will be no warning / notice.\r\n\r\n\r\n### Actual result\r\n[A] modal is small (width and heigth) the other modals\r\n[B] There is no [Save] button, just a [Close]  and [Save & Close] button\r\n\r\n\r\n### Documentation Changes Required\r\nNone\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/348305196","html_url":"https://github.com/joomla/joomla-cms/pull/18913#issuecomment-348305196","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18913","id":348305196,"user":{"login":"Ruud68","id":2733197,"avatar_url":"https://avatars1.githubusercontent.com/u/2733197?v=4","gravatar_id":"","url":"https://api.github.com/users/Ruud68","html_url":"https://github.com/Ruud68","followers_url":"https://api.github.com/users/Ruud68/followers","following_url":"https://api.github.com/users/Ruud68/following{/other_user}","gists_url":"https://api.github.com/users/Ruud68/gists{/gist_id}","starred_url":"https://api.github.com/users/Ruud68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ruud68/subscriptions","organizations_url":"https://api.github.com/users/Ruud68/orgs","repos_url":"https://api.github.com/users/Ruud68/repos","events_url":"https://api.github.com/users/Ruud68/events{/privacy}","received_events_url":"https://api.github.com/users/Ruud68/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T20:06:01Z","updated_at":"2017-11-30T20:06:01Z","author_association":"CONTRIBUTOR","body":"Thanks for testing @ladyjer :)<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/18913\">issues.joomla.org/tracker/joomla-cms/18913</a>.</sub>"}}
{"actor":{"display_login":"Ruud68"}}