{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/119442912","pull_request_review_id":41323090,"id":119442912,"diff_hunk":"@@ -138,4 +138,14 @@ install(TARGETS px4 DESTINATION ${CMAKE_INSTALL_BINDIR})\n install(DIRECTORY ${PROJECT_SOURCE_DIR}/ROMFS DESTINATION ${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})\n install(DIRECTORY ${PROJECT_SOURCE_DIR}/posix-configs DESTINATION ${CMAKE_INSTALL_DATADIR}/${PROJECT_NAME})\n \n+FIND_PROGRAM(STRIP_TOOL \"arm-linux-gnueabihf-strip\")\n+\n+add_custom_target(strip\n+\t\t\tDEPENDS px4.stripped\n+)\n+\n+add_custom_command(OUTPUT px4.stripped\n+\t\t\tCOMMAND arm-linux-gnueabihf-strip -R .comment -R .gnu.version $<TARGET_FILE:px4>","path":"src/firmware/posix/CMakeLists.txt","position":11,"original_position":11,"commit_id":"e717b673757d93d5ac453f0cb3f08c6509440655","original_commit_id":"e717b673757d93d5ac453f0cb3f08c6509440655","user":{"login":"dagar","id":84712,"avatar_url":"https://avatars0.githubusercontent.com/u/84712?v=3","gravatar_id":"","url":"https://api.github.com/users/dagar","html_url":"https://github.com/dagar","followers_url":"https://api.github.com/users/dagar/followers","following_url":"https://api.github.com/users/dagar/following{/other_user}","gists_url":"https://api.github.com/users/dagar/gists{/gist_id}","starred_url":"https://api.github.com/users/dagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagar/subscriptions","organizations_url":"https://api.github.com/users/dagar/orgs","repos_url":"https://api.github.com/users/dagar/repos","events_url":"https://api.github.com/users/dagar/events{/privacy}","received_events_url":"https://api.github.com/users/dagar/received_events","type":"User","site_admin":false},"body":"then use ${STRIP_TOOL} instead of arm-linux-gnueabihf-strip","created_at":"2017-05-31T18:52:42Z","updated_at":"2017-05-31T18:52:42Z","html_url":"https://github.com/PX4/Firmware/pull/7248#discussion_r119442912","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/7248","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/119442912"},"html":{"href":"https://github.com/PX4/Firmware/pull/7248#discussion_r119442912"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/7248"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/7248","id":120689192,"html_url":"https://github.com/PX4/Firmware/pull/7248","diff_url":"https://github.com/PX4/Firmware/pull/7248.diff","patch_url":"https://github.com/PX4/Firmware/pull/7248.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/7248","number":7248,"state":"open","locked":false,"title":"[WIP] Bebop/RPi Toolchain Update v2","user":{"login":"nicolaerosia","id":4127983,"avatar_url":"https://avatars1.githubusercontent.com/u/4127983?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaerosia","html_url":"https://github.com/nicolaerosia","followers_url":"https://api.github.com/users/nicolaerosia/followers","following_url":"https://api.github.com/users/nicolaerosia/following{/other_user}","gists_url":"https://api.github.com/users/nicolaerosia/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaerosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaerosia/subscriptions","organizations_url":"https://api.github.com/users/nicolaerosia/orgs","repos_url":"https://api.github.com/users/nicolaerosia/repos","events_url":"https://api.github.com/users/nicolaerosia/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaerosia/received_events","type":"User","site_admin":false},"body":"This is a continuation of https://github.com/PX4/Firmware/pull/6528\r\n\r\nYou will need to set `PX4_CXX_COMPILER` to a valid C++ compiler\r\n\r\nGCC Testing:\r\na. get rpi-tools, `git clone https://github.com/raspberrypi/tools`\r\n```\r\nexport PX4_CXX_COMPILER=<path>/tools/arm-bcm2708/gcc-linaro-arm-linux-gnueabihf-raspbian-x64/bin/arm-linux-gnueabihf-g++\r\nexport PX4_SOURCE=<px4-source>\r\n```\r\n\r\nb. get a different compiler, like 5.3.1 from Linaro: https://releases.linaro.org/components/toolchain/binaries/5.3-2016.05/arm-linux-gnueabihf/gcc-linaro-5.3.1-2016.05-x86_64_arm-linux-gnueabihf.tar.xz\r\n\r\n```\r\nexport PX4_CXX_COMPILER=<gcc-path>/bin/arm-linux-gnueabihf-g++\r\nexport PX4_SOURCE=<px4-source>\r\n```\r\n\r\n```\r\ncmake \\\r\n-G\"Unix Makefiles\" \\\r\n-DCONFIG=posix_rpi_cross \\\r\n${PX4_SOURCE}\r\n\r\nmake\r\n```\r\n\r\nClang Testing:\r\nYou will need a GCC cross-compiler!\r\na. get prebuild clang, http://releases.llvm.org/download.html\r\n```\r\nwget http://releases.llvm.org/3.9.0/clang+llvm-3.9.0-x86_64-fedora23.tar.xz\r\n```\r\nunpack\r\n\r\nCreate symlinks for clang and clang++ in gcc cross-compiler dir:\r\n```\r\nln -s <clang-path>/bin/clang <gcc-path>/bin/clang\r\nln -s <clang-path>/bin/clang++ <gcc-path>/bin/clang++\r\nexport PX4_CXX_COMPILER=<gcc-path>/bin/clang++\r\n\r\nexport PX4_SOURCE=<px4-source>\r\n\r\ncmake \\\r\n-G\"Unix Makefiles\" \\\r\n-DCONFIG=posix_rpi_cross \\\r\n${PX4_SOURCE}\r\n\r\nmake\r\n```\r\n\r\n@mhkabir @dagar could you please take a look?","created_at":"2017-05-15T20:38:08Z","updated_at":"2017-05-31T18:52:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56dbd8df5e62831a900a91c9b9299c50167e3af1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mhkabir","id":5557676,"avatar_url":"https://avatars2.githubusercontent.com/u/5557676?v=3","gravatar_id":"","url":"https://api.github.com/users/mhkabir","html_url":"https://github.com/mhkabir","followers_url":"https://api.github.com/users/mhkabir/followers","following_url":"https://api.github.com/users/mhkabir/following{/other_user}","gists_url":"https://api.github.com/users/mhkabir/gists{/gist_id}","starred_url":"https://api.github.com/users/mhkabir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhkabir/subscriptions","organizations_url":"https://api.github.com/users/mhkabir/orgs","repos_url":"https://api.github.com/users/mhkabir/repos","events_url":"https://api.github.com/users/mhkabir/events{/privacy}","received_events_url":"https://api.github.com/users/mhkabir/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/PX4/Firmware/milestones/23","html_url":"https://github.com/PX4/Firmware/milestone/23","labels_url":"https://api.github.com/repos/PX4/Firmware/milestones/23/labels","id":1911500,"number":23,"title":"Release v1.7.0","description":"Maintenance release of the 1.0 release schedule.","creator":{"login":"LorenzMeier","id":1208119,"avatar_url":"https://avatars0.githubusercontent.com/u/1208119?v=3","gravatar_id":"","url":"https://api.github.com/users/LorenzMeier","html_url":"https://github.com/LorenzMeier","followers_url":"https://api.github.com/users/LorenzMeier/followers","following_url":"https://api.github.com/users/LorenzMeier/following{/other_user}","gists_url":"https://api.github.com/users/LorenzMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/LorenzMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LorenzMeier/subscriptions","organizations_url":"https://api.github.com/users/LorenzMeier/orgs","repos_url":"https://api.github.com/users/LorenzMeier/repos","events_url":"https://api.github.com/users/LorenzMeier/events{/privacy}","received_events_url":"https://api.github.com/users/LorenzMeier/received_events","type":"User","site_admin":false},"open_issues":79,"closed_issues":10,"state":"open","created_at":"2016-07-29T11:56:06Z","updated_at":"2017-05-30T13:19:30Z","due_on":"2017-06-14T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/7248/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/7248/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/7248/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/e717b673757d93d5ac453f0cb3f08c6509440655","head":{"label":"nicolaerosia:toolchain_update","ref":"toolchain_update","sha":"e717b673757d93d5ac453f0cb3f08c6509440655","user":{"login":"nicolaerosia","id":4127983,"avatar_url":"https://avatars1.githubusercontent.com/u/4127983?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaerosia","html_url":"https://github.com/nicolaerosia","followers_url":"https://api.github.com/users/nicolaerosia/followers","following_url":"https://api.github.com/users/nicolaerosia/following{/other_user}","gists_url":"https://api.github.com/users/nicolaerosia/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaerosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaerosia/subscriptions","organizations_url":"https://api.github.com/users/nicolaerosia/orgs","repos_url":"https://api.github.com/users/nicolaerosia/repos","events_url":"https://api.github.com/users/nicolaerosia/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaerosia/received_events","type":"User","site_admin":false},"repo":{"id":90952621,"name":"Firmware","full_name":"nicolaerosia/Firmware","owner":{"login":"nicolaerosia","id":4127983,"avatar_url":"https://avatars1.githubusercontent.com/u/4127983?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolaerosia","html_url":"https://github.com/nicolaerosia","followers_url":"https://api.github.com/users/nicolaerosia/followers","following_url":"https://api.github.com/users/nicolaerosia/following{/other_user}","gists_url":"https://api.github.com/users/nicolaerosia/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaerosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaerosia/subscriptions","organizations_url":"https://api.github.com/users/nicolaerosia/orgs","repos_url":"https://api.github.com/users/nicolaerosia/repos","events_url":"https://api.github.com/users/nicolaerosia/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaerosia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolaerosia/Firmware","description":"PX4 Pro Autopilot Software","fork":true,"url":"https://api.github.com/repos/nicolaerosia/Firmware","forks_url":"https://api.github.com/repos/nicolaerosia/Firmware/forks","keys_url":"https://api.github.com/repos/nicolaerosia/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolaerosia/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolaerosia/Firmware/teams","hooks_url":"https://api.github.com/repos/nicolaerosia/Firmware/hooks","issue_events_url":"https://api.github.com/repos/nicolaerosia/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/nicolaerosia/Firmware/events","assignees_url":"https://api.github.com/repos/nicolaerosia/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/nicolaerosia/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/nicolaerosia/Firmware/tags","blobs_url":"https://api.github.com/repos/nicolaerosia/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolaerosia/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolaerosia/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolaerosia/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolaerosia/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolaerosia/Firmware/languages","stargazers_url":"https://api.github.com/repos/nicolaerosia/Firmware/stargazers","contributors_url":"https://api.github.com/repos/nicolaerosia/Firmware/contributors","subscribers_url":"https://api.github.com/repos/nicolaerosia/Firmware/subscribers","subscription_url":"https://api.github.com/repos/nicolaerosia/Firmware/subscription","commits_url":"https://api.github.com/repos/nicolaerosia/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolaerosia/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolaerosia/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolaerosia/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolaerosia/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/nicolaerosia/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolaerosia/Firmware/merges","archive_url":"https://api.github.com/repos/nicolaerosia/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolaerosia/Firmware/downloads","issues_url":"https://api.github.com/repos/nicolaerosia/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/nicolaerosia/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolaerosia/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolaerosia/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolaerosia/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/nicolaerosia/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/nicolaerosia/Firmware/deployments","created_at":"2017-05-11T07:51:27Z","updated_at":"2017-05-11T07:51:39Z","pushed_at":"2017-05-31T18:41:47Z","git_url":"git://github.com/nicolaerosia/Firmware.git","ssh_url":"git@github.com:nicolaerosia/Firmware.git","clone_url":"https://github.com/nicolaerosia/Firmware.git","svn_url":"https://github.com/nicolaerosia/Firmware","homepage":"http://px4.io","size":87610,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"6201fb564166028e9742c13a2acd28bb45875a92","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars0.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars0.githubusercontent.com/u/2096014?v=3","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2017-05-31T16:46:38Z","pushed_at":"2017-05-31T18:41:49Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":88532,"stargazers_count":1122,"watchers_count":1122,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3451,"mirror_url":null,"open_issues_count":388,"forks":3451,"open_issues":388,"watchers":1122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/7248"},"html":{"href":"https://github.com/PX4/Firmware/pull/7248"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/7248"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/7248/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/7248/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/7248/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/e717b673757d93d5ac453f0cb3f08c6509440655"}}}}
{"actor":{"display_login":"dagar"}}