{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/154686817","pull_request_review_id":80886090,"id":154686817,"diff_hunk":"@@ -3,7 +3,7 @@\n         <stateless>\n             <bean-instance-pool-ref pool-name=\"slsb-strict-max-pool\"/>\n         </stateless>\n-        <stateful default-access-timeout=\"${prop.default-access-timeout:5000}\" cache-ref=\"distributable\" clustered-cache-ref=\"distributable\"/>\n+        <stateful default-access-timeout=\"${prop.default-access-timeout:5000}\" cache-ref=\"distributable\" clustered-cache-ref=\"distributable\" passivation-disabled-cache-ref=\"simple\"/>","path":"ejb3/src/test/resources/org/jboss/as/ejb3/subsystem/subsystem-ejb3-transform.xml","position":5,"original_position":5,"commit_id":"6a5edf610241db9fa0d9f50647d55394aa4e0d80","original_commit_id":"9ca254b6141e4ce3392a2803e14512103080d66a","user":{"login":"pferraro","id":352192,"avatar_url":"https://avatars2.githubusercontent.com/u/352192?v=4","gravatar_id":"","url":"https://api.github.com/users/pferraro","html_url":"https://github.com/pferraro","followers_url":"https://api.github.com/users/pferraro/followers","following_url":"https://api.github.com/users/pferraro/following{/other_user}","gists_url":"https://api.github.com/users/pferraro/gists{/gist_id}","starred_url":"https://api.github.com/users/pferraro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pferraro/subscriptions","organizations_url":"https://api.github.com/users/pferraro/orgs","repos_url":"https://api.github.com/users/pferraro/repos","events_url":"https://api.github.com/users/pferraro/events{/privacy}","received_events_url":"https://api.github.com/users/pferraro/received_events","type":"User","site_admin":false},"body":"@yersan What I mean is, I don't think there is anything logic in Ejb3TransformersTestCase that specifically checks that the transformation results for these attributes is correct - only that the transformation results in a valid/consistent model.","created_at":"2017-12-04T15:49:23Z","updated_at":"2017-12-04T15:49:23Z","html_url":"https://github.com/wildfly/wildfly/pull/10676#discussion_r154686817","pull_request_url":"https://api.github.com/repos/wildfly/wildfly/pulls/10676","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments/154686817"},"html":{"href":"https://github.com/wildfly/wildfly/pull/10676#discussion_r154686817"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/10676"}},"in_reply_to_id":154495892},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly/pulls/10676","id":154816070,"html_url":"https://github.com/wildfly/wildfly/pull/10676","diff_url":"https://github.com/wildfly/wildfly/pull/10676.diff","patch_url":"https://github.com/wildfly/wildfly/pull/10676.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly/issues/10676","number":10676,"state":"open","locked":false,"title":"[WFLY-9403] Unable to deploy clustered ejb in a mixed domain","user":{"login":"yersan","id":5951113,"avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"body":"A tentative solution for WFLY-9403, I still need some feedback on this issue, see my comments.\r\n\r\nIssue: https://issues.jboss.org/browse/WFLY-9403\r\nJBEAP Issue: https://issues.jboss.org/browse/JBEAP-13295\r\n","created_at":"2017-11-27T13:58:05Z","updated_at":"2017-12-04T15:49:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"668d2f689a62486043d636da0d49e57f1b7bacc7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly/pulls/10676/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly/pulls/10676/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly/issues/10676/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/6a5edf610241db9fa0d9f50647d55394aa4e0d80","head":{"label":"yersan:bugs/WFLY-9403","ref":"bugs/WFLY-9403","sha":"6a5edf610241db9fa0d9f50647d55394aa4e0d80","user":{"login":"yersan","id":5951113,"avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"repo":{"id":51616834,"name":"wildfly","full_name":"yersan/wildfly","owner":{"login":"yersan","id":5951113,"avatar_url":"https://avatars3.githubusercontent.com/u/5951113?v=4","gravatar_id":"","url":"https://api.github.com/users/yersan","html_url":"https://github.com/yersan","followers_url":"https://api.github.com/users/yersan/followers","following_url":"https://api.github.com/users/yersan/following{/other_user}","gists_url":"https://api.github.com/users/yersan/gists{/gist_id}","starred_url":"https://api.github.com/users/yersan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yersan/subscriptions","organizations_url":"https://api.github.com/users/yersan/orgs","repos_url":"https://api.github.com/users/yersan/repos","events_url":"https://api.github.com/users/yersan/events{/privacy}","received_events_url":"https://api.github.com/users/yersan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yersan/wildfly","description":"WildFly Application Server","fork":true,"url":"https://api.github.com/repos/yersan/wildfly","forks_url":"https://api.github.com/repos/yersan/wildfly/forks","keys_url":"https://api.github.com/repos/yersan/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yersan/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yersan/wildfly/teams","hooks_url":"https://api.github.com/repos/yersan/wildfly/hooks","issue_events_url":"https://api.github.com/repos/yersan/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/yersan/wildfly/events","assignees_url":"https://api.github.com/repos/yersan/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/yersan/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/yersan/wildfly/tags","blobs_url":"https://api.github.com/repos/yersan/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yersan/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yersan/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/yersan/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yersan/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/yersan/wildfly/languages","stargazers_url":"https://api.github.com/repos/yersan/wildfly/stargazers","contributors_url":"https://api.github.com/repos/yersan/wildfly/contributors","subscribers_url":"https://api.github.com/repos/yersan/wildfly/subscribers","subscription_url":"https://api.github.com/repos/yersan/wildfly/subscription","commits_url":"https://api.github.com/repos/yersan/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/yersan/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/yersan/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/yersan/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/yersan/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/yersan/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yersan/wildfly/merges","archive_url":"https://api.github.com/repos/yersan/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yersan/wildfly/downloads","issues_url":"https://api.github.com/repos/yersan/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/yersan/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/yersan/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/yersan/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yersan/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/yersan/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/yersan/wildfly/deployments","created_at":"2016-02-12T21:13:07Z","updated_at":"2016-02-12T21:13:49Z","pushed_at":"2017-12-04T14:24:56Z","git_url":"git://github.com/yersan/wildfly.git","ssh_url":"git@github.com:yersan/wildfly.git","clone_url":"https://github.com/yersan/wildfly.git","svn_url":"https://github.com/yersan/wildfly","homepage":"http://wildfly.org","size":178212,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"341bce7d37617fbad19a5e2b44dc60fff9b383fd","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":764708,"name":"wildfly","full_name":"wildfly/wildfly","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly","description":"WildFly Application Server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly","forks_url":"https://api.github.com/repos/wildfly/wildfly/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly/deployments","created_at":"2010-07-08T20:46:07Z","updated_at":"2017-12-04T08:04:07Z","pushed_at":"2017-12-04T15:30:01Z","git_url":"git://github.com/wildfly/wildfly.git","ssh_url":"git@github.com:wildfly/wildfly.git","clone_url":"https://github.com/wildfly/wildfly.git","svn_url":"https://github.com/wildfly/wildfly","homepage":"http://wildfly.org","size":178394,"stargazers_count":1910,"watchers_count":1910,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1753,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1753,"open_issues":62,"watchers":1910,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/10676"},"html":{"href":"https://github.com/wildfly/wildfly/pull/10676"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/10676"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly/issues/10676/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/10676/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly/pulls/10676/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly/statuses/6a5edf610241db9fa0d9f50647d55394aa4e0d80"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pferraro"}}