{"action":"created","comment":{"url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments/146584715","pull_request_review_id":71547408,"id":146584715,"diff_hunk":"@@ -1,49 +1,47 @@\n <?php\n-declare(strict_types = 1);\n+declare(strict_types=1);","path":"src/DsAmen/Organism/CoreEntity/Base/SubPresenter/BaseTitlePresenter.php","position":3,"original_position":3,"commit_id":"b7d30ae33da1910f9f6ad3e6859e78c13c6ea774","original_commit_id":"b7d30ae33da1910f9f6ad3e6859e78c13c6ea774","user":{"login":"votemike","id":3957065,"avatar_url":"https://avatars3.githubusercontent.com/u/3957065?v=4","gravatar_id":"","url":"https://api.github.com/users/votemike","html_url":"https://github.com/votemike","followers_url":"https://api.github.com/users/votemike/followers","following_url":"https://api.github.com/users/votemike/following{/other_user}","gists_url":"https://api.github.com/users/votemike/gists{/gist_id}","starred_url":"https://api.github.com/users/votemike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/votemike/subscriptions","organizations_url":"https://api.github.com/users/votemike/orgs","repos_url":"https://api.github.com/users/votemike/repos","events_url":"https://api.github.com/users/votemike/events{/privacy}","received_events_url":"https://api.github.com/users/votemike/received_events","type":"User","site_admin":false},"body":"Why removing the spaces everywhere? I thought we always put spaces in?","created_at":"2017-10-24T14:46:32Z","updated_at":"2017-10-24T14:46:32Z","html_url":"https://github.com/bbc/programmes-frontend/pull/264#discussion_r146584715","pull_request_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/264","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments/146584715"},"html":{"href":"https://github.com/bbc/programmes-frontend/pull/264#discussion_r146584715"},"pull_request":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/264","id":147817762,"html_url":"https://github.com/bbc/programmes-frontend/pull/264","diff_url":"https://github.com/bbc/programmes-frontend/pull/264.diff","patch_url":"https://github.com/bbc/programmes-frontend/pull/264.patch","issue_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/264","number":264,"state":"open","locked":false,"title":"PROGRAMMES-5766 - Group object","user":{"login":"felipeparaujo","id":7460234,"avatar_url":"https://avatars3.githubusercontent.com/u/7460234?v=4","gravatar_id":"","url":"https://api.github.com/users/felipeparaujo","html_url":"https://github.com/felipeparaujo","followers_url":"https://api.github.com/users/felipeparaujo/followers","following_url":"https://api.github.com/users/felipeparaujo/following{/other_user}","gists_url":"https://api.github.com/users/felipeparaujo/gists{/gist_id}","starred_url":"https://api.github.com/users/felipeparaujo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felipeparaujo/subscriptions","organizations_url":"https://api.github.com/users/felipeparaujo/orgs","repos_url":"https://api.github.com/users/felipeparaujo/repos","events_url":"https://api.github.com/users/felipeparaujo/events{/privacy}","received_events_url":"https://api.github.com/users/felipeparaujo/received_events","type":"User","site_admin":false},"body":"This PR actually encompasses more than the Group Object. I moved some code around to take advantage of the overlapping logic in these objects. The objects now live in DsAmen/Organism/Object. The object presenters and its subpresenters extend the base classes (in Base) and use the Shared blocks (which are concrete implementations of the abstract classes in Base, without any changes). Easiest way to review this will be to check it out locally and observe the changes in intellij or similar.","created_at":"2017-10-20T14:43:59Z","updated_at":"2017-10-24T14:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb0f202f45c5f88fc12bf3bee510631fb24d5fac","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/264/commits","review_comments_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/264/comments","review_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/264/comments","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/b7d30ae33da1910f9f6ad3e6859e78c13c6ea774","head":{"label":"bbc:group-object","ref":"group-object","sha":"b7d30ae33da1910f9f6ad3e6859e78c13c6ea774","user":{"login":"bbc","id":828722,"avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":85298889,"name":"programmes-frontend","full_name":"bbc/programmes-frontend","owner":{"login":"bbc","id":828722,"avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bbc/programmes-frontend","description":"The new frontend for bbc.co.uk/programmes","fork":false,"url":"https://api.github.com/repos/bbc/programmes-frontend","forks_url":"https://api.github.com/repos/bbc/programmes-frontend/forks","keys_url":"https://api.github.com/repos/bbc/programmes-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/programmes-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/programmes-frontend/teams","hooks_url":"https://api.github.com/repos/bbc/programmes-frontend/hooks","issue_events_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/programmes-frontend/events","assignees_url":"https://api.github.com/repos/bbc/programmes-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/programmes-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/programmes-frontend/tags","blobs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/programmes-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/programmes-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/programmes-frontend/languages","stargazers_url":"https://api.github.com/repos/bbc/programmes-frontend/stargazers","contributors_url":"https://api.github.com/repos/bbc/programmes-frontend/contributors","subscribers_url":"https://api.github.com/repos/bbc/programmes-frontend/subscribers","subscription_url":"https://api.github.com/repos/bbc/programmes-frontend/subscription","commits_url":"https://api.github.com/repos/bbc/programmes-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/programmes-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/programmes-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/programmes-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/programmes-frontend/merges","archive_url":"https://api.github.com/repos/bbc/programmes-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/programmes-frontend/downloads","issues_url":"https://api.github.com/repos/bbc/programmes-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/programmes-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/programmes-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/programmes-frontend/labels{/name}","releases_url":"https://api.github.com/repos/bbc/programmes-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/programmes-frontend/deployments","created_at":"2017-03-17T10:19:20Z","updated_at":"2017-10-19T13:49:09Z","pushed_at":"2017-10-24T14:43:28Z","git_url":"git://github.com/bbc/programmes-frontend.git","ssh_url":"git@github.com:bbc/programmes-frontend.git","clone_url":"https://github.com/bbc/programmes-frontend.git","svn_url":"https://github.com/bbc/programmes-frontend","homepage":"","size":1800,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":6,"default_branch":"develop"}},"base":{"label":"bbc:develop","ref":"develop","sha":"e0347b3d11efa99a90de054d9ca8d3deeac33c8d","user":{"login":"bbc","id":828722,"avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"repo":{"id":85298889,"name":"programmes-frontend","full_name":"bbc/programmes-frontend","owner":{"login":"bbc","id":828722,"avatar_url":"https://avatars1.githubusercontent.com/u/828722?v=4","gravatar_id":"","url":"https://api.github.com/users/bbc","html_url":"https://github.com/bbc","followers_url":"https://api.github.com/users/bbc/followers","following_url":"https://api.github.com/users/bbc/following{/other_user}","gists_url":"https://api.github.com/users/bbc/gists{/gist_id}","starred_url":"https://api.github.com/users/bbc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbc/subscriptions","organizations_url":"https://api.github.com/users/bbc/orgs","repos_url":"https://api.github.com/users/bbc/repos","events_url":"https://api.github.com/users/bbc/events{/privacy}","received_events_url":"https://api.github.com/users/bbc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bbc/programmes-frontend","description":"The new frontend for bbc.co.uk/programmes","fork":false,"url":"https://api.github.com/repos/bbc/programmes-frontend","forks_url":"https://api.github.com/repos/bbc/programmes-frontend/forks","keys_url":"https://api.github.com/repos/bbc/programmes-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbc/programmes-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbc/programmes-frontend/teams","hooks_url":"https://api.github.com/repos/bbc/programmes-frontend/hooks","issue_events_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/bbc/programmes-frontend/events","assignees_url":"https://api.github.com/repos/bbc/programmes-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/bbc/programmes-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/bbc/programmes-frontend/tags","blobs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbc/programmes-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbc/programmes-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbc/programmes-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbc/programmes-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/bbc/programmes-frontend/languages","stargazers_url":"https://api.github.com/repos/bbc/programmes-frontend/stargazers","contributors_url":"https://api.github.com/repos/bbc/programmes-frontend/contributors","subscribers_url":"https://api.github.com/repos/bbc/programmes-frontend/subscribers","subscription_url":"https://api.github.com/repos/bbc/programmes-frontend/subscription","commits_url":"https://api.github.com/repos/bbc/programmes-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbc/programmes-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbc/programmes-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbc/programmes-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbc/programmes-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/bbc/programmes-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbc/programmes-frontend/merges","archive_url":"https://api.github.com/repos/bbc/programmes-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbc/programmes-frontend/downloads","issues_url":"https://api.github.com/repos/bbc/programmes-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/bbc/programmes-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/bbc/programmes-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/bbc/programmes-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbc/programmes-frontend/labels{/name}","releases_url":"https://api.github.com/repos/bbc/programmes-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/bbc/programmes-frontend/deployments","created_at":"2017-03-17T10:19:20Z","updated_at":"2017-10-19T13:49:09Z","pushed_at":"2017-10-24T14:43:28Z","git_url":"git://github.com/bbc/programmes-frontend.git","ssh_url":"git@github.com:bbc/programmes-frontend.git","clone_url":"https://github.com/bbc/programmes-frontend.git","svn_url":"https://github.com/bbc/programmes-frontend","homepage":"","size":1800,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/264"},"html":{"href":"https://github.com/bbc/programmes-frontend/pull/264"},"issue":{"href":"https://api.github.com/repos/bbc/programmes-frontend/issues/264"},"comments":{"href":"https://api.github.com/repos/bbc/programmes-frontend/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bbc/programmes-frontend/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/bbc/programmes-frontend/statuses/b7d30ae33da1910f9f6ad3e6859e78c13c6ea774"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"votemike"}}