{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/101182196","pull_request_review_id":21903184,"id":101182196,"diff_hunk":"@@ -53,6 +54,11 @@ export function adsense(global, data) {\n   if (data['tagOrigin']) {\n     i.setAttribute('data-tag-origin', data['tagOrigin']);\n   }\n+  if (global.context['layout'] == Layout.RESPONSIVE) {\n+    // Use fluid as it will fill the space which requires at least 250 width","path":"ads/google/adsense.js","position":13,"original_position":13,"commit_id":"6aee25ca54301ffaa92f9df29c0909208ffae9b4","original_commit_id":"6aee25ca54301ffaa92f9df29c0909208ffae9b4","user":{"login":"keithwrightbos","id":1766447,"avatar_url":"https://avatars.githubusercontent.com/u/1766447?v=3","gravatar_id":"","url":"https://api.github.com/users/keithwrightbos","html_url":"https://github.com/keithwrightbos","followers_url":"https://api.github.com/users/keithwrightbos/followers","following_url":"https://api.github.com/users/keithwrightbos/following{/other_user}","gists_url":"https://api.github.com/users/keithwrightbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keithwrightbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithwrightbos/subscriptions","organizations_url":"https://api.github.com/users/keithwrightbos/orgs","repos_url":"https://api.github.com/users/keithwrightbos/repos","events_url":"https://api.github.com/users/keithwrightbos/events{/privacy}","received_events_url":"https://api.github.com/users/keithwrightbos/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-02-15T00:52:49Z","updated_at":"2017-02-15T00:52:50Z","html_url":"https://github.com/ampproject/amphtml/pull/7515#discussion_r101182196","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7515","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/101182196"},"html":{"href":"https://github.com/ampproject/amphtml/pull/7515#discussion_r101182196"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7515"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/7515","id":105983379,"html_url":"https://github.com/ampproject/amphtml/pull/7515","diff_url":"https://github.com/ampproject/amphtml/pull/7515.diff","patch_url":"https://github.com/ampproject/amphtml/pull/7515.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/7515","number":7515,"state":"open","locked":false,"title":"Adsense explicitly support responsive","user":{"login":"keithwrightbos","id":1766447,"avatar_url":"https://avatars.githubusercontent.com/u/1766447?v=3","gravatar_id":"","url":"https://api.github.com/users/keithwrightbos","html_url":"https://github.com/keithwrightbos","followers_url":"https://api.github.com/users/keithwrightbos/followers","following_url":"https://api.github.com/users/keithwrightbos/following{/other_user}","gists_url":"https://api.github.com/users/keithwrightbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keithwrightbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithwrightbos/subscriptions","organizations_url":"https://api.github.com/users/keithwrightbos/orgs","repos_url":"https://api.github.com/users/keithwrightbos/repos","events_url":"https://api.github.com/users/keithwrightbos/events{/privacy}","received_events_url":"https://api.github.com/users/keithwrightbos/received_events","type":"User","site_admin":false},"body":"Adsense relies on a known, allowed set of format sizes based on the size of the slot however responsive layout can cause this to break resulting in a 400 response.  Change is to explicitly detect responsive layout for both delayed and fast fetch and modify the ad request accordingly.","created_at":"2017-02-13T21:30:44Z","updated_at":"2017-02-15T00:52:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ab2aca1524e0da50dc80cbb4ce8033c9ae82350","assignee":{"login":"keithwrightbos","id":1766447,"avatar_url":"https://avatars.githubusercontent.com/u/1766447?v=3","gravatar_id":"","url":"https://api.github.com/users/keithwrightbos","html_url":"https://github.com/keithwrightbos","followers_url":"https://api.github.com/users/keithwrightbos/followers","following_url":"https://api.github.com/users/keithwrightbos/following{/other_user}","gists_url":"https://api.github.com/users/keithwrightbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keithwrightbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithwrightbos/subscriptions","organizations_url":"https://api.github.com/users/keithwrightbos/orgs","repos_url":"https://api.github.com/users/keithwrightbos/repos","events_url":"https://api.github.com/users/keithwrightbos/events{/privacy}","received_events_url":"https://api.github.com/users/keithwrightbos/received_events","type":"User","site_admin":false},"assignees":[{"login":"keithwrightbos","id":1766447,"avatar_url":"https://avatars.githubusercontent.com/u/1766447?v=3","gravatar_id":"","url":"https://api.github.com/users/keithwrightbos","html_url":"https://github.com/keithwrightbos","followers_url":"https://api.github.com/users/keithwrightbos/followers","following_url":"https://api.github.com/users/keithwrightbos/following{/other_user}","gists_url":"https://api.github.com/users/keithwrightbos/gists{/gist_id}","starred_url":"https://api.github.com/users/keithwrightbos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithwrightbos/subscriptions","organizations_url":"https://api.github.com/users/keithwrightbos/orgs","repos_url":"https://api.github.com/users/keithwrightbos/repos","events_url":"https://api.github.com/users/keithwrightbos/events{/privacy}","received_events_url":"https://api.github.com/users/keithwrightbos/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7515/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7515/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/7515/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/6aee25ca54301ffaa92f9df29c0909208ffae9b4","head":{"label":"google:a4a_responsive","ref":"a4a_responsive","sha":"6aee25ca54301ffaa92f9df29c0909208ffae9b4","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":51965089,"name":"amphtml","full_name":"google/amphtml","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/google/amphtml","forks_url":"https://api.github.com/repos/google/amphtml/forks","keys_url":"https://api.github.com/repos/google/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/amphtml/teams","hooks_url":"https://api.github.com/repos/google/amphtml/hooks","issue_events_url":"https://api.github.com/repos/google/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/google/amphtml/events","assignees_url":"https://api.github.com/repos/google/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/google/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/google/amphtml/tags","blobs_url":"https://api.github.com/repos/google/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/google/amphtml/languages","stargazers_url":"https://api.github.com/repos/google/amphtml/stargazers","contributors_url":"https://api.github.com/repos/google/amphtml/contributors","subscribers_url":"https://api.github.com/repos/google/amphtml/subscribers","subscription_url":"https://api.github.com/repos/google/amphtml/subscription","commits_url":"https://api.github.com/repos/google/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/google/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/amphtml/merges","archive_url":"https://api.github.com/repos/google/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/amphtml/downloads","issues_url":"https://api.github.com/repos/google/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/google/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/google/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/google/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/google/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/google/amphtml/deployments","created_at":"2016-02-18T00:04:16Z","updated_at":"2017-02-08T18:37:04Z","pushed_at":"2017-02-14T18:51:43Z","git_url":"git://github.com/google/amphtml.git","ssh_url":"git@github.com:google/amphtml.git","clone_url":"https://github.com/google/amphtml.git","svn_url":"https://github.com/google/amphtml","homepage":"https://ampproject.org","size":229219,"stargazers_count":66,"watchers_count":66,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":0,"forks":20,"open_issues":0,"watchers":66,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"ecee9ac269d2ef8aac0276b4e67b1596ec76cdfe","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-02-14T17:50:45Z","pushed_at":"2017-02-15T00:48:28Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":228798,"stargazers_count":9578,"watchers_count":9578,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1556,"mirror_url":null,"open_issues_count":661,"forks":1556,"open_issues":661,"watchers":9578,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7515"},"html":{"href":"https://github.com/ampproject/amphtml/pull/7515"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/7515"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/7515/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7515/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7515/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/6aee25ca54301ffaa92f9df29c0909208ffae9b4"}}}}
{"actor":{"display_login":"keithwrightbos"}}