{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1264","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1264/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1264/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1264/events","html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/issues/1264","id":216871340,"number":1264,"title":"[Question] [HBase Client] ValueFilter adapter for BinaryComparator with CompareOp.EQUAL","user":{"login":"ckolbeck","id":225933,"avatar_url":"https://avatars2.githubusercontent.com/u/225933?v=3","gravatar_id":"","url":"https://api.github.com/users/ckolbeck","html_url":"https://github.com/ckolbeck","followers_url":"https://api.github.com/users/ckolbeck/followers","following_url":"https://api.github.com/users/ckolbeck/following{/other_user}","gists_url":"https://api.github.com/users/ckolbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/ckolbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckolbeck/subscriptions","organizations_url":"https://api.github.com/users/ckolbeck/orgs","repos_url":"https://api.github.com/users/ckolbeck/repos","events_url":"https://api.github.com/users/ckolbeck/events{/privacy}","received_events_url":"https://api.github.com/users/ckolbeck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-24T18:35:35Z","updated_at":"2017-03-24T21:10:50Z","closed_at":null,"body":"Relevant code: https://github.com/GoogleCloudPlatform/cloud-bigtable-client/blob/master/bigtable-hbase-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/adapters/filters/ValueFilterAdapter.java#L80\r\n\r\nThe use of `ValueRegexFilter` here seems odd, and currently breaks against the emulator if the value contains non-UTF8 bytes. That fact is well documented, but not documented is the fact that `BigtableTable.checkAndPut()` is implemented using a ValueRegexFilter, causing operations which expect non-UTF8 byte strings to always silently fail against the emulator.\r\n\r\nIs there a reason to use a `ValueRegexFilter` here instead of a `ValueRange` with closed upper and lower bounds of the desired value?"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/comments/289143809","html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/issues/1264#issuecomment-289143809","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/1264","id":289143809,"user":{"login":"ckolbeck","id":225933,"avatar_url":"https://avatars2.githubusercontent.com/u/225933?v=3","gravatar_id":"","url":"https://api.github.com/users/ckolbeck","html_url":"https://github.com/ckolbeck","followers_url":"https://api.github.com/users/ckolbeck/followers","following_url":"https://api.github.com/users/ckolbeck/following{/other_user}","gists_url":"https://api.github.com/users/ckolbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/ckolbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckolbeck/subscriptions","organizations_url":"https://api.github.com/users/ckolbeck/orgs","repos_url":"https://api.github.com/users/ckolbeck/repos","events_url":"https://api.github.com/users/ckolbeck/events{/privacy}","received_events_url":"https://api.github.com/users/ckolbeck/received_events","type":"User","site_admin":false},"created_at":"2017-03-24T21:10:50Z","updated_at":"2017-03-24T21:10:50Z","body":"Wonderful! Thanks so much for the quick work. Do you think this will make it in to next weeks release that you mentioned in https://github.com/GoogleCloudPlatform/cloud-bigtable-client/issues/1257?"}}
{"actor":{"display_login":"ckolbeck"}}