{"action":"created","comment":{"url":"https://api.github.com/repos/TextDB/textdb/pulls/comments/97479750","pull_request_review_id":18089863,"id":97479750,"diff_hunk":"@@ -17,4 +18,6 @@\n \n \tITuple joinTuples(ITuple outerTuple, ITuple innerTuple, Schema outputSchema)\n \t\t\tthrows Exception;\n+\t\n+\tSchema generateOutputSchema(Schema innerOperatorSchema, Schema outerOperatorSchema) throws DataFlowException;","path":"textdb/textdb-dataflow/src/main/java/edu/uci/ics/textdb/dataflow/common/IJoinPredicate.java","position":13,"original_position":13,"commit_id":"50d86f52b4d0ebfc7e7bd8cde6cd925ae8f40b76","original_commit_id":"50d86f52b4d0ebfc7e7bd8cde6cd925ae8f40b76","user":{"login":"zuozhiw","id":12578068,"avatar_url":"https://avatars.githubusercontent.com/u/12578068?v=3","gravatar_id":"","url":"https://api.github.com/users/zuozhiw","html_url":"https://github.com/zuozhiw","followers_url":"https://api.github.com/users/zuozhiw/followers","following_url":"https://api.github.com/users/zuozhiw/following{/other_user}","gists_url":"https://api.github.com/users/zuozhiw/gists{/gist_id}","starred_url":"https://api.github.com/users/zuozhiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuozhiw/subscriptions","organizations_url":"https://api.github.com/users/zuozhiw/orgs","repos_url":"https://api.github.com/users/zuozhiw/repos","events_url":"https://api.github.com/users/zuozhiw/events{/privacy}","received_events_url":"https://api.github.com/users/zuozhiw/received_events","type":"User","site_admin":false},"body":"`generateOutputSchema` function is moved from `Join` to the predicates, since different join predicates may produce different output schema","created_at":"2017-01-24T06:05:43Z","updated_at":"2017-01-24T06:05:43Z","html_url":"https://github.com/TextDB/textdb/pull/364#discussion_r97479750","pull_request_url":"https://api.github.com/repos/TextDB/textdb/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/TextDB/textdb/pulls/comments/97479750"},"html":{"href":"https://github.com/TextDB/textdb/pull/364#discussion_r97479750"},"pull_request":{"href":"https://api.github.com/repos/TextDB/textdb/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/TextDB/textdb/pulls/364","id":102852634,"html_url":"https://github.com/TextDB/textdb/pull/364","diff_url":"https://github.com/TextDB/textdb/pull/364.diff","patch_url":"https://github.com/TextDB/textdb/pull/364.patch","issue_url":"https://api.github.com/repos/TextDB/textdb/issues/364","number":364,"state":"open","locked":false,"title":"Add Similarity Join Predicate and Reuse the old Join","user":{"login":"zuozhiw","id":12578068,"avatar_url":"https://avatars.githubusercontent.com/u/12578068?v=3","gravatar_id":"","url":"https://api.github.com/users/zuozhiw","html_url":"https://github.com/zuozhiw","followers_url":"https://api.github.com/users/zuozhiw/followers","following_url":"https://api.github.com/users/zuozhiw/following{/other_user}","gists_url":"https://api.github.com/users/zuozhiw/gists{/gist_id}","starred_url":"https://api.github.com/users/zuozhiw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuozhiw/subscriptions","organizations_url":"https://api.github.com/users/zuozhiw/orgs","repos_url":"https://api.github.com/users/zuozhiw/repos","events_url":"https://api.github.com/users/zuozhiw/events{/privacy}","received_events_url":"https://api.github.com/users/zuozhiw/received_events","type":"User","site_admin":false},"body":"This PR adds `SimilarityJoinPredicate`, which is used to join different tuples if two tuples' values in spans are similar within a similarity threshold.\r\n\r\n`SimilarityJoinPredicate` implements the `IJoinPredicate` interface and it is parallel to the existing `JoinDistancePredicate`. It is able to use the existing `Join` class (which implements nested loop join) after some minor modifications. \r\n\r\n`SimilarityJoinPredicate` can also re-use the existing `JoinTestHelper` after some minor modifications.","created_at":"2017-01-24T04:49:15Z","updated_at":"2017-01-24T06:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5eadc1f3559413d272e34abb8fcb8f9fc21c70a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TextDB/textdb/pulls/364/commits","review_comments_url":"https://api.github.com/repos/TextDB/textdb/pulls/364/comments","review_comment_url":"https://api.github.com/repos/TextDB/textdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TextDB/textdb/issues/364/comments","statuses_url":"https://api.github.com/repos/TextDB/textdb/statuses/50d86f52b4d0ebfc7e7bd8cde6cd925ae8f40b76","head":{"label":"TextDB:zuozhi-sim-join","ref":"zuozhi-sim-join","sha":"50d86f52b4d0ebfc7e7bd8cde6cd925ae8f40b76","user":{"login":"TextDB","id":18126950,"avatar_url":"https://avatars.githubusercontent.com/u/18126950?v=3","gravatar_id":"","url":"https://api.github.com/users/TextDB","html_url":"https://github.com/TextDB","followers_url":"https://api.github.com/users/TextDB/followers","following_url":"https://api.github.com/users/TextDB/following{/other_user}","gists_url":"https://api.github.com/users/TextDB/gists{/gist_id}","starred_url":"https://api.github.com/users/TextDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextDB/subscriptions","organizations_url":"https://api.github.com/users/TextDB/orgs","repos_url":"https://api.github.com/users/TextDB/repos","events_url":"https://api.github.com/users/TextDB/events{/privacy}","received_events_url":"https://api.github.com/users/TextDB/received_events","type":"Organization","site_admin":false},"repo":{"id":53976910,"name":"textdb","full_name":"TextDB/textdb","owner":{"login":"TextDB","id":18126950,"avatar_url":"https://avatars.githubusercontent.com/u/18126950?v=3","gravatar_id":"","url":"https://api.github.com/users/TextDB","html_url":"https://github.com/TextDB","followers_url":"https://api.github.com/users/TextDB/followers","following_url":"https://api.github.com/users/TextDB/following{/other_user}","gists_url":"https://api.github.com/users/TextDB/gists{/gist_id}","starred_url":"https://api.github.com/users/TextDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextDB/subscriptions","organizations_url":"https://api.github.com/users/TextDB/orgs","repos_url":"https://api.github.com/users/TextDB/repos","events_url":"https://api.github.com/users/TextDB/events{/privacy}","received_events_url":"https://api.github.com/users/TextDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TextDB/textdb","description":"Text-centric data management system","fork":false,"url":"https://api.github.com/repos/TextDB/textdb","forks_url":"https://api.github.com/repos/TextDB/textdb/forks","keys_url":"https://api.github.com/repos/TextDB/textdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextDB/textdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextDB/textdb/teams","hooks_url":"https://api.github.com/repos/TextDB/textdb/hooks","issue_events_url":"https://api.github.com/repos/TextDB/textdb/issues/events{/number}","events_url":"https://api.github.com/repos/TextDB/textdb/events","assignees_url":"https://api.github.com/repos/TextDB/textdb/assignees{/user}","branches_url":"https://api.github.com/repos/TextDB/textdb/branches{/branch}","tags_url":"https://api.github.com/repos/TextDB/textdb/tags","blobs_url":"https://api.github.com/repos/TextDB/textdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextDB/textdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextDB/textdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextDB/textdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextDB/textdb/statuses/{sha}","languages_url":"https://api.github.com/repos/TextDB/textdb/languages","stargazers_url":"https://api.github.com/repos/TextDB/textdb/stargazers","contributors_url":"https://api.github.com/repos/TextDB/textdb/contributors","subscribers_url":"https://api.github.com/repos/TextDB/textdb/subscribers","subscription_url":"https://api.github.com/repos/TextDB/textdb/subscription","commits_url":"https://api.github.com/repos/TextDB/textdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextDB/textdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextDB/textdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextDB/textdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextDB/textdb/contents/{+path}","compare_url":"https://api.github.com/repos/TextDB/textdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextDB/textdb/merges","archive_url":"https://api.github.com/repos/TextDB/textdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextDB/textdb/downloads","issues_url":"https://api.github.com/repos/TextDB/textdb/issues{/number}","pulls_url":"https://api.github.com/repos/TextDB/textdb/pulls{/number}","milestones_url":"https://api.github.com/repos/TextDB/textdb/milestones{/number}","notifications_url":"https://api.github.com/repos/TextDB/textdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextDB/textdb/labels{/name}","releases_url":"https://api.github.com/repos/TextDB/textdb/releases{/id}","deployments_url":"https://api.github.com/repos/TextDB/textdb/deployments","created_at":"2016-03-15T20:38:46Z","updated_at":"2017-01-23T19:10:27Z","pushed_at":"2017-01-24T06:01:21Z","git_url":"git://github.com/TextDB/textdb.git","ssh_url":"git@github.com:TextDB/textdb.git","clone_url":"https://github.com/TextDB/textdb.git","svn_url":"https://github.com/TextDB/textdb","homepage":null,"size":21839,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":13,"forks":7,"open_issues":13,"watchers":17,"default_branch":"master"}},"base":{"label":"TextDB:master","ref":"master","sha":"d752cff5373b57bc43dd94ba906f0c4eebdf064e","user":{"login":"TextDB","id":18126950,"avatar_url":"https://avatars.githubusercontent.com/u/18126950?v=3","gravatar_id":"","url":"https://api.github.com/users/TextDB","html_url":"https://github.com/TextDB","followers_url":"https://api.github.com/users/TextDB/followers","following_url":"https://api.github.com/users/TextDB/following{/other_user}","gists_url":"https://api.github.com/users/TextDB/gists{/gist_id}","starred_url":"https://api.github.com/users/TextDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextDB/subscriptions","organizations_url":"https://api.github.com/users/TextDB/orgs","repos_url":"https://api.github.com/users/TextDB/repos","events_url":"https://api.github.com/users/TextDB/events{/privacy}","received_events_url":"https://api.github.com/users/TextDB/received_events","type":"Organization","site_admin":false},"repo":{"id":53976910,"name":"textdb","full_name":"TextDB/textdb","owner":{"login":"TextDB","id":18126950,"avatar_url":"https://avatars.githubusercontent.com/u/18126950?v=3","gravatar_id":"","url":"https://api.github.com/users/TextDB","html_url":"https://github.com/TextDB","followers_url":"https://api.github.com/users/TextDB/followers","following_url":"https://api.github.com/users/TextDB/following{/other_user}","gists_url":"https://api.github.com/users/TextDB/gists{/gist_id}","starred_url":"https://api.github.com/users/TextDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextDB/subscriptions","organizations_url":"https://api.github.com/users/TextDB/orgs","repos_url":"https://api.github.com/users/TextDB/repos","events_url":"https://api.github.com/users/TextDB/events{/privacy}","received_events_url":"https://api.github.com/users/TextDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TextDB/textdb","description":"Text-centric data management system","fork":false,"url":"https://api.github.com/repos/TextDB/textdb","forks_url":"https://api.github.com/repos/TextDB/textdb/forks","keys_url":"https://api.github.com/repos/TextDB/textdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextDB/textdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextDB/textdb/teams","hooks_url":"https://api.github.com/repos/TextDB/textdb/hooks","issue_events_url":"https://api.github.com/repos/TextDB/textdb/issues/events{/number}","events_url":"https://api.github.com/repos/TextDB/textdb/events","assignees_url":"https://api.github.com/repos/TextDB/textdb/assignees{/user}","branches_url":"https://api.github.com/repos/TextDB/textdb/branches{/branch}","tags_url":"https://api.github.com/repos/TextDB/textdb/tags","blobs_url":"https://api.github.com/repos/TextDB/textdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextDB/textdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextDB/textdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextDB/textdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextDB/textdb/statuses/{sha}","languages_url":"https://api.github.com/repos/TextDB/textdb/languages","stargazers_url":"https://api.github.com/repos/TextDB/textdb/stargazers","contributors_url":"https://api.github.com/repos/TextDB/textdb/contributors","subscribers_url":"https://api.github.com/repos/TextDB/textdb/subscribers","subscription_url":"https://api.github.com/repos/TextDB/textdb/subscription","commits_url":"https://api.github.com/repos/TextDB/textdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextDB/textdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextDB/textdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextDB/textdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextDB/textdb/contents/{+path}","compare_url":"https://api.github.com/repos/TextDB/textdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextDB/textdb/merges","archive_url":"https://api.github.com/repos/TextDB/textdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextDB/textdb/downloads","issues_url":"https://api.github.com/repos/TextDB/textdb/issues{/number}","pulls_url":"https://api.github.com/repos/TextDB/textdb/pulls{/number}","milestones_url":"https://api.github.com/repos/TextDB/textdb/milestones{/number}","notifications_url":"https://api.github.com/repos/TextDB/textdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextDB/textdb/labels{/name}","releases_url":"https://api.github.com/repos/TextDB/textdb/releases{/id}","deployments_url":"https://api.github.com/repos/TextDB/textdb/deployments","created_at":"2016-03-15T20:38:46Z","updated_at":"2017-01-23T19:10:27Z","pushed_at":"2017-01-24T06:01:21Z","git_url":"git://github.com/TextDB/textdb.git","ssh_url":"git@github.com:TextDB/textdb.git","clone_url":"https://github.com/TextDB/textdb.git","svn_url":"https://github.com/TextDB/textdb","homepage":null,"size":21839,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":13,"forks":7,"open_issues":13,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TextDB/textdb/pulls/364"},"html":{"href":"https://github.com/TextDB/textdb/pull/364"},"issue":{"href":"https://api.github.com/repos/TextDB/textdb/issues/364"},"comments":{"href":"https://api.github.com/repos/TextDB/textdb/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/TextDB/textdb/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/TextDB/textdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TextDB/textdb/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/TextDB/textdb/statuses/50d86f52b4d0ebfc7e7bd8cde6cd925ae8f40b76"}}}}
{"actor":{"display_login":"zuozhiw"}}