{"action":"created","comment":{"url":"https://api.github.com/repos/unidoc/unidoc/pulls/comments/131751887","pull_request_review_id":54760459,"id":131751887,"diff_hunk":"@@ -1413,19 +1413,19 @@ func (this *PdfColorspaceLab) ColorFromFloats(vals []float64) (PdfColor, error)\n \n \t// L\n \tl := vals[0]\n-\tif l < 0.0 || l > 1.0 {\n+\tif l < 0.0 || l > 100.0 {","path":"pdf/model/colorspace.go","position":5,"original_position":5,"commit_id":"f840c1c77ebf34c3d6a9bc51ee3ad056e98deb55","original_commit_id":"f840c1c77ebf34c3d6a9bc51ee3ad056e98deb55","user":{"login":"gunnsth","id":50777,"avatar_url":"https://avatars3.githubusercontent.com/u/50777?v=4","gravatar_id":"","url":"https://api.github.com/users/gunnsth","html_url":"https://github.com/gunnsth","followers_url":"https://api.github.com/users/gunnsth/followers","following_url":"https://api.github.com/users/gunnsth/following{/other_user}","gists_url":"https://api.github.com/users/gunnsth/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnsth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnsth/subscriptions","organizations_url":"https://api.github.com/users/gunnsth/orgs","repos_url":"https://api.github.com/users/gunnsth/repos","events_url":"https://api.github.com/users/gunnsth/events{/privacy}","received_events_url":"https://api.github.com/users/gunnsth/received_events","type":"User","site_admin":false},"body":"Yes, this appears to be correct, however it is inconsistent with our Lab ColorToRGB method, which is assuming some sort of normalized input components.  I will try to identify some test cases for testing.  I rarely encounter Lab colorspace, so might have been relatively less tested.  Unfortunately the standard does not provide any concrete test cases.\r\n\r\nAlso, the Range parameter can adjust the range of a and b.  I will add that after merging.","created_at":"2017-08-07T20:13:23Z","updated_at":"2017-08-07T20:20:49Z","html_url":"https://github.com/unidoc/unidoc/pull/108#discussion_r131751887","pull_request_url":"https://api.github.com/repos/unidoc/unidoc/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/unidoc/unidoc/pulls/comments/131751887"},"html":{"href":"https://github.com/unidoc/unidoc/pull/108#discussion_r131751887"},"pull_request":{"href":"https://api.github.com/repos/unidoc/unidoc/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/unidoc/unidoc/pulls/108","id":134362372,"html_url":"https://github.com/unidoc/unidoc/pull/108","diff_url":"https://github.com/unidoc/unidoc/pull/108.diff","patch_url":"https://github.com/unidoc/unidoc/pull/108.patch","issue_url":"https://api.github.com/repos/unidoc/unidoc/issues/108","number":108,"state":"open","locked":false,"title":"Reimplementing dummy colorspaces. See","user":{"login":"peterwilliams97","id":103773,"avatar_url":"https://avatars0.githubusercontent.com/u/103773?v=4","gravatar_id":"","url":"https://api.github.com/users/peterwilliams97","html_url":"https://github.com/peterwilliams97","followers_url":"https://api.github.com/users/peterwilliams97/followers","following_url":"https://api.github.com/users/peterwilliams97/following{/other_user}","gists_url":"https://api.github.com/users/peterwilliams97/gists{/gist_id}","starred_url":"https://api.github.com/users/peterwilliams97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterwilliams97/subscriptions","organizations_url":"https://api.github.com/users/peterwilliams97/orgs","repos_url":"https://api.github.com/users/peterwilliams97/repos","events_url":"https://api.github.com/users/peterwilliams97/events{/privacy}","received_events_url":"https://api.github.com/users/peterwilliams97/received_events","type":"User","site_admin":false},"body":"See corresponding change in sample code https://github.com/unidoc/unidoc-examples/pull/5","created_at":"2017-08-07T04:50:46Z","updated_at":"2017-08-07T20:20:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"577b9ca1aa549c7bbde3e1e6e6a6337a301dfb51","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/unidoc/unidoc/pulls/108/commits","review_comments_url":"https://api.github.com/repos/unidoc/unidoc/pulls/108/comments","review_comment_url":"https://api.github.com/repos/unidoc/unidoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unidoc/unidoc/issues/108/comments","statuses_url":"https://api.github.com/repos/unidoc/unidoc/statuses/f840c1c77ebf34c3d6a9bc51ee3ad056e98deb55","head":{"label":"peterwilliams97:xmaster2","ref":"xmaster2","sha":"f840c1c77ebf34c3d6a9bc51ee3ad056e98deb55","user":{"login":"peterwilliams97","id":103773,"avatar_url":"https://avatars0.githubusercontent.com/u/103773?v=4","gravatar_id":"","url":"https://api.github.com/users/peterwilliams97","html_url":"https://github.com/peterwilliams97","followers_url":"https://api.github.com/users/peterwilliams97/followers","following_url":"https://api.github.com/users/peterwilliams97/following{/other_user}","gists_url":"https://api.github.com/users/peterwilliams97/gists{/gist_id}","starred_url":"https://api.github.com/users/peterwilliams97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterwilliams97/subscriptions","organizations_url":"https://api.github.com/users/peterwilliams97/orgs","repos_url":"https://api.github.com/users/peterwilliams97/repos","events_url":"https://api.github.com/users/peterwilliams97/events{/privacy}","received_events_url":"https://api.github.com/users/peterwilliams97/received_events","type":"User","site_admin":false},"repo":{"id":74307156,"name":"unidoc","full_name":"peterwilliams97/unidoc","owner":{"login":"peterwilliams97","id":103773,"avatar_url":"https://avatars0.githubusercontent.com/u/103773?v=4","gravatar_id":"","url":"https://api.github.com/users/peterwilliams97","html_url":"https://github.com/peterwilliams97","followers_url":"https://api.github.com/users/peterwilliams97/followers","following_url":"https://api.github.com/users/peterwilliams97/following{/other_user}","gists_url":"https://api.github.com/users/peterwilliams97/gists{/gist_id}","starred_url":"https://api.github.com/users/peterwilliams97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterwilliams97/subscriptions","organizations_url":"https://api.github.com/users/peterwilliams97/orgs","repos_url":"https://api.github.com/users/peterwilliams97/repos","events_url":"https://api.github.com/users/peterwilliams97/events{/privacy}","received_events_url":"https://api.github.com/users/peterwilliams97/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterwilliams97/unidoc","description":"UniDoc is a PDF toolkit for Golang","fork":true,"url":"https://api.github.com/repos/peterwilliams97/unidoc","forks_url":"https://api.github.com/repos/peterwilliams97/unidoc/forks","keys_url":"https://api.github.com/repos/peterwilliams97/unidoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterwilliams97/unidoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterwilliams97/unidoc/teams","hooks_url":"https://api.github.com/repos/peterwilliams97/unidoc/hooks","issue_events_url":"https://api.github.com/repos/peterwilliams97/unidoc/issues/events{/number}","events_url":"https://api.github.com/repos/peterwilliams97/unidoc/events","assignees_url":"https://api.github.com/repos/peterwilliams97/unidoc/assignees{/user}","branches_url":"https://api.github.com/repos/peterwilliams97/unidoc/branches{/branch}","tags_url":"https://api.github.com/repos/peterwilliams97/unidoc/tags","blobs_url":"https://api.github.com/repos/peterwilliams97/unidoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterwilliams97/unidoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterwilliams97/unidoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterwilliams97/unidoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterwilliams97/unidoc/statuses/{sha}","languages_url":"https://api.github.com/repos/peterwilliams97/unidoc/languages","stargazers_url":"https://api.github.com/repos/peterwilliams97/unidoc/stargazers","contributors_url":"https://api.github.com/repos/peterwilliams97/unidoc/contributors","subscribers_url":"https://api.github.com/repos/peterwilliams97/unidoc/subscribers","subscription_url":"https://api.github.com/repos/peterwilliams97/unidoc/subscription","commits_url":"https://api.github.com/repos/peterwilliams97/unidoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterwilliams97/unidoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterwilliams97/unidoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterwilliams97/unidoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterwilliams97/unidoc/contents/{+path}","compare_url":"https://api.github.com/repos/peterwilliams97/unidoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterwilliams97/unidoc/merges","archive_url":"https://api.github.com/repos/peterwilliams97/unidoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterwilliams97/unidoc/downloads","issues_url":"https://api.github.com/repos/peterwilliams97/unidoc/issues{/number}","pulls_url":"https://api.github.com/repos/peterwilliams97/unidoc/pulls{/number}","milestones_url":"https://api.github.com/repos/peterwilliams97/unidoc/milestones{/number}","notifications_url":"https://api.github.com/repos/peterwilliams97/unidoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterwilliams97/unidoc/labels{/name}","releases_url":"https://api.github.com/repos/peterwilliams97/unidoc/releases{/id}","deployments_url":"https://api.github.com/repos/peterwilliams97/unidoc/deployments","created_at":"2016-11-20T22:39:09Z","updated_at":"2016-11-20T22:39:11Z","pushed_at":"2017-08-07T06:44:21Z","git_url":"git://github.com/peterwilliams97/unidoc.git","ssh_url":"git@github.com:peterwilliams97/unidoc.git","clone_url":"https://github.com/peterwilliams97/unidoc.git","svn_url":"https://github.com/peterwilliams97/unidoc","homepage":"http://unidoc.io","size":2455,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unidoc:master","ref":"master","sha":"d3d0312170a47d3f2fa6ff47398a072c7fd13637","user":{"login":"unidoc","id":20077688,"avatar_url":"https://avatars1.githubusercontent.com/u/20077688?v=4","gravatar_id":"","url":"https://api.github.com/users/unidoc","html_url":"https://github.com/unidoc","followers_url":"https://api.github.com/users/unidoc/followers","following_url":"https://api.github.com/users/unidoc/following{/other_user}","gists_url":"https://api.github.com/users/unidoc/gists{/gist_id}","starred_url":"https://api.github.com/users/unidoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unidoc/subscriptions","organizations_url":"https://api.github.com/users/unidoc/orgs","repos_url":"https://api.github.com/users/unidoc/repos","events_url":"https://api.github.com/users/unidoc/events{/privacy}","received_events_url":"https://api.github.com/users/unidoc/received_events","type":"Organization","site_admin":false},"repo":{"id":62952373,"name":"unidoc","full_name":"unidoc/unidoc","owner":{"login":"unidoc","id":20077688,"avatar_url":"https://avatars1.githubusercontent.com/u/20077688?v=4","gravatar_id":"","url":"https://api.github.com/users/unidoc","html_url":"https://github.com/unidoc","followers_url":"https://api.github.com/users/unidoc/followers","following_url":"https://api.github.com/users/unidoc/following{/other_user}","gists_url":"https://api.github.com/users/unidoc/gists{/gist_id}","starred_url":"https://api.github.com/users/unidoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unidoc/subscriptions","organizations_url":"https://api.github.com/users/unidoc/orgs","repos_url":"https://api.github.com/users/unidoc/repos","events_url":"https://api.github.com/users/unidoc/events{/privacy}","received_events_url":"https://api.github.com/users/unidoc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unidoc/unidoc","description":"UniDoc is a PDF library for Golang","fork":false,"url":"https://api.github.com/repos/unidoc/unidoc","forks_url":"https://api.github.com/repos/unidoc/unidoc/forks","keys_url":"https://api.github.com/repos/unidoc/unidoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unidoc/unidoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unidoc/unidoc/teams","hooks_url":"https://api.github.com/repos/unidoc/unidoc/hooks","issue_events_url":"https://api.github.com/repos/unidoc/unidoc/issues/events{/number}","events_url":"https://api.github.com/repos/unidoc/unidoc/events","assignees_url":"https://api.github.com/repos/unidoc/unidoc/assignees{/user}","branches_url":"https://api.github.com/repos/unidoc/unidoc/branches{/branch}","tags_url":"https://api.github.com/repos/unidoc/unidoc/tags","blobs_url":"https://api.github.com/repos/unidoc/unidoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unidoc/unidoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unidoc/unidoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/unidoc/unidoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unidoc/unidoc/statuses/{sha}","languages_url":"https://api.github.com/repos/unidoc/unidoc/languages","stargazers_url":"https://api.github.com/repos/unidoc/unidoc/stargazers","contributors_url":"https://api.github.com/repos/unidoc/unidoc/contributors","subscribers_url":"https://api.github.com/repos/unidoc/unidoc/subscribers","subscription_url":"https://api.github.com/repos/unidoc/unidoc/subscription","commits_url":"https://api.github.com/repos/unidoc/unidoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/unidoc/unidoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/unidoc/unidoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/unidoc/unidoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/unidoc/unidoc/contents/{+path}","compare_url":"https://api.github.com/repos/unidoc/unidoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unidoc/unidoc/merges","archive_url":"https://api.github.com/repos/unidoc/unidoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unidoc/unidoc/downloads","issues_url":"https://api.github.com/repos/unidoc/unidoc/issues{/number}","pulls_url":"https://api.github.com/repos/unidoc/unidoc/pulls{/number}","milestones_url":"https://api.github.com/repos/unidoc/unidoc/milestones{/number}","notifications_url":"https://api.github.com/repos/unidoc/unidoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unidoc/unidoc/labels{/name}","releases_url":"https://api.github.com/repos/unidoc/unidoc/releases{/id}","deployments_url":"https://api.github.com/repos/unidoc/unidoc/deployments","created_at":"2016-07-09T14:09:11Z","updated_at":"2017-08-07T09:59:15Z","pushed_at":"2017-08-07T06:45:37Z","git_url":"git://github.com/unidoc/unidoc.git","ssh_url":"git@github.com:unidoc/unidoc.git","clone_url":"https://github.com/unidoc/unidoc.git","svn_url":"https://github.com/unidoc/unidoc","homepage":"https://unidoc.io","size":2319,"stargazers_count":260,"watchers_count":260,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":33,"forks":15,"open_issues":33,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unidoc/unidoc/pulls/108"},"html":{"href":"https://github.com/unidoc/unidoc/pull/108"},"issue":{"href":"https://api.github.com/repos/unidoc/unidoc/issues/108"},"comments":{"href":"https://api.github.com/repos/unidoc/unidoc/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/unidoc/unidoc/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/unidoc/unidoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unidoc/unidoc/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/unidoc/unidoc/statuses/f840c1c77ebf34c3d6a9bc51ee3ad056e98deb55"}}}}
{"actor":{"display_login":"gunnsth"}}