{"action":"created","comment":{"url":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/comments/114023896","pull_request_review_id":35460141,"id":114023896,"diff_hunk":"@@ -380,6 +380,16 @@ fn test_key_usage() {\n ///    apply if the update is within the name and class scope as per\n ///    sections 3.1.1 and 3.1.2.\n /// ```\n+///\n+/// [RFC 3007](https://tools.ietf.org/html/rfc3007#section-1.5), Secure Dynamic Update, November 2000\n+///\n+/// ```text\n+///    [RFC2535, section 3.1.2] defines the signatory field of a key as the\n+///    final 4 bits of the flags field, but does not define its value.  This\n+///    proposal leaves this field undefined.  Updating [RFC2535], this field\n+///    SHOULD be set to 0 in KEY records, and MUST be ignored.\n+///\n+/// ```\n #[derive(Debug, PartialEq, Eq, Hash, Clone, Copy)]\n pub struct UpdateScope {","path":"client/src/rr/rdata/key.rs","position":15,"original_position":15,"commit_id":"07d01e5923dcd2cb00d510fcbbc500506664fe34","original_commit_id":"07d01e5923dcd2cb00d510fcbbc500506664fe34","user":{"login":"bluejekyll","id":986845,"avatar_url":"https://avatars0.githubusercontent.com/u/986845?v=3","gravatar_id":"","url":"https://api.github.com/users/bluejekyll","html_url":"https://github.com/bluejekyll","followers_url":"https://api.github.com/users/bluejekyll/followers","following_url":"https://api.github.com/users/bluejekyll/following{/other_user}","gists_url":"https://api.github.com/users/bluejekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/bluejekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluejekyll/subscriptions","organizations_url":"https://api.github.com/users/bluejekyll/orgs","repos_url":"https://api.github.com/users/bluejekyll/repos","events_url":"https://api.github.com/users/bluejekyll/events{/privacy}","received_events_url":"https://api.github.com/users/bluejekyll/received_events","type":"User","site_admin":false},"body":"Should I just remove this type?","created_at":"2017-04-28T21:33:31Z","updated_at":"2017-04-28T21:35:05Z","html_url":"https://github.com/bluejekyll/trust-dns/pull/122#discussion_r114023896","pull_request_url":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/comments/114023896"},"html":{"href":"https://github.com/bluejekyll/trust-dns/pull/122#discussion_r114023896"},"pull_request":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/122","id":118185798,"html_url":"https://github.com/bluejekyll/trust-dns/pull/122","diff_url":"https://github.com/bluejekyll/trust-dns/pull/122.diff","patch_url":"https://github.com/bluejekyll/trust-dns/pull/122.patch","issue_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/122","number":122,"state":"open","locked":false,"title":"Fix SIG(0) calculation","user":{"login":"jannic","id":232606,"avatar_url":"https://avatars3.githubusercontent.com/u/232606?v=3","gravatar_id":"","url":"https://api.github.com/users/jannic","html_url":"https://github.com/jannic","followers_url":"https://api.github.com/users/jannic/followers","following_url":"https://api.github.com/users/jannic/following{/other_user}","gists_url":"https://api.github.com/users/jannic/gists{/gist_id}","starred_url":"https://api.github.com/users/jannic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannic/subscriptions","organizations_url":"https://api.github.com/users/jannic/orgs","repos_url":"https://api.github.com/users/jannic/repos","events_url":"https://api.github.com/users/jannic/events{/privacy}","received_events_url":"https://api.github.com/users/jannic/received_events","type":"User","site_admin":false},"body":"This fixes https://github.com/bluejekyll/trust-dns/issues/120, and a bug where the message was hashed twice before signing it.\r\n\r\nWith these changes, bind9 accepts a SIG(0) signed update request sent with trust_dns.\r\n\r\nAs mentioned in https://github.com/jannic/trust-dns/commit/f1c05cfcdb0506836adf68988be2af859288fc1f I only tested this with RSA signatures, not sure if ED25519 are missing the hashing step, now.","created_at":"2017-04-28T16:10:53Z","updated_at":"2017-04-28T21:35:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9c5a324cbe2fd9a15dbe28fb7f23d007a0e197a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/122/commits","review_comments_url":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/122/comments","review_comment_url":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/122/comments","statuses_url":"https://api.github.com/repos/bluejekyll/trust-dns/statuses/07d01e5923dcd2cb00d510fcbbc500506664fe34","head":{"label":"jannic:pr-fix-sig0","ref":"pr-fix-sig0","sha":"07d01e5923dcd2cb00d510fcbbc500506664fe34","user":{"login":"jannic","id":232606,"avatar_url":"https://avatars3.githubusercontent.com/u/232606?v=3","gravatar_id":"","url":"https://api.github.com/users/jannic","html_url":"https://github.com/jannic","followers_url":"https://api.github.com/users/jannic/followers","following_url":"https://api.github.com/users/jannic/following{/other_user}","gists_url":"https://api.github.com/users/jannic/gists{/gist_id}","starred_url":"https://api.github.com/users/jannic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannic/subscriptions","organizations_url":"https://api.github.com/users/jannic/orgs","repos_url":"https://api.github.com/users/jannic/repos","events_url":"https://api.github.com/users/jannic/events{/privacy}","received_events_url":"https://api.github.com/users/jannic/received_events","type":"User","site_admin":false},"repo":{"id":89722017,"name":"trust-dns","full_name":"jannic/trust-dns","owner":{"login":"jannic","id":232606,"avatar_url":"https://avatars3.githubusercontent.com/u/232606?v=3","gravatar_id":"","url":"https://api.github.com/users/jannic","html_url":"https://github.com/jannic","followers_url":"https://api.github.com/users/jannic/followers","following_url":"https://api.github.com/users/jannic/following{/other_user}","gists_url":"https://api.github.com/users/jannic/gists{/gist_id}","starred_url":"https://api.github.com/users/jannic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannic/subscriptions","organizations_url":"https://api.github.com/users/jannic/orgs","repos_url":"https://api.github.com/users/jannic/repos","events_url":"https://api.github.com/users/jannic/events{/privacy}","received_events_url":"https://api.github.com/users/jannic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jannic/trust-dns","description":"A Rust based DNS client and server ","fork":true,"url":"https://api.github.com/repos/jannic/trust-dns","forks_url":"https://api.github.com/repos/jannic/trust-dns/forks","keys_url":"https://api.github.com/repos/jannic/trust-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jannic/trust-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jannic/trust-dns/teams","hooks_url":"https://api.github.com/repos/jannic/trust-dns/hooks","issue_events_url":"https://api.github.com/repos/jannic/trust-dns/issues/events{/number}","events_url":"https://api.github.com/repos/jannic/trust-dns/events","assignees_url":"https://api.github.com/repos/jannic/trust-dns/assignees{/user}","branches_url":"https://api.github.com/repos/jannic/trust-dns/branches{/branch}","tags_url":"https://api.github.com/repos/jannic/trust-dns/tags","blobs_url":"https://api.github.com/repos/jannic/trust-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jannic/trust-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jannic/trust-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/jannic/trust-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jannic/trust-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/jannic/trust-dns/languages","stargazers_url":"https://api.github.com/repos/jannic/trust-dns/stargazers","contributors_url":"https://api.github.com/repos/jannic/trust-dns/contributors","subscribers_url":"https://api.github.com/repos/jannic/trust-dns/subscribers","subscription_url":"https://api.github.com/repos/jannic/trust-dns/subscription","commits_url":"https://api.github.com/repos/jannic/trust-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/jannic/trust-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/jannic/trust-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/jannic/trust-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/jannic/trust-dns/contents/{+path}","compare_url":"https://api.github.com/repos/jannic/trust-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jannic/trust-dns/merges","archive_url":"https://api.github.com/repos/jannic/trust-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jannic/trust-dns/downloads","issues_url":"https://api.github.com/repos/jannic/trust-dns/issues{/number}","pulls_url":"https://api.github.com/repos/jannic/trust-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/jannic/trust-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/jannic/trust-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jannic/trust-dns/labels{/name}","releases_url":"https://api.github.com/repos/jannic/trust-dns/releases{/id}","deployments_url":"https://api.github.com/repos/jannic/trust-dns/deployments","created_at":"2017-04-28T15:58:36Z","updated_at":"2017-04-28T15:58:38Z","pushed_at":"2017-04-28T16:01:32Z","git_url":"git://github.com/jannic/trust-dns.git","ssh_url":"git@github.com:jannic/trust-dns.git","clone_url":"https://github.com/jannic/trust-dns.git","svn_url":"https://github.com/jannic/trust-dns","homepage":"","size":5060,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bluejekyll:key_flags","ref":"key_flags","sha":"f118cdca63133703ad0f98ff7db706339cbb086f","user":{"login":"bluejekyll","id":986845,"avatar_url":"https://avatars0.githubusercontent.com/u/986845?v=3","gravatar_id":"","url":"https://api.github.com/users/bluejekyll","html_url":"https://github.com/bluejekyll","followers_url":"https://api.github.com/users/bluejekyll/followers","following_url":"https://api.github.com/users/bluejekyll/following{/other_user}","gists_url":"https://api.github.com/users/bluejekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/bluejekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluejekyll/subscriptions","organizations_url":"https://api.github.com/users/bluejekyll/orgs","repos_url":"https://api.github.com/users/bluejekyll/repos","events_url":"https://api.github.com/users/bluejekyll/events{/privacy}","received_events_url":"https://api.github.com/users/bluejekyll/received_events","type":"User","site_admin":false},"repo":{"id":40389144,"name":"trust-dns","full_name":"bluejekyll/trust-dns","owner":{"login":"bluejekyll","id":986845,"avatar_url":"https://avatars0.githubusercontent.com/u/986845?v=3","gravatar_id":"","url":"https://api.github.com/users/bluejekyll","html_url":"https://github.com/bluejekyll","followers_url":"https://api.github.com/users/bluejekyll/followers","following_url":"https://api.github.com/users/bluejekyll/following{/other_user}","gists_url":"https://api.github.com/users/bluejekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/bluejekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluejekyll/subscriptions","organizations_url":"https://api.github.com/users/bluejekyll/orgs","repos_url":"https://api.github.com/users/bluejekyll/repos","events_url":"https://api.github.com/users/bluejekyll/events{/privacy}","received_events_url":"https://api.github.com/users/bluejekyll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bluejekyll/trust-dns","description":"A Rust based DNS client and server ","fork":false,"url":"https://api.github.com/repos/bluejekyll/trust-dns","forks_url":"https://api.github.com/repos/bluejekyll/trust-dns/forks","keys_url":"https://api.github.com/repos/bluejekyll/trust-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bluejekyll/trust-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bluejekyll/trust-dns/teams","hooks_url":"https://api.github.com/repos/bluejekyll/trust-dns/hooks","issue_events_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/events{/number}","events_url":"https://api.github.com/repos/bluejekyll/trust-dns/events","assignees_url":"https://api.github.com/repos/bluejekyll/trust-dns/assignees{/user}","branches_url":"https://api.github.com/repos/bluejekyll/trust-dns/branches{/branch}","tags_url":"https://api.github.com/repos/bluejekyll/trust-dns/tags","blobs_url":"https://api.github.com/repos/bluejekyll/trust-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bluejekyll/trust-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bluejekyll/trust-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/bluejekyll/trust-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bluejekyll/trust-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/bluejekyll/trust-dns/languages","stargazers_url":"https://api.github.com/repos/bluejekyll/trust-dns/stargazers","contributors_url":"https://api.github.com/repos/bluejekyll/trust-dns/contributors","subscribers_url":"https://api.github.com/repos/bluejekyll/trust-dns/subscribers","subscription_url":"https://api.github.com/repos/bluejekyll/trust-dns/subscription","commits_url":"https://api.github.com/repos/bluejekyll/trust-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/bluejekyll/trust-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/bluejekyll/trust-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/bluejekyll/trust-dns/contents/{+path}","compare_url":"https://api.github.com/repos/bluejekyll/trust-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bluejekyll/trust-dns/merges","archive_url":"https://api.github.com/repos/bluejekyll/trust-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bluejekyll/trust-dns/downloads","issues_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues{/number}","pulls_url":"https://api.github.com/repos/bluejekyll/trust-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/bluejekyll/trust-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/bluejekyll/trust-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bluejekyll/trust-dns/labels{/name}","releases_url":"https://api.github.com/repos/bluejekyll/trust-dns/releases{/id}","deployments_url":"https://api.github.com/repos/bluejekyll/trust-dns/deployments","created_at":"2015-08-08T02:47:12Z","updated_at":"2017-04-28T19:04:16Z","pushed_at":"2017-04-28T16:10:54Z","git_url":"git://github.com/bluejekyll/trust-dns.git","ssh_url":"git@github.com:bluejekyll/trust-dns.git","clone_url":"https://github.com/bluejekyll/trust-dns.git","svn_url":"https://github.com/bluejekyll/trust-dns","homepage":"","size":5048,"stargazers_count":481,"watchers_count":481,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":33,"forks":30,"open_issues":33,"watchers":481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/122"},"html":{"href":"https://github.com/bluejekyll/trust-dns/pull/122"},"issue":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/issues/122"},"comments":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/bluejekyll/trust-dns/statuses/07d01e5923dcd2cb00d510fcbbc500506664fe34"}}}}
{"actor":{"display_login":"bluejekyll"}}