{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/96475858","pull_request_review_id":17058792,"id":96475858,"diff_hunk":"@@ -203,9 +203,12 @@ Property Name                                Description\n \n ``hive.s3.aws-secret-key``                   Default AWS secret key to use.\n \n-``hive.s3.endpoint``                         The S3 storage endpoint server. This can be used to\n-                                             connect to an S3-compatible storage system instead\n-                                             of AWS.\n+``hive.s3.endpoint``                         The S3 storage endpoint server. Set this to connect to an\n+                                             S3-compatible storage system instead of AWS. You can also\n+                                             set this to AWS region-specific endpoint such as\n+                                             ``http[s]://<bucket>.s3-<AWS-region>.amazonaws.com`` if","path":"presto-docs/src/main/sphinx/connector/hive.rst","position":10,"original_position":10,"commit_id":"1548e0c041f2aa2712b7a3b652915a8d5e805b05","original_commit_id":"1548e0c041f2aa2712b7a3b652915a8d5e805b05","user":{"login":"cawallin","id":3652644,"avatar_url":"https://avatars.githubusercontent.com/u/3652644?v=3","gravatar_id":"","url":"https://api.github.com/users/cawallin","html_url":"https://github.com/cawallin","followers_url":"https://api.github.com/users/cawallin/followers","following_url":"https://api.github.com/users/cawallin/following{/other_user}","gists_url":"https://api.github.com/users/cawallin/gists{/gist_id}","starred_url":"https://api.github.com/users/cawallin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cawallin/subscriptions","organizations_url":"https://api.github.com/users/cawallin/orgs","repos_url":"https://api.github.com/users/cawallin/repos","events_url":"https://api.github.com/users/cawallin/events{/privacy}","received_events_url":"https://api.github.com/users/cawallin/received_events","type":"User","site_admin":false},"body":"Suggest: When using V4 signatures, it is recommended to set this to the AWS region-specific endpoint (e.g. ``http[s]://<bucket>.s3-<AWS-region>.amazonaws.com``).\r\n\r\nThe issue also came up when connecting to an S3 bucket in the same region as the EC2 instance where Presto is running, so we shouldn't mention the S3 bucket being in a different region.","created_at":"2017-01-17T18:23:24Z","updated_at":"2017-01-17T18:23:39Z","html_url":"https://github.com/prestodb/presto/pull/7104#discussion_r96475858","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/7104","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/96475858"},"html":{"href":"https://github.com/prestodb/presto/pull/7104#discussion_r96475858"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7104"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/7104","id":101916131,"html_url":"https://github.com/prestodb/presto/pull/7104","diff_url":"https://github.com/prestodb/presto/pull/7104.diff","patch_url":"https://github.com/prestodb/presto/pull/7104.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/7104","number":7104,"state":"open","locked":false,"title":"Document region specific S3 endpoint","user":{"login":"amrutagokhale","id":9261099,"avatar_url":"https://avatars.githubusercontent.com/u/9261099?v=3","gravatar_id":"","url":"https://api.github.com/users/amrutagokhale","html_url":"https://github.com/amrutagokhale","followers_url":"https://api.github.com/users/amrutagokhale/followers","following_url":"https://api.github.com/users/amrutagokhale/following{/other_user}","gists_url":"https://api.github.com/users/amrutagokhale/gists{/gist_id}","starred_url":"https://api.github.com/users/amrutagokhale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amrutagokhale/subscriptions","organizations_url":"https://api.github.com/users/amrutagokhale/orgs","repos_url":"https://api.github.com/users/amrutagokhale/repos","events_url":"https://api.github.com/users/amrutagokhale/events{/privacy}","received_events_url":"https://api.github.com/users/amrutagokhale/received_events","type":"User","site_admin":false},"body":"Change the description of the `hive.s3.endpoint` to document the fact that we can use it to set AWS region specific endpoints. This is useful for the case when you're accessing S3 buckets that lie in a region different than that of the EC2 instances where Presto is running.\r\n\r\nWe saw a customer case where this would have been helpful. Their attempt to access S3 buckets with ORC data was failing with a \"400 Bad Request\".  Additionally, the following warning appears in the logs:\r\n```WARNING: Attempting to re-send the request to testv4signatures-eu-central-1.s3-external-1.amazonaws.com with AWS V4 authentication. To avoid this warning in the future, please use region-specific endpoint to access buckets located in regions that require V4 signing.```\r\n\r\nAccording to https://github.com/aws/aws-sdk-java/issues/360, this might happen in a case when region is not set. ","created_at":"2017-01-17T18:04:33Z","updated_at":"2017-01-17T18:23:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a5c2da67e1ee439426c6c83343c0a3fb04ab52b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/7104/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/7104/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/7104/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/1548e0c041f2aa2712b7a3b652915a8d5e805b05","head":{"label":"Teradata:doc_s3_bucket_region","ref":"doc_s3_bucket_region","sha":"1548e0c041f2aa2712b7a3b652915a8d5e805b05","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":36903368,"name":"presto","full_name":"Teradata/presto","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto","description":"Teradata Distribution of Presto -- A Distributed SQL Query Engine for Big Data","fork":true,"url":"https://api.github.com/repos/Teradata/presto","forks_url":"https://api.github.com/repos/Teradata/presto/forks","keys_url":"https://api.github.com/repos/Teradata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto/teams","hooks_url":"https://api.github.com/repos/Teradata/presto/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto/events","assignees_url":"https://api.github.com/repos/Teradata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto/tags","blobs_url":"https://api.github.com/repos/Teradata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto/subscription","commits_url":"https://api.github.com/repos/Teradata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto/merges","archive_url":"https://api.github.com/repos/Teradata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto/downloads","issues_url":"https://api.github.com/repos/Teradata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto/deployments","created_at":"2015-06-05T00:38:37Z","updated_at":"2017-01-16T22:19:54Z","pushed_at":"2017-01-17T17:53:53Z","git_url":"git://github.com/Teradata/presto.git","ssh_url":"git@github.com:Teradata/presto.git","clone_url":"https://github.com/Teradata/presto.git","svn_url":"https://github.com/Teradata/presto","homepage":"http://www.teradata.com/presto","size":168012,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":63,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"759ad8344941ec06c646d748480275cb2cfef7ca","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2017-01-17T07:20:24Z","pushed_at":"2017-01-17T18:04:34Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":65148,"stargazers_count":5502,"watchers_count":5502,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1744,"mirror_url":null,"open_issues_count":845,"forks":1744,"open_issues":845,"watchers":5502,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7104"},"html":{"href":"https://github.com/prestodb/presto/pull/7104"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/7104"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/7104/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7104/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7104/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/1548e0c041f2aa2712b7a3b652915a8d5e805b05"}}}}
{"actor":{"display_login":"cawallin"}}