{"action":"closed","issue":{"url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/688","repository_url":"https://api.github.com/repos/GoogleChrome/lighthouse","labels_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/688/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/688/comments","events_url":"https://api.github.com/repos/GoogleChrome/lighthouse/issues/688/events","html_url":"https://github.com/GoogleChrome/lighthouse/issues/688","id":178491288,"number":688,"title":"renaming confusing config properties","user":{"login":"brendankenny","id":316891,"avatar_url":"https://avatars3.githubusercontent.com/u/316891?v=4","gravatar_id":"","url":"https://api.github.com/users/brendankenny","html_url":"https://github.com/brendankenny","followers_url":"https://api.github.com/users/brendankenny/followers","following_url":"https://api.github.com/users/brendankenny/following{/other_user}","gists_url":"https://api.github.com/users/brendankenny/gists{/gist_id}","starred_url":"https://api.github.com/users/brendankenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendankenny/subscriptions","organizations_url":"https://api.github.com/users/brendankenny/orgs","repos_url":"https://api.github.com/users/brendankenny/repos","events_url":"https://api.github.com/users/brendankenny/events{/privacy}","received_events_url":"https://api.github.com/users/brendankenny/received_events","type":"User","site_admin":false},"labels":[{"id":703688259,"url":"https://api.github.com/repos/GoogleChrome/lighthouse/labels/pending-close","name":"pending-close","color":"bfbfbf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-09-22T00:02:53Z","updated_at":"2017-09-26T22:18:18Z","closed_at":"2017-09-26T22:18:18Z","author_association":"MEMBER","body":"The config file was put together very quickly and has evolved somewhat haphazardly, so it's time to take a look at cleaning it up. Here's a list of properties in [the config file](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json) I've witnessed confuse some users, and a suggestion for how they could be changed. Feel free to bikeshed away and add more. After this we can start documenting re: #672 \n\nNote that if we change these, anyone with a custom config will be broken, so we probably want to do this right once and then stick to them until LH2.0.\n- [ ] `passes` -> `gathererPasses`\n  \n  [Example](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json#L2). \"What is a pass?\" We need to make clear this is for the gathering stage, but no need to nest within another object. @paulirish also had some notion around a name that makes it clearer these are each a page reload.\n- [x] `network` -> `recordNetwork`\n  \n  [Example](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json#L3). Needs to be clear that this isn't offline/online, but about getting a record of the network requests at the end of the pass. If not present, defaults to `false`.\n- [x] `trace` -> `recordTrace`\n  \n  [Example](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json#L4). Less necessary, but useful to be parallel to `recordNetwork`. Defaults to `false`.\n- [x] `loadPage` -> 💥\n  \n  [Example](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json#L5). I'd [still argue](https://github.com/GoogleChrome/lighthouse/issues/589) that `loadPage` isn't necessary, and the extra option is more overhead for devs using LH and for us testing LH. We haven't run into an audit that needs it or has used it yet. Moreover, it's actually non-functional right now, and fixing it would take as much effort as implementing it in the future if someone ever actually needed it. Removing it would involve deleting [a single conditional](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/gather/gather-runner.js#L125) and then from the various config files we have lying around. Currently defaults to `true` if not present, which violates assumptions about truthy/falsy.\n\nUnder `aggregations`:\n- [ ] `categorizable` -> ?\n  \n  [Example](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json#L75). It would be nice to have a more descriptive name. This is only(?) for report generation, but not at all clear from the name what it does or if it's necessary when writing a custom aggregation. It's possible documenting it may be sufficient.\n- [x] `criteria` -> `audits`?\n  \n  [Example](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json#L79). Not completely sure what we should use here, but when writing his own config, @ebidel wondered if these are just audits, why not just call them that. Would make it clear that the keys inside refer to audit names.\n- [ ] `items` -> ?\n  \n  [Example](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json#L76). Something more descriptive. Current choice might as well be `things` or `arrayValues` :)\n- [x] `rawValue` -> `expectedValue`\n  \n  [Example](https://github.com/GoogleChrome/lighthouse/blob/8c17a100a724a47ca57ed2237862c97f2f1e1f08/lighthouse-core/config/default.json#L81). From #677. I think the intention was to make the name parallel to `auditResult.rawValue`, but `rawValue` doesn't mean anything to you inside the config file.\n\nAny other ones?\n- [ ] documenting config properties\n"}}
{"actor":{"display_login":"patrickhulce"}}