{"action":"created","issue":{"url":"https://api.github.com/repos/godotengine/escoria/issues/16","repository_url":"https://api.github.com/repos/godotengine/escoria","labels_url":"https://api.github.com/repos/godotengine/escoria/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/godotengine/escoria/issues/16/comments","events_url":"https://api.github.com/repos/godotengine/escoria/issues/16/events","html_url":"https://github.com/godotengine/escoria/issues/16","id":223016518,"number":16,"title":"Rework item.gd and item_background.gd to avoid duplicated code","user":{"login":"StraToN","id":1289207,"avatar_url":"https://avatars3.githubusercontent.com/u/1289207?v=3","gravatar_id":"","url":"https://api.github.com/users/StraToN","html_url":"https://github.com/StraToN","followers_url":"https://api.github.com/users/StraToN/followers","following_url":"https://api.github.com/users/StraToN/following{/other_user}","gists_url":"https://api.github.com/users/StraToN/gists{/gist_id}","starred_url":"https://api.github.com/users/StraToN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StraToN/subscriptions","organizations_url":"https://api.github.com/users/StraToN/orgs","repos_url":"https://api.github.com/users/StraToN/repos","events_url":"https://api.github.com/users/StraToN/events{/privacy}","received_events_url":"https://api.github.com/users/StraToN/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-04-20T10:12:44Z","updated_at":"2017-05-29T22:20:58Z","closed_at":null,"body":"These 2 scripts duplicate code, that is bad. We should simplify using an item_base.gd script to be extended by item_background.gd."},"comment":{"url":"https://api.github.com/repos/godotengine/escoria/issues/comments/304738070","html_url":"https://github.com/godotengine/escoria/issues/16#issuecomment-304738070","issue_url":"https://api.github.com/repos/godotengine/escoria/issues/16","id":304738070,"user":{"login":"fleskesvor","id":672876,"avatar_url":"https://avatars0.githubusercontent.com/u/672876?v=3","gravatar_id":"","url":"https://api.github.com/users/fleskesvor","html_url":"https://github.com/fleskesvor","followers_url":"https://api.github.com/users/fleskesvor/followers","following_url":"https://api.github.com/users/fleskesvor/following{/other_user}","gists_url":"https://api.github.com/users/fleskesvor/gists{/gist_id}","starred_url":"https://api.github.com/users/fleskesvor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fleskesvor/subscriptions","organizations_url":"https://api.github.com/users/fleskesvor/orgs","repos_url":"https://api.github.com/users/fleskesvor/repos","events_url":"https://api.github.com/users/fleskesvor/events{/privacy}","received_events_url":"https://api.github.com/users/fleskesvor/received_events","type":"User","site_admin":false},"created_at":"2017-05-29T22:20:58Z","updated_at":"2017-05-29T22:20:58Z","body":"I'm not sure. Items use Control nodes for input, while item_backgrounds use Areas, so the input functions have different signatures. Can that be solved with overloading, or alternatively by giving viewport and shape_idx default values, in case the input node is a Control?"}}
{"actor":{"display_login":"fleskesvor"}}