{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/127768669","pull_request_review_id":50386743,"id":127768669,"diff_hunk":"@@ -869,6 +881,8 @@ options! {CodegenOptions, CodegenSetter, basic_codegen_options,\n         \"disable the use of the redzone\"),\n     relocation_model: Option<String> = (None, parse_opt_string, [TRACKED],\n          \"choose the relocation model to use (rustc --print relocation-models for details)\"),\n+    relro_level: Option<RelroLevel> = (None, parse_relro_level, [TRACKED],","path":"src/librustc/session/config.rs","position":48,"original_position":48,"commit_id":"ecf3f6d4def2b2aa4b268ed50a7799ce40423bc0","original_commit_id":"ecf3f6d4def2b2aa4b268ed50a7799ce40423bc0","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"@cuviper yeah that'd be a consequence of changing the defaults. I'd also be fine *not* changing the defaults and adding this option to eventually get stabilized.","created_at":"2017-07-17T17:21:21Z","updated_at":"2017-07-17T17:21:21Z","html_url":"https://github.com/rust-lang/rust/pull/43170#discussion_r127768669","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/43170","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/127768669"},"html":{"href":"https://github.com/rust-lang/rust/pull/43170#discussion_r127768669"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43170"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/43170","id":129993639,"html_url":"https://github.com/rust-lang/rust/pull/43170","diff_url":"https://github.com/rust-lang/rust/pull/43170.diff","patch_url":"https://github.com/rust-lang/rust/pull/43170.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/43170","number":43170,"state":"open","locked":false,"title":"Add support for full RELRO","user":{"login":"kyrias","id":2285387,"avatar_url":"https://avatars3.githubusercontent.com/u/2285387?v=4","gravatar_id":"","url":"https://api.github.com/users/kyrias","html_url":"https://github.com/kyrias","followers_url":"https://api.github.com/users/kyrias/followers","following_url":"https://api.github.com/users/kyrias/following{/other_user}","gists_url":"https://api.github.com/users/kyrias/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrias/subscriptions","organizations_url":"https://api.github.com/users/kyrias/orgs","repos_url":"https://api.github.com/users/kyrias/repos","events_url":"https://api.github.com/users/kyrias/events{/privacy}","received_events_url":"https://api.github.com/users/kyrias/received_events","type":"User","site_admin":false},"body":"This commit adds support for full RELRO, and enables it for the\r\nplatforms I know have support for it.\r\n\r\nFull RELRO makes the PLT+GOT data read-only on startup, preventing it\r\nfrom being overwritten.\r\n\r\nhttp://tk-blog.blogspot.com/2009/02/relro-not-so-well-known-memory.html\r\n\r\nFixes rust-lang/rust#29877.\r\n\r\n---\r\n\r\nI'm not entirely certain if this is the best way to do it, but I figured mimicking the way it's done for PIE seemed like a good start at least.  I'm not sure whether we want to have it enabled by default globally and then disabling it explicitly for targets that don't support it though.  I'm also not sure whether the `full_relro` function should call `bug!()` or something like it for linkers that don't support it rather than no-opping.","created_at":"2017-07-11T20:04:25Z","updated_at":"2017-07-17T17:21:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40dcc93b70daf1e7e7dd1a896449dd7444e79e12","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/43170/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/43170/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/43170/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/ecf3f6d4def2b2aa4b268ed50a7799ce40423bc0","head":{"label":"kyrias:full-relro","ref":"full-relro","sha":"ecf3f6d4def2b2aa4b268ed50a7799ce40423bc0","user":{"login":"kyrias","id":2285387,"avatar_url":"https://avatars3.githubusercontent.com/u/2285387?v=4","gravatar_id":"","url":"https://api.github.com/users/kyrias","html_url":"https://github.com/kyrias","followers_url":"https://api.github.com/users/kyrias/followers","following_url":"https://api.github.com/users/kyrias/following{/other_user}","gists_url":"https://api.github.com/users/kyrias/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrias/subscriptions","organizations_url":"https://api.github.com/users/kyrias/orgs","repos_url":"https://api.github.com/users/kyrias/repos","events_url":"https://api.github.com/users/kyrias/events{/privacy}","received_events_url":"https://api.github.com/users/kyrias/received_events","type":"User","site_admin":false},"repo":{"id":96872692,"name":"rust","full_name":"kyrias/rust","owner":{"login":"kyrias","id":2285387,"avatar_url":"https://avatars3.githubusercontent.com/u/2285387?v=4","gravatar_id":"","url":"https://api.github.com/users/kyrias","html_url":"https://github.com/kyrias","followers_url":"https://api.github.com/users/kyrias/followers","following_url":"https://api.github.com/users/kyrias/following{/other_user}","gists_url":"https://api.github.com/users/kyrias/gists{/gist_id}","starred_url":"https://api.github.com/users/kyrias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyrias/subscriptions","organizations_url":"https://api.github.com/users/kyrias/orgs","repos_url":"https://api.github.com/users/kyrias/repos","events_url":"https://api.github.com/users/kyrias/events{/privacy}","received_events_url":"https://api.github.com/users/kyrias/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyrias/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/kyrias/rust","forks_url":"https://api.github.com/repos/kyrias/rust/forks","keys_url":"https://api.github.com/repos/kyrias/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyrias/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyrias/rust/teams","hooks_url":"https://api.github.com/repos/kyrias/rust/hooks","issue_events_url":"https://api.github.com/repos/kyrias/rust/issues/events{/number}","events_url":"https://api.github.com/repos/kyrias/rust/events","assignees_url":"https://api.github.com/repos/kyrias/rust/assignees{/user}","branches_url":"https://api.github.com/repos/kyrias/rust/branches{/branch}","tags_url":"https://api.github.com/repos/kyrias/rust/tags","blobs_url":"https://api.github.com/repos/kyrias/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyrias/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyrias/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyrias/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyrias/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/kyrias/rust/languages","stargazers_url":"https://api.github.com/repos/kyrias/rust/stargazers","contributors_url":"https://api.github.com/repos/kyrias/rust/contributors","subscribers_url":"https://api.github.com/repos/kyrias/rust/subscribers","subscription_url":"https://api.github.com/repos/kyrias/rust/subscription","commits_url":"https://api.github.com/repos/kyrias/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyrias/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyrias/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyrias/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyrias/rust/contents/{+path}","compare_url":"https://api.github.com/repos/kyrias/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyrias/rust/merges","archive_url":"https://api.github.com/repos/kyrias/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyrias/rust/downloads","issues_url":"https://api.github.com/repos/kyrias/rust/issues{/number}","pulls_url":"https://api.github.com/repos/kyrias/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/kyrias/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/kyrias/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyrias/rust/labels{/name}","releases_url":"https://api.github.com/repos/kyrias/rust/releases{/id}","deployments_url":"https://api.github.com/repos/kyrias/rust/deployments","created_at":"2017-07-11T08:55:58Z","updated_at":"2017-07-11T08:56:21Z","pushed_at":"2017-07-14T20:55:55Z","git_url":"git://github.com/kyrias/rust.git","ssh_url":"git@github.com:kyrias/rust.git","clone_url":"https://github.com/kyrias/rust.git","svn_url":"https://github.com/kyrias/rust","homepage":"https://www.rust-lang.org","size":316356,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"ae4803a750cc415a3b8a69a68cec73400a5e27bf","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-07-17T16:50:05Z","pushed_at":"2017-07-17T17:02:25Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":317148,"stargazers_count":22618,"watchers_count":22618,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4162,"mirror_url":null,"open_issues_count":2757,"forks":4162,"open_issues":2757,"watchers":22618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43170"},"html":{"href":"https://github.com/rust-lang/rust/pull/43170"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/43170"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/43170/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43170/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43170/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/ecf3f6d4def2b2aa4b268ed50a7799ce40423bc0"}}}}
{"actor":{"display_login":"alexcrichton"}}