{"action":"opened","number":10655,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/10655","id":137623508,"html_url":"https://github.com/magento/magento2/pull/10655","diff_url":"https://github.com/magento/magento2/pull/10655.diff","patch_url":"https://github.com/magento/magento2/pull/10655.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/10655","number":10655,"state":"open","locked":false,"title":"Issue #10645 - Allow BEM class via attribute tag. Public","user":{"login":"DaniloEmpire","id":3659574,"avatar_url":"https://avatars2.githubusercontent.com/u/3659574?v=4","gravatar_id":"","url":"https://api.github.com/users/DaniloEmpire","html_url":"https://github.com/DaniloEmpire","followers_url":"https://api.github.com/users/DaniloEmpire/followers","following_url":"https://api.github.com/users/DaniloEmpire/following{/other_user}","gists_url":"https://api.github.com/users/DaniloEmpire/gists{/gist_id}","starred_url":"https://api.github.com/users/DaniloEmpire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaniloEmpire/subscriptions","organizations_url":"https://api.github.com/users/DaniloEmpire/orgs","repos_url":"https://api.github.com/users/DaniloEmpire/repos","events_url":"https://api.github.com/users/DaniloEmpire/events{/privacy}","received_events_url":"https://api.github.com/users/DaniloEmpire/received_events","type":"User","site_admin":false},"body":"### Description\r\nBefore the fix, classes with -- in them was replaced with a single - so result with input class--1 appears as class-1, breaking the BEM convention.\r\n\r\n### Fixed Issues\r\n1. magento/magento2#10645: Adding BEM class in XML via attribute tag causes class to be rewritten\r\n\r\n### Manual testing scenarios\r\n1. Go to default.xml\r\n2. Add attribute tag with a class to the body element i.e. `<attribute name=\"class\" value=\"class--1\" />`\r\n3. Clear cache and reload page\r\n\r\n### Contribution checklist\r\n - [X] Pull request has a meaningful description of its purpose\r\n - [X] All commits are accompanied by meaningful commit messages\r\n - [X] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [X] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2017-08-25T08:30:15Z","updated_at":"2017-08-25T08:30:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/10655/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/10655/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/10655/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/320e53e7103511bd25bbff3b6441fd7560905ed3","head":{"label":"DaniloEmpire:issue_10645","ref":"issue_10645","sha":"320e53e7103511bd25bbff3b6441fd7560905ed3","user":{"login":"DaniloEmpire","id":3659574,"avatar_url":"https://avatars2.githubusercontent.com/u/3659574?v=4","gravatar_id":"","url":"https://api.github.com/users/DaniloEmpire","html_url":"https://github.com/DaniloEmpire","followers_url":"https://api.github.com/users/DaniloEmpire/followers","following_url":"https://api.github.com/users/DaniloEmpire/following{/other_user}","gists_url":"https://api.github.com/users/DaniloEmpire/gists{/gist_id}","starred_url":"https://api.github.com/users/DaniloEmpire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaniloEmpire/subscriptions","organizations_url":"https://api.github.com/users/DaniloEmpire/orgs","repos_url":"https://api.github.com/users/DaniloEmpire/repos","events_url":"https://api.github.com/users/DaniloEmpire/events{/privacy}","received_events_url":"https://api.github.com/users/DaniloEmpire/received_events","type":"User","site_admin":false},"repo":{"id":101382840,"name":"magento2","full_name":"DaniloEmpire/magento2","owner":{"login":"DaniloEmpire","id":3659574,"avatar_url":"https://avatars2.githubusercontent.com/u/3659574?v=4","gravatar_id":"","url":"https://api.github.com/users/DaniloEmpire","html_url":"https://github.com/DaniloEmpire","followers_url":"https://api.github.com/users/DaniloEmpire/followers","following_url":"https://api.github.com/users/DaniloEmpire/following{/other_user}","gists_url":"https://api.github.com/users/DaniloEmpire/gists{/gist_id}","starred_url":"https://api.github.com/users/DaniloEmpire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaniloEmpire/subscriptions","organizations_url":"https://api.github.com/users/DaniloEmpire/orgs","repos_url":"https://api.github.com/users/DaniloEmpire/repos","events_url":"https://api.github.com/users/DaniloEmpire/events{/privacy}","received_events_url":"https://api.github.com/users/DaniloEmpire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaniloEmpire/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/DaniloEmpire/magento2","forks_url":"https://api.github.com/repos/DaniloEmpire/magento2/forks","keys_url":"https://api.github.com/repos/DaniloEmpire/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaniloEmpire/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaniloEmpire/magento2/teams","hooks_url":"https://api.github.com/repos/DaniloEmpire/magento2/hooks","issue_events_url":"https://api.github.com/repos/DaniloEmpire/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/DaniloEmpire/magento2/events","assignees_url":"https://api.github.com/repos/DaniloEmpire/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/DaniloEmpire/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/DaniloEmpire/magento2/tags","blobs_url":"https://api.github.com/repos/DaniloEmpire/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaniloEmpire/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaniloEmpire/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaniloEmpire/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaniloEmpire/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/DaniloEmpire/magento2/languages","stargazers_url":"https://api.github.com/repos/DaniloEmpire/magento2/stargazers","contributors_url":"https://api.github.com/repos/DaniloEmpire/magento2/contributors","subscribers_url":"https://api.github.com/repos/DaniloEmpire/magento2/subscribers","subscription_url":"https://api.github.com/repos/DaniloEmpire/magento2/subscription","commits_url":"https://api.github.com/repos/DaniloEmpire/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaniloEmpire/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaniloEmpire/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaniloEmpire/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaniloEmpire/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/DaniloEmpire/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaniloEmpire/magento2/merges","archive_url":"https://api.github.com/repos/DaniloEmpire/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaniloEmpire/magento2/downloads","issues_url":"https://api.github.com/repos/DaniloEmpire/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/DaniloEmpire/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/DaniloEmpire/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/DaniloEmpire/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaniloEmpire/magento2/labels{/name}","releases_url":"https://api.github.com/repos/DaniloEmpire/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/DaniloEmpire/magento2/deployments","created_at":"2017-08-25T08:22:59Z","updated_at":"2017-08-25T08:24:00Z","pushed_at":"2017-08-25T08:28:55Z","git_url":"git://github.com/DaniloEmpire/magento2.git","ssh_url":"git@github.com:DaniloEmpire/magento2.git","clone_url":"https://github.com/DaniloEmpire/magento2.git","svn_url":"https://github.com/DaniloEmpire/magento2","homepage":"http://www.magento.com","size":386040,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"magento:develop","ref":"develop","sha":"24f2f071267f9e5ba0d5428b75fcbc76e6ef5b55","user":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2017-08-24T16:58:33Z","pushed_at":"2017-08-25T03:13:09Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":386040,"stargazers_count":4675,"watchers_count":4675,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3582,"mirror_url":null,"open_issues_count":2500,"forks":3582,"open_issues":2500,"watchers":4675,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/10655"},"html":{"href":"https://github.com/magento/magento2/pull/10655"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/10655"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/10655/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/10655/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/10655/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/320e53e7103511bd25bbff3b6441fd7560905ed3"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":4,"changed_files":3}}
{"actor":{"display_login":"DaniloEmpire"}}