{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18824","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18824/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18824/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18824/events","html_url":"https://github.com/TrinityCore/TrinityCore/issues/18824","id":200702319,"number":18824,"title":"[3.3.5] Bosses respawning","user":{"login":"Keader","id":7120913,"avatar_url":"https://avatars.githubusercontent.com/u/7120913?v=3","gravatar_id":"","url":"https://api.github.com/users/Keader","html_url":"https://github.com/Keader","followers_url":"https://api.github.com/users/Keader/followers","following_url":"https://api.github.com/users/Keader/following{/other_user}","gists_url":"https://api.github.com/users/Keader/gists{/gist_id}","starred_url":"https://api.github.com/users/Keader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keader/subscriptions","organizations_url":"https://api.github.com/users/Keader/orgs","repos_url":"https://api.github.com/users/Keader/repos","events_url":"https://api.github.com/users/Keader/events{/privacy}","received_events_url":"https://api.github.com/users/Keader/received_events","type":"User","site_admin":false},"labels":[{"id":36087725,"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Branch-3.3.5a","name":"Branch-3.3.5a","color":"188846","default":false},{"id":26232644,"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600","default":false},{"id":104773,"url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Sub-Instances","name":"Sub-Instances","color":"e10c02","default":false}],"state":"open","locked":false,"assignee":{"login":"Treeston","id":14020072,"avatar_url":"https://avatars.githubusercontent.com/u/14020072?v=3","gravatar_id":"","url":"https://api.github.com/users/Treeston","html_url":"https://github.com/Treeston","followers_url":"https://api.github.com/users/Treeston/followers","following_url":"https://api.github.com/users/Treeston/following{/other_user}","gists_url":"https://api.github.com/users/Treeston/gists{/gist_id}","starred_url":"https://api.github.com/users/Treeston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Treeston/subscriptions","organizations_url":"https://api.github.com/users/Treeston/orgs","repos_url":"https://api.github.com/users/Treeston/repos","events_url":"https://api.github.com/users/Treeston/events{/privacy}","received_events_url":"https://api.github.com/users/Treeston/received_events","type":"User","site_admin":false},"assignees":[{"login":"Treeston","id":14020072,"avatar_url":"https://avatars.githubusercontent.com/u/14020072?v=3","gravatar_id":"","url":"https://api.github.com/users/Treeston","html_url":"https://github.com/Treeston","followers_url":"https://api.github.com/users/Treeston/followers","following_url":"https://api.github.com/users/Treeston/following{/other_user}","gists_url":"https://api.github.com/users/Treeston/gists{/gist_id}","starred_url":"https://api.github.com/users/Treeston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Treeston/subscriptions","organizations_url":"https://api.github.com/users/Treeston/orgs","repos_url":"https://api.github.com/users/Treeston/repos","events_url":"https://api.github.com/users/Treeston/events{/privacy}","received_events_url":"https://api.github.com/users/Treeston/received_events","type":"User","site_admin":false}],"milestone":null,"comments":27,"created_at":"2017-01-13T18:50:29Z","updated_at":"2017-01-25T17:32:02Z","closed_at":null,"body":"**Description:** Bosses can respawn after you kill him.\r\n\r\n**Expected behaviour:** Boss should never respawn after you kill him (after state = DONE).\r\n\r\n**Steps to reproduce the problem:**\r\n\r\n1. Kill some boss\r\n2. Wait respawn\r\n\r\nIt was fixed by this commit: f826ecb4b2e8cc1fa54419947dff041a580d9c03\r\nBut reverted in : b3d44d6c366c7e4f12a6ce30ee5cf6b9bff68a06\r\n\r\nNow need a new solution to fix Bosses without entry in linked_respawn.\r\n\r\n**Branch(es):** 3.3.5\r\n\r\n**TC rev. hash/commit:**  a17e3673b2d775db12ff16cba928648200679889"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/275175298","html_url":"https://github.com/TrinityCore/TrinityCore/issues/18824#issuecomment-275175298","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/18824","id":275175298,"user":{"login":"Keader","id":7120913,"avatar_url":"https://avatars.githubusercontent.com/u/7120913?v=3","gravatar_id":"","url":"https://api.github.com/users/Keader","html_url":"https://github.com/Keader","followers_url":"https://api.github.com/users/Keader/followers","following_url":"https://api.github.com/users/Keader/following{/other_user}","gists_url":"https://api.github.com/users/Keader/gists{/gist_id}","starred_url":"https://api.github.com/users/Keader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keader/subscriptions","organizations_url":"https://api.github.com/users/Keader/orgs","repos_url":"https://api.github.com/users/Keader/repos","events_url":"https://api.github.com/users/Keader/events{/privacy}","received_events_url":"https://api.github.com/users/Keader/received_events","type":"User","site_admin":false},"created_at":"2017-01-25T17:32:01Z","updated_at":"2017-01-25T17:32:01Z","body":"I removed princes spawn, they are summoned by controller (like illidari council in black temple).\r\nSo, if they respawn is because controller respawn. Controller has BossAI and using that code should never respawn.\r\n\r\n```diff\r\ndiff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp\r\nindex a6ec97c..fbab3f9 100644\r\n--- a/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp\r\n+++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_blood_prince_council.cpp\r\n@@ -208,10 +208,10 @@ uint32 const PrincesData[] =\r\n     DATA_PRINCE_VALANAR\r\n };\r\n \r\n-class boss_blood_council_controller : public CreatureScript\r\n+class boss_blood_council_controller : public BossCreatureScript\r\n {\r\n     public:\r\n-        boss_blood_council_controller() : CreatureScript(\"boss_blood_council_controller\") { }\r\n+        boss_blood_council_controller() : BossCreatureScript(\"boss_blood_council_controller\", DATA_BLOOD_PRINCE_COUNCIL) { }\r\n \r\n         struct boss_blood_council_controllerAI : public BossAI\r\n         {\r\n```\r\n\r\n@Noryad BossState = 3 (DONE) when you build this code ?"}}
{"actor":{"display_login":"Keader"}}