{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/144900130","pull_request_review_id":69620331,"id":144900130,"diff_hunk":"@@ -121,6 +121,10 @@ public override IList TransformList(IList collection)\n \t\t/// same visibility and inheritance depth.</exception>\n \t\tprivate void SetProperty(string alias, object value, object resultObj)\n \t\t{\n+\t\t\tif (alias == null)\n+\t\t\t\t// Grouping properties in criteria are selected without alias, just ignore them.\n+\t\t\t\treturn;","path":"src/NHibernate/Transform/AliasToBeanResultTransformer.cs","position":6,"original_position":6,"commit_id":"a87a23bcd6fcc4b8c5d69289be873d4845718756","original_commit_id":"a87a23bcd6fcc4b8c5d69289be873d4845718756","user":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars2.githubusercontent.com/u/12201973?v=4","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"body":"The fix. Reintroduces the check removed [here](https://github.com/nhibernate/nhibernate-core/pull/597/commits/9491f57aca2264e293889dc960e49ddfb20350f8#diff-e431ffcf2f1f91c671a967d74bcb1252L85) without us spotting it and questioning it.","created_at":"2017-10-16T16:36:50Z","updated_at":"2017-10-16T16:37:07Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1380#discussion_r144900130","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1380","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/144900130"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/1380#discussion_r144900130"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1380"}}},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1380","id":146666694,"html_url":"https://github.com/nhibernate/nhibernate-core/pull/1380","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/1380.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/1380.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1380","number":1380,"state":"open","locked":false,"title":"Added unit test for issue#750","user":{"login":"mazharqayyum","id":569356,"avatar_url":"https://avatars0.githubusercontent.com/u/569356?v=4","gravatar_id":"","url":"https://api.github.com/users/mazharqayyum","html_url":"https://github.com/mazharqayyum","followers_url":"https://api.github.com/users/mazharqayyum/followers","following_url":"https://api.github.com/users/mazharqayyum/following{/other_user}","gists_url":"https://api.github.com/users/mazharqayyum/gists{/gist_id}","starred_url":"https://api.github.com/users/mazharqayyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazharqayyum/subscriptions","organizations_url":"https://api.github.com/users/mazharqayyum/orgs","repos_url":"https://api.github.com/users/mazharqayyum/repos","events_url":"https://api.github.com/users/mazharqayyum/events{/privacy}","received_events_url":"https://api.github.com/users/mazharqayyum/received_events","type":"User","site_admin":false},"body":"…ues/750\r\n\r\nI have created the unit test to demonstrate exception happening due to AliasToBean result transformer. The related issue is https://github.com/nhibernate/nhibernate-core/issues/750","created_at":"2017-10-15T20:15:51Z","updated_at":"2017-10-16T16:37:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7920a61c76b5e89c9f62f1ae1b2f4acc305ec3b2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones/10","html_url":"https://github.com/nhibernate/nhibernate-core/milestone/10","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones/10/labels","id":2831824,"number":10,"title":"5.0.1","description":null,"creator":{"login":"hazzik","id":144791,"avatar_url":"https://avatars1.githubusercontent.com/u/144791?v=4","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":11,"state":"open","created_at":"2017-10-12T00:03:40Z","updated_at":"2017-10-16T16:25:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1380/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1380/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1380/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/a87a23bcd6fcc4b8c5d69289be873d4845718756","head":{"label":"mazharqayyum:master","ref":"master","sha":"a87a23bcd6fcc4b8c5d69289be873d4845718756","user":{"login":"mazharqayyum","id":569356,"avatar_url":"https://avatars0.githubusercontent.com/u/569356?v=4","gravatar_id":"","url":"https://api.github.com/users/mazharqayyum","html_url":"https://github.com/mazharqayyum","followers_url":"https://api.github.com/users/mazharqayyum/followers","following_url":"https://api.github.com/users/mazharqayyum/following{/other_user}","gists_url":"https://api.github.com/users/mazharqayyum/gists{/gist_id}","starred_url":"https://api.github.com/users/mazharqayyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazharqayyum/subscriptions","organizations_url":"https://api.github.com/users/mazharqayyum/orgs","repos_url":"https://api.github.com/users/mazharqayyum/repos","events_url":"https://api.github.com/users/mazharqayyum/events{/privacy}","received_events_url":"https://api.github.com/users/mazharqayyum/received_events","type":"User","site_admin":false},"repo":{"id":106863107,"name":"nhibernate-core","full_name":"mazharqayyum/nhibernate-core","owner":{"login":"mazharqayyum","id":569356,"avatar_url":"https://avatars0.githubusercontent.com/u/569356?v=4","gravatar_id":"","url":"https://api.github.com/users/mazharqayyum","html_url":"https://github.com/mazharqayyum","followers_url":"https://api.github.com/users/mazharqayyum/followers","following_url":"https://api.github.com/users/mazharqayyum/following{/other_user}","gists_url":"https://api.github.com/users/mazharqayyum/gists{/gist_id}","starred_url":"https://api.github.com/users/mazharqayyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazharqayyum/subscriptions","organizations_url":"https://api.github.com/users/mazharqayyum/orgs","repos_url":"https://api.github.com/users/mazharqayyum/repos","events_url":"https://api.github.com/users/mazharqayyum/events{/privacy}","received_events_url":"https://api.github.com/users/mazharqayyum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mazharqayyum/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/mazharqayyum/nhibernate-core","forks_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/forks","keys_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/events","assignees_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/merges","archive_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/mazharqayyum/nhibernate-core/deployments","created_at":"2017-10-13T19:04:47Z","updated_at":"2017-10-13T19:05:01Z","pushed_at":"2017-10-16T16:28:49Z","git_url":"git://github.com/mazharqayyum/nhibernate-core.git","ssh_url":"git@github.com:mazharqayyum/nhibernate-core.git","clone_url":"https://github.com/mazharqayyum/nhibernate-core.git","svn_url":"https://github.com/mazharqayyum/nhibernate-core","homepage":"http://nhibernate.info","size":80664,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"903494f4e1abdb2ee1fe0351f6d44d9b312a479f","user":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","owner":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/deployments","created_at":"2011-08-14T17:51:09Z","updated_at":"2017-10-16T09:37:48Z","pushed_at":"2017-10-16T16:28:51Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":80777,"stargazers_count":1216,"watchers_count":1216,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":720,"mirror_url":null,"open_issues_count":713,"forks":720,"open_issues":713,"watchers":1216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1380"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/1380"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1380"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1380/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1380/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1380/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/a87a23bcd6fcc4b8c5d69289be873d4845718756"}},"author_association":"NONE"}}
{"actor":{"display_login":"fredericDelaporte"}}