{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/38972","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/38972/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/38972/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/38972/events","html_url":"https://github.com/rust-lang/rust/issues/38972","id":199959960,"number":38972,"title":"Irrefutable while-let pattern in log4rs-rolling-file-0.2.0, Rust 1.16","user":{"login":"brson","id":147214,"avatar_url":"https://avatars.githubusercontent.com/u/147214?v=3","gravatar_id":"","url":"https://api.github.com/users/brson","html_url":"https://github.com/brson","followers_url":"https://api.github.com/users/brson/followers","following_url":"https://api.github.com/users/brson/following{/other_user}","gists_url":"https://api.github.com/users/brson/gists{/gist_id}","starred_url":"https://api.github.com/users/brson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brson/subscriptions","organizations_url":"https://api.github.com/users/brson/orgs","repos_url":"https://api.github.com/users/brson/repos","events_url":"https://api.github.com/users/brson/events{/privacy}","received_events_url":"https://api.github.com/users/brson/received_events","type":"User","site_admin":false},"labels":[{"id":37544,"url":"https://api.github.com/repos/rust-lang/rust/labels/A-typesystem","name":"A-typesystem","color":"d7e102","default":false},{"id":203429200,"url":"https://api.github.com/repos/rust-lang/rust/labels/P-high","name":"P-high","color":"eb6420","default":false},{"id":147085028,"url":"https://api.github.com/repos/rust-lang/rust/labels/regression-from-stable-to-nightly","name":"regression-from-stable-to-nightly","color":"FF309F","default":false},{"id":211668100,"url":"https://api.github.com/repos/rust-lang/rust/labels/T-compiler","name":"T-compiler","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-01-10T23:10:34Z","updated_at":"2017-01-27T13:29:30Z","closed_at":null,"body":"https://github.com/sfackler/log4rs-rolling-file 1ce36b4301c86fa750134d35cb815d146c5836ee\r\n\r\nNot on stable/beta.\r\n\r\n```\r\n101 brian@ip-10-145-43-250:~⟫ rustc +nightly -Vv\r\nrustc 1.16.0-nightly (47c8d9fdc 2017-01-08)\r\nbinary: rustc\r\ncommit-hash: 47c8d9fdcf2e6502cf4ca7d7f059fdc1a2810afa\r\ncommit-date: 2017-01-08\r\nhost: x86_64-unknown-linux-gnu\r\nrelease: 1.16.0-nightly\r\nLLVM version: 3.9\r\n```\r\n\r\n```\r\nbrian@ip-10-145-43-250:~/dev/log4rs-rolling-file⟫ cargo +nightly test\r\n   Compiling crossbeam v0.2.10\r\n   Compiling serde v0.7.15\r\n   Compiling libc v0.2.19\r\n   Compiling traitobject v0.0.3\r\n   Compiling unsafe-any v0.4.1\r\n   Compiling typemap v0.3.3\r\n   Compiling winapi-build v0.1.1\r\n   Compiling yaml-rust v0.3.5\r\n   Compiling kernel32-sys v0.2.2\r\n   Compiling num-traits v0.1.36\r\n   Compiling log v0.3.6\r\n   Compiling winapi v0.2.8\r\n   Compiling time v0.1.35\r\n   Compiling num-integer v0.1.32\r\n   Compiling num-iter v0.1.32\r\n   Compiling rand v0.3.15\r\n   Compiling quick-error v1.1.0\r\n   Compiling num v0.1.36\r\n   Compiling chrono v0.2.25\r\n   Compiling humantime v0.1.3\r\n   Compiling serde_yaml v0.2.5\r\n   Compiling ordered-float v0.1.0\r\n   Compiling serde-value v0.2.1\r\n   Compiling antidote v1.0.0\r\n   Compiling tempdir v0.3.5\r\n   Compiling log4rs v0.4.8\r\n   Compiling log4rs-rolling-file v0.2.0 (file:///mnt2/dev/log4rs-rolling-file)\r\nerror[E0165]: irrefutable while-let pattern\r\n  --> src/policy/compound/roll/delete/config.rs:81:43\r\n   |\r\n81 |                                 while let Some(key) =\r\n   |                                           ^^^^^^^^^ irrefutable pattern\r\n\r\nerror: aborting due to previous error\r\n\r\nBuild failed, waiting for other jobs to finish...\r\nerror[E0165]: irrefutable while-let pattern\r\n  --> src/policy/compound/roll/delete/config.rs:81:43\r\n   |\r\n81 |                                 while let Some(key) =\r\n   |                                           ^^^^^^^^^ irrefutable pattern\r\n\r\nerror: aborting due to previous error\r\n\r\nerror: Could not compile `log4rs-rolling-file`.\r\n\r\nTo learn more, run the command again with --verbose.\r\n```\r\n\r\nThis case is interesting. The loop is generated by serde and from inspection seems be a degenerate case. I can't tell if it was previously right or wrong.\r\n\r\ncc @sfackler @erickt \r\n```"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/275665175","html_url":"https://github.com/rust-lang/rust/issues/38972#issuecomment-275665175","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/38972","id":275665175,"user":{"login":"canndrew","id":5555066,"avatar_url":"https://avatars.githubusercontent.com/u/5555066?v=3","gravatar_id":"","url":"https://api.github.com/users/canndrew","html_url":"https://github.com/canndrew","followers_url":"https://api.github.com/users/canndrew/followers","following_url":"https://api.github.com/users/canndrew/following{/other_user}","gists_url":"https://api.github.com/users/canndrew/gists{/gist_id}","starred_url":"https://api.github.com/users/canndrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canndrew/subscriptions","organizations_url":"https://api.github.com/users/canndrew/orgs","repos_url":"https://api.github.com/users/canndrew/repos","events_url":"https://api.github.com/users/canndrew/events{/privacy}","received_events_url":"https://api.github.com/users/canndrew/received_events","type":"User","site_admin":false},"created_at":"2017-01-27T13:29:30Z","updated_at":"2017-01-27T13:29:30Z","body":"Yeah, this should be fixed properly."}}
{"actor":{"display_login":"canndrew"}}