{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/123873368","pull_request_review_id":46122138,"id":123873368,"diff_hunk":"@@ -1485,6 +1485,23 @@ end\n using .DSP\n export conv, conv2, deconv, filt, filt!, xcorr\n \n+# PR #22475\n+@deprecate ntuple{N}(f, ::Type{Val{N}}) ntuple(f, Val(N))\n+@deprecate fill_to_length{N}(t, val, ::Type{Val{N}}) fill_to_length(t, val, Val(N))\n+@deprecate literal_pow{N}(a,b , ::Type{Val{N}}) literal_pow(f, Val(N))\n+#@deprecate IteratorsMD.split(t, V::Type{Val{n}}) IteratorsMD.split(t, Val(n))","path":"base/deprecated.jl","position":8,"original_position":8,"commit_id":"85d730e27b4670c236bfc511d871ed729af64aea","original_commit_id":"85d730e27b4670c236bfc511d871ed729af64aea","user":{"login":"fredrikekre","id":11698744,"avatar_url":"https://avatars1.githubusercontent.com/u/11698744?v=3","gravatar_id":"","url":"https://api.github.com/users/fredrikekre","html_url":"https://github.com/fredrikekre","followers_url":"https://api.github.com/users/fredrikekre/followers","following_url":"https://api.github.com/users/fredrikekre/following{/other_user}","gists_url":"https://api.github.com/users/fredrikekre/gists{/gist_id}","starred_url":"https://api.github.com/users/fredrikekre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredrikekre/subscriptions","organizations_url":"https://api.github.com/users/fredrikekre/orgs","repos_url":"https://api.github.com/users/fredrikekre/repos","events_url":"https://api.github.com/users/fredrikekre/events{/privacy}","received_events_url":"https://api.github.com/users/fredrikekre/received_events","type":"User","site_admin":false},"body":"You can `@eval` the deprecation into the `IteratorsMS` module.","created_at":"2017-06-24T08:24:05Z","updated_at":"2017-06-24T08:24:05Z","html_url":"https://github.com/JuliaLang/julia/pull/22475#discussion_r123873368","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22475","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/123873368"},"html":{"href":"https://github.com/JuliaLang/julia/pull/22475#discussion_r123873368"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22475"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/22475","id":126925406,"html_url":"https://github.com/JuliaLang/julia/pull/22475","diff_url":"https://github.com/JuliaLang/julia/pull/22475.diff","patch_url":"https://github.com/JuliaLang/julia/pull/22475.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/22475","number":22475,"state":"open","locked":false,"title":"Use Val(x) and f(::Val{x})","user":{"login":"andyferris","id":2974526,"avatar_url":"https://avatars0.githubusercontent.com/u/2974526?v=3","gravatar_id":"","url":"https://api.github.com/users/andyferris","html_url":"https://github.com/andyferris","followers_url":"https://api.github.com/users/andyferris/followers","following_url":"https://api.github.com/users/andyferris/following{/other_user}","gists_url":"https://api.github.com/users/andyferris/gists{/gist_id}","starred_url":"https://api.github.com/users/andyferris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyferris/subscriptions","organizations_url":"https://api.github.com/users/andyferris/orgs","repos_url":"https://api.github.com/users/andyferris/repos","events_url":"https://api.github.com/users/andyferris/events{/privacy}","received_events_url":"https://api.github.com/users/andyferris/received_events","type":"User","site_admin":false},"body":"@JeffBezanson as discussed. Instead of calling `f(Val{x})` and method definitions `f(::Type{Val{x}}) where x = ...`, we use `f(Val(x))` and `f(::Val{x}) where x = ...`. There is a new `@pure` function for `Val(x) -> Val{x}()`, a `show` override, and a docstring/doctest.\r\n\r\n~~This is WIP and so far only \"upgrades\" two functions (`ntuple` and `fill_to_length`). I am currently intending to replace~~ I have replaced all uses of `Val{x}` in `Base` with the new constructor (except for specific inference tests targeting type parameters).\r\n\r\nAlso, what does this mean when building? I'm kind-of lost with the documentation system.\r\n\r\n> WARNING: replacing docs for 'Base.Val :: Union{}' in module 'Base'.\r\n","created_at":"2017-06-22T07:26:30Z","updated_at":"2017-06-24T08:24:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24fde05b5fd4ab9284b688a386e150df3df5a4c8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22475/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22475/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/22475/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/85d730e27b4670c236bfc511d871ed729af64aea","head":{"label":"andyferris:master","ref":"master","sha":"85d730e27b4670c236bfc511d871ed729af64aea","user":{"login":"andyferris","id":2974526,"avatar_url":"https://avatars0.githubusercontent.com/u/2974526?v=3","gravatar_id":"","url":"https://api.github.com/users/andyferris","html_url":"https://github.com/andyferris","followers_url":"https://api.github.com/users/andyferris/followers","following_url":"https://api.github.com/users/andyferris/following{/other_user}","gists_url":"https://api.github.com/users/andyferris/gists{/gist_id}","starred_url":"https://api.github.com/users/andyferris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyferris/subscriptions","organizations_url":"https://api.github.com/users/andyferris/orgs","repos_url":"https://api.github.com/users/andyferris/repos","events_url":"https://api.github.com/users/andyferris/events{/privacy}","received_events_url":"https://api.github.com/users/andyferris/received_events","type":"User","site_admin":false},"repo":{"id":61960975,"name":"julia","full_name":"andyferris/julia","owner":{"login":"andyferris","id":2974526,"avatar_url":"https://avatars0.githubusercontent.com/u/2974526?v=3","gravatar_id":"","url":"https://api.github.com/users/andyferris","html_url":"https://github.com/andyferris","followers_url":"https://api.github.com/users/andyferris/followers","following_url":"https://api.github.com/users/andyferris/following{/other_user}","gists_url":"https://api.github.com/users/andyferris/gists{/gist_id}","starred_url":"https://api.github.com/users/andyferris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyferris/subscriptions","organizations_url":"https://api.github.com/users/andyferris/orgs","repos_url":"https://api.github.com/users/andyferris/repos","events_url":"https://api.github.com/users/andyferris/events{/privacy}","received_events_url":"https://api.github.com/users/andyferris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andyferris/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/andyferris/julia","forks_url":"https://api.github.com/repos/andyferris/julia/forks","keys_url":"https://api.github.com/repos/andyferris/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andyferris/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andyferris/julia/teams","hooks_url":"https://api.github.com/repos/andyferris/julia/hooks","issue_events_url":"https://api.github.com/repos/andyferris/julia/issues/events{/number}","events_url":"https://api.github.com/repos/andyferris/julia/events","assignees_url":"https://api.github.com/repos/andyferris/julia/assignees{/user}","branches_url":"https://api.github.com/repos/andyferris/julia/branches{/branch}","tags_url":"https://api.github.com/repos/andyferris/julia/tags","blobs_url":"https://api.github.com/repos/andyferris/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andyferris/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andyferris/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/andyferris/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andyferris/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/andyferris/julia/languages","stargazers_url":"https://api.github.com/repos/andyferris/julia/stargazers","contributors_url":"https://api.github.com/repos/andyferris/julia/contributors","subscribers_url":"https://api.github.com/repos/andyferris/julia/subscribers","subscription_url":"https://api.github.com/repos/andyferris/julia/subscription","commits_url":"https://api.github.com/repos/andyferris/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/andyferris/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/andyferris/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/andyferris/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/andyferris/julia/contents/{+path}","compare_url":"https://api.github.com/repos/andyferris/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andyferris/julia/merges","archive_url":"https://api.github.com/repos/andyferris/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andyferris/julia/downloads","issues_url":"https://api.github.com/repos/andyferris/julia/issues{/number}","pulls_url":"https://api.github.com/repos/andyferris/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/andyferris/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/andyferris/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andyferris/julia/labels{/name}","releases_url":"https://api.github.com/repos/andyferris/julia/releases{/id}","deployments_url":"https://api.github.com/repos/andyferris/julia/deployments","created_at":"2016-06-25T20:46:08Z","updated_at":"2016-06-25T20:46:15Z","pushed_at":"2017-06-24T06:59:22Z","git_url":"git://github.com/andyferris/julia.git","ssh_url":"git@github.com:andyferris/julia.git","clone_url":"https://github.com/andyferris/julia.git","svn_url":"https://github.com/andyferris/julia","homepage":"http://julialang.org/","size":114467,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"d04015144f1cd3daa2f53473beb22bff417ac692","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars3.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars3.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2017-06-23T21:30:56Z","pushed_at":"2017-06-24T06:59:24Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":184719,"stargazers_count":8795,"watchers_count":8795,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1997,"mirror_url":null,"open_issues_count":2336,"forks":1997,"open_issues":2336,"watchers":8795,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22475"},"html":{"href":"https://github.com/JuliaLang/julia/pull/22475"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/22475"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/22475/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22475/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22475/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/85d730e27b4670c236bfc511d871ed729af64aea"}}}}
{"actor":{"display_login":"fredrikekre"}}