{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/120104672","pull_request_review_id":42034042,"id":120104672,"diff_hunk":"@@ -0,0 +1,120 @@\n+package com.mapswithme.maps.news;\n+\n+import android.app.Dialog;\n+import android.os.Bundle;\n+import android.support.annotation.NonNull;\n+import android.support.annotation.Nullable;\n+import android.support.v4.app.Fragment;\n+import android.support.v4.app.FragmentActivity;\n+import android.support.v4.app.FragmentManager;\n+import android.text.Html;\n+import android.text.method.LinkMovementMethod;\n+import android.view.View;\n+import android.view.Window;\n+import android.widget.ImageView;\n+import android.widget.TextView;\n+\n+import com.mapswithme.maps.BuildConfig;\n+import com.mapswithme.maps.R;\n+import com.mapswithme.maps.base.BaseMwmDialogFragment;\n+import com.mapswithme.maps.location.LocationHelper;\n+import com.mapswithme.util.Counters;\n+import com.mapswithme.util.UiUtils;\n+\n+public class WelcomeDialogFragment extends BaseMwmDialogFragment implements View.OnClickListener\n+{\n+  @Nullable\n+  private BaseNewsFragment.NewsDialogListener mListener;","path":"android/src/com/mapswithme/maps/news/WelcomeDialogFragment.java","position":27,"original_position":27,"commit_id":"83566c48ea860610de5ae1f05d821f48778ed663","original_commit_id":"83566c48ea860610de5ae1f05d821f48778ed663","user":{"login":"alexzatsepin","id":8442156,"avatar_url":"https://avatars1.githubusercontent.com/u/8442156?v=3","gravatar_id":"","url":"https://api.github.com/users/alexzatsepin","html_url":"https://github.com/alexzatsepin","followers_url":"https://api.github.com/users/alexzatsepin/followers","following_url":"https://api.github.com/users/alexzatsepin/following{/other_user}","gists_url":"https://api.github.com/users/alexzatsepin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexzatsepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexzatsepin/subscriptions","organizations_url":"https://api.github.com/users/alexzatsepin/orgs","repos_url":"https://api.github.com/users/alexzatsepin/repos","events_url":"https://api.github.com/users/alexzatsepin/events{/privacy}","received_events_url":"https://api.github.com/users/alexzatsepin/received_events","type":"User","site_admin":false},"body":"Предлагаю делать запись листенера в onAttach и в onDetach его занулять. Так будет более правильно и красиво, не надо будет напрямую параметр передавать","created_at":"2017-06-05T13:13:50Z","updated_at":"2017-06-05T13:54:36Z","html_url":"https://github.com/mapsme/omim/pull/6163#discussion_r120104672","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/6163","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/120104672"},"html":{"href":"https://github.com/mapsme/omim/pull/6163#discussion_r120104672"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6163"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/6163","id":123242109,"html_url":"https://github.com/mapsme/omim/pull/6163","diff_url":"https://github.com/mapsme/omim/pull/6163.diff","patch_url":"https://github.com/mapsme/omim/pull/6163.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/6163","number":6163,"state":"open","locked":false,"title":"[android] Dynamic permissions dialogs","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars1.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"body":"https://jira.mail.ru/browse/MAPSME-4570\r\n\r\n@alexzatsepin @milchakov PTAL","created_at":"2017-05-31T10:27:03Z","updated_at":"2017-06-05T13:54:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3b0feb8ef12eec85c4b1ab308271bae79a5c9bd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"milchakov","id":2606569,"avatar_url":"https://avatars2.githubusercontent.com/u/2606569?v=3","gravatar_id":"","url":"https://api.github.com/users/milchakov","html_url":"https://github.com/milchakov","followers_url":"https://api.github.com/users/milchakov/followers","following_url":"https://api.github.com/users/milchakov/following{/other_user}","gists_url":"https://api.github.com/users/milchakov/gists{/gist_id}","starred_url":"https://api.github.com/users/milchakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milchakov/subscriptions","organizations_url":"https://api.github.com/users/milchakov/orgs","repos_url":"https://api.github.com/users/milchakov/repos","events_url":"https://api.github.com/users/milchakov/events{/privacy}","received_events_url":"https://api.github.com/users/milchakov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/6163/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/6163/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/6163/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/83566c48ea860610de5ae1f05d821f48778ed663","head":{"label":"goblinr:MAPSME-4570-permissions-onboarding-dialog","ref":"MAPSME-4570-permissions-onboarding-dialog","sha":"83566c48ea860610de5ae1f05d821f48778ed663","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars1.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"repo":{"id":68004519,"name":"omim","full_name":"goblinr/omim","owner":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars1.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goblinr/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/goblinr/omim","forks_url":"https://api.github.com/repos/goblinr/omim/forks","keys_url":"https://api.github.com/repos/goblinr/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goblinr/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goblinr/omim/teams","hooks_url":"https://api.github.com/repos/goblinr/omim/hooks","issue_events_url":"https://api.github.com/repos/goblinr/omim/issues/events{/number}","events_url":"https://api.github.com/repos/goblinr/omim/events","assignees_url":"https://api.github.com/repos/goblinr/omim/assignees{/user}","branches_url":"https://api.github.com/repos/goblinr/omim/branches{/branch}","tags_url":"https://api.github.com/repos/goblinr/omim/tags","blobs_url":"https://api.github.com/repos/goblinr/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goblinr/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goblinr/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/goblinr/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goblinr/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/goblinr/omim/languages","stargazers_url":"https://api.github.com/repos/goblinr/omim/stargazers","contributors_url":"https://api.github.com/repos/goblinr/omim/contributors","subscribers_url":"https://api.github.com/repos/goblinr/omim/subscribers","subscription_url":"https://api.github.com/repos/goblinr/omim/subscription","commits_url":"https://api.github.com/repos/goblinr/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/goblinr/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/goblinr/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/goblinr/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/goblinr/omim/contents/{+path}","compare_url":"https://api.github.com/repos/goblinr/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goblinr/omim/merges","archive_url":"https://api.github.com/repos/goblinr/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goblinr/omim/downloads","issues_url":"https://api.github.com/repos/goblinr/omim/issues{/number}","pulls_url":"https://api.github.com/repos/goblinr/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/goblinr/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/goblinr/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goblinr/omim/labels{/name}","releases_url":"https://api.github.com/repos/goblinr/omim/releases{/id}","deployments_url":"https://api.github.com/repos/goblinr/omim/deployments","created_at":"2016-09-12T11:50:39Z","updated_at":"2016-09-12T11:52:10Z","pushed_at":"2017-06-05T12:28:43Z","git_url":"git://github.com/goblinr/omim.git","ssh_url":"git@github.com:goblinr/omim.git","clone_url":"https://github.com/goblinr/omim.git","svn_url":"https://github.com/goblinr/omim","homepage":null,"size":3154923,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"02bc7f892c133995c45e00077ccbf773ac991df5","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars2.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars2.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-06-04T11:43:47Z","pushed_at":"2017-06-05T13:32:08Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3164066,"stargazers_count":2268,"watchers_count":2268,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":468,"mirror_url":null,"open_issues_count":498,"forks":468,"open_issues":498,"watchers":2268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6163"},"html":{"href":"https://github.com/mapsme/omim/pull/6163"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/6163"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/6163/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6163/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6163/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/83566c48ea860610de5ae1f05d821f48778ed663"}}}}
{"actor":{"display_login":"alexzatsepin"}}