{"action":"created","comment":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/107215603","pull_request_review_id":28174664,"id":107215603,"diff_hunk":"@@ -0,0 +1,166 @@\n+$no-files-warn-color: #ff0000;\n+\n+$btn-background: #ffffff;\n+\n+$btn-choose-files-text: #ffffff;\n+\n+$border-med-blue: rgb(86, 146, 206);\n+$border-med-blue-a-light: rgba(86, 146, 206, 0.2);\n+\n+$files-table-background: #ffffff;\n+\n+.membershipapplication {\n+\n+  .entry-content.wpcf7 {\n+    margin-top: 1em !important;\n+    padding-top: 0;\n+  }\n+\n+  .required-field-explanation {\n+    font-weight: bold;\n+    margin-top: 2em;\n+  }\n+\n+  .instructions {\n+    text-align: center;\n+  }\n+\n+  .app-section {\n+\n+    text-align: left;\n+\n+    .instructions {\n+      text-align: left;\n+    }\n+\n+    h2 {\n+      border-top: 3pt solid rgba(86, 146, 206, 0.2);\n+      font-weight: bold;\n+      margin-top: 3em;\n+      padding-top: 1em;\n+    }\n+\n+    h2.first {\n+      margin-top: 1em;\n+    }\n+\n+    .answers {\n+\n+      margin-left: 1em;\n+\n+      .field-instruction {\n+        font-size: smaller;\n+        font-style: italic;\n+      }\n+\n+    }\n+  }\n+\n+  #supporting-files {\n+\n+    margin-bottom: 1em;\n+\n+    .files {\n+      background: $border-med-blue-a-light;\n+      border: 1px solid $border-med-blue;\n+      margin-left: 1em;\n+      padding: 2em;\n+\n+    }\n+\n+    table {\n+      margin-left: 1em;\n+      margin-right: 1em;\n+\n+      // not striped\n+      tr:nth-child(odd), tr:nth-child(even) {\n+        background-color: $files-table-background;\n+      }\n+\n+      th,\n+      td {\n+        margin: 0;\n+        padding-bottom: 0;\n+        padding-top: 0;\n+      }\n+\n+      th {\n+        border-bottom: 0;\n+        font-weight: bold;\n+      }\n+    }\n+\n+    #upload-files {\n+\n+      .files-to-upload-title {\n+        font-weight: normal;\n+        margin-bottom: 0;\n+      }\n+\n+    }\n+\n+    p.upload-button-pre {","path":"app/assets/stylesheets/membership-applications.scss","position":102,"original_position":102,"commit_id":"edc5d5bc84a5f6e1404bf6ef2fb3e38e322c924d","original_commit_id":"edc5d5bc84a5f6e1404bf6ef2fb3e38e322c924d","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Avoid qualifying class selectors with an element.<br>Selector should have depth of applicability no greater than 2, but was 3","created_at":"2017-03-21T17:08:46Z","updated_at":"2017-03-21T17:08:47Z","html_url":"https://github.com/AgileVentures/shf-project/pull/192#discussion_r107215603","pull_request_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/192","_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/107215603"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/192#discussion_r107215603"},"pull_request":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/192","id":111831018,"html_url":"https://github.com/AgileVentures/shf-project/pull/192","diff_url":"https://github.com/AgileVentures/shf-project/pull/192.diff","patch_url":"https://github.com/AgileVentures/shf-project/pull/192.patch","issue_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/192","number":192,"state":"open","locked":false,"title":"Improve file upload UI (version #2; commits cleaned up)","user":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars3.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"body":"PT Story: Need to improve file-upload visibility\r\nhttps://www.pivotaltracker.com/story/show/141029197\r\n\r\nThis is a first attempt at improving the user experience (UX) when a user fills out a membership application.  Users are skipping over the section to upload files.\r\n\r\n**Translations needed!**\r\n\r\n(This replaces PR #188 because that one had _merges_ in it that added files not part of this PR.)\r\n\r\n\r\n### Changes proposed in this pull request:\r\n1.  Add instructions so users understand the importance of uploading files. Let users know they'll have 3 sections to complete.\r\n2.  Set off each of the 3 major sections so users can see each of them clearly. (Indent the text under each section header to help set them off.)\r\n3. If a users selects more than 1 file to upload, show the list of the files that will be uploaded when they submit the page.\r\n3. Use background color and styling per @thesuss example in PivT to highlight the file upload section even more\r\n4. If no files have been uploaded, show the warning icon\r\n5. Added CSS classes and ids to views so styles can be applied\r\n\r\n\r\n## Ready for Review\r\n@patmbolger @thesuss \r\n\r\n\r\n## Screenshots (Optional):\r\n\r\n\r\n### If no files have been uploaded:\r\n\r\n**New/edit view:**\r\n\r\n\r\n<img width=\"498\" alt=\"new-app-nofiles-warning-sv\" src=\"https://cloud.githubusercontent.com/assets/673794/24092750/779547bc-0d0d-11e7-9424-cbd01f5d3f46.png\">\r\n\r\n---\r\n\r\n### Applicant has chosen 3 files but hasn't saved their new application yet:\r\n\r\n<img width=\"527\" alt=\"new-app-nofiles-warning-3-to-update-sv\" src=\"https://cloud.githubusercontent.com/assets/673794/24092751/7795c66a-0d0d-11e7-8a0b-ebfb226d35cb.png\">\r\n\r\n\r\n### Editing an application with files already uploaded:\r\n\r\n\r\n<img width=\"507\" alt=\"edit-app-with-2files-sv\" src=\"https://cloud.githubusercontent.com/assets/673794/24092851/1f619d6a-0d0e-11e7-928c-8ee43fde482f.png\">\r\n\r\n---\r\n\r\n(English):\r\n\r\n\r\n<img width=\"516\" alt=\"edit-app-with-2files-en\" src=\"https://cloud.githubusercontent.com/assets/673794/24092850/1f6012ba-0d0e-11e7-853c-212c03c1fd39.png\">\r\n\r\n---\r\n\r\n### Viewing an application\r\n\r\n<img width=\"424\" alt=\"show-application-sv\" src=\"https://cloud.githubusercontent.com/assets/673794/24092746/6aa79a3c-0d0d-11e7-8b79-18a174d3ca0c.png\">\r\n\r\n\r\nReady for review:\r\n\r\n","created_at":"2017-03-21T17:08:27Z","updated_at":"2017-03-21T17:08:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"352241fa51e95ee80c7f2cd07593452e4a4fa38d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/192/commits","review_comments_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/192/comments","review_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/192/comments","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/edc5d5bc84a5f6e1404bf6ef2fb3e38e322c924d","head":{"label":"weedySeaDragon:sprint9-141029197-2-Improve-file-upload-UI","ref":"sprint9-141029197-2-Improve-file-upload-UI","sha":"edc5d5bc84a5f6e1404bf6ef2fb3e38e322c924d","user":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars3.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"repo":{"id":72142277,"name":"shf-project","full_name":"weedySeaDragon/shf-project","owner":{"login":"weedySeaDragon","id":673794,"avatar_url":"https://avatars3.githubusercontent.com/u/673794?v=3","gravatar_id":"","url":"https://api.github.com/users/weedySeaDragon","html_url":"https://github.com/weedySeaDragon","followers_url":"https://api.github.com/users/weedySeaDragon/followers","following_url":"https://api.github.com/users/weedySeaDragon/following{/other_user}","gists_url":"https://api.github.com/users/weedySeaDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/weedySeaDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weedySeaDragon/subscriptions","organizations_url":"https://api.github.com/users/weedySeaDragon/orgs","repos_url":"https://api.github.com/users/weedySeaDragon/repos","events_url":"https://api.github.com/users/weedySeaDragon/events{/privacy}","received_events_url":"https://api.github.com/users/weedySeaDragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weedySeaDragon/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/weedySeaDragon/shf-project","forks_url":"https://api.github.com/repos/weedySeaDragon/shf-project/forks","keys_url":"https://api.github.com/repos/weedySeaDragon/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weedySeaDragon/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weedySeaDragon/shf-project/teams","hooks_url":"https://api.github.com/repos/weedySeaDragon/shf-project/hooks","issue_events_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/weedySeaDragon/shf-project/events","assignees_url":"https://api.github.com/repos/weedySeaDragon/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/weedySeaDragon/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/weedySeaDragon/shf-project/tags","blobs_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weedySeaDragon/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/weedySeaDragon/shf-project/languages","stargazers_url":"https://api.github.com/repos/weedySeaDragon/shf-project/stargazers","contributors_url":"https://api.github.com/repos/weedySeaDragon/shf-project/contributors","subscribers_url":"https://api.github.com/repos/weedySeaDragon/shf-project/subscribers","subscription_url":"https://api.github.com/repos/weedySeaDragon/shf-project/subscription","commits_url":"https://api.github.com/repos/weedySeaDragon/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/weedySeaDragon/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/weedySeaDragon/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/weedySeaDragon/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/weedySeaDragon/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weedySeaDragon/shf-project/merges","archive_url":"https://api.github.com/repos/weedySeaDragon/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weedySeaDragon/shf-project/downloads","issues_url":"https://api.github.com/repos/weedySeaDragon/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/weedySeaDragon/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/weedySeaDragon/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/weedySeaDragon/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weedySeaDragon/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/weedySeaDragon/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/weedySeaDragon/shf-project/deployments","created_at":"2016-10-27T19:44:01Z","updated_at":"2017-02-06T19:31:28Z","pushed_at":"2017-03-21T17:06:15Z","git_url":"git://github.com/weedySeaDragon/shf-project.git","ssh_url":"git@github.com:weedySeaDragon/shf-project.git","clone_url":"https://github.com/weedySeaDragon/shf-project.git","svn_url":"https://github.com/weedySeaDragon/shf-project","homepage":null,"size":23729,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"AgileVentures:develop","ref":"develop","sha":"df6f59e6bd6529792d7fedce616debd98a7aa2f4","user":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars3.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"repo":{"id":71157737,"name":"shf-project","full_name":"AgileVentures/shf-project","owner":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars3.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AgileVentures/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/AgileVentures/shf-project","forks_url":"https://api.github.com/repos/AgileVentures/shf-project/forks","keys_url":"https://api.github.com/repos/AgileVentures/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgileVentures/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgileVentures/shf-project/teams","hooks_url":"https://api.github.com/repos/AgileVentures/shf-project/hooks","issue_events_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/AgileVentures/shf-project/events","assignees_url":"https://api.github.com/repos/AgileVentures/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/AgileVentures/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/AgileVentures/shf-project/tags","blobs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgileVentures/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgileVentures/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/AgileVentures/shf-project/languages","stargazers_url":"https://api.github.com/repos/AgileVentures/shf-project/stargazers","contributors_url":"https://api.github.com/repos/AgileVentures/shf-project/contributors","subscribers_url":"https://api.github.com/repos/AgileVentures/shf-project/subscribers","subscription_url":"https://api.github.com/repos/AgileVentures/shf-project/subscription","commits_url":"https://api.github.com/repos/AgileVentures/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgileVentures/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/AgileVentures/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/AgileVentures/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgileVentures/shf-project/merges","archive_url":"https://api.github.com/repos/AgileVentures/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgileVentures/shf-project/downloads","issues_url":"https://api.github.com/repos/AgileVentures/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/AgileVentures/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/AgileVentures/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgileVentures/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/AgileVentures/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/AgileVentures/shf-project/deployments","created_at":"2016-10-17T16:18:10Z","updated_at":"2016-12-02T13:34:05Z","pushed_at":"2017-03-21T17:08:28Z","git_url":"git://github.com/AgileVentures/shf-project.git","ssh_url":"git@github.com:AgileVentures/shf-project.git","clone_url":"https://github.com/AgileVentures/shf-project.git","svn_url":"https://github.com/AgileVentures/shf-project","homepage":null,"size":22589,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":4,"forks":9,"open_issues":4,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/192"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/192"},"issue":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/192"},"comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/AgileVentures/shf-project/statuses/edc5d5bc84a5f6e1404bf6ef2fb3e38e322c924d"}}}}
{"actor":{"display_login":"houndci-bot"}}