{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/2706","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/2706/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/2706/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/2706/events","html_url":"https://github.com/WordPress/gutenberg/pull/2706","id":256321963,"number":2706,"title":"Visual Mode: Extract content inserter as separate component","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars1.githubusercontent.com/u/1779930?v=4","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"labels":[{"id":596962434,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Component]%20Inserter","name":"[Component] Inserter","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-08T17:32:12Z","updated_at":"2017-09-08T17:36:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/2706","html_url":"https://github.com/WordPress/gutenberg/pull/2706","diff_url":"https://github.com/WordPress/gutenberg/pull/2706.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/2706.patch"},"body":"This pull request seeks to refactor a separate component of the \"Continue Writing\" controls currently rendered as children of the `<VisualEditorBlockList />`. Importantly, this resolves an issue where attempting to navigate the content inserter with the keyboard will cause focus to shift between blocks, due to the behavior of the `<WritingFlow />` component introduced in #2424. Since the inserter controls are not relevant to writing flow nor particularly the rendering of the list of blocks, it is sensible to isolate as its own component.\r\n\r\n__Testing instructions:__\r\n\r\nVerify that there are no regressions in the insertion of a new block using the inserter from Visual post content. Particularly, note that you can insert a block using keyboard navigation in the Inserter popover.\r\n\r\nEnsure unit tests pass:\r\n\r\n```\r\nnpm run test-unit\r\n```"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/328167384","html_url":"https://github.com/WordPress/gutenberg/pull/2706#issuecomment-328167384","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/2706","id":328167384,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-09-08T17:35:49Z","updated_at":"2017-09-08T17:36:14Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=h1) Report\n> Merging [#2706](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=desc) into [master](https://codecov.io/gh/WordPress/gutenberg/commit/8afb094dafcbdacf14208e16949ea56137bba42d?src=pr&el=desc) will **increase** coverage by `0.26%`.\n> The diff coverage is `85.71%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/WordPress/gutenberg/pull/2706/graphs/tree.svg?token=4D37xiV136&width=650&src=pr&height=150)](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #2706      +/-   ##\n==========================================\n+ Coverage   33.64%   33.91%   +0.26%     \n==========================================\n  Files         185      186       +1     \n  Lines        5584     5575       -9     \n  Branches      973      970       -3     \n==========================================\n+ Hits         1879     1891      +12     \n+ Misses       3138     3120      -18     \n+ Partials      567      564       -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [editor/modes/visual-editor/block-list.js](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=tree#diff-ZWRpdG9yL21vZGVzL3Zpc3VhbC1lZGl0b3IvYmxvY2stbGlzdC5qcw==) | `0% <ø> (ø)` | :arrow_up: |\n| [editor/modes/visual-editor/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=tree#diff-ZWRpdG9yL21vZGVzL3Zpc3VhbC1lZGl0b3IvaW5kZXguanM=) | `0% <0%> (ø)` | :arrow_up: |\n| [editor/modes/visual-editor/inserter.js](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=tree#diff-ZWRpdG9yL21vZGVzL3Zpc3VhbC1lZGl0b3IvaW5zZXJ0ZXIuanM=) | `92.3% <92.3%> (ø)` | |\n| [editor/inserter/index.js](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=tree#diff-ZWRpdG9yL2luc2VydGVyL2luZGV4Lmpz) | `0% <0%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=footer). Last update [8afb094...1168d05](https://codecov.io/gh/WordPress/gutenberg/pull/2706?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}