{"action":"created","comment":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/137469364","pull_request_review_id":61138035,"id":137469364,"diff_hunk":"@@ -298,16 +298,16 @@ public IChatPanel getChatPanel() {\n     if (!isServerHeadless) {\n       return new ArrayList<>();\n     }\n-    final List<Action> rVal = new ArrayList<>();\n-    rVal.add(clientModel.getHostBotSetMapClientAction(this));\n-    rVal.add(clientModel.getHostBotChangeGameOptionsClientAction(this));\n-    rVal.add(clientModel.getHostBotChangeGameToSaveGameClientAction());\n-    rVal.add(clientModel.getHostBotChangeToAutosaveClientAction(this, SaveGameFileChooser.AUTOSAVE_TYPE.AUTOSAVE));\n-    rVal.add(clientModel.getHostBotChangeToAutosaveClientAction(this, SaveGameFileChooser.AUTOSAVE_TYPE.AUTOSAVE2));\n-    rVal.add(clientModel.getHostBotChangeToAutosaveClientAction(this, SaveGameFileChooser.AUTOSAVE_TYPE.AUTOSAVE_ODD));\n-    rVal.add(clientModel.getHostBotChangeToAutosaveClientAction(this, SaveGameFileChooser.AUTOSAVE_TYPE.AUTOSAVE_EVEN));\n-    rVal.add(clientModel.getHostBotGetGameSaveClientAction(this));\n-    return rVal;\n+    final List<Action> actions = new ArrayList<>();\n+    actions.add(clientModel.getHostBotSetMapClientAction(this));\n+    actions.add(clientModel.getHostBotChangeGameOptionsClientAction(this));\n+    actions.add(clientModel.getHostBotChangeGameToSaveGameClientAction());\n+    actions.add(clientModel.getHostBotChangeToAutosaveClientAction(this, AUTOSAVE_TYPE.AUTOSAVE));\n+    actions.add(clientModel.getHostBotChangeToAutosaveClientAction(this, AUTOSAVE_TYPE.AUTOSAVE2));\n+    actions.add(clientModel.getHostBotChangeToAutosaveClientAction(this, AUTOSAVE_TYPE.AUTOSAVE_ODD));\n+    actions.add(clientModel.getHostBotChangeToAutosaveClientAction(this, AUTOSAVE_TYPE.AUTOSAVE_EVEN));\n+    actions.add(clientModel.getHostBotGetGameSaveClientAction(this));\n+    return actions;","path":"src/main/java/games/strategy/engine/framework/startup/ui/ClientSetupPanel.java","position":32,"original_position":32,"commit_id":"89d300e3728423dbf68db886e09091caa3497a59","original_commit_id":"89d300e3728423dbf68db886e09091caa3497a59","user":{"login":"RoiEXLab","id":8350879,"avatar_url":"https://avatars0.githubusercontent.com/u/8350879?v=4","gravatar_id":"","url":"https://api.github.com/users/RoiEXLab","html_url":"https://github.com/RoiEXLab","followers_url":"https://api.github.com/users/RoiEXLab/followers","following_url":"https://api.github.com/users/RoiEXLab/following{/other_user}","gists_url":"https://api.github.com/users/RoiEXLab/gists{/gist_id}","starred_url":"https://api.github.com/users/RoiEXLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoiEXLab/subscriptions","organizations_url":"https://api.github.com/users/RoiEXLab/orgs","repos_url":"https://api.github.com/users/RoiEXLab/repos","events_url":"https://api.github.com/users/RoiEXLab/events{/privacy}","received_events_url":"https://api.github.com/users/RoiEXLab/received_events","type":"User","site_admin":false},"body":"Using Arrays.asList would remove 2 lines of code","created_at":"2017-09-07T07:52:16Z","updated_at":"2017-09-07T07:56:46Z","html_url":"https://github.com/triplea-game/triplea/pull/2332#discussion_r137469364","pull_request_url":"https://api.github.com/repos/triplea-game/triplea/pulls/2332","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/137469364"},"html":{"href":"https://github.com/triplea-game/triplea/pull/2332#discussion_r137469364"},"pull_request":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/2332"}}},"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/2332","id":139712587,"html_url":"https://github.com/triplea-game/triplea/pull/2332","diff_url":"https://github.com/triplea-game/triplea/pull/2332.diff","patch_url":"https://github.com/triplea-game/triplea/pull/2332.patch","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/2332","number":2332,"state":"open","locked":false,"title":"Checkstyle: Rename \"rVal\" local variables (part 1)","user":{"login":"ssoloff","id":4826349,"avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"body":"This PR fixes violations of the Checkstyle LocalFinalVariableName rule due to local variables named `rVal` whose purpose is to store a method return value.\r\n\r\nThis is one part in a series of related PRs in order to keep the review size reasonable.","created_at":"2017-09-07T04:10:06Z","updated_at":"2017-09-07T07:56:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b756577903b0256117bf39a079f8da34767ea933","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/triplea-game/triplea/pulls/2332/commits","review_comments_url":"https://api.github.com/repos/triplea-game/triplea/pulls/2332/comments","review_comment_url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/2332/comments","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/89d300e3728423dbf68db886e09091caa3497a59","head":{"label":"ssoloff:checkstyle-fix-rval-local-variable-name-violations-part-1","ref":"checkstyle-fix-rval-local-variable-name-violations-part-1","sha":"89d300e3728423dbf68db886e09091caa3497a59","user":{"login":"ssoloff","id":4826349,"avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"repo":{"id":76764435,"name":"triplea-game-triplea","full_name":"ssoloff/triplea-game-triplea","owner":{"login":"ssoloff","id":4826349,"avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ssoloff/triplea-game-triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":true,"url":"https://api.github.com/repos/ssoloff/triplea-game-triplea","forks_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/forks","keys_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/teams","hooks_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/hooks","issue_events_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/issues/events{/number}","events_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/events","assignees_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/assignees{/user}","branches_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/branches{/branch}","tags_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/tags","blobs_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/languages","stargazers_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/stargazers","contributors_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/contributors","subscribers_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/subscribers","subscription_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/subscription","commits_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/contents/{+path}","compare_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/merges","archive_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/downloads","issues_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/issues{/number}","pulls_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/labels{/name}","releases_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/releases{/id}","deployments_url":"https://api.github.com/repos/ssoloff/triplea-game-triplea/deployments","created_at":"2016-12-18T05:24:33Z","updated_at":"2017-06-02T01:15:48Z","pushed_at":"2017-09-07T03:59:43Z","git_url":"git://github.com/ssoloff/triplea-game-triplea.git","ssh_url":"git@github.com:ssoloff/triplea-game-triplea.git","clone_url":"https://github.com/ssoloff/triplea-game-triplea.git","svn_url":"https://github.com/ssoloff/triplea-game-triplea","homepage":null,"size":711938,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"triplea-game:master","ref":"master","sha":"88413d5c14dae0e84ce89ff2f792262303c8cd37","user":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars0.githubusercontent.com/u/13318615?v=4","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"repo":{"id":39766308,"name":"triplea","full_name":"triplea-game/triplea","owner":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars0.githubusercontent.com/u/13318615?v=4","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/triplea-game/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":false,"url":"https://api.github.com/repos/triplea-game/triplea","forks_url":"https://api.github.com/repos/triplea-game/triplea/forks","keys_url":"https://api.github.com/repos/triplea-game/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/triplea-game/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/triplea-game/triplea/teams","hooks_url":"https://api.github.com/repos/triplea-game/triplea/hooks","issue_events_url":"https://api.github.com/repos/triplea-game/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/triplea-game/triplea/events","assignees_url":"https://api.github.com/repos/triplea-game/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/triplea-game/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/triplea-game/triplea/tags","blobs_url":"https://api.github.com/repos/triplea-game/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/triplea-game/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/triplea-game/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/triplea-game/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/triplea-game/triplea/languages","stargazers_url":"https://api.github.com/repos/triplea-game/triplea/stargazers","contributors_url":"https://api.github.com/repos/triplea-game/triplea/contributors","subscribers_url":"https://api.github.com/repos/triplea-game/triplea/subscribers","subscription_url":"https://api.github.com/repos/triplea-game/triplea/subscription","commits_url":"https://api.github.com/repos/triplea-game/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/triplea-game/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/triplea-game/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/triplea-game/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/triplea-game/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/triplea-game/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/triplea-game/triplea/merges","archive_url":"https://api.github.com/repos/triplea-game/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/triplea-game/triplea/downloads","issues_url":"https://api.github.com/repos/triplea-game/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/triplea-game/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/triplea-game/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/triplea-game/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/triplea-game/triplea/labels{/name}","releases_url":"https://api.github.com/repos/triplea-game/triplea/releases{/id}","deployments_url":"https://api.github.com/repos/triplea-game/triplea/deployments","created_at":"2015-07-27T09:32:58Z","updated_at":"2017-08-31T20:08:04Z","pushed_at":"2017-09-07T04:10:07Z","git_url":"git://github.com/triplea-game/triplea.git","ssh_url":"git@github.com:triplea-game/triplea.git","clone_url":"https://github.com/triplea-game/triplea.git","svn_url":"https://github.com/triplea-game/triplea","homepage":null,"size":720202,"stargazers_count":70,"watchers_count":70,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":82,"forks":43,"open_issues":82,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/2332"},"html":{"href":"https://github.com/triplea-game/triplea/pull/2332"},"issue":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/2332"},"comments":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/2332/comments"},"review_comments":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/2332/comments"},"review_comment":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/2332/commits"},"statuses":{"href":"https://api.github.com/repos/triplea-game/triplea/statuses/89d300e3728423dbf68db886e09091caa3497a59"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RoiEXLab"}}