{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41234","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41234/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41234/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41234/events","html_url":"https://github.com/kubernetes/kubernetes/pull/41234","id":206711451,"number":41234,"title":"Enforce Node Allocatable via cgroups","user":{"login":"vishh","id":7063592,"avatar_url":"https://avatars.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"dashpole","id":3262098,"avatar_url":"https://avatars.githubusercontent.com/u/3262098?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},"assignees":[{"login":"dashpole","id":3262098,"avatar_url":"https://avatars.githubusercontent.com/u/3262098?v=3","gravatar_id":"","url":"https://api.github.com/users/dashpole","html_url":"https://github.com/dashpole","followers_url":"https://api.github.com/users/dashpole/followers","following_url":"https://api.github.com/users/dashpole/following{/other_user}","gists_url":"https://api.github.com/users/dashpole/gists{/gist_id}","starred_url":"https://api.github.com/users/dashpole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dashpole/subscriptions","organizations_url":"https://api.github.com/users/dashpole/orgs","repos_url":"https://api.github.com/users/dashpole/repos","events_url":"https://api.github.com/users/dashpole/events{/privacy}","received_events_url":"https://api.github.com/users/dashpole/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars.githubusercontent.com/u/6233452?v=3","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31","html_url":"https://github.com/kubernetes/kubernetes/milestone/31","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31/labels","id":2130587,"number":31,"title":"v1.6","description":null,"creator":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"open_issues":306,"closed_issues":367,"state":"open","created_at":"2016-11-12T00:35:38Z","updated_at":"2017-02-24T01:43:42Z","due_on":null,"closed_at":null},"comments":18,"created_at":"2017-02-10T05:22:31Z","updated_at":"2017-02-24T04:04:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/41234","html_url":"https://github.com/kubernetes/kubernetes/pull/41234","diff_url":"https://github.com/kubernetes/kubernetes/pull/41234.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/41234.patch"},"body":"This PR enforces node allocatable across all pods using a top level cgroup as described in https://github.com/kubernetes/community/pull/348\r\n\r\nThis PR also provides an option to enforce `kubeReserved` and `systemReserved` on user specified cgroups. \r\n\r\nThis PR will by default make kubelet create top level cgroups even if `kubeReserved` and `systemReserved` is not specified and hence `Allocatable = Capacity`.\r\n\r\n```release-note\r\nNew Kubelet flag `--enforce-node-allocatable` with a default value of `pods` is added which will make kubelet create a top level cgroup for all pods to enforce Node Allocatable. Optionally, `system-reserved` & `kube-reserved` values can also be specified separated by comma to enforce node allocatable on cgroups specified via `--system-reserved-cgroup` & `--kube-reserved-cgroup` respectively. Note the default value of the latter flags are \"\".\r\nThis feature requires a **Node Drain** prior to upgrade failing which pods will be restarted if possible or terminated if they have a `RestartNever` policy.\r\n```\r\n\r\ncc @kubernetes/sig-node-pr-reviews @kubernetes/sig-node-feature-requests \r\n\r\nTODO:\r\n\r\n- [x] Adjust effective Node Allocatable to subtract hard eviction thresholds\r\n- [x] Add unit tests\r\n- [x] Complete pending e2e tests\r\n- [x] Manual testing\r\n- [x] Get the proposal merged\r\n\r\n@dashpole is working on adding support for evictions for enforcing Node allocatable more gracefully. That work will show up in a subsequent PR for v1.6"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/282198561","html_url":"https://github.com/kubernetes/kubernetes/pull/41234#issuecomment-282198561","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/41234","id":282198561,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-02-24T04:04:42Z","updated_at":"2017-02-24T04:04:42Z","body":"@vishh: The following test(s) **failed**:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nJenkins CRI GCE Node e2e | 8c7160c5b686d1b5bad776ee26b8a1335cc266b3 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/41234/pull-kubernetes-node-e2e-cri/12704/) | `@k8s-bot cri node e2e test this`\nJenkins non-CRI GCE e2e | f5f2f22c76da510f4ebe269ea826540dc9533bb9 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/41234/pull-kubernetes-e2e-gce-non-cri/1251/) | `@k8s-bot non-cri e2e test this`\nJenkins verification | 98209cacd517be91456e93d0b5077940f7c5597b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/41234/pull-kubernetes-verify/19218/) | `@k8s-bot verify test this`\nJenkins GCE Node e2e | 98209cacd517be91456e93d0b5077940f7c5597b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/41234/pull-kubernetes-node-e2e/19407/) | `@k8s-bot node e2e test this`\nJenkins kops AWS e2e | 98209cacd517be91456e93d0b5077940f7c5597b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/41234/pull-kubernetes-e2e-kops-aws/14162/) | `@k8s-bot kops aws e2e test this`\nJenkins Cross Build | 933b54ced21de0c9a07bda388de1acad65e93fa6 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/41234/pull-kubernetes-cross/1811/) | `@k8s-bot cross build this`\nJenkins non-CRI GCE Node e2e | 933b54ced21de0c9a07bda388de1acad65e93fa6 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/41234/pull-kubernetes-node-e2e-non-cri/1273/) | `@k8s-bot non-cri node e2e test this`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/41234). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/vishh). Please help us cut down on flakes by linking to an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-request-commands.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/prow/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}