{"action":"created","issue":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/1491","repository_url":"https://api.github.com/repos/rstudio/rstudio","labels_url":"https://api.github.com/repos/rstudio/rstudio/issues/1491/labels{/name}","comments_url":"https://api.github.com/repos/rstudio/rstudio/issues/1491/comments","events_url":"https://api.github.com/repos/rstudio/rstudio/issues/1491/events","html_url":"https://github.com/rstudio/rstudio/pull/1491","id":254465654,"number":1491,"title":"Fix stuck console scrolling on high-dpi Windows","user":{"login":"gtritchie","id":10569626,"avatar_url":"https://avatars3.githubusercontent.com/u/10569626?v=4","gravatar_id":"","url":"https://api.github.com/users/gtritchie","html_url":"https://github.com/gtritchie","followers_url":"https://api.github.com/users/gtritchie/followers","following_url":"https://api.github.com/users/gtritchie/following{/other_user}","gists_url":"https://api.github.com/users/gtritchie/gists{/gist_id}","starred_url":"https://api.github.com/users/gtritchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtritchie/subscriptions","organizations_url":"https://api.github.com/users/gtritchie/orgs","repos_url":"https://api.github.com/users/gtritchie/repos","events_url":"https://api.github.com/users/gtritchie/events{/privacy}","received_events_url":"https://api.github.com/users/gtritchie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-31T20:56:51Z","updated_at":"2017-08-31T21:12:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/1491","html_url":"https://github.com/rstudio/rstudio/pull/1491","diff_url":"https://github.com/rstudio/rstudio/pull/1491.diff","patch_url":"https://github.com/rstudio/rstudio/pull/1491.patch"},"body":"With Windows display zooming at a variety of settings (> 100% - 225%) I observed a frequent off-by-one in the values returned by `ScrollPanel` used to determine if it is scrolled to the bottom.\r\n\r\nSo for Windows, I allow a fudge-factor of 1 pixel to prevent auto-scrolling from getting stuck."},"comment":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/comments/326422000","html_url":"https://github.com/rstudio/rstudio/pull/1491#issuecomment-326422000","issue_url":"https://api.github.com/repos/rstudio/rstudio/issues/1491","id":326422000,"user":{"login":"gtritchie","id":10569626,"avatar_url":"https://avatars3.githubusercontent.com/u/10569626?v=4","gravatar_id":"","url":"https://api.github.com/users/gtritchie","html_url":"https://github.com/gtritchie","followers_url":"https://api.github.com/users/gtritchie/followers","following_url":"https://api.github.com/users/gtritchie/following{/other_user}","gists_url":"https://api.github.com/users/gtritchie/gists{/gist_id}","starred_url":"https://api.github.com/users/gtritchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtritchie/subscriptions","organizations_url":"https://api.github.com/users/gtritchie/orgs","repos_url":"https://api.github.com/users/gtritchie/repos","events_url":"https://api.github.com/users/gtritchie/events{/privacy}","received_events_url":"https://api.github.com/users/gtritchie/received_events","type":"User","site_admin":false},"created_at":"2017-08-31T21:12:19Z","updated_at":"2017-08-31T21:12:19Z","author_association":"CONTRIBUTOR","body":"I was going for minimally scoped fix, but agree there seems to be little\ndanger in making it platform agnostic and bumping up the fudge factor.\nStand by...\n\nOn Thu, Aug 31, 2017 at 2:09 PM, Jonathan <notifications@github.com> wrote:\n\n> Does this only happen on the Windows desktop? I'd be surprised if it\n> didn't also repro on high DPI Linux (or at least Linux at > 100% zoom)\n> since they're both on Qt.\n>\n> FWIW I'd be a fan of increasing the fudge factor *and* allowing this to\n> apply to any OS/platform, presuming the effect is that you can be a few px\n> off the bottom and still get auto-scroll (possibly what users want anyway\n> if they can still see most of the last line!).\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/rstudio/rstudio/pull/1491#issuecomment-326421406>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AKFHmj1FXFhbgIO94JLt3JW16DAiPCcdks5sdyEagaJpZM4PJZex>\n> .\n>\n"}}
{"actor":{"display_login":"gtritchie"}}