{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/154513619","pull_request_review_id":80691669,"id":154513619,"diff_hunk":"@@ -11,7 +11,6 @@\n \n namespace NHibernate.Tuple.Entity\n {\n-\t[Serializable]\n \tpublic class EntityMetamodel","path":"src/NHibernate/Tuple/Entity/EntityMetamodel.cs","position":5,"original_position":5,"commit_id":"2419704158ad3c150ed98df7e752da737601d603","original_commit_id":"2419704158ad3c150ed98df7e752da737601d603","user":{"login":"ngbrown","id":228987,"avatar_url":"https://avatars3.githubusercontent.com/u/228987?v=4","gravatar_id":"","url":"https://api.github.com/users/ngbrown","html_url":"https://github.com/ngbrown","followers_url":"https://api.github.com/users/ngbrown/followers","following_url":"https://api.github.com/users/ngbrown/following{/other_user}","gists_url":"https://api.github.com/users/ngbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ngbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngbrown/subscriptions","organizations_url":"https://api.github.com/users/ngbrown/orgs","repos_url":"https://api.github.com/users/ngbrown/repos","events_url":"https://api.github.com/users/ngbrown/events{/privacy}","received_events_url":"https://api.github.com/users/ngbrown/received_events","type":"User","site_admin":false},"body":"Moved to #1469","created_at":"2017-12-03T04:16:43Z","updated_at":"2017-12-03T04:16:44Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1425#discussion_r154513619","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1425","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/154513619"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/1425#discussion_r154513619"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1425"}},"in_reply_to_id":153074781},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1425","id":150712065,"html_url":"https://github.com/nhibernate/nhibernate-core/pull/1425","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/1425.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/1425.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1425","number":1425,"state":"open","locked":false,"title":"Serialize system types better in preparation for .NET Core.","user":{"login":"ngbrown","id":228987,"avatar_url":"https://avatars3.githubusercontent.com/u/228987?v=4","gravatar_id":"","url":"https://api.github.com/users/ngbrown","html_url":"https://github.com/ngbrown","followers_url":"https://api.github.com/users/ngbrown/followers","following_url":"https://api.github.com/users/ngbrown/following{/other_user}","gists_url":"https://api.github.com/users/ngbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ngbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngbrown/subscriptions","organizations_url":"https://api.github.com/users/ngbrown/orgs","repos_url":"https://api.github.com/users/ngbrown/repos","events_url":"https://api.github.com/users/ngbrown/events{/privacy}","received_events_url":"https://api.github.com/users/ngbrown/received_events","type":"User","site_admin":false},"body":"Serialize `System.Type`, `ConstructorInfo`, `FieldInfo`, `MethodInfo`, and `PropertyInfo` using only basic types.\r\n\r\nI also cleaned up attributes and overloads using some Roslyn Analyzers I wrote that were based on:\r\n\r\n* [CA2229](https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2229-implement-serialization-constructors)\r\n* [CA2235](https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2235-mark-all-non-serializable-fields)\r\n* [CA2239](https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2239-provide-deserialization-methods-for-optional-fields)\r\n* [CA2240](https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2240-implement-iserializable-correctly)\r\n\r\nI also used reflection generated list of `[Serializable]` types in .NET Core 2.0 to find and replace fields in serialized types.\r\n\r\nThis partially addresses #889 - NH3853.  While not switching away from binary serialization, it should be compatible with .NET Core (to be verified).\r\n\r\nIf an application is serializing NHibernate internals (like `ISession` or some of the exceptions that are now completely serialized like `PropertyNotFoundException`) into permanent storage and expects them to be rehydrated with any future version of NHibernate, then this will break that.  Applications should only expect binary serialization compatibility within a very limited version range.","created_at":"2017-11-05T07:58:45Z","updated_at":"2017-12-03T04:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"138b97294a8bd3151c26e39f9d210d2222853528","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1425/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1425/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1425/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/2419704158ad3c150ed98df7e752da737601d603","head":{"label":"ngbrown:feature/no-reflection-serialization","ref":"feature/no-reflection-serialization","sha":"2419704158ad3c150ed98df7e752da737601d603","user":{"login":"ngbrown","id":228987,"avatar_url":"https://avatars3.githubusercontent.com/u/228987?v=4","gravatar_id":"","url":"https://api.github.com/users/ngbrown","html_url":"https://github.com/ngbrown","followers_url":"https://api.github.com/users/ngbrown/followers","following_url":"https://api.github.com/users/ngbrown/following{/other_user}","gists_url":"https://api.github.com/users/ngbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ngbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngbrown/subscriptions","organizations_url":"https://api.github.com/users/ngbrown/orgs","repos_url":"https://api.github.com/users/ngbrown/repos","events_url":"https://api.github.com/users/ngbrown/events{/privacy}","received_events_url":"https://api.github.com/users/ngbrown/received_events","type":"User","site_admin":false},"repo":{"id":2336186,"name":"nhibernate-core","full_name":"ngbrown/nhibernate-core","owner":{"login":"ngbrown","id":228987,"avatar_url":"https://avatars3.githubusercontent.com/u/228987?v=4","gravatar_id":"","url":"https://api.github.com/users/ngbrown","html_url":"https://github.com/ngbrown","followers_url":"https://api.github.com/users/ngbrown/followers","following_url":"https://api.github.com/users/ngbrown/following{/other_user}","gists_url":"https://api.github.com/users/ngbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/ngbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngbrown/subscriptions","organizations_url":"https://api.github.com/users/ngbrown/orgs","repos_url":"https://api.github.com/users/ngbrown/repos","events_url":"https://api.github.com/users/ngbrown/events{/privacy}","received_events_url":"https://api.github.com/users/ngbrown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngbrown/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/ngbrown/nhibernate-core","forks_url":"https://api.github.com/repos/ngbrown/nhibernate-core/forks","keys_url":"https://api.github.com/repos/ngbrown/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngbrown/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngbrown/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/ngbrown/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/ngbrown/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/ngbrown/nhibernate-core/events","assignees_url":"https://api.github.com/repos/ngbrown/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/ngbrown/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/ngbrown/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/ngbrown/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngbrown/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngbrown/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngbrown/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngbrown/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ngbrown/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/ngbrown/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/ngbrown/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/ngbrown/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/ngbrown/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/ngbrown/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngbrown/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngbrown/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngbrown/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngbrown/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/ngbrown/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngbrown/nhibernate-core/merges","archive_url":"https://api.github.com/repos/ngbrown/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngbrown/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/ngbrown/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/ngbrown/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ngbrown/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ngbrown/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngbrown/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/ngbrown/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/ngbrown/nhibernate-core/deployments","created_at":"2011-09-06T17:57:14Z","updated_at":"2017-10-27T02:10:11Z","pushed_at":"2017-12-03T03:52:13Z","git_url":"git://github.com/ngbrown/nhibernate-core.git","ssh_url":"git@github.com:ngbrown/nhibernate-core.git","clone_url":"https://github.com/ngbrown/nhibernate-core.git","svn_url":"https://github.com/ngbrown/nhibernate-core","homepage":"http://nhibernate.info","size":80811,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":3,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"da56a73706cfed3e186def5538046fbe73bddc19","user":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","owner":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/deployments","created_at":"2011-08-14T17:51:09Z","updated_at":"2017-11-30T02:42:38Z","pushed_at":"2017-12-03T03:52:14Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":81149,"stargazers_count":1263,"watchers_count":1263,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":731,"mirror_url":null,"archived":false,"open_issues_count":714,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":731,"open_issues":714,"watchers":1263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1425"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/1425"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1425"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1425/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1425/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1425/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/2419704158ad3c150ed98df7e752da737601d603"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ngbrown"}}