{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/build/pulls/comments/136430956","pull_request_review_id":59961642,"id":136430956,"diff_hunk":"@@ -0,0 +1,80 @@\n+import 'package:analyzer/dart/element/element.dart';\n+import 'package:build_test/build_test.dart';\n+import 'package:test/test.dart';\n+\n+import 'package:build_compilers/src/modules.dart';\n+\n+void main() {\n+  LibraryElement libCycle;\n+  LibraryElement libSecondaryInCycle;\n+  LibraryElement libNoCycle;\n+  LibraryElement libCycleWithB;\n+  LibraryElement libCycleWithA;\n+  final assetCycle = makeAssetId('a|lib/a_cycle.dart');","path":"build_compilers/test/modules_test.dart","position":17,"original_position":13,"commit_id":"497c1b342460202507eabdb7c75618fce37dc104","original_commit_id":"a56799551661ea1346e4f76d32707321b42d869d","user":{"login":"natebosch","id":7528195,"avatar_url":"https://avatars3.githubusercontent.com/u/7528195?v=4","gravatar_id":"","url":"https://api.github.com/users/natebosch","html_url":"https://github.com/natebosch","followers_url":"https://api.github.com/users/natebosch/followers","following_url":"https://api.github.com/users/natebosch/following{/other_user}","gists_url":"https://api.github.com/users/natebosch/gists{/gist_id}","starred_url":"https://api.github.com/users/natebosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natebosch/subscriptions","organizations_url":"https://api.github.com/users/natebosch/orgs","repos_url":"https://api.github.com/users/natebosch/repos","events_url":"https://api.github.com/users/natebosch/events{/privacy}","received_events_url":"https://api.github.com/users/natebosch/received_events","type":"User","site_admin":false},"body":"The interesting bit is that it's a cycle, not that it's in package A. Would prefer to keep this as is unless you feel strongly about it.","created_at":"2017-08-31T19:46:26Z","updated_at":"2017-08-31T19:49:00Z","html_url":"https://github.com/dart-lang/build/pull/392#discussion_r136430956","pull_request_url":"https://api.github.com/repos/dart-lang/build/pulls/392","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/build/pulls/comments/136430956"},"html":{"href":"https://github.com/dart-lang/build/pull/392#discussion_r136430956"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/build/pulls/392"}},"in_reply_to_id":136403987},"pull_request":{"url":"https://api.github.com/repos/dart-lang/build/pulls/392","id":138723870,"html_url":"https://github.com/dart-lang/build/pull/392","diff_url":"https://github.com/dart-lang/build/pull/392.diff","patch_url":"https://github.com/dart-lang/build/pull/392.patch","issue_url":"https://api.github.com/repos/dart-lang/build/issues/392","number":392,"state":"open","locked":false,"title":"Add module/cycle finding","user":{"login":"natebosch","id":7528195,"avatar_url":"https://avatars3.githubusercontent.com/u/7528195?v=4","gravatar_id":"","url":"https://api.github.com/users/natebosch","html_url":"https://github.com/natebosch","followers_url":"https://api.github.com/users/natebosch/followers","following_url":"https://api.github.com/users/natebosch/following{/other_user}","gists_url":"https://api.github.com/users/natebosch/gists{/gist_id}","starred_url":"https://api.github.com/users/natebosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natebosch/subscriptions","organizations_url":"https://api.github.com/users/natebosch/orgs","repos_url":"https://api.github.com/users/natebosch/repos","events_url":"https://api.github.com/users/natebosch/events{/privacy}","received_events_url":"https://api.github.com/users/natebosch/received_events","type":"User","site_admin":false},"body":"Closes #345\r\n\r\nWe'll start with some code that can be run from a SummaryBuilder or\r\nDDCBuilder inline rather than something which writes a .json file.\r\n\r\n- Add `package:build_compilers` which will hold the SummaryBuilder and\r\n  DDCBuilder. Configure Travis to run tests.\r\n- Add `modules.dart` with code to determing the primary library in a\r\n  cycle, and to find the modules for imports.","created_at":"2017-08-31T17:30:34Z","updated_at":"2017-08-31T19:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"656bcbe6b3ea3fc122ccabf0f85f3df70c9b3c07","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/build/pulls/392/commits","review_comments_url":"https://api.github.com/repos/dart-lang/build/pulls/392/comments","review_comment_url":"https://api.github.com/repos/dart-lang/build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/build/issues/392/comments","statuses_url":"https://api.github.com/repos/dart-lang/build/statuses/497c1b342460202507eabdb7c75618fce37dc104","head":{"label":"dart-lang:natebosch_module-definitions","ref":"natebosch_module-definitions","sha":"497c1b342460202507eabdb7c75618fce37dc104","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":50053618,"name":"build","full_name":"dart-lang/build","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/build","description":"A build system for Dart","fork":false,"url":"https://api.github.com/repos/dart-lang/build","forks_url":"https://api.github.com/repos/dart-lang/build/forks","keys_url":"https://api.github.com/repos/dart-lang/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/build/teams","hooks_url":"https://api.github.com/repos/dart-lang/build/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/build/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/build/events","assignees_url":"https://api.github.com/repos/dart-lang/build/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/build/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/build/tags","blobs_url":"https://api.github.com/repos/dart-lang/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/build/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/build/languages","stargazers_url":"https://api.github.com/repos/dart-lang/build/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/build/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/build/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/build/subscription","commits_url":"https://api.github.com/repos/dart-lang/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/build/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/build/merges","archive_url":"https://api.github.com/repos/dart-lang/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/build/downloads","issues_url":"https://api.github.com/repos/dart-lang/build/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/build/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/build/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/build/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/build/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/build/deployments","created_at":"2016-01-20T19:12:37Z","updated_at":"2017-08-27T02:25:32Z","pushed_at":"2017-08-31T19:48:33Z","git_url":"git://github.com/dart-lang/build.git","ssh_url":"git@github.com:dart-lang/build.git","clone_url":"https://github.com/dart-lang/build.git","svn_url":"https://github.com/dart-lang/build","homepage":"https://pub.dartlang.org/packages/build","size":620,"stargazers_count":22,"watchers_count":22,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":41,"forks":10,"open_issues":41,"watchers":22,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"4a388a33babc7c5b2ac5dadbf3656f8a0d572024","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":50053618,"name":"build","full_name":"dart-lang/build","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/build","description":"A build system for Dart","fork":false,"url":"https://api.github.com/repos/dart-lang/build","forks_url":"https://api.github.com/repos/dart-lang/build/forks","keys_url":"https://api.github.com/repos/dart-lang/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/build/teams","hooks_url":"https://api.github.com/repos/dart-lang/build/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/build/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/build/events","assignees_url":"https://api.github.com/repos/dart-lang/build/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/build/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/build/tags","blobs_url":"https://api.github.com/repos/dart-lang/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/build/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/build/languages","stargazers_url":"https://api.github.com/repos/dart-lang/build/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/build/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/build/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/build/subscription","commits_url":"https://api.github.com/repos/dart-lang/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/build/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/build/merges","archive_url":"https://api.github.com/repos/dart-lang/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/build/downloads","issues_url":"https://api.github.com/repos/dart-lang/build/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/build/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/build/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/build/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/build/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/build/deployments","created_at":"2016-01-20T19:12:37Z","updated_at":"2017-08-27T02:25:32Z","pushed_at":"2017-08-31T19:48:33Z","git_url":"git://github.com/dart-lang/build.git","ssh_url":"git@github.com:dart-lang/build.git","clone_url":"https://github.com/dart-lang/build.git","svn_url":"https://github.com/dart-lang/build","homepage":"https://pub.dartlang.org/packages/build","size":620,"stargazers_count":22,"watchers_count":22,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":41,"forks":10,"open_issues":41,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/build/pulls/392"},"html":{"href":"https://github.com/dart-lang/build/pull/392"},"issue":{"href":"https://api.github.com/repos/dart-lang/build/issues/392"},"comments":{"href":"https://api.github.com/repos/dart-lang/build/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/build/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/build/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/build/statuses/497c1b342460202507eabdb7c75618fce37dc104"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"natebosch"}}