{"action":"closed","issue":{"url":"https://api.github.com/repos/gildor/kotlin-coroutines-retrofit/issues/20","repository_url":"https://api.github.com/repos/gildor/kotlin-coroutines-retrofit","labels_url":"https://api.github.com/repos/gildor/kotlin-coroutines-retrofit/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/gildor/kotlin-coroutines-retrofit/issues/20/comments","events_url":"https://api.github.com/repos/gildor/kotlin-coroutines-retrofit/issues/20/events","html_url":"https://github.com/gildor/kotlin-coroutines-retrofit/issues/20","id":239817517,"number":20,"title":"Checking for continuation.isCancelled only in failures ","user":{"login":"robertoestivill","id":3728545,"avatar_url":"https://avatars2.githubusercontent.com/u/3728545?v=3","gravatar_id":"","url":"https://api.github.com/users/robertoestivill","html_url":"https://github.com/robertoestivill","followers_url":"https://api.github.com/users/robertoestivill/followers","following_url":"https://api.github.com/users/robertoestivill/following{/other_user}","gists_url":"https://api.github.com/users/robertoestivill/gists{/gist_id}","starred_url":"https://api.github.com/users/robertoestivill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertoestivill/subscriptions","organizations_url":"https://api.github.com/users/robertoestivill/orgs","repos_url":"https://api.github.com/users/robertoestivill/repos","events_url":"https://api.github.com/users/robertoestivill/events{/privacy}","received_events_url":"https://api.github.com/users/robertoestivill/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-30T15:43:42Z","updated_at":"2017-07-03T16:39:58Z","closed_at":"2017-07-03T16:39:58Z","body":"I have just noticed that the methods in `CallAwait.kt` only check if the `continuation.isCancelled` on the `onFailure` callback. Is there any reason why `onResponse` doesn't implement the same behavior ? \r\n\r\n```java\r\noverride fun onFailure(call: Call<T>, t: Throwable) {\r\n    // Don't bother with resuming the continuation if it is already cancelled.\r\n    if (continuation.isCancelled) return\r\n    ...\r\n}\r\n```\r\n\r\n"}}
{"actor":{"display_login":"robertoestivill"}}