{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/helm/issues/2143","repository_url":"https://api.github.com/repos/kubernetes/helm","labels_url":"https://api.github.com/repos/kubernetes/helm/issues/2143/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/helm/issues/2143/comments","events_url":"https://api.github.com/repos/kubernetes/helm/issues/2143/events","html_url":"https://github.com/kubernetes/helm/pull/2143","id":215492876,"number":2143,"title":"Trigger deployment as success when new replicaSet has reached min you need","user":{"login":"kiich","id":4416324,"avatar_url":"https://avatars2.githubusercontent.com/u/4416324?v=3","gravatar_id":"","url":"https://api.github.com/users/kiich","html_url":"https://github.com/kiich","followers_url":"https://api.github.com/users/kiich/followers","following_url":"https://api.github.com/users/kiich/following{/other_user}","gists_url":"https://api.github.com/users/kiich/gists{/gist_id}","starred_url":"https://api.github.com/users/kiich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiich/subscriptions","organizations_url":"https://api.github.com/users/kiich/orgs","repos_url":"https://api.github.com/users/kiich/repos","events_url":"https://api.github.com/users/kiich/events{/privacy}","received_events_url":"https://api.github.com/users/kiich/received_events","type":"User","site_admin":false},"labels":[{"id":484574947,"url":"https://api.github.com/repos/kubernetes/helm/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"c2e0c6","default":false},{"id":562687520,"url":"https://api.github.com/repos/kubernetes/helm/labels/feature","name":"feature","color":"0052cc","default":false},{"id":562692416,"url":"https://api.github.com/repos/kubernetes/helm/labels/in%20progress","name":"in progress","color":"11DD11","default":false},{"id":562695413,"url":"https://api.github.com/repos/kubernetes/helm/labels/size/small","name":"size/small","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/helm/milestones/30","html_url":"https://github.com/kubernetes/helm/milestone/30","labels_url":"https://api.github.com/repos/kubernetes/helm/milestones/30/labels","id":2280951,"number":30,"title":"2.3.0","description":"","creator":{"login":"technosophos","id":89193,"avatar_url":"https://avatars2.githubusercontent.com/u/89193?v=3","gravatar_id":"","url":"https://api.github.com/users/technosophos","html_url":"https://github.com/technosophos","followers_url":"https://api.github.com/users/technosophos/followers","following_url":"https://api.github.com/users/technosophos/following{/other_user}","gists_url":"https://api.github.com/users/technosophos/gists{/gist_id}","starred_url":"https://api.github.com/users/technosophos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technosophos/subscriptions","organizations_url":"https://api.github.com/users/technosophos/orgs","repos_url":"https://api.github.com/users/technosophos/repos","events_url":"https://api.github.com/users/technosophos/events{/privacy}","received_events_url":"https://api.github.com/users/technosophos/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":49,"state":"open","created_at":"2017-01-26T20:24:09Z","updated_at":"2017-03-24T16:56:27Z","due_on":"2017-04-04T07:00:00Z","closed_at":null},"comments":8,"created_at":"2017-03-20T17:17:35Z","updated_at":"2017-03-28T01:11:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/2143","html_url":"https://github.com/kubernetes/helm/pull/2143","diff_url":"https://github.com/kubernetes/helm/pull/2143.diff","patch_url":"https://github.com/kubernetes/helm/pull/2143.patch"},"body":"Current check for deployment as success is to get related replicasets and then wait till all pods are ready.\r\n\r\nThis PR is to fine tune this logic where we get the new replica set associated to the deployment, wait until this new replicaset has reached minimum we require which is calculated from number of replicas needed in deployment minus value of maxUnavailable.\r\n\r\nOnce this value is reached, we treat the deployment is ready."},"comment":{"url":"https://api.github.com/repos/kubernetes/helm/issues/comments/289632649","html_url":"https://github.com/kubernetes/helm/pull/2143#issuecomment-289632649","issue_url":"https://api.github.com/repos/kubernetes/helm/issues/2143","id":289632649,"user":{"login":"thomastaylor312","id":4294228,"avatar_url":"https://avatars1.githubusercontent.com/u/4294228?v=3","gravatar_id":"","url":"https://api.github.com/users/thomastaylor312","html_url":"https://github.com/thomastaylor312","followers_url":"https://api.github.com/users/thomastaylor312/followers","following_url":"https://api.github.com/users/thomastaylor312/following{/other_user}","gists_url":"https://api.github.com/users/thomastaylor312/gists{/gist_id}","starred_url":"https://api.github.com/users/thomastaylor312/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomastaylor312/subscriptions","organizations_url":"https://api.github.com/users/thomastaylor312/orgs","repos_url":"https://api.github.com/users/thomastaylor312/repos","events_url":"https://api.github.com/users/thomastaylor312/events{/privacy}","received_events_url":"https://api.github.com/users/thomastaylor312/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T01:11:15Z","updated_at":"2017-03-28T01:11:15Z","body":"@kiich Sorry about that. I had written that and then tested again and forgot to remove it. `type: Recreate` works as it should. \r\n\r\nI think we'll just go with the documentation route on this one. Once that is pushed up, I'll read through it and then merge if it looks good"}}
{"actor":{"display_login":"thomastaylor312"}}