{"action":"closed","issue":{"url":"https://api.github.com/repos/neomake/neomake/issues/1476","repository_url":"https://api.github.com/repos/neomake/neomake","labels_url":"https://api.github.com/repos/neomake/neomake/issues/1476/labels{/name}","comments_url":"https://api.github.com/repos/neomake/neomake/issues/1476/comments","events_url":"https://api.github.com/repos/neomake/neomake/issues/1476/events","html_url":"https://github.com/neomake/neomake/issues/1476","id":246483490,"number":1476,"title":"Node based makers don't work in nvim on Windows","user":{"login":"kylemacfarlane","id":99594,"avatar_url":"https://avatars1.githubusercontent.com/u/99594?v=4","gravatar_id":"","url":"https://api.github.com/users/kylemacfarlane","html_url":"https://github.com/kylemacfarlane","followers_url":"https://api.github.com/users/kylemacfarlane/followers","following_url":"https://api.github.com/users/kylemacfarlane/following{/other_user}","gists_url":"https://api.github.com/users/kylemacfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/kylemacfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylemacfarlane/subscriptions","organizations_url":"https://api.github.com/users/kylemacfarlane/orgs","repos_url":"https://api.github.com/users/kylemacfarlane/repos","events_url":"https://api.github.com/users/kylemacfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/kylemacfarlane/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-07-28T23:53:32Z","updated_at":"2017-07-29T18:45:48Z","closed_at":"2017-07-29T18:45:48Z","body":"Very similar to #992 but only nvim this time around.\r\n\r\nPython makers seem to work fine but node makers can't find the binaries. Here's the log output:\r\n\r\n```\r\n00:42:42 [D      ] [1.-:1:1] Nothing to make: no enabled file mode makers (filetype=cfg).\r\n00:42:42 [D      ] [1.-:-:1] Cleaning make info.\r\n00:42:45 [D +2.84] [2.-:3:1] Running makers: eslint.\r\n00:42:45 [D      ] Skipping User autocmd NeomakeJobInit: no hooks.\r\n00:42:45 [V      ] [2.1:3:1] Starting async job: ['eslint', '-f', 'compact', 'C:\\Users\\kyle\\projects\\test-neomake\\app.js'].\r\n00:42:45 [D      ] [2.1:3:1] cwd: C:\\Users\\kyle\\projects\\test-neomake.\r\n00:42:45 [E +0.06] [2.-:-:1] Failed to start Neovim job: ['eslint', '-f', 'compact', 'C:\\Users\\kyle\\projects\\test-neomake\\app.js']: Vim(let):E903: Process failed to start: no such file or directory: \"eslint\".\r\n00:42:45 [D      ] [2.-:-:1] Cleaning make info.\r\n```\r\n\r\nIf you remember from #992 there's a specific issue with node due to the batch files npm generates on Windows. This would explain why it's node only but I'm not sure if it is the same issue this time around.\r\n\r\nFor example the current code at https://github.com/neomake/neomake/blob/master/autoload/neomake.vim#L628\r\n\r\n    if has('nvim')\r\n        if args_is_list\r\n            let argv = [exe] + args\r\n        else\r\n            let argv = exe . (!empty(args) ? ' ' . args : '')\r\n        endif\r\n\r\nIf I change this to:\r\n\r\n    if has('nvim')\r\n        if args_is_list\r\n            let argv = [\"eslint.cmd\"] + args\r\n        else\r\n            let argv = \"eslint.cmd\" . (!empty(args) ? ' ' . args : '')\r\n        endif\r\n\r\nThen it works. Which implies that nvim doesn't check for `%PATHEXT%` but if that was the case how are the Python linters working?\r\n\r\nThe only fix I've found is to bypass the nvim specific arguments on Windows:\r\n\r\n    if has('nvim') && !neomake#utils#IsRunningWindows()\r\n        if args_is_list\r\n            let argv = [exe] + args\r\n        else\r\n            let argv = exe . (!empty(args) ? ' ' . args : '')\r\n        endif\r\n"}}
{"actor":{"display_login":"blueyed"}}