{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/142515315","pull_request_review_id":66887689,"id":142515315,"diff_hunk":"@@ -22,50 +64,100 @@ protected override string TypeName\n \t\t[Test]\n \t\tpublic void Equals()\n \t\t{\n-\t\t\tdecimal lhs = 5.64351M;\n-\t\t\tdecimal rhs = 5.64351M;\n+\t\t\tconst decimal lhs = 5.64351M;\n+\t\t\tvar rhs = 5.64351M;\n \n-\t\t\tDecimalType type = (DecimalType) NHibernateUtil.Decimal;\n-\t\t\tAssert.IsTrue(type.IsEqual(lhs, rhs));\n+\t\t\tAssert.That(_type.IsEqual(lhs, rhs), Is.True);\n \n \t\t\t// Test that two decimal fields that are equal except one has a higher precision than\n \t\t\t// the other one are returned as Equal by the DecimalType.\n \t\t\trhs = 5.643510M;\n-\t\t\tAssert.IsTrue(type.IsEqual(lhs, rhs));\n+\t\t\tAssert.That(_type.IsEqual(lhs, rhs), Is.True);\n \t\t}\n \n \t\t[Test]\n \t\tpublic void ReadWrite()\n \t\t{\n-\t\t\tdecimal expected = 5.64351M;\n+\t\t\tconst decimal expected = 5.64351M;\n \n-\t\t\tDecimalClass basic = new DecimalClass();\n-\t\t\tbasic.Id = 1;\n-\t\t\tbasic.DecimalValue = expected;\n+\t\t\tvar basic = new DecimalClass\n+\t\t\t{\n+\t\t\t\tId = 1,\n+\t\t\t\tDecimalValue = expected\n+\t\t\t};\n \n-\t\t\tISession s = OpenSession();\n-\t\t\ts.Save(basic);\n-\t\t\ts.Flush();\n-\t\t\ts.Close();\n+\t\t\tusing (var s = OpenSession())\n+\t\t\t{\n+\t\t\t\ts.Save(basic);\n+\t\t\t\ts.Flush();\n+\t\t\t}\n \n-\t\t\ts = OpenSession();\n-\t\t\tbasic = (DecimalClass) s.Load(typeof(DecimalClass), 1);\n+\t\t\tusing (var s = OpenSession())\n+\t\t\t{\n+\t\t\t\tbasic = s.Load<DecimalClass>(1);\n \n-\t\t\tAssert.AreEqual(expected, basic.DecimalValue);\n-\t\t\tAssert.AreEqual(5.643510M, basic.DecimalValue);\n-\n-\t\t\ts.Delete(basic);\n-\t\t\ts.Flush();\n-\t\t\ts.Close();\n+\t\t\t\tAssert.That(basic.DecimalValue, Is.EqualTo(expected));\n+\t\t\t\tAssert.That(basic.DecimalValue, Is.EqualTo(5.643510M));\n+\t\t\t}\n \t\t}\n \n \t\t[Test]\n \t\tpublic void UnsavedValue()\n \t\t{\n-\t\t\tDecimalType type = (DecimalType) NHibernateUtil.Decimal;\n-\t\t\tobject mappedValue = type.StringToObject(\"0\");\n-\t\t\tAssert.AreEqual(0m, mappedValue);\n-\t\t\tAssert.IsTrue(type.IsEqual(mappedValue, 0m), \"'0' in the mapping file should have been converted to a 0m\");\n+\t\t\tvar mappedValue = _type.StringToObject(\"0\");\n+\t\t\tAssert.That(mappedValue, Is.EqualTo(0m));\n+\t\t\tAssert.IsTrue(_type.IsEqual(mappedValue, 0m), \"'0' in the mapping file should have been converted to a 0m\");\n+\t\t}\n+\n+\t\t[Test]\n+\t\tpublic void HighScaleParameterSelect()","path":"src/NHibernate.Test/TypesTest/DecimalTypeFixture.cs","position":135,"original_position":135,"commit_id":"b15723f3ea19efb708ef75257765ba76423e527f","original_commit_id":"b15723f3ea19efb708ef75257765ba76423e527f","user":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars2.githubusercontent.com/u/12201973?v=4","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"body":"Starting with this one, new tests for checking \"high\" scale decimal are not truncated.","created_at":"2017-10-03T20:35:59Z","updated_at":"2017-10-03T20:51:03Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/708#discussion_r142515315","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/708","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/142515315"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/708#discussion_r142515315"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/708"}}},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/708","id":144520738,"html_url":"https://github.com/nhibernate/nhibernate-core/pull/708","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/708.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/708.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/708","number":708,"state":"open","locked":false,"title":"NH-4087 - Fix decimal parameter with scale above 5","user":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars2.githubusercontent.com/u/12201973?v=4","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"body":"[NH-4087](https://nhibernate.jira.com/browse/NH-4087) - Fix decimal parameter with scale above 5\r\n\r\n * Cease defining default precision/scale in SQL Server driver unless explicitly configured\r\n * Allow Firebird to adjust its default parameter type cast\r\n\r\n","created_at":"2017-10-03T20:29:22Z","updated_at":"2017-10-03T20:51:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74bd392c9253a6cd83b4a2504dc68c0914b13032","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/708/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/708/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/708/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/b15723f3ea19efb708ef75257765ba76423e527f","head":{"label":"fredericDelaporte:NH-4087","ref":"NH-4087","sha":"b15723f3ea19efb708ef75257765ba76423e527f","user":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars2.githubusercontent.com/u/12201973?v=4","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"repo":{"id":81663690,"name":"nhibernate-core","full_name":"fredericDelaporte/nhibernate-core","owner":{"login":"fredericDelaporte","id":12201973,"avatar_url":"https://avatars2.githubusercontent.com/u/12201973?v=4","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fredericDelaporte/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core","forks_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/forks","keys_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/events","assignees_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/merges","archive_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/fredericDelaporte/nhibernate-core/deployments","created_at":"2017-02-11T16:01:00Z","updated_at":"2017-02-11T16:01:12Z","pushed_at":"2017-10-03T20:24:45Z","git_url":"git://github.com/fredericDelaporte/nhibernate-core.git","ssh_url":"git@github.com:fredericDelaporte/nhibernate-core.git","clone_url":"https://github.com/fredericDelaporte/nhibernate-core.git","svn_url":"https://github.com/fredericDelaporte/nhibernate-core","homepage":"http://nhibernate.info","size":79741,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"faebdcc7a79e8083c177e3be298477a617fb8035","user":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","owner":{"login":"nhibernate","id":961041,"avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/deployments","created_at":"2011-08-14T17:51:09Z","updated_at":"2017-10-01T17:04:34Z","pushed_at":"2017-10-03T20:29:23Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":80367,"stargazers_count":1199,"watchers_count":1199,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":716,"mirror_url":null,"open_issues_count":58,"forks":716,"open_issues":58,"watchers":1199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/708"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/708"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/708"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/708/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/708/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/708/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/b15723f3ea19efb708ef75257765ba76423e527f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fredericDelaporte"}}