{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/131868105","pull_request_review_id":54886639,"id":131868105,"diff_hunk":"@@ -88,10 +88,17 @@ void RoutingSession::RebuildRoute(m2::PointD const & startPoint,\n   CHECK(m_router, ());\n   RemoveRoute();\n   SetState(routeRebuildingState);\n-  m_routingRebuildCount++;\n-  m_lastCompletionPercent = 0;\n \n-  m_checkpoints.SetPointFrom(startPoint);\n+  {\n+    // TODO: after moving all routing callbacks to single thread this guard can be removed\n+    threads::MutexGuard guard(m_routingSessionMutex);\n+    UNUSED_VALUE(guard);","path":"routing/routing_session.cpp","position":11,"original_position":11,"commit_id":"fafb0dcd05abca07d08c76b0d27cdeb32723bb7a","original_commit_id":"fafb0dcd05abca07d08c76b0d27cdeb32723bb7a","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"body":"сделала DNM реквест, чтобы проверить, соберется ли без UNUSED_VALUE или будут ворнинги у gcc, если соберется, уберу UNUSED_VALUE во всем файле https://github.com/mapsme/omim/pull/6815","created_at":"2017-08-08T09:49:06Z","updated_at":"2017-08-08T09:49:07Z","html_url":"https://github.com/mapsme/omim/pull/6808#discussion_r131868105","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/6808","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/131868105"},"html":{"href":"https://github.com/mapsme/omim/pull/6808#discussion_r131868105"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6808"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/6808","id":134458328,"html_url":"https://github.com/mapsme/omim/pull/6808","diff_url":"https://github.com/mapsme/omim/pull/6808.diff","patch_url":"https://github.com/mapsme/omim/pull/6808.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/6808","number":6808,"state":"open","locked":false,"title":"Fix route rebuild on traffic update","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"body":"MAPSME-5226\r\nПри перестроении маршрута в RebuildRouteOnTrafficUpdate не всегда нужно использовать текущее местоположение в качестве старта, а только в случае следования по маршруту (OnRoute) и в случае, если было обнаружено, что пользователь отклонился и требуется перестроение (RouteNeedRebuild). В остальных случаях перестраивать надо с той же начальной точкой, которая есть на текущий момент (для состояния RouteRebuilding точка уже обновлена, если это требуется, для остальных пользователю вероятно не надо перепрыгивать на текущую позицию).\r\n\r\nПри работе над багом также обнаружила, что RebuildRouteOnTrafficUpdate вызывается и вызывает RebuildRoute в треде, отличном от треда RoutingManager и при этом не берёт мьютекс, в результате чего могут возникнуть гонки данных -- поправила. По идее этот код будет существенно переработан при переносе всех вызовов колбеков роутинга в один тред, поэтому просто сделала чтобы в полях RoutingSession не оказался мусор.","created_at":"2017-08-07T14:59:11Z","updated_at":"2017-08-08T09:49:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cb5f895958c658ee5d8edc4bfc6c5f54e714ecb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/6808/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/6808/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/6808/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/fafb0dcd05abca07d08c76b0d27cdeb32723bb7a","head":{"label":"tatiana-kondakova:fix_deeplink_route_rebuild","ref":"fix_deeplink_route_rebuild","sha":"fafb0dcd05abca07d08c76b0d27cdeb32723bb7a","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"repo":{"id":98180090,"name":"omim","full_name":"tatiana-kondakova/omim","owner":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tatiana-kondakova/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/tatiana-kondakova/omim","forks_url":"https://api.github.com/repos/tatiana-kondakova/omim/forks","keys_url":"https://api.github.com/repos/tatiana-kondakova/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatiana-kondakova/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatiana-kondakova/omim/teams","hooks_url":"https://api.github.com/repos/tatiana-kondakova/omim/hooks","issue_events_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues/events{/number}","events_url":"https://api.github.com/repos/tatiana-kondakova/omim/events","assignees_url":"https://api.github.com/repos/tatiana-kondakova/omim/assignees{/user}","branches_url":"https://api.github.com/repos/tatiana-kondakova/omim/branches{/branch}","tags_url":"https://api.github.com/repos/tatiana-kondakova/omim/tags","blobs_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatiana-kondakova/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/tatiana-kondakova/omim/languages","stargazers_url":"https://api.github.com/repos/tatiana-kondakova/omim/stargazers","contributors_url":"https://api.github.com/repos/tatiana-kondakova/omim/contributors","subscribers_url":"https://api.github.com/repos/tatiana-kondakova/omim/subscribers","subscription_url":"https://api.github.com/repos/tatiana-kondakova/omim/subscription","commits_url":"https://api.github.com/repos/tatiana-kondakova/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatiana-kondakova/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/tatiana-kondakova/omim/contents/{+path}","compare_url":"https://api.github.com/repos/tatiana-kondakova/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatiana-kondakova/omim/merges","archive_url":"https://api.github.com/repos/tatiana-kondakova/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatiana-kondakova/omim/downloads","issues_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues{/number}","pulls_url":"https://api.github.com/repos/tatiana-kondakova/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/tatiana-kondakova/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/tatiana-kondakova/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatiana-kondakova/omim/labels{/name}","releases_url":"https://api.github.com/repos/tatiana-kondakova/omim/releases{/id}","deployments_url":"https://api.github.com/repos/tatiana-kondakova/omim/deployments","created_at":"2017-07-24T10:44:21Z","updated_at":"2017-07-24T10:45:30Z","pushed_at":"2017-08-08T09:43:51Z","git_url":"git://github.com/tatiana-kondakova/omim.git","ssh_url":"git@github.com:tatiana-kondakova/omim.git","clone_url":"https://github.com/tatiana-kondakova/omim.git","svn_url":"https://github.com/tatiana-kondakova/omim","homepage":"","size":3273792,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"26f348e47f45ebaa2a3def023d84b105ad8600c2","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-08-07T02:04:43Z","pushed_at":"2017-08-08T09:45:02Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3282795,"stargazers_count":2364,"watchers_count":2364,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":489,"mirror_url":null,"open_issues_count":527,"forks":489,"open_issues":527,"watchers":2364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6808"},"html":{"href":"https://github.com/mapsme/omim/pull/6808"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/6808"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/6808/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6808/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6808/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/fafb0dcd05abca07d08c76b0d27cdeb32723bb7a"}}}}
{"actor":{"display_login":"tatiana-kondakova"}}