{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/120848285","pull_request_review_id":42845346,"id":120848285,"diff_hunk":"@@ -66,6 +66,27 @@ extern \"C\" {\n  */\n #define GNRC_NETDEV_MAC_INFO_RX_STARTED         (0x0004U)\n \n+#ifdef MODULE_GNRC_MAC\n+/**\n+ * @brief   Flag to track if a device supports on-chip CSMA functionality\n+ *\n+ * This flag should be (is expected) set only once at the initialization of the\n+ * device, or at the initialization of the MAC protocol, according to the fact that\n+ * whether the device supports on-chip CSMA. If yes, the related flag bit should\n+ * be set, otherwise, should be cleared.\n+ */\n+#define GNRC_NETDEV_MAC_INFO_ONCHIP_CSMA        (0x0100U)","path":"sys/include/net/gnrc/netdev.h","position":23,"original_position":13,"commit_id":"779d411fabb7b4422d23954471bf4a77959da1a7","original_commit_id":"1a1fff048f318ca4fb1373b4ca7f2b877f4b3dfe","user":{"login":"gebart","id":317506,"avatar_url":"https://avatars2.githubusercontent.com/u/317506?v=3","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"body":"This is already handled via netopt by csma_sender_csma_ca_send. If the check in csma_sender is not correct, then it should be refactored instead of adding another layer of checks on top. ","created_at":"2017-06-08T10:07:39Z","updated_at":"2017-06-08T10:09:37Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/7155#discussion_r120848285","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7155","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/120848285"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/7155#discussion_r120848285"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7155"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7155","id":124611095,"html_url":"https://github.com/RIOT-OS/RIOT/pull/7155","diff_url":"https://github.com/RIOT-OS/RIOT/pull/7155.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/7155.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/7155","number":7155,"state":"open","locked":false,"title":"gnrc_mac: use csma_sender API when needed for csma transmission","user":{"login":"zhuoshuguo","id":9894607,"avatar_url":"https://avatars2.githubusercontent.com/u/9894607?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoshuguo","html_url":"https://github.com/zhuoshuguo","followers_url":"https://api.github.com/users/zhuoshuguo/followers","following_url":"https://api.github.com/users/zhuoshuguo/following{/other_user}","gists_url":"https://api.github.com/users/zhuoshuguo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoshuguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoshuguo/subscriptions","organizations_url":"https://api.github.com/users/zhuoshuguo/orgs","repos_url":"https://api.github.com/users/zhuoshuguo/repos","events_url":"https://api.github.com/users/zhuoshuguo/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoshuguo/received_events","type":"User","site_admin":false},"body":"This PR adds `csma_sender` to gnrc_mac for enabling software CSMA transmission when needed (for devices that don't support hardware CSMA).\r\nRelated operations are based on the corresponding flags that indicate whether the device supports/wants CSMA transmissions.\r\n\r\n@miri64 @gebart Could you check whether you are happy with this PR. :-)\r\n\r\nOnce this PR would be merged, I will immediately adapt [Lw-MAC](https://github.com/RIOT-OS/RIOT/pull/6554) to use it.","created_at":"2017-06-08T09:56:39Z","updated_at":"2017-06-08T10:09:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d937c8bf11ba0f64cf4d63d0939ec3c0033d540d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7155/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7155/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/7155/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/779d411fabb7b4422d23954471bf4a77959da1a7","head":{"label":"zhuoshuguo:gnrc_mac_use_csma_sender","ref":"gnrc_mac_use_csma_sender","sha":"779d411fabb7b4422d23954471bf4a77959da1a7","user":{"login":"zhuoshuguo","id":9894607,"avatar_url":"https://avatars2.githubusercontent.com/u/9894607?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoshuguo","html_url":"https://github.com/zhuoshuguo","followers_url":"https://api.github.com/users/zhuoshuguo/followers","following_url":"https://api.github.com/users/zhuoshuguo/following{/other_user}","gists_url":"https://api.github.com/users/zhuoshuguo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoshuguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoshuguo/subscriptions","organizations_url":"https://api.github.com/users/zhuoshuguo/orgs","repos_url":"https://api.github.com/users/zhuoshuguo/repos","events_url":"https://api.github.com/users/zhuoshuguo/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoshuguo/received_events","type":"User","site_admin":false},"repo":{"id":54036204,"name":"RIOT","full_name":"zhuoshuguo/RIOT","owner":{"login":"zhuoshuguo","id":9894607,"avatar_url":"https://avatars2.githubusercontent.com/u/9894607?v=3","gravatar_id":"","url":"https://api.github.com/users/zhuoshuguo","html_url":"https://github.com/zhuoshuguo","followers_url":"https://api.github.com/users/zhuoshuguo/followers","following_url":"https://api.github.com/users/zhuoshuguo/following{/other_user}","gists_url":"https://api.github.com/users/zhuoshuguo/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuoshuguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuoshuguo/subscriptions","organizations_url":"https://api.github.com/users/zhuoshuguo/orgs","repos_url":"https://api.github.com/users/zhuoshuguo/repos","events_url":"https://api.github.com/users/zhuoshuguo/events{/privacy}","received_events_url":"https://api.github.com/users/zhuoshuguo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhuoshuguo/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/zhuoshuguo/RIOT","forks_url":"https://api.github.com/repos/zhuoshuguo/RIOT/forks","keys_url":"https://api.github.com/repos/zhuoshuguo/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhuoshuguo/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhuoshuguo/RIOT/teams","hooks_url":"https://api.github.com/repos/zhuoshuguo/RIOT/hooks","issue_events_url":"https://api.github.com/repos/zhuoshuguo/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/zhuoshuguo/RIOT/events","assignees_url":"https://api.github.com/repos/zhuoshuguo/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/zhuoshuguo/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/zhuoshuguo/RIOT/tags","blobs_url":"https://api.github.com/repos/zhuoshuguo/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhuoshuguo/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhuoshuguo/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhuoshuguo/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhuoshuguo/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/zhuoshuguo/RIOT/languages","stargazers_url":"https://api.github.com/repos/zhuoshuguo/RIOT/stargazers","contributors_url":"https://api.github.com/repos/zhuoshuguo/RIOT/contributors","subscribers_url":"https://api.github.com/repos/zhuoshuguo/RIOT/subscribers","subscription_url":"https://api.github.com/repos/zhuoshuguo/RIOT/subscription","commits_url":"https://api.github.com/repos/zhuoshuguo/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhuoshuguo/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhuoshuguo/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhuoshuguo/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhuoshuguo/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/zhuoshuguo/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhuoshuguo/RIOT/merges","archive_url":"https://api.github.com/repos/zhuoshuguo/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhuoshuguo/RIOT/downloads","issues_url":"https://api.github.com/repos/zhuoshuguo/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/zhuoshuguo/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/zhuoshuguo/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/zhuoshuguo/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhuoshuguo/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/zhuoshuguo/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/zhuoshuguo/RIOT/deployments","created_at":"2016-03-16T13:56:24Z","updated_at":"2016-03-16T13:56:38Z","pushed_at":"2017-06-08T10:07:44Z","git_url":"git://github.com/zhuoshuguo/RIOT.git","ssh_url":"git@github.com:zhuoshuguo/RIOT.git","clone_url":"https://github.com/zhuoshuguo/RIOT.git","svn_url":"https://github.com/zhuoshuguo/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":40428,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"fix_cpu_header_include_guards"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"078bf23a1799725a8a006bac7ccaaadd3a213226","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars1.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars1.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2017-06-08T09:54:14Z","pushed_at":"2017-06-08T10:07:46Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":39458,"stargazers_count":1287,"watchers_count":1287,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":789,"mirror_url":null,"open_issues_count":568,"forks":789,"open_issues":568,"watchers":1287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7155"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/7155"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/7155"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/7155/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7155/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7155/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/779d411fabb7b4422d23954471bf4a77959da1a7"}}}}
{"actor":{"display_login":"gebart"}}