{"action":"created","comment":{"url":"https://api.github.com/repos/mripard/sunxi-mali/pulls/comments/157792069","pull_request_review_id":84493085,"id":157792069,"diff_hunk":"@@ -59,7 +59,9 @@ _mali_osk_errcode_t mali_mem_validation_check(u32 phys_addr, u32 size)\n \t\t}\n \t}\n \n-\tMALI_PRINT_ERROR((\"MALI PHYSICAL RANGE VALIDATION ERROR: The range supplied was: phys_base=0x%08X, size=0x%08X\\n\", phys_addr, size));\n+\tMALI_PRINT_ERROR((\"MALI PHYSICAL RANGE VALIDATION ERROR: The range supplied was:\\n\"\n+\t\t\t    \"phys_base=0x%08X, size=0x%08X, valid_base=0x%08X, valid_size=0x%08X\\n\",\n+\t\t\t    phys_addr, size, mali_mem_validator.phys_base, mali_mem_validator.size));","path":"r6p2/src/devicedrv/mali/common/mali_mem_validation.c","position":7,"original_position":7,"commit_id":"401ce7f13945e63d84cb3f4de2a3a4ef0c6d9af7","original_commit_id":"401ce7f13945e63d84cb3f4de2a3a4ef0c6d9af7","user":{"login":"giuliobenetti","id":2040297,"avatar_url":"https://avatars3.githubusercontent.com/u/2040297?v=4","gravatar_id":"","url":"https://api.github.com/users/giuliobenetti","html_url":"https://github.com/giuliobenetti","followers_url":"https://api.github.com/users/giuliobenetti/followers","following_url":"https://api.github.com/users/giuliobenetti/following{/other_user}","gists_url":"https://api.github.com/users/giuliobenetti/gists{/gist_id}","starred_url":"https://api.github.com/users/giuliobenetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuliobenetti/subscriptions","organizations_url":"https://api.github.com/users/giuliobenetti/orgs","repos_url":"https://api.github.com/users/giuliobenetti/repos","events_url":"https://api.github.com/users/giuliobenetti/events{/privacy}","received_events_url":"https://api.github.com/users/giuliobenetti/received_events","type":"User","site_admin":false},"body":"Oh, you're right. It has to be a separate patch.\r\nAbout error I assumed it is range provided through DT,\r\nbut I'm not sure, I have to test it.\r\n\r\nSo I prefer to remove this commit and postpone it.","created_at":"2017-12-19T15:48:33Z","updated_at":"2017-12-19T15:48:33Z","html_url":"https://github.com/mripard/sunxi-mali/pull/19#discussion_r157792069","pull_request_url":"https://api.github.com/repos/mripard/sunxi-mali/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mripard/sunxi-mali/pulls/comments/157792069"},"html":{"href":"https://github.com/mripard/sunxi-mali/pull/19#discussion_r157792069"},"pull_request":{"href":"https://api.github.com/repos/mripard/sunxi-mali/pulls/19"}},"in_reply_to_id":157749967},"pull_request":{"url":"https://api.github.com/repos/mripard/sunxi-mali/pulls/19","id":158144095,"html_url":"https://github.com/mripard/sunxi-mali/pull/19","diff_url":"https://github.com/mripard/sunxi-mali/pull/19.diff","patch_url":"https://github.com/mripard/sunxi-mali/pull/19.patch","issue_url":"https://api.github.com/repos/mripard/sunxi-mali/issues/19","number":19,"state":"open","locked":false,"title":"Added clean option to build.sh and updated multi-buffering informations","user":{"login":"giuliobenetti","id":2040297,"avatar_url":"https://avatars3.githubusercontent.com/u/2040297?v=4","gravatar_id":"","url":"https://api.github.com/users/giuliobenetti","html_url":"https://github.com/giuliobenetti","followers_url":"https://api.github.com/users/giuliobenetti/followers","following_url":"https://api.github.com/users/giuliobenetti/following{/other_user}","gists_url":"https://api.github.com/users/giuliobenetti/gists{/gist_id}","starred_url":"https://api.github.com/users/giuliobenetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuliobenetti/subscriptions","organizations_url":"https://api.github.com/users/giuliobenetti/orgs","repos_url":"https://api.github.com/users/giuliobenetti/repos","events_url":"https://api.github.com/users/giuliobenetti/events{/privacy}","received_events_url":"https://api.github.com/users/giuliobenetti/received_events","type":"User","site_admin":false},"body":"Added clean option to build.sh\r\nUpdated informations regarding multi-buffering\r\nAdded validator phys_base and size on MALI_PRINT_ERROR","created_at":"2017-12-13T16:40:04Z","updated_at":"2017-12-19T15:48:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc7392658d4caf958db272a854ef343bcfc3f3e7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mripard/sunxi-mali/pulls/19/commits","review_comments_url":"https://api.github.com/repos/mripard/sunxi-mali/pulls/19/comments","review_comment_url":"https://api.github.com/repos/mripard/sunxi-mali/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mripard/sunxi-mali/issues/19/comments","statuses_url":"https://api.github.com/repos/mripard/sunxi-mali/statuses/401ce7f13945e63d84cb3f4de2a3a4ef0c6d9af7","head":{"label":"micronovasrl:master","ref":"master","sha":"401ce7f13945e63d84cb3f4de2a3a4ef0c6d9af7","user":{"login":"micronovasrl","id":32640638,"avatar_url":"https://avatars3.githubusercontent.com/u/32640638?v=4","gravatar_id":"","url":"https://api.github.com/users/micronovasrl","html_url":"https://github.com/micronovasrl","followers_url":"https://api.github.com/users/micronovasrl/followers","following_url":"https://api.github.com/users/micronovasrl/following{/other_user}","gists_url":"https://api.github.com/users/micronovasrl/gists{/gist_id}","starred_url":"https://api.github.com/users/micronovasrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micronovasrl/subscriptions","organizations_url":"https://api.github.com/users/micronovasrl/orgs","repos_url":"https://api.github.com/users/micronovasrl/repos","events_url":"https://api.github.com/users/micronovasrl/events{/privacy}","received_events_url":"https://api.github.com/users/micronovasrl/received_events","type":"Organization","site_admin":false},"repo":{"id":112018387,"name":"linova-sunxi-mali","full_name":"micronovasrl/linova-sunxi-mali","owner":{"login":"micronovasrl","id":32640638,"avatar_url":"https://avatars3.githubusercontent.com/u/32640638?v=4","gravatar_id":"","url":"https://api.github.com/users/micronovasrl","html_url":"https://github.com/micronovasrl","followers_url":"https://api.github.com/users/micronovasrl/followers","following_url":"https://api.github.com/users/micronovasrl/following{/other_user}","gists_url":"https://api.github.com/users/micronovasrl/gists{/gist_id}","starred_url":"https://api.github.com/users/micronovasrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micronovasrl/subscriptions","organizations_url":"https://api.github.com/users/micronovasrl/orgs","repos_url":"https://api.github.com/users/micronovasrl/repos","events_url":"https://api.github.com/users/micronovasrl/events{/privacy}","received_events_url":"https://api.github.com/users/micronovasrl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micronovasrl/linova-sunxi-mali","description":null,"fork":true,"url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali","forks_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/forks","keys_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/teams","hooks_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/hooks","issue_events_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/issues/events{/number}","events_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/events","assignees_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/assignees{/user}","branches_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/branches{/branch}","tags_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/tags","blobs_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/git/refs{/sha}","trees_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/statuses/{sha}","languages_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/languages","stargazers_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/stargazers","contributors_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/contributors","subscribers_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/subscribers","subscription_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/subscription","commits_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/commits{/sha}","git_commits_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/git/commits{/sha}","comments_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/comments{/number}","issue_comment_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/issues/comments{/number}","contents_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/contents/{+path}","compare_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/merges","archive_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/downloads","issues_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/issues{/number}","pulls_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/pulls{/number}","milestones_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/milestones{/number}","notifications_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/labels{/name}","releases_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/releases{/id}","deployments_url":"https://api.github.com/repos/micronovasrl/linova-sunxi-mali/deployments","created_at":"2017-11-25T16:33:34Z","updated_at":"2017-12-14T21:44:33Z","pushed_at":"2017-12-15T20:26:11Z","git_url":"git://github.com/micronovasrl/linova-sunxi-mali.git","ssh_url":"git@github.com:micronovasrl/linova-sunxi-mali.git","clone_url":"https://github.com/micronovasrl/linova-sunxi-mali.git","svn_url":"https://github.com/micronovasrl/linova-sunxi-mali","homepage":null,"size":509,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mripard:master","ref":"master","sha":"2e7fa4ce38141a5860baf92d052020a99886d689","user":{"login":"mripard","id":368287,"avatar_url":"https://avatars3.githubusercontent.com/u/368287?v=4","gravatar_id":"","url":"https://api.github.com/users/mripard","html_url":"https://github.com/mripard","followers_url":"https://api.github.com/users/mripard/followers","following_url":"https://api.github.com/users/mripard/following{/other_user}","gists_url":"https://api.github.com/users/mripard/gists{/gist_id}","starred_url":"https://api.github.com/users/mripard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mripard/subscriptions","organizations_url":"https://api.github.com/users/mripard/orgs","repos_url":"https://api.github.com/users/mripard/repos","events_url":"https://api.github.com/users/mripard/events{/privacy}","received_events_url":"https://api.github.com/users/mripard/received_events","type":"User","site_admin":false},"repo":{"id":63767335,"name":"sunxi-mali","full_name":"mripard/sunxi-mali","owner":{"login":"mripard","id":368287,"avatar_url":"https://avatars3.githubusercontent.com/u/368287?v=4","gravatar_id":"","url":"https://api.github.com/users/mripard","html_url":"https://github.com/mripard","followers_url":"https://api.github.com/users/mripard/followers","following_url":"https://api.github.com/users/mripard/following{/other_user}","gists_url":"https://api.github.com/users/mripard/gists{/gist_id}","starred_url":"https://api.github.com/users/mripard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mripard/subscriptions","organizations_url":"https://api.github.com/users/mripard/orgs","repos_url":"https://api.github.com/users/mripard/repos","events_url":"https://api.github.com/users/mripard/events{/privacy}","received_events_url":"https://api.github.com/users/mripard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mripard/sunxi-mali","description":null,"fork":false,"url":"https://api.github.com/repos/mripard/sunxi-mali","forks_url":"https://api.github.com/repos/mripard/sunxi-mali/forks","keys_url":"https://api.github.com/repos/mripard/sunxi-mali/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mripard/sunxi-mali/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mripard/sunxi-mali/teams","hooks_url":"https://api.github.com/repos/mripard/sunxi-mali/hooks","issue_events_url":"https://api.github.com/repos/mripard/sunxi-mali/issues/events{/number}","events_url":"https://api.github.com/repos/mripard/sunxi-mali/events","assignees_url":"https://api.github.com/repos/mripard/sunxi-mali/assignees{/user}","branches_url":"https://api.github.com/repos/mripard/sunxi-mali/branches{/branch}","tags_url":"https://api.github.com/repos/mripard/sunxi-mali/tags","blobs_url":"https://api.github.com/repos/mripard/sunxi-mali/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mripard/sunxi-mali/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mripard/sunxi-mali/git/refs{/sha}","trees_url":"https://api.github.com/repos/mripard/sunxi-mali/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mripard/sunxi-mali/statuses/{sha}","languages_url":"https://api.github.com/repos/mripard/sunxi-mali/languages","stargazers_url":"https://api.github.com/repos/mripard/sunxi-mali/stargazers","contributors_url":"https://api.github.com/repos/mripard/sunxi-mali/contributors","subscribers_url":"https://api.github.com/repos/mripard/sunxi-mali/subscribers","subscription_url":"https://api.github.com/repos/mripard/sunxi-mali/subscription","commits_url":"https://api.github.com/repos/mripard/sunxi-mali/commits{/sha}","git_commits_url":"https://api.github.com/repos/mripard/sunxi-mali/git/commits{/sha}","comments_url":"https://api.github.com/repos/mripard/sunxi-mali/comments{/number}","issue_comment_url":"https://api.github.com/repos/mripard/sunxi-mali/issues/comments{/number}","contents_url":"https://api.github.com/repos/mripard/sunxi-mali/contents/{+path}","compare_url":"https://api.github.com/repos/mripard/sunxi-mali/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mripard/sunxi-mali/merges","archive_url":"https://api.github.com/repos/mripard/sunxi-mali/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mripard/sunxi-mali/downloads","issues_url":"https://api.github.com/repos/mripard/sunxi-mali/issues{/number}","pulls_url":"https://api.github.com/repos/mripard/sunxi-mali/pulls{/number}","milestones_url":"https://api.github.com/repos/mripard/sunxi-mali/milestones{/number}","notifications_url":"https://api.github.com/repos/mripard/sunxi-mali/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mripard/sunxi-mali/labels{/name}","releases_url":"https://api.github.com/repos/mripard/sunxi-mali/releases{/id}","deployments_url":"https://api.github.com/repos/mripard/sunxi-mali/deployments","created_at":"2016-07-20T09:10:34Z","updated_at":"2017-12-06T12:57:16Z","pushed_at":"2017-12-19T13:06:10Z","git_url":"git://github.com/mripard/sunxi-mali.git","ssh_url":"git@github.com:mripard/sunxi-mali.git","clone_url":"https://github.com/mripard/sunxi-mali.git","svn_url":"https://github.com/mripard/sunxi-mali","homepage":null,"size":512,"stargazers_count":29,"watchers_count":29,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":11,"open_issues":2,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mripard/sunxi-mali/pulls/19"},"html":{"href":"https://github.com/mripard/sunxi-mali/pull/19"},"issue":{"href":"https://api.github.com/repos/mripard/sunxi-mali/issues/19"},"comments":{"href":"https://api.github.com/repos/mripard/sunxi-mali/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/mripard/sunxi-mali/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/mripard/sunxi-mali/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mripard/sunxi-mali/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/mripard/sunxi-mali/statuses/401ce7f13945e63d84cb3f4de2a3a4ef0c6d9af7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"giuliobenetti"}}