{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/cartoframes/issues/223","repository_url":"https://api.github.com/repos/CartoDB/cartoframes","labels_url":"https://api.github.com/repos/CartoDB/cartoframes/issues/223/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/cartoframes/issues/223/comments","events_url":"https://api.github.com/repos/CartoDB/cartoframes/issues/223/events","html_url":"https://github.com/CartoDB/cartoframes/pull/223","id":260055481,"number":223,"title":"Brings animated (torque) maps to life","user":{"login":"andy-esch","id":1041056,"avatar_url":"https://avatars2.githubusercontent.com/u/1041056?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-esch","html_url":"https://github.com/andy-esch","followers_url":"https://api.github.com/users/andy-esch/followers","following_url":"https://api.github.com/users/andy-esch/following{/other_user}","gists_url":"https://api.github.com/users/andy-esch/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-esch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-esch/subscriptions","organizations_url":"https://api.github.com/users/andy-esch/orgs","repos_url":"https://api.github.com/users/andy-esch/repos","events_url":"https://api.github.com/users/andy-esch/events{/privacy}","received_events_url":"https://api.github.com/users/andy-esch/received_events","type":"User","site_admin":false},"labels":[{"id":547255173,"url":"https://api.github.com/repos/CartoDB/cartoframes/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-09-24T03:44:11Z","updated_at":"2017-10-04T20:30:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/CartoDB/cartoframes/pulls/223","html_url":"https://github.com/CartoDB/cartoframes/pull/223","diff_url":"https://github.com/CartoDB/cartoframes/pull/223.diff","patch_url":"https://github.com/CartoDB/cartoframes/pull/223.patch"},"body":"This PR brings torque maps to cartoframes. \r\n\r\n## Examples\r\n### Basic usage\r\n![torque-cartoframes](https://user-images.githubusercontent.com/1041056/30779023-c9721942-a0b1-11e7-8dc0-efe740c869a2.gif)\r\n\r\n### Torque Category and Numeric classification\r\n![torque-cartoframes](https://user-images.githubusercontent.com/1041056/31156593-52fdc994-a883-11e7-941e-8e0b3ce81884.gif)\r\n\r\n## Modifications / enhancements\r\n- configures `cartoframes/assets/cartoframes.html` to use the basemap instead of relying on the named maps basemap (which seems to not be directly loadable with torque named maps)\r\n- fixes order of cartocss generated so `Map {...}` code appears before `#layer {...}`\r\n- restricts maps to basemap + animated layer for now\r\n- some general code cleanups\r\n- better handling of errors with maps api POSTs\r\n- cleans up `cumulative` options (True/False only)\r\n- new defaults for torque styles (size = 4 as opposed to static sizes of 10 / colors of `#2752ff`)\r\n- constructs turbo carto style, sends it to carto, gets processed version since torque can't directly handle turbo carto styles\r\n\r\n## Restrictions\r\n- torque maps can only be one-layered (no static layers)\r\n- currently cannot combine size and color attributes with torque (what to do with trails, etc.)\r\n- the torque tiles are pulled from the named map, but no raster layers are pulled, so basemaps have to be setup elsewhere. i'm currently restricting basemaps to no-label and labels on bottom for now.\r\n\r\n## Problems still to work through\r\n- [x] torque category maps\r\n- [x] numeric classification\r\n- [ ] boolean values are not working for category classification\r\n\r\n## ToDos\r\n\r\n- [ ] more ad hoc tests on different datasets\r\n\r\ncc @makella "},"comment":{"url":"https://api.github.com/repos/CartoDB/cartoframes/issues/comments/334280083","html_url":"https://github.com/CartoDB/cartoframes/pull/223#issuecomment-334280083","issue_url":"https://api.github.com/repos/CartoDB/cartoframes/issues/223","id":334280083,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-10-04T20:30:29Z","updated_at":"2017-10-04T20:30:29Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/13572171/badge)](https://coveralls.io/builds/13572171)\n\nCoverage increased (+1.8%) to 95.544% when pulling **6ad6433ffb852a873faaf1d4ca4c7cd8ad1ba883 on fix-torque-maps** into **63569f6621d45f86c7d8f1ced5253d4cc824c2e0 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}