{"action":"created","comment":{"url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/comments/125979608","pull_request_review_id":48423095,"id":125979608,"diff_hunk":"@@ -0,0 +1,194 @@\n+within Buildings.Experimental.OpenBuildingControl.ASHRAE.G36.AtomicSequences;\n+block EconModulationMultiZone\n+  \"Outdoor and return air damper position modulation sequence for multiple zone VAV AHU\"\n+\n+  parameter Real outDamConSigMax(min=0, max=1, unit=\"1\") = retDamConSigMin\n+  \"Maximum control loop signal for the outdoor air damper\";\n+  parameter Real retDamConSigMin(min=0, max=1, unit=\"1\") = 0.5\n+  \"Minimum control loop signal for the return air damper\";\n+  parameter Real yConSigMin=0 \"Lower limit of controller output\";\n+  parameter Real yConSigMax=1 \"Upper limit of controller output\";\n+  parameter Real controllerGain=1 \"Gain of controller\";\n+\n+  CDL.Interfaces.RealInput TSup(unit=\"K\", quantity = \"ThermodynamicTemperature\")\n+    \"Measured supply air temperature\" annotation (Placement(transformation(extent={{-160,-40},{-120,0}}),\n+        iconTransformation(extent={{-120,50},{-100,70}})));\n+  CDL.Interfaces.RealInput TCooSet(unit=\"K\", quantity = \"ThermodynamicTemperature\")\n+    \"Supply air temperature cooling setpoint\" annotation (Placement(transformation(extent={{-160,-10},{-120,30}}),\n+        iconTransformation(extent={{-120,80},{-100,100}})));\n+  CDL.Interfaces.RealInput uOutDamPosMin(min=0, max=1, unit=\"1\")\n+    \"Minimum economizer damper position limit as returned by the EconDamperPositionLimitsMultiZone sequence\"\n+    annotation (Placement(transformation(extent={{-160,-120},{-120,-80}}),\n+        iconTransformation(extent={{-120,-30},{-100,-10}})));    //fixme: add quantity for ALL damper positions?\n+  CDL.Interfaces.RealInput uOutDamPosMax(min=0, max=1, unit=\"1\")\n+    \"Maximum economizer damper position limit as returned by the EconEnableDisableMultiZone sequence. \n+    If the economizer is disabled, this value equals uOutDamPosMin\"\n+    annotation (Placement(transformation(extent={{-160,-90},{-120,-50}}),\n+        iconTransformation(extent={{-120,0},{-100,20}})));\n+  CDL.Interfaces.RealInput uRetDamPosMin(min=0, max=1, unit=\"1\")\n+    \"Minimum return air damper position limit as returned by the EconEnableDisableMultiZone sequence\"\n+    annotation (Placement(transformation(extent={{-160,40},{-120,80}}),\n+        iconTransformation(extent={{-120,-100},{-100,-80}})));\n+  CDL.Interfaces.RealInput uRetDamPosMax(min=0, max=1, unit=\"1\")\n+    \"Maximum return air damper position limit as returned by the EconEnableDisableMultiZone sequence.\"\n+    annotation (Placement(transformation(extent={{-160,80},{-120,120}}),\n+        iconTransformation(extent={{-120,-70},{-100,-50}})));\n+\n+  CDL.Interfaces.RealOutput yOutDamPos(min=0, max=1, unit=\"1\") \"Economizer damper position\"\n+    annotation (Placement(transformation(extent={{120,-30},{140,-10}}),\n+        iconTransformation(extent={{100,-30},{120,-10}})));\n+  CDL.Interfaces.RealOutput yRetDamPos(min=0, max=1, unit=\"1\") \"Return air damper position\"\n+    annotation (Placement(transformation(extent={{120,10},{140,30}}),\n+        iconTransformation(extent={{100,10},{120,30}})));\n+\n+  CDL.Continuous.LimPID damPosController(\n+    Td=0.1,","path":"Buildings/Experimental/OpenBuildingControl/ASHRAE/G36/AtomicSequences/EconModulationMultiZone.mo","position":45,"original_position":45,"commit_id":"e88c76d53573e01a58cf3a6686b83ee6f9cdabe5","original_commit_id":"e88c76d53573e01a58cf3a6686b83ee6f9cdabe5","user":{"login":"milicag","id":5322943,"avatar_url":"https://avatars3.githubusercontent.com/u/5322943?v=3","gravatar_id":"","url":"https://api.github.com/users/milicag","html_url":"https://github.com/milicag","followers_url":"https://api.github.com/users/milicag/followers","following_url":"https://api.github.com/users/milicag/following{/other_user}","gists_url":"https://api.github.com/users/milicag/gists{/gist_id}","starred_url":"https://api.github.com/users/milicag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milicag/subscriptions","organizations_url":"https://api.github.com/users/milicag/orgs","repos_url":"https://api.github.com/users/milicag/repos","events_url":"https://api.github.com/users/milicag/events{/privacy}","received_events_url":"https://api.github.com/users/milicag/received_events","type":"User","site_admin":false},"body":"![pi_cont_default](https://user-images.githubusercontent.com/5322943/27926771-6af54f1c-623e-11e7-90d2-ba1e081be181.PNG)\r\n","created_at":"2017-07-06T18:29:49Z","updated_at":"2017-07-06T18:29:49Z","html_url":"https://github.com/lbl-srg/modelica-buildings/pull/832#discussion_r125979608","pull_request_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/832","_links":{"self":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/comments/125979608"},"html":{"href":"https://github.com/lbl-srg/modelica-buildings/pull/832#discussion_r125979608"},"pull_request":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/832"}}},"pull_request":{"url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/832","id":128697075,"html_url":"https://github.com/lbl-srg/modelica-buildings/pull/832","diff_url":"https://github.com/lbl-srg/modelica-buildings/pull/832.diff","patch_url":"https://github.com/lbl-srg/modelica-buildings/pull/832.patch","issue_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/832","number":832,"state":"open","locked":false,"title":"Multizone VAV AHU economizer control sequence","user":{"login":"milicag","id":5322943,"avatar_url":"https://avatars3.githubusercontent.com/u/5322943?v=3","gravatar_id":"","url":"https://api.github.com/users/milicag","html_url":"https://github.com/milicag","followers_url":"https://api.github.com/users/milicag/followers","following_url":"https://api.github.com/users/milicag/following{/other_user}","gists_url":"https://api.github.com/users/milicag/gists{/gist_id}","starred_url":"https://api.github.com/users/milicag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milicag/subscriptions","organizations_url":"https://api.github.com/users/milicag/orgs","repos_url":"https://api.github.com/users/milicag/repos","events_url":"https://api.github.com/users/milicag/events{/privacy}","received_events_url":"https://api.github.com/users/milicag/received_events","type":"User","site_admin":false},"body":"This PR adds a multizone VAV AHU economizer control sequence as prescribed by ASHRAE Guideline 36 (G36). The PR comprises 3 atomic and 1 composite control sequence models with the corresponding tests, scripts and validation results. \r\n\r\nAtomic control sequences:\r\n\r\n- ```EconDamperPositionLimitsMultiZone```:  Outdoor and return air damper position limits for minimum outdoor airflow control\r\n- ```EconEnableDisableMultiZone```: Economizer enable/disable switch\r\n- ```EconModulationMultiZone```: Outdoor and return air damper position modulation for economizer operation\r\n\r\nComposite control sequence:\r\n\r\n- ```EconomizerMultiZone```: Multiple zone VAV AHU economizer control sequence\r\n\r\nIn addition, the PR introduces ```OperationMode```, ```ZoneState```, and ```FreezeProtectionStage``` ```Types```, also according to G36.","created_at":"2017-07-03T21:37:33Z","updated_at":"2017-07-06T18:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33dd07411e095a528c971622813d97b842493813","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JayHuLBL","id":23491921,"avatar_url":"https://avatars2.githubusercontent.com/u/23491921?v=3","gravatar_id":"","url":"https://api.github.com/users/JayHuLBL","html_url":"https://github.com/JayHuLBL","followers_url":"https://api.github.com/users/JayHuLBL/followers","following_url":"https://api.github.com/users/JayHuLBL/following{/other_user}","gists_url":"https://api.github.com/users/JayHuLBL/gists{/gist_id}","starred_url":"https://api.github.com/users/JayHuLBL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayHuLBL/subscriptions","organizations_url":"https://api.github.com/users/JayHuLBL/orgs","repos_url":"https://api.github.com/users/JayHuLBL/repos","events_url":"https://api.github.com/users/JayHuLBL/events{/privacy}","received_events_url":"https://api.github.com/users/JayHuLBL/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/832/commits","review_comments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/832/comments","review_comment_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/832/comments","statuses_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/statuses/e88c76d53573e01a58cf3a6686b83ee6f9cdabe5","head":{"label":"lbl-srg:issue805_multizone_econ","ref":"issue805_multizone_econ","sha":"e88c76d53573e01a58cf3a6686b83ee6f9cdabe5","user":{"login":"lbl-srg","id":3753398,"avatar_url":"https://avatars0.githubusercontent.com/u/3753398?v=3","gravatar_id":"","url":"https://api.github.com/users/lbl-srg","html_url":"https://github.com/lbl-srg","followers_url":"https://api.github.com/users/lbl-srg/followers","following_url":"https://api.github.com/users/lbl-srg/following{/other_user}","gists_url":"https://api.github.com/users/lbl-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/lbl-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbl-srg/subscriptions","organizations_url":"https://api.github.com/users/lbl-srg/orgs","repos_url":"https://api.github.com/users/lbl-srg/repos","events_url":"https://api.github.com/users/lbl-srg/events{/privacy}","received_events_url":"https://api.github.com/users/lbl-srg/received_events","type":"Organization","site_admin":false},"repo":{"id":8538889,"name":"modelica-buildings","full_name":"lbl-srg/modelica-buildings","owner":{"login":"lbl-srg","id":3753398,"avatar_url":"https://avatars0.githubusercontent.com/u/3753398?v=3","gravatar_id":"","url":"https://api.github.com/users/lbl-srg","html_url":"https://github.com/lbl-srg","followers_url":"https://api.github.com/users/lbl-srg/followers","following_url":"https://api.github.com/users/lbl-srg/following{/other_user}","gists_url":"https://api.github.com/users/lbl-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/lbl-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbl-srg/subscriptions","organizations_url":"https://api.github.com/users/lbl-srg/orgs","repos_url":"https://api.github.com/users/lbl-srg/repos","events_url":"https://api.github.com/users/lbl-srg/events{/privacy}","received_events_url":"https://api.github.com/users/lbl-srg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbl-srg/modelica-buildings","description":"Modelica Buildings library","fork":false,"url":"https://api.github.com/repos/lbl-srg/modelica-buildings","forks_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/forks","keys_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/teams","hooks_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/hooks","issue_events_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/events{/number}","events_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/events","assignees_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/assignees{/user}","branches_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/branches{/branch}","tags_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/tags","blobs_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/statuses/{sha}","languages_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/languages","stargazers_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/stargazers","contributors_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/contributors","subscribers_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/subscribers","subscription_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/subscription","commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/contents/{+path}","compare_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/merges","archive_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/downloads","issues_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues{/number}","pulls_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls{/number}","milestones_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/milestones{/number}","notifications_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/labels{/name}","releases_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/releases{/id}","deployments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/deployments","created_at":"2013-03-03T16:36:03Z","updated_at":"2017-06-26T15:22:13Z","pushed_at":"2017-07-06T17:07:00Z","git_url":"git://github.com/lbl-srg/modelica-buildings.git","ssh_url":"git@github.com:lbl-srg/modelica-buildings.git","clone_url":"https://github.com/lbl-srg/modelica-buildings.git","svn_url":"https://github.com/lbl-srg/modelica-buildings","homepage":null,"size":123023,"stargazers_count":48,"watchers_count":48,"language":"Modelica","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":59,"forks":45,"open_issues":59,"watchers":48,"default_branch":"master"}},"base":{"label":"lbl-srg:issue609_cdl","ref":"issue609_cdl","sha":"d01f50585ac4525b345b887a9b1ae66ee4c704a9","user":{"login":"lbl-srg","id":3753398,"avatar_url":"https://avatars0.githubusercontent.com/u/3753398?v=3","gravatar_id":"","url":"https://api.github.com/users/lbl-srg","html_url":"https://github.com/lbl-srg","followers_url":"https://api.github.com/users/lbl-srg/followers","following_url":"https://api.github.com/users/lbl-srg/following{/other_user}","gists_url":"https://api.github.com/users/lbl-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/lbl-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbl-srg/subscriptions","organizations_url":"https://api.github.com/users/lbl-srg/orgs","repos_url":"https://api.github.com/users/lbl-srg/repos","events_url":"https://api.github.com/users/lbl-srg/events{/privacy}","received_events_url":"https://api.github.com/users/lbl-srg/received_events","type":"Organization","site_admin":false},"repo":{"id":8538889,"name":"modelica-buildings","full_name":"lbl-srg/modelica-buildings","owner":{"login":"lbl-srg","id":3753398,"avatar_url":"https://avatars0.githubusercontent.com/u/3753398?v=3","gravatar_id":"","url":"https://api.github.com/users/lbl-srg","html_url":"https://github.com/lbl-srg","followers_url":"https://api.github.com/users/lbl-srg/followers","following_url":"https://api.github.com/users/lbl-srg/following{/other_user}","gists_url":"https://api.github.com/users/lbl-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/lbl-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbl-srg/subscriptions","organizations_url":"https://api.github.com/users/lbl-srg/orgs","repos_url":"https://api.github.com/users/lbl-srg/repos","events_url":"https://api.github.com/users/lbl-srg/events{/privacy}","received_events_url":"https://api.github.com/users/lbl-srg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbl-srg/modelica-buildings","description":"Modelica Buildings library","fork":false,"url":"https://api.github.com/repos/lbl-srg/modelica-buildings","forks_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/forks","keys_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/teams","hooks_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/hooks","issue_events_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/events{/number}","events_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/events","assignees_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/assignees{/user}","branches_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/branches{/branch}","tags_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/tags","blobs_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/statuses/{sha}","languages_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/languages","stargazers_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/stargazers","contributors_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/contributors","subscribers_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/subscribers","subscription_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/subscription","commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/contents/{+path}","compare_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/merges","archive_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/downloads","issues_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues{/number}","pulls_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls{/number}","milestones_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/milestones{/number}","notifications_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/labels{/name}","releases_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/releases{/id}","deployments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/deployments","created_at":"2013-03-03T16:36:03Z","updated_at":"2017-06-26T15:22:13Z","pushed_at":"2017-07-06T17:07:00Z","git_url":"git://github.com/lbl-srg/modelica-buildings.git","ssh_url":"git@github.com:lbl-srg/modelica-buildings.git","clone_url":"https://github.com/lbl-srg/modelica-buildings.git","svn_url":"https://github.com/lbl-srg/modelica-buildings","homepage":null,"size":123023,"stargazers_count":48,"watchers_count":48,"language":"Modelica","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":59,"forks":45,"open_issues":59,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/832"},"html":{"href":"https://github.com/lbl-srg/modelica-buildings/pull/832"},"issue":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/832"},"comments":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/832/comments"},"review_comments":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/832/comments"},"review_comment":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/832/commits"},"statuses":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/statuses/e88c76d53573e01a58cf3a6686b83ee6f9cdabe5"}}}}
{"actor":{"display_login":"milicag"}}