{"action":"created","issue":{"url":"https://api.github.com/repos/monicahq/monica/issues/253","repository_url":"https://api.github.com/repos/monicahq/monica","labels_url":"https://api.github.com/repos/monicahq/monica/issues/253/labels{/name}","comments_url":"https://api.github.com/repos/monicahq/monica/issues/253/comments","events_url":"https://api.github.com/repos/monicahq/monica/issues/253/events","html_url":"https://github.com/monicahq/monica/pull/253","id":235486940,"number":253,"title":"Separate people controller into smaller chunks [Completed]","user":{"login":"yamakadi","id":25483877,"avatar_url":"https://avatars0.githubusercontent.com/u/25483877?v=3","gravatar_id":"","url":"https://api.github.com/users/yamakadi","html_url":"https://github.com/yamakadi","followers_url":"https://api.github.com/users/yamakadi/followers","following_url":"https://api.github.com/users/yamakadi/following{/other_user}","gists_url":"https://api.github.com/users/yamakadi/gists{/gist_id}","starred_url":"https://api.github.com/users/yamakadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamakadi/subscriptions","organizations_url":"https://api.github.com/users/yamakadi/orgs","repos_url":"https://api.github.com/users/yamakadi/repos","events_url":"https://api.github.com/users/yamakadi/events{/privacy}","received_events_url":"https://api.github.com/users/yamakadi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-06-13T09:12:47Z","updated_at":"2017-06-15T23:08:18Z","closed_at":"2017-06-15T19:03:22Z","pull_request":{"url":"https://api.github.com/repos/monicahq/monica/pulls/253","html_url":"https://github.com/monicahq/monica/pull/253","diff_url":"https://github.com/monicahq/monica/pull/253.diff","patch_url":"https://github.com/monicahq/monica/pull/253.patch"},"body":"This is an incomplete pull request aimed at separating PeopleController into smaller chunks and move some of the logic to more appropriate places. I'm sending it in before completion, so we can discuss some of the decisions I've made and talk through them in case there are any disagreements."},"comment":{"url":"https://api.github.com/repos/monicahq/monica/issues/comments/308889488","html_url":"https://github.com/monicahq/monica/pull/253#issuecomment-308889488","issue_url":"https://api.github.com/repos/monicahq/monica/issues/253","id":308889488,"user":{"login":"erdmenchen","id":6791096,"avatar_url":"https://avatars3.githubusercontent.com/u/6791096?v=3","gravatar_id":"","url":"https://api.github.com/users/erdmenchen","html_url":"https://github.com/erdmenchen","followers_url":"https://api.github.com/users/erdmenchen/followers","following_url":"https://api.github.com/users/erdmenchen/following{/other_user}","gists_url":"https://api.github.com/users/erdmenchen/gists{/gist_id}","starred_url":"https://api.github.com/users/erdmenchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdmenchen/subscriptions","organizations_url":"https://api.github.com/users/erdmenchen/orgs","repos_url":"https://api.github.com/users/erdmenchen/repos","events_url":"https://api.github.com/users/erdmenchen/events{/privacy}","received_events_url":"https://api.github.com/users/erdmenchen/received_events","type":"User","site_admin":false},"created_at":"2017-06-15T23:08:18Z","updated_at":"2017-06-15T23:08:18Z","body":"@djaiss: Thats why we asked for a develop branch beside the master branch.\r\n\r\nThat way, we can merge pull request to the dev branch and do more tests and further fixing before we finaly merge to master and production.\r\n\r\nMaybe we should do this now. \r\nFor more information on this: http://nvie.com/posts/a-successful-git-branching-model/ \r\n\r\nHowever: Great work @yamakadi ! This makes the code much easier to extend and reduces complexity."}}
{"actor":{"display_login":"erdmenchen"}}