{"action":"created","comment":{"url":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/comments/106968483","pull_request_review_id":27905460,"id":106968483,"diff_hunk":"@@ -261,7 +261,8 @@ Dependencies\n \n A C compiler is required.  To use the Python API or the command-line tools a\n Python interpreter is also required.  We have tested it with Python v2.4,\n-v2.5, v2.6, and v2.7.  For the Haskell interface, GHC >= 6.8.1 is required.\n+v2.5, v2.6, v2.7, v3.3 and v3.5.  For the Haskell interface, GHC >= 6.8.1 is","path":"README.rst","position":5,"original_position":5,"commit_id":"bc88820b9c3bcf5ab2cd0f722e1838743da0b9b6","original_commit_id":"bc88820b9c3bcf5ab2cd0f722e1838743da0b9b6","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars3.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"body":"update: code in this PR can't work on 2.4 / 2.5 (see below).\r\n\r\nand there is no reason to support these dead versions today, so just remove all references from docs etc.","created_at":"2017-03-20T17:44:21Z","updated_at":"2017-03-20T17:45:24Z","html_url":"https://github.com/tahoe-lafs/zfec/pull/4#discussion_r106968483","pull_request_url":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/comments/106968483"},"html":{"href":"https://github.com/tahoe-lafs/zfec/pull/4#discussion_r106968483"},"pull_request":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/4","id":100686713,"html_url":"https://github.com/tahoe-lafs/zfec/pull/4","diff_url":"https://github.com/tahoe-lafs/zfec/pull/4.diff","patch_url":"https://github.com/tahoe-lafs/zfec/pull/4.patch","issue_url":"https://api.github.com/repos/tahoe-lafs/zfec/issues/4","number":4,"state":"open","locked":false,"title":"[WIP] Support for Python 3","user":{"login":"george-hopkins","id":552590,"avatar_url":"https://avatars1.githubusercontent.com/u/552590?v=3","gravatar_id":"","url":"https://api.github.com/users/george-hopkins","html_url":"https://github.com/george-hopkins","followers_url":"https://api.github.com/users/george-hopkins/followers","following_url":"https://api.github.com/users/george-hopkins/following{/other_user}","gists_url":"https://api.github.com/users/george-hopkins/gists{/gist_id}","starred_url":"https://api.github.com/users/george-hopkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/george-hopkins/subscriptions","organizations_url":"https://api.github.com/users/george-hopkins/orgs","repos_url":"https://api.github.com/users/george-hopkins/repos","events_url":"https://api.github.com/users/george-hopkins/events{/privacy}","received_events_url":"https://api.github.com/users/george-hopkins/received_events","type":"User","site_admin":false},"body":"This PR implements support for Python 3. As I'm not very familiar with whole code base, I would be glad to receive some feedback if everything still works as expected. All unit tests pass on 2.7, 3.3 and 3.5. In addition the decoding was tested against an other implementation.\r\n\r\n- [ ] Wait for zooko/pyutil#4 to get merged and released (ports pyutil to Python 3)\r\n","created_at":"2017-01-09T13:43:03Z","updated_at":"2017-03-20T17:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4993285de36b900a7526472be65382df204890b6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/4/commits","review_comments_url":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/4/comments","review_comment_url":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tahoe-lafs/zfec/issues/4/comments","statuses_url":"https://api.github.com/repos/tahoe-lafs/zfec/statuses/bc88820b9c3bcf5ab2cd0f722e1838743da0b9b6","head":{"label":"george-hopkins:python3","ref":"python3","sha":"bc88820b9c3bcf5ab2cd0f722e1838743da0b9b6","user":{"login":"george-hopkins","id":552590,"avatar_url":"https://avatars1.githubusercontent.com/u/552590?v=3","gravatar_id":"","url":"https://api.github.com/users/george-hopkins","html_url":"https://github.com/george-hopkins","followers_url":"https://api.github.com/users/george-hopkins/followers","following_url":"https://api.github.com/users/george-hopkins/following{/other_user}","gists_url":"https://api.github.com/users/george-hopkins/gists{/gist_id}","starred_url":"https://api.github.com/users/george-hopkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/george-hopkins/subscriptions","organizations_url":"https://api.github.com/users/george-hopkins/orgs","repos_url":"https://api.github.com/users/george-hopkins/repos","events_url":"https://api.github.com/users/george-hopkins/events{/privacy}","received_events_url":"https://api.github.com/users/george-hopkins/received_events","type":"User","site_admin":false},"repo":{"id":78228378,"name":"zfec","full_name":"george-hopkins/zfec","owner":{"login":"george-hopkins","id":552590,"avatar_url":"https://avatars1.githubusercontent.com/u/552590?v=3","gravatar_id":"","url":"https://api.github.com/users/george-hopkins","html_url":"https://github.com/george-hopkins","followers_url":"https://api.github.com/users/george-hopkins/followers","following_url":"https://api.github.com/users/george-hopkins/following{/other_user}","gists_url":"https://api.github.com/users/george-hopkins/gists{/gist_id}","starred_url":"https://api.github.com/users/george-hopkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/george-hopkins/subscriptions","organizations_url":"https://api.github.com/users/george-hopkins/orgs","repos_url":"https://api.github.com/users/george-hopkins/repos","events_url":"https://api.github.com/users/george-hopkins/events{/privacy}","received_events_url":"https://api.github.com/users/george-hopkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/george-hopkins/zfec","description":" zfec -- an efficient, portable erasure coding tool","fork":true,"url":"https://api.github.com/repos/george-hopkins/zfec","forks_url":"https://api.github.com/repos/george-hopkins/zfec/forks","keys_url":"https://api.github.com/repos/george-hopkins/zfec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/george-hopkins/zfec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/george-hopkins/zfec/teams","hooks_url":"https://api.github.com/repos/george-hopkins/zfec/hooks","issue_events_url":"https://api.github.com/repos/george-hopkins/zfec/issues/events{/number}","events_url":"https://api.github.com/repos/george-hopkins/zfec/events","assignees_url":"https://api.github.com/repos/george-hopkins/zfec/assignees{/user}","branches_url":"https://api.github.com/repos/george-hopkins/zfec/branches{/branch}","tags_url":"https://api.github.com/repos/george-hopkins/zfec/tags","blobs_url":"https://api.github.com/repos/george-hopkins/zfec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/george-hopkins/zfec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/george-hopkins/zfec/git/refs{/sha}","trees_url":"https://api.github.com/repos/george-hopkins/zfec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/george-hopkins/zfec/statuses/{sha}","languages_url":"https://api.github.com/repos/george-hopkins/zfec/languages","stargazers_url":"https://api.github.com/repos/george-hopkins/zfec/stargazers","contributors_url":"https://api.github.com/repos/george-hopkins/zfec/contributors","subscribers_url":"https://api.github.com/repos/george-hopkins/zfec/subscribers","subscription_url":"https://api.github.com/repos/george-hopkins/zfec/subscription","commits_url":"https://api.github.com/repos/george-hopkins/zfec/commits{/sha}","git_commits_url":"https://api.github.com/repos/george-hopkins/zfec/git/commits{/sha}","comments_url":"https://api.github.com/repos/george-hopkins/zfec/comments{/number}","issue_comment_url":"https://api.github.com/repos/george-hopkins/zfec/issues/comments{/number}","contents_url":"https://api.github.com/repos/george-hopkins/zfec/contents/{+path}","compare_url":"https://api.github.com/repos/george-hopkins/zfec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/george-hopkins/zfec/merges","archive_url":"https://api.github.com/repos/george-hopkins/zfec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/george-hopkins/zfec/downloads","issues_url":"https://api.github.com/repos/george-hopkins/zfec/issues{/number}","pulls_url":"https://api.github.com/repos/george-hopkins/zfec/pulls{/number}","milestones_url":"https://api.github.com/repos/george-hopkins/zfec/milestones{/number}","notifications_url":"https://api.github.com/repos/george-hopkins/zfec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/george-hopkins/zfec/labels{/name}","releases_url":"https://api.github.com/repos/george-hopkins/zfec/releases{/id}","deployments_url":"https://api.github.com/repos/george-hopkins/zfec/deployments","created_at":"2017-01-06T18:19:51Z","updated_at":"2017-01-06T18:19:54Z","pushed_at":"2017-01-09T13:43:51Z","git_url":"git://github.com/george-hopkins/zfec.git","ssh_url":"git@github.com:george-hopkins/zfec.git","clone_url":"https://github.com/george-hopkins/zfec.git","svn_url":"https://github.com/george-hopkins/zfec","homepage":null,"size":2381,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tahoe-lafs:master","ref":"master","sha":"40c6727e3326b34d54711337324ebaae80985803","user":{"login":"tahoe-lafs","id":1156454,"avatar_url":"https://avatars2.githubusercontent.com/u/1156454?v=3","gravatar_id":"","url":"https://api.github.com/users/tahoe-lafs","html_url":"https://github.com/tahoe-lafs","followers_url":"https://api.github.com/users/tahoe-lafs/followers","following_url":"https://api.github.com/users/tahoe-lafs/following{/other_user}","gists_url":"https://api.github.com/users/tahoe-lafs/gists{/gist_id}","starred_url":"https://api.github.com/users/tahoe-lafs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahoe-lafs/subscriptions","organizations_url":"https://api.github.com/users/tahoe-lafs/orgs","repos_url":"https://api.github.com/users/tahoe-lafs/repos","events_url":"https://api.github.com/users/tahoe-lafs/events{/privacy}","received_events_url":"https://api.github.com/users/tahoe-lafs/received_events","type":"Organization","site_admin":false},"repo":{"id":54948428,"name":"zfec","full_name":"tahoe-lafs/zfec","owner":{"login":"tahoe-lafs","id":1156454,"avatar_url":"https://avatars2.githubusercontent.com/u/1156454?v=3","gravatar_id":"","url":"https://api.github.com/users/tahoe-lafs","html_url":"https://github.com/tahoe-lafs","followers_url":"https://api.github.com/users/tahoe-lafs/followers","following_url":"https://api.github.com/users/tahoe-lafs/following{/other_user}","gists_url":"https://api.github.com/users/tahoe-lafs/gists{/gist_id}","starred_url":"https://api.github.com/users/tahoe-lafs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tahoe-lafs/subscriptions","organizations_url":"https://api.github.com/users/tahoe-lafs/orgs","repos_url":"https://api.github.com/users/tahoe-lafs/repos","events_url":"https://api.github.com/users/tahoe-lafs/events{/privacy}","received_events_url":"https://api.github.com/users/tahoe-lafs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tahoe-lafs/zfec","description":" zfec -- an efficient, portable erasure coding tool","fork":false,"url":"https://api.github.com/repos/tahoe-lafs/zfec","forks_url":"https://api.github.com/repos/tahoe-lafs/zfec/forks","keys_url":"https://api.github.com/repos/tahoe-lafs/zfec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tahoe-lafs/zfec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tahoe-lafs/zfec/teams","hooks_url":"https://api.github.com/repos/tahoe-lafs/zfec/hooks","issue_events_url":"https://api.github.com/repos/tahoe-lafs/zfec/issues/events{/number}","events_url":"https://api.github.com/repos/tahoe-lafs/zfec/events","assignees_url":"https://api.github.com/repos/tahoe-lafs/zfec/assignees{/user}","branches_url":"https://api.github.com/repos/tahoe-lafs/zfec/branches{/branch}","tags_url":"https://api.github.com/repos/tahoe-lafs/zfec/tags","blobs_url":"https://api.github.com/repos/tahoe-lafs/zfec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tahoe-lafs/zfec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tahoe-lafs/zfec/git/refs{/sha}","trees_url":"https://api.github.com/repos/tahoe-lafs/zfec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tahoe-lafs/zfec/statuses/{sha}","languages_url":"https://api.github.com/repos/tahoe-lafs/zfec/languages","stargazers_url":"https://api.github.com/repos/tahoe-lafs/zfec/stargazers","contributors_url":"https://api.github.com/repos/tahoe-lafs/zfec/contributors","subscribers_url":"https://api.github.com/repos/tahoe-lafs/zfec/subscribers","subscription_url":"https://api.github.com/repos/tahoe-lafs/zfec/subscription","commits_url":"https://api.github.com/repos/tahoe-lafs/zfec/commits{/sha}","git_commits_url":"https://api.github.com/repos/tahoe-lafs/zfec/git/commits{/sha}","comments_url":"https://api.github.com/repos/tahoe-lafs/zfec/comments{/number}","issue_comment_url":"https://api.github.com/repos/tahoe-lafs/zfec/issues/comments{/number}","contents_url":"https://api.github.com/repos/tahoe-lafs/zfec/contents/{+path}","compare_url":"https://api.github.com/repos/tahoe-lafs/zfec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tahoe-lafs/zfec/merges","archive_url":"https://api.github.com/repos/tahoe-lafs/zfec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tahoe-lafs/zfec/downloads","issues_url":"https://api.github.com/repos/tahoe-lafs/zfec/issues{/number}","pulls_url":"https://api.github.com/repos/tahoe-lafs/zfec/pulls{/number}","milestones_url":"https://api.github.com/repos/tahoe-lafs/zfec/milestones{/number}","notifications_url":"https://api.github.com/repos/tahoe-lafs/zfec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tahoe-lafs/zfec/labels{/name}","releases_url":"https://api.github.com/repos/tahoe-lafs/zfec/releases{/id}","deployments_url":"https://api.github.com/repos/tahoe-lafs/zfec/deployments","created_at":"2016-03-29T05:29:53Z","updated_at":"2017-03-20T07:20:30Z","pushed_at":"2017-01-09T13:43:53Z","git_url":"git://github.com/tahoe-lafs/zfec.git","ssh_url":"git@github.com:tahoe-lafs/zfec.git","clone_url":"https://github.com/tahoe-lafs/zfec.git","svn_url":"https://github.com/tahoe-lafs/zfec","homepage":null,"size":2372,"stargazers_count":183,"watchers_count":183,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":4,"forks":11,"open_issues":4,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/4"},"html":{"href":"https://github.com/tahoe-lafs/zfec/pull/4"},"issue":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/issues/4"},"comments":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/tahoe-lafs/zfec/statuses/bc88820b9c3bcf5ab2cd0f722e1838743da0b9b6"}}}}
{"actor":{"display_login":"ThomasWaldmann"}}