{"action":"created","issue":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/680","repository_url":"https://api.github.com/repos/Subsurface-divelog/subsurface","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/680/labels{/name}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/680/comments","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/680/events","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/680","id":266357993,"number":680,"title":"Find current gasmix for heatmap","user":{"login":"atdotde","id":863957,"avatar_url":"https://avatars2.githubusercontent.com/u/863957?v=4","gravatar_id":"","url":"https://api.github.com/users/atdotde","html_url":"https://github.com/atdotde","followers_url":"https://api.github.com/users/atdotde/followers","following_url":"https://api.github.com/users/atdotde/following{/other_user}","gists_url":"https://api.github.com/users/atdotde/gists{/gist_id}","starred_url":"https://api.github.com/users/atdotde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atdotde/subscriptions","organizations_url":"https://api.github.com/users/atdotde/orgs","repos_url":"https://api.github.com/users/atdotde/repos","events_url":"https://api.github.com/users/atdotde/events{/privacy}","received_events_url":"https://api.github.com/users/atdotde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-18T04:38:24Z","updated_at":"2017-10-18T10:34:10Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/680","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/680","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/680.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/680.patch"},"body":"To compute the heatmap value, we need the current gasmix but\r\nthe current cylinderindex is no longer available.\r\n\r\nI still think this approach is worse than #679 since it walks the events list for every pixel of the heat map but fine. Trade performance for memory footprint.\r\n\r\nFixes #562\r\n\r\nSuggested-by: Linus Torvalds <torvalds@linux-foundation.org>\r\nSigned-off-by: Robert C. Helling <helling@atdotde.de>\r\n\r\n<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->"},"comment":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments/337545022","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/680#issuecomment-337545022","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/680","id":337545022,"user":{"login":"dirkhh","id":237471,"avatar_url":"https://avatars1.githubusercontent.com/u/237471?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkhh","html_url":"https://github.com/dirkhh","followers_url":"https://api.github.com/users/dirkhh/followers","following_url":"https://api.github.com/users/dirkhh/following{/other_user}","gists_url":"https://api.github.com/users/dirkhh/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkhh/subscriptions","organizations_url":"https://api.github.com/users/dirkhh/orgs","repos_url":"https://api.github.com/users/dirkhh/repos","events_url":"https://api.github.com/users/dirkhh/events{/privacy}","received_events_url":"https://api.github.com/users/dirkhh/received_events","type":"User","site_admin":false},"created_at":"2017-10-18T10:34:10Z","updated_at":"2017-10-18T10:34:10Z","author_association":"COLLABORATOR","body":"I hear your frustration.\r\nThanks for fixing this. I think this is the right way to do it as this way we need to fix one spot if the gas handling changes...\r\nWe should close #679 "}}
{"actor":{"display_login":"dirkhh"}}