{"action":"created","issue":{"url":"https://api.github.com/repos/edselmalasig/sndpeek-imgui/issues/1","repository_url":"https://api.github.com/repos/edselmalasig/sndpeek-imgui","labels_url":"https://api.github.com/repos/edselmalasig/sndpeek-imgui/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/edselmalasig/sndpeek-imgui/issues/1/comments","events_url":"https://api.github.com/repos/edselmalasig/sndpeek-imgui/issues/1/events","html_url":"https://github.com/edselmalasig/sndpeek-imgui/issues/1","id":203156693,"number":1,"title":"Build broken on Linux","user":{"login":"ebachard","id":23149049,"avatar_url":"https://avatars.githubusercontent.com/u/23149049?v=3","gravatar_id":"","url":"https://api.github.com/users/ebachard","html_url":"https://github.com/ebachard","followers_url":"https://api.github.com/users/ebachard/followers","following_url":"https://api.github.com/users/ebachard/following{/other_user}","gists_url":"https://api.github.com/users/ebachard/gists{/gist_id}","starred_url":"https://api.github.com/users/ebachard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebachard/subscriptions","organizations_url":"https://api.github.com/users/ebachard/orgs","repos_url":"https://api.github.com/users/ebachard/repos","events_url":"https://api.github.com/users/ebachard/events{/privacy}","received_events_url":"https://api.github.com/users/ebachard/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-25T16:46:33Z","updated_at":"2017-01-25T22:02:58Z","closed_at":"2017-01-25T22:02:58Z","body":"Hi,\r\n\r\nThanks for your nice program. I tried to build it on Linux (alsa version) , and the build was slightly broken.\r\n- missing files to be built (imgui*.cpp not in the makefile.alsa)\r\n- missing includes\r\n- missing flags for the linking\r\n- wrong SDL version ? (looks like imgui uses SDL2 while sndpeek-imgui uses SDL(1.2 ???)\r\n- wrong OpenGL context (maybe my fault)\r\n\r\nWhere can we find the sound-track ? Looks very nice :-)\r\n\r\nFYI, and if ever this can help, you'll find below a diff showing several \"improvement\" (maybe some are plain wrong, apologies in advance)\r\n\r\n\r\nCurrent state : the build is ok, but the window is Frozen (maybe my fault, perhaps I should use OpenGL 2 only => will try to debug soon)\r\n`diff --git a/src/marsyas/LPC.h b/src/marsyas/LPC.h\r\nindex 8f774f1..bce6543 100755\r\n--- a/src/marsyas/LPC.h\r\n+++ b/src/marsyas/LPC.h\r\n@@ -39,6 +39,10 @@ in Speech Recognition research.\r\n #include \"AutoCorrelation.h\"\r\n #include \"MarSignal.h\"\r\n \r\n+/* abs not declared in this scope */\r\n+#include <stdlib.h>\r\n+\r\n+\r\n class LPC: public System\r\n {\r\n private:\r\ndiff --git a/src/sndpeek-bin/AutoCorrelation.o b/src/sndpeek-bin/AutoCorrelation.o\r\ndeleted file mode 100644\r\nindex ac4222d..0000000\r\nBinary files a/src/sndpeek-bin/AutoCorrelation.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/Centroid.o b/src/sndpeek-bin/Centroid.o\r\ndeleted file mode 100644\r\nindex 048c36b..0000000\r\nBinary files a/src/sndpeek-bin/Centroid.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/Communicator.o b/src/sndpeek-bin/Communicator.o\r\ndeleted file mode 100644\r\nindex 1e787bb..0000000\r\nBinary files a/src/sndpeek-bin/Communicator.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/DownSampler.o b/src/sndpeek-bin/DownSampler.o\r\ndeleted file mode 100644\r\nindex 05360a4..0000000\r\nBinary files a/src/sndpeek-bin/DownSampler.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/Flux.o b/src/sndpeek-bin/Flux.o\r\ndeleted file mode 100644\r\nindex a9a09a2..0000000\r\nBinary files a/src/sndpeek-bin/Flux.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/Hamming.o b/src/sndpeek-bin/Hamming.o\r\ndeleted file mode 100644\r\nindex 63c3725..0000000\r\nBinary files a/src/sndpeek-bin/Hamming.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/LPC.o b/src/sndpeek-bin/LPC.o\r\ndeleted file mode 100644\r\nindex 9057369..0000000\r\nBinary files a/src/sndpeek-bin/LPC.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/MFCC.o b/src/sndpeek-bin/MFCC.o\r\ndeleted file mode 100644\r\nindex 461df6e..0000000\r\nBinary files a/src/sndpeek-bin/MFCC.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/MagFFT.o b/src/sndpeek-bin/MagFFT.o\r\ndeleted file mode 100644\r\nindex 1c8eb34..0000000\r\nBinary files a/src/sndpeek-bin/MagFFT.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/MarSignal.o b/src/sndpeek-bin/MarSignal.o\r\ndeleted file mode 100644\r\nindex 48cf181..0000000\r\nBinary files a/src/sndpeek-bin/MarSignal.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/NormRMS.o b/src/sndpeek-bin/NormRMS.o\r\ndeleted file mode 100644\r\nindex 2766ab3..0000000\r\nBinary files a/src/sndpeek-bin/NormRMS.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/RMS.o b/src/sndpeek-bin/RMS.o\r\ndeleted file mode 100644\r\nindex eca4398..0000000\r\nBinary files a/src/sndpeek-bin/RMS.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/Rolloff.o b/src/sndpeek-bin/Rolloff.o\r\ndeleted file mode 100644\r\nindex 3b291a2..0000000\r\nBinary files a/src/sndpeek-bin/Rolloff.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/RtAudio.o b/src/sndpeek-bin/RtAudio.o\r\ndeleted file mode 100644\r\nindex d06ce79..0000000\r\nBinary files a/src/sndpeek-bin/RtAudio.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/Stk.o b/src/sndpeek-bin/Stk.o\r\ndeleted file mode 100644\r\nindex aa9287d..0000000\r\nBinary files a/src/sndpeek-bin/Stk.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/System.o b/src/sndpeek-bin/System.o\r\ndeleted file mode 100644\r\nindex b1626f0..0000000\r\nBinary files a/src/sndpeek-bin/System.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/Thread.o b/src/sndpeek-bin/Thread.o\r\ndeleted file mode 100644\r\nindex 4a014d7..0000000\r\nBinary files a/src/sndpeek-bin/Thread.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/chuck_fft.o b/src/sndpeek-bin/chuck_fft.o\r\ndeleted file mode 100644\r\nindex e50c28e..0000000\r\nBinary files a/src/sndpeek-bin/chuck_fft.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/fmatrix.o b/src/sndpeek-bin/fmatrix.o\r\ndeleted file mode 100644\r\nindex a8ab3a5..0000000\r\nBinary files a/src/sndpeek-bin/fmatrix.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/fvec.o b/src/sndpeek-bin/fvec.o\r\ndeleted file mode 100644\r\nindex 730fb33..0000000\r\nBinary files a/src/sndpeek-bin/fvec.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/sndpeek b/src/sndpeek-bin/sndpeek\r\ndeleted file mode 100755\r\nindex 3e4b949..0000000\r\nBinary files a/src/sndpeek-bin/sndpeek and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/sndpeek.o b/src/sndpeek-bin/sndpeek.o\r\ndeleted file mode 100644\r\nindex f598cd8..0000000\r\nBinary files a/src/sndpeek-bin/sndpeek.o and /dev/null differ\r\ndiff --git a/src/sndpeek-bin/util_sndfile.o b/src/sndpeek-bin/util_sndfile.o\r\ndeleted file mode 100644\r\nindex c17f053..0000000\r\nBinary files a/src/sndpeek-bin/util_sndfile.o and /dev/null differ\r\ndiff --git a/src/sndpeek/AutoCorrelation.o b/src/sndpeek/AutoCorrelation.o\r\ndeleted file mode 100644\r\nindex 5f43edf..0000000\r\nBinary files a/src/sndpeek/AutoCorrelation.o and /dev/null differ\r\ndiff --git a/src/sndpeek/Centroid.o b/src/sndpeek/Centroid.o\r\ndeleted file mode 100644\r\nindex 4c1a989..0000000\r\nBinary files a/src/sndpeek/Centroid.o and /dev/null differ\r\ndiff --git a/src/sndpeek/Communicator.o b/src/sndpeek/Communicator.o\r\ndeleted file mode 100644\r\nindex 27d249e..0000000\r\nBinary files a/src/sndpeek/Communicator.o and /dev/null differ\r\ndiff --git a/src/sndpeek/DownSampler.o b/src/sndpeek/DownSampler.o\r\ndeleted file mode 100644\r\nindex 7f1e073..0000000\r\nBinary files a/src/sndpeek/DownSampler.o and /dev/null differ\r\ndiff --git a/src/sndpeek/Flux.o b/src/sndpeek/Flux.o\r\ndeleted file mode 100644\r\nindex 3db60a5..0000000\r\nBinary files a/src/sndpeek/Flux.o and /dev/null differ\r\ndiff --git a/src/sndpeek/Hamming.o b/src/sndpeek/Hamming.o\r\ndeleted file mode 100644\r\nindex 76186be..0000000\r\nBinary files a/src/sndpeek/Hamming.o and /dev/null differ\r\ndiff --git a/src/sndpeek/LPC.o b/src/sndpeek/LPC.o\r\ndeleted file mode 100644\r\nindex c1add97..0000000\r\nBinary files a/src/sndpeek/LPC.o and /dev/null differ\r\ndiff --git a/src/sndpeek/MFCC.o b/src/sndpeek/MFCC.o\r\ndeleted file mode 100644\r\nindex 45d7155..0000000\r\nBinary files a/src/sndpeek/MFCC.o and /dev/null differ\r\ndiff --git a/src/sndpeek/MagFFT.o b/src/sndpeek/MagFFT.o\r\ndeleted file mode 100644\r\nindex 99d1a6f..0000000\r\nBinary files a/src/sndpeek/MagFFT.o and /dev/null differ\r\ndiff --git a/src/sndpeek/MarSignal.o b/src/sndpeek/MarSignal.o\r\ndeleted file mode 100644\r\nindex 326f6ed..0000000\r\nBinary files a/src/sndpeek/MarSignal.o and /dev/null differ\r\ndiff --git a/src/sndpeek/NormRMS.o b/src/sndpeek/NormRMS.o\r\ndeleted file mode 100644\r\nindex dfb5f1f..0000000\r\nBinary files a/src/sndpeek/NormRMS.o and /dev/null differ\r\ndiff --git a/src/sndpeek/RMS.o b/src/sndpeek/RMS.o\r\ndeleted file mode 100644\r\nindex 83b4daa..0000000\r\nBinary files a/src/sndpeek/RMS.o and /dev/null differ\r\ndiff --git a/src/sndpeek/Rolloff.o b/src/sndpeek/Rolloff.o\r\ndeleted file mode 100644\r\nindex 18bcd5c..0000000\r\nBinary files a/src/sndpeek/Rolloff.o and /dev/null differ\r\ndiff --git a/src/sndpeek/RtAudio.o b/src/sndpeek/RtAudio.o\r\ndeleted file mode 100644\r\nindex 0d2b552..0000000\r\nBinary files a/src/sndpeek/RtAudio.o and /dev/null differ\r\ndiff --git a/src/sndpeek/Stk.o b/src/sndpeek/Stk.o\r\ndeleted file mode 100644\r\nindex 66eae67..0000000\r\nBinary files a/src/sndpeek/Stk.o and /dev/null differ\r\ndiff --git a/src/sndpeek/System.o b/src/sndpeek/System.o\r\ndeleted file mode 100644\r\nindex ec4ad5c..0000000\r\nBinary files a/src/sndpeek/System.o and /dev/null differ\r\ndiff --git a/src/sndpeek/Thread.o b/src/sndpeek/Thread.o\r\ndeleted file mode 100644\r\nindex 3a2cfcb..0000000\r\nBinary files a/src/sndpeek/Thread.o and /dev/null differ\r\ndiff --git a/src/sndpeek/chuck_fft.o b/src/sndpeek/chuck_fft.o\r\ndeleted file mode 100644\r\nindex 435f76a..0000000\r\nBinary files a/src/sndpeek/chuck_fft.o and /dev/null differ\r\ndiff --git a/src/sndpeek/fmatrix.o b/src/sndpeek/fmatrix.o\r\ndeleted file mode 100644\r\nindex e656ad1..0000000\r\nBinary files a/src/sndpeek/fmatrix.o and /dev/null differ\r\ndiff --git a/src/sndpeek/fvec.o b/src/sndpeek/fvec.o\r\ndeleted file mode 100644\r\nindex 5c90bdd..0000000\r\nBinary files a/src/sndpeek/fvec.o and /dev/null differ\r\ndiff --git a/src/sndpeek/imgui.o b/src/sndpeek/imgui.o\r\ndeleted file mode 100644\r\nindex a2f4327..0000000\r\nBinary files a/src/sndpeek/imgui.o and /dev/null differ\r\ndiff --git a/src/sndpeek/imgui_demo.o b/src/sndpeek/imgui_demo.o\r\ndeleted file mode 100644\r\nindex 30690fc..0000000\r\nBinary files a/src/sndpeek/imgui_demo.o and /dev/null differ\r\ndiff --git a/src/sndpeek/imgui_draw.o b/src/sndpeek/imgui_draw.o\r\ndeleted file mode 100644\r\nindex 8bb2140..0000000\r\nBinary files a/src/sndpeek/imgui_draw.o and /dev/null differ\r\ndiff --git a/src/sndpeek/imgui_impl_sdl.o b/src/sndpeek/imgui_impl_sdl.o\r\ndeleted file mode 100644\r\nindex d17a5c3..0000000\r\nBinary files a/src/sndpeek/imgui_impl_sdl.o and /dev/null differ\r\ndiff --git a/src/sndpeek/makefile.alsa b/src/sndpeek/makefile.alsa\r\nindex 34fb848..6d4b148 100755\r\n--- a/src/sndpeek/makefile.alsa\r\n+++ b/src/sndpeek/makefile.alsa\r\n@@ -1,18 +1,41 @@\r\n \r\n CC=gcc\r\n CPP=g++\r\n-INCLUDES=-I../marsyas/\r\n+INCLUDES=-I../marsyas/ -I../imgui/\r\n MARSYAS_DIR=../marsyas/\r\n+IMGUI_DIR=../imgui/\r\n CFLAGS=-D__LINUX_ALSA__ -D__LITTLE_ENDIAN__ $(INCLUDES) -O3 -c\r\n-LIBS=-L/usr/X11R6/lib -lglut -lGL -lGLU -lasound -lXmu -lX11 -lXext -lXi -lm -lsndfile\r\n+LIBS=-L/usr/X11R6/lib -lGL -lGLEW -lGLU -lglut -lasound -lXmu -lX11 -lXext -lXi -lm -lsndfile -lpthread `sdl2-config --cflags --libs`\r\n \r\n OBJS=chuck_fft.o RtAudio.o Thread.o sndpeek.o Stk.o \\\r\n \tCentroid.o DownSampler.o Flux.o LPC.o MFCC.o RMS.o Rolloff.o \\\r\n \tSystem.o fvec.o AutoCorrelation.o Communicator.o Hamming.o \\\r\n \tMagFFT.o NormRMS.o MarSignal.o fmatrix.o\r\n \r\n-sndpeek: $(OBJS)\r\n-\t$(CPP) -o $@ $(OBJS) $(LIBS)\r\n+OBJS2=imgui_draw.o \\\r\n+\timgui.o  \\\r\n+\timgui_demo.o \\\r\n+\timgui_impl_sdl.o \\\r\n+\timgui_impl_sdl_gl3.o\r\n+\r\n+\r\n+sndpeek: $(OBJS) $(OBJS2)\r\n+\t$(CPP) -o $@ $(OBJS) $(OBJS2) $(LIBS) \r\n+\r\n+imgui.o:\r\n+\t$(CC) $(CFLAGS) $(IMGUI_DIR)$*.cpp\r\n+\r\n+imgui_draw.o:\r\n+\t$(CC) $(CFLAGS) $(IMGUI_DIR)$*.cpp\r\n+\r\n+imgui_demo.o:\r\n+\t$(CC) $(CFLAGS) $(IMGUI_DIR)$*.cpp\r\n+\r\n+imgui_impl_sdl.o:\r\n+\t$(CC) $(CFLAGS) $(IMGUI_DIR)$*.cpp\r\n+\r\n+imgui_impl_sdl_gl3.o:\r\n+\t$(CC) $(CFLAGS) $(IMGUI_DIR)$*.cpp\r\n \r\n Centroid.o:\r\n \t$(CC) $(CFLAGS) $(MARSYAS_DIR)$*.cpp\r\ndiff --git a/src/sndpeek/sndpeek b/src/sndpeek/sndpeek\r\ndeleted file mode 100755\r\nindex e0dccdc..0000000\r\nBinary files a/src/sndpeek/sndpeek and /dev/null differ\r\ndiff --git a/src/sndpeek/sndpeek.cpp b/src/sndpeek/sndpeek.cpp\r\nindex 676b789..105bb59 100755\r\n--- a/src/sndpeek/sndpeek.cpp\r\n+++ b/src/sndpeek/sndpeek.cpp\r\n@@ -60,8 +60,12 @@\r\n #include \"RtAudio.h\"\r\n #include \"Thread.h\"\r\n \r\n+#if defined (__LINUX_ALSA__)\r\n+#include <GL/glew.h>\r\n+#endif\r\n+\r\n // OpenGL\r\n-#ifdef __APPLE__\r\n+#if defined (__APPLE__) \r\n //glew\r\n #include <GL/glew.h>\r\n   #include <GLUT/glut.h>\r\n@@ -73,6 +77,7 @@\r\n   #include <GL/glu.h>\r\n #endif\r\n \r\n+\r\n // process related\r\n #if defined(__OS_WINDOWS__)\r\n   #include <process.h>\r\n@@ -96,10 +101,8 @@\r\n #include \"RMS.h\"\r\n #include \"Rolloff.h\"\r\n \r\n-//SDL\r\n #include <SDL2/SDL.h>\r\n \r\n-\r\n //imgui\r\n #include <imgui.h>\r\n #include <imgui_impl_sdl.h>\r\n@@ -593,8 +596,11 @@ int main( int argc, char ** argv )\r\n         SDL_GL_SetAttribute(SDL_GL_DOUBLEBUFFER, 1);\r\n         SDL_GL_SetAttribute(SDL_GL_DEPTH_SIZE, 24);\r\n         SDL_GL_SetAttribute(SDL_GL_STENCIL_SIZE, 8);\r\n-        SDL_GL_SetAttribute(SDL_GL_CONTEXT_MAJOR_VERSION, 2);\r\n-        SDL_GL_SetAttribute(SDL_GL_CONTEXT_MINOR_VERSION, 2);\r\n+/// ericb\r\n+//        SDL_GL_SetAttribute(SDL_GL_CONTEXT_MAJOR_VERSION, 2);\r\n+//        SDL_GL_SetAttribute(SDL_GL_CONTEXT_MINOR_VERSION, 2);\r\n+        SDL_GL_SetAttribute(SDL_GL_CONTEXT_MAJOR_VERSION, 3);\r\n+        SDL_GL_SetAttribute(SDL_GL_CONTEXT_MINOR_VERSION, 3);\r\n         SDL_GL_SetAttribute(SDL_GL_CONTEXT_PROFILE_MASK, SDL_GL_CONTEXT_PROFILE_CORE);\r\n         SDL_DisplayMode current;\r\n         SDL_GetCurrentDisplayMode(0, &current);\r\ndiff --git a/src/sndpeek/sndpeek.o b/src/sndpeek/sndpeek.o\r\ndeleted file mode 100644\r\nindex bc79a79..0000000\r\nBinary files a/src/sndpeek/sndpeek.o and /dev/null differ\r\ndiff --git a/src/sndpeek/util_sndfile.o b/src/sndpeek/util_sndfile.o\r\ndeleted file mode 100644\r\nindex b57d023..0000000\r\nBinary files a/src/sndpeek/util_sndfile.o and /dev/null differ`"},"comment":{"url":"https://api.github.com/repos/edselmalasig/sndpeek-imgui/issues/comments/275246981","html_url":"https://github.com/edselmalasig/sndpeek-imgui/issues/1#issuecomment-275246981","issue_url":"https://api.github.com/repos/edselmalasig/sndpeek-imgui/issues/1","id":275246981,"user":{"login":"ebachard","id":23149049,"avatar_url":"https://avatars.githubusercontent.com/u/23149049?v=3","gravatar_id":"","url":"https://api.github.com/users/ebachard","html_url":"https://github.com/ebachard","followers_url":"https://api.github.com/users/ebachard/followers","following_url":"https://api.github.com/users/ebachard/following{/other_user}","gists_url":"https://api.github.com/users/ebachard/gists{/gist_id}","starred_url":"https://api.github.com/users/ebachard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebachard/subscriptions","organizations_url":"https://api.github.com/users/ebachard/orgs","repos_url":"https://api.github.com/users/ebachard/repos","events_url":"https://api.github.com/users/ebachard/events{/privacy}","received_events_url":"https://api.github.com/users/ebachard/received_events","type":"User","site_admin":false},"created_at":"2017-01-25T22:02:58Z","updated_at":"2017-01-25T22:02:58Z","body":"Thanks for your fast answer ! \r\nIn fact, I'm studying imgui, not your software, and the curiosity did te rest : I checkout'ed  the sources, and did some changes to make it compile under Linux. More, I'd be happy to compile it (done) and make it work. That's the reason why I contacted you:\r\n- the build is ok, no warning nor big problem, even linking went fine at the end\r\n- the binary does not work (and at the end I can't see the imgui effect ;-)\r\nMore precisely: the window launches, but got frozen after some seconds. Excepted if I missed something important, I'm pretty sure I'm not far. Was the message : it should work on Linux too :-)\r\n\r\nBTW, what's the problem with sound ? And what's the reason to not keep something working on Linux. e.g. : what about keep the current Linux code to be maintained by Linux people, the time things improve ? (and do what you want on the Windows side ? Of course, I perfectly understand you want to monetize your code, and in this case I perfectly understand the \"no future\" state of the current code.  So good luck for your project :-)"}}
{"actor":{"display_login":"ebachard"}}