{"action":"created","comment":{"url":"https://api.github.com/repos/ghaering/pysqlite/pulls/comments/143046337","pull_request_review_id":67501371,"id":143046337,"diff_hunk":"@@ -29,7 +29,7 @@\n     print(\"Only Python 2.7 is supported.\")\n     sys.exit(1)\n \n-import commands\n+import subprocess","path":"setup.py","position":5,"original_position":5,"commit_id":"869f97de4960cb3b0d970b5db390a97a5e432b64","original_commit_id":"869f97de4960cb3b0d970b5db390a97a5e432b64","user":{"login":"Evolver","id":127746,"avatar_url":"https://avatars2.githubusercontent.com/u/127746?v=4","gravatar_id":"","url":"https://api.github.com/users/Evolver","html_url":"https://github.com/Evolver","followers_url":"https://api.github.com/users/Evolver/followers","following_url":"https://api.github.com/users/Evolver/following{/other_user}","gists_url":"https://api.github.com/users/Evolver/gists{/gist_id}","starred_url":"https://api.github.com/users/Evolver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evolver/subscriptions","organizations_url":"https://api.github.com/users/Evolver/orgs","repos_url":"https://api.github.com/users/Evolver/repos","events_url":"https://api.github.com/users/Evolver/events{/privacy}","received_events_url":"https://api.github.com/users/Evolver/received_events","type":"User","site_admin":false},"body":"subprocess came in 2.4 (https://docs.python.org/2/library/subprocess.html#module-subprocess), so not sure how backwards compatible this change would be. Not following pysqlite history, so no idea if this is something to worry about.","created_at":"2017-10-05T20:20:58Z","updated_at":"2017-10-05T20:20:58Z","html_url":"https://github.com/ghaering/pysqlite/pull/117#discussion_r143046337","pull_request_url":"https://api.github.com/repos/ghaering/pysqlite/pulls/117","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ghaering/pysqlite/pulls/comments/143046337"},"html":{"href":"https://github.com/ghaering/pysqlite/pull/117#discussion_r143046337"},"pull_request":{"href":"https://api.github.com/repos/ghaering/pysqlite/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/ghaering/pysqlite/pulls/117","id":145010043,"html_url":"https://github.com/ghaering/pysqlite/pull/117","diff_url":"https://github.com/ghaering/pysqlite/pull/117.diff","patch_url":"https://github.com/ghaering/pysqlite/pull/117.patch","issue_url":"https://api.github.com/repos/ghaering/pysqlite/issues/117","number":117,"state":"open","locked":false,"title":"Fixed for msys/cygwin environments","user":{"login":"Evolver","id":127746,"avatar_url":"https://avatars2.githubusercontent.com/u/127746?v=4","gravatar_id":"","url":"https://api.github.com/users/Evolver","html_url":"https://github.com/Evolver","followers_url":"https://api.github.com/users/Evolver/followers","following_url":"https://api.github.com/users/Evolver/following{/other_user}","gists_url":"https://api.github.com/users/Evolver/gists{/gist_id}","starred_url":"https://api.github.com/users/Evolver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evolver/subscriptions","organizations_url":"https://api.github.com/users/Evolver/orgs","repos_url":"https://api.github.com/users/Evolver/repos","events_url":"https://api.github.com/users/Evolver/events{/privacy}","received_events_url":"https://api.github.com/users/Evolver/received_events","type":"User","site_admin":false},"body":"Replaced commands.getstatusoutput() with subprocess.check_output() since the latter properly escapes command line arguments in msys environment.\r\n\r\nChanged win32/unix detection to rely on presence of \"uname\", to cover msys/cygwin environments. Not sure if this would be the best way to detect unix shell, but the problem is that sys.platform returns \"win32\" in msys case, tricking the setup script into performing unnecessary escaping of MODULE_NAME macro.","created_at":"2017-10-05T20:14:17Z","updated_at":"2017-10-05T20:20:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95a8b80e86355dc069431e936e449a61c41a236f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ghaering/pysqlite/pulls/117/commits","review_comments_url":"https://api.github.com/repos/ghaering/pysqlite/pulls/117/comments","review_comment_url":"https://api.github.com/repos/ghaering/pysqlite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ghaering/pysqlite/issues/117/comments","statuses_url":"https://api.github.com/repos/ghaering/pysqlite/statuses/869f97de4960cb3b0d970b5db390a97a5e432b64","head":{"label":"Evolver:msys_fixes","ref":"msys_fixes","sha":"869f97de4960cb3b0d970b5db390a97a5e432b64","user":{"login":"Evolver","id":127746,"avatar_url":"https://avatars2.githubusercontent.com/u/127746?v=4","gravatar_id":"","url":"https://api.github.com/users/Evolver","html_url":"https://github.com/Evolver","followers_url":"https://api.github.com/users/Evolver/followers","following_url":"https://api.github.com/users/Evolver/following{/other_user}","gists_url":"https://api.github.com/users/Evolver/gists{/gist_id}","starred_url":"https://api.github.com/users/Evolver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evolver/subscriptions","organizations_url":"https://api.github.com/users/Evolver/orgs","repos_url":"https://api.github.com/users/Evolver/repos","events_url":"https://api.github.com/users/Evolver/events{/privacy}","received_events_url":"https://api.github.com/users/Evolver/received_events","type":"User","site_admin":false},"repo":{"id":105933726,"name":"pysqlite","full_name":"Evolver/pysqlite","owner":{"login":"Evolver","id":127746,"avatar_url":"https://avatars2.githubusercontent.com/u/127746?v=4","gravatar_id":"","url":"https://api.github.com/users/Evolver","html_url":"https://github.com/Evolver","followers_url":"https://api.github.com/users/Evolver/followers","following_url":"https://api.github.com/users/Evolver/following{/other_user}","gists_url":"https://api.github.com/users/Evolver/gists{/gist_id}","starred_url":"https://api.github.com/users/Evolver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evolver/subscriptions","organizations_url":"https://api.github.com/users/Evolver/orgs","repos_url":"https://api.github.com/users/Evolver/repos","events_url":"https://api.github.com/users/Evolver/events{/privacy}","received_events_url":"https://api.github.com/users/Evolver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Evolver/pysqlite","description":"Python DB-API module for SQLite 3.","fork":true,"url":"https://api.github.com/repos/Evolver/pysqlite","forks_url":"https://api.github.com/repos/Evolver/pysqlite/forks","keys_url":"https://api.github.com/repos/Evolver/pysqlite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Evolver/pysqlite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Evolver/pysqlite/teams","hooks_url":"https://api.github.com/repos/Evolver/pysqlite/hooks","issue_events_url":"https://api.github.com/repos/Evolver/pysqlite/issues/events{/number}","events_url":"https://api.github.com/repos/Evolver/pysqlite/events","assignees_url":"https://api.github.com/repos/Evolver/pysqlite/assignees{/user}","branches_url":"https://api.github.com/repos/Evolver/pysqlite/branches{/branch}","tags_url":"https://api.github.com/repos/Evolver/pysqlite/tags","blobs_url":"https://api.github.com/repos/Evolver/pysqlite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Evolver/pysqlite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Evolver/pysqlite/git/refs{/sha}","trees_url":"https://api.github.com/repos/Evolver/pysqlite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Evolver/pysqlite/statuses/{sha}","languages_url":"https://api.github.com/repos/Evolver/pysqlite/languages","stargazers_url":"https://api.github.com/repos/Evolver/pysqlite/stargazers","contributors_url":"https://api.github.com/repos/Evolver/pysqlite/contributors","subscribers_url":"https://api.github.com/repos/Evolver/pysqlite/subscribers","subscription_url":"https://api.github.com/repos/Evolver/pysqlite/subscription","commits_url":"https://api.github.com/repos/Evolver/pysqlite/commits{/sha}","git_commits_url":"https://api.github.com/repos/Evolver/pysqlite/git/commits{/sha}","comments_url":"https://api.github.com/repos/Evolver/pysqlite/comments{/number}","issue_comment_url":"https://api.github.com/repos/Evolver/pysqlite/issues/comments{/number}","contents_url":"https://api.github.com/repos/Evolver/pysqlite/contents/{+path}","compare_url":"https://api.github.com/repos/Evolver/pysqlite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Evolver/pysqlite/merges","archive_url":"https://api.github.com/repos/Evolver/pysqlite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Evolver/pysqlite/downloads","issues_url":"https://api.github.com/repos/Evolver/pysqlite/issues{/number}","pulls_url":"https://api.github.com/repos/Evolver/pysqlite/pulls{/number}","milestones_url":"https://api.github.com/repos/Evolver/pysqlite/milestones{/number}","notifications_url":"https://api.github.com/repos/Evolver/pysqlite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Evolver/pysqlite/labels{/name}","releases_url":"https://api.github.com/repos/Evolver/pysqlite/releases{/id}","deployments_url":"https://api.github.com/repos/Evolver/pysqlite/deployments","created_at":"2017-10-05T19:52:31Z","updated_at":"2017-10-05T19:52:33Z","pushed_at":"2017-10-05T20:11:37Z","git_url":"git://github.com/Evolver/pysqlite.git","ssh_url":"git@github.com:Evolver/pysqlite.git","clone_url":"https://github.com/Evolver/pysqlite.git","svn_url":"https://github.com/Evolver/pysqlite","homepage":null,"size":2789,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ghaering:master","ref":"master","sha":"e728ffbcaeb7bfae1d6b7165369bd0ae16cabf95","user":{"login":"ghaering","id":907541,"avatar_url":"https://avatars1.githubusercontent.com/u/907541?v=4","gravatar_id":"","url":"https://api.github.com/users/ghaering","html_url":"https://github.com/ghaering","followers_url":"https://api.github.com/users/ghaering/followers","following_url":"https://api.github.com/users/ghaering/following{/other_user}","gists_url":"https://api.github.com/users/ghaering/gists{/gist_id}","starred_url":"https://api.github.com/users/ghaering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghaering/subscriptions","organizations_url":"https://api.github.com/users/ghaering/orgs","repos_url":"https://api.github.com/users/ghaering/repos","events_url":"https://api.github.com/users/ghaering/events{/privacy}","received_events_url":"https://api.github.com/users/ghaering/received_events","type":"User","site_admin":false},"repo":{"id":13468979,"name":"pysqlite","full_name":"ghaering/pysqlite","owner":{"login":"ghaering","id":907541,"avatar_url":"https://avatars1.githubusercontent.com/u/907541?v=4","gravatar_id":"","url":"https://api.github.com/users/ghaering","html_url":"https://github.com/ghaering","followers_url":"https://api.github.com/users/ghaering/followers","following_url":"https://api.github.com/users/ghaering/following{/other_user}","gists_url":"https://api.github.com/users/ghaering/gists{/gist_id}","starred_url":"https://api.github.com/users/ghaering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghaering/subscriptions","organizations_url":"https://api.github.com/users/ghaering/orgs","repos_url":"https://api.github.com/users/ghaering/repos","events_url":"https://api.github.com/users/ghaering/events{/privacy}","received_events_url":"https://api.github.com/users/ghaering/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghaering/pysqlite","description":"Python DB-API module for SQLite 3.","fork":false,"url":"https://api.github.com/repos/ghaering/pysqlite","forks_url":"https://api.github.com/repos/ghaering/pysqlite/forks","keys_url":"https://api.github.com/repos/ghaering/pysqlite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghaering/pysqlite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghaering/pysqlite/teams","hooks_url":"https://api.github.com/repos/ghaering/pysqlite/hooks","issue_events_url":"https://api.github.com/repos/ghaering/pysqlite/issues/events{/number}","events_url":"https://api.github.com/repos/ghaering/pysqlite/events","assignees_url":"https://api.github.com/repos/ghaering/pysqlite/assignees{/user}","branches_url":"https://api.github.com/repos/ghaering/pysqlite/branches{/branch}","tags_url":"https://api.github.com/repos/ghaering/pysqlite/tags","blobs_url":"https://api.github.com/repos/ghaering/pysqlite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghaering/pysqlite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghaering/pysqlite/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghaering/pysqlite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghaering/pysqlite/statuses/{sha}","languages_url":"https://api.github.com/repos/ghaering/pysqlite/languages","stargazers_url":"https://api.github.com/repos/ghaering/pysqlite/stargazers","contributors_url":"https://api.github.com/repos/ghaering/pysqlite/contributors","subscribers_url":"https://api.github.com/repos/ghaering/pysqlite/subscribers","subscription_url":"https://api.github.com/repos/ghaering/pysqlite/subscription","commits_url":"https://api.github.com/repos/ghaering/pysqlite/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghaering/pysqlite/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghaering/pysqlite/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghaering/pysqlite/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghaering/pysqlite/contents/{+path}","compare_url":"https://api.github.com/repos/ghaering/pysqlite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghaering/pysqlite/merges","archive_url":"https://api.github.com/repos/ghaering/pysqlite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghaering/pysqlite/downloads","issues_url":"https://api.github.com/repos/ghaering/pysqlite/issues{/number}","pulls_url":"https://api.github.com/repos/ghaering/pysqlite/pulls{/number}","milestones_url":"https://api.github.com/repos/ghaering/pysqlite/milestones{/number}","notifications_url":"https://api.github.com/repos/ghaering/pysqlite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghaering/pysqlite/labels{/name}","releases_url":"https://api.github.com/repos/ghaering/pysqlite/releases{/id}","deployments_url":"https://api.github.com/repos/ghaering/pysqlite/deployments","created_at":"2013-10-10T11:02:40Z","updated_at":"2017-10-04T12:56:44Z","pushed_at":"2017-10-05T20:14:18Z","git_url":"git://github.com/ghaering/pysqlite.git","ssh_url":"git@github.com:ghaering/pysqlite.git","clone_url":"https://github.com/ghaering/pysqlite.git","svn_url":"https://github.com/ghaering/pysqlite","homepage":null,"size":2789,"stargazers_count":183,"watchers_count":183,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":26,"forks":70,"open_issues":26,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghaering/pysqlite/pulls/117"},"html":{"href":"https://github.com/ghaering/pysqlite/pull/117"},"issue":{"href":"https://api.github.com/repos/ghaering/pysqlite/issues/117"},"comments":{"href":"https://api.github.com/repos/ghaering/pysqlite/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/ghaering/pysqlite/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/ghaering/pysqlite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ghaering/pysqlite/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/ghaering/pysqlite/statuses/869f97de4960cb3b0d970b5db390a97a5e432b64"}},"author_association":"NONE"}}
{"actor":{"display_login":"Evolver"}}