{"action":"created","issue":{"url":"https://api.github.com/repos/servo/rust-cssparser/issues/180","repository_url":"https://api.github.com/repos/servo/rust-cssparser","labels_url":"https://api.github.com/repos/servo/rust-cssparser/issues/180/labels{/name}","comments_url":"https://api.github.com/repos/servo/rust-cssparser/issues/180/comments","events_url":"https://api.github.com/repos/servo/rust-cssparser/issues/180/events","html_url":"https://github.com/servo/rust-cssparser/pull/180","id":251145287,"number":180,"title":"Have at-rule without block handled in two stages as well","user":{"login":"upsuper","id":333750,"avatar_url":"https://avatars3.githubusercontent.com/u/333750?v=4","gravatar_id":"","url":"https://api.github.com/users/upsuper","html_url":"https://github.com/upsuper","followers_url":"https://api.github.com/users/upsuper/followers","following_url":"https://api.github.com/users/upsuper/following{/other_user}","gists_url":"https://api.github.com/users/upsuper/gists{/gist_id}","starred_url":"https://api.github.com/users/upsuper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upsuper/subscriptions","organizations_url":"https://api.github.com/users/upsuper/orgs","repos_url":"https://api.github.com/users/upsuper/repos","events_url":"https://api.github.com/users/upsuper/events{/privacy}","received_events_url":"https://api.github.com/users/upsuper/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-18T05:43:44Z","updated_at":"2017-08-18T05:43:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/rust-cssparser/pulls/180","html_url":"https://github.com/servo/rust-cssparser/pull/180","diff_url":"https://github.com/servo/rust-cssparser/pull/180.diff","patch_url":"https://github.com/servo/rust-cssparser/pull/180.patch"},"body":"This change makes `AtRuleParser::parse_prelude` always return a prelude if parsed successfully, so that at-rules which do not accept block can be handled in two phases just like those with block.\r\n\r\nThis is important because at-rules without block usually have side effects. If `parse_prelude` executes the side effect, but `parse_at_rule` later determined that the rule is actually invalid (e.g. because it is followed by a block), there is no way for impl of `AtRuleParser` to undo the side effect.\r\n\r\nIt provides the necessary parser side change for fixing [Gecko bug 1388911](https://bugzilla.mozilla.org/show_bug.cgi?id=1388911).\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/rust-cssparser/180)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/rust-cssparser/issues/comments/323264902","html_url":"https://github.com/servo/rust-cssparser/pull/180#issuecomment-323264902","issue_url":"https://api.github.com/repos/servo/rust-cssparser/issues/180","id":323264902,"user":{"login":"upsuper","id":333750,"avatar_url":"https://avatars3.githubusercontent.com/u/333750?v=4","gravatar_id":"","url":"https://api.github.com/users/upsuper","html_url":"https://github.com/upsuper","followers_url":"https://api.github.com/users/upsuper/followers","following_url":"https://api.github.com/users/upsuper/following{/other_user}","gists_url":"https://api.github.com/users/upsuper/gists{/gist_id}","starred_url":"https://api.github.com/users/upsuper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/upsuper/subscriptions","organizations_url":"https://api.github.com/users/upsuper/orgs","repos_url":"https://api.github.com/users/upsuper/repos","events_url":"https://api.github.com/users/upsuper/events{/privacy}","received_events_url":"https://api.github.com/users/upsuper/received_events","type":"User","site_admin":false},"created_at":"2017-08-18T05:43:53Z","updated_at":"2017-08-18T05:43:53Z","body":"r? @SimonSapin "}}
{"actor":{"display_login":"upsuper"}}