{"action":"created","issue":{"url":"https://api.github.com/repos/warner/magic-wormhole/issues/252","repository_url":"https://api.github.com/repos/warner/magic-wormhole","labels_url":"https://api.github.com/repos/warner/magic-wormhole/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/warner/magic-wormhole/issues/252/comments","events_url":"https://api.github.com/repos/warner/magic-wormhole/issues/252/events","html_url":"https://github.com/warner/magic-wormhole/issues/252","id":257871678,"number":252,"title":"--tor-control-port= is broken","user":{"login":"warner","id":27146,"avatar_url":"https://avatars3.githubusercontent.com/u/27146?v=4","gravatar_id":"","url":"https://api.github.com/users/warner","html_url":"https://github.com/warner","followers_url":"https://api.github.com/users/warner/followers","following_url":"https://api.github.com/users/warner/following{/other_user}","gists_url":"https://api.github.com/users/warner/gists{/gist_id}","starred_url":"https://api.github.com/users/warner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warner/subscriptions","organizations_url":"https://api.github.com/users/warner/orgs","repos_url":"https://api.github.com/users/warner/repos","events_url":"https://api.github.com/users/warner/events{/privacy}","received_events_url":"https://api.github.com/users/warner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-14T22:10:48Z","updated_at":"2017-09-14T22:33:43Z","closed_at":null,"author_association":"OWNER","body":"rxcomm noticed that using `--tor-control-port=` is broken: using it always causes `wormhole` to fall back to using the default SOCKS port.\r\n\r\nIt appears that `txtorcon.connect(tor_control_port=)` doesn't accept a string, only one of:\r\n\r\n* an endpoint instance\r\n* a sequence of endpoint instances\r\n* None, meaning try the usual suspects (`unix:/var/run/tor/control`, `tcp:127.0.0.1:9051`, `tcp:127.0.0.1:9151`)\r\n\r\nSo the fix is probably just having `wormhole.tor_manager.get_tor` render the argv value into an endpoint with `endpoints.clientFromString()` before passing it into `txtorcon.connect()`.\r\n"},"comment":{"url":"https://api.github.com/repos/warner/magic-wormhole/issues/comments/329627190","html_url":"https://github.com/warner/magic-wormhole/issues/252#issuecomment-329627190","issue_url":"https://api.github.com/repos/warner/magic-wormhole/issues/252","id":329627190,"user":{"login":"warner","id":27146,"avatar_url":"https://avatars3.githubusercontent.com/u/27146?v=4","gravatar_id":"","url":"https://api.github.com/users/warner","html_url":"https://github.com/warner","followers_url":"https://api.github.com/users/warner/followers","following_url":"https://api.github.com/users/warner/following{/other_user}","gists_url":"https://api.github.com/users/warner/gists{/gist_id}","starred_url":"https://api.github.com/users/warner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warner/subscriptions","organizations_url":"https://api.github.com/users/warner/orgs","repos_url":"https://api.github.com/users/warner/repos","events_url":"https://api.github.com/users/warner/events{/privacy}","received_events_url":"https://api.github.com/users/warner/received_events","type":"User","site_admin":false},"created_at":"2017-09-14T22:33:43Z","updated_at":"2017-09-14T22:33:43Z","author_association":"OWNER","body":"Eh, I'm happy to change it on the calling side. That API already takes enough types :)\r\n"}}
{"actor":{"display_login":"warner"}}