{"action":"created","issue":{"url":"https://api.github.com/repos/webpack/webpack/issues/5150","repository_url":"https://api.github.com/repos/webpack/webpack","labels_url":"https://api.github.com/repos/webpack/webpack/issues/5150/labels{/name}","comments_url":"https://api.github.com/repos/webpack/webpack/issues/5150/comments","events_url":"https://api.github.com/repos/webpack/webpack/issues/5150/events","html_url":"https://github.com/webpack/webpack/pull/5150","id":238135075,"number":5150,"title":"Add benchmark","user":{"login":"sokra","id":1365881,"avatar_url":"https://avatars0.githubusercontent.com/u/1365881?v=4","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"labels":[{"id":572709861,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20CI-not-ok","name":"PR: CI-not-ok","color":"d93f0b","default":false},{"id":572817354,"url":"https://api.github.com/repos/webpack/webpack/labels/PR:%20unreviewed","name":"PR: unreviewed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/webpack/webpack/milestones/11","html_url":"https://github.com/webpack/webpack/milestone/11","labels_url":"https://api.github.com/repos/webpack/webpack/milestones/11/labels","id":2154159,"number":11,"title":"webpack 3","description":"","creator":{"login":"sokra","id":1365881,"avatar_url":"https://avatars0.githubusercontent.com/u/1365881?v=4","gravatar_id":"","url":"https://api.github.com/users/sokra","html_url":"https://github.com/sokra","followers_url":"https://api.github.com/users/sokra/followers","following_url":"https://api.github.com/users/sokra/following{/other_user}","gists_url":"https://api.github.com/users/sokra/gists{/gist_id}","starred_url":"https://api.github.com/users/sokra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sokra/subscriptions","organizations_url":"https://api.github.com/users/sokra/orgs","repos_url":"https://api.github.com/users/sokra/repos","events_url":"https://api.github.com/users/sokra/events{/privacy}","received_events_url":"https://api.github.com/users/sokra/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":17,"state":"open","created_at":"2016-11-23T16:31:52Z","updated_at":"2017-07-24T09:17:31Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-06-23T12:58:24Z","updated_at":"2017-07-24T09:28:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/webpack/webpack/pulls/5150","html_url":"https://github.com/webpack/webpack/pull/5150","diff_url":"https://github.com/webpack/webpack/pull/5150.diff","patch_url":"https://github.com/webpack/webpack/pull/5150.patch"},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n\r\n**What kind of change does this PR introduce?**\r\nbenchmark\r\n<!-- E.g. a bugfix, feature, refactoring, build related change, etc… -->\r\n\r\n**Did you add tests for your changes?**\r\nN/A\r\n<!-- Note that we won't merge your changes if you don't add tests -->\r\n\r\n**If relevant, link to documentation update:**\r\nN/A\r\n<!-- Link PR from webpack/webpack.js.org here, or N/A -->\r\n\r\n**Summary**\r\nrefactor webpack to be webpackable\r\nadd a single file benchmark \r\n<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->\r\n<!-- Try to link to an open issue for more information. -->\r\n\r\n**Does this PR introduce a breaking change?**\r\nno\r\n<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->\r\n\r\n**Other information**\r\n"},"comment":{"url":"https://api.github.com/repos/webpack/webpack/issues/comments/317368635","html_url":"https://github.com/webpack/webpack/pull/5150#issuecomment-317368635","issue_url":"https://api.github.com/repos/webpack/webpack/issues/5150","id":317368635,"user":{"login":"webpack-bot","id":26676291,"avatar_url":"https://avatars0.githubusercontent.com/u/26676291?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-bot","html_url":"https://github.com/webpack-bot","followers_url":"https://api.github.com/users/webpack-bot/followers","following_url":"https://api.github.com/users/webpack-bot/following{/other_user}","gists_url":"https://api.github.com/users/webpack-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-bot/subscriptions","organizations_url":"https://api.github.com/users/webpack-bot/orgs","repos_url":"https://api.github.com/users/webpack-bot/repos","events_url":"https://api.github.com/users/webpack-bot/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-bot/received_events","type":"User","site_admin":false},"created_at":"2017-07-24T09:28:36Z","updated_at":"2017-07-24T09:28:36Z","body":"<!-- identifier: ci-result -->\n\n@sokra The tests look fine, but there are code style issue in your Pull Request. Please review the following:\n\n``` text\n> webpack@3.3.0 travis:lint /home/travis/build/webpack/webpack\n> npm run lint-files && npm run nsp\n\n\n> webpack@3.3.0 lint-files /home/travis/build/webpack/webpack\n> npm run lint && npm run beautify-lint\n\n\n> webpack@3.3.0 lint /home/travis/build/webpack/webpack\n> eslint lib bin hot buildin \"test/**/webpack.config.js\" \"test/binCases/**/test.js\" \"examples/**/webpack.config.js\"\n\n\n> webpack@3.3.0 beautify-lint /home/travis/build/webpack/webpack\n> beautify-lint \"lib/**/*.js\" \"hot/**/*.js\" \"bin/**/*.js\" \"benchmark/*.js\" \"test/*.js\"\n\nIndex: benchmark/createTestCases.js\n===================================================================\n--- benchmark/createTestCases.js\n+++ benchmark/createTestCases.js\n@@ -47,8 +47,9 @@\n \n function createTree(fs, count, folder) {\n \tfs.mkdirSync(folder);\n \tlet remaining = count - 1;\n+\n \tfunction make(prefix, count, depth) {\n \t\tif(count === 0) {\n \t\t\tfs.writeFileSync(`${folder}/${prefix}.js`, `export default 1;\\n${avgJs}`);\n \t\t} else {\n\n\n1 Errors. (326 files checked)\n```\n\nSee [complete report here](https://travis-ci.org/webpack/webpack/builds/256805451?utm_source&#x3D;github_status&amp;utm_medium&#x3D;notification)."}}
{"actor":{"display_login":"webpack-bot"}}