{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/39466","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/39466/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/39466/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/39466/events","html_url":"https://github.com/kubernetes/kubernetes/pull/39466","id":198934359,"number":39466,"title":"Generate OpenAPI definition for inlined types","user":{"login":"mbohlool","id":1613024,"avatar_url":"https://avatars.githubusercontent.com/u/1613024?v=3","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":496752863,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P1","name":"priority/P1","color":"ededed","default":false},{"id":173493835,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-01-05T11:28:20Z","updated_at":"2017-01-05T11:28:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/39466","html_url":"https://github.com/kubernetes/kubernetes/pull/39466","diff_url":"https://github.com/kubernetes/kubernetes/pull/39466.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/39466.patch"},"body":"Currently OpenAPI definition generator ignores any type's member with an empty json name tag. However, most (if not all) of these types also have \"inline\" json tag. That means we should inline their members into parent type's OpenAPI definition instead of ignoring them. This resulted in many types missing common parameters such as \"Name\". It look something serious to me for OpenAPI spec and I suggest we merge and cherry-pick this into 1.5 release branch as soon as possible."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/270623569","html_url":"https://github.com/kubernetes/kubernetes/pull/39466#issuecomment-270623569","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/39466","id":270623569,"user":{"login":"k8s-reviewable","id":24305385,"avatar_url":"https://avatars.githubusercontent.com/u/24305385?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-reviewable","html_url":"https://github.com/k8s-reviewable","followers_url":"https://api.github.com/users/k8s-reviewable/followers","following_url":"https://api.github.com/users/k8s-reviewable/following{/other_user}","gists_url":"https://api.github.com/users/k8s-reviewable/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-reviewable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-reviewable/subscriptions","organizations_url":"https://api.github.com/users/k8s-reviewable/orgs","repos_url":"https://api.github.com/users/k8s-reviewable/repos","events_url":"https://api.github.com/users/k8s-reviewable/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-reviewable/received_events","type":"User","site_admin":false},"created_at":"2017-01-05T11:28:31Z","updated_at":"2017-01-05T11:28:31Z","body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.png\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/39466)\n<!-- Reviewable:end -->\n"}}
{"actor":{"display_login":"k8s-reviewable"}}