{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/130354045","pull_request_review_id":53219073,"id":130354045,"diff_hunk":"@@ -528,7 +530,7 @@ void MainWindow::load_plugin(QString fileName, bool blacklisted)\n       {\n         if ( plugin_blacklist.contains(name) ){\n           qDebug(\"### Ignoring plugin \\\"%s\\\".\", qPrintable(fileName));\n-          return;\n+          return true;","path":"Polyhedron/demo/Polyhedron/MainWindow.cpp","position":23,"original_position":23,"commit_id":"a4ff510091c7276a2865f12405107e93cecafae2","original_commit_id":"a4ff510091c7276a2865f12405107e93cecafae2","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"body":"Actually the function returns true if fileName leads to a plugin, not if the plugin is loaded. I needed a way to get all plugins in load_plugins, and load_plugin() is the one that filters the files, so I used the return value. using a reference to a bool might be clearer though.","created_at":"2017-07-31T13:38:05Z","updated_at":"2017-07-31T13:38:05Z","html_url":"https://github.com/CGAL/cgal/pull/2314#discussion_r130354045","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/2314","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/130354045"},"html":{"href":"https://github.com/CGAL/cgal/pull/2314#discussion_r130354045"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2314"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/2314","id":132979260,"html_url":"https://github.com/CGAL/cgal/pull/2314","diff_url":"https://github.com/CGAL/cgal/pull/2314.diff","patch_url":"https://github.com/CGAL/cgal/pull/2314.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/2314","number":2314,"state":"open","locked":false,"title":"Polyhedron_demo: Enhance the plugins management in Preferences","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"body":"## Summary of Changes\r\n\r\nAdd a hierarchy to the list of plugins in the Preferences dialog based on their location :\r\n\r\n![preferences-screenshot](https://user-images.githubusercontent.com/11310805/28768328-7c98b4fa-75d7-11e7-96a2-b4e6ba45698c.png)\r\n\r\n\r\n## Release Management\r\n\r\n* Affected package(s):Polyhedron_demo\r\n","created_at":"2017-07-28T14:20:02Z","updated_at":"2017-07-31T13:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56ebba33e4867f8886928d3db96c354ac8a90b5d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/25","html_url":"https://github.com/CGAL/cgal/milestone/25","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/25/labels","id":2606767,"number":25,"title":"4.12-beta","description":"","creator":{"login":"sloriot","id":1224632,"avatar_url":"https://avatars2.githubusercontent.com/u/1224632?v=4","gravatar_id":"","url":"https://api.github.com/users/sloriot","html_url":"https://github.com/sloriot","followers_url":"https://api.github.com/users/sloriot/followers","following_url":"https://api.github.com/users/sloriot/following{/other_user}","gists_url":"https://api.github.com/users/sloriot/gists{/gist_id}","starred_url":"https://api.github.com/users/sloriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloriot/subscriptions","organizations_url":"https://api.github.com/users/sloriot/orgs","repos_url":"https://api.github.com/users/sloriot/repos","events_url":"https://api.github.com/users/sloriot/events{/privacy}","received_events_url":"https://api.github.com/users/sloriot/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":0,"state":"open","created_at":"2017-06-27T09:50:39Z","updated_at":"2017-07-28T16:35:20Z","due_on":"2018-02-10T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/2314/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/2314/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/2314/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/a4ff510091c7276a2865f12405107e93cecafae2","head":{"label":"maxGimeno:Add_plugins_info_in_preferences-GF","ref":"Add_plugins_info_in_preferences-GF","sha":"a4ff510091c7276a2865f12405107e93cecafae2","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"repo":{"id":38375573,"name":"cgal","full_name":"maxGimeno/cgal","owner":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars0.githubusercontent.com/u/11310805?v=4","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxGimeno/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/maxGimeno/cgal","forks_url":"https://api.github.com/repos/maxGimeno/cgal/forks","keys_url":"https://api.github.com/repos/maxGimeno/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxGimeno/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxGimeno/cgal/teams","hooks_url":"https://api.github.com/repos/maxGimeno/cgal/hooks","issue_events_url":"https://api.github.com/repos/maxGimeno/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/maxGimeno/cgal/events","assignees_url":"https://api.github.com/repos/maxGimeno/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/maxGimeno/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/maxGimeno/cgal/tags","blobs_url":"https://api.github.com/repos/maxGimeno/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxGimeno/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxGimeno/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxGimeno/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxGimeno/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/maxGimeno/cgal/languages","stargazers_url":"https://api.github.com/repos/maxGimeno/cgal/stargazers","contributors_url":"https://api.github.com/repos/maxGimeno/cgal/contributors","subscribers_url":"https://api.github.com/repos/maxGimeno/cgal/subscribers","subscription_url":"https://api.github.com/repos/maxGimeno/cgal/subscription","commits_url":"https://api.github.com/repos/maxGimeno/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxGimeno/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxGimeno/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxGimeno/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxGimeno/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/maxGimeno/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxGimeno/cgal/merges","archive_url":"https://api.github.com/repos/maxGimeno/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxGimeno/cgal/downloads","issues_url":"https://api.github.com/repos/maxGimeno/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/maxGimeno/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/maxGimeno/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/maxGimeno/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxGimeno/cgal/labels{/name}","releases_url":"https://api.github.com/repos/maxGimeno/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/maxGimeno/cgal/deployments","created_at":"2015-07-01T14:25:52Z","updated_at":"2017-01-20T17:02:24Z","pushed_at":"2017-07-31T09:17:46Z","git_url":"git://github.com/maxGimeno/cgal.git","ssh_url":"git@github.com:maxGimeno/cgal.git","clone_url":"https://github.com/maxGimeno/cgal.git","svn_url":"https://github.com/maxGimeno/cgal","homepage":"http://www.cgal.org","size":547165,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"07ccaa29ce9fb7ff31c084dedc634811351f07cf","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars0.githubusercontent.com/u/5746664?v=4","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars0.githubusercontent.com/u/5746664?v=4","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository, see the README below","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/CGAL/cgal/deployments","created_at":"2014-10-01T12:22:47Z","updated_at":"2017-07-31T09:54:18Z","pushed_at":"2017-07-31T12:21:24Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"https://github.com/CGAL/cgal#readme","size":546110,"stargazers_count":587,"watchers_count":587,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":270,"mirror_url":null,"open_issues_count":218,"forks":270,"open_issues":218,"watchers":587,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2314"},"html":{"href":"https://github.com/CGAL/cgal/pull/2314"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/2314"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/2314/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2314/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/2314/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/a4ff510091c7276a2865f12405107e93cecafae2"}}}}
{"actor":{"display_login":"maxGimeno"}}