{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/124600341","pull_request_review_id":46905559,"id":124600341,"diff_hunk":"@@ -1,10 +1,14 @@\n angular.module('encore.ui', [\n-    'cfp.hotkeys',\n-    'ui.bootstrap',\n     'encore.ui.tpls',\n     'ngMessages',\n     <%= _.uniq(config.srcModules).join(',\\n    ') %>\n ])\n+.config(function ($locationProvider) {\n+    // Angular 1.6 changes the default value of the prefix to '!', this reverts to previous behavior\n+    // https://github.com/angular/angular.js/commit/aa077e81129c740041438688dff2e8d20c3d7b52\n+    $locationProvider.hashPrefix('');","path":"grunt-tasks/templates/encore-ui.ejs.js","position":11,"original_position":11,"commit_id":"6ecaad570c39a9d80782639fa003f5cb9db25491","original_commit_id":"6ecaad570c39a9d80782639fa003f5cb9db25491","user":{"login":"CITguy","id":545605,"avatar_url":"https://avatars2.githubusercontent.com/u/545605?v=3","gravatar_id":"","url":"https://api.github.com/users/CITguy","html_url":"https://github.com/CITguy","followers_url":"https://api.github.com/users/CITguy/followers","following_url":"https://api.github.com/users/CITguy/following{/other_user}","gists_url":"https://api.github.com/users/CITguy/gists{/gist_id}","starred_url":"https://api.github.com/users/CITguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CITguy/subscriptions","organizations_url":"https://api.github.com/users/CITguy/orgs","repos_url":"https://api.github.com/users/CITguy/repos","events_url":"https://api.github.com/users/CITguy/events{/privacy}","received_events_url":"https://api.github.com/users/CITguy/received_events","type":"User","site_admin":false},"body":"This configuration was moved to the distributed asset output, so that each consuming application doesn't have to apply this fix manually.","created_at":"2017-06-28T17:13:35Z","updated_at":"2017-06-28T17:13:35Z","html_url":"https://github.com/rackerlabs/encore-ui/pull/1991#discussion_r124600341","pull_request_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1991","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments/124600341"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1991#discussion_r124600341"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1991"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1991","id":121404902,"html_url":"https://github.com/rackerlabs/encore-ui/pull/1991","diff_url":"https://github.com/rackerlabs/encore-ui/pull/1991.diff","patch_url":"https://github.com/rackerlabs/encore-ui/pull/1991.patch","issue_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1991","number":1991,"state":"open","locked":false,"title":"fix(angular): Angular 1.6 upgrade","user":{"login":"halkon","id":1437154,"avatar_url":"https://avatars1.githubusercontent.com/u/1437154?v=3","gravatar_id":"","url":"https://api.github.com/users/halkon","html_url":"https://github.com/halkon","followers_url":"https://api.github.com/users/halkon/followers","following_url":"https://api.github.com/users/halkon/following{/other_user}","gists_url":"https://api.github.com/users/halkon/gists{/gist_id}","starred_url":"https://api.github.com/users/halkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halkon/subscriptions","organizations_url":"https://api.github.com/users/halkon/orgs","repos_url":"https://api.github.com/users/halkon/repos","events_url":"https://api.github.com/users/halkon/events{/privacy}","received_events_url":"https://api.github.com/users/halkon/received_events","type":"User","site_admin":false},"body":"JIRA:\r\n\r\n### LGTMs\r\n- [ ] Dev LGTM\r\n- [ ] Dev+Vidyo LGTM\r\n- [ ] QE LGTM\r\n\r\nMainly want to share the first pass of facepalms","created_at":"2017-05-19T00:37:11Z","updated_at":"2017-06-28T17:13:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57b65068d1d433042ac3919cd9276ec6bb9e0501","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1991/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1991/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1991/comments","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/6ecaad570c39a9d80782639fa003f5cb9db25491","head":{"label":"rackerlabs:FRMW-1337_upgrade-angular-to-1.6","ref":"FRMW-1337_upgrade-angular-to-1.6","sha":"6ecaad570c39a9d80782639fa003f5cb9db25491","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars2.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars2.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/encore-ui/deployments","created_at":"2013-07-15T20:06:52Z","updated_at":"2017-06-20T15:18:48Z","pushed_at":"2017-06-28T17:12:22Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":61370,"stargazers_count":48,"watchers_count":48,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":14,"forks":57,"open_issues":14,"watchers":48,"default_branch":"master"}},"base":{"label":"rackerlabs:next","ref":"next","sha":"b4552c971327f2555eacb3b37d374f9520dc4fe7","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars2.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":11432401,"name":"encore-ui","full_name":"rackerlabs/encore-ui","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars2.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/encore-ui","description":"UI Framework for Encore","fork":false,"url":"https://api.github.com/repos/rackerlabs/encore-ui","forks_url":"https://api.github.com/repos/rackerlabs/encore-ui/forks","keys_url":"https://api.github.com/repos/rackerlabs/encore-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/encore-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/encore-ui/teams","hooks_url":"https://api.github.com/repos/rackerlabs/encore-ui/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/encore-ui/events","assignees_url":"https://api.github.com/repos/rackerlabs/encore-ui/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/encore-ui/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/tags","blobs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/encore-ui/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/encore-ui/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/encore-ui/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/encore-ui/subscription","commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/encore-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/encore-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/encore-ui/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/encore-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/encore-ui/merges","archive_url":"https://api.github.com/repos/rackerlabs/encore-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/encore-ui/downloads","issues_url":"https://api.github.com/repos/rackerlabs/encore-ui/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/encore-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/encore-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/encore-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/encore-ui/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/encore-ui/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/encore-ui/deployments","created_at":"2013-07-15T20:06:52Z","updated_at":"2017-06-20T15:18:48Z","pushed_at":"2017-06-28T17:12:22Z","git_url":"git://github.com/rackerlabs/encore-ui.git","ssh_url":"git@github.com:rackerlabs/encore-ui.git","clone_url":"https://github.com/rackerlabs/encore-ui.git","svn_url":"https://github.com/rackerlabs/encore-ui","homepage":"http://rackerlabs.github.io/encore-ui/","size":61370,"stargazers_count":48,"watchers_count":48,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"open_issues_count":14,"forks":57,"open_issues":14,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1991"},"html":{"href":"https://github.com/rackerlabs/encore-ui/pull/1991"},"issue":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1991"},"comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/issues/1991/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1991/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/pulls/1991/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/encore-ui/statuses/6ecaad570c39a9d80782639fa003f5cb9db25491"}}}}
{"actor":{"display_login":"CITguy"}}