{"action":"created","issue":{"url":"https://api.github.com/repos/singularityware/singularity/issues/539","repository_url":"https://api.github.com/repos/singularityware/singularity","labels_url":"https://api.github.com/repos/singularityware/singularity/issues/539/labels{/name}","comments_url":"https://api.github.com/repos/singularityware/singularity/issues/539/comments","events_url":"https://api.github.com/repos/singularityware/singularity/issues/539/events","html_url":"https://github.com/singularityware/singularity/pull/539","id":217244016,"number":539,"title":"Fix permissions docker","user":{"login":"hra0031","id":26401713,"avatar_url":"https://avatars0.githubusercontent.com/u/26401713?v=3","gravatar_id":"","url":"https://api.github.com/users/hra0031","html_url":"https://github.com/hra0031","followers_url":"https://api.github.com/users/hra0031/followers","following_url":"https://api.github.com/users/hra0031/following{/other_user}","gists_url":"https://api.github.com/users/hra0031/gists{/gist_id}","starred_url":"https://api.github.com/users/hra0031/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hra0031/subscriptions","organizations_url":"https://api.github.com/users/hra0031/orgs","repos_url":"https://api.github.com/users/hra0031/repos","events_url":"https://api.github.com/users/hra0031/events{/privacy}","received_events_url":"https://api.github.com/users/hra0031/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-03-27T13:22:25Z","updated_at":"2017-03-30T07:24:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/539","html_url":"https://github.com/singularityware/singularity/pull/539","diff_url":"https://github.com/singularityware/singularity/pull/539.diff","patch_url":"https://github.com/singularityware/singularity/pull/539.patch"},"body":"Fixes #538\r\n\r\nChanges proposed in this pull request\r\n\r\n - Fix file permissions for custom docker images\r\n\r\n@singularityware-admin"},"comment":{"url":"https://api.github.com/repos/singularityware/singularity/issues/comments/290324994","html_url":"https://github.com/singularityware/singularity/pull/539#issuecomment-290324994","issue_url":"https://api.github.com/repos/singularityware/singularity/issues/539","id":290324994,"user":{"login":"vsoch","id":814322,"avatar_url":"https://avatars3.githubusercontent.com/u/814322?v=3","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T07:24:13Z","updated_at":"2017-03-30T07:24:13Z","body":"@gmkurtzer to give this some context - we no longer have the fix_permissions functions because it is assumed this is done in the C code. However, if you are unable to do this, then we need to consider moving this back to python, and somehow dealing with this wrt the content file, etc. Let us know how things look on the C end! This PR will be un-broken given that those functions are added back. If you get it working with C, then this PR will be fixed by removing the fix_permissions command. @hra0031  - if we do go this route, it will be desired to not have fix_permissions happen on the level of run_command (because as  you can imagine, there are many commands for which we wouldn't need/want to run it) but on the level of the import/pull etc. function that would be extracting the layers. Right now, since the python isn't extracting anything, adding it anywhere would not do anything."}}
{"actor":{"display_login":"vsoch"}}