{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/101094060","pull_request_review_id":21813649,"id":101094060,"diff_hunk":"@@ -22,7 +24,7 @@ SocketListSend.prototype._request = function(msg, cmd, callback) {\n \n   function onclose() {\n     self.slave.removeListener('internalMessage', onreply);\n-    callback(new Error('Slave closed before reply'));\n+    callback(new errors.Error('ERR_SLAVE_CLOSED_BEFORE_REPLY'));","path":"lib/internal/socket_list.js","position":13,"original_position":13,"commit_id":"88d069d2f08e62bd2a274b1b5db80982368b3877","original_commit_id":"88d069d2f08e62bd2a274b1b5db80982368b3877","user":{"login":"joyeecheung","id":4299420,"avatar_url":"https://avatars.githubusercontent.com/u/4299420?v=3","gravatar_id":"","url":"https://api.github.com/users/joyeecheung","html_url":"https://github.com/joyeecheung","followers_url":"https://api.github.com/users/joyeecheung/followers","following_url":"https://api.github.com/users/joyeecheung/following{/other_user}","gists_url":"https://api.github.com/users/joyeecheung/gists{/gist_id}","starred_url":"https://api.github.com/users/joyeecheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyeecheung/subscriptions","organizations_url":"https://api.github.com/users/joyeecheung/orgs","repos_url":"https://api.github.com/users/joyeecheung/repos","events_url":"https://api.github.com/users/joyeecheung/events{/privacy}","received_events_url":"https://api.github.com/users/joyeecheung/received_events","type":"User","site_admin":false},"body":"Refs: [Documenting new errors](https://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.md#documenting-new-errors)","created_at":"2017-02-14T17:33:10Z","updated_at":"2017-02-14T17:33:10Z","html_url":"https://github.com/nodejs/node/pull/11356#discussion_r101094060","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/11356","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/101094060"},"html":{"href":"https://github.com/nodejs/node/pull/11356#discussion_r101094060"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/11356"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/11356","id":105979515,"html_url":"https://github.com/nodejs/node/pull/11356","diff_url":"https://github.com/nodejs/node/pull/11356.diff","patch_url":"https://github.com/nodejs/node/pull/11356.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/11356","number":11356,"state":"open","locked":false,"title":"errors socket_list : Migrate errors to internal/errors.js","user":{"login":"bougarfaoui","id":24884095,"avatar_url":"https://avatars.githubusercontent.com/u/24884095?v=3","gravatar_id":"","url":"https://api.github.com/users/bougarfaoui","html_url":"https://github.com/bougarfaoui","followers_url":"https://api.github.com/users/bougarfaoui/followers","following_url":"https://api.github.com/users/bougarfaoui/following{/other_user}","gists_url":"https://api.github.com/users/bougarfaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bougarfaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bougarfaoui/subscriptions","organizations_url":"https://api.github.com/users/bougarfaoui/orgs","repos_url":"https://api.github.com/users/bougarfaoui/repos","events_url":"https://api.github.com/users/bougarfaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bougarfaoui/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n - Assign codes to errors reported by internal/socket_list.js\r\n\r\nRef: #11273\r\n\r\nSemver-major because this updates specific error messages and converts errors over to use the new internal/errors.js mechanism.\r\n\r\ncc @jasnell\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\nerrors, socket_list\r\n","created_at":"2017-02-13T21:08:13Z","updated_at":"2017-02-14T17:33:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0495623133f4f5d3e908bd9e1122880daba503cb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/11356/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/11356/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/11356/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/88d069d2f08e62bd2a274b1b5db80982368b3877","head":{"label":"bougarfaoui:internal-errors-socket_list","ref":"internal-errors-socket_list","sha":"88d069d2f08e62bd2a274b1b5db80982368b3877","user":{"login":"bougarfaoui","id":24884095,"avatar_url":"https://avatars.githubusercontent.com/u/24884095?v=3","gravatar_id":"","url":"https://api.github.com/users/bougarfaoui","html_url":"https://github.com/bougarfaoui","followers_url":"https://api.github.com/users/bougarfaoui/followers","following_url":"https://api.github.com/users/bougarfaoui/following{/other_user}","gists_url":"https://api.github.com/users/bougarfaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bougarfaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bougarfaoui/subscriptions","organizations_url":"https://api.github.com/users/bougarfaoui/orgs","repos_url":"https://api.github.com/users/bougarfaoui/repos","events_url":"https://api.github.com/users/bougarfaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bougarfaoui/received_events","type":"User","site_admin":false},"repo":{"id":81848387,"name":"node","full_name":"bougarfaoui/node","owner":{"login":"bougarfaoui","id":24884095,"avatar_url":"https://avatars.githubusercontent.com/u/24884095?v=3","gravatar_id":"","url":"https://api.github.com/users/bougarfaoui","html_url":"https://github.com/bougarfaoui","followers_url":"https://api.github.com/users/bougarfaoui/followers","following_url":"https://api.github.com/users/bougarfaoui/following{/other_user}","gists_url":"https://api.github.com/users/bougarfaoui/gists{/gist_id}","starred_url":"https://api.github.com/users/bougarfaoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bougarfaoui/subscriptions","organizations_url":"https://api.github.com/users/bougarfaoui/orgs","repos_url":"https://api.github.com/users/bougarfaoui/repos","events_url":"https://api.github.com/users/bougarfaoui/events{/privacy}","received_events_url":"https://api.github.com/users/bougarfaoui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bougarfaoui/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/bougarfaoui/node","forks_url":"https://api.github.com/repos/bougarfaoui/node/forks","keys_url":"https://api.github.com/repos/bougarfaoui/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bougarfaoui/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bougarfaoui/node/teams","hooks_url":"https://api.github.com/repos/bougarfaoui/node/hooks","issue_events_url":"https://api.github.com/repos/bougarfaoui/node/issues/events{/number}","events_url":"https://api.github.com/repos/bougarfaoui/node/events","assignees_url":"https://api.github.com/repos/bougarfaoui/node/assignees{/user}","branches_url":"https://api.github.com/repos/bougarfaoui/node/branches{/branch}","tags_url":"https://api.github.com/repos/bougarfaoui/node/tags","blobs_url":"https://api.github.com/repos/bougarfaoui/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bougarfaoui/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bougarfaoui/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/bougarfaoui/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bougarfaoui/node/statuses/{sha}","languages_url":"https://api.github.com/repos/bougarfaoui/node/languages","stargazers_url":"https://api.github.com/repos/bougarfaoui/node/stargazers","contributors_url":"https://api.github.com/repos/bougarfaoui/node/contributors","subscribers_url":"https://api.github.com/repos/bougarfaoui/node/subscribers","subscription_url":"https://api.github.com/repos/bougarfaoui/node/subscription","commits_url":"https://api.github.com/repos/bougarfaoui/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/bougarfaoui/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/bougarfaoui/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/bougarfaoui/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/bougarfaoui/node/contents/{+path}","compare_url":"https://api.github.com/repos/bougarfaoui/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bougarfaoui/node/merges","archive_url":"https://api.github.com/repos/bougarfaoui/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bougarfaoui/node/downloads","issues_url":"https://api.github.com/repos/bougarfaoui/node/issues{/number}","pulls_url":"https://api.github.com/repos/bougarfaoui/node/pulls{/number}","milestones_url":"https://api.github.com/repos/bougarfaoui/node/milestones{/number}","notifications_url":"https://api.github.com/repos/bougarfaoui/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bougarfaoui/node/labels{/name}","releases_url":"https://api.github.com/repos/bougarfaoui/node/releases{/id}","deployments_url":"https://api.github.com/repos/bougarfaoui/node/deployments","created_at":"2017-02-13T16:53:29Z","updated_at":"2017-02-13T16:53:54Z","pushed_at":"2017-02-13T22:34:16Z","git_url":"git://github.com/bougarfaoui/node.git","ssh_url":"git@github.com:bougarfaoui/node.git","clone_url":"https://github.com/bougarfaoui/node.git","svn_url":"https://github.com/bougarfaoui/node","homepage":"https://nodejs.org","size":262313,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c6238e2761e9ba5c35aa4842c9be2ae937d28998","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-02-14T17:14:48Z","pushed_at":"2017-02-14T17:31:50Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":262426,"stargazers_count":31641,"watchers_count":31641,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5889,"mirror_url":null,"open_issues_count":1050,"forks":5889,"open_issues":1050,"watchers":31641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/11356"},"html":{"href":"https://github.com/nodejs/node/pull/11356"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/11356"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/11356/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/11356/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/11356/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/88d069d2f08e62bd2a274b1b5db80982368b3877"}}}}
{"actor":{"display_login":"joyeecheung"}}