{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/build/pulls/comments/109069277","pull_request_review_id":30147514,"id":109069277,"diff_hunk":"@@ -0,0 +1,44 @@\n+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file\n+// for details. All rights reserved. Use of this source code is governed by a\n+// BSD-style license that can be found in the LICENSE file.\n+\n+import 'package:build/build.dart';\n+import 'package:build_test/build_test.dart';\n+import 'package:glob/glob.dart';\n+import 'package:test/test.dart';\n+\n+void main() {\n+  group('$InMemoryAssetReader', () {\n+    final packageName = 'some_pkg';\n+    final libAsset = new AssetId(packageName, 'lib/some_pkg.dart');\n+    final testAsset = new AssetId(packageName, 'test/some_test.dart');\n+\n+    AssetReader assetReader;\n+\n+    setUp(() {\n+      assetReader = new InMemoryAssetReader(\n+        sourceAssets: {\n+          libAsset: new DatedString('libAsset'),\n+          testAsset: new DatedString('testAsset'),\n+        },\n+        rootPackage: packageName,\n+      );\n+    });\n+\n+    test('#findAssets should throw if rootPackage not supplied', () {\n+      assetReader = new InMemoryAssetReader();\n+      expect(\n+        () => assetReader.findAssets(new Glob('lib/*.dart')),\n+        throwsUnsupportedError,\n+      );\n+    });\n+\n+    test('#findAssets should files in lib/', () {","path":"build_test/test/in_memory_reader_test.dart","position":36,"original_position":36,"commit_id":"3f1e2b20d23c27e7caa779af67528a23cf902ae5","original_commit_id":"3f1e2b20d23c27e7caa779af67528a23cf902ae5","user":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars1.githubusercontent.com/u/168174?v=3","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-03-31T00:48:36Z","updated_at":"2017-03-31T00:48:37Z","html_url":"https://github.com/dart-lang/build/pull/243#discussion_r109069277","pull_request_url":"https://api.github.com/repos/dart-lang/build/pulls/243","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/build/pulls/comments/109069277"},"html":{"href":"https://github.com/dart-lang/build/pull/243#discussion_r109069277"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/build/pulls/243"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/build/pulls/243","id":113494154,"html_url":"https://github.com/dart-lang/build/pull/243","diff_url":"https://github.com/dart-lang/build/pull/243.diff","patch_url":"https://github.com/dart-lang/build/pull/243.patch","issue_url":"https://api.github.com/repos/dart-lang/build/issues/243","number":243,"state":"open","locked":false,"title":"Add a test for InMemoryAssetReader.","user":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars1.githubusercontent.com/u/168174?v=3","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"body":"Proves that https://github.com/dart-lang/build/issues/241 is not a bug.","created_at":"2017-03-30T18:27:45Z","updated_at":"2017-03-31T00:48:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6dc306e0fd6bd5af18313873a954a537996bfc15","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/build/pulls/243/commits","review_comments_url":"https://api.github.com/repos/dart-lang/build/pulls/243/comments","review_comment_url":"https://api.github.com/repos/dart-lang/build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/build/issues/243/comments","statuses_url":"https://api.github.com/repos/dart-lang/build/statuses/3f1e2b20d23c27e7caa779af67528a23cf902ae5","head":{"label":"matanlurey:in_memory_test","ref":"in_memory_test","sha":"3f1e2b20d23c27e7caa779af67528a23cf902ae5","user":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars1.githubusercontent.com/u/168174?v=3","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"repo":{"id":82082791,"name":"build","full_name":"matanlurey/build","owner":{"login":"matanlurey","id":168174,"avatar_url":"https://avatars1.githubusercontent.com/u/168174?v=3","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matanlurey/build","description":"A build system for Dart","fork":true,"url":"https://api.github.com/repos/matanlurey/build","forks_url":"https://api.github.com/repos/matanlurey/build/forks","keys_url":"https://api.github.com/repos/matanlurey/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matanlurey/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matanlurey/build/teams","hooks_url":"https://api.github.com/repos/matanlurey/build/hooks","issue_events_url":"https://api.github.com/repos/matanlurey/build/issues/events{/number}","events_url":"https://api.github.com/repos/matanlurey/build/events","assignees_url":"https://api.github.com/repos/matanlurey/build/assignees{/user}","branches_url":"https://api.github.com/repos/matanlurey/build/branches{/branch}","tags_url":"https://api.github.com/repos/matanlurey/build/tags","blobs_url":"https://api.github.com/repos/matanlurey/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matanlurey/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matanlurey/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/matanlurey/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matanlurey/build/statuses/{sha}","languages_url":"https://api.github.com/repos/matanlurey/build/languages","stargazers_url":"https://api.github.com/repos/matanlurey/build/stargazers","contributors_url":"https://api.github.com/repos/matanlurey/build/contributors","subscribers_url":"https://api.github.com/repos/matanlurey/build/subscribers","subscription_url":"https://api.github.com/repos/matanlurey/build/subscription","commits_url":"https://api.github.com/repos/matanlurey/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/matanlurey/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/matanlurey/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/matanlurey/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/matanlurey/build/contents/{+path}","compare_url":"https://api.github.com/repos/matanlurey/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matanlurey/build/merges","archive_url":"https://api.github.com/repos/matanlurey/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matanlurey/build/downloads","issues_url":"https://api.github.com/repos/matanlurey/build/issues{/number}","pulls_url":"https://api.github.com/repos/matanlurey/build/pulls{/number}","milestones_url":"https://api.github.com/repos/matanlurey/build/milestones{/number}","notifications_url":"https://api.github.com/repos/matanlurey/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matanlurey/build/labels{/name}","releases_url":"https://api.github.com/repos/matanlurey/build/releases{/id}","deployments_url":"https://api.github.com/repos/matanlurey/build/deployments","created_at":"2017-02-15T16:43:04Z","updated_at":"2017-02-15T16:43:06Z","pushed_at":"2017-03-31T00:47:46Z","git_url":"git://github.com/matanlurey/build.git","ssh_url":"git@github.com:matanlurey/build.git","clone_url":"https://github.com/matanlurey/build.git","svn_url":"https://github.com/matanlurey/build","homepage":"https://pub.dartlang.org/packages/build","size":435,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"9a15fe31499b532ec4b34b602dd1f03a1154ab07","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars3.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":50053618,"name":"build","full_name":"dart-lang/build","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars3.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/build","description":"A build system for Dart","fork":false,"url":"https://api.github.com/repos/dart-lang/build","forks_url":"https://api.github.com/repos/dart-lang/build/forks","keys_url":"https://api.github.com/repos/dart-lang/build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/build/teams","hooks_url":"https://api.github.com/repos/dart-lang/build/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/build/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/build/events","assignees_url":"https://api.github.com/repos/dart-lang/build/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/build/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/build/tags","blobs_url":"https://api.github.com/repos/dart-lang/build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/build/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/build/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/build/languages","stargazers_url":"https://api.github.com/repos/dart-lang/build/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/build/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/build/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/build/subscription","commits_url":"https://api.github.com/repos/dart-lang/build/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/build/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/build/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/build/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/build/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/build/merges","archive_url":"https://api.github.com/repos/dart-lang/build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/build/downloads","issues_url":"https://api.github.com/repos/dart-lang/build/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/build/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/build/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/build/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/build/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/build/deployments","created_at":"2016-01-20T19:12:37Z","updated_at":"2017-03-13T18:06:50Z","pushed_at":"2017-03-31T00:47:43Z","git_url":"git://github.com/dart-lang/build.git","ssh_url":"git@github.com:dart-lang/build.git","clone_url":"https://github.com/dart-lang/build.git","svn_url":"https://github.com/dart-lang/build","homepage":"https://pub.dartlang.org/packages/build","size":423,"stargazers_count":19,"watchers_count":19,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":26,"forks":7,"open_issues":26,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/build/pulls/243"},"html":{"href":"https://github.com/dart-lang/build/pull/243"},"issue":{"href":"https://api.github.com/repos/dart-lang/build/issues/243"},"comments":{"href":"https://api.github.com/repos/dart-lang/build/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/build/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/build/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/build/statuses/3f1e2b20d23c27e7caa779af67528a23cf902ae5"}}}}
{"actor":{"display_login":"matanlurey"}}