{"action":"created","issue":{"url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1341","repository_url":"https://api.github.com/repos/jonathanmccann/liferay-portal","labels_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1341/labels{/name}","comments_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1341/comments","events_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1341/events","html_url":"https://github.com/jonathanmccann/liferay-portal/pull/1341","id":235619262,"number":1341,"title":"[TECHNICAL-SUPPORT] LPS-72834","user":{"login":"SamZiemer","id":8029905,"avatar_url":"https://avatars3.githubusercontent.com/u/8029905?v=3","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-13T16:51:34Z","updated_at":"2017-06-13T16:54:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jonathanmccann/liferay-portal/pulls/1341","html_url":"https://github.com/jonathanmccann/liferay-portal/pull/1341","diff_url":"https://github.com/jonathanmccann/liferay-portal/pull/1341.diff","patch_url":"https://github.com/jonathanmccann/liferay-portal/pull/1341.patch"},"body":"/cc @JoshuaStClair\r\n\r\nNotes from Josh\r\n\r\n> In [LPP-25693](https://issues.liferay.com/browse/LPP-25693), the client describes that the current error messages for remote staging, when a user is not present on the remote server, are too vague and provide no insight to the user without the help of the console. The only UI indicator of an error is the tiny exclamation mark by the \"Go to Remote Live\" button, which is easy to miss. Even so, this error only says \"An unexpected error occurred.\" which isn't helpful for resolving the problem. \r\n> In order to fix this, I added a SessionError message that appears at the top, which specifically describes this scenario displaying: \"An error occurred while authenticating user {0} on the remote server.\" The exclamation mark will also be more specific in this case saying: \"An error occurred while authenticating user.\"\r\n> While looking over the code, I noticed a lot of areas that could use refactoring. Particularly in view.jsp, the when/otherwise tags had redundant nested conditions that were always true given that it had already passed the outer condition. I simplified these conditions to make the code easier to follow and maintain.\r\n> Next, if I wanted to add Session Error messages where the exception was being thrown, I would need to add it to the scriptlets in the view.jsp file. Instead of building off of the bad code, I decided to move the try catch block, along with a lot of the other scriptlets, inside the StagingBarPortlet:render command to make it easier to maintain in the future. By moving some of the setAttribute calls into the render command, I also took out redundant attributes whose only difference was the namespace: \"view.jsp-\" before the keys. I modified the corresponding included jsp's that used those attributes. \r\n> Also, just to note, the \"Go to Remote Live\" link doesn't actually work right now, per [LPS-72443](https://issues.liferay.com/browse/LPS-72443)\r\n> "},"comment":{"url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/comments/308180329","html_url":"https://github.com/jonathanmccann/liferay-portal/pull/1341#issuecomment-308180329","issue_url":"https://api.github.com/repos/jonathanmccann/liferay-portal/issues/1341","id":308180329,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars1.githubusercontent.com/u/4502793?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2017-06-13T16:54:27Z","updated_at":"2017-06-13T16:54:27Z","body":"<h1>Build started.</h1><p>Jenkins is currently running tests.</p><h4>Base Branch:</h4><p>Branch Name: <a href=\"https://github.com/liferay/liferay-portal/tree/master\">master</a></p><h4>Job Summary:</h4><p>Job Link: <a href=\"https://test-1-21.liferay.com/job/test-portal-acceptance-pullrequest(master)/811/\">test-portal-acceptance-pullrequest(master)</a></p><p><b>For more details click <a href=\"https://test-1-21.liferay.com//userContent/jobs/test-portal-acceptance-pullrequest(master)/builds/811/jenkins-report.html\">here</a>.</b></p>"}}
{"actor":{"display_login":"liferay-continuous-integration"}}