{"push_id":1680475986,"size":17,"distinct_size":6,"ref":"refs/heads/ReplyRework","head":"2da21942d8181383ec3942070ef806e27f11310c","before":"4c12e538b74d519469bffa1e4f005daa795ffb58","commits":[{"sha":"392785edd82caa4f36f4198b58c68d4849740c0d","author":{"name":"Sereri","email":"12fe2b3c8de88cac93cccf5c1a0e44f7f645228d@gmx.net"},"message":"version 168","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/392785edd82caa4f36f4198b58c68d4849740c0d"},{"sha":"963fb5063ebb34a4d345eb0fef4edaaf6e97dd13","author":{"name":"Sereri","email":"12fe2b3c8de88cac93cccf5c1a0e44f7f645228d@gmx.net"},"message":"Merge pull request #474 from Sereri/master\n\nversion 168","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/963fb5063ebb34a4d345eb0fef4edaaf6e97dd13"},{"sha":"80dedec5f395706807b81b974a5680213a8ff510","author":{"name":"baka kaba","email":"68afdb14074bf22c7cec6dcf5f654ff8bdff5275@email.nope"},"message":"Fix base themes for custom css\n\nI thought the only check for custom themes was whether they ended in .dark.css or not,\nturns out they could refer to every app theme and yeah I messed up\n\nI've added them all as custom variations of the theme enums - it's not a good solution\nbut it's the easiest fix right now. Just having the base themes and some way of overlaying\ncustom css (without breaking forum-specific themes) will mean reworking the whole thing","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/80dedec5f395706807b81b974a5680213a8ff510"},{"sha":"ec0add9e1cacc061a8225b589e73823a81300dd4","author":{"name":"baka-kaba","email":"9b9fcb166c64ab6e11ecdda34ea9f2f30b75e18f@users.noreply.github.com"},"message":"Merge pull request #475 from baka-kaba/ISeeHowThemesWork\n\nFix base themes for custom css","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/ec0add9e1cacc061a8225b589e73823a81300dd4"},{"sha":"ba53e5c094ed2f6e1ab242b2d4692880f4fe12f6","author":{"name":"Sereri","email":"12fe2b3c8de88cac93cccf5c1a0e44f7f645228d@gmx.net"},"message":"Our frog is round enough","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/ba53e5c094ed2f6e1ab242b2d4692880f4fe12f6"},{"sha":"3680616e04f2d35b1f5c43e0194e052fb93d37e7","author":{"name":"Sereri","email":"12fe2b3c8de88cac93cccf5c1a0e44f7f645228d@gmx.net"},"message":"Merge pull request #476 from Sereri/master\n\nOur frog is round enough","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/3680616e04f2d35b1f5c43e0194e052fb93d37e7"},{"sha":"e4ce32088d21f5f3862014cd3fdedbe3e13915a7","author":{"name":"baka kaba","email":"68afdb14074bf22c7cec6dcf5f654ff8bdff5275@email.nope"},"message":"Unbreak my WebView\n\nOld versions loooove Mixed Content","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/e4ce32088d21f5f3862014cd3fdedbe3e13915a7"},{"sha":"97cf0b547a06c366bb86e0cb0be5aec031ef9122","author":{"name":"baka-kaba","email":"9b9fcb166c64ab6e11ecdda34ea9f2f30b75e18f@users.noreply.github.com"},"message":"Merge pull request #477 from baka-kaba/Cleanup\n\nUnbreak my WebView","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/97cf0b547a06c366bb86e0cb0be5aec031ef9122"},{"sha":"fd36e3bb6fe488f3adadf563d75fa88fd1d049f3","author":{"name":"Sereri","email":"12fe2b3c8de88cac93cccf5c1a0e44f7f645228d@gmx.net"},"message":"Added DownloadListener to webview in ThreadDisplayFragment","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/fd36e3bb6fe488f3adadf563d75fa88fd1d049f3"},{"sha":"37b7fb8720bd79b0c74d97d6c8ff109a6dee4893","author":{"name":"Sereri","email":"12fe2b3c8de88cac93cccf5c1a0e44f7f645228d@gmx.net"},"message":"Merge pull request #478 from Sereri/master\n\nAdded DownloadListener to webview in ThreadDisplayFragment","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/37b7fb8720bd79b0c74d97d6c8ff109a6dee4893"},{"sha":"d049ea433f705899d071fcc8341e6ca4e2da2086","author":{"name":"baka kaba","email":"68afdb14074bf22c7cec6dcf5f654ff8bdff5275@email.nope"},"message":"Check for PMs and announcements on sync\n\nAdded checks for those so they can notify the user on app start.\nThey're handled whenever the user loads a page with one of those notification links -\nthe bookmarks page for PMs, and an actual forum page (with the thread list) for announcements.\n\nThat's not great if the user doesn't visit one of those pages, so now those pages are loaded on sync\nto trigger an update","distinct":false,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/d049ea433f705899d071fcc8341e6ca4e2da2086"},{"sha":"4587df4153ae9a2cb41218065f51ed7930c76a66","author":{"name":"baka-kaba","email":"9b9fcb166c64ab6e11ecdda34ea9f2f30b75e18f@users.noreply.github.com"},"message":"Merge pull request #479 from baka-kaba/master\n\nCheck for PMs and announcements on sync","distinct":true,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/4587df4153ae9a2cb41218065f51ed7930c76a66"},{"sha":"9f32e9a3fc7e2ebe3b6a552ac055271bea79d976","author":{"name":"baka kaba","email":"68afdb14074bf22c7cec6dcf5f654ff8bdff5275@email.nope"},"message":"Rework posting flow and draft handling\n\nI've changed the way posting works, removing menu options and pushing them into modal dialogs instead.\nSo 'save draft' is now an option when the user leaves the reply activity with an unsent post, and 'preview'\nis an option on the 'submit post' confirmation dialog.\n\nThe 'discard draft?' prompt is meant to force the decision to happen when the user is leaving the reply window,\nwhen they know whether they want to keep it or save it for later. The previous behaviour saved it automatically\nand then asked whether the user wanted to keep it when they next replied to that thread, which could be\nmonths later (if ever). So this way garbage can go straight where it belongs\n\nThe 'restore draft?' prompt is no longer dismissable, so the user has to make a decision. Before you could\naccidentally cancel the dialog and it would default to discarding the draft.\nHaving it default to using the draft is another option, I think a forced decision is better though\n\nThe 'submit post?' dialog now has the preview function as a third choice. Mostly to make it more discoverable\nand encourage people to use it, plus it fits with the main site's POST / PREVIEW button layout\n(which isn't necessarily an exemplar or anything I know ok)\n\nAutomatic draft saving now happens in #onPause, should hopefully cover more situations where the reply\ncan be 'lost'. I've moved it into the general cleanup method, and removed some of the calls that are basically\ncovered by onPause (like the viewpager hiding the reply page)\n\nAlso various code tweaks while I was in there, some documentation, and I've ditched the reply content state\nvariable so we can just grab the current contents of the message composer instead","distinct":true,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/9f32e9a3fc7e2ebe3b6a552ac055271bea79d976"},{"sha":"0a80e64348d6dac9a780bcc7dc294b41a692186d","author":{"name":"baka kaba","email":"68afdb14074bf22c7cec6dcf5f654ff8bdff5275@email.nope"},"message":"Move code into #onActivityCreated, rename and clean up async code\n\nSome of the code in #onCreate relies on the Activity already existing, so I've moved it into #onActivityCreated.\nI've also renamed some of the async methods/variables to make it clearer what they do, and done a bit of refactoring.","distinct":true,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/0a80e64348d6dac9a780bcc7dc294b41a692186d"},{"sha":"221d48d10e4ab81ab6b1540f4c2d5e3d514fddd7","author":{"name":"baka kaba","email":"68afdb14074bf22c7cec6dcf5f654ff8bdff5275@email.nope"},"message":"Rework draft logic, add error messages when activity cannot start\n\nI've moved the draft code around so the loader handles loading any data, and creates a SavedDraft object\nencapsulating all the related variables. A separate method gets called when the reply data is loaded, checks\nif there's any SavedDraft object to handle, and then decides whether to give the user the option to use it.\n\nThe idea is to separate the deserialisation from the general workflow, and have the decision logic pulled out\ninto a clearer and more explicit flow, and make the overall state a bit simpler.","distinct":true,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/221d48d10e4ab81ab6b1540f4c2d5e3d514fddd7"},{"sha":"820d0cd14f1aa12320a2d405ade18157af5ab2c0","author":{"name":"baka kaba","email":"68afdb14074bf22c7cec6dcf5f654ff8bdff5275@email.nope"},"message":"Reorder methods, add docs and resource strings, fix lint\n\nMoved stuff around to group methods more logically, and hopefully make it easier to follow\nAdded some more docs/annotations/todos\nReworded some things and moved them into resource strings, mostly shorter button text and edit/post-aware prompts","distinct":true,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/820d0cd14f1aa12320a2d405ade18157af5ab2c0"},{"sha":"2da21942d8181383ec3942070ef806e27f11310c","author":{"name":"baka kaba","email":"68afdb14074bf22c7cec6dcf5f654ff8bdff5275@email.nope"},"message":"Remove thread info ContentObserver from PostReplyFragment\n\nI've removed the thing that notifies when the thread data changes and forces a title update.\nIt's not something that changes often, and even if it did change while someone was writing a reply,\nit doesn't seem important?","distinct":true,"url":"https://api.github.com/repos/baka-kaba/Awful.apk/commits/2da21942d8181383ec3942070ef806e27f11310c"}]}
{"actor":{"display_login":"baka-kaba"}}