{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/comments/121228239","pull_request_review_id":43267861,"id":121228239,"diff_hunk":"@@ -1305,6 +1349,21 @@ export abstract class ChromeDebugAdapter implements IDebugAdapter {\n         };\n     }\n \n+    private scriptToScriptEvent(script: Crdp.Debugger.ScriptParsedEvent): ScriptEvent {\n+        const sourceReference = this.getSourceReferenceForScriptId(script.scriptId);\n+        const origin = this.getReadonlyOrigin(script.url);\n+        const source = {\n+            name: path.basename(script.url),\n+            path: script.url,\n+            sourceReference,\n+            origin\n+        };\n+\n+        const pinezorroScript: Script = new Script(source);","path":"src/chrome/chromeDebugAdapter.ts","position":102,"original_position":102,"commit_id":"0298a8249f62388818d1934dc01a45eb33f842ec","original_commit_id":"0298a8249f62388818d1934dc01a45eb33f842ec","user":{"login":"roblourens","id":323878,"avatar_url":"https://avatars0.githubusercontent.com/u/323878?v=3","gravatar_id":"","url":"https://api.github.com/users/roblourens","html_url":"https://github.com/roblourens","followers_url":"https://api.github.com/users/roblourens/followers","following_url":"https://api.github.com/users/roblourens/following{/other_user}","gists_url":"https://api.github.com/users/roblourens/gists{/gist_id}","starred_url":"https://api.github.com/users/roblourens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblourens/subscriptions","organizations_url":"https://api.github.com/users/roblourens/orgs","repos_url":"https://api.github.com/users/roblourens/repos","events_url":"https://api.github.com/users/roblourens/events{/privacy}","received_events_url":"https://api.github.com/users/roblourens/received_events","type":"User","site_admin":false},"body":"Don't refer to pinezorro here. It's relevant for the debug protocol itself, not a particular client","created_at":"2017-06-09T21:41:52Z","updated_at":"2017-06-09T21:41:58Z","html_url":"https://github.com/Microsoft/vscode-chrome-debug-core/pull/211#discussion_r121228239","pull_request_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/211","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/comments/121228239"},"html":{"href":"https://github.com/Microsoft/vscode-chrome-debug-core/pull/211#discussion_r121228239"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/211","id":124951358,"html_url":"https://github.com/Microsoft/vscode-chrome-debug-core/pull/211","diff_url":"https://github.com/Microsoft/vscode-chrome-debug-core/pull/211.diff","patch_url":"https://github.com/Microsoft/vscode-chrome-debug-core/pull/211.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/issues/211","number":211,"state":"open","locked":false,"title":"Adding support for dynamic scripts","user":{"login":"rakatyal","id":12533467,"avatar_url":"https://avatars1.githubusercontent.com/u/12533467?v=3","gravatar_id":"","url":"https://api.github.com/users/rakatyal","html_url":"https://github.com/rakatyal","followers_url":"https://api.github.com/users/rakatyal/followers","following_url":"https://api.github.com/users/rakatyal/following{/other_user}","gists_url":"https://api.github.com/users/rakatyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rakatyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakatyal/subscriptions","organizations_url":"https://api.github.com/users/rakatyal/orgs","repos_url":"https://api.github.com/users/rakatyal/repos","events_url":"https://api.github.com/users/rakatyal/events{/privacy}","received_events_url":"https://api.github.com/users/rakatyal/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-09T21:12:36Z","updated_at":"2017-06-09T21:41:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ad079123018fe51381f2a3f83ecd7aa9039cf19","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/211/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/211/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/issues/211/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/statuses/0298a8249f62388818d1934dc01a45eb33f842ec","head":{"label":"rakatyal:raghav/dynamic_scripts","ref":"raghav/dynamic_scripts","sha":"0298a8249f62388818d1934dc01a45eb33f842ec","user":{"login":"rakatyal","id":12533467,"avatar_url":"https://avatars1.githubusercontent.com/u/12533467?v=3","gravatar_id":"","url":"https://api.github.com/users/rakatyal","html_url":"https://github.com/rakatyal","followers_url":"https://api.github.com/users/rakatyal/followers","following_url":"https://api.github.com/users/rakatyal/following{/other_user}","gists_url":"https://api.github.com/users/rakatyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rakatyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakatyal/subscriptions","organizations_url":"https://api.github.com/users/rakatyal/orgs","repos_url":"https://api.github.com/users/rakatyal/repos","events_url":"https://api.github.com/users/rakatyal/events{/privacy}","received_events_url":"https://api.github.com/users/rakatyal/received_events","type":"User","site_admin":false},"repo":{"id":93896556,"name":"vscode-chrome-debug-core","full_name":"rakatyal/vscode-chrome-debug-core","owner":{"login":"rakatyal","id":12533467,"avatar_url":"https://avatars1.githubusercontent.com/u/12533467?v=3","gravatar_id":"","url":"https://api.github.com/users/rakatyal","html_url":"https://github.com/rakatyal","followers_url":"https://api.github.com/users/rakatyal/followers","following_url":"https://api.github.com/users/rakatyal/following{/other_user}","gists_url":"https://api.github.com/users/rakatyal/gists{/gist_id}","starred_url":"https://api.github.com/users/rakatyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakatyal/subscriptions","organizations_url":"https://api.github.com/users/rakatyal/orgs","repos_url":"https://api.github.com/users/rakatyal/repos","events_url":"https://api.github.com/users/rakatyal/events{/privacy}","received_events_url":"https://api.github.com/users/rakatyal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rakatyal/vscode-chrome-debug-core","description":"A library for implementing VS Code debug adapters for targets that implement the Chrome Debugging Protocol.","fork":true,"url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core","forks_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/forks","keys_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/teams","hooks_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/hooks","issue_events_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/issues/events{/number}","events_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/events","assignees_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/assignees{/user}","branches_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/branches{/branch}","tags_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/tags","blobs_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/statuses/{sha}","languages_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/languages","stargazers_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/stargazers","contributors_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/contributors","subscribers_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/subscribers","subscription_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/subscription","commits_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/contents/{+path}","compare_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/merges","archive_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/downloads","issues_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/issues{/number}","pulls_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/pulls{/number}","milestones_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/milestones{/number}","notifications_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/labels{/name}","releases_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/releases{/id}","deployments_url":"https://api.github.com/repos/rakatyal/vscode-chrome-debug-core/deployments","created_at":"2017-06-09T21:01:48Z","updated_at":"2017-06-09T21:01:50Z","pushed_at":"2017-06-09T21:11:25Z","git_url":"git://github.com/rakatyal/vscode-chrome-debug-core.git","ssh_url":"git@github.com:rakatyal/vscode-chrome-debug-core.git","clone_url":"https://github.com/rakatyal/vscode-chrome-debug-core.git","svn_url":"https://github.com/rakatyal/vscode-chrome-debug-core","homepage":"","size":11634,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"a5b30564b855b572ab04a13aba8ae924e170150c","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":56088006,"name":"vscode-chrome-debug-core","full_name":"Microsoft/vscode-chrome-debug-core","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-chrome-debug-core","description":"A library for implementing VS Code debug adapters for targets that implement the Chrome Debugging Protocol.","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core","forks_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/deployments","created_at":"2016-04-12T18:30:31Z","updated_at":"2017-06-06T00:35:36Z","pushed_at":"2017-06-09T21:12:36Z","git_url":"git://github.com/Microsoft/vscode-chrome-debug-core.git","ssh_url":"git@github.com:Microsoft/vscode-chrome-debug-core.git","clone_url":"https://github.com/Microsoft/vscode-chrome-debug-core.git","svn_url":"https://github.com/Microsoft/vscode-chrome-debug-core","homepage":"","size":11634,"stargazers_count":33,"watchers_count":33,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":39,"forks":38,"open_issues":39,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/211"},"html":{"href":"https://github.com/Microsoft/vscode-chrome-debug-core/pull/211"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/issues/211"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-chrome-debug-core/statuses/0298a8249f62388818d1934dc01a45eb33f842ec"}}}}
{"actor":{"display_login":"roblourens"}}