{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/126987779","pull_request_review_id":49527395,"id":126987779,"diff_hunk":"@@ -155,6 +167,37 @@ click: function () { closeClicked.raiseEvent(this); }');\n         },\n \n         /**\n+         * Gets or sets the security settings for iFrames generated by the Infobox.\n+         * This will disable sandboxing for the iFrame, and allow HTML to be in the title.\n+         * Only do this if you are in complete control of the data that will be loaded into the InfoBox,\n+         * otherwise it is a security issue.\n+         * @memberof InfoBox.prototype\n+         *\n+         * @type {Boolean}\n+         */\n+        disableSecurity : {\n+            get : function() {\n+                return this._disableSecurity;\n+            },\n+            set : function(value) {\n+                this._disableSecurity = value;\n+                var e = this._element.getElementsByClassName('cesium-infoBox-title')[0];\n+                if (value) {\n+                    e.removeAttribute('data-bind');\n+                    e.setAttribute('data-bind', 'html: titleText');\n+                    this._frame.removeAttribute('sandbox');\n+                }\n+                else {\n+                    e.removeAttribute('data-bind');\n+                    e.setAttribute('data-bind', 'text: titleText');\n+                    this._frame.setAttribute('sandbox', 'allow-same-origin allow-popups allow-forms');\n+                }\n+                knockout.cleanNode(this._element);","path":"Source/Widgets/InfoBox/InfoBox.js","position":99,"original_position":99,"commit_id":"9911050209541e83d6cb1699d323c0a4d9cc9cf0","original_commit_id":"9911050209541e83d6cb1699d323c0a4d9cc9cf0","user":{"login":"burn123","id":2721458,"avatar_url":"https://avatars1.githubusercontent.com/u/2721458?v=3","gravatar_id":"","url":"https://api.github.com/users/burn123","html_url":"https://github.com/burn123","followers_url":"https://api.github.com/users/burn123/followers","following_url":"https://api.github.com/users/burn123/following{/other_user}","gists_url":"https://api.github.com/users/burn123/gists{/gist_id}","starred_url":"https://api.github.com/users/burn123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burn123/subscriptions","organizations_url":"https://api.github.com/users/burn123/orgs","repos_url":"https://api.github.com/users/burn123/repos","events_url":"https://api.github.com/users/burn123/events{/privacy}","received_events_url":"https://api.github.com/users/burn123/received_events","type":"User","site_admin":false},"body":"But when the `titleText` is set in Viewer, would you need an additional check there? Otherwise, I'm not sure how you would know which property of `titleInfo` to set.","created_at":"2017-07-12T15:28:08Z","updated_at":"2017-07-12T15:28:08Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5616#discussion_r126987779","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5616","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/126987779"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5616#discussion_r126987779"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5616"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5616","id":130002167,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5616","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5616.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5616.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/5616","number":5616,"state":"open","locked":false,"title":"Add ability to disable security for InfoBox","user":{"login":"burn123","id":2721458,"avatar_url":"https://avatars1.githubusercontent.com/u/2721458?v=3","gravatar_id":"","url":"https://api.github.com/users/burn123","html_url":"https://github.com/burn123","followers_url":"https://api.github.com/users/burn123/followers","following_url":"https://api.github.com/users/burn123/following{/other_user}","gists_url":"https://api.github.com/users/burn123/gists{/gist_id}","starred_url":"https://api.github.com/users/burn123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burn123/subscriptions","organizations_url":"https://api.github.com/users/burn123/orgs","repos_url":"https://api.github.com/users/burn123/repos","events_url":"https://api.github.com/users/burn123/events{/privacy}","received_events_url":"https://api.github.com/users/burn123/received_events","type":"User","site_admin":false},"body":"This fixes #5446, also see this [forum post.](https://groups.google.com/forum/#!msg/cesium-dev/Ktn8aPQmOsQ/_Dbd7igkCQAJ)\r\n\r\nThis adds the ability to disable the sandboxing on the iFrame in an InfoBox, as well as allow for the title to contain HTML, by setting the new `disableSecurity` property. If there are other security things that could be disabled, they could go here as well. The idea was to have a top level InfoBox property, but since the InfoBox isn't usually directly Instantiated (at least in my case), I also added the ability to set the property directly.\r\n\r\nI don't know much about knockout, so to accomplish HTML in the title I had to remove the data-bind, add the bind as `html`, then clear and apply bindings. If someone knows a different/more efficient way of doing this, that would be cool.\r\n\r\nThere are 3 failed tests, but I checked the master, and there are 3 failed checks there as well, so I'm not to blame.\r\n\r\nI also just sent the CLA to whoever it is important.","created_at":"2017-07-11T20:48:29Z","updated_at":"2017-07-12T15:28:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5d64f4a04e4d09f5cdf91731fc52964845d24b1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5616/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5616/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/5616/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/9911050209541e83d6cb1699d323c0a4d9cc9cf0","head":{"label":"burn123:infobox-security","ref":"infobox-security","sha":"9911050209541e83d6cb1699d323c0a4d9cc9cf0","user":{"login":"burn123","id":2721458,"avatar_url":"https://avatars1.githubusercontent.com/u/2721458?v=3","gravatar_id":"","url":"https://api.github.com/users/burn123","html_url":"https://github.com/burn123","followers_url":"https://api.github.com/users/burn123/followers","following_url":"https://api.github.com/users/burn123/following{/other_user}","gists_url":"https://api.github.com/users/burn123/gists{/gist_id}","starred_url":"https://api.github.com/users/burn123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burn123/subscriptions","organizations_url":"https://api.github.com/users/burn123/orgs","repos_url":"https://api.github.com/users/burn123/repos","events_url":"https://api.github.com/users/burn123/events{/privacy}","received_events_url":"https://api.github.com/users/burn123/received_events","type":"User","site_admin":false},"repo":{"id":96899517,"name":"cesium","full_name":"burn123/cesium","owner":{"login":"burn123","id":2721458,"avatar_url":"https://avatars1.githubusercontent.com/u/2721458?v=3","gravatar_id":"","url":"https://api.github.com/users/burn123","html_url":"https://github.com/burn123","followers_url":"https://api.github.com/users/burn123/followers","following_url":"https://api.github.com/users/burn123/following{/other_user}","gists_url":"https://api.github.com/users/burn123/gists{/gist_id}","starred_url":"https://api.github.com/users/burn123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burn123/subscriptions","organizations_url":"https://api.github.com/users/burn123/orgs","repos_url":"https://api.github.com/users/burn123/repos","events_url":"https://api.github.com/users/burn123/events{/privacy}","received_events_url":"https://api.github.com/users/burn123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burn123/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":true,"url":"https://api.github.com/repos/burn123/cesium","forks_url":"https://api.github.com/repos/burn123/cesium/forks","keys_url":"https://api.github.com/repos/burn123/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burn123/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burn123/cesium/teams","hooks_url":"https://api.github.com/repos/burn123/cesium/hooks","issue_events_url":"https://api.github.com/repos/burn123/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/burn123/cesium/events","assignees_url":"https://api.github.com/repos/burn123/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/burn123/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/burn123/cesium/tags","blobs_url":"https://api.github.com/repos/burn123/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burn123/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burn123/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/burn123/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burn123/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/burn123/cesium/languages","stargazers_url":"https://api.github.com/repos/burn123/cesium/stargazers","contributors_url":"https://api.github.com/repos/burn123/cesium/contributors","subscribers_url":"https://api.github.com/repos/burn123/cesium/subscribers","subscription_url":"https://api.github.com/repos/burn123/cesium/subscription","commits_url":"https://api.github.com/repos/burn123/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/burn123/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/burn123/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/burn123/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/burn123/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/burn123/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burn123/cesium/merges","archive_url":"https://api.github.com/repos/burn123/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burn123/cesium/downloads","issues_url":"https://api.github.com/repos/burn123/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/burn123/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/burn123/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/burn123/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burn123/cesium/labels{/name}","releases_url":"https://api.github.com/repos/burn123/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/burn123/cesium/deployments","created_at":"2017-07-11T14:00:18Z","updated_at":"2017-07-11T14:00:31Z","pushed_at":"2017-07-12T03:23:22Z","git_url":"git://github.com/burn123/cesium.git","ssh_url":"git@github.com:burn123/cesium.git","clone_url":"https://github.com/burn123/cesium.git","svn_url":"https://github.com/burn123/cesium","homepage":"http://cesiumjs.org/","size":262153,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"b2fc7ffb6d65a3fa1de9fa33e28f4f5bef02f1da","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars3.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars3.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2017-07-12T11:45:42Z","pushed_at":"2017-07-12T15:16:17Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"http://cesiumjs.org/","size":273026,"stargazers_count":2306,"watchers_count":2306,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1117,"mirror_url":null,"open_issues_count":574,"forks":1117,"open_issues":574,"watchers":2306,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5616"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5616"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/5616"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/5616/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5616/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5616/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/9911050209541e83d6cb1699d323c0a4d9cc9cf0"}}}}
{"actor":{"display_login":"burn123"}}