{"action":"created","comment":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/154312247","pull_request_review_id":80456175,"id":154312247,"diff_hunk":"@@ -0,0 +1,42 @@\n+import com.sap.piper.Utils\n+\n+/**\n+ * externalPipelineExecute","path":"vars/externalPipelineExecute.groovy","position":4,"original_position":4,"commit_id":"06e5a72f87ac1ea4c4cba970ba63ac842b853002","original_commit_id":"06e5a72f87ac1ea4c4cba970ba63ac842b853002","user":{"login":"marcusholl","id":1853183,"avatar_url":"https://avatars2.githubusercontent.com/u/1853183?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusholl","html_url":"https://github.com/marcusholl","followers_url":"https://api.github.com/users/marcusholl/followers","following_url":"https://api.github.com/users/marcusholl/following{/other_user}","gists_url":"https://api.github.com/users/marcusholl/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusholl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusholl/subscriptions","organizations_url":"https://api.github.com/users/marcusholl/orgs","repos_url":"https://api.github.com/users/marcusholl/repos","events_url":"https://api.github.com/users/marcusholl/events{/privacy}","received_events_url":"https://api.github.com/users/marcusholl/received_events","type":"User","site_admin":false},"body":"changed to ```pipelineExecute```.","created_at":"2017-12-01T10:22:47Z","updated_at":"2017-12-01T10:22:47Z","html_url":"https://github.com/SAP/jenkins-library/pull/16#discussion_r154312247","pull_request_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/16","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments/154312247"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/16#discussion_r154312247"},"pull_request":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/16"}},"in_reply_to_id":154040550},"pull_request":{"url":"https://api.github.com/repos/SAP/jenkins-library/pulls/16","id":154553663,"html_url":"https://github.com/SAP/jenkins-library/pull/16","diff_url":"https://github.com/SAP/jenkins-library/pull/16.diff","patch_url":"https://github.com/SAP/jenkins-library/pull/16.patch","issue_url":"https://api.github.com/repos/SAP/jenkins-library/issues/16","number":16,"state":"open","locked":false,"title":"Central pipeline load step","user":{"login":"o-liver","id":29037234,"avatar_url":"https://avatars1.githubusercontent.com/u/29037234?v=4","gravatar_id":"","url":"https://api.github.com/users/o-liver","html_url":"https://github.com/o-liver","followers_url":"https://api.github.com/users/o-liver/followers","following_url":"https://api.github.com/users/o-liver/following{/other_user}","gists_url":"https://api.github.com/users/o-liver/gists{/gist_id}","starred_url":"https://api.github.com/users/o-liver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o-liver/subscriptions","organizations_url":"https://api.github.com/users/o-liver/orgs","repos_url":"https://api.github.com/users/o-liver/repos","events_url":"https://api.github.com/users/o-liver/events{/privacy}","received_events_url":"https://api.github.com/users/o-liver/received_events","type":"User","site_admin":false},"body":"A step to implement this: https://github.com/SAP/jenkins-pipelines/pull/3\r\nThe idea is to set up a pipeline job in Jenkins that loads a minimal pipeline, which in turn loads the shared library and then uses **this** **step** to load the actual pipeline.\r\n\r\nDescription from @marcusholl:\r\n>With that approach the project sources are checked out using\r\nprojectUrl, branch and credentials from the job configuration.\r\n>\r\n>In case of using this pipeline script as a central pipeline\r\nscript, not contained in the project sources, but served from a\r\ncentral repo, the projectUrl and the branch of the \"payload\"\r\nrepo needed to be provided via job parameters. This way is\r\nnow not supported anymore.\r\n>\r\n>Instead the \"payload\" repo needs to be referenced always directly in\r\nthe job configuration. Hence there is no need anymore for having\r\nrepository URL and branch as job parameters. The central pipeline\r\nscript is now expected to be loaded from a stub pipeline script\r\nlocated in the \"payload\" repo. An example for such a stub pipeline\r\nscript is contained in this commit (pipelines/stub/Jenkinsfile).\r\n>\r\n>Advantage of that approach: In case the \"payload\" repo is protected\r\nwith credentials we can use directly use the credentialsId which is\r\nprovided in the job configuration together with repoUrl and branch.\r\nBefore this was not possible since the repoUrl, the branch and the\r\ncredentialsId configured in the job was thatone of the central\r\npipeline script rather than thatpone of the \"payload\" repo.\r\n>\r\n>Disadvantate of that approach: The central pipeline script can be\r\ndisabled by project members by not using the stub file or by changing\r\nthis file.","created_at":"2017-11-24T13:57:24Z","updated_at":"2017-12-01T10:22:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e74326643aec0f8e9d1a71f82aea63624055fe0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kbarnold","id":11404448,"avatar_url":"https://avatars3.githubusercontent.com/u/11404448?v=4","gravatar_id":"","url":"https://api.github.com/users/kbarnold","html_url":"https://github.com/kbarnold","followers_url":"https://api.github.com/users/kbarnold/followers","following_url":"https://api.github.com/users/kbarnold/following{/other_user}","gists_url":"https://api.github.com/users/kbarnold/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarnold/subscriptions","organizations_url":"https://api.github.com/users/kbarnold/orgs","repos_url":"https://api.github.com/users/kbarnold/repos","events_url":"https://api.github.com/users/kbarnold/events{/privacy}","received_events_url":"https://api.github.com/users/kbarnold/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/16/commits","review_comments_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/16/comments","review_comment_url":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/issues/16/comments","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/06e5a72f87ac1ea4c4cba970ba63ac842b853002","head":{"label":"o-liver:centralPipelineLoadStep","ref":"centralPipelineLoadStep","sha":"06e5a72f87ac1ea4c4cba970ba63ac842b853002","user":{"login":"o-liver","id":29037234,"avatar_url":"https://avatars1.githubusercontent.com/u/29037234?v=4","gravatar_id":"","url":"https://api.github.com/users/o-liver","html_url":"https://github.com/o-liver","followers_url":"https://api.github.com/users/o-liver/followers","following_url":"https://api.github.com/users/o-liver/following{/other_user}","gists_url":"https://api.github.com/users/o-liver/gists{/gist_id}","starred_url":"https://api.github.com/users/o-liver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o-liver/subscriptions","organizations_url":"https://api.github.com/users/o-liver/orgs","repos_url":"https://api.github.com/users/o-liver/repos","events_url":"https://api.github.com/users/o-liver/events{/privacy}","received_events_url":"https://api.github.com/users/o-liver/received_events","type":"User","site_admin":false},"repo":{"id":110965027,"name":"jenkins-library","full_name":"o-liver/jenkins-library","owner":{"login":"o-liver","id":29037234,"avatar_url":"https://avatars1.githubusercontent.com/u/29037234?v=4","gravatar_id":"","url":"https://api.github.com/users/o-liver","html_url":"https://github.com/o-liver","followers_url":"https://api.github.com/users/o-liver/followers","following_url":"https://api.github.com/users/o-liver/following{/other_user}","gists_url":"https://api.github.com/users/o-liver/gists{/gist_id}","starred_url":"https://api.github.com/users/o-liver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/o-liver/subscriptions","organizations_url":"https://api.github.com/users/o-liver/orgs","repos_url":"https://api.github.com/users/o-liver/repos","events_url":"https://api.github.com/users/o-liver/events{/privacy}","received_events_url":"https://api.github.com/users/o-liver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/o-liver/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":true,"url":"https://api.github.com/repos/o-liver/jenkins-library","forks_url":"https://api.github.com/repos/o-liver/jenkins-library/forks","keys_url":"https://api.github.com/repos/o-liver/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/o-liver/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/o-liver/jenkins-library/teams","hooks_url":"https://api.github.com/repos/o-liver/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/o-liver/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/o-liver/jenkins-library/events","assignees_url":"https://api.github.com/repos/o-liver/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/o-liver/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/o-liver/jenkins-library/tags","blobs_url":"https://api.github.com/repos/o-liver/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/o-liver/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/o-liver/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/o-liver/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/o-liver/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/o-liver/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/o-liver/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/o-liver/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/o-liver/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/o-liver/jenkins-library/subscription","commits_url":"https://api.github.com/repos/o-liver/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/o-liver/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/o-liver/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/o-liver/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/o-liver/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/o-liver/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/o-liver/jenkins-library/merges","archive_url":"https://api.github.com/repos/o-liver/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/o-liver/jenkins-library/downloads","issues_url":"https://api.github.com/repos/o-liver/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/o-liver/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/o-liver/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/o-liver/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/o-liver/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/o-liver/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/o-liver/jenkins-library/deployments","created_at":"2017-11-16T11:47:41Z","updated_at":"2017-11-16T11:47:43Z","pushed_at":"2017-11-29T11:51:11Z","git_url":"git://github.com/o-liver/jenkins-library.git","ssh_url":"git@github.com:o-liver/jenkins-library.git","clone_url":"https://github.com/o-liver/jenkins-library.git","svn_url":"https://github.com/o-liver/jenkins-library","homepage":null,"size":543,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SAP:master","ref":"master","sha":"e9a17aa41c43bf5cadac2a23be2503878d385911","user":{"login":"SAP","id":2531208,"avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"repo":{"id":107318996,"name":"jenkins-library","full_name":"SAP/jenkins-library","owner":{"login":"SAP","id":2531208,"avatar_url":"https://avatars1.githubusercontent.com/u/2531208?v=4","gravatar_id":"","url":"https://api.github.com/users/SAP","html_url":"https://github.com/SAP","followers_url":"https://api.github.com/users/SAP/followers","following_url":"https://api.github.com/users/SAP/following{/other_user}","gists_url":"https://api.github.com/users/SAP/gists{/gist_id}","starred_url":"https://api.github.com/users/SAP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SAP/subscriptions","organizations_url":"https://api.github.com/users/SAP/orgs","repos_url":"https://api.github.com/users/SAP/repos","events_url":"https://api.github.com/users/SAP/events{/privacy}","received_events_url":"https://api.github.com/users/SAP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SAP/jenkins-library","description":"Jenkins shared library for Continuous Delivery pipelines.","fork":false,"url":"https://api.github.com/repos/SAP/jenkins-library","forks_url":"https://api.github.com/repos/SAP/jenkins-library/forks","keys_url":"https://api.github.com/repos/SAP/jenkins-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SAP/jenkins-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SAP/jenkins-library/teams","hooks_url":"https://api.github.com/repos/SAP/jenkins-library/hooks","issue_events_url":"https://api.github.com/repos/SAP/jenkins-library/issues/events{/number}","events_url":"https://api.github.com/repos/SAP/jenkins-library/events","assignees_url":"https://api.github.com/repos/SAP/jenkins-library/assignees{/user}","branches_url":"https://api.github.com/repos/SAP/jenkins-library/branches{/branch}","tags_url":"https://api.github.com/repos/SAP/jenkins-library/tags","blobs_url":"https://api.github.com/repos/SAP/jenkins-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SAP/jenkins-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SAP/jenkins-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/SAP/jenkins-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SAP/jenkins-library/statuses/{sha}","languages_url":"https://api.github.com/repos/SAP/jenkins-library/languages","stargazers_url":"https://api.github.com/repos/SAP/jenkins-library/stargazers","contributors_url":"https://api.github.com/repos/SAP/jenkins-library/contributors","subscribers_url":"https://api.github.com/repos/SAP/jenkins-library/subscribers","subscription_url":"https://api.github.com/repos/SAP/jenkins-library/subscription","commits_url":"https://api.github.com/repos/SAP/jenkins-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/SAP/jenkins-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/SAP/jenkins-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/SAP/jenkins-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/SAP/jenkins-library/contents/{+path}","compare_url":"https://api.github.com/repos/SAP/jenkins-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SAP/jenkins-library/merges","archive_url":"https://api.github.com/repos/SAP/jenkins-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SAP/jenkins-library/downloads","issues_url":"https://api.github.com/repos/SAP/jenkins-library/issues{/number}","pulls_url":"https://api.github.com/repos/SAP/jenkins-library/pulls{/number}","milestones_url":"https://api.github.com/repos/SAP/jenkins-library/milestones{/number}","notifications_url":"https://api.github.com/repos/SAP/jenkins-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SAP/jenkins-library/labels{/name}","releases_url":"https://api.github.com/repos/SAP/jenkins-library/releases{/id}","deployments_url":"https://api.github.com/repos/SAP/jenkins-library/deployments","created_at":"2017-10-17T20:14:48Z","updated_at":"2017-11-22T09:45:36Z","pushed_at":"2017-12-01T09:55:14Z","git_url":"git://github.com/SAP/jenkins-library.git","ssh_url":"git@github.com:SAP/jenkins-library.git","clone_url":"https://github.com/SAP/jenkins-library.git","svn_url":"https://github.com/SAP/jenkins-library","homepage":null,"size":614,"stargazers_count":12,"watchers_count":12,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":9,"open_issues":10,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/16"},"html":{"href":"https://github.com/SAP/jenkins-library/pull/16"},"issue":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/16"},"comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SAP/jenkins-library/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/SAP/jenkins-library/statuses/06e5a72f87ac1ea4c4cba970ba63ac842b853002"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marcusholl"}}