{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tipb/pulls/comments/155458561","pull_request_review_id":81778659,"id":155458561,"diff_hunk":"@@ -130,3 +130,18 @@ message DAGRequest {\n \t// It represents which columns we should output.\n \trepeated uint32 output_offsets = 5;\n }\n+\n+enum EncodeType {\n+        TypeDefault = 0;\n+        TypeArrow = 1;\n+}\n+\n+message StreamResponse {\n+    optional Error error = 1;\n+    optional EncodeType encode_type=2;\n+\t//Data for all rows\n+    optional bytes data = 3 [(gogoproto.customtype) = \"github.com/pingcap/tipb/sharedbytes.SharedBytes\", (gogoproto.nullable) = false];\n+\trepeated Error warnings = 4;","path":"proto/select.proto","position":15,"original_position":15,"commit_id":"0df4e7adf9361094ebd3a163a93614c815b33aef","original_commit_id":"0df4e7adf9361094ebd3a163a93614c815b33aef","user":{"login":"coocood","id":891222,"avatar_url":"https://avatars0.githubusercontent.com/u/891222?v=4","gravatar_id":"","url":"https://api.github.com/users/coocood","html_url":"https://github.com/coocood","followers_url":"https://api.github.com/users/coocood/followers","following_url":"https://api.github.com/users/coocood/following{/other_user}","gists_url":"https://api.github.com/users/coocood/gists{/gist_id}","starred_url":"https://api.github.com/users/coocood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coocood/subscriptions","organizations_url":"https://api.github.com/users/coocood/orgs","repos_url":"https://api.github.com/users/coocood/repos","events_url":"https://api.github.com/users/coocood/events{/privacy}","received_events_url":"https://api.github.com/users/coocood/received_events","type":"User","site_admin":false},"body":"alignment","created_at":"2017-12-07T08:42:48Z","updated_at":"2017-12-07T08:42:48Z","html_url":"https://github.com/pingcap/tipb/pull/71#discussion_r155458561","pull_request_url":"https://api.github.com/repos/pingcap/tipb/pulls/71","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tipb/pulls/comments/155458561"},"html":{"href":"https://github.com/pingcap/tipb/pull/71#discussion_r155458561"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tipb/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tipb/pulls/71","id":156930008,"html_url":"https://github.com/pingcap/tipb/pull/71","diff_url":"https://github.com/pingcap/tipb/pull/71.diff","patch_url":"https://github.com/pingcap/tipb/pull/71.patch","issue_url":"https://api.github.com/repos/pingcap/tipb/issues/71","number":71,"state":"open","locked":false,"title":"proto/select.proto:init ResponseStream","user":{"login":"AndreMouche","id":1085697,"avatar_url":"https://avatars1.githubusercontent.com/u/1085697?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreMouche","html_url":"https://github.com/AndreMouche","followers_url":"https://api.github.com/users/AndreMouche/followers","following_url":"https://api.github.com/users/AndreMouche/following{/other_user}","gists_url":"https://api.github.com/users/AndreMouche/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreMouche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreMouche/subscriptions","organizations_url":"https://api.github.com/users/AndreMouche/orgs","repos_url":"https://api.github.com/users/AndreMouche/repos","events_url":"https://api.github.com/users/AndreMouche/events{/privacy}","received_events_url":"https://api.github.com/users/AndreMouche/received_events","type":"User","site_admin":false},"body":"@hicqu @ilovesoup @tiancaiamao @coocood @BusyJay @lamxTyler PTAL","created_at":"2017-12-07T08:20:13Z","updated_at":"2017-12-07T08:42:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"966f8a642c22ebc946d76757ed1fce4184f48e65","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tipb/pulls/71/commits","review_comments_url":"https://api.github.com/repos/pingcap/tipb/pulls/71/comments","review_comment_url":"https://api.github.com/repos/pingcap/tipb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tipb/issues/71/comments","statuses_url":"https://api.github.com/repos/pingcap/tipb/statuses/0df4e7adf9361094ebd3a163a93614c815b33aef","head":{"label":"pingcap:shirly/select_stream","ref":"shirly/select_stream","sha":"0df4e7adf9361094ebd3a163a93614c815b33aef","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53292445,"name":"tipb","full_name":"pingcap/tipb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tipb","description":"TiDB protobuf","fork":false,"url":"https://api.github.com/repos/pingcap/tipb","forks_url":"https://api.github.com/repos/pingcap/tipb/forks","keys_url":"https://api.github.com/repos/pingcap/tipb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tipb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tipb/teams","hooks_url":"https://api.github.com/repos/pingcap/tipb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tipb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tipb/events","assignees_url":"https://api.github.com/repos/pingcap/tipb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tipb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tipb/tags","blobs_url":"https://api.github.com/repos/pingcap/tipb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tipb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tipb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tipb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tipb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tipb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tipb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tipb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tipb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tipb/subscription","commits_url":"https://api.github.com/repos/pingcap/tipb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tipb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tipb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tipb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tipb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tipb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tipb/merges","archive_url":"https://api.github.com/repos/pingcap/tipb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tipb/downloads","issues_url":"https://api.github.com/repos/pingcap/tipb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tipb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tipb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tipb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tipb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tipb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tipb/deployments","created_at":"2016-03-07T03:18:24Z","updated_at":"2017-11-22T02:29:26Z","pushed_at":"2017-12-07T08:32:35Z","git_url":"git://github.com/pingcap/tipb.git","ssh_url":"git@github.com:pingcap/tipb.git","clone_url":"https://github.com/pingcap/tipb.git","svn_url":"https://github.com/pingcap/tipb","homepage":null,"size":1256,"stargazers_count":10,"watchers_count":10,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":9,"open_issues":5,"watchers":10,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"fb8adda809581506ba05dab6e305b04b4365f649","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53292445,"name":"tipb","full_name":"pingcap/tipb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tipb","description":"TiDB protobuf","fork":false,"url":"https://api.github.com/repos/pingcap/tipb","forks_url":"https://api.github.com/repos/pingcap/tipb/forks","keys_url":"https://api.github.com/repos/pingcap/tipb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tipb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tipb/teams","hooks_url":"https://api.github.com/repos/pingcap/tipb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tipb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tipb/events","assignees_url":"https://api.github.com/repos/pingcap/tipb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tipb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tipb/tags","blobs_url":"https://api.github.com/repos/pingcap/tipb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tipb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tipb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tipb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tipb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tipb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tipb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tipb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tipb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tipb/subscription","commits_url":"https://api.github.com/repos/pingcap/tipb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tipb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tipb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tipb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tipb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tipb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tipb/merges","archive_url":"https://api.github.com/repos/pingcap/tipb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tipb/downloads","issues_url":"https://api.github.com/repos/pingcap/tipb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tipb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tipb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tipb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tipb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tipb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tipb/deployments","created_at":"2016-03-07T03:18:24Z","updated_at":"2017-11-22T02:29:26Z","pushed_at":"2017-12-07T08:32:35Z","git_url":"git://github.com/pingcap/tipb.git","ssh_url":"git@github.com:pingcap/tipb.git","clone_url":"https://github.com/pingcap/tipb.git","svn_url":"https://github.com/pingcap/tipb","homepage":null,"size":1256,"stargazers_count":10,"watchers_count":10,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":9,"open_issues":5,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tipb/pulls/71"},"html":{"href":"https://github.com/pingcap/tipb/pull/71"},"issue":{"href":"https://api.github.com/repos/pingcap/tipb/issues/71"},"comments":{"href":"https://api.github.com/repos/pingcap/tipb/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tipb/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tipb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tipb/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tipb/statuses/0df4e7adf9361094ebd3a163a93614c815b33aef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"coocood"}}