{"action":"created","comment":{"url":"https://api.github.com/repos/TopChef/TopChef/pulls/comments/133611546","pull_request_review_id":56812625,"id":133611546,"diff_hunk":"@@ -64,33 +65,94 @@ class TestPatch(TestJobDetail):\n \n     @given(\n         jobs(),\n-        sampled_from(Job.JobStatus),\n-        dictionaries(text(), text())\n+        sampled_from(Job.JobStatus)\n     )\n-    def test_patch_happy_path(\n-            self, job: Job, status: Job.JobStatus, results: dict\n+    def test_patch_set_status(\n+            self, job: Job, status: Job.JobStatus\n     ) -> None:\n         \"\"\"\n \n         :param job: The randomly-generated job to modify\n         :param status: The randomly-generated status to set\n         \"\"\"\n         request_body = {\n-            'status': self._JOB_STATUS_LOOKUP[status],\n-            'results': results\n+            'status': self._JOB_STATUS_LOOKUP[status]\n         }\n         self.request.get_json = mock.MagicMock(return_value=request_body)\n         endpoint = JobDetail(self.session, flask_request=self.request)\n         response = endpoint.patch(job)\n         self.assertEqual(200, response.status_code)\n         self.assertEqual(job.status, status)\n-        self.assertEqual(job.results, results)\n \n     @given(\n         jobs(),\n         dictionaries(text(), text())\n     )\n-    def test_patch_error(self, job: Job, bad_results: dict) -> None:\n+    def test_patch_set_results_schema_matches(\n+            self,\n+            job: Job,\n+            new_results: dict\n+    ) -> None:\n+        \"\"\"\n+        Tests that the results can be set correctly if they pass JSON schema\n+        validation","path":"tests/unit/test_api/test_job_detail.py","position":49,"original_position":49,"commit_id":"441fe78ead1f6bf257d205fc058384e27985ed82","original_commit_id":"441fe78ead1f6bf257d205fc058384e27985ed82","user":{"login":"MichalKononenko","id":8391612,"avatar_url":"https://avatars3.githubusercontent.com/u/8391612?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalKononenko","html_url":"https://github.com/MichalKononenko","followers_url":"https://api.github.com/users/MichalKononenko/followers","following_url":"https://api.github.com/users/MichalKononenko/following{/other_user}","gists_url":"https://api.github.com/users/MichalKononenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalKononenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalKononenko/subscriptions","organizations_url":"https://api.github.com/users/MichalKononenko/orgs","repos_url":"https://api.github.com/users/MichalKononenko/repos","events_url":"https://api.github.com/users/MichalKononenko/events{/privacy}","received_events_url":"https://api.github.com/users/MichalKononenko/received_events","type":"User","site_admin":false},"body":"Document the parameters here","created_at":"2017-08-17T02:33:30Z","updated_at":"2017-08-17T02:33:31Z","html_url":"https://github.com/TopChef/TopChef/pull/131#discussion_r133611546","pull_request_url":"https://api.github.com/repos/TopChef/TopChef/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/TopChef/TopChef/pulls/comments/133611546"},"html":{"href":"https://github.com/TopChef/TopChef/pull/131#discussion_r133611546"},"pull_request":{"href":"https://api.github.com/repos/TopChef/TopChef/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/TopChef/TopChef/pulls/131","id":136143117,"html_url":"https://github.com/TopChef/TopChef/pull/131","diff_url":"https://github.com/TopChef/TopChef/pull/131.diff","patch_url":"https://github.com/TopChef/TopChef/pull/131.patch","issue_url":"https://api.github.com/repos/TopChef/TopChef/issues/131","number":131,"state":"open","locked":false,"title":"Json schema validation","user":{"login":"MichalKononenko","id":8391612,"avatar_url":"https://avatars3.githubusercontent.com/u/8391612?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalKononenko","html_url":"https://github.com/MichalKononenko","followers_url":"https://api.github.com/users/MichalKononenko/followers","following_url":"https://api.github.com/users/MichalKononenko/following{/other_user}","gists_url":"https://api.github.com/users/MichalKononenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalKononenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalKononenko/subscriptions","organizations_url":"https://api.github.com/users/MichalKononenko/orgs","repos_url":"https://api.github.com/users/MichalKononenko/repos","events_url":"https://api.github.com/users/MichalKononenko/events{/privacy}","received_events_url":"https://api.github.com/users/MichalKononenko/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-16T23:18:46Z","updated_at":"2017-08-17T02:33:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"356b4bb1bf6e683740185826c8af8826a2ffd2a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TopChef/TopChef/pulls/131/commits","review_comments_url":"https://api.github.com/repos/TopChef/TopChef/pulls/131/comments","review_comment_url":"https://api.github.com/repos/TopChef/TopChef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TopChef/TopChef/issues/131/comments","statuses_url":"https://api.github.com/repos/TopChef/TopChef/statuses/441fe78ead1f6bf257d205fc058384e27985ed82","head":{"label":"TopChef:JSONSchemaValidation","ref":"JSONSchemaValidation","sha":"441fe78ead1f6bf257d205fc058384e27985ed82","user":{"login":"TopChef","id":21366868,"avatar_url":"https://avatars2.githubusercontent.com/u/21366868?v=4","gravatar_id":"","url":"https://api.github.com/users/TopChef","html_url":"https://github.com/TopChef","followers_url":"https://api.github.com/users/TopChef/followers","following_url":"https://api.github.com/users/TopChef/following{/other_user}","gists_url":"https://api.github.com/users/TopChef/gists{/gist_id}","starred_url":"https://api.github.com/users/TopChef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TopChef/subscriptions","organizations_url":"https://api.github.com/users/TopChef/orgs","repos_url":"https://api.github.com/users/TopChef/repos","events_url":"https://api.github.com/users/TopChef/events{/privacy}","received_events_url":"https://api.github.com/users/TopChef/received_events","type":"Organization","site_admin":false},"repo":{"id":57226569,"name":"TopChef","full_name":"TopChef/TopChef","owner":{"login":"TopChef","id":21366868,"avatar_url":"https://avatars2.githubusercontent.com/u/21366868?v=4","gravatar_id":"","url":"https://api.github.com/users/TopChef","html_url":"https://github.com/TopChef","followers_url":"https://api.github.com/users/TopChef/followers","following_url":"https://api.github.com/users/TopChef/following{/other_user}","gists_url":"https://api.github.com/users/TopChef/gists{/gist_id}","starred_url":"https://api.github.com/users/TopChef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TopChef/subscriptions","organizations_url":"https://api.github.com/users/TopChef/orgs","repos_url":"https://api.github.com/users/TopChef/repos","events_url":"https://api.github.com/users/TopChef/events{/privacy}","received_events_url":"https://api.github.com/users/TopChef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TopChef/TopChef","description":"Client/Server code for connecting Bruker TopSpin Software to a job queue server. ","fork":false,"url":"https://api.github.com/repos/TopChef/TopChef","forks_url":"https://api.github.com/repos/TopChef/TopChef/forks","keys_url":"https://api.github.com/repos/TopChef/TopChef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TopChef/TopChef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TopChef/TopChef/teams","hooks_url":"https://api.github.com/repos/TopChef/TopChef/hooks","issue_events_url":"https://api.github.com/repos/TopChef/TopChef/issues/events{/number}","events_url":"https://api.github.com/repos/TopChef/TopChef/events","assignees_url":"https://api.github.com/repos/TopChef/TopChef/assignees{/user}","branches_url":"https://api.github.com/repos/TopChef/TopChef/branches{/branch}","tags_url":"https://api.github.com/repos/TopChef/TopChef/tags","blobs_url":"https://api.github.com/repos/TopChef/TopChef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TopChef/TopChef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TopChef/TopChef/git/refs{/sha}","trees_url":"https://api.github.com/repos/TopChef/TopChef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TopChef/TopChef/statuses/{sha}","languages_url":"https://api.github.com/repos/TopChef/TopChef/languages","stargazers_url":"https://api.github.com/repos/TopChef/TopChef/stargazers","contributors_url":"https://api.github.com/repos/TopChef/TopChef/contributors","subscribers_url":"https://api.github.com/repos/TopChef/TopChef/subscribers","subscription_url":"https://api.github.com/repos/TopChef/TopChef/subscription","commits_url":"https://api.github.com/repos/TopChef/TopChef/commits{/sha}","git_commits_url":"https://api.github.com/repos/TopChef/TopChef/git/commits{/sha}","comments_url":"https://api.github.com/repos/TopChef/TopChef/comments{/number}","issue_comment_url":"https://api.github.com/repos/TopChef/TopChef/issues/comments{/number}","contents_url":"https://api.github.com/repos/TopChef/TopChef/contents/{+path}","compare_url":"https://api.github.com/repos/TopChef/TopChef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TopChef/TopChef/merges","archive_url":"https://api.github.com/repos/TopChef/TopChef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TopChef/TopChef/downloads","issues_url":"https://api.github.com/repos/TopChef/TopChef/issues{/number}","pulls_url":"https://api.github.com/repos/TopChef/TopChef/pulls{/number}","milestones_url":"https://api.github.com/repos/TopChef/TopChef/milestones{/number}","notifications_url":"https://api.github.com/repos/TopChef/TopChef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TopChef/TopChef/labels{/name}","releases_url":"https://api.github.com/repos/TopChef/TopChef/releases{/id}","deployments_url":"https://api.github.com/repos/TopChef/TopChef/deployments","created_at":"2016-04-27T15:57:41Z","updated_at":"2017-05-25T03:22:49Z","pushed_at":"2017-08-16T23:18:46Z","git_url":"git://github.com/TopChef/TopChef.git","ssh_url":"git@github.com:TopChef/TopChef.git","clone_url":"https://github.com/TopChef/TopChef.git","svn_url":"https://github.com/TopChef/TopChef","homepage":null,"size":554,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":26,"forks":2,"open_issues":26,"watchers":2,"default_branch":"master"}},"base":{"label":"TopChef:0.2-overhaul","ref":"0.2-overhaul","sha":"192d03f03ba1b11366ee573321b208f95b9377f2","user":{"login":"TopChef","id":21366868,"avatar_url":"https://avatars2.githubusercontent.com/u/21366868?v=4","gravatar_id":"","url":"https://api.github.com/users/TopChef","html_url":"https://github.com/TopChef","followers_url":"https://api.github.com/users/TopChef/followers","following_url":"https://api.github.com/users/TopChef/following{/other_user}","gists_url":"https://api.github.com/users/TopChef/gists{/gist_id}","starred_url":"https://api.github.com/users/TopChef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TopChef/subscriptions","organizations_url":"https://api.github.com/users/TopChef/orgs","repos_url":"https://api.github.com/users/TopChef/repos","events_url":"https://api.github.com/users/TopChef/events{/privacy}","received_events_url":"https://api.github.com/users/TopChef/received_events","type":"Organization","site_admin":false},"repo":{"id":57226569,"name":"TopChef","full_name":"TopChef/TopChef","owner":{"login":"TopChef","id":21366868,"avatar_url":"https://avatars2.githubusercontent.com/u/21366868?v=4","gravatar_id":"","url":"https://api.github.com/users/TopChef","html_url":"https://github.com/TopChef","followers_url":"https://api.github.com/users/TopChef/followers","following_url":"https://api.github.com/users/TopChef/following{/other_user}","gists_url":"https://api.github.com/users/TopChef/gists{/gist_id}","starred_url":"https://api.github.com/users/TopChef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TopChef/subscriptions","organizations_url":"https://api.github.com/users/TopChef/orgs","repos_url":"https://api.github.com/users/TopChef/repos","events_url":"https://api.github.com/users/TopChef/events{/privacy}","received_events_url":"https://api.github.com/users/TopChef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TopChef/TopChef","description":"Client/Server code for connecting Bruker TopSpin Software to a job queue server. ","fork":false,"url":"https://api.github.com/repos/TopChef/TopChef","forks_url":"https://api.github.com/repos/TopChef/TopChef/forks","keys_url":"https://api.github.com/repos/TopChef/TopChef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TopChef/TopChef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TopChef/TopChef/teams","hooks_url":"https://api.github.com/repos/TopChef/TopChef/hooks","issue_events_url":"https://api.github.com/repos/TopChef/TopChef/issues/events{/number}","events_url":"https://api.github.com/repos/TopChef/TopChef/events","assignees_url":"https://api.github.com/repos/TopChef/TopChef/assignees{/user}","branches_url":"https://api.github.com/repos/TopChef/TopChef/branches{/branch}","tags_url":"https://api.github.com/repos/TopChef/TopChef/tags","blobs_url":"https://api.github.com/repos/TopChef/TopChef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TopChef/TopChef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TopChef/TopChef/git/refs{/sha}","trees_url":"https://api.github.com/repos/TopChef/TopChef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TopChef/TopChef/statuses/{sha}","languages_url":"https://api.github.com/repos/TopChef/TopChef/languages","stargazers_url":"https://api.github.com/repos/TopChef/TopChef/stargazers","contributors_url":"https://api.github.com/repos/TopChef/TopChef/contributors","subscribers_url":"https://api.github.com/repos/TopChef/TopChef/subscribers","subscription_url":"https://api.github.com/repos/TopChef/TopChef/subscription","commits_url":"https://api.github.com/repos/TopChef/TopChef/commits{/sha}","git_commits_url":"https://api.github.com/repos/TopChef/TopChef/git/commits{/sha}","comments_url":"https://api.github.com/repos/TopChef/TopChef/comments{/number}","issue_comment_url":"https://api.github.com/repos/TopChef/TopChef/issues/comments{/number}","contents_url":"https://api.github.com/repos/TopChef/TopChef/contents/{+path}","compare_url":"https://api.github.com/repos/TopChef/TopChef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TopChef/TopChef/merges","archive_url":"https://api.github.com/repos/TopChef/TopChef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TopChef/TopChef/downloads","issues_url":"https://api.github.com/repos/TopChef/TopChef/issues{/number}","pulls_url":"https://api.github.com/repos/TopChef/TopChef/pulls{/number}","milestones_url":"https://api.github.com/repos/TopChef/TopChef/milestones{/number}","notifications_url":"https://api.github.com/repos/TopChef/TopChef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TopChef/TopChef/labels{/name}","releases_url":"https://api.github.com/repos/TopChef/TopChef/releases{/id}","deployments_url":"https://api.github.com/repos/TopChef/TopChef/deployments","created_at":"2016-04-27T15:57:41Z","updated_at":"2017-05-25T03:22:49Z","pushed_at":"2017-08-16T23:18:46Z","git_url":"git://github.com/TopChef/TopChef.git","ssh_url":"git@github.com:TopChef/TopChef.git","clone_url":"https://github.com/TopChef/TopChef.git","svn_url":"https://github.com/TopChef/TopChef","homepage":null,"size":554,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":26,"forks":2,"open_issues":26,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TopChef/TopChef/pulls/131"},"html":{"href":"https://github.com/TopChef/TopChef/pull/131"},"issue":{"href":"https://api.github.com/repos/TopChef/TopChef/issues/131"},"comments":{"href":"https://api.github.com/repos/TopChef/TopChef/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/TopChef/TopChef/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/TopChef/TopChef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TopChef/TopChef/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/TopChef/TopChef/statuses/441fe78ead1f6bf257d205fc058384e27985ed82"}}}}
{"actor":{"display_login":"MichalKononenko"}}