{"action":"created","issue":{"url":"https://api.github.com/repos/dependents/node-sass-lookup/issues/2","repository_url":"https://api.github.com/repos/dependents/node-sass-lookup","labels_url":"https://api.github.com/repos/dependents/node-sass-lookup/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/dependents/node-sass-lookup/issues/2/comments","events_url":"https://api.github.com/repos/dependents/node-sass-lookup/issues/2/events","html_url":"https://github.com/dependents/node-sass-lookup/pull/2","id":251532643,"number":2,"title":"Update directory handling (check partials and allow multiple director…","user":{"login":"alreece45","id":464982,"avatar_url":"https://avatars3.githubusercontent.com/u/464982?v=4","gravatar_id":"","url":"https://api.github.com/users/alreece45","html_url":"https://github.com/alreece45","followers_url":"https://api.github.com/users/alreece45/followers","following_url":"https://api.github.com/users/alreece45/following{/other_user}","gists_url":"https://api.github.com/users/alreece45/gists{/gist_id}","starred_url":"https://api.github.com/users/alreece45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alreece45/subscriptions","organizations_url":"https://api.github.com/users/alreece45/orgs","repos_url":"https://api.github.com/users/alreece45/repos","events_url":"https://api.github.com/users/alreece45/events{/privacy}","received_events_url":"https://api.github.com/users/alreece45/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-21T02:04:36Z","updated_at":"2017-08-23T23:54:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dependents/node-sass-lookup/pulls/2","html_url":"https://github.com/dependents/node-sass-lookup/pull/2","diff_url":"https://github.com/dependents/node-sass-lookup/pull/2.diff","patch_url":"https://github.com/dependents/node-sass-lookup/pull/2.patch"},"body":"Currently, the only directory checked for partials is the directory of `filename`, `directory` is not checked for partials.\r\n\r\nThis pull request checks `directory` and will also check multiple directories (if its not a string).\r\n\r\nThe function returned a value, even when a file couldn't be found-- so this function does the same, but only if `directory` is a string.\r\n\r\nThe patch and the testing could probably use some work. Critique welcome."},"comment":{"url":"https://api.github.com/repos/dependents/node-sass-lookup/issues/comments/324494279","html_url":"https://github.com/dependents/node-sass-lookup/pull/2#issuecomment-324494279","issue_url":"https://api.github.com/repos/dependents/node-sass-lookup/issues/2","id":324494279,"user":{"login":"alreece45","id":464982,"avatar_url":"https://avatars3.githubusercontent.com/u/464982?v=4","gravatar_id":"","url":"https://api.github.com/users/alreece45","html_url":"https://github.com/alreece45","followers_url":"https://api.github.com/users/alreece45/followers","following_url":"https://api.github.com/users/alreece45/following{/other_user}","gists_url":"https://api.github.com/users/alreece45/gists{/gist_id}","starred_url":"https://api.github.com/users/alreece45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alreece45/subscriptions","organizations_url":"https://api.github.com/users/alreece45/orgs","repos_url":"https://api.github.com/users/alreece45/repos","events_url":"https://api.github.com/users/alreece45/events{/privacy}","received_events_url":"https://api.github.com/users/alreece45/received_events","type":"User","site_admin":false},"created_at":"2017-08-23T23:54:56Z","updated_at":"2017-08-23T23:54:56Z","body":"I don't know of a spec on @import behavior, but it seems to match the behavior of both `sass` and `libsass`\r\n\r\nOther notes on their import behavior:\r\n * Ambiguities result in an error ([libsass](https://github.com/sass/libsass/blob/5a7dbc80a9f6b8062006b758d05bb302a695cc1f/src/context.cpp#L345), and [sass](https://github.com/sass/sass/blob/stable/lib/sass/importers/filesystem.rb#L169))\r\n * They check more than one extension (both check `scss` and `sass`, libsass also checks .css)\r\n\r\nAs far as their import behavior:\r\n\r\n`sass` [appears to](https://github.com/sass/sass/blob/f31605339b4f4dd3098b010186db481b7563a634/lib/sass/engine.rb#L199) create a importer for each path, [asks](https://github.com/sass/sass/blob/7716e67f3507c6f65878c69aa49ec358ebf675c7/lib/sass/tree/import_node.rb#L44) each importer to find<sup>[[1]](https://github.com/sass/sass/blob/f31605339b4f4dd3098b010186db481b7563a634/lib/sass/importers/filesystem.rb#L26)[[2]](https://github.com/sass/sass/blob/f31605339b4f4dd3098b010186db481b7563a634/lib/sass/importers/filesystem.rb#L203)</sup> a path, which ends up using [`possible_paths()`](https://github.com/sass/sass/blob/3.5.1/lib/sass/importers/filesystem.rb#L119)\r\n\r\n`libsass's` parser's appears to call [`Sass::Parser::parse_imports()`](https://github.com/sass/libsass/blob/2148c56a42aedb63ab7637c19dc297f1002a4fa0/src/parser.cpp#L313). When not using a standard importer, it appears to call `import_url`, which calls [`Sass::Context::load_import`](https://github.com/sass/libsass/blob/5a7dbc80a9f6b8062006b758d05bb302a695cc1f/src/context.cpp#L337). `find_include()` is run for each path,.ends up at [`Sass::File::resolve_includes`](https://github.com/sass/libsass/blob/4869c0fb3abeb4697959a415ccc2fc6aec290378/src/file.cpp#L305)-- which attempts to load partials."}}
{"actor":{"display_login":"alreece45"}}