{"action":"created","comment":{"url":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/comments/119569189","pull_request_review_id":41458825,"id":119569189,"diff_hunk":"@@ -1,50 +1,45 @@\n {\n   \"name\": \"react-page-visibility\",\n-  \"version\": \"0.0.2\",\n+  \"version\": \"1.0.0\",\n   \"description\": \"Declarative, nested, stateful, isomorphic page visibility for React\",\n   \"author\": \"Gilad Peleg <giladp007@gmail.com> (http://giladpeleg.com)\",\n   \"repository\": \"pgilad/react-page-visibility\",\n-  \"keywords\": \"react, components, visibility, page, higher-order, browser\",\n-  \"main\": \"index.js\",\n+  \"keywords\": \"react, components, visibility, page, higher-order, browser, react-component\",\n+  \"main\": \"dist/index.js\",\n+  \"module\": \"src/index.js\",\n   \"files\": [\n-    \"index.js\",\n-    \"visibility.js\"\n+    \"dist\",","path":"package.json","position":16,"original_position":16,"commit_id":"1c1579de5a3cfdd21a9483b1bffbce542b2dc7b9","original_commit_id":"1c1579de5a3cfdd21a9483b1bffbce542b2dc7b9","user":{"login":"jonathanchrisp","id":406799,"avatar_url":"https://avatars2.githubusercontent.com/u/406799?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanchrisp","html_url":"https://github.com/jonathanchrisp","followers_url":"https://api.github.com/users/jonathanchrisp/followers","following_url":"https://api.github.com/users/jonathanchrisp/following{/other_user}","gists_url":"https://api.github.com/users/jonathanchrisp/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanchrisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanchrisp/subscriptions","organizations_url":"https://api.github.com/users/jonathanchrisp/orgs","repos_url":"https://api.github.com/users/jonathanchrisp/repos","events_url":"https://api.github.com/users/jonathanchrisp/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanchrisp/received_events","type":"User","site_admin":false},"body":"This files property caught me out when publishing to npm, even if you have a `.npmignore` file defined it gets ignored and this takes precedence with no warning from npm. At least I learn't something new 😄 ","created_at":"2017-06-01T09:34:13Z","updated_at":"2017-06-01T09:51:03Z","html_url":"https://github.com/pgilad/react-page-visibility/pull/3#discussion_r119569189","pull_request_url":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/comments/119569189"},"html":{"href":"https://github.com/pgilad/react-page-visibility/pull/3#discussion_r119569189"},"pull_request":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/3","id":123006314,"html_url":"https://github.com/pgilad/react-page-visibility/pull/3","diff_url":"https://github.com/pgilad/react-page-visibility/pull/3.diff","patch_url":"https://github.com/pgilad/react-page-visibility/pull/3.patch","issue_url":"https://api.github.com/repos/pgilad/react-page-visibility/issues/3","number":3,"state":"open","locked":false,"title":"Refactor and create build for UMD","user":{"login":"pgilad","id":4533329,"avatar_url":"https://avatars3.githubusercontent.com/u/4533329?v=3","gravatar_id":"","url":"https://api.github.com/users/pgilad","html_url":"https://github.com/pgilad","followers_url":"https://api.github.com/users/pgilad/followers","following_url":"https://api.github.com/users/pgilad/following{/other_user}","gists_url":"https://api.github.com/users/pgilad/gists{/gist_id}","starred_url":"https://api.github.com/users/pgilad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgilad/subscriptions","organizations_url":"https://api.github.com/users/pgilad/orgs","repos_url":"https://api.github.com/users/pgilad/repos","events_url":"https://api.github.com/users/pgilad/events{/privacy}","received_events_url":"https://api.github.com/users/pgilad/received_events","type":"User","site_admin":false},"body":"Closes #2 \r\n\r\n- Build UMD when publishing\r\n- Keep prop-types (it has the NODE_ENV check inside)\r\n- Upgrade to latest react\r\n- Easier testing\r\n- Version 1.0.0\r\n\r\nHuge thanks to @jonathanchrisp for the huge contributions to this PR","created_at":"2017-05-30T09:26:37Z","updated_at":"2017-06-01T09:51:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1afb174902711d24747b8a2dbb69ddb90cbc5e0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/3/commits","review_comments_url":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/3/comments","review_comment_url":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pgilad/react-page-visibility/issues/3/comments","statuses_url":"https://api.github.com/repos/pgilad/react-page-visibility/statuses/1c1579de5a3cfdd21a9483b1bffbce542b2dc7b9","head":{"label":"pgilad:refactor/es5-module","ref":"refactor/es5-module","sha":"1c1579de5a3cfdd21a9483b1bffbce542b2dc7b9","user":{"login":"pgilad","id":4533329,"avatar_url":"https://avatars3.githubusercontent.com/u/4533329?v=3","gravatar_id":"","url":"https://api.github.com/users/pgilad","html_url":"https://github.com/pgilad","followers_url":"https://api.github.com/users/pgilad/followers","following_url":"https://api.github.com/users/pgilad/following{/other_user}","gists_url":"https://api.github.com/users/pgilad/gists{/gist_id}","starred_url":"https://api.github.com/users/pgilad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgilad/subscriptions","organizations_url":"https://api.github.com/users/pgilad/orgs","repos_url":"https://api.github.com/users/pgilad/repos","events_url":"https://api.github.com/users/pgilad/events{/privacy}","received_events_url":"https://api.github.com/users/pgilad/received_events","type":"User","site_admin":false},"repo":{"id":57594270,"name":"react-page-visibility","full_name":"pgilad/react-page-visibility","owner":{"login":"pgilad","id":4533329,"avatar_url":"https://avatars3.githubusercontent.com/u/4533329?v=3","gravatar_id":"","url":"https://api.github.com/users/pgilad","html_url":"https://github.com/pgilad","followers_url":"https://api.github.com/users/pgilad/followers","following_url":"https://api.github.com/users/pgilad/following{/other_user}","gists_url":"https://api.github.com/users/pgilad/gists{/gist_id}","starred_url":"https://api.github.com/users/pgilad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgilad/subscriptions","organizations_url":"https://api.github.com/users/pgilad/orgs","repos_url":"https://api.github.com/users/pgilad/repos","events_url":"https://api.github.com/users/pgilad/events{/privacy}","received_events_url":"https://api.github.com/users/pgilad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgilad/react-page-visibility","description":"Declarative, nested, stateful, isomorphic page visibility React component","fork":false,"url":"https://api.github.com/repos/pgilad/react-page-visibility","forks_url":"https://api.github.com/repos/pgilad/react-page-visibility/forks","keys_url":"https://api.github.com/repos/pgilad/react-page-visibility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgilad/react-page-visibility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgilad/react-page-visibility/teams","hooks_url":"https://api.github.com/repos/pgilad/react-page-visibility/hooks","issue_events_url":"https://api.github.com/repos/pgilad/react-page-visibility/issues/events{/number}","events_url":"https://api.github.com/repos/pgilad/react-page-visibility/events","assignees_url":"https://api.github.com/repos/pgilad/react-page-visibility/assignees{/user}","branches_url":"https://api.github.com/repos/pgilad/react-page-visibility/branches{/branch}","tags_url":"https://api.github.com/repos/pgilad/react-page-visibility/tags","blobs_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgilad/react-page-visibility/statuses/{sha}","languages_url":"https://api.github.com/repos/pgilad/react-page-visibility/languages","stargazers_url":"https://api.github.com/repos/pgilad/react-page-visibility/stargazers","contributors_url":"https://api.github.com/repos/pgilad/react-page-visibility/contributors","subscribers_url":"https://api.github.com/repos/pgilad/react-page-visibility/subscribers","subscription_url":"https://api.github.com/repos/pgilad/react-page-visibility/subscription","commits_url":"https://api.github.com/repos/pgilad/react-page-visibility/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgilad/react-page-visibility/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgilad/react-page-visibility/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgilad/react-page-visibility/contents/{+path}","compare_url":"https://api.github.com/repos/pgilad/react-page-visibility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgilad/react-page-visibility/merges","archive_url":"https://api.github.com/repos/pgilad/react-page-visibility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgilad/react-page-visibility/downloads","issues_url":"https://api.github.com/repos/pgilad/react-page-visibility/issues{/number}","pulls_url":"https://api.github.com/repos/pgilad/react-page-visibility/pulls{/number}","milestones_url":"https://api.github.com/repos/pgilad/react-page-visibility/milestones{/number}","notifications_url":"https://api.github.com/repos/pgilad/react-page-visibility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgilad/react-page-visibility/labels{/name}","releases_url":"https://api.github.com/repos/pgilad/react-page-visibility/releases{/id}","deployments_url":"https://api.github.com/repos/pgilad/react-page-visibility/deployments","created_at":"2016-05-01T10:29:52Z","updated_at":"2017-05-15T00:23:06Z","pushed_at":"2017-05-30T09:26:38Z","git_url":"git://github.com/pgilad/react-page-visibility.git","ssh_url":"git@github.com:pgilad/react-page-visibility.git","clone_url":"https://github.com/pgilad/react-page-visibility.git","svn_url":"https://github.com/pgilad/react-page-visibility","homepage":"","size":74,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":8,"default_branch":"master"}},"base":{"label":"pgilad:master","ref":"master","sha":"e9d855e88e573b039d32434235095545410a0f77","user":{"login":"pgilad","id":4533329,"avatar_url":"https://avatars3.githubusercontent.com/u/4533329?v=3","gravatar_id":"","url":"https://api.github.com/users/pgilad","html_url":"https://github.com/pgilad","followers_url":"https://api.github.com/users/pgilad/followers","following_url":"https://api.github.com/users/pgilad/following{/other_user}","gists_url":"https://api.github.com/users/pgilad/gists{/gist_id}","starred_url":"https://api.github.com/users/pgilad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgilad/subscriptions","organizations_url":"https://api.github.com/users/pgilad/orgs","repos_url":"https://api.github.com/users/pgilad/repos","events_url":"https://api.github.com/users/pgilad/events{/privacy}","received_events_url":"https://api.github.com/users/pgilad/received_events","type":"User","site_admin":false},"repo":{"id":57594270,"name":"react-page-visibility","full_name":"pgilad/react-page-visibility","owner":{"login":"pgilad","id":4533329,"avatar_url":"https://avatars3.githubusercontent.com/u/4533329?v=3","gravatar_id":"","url":"https://api.github.com/users/pgilad","html_url":"https://github.com/pgilad","followers_url":"https://api.github.com/users/pgilad/followers","following_url":"https://api.github.com/users/pgilad/following{/other_user}","gists_url":"https://api.github.com/users/pgilad/gists{/gist_id}","starred_url":"https://api.github.com/users/pgilad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgilad/subscriptions","organizations_url":"https://api.github.com/users/pgilad/orgs","repos_url":"https://api.github.com/users/pgilad/repos","events_url":"https://api.github.com/users/pgilad/events{/privacy}","received_events_url":"https://api.github.com/users/pgilad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgilad/react-page-visibility","description":"Declarative, nested, stateful, isomorphic page visibility React component","fork":false,"url":"https://api.github.com/repos/pgilad/react-page-visibility","forks_url":"https://api.github.com/repos/pgilad/react-page-visibility/forks","keys_url":"https://api.github.com/repos/pgilad/react-page-visibility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgilad/react-page-visibility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgilad/react-page-visibility/teams","hooks_url":"https://api.github.com/repos/pgilad/react-page-visibility/hooks","issue_events_url":"https://api.github.com/repos/pgilad/react-page-visibility/issues/events{/number}","events_url":"https://api.github.com/repos/pgilad/react-page-visibility/events","assignees_url":"https://api.github.com/repos/pgilad/react-page-visibility/assignees{/user}","branches_url":"https://api.github.com/repos/pgilad/react-page-visibility/branches{/branch}","tags_url":"https://api.github.com/repos/pgilad/react-page-visibility/tags","blobs_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgilad/react-page-visibility/statuses/{sha}","languages_url":"https://api.github.com/repos/pgilad/react-page-visibility/languages","stargazers_url":"https://api.github.com/repos/pgilad/react-page-visibility/stargazers","contributors_url":"https://api.github.com/repos/pgilad/react-page-visibility/contributors","subscribers_url":"https://api.github.com/repos/pgilad/react-page-visibility/subscribers","subscription_url":"https://api.github.com/repos/pgilad/react-page-visibility/subscription","commits_url":"https://api.github.com/repos/pgilad/react-page-visibility/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgilad/react-page-visibility/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgilad/react-page-visibility/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgilad/react-page-visibility/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgilad/react-page-visibility/contents/{+path}","compare_url":"https://api.github.com/repos/pgilad/react-page-visibility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgilad/react-page-visibility/merges","archive_url":"https://api.github.com/repos/pgilad/react-page-visibility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgilad/react-page-visibility/downloads","issues_url":"https://api.github.com/repos/pgilad/react-page-visibility/issues{/number}","pulls_url":"https://api.github.com/repos/pgilad/react-page-visibility/pulls{/number}","milestones_url":"https://api.github.com/repos/pgilad/react-page-visibility/milestones{/number}","notifications_url":"https://api.github.com/repos/pgilad/react-page-visibility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgilad/react-page-visibility/labels{/name}","releases_url":"https://api.github.com/repos/pgilad/react-page-visibility/releases{/id}","deployments_url":"https://api.github.com/repos/pgilad/react-page-visibility/deployments","created_at":"2016-05-01T10:29:52Z","updated_at":"2017-05-15T00:23:06Z","pushed_at":"2017-05-30T09:26:38Z","git_url":"git://github.com/pgilad/react-page-visibility.git","ssh_url":"git@github.com:pgilad/react-page-visibility.git","clone_url":"https://github.com/pgilad/react-page-visibility.git","svn_url":"https://github.com/pgilad/react-page-visibility","homepage":"","size":74,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/3"},"html":{"href":"https://github.com/pgilad/react-page-visibility/pull/3"},"issue":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/issues/3"},"comments":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/pgilad/react-page-visibility/statuses/1c1579de5a3cfdd21a9483b1bffbce542b2dc7b9"}}}}
{"actor":{"display_login":"jonathanchrisp"}}