{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments/133949063","pull_request_review_id":57189517,"id":133949063,"diff_hunk":"@@ -34,7 +35,8 @@\n \n public class MainApplication extends NavigationApplication implements INotificationsApplication {\n \n-  NotificationsLifecycleFacade notificationsLifecycleFacade;\n+  public static MainApplication instance;","path":"android/app/src/main/java/com/mattermost/rnbeta/MainApplication.java","position":20,"original_position":20,"commit_id":"d9354765f2861e3473069d46e5bc49d98b99e3d2","original_commit_id":"d9354765f2861e3473069d46e5bc49d98b99e3d2","user":{"login":"MusikPolice","id":1799952,"avatar_url":"https://avatars2.githubusercontent.com/u/1799952?v=4","gravatar_id":"","url":"https://api.github.com/users/MusikPolice","html_url":"https://github.com/MusikPolice","followers_url":"https://api.github.com/users/MusikPolice/followers","following_url":"https://api.github.com/users/MusikPolice/following{/other_user}","gists_url":"https://api.github.com/users/MusikPolice/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikPolice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikPolice/subscriptions","organizations_url":"https://api.github.com/users/MusikPolice/orgs","repos_url":"https://api.github.com/users/MusikPolice/repos","events_url":"https://api.github.com/users/MusikPolice/events{/privacy}","received_events_url":"https://api.github.com/users/MusikPolice/received_events","type":"User","site_admin":false},"body":"Not clear on the use of this static variable. It looks like you're trying to make `MainApplication` a singleton, but you aren't actually using it anywhere. You assign `this` to `instance` on line 70, but you don't use it on line 60, instead using `MainApplication.this`. \r\n\r\nI think you can probably remove `instance` altogether and just pass `this` on line 60.","created_at":"2017-08-18T12:41:40Z","updated_at":"2017-08-18T12:41:40Z","html_url":"https://github.com/mattermost/mattermost-mobile/pull/856#discussion_r133949063","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/856","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments/133949063"},"html":{"href":"https://github.com/mattermost/mattermost-mobile/pull/856#discussion_r133949063"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/856"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/856","id":136303686,"html_url":"https://github.com/mattermost/mattermost-mobile/pull/856","diff_url":"https://github.com/mattermost/mattermost-mobile/pull/856.diff","patch_url":"https://github.com/mattermost/mattermost-mobile/pull/856.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/856","number":856,"state":"open","locked":false,"title":"Appconfig support for iOS and Android","user":{"login":"enahum","id":6757047,"avatar_url":"https://avatars1.githubusercontent.com/u/6757047?v=4","gravatar_id":"","url":"https://api.github.com/users/enahum","html_url":"https://github.com/enahum","followers_url":"https://api.github.com/users/enahum/followers","following_url":"https://api.github.com/users/enahum/following{/other_user}","gists_url":"https://api.github.com/users/enahum/gists{/gist_id}","starred_url":"https://api.github.com/users/enahum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enahum/subscriptions","organizations_url":"https://api.github.com/users/enahum/orgs","repos_url":"https://api.github.com/users/enahum/repos","events_url":"https://api.github.com/users/enahum/events{/privacy}","received_events_url":"https://api.github.com/users/enahum/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nAdded support for AppConfig for iOS and Android so EMM providers can use it to configure the app.\r\n\r\nThe following is a list of the things that have been implemented\r\n\r\n| Key         | Description | Default Value | Type | iOS support | Android for work support |\r\n| --------  | ----------- | -------------  | ----- | -----------  | -------------------------  |\r\n| inAppPinCode | Locks the app so the user needs to validate as the owner of the phone, it will prompt for fingerprint or passcode | false | string | Yes | Yes |\r\n| blurApplicationScreen | Protects app on screen information while the app is in the background. On Android it also prevents taking screenshots from the app | false | string | Yes | Yes |\r\n| jailbreakDetection | Disable app launch on Jailbroken or rooted devices | false | string | Yes | Yes |\r\n| copyAndPasteProtection | Disables the ability to copy or paste from any input in the app | false | string | Yes | No |\r\n| serverUrl | The Mattermost server URL users will be connecting to | | string | Yes | Yes |\r\n| allowOtherServers | Allows the user to change the above server URL | true | string | Yes | Yes |\r\n| username | Set the username or email address to use to authenticate | | string | Yes | Yes |\r\n| vendor | Name of the EMM vendor or company deploying the app so the users are aware the app is being protected | Mattermost | string | Yes | Yes |\r\n\r\n#### Ticket Link\r\nhttps://mattermost.atlassian.net/browse/RN-287\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] Includes text changes and localization file updates\r\n\r\n#### Device Information\r\nThis PR was tested on: \r\n* iOS 10.3.2 iPhone 6s\r\n* Android 6.0.1 Samsung J5\r\n\r\n#### EMM providers\r\n* MobileIron\r\n* BlackBerry Dynamics\r\n* AirWatch (pending)","created_at":"2017-08-17T16:48:02Z","updated_at":"2017-08-18T12:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4915a8077e1d1757db4cba810527940090aec336","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hmhealey","id":3277310,"avatar_url":"https://avatars3.githubusercontent.com/u/3277310?v=4","gravatar_id":"","url":"https://api.github.com/users/hmhealey","html_url":"https://github.com/hmhealey","followers_url":"https://api.github.com/users/hmhealey/followers","following_url":"https://api.github.com/users/hmhealey/following{/other_user}","gists_url":"https://api.github.com/users/hmhealey/gists{/gist_id}","starred_url":"https://api.github.com/users/hmhealey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmhealey/subscriptions","organizations_url":"https://api.github.com/users/hmhealey/orgs","repos_url":"https://api.github.com/users/hmhealey/repos","events_url":"https://api.github.com/users/hmhealey/events{/privacy}","received_events_url":"https://api.github.com/users/hmhealey/received_events","type":"User","site_admin":false},{"login":"jarredwitt","id":5090577,"avatar_url":"https://avatars1.githubusercontent.com/u/5090577?v=4","gravatar_id":"","url":"https://api.github.com/users/jarredwitt","html_url":"https://github.com/jarredwitt","followers_url":"https://api.github.com/users/jarredwitt/followers","following_url":"https://api.github.com/users/jarredwitt/following{/other_user}","gists_url":"https://api.github.com/users/jarredwitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jarredwitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarredwitt/subscriptions","organizations_url":"https://api.github.com/users/jarredwitt/orgs","repos_url":"https://api.github.com/users/jarredwitt/repos","events_url":"https://api.github.com/users/jarredwitt/events{/privacy}","received_events_url":"https://api.github.com/users/jarredwitt/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones/2","html_url":"https://github.com/mattermost/mattermost-mobile/milestone/2","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones/2/labels","id":2671987,"number":2,"title":"1.2","description":"","creator":{"login":"enahum","id":6757047,"avatar_url":"https://avatars1.githubusercontent.com/u/6757047?v=4","gravatar_id":"","url":"https://api.github.com/users/enahum","html_url":"https://github.com/enahum","followers_url":"https://api.github.com/users/enahum/followers","following_url":"https://api.github.com/users/enahum/following{/other_user}","gists_url":"https://api.github.com/users/enahum/gists{/gist_id}","starred_url":"https://api.github.com/users/enahum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enahum/subscriptions","organizations_url":"https://api.github.com/users/enahum/orgs","repos_url":"https://api.github.com/users/enahum/repos","events_url":"https://api.github.com/users/enahum/events{/privacy}","received_events_url":"https://api.github.com/users/enahum/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":8,"state":"open","created_at":"2017-07-31T18:10:58Z","updated_at":"2017-08-18T01:44:18Z","due_on":"2017-09-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/856/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/856/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/856/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/d9354765f2861e3473069d46e5bc49d98b99e3d2","head":{"label":"mattermost:appconfig","ref":"appconfig","sha":"d9354765f2861e3473069d46e5bc49d98b99e3d2","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":70265724,"name":"mattermost-mobile","full_name":"mattermost/mattermost-mobile","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-mobile","description":"Next generation iOS and Android apps for Mattermost in React Native","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-mobile","forks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-mobile/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-mobile/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-mobile/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-mobile/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/deployments","created_at":"2016-10-07T16:52:32Z","updated_at":"2017-08-18T06:06:21Z","pushed_at":"2017-08-18T01:44:21Z","git_url":"git://github.com/mattermost/mattermost-mobile.git","ssh_url":"git@github.com:mattermost/mattermost-mobile.git","clone_url":"https://github.com/mattermost/mattermost-mobile.git","svn_url":"https://github.com/mattermost/mattermost-mobile","homepage":"https://about.mattermost.com/","size":6982,"stargazers_count":200,"watchers_count":200,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":36,"forks":52,"open_issues":36,"watchers":200,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"57c602eb7922e943f71edd073ef631582a6a7141","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":70265724,"name":"mattermost-mobile","full_name":"mattermost/mattermost-mobile","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-mobile","description":"Next generation iOS and Android apps for Mattermost in React Native","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-mobile","forks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-mobile/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-mobile/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-mobile/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-mobile/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-mobile/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-mobile/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-mobile/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-mobile/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-mobile/deployments","created_at":"2016-10-07T16:52:32Z","updated_at":"2017-08-18T06:06:21Z","pushed_at":"2017-08-18T01:44:21Z","git_url":"git://github.com/mattermost/mattermost-mobile.git","ssh_url":"git@github.com:mattermost/mattermost-mobile.git","clone_url":"https://github.com/mattermost/mattermost-mobile.git","svn_url":"https://github.com/mattermost/mattermost-mobile","homepage":"https://about.mattermost.com/","size":6982,"stargazers_count":200,"watchers_count":200,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":36,"forks":52,"open_issues":36,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/856"},"html":{"href":"https://github.com/mattermost/mattermost-mobile/pull/856"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/856"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/issues/856/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/856/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/pulls/856/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-mobile/statuses/d9354765f2861e3473069d46e5bc49d98b99e3d2"}}}}
{"actor":{"display_login":"MusikPolice"}}