{"action":"created","comment":{"url":"https://api.github.com/repos/SSSD/sssd/pulls/comments/96150110","pull_request_review_id":16725816,"id":96150110,"diff_hunk":"@@ -267,28 +353,24 @@ static int client_registration(struct sbus_request *dbus_req, void *data)\n           \"Received ID registration: (%s,%d)\\n\", svc_name, svc_ver);\n \n     /* search this service in the list */\n-    svc = mini->ctx->svc_list;\n-    while (svc) {\n-        ret = strcasecmp(svc->identity, svc_name);\n-        if (ret == 0) {\n-            break;\n+    ret = get_service_in_the_list(mini, svc_name, svc_type == MT_SVC_PROVIDER,\n+                                  &svc, &explicitly_configured);\n+    if (ret != EOK) {\n+        if (ret == ENOENT) {","path":"src/monitor/monitor.c","position":157,"original_position":128,"commit_id":"648175a12920d7239e7f790a0153e7af5cb48540","original_commit_id":"a78e66da75f678bd711960f2090111ad95a6e365","user":{"login":"fidencio","id":112762,"avatar_url":"https://avatars.githubusercontent.com/u/112762?v=3","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"body":"I do believe it must be called on any error. Fixed in tthe new series.","created_at":"2017-01-15T22:54:53Z","updated_at":"2017-01-15T22:54:53Z","html_url":"https://github.com/SSSD/sssd/pull/94#discussion_r96150110","pull_request_url":"https://api.github.com/repos/SSSD/sssd/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/comments/96150110"},"html":{"href":"https://github.com/SSSD/sssd/pull/94#discussion_r96150110"},"pull_request":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/SSSD/sssd/pulls/94","id":95233432,"html_url":"https://github.com/SSSD/sssd/pull/94","diff_url":"https://github.com/SSSD/sssd/pull/94.diff","patch_url":"https://github.com/SSSD/sssd/pull/94.patch","issue_url":"https://api.github.com/repos/SSSD/sssd/issues/94","number":94,"state":"open","locked":false,"title":"Enable {socket,dbus}-activation for responders","user":{"login":"fidencio","id":112762,"avatar_url":"https://avatars.githubusercontent.com/u/112762?v=3","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"body":"This series fixes [#2243](https://fedorahosted.org/sssd/ticket/2243), [#3129](https://fedorahosted.org/sssd/ticket/3129) and [#3245](https://fedorahosted.org/sssd/ticket/3245) following what was discussed in the [ML](https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/message/H6JOF5SGGSIJUIWYNANDA73ODHWBS7J2/) and summed up at [this](https://fedorahosted.org/sssd/wiki/DesignDocs/SocketActivatableResponders) design document.\r\n\r\nThe approach taken was the less intrusive possible and keeps the backward compatibility.\r\n\r\n[PR#84](https://github.com/SSSD/sssd/pull/84) was closed due to my lack of skills with github. :-\\","created_at":"2016-11-24T23:03:07Z","updated_at":"2017-01-15T22:54:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c23012e177762e6ac593d93c33edc384458b46cf","assignee":{"login":"pbrezina","id":18548882,"avatar_url":"https://avatars.githubusercontent.com/u/18548882?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrezina","html_url":"https://github.com/pbrezina","followers_url":"https://api.github.com/users/pbrezina/followers","following_url":"https://api.github.com/users/pbrezina/following{/other_user}","gists_url":"https://api.github.com/users/pbrezina/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrezina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrezina/subscriptions","organizations_url":"https://api.github.com/users/pbrezina/orgs","repos_url":"https://api.github.com/users/pbrezina/repos","events_url":"https://api.github.com/users/pbrezina/events{/privacy}","received_events_url":"https://api.github.com/users/pbrezina/received_events","type":"User","site_admin":false},"assignees":[{"login":"pbrezina","id":18548882,"avatar_url":"https://avatars.githubusercontent.com/u/18548882?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrezina","html_url":"https://github.com/pbrezina","followers_url":"https://api.github.com/users/pbrezina/followers","following_url":"https://api.github.com/users/pbrezina/following{/other_user}","gists_url":"https://api.github.com/users/pbrezina/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrezina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrezina/subscriptions","organizations_url":"https://api.github.com/users/pbrezina/orgs","repos_url":"https://api.github.com/users/pbrezina/repos","events_url":"https://api.github.com/users/pbrezina/events{/privacy}","received_events_url":"https://api.github.com/users/pbrezina/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SSSD/sssd/pulls/94/commits","review_comments_url":"https://api.github.com/repos/SSSD/sssd/pulls/94/comments","review_comment_url":"https://api.github.com/repos/SSSD/sssd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SSSD/sssd/issues/94/comments","statuses_url":"https://api.github.com/repos/SSSD/sssd/statuses/648175a12920d7239e7f790a0153e7af5cb48540","head":{"label":"fidencio:wip/socket_activation","ref":"wip/socket_activation","sha":"648175a12920d7239e7f790a0153e7af5cb48540","user":{"login":"fidencio","id":112762,"avatar_url":"https://avatars.githubusercontent.com/u/112762?v=3","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"repo":{"id":67102888,"name":"sssd","full_name":"fidencio/sssd","owner":{"login":"fidencio","id":112762,"avatar_url":"https://avatars.githubusercontent.com/u/112762?v=3","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fidencio/sssd","description":"A daemon to manage identity, authentication and authorization for centrally-managed systems.","fork":true,"url":"https://api.github.com/repos/fidencio/sssd","forks_url":"https://api.github.com/repos/fidencio/sssd/forks","keys_url":"https://api.github.com/repos/fidencio/sssd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fidencio/sssd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fidencio/sssd/teams","hooks_url":"https://api.github.com/repos/fidencio/sssd/hooks","issue_events_url":"https://api.github.com/repos/fidencio/sssd/issues/events{/number}","events_url":"https://api.github.com/repos/fidencio/sssd/events","assignees_url":"https://api.github.com/repos/fidencio/sssd/assignees{/user}","branches_url":"https://api.github.com/repos/fidencio/sssd/branches{/branch}","tags_url":"https://api.github.com/repos/fidencio/sssd/tags","blobs_url":"https://api.github.com/repos/fidencio/sssd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fidencio/sssd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fidencio/sssd/git/refs{/sha}","trees_url":"https://api.github.com/repos/fidencio/sssd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fidencio/sssd/statuses/{sha}","languages_url":"https://api.github.com/repos/fidencio/sssd/languages","stargazers_url":"https://api.github.com/repos/fidencio/sssd/stargazers","contributors_url":"https://api.github.com/repos/fidencio/sssd/contributors","subscribers_url":"https://api.github.com/repos/fidencio/sssd/subscribers","subscription_url":"https://api.github.com/repos/fidencio/sssd/subscription","commits_url":"https://api.github.com/repos/fidencio/sssd/commits{/sha}","git_commits_url":"https://api.github.com/repos/fidencio/sssd/git/commits{/sha}","comments_url":"https://api.github.com/repos/fidencio/sssd/comments{/number}","issue_comment_url":"https://api.github.com/repos/fidencio/sssd/issues/comments{/number}","contents_url":"https://api.github.com/repos/fidencio/sssd/contents/{+path}","compare_url":"https://api.github.com/repos/fidencio/sssd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fidencio/sssd/merges","archive_url":"https://api.github.com/repos/fidencio/sssd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fidencio/sssd/downloads","issues_url":"https://api.github.com/repos/fidencio/sssd/issues{/number}","pulls_url":"https://api.github.com/repos/fidencio/sssd/pulls{/number}","milestones_url":"https://api.github.com/repos/fidencio/sssd/milestones{/number}","notifications_url":"https://api.github.com/repos/fidencio/sssd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fidencio/sssd/labels{/name}","releases_url":"https://api.github.com/repos/fidencio/sssd/releases{/id}","deployments_url":"https://api.github.com/repos/fidencio/sssd/deployments","created_at":"2016-09-01T06:05:21Z","updated_at":"2016-09-01T06:05:26Z","pushed_at":"2017-01-12T11:06:52Z","git_url":"git://github.com/fidencio/sssd.git","ssh_url":"git@github.com:fidencio/sssd.git","clone_url":"https://github.com/fidencio/sssd.git","svn_url":"https://github.com/fidencio/sssd","homepage":"https://fedorahosted.org/sssd","size":32880,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SSSD:master","ref":"master","sha":"1a71eeb4d71f7f6d63edb4298d69b35a94edc020","user":{"login":"SSSD","id":12898906,"avatar_url":"https://avatars.githubusercontent.com/u/12898906?v=3","gravatar_id":"","url":"https://api.github.com/users/SSSD","html_url":"https://github.com/SSSD","followers_url":"https://api.github.com/users/SSSD/followers","following_url":"https://api.github.com/users/SSSD/following{/other_user}","gists_url":"https://api.github.com/users/SSSD/gists{/gist_id}","starred_url":"https://api.github.com/users/SSSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSSD/subscriptions","organizations_url":"https://api.github.com/users/SSSD/orgs","repos_url":"https://api.github.com/users/SSSD/repos","events_url":"https://api.github.com/users/SSSD/events{/privacy}","received_events_url":"https://api.github.com/users/SSSD/received_events","type":"Organization","site_admin":false},"repo":{"id":37479167,"name":"sssd","full_name":"SSSD/sssd","owner":{"login":"SSSD","id":12898906,"avatar_url":"https://avatars.githubusercontent.com/u/12898906?v=3","gravatar_id":"","url":"https://api.github.com/users/SSSD","html_url":"https://github.com/SSSD","followers_url":"https://api.github.com/users/SSSD/followers","following_url":"https://api.github.com/users/SSSD/following{/other_user}","gists_url":"https://api.github.com/users/SSSD/gists{/gist_id}","starred_url":"https://api.github.com/users/SSSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSSD/subscriptions","organizations_url":"https://api.github.com/users/SSSD/orgs","repos_url":"https://api.github.com/users/SSSD/repos","events_url":"https://api.github.com/users/SSSD/events{/privacy}","received_events_url":"https://api.github.com/users/SSSD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SSSD/sssd","description":"A daemon to manage identity, authentication and authorization for centrally-managed systems.","fork":false,"url":"https://api.github.com/repos/SSSD/sssd","forks_url":"https://api.github.com/repos/SSSD/sssd/forks","keys_url":"https://api.github.com/repos/SSSD/sssd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SSSD/sssd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SSSD/sssd/teams","hooks_url":"https://api.github.com/repos/SSSD/sssd/hooks","issue_events_url":"https://api.github.com/repos/SSSD/sssd/issues/events{/number}","events_url":"https://api.github.com/repos/SSSD/sssd/events","assignees_url":"https://api.github.com/repos/SSSD/sssd/assignees{/user}","branches_url":"https://api.github.com/repos/SSSD/sssd/branches{/branch}","tags_url":"https://api.github.com/repos/SSSD/sssd/tags","blobs_url":"https://api.github.com/repos/SSSD/sssd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SSSD/sssd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SSSD/sssd/git/refs{/sha}","trees_url":"https://api.github.com/repos/SSSD/sssd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SSSD/sssd/statuses/{sha}","languages_url":"https://api.github.com/repos/SSSD/sssd/languages","stargazers_url":"https://api.github.com/repos/SSSD/sssd/stargazers","contributors_url":"https://api.github.com/repos/SSSD/sssd/contributors","subscribers_url":"https://api.github.com/repos/SSSD/sssd/subscribers","subscription_url":"https://api.github.com/repos/SSSD/sssd/subscription","commits_url":"https://api.github.com/repos/SSSD/sssd/commits{/sha}","git_commits_url":"https://api.github.com/repos/SSSD/sssd/git/commits{/sha}","comments_url":"https://api.github.com/repos/SSSD/sssd/comments{/number}","issue_comment_url":"https://api.github.com/repos/SSSD/sssd/issues/comments{/number}","contents_url":"https://api.github.com/repos/SSSD/sssd/contents/{+path}","compare_url":"https://api.github.com/repos/SSSD/sssd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SSSD/sssd/merges","archive_url":"https://api.github.com/repos/SSSD/sssd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SSSD/sssd/downloads","issues_url":"https://api.github.com/repos/SSSD/sssd/issues{/number}","pulls_url":"https://api.github.com/repos/SSSD/sssd/pulls{/number}","milestones_url":"https://api.github.com/repos/SSSD/sssd/milestones{/number}","notifications_url":"https://api.github.com/repos/SSSD/sssd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SSSD/sssd/labels{/name}","releases_url":"https://api.github.com/repos/SSSD/sssd/releases{/id}","deployments_url":"https://api.github.com/repos/SSSD/sssd/deployments","created_at":"2015-06-15T17:09:48Z","updated_at":"2016-12-19T12:58:04Z","pushed_at":"2017-01-15T09:49:52Z","git_url":"git://github.com/SSSD/sssd.git","ssh_url":"git@github.com:SSSD/sssd.git","clone_url":"https://github.com/SSSD/sssd.git","svn_url":"https://github.com/SSSD/sssd","homepage":"https://fedorahosted.org/sssd","size":32900,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":17,"forks":28,"open_issues":17,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/94"},"html":{"href":"https://github.com/SSSD/sssd/pull/94"},"issue":{"href":"https://api.github.com/repos/SSSD/sssd/issues/94"},"comments":{"href":"https://api.github.com/repos/SSSD/sssd/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/SSSD/sssd/statuses/648175a12920d7239e7f790a0153e7af5cb48540"}}}}
{"actor":{"display_login":"fidencio"}}