{"action":"created","issue":{"url":"https://api.github.com/repos/tomerfiliba/plumbum/issues/347","repository_url":"https://api.github.com/repos/tomerfiliba/plumbum","labels_url":"https://api.github.com/repos/tomerfiliba/plumbum/issues/347/labels{/name}","comments_url":"https://api.github.com/repos/tomerfiliba/plumbum/issues/347/comments","events_url":"https://api.github.com/repos/tomerfiliba/plumbum/issues/347/events","html_url":"https://github.com/tomerfiliba/plumbum/pull/347","id":259466763,"number":347,"title":"Fix #293: AttributeError: 'SshMachine' object has no attribute 'env'","user":{"login":"rrei","id":1902649,"avatar_url":"https://avatars1.githubusercontent.com/u/1902649?v=4","gravatar_id":"","url":"https://api.github.com/users/rrei","html_url":"https://github.com/rrei","followers_url":"https://api.github.com/users/rrei/followers","following_url":"https://api.github.com/users/rrei/following{/other_user}","gists_url":"https://api.github.com/users/rrei/gists{/gist_id}","starred_url":"https://api.github.com/users/rrei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrei/subscriptions","organizations_url":"https://api.github.com/users/rrei/orgs","repos_url":"https://api.github.com/users/rrei/repos","events_url":"https://api.github.com/users/rrei/events{/privacy}","received_events_url":"https://api.github.com/users/rrei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-21T11:40:06Z","updated_at":"2017-09-21T13:30:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tomerfiliba/plumbum/pulls/347","html_url":"https://github.com/tomerfiliba/plumbum/pull/347","diff_url":"https://github.com/tomerfiliba/plumbum/pull/347.diff","patch_url":"https://github.com/tomerfiliba/plumbum/pull/347.patch"},"body":"As described in my comment, I just moved the code to `BaseRemoteMachine` and called those methods from `RemoteEnv` :)"},"comment":{"url":"https://api.github.com/repos/tomerfiliba/plumbum/issues/comments/331156814","html_url":"https://github.com/tomerfiliba/plumbum/pull/347#issuecomment-331156814","issue_url":"https://api.github.com/repos/tomerfiliba/plumbum/issues/347","id":331156814,"user":{"login":"henryiii","id":4616906,"avatar_url":"https://avatars1.githubusercontent.com/u/4616906?v=4","gravatar_id":"","url":"https://api.github.com/users/henryiii","html_url":"https://github.com/henryiii","followers_url":"https://api.github.com/users/henryiii/followers","following_url":"https://api.github.com/users/henryiii/following{/other_user}","gists_url":"https://api.github.com/users/henryiii/gists{/gist_id}","starred_url":"https://api.github.com/users/henryiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryiii/subscriptions","organizations_url":"https://api.github.com/users/henryiii/orgs","repos_url":"https://api.github.com/users/henryiii/repos","events_url":"https://api.github.com/users/henryiii/events{/privacy}","received_events_url":"https://api.github.com/users/henryiii/received_events","type":"User","site_admin":false},"created_at":"2017-09-21T13:30:51Z","updated_at":"2017-09-21T13:30:51Z","author_association":"COLLABORATOR","body":"Try something like this:\r\n```python\r\n@_setdoc(BaseRemoteMachine)\r\ndef expand(self, expr):\r\n    self.remote.expand(expr)\r\n```\r\n\r\nAnd remove the `_` in front of the methods for the remotes. (if you *really* think the `_` are good ideas, we can modify `_setdoc` to take an optional name, it's in `plumbum/lib.py`."}}
{"actor":{"display_login":"henryiii"}}