{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/142718629","pull_request_review_id":67121481,"id":142718629,"diff_hunk":"@@ -534,17 +534,18 @@ get_absolute_path() {\n copy_files_or_dirs_from_list() {\n     eval $invocation\n \n-    local root_path=$(remove_trailing_slash $1)\n-    local out_path=$(remove_trailing_slash $2)\n-    local override=$3\n-    local override_switch=$(if [ \"$override\" = false ]; then printf -- \"-n\"; fi)\n+    local root_path=\"$(remove_trailing_slash \"$1\")\"\n+    local out_path=\"$(remove_trailing_slash \"$2\")\"\n+    local override=\"$3\"\n+    local override_switch=\"$(if [ \"$override\" = false ]; then printf -- \"-n\"; fi)\"\n     \n     cat | uniq | while read -r file_path; do\n-        local path=$(remove_beginning_slash ${file_path#$root_path})\n-        local target=$out_path/$path\n+        local path=\"$(remove_beginning_slash \"${file_path#$root_path}\")\"\n+        local target=\"$out_path\"/\"$path\"\n         if [ \"$override\" = true ] || (! ([ -d \"$target\" ] || [ -e \"$target\" ])); then\n-            mkdir -p $out_path/$(dirname $path)\n-            cp -R $override_switch $root_path/$path $target\n+            mkdir -p \"$out_path\"/\"$(dirname \"$path\")\"\n+            say \"cp -R $override_switch $root_path/$path $target\"\n+            cp -R \"$override_switch\" \"$root_path\"/\"$path\" \"$target\"","path":"scripts/obtain/dotnet-install.sh","position":null,"original_position":223,"commit_id":"0ee5b46cd7e5e3aeb778841b5d5d874504568c9e","original_commit_id":"191ffece69e2fa15314d39dc0904e18c4dc2362b","user":{"login":"benknoble","id":22802209,"avatar_url":"https://avatars3.githubusercontent.com/u/22802209?v=4","gravatar_id":"","url":"https://api.github.com/users/benknoble","html_url":"https://github.com/benknoble","followers_url":"https://api.github.com/users/benknoble/followers","following_url":"https://api.github.com/users/benknoble/following{/other_user}","gists_url":"https://api.github.com/users/benknoble/gists{/gist_id}","starred_url":"https://api.github.com/users/benknoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benknoble/subscriptions","organizations_url":"https://api.github.com/users/benknoble/orgs","repos_url":"https://api.github.com/users/benknoble/repos","events_url":"https://api.github.com/users/benknoble/events{/privacy}","received_events_url":"https://api.github.com/users/benknoble/received_events","type":"User","site_admin":false},"body":"Yes, discovered that just now","created_at":"2017-10-04T16:13:32Z","updated_at":"2017-10-04T16:13:32Z","html_url":"https://github.com/dotnet/cli/pull/7756#discussion_r142718629","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/7756","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/142718629"},"html":{"href":"https://github.com/dotnet/cli/pull/7756#discussion_r142718629"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/7756"}},"in_reply_to_id":142717797},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/7756","id":144552324,"html_url":"https://github.com/dotnet/cli/pull/7756","diff_url":"https://github.com/dotnet/cli/pull/7756.diff","patch_url":"https://github.com/dotnet/cli/pull/7756.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/7756","number":7756,"state":"open","locked":false,"title":"Quote variable expansions in dotnet-install.sh","user":{"login":"benknoble","id":22802209,"avatar_url":"https://avatars3.githubusercontent.com/u/22802209?v=4","gravatar_id":"","url":"https://api.github.com/users/benknoble","html_url":"https://github.com/benknoble","followers_url":"https://api.github.com/users/benknoble/followers","following_url":"https://api.github.com/users/benknoble/following{/other_user}","gists_url":"https://api.github.com/users/benknoble/gists{/gist_id}","starred_url":"https://api.github.com/users/benknoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benknoble/subscriptions","organizations_url":"https://api.github.com/users/benknoble/orgs","repos_url":"https://api.github.com/users/benknoble/repos","events_url":"https://api.github.com/users/benknoble/events{/privacy}","received_events_url":"https://api.github.com/users/benknoble/received_events","type":"User","site_admin":false},"body":"Fix #5281 to prevent paths with spaces from causing problems due to word\r\nsplitting.\r\n\r\nSome of them aren't likely to have issues, but safety first.\r\n\r\nSee also dotnet/roslyn#22320 for something similar","created_at":"2017-10-03T23:26:03Z","updated_at":"2017-10-04T16:13:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f0717238953f8f85023ad85be4976e541524023","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/7756/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/7756/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/7756/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/0ee5b46cd7e5e3aeb778841b5d5d874504568c9e","head":{"label":"benknoble:quote-fix","ref":"quote-fix","sha":"0ee5b46cd7e5e3aeb778841b5d5d874504568c9e","user":{"login":"benknoble","id":22802209,"avatar_url":"https://avatars3.githubusercontent.com/u/22802209?v=4","gravatar_id":"","url":"https://api.github.com/users/benknoble","html_url":"https://github.com/benknoble","followers_url":"https://api.github.com/users/benknoble/followers","following_url":"https://api.github.com/users/benknoble/following{/other_user}","gists_url":"https://api.github.com/users/benknoble/gists{/gist_id}","starred_url":"https://api.github.com/users/benknoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benknoble/subscriptions","organizations_url":"https://api.github.com/users/benknoble/orgs","repos_url":"https://api.github.com/users/benknoble/repos","events_url":"https://api.github.com/users/benknoble/events{/privacy}","received_events_url":"https://api.github.com/users/benknoble/received_events","type":"User","site_admin":false},"repo":{"id":105546154,"name":"cli","full_name":"benknoble/cli","owner":{"login":"benknoble","id":22802209,"avatar_url":"https://avatars3.githubusercontent.com/u/22802209?v=4","gravatar_id":"","url":"https://api.github.com/users/benknoble","html_url":"https://github.com/benknoble","followers_url":"https://api.github.com/users/benknoble/followers","following_url":"https://api.github.com/users/benknoble/following{/other_user}","gists_url":"https://api.github.com/users/benknoble/gists{/gist_id}","starred_url":"https://api.github.com/users/benknoble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benknoble/subscriptions","organizations_url":"https://api.github.com/users/benknoble/orgs","repos_url":"https://api.github.com/users/benknoble/repos","events_url":"https://api.github.com/users/benknoble/events{/privacy}","received_events_url":"https://api.github.com/users/benknoble/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benknoble/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/benknoble/cli","forks_url":"https://api.github.com/repos/benknoble/cli/forks","keys_url":"https://api.github.com/repos/benknoble/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benknoble/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benknoble/cli/teams","hooks_url":"https://api.github.com/repos/benknoble/cli/hooks","issue_events_url":"https://api.github.com/repos/benknoble/cli/issues/events{/number}","events_url":"https://api.github.com/repos/benknoble/cli/events","assignees_url":"https://api.github.com/repos/benknoble/cli/assignees{/user}","branches_url":"https://api.github.com/repos/benknoble/cli/branches{/branch}","tags_url":"https://api.github.com/repos/benknoble/cli/tags","blobs_url":"https://api.github.com/repos/benknoble/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benknoble/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benknoble/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/benknoble/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benknoble/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/benknoble/cli/languages","stargazers_url":"https://api.github.com/repos/benknoble/cli/stargazers","contributors_url":"https://api.github.com/repos/benknoble/cli/contributors","subscribers_url":"https://api.github.com/repos/benknoble/cli/subscribers","subscription_url":"https://api.github.com/repos/benknoble/cli/subscription","commits_url":"https://api.github.com/repos/benknoble/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/benknoble/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/benknoble/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/benknoble/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/benknoble/cli/contents/{+path}","compare_url":"https://api.github.com/repos/benknoble/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benknoble/cli/merges","archive_url":"https://api.github.com/repos/benknoble/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benknoble/cli/downloads","issues_url":"https://api.github.com/repos/benknoble/cli/issues{/number}","pulls_url":"https://api.github.com/repos/benknoble/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/benknoble/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/benknoble/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benknoble/cli/labels{/name}","releases_url":"https://api.github.com/repos/benknoble/cli/releases{/id}","deployments_url":"https://api.github.com/repos/benknoble/cli/deployments","created_at":"2017-10-02T14:45:39Z","updated_at":"2017-10-02T14:45:44Z","pushed_at":"2017-10-04T16:08:10Z","git_url":"git://github.com/benknoble/cli.git","ssh_url":"git@github.com:benknoble/cli.git","clone_url":"https://github.com/benknoble/cli.git","svn_url":"https://github.com/benknoble/cli","homepage":"https://github.com/dotnet/core","size":31704,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"e2c89f3d61000aedd7d5504b856f8af5d09fa36d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2017-10-03T18:25:43Z","pushed_at":"2017-10-04T16:08:13Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://github.com/dotnet/core","size":35583,"stargazers_count":2326,"watchers_count":2326,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":768,"mirror_url":null,"open_issues_count":401,"forks":768,"open_issues":401,"watchers":2326,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/7756"},"html":{"href":"https://github.com/dotnet/cli/pull/7756"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/7756"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/7756/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/7756/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/7756/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/0ee5b46cd7e5e3aeb778841b5d5d874504568c9e"}},"author_association":"NONE"}}
{"actor":{"display_login":"benknoble"}}