{"action":"closed","number":97,"pull_request":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/97","id":80746286,"html_url":"https://github.com/SnappyDataInc/snappy-store/pull/97","diff_url":"https://github.com/SnappyDataInc/snappy-store/pull/97.diff","patch_url":"https://github.com/SnappyDataInc/snappy-store/pull/97.patch","issue_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/97","number":97,"state":"closed","locked":false,"title":"[SNAP-976] Don't overwrite configured max eviction size","user":{"login":"sumwale","id":11540628,"avatar_url":"https://avatars3.githubusercontent.com/u/11540628?v=4","gravatar_id":"","url":"https://api.github.com/users/sumwale","html_url":"https://github.com/sumwale","followers_url":"https://api.github.com/users/sumwale/followers","following_url":"https://api.github.com/users/sumwale/following{/other_user}","gists_url":"https://api.github.com/users/sumwale/gists{/gist_id}","starred_url":"https://api.github.com/users/sumwale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumwale/subscriptions","organizations_url":"https://api.github.com/users/sumwale/orgs","repos_url":"https://api.github.com/users/sumwale/repos","events_url":"https://api.github.com/users/sumwale/events{/privacy}","received_events_url":"https://api.github.com/users/sumwale/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this pull request\n\nMoved computeLocalMaxMemory to be after the check for overwriting maximum.\nAlso overwrite the configured maximum only if the localMaxMemory is smaller.\n\nStill don't understand the reason for adding computeLocalMaxMemory in the first place. Tracked it down to an old change in GemfireXD:\n\n```\ncommit d45a103bb2467ffd31b2ffa04f75fcd4906cb2bd\n...\n    [fixes #50069] create table statement fails with persistence error when offheap is present\n\n    Tests ran: gfxd-precheckin and parReg.bt with off-heap enabled\n```\n\nThis change is absent in geode. The addition of computeLocalMaxMemory seems to have little correlation to the bug itself. Also the checks of \"getLocalMaxMemory > 0\" have been changed to \"getLocalMaxMemory != 0\" in this changeset which looks quite dicey to me. However, removing it completely needs more discussion and testing, so not doing it now. Reviewers may want to file a separate bug to track it.\n## Patch testing\n\nNew check has been added to snappydata/core ColumnTableTest.\"Test PR with EVICTION BY\" that also compares the size.\n\nRan precheckin -Pstore\n## ReleaseNotes changes\n\nNA\n## Other PRs\n\nNA\n","created_at":"2016-08-10T07:26:05Z","updated_at":"2017-09-16T17:48:07Z","closed_at":"2017-09-16T17:48:07Z","merged_at":null,"merge_commit_sha":"bacc8e97b39e4e228706249c52ddac8dfdfa27d1","assignee":{"login":"suranjan","id":189977,"avatar_url":"https://avatars1.githubusercontent.com/u/189977?v=4","gravatar_id":"","url":"https://api.github.com/users/suranjan","html_url":"https://github.com/suranjan","followers_url":"https://api.github.com/users/suranjan/followers","following_url":"https://api.github.com/users/suranjan/following{/other_user}","gists_url":"https://api.github.com/users/suranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/suranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suranjan/subscriptions","organizations_url":"https://api.github.com/users/suranjan/orgs","repos_url":"https://api.github.com/users/suranjan/repos","events_url":"https://api.github.com/users/suranjan/events{/privacy}","received_events_url":"https://api.github.com/users/suranjan/received_events","type":"User","site_admin":false},"assignees":[{"login":"suranjan","id":189977,"avatar_url":"https://avatars1.githubusercontent.com/u/189977?v=4","gravatar_id":"","url":"https://api.github.com/users/suranjan","html_url":"https://github.com/suranjan","followers_url":"https://api.github.com/users/suranjan/followers","following_url":"https://api.github.com/users/suranjan/following{/other_user}","gists_url":"https://api.github.com/users/suranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/suranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suranjan/subscriptions","organizations_url":"https://api.github.com/users/suranjan/orgs","repos_url":"https://api.github.com/users/suranjan/repos","events_url":"https://api.github.com/users/suranjan/events{/privacy}","received_events_url":"https://api.github.com/users/suranjan/received_events","type":"User","site_admin":false},{"login":"kneeraj","id":1151021,"avatar_url":"https://avatars3.githubusercontent.com/u/1151021?v=4","gravatar_id":"","url":"https://api.github.com/users/kneeraj","html_url":"https://github.com/kneeraj","followers_url":"https://api.github.com/users/kneeraj/followers","following_url":"https://api.github.com/users/kneeraj/following{/other_user}","gists_url":"https://api.github.com/users/kneeraj/gists{/gist_id}","starred_url":"https://api.github.com/users/kneeraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kneeraj/subscriptions","organizations_url":"https://api.github.com/users/kneeraj/orgs","repos_url":"https://api.github.com/users/kneeraj/repos","events_url":"https://api.github.com/users/kneeraj/events{/privacy}","received_events_url":"https://api.github.com/users/kneeraj/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/97/commits","review_comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/97/comments","review_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/97/comments","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/1cca5d4cf0dc65f2efb1dc647d6253d74f37bd18","head":{"label":"SnappyDataInc:SNAP-976","ref":"SNAP-976","sha":"1cca5d4cf0dc65f2efb1dc647d6253d74f37bd18","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"name":"snappy-store","full_name":"SnappyDataInc/snappy-store","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2017-09-11T14:31:11Z","pushed_at":"2017-09-16T17:47:09Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":118834,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":33,"default_branch":"snappy/master"}},"base":{"label":"SnappyDataInc:snappy/master","ref":"snappy/master","sha":"dbd274430859560e9dd66077b1592ddfbc9cdabd","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"name":"snappy-store","full_name":"SnappyDataInc/snappy-store","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars2.githubusercontent.com/u/11342682?v=4","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2017-09-11T14:31:11Z","pushed_at":"2017-09-16T17:47:09Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":118834,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":9,"forks":10,"open_issues":9,"watchers":33,"default_branch":"snappy/master"}},"_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/97"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/97"},"issue":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/97"},"comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/1cca5d4cf0dc65f2efb1dc647d6253d74f37bd18"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":8,"additions":4,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"sumwale"}}