{"action":"created","issue":{"url":"https://api.github.com/repos/whitequark/parser/issues/403","repository_url":"https://api.github.com/repos/whitequark/parser","labels_url":"https://api.github.com/repos/whitequark/parser/issues/403/labels{/name}","comments_url":"https://api.github.com/repos/whitequark/parser/issues/403/comments","events_url":"https://api.github.com/repos/whitequark/parser/issues/403/events","html_url":"https://github.com/whitequark/parser/pull/403","id":275556498,"number":403,"title":"Proof of concept for tree-like Rewriter","user":{"login":"marcandre","id":33770,"avatar_url":"https://avatars2.githubusercontent.com/u/33770?v=4","gravatar_id":"","url":"https://api.github.com/users/marcandre","html_url":"https://github.com/marcandre","followers_url":"https://api.github.com/users/marcandre/followers","following_url":"https://api.github.com/users/marcandre/following{/other_user}","gists_url":"https://api.github.com/users/marcandre/gists{/gist_id}","starred_url":"https://api.github.com/users/marcandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcandre/subscriptions","organizations_url":"https://api.github.com/users/marcandre/orgs","repos_url":"https://api.github.com/users/marcandre/repos","events_url":"https://api.github.com/users/marcandre/events{/privacy}","received_events_url":"https://api.github.com/users/marcandre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-11-21T01:37:31Z","updated_at":"2017-11-25T04:51:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/whitequark/parser/pulls/403","html_url":"https://github.com/whitequark/parser/pull/403","diff_url":"https://github.com/whitequark/parser/pull/403.diff","patch_url":"https://github.com/whitequark/parser/pull/403.patch"},"body":"This is only a proof of concept for discussion for #401. If there is interest, it could become a real PR with a preference switch to maintain backward compatibility.\r\n\r\nI've kept the 21 failing tests to make it easier to judge the differences. I'm still quite curious as to what kind of use case required these.\r\n\r\nHere's the list:\r\n```\r\n\r\nTestSourceRewriter#test_insertion_within_replace_clobber [test_source_rewriter.rb:182]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_remove_overlapping_insertion_clobber [test_source_rewriter.rb:212]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_overlapping_delete:\r\nParser::ClobberingError: Trying to combine overlapping ranges: ...\r\ntest_source_rewriter.rb:458:in `test_overlapping_delete'\r\n\r\nTestSourceRewriter#test_replace_overlapping_insertion_clobber [test_source_rewriter.rb:202]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_overlapping_replace_left_smaller_than_replaced_matching:\r\nParser::ClobberingError: Trying to combine overlapping ranges: \r\n...test_source_rewriter.rb:312:in `test_overlapping_replace_left_smaller_than_replaced_matching'\r\n\r\nTestSourceRewriter#test_overlapping_replace_left_larger_right_larger_matching:\r\nParser::ClobberingError: Trying to combine overlapping ranges: \r\n...test_source_rewriter.rb:338:in `test_overlapping_replace_left_larger_right_larger_matching'\r\n\r\nTestSourceRewriter#test_remove_overlapping_multi_insertion_clobber [test_source_rewriter.rb:252]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_subsuming_replace_both_smaller_non_matching [test_source_rewriter.rb:373]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_clobbering_error_backward_compatibility [test_source_rewriter.rb:449]:\r\nExpected false to be truthy.\r\n\r\nTestSourceRewriter#test_replace_overlapping_multi_insertion_clobber [test_source_rewriter.rb:242]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_overlapping_replace:\r\nParser::ClobberingError: Trying to combine overlapping ranges: \r\n...test_source_rewriter.rb:466:in `test_overlapping_replace'\r\n\r\nTestSourceRewriter#test_insertion_within_remove_clobber [test_source_rewriter.rb:192]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_subsuming_replace_both_larger_non_matching [test_source_rewriter.rb:391]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_insertion_on_merged_insertion_clobber [test_source_rewriter.rb:266]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_transaction_rollback [test_source_rewriter.rb:533]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_replace_same_begin_larger_than_replaced_range_non_matching [test_source_rewriter.rb:301]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_multiple_insertions_at_same_location_clobber [test_source_rewriter.rb:130]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_clobber [test_source_rewriter.rb:415]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_multi_insertion_within_replace_clobber [test_source_rewriter.rb:222]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_multi_insertion_within_remove_clobber [test_source_rewriter.rb:232]:\r\nParser::ClobberingError expected but nothing was raised.\r\n\r\nTestSourceRewriter#test_overlapping_replace_left_larger_right_smaller_matching:\r\nParser::ClobberingError: Trying to combine overlapping ranges: (rewriter):1:2 and (rewriter):1:4\r\ntest_source_rewriter.rb:330:in `test_overlapping_replace_left_larger_right_smaller_matching'\r\n```"},"comment":{"url":"https://api.github.com/repos/whitequark/parser/issues/comments/346919068","html_url":"https://github.com/whitequark/parser/pull/403#issuecomment-346919068","issue_url":"https://api.github.com/repos/whitequark/parser/issues/403","id":346919068,"user":{"login":"whitequark","id":54771,"avatar_url":"https://avatars1.githubusercontent.com/u/54771?v=4","gravatar_id":"","url":"https://api.github.com/users/whitequark","html_url":"https://github.com/whitequark","followers_url":"https://api.github.com/users/whitequark/followers","following_url":"https://api.github.com/users/whitequark/following{/other_user}","gists_url":"https://api.github.com/users/whitequark/gists{/gist_id}","starred_url":"https://api.github.com/users/whitequark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whitequark/subscriptions","organizations_url":"https://api.github.com/users/whitequark/orgs","repos_url":"https://api.github.com/users/whitequark/repos","events_url":"https://api.github.com/users/whitequark/events{/privacy}","received_events_url":"https://api.github.com/users/whitequark/received_events","type":"User","site_admin":false},"created_at":"2017-11-25T04:51:40Z","updated_at":"2017-11-25T04:51:40Z","author_association":"OWNER","body":"Reverted"}}
{"actor":{"display_login":"whitequark"}}