{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51950","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51950/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51950/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51950/events","html_url":"https://github.com/kubernetes/kubernetes/issues/51950","id":255258957,"number":51950,"title":"PodFitsHostPorts fail on same hostPort, different hostIP","user":{"login":"CallMeFoxie","id":5840290,"avatar_url":"https://avatars0.githubusercontent.com/u/5840290?v=4","gravatar_id":"","url":"https://api.github.com/users/CallMeFoxie","html_url":"https://github.com/CallMeFoxie","followers_url":"https://api.github.com/users/CallMeFoxie/followers","following_url":"https://api.github.com/users/CallMeFoxie/following{/other_user}","gists_url":"https://api.github.com/users/CallMeFoxie/gists{/gist_id}","starred_url":"https://api.github.com/users/CallMeFoxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CallMeFoxie/subscriptions","organizations_url":"https://api.github.com/users/CallMeFoxie/orgs","repos_url":"https://api.github.com/users/CallMeFoxie/repos","events_url":"https://api.github.com/users/CallMeFoxie/events{/privacy}","received_events_url":"https://api.github.com/users/CallMeFoxie/received_events","type":"User","site_admin":false},"labels":[{"id":105146071,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":617149945,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-sig","name":"needs-sig","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-05T12:23:49Z","updated_at":"2017-09-05T12:24:44Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"/kind bug\r\n\r\nHi\r\nI've posted PR few months ago #39369 - regarding validating against combination of hostPort:protocol:hostIP.\r\nIt seems that something similar is back, this time with Predicates.\r\n\r\nThe issue is in `plugin/pkg/scheduler/algorithm/predicates/predicates.go` in `PodFitsHostPorts:880` - it checks only for ports and not for IPs they listen on.\r\n\r\nI will try to get PR for this but not if it will be soon.\r\n\r\nBasically: one pod SHOULD be able to listen on:\r\n10.1.1.1:8080\r\n10.1.1.2:8080\r\n\r\nright now it gets denied with PodFitsHostPorts error.\r\nIt was working back in 1.5 or whichever release was in February this year. It seems to have been broken around 1.7.0 release based on Git Blame.\r\n\r\nAshley"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/327159584","html_url":"https://github.com/kubernetes/kubernetes/issues/51950#issuecomment-327159584","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51950","id":327159584,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars0.githubusercontent.com/u/13653959?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-09-05T12:24:44Z","updated_at":"2017-09-05T12:24:44Z","author_association":"COLLABORATOR","body":"@CallMeFoxie\nThere are no sig labels on this issue. Please [add a sig label](https://github.com/kubernetes/test-infra/blob/master/commands.md) by:\n\n1. mentioning a sig: `@kubernetes/sig-<group-name>-<group-suffix>`\n    e.g., `@kubernetes/sig-contributor-experience-<group-suffix>` to notify the contributor experience sig, OR\n\n2. specifying the label manually: `/sig <label>`\n    e.g., `/sig scalability` to apply the `sig/scalability` label\n\nNote: Method 1 will trigger an email to the group. You can find the group list [here](https://github.com/kubernetes/community/blob/master/sig-list.md) and label list [here](https://github.com/kubernetes/kubernetes/labels).\nThe `<group-suffix>` in the method 1 has to be replaced with one of these: _**bugs, feature-requests, pr-reviews, test-failures, proposals**_"}}
{"actor":{"display_login":"k8s-merge-robot"}}