{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/134160199","pull_request_review_id":57418777,"id":134160199,"diff_hunk":"@@ -192,29 +192,38 @@ bool MulticopterLandDetector::_get_ground_contact_state()\n \tconst bool manual_control_idle = (_has_manual_control_present() && _manual.z < _params.manual_stick_down_threshold);\n \tconst bool manual_control_idle_or_auto = manual_control_idle || !_control_mode.flag_control_manual_enabled;\n \n-\t// Widen acceptance thresholds for landed state right after landed\n-\t// so that motor spool-up and other effects do not trigger false negatives.\n-\tfloat landThresholdFactor = 1.0f;\n-\n-\tif (hrt_elapsed_time(&_landed_time) < LAND_DETECTOR_LAND_PHASE_TIME_US) {\n-\t\tlandThresholdFactor = 2.5f;\n-\t}\n+\t// land speed threshold","path":"src/modules/land_detector/MulticopterLandDetector.cpp","position":11,"original_position":11,"commit_id":"4a20b71b82aa41b0ddf5b0ca23fd6cd3a9f3b7d5","original_commit_id":"4a20b71b82aa41b0ddf5b0ca23fd6cd3a9f3b7d5","user":{"login":"MaEtUgR","id":4668506,"avatar_url":"https://avatars2.githubusercontent.com/u/4668506?v=4","gravatar_id":"","url":"https://api.github.com/users/MaEtUgR","html_url":"https://github.com/MaEtUgR","followers_url":"https://api.github.com/users/MaEtUgR/followers","following_url":"https://api.github.com/users/MaEtUgR/following{/other_user}","gists_url":"https://api.github.com/users/MaEtUgR/gists{/gist_id}","starred_url":"https://api.github.com/users/MaEtUgR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaEtUgR/subscriptions","organizations_url":"https://api.github.com/users/MaEtUgR/orgs","repos_url":"https://api.github.com/users/MaEtUgR/repos","events_url":"https://api.github.com/users/MaEtUgR/events{/privacy}","received_events_url":"https://api.github.com/users/MaEtUgR/received_events","type":"User","site_admin":false},"body":"this comment says nothing, a descripion even if only with keywords would help more then duplicating the title.","created_at":"2017-08-21T07:24:07Z","updated_at":"2017-08-21T07:24:07Z","html_url":"https://github.com/PX4/Firmware/pull/7831#discussion_r134160199","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/7831","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/134160199"},"html":{"href":"https://github.com/PX4/Firmware/pull/7831#discussion_r134160199"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/7831"}}},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/7831","id":136688075,"html_url":"https://github.com/PX4/Firmware/pull/7831","diff_url":"https://github.com/PX4/Firmware/pull/7831.diff","patch_url":"https://github.com/PX4/Firmware/pull/7831.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/7831","number":7831,"state":"open","locked":false,"title":"landdetector groundcontact: adjust climbrate if landing speed is low","user":{"login":"Stifael","id":13449161,"avatar_url":"https://avatars2.githubusercontent.com/u/13449161?v=4","gravatar_id":"","url":"https://api.github.com/users/Stifael","html_url":"https://github.com/Stifael","followers_url":"https://api.github.com/users/Stifael/followers","following_url":"https://api.github.com/users/Stifael/following{/other_user}","gists_url":"https://api.github.com/users/Stifael/gists{/gist_id}","starred_url":"https://api.github.com/users/Stifael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stifael/subscriptions","organizations_url":"https://api.github.com/users/Stifael/orgs","repos_url":"https://api.github.com/users/Stifael/repos","events_url":"https://api.github.com/users/Stifael/events{/privacy}","received_events_url":"https://api.github.com/users/Stifael/received_events","type":"User","site_admin":false},"body":"The threshold for no vertical movement is a constant value of 0.5. If the parameter landspeed is set low (for instance below 0.5), then the landdetector will always detect no vertical movement. This PR is a protection for having low landspeed.\r\n\r\nissue: \r\nhttps://github.com/PX4/Firmware/issues/7811\r\n","created_at":"2017-08-21T06:28:54Z","updated_at":"2017-08-21T07:24:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eec28c37da7430e9959bc5f400824f63c0cfa661","assignee":{"login":"PX4TestFlights","id":24407792,"avatar_url":"https://avatars0.githubusercontent.com/u/24407792?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4TestFlights","html_url":"https://github.com/PX4TestFlights","followers_url":"https://api.github.com/users/PX4TestFlights/followers","following_url":"https://api.github.com/users/PX4TestFlights/following{/other_user}","gists_url":"https://api.github.com/users/PX4TestFlights/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4TestFlights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4TestFlights/subscriptions","organizations_url":"https://api.github.com/users/PX4TestFlights/orgs","repos_url":"https://api.github.com/users/PX4TestFlights/repos","events_url":"https://api.github.com/users/PX4TestFlights/events{/privacy}","received_events_url":"https://api.github.com/users/PX4TestFlights/received_events","type":"User","site_admin":false},"assignees":[{"login":"PX4TestFlights","id":24407792,"avatar_url":"https://avatars0.githubusercontent.com/u/24407792?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4TestFlights","html_url":"https://github.com/PX4TestFlights","followers_url":"https://api.github.com/users/PX4TestFlights/followers","following_url":"https://api.github.com/users/PX4TestFlights/following{/other_user}","gists_url":"https://api.github.com/users/PX4TestFlights/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4TestFlights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4TestFlights/subscriptions","organizations_url":"https://api.github.com/users/PX4TestFlights/orgs","repos_url":"https://api.github.com/users/PX4TestFlights/repos","events_url":"https://api.github.com/users/PX4TestFlights/events{/privacy}","received_events_url":"https://api.github.com/users/PX4TestFlights/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/7831/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/7831/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/7831/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/4a20b71b82aa41b0ddf5b0ca23fd6cd3a9f3b7d5","head":{"label":"PX4:pr-MClanddetector_catch_low_speed","ref":"pr-MClanddetector_catch_low_speed","sha":"4a20b71b82aa41b0ddf5b0ca23fd6cd3a9f3b7d5","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2017-08-20T10:54:46Z","pushed_at":"2017-08-21T06:57:17Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":90626,"stargazers_count":1257,"watchers_count":1257,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3720,"mirror_url":null,"open_issues_count":439,"forks":3720,"open_issues":439,"watchers":1257,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"1e42d523da8d8852d52d922a9e9fca75d6a7c122","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2017-08-20T10:54:46Z","pushed_at":"2017-08-21T06:57:17Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":90626,"stargazers_count":1257,"watchers_count":1257,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3720,"mirror_url":null,"open_issues_count":439,"forks":3720,"open_issues":439,"watchers":1257,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/7831"},"html":{"href":"https://github.com/PX4/Firmware/pull/7831"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/7831"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/7831/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/7831/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/7831/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/4a20b71b82aa41b0ddf5b0ca23fd6cd3a9f3b7d5"}}}}
{"actor":{"display_login":"MaEtUgR"}}