{"action":"created","comment":{"url":"https://api.github.com/repos/bulletphysics/bullet3/pulls/comments/110081998","pull_request_review_id":31226879,"id":110081998,"diff_hunk":"@@ -1,424 +1,228 @@\n-\n-from setuptools import find_packages\n+from setuptools import setup, Extension, find_packages","path":"setup.py","position":3,"original_position":3,"commit_id":"6ea5688ff1162bc6c20be47a412b8405a0bb52ee","original_commit_id":"6ea5688ff1162bc6c20be47a412b8405a0bb52ee","user":{"login":"cprogrammer1994","id":11232402,"avatar_url":"https://avatars2.githubusercontent.com/u/11232402?v=3","gravatar_id":"","url":"https://api.github.com/users/cprogrammer1994","html_url":"https://github.com/cprogrammer1994","followers_url":"https://api.github.com/users/cprogrammer1994/followers","following_url":"https://api.github.com/users/cprogrammer1994/following{/other_user}","gists_url":"https://api.github.com/users/cprogrammer1994/gists{/gist_id}","starred_url":"https://api.github.com/users/cprogrammer1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprogrammer1994/subscriptions","organizations_url":"https://api.github.com/users/cprogrammer1994/orgs","repos_url":"https://api.github.com/users/cprogrammer1994/repos","events_url":"https://api.github.com/users/cprogrammer1994/events{/privacy}","received_events_url":"https://api.github.com/users/cprogrammer1994/received_events","type":"User","site_admin":false},"body":"[PyPA sample uses setuptools as well](https://github.com/pypa/sampleproject/blob/master/setup.py#L9)\r\n\r\n> setuptools provides enhancements to distutils, and is much more commonly used than just using distutils by itself. _[from distutils docs](https://packaging.python.org/key_projects/#distutils)_","created_at":"2017-04-06T05:37:39Z","updated_at":"2017-04-06T05:37:39Z","html_url":"https://github.com/bulletphysics/bullet3/pull/1057#discussion_r110081998","pull_request_url":"https://api.github.com/repos/bulletphysics/bullet3/pulls/1057","_links":{"self":{"href":"https://api.github.com/repos/bulletphysics/bullet3/pulls/comments/110081998"},"html":{"href":"https://github.com/bulletphysics/bullet3/pull/1057#discussion_r110081998"},"pull_request":{"href":"https://api.github.com/repos/bulletphysics/bullet3/pulls/1057"}}},"pull_request":{"url":"https://api.github.com/repos/bulletphysics/bullet3/pulls/1057","id":114336829,"html_url":"https://github.com/bulletphysics/bullet3/pull/1057","diff_url":"https://github.com/bulletphysics/bullet3/pull/1057.diff","patch_url":"https://github.com/bulletphysics/bullet3/pull/1057.patch","issue_url":"https://api.github.com/repos/bulletphysics/bullet3/issues/1057","number":1057,"state":"open","locked":false,"title":"refactor setup.py","user":{"login":"cprogrammer1994","id":11232402,"avatar_url":"https://avatars2.githubusercontent.com/u/11232402?v=3","gravatar_id":"","url":"https://api.github.com/users/cprogrammer1994","html_url":"https://github.com/cprogrammer1994","followers_url":"https://api.github.com/users/cprogrammer1994/followers","following_url":"https://api.github.com/users/cprogrammer1994/following{/other_user}","gists_url":"https://api.github.com/users/cprogrammer1994/gists{/gist_id}","starred_url":"https://api.github.com/users/cprogrammer1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprogrammer1994/subscriptions","organizations_url":"https://api.github.com/users/cprogrammer1994/orgs","repos_url":"https://api.github.com/users/cprogrammer1994/repos","events_url":"https://api.github.com/users/cprogrammer1994/events{/privacy}","received_events_url":"https://api.github.com/users/cprogrammer1994/received_events","type":"User","site_admin":false},"body":"tested on windows with python 3.5 and 3.6","created_at":"2017-04-05T09:50:57Z","updated_at":"2017-04-06T05:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a389ffdf1ab43c52037ec99b05802e2219b3a83c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bulletphysics/bullet3/pulls/1057/commits","review_comments_url":"https://api.github.com/repos/bulletphysics/bullet3/pulls/1057/comments","review_comment_url":"https://api.github.com/repos/bulletphysics/bullet3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bulletphysics/bullet3/issues/1057/comments","statuses_url":"https://api.github.com/repos/bulletphysics/bullet3/statuses/6ea5688ff1162bc6c20be47a412b8405a0bb52ee","head":{"label":"cprogrammer1994:pypi-related","ref":"pypi-related","sha":"6ea5688ff1162bc6c20be47a412b8405a0bb52ee","user":{"login":"cprogrammer1994","id":11232402,"avatar_url":"https://avatars2.githubusercontent.com/u/11232402?v=3","gravatar_id":"","url":"https://api.github.com/users/cprogrammer1994","html_url":"https://github.com/cprogrammer1994","followers_url":"https://api.github.com/users/cprogrammer1994/followers","following_url":"https://api.github.com/users/cprogrammer1994/following{/other_user}","gists_url":"https://api.github.com/users/cprogrammer1994/gists{/gist_id}","starred_url":"https://api.github.com/users/cprogrammer1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprogrammer1994/subscriptions","organizations_url":"https://api.github.com/users/cprogrammer1994/orgs","repos_url":"https://api.github.com/users/cprogrammer1994/repos","events_url":"https://api.github.com/users/cprogrammer1994/events{/privacy}","received_events_url":"https://api.github.com/users/cprogrammer1994/received_events","type":"User","site_admin":false},"repo":{"id":80042916,"name":"bullet3","full_name":"cprogrammer1994/bullet3","owner":{"login":"cprogrammer1994","id":11232402,"avatar_url":"https://avatars2.githubusercontent.com/u/11232402?v=3","gravatar_id":"","url":"https://api.github.com/users/cprogrammer1994","html_url":"https://github.com/cprogrammer1994","followers_url":"https://api.github.com/users/cprogrammer1994/followers","following_url":"https://api.github.com/users/cprogrammer1994/following{/other_user}","gists_url":"https://api.github.com/users/cprogrammer1994/gists{/gist_id}","starred_url":"https://api.github.com/users/cprogrammer1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cprogrammer1994/subscriptions","organizations_url":"https://api.github.com/users/cprogrammer1994/orgs","repos_url":"https://api.github.com/users/cprogrammer1994/repos","events_url":"https://api.github.com/users/cprogrammer1994/events{/privacy}","received_events_url":"https://api.github.com/users/cprogrammer1994/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cprogrammer1994/bullet3","description":"Bullet Physics SDK: real-time collision detection and multi-physics simulation for VR, games, visual effects, robotics, machine learning etc.","fork":true,"url":"https://api.github.com/repos/cprogrammer1994/bullet3","forks_url":"https://api.github.com/repos/cprogrammer1994/bullet3/forks","keys_url":"https://api.github.com/repos/cprogrammer1994/bullet3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cprogrammer1994/bullet3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cprogrammer1994/bullet3/teams","hooks_url":"https://api.github.com/repos/cprogrammer1994/bullet3/hooks","issue_events_url":"https://api.github.com/repos/cprogrammer1994/bullet3/issues/events{/number}","events_url":"https://api.github.com/repos/cprogrammer1994/bullet3/events","assignees_url":"https://api.github.com/repos/cprogrammer1994/bullet3/assignees{/user}","branches_url":"https://api.github.com/repos/cprogrammer1994/bullet3/branches{/branch}","tags_url":"https://api.github.com/repos/cprogrammer1994/bullet3/tags","blobs_url":"https://api.github.com/repos/cprogrammer1994/bullet3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cprogrammer1994/bullet3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cprogrammer1994/bullet3/git/refs{/sha}","trees_url":"https://api.github.com/repos/cprogrammer1994/bullet3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cprogrammer1994/bullet3/statuses/{sha}","languages_url":"https://api.github.com/repos/cprogrammer1994/bullet3/languages","stargazers_url":"https://api.github.com/repos/cprogrammer1994/bullet3/stargazers","contributors_url":"https://api.github.com/repos/cprogrammer1994/bullet3/contributors","subscribers_url":"https://api.github.com/repos/cprogrammer1994/bullet3/subscribers","subscription_url":"https://api.github.com/repos/cprogrammer1994/bullet3/subscription","commits_url":"https://api.github.com/repos/cprogrammer1994/bullet3/commits{/sha}","git_commits_url":"https://api.github.com/repos/cprogrammer1994/bullet3/git/commits{/sha}","comments_url":"https://api.github.com/repos/cprogrammer1994/bullet3/comments{/number}","issue_comment_url":"https://api.github.com/repos/cprogrammer1994/bullet3/issues/comments{/number}","contents_url":"https://api.github.com/repos/cprogrammer1994/bullet3/contents/{+path}","compare_url":"https://api.github.com/repos/cprogrammer1994/bullet3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cprogrammer1994/bullet3/merges","archive_url":"https://api.github.com/repos/cprogrammer1994/bullet3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cprogrammer1994/bullet3/downloads","issues_url":"https://api.github.com/repos/cprogrammer1994/bullet3/issues{/number}","pulls_url":"https://api.github.com/repos/cprogrammer1994/bullet3/pulls{/number}","milestones_url":"https://api.github.com/repos/cprogrammer1994/bullet3/milestones{/number}","notifications_url":"https://api.github.com/repos/cprogrammer1994/bullet3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cprogrammer1994/bullet3/labels{/name}","releases_url":"https://api.github.com/repos/cprogrammer1994/bullet3/releases{/id}","deployments_url":"https://api.github.com/repos/cprogrammer1994/bullet3/deployments","created_at":"2017-01-25T18:18:17Z","updated_at":"2017-01-25T18:18:25Z","pushed_at":"2017-04-05T10:08:36Z","git_url":"git://github.com/cprogrammer1994/bullet3.git","ssh_url":"git@github.com:cprogrammer1994/bullet3.git","clone_url":"https://github.com/cprogrammer1994/bullet3.git","svn_url":"https://github.com/cprogrammer1994/bullet3","homepage":"http://bulletphysics.org","size":106814,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bulletphysics:master","ref":"master","sha":"ac9189602545f524665c7bba6c1aa14e0e77a8e9","user":{"login":"bulletphysics","id":6955508,"avatar_url":"https://avatars0.githubusercontent.com/u/6955508?v=3","gravatar_id":"","url":"https://api.github.com/users/bulletphysics","html_url":"https://github.com/bulletphysics","followers_url":"https://api.github.com/users/bulletphysics/followers","following_url":"https://api.github.com/users/bulletphysics/following{/other_user}","gists_url":"https://api.github.com/users/bulletphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/bulletphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bulletphysics/subscriptions","organizations_url":"https://api.github.com/users/bulletphysics/orgs","repos_url":"https://api.github.com/users/bulletphysics/repos","events_url":"https://api.github.com/users/bulletphysics/events{/privacy}","received_events_url":"https://api.github.com/users/bulletphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":1605598,"name":"bullet3","full_name":"bulletphysics/bullet3","owner":{"login":"bulletphysics","id":6955508,"avatar_url":"https://avatars0.githubusercontent.com/u/6955508?v=3","gravatar_id":"","url":"https://api.github.com/users/bulletphysics","html_url":"https://github.com/bulletphysics","followers_url":"https://api.github.com/users/bulletphysics/followers","following_url":"https://api.github.com/users/bulletphysics/following{/other_user}","gists_url":"https://api.github.com/users/bulletphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/bulletphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bulletphysics/subscriptions","organizations_url":"https://api.github.com/users/bulletphysics/orgs","repos_url":"https://api.github.com/users/bulletphysics/repos","events_url":"https://api.github.com/users/bulletphysics/events{/privacy}","received_events_url":"https://api.github.com/users/bulletphysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bulletphysics/bullet3","description":"Bullet Physics SDK: real-time collision detection and multi-physics simulation for VR, games, visual effects, robotics, machine learning etc.","fork":false,"url":"https://api.github.com/repos/bulletphysics/bullet3","forks_url":"https://api.github.com/repos/bulletphysics/bullet3/forks","keys_url":"https://api.github.com/repos/bulletphysics/bullet3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bulletphysics/bullet3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bulletphysics/bullet3/teams","hooks_url":"https://api.github.com/repos/bulletphysics/bullet3/hooks","issue_events_url":"https://api.github.com/repos/bulletphysics/bullet3/issues/events{/number}","events_url":"https://api.github.com/repos/bulletphysics/bullet3/events","assignees_url":"https://api.github.com/repos/bulletphysics/bullet3/assignees{/user}","branches_url":"https://api.github.com/repos/bulletphysics/bullet3/branches{/branch}","tags_url":"https://api.github.com/repos/bulletphysics/bullet3/tags","blobs_url":"https://api.github.com/repos/bulletphysics/bullet3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bulletphysics/bullet3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bulletphysics/bullet3/git/refs{/sha}","trees_url":"https://api.github.com/repos/bulletphysics/bullet3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bulletphysics/bullet3/statuses/{sha}","languages_url":"https://api.github.com/repos/bulletphysics/bullet3/languages","stargazers_url":"https://api.github.com/repos/bulletphysics/bullet3/stargazers","contributors_url":"https://api.github.com/repos/bulletphysics/bullet3/contributors","subscribers_url":"https://api.github.com/repos/bulletphysics/bullet3/subscribers","subscription_url":"https://api.github.com/repos/bulletphysics/bullet3/subscription","commits_url":"https://api.github.com/repos/bulletphysics/bullet3/commits{/sha}","git_commits_url":"https://api.github.com/repos/bulletphysics/bullet3/git/commits{/sha}","comments_url":"https://api.github.com/repos/bulletphysics/bullet3/comments{/number}","issue_comment_url":"https://api.github.com/repos/bulletphysics/bullet3/issues/comments{/number}","contents_url":"https://api.github.com/repos/bulletphysics/bullet3/contents/{+path}","compare_url":"https://api.github.com/repos/bulletphysics/bullet3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bulletphysics/bullet3/merges","archive_url":"https://api.github.com/repos/bulletphysics/bullet3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bulletphysics/bullet3/downloads","issues_url":"https://api.github.com/repos/bulletphysics/bullet3/issues{/number}","pulls_url":"https://api.github.com/repos/bulletphysics/bullet3/pulls{/number}","milestones_url":"https://api.github.com/repos/bulletphysics/bullet3/milestones{/number}","notifications_url":"https://api.github.com/repos/bulletphysics/bullet3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bulletphysics/bullet3/labels{/name}","releases_url":"https://api.github.com/repos/bulletphysics/bullet3/releases{/id}","deployments_url":"https://api.github.com/repos/bulletphysics/bullet3/deployments","created_at":"2011-04-12T18:45:08Z","updated_at":"2017-04-06T02:51:45Z","pushed_at":"2017-04-06T04:57:27Z","git_url":"git://github.com/bulletphysics/bullet3.git","ssh_url":"git@github.com:bulletphysics/bullet3.git","clone_url":"https://github.com/bulletphysics/bullet3.git","svn_url":"https://github.com/bulletphysics/bullet3","homepage":"http://bulletphysics.org","size":106805,"stargazers_count":2314,"watchers_count":2314,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":689,"mirror_url":null,"open_issues_count":300,"forks":689,"open_issues":300,"watchers":2314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bulletphysics/bullet3/pulls/1057"},"html":{"href":"https://github.com/bulletphysics/bullet3/pull/1057"},"issue":{"href":"https://api.github.com/repos/bulletphysics/bullet3/issues/1057"},"comments":{"href":"https://api.github.com/repos/bulletphysics/bullet3/issues/1057/comments"},"review_comments":{"href":"https://api.github.com/repos/bulletphysics/bullet3/pulls/1057/comments"},"review_comment":{"href":"https://api.github.com/repos/bulletphysics/bullet3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bulletphysics/bullet3/pulls/1057/commits"},"statuses":{"href":"https://api.github.com/repos/bulletphysics/bullet3/statuses/6ea5688ff1162bc6c20be47a412b8405a0bb52ee"}}}}
{"actor":{"display_login":"cprogrammer1994"}}