{"action":"created","comment":{"url":"https://api.github.com/repos/magento/magento2/pulls/comments/142015395","pull_request_review_id":66322596,"id":142015395,"diff_hunk":"@@ -42,7 +42,7 @@ public function __construct(\\Magento\\Framework\\Stdlib\\DateTime\\TimezoneInterface\n     public function filter($value)\n     {\n         try {\n-            $dateTime = $this->_localeDate->date($value, null, false);\n+            $dateTime = $this->_localeDate->date($value, null, false, false);","path":"lib/internal/Magento/Framework/Stdlib/DateTime/Filter/DateTime.php","position":5,"original_position":5,"commit_id":"5515d1d5c5ab58952056ab4640924f8e8539db1a","original_commit_id":"5515d1d5c5ab58952056ab4640924f8e8539db1a","user":{"login":"orlangur","id":642698,"avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"body":"I don't think passing `$includeTime = false` is correct for `DateTime` filter.\r\n\r\nI see such `false` correctly passed in `\\Magento\\Framework\\Stdlib\\DateTime\\Filter\\Date::filter` though. Should we replace `DateTime` with `Date` filter maybe?","created_at":"2017-09-30T21:13:14Z","updated_at":"2017-09-30T21:13:22Z","html_url":"https://github.com/magento/magento2/pull/11156#discussion_r142015395","pull_request_url":"https://api.github.com/repos/magento/magento2/pulls/11156","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments/142015395"},"html":{"href":"https://github.com/magento/magento2/pull/11156#discussion_r142015395"},"pull_request":{"href":"https://api.github.com/repos/magento/magento2/pulls/11156"}}},"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/11156","id":144021155,"html_url":"https://github.com/magento/magento2/pull/11156","diff_url":"https://github.com/magento/magento2/pull/11156.diff","patch_url":"https://github.com/magento/magento2/pull/11156.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/11156","number":11156,"state":"open","locked":false,"title":"fixed issue 10578 missing false on _localeDate->date(...","user":{"login":"cproboscht","id":16148781,"avatar_url":"https://avatars0.githubusercontent.com/u/16148781?v=4","gravatar_id":"","url":"https://api.github.com/users/cproboscht","html_url":"https://github.com/cproboscht","followers_url":"https://api.github.com/users/cproboscht/followers","following_url":"https://api.github.com/users/cproboscht/following{/other_user}","gists_url":"https://api.github.com/users/cproboscht/gists{/gist_id}","starred_url":"https://api.github.com/users/cproboscht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cproboscht/subscriptions","organizations_url":"https://api.github.com/users/cproboscht/orgs","repos_url":"https://api.github.com/users/cproboscht/repos","events_url":"https://api.github.com/users/cproboscht/events{/privacy}","received_events_url":"https://api.github.com/users/cproboscht/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\n<!--- Provide a description of the changes proposed in the pull request -->\r\nProblem with locale en_GB for saving products with used datepicker with dates like \"28/09/2017\" \r\nequivalent problem: Reports and date format #7037 fixed earlier.\r\nmissing fix here for products\r\n\r\n### Fixed Issues (if relevant)\r\n<!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant  -->\r\n1. magento/magento2#10578: Stock Managment issue 2.1.8 \r\n\r\n### Manual testing scenarios\r\n<!--- Provide a set of unambiguous steps to test the proposed code change -->\r\n1. create admin account with locale : en_GB\r\n2. try to create product with used date for example: set new from: 28/09/2017\r\n3. save product\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2017-09-30T09:07:33Z","updated_at":"2017-09-30T21:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d88b295169a1b9daf1c19e8ec9e36dcfc82ac975","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/11156/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/11156/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/11156/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/5515d1d5c5ab58952056ab4640924f8e8539db1a","head":{"label":"cproboscht:issue_10578","ref":"issue_10578","sha":"5515d1d5c5ab58952056ab4640924f8e8539db1a","user":{"login":"cproboscht","id":16148781,"avatar_url":"https://avatars0.githubusercontent.com/u/16148781?v=4","gravatar_id":"","url":"https://api.github.com/users/cproboscht","html_url":"https://github.com/cproboscht","followers_url":"https://api.github.com/users/cproboscht/followers","following_url":"https://api.github.com/users/cproboscht/following{/other_user}","gists_url":"https://api.github.com/users/cproboscht/gists{/gist_id}","starred_url":"https://api.github.com/users/cproboscht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cproboscht/subscriptions","organizations_url":"https://api.github.com/users/cproboscht/orgs","repos_url":"https://api.github.com/users/cproboscht/repos","events_url":"https://api.github.com/users/cproboscht/events{/privacy}","received_events_url":"https://api.github.com/users/cproboscht/received_events","type":"User","site_admin":false},"repo":{"id":105255315,"name":"magento2","full_name":"cproboscht/magento2","owner":{"login":"cproboscht","id":16148781,"avatar_url":"https://avatars0.githubusercontent.com/u/16148781?v=4","gravatar_id":"","url":"https://api.github.com/users/cproboscht","html_url":"https://github.com/cproboscht","followers_url":"https://api.github.com/users/cproboscht/followers","following_url":"https://api.github.com/users/cproboscht/following{/other_user}","gists_url":"https://api.github.com/users/cproboscht/gists{/gist_id}","starred_url":"https://api.github.com/users/cproboscht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cproboscht/subscriptions","organizations_url":"https://api.github.com/users/cproboscht/orgs","repos_url":"https://api.github.com/users/cproboscht/repos","events_url":"https://api.github.com/users/cproboscht/events{/privacy}","received_events_url":"https://api.github.com/users/cproboscht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cproboscht/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/cproboscht/magento2","forks_url":"https://api.github.com/repos/cproboscht/magento2/forks","keys_url":"https://api.github.com/repos/cproboscht/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cproboscht/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cproboscht/magento2/teams","hooks_url":"https://api.github.com/repos/cproboscht/magento2/hooks","issue_events_url":"https://api.github.com/repos/cproboscht/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/cproboscht/magento2/events","assignees_url":"https://api.github.com/repos/cproboscht/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/cproboscht/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/cproboscht/magento2/tags","blobs_url":"https://api.github.com/repos/cproboscht/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cproboscht/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cproboscht/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/cproboscht/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cproboscht/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/cproboscht/magento2/languages","stargazers_url":"https://api.github.com/repos/cproboscht/magento2/stargazers","contributors_url":"https://api.github.com/repos/cproboscht/magento2/contributors","subscribers_url":"https://api.github.com/repos/cproboscht/magento2/subscribers","subscription_url":"https://api.github.com/repos/cproboscht/magento2/subscription","commits_url":"https://api.github.com/repos/cproboscht/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/cproboscht/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/cproboscht/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/cproboscht/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/cproboscht/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/cproboscht/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cproboscht/magento2/merges","archive_url":"https://api.github.com/repos/cproboscht/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cproboscht/magento2/downloads","issues_url":"https://api.github.com/repos/cproboscht/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/cproboscht/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/cproboscht/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/cproboscht/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cproboscht/magento2/labels{/name}","releases_url":"https://api.github.com/repos/cproboscht/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/cproboscht/magento2/deployments","created_at":"2017-09-29T09:31:10Z","updated_at":"2017-09-29T09:32:12Z","pushed_at":"2017-09-30T09:00:39Z","git_url":"git://github.com/cproboscht/magento2.git","ssh_url":"git@github.com:cproboscht/magento2.git","clone_url":"https://github.com/cproboscht/magento2.git","svn_url":"https://github.com/cproboscht/magento2","homepage":"http://www.magento.com","size":392311,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.2-develop"}},"base":{"label":"magento:2.2-develop","ref":"2.2-develop","sha":"9c14af7a97bcf338662de365d2613c7ca9dbf8c6","user":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2017-09-30T18:56:38Z","pushed_at":"2017-09-30T19:43:11Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":392334,"stargazers_count":4785,"watchers_count":4785,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3711,"mirror_url":null,"open_issues_count":1855,"forks":3711,"open_issues":1855,"watchers":4785,"default_branch":"2.2-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/11156"},"html":{"href":"https://github.com/magento/magento2/pull/11156"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/11156"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/11156/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/11156/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/11156/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/5515d1d5c5ab58952056ab4640924f8e8539db1a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"orlangur"}}