{"action":"closed","number":2093,"pull_request":{"url":"https://api.github.com/repos/open-keychain/open-keychain/pulls/2093","id":117339565,"html_url":"https://github.com/open-keychain/open-keychain/pull/2093","diff_url":"https://github.com/open-keychain/open-keychain/pull/2093.diff","patch_url":"https://github.com/open-keychain/open-keychain/pull/2093.patch","issue_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/2093","number":2093,"state":"closed","locked":false,"title":"Key Status Card","user":{"login":"Valodim","id":27813,"avatar_url":"https://avatars0.githubusercontent.com/u/27813?v=3","gravatar_id":"","url":"https://api.github.com/users/Valodim","html_url":"https://github.com/Valodim","followers_url":"https://api.github.com/users/Valodim/followers","following_url":"https://api.github.com/users/Valodim/following{/other_user}","gists_url":"https://api.github.com/users/Valodim/gists{/gist_id}","starred_url":"https://api.github.com/users/Valodim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Valodim/subscriptions","organizations_url":"https://api.github.com/users/Valodim/orgs","repos_url":"https://api.github.com/users/Valodim/repos","events_url":"https://api.github.com/users/Valodim/events{/privacy}","received_events_url":"https://api.github.com/users/Valodim/received_events","type":"User","site_admin":false},"body":"This is a follow-up to #1450. It adds a \"key status\" card to key view, that displays a summary of key health. I think it came together rather nicely.\r\n\r\nI'm fairly happy with the summary info at this point, and if there are problems with the primary key (revoked,expired, insecure, ...) then subkey state is never displayed. The per-subkey state could use some more work, and there is no distinction yet between the user's own keys or other keys.\r\n\r\nOne more thing we should also rethink is the status string up in the toolbar, which is now redundant information (see screenshots).\r\n\r\n## Screenshots:\r\n![](https://matrix.org/_matrix/media/v1/download/stratum0.org/wLmWQuNwmAFPzFyYiZLHPGGK)\r\n![](https://matrix.org/_matrix/media/v1/download/stratum0.org/CprFAsigqXEDyEHUXBHfaFaz)\r\n![](https://matrix.org/_matrix/media/v1/download/stratum0.org/hApdMIzxLpMDbHYXrZLpqjTy)\r\n\r\n## Types of changes\r\n- ✅ New feature (non-breaking change which adds functionality)\r\n","created_at":"2017-04-24T19:30:20Z","updated_at":"2017-04-26T07:45:58Z","closed_at":"2017-04-26T07:45:58Z","merged_at":"2017-04-26T07:45:58Z","merge_commit_sha":"8738862f0919867fee1c29b34eabce634a396eb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-keychain/open-keychain/pulls/2093/commits","review_comments_url":"https://api.github.com/repos/open-keychain/open-keychain/pulls/2093/comments","review_comment_url":"https://api.github.com/repos/open-keychain/open-keychain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/2093/comments","statuses_url":"https://api.github.com/repos/open-keychain/open-keychain/statuses/542e0733cb267e165fa02d00e58fa46c61612548","head":{"label":"open-keychain:key-status","ref":"key-status","sha":"542e0733cb267e165fa02d00e58fa46c61612548","user":{"login":"open-keychain","id":6513445,"avatar_url":"https://avatars2.githubusercontent.com/u/6513445?v=3","gravatar_id":"","url":"https://api.github.com/users/open-keychain","html_url":"https://github.com/open-keychain","followers_url":"https://api.github.com/users/open-keychain/followers","following_url":"https://api.github.com/users/open-keychain/following{/other_user}","gists_url":"https://api.github.com/users/open-keychain/gists{/gist_id}","starred_url":"https://api.github.com/users/open-keychain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-keychain/subscriptions","organizations_url":"https://api.github.com/users/open-keychain/orgs","repos_url":"https://api.github.com/users/open-keychain/repos","events_url":"https://api.github.com/users/open-keychain/events{/privacy}","received_events_url":"https://api.github.com/users/open-keychain/received_events","type":"Organization","site_admin":false},"repo":{"id":3669065,"name":"open-keychain","full_name":"open-keychain/open-keychain","owner":{"login":"open-keychain","id":6513445,"avatar_url":"https://avatars2.githubusercontent.com/u/6513445?v=3","gravatar_id":"","url":"https://api.github.com/users/open-keychain","html_url":"https://github.com/open-keychain","followers_url":"https://api.github.com/users/open-keychain/followers","following_url":"https://api.github.com/users/open-keychain/following{/other_user}","gists_url":"https://api.github.com/users/open-keychain/gists{/gist_id}","starred_url":"https://api.github.com/users/open-keychain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-keychain/subscriptions","organizations_url":"https://api.github.com/users/open-keychain/orgs","repos_url":"https://api.github.com/users/open-keychain/repos","events_url":"https://api.github.com/users/open-keychain/events{/privacy}","received_events_url":"https://api.github.com/users/open-keychain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-keychain/open-keychain","description":"OpenKeychain is an OpenPGP implementation for Android.","fork":false,"url":"https://api.github.com/repos/open-keychain/open-keychain","forks_url":"https://api.github.com/repos/open-keychain/open-keychain/forks","keys_url":"https://api.github.com/repos/open-keychain/open-keychain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-keychain/open-keychain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-keychain/open-keychain/teams","hooks_url":"https://api.github.com/repos/open-keychain/open-keychain/hooks","issue_events_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/events{/number}","events_url":"https://api.github.com/repos/open-keychain/open-keychain/events","assignees_url":"https://api.github.com/repos/open-keychain/open-keychain/assignees{/user}","branches_url":"https://api.github.com/repos/open-keychain/open-keychain/branches{/branch}","tags_url":"https://api.github.com/repos/open-keychain/open-keychain/tags","blobs_url":"https://api.github.com/repos/open-keychain/open-keychain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-keychain/open-keychain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-keychain/open-keychain/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-keychain/open-keychain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-keychain/open-keychain/statuses/{sha}","languages_url":"https://api.github.com/repos/open-keychain/open-keychain/languages","stargazers_url":"https://api.github.com/repos/open-keychain/open-keychain/stargazers","contributors_url":"https://api.github.com/repos/open-keychain/open-keychain/contributors","subscribers_url":"https://api.github.com/repos/open-keychain/open-keychain/subscribers","subscription_url":"https://api.github.com/repos/open-keychain/open-keychain/subscription","commits_url":"https://api.github.com/repos/open-keychain/open-keychain/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-keychain/open-keychain/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-keychain/open-keychain/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-keychain/open-keychain/contents/{+path}","compare_url":"https://api.github.com/repos/open-keychain/open-keychain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-keychain/open-keychain/merges","archive_url":"https://api.github.com/repos/open-keychain/open-keychain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-keychain/open-keychain/downloads","issues_url":"https://api.github.com/repos/open-keychain/open-keychain/issues{/number}","pulls_url":"https://api.github.com/repos/open-keychain/open-keychain/pulls{/number}","milestones_url":"https://api.github.com/repos/open-keychain/open-keychain/milestones{/number}","notifications_url":"https://api.github.com/repos/open-keychain/open-keychain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-keychain/open-keychain/labels{/name}","releases_url":"https://api.github.com/repos/open-keychain/open-keychain/releases{/id}","deployments_url":"https://api.github.com/repos/open-keychain/open-keychain/deployments","created_at":"2012-03-09T09:10:42Z","updated_at":"2017-04-20T07:24:39Z","pushed_at":"2017-04-26T07:45:58Z","git_url":"git://github.com/open-keychain/open-keychain.git","ssh_url":"git@github.com:open-keychain/open-keychain.git","clone_url":"https://github.com/open-keychain/open-keychain.git","svn_url":"https://github.com/open-keychain/open-keychain","homepage":"https://www.openkeychain.org","size":74659,"stargazers_count":801,"watchers_count":801,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":317,"mirror_url":null,"open_issues_count":201,"forks":317,"open_issues":201,"watchers":801,"default_branch":"master"}},"base":{"label":"open-keychain:master","ref":"master","sha":"c59a570a27450db7fd0b34636b65e9caea8b6d44","user":{"login":"open-keychain","id":6513445,"avatar_url":"https://avatars2.githubusercontent.com/u/6513445?v=3","gravatar_id":"","url":"https://api.github.com/users/open-keychain","html_url":"https://github.com/open-keychain","followers_url":"https://api.github.com/users/open-keychain/followers","following_url":"https://api.github.com/users/open-keychain/following{/other_user}","gists_url":"https://api.github.com/users/open-keychain/gists{/gist_id}","starred_url":"https://api.github.com/users/open-keychain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-keychain/subscriptions","organizations_url":"https://api.github.com/users/open-keychain/orgs","repos_url":"https://api.github.com/users/open-keychain/repos","events_url":"https://api.github.com/users/open-keychain/events{/privacy}","received_events_url":"https://api.github.com/users/open-keychain/received_events","type":"Organization","site_admin":false},"repo":{"id":3669065,"name":"open-keychain","full_name":"open-keychain/open-keychain","owner":{"login":"open-keychain","id":6513445,"avatar_url":"https://avatars2.githubusercontent.com/u/6513445?v=3","gravatar_id":"","url":"https://api.github.com/users/open-keychain","html_url":"https://github.com/open-keychain","followers_url":"https://api.github.com/users/open-keychain/followers","following_url":"https://api.github.com/users/open-keychain/following{/other_user}","gists_url":"https://api.github.com/users/open-keychain/gists{/gist_id}","starred_url":"https://api.github.com/users/open-keychain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-keychain/subscriptions","organizations_url":"https://api.github.com/users/open-keychain/orgs","repos_url":"https://api.github.com/users/open-keychain/repos","events_url":"https://api.github.com/users/open-keychain/events{/privacy}","received_events_url":"https://api.github.com/users/open-keychain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-keychain/open-keychain","description":"OpenKeychain is an OpenPGP implementation for Android.","fork":false,"url":"https://api.github.com/repos/open-keychain/open-keychain","forks_url":"https://api.github.com/repos/open-keychain/open-keychain/forks","keys_url":"https://api.github.com/repos/open-keychain/open-keychain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-keychain/open-keychain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-keychain/open-keychain/teams","hooks_url":"https://api.github.com/repos/open-keychain/open-keychain/hooks","issue_events_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/events{/number}","events_url":"https://api.github.com/repos/open-keychain/open-keychain/events","assignees_url":"https://api.github.com/repos/open-keychain/open-keychain/assignees{/user}","branches_url":"https://api.github.com/repos/open-keychain/open-keychain/branches{/branch}","tags_url":"https://api.github.com/repos/open-keychain/open-keychain/tags","blobs_url":"https://api.github.com/repos/open-keychain/open-keychain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-keychain/open-keychain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-keychain/open-keychain/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-keychain/open-keychain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-keychain/open-keychain/statuses/{sha}","languages_url":"https://api.github.com/repos/open-keychain/open-keychain/languages","stargazers_url":"https://api.github.com/repos/open-keychain/open-keychain/stargazers","contributors_url":"https://api.github.com/repos/open-keychain/open-keychain/contributors","subscribers_url":"https://api.github.com/repos/open-keychain/open-keychain/subscribers","subscription_url":"https://api.github.com/repos/open-keychain/open-keychain/subscription","commits_url":"https://api.github.com/repos/open-keychain/open-keychain/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-keychain/open-keychain/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-keychain/open-keychain/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-keychain/open-keychain/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-keychain/open-keychain/contents/{+path}","compare_url":"https://api.github.com/repos/open-keychain/open-keychain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-keychain/open-keychain/merges","archive_url":"https://api.github.com/repos/open-keychain/open-keychain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-keychain/open-keychain/downloads","issues_url":"https://api.github.com/repos/open-keychain/open-keychain/issues{/number}","pulls_url":"https://api.github.com/repos/open-keychain/open-keychain/pulls{/number}","milestones_url":"https://api.github.com/repos/open-keychain/open-keychain/milestones{/number}","notifications_url":"https://api.github.com/repos/open-keychain/open-keychain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-keychain/open-keychain/labels{/name}","releases_url":"https://api.github.com/repos/open-keychain/open-keychain/releases{/id}","deployments_url":"https://api.github.com/repos/open-keychain/open-keychain/deployments","created_at":"2012-03-09T09:10:42Z","updated_at":"2017-04-20T07:24:39Z","pushed_at":"2017-04-26T07:45:58Z","git_url":"git://github.com/open-keychain/open-keychain.git","ssh_url":"git@github.com:open-keychain/open-keychain.git","clone_url":"https://github.com/open-keychain/open-keychain.git","svn_url":"https://github.com/open-keychain/open-keychain","homepage":"https://www.openkeychain.org","size":74659,"stargazers_count":801,"watchers_count":801,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":317,"mirror_url":null,"open_issues_count":201,"forks":317,"open_issues":201,"watchers":801,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-keychain/open-keychain/pulls/2093"},"html":{"href":"https://github.com/open-keychain/open-keychain/pull/2093"},"issue":{"href":"https://api.github.com/repos/open-keychain/open-keychain/issues/2093"},"comments":{"href":"https://api.github.com/repos/open-keychain/open-keychain/issues/2093/comments"},"review_comments":{"href":"https://api.github.com/repos/open-keychain/open-keychain/pulls/2093/comments"},"review_comment":{"href":"https://api.github.com/repos/open-keychain/open-keychain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-keychain/open-keychain/pulls/2093/commits"},"statuses":{"href":"https://api.github.com/repos/open-keychain/open-keychain/statuses/542e0733cb267e165fa02d00e58fa46c61612548"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dschuermann","id":321888,"avatar_url":"https://avatars0.githubusercontent.com/u/321888?v=3","gravatar_id":"","url":"https://api.github.com/users/dschuermann","html_url":"https://github.com/dschuermann","followers_url":"https://api.github.com/users/dschuermann/followers","following_url":"https://api.github.com/users/dschuermann/following{/other_user}","gists_url":"https://api.github.com/users/dschuermann/gists{/gist_id}","starred_url":"https://api.github.com/users/dschuermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschuermann/subscriptions","organizations_url":"https://api.github.com/users/dschuermann/orgs","repos_url":"https://api.github.com/users/dschuermann/repos","events_url":"https://api.github.com/users/dschuermann/events{/privacy}","received_events_url":"https://api.github.com/users/dschuermann/received_events","type":"User","site_admin":false},"comments":5,"review_comments":5,"maintainer_can_modify":false,"commits":8,"additions":1699,"deletions":195,"changed_files":29}}
{"actor":{"display_login":"dschuermann"}}