{"action":"created","comment":{"url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/comments/146699144","pull_request_review_id":71679595,"id":146699144,"diff_hunk":"@@ -44,6 +44,40 @@ eslintTester.run('avoid-leaking-state-in-components', rule, {\n       code: 'export default Component.extend({ classNames: [], classNameBindings: [], actions: {}, concatenatedProperties: [], mergedProperties: [], positionalParams: [] });',\n       parserOptions: { ecmaVersion: 6, sourceType: 'module' },\n     },\n+\n+    {\n+      code: 'export default Foo.extend();',\n+      parserOptions: { ecmaVersion: 6, sourceType: 'module' },\n+    },\n+    {\n+      code: 'export default Foo.extend({ someProp: \"example\", init() { this.set(\"anotherProp\", []) } });',\n+      parserOptions: { ecmaVersion: 6, sourceType: 'module' },\n+    },\n+    {\n+      code: 'export default Foo.extend({ someProp: \"example\", init() { this.set(\"anotherProp\", {}) } });',\n+      parserOptions: { ecmaVersion: 6, sourceType: 'module' },\n+    },\n+    {\n+      code: 'export default Foo.extend({ someProp: \"example\", init() { this.set(\"anotherProp\", new Ember.A()) } });',","path":"tests/lib/rules/avoid-leaking-state-in-ember-objects.js","position":36,"original_position":36,"commit_id":"f75de38b97063b9d3317821084afe01e2de9c29f","original_commit_id":"f75de38b97063b9d3317821084afe01e2de9c29f","user":{"login":"nlfurniss","id":1477357,"avatar_url":"https://avatars3.githubusercontent.com/u/1477357?v=4","gravatar_id":"","url":"https://api.github.com/users/nlfurniss","html_url":"https://github.com/nlfurniss","followers_url":"https://api.github.com/users/nlfurniss/followers","following_url":"https://api.github.com/users/nlfurniss/following{/other_user}","gists_url":"https://api.github.com/users/nlfurniss/gists{/gist_id}","starred_url":"https://api.github.com/users/nlfurniss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlfurniss/subscriptions","organizations_url":"https://api.github.com/users/nlfurniss/orgs","repos_url":"https://api.github.com/users/nlfurniss/repos","events_url":"https://api.github.com/users/nlfurniss/events{/privacy}","received_events_url":"https://api.github.com/users/nlfurniss/received_events","type":"User","site_admin":false},"body":"you should use template literals so you can format the code on multiple lines and make it waaay easier to read. [Like this](https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/tests/lib/rules/no-attrs.js#L14)","created_at":"2017-10-24T21:33:11Z","updated_at":"2017-10-24T21:33:36Z","html_url":"https://github.com/ember-cli/eslint-plugin-ember/pull/156#discussion_r146699144","pull_request_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/156","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/comments/146699144"},"html":{"href":"https://github.com/ember-cli/eslint-plugin-ember/pull/156#discussion_r146699144"},"pull_request":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/156","id":148512274,"html_url":"https://github.com/ember-cli/eslint-plugin-ember/pull/156","diff_url":"https://github.com/ember-cli/eslint-plugin-ember/pull/156.diff","patch_url":"https://github.com/ember-cli/eslint-plugin-ember/pull/156.patch","issue_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/issues/156","number":156,"state":"open","locked":false,"title":"updated avoid-leaking-state rule to work for all kind of ember object","user":{"login":"shegupta","id":26234643,"avatar_url":"https://avatars2.githubusercontent.com/u/26234643?v=4","gravatar_id":"","url":"https://api.github.com/users/shegupta","html_url":"https://github.com/shegupta","followers_url":"https://api.github.com/users/shegupta/followers","following_url":"https://api.github.com/users/shegupta/following{/other_user}","gists_url":"https://api.github.com/users/shegupta/gists{/gist_id}","starred_url":"https://api.github.com/users/shegupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shegupta/subscriptions","organizations_url":"https://api.github.com/users/shegupta/orgs","repos_url":"https://api.github.com/users/shegupta/repos","events_url":"https://api.github.com/users/shegupta/events{/privacy}","received_events_url":"https://api.github.com/users/shegupta/received_events","type":"User","site_admin":false},"body":"Currently, we have lint rule set up to catch these issues only for ember components, extending that rule to cover all sort of ember objects like:  \r\nComponents, Routes, Controllers, Services and any other object which uses extend (ex Foo.extend({}).\r\n\r\n","created_at":"2017-10-24T21:02:21Z","updated_at":"2017-10-24T21:33:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f75ef7637fd3915f872149d98882a5b090da5d5a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/156/commits","review_comments_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/156/comments","review_comment_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/issues/156/comments","statuses_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/statuses/f75de38b97063b9d3317821084afe01e2de9c29f","head":{"label":"shegupta:update_rules","ref":"update_rules","sha":"f75de38b97063b9d3317821084afe01e2de9c29f","user":{"login":"shegupta","id":26234643,"avatar_url":"https://avatars2.githubusercontent.com/u/26234643?v=4","gravatar_id":"","url":"https://api.github.com/users/shegupta","html_url":"https://github.com/shegupta","followers_url":"https://api.github.com/users/shegupta/followers","following_url":"https://api.github.com/users/shegupta/following{/other_user}","gists_url":"https://api.github.com/users/shegupta/gists{/gist_id}","starred_url":"https://api.github.com/users/shegupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shegupta/subscriptions","organizations_url":"https://api.github.com/users/shegupta/orgs","repos_url":"https://api.github.com/users/shegupta/repos","events_url":"https://api.github.com/users/shegupta/events{/privacy}","received_events_url":"https://api.github.com/users/shegupta/received_events","type":"User","site_admin":false},"repo":{"id":108018759,"name":"eslint-plugin-ember","full_name":"shegupta/eslint-plugin-ember","owner":{"login":"shegupta","id":26234643,"avatar_url":"https://avatars2.githubusercontent.com/u/26234643?v=4","gravatar_id":"","url":"https://api.github.com/users/shegupta","html_url":"https://github.com/shegupta","followers_url":"https://api.github.com/users/shegupta/followers","following_url":"https://api.github.com/users/shegupta/following{/other_user}","gists_url":"https://api.github.com/users/shegupta/gists{/gist_id}","starred_url":"https://api.github.com/users/shegupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shegupta/subscriptions","organizations_url":"https://api.github.com/users/shegupta/orgs","repos_url":"https://api.github.com/users/shegupta/repos","events_url":"https://api.github.com/users/shegupta/events{/privacy}","received_events_url":"https://api.github.com/users/shegupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shegupta/eslint-plugin-ember","description":"An ESlint plugin that provides set of rules for Ember Applications based on commonly known good practices.","fork":true,"url":"https://api.github.com/repos/shegupta/eslint-plugin-ember","forks_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/forks","keys_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/teams","hooks_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/hooks","issue_events_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/issues/events{/number}","events_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/events","assignees_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/assignees{/user}","branches_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/branches{/branch}","tags_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/tags","blobs_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/git/refs{/sha}","trees_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/statuses/{sha}","languages_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/languages","stargazers_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/stargazers","contributors_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/contributors","subscribers_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/subscribers","subscription_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/subscription","commits_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/commits{/sha}","git_commits_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/git/commits{/sha}","comments_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/comments{/number}","issue_comment_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/issues/comments{/number}","contents_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/contents/{+path}","compare_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/merges","archive_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/downloads","issues_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/issues{/number}","pulls_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/pulls{/number}","milestones_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/milestones{/number}","notifications_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/labels{/name}","releases_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/releases{/id}","deployments_url":"https://api.github.com/repos/shegupta/eslint-plugin-ember/deployments","created_at":"2017-10-23T17:57:29Z","updated_at":"2017-10-23T17:57:31Z","pushed_at":"2017-10-24T20:55:43Z","git_url":"git://github.com/shegupta/eslint-plugin-ember.git","ssh_url":"git@github.com:shegupta/eslint-plugin-ember.git","clone_url":"https://github.com/shegupta/eslint-plugin-ember.git","svn_url":"https://github.com/shegupta/eslint-plugin-ember","homepage":"","size":426,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ember-cli:master","ref":"master","sha":"da5faeebbafdfc34bdcd1429bb91b10185c52e63","user":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars3.githubusercontent.com/u/10262982?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":75928556,"name":"eslint-plugin-ember","full_name":"ember-cli/eslint-plugin-ember","owner":{"login":"ember-cli","id":10262982,"avatar_url":"https://avatars3.githubusercontent.com/u/10262982?v=4","gravatar_id":"","url":"https://api.github.com/users/ember-cli","html_url":"https://github.com/ember-cli","followers_url":"https://api.github.com/users/ember-cli/followers","following_url":"https://api.github.com/users/ember-cli/following{/other_user}","gists_url":"https://api.github.com/users/ember-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/ember-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ember-cli/subscriptions","organizations_url":"https://api.github.com/users/ember-cli/orgs","repos_url":"https://api.github.com/users/ember-cli/repos","events_url":"https://api.github.com/users/ember-cli/events{/privacy}","received_events_url":"https://api.github.com/users/ember-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ember-cli/eslint-plugin-ember","description":"An ESlint plugin that provides set of rules for Ember Applications based on commonly known good practices.","fork":false,"url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember","forks_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/forks","keys_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/teams","hooks_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/hooks","issue_events_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/issues/events{/number}","events_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/events","assignees_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/assignees{/user}","branches_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/branches{/branch}","tags_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/tags","blobs_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/git/refs{/sha}","trees_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/statuses/{sha}","languages_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/languages","stargazers_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/stargazers","contributors_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/contributors","subscribers_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/subscribers","subscription_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/subscription","commits_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/commits{/sha}","git_commits_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/git/commits{/sha}","comments_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/comments{/number}","issue_comment_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/issues/comments{/number}","contents_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/contents/{+path}","compare_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/merges","archive_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/downloads","issues_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/issues{/number}","pulls_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls{/number}","milestones_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/milestones{/number}","notifications_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/labels{/name}","releases_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/releases{/id}","deployments_url":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/deployments","created_at":"2016-12-08T10:40:40Z","updated_at":"2017-10-24T15:31:47Z","pushed_at":"2017-10-24T21:02:22Z","git_url":"git://github.com/ember-cli/eslint-plugin-ember.git","ssh_url":"git@github.com:ember-cli/eslint-plugin-ember.git","clone_url":"https://github.com/ember-cli/eslint-plugin-ember.git","svn_url":"https://github.com/ember-cli/eslint-plugin-ember","homepage":"","size":406,"stargazers_count":123,"watchers_count":123,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":46,"open_issues":25,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/156"},"html":{"href":"https://github.com/ember-cli/eslint-plugin-ember/pull/156"},"issue":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/issues/156"},"comments":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/ember-cli/eslint-plugin-ember/statuses/f75de38b97063b9d3317821084afe01e2de9c29f"}},"author_association":"NONE"}}
{"actor":{"display_login":"nlfurniss"}}