{"action":"created","comment":{"url":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments/144342352","pull_request_review_id":68986930,"id":144342352,"diff_hunk":"@@ -358,22 +522,47 @@ private void testTabbedColumnsSort(String listTarget) {\n     Set<String> tabHeadings = page.getTabHeadings();\n     tabHeadings.forEach(tabHeading -> {\n       page.clickTab(tabHeading);\n-      assertTrue(\"clicked tab without errors\", LimsUtils.isStringEmptyOrNull(page.getErrors().getText()));\n+      assertTrue(\"clicked tab without errors\", isStringEmptyOrNull(page.getErrors().getText()));\n     });\n   }\n \n+  private void testSearch(String listTarget, String searchTarget) {\n+    // confirm that searching by a term returns no errors\n+    ListPage page = getList(listTarget);\n+    page.getTable().searchFor(searchTarget);\n+    assertTrue(\"error searching \" + listTarget + \" page for '\" + searchTarget + \"': \", isStringEmptyOrNull(page.getErrors().getText()));","path":"miso-web/src/it/java/uk/ac/bbsrc/tgac/miso/webapp/integrationtest/ListTablesIT.java","position":305,"original_position":305,"commit_id":"88748b5b93739c69aef53bcb5acbf1e42166ae33","original_commit_id":"88748b5b93739c69aef53bcb5acbf1e42166ae33","user":{"login":"callunity","id":8324996,"avatar_url":"https://avatars2.githubusercontent.com/u/8324996?v=4","gravatar_id":"","url":"https://api.github.com/users/callunity","html_url":"https://github.com/callunity","followers_url":"https://api.github.com/users/callunity/followers","following_url":"https://api.github.com/users/callunity/following{/other_user}","gists_url":"https://api.github.com/users/callunity/gists{/gist_id}","starred_url":"https://api.github.com/users/callunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callunity/subscriptions","organizations_url":"https://api.github.com/users/callunity/orgs","repos_url":"https://api.github.com/users/callunity/repos","events_url":"https://api.github.com/users/callunity/events{/privacy}","received_events_url":"https://api.github.com/users/callunity/received_events","type":"User","site_admin":false},"body":"As per our conversation, I've made a ticket to write unit tests for the Pagination Filters, as unit tests will run faster and can be less brittle.","created_at":"2017-10-12T16:31:05Z","updated_at":"2017-10-12T16:31:05Z","html_url":"https://github.com/TGAC/miso-lims/pull/1167#discussion_r144342352","pull_request_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/1167","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments/144342352"},"html":{"href":"https://github.com/TGAC/miso-lims/pull/1167#discussion_r144342352"},"pull_request":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/1167"}},"in_reply_to_id":144327389},"pull_request":{"url":"https://api.github.com/repos/TGAC/miso-lims/pulls/1167","id":146050202,"html_url":"https://github.com/TGAC/miso-lims/pull/1167","diff_url":"https://github.com/TGAC/miso-lims/pull/1167.diff","patch_url":"https://github.com/TGAC/miso-lims/pull/1167.patch","issue_url":"https://api.github.com/repos/TGAC/miso-lims/issues/1167","number":1167,"state":"open","locked":false,"title":"integration test table search","user":{"login":"callunity","id":8324996,"avatar_url":"https://avatars2.githubusercontent.com/u/8324996?v=4","gravatar_id":"","url":"https://api.github.com/users/callunity","html_url":"https://github.com/callunity","followers_url":"https://api.github.com/users/callunity/followers","following_url":"https://api.github.com/users/callunity/following{/other_user}","gists_url":"https://api.github.com/users/callunity/gists{/gist_id}","starred_url":"https://api.github.com/users/callunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callunity/subscriptions","organizations_url":"https://api.github.com/users/callunity/orgs","repos_url":"https://api.github.com/users/callunity/repos","events_url":"https://api.github.com/users/callunity/events{/privacy}","received_events_url":"https://api.github.com/users/callunity/received_events","type":"User","site_admin":false},"body":"GLT-1954","created_at":"2017-10-11T20:13:06Z","updated_at":"2017-10-12T16:31:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"327efc077a143a5988bbc2564ca7f121cb395e61","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/1167/commits","review_comments_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/1167/comments","review_comment_url":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TGAC/miso-lims/issues/1167/comments","statuses_url":"https://api.github.com/repos/TGAC/miso-lims/statuses/88748b5b93739c69aef53bcb5acbf1e42166ae33","head":{"label":"TGAC:GLT-1954_test_search","ref":"GLT-1954_test_search","sha":"88748b5b93739c69aef53bcb5acbf1e42166ae33","user":{"login":"TGAC","id":1872319,"avatar_url":"https://avatars2.githubusercontent.com/u/1872319?v=4","gravatar_id":"","url":"https://api.github.com/users/TGAC","html_url":"https://github.com/TGAC","followers_url":"https://api.github.com/users/TGAC/followers","following_url":"https://api.github.com/users/TGAC/following{/other_user}","gists_url":"https://api.github.com/users/TGAC/gists{/gist_id}","starred_url":"https://api.github.com/users/TGAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGAC/subscriptions","organizations_url":"https://api.github.com/users/TGAC/orgs","repos_url":"https://api.github.com/users/TGAC/repos","events_url":"https://api.github.com/users/TGAC/events{/privacy}","received_events_url":"https://api.github.com/users/TGAC/received_events","type":"Organization","site_admin":false},"repo":{"id":4726428,"name":"miso-lims","full_name":"TGAC/miso-lims","owner":{"login":"TGAC","id":1872319,"avatar_url":"https://avatars2.githubusercontent.com/u/1872319?v=4","gravatar_id":"","url":"https://api.github.com/users/TGAC","html_url":"https://github.com/TGAC","followers_url":"https://api.github.com/users/TGAC/followers","following_url":"https://api.github.com/users/TGAC/following{/other_user}","gists_url":"https://api.github.com/users/TGAC/gists{/gist_id}","starred_url":"https://api.github.com/users/TGAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGAC/subscriptions","organizations_url":"https://api.github.com/users/TGAC/orgs","repos_url":"https://api.github.com/users/TGAC/repos","events_url":"https://api.github.com/users/TGAC/events{/privacy}","received_events_url":"https://api.github.com/users/TGAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TGAC/miso-lims","description":"MISO: An open-source LIMS for NGS sequencing centres","fork":false,"url":"https://api.github.com/repos/TGAC/miso-lims","forks_url":"https://api.github.com/repos/TGAC/miso-lims/forks","keys_url":"https://api.github.com/repos/TGAC/miso-lims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TGAC/miso-lims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TGAC/miso-lims/teams","hooks_url":"https://api.github.com/repos/TGAC/miso-lims/hooks","issue_events_url":"https://api.github.com/repos/TGAC/miso-lims/issues/events{/number}","events_url":"https://api.github.com/repos/TGAC/miso-lims/events","assignees_url":"https://api.github.com/repos/TGAC/miso-lims/assignees{/user}","branches_url":"https://api.github.com/repos/TGAC/miso-lims/branches{/branch}","tags_url":"https://api.github.com/repos/TGAC/miso-lims/tags","blobs_url":"https://api.github.com/repos/TGAC/miso-lims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TGAC/miso-lims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TGAC/miso-lims/git/refs{/sha}","trees_url":"https://api.github.com/repos/TGAC/miso-lims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TGAC/miso-lims/statuses/{sha}","languages_url":"https://api.github.com/repos/TGAC/miso-lims/languages","stargazers_url":"https://api.github.com/repos/TGAC/miso-lims/stargazers","contributors_url":"https://api.github.com/repos/TGAC/miso-lims/contributors","subscribers_url":"https://api.github.com/repos/TGAC/miso-lims/subscribers","subscription_url":"https://api.github.com/repos/TGAC/miso-lims/subscription","commits_url":"https://api.github.com/repos/TGAC/miso-lims/commits{/sha}","git_commits_url":"https://api.github.com/repos/TGAC/miso-lims/git/commits{/sha}","comments_url":"https://api.github.com/repos/TGAC/miso-lims/comments{/number}","issue_comment_url":"https://api.github.com/repos/TGAC/miso-lims/issues/comments{/number}","contents_url":"https://api.github.com/repos/TGAC/miso-lims/contents/{+path}","compare_url":"https://api.github.com/repos/TGAC/miso-lims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TGAC/miso-lims/merges","archive_url":"https://api.github.com/repos/TGAC/miso-lims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TGAC/miso-lims/downloads","issues_url":"https://api.github.com/repos/TGAC/miso-lims/issues{/number}","pulls_url":"https://api.github.com/repos/TGAC/miso-lims/pulls{/number}","milestones_url":"https://api.github.com/repos/TGAC/miso-lims/milestones{/number}","notifications_url":"https://api.github.com/repos/TGAC/miso-lims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TGAC/miso-lims/labels{/name}","releases_url":"https://api.github.com/repos/TGAC/miso-lims/releases{/id}","deployments_url":"https://api.github.com/repos/TGAC/miso-lims/deployments","created_at":"2012-06-20T13:17:28Z","updated_at":"2017-10-05T18:44:44Z","pushed_at":"2017-10-12T14:15:28Z","git_url":"git://github.com/TGAC/miso-lims.git","ssh_url":"git@github.com:TGAC/miso-lims.git","clone_url":"https://github.com/TGAC/miso-lims.git","svn_url":"https://github.com/TGAC/miso-lims","homepage":"http://tgac.github.io/miso-lims/","size":109339,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":5,"forks":31,"open_issues":5,"watchers":59,"default_branch":"develop"}},"base":{"label":"TGAC:develop","ref":"develop","sha":"d313a8f72b938a1dec8e8bea60f10ba7f875af59","user":{"login":"TGAC","id":1872319,"avatar_url":"https://avatars2.githubusercontent.com/u/1872319?v=4","gravatar_id":"","url":"https://api.github.com/users/TGAC","html_url":"https://github.com/TGAC","followers_url":"https://api.github.com/users/TGAC/followers","following_url":"https://api.github.com/users/TGAC/following{/other_user}","gists_url":"https://api.github.com/users/TGAC/gists{/gist_id}","starred_url":"https://api.github.com/users/TGAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGAC/subscriptions","organizations_url":"https://api.github.com/users/TGAC/orgs","repos_url":"https://api.github.com/users/TGAC/repos","events_url":"https://api.github.com/users/TGAC/events{/privacy}","received_events_url":"https://api.github.com/users/TGAC/received_events","type":"Organization","site_admin":false},"repo":{"id":4726428,"name":"miso-lims","full_name":"TGAC/miso-lims","owner":{"login":"TGAC","id":1872319,"avatar_url":"https://avatars2.githubusercontent.com/u/1872319?v=4","gravatar_id":"","url":"https://api.github.com/users/TGAC","html_url":"https://github.com/TGAC","followers_url":"https://api.github.com/users/TGAC/followers","following_url":"https://api.github.com/users/TGAC/following{/other_user}","gists_url":"https://api.github.com/users/TGAC/gists{/gist_id}","starred_url":"https://api.github.com/users/TGAC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TGAC/subscriptions","organizations_url":"https://api.github.com/users/TGAC/orgs","repos_url":"https://api.github.com/users/TGAC/repos","events_url":"https://api.github.com/users/TGAC/events{/privacy}","received_events_url":"https://api.github.com/users/TGAC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TGAC/miso-lims","description":"MISO: An open-source LIMS for NGS sequencing centres","fork":false,"url":"https://api.github.com/repos/TGAC/miso-lims","forks_url":"https://api.github.com/repos/TGAC/miso-lims/forks","keys_url":"https://api.github.com/repos/TGAC/miso-lims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TGAC/miso-lims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TGAC/miso-lims/teams","hooks_url":"https://api.github.com/repos/TGAC/miso-lims/hooks","issue_events_url":"https://api.github.com/repos/TGAC/miso-lims/issues/events{/number}","events_url":"https://api.github.com/repos/TGAC/miso-lims/events","assignees_url":"https://api.github.com/repos/TGAC/miso-lims/assignees{/user}","branches_url":"https://api.github.com/repos/TGAC/miso-lims/branches{/branch}","tags_url":"https://api.github.com/repos/TGAC/miso-lims/tags","blobs_url":"https://api.github.com/repos/TGAC/miso-lims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TGAC/miso-lims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TGAC/miso-lims/git/refs{/sha}","trees_url":"https://api.github.com/repos/TGAC/miso-lims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TGAC/miso-lims/statuses/{sha}","languages_url":"https://api.github.com/repos/TGAC/miso-lims/languages","stargazers_url":"https://api.github.com/repos/TGAC/miso-lims/stargazers","contributors_url":"https://api.github.com/repos/TGAC/miso-lims/contributors","subscribers_url":"https://api.github.com/repos/TGAC/miso-lims/subscribers","subscription_url":"https://api.github.com/repos/TGAC/miso-lims/subscription","commits_url":"https://api.github.com/repos/TGAC/miso-lims/commits{/sha}","git_commits_url":"https://api.github.com/repos/TGAC/miso-lims/git/commits{/sha}","comments_url":"https://api.github.com/repos/TGAC/miso-lims/comments{/number}","issue_comment_url":"https://api.github.com/repos/TGAC/miso-lims/issues/comments{/number}","contents_url":"https://api.github.com/repos/TGAC/miso-lims/contents/{+path}","compare_url":"https://api.github.com/repos/TGAC/miso-lims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TGAC/miso-lims/merges","archive_url":"https://api.github.com/repos/TGAC/miso-lims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TGAC/miso-lims/downloads","issues_url":"https://api.github.com/repos/TGAC/miso-lims/issues{/number}","pulls_url":"https://api.github.com/repos/TGAC/miso-lims/pulls{/number}","milestones_url":"https://api.github.com/repos/TGAC/miso-lims/milestones{/number}","notifications_url":"https://api.github.com/repos/TGAC/miso-lims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TGAC/miso-lims/labels{/name}","releases_url":"https://api.github.com/repos/TGAC/miso-lims/releases{/id}","deployments_url":"https://api.github.com/repos/TGAC/miso-lims/deployments","created_at":"2012-06-20T13:17:28Z","updated_at":"2017-10-05T18:44:44Z","pushed_at":"2017-10-12T14:15:28Z","git_url":"git://github.com/TGAC/miso-lims.git","ssh_url":"git@github.com:TGAC/miso-lims.git","clone_url":"https://github.com/TGAC/miso-lims.git","svn_url":"https://github.com/TGAC/miso-lims","homepage":"http://tgac.github.io/miso-lims/","size":109339,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":5,"forks":31,"open_issues":5,"watchers":59,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/1167"},"html":{"href":"https://github.com/TGAC/miso-lims/pull/1167"},"issue":{"href":"https://api.github.com/repos/TGAC/miso-lims/issues/1167"},"comments":{"href":"https://api.github.com/repos/TGAC/miso-lims/issues/1167/comments"},"review_comments":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/1167/comments"},"review_comment":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TGAC/miso-lims/pulls/1167/commits"},"statuses":{"href":"https://api.github.com/repos/TGAC/miso-lims/statuses/88748b5b93739c69aef53bcb5acbf1e42166ae33"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"callunity"}}