{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/110951393","pull_request_review_id":32158337,"id":110951393,"diff_hunk":"@@ -43,198 +36,239 @@ let postis;\n  */\n let enabled = false;\n \n+/**\n+ * Initializes supported commands.\n+ *\n+ * @returns {void}\n+ */\n function initCommands() {\n     commands = {\n-        \"display-name\":\n+        'display-name':\n             APP.conference.changeLocalDisplayName.bind(APP.conference),\n-        \"toggle-audio\": APP.conference.toggleAudioMuted.bind(APP.conference),\n-        \"toggle-video\": APP.conference.toggleVideoMuted.bind(APP.conference),\n-        \"toggle-film-strip\": APP.UI.toggleFilmStrip,\n-        \"toggle-chat\": APP.UI.toggleChat,\n-        \"toggle-contact-list\": APP.UI.toggleContactList,\n-        \"toggle-share-screen\":\n+        'toggle-audio': APP.conference.toggleAudioMuted.bind(APP.conference),\n+        'toggle-video': APP.conference.toggleVideoMuted.bind(APP.conference),\n+        'toggle-film-strip': APP.UI.toggleFilmStrip,\n+        'toggle-chat': APP.UI.toggleChat,\n+        'toggle-contact-list': APP.UI.toggleContactList,\n+        'toggle-share-screen':\n             APP.conference.toggleScreenSharing.bind(APP.conference),\n-        \"video-hangup\": () => APP.conference.hangup(),\n-        \"email\": APP.conference.changeLocalEmail,\n-        \"avatar-url\": APP.conference.changeLocalAvatarUrl,\n-        \"remote-control-event\": event =>\n+        'video-hangup': () => APP.conference.hangup(),\n+        'email': APP.conference.changeLocalEmail,\n+        'avatar-url': APP.conference.changeLocalAvatarUrl,\n+        'remote-control-event': event =>\n             APP.remoteControl.onRemoteControlAPIEvent(event)\n     };\n-    Object.keys(commands).forEach(function (key) {\n+    Object.keys(commands).forEach(key => {\n         postis.listen(key, args => commands[key](...args));\n     });\n }\n \n /**\n  * Sends message to the external application.\n- * @param message {object}\n- * @param method {string}\n- * @param params {object} the object that will be sent as JSON string\n+ *\n+ * @param {Object} message - The message to be sent.\n+ * @returns {void}\n  */\n function sendMessage(message) {\n-    if(enabled) {\n+    if (enabled) {\n         postis.send(message);\n     }\n }\n \n /**\n  * Check whether the API should be enabled or not.\n+ *\n  * @returns {boolean}\n  */\n-function shouldBeEnabled () {\n-    return (typeof jitsi_meet_external_api_id === \"number\");\n+function shouldBeEnabled() {\n+    return typeof jitsiMeetExternalApiId === 'number';\n }\n \n /**\n  * Sends event object to the external application that has been subscribed\n  * for that event.\n- * @param name the name event\n- * @param object data associated with the event\n+ *\n+ * @param {string} name - The name event.\n+ * @param {Object} object - Data associated with the event.\n+ * @returns {void}\n  */\n-function triggerEvent (name, object) {\n-    if(enabled) {\n-        sendMessage({method: name, params: object});\n+function triggerEvent(name, object) {\n+    if (enabled) {\n+        sendMessage({ method: name,\n+            params: object });\n     }\n }\n \n+/**\n+ * Implements API class that communicates with external api class\n+ * and provides interface to access Jitsi Meet features by external\n+ * applications that embed Jitsi Meet\n+ */\n class API {\n     /**\n-     * Constructs new instance\n-     * @constructor\n-     */\n-    constructor() { }","path":"modules/API/API.js","position":133,"original_position":133,"commit_id":"782eca513826cce6c0750f96a6a292f010c0c45b","original_commit_id":"782eca513826cce6c0750f96a6a292f010c0c45b","user":{"login":"virtuacoplenny","id":1243084,"avatar_url":"https://avatars3.githubusercontent.com/u/1243084?v=3","gravatar_id":"","url":"https://api.github.com/users/virtuacoplenny","html_url":"https://github.com/virtuacoplenny","followers_url":"https://api.github.com/users/virtuacoplenny/followers","following_url":"https://api.github.com/users/virtuacoplenny/following{/other_user}","gists_url":"https://api.github.com/users/virtuacoplenny/gists{/gist_id}","starred_url":"https://api.github.com/users/virtuacoplenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtuacoplenny/subscriptions","organizations_url":"https://api.github.com/users/virtuacoplenny/orgs","repos_url":"https://api.github.com/users/virtuacoplenny/repos","events_url":"https://api.github.com/users/virtuacoplenny/events{/privacy}","received_events_url":"https://api.github.com/users/virtuacoplenny/received_events","type":"User","site_admin":false},"body":"Nice removal. Makes it more obvious this isn't intended to be used with new.","created_at":"2017-04-11T16:34:32Z","updated_at":"2017-04-11T16:42:29Z","html_url":"https://github.com/jitsi/jitsi-meet/pull/1478#discussion_r110951393","pull_request_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/1478","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/110951393"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/1478#discussion_r110951393"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/1478"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/1478","id":114875688,"html_url":"https://github.com/jitsi/jitsi-meet/pull/1478","diff_url":"https://github.com/jitsi/jitsi-meet/pull/1478.diff","patch_url":"https://github.com/jitsi/jitsi-meet/pull/1478.patch","issue_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/1478","number":1478,"state":"open","locked":false,"title":"ref(iframe_api): ESLint support for API.js","user":{"login":"hristoterezov","id":1729265,"avatar_url":"https://avatars0.githubusercontent.com/u/1729265?v=3","gravatar_id":"","url":"https://api.github.com/users/hristoterezov","html_url":"https://github.com/hristoterezov","followers_url":"https://api.github.com/users/hristoterezov/followers","following_url":"https://api.github.com/users/hristoterezov/following{/other_user}","gists_url":"https://api.github.com/users/hristoterezov/gists{/gist_id}","starred_url":"https://api.github.com/users/hristoterezov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hristoterezov/subscriptions","organizations_url":"https://api.github.com/users/hristoterezov/orgs","repos_url":"https://api.github.com/users/hristoterezov/repos","events_url":"https://api.github.com/users/hristoterezov/events{/privacy}","received_events_url":"https://api.github.com/users/hristoterezov/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-07T18:38:11Z","updated_at":"2017-04-11T16:42:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d7472fda10fd8f7adb23668311348a56f8e917a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/1478/commits","review_comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/1478/comments","review_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/1478/comments","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/782eca513826cce6c0750f96a6a292f010c0c45b","head":{"label":"jitsi:api_eslint","ref":"api_eslint","sha":"782eca513826cce6c0750f96a6a292f010c0c45b","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars1.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":15225670,"name":"jitsi-meet","full_name":"jitsi/jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars1.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet","description":"Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.","fork":false,"url":"https://api.github.com/repos/jitsi/jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jitsi-meet/deployments","created_at":"2013-12-16T12:51:09Z","updated_at":"2017-04-11T13:05:22Z","pushed_at":"2017-04-11T16:23:46Z","git_url":"git://github.com/jitsi/jitsi-meet.git","ssh_url":"git@github.com:jitsi/jitsi-meet.git","clone_url":"https://github.com/jitsi/jitsi-meet.git","svn_url":"https://github.com/jitsi/jitsi-meet","homepage":"https://jitsi.org/meet","size":19003,"stargazers_count":1051,"watchers_count":1051,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":452,"mirror_url":null,"open_issues_count":237,"forks":452,"open_issues":237,"watchers":1051,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"6f15903019f98884c0a8b1bad3b659c2c0963e9a","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars1.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":15225670,"name":"jitsi-meet","full_name":"jitsi/jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars1.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet","description":"Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.","fork":false,"url":"https://api.github.com/repos/jitsi/jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jitsi-meet/deployments","created_at":"2013-12-16T12:51:09Z","updated_at":"2017-04-11T13:05:22Z","pushed_at":"2017-04-11T16:23:46Z","git_url":"git://github.com/jitsi/jitsi-meet.git","ssh_url":"git@github.com:jitsi/jitsi-meet.git","clone_url":"https://github.com/jitsi/jitsi-meet.git","svn_url":"https://github.com/jitsi/jitsi-meet","homepage":"https://jitsi.org/meet","size":19003,"stargazers_count":1051,"watchers_count":1051,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":452,"mirror_url":null,"open_issues_count":237,"forks":452,"open_issues":237,"watchers":1051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/1478"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/1478"},"issue":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/1478"},"comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/1478/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/1478/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/1478/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/782eca513826cce6c0750f96a6a292f010c0c45b"}}}}
{"actor":{"display_login":"virtuacoplenny"}}