{"action":"created","comment":{"url":"https://api.github.com/repos/dask/dask/pulls/comments/152390961","pull_request_review_id":78246294,"id":152390961,"diff_hunk":"@@ -597,3 +596,18 @@ def test_parquet_select_cats(tmpdir):\n     assert list(rddf.columns) == ['ints']\n     rddf = dd.read_parquet(fn)\n     assert list(rddf.columns) == list(df)\n+\n+\n+@pytest.mark.parametrize('compression,', ['default', None, 'gzip', 'snappy'])\n+def test_writing_parquet_with_compression(tmpdir, compression, engine):\n+    fn = str(tmpdir)\n+\n+    if engine == 'fastparquet' and compression == 'snappy':\n+        pytest.importorskip('snappy')\n+\n+    df = pd.DataFrame({'x': ['a', 'b', 'c'] * 10, 'y': [1, 2, 3] * 10})\n+    ddf = dd.from_pandas(df, npartitions=3)\n+\n+    ddf.to_parquet(fn, compression=compression, engine=engine)\n+    out = dd.read_parquet(fn, engine=engine)\n+    assert_eq(out, ddf)","path":"dask/dataframe/io/tests/test_parquet.py","position":38,"original_position":38,"commit_id":"ae565f509f65bd7d1ec361909bdc63b08d2ad4b3","original_commit_id":"ae565f509f65bd7d1ec361909bdc63b08d2ad4b3","user":{"login":"castalheiro","id":4572839,"avatar_url":"https://avatars1.githubusercontent.com/u/4572839?v=4","gravatar_id":"","url":"https://api.github.com/users/castalheiro","html_url":"https://github.com/castalheiro","followers_url":"https://api.github.com/users/castalheiro/followers","following_url":"https://api.github.com/users/castalheiro/following{/other_user}","gists_url":"https://api.github.com/users/castalheiro/gists{/gist_id}","starred_url":"https://api.github.com/users/castalheiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castalheiro/subscriptions","organizations_url":"https://api.github.com/users/castalheiro/orgs","repos_url":"https://api.github.com/users/castalheiro/repos","events_url":"https://api.github.com/users/castalheiro/events{/privacy}","received_events_url":"https://api.github.com/users/castalheiro/received_events","type":"User","site_admin":false},"body":"All parquet tests fail on my machine. I'll change the data frame input parameter and hope it goes ok","created_at":"2017-11-21T20:21:50Z","updated_at":"2017-11-21T20:21:51Z","html_url":"https://github.com/dask/dask/pull/2908#discussion_r152390961","pull_request_url":"https://api.github.com/repos/dask/dask/pulls/2908","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dask/dask/pulls/comments/152390961"},"html":{"href":"https://github.com/dask/dask/pull/2908#discussion_r152390961"},"pull_request":{"href":"https://api.github.com/repos/dask/dask/pulls/2908"}},"in_reply_to_id":152134177},"pull_request":{"url":"https://api.github.com/repos/dask/dask/pulls/2908","id":153505472,"html_url":"https://github.com/dask/dask/pull/2908","diff_url":"https://github.com/dask/dask/pull/2908.diff","patch_url":"https://github.com/dask/dask/pull/2908.patch","issue_url":"https://api.github.com/repos/dask/dask/issues/2908","number":2908,"state":"open","locked":false,"title":"Add missing compression argument in to_parquet underlying methods","user":{"login":"castalheiro","id":4572839,"avatar_url":"https://avatars1.githubusercontent.com/u/4572839?v=4","gravatar_id":"","url":"https://api.github.com/users/castalheiro","html_url":"https://github.com/castalheiro","followers_url":"https://api.github.com/users/castalheiro/followers","following_url":"https://api.github.com/users/castalheiro/following{/other_user}","gists_url":"https://api.github.com/users/castalheiro/gists{/gist_id}","starred_url":"https://api.github.com/users/castalheiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castalheiro/subscriptions","organizations_url":"https://api.github.com/users/castalheiro/orgs","repos_url":"https://api.github.com/users/castalheiro/repos","events_url":"https://api.github.com/users/castalheiro/events{/privacy}","received_events_url":"https://api.github.com/users/castalheiro/received_events","type":"User","site_admin":false},"body":"Fixes #2907.\r\n\r\n- [x] Tests added / passed\r\n- [x] Passes `flake8 dask`\r\n- [ ] Fully documented, including `docs/source/changelog.rst` for all changes\r\n      and one of the `docs/source/*-api.rst` files for new API\r\n","created_at":"2017-11-19T17:08:28Z","updated_at":"2017-11-21T20:21:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25542031fc23f12384bde669297cdbff2af7a521","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dask/dask/pulls/2908/commits","review_comments_url":"https://api.github.com/repos/dask/dask/pulls/2908/comments","review_comment_url":"https://api.github.com/repos/dask/dask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dask/dask/issues/2908/comments","statuses_url":"https://api.github.com/repos/dask/dask/statuses/ae565f509f65bd7d1ec361909bdc63b08d2ad4b3","head":{"label":"castalheiro:master","ref":"master","sha":"ae565f509f65bd7d1ec361909bdc63b08d2ad4b3","user":{"login":"castalheiro","id":4572839,"avatar_url":"https://avatars1.githubusercontent.com/u/4572839?v=4","gravatar_id":"","url":"https://api.github.com/users/castalheiro","html_url":"https://github.com/castalheiro","followers_url":"https://api.github.com/users/castalheiro/followers","following_url":"https://api.github.com/users/castalheiro/following{/other_user}","gists_url":"https://api.github.com/users/castalheiro/gists{/gist_id}","starred_url":"https://api.github.com/users/castalheiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castalheiro/subscriptions","organizations_url":"https://api.github.com/users/castalheiro/orgs","repos_url":"https://api.github.com/users/castalheiro/repos","events_url":"https://api.github.com/users/castalheiro/events{/privacy}","received_events_url":"https://api.github.com/users/castalheiro/received_events","type":"User","site_admin":false},"repo":{"id":111314945,"name":"dask","full_name":"castalheiro/dask","owner":{"login":"castalheiro","id":4572839,"avatar_url":"https://avatars1.githubusercontent.com/u/4572839?v=4","gravatar_id":"","url":"https://api.github.com/users/castalheiro","html_url":"https://github.com/castalheiro","followers_url":"https://api.github.com/users/castalheiro/followers","following_url":"https://api.github.com/users/castalheiro/following{/other_user}","gists_url":"https://api.github.com/users/castalheiro/gists{/gist_id}","starred_url":"https://api.github.com/users/castalheiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castalheiro/subscriptions","organizations_url":"https://api.github.com/users/castalheiro/orgs","repos_url":"https://api.github.com/users/castalheiro/repos","events_url":"https://api.github.com/users/castalheiro/events{/privacy}","received_events_url":"https://api.github.com/users/castalheiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/castalheiro/dask","description":"Parallel computing with task scheduling","fork":true,"url":"https://api.github.com/repos/castalheiro/dask","forks_url":"https://api.github.com/repos/castalheiro/dask/forks","keys_url":"https://api.github.com/repos/castalheiro/dask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/castalheiro/dask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/castalheiro/dask/teams","hooks_url":"https://api.github.com/repos/castalheiro/dask/hooks","issue_events_url":"https://api.github.com/repos/castalheiro/dask/issues/events{/number}","events_url":"https://api.github.com/repos/castalheiro/dask/events","assignees_url":"https://api.github.com/repos/castalheiro/dask/assignees{/user}","branches_url":"https://api.github.com/repos/castalheiro/dask/branches{/branch}","tags_url":"https://api.github.com/repos/castalheiro/dask/tags","blobs_url":"https://api.github.com/repos/castalheiro/dask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/castalheiro/dask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/castalheiro/dask/git/refs{/sha}","trees_url":"https://api.github.com/repos/castalheiro/dask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/castalheiro/dask/statuses/{sha}","languages_url":"https://api.github.com/repos/castalheiro/dask/languages","stargazers_url":"https://api.github.com/repos/castalheiro/dask/stargazers","contributors_url":"https://api.github.com/repos/castalheiro/dask/contributors","subscribers_url":"https://api.github.com/repos/castalheiro/dask/subscribers","subscription_url":"https://api.github.com/repos/castalheiro/dask/subscription","commits_url":"https://api.github.com/repos/castalheiro/dask/commits{/sha}","git_commits_url":"https://api.github.com/repos/castalheiro/dask/git/commits{/sha}","comments_url":"https://api.github.com/repos/castalheiro/dask/comments{/number}","issue_comment_url":"https://api.github.com/repos/castalheiro/dask/issues/comments{/number}","contents_url":"https://api.github.com/repos/castalheiro/dask/contents/{+path}","compare_url":"https://api.github.com/repos/castalheiro/dask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/castalheiro/dask/merges","archive_url":"https://api.github.com/repos/castalheiro/dask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/castalheiro/dask/downloads","issues_url":"https://api.github.com/repos/castalheiro/dask/issues{/number}","pulls_url":"https://api.github.com/repos/castalheiro/dask/pulls{/number}","milestones_url":"https://api.github.com/repos/castalheiro/dask/milestones{/number}","notifications_url":"https://api.github.com/repos/castalheiro/dask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/castalheiro/dask/labels{/name}","releases_url":"https://api.github.com/repos/castalheiro/dask/releases{/id}","deployments_url":"https://api.github.com/repos/castalheiro/dask/deployments","created_at":"2017-11-19T17:03:46Z","updated_at":"2017-11-19T17:03:49Z","pushed_at":"2017-11-20T22:18:43Z","git_url":"git://github.com/castalheiro/dask.git","ssh_url":"git@github.com:castalheiro/dask.git","clone_url":"https://github.com/castalheiro/dask.git","svn_url":"https://github.com/castalheiro/dask","homepage":"http://dask.pydata.org","size":15547,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dask:master","ref":"master","sha":"7813d9bab5051cccf0c86fa7690e7a4a2a5798ff","user":{"login":"dask","id":17131925,"avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"repo":{"id":28782747,"name":"dask","full_name":"dask/dask","owner":{"login":"dask","id":17131925,"avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dask/dask","description":"Parallel computing with task scheduling","fork":false,"url":"https://api.github.com/repos/dask/dask","forks_url":"https://api.github.com/repos/dask/dask/forks","keys_url":"https://api.github.com/repos/dask/dask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dask/dask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dask/dask/teams","hooks_url":"https://api.github.com/repos/dask/dask/hooks","issue_events_url":"https://api.github.com/repos/dask/dask/issues/events{/number}","events_url":"https://api.github.com/repos/dask/dask/events","assignees_url":"https://api.github.com/repos/dask/dask/assignees{/user}","branches_url":"https://api.github.com/repos/dask/dask/branches{/branch}","tags_url":"https://api.github.com/repos/dask/dask/tags","blobs_url":"https://api.github.com/repos/dask/dask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dask/dask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dask/dask/git/refs{/sha}","trees_url":"https://api.github.com/repos/dask/dask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dask/dask/statuses/{sha}","languages_url":"https://api.github.com/repos/dask/dask/languages","stargazers_url":"https://api.github.com/repos/dask/dask/stargazers","contributors_url":"https://api.github.com/repos/dask/dask/contributors","subscribers_url":"https://api.github.com/repos/dask/dask/subscribers","subscription_url":"https://api.github.com/repos/dask/dask/subscription","commits_url":"https://api.github.com/repos/dask/dask/commits{/sha}","git_commits_url":"https://api.github.com/repos/dask/dask/git/commits{/sha}","comments_url":"https://api.github.com/repos/dask/dask/comments{/number}","issue_comment_url":"https://api.github.com/repos/dask/dask/issues/comments{/number}","contents_url":"https://api.github.com/repos/dask/dask/contents/{+path}","compare_url":"https://api.github.com/repos/dask/dask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dask/dask/merges","archive_url":"https://api.github.com/repos/dask/dask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dask/dask/downloads","issues_url":"https://api.github.com/repos/dask/dask/issues{/number}","pulls_url":"https://api.github.com/repos/dask/dask/pulls{/number}","milestones_url":"https://api.github.com/repos/dask/dask/milestones{/number}","notifications_url":"https://api.github.com/repos/dask/dask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dask/dask/labels{/name}","releases_url":"https://api.github.com/repos/dask/dask/releases{/id}","deployments_url":"https://api.github.com/repos/dask/dask/deployments","created_at":"2015-01-04T18:50:00Z","updated_at":"2017-11-21T15:17:09Z","pushed_at":"2017-11-21T15:33:24Z","git_url":"git://github.com/dask/dask.git","ssh_url":"git@github.com:dask/dask.git","clone_url":"https://github.com/dask/dask.git","svn_url":"https://github.com/dask/dask","homepage":"http://dask.pydata.org","size":15531,"stargazers_count":2118,"watchers_count":2118,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":367,"mirror_url":null,"archived":false,"open_issues_count":293,"forks":367,"open_issues":293,"watchers":2118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dask/dask/pulls/2908"},"html":{"href":"https://github.com/dask/dask/pull/2908"},"issue":{"href":"https://api.github.com/repos/dask/dask/issues/2908"},"comments":{"href":"https://api.github.com/repos/dask/dask/issues/2908/comments"},"review_comments":{"href":"https://api.github.com/repos/dask/dask/pulls/2908/comments"},"review_comment":{"href":"https://api.github.com/repos/dask/dask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dask/dask/pulls/2908/commits"},"statuses":{"href":"https://api.github.com/repos/dask/dask/statuses/ae565f509f65bd7d1ec361909bdc63b08d2ad4b3"}},"author_association":"NONE"}}
{"actor":{"display_login":"castalheiro"}}