{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/emission/pulls/comments/101314294","pull_request_review_id":22038594,"id":101314294,"diff_hunk":"@@ -88,64 +61,45 @@ class InfiniteScrollArtworksGrid extends React.Component {\n \n   constructor(props) {\n     super(props)\n+\n     this.state = {\n       sectionDimension: 0,\n-      artworks: this.props.artworks,\n-      page: this.props.artworks.length ? 1 : 0,\n       completed: false,\n       fetchingNextPage: false,\n     }\n \n     this._sentEndForContentLength = null\n-  }\n-\n-  // Initial setup\n-  componentWillMount(){\n-    if (this.state.artworks.length === 0) {\n-      this.fetchNextPage()\n+    if (this.props.filter) {","path":"lib/components/artwork_grids/infinite_scroll_grid.js","position":68,"original_position":68,"commit_id":"a4149e835725e7786d2de5dc81233beedf2404a8","original_commit_id":"a4149e835725e7786d2de5dc81233beedf2404a8","user":{"login":"broskoski","id":821469,"avatar_url":"https://avatars.githubusercontent.com/u/821469?v=3","gravatar_id":"","url":"https://api.github.com/users/broskoski","html_url":"https://github.com/broskoski","followers_url":"https://api.github.com/users/broskoski/followers","following_url":"https://api.github.com/users/broskoski/following{/other_user}","gists_url":"https://api.github.com/users/broskoski/gists{/gist_id}","starred_url":"https://api.github.com/users/broskoski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broskoski/subscriptions","organizations_url":"https://api.github.com/users/broskoski/orgs","repos_url":"https://api.github.com/users/broskoski/repos","events_url":"https://api.github.com/users/broskoski/events{/privacy}","received_events_url":"https://api.github.com/users/broskoski/received_events","type":"User","site_admin":false},"body":"This is the only semi-annoying thing here, we set variables on construction which as far as I can tell does not trigger any additional queries, it's just....not as nice as it could be.","created_at":"2017-02-15T16:10:08Z","updated_at":"2017-02-15T16:10:09Z","html_url":"https://github.com/artsy/emission/pull/441#discussion_r101314294","pull_request_url":"https://api.github.com/repos/artsy/emission/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/artsy/emission/pulls/comments/101314294"},"html":{"href":"https://github.com/artsy/emission/pull/441#discussion_r101314294"},"pull_request":{"href":"https://api.github.com/repos/artsy/emission/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/emission/pulls/441","id":105328431,"html_url":"https://github.com/artsy/emission/pull/441","diff_url":"https://github.com/artsy/emission/pull/441.diff","patch_url":"https://github.com/artsy/emission/pull/441.patch","issue_url":"https://api.github.com/repos/artsy/emission/issues/441","number":441,"state":"open","locked":false,"title":"@alloy - Wire artwork grid up to artworks connection [WIP] #dontmerge","user":{"login":"broskoski","id":821469,"avatar_url":"https://avatars.githubusercontent.com/u/821469?v=3","gravatar_id":"","url":"https://api.github.com/users/broskoski","html_url":"https://github.com/broskoski","followers_url":"https://api.github.com/users/broskoski/followers","following_url":"https://api.github.com/users/broskoski/following{/other_user}","gists_url":"https://api.github.com/users/broskoski/gists{/gist_id}","starred_url":"https://api.github.com/users/broskoski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broskoski/subscriptions","organizations_url":"https://api.github.com/users/broskoski/orgs","repos_url":"https://api.github.com/users/broskoski/repos","events_url":"https://api.github.com/users/broskoski/events{/privacy}","received_events_url":"https://api.github.com/users/broskoski/received_events","type":"User","site_admin":false},"body":"Very much just getting the hang of things here but wanted to get some WIP up.\r\n\r\nI think the structure is a little off right now, and I haven't settled on a good arrangement of where everything should live. `InfiniteScrollGrid` should definitely handle the scroll progress check, but I haven't decided if it's better to try and keep it as a dumb component and just send it artworks or if it should actually maintain its own query. Right now it's firing back to the `Artworks` component, which is updating the relay variable and triggering a render, but it is obviously doing that for _both_ `for_sale_artworks` and `not_for_sale_artworks`. I guess smart component it is for `InfiniteScrollGrid`, thanks for being my 🦆 \r\n\r\nOne funny gotcha I've encountered so far, you can't actually access attributes on `artwork` from outside the component who's fragment it belongs to...so for example the check for `artwork.image` returns null _unless_ you include that attribute in the query outside the fragment. I'm sure there's some better way of doing this that I don't know about.","created_at":"2017-02-08T23:22:56Z","updated_at":"2017-02-15T16:10:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a2b94889d3c574afc752775af072b78e5a0199a","assignee":{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"assignees":[{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/emission/pulls/441/commits","review_comments_url":"https://api.github.com/repos/artsy/emission/pulls/441/comments","review_comment_url":"https://api.github.com/repos/artsy/emission/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/emission/issues/441/comments","statuses_url":"https://api.github.com/repos/artsy/emission/statuses/a4149e835725e7786d2de5dc81233beedf2404a8","head":{"label":"broskoski:artworks-relay","ref":"artworks-relay","sha":"a4149e835725e7786d2de5dc81233beedf2404a8","user":{"login":"broskoski","id":821469,"avatar_url":"https://avatars.githubusercontent.com/u/821469?v=3","gravatar_id":"","url":"https://api.github.com/users/broskoski","html_url":"https://github.com/broskoski","followers_url":"https://api.github.com/users/broskoski/followers","following_url":"https://api.github.com/users/broskoski/following{/other_user}","gists_url":"https://api.github.com/users/broskoski/gists{/gist_id}","starred_url":"https://api.github.com/users/broskoski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broskoski/subscriptions","organizations_url":"https://api.github.com/users/broskoski/orgs","repos_url":"https://api.github.com/users/broskoski/repos","events_url":"https://api.github.com/users/broskoski/events{/privacy}","received_events_url":"https://api.github.com/users/broskoski/received_events","type":"User","site_admin":false},"repo":{"id":75220493,"name":"emission","full_name":"broskoski/emission","owner":{"login":"broskoski","id":821469,"avatar_url":"https://avatars.githubusercontent.com/u/821469?v=3","gravatar_id":"","url":"https://api.github.com/users/broskoski","html_url":"https://github.com/broskoski","followers_url":"https://api.github.com/users/broskoski/followers","following_url":"https://api.github.com/users/broskoski/following{/other_user}","gists_url":"https://api.github.com/users/broskoski/gists{/gist_id}","starred_url":"https://api.github.com/users/broskoski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broskoski/subscriptions","organizations_url":"https://api.github.com/users/broskoski/orgs","repos_url":"https://api.github.com/users/broskoski/repos","events_url":"https://api.github.com/users/broskoski/events{/privacy}","received_events_url":"https://api.github.com/users/broskoski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/broskoski/emission","description":"React Native Components","fork":true,"url":"https://api.github.com/repos/broskoski/emission","forks_url":"https://api.github.com/repos/broskoski/emission/forks","keys_url":"https://api.github.com/repos/broskoski/emission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broskoski/emission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broskoski/emission/teams","hooks_url":"https://api.github.com/repos/broskoski/emission/hooks","issue_events_url":"https://api.github.com/repos/broskoski/emission/issues/events{/number}","events_url":"https://api.github.com/repos/broskoski/emission/events","assignees_url":"https://api.github.com/repos/broskoski/emission/assignees{/user}","branches_url":"https://api.github.com/repos/broskoski/emission/branches{/branch}","tags_url":"https://api.github.com/repos/broskoski/emission/tags","blobs_url":"https://api.github.com/repos/broskoski/emission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broskoski/emission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broskoski/emission/git/refs{/sha}","trees_url":"https://api.github.com/repos/broskoski/emission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broskoski/emission/statuses/{sha}","languages_url":"https://api.github.com/repos/broskoski/emission/languages","stargazers_url":"https://api.github.com/repos/broskoski/emission/stargazers","contributors_url":"https://api.github.com/repos/broskoski/emission/contributors","subscribers_url":"https://api.github.com/repos/broskoski/emission/subscribers","subscription_url":"https://api.github.com/repos/broskoski/emission/subscription","commits_url":"https://api.github.com/repos/broskoski/emission/commits{/sha}","git_commits_url":"https://api.github.com/repos/broskoski/emission/git/commits{/sha}","comments_url":"https://api.github.com/repos/broskoski/emission/comments{/number}","issue_comment_url":"https://api.github.com/repos/broskoski/emission/issues/comments{/number}","contents_url":"https://api.github.com/repos/broskoski/emission/contents/{+path}","compare_url":"https://api.github.com/repos/broskoski/emission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broskoski/emission/merges","archive_url":"https://api.github.com/repos/broskoski/emission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broskoski/emission/downloads","issues_url":"https://api.github.com/repos/broskoski/emission/issues{/number}","pulls_url":"https://api.github.com/repos/broskoski/emission/pulls{/number}","milestones_url":"https://api.github.com/repos/broskoski/emission/milestones{/number}","notifications_url":"https://api.github.com/repos/broskoski/emission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broskoski/emission/labels{/name}","releases_url":"https://api.github.com/repos/broskoski/emission/releases{/id}","deployments_url":"https://api.github.com/repos/broskoski/emission/deployments","created_at":"2016-11-30T19:39:01Z","updated_at":"2016-11-30T19:39:02Z","pushed_at":"2017-02-15T16:06:40Z","git_url":"git://github.com/broskoski/emission.git","ssh_url":"git@github.com:broskoski/emission.git","clone_url":"https://github.com/broskoski/emission.git","svn_url":"https://github.com/broskoski/emission","homepage":null,"size":39150,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"0a5c6454ced2136817d21464ba9ad5eb0f572940","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":52437732,"name":"emission","full_name":"artsy/emission","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/emission","description":"React Native Components","fork":false,"url":"https://api.github.com/repos/artsy/emission","forks_url":"https://api.github.com/repos/artsy/emission/forks","keys_url":"https://api.github.com/repos/artsy/emission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/emission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/emission/teams","hooks_url":"https://api.github.com/repos/artsy/emission/hooks","issue_events_url":"https://api.github.com/repos/artsy/emission/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/emission/events","assignees_url":"https://api.github.com/repos/artsy/emission/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/emission/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/emission/tags","blobs_url":"https://api.github.com/repos/artsy/emission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/emission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/emission/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/emission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/emission/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/emission/languages","stargazers_url":"https://api.github.com/repos/artsy/emission/stargazers","contributors_url":"https://api.github.com/repos/artsy/emission/contributors","subscribers_url":"https://api.github.com/repos/artsy/emission/subscribers","subscription_url":"https://api.github.com/repos/artsy/emission/subscription","commits_url":"https://api.github.com/repos/artsy/emission/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/emission/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/emission/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/emission/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/emission/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/emission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/emission/merges","archive_url":"https://api.github.com/repos/artsy/emission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/emission/downloads","issues_url":"https://api.github.com/repos/artsy/emission/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/emission/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/emission/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/emission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/emission/labels{/name}","releases_url":"https://api.github.com/repos/artsy/emission/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/emission/deployments","created_at":"2016-02-24T11:36:24Z","updated_at":"2017-02-15T11:34:27Z","pushed_at":"2017-02-15T16:06:42Z","git_url":"git://github.com/artsy/emission.git","ssh_url":"git@github.com:artsy/emission.git","clone_url":"https://github.com/artsy/emission.git","svn_url":"https://github.com/artsy/emission","homepage":null,"size":39282,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":38,"forks":13,"open_issues":38,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/emission/pulls/441"},"html":{"href":"https://github.com/artsy/emission/pull/441"},"issue":{"href":"https://api.github.com/repos/artsy/emission/issues/441"},"comments":{"href":"https://api.github.com/repos/artsy/emission/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/emission/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/emission/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/emission/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/emission/statuses/a4149e835725e7786d2de5dc81233beedf2404a8"}}}}
{"actor":{"display_login":"broskoski"}}