{"action":"created","comment":{"url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/comments/122292803","pull_request_review_id":44396861,"id":122292803,"diff_hunk":"@@ -618,7 +618,14 @@ public function setAmount($amount = 0.0)\n         if (!$this->getWithAmount()) {\n             throw new DisabledDataException('amount');\n         }\n-        $this->amount = $amount;\n+\n+        // Fix case where cents are from 995 to 999 : the amount must be rounded\n+        // otherwise the amount of cents is \"100\"\n+        if(is_numeric($amount)) {","path":"src/PaymentSlipData.php","position":8,"original_position":8,"commit_id":"dd5250c6dc817375c5d465781dd8b6ccbb498cd6","original_commit_id":"dd5250c6dc817375c5d465781dd8b6ccbb498cd6","user":{"login":"Nitpick-CI","id":12626182,"avatar_url":"https://avatars2.githubusercontent.com/u/12626182?v=3","gravatar_id":"","url":"https://api.github.com/users/Nitpick-CI","html_url":"https://github.com/Nitpick-CI","followers_url":"https://api.github.com/users/Nitpick-CI/followers","following_url":"https://api.github.com/users/Nitpick-CI/following{/other_user}","gists_url":"https://api.github.com/users/Nitpick-CI/gists{/gist_id}","starred_url":"https://api.github.com/users/Nitpick-CI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nitpick-CI/subscriptions","organizations_url":"https://api.github.com/users/Nitpick-CI/orgs","repos_url":"https://api.github.com/users/Nitpick-CI/repos","events_url":"https://api.github.com/users/Nitpick-CI/events{/privacy}","received_events_url":"https://api.github.com/users/Nitpick-CI/received_events","type":"User","site_admin":false},"body":"Expected 1 space after IF keyword; 0 found","created_at":"2017-06-15T19:37:16Z","updated_at":"2017-06-15T19:37:16Z","html_url":"https://github.com/ravage84/SwissPaymentSlip/pull/27#discussion_r122292803","pull_request_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/comments/122292803"},"html":{"href":"https://github.com/ravage84/SwissPaymentSlip/pull/27#discussion_r122292803"},"pull_request":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/27","id":99329292,"html_url":"https://github.com/ravage84/SwissPaymentSlip/pull/27","diff_url":"https://github.com/ravage84/SwissPaymentSlip/pull/27.diff","patch_url":"https://github.com/ravage84/SwissPaymentSlip/pull/27.patch","issue_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/issues/27","number":27,"state":"open","locked":false,"title":"Permit to specify the banking customer length (up to 10 digits)","user":{"login":"sdespont","id":646632,"avatar_url":"https://avatars0.githubusercontent.com/u/646632?v=3","gravatar_id":"","url":"https://api.github.com/users/sdespont","html_url":"https://github.com/sdespont","followers_url":"https://api.github.com/users/sdespont/followers","following_url":"https://api.github.com/users/sdespont/following{/other_user}","gists_url":"https://api.github.com/users/sdespont/gists{/gist_id}","starred_url":"https://api.github.com/users/sdespont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdespont/subscriptions","organizations_url":"https://api.github.com/users/sdespont/orgs","repos_url":"https://api.github.com/users/sdespont/repos","events_url":"https://api.github.com/users/sdespont/events{/privacy}","received_events_url":"https://api.github.com/users/sdespont/received_events","type":"User","site_admin":false},"body":"Marc,\r\n\r\nI am facing a limitation: the banking customer ID I need to use has 7 digits and not 6 as usual. The current stable version expects the banking customer ID has exactly 6 digits. I have extended the class to use a banking customer ID up to 10 digits.\r\n\r\nAlso, I have added some verifications regarding the complete reference number when using with a banking customer ID which must have exactly 26 digits (without the check digit) and must be numerical.\r\n\r\nPlease, review these changes and tell me what you think about this suggestion.\r\n\r\nSébastien","created_at":"2016-12-25T20:54:39Z","updated_at":"2017-06-15T19:37:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc5c6d0d6543259e7488f8b4cf25734fc2e6e951","assignee":{"login":"ravage84","id":625761,"avatar_url":"https://avatars2.githubusercontent.com/u/625761?v=3","gravatar_id":"","url":"https://api.github.com/users/ravage84","html_url":"https://github.com/ravage84","followers_url":"https://api.github.com/users/ravage84/followers","following_url":"https://api.github.com/users/ravage84/following{/other_user}","gists_url":"https://api.github.com/users/ravage84/gists{/gist_id}","starred_url":"https://api.github.com/users/ravage84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravage84/subscriptions","organizations_url":"https://api.github.com/users/ravage84/orgs","repos_url":"https://api.github.com/users/ravage84/repos","events_url":"https://api.github.com/users/ravage84/events{/privacy}","received_events_url":"https://api.github.com/users/ravage84/received_events","type":"User","site_admin":false},"assignees":[{"login":"ravage84","id":625761,"avatar_url":"https://avatars2.githubusercontent.com/u/625761?v=3","gravatar_id":"","url":"https://api.github.com/users/ravage84","html_url":"https://github.com/ravage84","followers_url":"https://api.github.com/users/ravage84/followers","following_url":"https://api.github.com/users/ravage84/following{/other_user}","gists_url":"https://api.github.com/users/ravage84/gists{/gist_id}","starred_url":"https://api.github.com/users/ravage84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravage84/subscriptions","organizations_url":"https://api.github.com/users/ravage84/orgs","repos_url":"https://api.github.com/users/ravage84/repos","events_url":"https://api.github.com/users/ravage84/events{/privacy}","received_events_url":"https://api.github.com/users/ravage84/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/milestones/9","html_url":"https://github.com/ravage84/SwissPaymentSlip/milestone/9","labels_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/milestones/9/labels","id":2573687,"number":9,"title":"0.13.0","description":null,"creator":{"login":"ravage84","id":625761,"avatar_url":"https://avatars2.githubusercontent.com/u/625761?v=3","gravatar_id":"","url":"https://api.github.com/users/ravage84","html_url":"https://github.com/ravage84","followers_url":"https://api.github.com/users/ravage84/followers","following_url":"https://api.github.com/users/ravage84/following{/other_user}","gists_url":"https://api.github.com/users/ravage84/gists{/gist_id}","starred_url":"https://api.github.com/users/ravage84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravage84/subscriptions","organizations_url":"https://api.github.com/users/ravage84/orgs","repos_url":"https://api.github.com/users/ravage84/repos","events_url":"https://api.github.com/users/ravage84/events{/privacy}","received_events_url":"https://api.github.com/users/ravage84/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2017-06-09T11:57:44Z","updated_at":"2017-06-09T11:57:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/27/commits","review_comments_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/27/comments","review_comment_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/issues/27/comments","statuses_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/statuses/dd5250c6dc817375c5d465781dd8b6ccbb498cd6","head":{"label":"sdespont:master","ref":"master","sha":"dd5250c6dc817375c5d465781dd8b6ccbb498cd6","user":{"login":"sdespont","id":646632,"avatar_url":"https://avatars0.githubusercontent.com/u/646632?v=3","gravatar_id":"","url":"https://api.github.com/users/sdespont","html_url":"https://github.com/sdespont","followers_url":"https://api.github.com/users/sdespont/followers","following_url":"https://api.github.com/users/sdespont/following{/other_user}","gists_url":"https://api.github.com/users/sdespont/gists{/gist_id}","starred_url":"https://api.github.com/users/sdespont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdespont/subscriptions","organizations_url":"https://api.github.com/users/sdespont/orgs","repos_url":"https://api.github.com/users/sdespont/repos","events_url":"https://api.github.com/users/sdespont/events{/privacy}","received_events_url":"https://api.github.com/users/sdespont/received_events","type":"User","site_admin":false},"repo":{"id":77319387,"name":"SwissPaymentSlip","full_name":"sdespont/SwissPaymentSlip","owner":{"login":"sdespont","id":646632,"avatar_url":"https://avatars0.githubusercontent.com/u/646632?v=3","gravatar_id":"","url":"https://api.github.com/users/sdespont","html_url":"https://github.com/sdespont","followers_url":"https://api.github.com/users/sdespont/followers","following_url":"https://api.github.com/users/sdespont/following{/other_user}","gists_url":"https://api.github.com/users/sdespont/gists{/gist_id}","starred_url":"https://api.github.com/users/sdespont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdespont/subscriptions","organizations_url":"https://api.github.com/users/sdespont/orgs","repos_url":"https://api.github.com/users/sdespont/repos","events_url":"https://api.github.com/users/sdespont/events{/privacy}","received_events_url":"https://api.github.com/users/sdespont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdespont/SwissPaymentSlip","description":"A PHP library for creating Swiss Payment Slips","fork":true,"url":"https://api.github.com/repos/sdespont/SwissPaymentSlip","forks_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/forks","keys_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/teams","hooks_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/hooks","issue_events_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/issues/events{/number}","events_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/events","assignees_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/assignees{/user}","branches_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/branches{/branch}","tags_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/tags","blobs_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/statuses/{sha}","languages_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/languages","stargazers_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/stargazers","contributors_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/contributors","subscribers_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/subscribers","subscription_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/subscription","commits_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/contents/{+path}","compare_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/merges","archive_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/downloads","issues_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/issues{/number}","pulls_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/pulls{/number}","milestones_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/milestones{/number}","notifications_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/labels{/name}","releases_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/releases{/id}","deployments_url":"https://api.github.com/repos/sdespont/SwissPaymentSlip/deployments","created_at":"2016-12-25T09:33:12Z","updated_at":"2017-06-11T22:36:25Z","pushed_at":"2017-06-15T19:37:02Z","git_url":"git://github.com/sdespont/SwissPaymentSlip.git","ssh_url":"git@github.com:sdespont/SwissPaymentSlip.git","clone_url":"https://github.com/sdespont/SwissPaymentSlip.git","svn_url":"https://github.com/sdespont/SwissPaymentSlip","homepage":"","size":392,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ravage84:master","ref":"master","sha":"a723d14823cf4684ee33cca5e78371c9b2f7904a","user":{"login":"ravage84","id":625761,"avatar_url":"https://avatars2.githubusercontent.com/u/625761?v=3","gravatar_id":"","url":"https://api.github.com/users/ravage84","html_url":"https://github.com/ravage84","followers_url":"https://api.github.com/users/ravage84/followers","following_url":"https://api.github.com/users/ravage84/following{/other_user}","gists_url":"https://api.github.com/users/ravage84/gists{/gist_id}","starred_url":"https://api.github.com/users/ravage84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravage84/subscriptions","organizations_url":"https://api.github.com/users/ravage84/orgs","repos_url":"https://api.github.com/users/ravage84/repos","events_url":"https://api.github.com/users/ravage84/events{/privacy}","received_events_url":"https://api.github.com/users/ravage84/received_events","type":"User","site_admin":false},"repo":{"id":8628763,"name":"SwissPaymentSlip","full_name":"ravage84/SwissPaymentSlip","owner":{"login":"ravage84","id":625761,"avatar_url":"https://avatars2.githubusercontent.com/u/625761?v=3","gravatar_id":"","url":"https://api.github.com/users/ravage84","html_url":"https://github.com/ravage84","followers_url":"https://api.github.com/users/ravage84/followers","following_url":"https://api.github.com/users/ravage84/following{/other_user}","gists_url":"https://api.github.com/users/ravage84/gists{/gist_id}","starred_url":"https://api.github.com/users/ravage84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravage84/subscriptions","organizations_url":"https://api.github.com/users/ravage84/orgs","repos_url":"https://api.github.com/users/ravage84/repos","events_url":"https://api.github.com/users/ravage84/events{/privacy}","received_events_url":"https://api.github.com/users/ravage84/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravage84/SwissPaymentSlip","description":"A PHP library for creating Swiss Payment Slips","fork":false,"url":"https://api.github.com/repos/ravage84/SwissPaymentSlip","forks_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/forks","keys_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/teams","hooks_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/hooks","issue_events_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/issues/events{/number}","events_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/events","assignees_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/assignees{/user}","branches_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/branches{/branch}","tags_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/tags","blobs_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/statuses/{sha}","languages_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/languages","stargazers_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/stargazers","contributors_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/contributors","subscribers_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/subscribers","subscription_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/subscription","commits_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/contents/{+path}","compare_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/merges","archive_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/downloads","issues_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/issues{/number}","pulls_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls{/number}","milestones_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/milestones{/number}","notifications_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/labels{/name}","releases_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/releases{/id}","deployments_url":"https://api.github.com/repos/ravage84/SwissPaymentSlip/deployments","created_at":"2013-03-07T14:13:55Z","updated_at":"2017-05-30T16:25:48Z","pushed_at":"2017-06-15T19:37:04Z","git_url":"git://github.com/ravage84/SwissPaymentSlip.git","ssh_url":"git@github.com:ravage84/SwissPaymentSlip.git","clone_url":"https://github.com/ravage84/SwissPaymentSlip.git","svn_url":"https://github.com/ravage84/SwissPaymentSlip","homepage":"","size":379,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/27"},"html":{"href":"https://github.com/ravage84/SwissPaymentSlip/pull/27"},"issue":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/issues/27"},"comments":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/ravage84/SwissPaymentSlip/statuses/dd5250c6dc817375c5d465781dd8b6ccbb498cd6"}}}}
{"actor":{"display_login":"Nitpick-CI"}}