{"push_id":1772714800,"size":1,"distinct_size":1,"ref":"refs/heads/jcr-fix-query-count-grouped-results","head":"980e75438da703da37b694efadeb8d81b915ebed","before":"0ff6353186bdec38d19dd2a76d548a07c02b5507","commits":[{"sha":"980e75438da703da37b694efadeb8d81b915ebed","author":{"name":"Collin Redding","email":"d46f375d8aaf6893782d4503835b61ef3c034b5b@gmail.com"},"message":"Fix `Query` counting grouped SQL queries using the `id` column\n\nThis fixes an issue with the `Query` using the `id` column to\ncount results. This doesn't always work for grouped SQL queries\nin Postgres because the `id` column may not be part of the\n`GROUP BY`. This fixes the issue by doing `SELECT 1` to count the\ngrouped results. This avoids trying to choose a column that is\npart of the group by but still accurately returns a count for the\ngrouped results.\n\nNote: I can't currently add a system test for this issue because\nthe system tests use SQLite and SQLite doesn't error when a\ncolumn that is selected is not part of the group by.","distinct":true,"url":"https://api.github.com/repos/redding/mr/commits/980e75438da703da37b694efadeb8d81b915ebed"}]}
{"actor":{"display_login":"jcredding"}}