{"action":"created","issue":{"url":"https://api.github.com/repos/inaturalist/iNaturalistAndroid/issues/382","repository_url":"https://api.github.com/repos/inaturalist/iNaturalistAndroid","labels_url":"https://api.github.com/repos/inaturalist/iNaturalistAndroid/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/inaturalist/iNaturalistAndroid/issues/382/comments","events_url":"https://api.github.com/repos/inaturalist/iNaturalistAndroid/issues/382/events","html_url":"https://github.com/inaturalist/iNaturalistAndroid/issues/382","id":241891403,"number":382,"title":"vision suggestions","user":{"login":"kueda","id":22691,"avatar_url":"https://avatars3.githubusercontent.com/u/22691?v=4","gravatar_id":"","url":"https://api.github.com/users/kueda","html_url":"https://github.com/kueda","followers_url":"https://api.github.com/users/kueda/followers","following_url":"https://api.github.com/users/kueda/following{/other_user}","gists_url":"https://api.github.com/users/kueda/gists{/gist_id}","starred_url":"https://api.github.com/users/kueda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kueda/subscriptions","organizations_url":"https://api.github.com/users/kueda/orgs","repos_url":"https://api.github.com/users/kueda/repos","events_url":"https://api.github.com/users/kueda/events{/privacy}","received_events_url":"https://api.github.com/users/kueda/received_events","type":"User","site_admin":false},"labels":[{"id":495921367,"url":"https://api.github.com/repos/inaturalist/iNaturalistAndroid/labels/feature","name":"feature","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"budowski","id":1490104,"avatar_url":"https://avatars2.githubusercontent.com/u/1490104?v=4","gravatar_id":"","url":"https://api.github.com/users/budowski","html_url":"https://github.com/budowski","followers_url":"https://api.github.com/users/budowski/followers","following_url":"https://api.github.com/users/budowski/following{/other_user}","gists_url":"https://api.github.com/users/budowski/gists{/gist_id}","starred_url":"https://api.github.com/users/budowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budowski/subscriptions","organizations_url":"https://api.github.com/users/budowski/orgs","repos_url":"https://api.github.com/users/budowski/repos","events_url":"https://api.github.com/users/budowski/events{/privacy}","received_events_url":"https://api.github.com/users/budowski/received_events","type":"User","site_admin":false},"assignees":[{"login":"budowski","id":1490104,"avatar_url":"https://avatars2.githubusercontent.com/u/1490104?v=4","gravatar_id":"","url":"https://api.github.com/users/budowski","html_url":"https://github.com/budowski","followers_url":"https://api.github.com/users/budowski/followers","following_url":"https://api.github.com/users/budowski/following{/other_user}","gists_url":"https://api.github.com/users/budowski/gists{/gist_id}","starred_url":"https://api.github.com/users/budowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/budowski/subscriptions","organizations_url":"https://api.github.com/users/budowski/orgs","repos_url":"https://api.github.com/users/budowski/repos","events_url":"https://api.github.com/users/budowski/events{/privacy}","received_events_url":"https://api.github.com/users/budowski/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-07-11T00:40:48Z","updated_at":"2017-08-14T18:42:36Z","closed_at":null,"body":"Again, designs forthcoming. This view is mostly to achieve parity with the iOS version of the same, which is centered around `POST https://api.inaturalist.org/v1/computervision/score_image`, and endpoint that takes the following params\r\n\r\n* `lat`: latitude of the observation\r\n* `lng`: longitude of the observation\r\n* `observed_on`: date of the observation, `YYYY-MM-DD` will do\r\n* `image` (required): multipart-encoded JPG squashed to fill a 299x299 pixel image\r\n\r\nThis means to get the vision results, you need to make a 299x299 squashed version of the photo and send it along with the lat/lng and observed_on from the observation.\r\n\r\nThe other tricky part is that requests to this endpoint *must* be authenticated with a JSON Web Token. In iOS we're using an anonymous JWT for all requests: https://github.com/inaturalist/INaturalistIOS/blob/master/INaturalistIOS/LoginController.m#L645, but since we already use JWT in Android you can use a regular one for a signed in user. However, the taxon chooser *does* need to work for users who have not signed in, so you will need to generate an anonymous JWT sometimes.\r\n\r\nRequirements:\r\n\r\n- [x] Show vision suggestions based on the first photo in the observation\r\n- [ ] Show suggestions even if user has not signed in\r\n- [ ] Taps on the row show the taxon detail page, which will have \"Select\" and \"Compare\" buttons\r\n- [ ] Taps on the selection button will choose that taxon, close the Suggestions view, and add that taxon to the observation or identification\r\n- [ ] Tapping on the search field will bring up the existing taxon search view. Choosing a taxon there will do the same as choosing a taxon on the Suggestions view\r\n- [ ] If there is no network connection, show the no-network state, but the user should still be able to tap the search field to use the regular taxon search tool\r\n- [ ] Suggestions should be optional, so we'll need a checkbox on the Settings view with the heading \"Suggest species\" and the sub-text \"Suggest species based on visual similarity to photos.\" If the user has opted out, we should show the existing species search instead of the Suggestions."},"comment":{"url":"https://api.github.com/repos/inaturalist/iNaturalistAndroid/issues/comments/322273937","html_url":"https://github.com/inaturalist/iNaturalistAndroid/issues/382#issuecomment-322273937","issue_url":"https://api.github.com/repos/inaturalist/iNaturalistAndroid/issues/382","id":322273937,"user":{"login":"joellebel","id":11527994,"avatar_url":"https://avatars3.githubusercontent.com/u/11527994?v=4","gravatar_id":"","url":"https://api.github.com/users/joellebel","html_url":"https://github.com/joellebel","followers_url":"https://api.github.com/users/joellebel/followers","following_url":"https://api.github.com/users/joellebel/following{/other_user}","gists_url":"https://api.github.com/users/joellebel/gists{/gist_id}","starred_url":"https://api.github.com/users/joellebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joellebel/subscriptions","organizations_url":"https://api.github.com/users/joellebel/orgs","repos_url":"https://api.github.com/users/joellebel/repos","events_url":"https://api.github.com/users/joellebel/events{/privacy}","received_events_url":"https://api.github.com/users/joellebel/received_events","type":"User","site_admin":false},"created_at":"2017-08-14T18:42:35Z","updated_at":"2017-08-14T18:42:35Z","body":"# Round 1 Implementation Feedback\r\n\r\n@budowski  I summarized all our feedback and put it here for your convenience:\r\n\r\n- [ ] Photos and icons need to be about 30% bigger (We are curious to know if thumbnail size can be based on row width for a future release) \r\n\r\n- [ ] Everything should scroll, not just the top 10 suggestions\r\n\r\n- [ ] Photo (at the top) needs to be tappable to view full screen\r\n\r\n- [ ] Probably shouldn’t re-query on rotate\r\n\r\n- [ ] Maybe you haven't gotten to this yet, but the taxon chooser isn't working for the \"Suggest ID\" flow\r\n"}}
{"actor":{"display_login":"joellebel"}}