{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/158865986","pull_request_review_id":85731617,"id":158865986,"diff_hunk":"@@ -0,0 +1,58 @@\n+// Copyright Joyent, Inc. and other Node contributors.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a\n+// copy of this software and associated documentation files (the\n+// \"Software\"), to deal in the Software without restriction, including\n+// without limitation the rights to use, copy, modify, merge, publish,\n+// distribute, sublicense, and/or sell copies of the Software, and to permit\n+// persons to whom the Software is furnished to do so, subject to the\n+// following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included\n+// in all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS\n+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN\n+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,\n+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR\n+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE\n+// USE OR OTHER DEALINGS IN THE SOFTWARE.\n+\n+'use strict';\n+const common = require('../common');\n+const fixtures = require('../common/fixtures');\n+const fs = require('fs');\n+const filepath = fixtures.path('x.txt');\n+const fd = fs.openSync(filepath, 'r');\n+\n+const expected = Buffer.from('xyz\\n');\n+\n+common.expectsError(\n+  fs.read.bind(fd,\n+               Buffer.allocUnsafe(expected.length),\n+               0,\n+               expected.length,\n+               0,\n+               common.mustNotCall()),\n+  { code: 'ERR_INVALID_ARG_TYPE', type: TypeError });\n+\n+common.expectsError(\n+  fs.read.bind(undefined,\n+               fd,\n+               Buffer.allocUnsafe(expected.length),\n+               -1,\n+               expected.length,\n+               0,\n+               common.mustNotCall()),\n+  { code: 'ERR_OUT_OF_RANGE', type: RangeError });","path":"test/parallel/test-fs-read-constructor-errors.js","position":48,"original_position":48,"commit_id":"5e59b4fab76ef108acec8e882c5c09fb16d65e6c","original_commit_id":"5e59b4fab76ef108acec8e882c5c09fb16d65e6c","user":{"login":"apapirovski","id":20809,"avatar_url":"https://avatars2.githubusercontent.com/u/20809?v=4","gravatar_id":"","url":"https://api.github.com/users/apapirovski","html_url":"https://github.com/apapirovski","followers_url":"https://api.github.com/users/apapirovski/followers","following_url":"https://api.github.com/users/apapirovski/following{/other_user}","gists_url":"https://api.github.com/users/apapirovski/gists{/gist_id}","starred_url":"https://api.github.com/users/apapirovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapirovski/subscriptions","organizations_url":"https://api.github.com/users/apapirovski/orgs","repos_url":"https://api.github.com/users/apapirovski/repos","events_url":"https://api.github.com/users/apapirovski/events{/privacy}","received_events_url":"https://api.github.com/users/apapirovski/received_events","type":"User","site_admin":false},"body":"Does this have an upper boundary or just lower? If it does, that would ideally also be tested.","created_at":"2017-12-27T20:44:44Z","updated_at":"2017-12-27T20:45:32Z","html_url":"https://github.com/nodejs/node/pull/17875#discussion_r158865986","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/17875","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/158865986"},"html":{"href":"https://github.com/nodejs/node/pull/17875#discussion_r158865986"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/17875"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/17875","id":160218093,"html_url":"https://github.com/nodejs/node/pull/17875","diff_url":"https://github.com/nodejs/node/pull/17875.diff","patch_url":"https://github.com/nodejs/node/pull/17875.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/17875","number":17875,"state":"open","locked":false,"title":"test: added coverage tests related with method fs.read and fs.readSync","user":{"login":"bacriom","id":25074747,"avatar_url":"https://avatars2.githubusercontent.com/u/25074747?v=4","gravatar_id":"","url":"https://api.github.com/users/bacriom","html_url":"https://github.com/bacriom","followers_url":"https://api.github.com/users/bacriom/followers","following_url":"https://api.github.com/users/bacriom/following{/other_user}","gists_url":"https://api.github.com/users/bacriom/gists{/gist_id}","starred_url":"https://api.github.com/users/bacriom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacriom/subscriptions","organizations_url":"https://api.github.com/users/bacriom/orgs","repos_url":"https://api.github.com/users/bacriom/repos","events_url":"https://api.github.com/users/bacriom/events{/privacy}","received_events_url":"https://api.github.com/users/bacriom/received_events","type":"User","site_admin":false},"body":"Tests added to extend the code coverage testing of the project on the method read and readSync of the file fs.js\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)","created_at":"2017-12-27T09:17:18Z","updated_at":"2017-12-27T20:45:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57591e8ebd2f7ed3aed9f265c7206a1c672891cf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/17875/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/17875/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/17875/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/5e59b4fab76ef108acec8e882c5c09fb16d65e6c","head":{"label":"bacriom:bacriom-branch","ref":"bacriom-branch","sha":"5e59b4fab76ef108acec8e882c5c09fb16d65e6c","user":{"login":"bacriom","id":25074747,"avatar_url":"https://avatars2.githubusercontent.com/u/25074747?v=4","gravatar_id":"","url":"https://api.github.com/users/bacriom","html_url":"https://github.com/bacriom","followers_url":"https://api.github.com/users/bacriom/followers","following_url":"https://api.github.com/users/bacriom/following{/other_user}","gists_url":"https://api.github.com/users/bacriom/gists{/gist_id}","starred_url":"https://api.github.com/users/bacriom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacriom/subscriptions","organizations_url":"https://api.github.com/users/bacriom/orgs","repos_url":"https://api.github.com/users/bacriom/repos","events_url":"https://api.github.com/users/bacriom/events{/privacy}","received_events_url":"https://api.github.com/users/bacriom/received_events","type":"User","site_admin":false},"repo":{"id":114691578,"name":"node","full_name":"bacriom/node","owner":{"login":"bacriom","id":25074747,"avatar_url":"https://avatars2.githubusercontent.com/u/25074747?v=4","gravatar_id":"","url":"https://api.github.com/users/bacriom","html_url":"https://github.com/bacriom","followers_url":"https://api.github.com/users/bacriom/followers","following_url":"https://api.github.com/users/bacriom/following{/other_user}","gists_url":"https://api.github.com/users/bacriom/gists{/gist_id}","starred_url":"https://api.github.com/users/bacriom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacriom/subscriptions","organizations_url":"https://api.github.com/users/bacriom/orgs","repos_url":"https://api.github.com/users/bacriom/repos","events_url":"https://api.github.com/users/bacriom/events{/privacy}","received_events_url":"https://api.github.com/users/bacriom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bacriom/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/bacriom/node","forks_url":"https://api.github.com/repos/bacriom/node/forks","keys_url":"https://api.github.com/repos/bacriom/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bacriom/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bacriom/node/teams","hooks_url":"https://api.github.com/repos/bacriom/node/hooks","issue_events_url":"https://api.github.com/repos/bacriom/node/issues/events{/number}","events_url":"https://api.github.com/repos/bacriom/node/events","assignees_url":"https://api.github.com/repos/bacriom/node/assignees{/user}","branches_url":"https://api.github.com/repos/bacriom/node/branches{/branch}","tags_url":"https://api.github.com/repos/bacriom/node/tags","blobs_url":"https://api.github.com/repos/bacriom/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bacriom/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bacriom/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/bacriom/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bacriom/node/statuses/{sha}","languages_url":"https://api.github.com/repos/bacriom/node/languages","stargazers_url":"https://api.github.com/repos/bacriom/node/stargazers","contributors_url":"https://api.github.com/repos/bacriom/node/contributors","subscribers_url":"https://api.github.com/repos/bacriom/node/subscribers","subscription_url":"https://api.github.com/repos/bacriom/node/subscription","commits_url":"https://api.github.com/repos/bacriom/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/bacriom/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/bacriom/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/bacriom/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/bacriom/node/contents/{+path}","compare_url":"https://api.github.com/repos/bacriom/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bacriom/node/merges","archive_url":"https://api.github.com/repos/bacriom/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bacriom/node/downloads","issues_url":"https://api.github.com/repos/bacriom/node/issues{/number}","pulls_url":"https://api.github.com/repos/bacriom/node/pulls{/number}","milestones_url":"https://api.github.com/repos/bacriom/node/milestones{/number}","notifications_url":"https://api.github.com/repos/bacriom/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bacriom/node/labels{/name}","releases_url":"https://api.github.com/repos/bacriom/node/releases{/id}","deployments_url":"https://api.github.com/repos/bacriom/node/deployments","created_at":"2017-12-18T21:55:45Z","updated_at":"2017-12-18T21:56:10Z","pushed_at":"2017-12-27T20:15:54Z","git_url":"git://github.com/bacriom/node.git","ssh_url":"git@github.com:bacriom/node.git","clone_url":"https://github.com/bacriom/node.git","svn_url":"https://github.com/bacriom/node","homepage":"https://nodejs.org","size":340457,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"03b8ac14e7cb535fc7a82188c666b5a2a38d00bc","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-12-27T19:38:32Z","pushed_at":"2017-12-27T19:55:13Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":342436,"stargazers_count":43889,"watchers_count":43889,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9187,"mirror_url":null,"archived":false,"open_issues_count":771,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9187,"open_issues":771,"watchers":43889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/17875"},"html":{"href":"https://github.com/nodejs/node/pull/17875"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/17875"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/17875/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/17875/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/17875/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/5e59b4fab76ef108acec8e882c5c09fb16d65e6c"}},"author_association":"NONE"}}
{"actor":{"display_login":"apapirovski"}}