{"action":"created","comment":{"url":"https://api.github.com/repos/lucified/minard-backend/pulls/comments/119904015","pull_request_review_id":41828615,"id":119904015,"diff_hunk":"@@ -248,7 +248,13 @@ class AuthenticationHapiPlugin extends HapiPlugin {\n       const teamTokenResult = await teamTokenQuery(this.db, { teamId: team.id });\n       const teamToken =\n         (teamTokenResult && teamTokenResult.length) ? teamTokenResult[0].token : undefined;\n-      return reply({ ...team, 'invitation-token': teamToken });\n+      return reply({\n+        id: team.id,\n+        name: team.id,","path":"src/authentication/authentication-hapi-plugin.ts","position":7,"original_position":7,"commit_id":"aff20aa1b327799f5e5dc2cd8dcad2cc993d87fa","original_commit_id":"aff20aa1b327799f5e5dc2cd8dcad2cc993d87fa","user":{"login":"dennari","id":112560,"avatar_url":"https://avatars2.githubusercontent.com/u/112560?v=3","gravatar_id":"","url":"https://api.github.com/users/dennari","html_url":"https://github.com/dennari","followers_url":"https://api.github.com/users/dennari/followers","following_url":"https://api.github.com/users/dennari/following{/other_user}","gists_url":"https://api.github.com/users/dennari/gists{/gist_id}","starred_url":"https://api.github.com/users/dennari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennari/subscriptions","organizations_url":"https://api.github.com/users/dennari/orgs","repos_url":"https://api.github.com/users/dennari/repos","events_url":"https://api.github.com/users/dennari/events{/privacy}","received_events_url":"https://api.github.com/users/dennari/received_events","type":"User","site_admin":false},"body":"Shouldn't this be `team.name`? This could be tested, along with all the properties included here, in the unit test.","created_at":"2017-06-02T16:55:52Z","updated_at":"2017-06-02T16:56:07Z","html_url":"https://github.com/lucified/minard-backend/pull/213#discussion_r119904015","pull_request_url":"https://api.github.com/repos/lucified/minard-backend/pulls/213","_links":{"self":{"href":"https://api.github.com/repos/lucified/minard-backend/pulls/comments/119904015"},"html":{"href":"https://github.com/lucified/minard-backend/pull/213#discussion_r119904015"},"pull_request":{"href":"https://api.github.com/repos/lucified/minard-backend/pulls/213"}}},"pull_request":{"url":"https://api.github.com/repos/lucified/minard-backend/pulls/213","id":123725379,"html_url":"https://github.com/lucified/minard-backend/pull/213","diff_url":"https://github.com/lucified/minard-backend/pull/213.diff","patch_url":"https://github.com/lucified/minard-backend/pull/213.patch","issue_url":"https://api.github.com/repos/lucified/minard-backend/issues/213","number":213,"state":"open","locked":false,"title":"Don't leak GitLab-specific information in team endpoint","user":{"login":"vsaarinen","id":888333,"avatar_url":"https://avatars2.githubusercontent.com/u/888333?v=3","gravatar_id":"","url":"https://api.github.com/users/vsaarinen","html_url":"https://github.com/vsaarinen","followers_url":"https://api.github.com/users/vsaarinen/followers","following_url":"https://api.github.com/users/vsaarinen/following{/other_user}","gists_url":"https://api.github.com/users/vsaarinen/gists{/gist_id}","starred_url":"https://api.github.com/users/vsaarinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsaarinen/subscriptions","organizations_url":"https://api.github.com/users/vsaarinen/orgs","repos_url":"https://api.github.com/users/vsaarinen/repos","events_url":"https://api.github.com/users/vsaarinen/events{/privacy}","received_events_url":"https://api.github.com/users/vsaarinen/received_events","type":"User","site_admin":false},"body":"`/team` was returning information that is not used by minard-ui such as `web_url`. This field contained an internal GitLab URL that should not be visible to users. Fix this.","created_at":"2017-06-02T14:06:22Z","updated_at":"2017-06-02T16:56:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b3e371c1ee12b7b76b899f936a8fdbd21f16ec2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lucified/minard-backend/pulls/213/commits","review_comments_url":"https://api.github.com/repos/lucified/minard-backend/pulls/213/comments","review_comment_url":"https://api.github.com/repos/lucified/minard-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lucified/minard-backend/issues/213/comments","statuses_url":"https://api.github.com/repos/lucified/minard-backend/statuses/aff20aa1b327799f5e5dc2cd8dcad2cc993d87fa","head":{"label":"lucified:dont-return-web-url-with-team-info","ref":"dont-return-web-url-with-team-info","sha":"aff20aa1b327799f5e5dc2cd8dcad2cc993d87fa","user":{"login":"lucified","id":15692433,"avatar_url":"https://avatars2.githubusercontent.com/u/15692433?v=3","gravatar_id":"","url":"https://api.github.com/users/lucified","html_url":"https://github.com/lucified","followers_url":"https://api.github.com/users/lucified/followers","following_url":"https://api.github.com/users/lucified/following{/other_user}","gists_url":"https://api.github.com/users/lucified/gists{/gist_id}","starred_url":"https://api.github.com/users/lucified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucified/subscriptions","organizations_url":"https://api.github.com/users/lucified/orgs","repos_url":"https://api.github.com/users/lucified/repos","events_url":"https://api.github.com/users/lucified/events{/privacy}","received_events_url":"https://api.github.com/users/lucified/received_events","type":"Organization","site_admin":false},"repo":{"id":63178369,"name":"minard-backend","full_name":"lucified/minard-backend","owner":{"login":"lucified","id":15692433,"avatar_url":"https://avatars2.githubusercontent.com/u/15692433?v=3","gravatar_id":"","url":"https://api.github.com/users/lucified","html_url":"https://github.com/lucified","followers_url":"https://api.github.com/users/lucified/followers","following_url":"https://api.github.com/users/lucified/following{/other_user}","gists_url":"https://api.github.com/users/lucified/gists{/gist_id}","starred_url":"https://api.github.com/users/lucified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucified/subscriptions","organizations_url":"https://api.github.com/users/lucified/orgs","repos_url":"https://api.github.com/users/lucified/repos","events_url":"https://api.github.com/users/lucified/events{/privacy}","received_events_url":"https://api.github.com/users/lucified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lucified/minard-backend","description":"Minard backend","fork":false,"url":"https://api.github.com/repos/lucified/minard-backend","forks_url":"https://api.github.com/repos/lucified/minard-backend/forks","keys_url":"https://api.github.com/repos/lucified/minard-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucified/minard-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucified/minard-backend/teams","hooks_url":"https://api.github.com/repos/lucified/minard-backend/hooks","issue_events_url":"https://api.github.com/repos/lucified/minard-backend/issues/events{/number}","events_url":"https://api.github.com/repos/lucified/minard-backend/events","assignees_url":"https://api.github.com/repos/lucified/minard-backend/assignees{/user}","branches_url":"https://api.github.com/repos/lucified/minard-backend/branches{/branch}","tags_url":"https://api.github.com/repos/lucified/minard-backend/tags","blobs_url":"https://api.github.com/repos/lucified/minard-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucified/minard-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucified/minard-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucified/minard-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucified/minard-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/lucified/minard-backend/languages","stargazers_url":"https://api.github.com/repos/lucified/minard-backend/stargazers","contributors_url":"https://api.github.com/repos/lucified/minard-backend/contributors","subscribers_url":"https://api.github.com/repos/lucified/minard-backend/subscribers","subscription_url":"https://api.github.com/repos/lucified/minard-backend/subscription","commits_url":"https://api.github.com/repos/lucified/minard-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucified/minard-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucified/minard-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucified/minard-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucified/minard-backend/contents/{+path}","compare_url":"https://api.github.com/repos/lucified/minard-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucified/minard-backend/merges","archive_url":"https://api.github.com/repos/lucified/minard-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucified/minard-backend/downloads","issues_url":"https://api.github.com/repos/lucified/minard-backend/issues{/number}","pulls_url":"https://api.github.com/repos/lucified/minard-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/lucified/minard-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/lucified/minard-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucified/minard-backend/labels{/name}","releases_url":"https://api.github.com/repos/lucified/minard-backend/releases{/id}","deployments_url":"https://api.github.com/repos/lucified/minard-backend/deployments","created_at":"2016-07-12T17:24:24Z","updated_at":"2017-04-02T17:45:48Z","pushed_at":"2017-06-02T16:51:23Z","git_url":"git://github.com/lucified/minard-backend.git","ssh_url":"git@github.com:lucified/minard-backend.git","clone_url":"https://github.com/lucified/minard-backend.git","svn_url":"https://github.com/lucified/minard-backend","homepage":"https://lucify.com/minard","size":2445,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"base":{"label":"lucified:master","ref":"master","sha":"9478547ba029378bc01bd3b3a2bac498abcc60e2","user":{"login":"lucified","id":15692433,"avatar_url":"https://avatars2.githubusercontent.com/u/15692433?v=3","gravatar_id":"","url":"https://api.github.com/users/lucified","html_url":"https://github.com/lucified","followers_url":"https://api.github.com/users/lucified/followers","following_url":"https://api.github.com/users/lucified/following{/other_user}","gists_url":"https://api.github.com/users/lucified/gists{/gist_id}","starred_url":"https://api.github.com/users/lucified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucified/subscriptions","organizations_url":"https://api.github.com/users/lucified/orgs","repos_url":"https://api.github.com/users/lucified/repos","events_url":"https://api.github.com/users/lucified/events{/privacy}","received_events_url":"https://api.github.com/users/lucified/received_events","type":"Organization","site_admin":false},"repo":{"id":63178369,"name":"minard-backend","full_name":"lucified/minard-backend","owner":{"login":"lucified","id":15692433,"avatar_url":"https://avatars2.githubusercontent.com/u/15692433?v=3","gravatar_id":"","url":"https://api.github.com/users/lucified","html_url":"https://github.com/lucified","followers_url":"https://api.github.com/users/lucified/followers","following_url":"https://api.github.com/users/lucified/following{/other_user}","gists_url":"https://api.github.com/users/lucified/gists{/gist_id}","starred_url":"https://api.github.com/users/lucified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucified/subscriptions","organizations_url":"https://api.github.com/users/lucified/orgs","repos_url":"https://api.github.com/users/lucified/repos","events_url":"https://api.github.com/users/lucified/events{/privacy}","received_events_url":"https://api.github.com/users/lucified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lucified/minard-backend","description":"Minard backend","fork":false,"url":"https://api.github.com/repos/lucified/minard-backend","forks_url":"https://api.github.com/repos/lucified/minard-backend/forks","keys_url":"https://api.github.com/repos/lucified/minard-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lucified/minard-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lucified/minard-backend/teams","hooks_url":"https://api.github.com/repos/lucified/minard-backend/hooks","issue_events_url":"https://api.github.com/repos/lucified/minard-backend/issues/events{/number}","events_url":"https://api.github.com/repos/lucified/minard-backend/events","assignees_url":"https://api.github.com/repos/lucified/minard-backend/assignees{/user}","branches_url":"https://api.github.com/repos/lucified/minard-backend/branches{/branch}","tags_url":"https://api.github.com/repos/lucified/minard-backend/tags","blobs_url":"https://api.github.com/repos/lucified/minard-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lucified/minard-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lucified/minard-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/lucified/minard-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lucified/minard-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/lucified/minard-backend/languages","stargazers_url":"https://api.github.com/repos/lucified/minard-backend/stargazers","contributors_url":"https://api.github.com/repos/lucified/minard-backend/contributors","subscribers_url":"https://api.github.com/repos/lucified/minard-backend/subscribers","subscription_url":"https://api.github.com/repos/lucified/minard-backend/subscription","commits_url":"https://api.github.com/repos/lucified/minard-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/lucified/minard-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/lucified/minard-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/lucified/minard-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/lucified/minard-backend/contents/{+path}","compare_url":"https://api.github.com/repos/lucified/minard-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lucified/minard-backend/merges","archive_url":"https://api.github.com/repos/lucified/minard-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lucified/minard-backend/downloads","issues_url":"https://api.github.com/repos/lucified/minard-backend/issues{/number}","pulls_url":"https://api.github.com/repos/lucified/minard-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/lucified/minard-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/lucified/minard-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lucified/minard-backend/labels{/name}","releases_url":"https://api.github.com/repos/lucified/minard-backend/releases{/id}","deployments_url":"https://api.github.com/repos/lucified/minard-backend/deployments","created_at":"2016-07-12T17:24:24Z","updated_at":"2017-04-02T17:45:48Z","pushed_at":"2017-06-02T16:51:23Z","git_url":"git://github.com/lucified/minard-backend.git","ssh_url":"git@github.com:lucified/minard-backend.git","clone_url":"https://github.com/lucified/minard-backend.git","svn_url":"https://github.com/lucified/minard-backend","homepage":"https://lucify.com/minard","size":2445,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lucified/minard-backend/pulls/213"},"html":{"href":"https://github.com/lucified/minard-backend/pull/213"},"issue":{"href":"https://api.github.com/repos/lucified/minard-backend/issues/213"},"comments":{"href":"https://api.github.com/repos/lucified/minard-backend/issues/213/comments"},"review_comments":{"href":"https://api.github.com/repos/lucified/minard-backend/pulls/213/comments"},"review_comment":{"href":"https://api.github.com/repos/lucified/minard-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lucified/minard-backend/pulls/213/commits"},"statuses":{"href":"https://api.github.com/repos/lucified/minard-backend/statuses/aff20aa1b327799f5e5dc2cd8dcad2cc993d87fa"}}}}
{"actor":{"display_login":"dennari"}}