{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1954","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1954/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1954/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1954/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1954","id":251120064,"number":1954,"title":"controller name adjustment no longer needed for `provider_foreman`","user":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars3.githubusercontent.com/u/1538216?v=4","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-18T02:05:14Z","updated_at":"2017-08-18T14:23:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1954","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1954","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1954.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1954.patch"},"body":"The PR is basically a revert of 1f6221d7ad1f5fc330d5c9b8725c510946b538cb (https://github.com/ManageIQ/manageiq-ui-classic/pull/1847)\r\n\r\n@himdel @karelhala Like I had indicated in https://github.com/ManageIQ/manageiq-ui-classic/pull/1847, we never really needed this `controller name` adjustment for `provider_foreman` before. \r\nSomething changed last week which caused the below error -\r\n```\r\n-07T12:14:07.262478 #36969] FATAL -- : Error caught: [ActionController::UrlGenerationError] No route matches {:action=>\"show\", :controller=>\"ems_configuration\", :id=>\"29\"}\r\n\r\n```\r\nbut now, the issue seems to have fixed itself, just like that, and we do not need the https://github.com/ManageIQ/manageiq-ui-classic/pull/1847 fix anymore.\r\n\r\nWhat broke it, and what fixed it, remains a mystery.\r\n(My hunch is webpack related changes had something to do with it)\r\n\r\nSo let's remove those lines since they are not needed anymore.\r\nLet's get a better handle on the issue if it resurfaces. Thanks."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/323367572","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1954#issuecomment-323367572","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1954","id":323367572,"user":{"login":"AparnaKarve","id":1538216,"avatar_url":"https://avatars3.githubusercontent.com/u/1538216?v=4","gravatar_id":"","url":"https://api.github.com/users/AparnaKarve","html_url":"https://github.com/AparnaKarve","followers_url":"https://api.github.com/users/AparnaKarve/followers","following_url":"https://api.github.com/users/AparnaKarve/following{/other_user}","gists_url":"https://api.github.com/users/AparnaKarve/gists{/gist_id}","starred_url":"https://api.github.com/users/AparnaKarve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AparnaKarve/subscriptions","organizations_url":"https://api.github.com/users/AparnaKarve/orgs","repos_url":"https://api.github.com/users/AparnaKarve/repos","events_url":"https://api.github.com/users/AparnaKarve/events{/privacy}","received_events_url":"https://api.github.com/users/AparnaKarve/received_events","type":"User","site_admin":false},"created_at":"2017-08-18T14:23:52Z","updated_at":"2017-08-18T14:23:52Z","body":"@miq-bot add_label fine/no,gtl"}}
{"actor":{"display_login":"AparnaKarve"}}