{"action":"created","issue":{"url":"https://api.github.com/repos/springfox/springfox/issues/1671","repository_url":"https://api.github.com/repos/springfox/springfox","labels_url":"https://api.github.com/repos/springfox/springfox/issues/1671/labels{/name}","comments_url":"https://api.github.com/repos/springfox/springfox/issues/1671/comments","events_url":"https://api.github.com/repos/springfox/springfox/issues/1671/events","html_url":"https://github.com/springfox/springfox/pull/1671","id":206882988,"number":1671,"title":"General functionality for comparing models. Initial support for #182, #807, #895, #1356","user":{"login":"MaksimOrlov","id":7836239,"avatar_url":"https://avatars.githubusercontent.com/u/7836239?v=3","gravatar_id":"","url":"https://api.github.com/users/MaksimOrlov","html_url":"https://github.com/MaksimOrlov","followers_url":"https://api.github.com/users/MaksimOrlov/followers","following_url":"https://api.github.com/users/MaksimOrlov/following{/other_user}","gists_url":"https://api.github.com/users/MaksimOrlov/gists{/gist_id}","starred_url":"https://api.github.com/users/MaksimOrlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaksimOrlov/subscriptions","organizations_url":"https://api.github.com/users/MaksimOrlov/orgs","repos_url":"https://api.github.com/users/MaksimOrlov/repos","events_url":"https://api.github.com/users/MaksimOrlov/events{/privacy}","received_events_url":"https://api.github.com/users/MaksimOrlov/received_events","type":"User","site_admin":false},"labels":[{"id":239929280,"url":"https://api.github.com/repos/springfox/springfox/labels/PR","name":"PR","color":"fbca04","default":false},{"id":533732449,"url":"https://api.github.com/repos/springfox/springfox/labels/ready","name":"ready","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/springfox/springfox/milestones/39","html_url":"https://github.com/springfox/springfox/milestone/39","labels_url":"https://api.github.com/repos/springfox/springfox/milestones/39/labels","id":1974106,"number":39,"title":"2.7.0","description":"","creator":{"login":"dilipkrish","id":73257,"avatar_url":"https://avatars.githubusercontent.com/u/73257?v=3","gravatar_id":"","url":"https://api.github.com/users/dilipkrish","html_url":"https://github.com/dilipkrish","followers_url":"https://api.github.com/users/dilipkrish/followers","following_url":"https://api.github.com/users/dilipkrish/following{/other_user}","gists_url":"https://api.github.com/users/dilipkrish/gists{/gist_id}","starred_url":"https://api.github.com/users/dilipkrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilipkrish/subscriptions","organizations_url":"https://api.github.com/users/dilipkrish/orgs","repos_url":"https://api.github.com/users/dilipkrish/repos","events_url":"https://api.github.com/users/dilipkrish/events{/privacy}","received_events_url":"https://api.github.com/users/dilipkrish/received_events","type":"User","site_admin":false},"open_issues":112,"closed_issues":38,"state":"open","created_at":"2016-08-31T03:16:25Z","updated_at":"2017-02-14T13:29:18Z","due_on":"2017-03-01T08:00:00Z","closed_at":null},"comments":4,"created_at":"2017-02-10T19:19:19Z","updated_at":"2017-02-14T15:40:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/springfox/springfox/pulls/1671","html_url":"https://github.com/springfox/springfox/pull/1671","diff_url":"https://github.com/springfox/springfox/pull/1671.diff","patch_url":"https://github.com/springfox/springfox/pull/1671.patch"},"body":"Good evening, @dilipkrish .\r\n\r\nIt is my view and my suggestion for how **models** should be compared and linked with each other.\r\n\r\nThis PR is related to issues #182, #563, #807, #895 and #1356.\r\n\r\nThe short review about idea is:\r\n\r\n1. At first we add link between **ResolvedMethodParameter** and it's **ModelContext**. We will keep links inside **OperationModelContextsBuilder**.\r\n\r\n2. Then, when we will go through each **ModelContext** we will use _.fromParent_ to keep link inside **ModelContext**, because, if we change it's model (_@JsonView_ or something else) we will change parent's model consequently. \r\n\r\n3. Each **ModelProperty** keeps link to related **ModelContext** inside **ModelReferenceProvider**.\r\n\r\n4. We compare models with .equals, by building a tree with contexts and compare it with other models level by level.\r\n\r\nComparing models without saving links could lead to the situation when model's name was changed (i.e. _name ->name_1_), but **ModelReference** (in **Parameter** or **ModelProperty**) is still pointing to old model's name, that will lead to inappropriate stuff....\r\n\r\nI'm looking forward for your opinion, remarks, suggestions, etc....\r\n\r\nP.S I remove **Cacheable** while I was testing, I think I know the way how to return it back."},"comment":{"url":"https://api.github.com/repos/springfox/springfox/issues/comments/279742805","html_url":"https://github.com/springfox/springfox/pull/1671#issuecomment-279742805","issue_url":"https://api.github.com/repos/springfox/springfox/issues/1671","id":279742805,"user":{"login":"MaksimOrlov","id":7836239,"avatar_url":"https://avatars.githubusercontent.com/u/7836239?v=3","gravatar_id":"","url":"https://api.github.com/users/MaksimOrlov","html_url":"https://github.com/MaksimOrlov","followers_url":"https://api.github.com/users/MaksimOrlov/followers","following_url":"https://api.github.com/users/MaksimOrlov/following{/other_user}","gists_url":"https://api.github.com/users/MaksimOrlov/gists{/gist_id}","starred_url":"https://api.github.com/users/MaksimOrlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaksimOrlov/subscriptions","organizations_url":"https://api.github.com/users/MaksimOrlov/orgs","repos_url":"https://api.github.com/users/MaksimOrlov/repos","events_url":"https://api.github.com/users/MaksimOrlov/events{/privacy}","received_events_url":"https://api.github.com/users/MaksimOrlov/received_events","type":"User","site_admin":false},"created_at":"2017-02-14T15:40:48Z","updated_at":"2017-02-14T15:40:48Z","body":"@dilipkrish, I've just registered a google id, here is a [link](https://plus.google.com/108554856838783249526). The Id is **108554856838783249526**.\r\nUnfortunately, I have never used hangout before, I don't know how good connection is relatively to my computer comparing to skype..."}}
{"actor":{"display_login":"MaksimOrlov"}}