{"action":"closed","number":738,"pull_request":{"url":"https://api.github.com/repos/appium/java-client/pulls/738","id":143523883,"html_url":"https://github.com/appium/java-client/pull/738","diff_url":"https://github.com/appium/java-client/pull/738.diff","patch_url":"https://github.com/appium/java-client/pull/738.patch","issue_url":"https://api.github.com/repos/appium/java-client/issues/738","number":738,"state":"closed","locked":false,"title":"Explicit","user":{"login":"titusfortner","id":777185,"avatar_url":"https://avatars3.githubusercontent.com/u/777185?v=4","gravatar_id":"","url":"https://api.github.com/users/titusfortner","html_url":"https://github.com/titusfortner","followers_url":"https://api.github.com/users/titusfortner/followers","following_url":"https://api.github.com/users/titusfortner/following{/other_user}","gists_url":"https://api.github.com/users/titusfortner/gists{/gist_id}","starred_url":"https://api.github.com/users/titusfortner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusfortner/subscriptions","organizations_url":"https://api.github.com/users/titusfortner/orgs","repos_url":"https://api.github.com/users/titusfortner/repos","events_url":"https://api.github.com/users/titusfortner/events{/privacy}","received_events_url":"https://api.github.com/users/titusfortner/received_events","type":"User","site_admin":false},"body":"## Change list\r\n* Changes name of constant since it actually isn't being used implicitly\r\n* Removes the resetting of implicit waits\r\n \r\n## Types of changes\r\n\r\nWhat types of changes are you proposing/introducing to Java client?\r\n_Put an `x` in the boxes that apply_\r\n\r\n- [ ] No changes in production code.\r\n- [ ] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n\r\n## Details\r\n\r\nImplicit waits are currently entirely overridden. Setting implicit wait to 0.5 or 300 won't make any difference when locating elements.\r\n\r\nI don't think we should remove the user's ability to set an implicit wait, even if it can have negative consequences for them.\r\n\r\nThis is a \"breaking\" change because implicit waits will now be respected, which can allow users to combine implicit and explicit in ways that are not ideal, or cause longer test runs if users are testing for the absence of an element. But I think them not being respected before was technically the unexpected behavior, and this is essentially a bug fix for that.\r\n\r\nI think this should be released with the recognition that people might have timing issues and that they should be told not to set implicit waits if they want to keep previous behavior.\r\n\r\nI'm trying to think about how overriding the implicit wait setting in the appium driver, storing the value and doing fancy things with it during location method could work... but all I come up with would remove options from the user that I think they should have.\r\n\r\nAnyway, let's discuss. Feel free to use/modify this code as necessary in anything you end up doing..","created_at":"2017-09-27T23:31:02Z","updated_at":"2017-10-02T12:32:59Z","closed_at":"2017-10-02T12:32:59Z","merged_at":"2017-10-02T12:32:58Z","merge_commit_sha":"a971cc838f9b68509d0ad02801df67343060cd6d","assignee":{"login":"TikhomirovSergey","id":4927589,"avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"assignees":[{"login":"TikhomirovSergey","id":4927589,"avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/java-client/pulls/738/commits","review_comments_url":"https://api.github.com/repos/appium/java-client/pulls/738/comments","review_comment_url":"https://api.github.com/repos/appium/java-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/java-client/issues/738/comments","statuses_url":"https://api.github.com/repos/appium/java-client/statuses/a971cc838f9b68509d0ad02801df67343060cd6d","head":{"label":"titusfortner:explicit","ref":"explicit","sha":"a971cc838f9b68509d0ad02801df67343060cd6d","user":{"login":"titusfortner","id":777185,"avatar_url":"https://avatars3.githubusercontent.com/u/777185?v=4","gravatar_id":"","url":"https://api.github.com/users/titusfortner","html_url":"https://github.com/titusfortner","followers_url":"https://api.github.com/users/titusfortner/followers","following_url":"https://api.github.com/users/titusfortner/following{/other_user}","gists_url":"https://api.github.com/users/titusfortner/gists{/gist_id}","starred_url":"https://api.github.com/users/titusfortner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusfortner/subscriptions","organizations_url":"https://api.github.com/users/titusfortner/orgs","repos_url":"https://api.github.com/users/titusfortner/repos","events_url":"https://api.github.com/users/titusfortner/events{/privacy}","received_events_url":"https://api.github.com/users/titusfortner/received_events","type":"User","site_admin":false},"repo":{"id":105071050,"name":"java-client","full_name":"titusfortner/java-client","owner":{"login":"titusfortner","id":777185,"avatar_url":"https://avatars3.githubusercontent.com/u/777185?v=4","gravatar_id":"","url":"https://api.github.com/users/titusfortner","html_url":"https://github.com/titusfortner","followers_url":"https://api.github.com/users/titusfortner/followers","following_url":"https://api.github.com/users/titusfortner/following{/other_user}","gists_url":"https://api.github.com/users/titusfortner/gists{/gist_id}","starred_url":"https://api.github.com/users/titusfortner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/titusfortner/subscriptions","organizations_url":"https://api.github.com/users/titusfortner/orgs","repos_url":"https://api.github.com/users/titusfortner/repos","events_url":"https://api.github.com/users/titusfortner/events{/privacy}","received_events_url":"https://api.github.com/users/titusfortner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/titusfortner/java-client","description":"Java language binding for writing Appium Tests, conforms to Mobile JSON Wire Protocol","fork":true,"url":"https://api.github.com/repos/titusfortner/java-client","forks_url":"https://api.github.com/repos/titusfortner/java-client/forks","keys_url":"https://api.github.com/repos/titusfortner/java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/titusfortner/java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/titusfortner/java-client/teams","hooks_url":"https://api.github.com/repos/titusfortner/java-client/hooks","issue_events_url":"https://api.github.com/repos/titusfortner/java-client/issues/events{/number}","events_url":"https://api.github.com/repos/titusfortner/java-client/events","assignees_url":"https://api.github.com/repos/titusfortner/java-client/assignees{/user}","branches_url":"https://api.github.com/repos/titusfortner/java-client/branches{/branch}","tags_url":"https://api.github.com/repos/titusfortner/java-client/tags","blobs_url":"https://api.github.com/repos/titusfortner/java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/titusfortner/java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/titusfortner/java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/titusfortner/java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/titusfortner/java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/titusfortner/java-client/languages","stargazers_url":"https://api.github.com/repos/titusfortner/java-client/stargazers","contributors_url":"https://api.github.com/repos/titusfortner/java-client/contributors","subscribers_url":"https://api.github.com/repos/titusfortner/java-client/subscribers","subscription_url":"https://api.github.com/repos/titusfortner/java-client/subscription","commits_url":"https://api.github.com/repos/titusfortner/java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/titusfortner/java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/titusfortner/java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/titusfortner/java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/titusfortner/java-client/contents/{+path}","compare_url":"https://api.github.com/repos/titusfortner/java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/titusfortner/java-client/merges","archive_url":"https://api.github.com/repos/titusfortner/java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/titusfortner/java-client/downloads","issues_url":"https://api.github.com/repos/titusfortner/java-client/issues{/number}","pulls_url":"https://api.github.com/repos/titusfortner/java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/titusfortner/java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/titusfortner/java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/titusfortner/java-client/labels{/name}","releases_url":"https://api.github.com/repos/titusfortner/java-client/releases{/id}","deployments_url":"https://api.github.com/repos/titusfortner/java-client/deployments","created_at":"2017-09-27T21:25:45Z","updated_at":"2017-09-27T21:25:47Z","pushed_at":"2017-09-28T13:39:07Z","git_url":"git://github.com/titusfortner/java-client.git","ssh_url":"git@github.com:titusfortner/java-client.git","clone_url":"https://github.com/titusfortner/java-client.git","svn_url":"https://github.com/titusfortner/java-client","homepage":null,"size":48033,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"b68ec85b8075c97f711005b3b1c21da9f14610c7","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":18454064,"name":"java-client","full_name":"appium/java-client","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/java-client","description":"Java language binding for writing Appium Tests, conforms to Mobile JSON Wire Protocol","fork":false,"url":"https://api.github.com/repos/appium/java-client","forks_url":"https://api.github.com/repos/appium/java-client/forks","keys_url":"https://api.github.com/repos/appium/java-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/java-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/java-client/teams","hooks_url":"https://api.github.com/repos/appium/java-client/hooks","issue_events_url":"https://api.github.com/repos/appium/java-client/issues/events{/number}","events_url":"https://api.github.com/repos/appium/java-client/events","assignees_url":"https://api.github.com/repos/appium/java-client/assignees{/user}","branches_url":"https://api.github.com/repos/appium/java-client/branches{/branch}","tags_url":"https://api.github.com/repos/appium/java-client/tags","blobs_url":"https://api.github.com/repos/appium/java-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/java-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/java-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/java-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/java-client/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/java-client/languages","stargazers_url":"https://api.github.com/repos/appium/java-client/stargazers","contributors_url":"https://api.github.com/repos/appium/java-client/contributors","subscribers_url":"https://api.github.com/repos/appium/java-client/subscribers","subscription_url":"https://api.github.com/repos/appium/java-client/subscription","commits_url":"https://api.github.com/repos/appium/java-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/java-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/java-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/java-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/java-client/contents/{+path}","compare_url":"https://api.github.com/repos/appium/java-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/java-client/merges","archive_url":"https://api.github.com/repos/appium/java-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/java-client/downloads","issues_url":"https://api.github.com/repos/appium/java-client/issues{/number}","pulls_url":"https://api.github.com/repos/appium/java-client/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/java-client/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/java-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/java-client/labels{/name}","releases_url":"https://api.github.com/repos/appium/java-client/releases{/id}","deployments_url":"https://api.github.com/repos/appium/java-client/deployments","created_at":"2014-04-04T22:05:23Z","updated_at":"2017-10-01T06:45:55Z","pushed_at":"2017-10-02T12:32:56Z","git_url":"git://github.com/appium/java-client.git","ssh_url":"git@github.com:appium/java-client.git","clone_url":"https://github.com/appium/java-client.git","svn_url":"https://github.com/appium/java-client","homepage":null,"size":48030,"stargazers_count":400,"watchers_count":400,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":391,"mirror_url":null,"open_issues_count":49,"forks":391,"open_issues":49,"watchers":400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/java-client/pulls/738"},"html":{"href":"https://github.com/appium/java-client/pull/738"},"issue":{"href":"https://api.github.com/repos/appium/java-client/issues/738"},"comments":{"href":"https://api.github.com/repos/appium/java-client/issues/738/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/java-client/pulls/738/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/java-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/java-client/pulls/738/commits"},"statuses":{"href":"https://api.github.com/repos/appium/java-client/statuses/a971cc838f9b68509d0ad02801df67343060cd6d"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"TikhomirovSergey","id":4927589,"avatar_url":"https://avatars3.githubusercontent.com/u/4927589?v=4","gravatar_id":"","url":"https://api.github.com/users/TikhomirovSergey","html_url":"https://github.com/TikhomirovSergey","followers_url":"https://api.github.com/users/TikhomirovSergey/followers","following_url":"https://api.github.com/users/TikhomirovSergey/following{/other_user}","gists_url":"https://api.github.com/users/TikhomirovSergey/gists{/gist_id}","starred_url":"https://api.github.com/users/TikhomirovSergey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TikhomirovSergey/subscriptions","organizations_url":"https://api.github.com/users/TikhomirovSergey/orgs","repos_url":"https://api.github.com/users/TikhomirovSergey/repos","events_url":"https://api.github.com/users/TikhomirovSergey/events{/privacy}","received_events_url":"https://api.github.com/users/TikhomirovSergey/received_events","type":"User","site_admin":false},"comments":8,"review_comments":4,"maintainer_can_modify":false,"commits":2,"additions":10,"deletions":17,"changed_files":3}}
{"actor":{"display_login":"TikhomirovSergey"}}