{"action":"created","comment":{"url":"https://api.github.com/repos/codenvy/codenvy/pulls/comments/101011071","pull_request_review_id":21727709,"id":101011071,"diff_hunk":"@@ -1,3 +1,11 @@\n+# Include all custom CODENVY_* properties that user may has defined in its codenvy.env file\n+<% ENV.each do |k,v| -%>\n+<% if k.include? \"CODENVY_\" then  -%>","path":"dockerfiles/init/modules/codenvy/templates/codenvy.env.erb","position":3,"original_position":3,"commit_id":"ffa6be2b09aab59c20b6c36b49e2402d1a1398c6","original_commit_id":"ffa6be2b09aab59c20b6c36b49e2402d1a1398c6","user":{"login":"TylerJewell","id":392458,"avatar_url":"https://avatars.githubusercontent.com/u/392458?v=3","gravatar_id":"","url":"https://api.github.com/users/TylerJewell","html_url":"https://github.com/TylerJewell","followers_url":"https://api.github.com/users/TylerJewell/followers","following_url":"https://api.github.com/users/TylerJewell/following{/other_user}","gists_url":"https://api.github.com/users/TylerJewell/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerJewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerJewell/subscriptions","organizations_url":"https://api.github.com/users/TylerJewell/orgs","repos_url":"https://api.github.com/users/TylerJewell/repos","events_url":"https://api.github.com/users/TylerJewell/events{/privacy}","received_events_url":"https://api.github.com/users/TylerJewell/received_events","type":"User","site_admin":false},"body":"Yes, I agree we can remove this logic from this PR.","created_at":"2017-02-14T11:11:58Z","updated_at":"2017-02-14T11:11:58Z","html_url":"https://github.com/codenvy/codenvy/pull/1764#discussion_r101011071","pull_request_url":"https://api.github.com/repos/codenvy/codenvy/pulls/1764","_links":{"self":{"href":"https://api.github.com/repos/codenvy/codenvy/pulls/comments/101011071"},"html":{"href":"https://github.com/codenvy/codenvy/pull/1764#discussion_r101011071"},"pull_request":{"href":"https://api.github.com/repos/codenvy/codenvy/pulls/1764"}}},"pull_request":{"url":"https://api.github.com/repos/codenvy/codenvy/pulls/1764","id":105758595,"html_url":"https://github.com/codenvy/codenvy/pull/1764","diff_url":"https://github.com/codenvy/codenvy/pull/1764.diff","patch_url":"https://github.com/codenvy/codenvy/pull/1764.patch","issue_url":"https://api.github.com/repos/codenvy/codenvy/issues/1764","number":1764,"state":"open","locked":false,"title":"WIP - [cli] Clearer  networking configuration & CLI override for CODENVY_HOST","user":{"login":"TylerJewell","id":392458,"avatar_url":"https://avatars.githubusercontent.com/u/392458?v=3","gravatar_id":"","url":"https://api.github.com/users/TylerJewell","html_url":"https://github.com/TylerJewell","followers_url":"https://api.github.com/users/TylerJewell/followers","following_url":"https://api.github.com/users/TylerJewell/following{/other_user}","gists_url":"https://api.github.com/users/TylerJewell/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerJewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerJewell/subscriptions","organizations_url":"https://api.github.com/users/TylerJewell/orgs","repos_url":"https://api.github.com/users/TylerJewell/repos","events_url":"https://api.github.com/users/TylerJewell/events{/privacy}","received_events_url":"https://api.github.com/users/TylerJewell/received_events","type":"User","site_admin":false},"body":"DO NOT MERGE WITHOUT REVIEW\r\n\r\n### What does this PR do?\r\nAdds in additional content to the `codenvy.env` file that outlines clear instructions on our network protocol discovery and progression for various connections that must be established.  This copies the content that we have within the Che configuration. \r\n\r\nWe need this to be carefully reviewed as I am sure that some of the properties in this file are relevant to Che, but absolutely not relevant for Codenvy.  We need to make sure that the Codenvy version is accurate.  Once this is reviewed, I will open up a PR for codenvy documentation to make this clear as well.\r\n\r\nAlso adds in changes needed to adapt to https://github.com/eclipse/che/pull/4114, so that CODENVY_HOST provided on command line will override value in `codenvy.env`.\r\n\r\n#### Changelog\r\nAdd networking progression and configuration to `codenvy.env`\r\nCLI override for `CODENVY_HOST` variable.\r\n\r\n#### Release Notes\r\nN/A\r\n\r\n#### Docs PR\r\nTBD","created_at":"2017-02-11T16:29:40Z","updated_at":"2017-02-14T11:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14955cb112b572a28b05a2da57a6c589cb61d639","assignee":{"login":"TylerJewell","id":392458,"avatar_url":"https://avatars.githubusercontent.com/u/392458?v=3","gravatar_id":"","url":"https://api.github.com/users/TylerJewell","html_url":"https://github.com/TylerJewell","followers_url":"https://api.github.com/users/TylerJewell/followers","following_url":"https://api.github.com/users/TylerJewell/following{/other_user}","gists_url":"https://api.github.com/users/TylerJewell/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerJewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerJewell/subscriptions","organizations_url":"https://api.github.com/users/TylerJewell/orgs","repos_url":"https://api.github.com/users/TylerJewell/repos","events_url":"https://api.github.com/users/TylerJewell/events{/privacy}","received_events_url":"https://api.github.com/users/TylerJewell/received_events","type":"User","site_admin":false},"assignees":[{"login":"TylerJewell","id":392458,"avatar_url":"https://avatars.githubusercontent.com/u/392458?v=3","gravatar_id":"","url":"https://api.github.com/users/TylerJewell","html_url":"https://github.com/TylerJewell","followers_url":"https://api.github.com/users/TylerJewell/followers","following_url":"https://api.github.com/users/TylerJewell/following{/other_user}","gists_url":"https://api.github.com/users/TylerJewell/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerJewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerJewell/subscriptions","organizations_url":"https://api.github.com/users/TylerJewell/orgs","repos_url":"https://api.github.com/users/TylerJewell/repos","events_url":"https://api.github.com/users/TylerJewell/events{/privacy}","received_events_url":"https://api.github.com/users/TylerJewell/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codenvy/codenvy/pulls/1764/commits","review_comments_url":"https://api.github.com/repos/codenvy/codenvy/pulls/1764/comments","review_comment_url":"https://api.github.com/repos/codenvy/codenvy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codenvy/codenvy/issues/1764/comments","statuses_url":"https://api.github.com/repos/codenvy/codenvy/statuses/ffa6be2b09aab59c20b6c36b49e2402d1a1398c6","head":{"label":"codenvy:clean-networking","ref":"clean-networking","sha":"ffa6be2b09aab59c20b6c36b49e2402d1a1398c6","user":{"login":"codenvy","id":2736247,"avatar_url":"https://avatars.githubusercontent.com/u/2736247?v=3","gravatar_id":"","url":"https://api.github.com/users/codenvy","html_url":"https://github.com/codenvy","followers_url":"https://api.github.com/users/codenvy/followers","following_url":"https://api.github.com/users/codenvy/following{/other_user}","gists_url":"https://api.github.com/users/codenvy/gists{/gist_id}","starred_url":"https://api.github.com/users/codenvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenvy/subscriptions","organizations_url":"https://api.github.com/users/codenvy/orgs","repos_url":"https://api.github.com/users/codenvy/repos","events_url":"https://api.github.com/users/codenvy/events{/privacy}","received_events_url":"https://api.github.com/users/codenvy/received_events","type":"Organization","site_admin":false},"repo":{"id":54102761,"name":"codenvy","full_name":"codenvy/codenvy","owner":{"login":"codenvy","id":2736247,"avatar_url":"https://avatars.githubusercontent.com/u/2736247?v=3","gravatar_id":"","url":"https://api.github.com/users/codenvy","html_url":"https://github.com/codenvy","followers_url":"https://api.github.com/users/codenvy/followers","following_url":"https://api.github.com/users/codenvy/following{/other_user}","gists_url":"https://api.github.com/users/codenvy/gists{/gist_id}","starred_url":"https://api.github.com/users/codenvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenvy/subscriptions","organizations_url":"https://api.github.com/users/codenvy/orgs","repos_url":"https://api.github.com/users/codenvy/repos","events_url":"https://api.github.com/users/codenvy/events{/privacy}","received_events_url":"https://api.github.com/users/codenvy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codenvy/codenvy","description":"Codenvy","fork":false,"url":"https://api.github.com/repos/codenvy/codenvy","forks_url":"https://api.github.com/repos/codenvy/codenvy/forks","keys_url":"https://api.github.com/repos/codenvy/codenvy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codenvy/codenvy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codenvy/codenvy/teams","hooks_url":"https://api.github.com/repos/codenvy/codenvy/hooks","issue_events_url":"https://api.github.com/repos/codenvy/codenvy/issues/events{/number}","events_url":"https://api.github.com/repos/codenvy/codenvy/events","assignees_url":"https://api.github.com/repos/codenvy/codenvy/assignees{/user}","branches_url":"https://api.github.com/repos/codenvy/codenvy/branches{/branch}","tags_url":"https://api.github.com/repos/codenvy/codenvy/tags","blobs_url":"https://api.github.com/repos/codenvy/codenvy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codenvy/codenvy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codenvy/codenvy/git/refs{/sha}","trees_url":"https://api.github.com/repos/codenvy/codenvy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codenvy/codenvy/statuses/{sha}","languages_url":"https://api.github.com/repos/codenvy/codenvy/languages","stargazers_url":"https://api.github.com/repos/codenvy/codenvy/stargazers","contributors_url":"https://api.github.com/repos/codenvy/codenvy/contributors","subscribers_url":"https://api.github.com/repos/codenvy/codenvy/subscribers","subscription_url":"https://api.github.com/repos/codenvy/codenvy/subscription","commits_url":"https://api.github.com/repos/codenvy/codenvy/commits{/sha}","git_commits_url":"https://api.github.com/repos/codenvy/codenvy/git/commits{/sha}","comments_url":"https://api.github.com/repos/codenvy/codenvy/comments{/number}","issue_comment_url":"https://api.github.com/repos/codenvy/codenvy/issues/comments{/number}","contents_url":"https://api.github.com/repos/codenvy/codenvy/contents/{+path}","compare_url":"https://api.github.com/repos/codenvy/codenvy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codenvy/codenvy/merges","archive_url":"https://api.github.com/repos/codenvy/codenvy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codenvy/codenvy/downloads","issues_url":"https://api.github.com/repos/codenvy/codenvy/issues{/number}","pulls_url":"https://api.github.com/repos/codenvy/codenvy/pulls{/number}","milestones_url":"https://api.github.com/repos/codenvy/codenvy/milestones{/number}","notifications_url":"https://api.github.com/repos/codenvy/codenvy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codenvy/codenvy/labels{/name}","releases_url":"https://api.github.com/repos/codenvy/codenvy/releases{/id}","deployments_url":"https://api.github.com/repos/codenvy/codenvy/deployments","created_at":"2016-03-17T08:51:27Z","updated_at":"2017-02-10T09:17:52Z","pushed_at":"2017-02-14T10:46:17Z","git_url":"git://github.com/codenvy/codenvy.git","ssh_url":"git@github.com:codenvy/codenvy.git","clone_url":"https://github.com/codenvy/codenvy.git","svn_url":"https://github.com/codenvy/codenvy","homepage":null,"size":143709,"stargazers_count":57,"watchers_count":57,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":230,"forks":46,"open_issues":230,"watchers":57,"default_branch":"master"}},"base":{"label":"codenvy:master","ref":"master","sha":"9e2802561ed41ada1163ed14f552808fd81ce338","user":{"login":"codenvy","id":2736247,"avatar_url":"https://avatars.githubusercontent.com/u/2736247?v=3","gravatar_id":"","url":"https://api.github.com/users/codenvy","html_url":"https://github.com/codenvy","followers_url":"https://api.github.com/users/codenvy/followers","following_url":"https://api.github.com/users/codenvy/following{/other_user}","gists_url":"https://api.github.com/users/codenvy/gists{/gist_id}","starred_url":"https://api.github.com/users/codenvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenvy/subscriptions","organizations_url":"https://api.github.com/users/codenvy/orgs","repos_url":"https://api.github.com/users/codenvy/repos","events_url":"https://api.github.com/users/codenvy/events{/privacy}","received_events_url":"https://api.github.com/users/codenvy/received_events","type":"Organization","site_admin":false},"repo":{"id":54102761,"name":"codenvy","full_name":"codenvy/codenvy","owner":{"login":"codenvy","id":2736247,"avatar_url":"https://avatars.githubusercontent.com/u/2736247?v=3","gravatar_id":"","url":"https://api.github.com/users/codenvy","html_url":"https://github.com/codenvy","followers_url":"https://api.github.com/users/codenvy/followers","following_url":"https://api.github.com/users/codenvy/following{/other_user}","gists_url":"https://api.github.com/users/codenvy/gists{/gist_id}","starred_url":"https://api.github.com/users/codenvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenvy/subscriptions","organizations_url":"https://api.github.com/users/codenvy/orgs","repos_url":"https://api.github.com/users/codenvy/repos","events_url":"https://api.github.com/users/codenvy/events{/privacy}","received_events_url":"https://api.github.com/users/codenvy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codenvy/codenvy","description":"Codenvy","fork":false,"url":"https://api.github.com/repos/codenvy/codenvy","forks_url":"https://api.github.com/repos/codenvy/codenvy/forks","keys_url":"https://api.github.com/repos/codenvy/codenvy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codenvy/codenvy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codenvy/codenvy/teams","hooks_url":"https://api.github.com/repos/codenvy/codenvy/hooks","issue_events_url":"https://api.github.com/repos/codenvy/codenvy/issues/events{/number}","events_url":"https://api.github.com/repos/codenvy/codenvy/events","assignees_url":"https://api.github.com/repos/codenvy/codenvy/assignees{/user}","branches_url":"https://api.github.com/repos/codenvy/codenvy/branches{/branch}","tags_url":"https://api.github.com/repos/codenvy/codenvy/tags","blobs_url":"https://api.github.com/repos/codenvy/codenvy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codenvy/codenvy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codenvy/codenvy/git/refs{/sha}","trees_url":"https://api.github.com/repos/codenvy/codenvy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codenvy/codenvy/statuses/{sha}","languages_url":"https://api.github.com/repos/codenvy/codenvy/languages","stargazers_url":"https://api.github.com/repos/codenvy/codenvy/stargazers","contributors_url":"https://api.github.com/repos/codenvy/codenvy/contributors","subscribers_url":"https://api.github.com/repos/codenvy/codenvy/subscribers","subscription_url":"https://api.github.com/repos/codenvy/codenvy/subscription","commits_url":"https://api.github.com/repos/codenvy/codenvy/commits{/sha}","git_commits_url":"https://api.github.com/repos/codenvy/codenvy/git/commits{/sha}","comments_url":"https://api.github.com/repos/codenvy/codenvy/comments{/number}","issue_comment_url":"https://api.github.com/repos/codenvy/codenvy/issues/comments{/number}","contents_url":"https://api.github.com/repos/codenvy/codenvy/contents/{+path}","compare_url":"https://api.github.com/repos/codenvy/codenvy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codenvy/codenvy/merges","archive_url":"https://api.github.com/repos/codenvy/codenvy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codenvy/codenvy/downloads","issues_url":"https://api.github.com/repos/codenvy/codenvy/issues{/number}","pulls_url":"https://api.github.com/repos/codenvy/codenvy/pulls{/number}","milestones_url":"https://api.github.com/repos/codenvy/codenvy/milestones{/number}","notifications_url":"https://api.github.com/repos/codenvy/codenvy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codenvy/codenvy/labels{/name}","releases_url":"https://api.github.com/repos/codenvy/codenvy/releases{/id}","deployments_url":"https://api.github.com/repos/codenvy/codenvy/deployments","created_at":"2016-03-17T08:51:27Z","updated_at":"2017-02-10T09:17:52Z","pushed_at":"2017-02-14T10:46:17Z","git_url":"git://github.com/codenvy/codenvy.git","ssh_url":"git@github.com:codenvy/codenvy.git","clone_url":"https://github.com/codenvy/codenvy.git","svn_url":"https://github.com/codenvy/codenvy","homepage":null,"size":143709,"stargazers_count":57,"watchers_count":57,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":230,"forks":46,"open_issues":230,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codenvy/codenvy/pulls/1764"},"html":{"href":"https://github.com/codenvy/codenvy/pull/1764"},"issue":{"href":"https://api.github.com/repos/codenvy/codenvy/issues/1764"},"comments":{"href":"https://api.github.com/repos/codenvy/codenvy/issues/1764/comments"},"review_comments":{"href":"https://api.github.com/repos/codenvy/codenvy/pulls/1764/comments"},"review_comment":{"href":"https://api.github.com/repos/codenvy/codenvy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codenvy/codenvy/pulls/1764/commits"},"statuses":{"href":"https://api.github.com/repos/codenvy/codenvy/statuses/ffa6be2b09aab59c20b6c36b49e2402d1a1398c6"}}}}
{"actor":{"display_login":"TylerJewell"}}