{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/15365","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/15365/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/15365/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/15365/events","html_url":"https://github.com/nodejs/node/pull/15365","id":257054671,"number":15365,"title":"BREAKING: deprecate loading files with unknown or missing extensions","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"labels":[{"id":155435814,"url":"https://api.github.com/repos/nodejs/node/labels/module","name":"module","color":"fbca04","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false},{"id":678967907,"url":"https://api.github.com/repos/nodejs/node/labels/tsc-review","name":"tsc-review","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":42,"created_at":"2017-09-12T14:02:40Z","updated_at":"2017-09-13T15:17:14Z","closed_at":"2017-09-13T15:17:14Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/15365","html_url":"https://github.com/nodejs/node/pull/15365","diff_url":"https://github.com/nodejs/node/pull/15365.diff","patch_url":"https://github.com/nodejs/node/pull/15365.patch"},"body":"This prevents treating files as CJS when they are not specified as\r\n.js explicitly. Package managers create links without the extension\r\nalready so the use of \"bin\" still works. Also, node continues to do\r\npath searching and can find a .js file with the same location via\r\ncommand line.\r\n\r\nThis fixes some problems with ESM loading from CLI arguments since we cannot reliably know if a file is supposed to be loaded via CJS normally. This will also be desired once loader hooks come around so that they can capture all modules loaded via CLI arguments.\r\n\r\nRight now we have a [very simplistic check](https://github.com/nodejs/node/blob/6ccb9fe8097b4199e0bb56e06ff567bd3fa73ca5/lib/module.js#L436) for if a main entry point should be loaded as ESM. However, this still has collisions and doesn't have a path forward for loader hooks wishing to change how main entry points/preloading via `--require` works.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\nmodule"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/329201210","html_url":"https://github.com/nodejs/node/pull/15365#issuecomment-329201210","issue_url":"https://api.github.com/repos/nodejs/node/issues/15365","id":329201210,"user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"created_at":"2017-09-13T15:17:14Z","updated_at":"2017-09-13T15:17:14Z","author_association":"CONTRIBUTOR","body":"I think we have significant objections, I'll close for now but may re-open as number of evaluation modes increases over time."}}
{"actor":{"display_login":"bmeck"}}