{"action":"created","comment":{"url":"https://api.github.com/repos/openresty/openresty/pulls/comments/111693869","pull_request_review_id":32953098,"id":111693869,"diff_hunk":"@@ -0,0 +1,232 @@\n+diff --git a/src/core/nginx.c b/src/core/nginx.c\n+index 60f8fe7..b15f84c 100644\n+--- a/src/core/nginx.c\n++++ b/src/core/nginx.c\n+@@ -53,6 +53,13 @@ static ngx_command_t  ngx_core_commands[] = {\n+       offsetof(ngx_core_conf_t, master),\n+       NULL },\n+ \n++    { ngx_string(\"privilege_process\"),","path":"patches/nginx-1.11.2-privilege_process.patch","position":9,"original_position":9,"commit_id":"c5800e98c1844f9cf67a80deb01a1b5e331f9507","original_commit_id":"c5800e98c1844f9cf67a80deb01a1b5e331f9507","user":{"login":"agentzh","id":56241,"avatar_url":"https://avatars2.githubusercontent.com/u/56241?v=3","gravatar_id":"","url":"https://api.github.com/users/agentzh","html_url":"https://github.com/agentzh","followers_url":"https://api.github.com/users/agentzh/followers","following_url":"https://api.github.com/users/agentzh/following{/other_user}","gists_url":"https://api.github.com/users/agentzh/gists{/gist_id}","starred_url":"https://api.github.com/users/agentzh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agentzh/subscriptions","organizations_url":"https://api.github.com/users/agentzh/orgs","repos_url":"https://api.github.com/users/agentzh/repos","events_url":"https://api.github.com/users/agentzh/events{/privacy}","received_events_url":"https://api.github.com/users/agentzh/received_events","type":"User","site_admin":false},"body":"We don't need an explicit config directive to enable this. We only need a C API for 3rd-party module to request at run time. Just like the existing cache manager and cache loader processes have no explicit config directives, but are triggered automatically by the presence of any http cache directives like `proxy_cache`.","created_at":"2017-04-16T23:05:56Z","updated_at":"2017-04-16T23:18:40Z","html_url":"https://github.com/openresty/openresty/pull/250#discussion_r111693869","pull_request_url":"https://api.github.com/repos/openresty/openresty/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/openresty/openresty/pulls/comments/111693869"},"html":{"href":"https://github.com/openresty/openresty/pull/250#discussion_r111693869"},"pull_request":{"href":"https://api.github.com/repos/openresty/openresty/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/openresty/openresty/pulls/250","id":116030495,"html_url":"https://github.com/openresty/openresty/pull/250","diff_url":"https://github.com/openresty/openresty/pull/250.diff","patch_url":"https://github.com/openresty/openresty/pull/250.patch","issue_url":"https://api.github.com/repos/openresty/openresty/issues/250","number":250,"state":"open","locked":false,"title":"feature: supported privilege process.","user":{"login":"membphis","id":6814606,"avatar_url":"https://avatars0.githubusercontent.com/u/6814606?v=3","gravatar_id":"","url":"https://api.github.com/users/membphis","html_url":"https://github.com/membphis","followers_url":"https://api.github.com/users/membphis/followers","following_url":"https://api.github.com/users/membphis/following{/other_user}","gists_url":"https://api.github.com/users/membphis/gists{/gist_id}","starred_url":"https://api.github.com/users/membphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/membphis/subscriptions","organizations_url":"https://api.github.com/users/membphis/orgs","repos_url":"https://api.github.com/users/membphis/repos","events_url":"https://api.github.com/users/membphis/events{/privacy}","received_events_url":"https://api.github.com/users/membphis/received_events","type":"User","site_admin":false},"body":"The privilege process has the same permission as Nginx `master` process, and it closed the listening socket for safety.\r\n\r\nWe can do something special in this privilege process. ","created_at":"2017-04-15T16:25:11Z","updated_at":"2017-04-16T23:18:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"528a94b054fd34fdb74bafa93c3b8e624b15e1c9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openresty/openresty/pulls/250/commits","review_comments_url":"https://api.github.com/repos/openresty/openresty/pulls/250/comments","review_comment_url":"https://api.github.com/repos/openresty/openresty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openresty/openresty/issues/250/comments","statuses_url":"https://api.github.com/repos/openresty/openresty/statuses/c5800e98c1844f9cf67a80deb01a1b5e331f9507","head":{"label":"membphis:privilege_process","ref":"privilege_process","sha":"c5800e98c1844f9cf67a80deb01a1b5e331f9507","user":{"login":"membphis","id":6814606,"avatar_url":"https://avatars0.githubusercontent.com/u/6814606?v=3","gravatar_id":"","url":"https://api.github.com/users/membphis","html_url":"https://github.com/membphis","followers_url":"https://api.github.com/users/membphis/followers","following_url":"https://api.github.com/users/membphis/following{/other_user}","gists_url":"https://api.github.com/users/membphis/gists{/gist_id}","starred_url":"https://api.github.com/users/membphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/membphis/subscriptions","organizations_url":"https://api.github.com/users/membphis/orgs","repos_url":"https://api.github.com/users/membphis/repos","events_url":"https://api.github.com/users/membphis/events{/privacy}","received_events_url":"https://api.github.com/users/membphis/received_events","type":"User","site_admin":false},"repo":{"id":87437002,"name":"openresty","full_name":"membphis/openresty","owner":{"login":"membphis","id":6814606,"avatar_url":"https://avatars0.githubusercontent.com/u/6814606?v=3","gravatar_id":"","url":"https://api.github.com/users/membphis","html_url":"https://github.com/membphis","followers_url":"https://api.github.com/users/membphis/followers","following_url":"https://api.github.com/users/membphis/following{/other_user}","gists_url":"https://api.github.com/users/membphis/gists{/gist_id}","starred_url":"https://api.github.com/users/membphis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/membphis/subscriptions","organizations_url":"https://api.github.com/users/membphis/orgs","repos_url":"https://api.github.com/users/membphis/repos","events_url":"https://api.github.com/users/membphis/events{/privacy}","received_events_url":"https://api.github.com/users/membphis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/membphis/openresty","description":"Turning Nginx into a Full-Fledged Scriptable Web Platform","fork":true,"url":"https://api.github.com/repos/membphis/openresty","forks_url":"https://api.github.com/repos/membphis/openresty/forks","keys_url":"https://api.github.com/repos/membphis/openresty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/membphis/openresty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/membphis/openresty/teams","hooks_url":"https://api.github.com/repos/membphis/openresty/hooks","issue_events_url":"https://api.github.com/repos/membphis/openresty/issues/events{/number}","events_url":"https://api.github.com/repos/membphis/openresty/events","assignees_url":"https://api.github.com/repos/membphis/openresty/assignees{/user}","branches_url":"https://api.github.com/repos/membphis/openresty/branches{/branch}","tags_url":"https://api.github.com/repos/membphis/openresty/tags","blobs_url":"https://api.github.com/repos/membphis/openresty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/membphis/openresty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/membphis/openresty/git/refs{/sha}","trees_url":"https://api.github.com/repos/membphis/openresty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/membphis/openresty/statuses/{sha}","languages_url":"https://api.github.com/repos/membphis/openresty/languages","stargazers_url":"https://api.github.com/repos/membphis/openresty/stargazers","contributors_url":"https://api.github.com/repos/membphis/openresty/contributors","subscribers_url":"https://api.github.com/repos/membphis/openresty/subscribers","subscription_url":"https://api.github.com/repos/membphis/openresty/subscription","commits_url":"https://api.github.com/repos/membphis/openresty/commits{/sha}","git_commits_url":"https://api.github.com/repos/membphis/openresty/git/commits{/sha}","comments_url":"https://api.github.com/repos/membphis/openresty/comments{/number}","issue_comment_url":"https://api.github.com/repos/membphis/openresty/issues/comments{/number}","contents_url":"https://api.github.com/repos/membphis/openresty/contents/{+path}","compare_url":"https://api.github.com/repos/membphis/openresty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/membphis/openresty/merges","archive_url":"https://api.github.com/repos/membphis/openresty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/membphis/openresty/downloads","issues_url":"https://api.github.com/repos/membphis/openresty/issues{/number}","pulls_url":"https://api.github.com/repos/membphis/openresty/pulls{/number}","milestones_url":"https://api.github.com/repos/membphis/openresty/milestones{/number}","notifications_url":"https://api.github.com/repos/membphis/openresty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/membphis/openresty/labels{/name}","releases_url":"https://api.github.com/repos/membphis/openresty/releases{/id}","deployments_url":"https://api.github.com/repos/membphis/openresty/deployments","created_at":"2017-04-06T14:12:37Z","updated_at":"2017-04-06T14:12:39Z","pushed_at":"2017-04-16T01:52:01Z","git_url":"git://github.com/membphis/openresty.git","ssh_url":"git@github.com:membphis/openresty.git","clone_url":"https://github.com/membphis/openresty.git","svn_url":"https://github.com/membphis/openresty","homepage":"https://openresty.org","size":1531,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openresty:master","ref":"master","sha":"78af48d106118e6198036c8be785fc9ef394737a","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars2.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":480080,"name":"openresty","full_name":"openresty/openresty","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars2.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/openresty","description":"Turning Nginx into a Full-Fledged Scriptable Web Platform","fork":false,"url":"https://api.github.com/repos/openresty/openresty","forks_url":"https://api.github.com/repos/openresty/openresty/forks","keys_url":"https://api.github.com/repos/openresty/openresty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/openresty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/openresty/teams","hooks_url":"https://api.github.com/repos/openresty/openresty/hooks","issue_events_url":"https://api.github.com/repos/openresty/openresty/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/openresty/events","assignees_url":"https://api.github.com/repos/openresty/openresty/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/openresty/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/openresty/tags","blobs_url":"https://api.github.com/repos/openresty/openresty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/openresty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/openresty/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/openresty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/openresty/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/openresty/languages","stargazers_url":"https://api.github.com/repos/openresty/openresty/stargazers","contributors_url":"https://api.github.com/repos/openresty/openresty/contributors","subscribers_url":"https://api.github.com/repos/openresty/openresty/subscribers","subscription_url":"https://api.github.com/repos/openresty/openresty/subscription","commits_url":"https://api.github.com/repos/openresty/openresty/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/openresty/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/openresty/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/openresty/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/openresty/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/openresty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/openresty/merges","archive_url":"https://api.github.com/repos/openresty/openresty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/openresty/downloads","issues_url":"https://api.github.com/repos/openresty/openresty/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/openresty/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/openresty/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/openresty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/openresty/labels{/name}","releases_url":"https://api.github.com/repos/openresty/openresty/releases{/id}","deployments_url":"https://api.github.com/repos/openresty/openresty/deployments","created_at":"2010-01-20T03:57:59Z","updated_at":"2017-04-16T14:28:05Z","pushed_at":"2017-04-16T01:52:02Z","git_url":"git://github.com/openresty/openresty.git","ssh_url":"git@github.com:openresty/openresty.git","clone_url":"https://github.com/openresty/openresty.git","svn_url":"https://github.com/openresty/openresty","homepage":"https://openresty.org","size":1551,"stargazers_count":3289,"watchers_count":3289,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":538,"mirror_url":null,"open_issues_count":70,"forks":538,"open_issues":70,"watchers":3289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openresty/openresty/pulls/250"},"html":{"href":"https://github.com/openresty/openresty/pull/250"},"issue":{"href":"https://api.github.com/repos/openresty/openresty/issues/250"},"comments":{"href":"https://api.github.com/repos/openresty/openresty/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/openresty/openresty/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/openresty/openresty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openresty/openresty/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/openresty/openresty/statuses/c5800e98c1844f9cf67a80deb01a1b5e331f9507"}}}}
{"actor":{"display_login":"agentzh"}}