{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/158978498","pull_request_review_id":85860065,"id":158978498,"diff_hunk":"@@ -52,7 +52,55 @@ impl<'cx, 'gcx, 'tcx> MirBorrowckCtxt<'cx, 'gcx, 'tcx> {\n                 .span_label(span, format!(\"use of possibly uninitialized {}\", item_msg))\n                 .emit();\n         } else {\n-            let msg = \"\"; //FIXME: add \"partially \" or \"collaterally \"\n+            // FIXME Should these be moved to impl Place?","path":"src/librustc_mir/borrow_check/error_reporting.rs","position":5,"original_position":5,"commit_id":"cf069df53bab63a3d81647ab1c1b78649442d2e8","original_commit_id":"9e6ba271c73cbef7f5cf9b21c31edf9e7506934c","user":{"login":"estebank","id":1606434,"avatar_url":"https://avatars2.githubusercontent.com/u/1606434?v=4","gravatar_id":"","url":"https://api.github.com/users/estebank","html_url":"https://github.com/estebank","followers_url":"https://api.github.com/users/estebank/followers","following_url":"https://api.github.com/users/estebank/following{/other_user}","gists_url":"https://api.github.com/users/estebank/gists{/gist_id}","starred_url":"https://api.github.com/users/estebank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estebank/subscriptions","organizations_url":"https://api.github.com/users/estebank/orgs","repos_url":"https://api.github.com/users/estebank/repos","events_url":"https://api.github.com/users/estebank/events{/privacy}","received_events_url":"https://api.github.com/users/estebank/received_events","type":"User","site_admin":false},"body":"Yes, you can move both this functions to be methods of [`Place`](https://github.com/rust-lang/rust/tree/master/src/librustc/mir/mod.rs).","created_at":"2017-12-28T18:00:18Z","updated_at":"2017-12-28T18:01:41Z","html_url":"https://github.com/rust-lang/rust/pull/47020#discussion_r158978498","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/47020","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/158978498"},"html":{"href":"https://github.com/rust-lang/rust/pull/47020#discussion_r158978498"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/47020"}},"in_reply_to_id":158740734},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/47020","id":160158933,"html_url":"https://github.com/rust-lang/rust/pull/47020","diff_url":"https://github.com/rust-lang/rust/pull/47020.diff","patch_url":"https://github.com/rust-lang/rust/pull/47020.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/47020","number":47020,"state":"open","locked":false,"title":"nll: Improved error messages in the case of partial and collateral moves","user":{"login":"vramana","id":3112509,"avatar_url":"https://avatars0.githubusercontent.com/u/3112509?v=4","gravatar_id":"","url":"https://api.github.com/users/vramana","html_url":"https://github.com/vramana","followers_url":"https://api.github.com/users/vramana/followers","following_url":"https://api.github.com/users/vramana/following{/other_user}","gists_url":"https://api.github.com/users/vramana/gists{/gist_id}","starred_url":"https://api.github.com/users/vramana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramana/subscriptions","organizations_url":"https://api.github.com/users/vramana/orgs","repos_url":"https://api.github.com/users/vramana/repos","events_url":"https://api.github.com/users/vramana/events{/privacy}","received_events_url":"https://api.github.com/users/vramana/received_events","type":"User","site_admin":false},"body":"Fixes #45700","created_at":"2017-12-26T19:10:25Z","updated_at":"2017-12-28T18:01:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8bd645bda2adf0be891743ab77311d0dac197ac","assignee":{"login":"arielb1","id":1830974,"avatar_url":"https://avatars1.githubusercontent.com/u/1830974?v=4","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false},"assignees":[{"login":"arielb1","id":1830974,"avatar_url":"https://avatars1.githubusercontent.com/u/1830974?v=4","gravatar_id":"","url":"https://api.github.com/users/arielb1","html_url":"https://github.com/arielb1","followers_url":"https://api.github.com/users/arielb1/followers","following_url":"https://api.github.com/users/arielb1/following{/other_user}","gists_url":"https://api.github.com/users/arielb1/gists{/gist_id}","starred_url":"https://api.github.com/users/arielb1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arielb1/subscriptions","organizations_url":"https://api.github.com/users/arielb1/orgs","repos_url":"https://api.github.com/users/arielb1/repos","events_url":"https://api.github.com/users/arielb1/events{/privacy}","received_events_url":"https://api.github.com/users/arielb1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/47020/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/47020/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/47020/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/cf069df53bab63a3d81647ab1c1b78649442d2e8","head":{"label":"vramana:fix-45700","ref":"fix-45700","sha":"cf069df53bab63a3d81647ab1c1b78649442d2e8","user":{"login":"vramana","id":3112509,"avatar_url":"https://avatars0.githubusercontent.com/u/3112509?v=4","gravatar_id":"","url":"https://api.github.com/users/vramana","html_url":"https://github.com/vramana","followers_url":"https://api.github.com/users/vramana/followers","following_url":"https://api.github.com/users/vramana/following{/other_user}","gists_url":"https://api.github.com/users/vramana/gists{/gist_id}","starred_url":"https://api.github.com/users/vramana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramana/subscriptions","organizations_url":"https://api.github.com/users/vramana/orgs","repos_url":"https://api.github.com/users/vramana/repos","events_url":"https://api.github.com/users/vramana/events{/privacy}","received_events_url":"https://api.github.com/users/vramana/received_events","type":"User","site_admin":false},"repo":{"id":110289110,"name":"rust","full_name":"vramana/rust","owner":{"login":"vramana","id":3112509,"avatar_url":"https://avatars0.githubusercontent.com/u/3112509?v=4","gravatar_id":"","url":"https://api.github.com/users/vramana","html_url":"https://github.com/vramana","followers_url":"https://api.github.com/users/vramana/followers","following_url":"https://api.github.com/users/vramana/following{/other_user}","gists_url":"https://api.github.com/users/vramana/gists{/gist_id}","starred_url":"https://api.github.com/users/vramana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vramana/subscriptions","organizations_url":"https://api.github.com/users/vramana/orgs","repos_url":"https://api.github.com/users/vramana/repos","events_url":"https://api.github.com/users/vramana/events{/privacy}","received_events_url":"https://api.github.com/users/vramana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vramana/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/vramana/rust","forks_url":"https://api.github.com/repos/vramana/rust/forks","keys_url":"https://api.github.com/repos/vramana/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vramana/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vramana/rust/teams","hooks_url":"https://api.github.com/repos/vramana/rust/hooks","issue_events_url":"https://api.github.com/repos/vramana/rust/issues/events{/number}","events_url":"https://api.github.com/repos/vramana/rust/events","assignees_url":"https://api.github.com/repos/vramana/rust/assignees{/user}","branches_url":"https://api.github.com/repos/vramana/rust/branches{/branch}","tags_url":"https://api.github.com/repos/vramana/rust/tags","blobs_url":"https://api.github.com/repos/vramana/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vramana/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vramana/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/vramana/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vramana/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/vramana/rust/languages","stargazers_url":"https://api.github.com/repos/vramana/rust/stargazers","contributors_url":"https://api.github.com/repos/vramana/rust/contributors","subscribers_url":"https://api.github.com/repos/vramana/rust/subscribers","subscription_url":"https://api.github.com/repos/vramana/rust/subscription","commits_url":"https://api.github.com/repos/vramana/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/vramana/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/vramana/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/vramana/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/vramana/rust/contents/{+path}","compare_url":"https://api.github.com/repos/vramana/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vramana/rust/merges","archive_url":"https://api.github.com/repos/vramana/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vramana/rust/downloads","issues_url":"https://api.github.com/repos/vramana/rust/issues{/number}","pulls_url":"https://api.github.com/repos/vramana/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/vramana/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/vramana/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vramana/rust/labels{/name}","releases_url":"https://api.github.com/repos/vramana/rust/releases{/id}","deployments_url":"https://api.github.com/repos/vramana/rust/deployments","created_at":"2017-11-10T20:21:57Z","updated_at":"2017-11-10T20:22:21Z","pushed_at":"2017-12-26T23:45:11Z","git_url":"git://github.com/vramana/rust.git","ssh_url":"git@github.com:vramana/rust.git","clone_url":"https://github.com/vramana/rust.git","svn_url":"https://github.com/vramana/rust","homepage":"https://www.rust-lang.org","size":341273,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"cddc4a62d8e72c2bd303994752a7f8545ffb9c79","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-12-28T17:15:36Z","pushed_at":"2017-12-28T17:41:30Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":341730,"stargazers_count":25511,"watchers_count":25511,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4612,"mirror_url":null,"archived":false,"open_issues_count":3186,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4612,"open_issues":3186,"watchers":25511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/47020"},"html":{"href":"https://github.com/rust-lang/rust/pull/47020"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/47020"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/47020/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/47020/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/47020/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/cf069df53bab63a3d81647ab1c1b78649442d2e8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"estebank"}}