{"action":"created","comment":{"url":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/comments/125023027","pull_request_review_id":47372394,"id":125023027,"diff_hunk":"@@ -1,3 +1,219 @@\n package etcd\n \n //go:generate mockery -dir $GOPATH/src/github.com/UKHomeOffice/keto-k8/pkg/etcd -name=Clienter\n+\n+import (\n+\t\"fmt\"\n+\t\"log\"\n+\t\"path\"\n+\t\"os\"\n+\t\"os/exec\"\n+\t\"testing\"\n+\n+\t\"github.com/UKHomeOffice/keto-k8/pkg/fileutil\"\n+\t\"time\"\n+)\n+\n+const containerName string = \"ectd_int_test\"\n+\n+var etcdStarted = false","path":"pkg/etcd/etcd_test.go","position":19,"original_position":19,"commit_id":"a66a5f34f2896199ebb850ca480d6bc361514f23","original_commit_id":"f76ee4f27151bb70b844a7ad2031ee1d14ec7d33","user":{"login":"lewismarshall","id":2500933,"avatar_url":"https://avatars0.githubusercontent.com/u/2500933?v=3","gravatar_id":"","url":"https://api.github.com/users/lewismarshall","html_url":"https://github.com/lewismarshall","followers_url":"https://api.github.com/users/lewismarshall/followers","following_url":"https://api.github.com/users/lewismarshall/following{/other_user}","gists_url":"https://api.github.com/users/lewismarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/lewismarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewismarshall/subscriptions","organizations_url":"https://api.github.com/users/lewismarshall/orgs","repos_url":"https://api.github.com/users/lewismarshall/repos","events_url":"https://api.github.com/users/lewismarshall/events{/privacy}","received_events_url":"https://api.github.com/users/lewismarshall/received_events","type":"User","site_admin":false},"body":"I do agree in principle but it's a trade-off I guess but for now speed over safeguarding future poor tests.","created_at":"2017-06-30T12:00:45Z","updated_at":"2017-06-30T12:00:45Z","html_url":"https://github.com/UKHomeOffice/keto-k8/pull/42#discussion_r125023027","pull_request_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/42","_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/comments/125023027"},"html":{"href":"https://github.com/UKHomeOffice/keto-k8/pull/42#discussion_r125023027"},"pull_request":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/42","id":128103116,"html_url":"https://github.com/UKHomeOffice/keto-k8/pull/42","diff_url":"https://github.com/UKHomeOffice/keto-k8/pull/42.diff","patch_url":"https://github.com/UKHomeOffice/keto-k8/pull/42.patch","issue_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues/42","number":42,"state":"open","locked":false,"title":"Integration tests","user":{"login":"lewismarshall","id":2500933,"avatar_url":"https://avatars0.githubusercontent.com/u/2500933?v=3","gravatar_id":"","url":"https://api.github.com/users/lewismarshall","html_url":"https://github.com/lewismarshall","followers_url":"https://api.github.com/users/lewismarshall/followers","following_url":"https://api.github.com/users/lewismarshall/following{/other_user}","gists_url":"https://api.github.com/users/lewismarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/lewismarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lewismarshall/subscriptions","organizations_url":"https://api.github.com/users/lewismarshall/orgs","repos_url":"https://api.github.com/users/lewismarshall/repos","events_url":"https://api.github.com/users/lewismarshall/events{/privacy}","received_events_url":"https://api.github.com/users/lewismarshall/received_events","type":"User","site_admin":false},"body":"So far added etcd.\r\n\r\nWill Fix #40 \r\nAlso Fixes #9 ","created_at":"2017-06-29T09:12:33Z","updated_at":"2017-06-30T12:00:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de7dae7a07ebc3f48b511706b06c60b026472d38","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gambol99","id":4280679,"avatar_url":"https://avatars0.githubusercontent.com/u/4280679?v=3","gravatar_id":"","url":"https://api.github.com/users/gambol99","html_url":"https://github.com/gambol99","followers_url":"https://api.github.com/users/gambol99/followers","following_url":"https://api.github.com/users/gambol99/following{/other_user}","gists_url":"https://api.github.com/users/gambol99/gists{/gist_id}","starred_url":"https://api.github.com/users/gambol99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gambol99/subscriptions","organizations_url":"https://api.github.com/users/gambol99/orgs","repos_url":"https://api.github.com/users/gambol99/repos","events_url":"https://api.github.com/users/gambol99/events{/privacy}","received_events_url":"https://api.github.com/users/gambol99/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/42/commits","review_comments_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/42/comments","review_comment_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues/42/comments","statuses_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/statuses/a66a5f34f2896199ebb850ca480d6bc361514f23","head":{"label":"UKHomeOffice:integration_tests","ref":"integration_tests","sha":"a66a5f34f2896199ebb850ca480d6bc361514f23","user":{"login":"UKHomeOffice","id":3778081,"avatar_url":"https://avatars1.githubusercontent.com/u/3778081?v=3","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":84952744,"name":"keto-k8","full_name":"UKHomeOffice/keto-k8","owner":{"login":"UKHomeOffice","id":3778081,"avatar_url":"https://avatars1.githubusercontent.com/u/3778081?v=3","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UKHomeOffice/keto-k8","description":"Provides syncing of kubeadm resources between multiple masters","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/keto-k8","forks_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/deployments","created_at":"2017-03-14T13:33:40Z","updated_at":"2017-06-13T12:44:30Z","pushed_at":"2017-06-30T10:32:53Z","git_url":"git://github.com/UKHomeOffice/keto-k8.git","ssh_url":"git@github.com:UKHomeOffice/keto-k8.git","clone_url":"https://github.com/UKHomeOffice/keto-k8.git","svn_url":"https://github.com/UKHomeOffice/keto-k8","homepage":null,"size":144,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":3,"default_branch":"master"}},"base":{"label":"UKHomeOffice:master","ref":"master","sha":"50cf325e8e395a6c02287c92c0198c0563a09a6c","user":{"login":"UKHomeOffice","id":3778081,"avatar_url":"https://avatars1.githubusercontent.com/u/3778081?v=3","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":84952744,"name":"keto-k8","full_name":"UKHomeOffice/keto-k8","owner":{"login":"UKHomeOffice","id":3778081,"avatar_url":"https://avatars1.githubusercontent.com/u/3778081?v=3","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UKHomeOffice/keto-k8","description":"Provides syncing of kubeadm resources between multiple masters","fork":false,"url":"https://api.github.com/repos/UKHomeOffice/keto-k8","forks_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/keto-k8/deployments","created_at":"2017-03-14T13:33:40Z","updated_at":"2017-06-13T12:44:30Z","pushed_at":"2017-06-30T10:32:53Z","git_url":"git://github.com/UKHomeOffice/keto-k8.git","ssh_url":"git@github.com:UKHomeOffice/keto-k8.git","clone_url":"https://github.com/UKHomeOffice/keto-k8.git","svn_url":"https://github.com/UKHomeOffice/keto-k8","homepage":null,"size":144,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":14,"forks":0,"open_issues":14,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/42"},"html":{"href":"https://github.com/UKHomeOffice/keto-k8/pull/42"},"issue":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues/42"},"comments":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/UKHomeOffice/keto-k8/statuses/a66a5f34f2896199ebb850ca480d6bc361514f23"}}}}
{"actor":{"display_login":"lewismarshall"}}