{"action":"created","comment":{"url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/comments/118733703","pull_request_review_id":40557005,"id":118733703,"diff_hunk":"@@ -47,6 +47,7 @@ private static void DestroyChildren(Page page)\n         {\n             if (page is MasterDetailPage)\n             {\n+                DestroyPage(((MasterDetailPage)page).Master);","path":"Source/Xamarin/Prism.Forms/Common/PageUtilities.cs","position":4,"original_position":4,"commit_id":"c1f74d5bcdc888e7d809e33c8da3023da8c313da","original_commit_id":"c1f74d5bcdc888e7d809e33c8da3023da8c313da","user":{"login":"dansiegel","id":3860573,"avatar_url":"https://avatars0.githubusercontent.com/u/3860573?v=3","gravatar_id":"","url":"https://api.github.com/users/dansiegel","html_url":"https://github.com/dansiegel","followers_url":"https://api.github.com/users/dansiegel/followers","following_url":"https://api.github.com/users/dansiegel/following{/other_user}","gists_url":"https://api.github.com/users/dansiegel/gists{/gist_id}","starred_url":"https://api.github.com/users/dansiegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dansiegel/subscriptions","organizations_url":"https://api.github.com/users/dansiegel/orgs","repos_url":"https://api.github.com/users/dansiegel/repos","events_url":"https://api.github.com/users/dansiegel/events{/privacy}","received_events_url":"https://api.github.com/users/dansiegel/received_events","type":"User","site_admin":false},"body":"I'm a fan of this being inside of `DestroyChildren`. The parent should be Destroyed by `InvokeViewAndViewModelAction<IDestructible>(page, v => v.Destroy());` on line 35. If that's not occurring I would like to know why and address that issue instead.","created_at":"2017-05-26T15:55:20Z","updated_at":"2017-05-26T15:55:28Z","html_url":"https://github.com/PrismLibrary/Prism/pull/1064#discussion_r118733703","pull_request_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1064","_links":{"self":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/comments/118733703"},"html":{"href":"https://github.com/PrismLibrary/Prism/pull/1064#discussion_r118733703"},"pull_request":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1064"}}},"pull_request":{"url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1064","id":122579073,"html_url":"https://github.com/PrismLibrary/Prism/pull/1064","diff_url":"https://github.com/PrismLibrary/Prism/pull/1064.diff","patch_url":"https://github.com/PrismLibrary/Prism/pull/1064.patch","issue_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/1064","number":1064,"state":"open","locked":false,"title":"Fix Destroy for MasterDetailPage.","user":{"login":"nuitsjp","id":16175660,"avatar_url":"https://avatars3.githubusercontent.com/u/16175660?v=3","gravatar_id":"","url":"https://api.github.com/users/nuitsjp","html_url":"https://github.com/nuitsjp","followers_url":"https://api.github.com/users/nuitsjp/followers","following_url":"https://api.github.com/users/nuitsjp/following{/other_user}","gists_url":"https://api.github.com/users/nuitsjp/gists{/gist_id}","starred_url":"https://api.github.com/users/nuitsjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuitsjp/subscriptions","organizations_url":"https://api.github.com/users/nuitsjp/orgs","repos_url":"https://api.github.com/users/nuitsjp/repos","events_url":"https://api.github.com/users/nuitsjp/events{/privacy}","received_events_url":"https://api.github.com/users/nuitsjp/received_events","type":"User","site_admin":false},"body":"Please take a moment to fill out the following:\r\n\r\nFixes issue #1063 .\r\n\r\nChanges proposed in this pull request:\r\n- Fixed to call Destroy of MasterPage","created_at":"2017-05-26T06:18:21Z","updated_at":"2017-05-26T15:55:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97b4c7cfae321b02d84d60b90d477b4b8989aaca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brianlagunas","id":835562,"avatar_url":"https://avatars3.githubusercontent.com/u/835562?v=3","gravatar_id":"","url":"https://api.github.com/users/brianlagunas","html_url":"https://github.com/brianlagunas","followers_url":"https://api.github.com/users/brianlagunas/followers","following_url":"https://api.github.com/users/brianlagunas/following{/other_user}","gists_url":"https://api.github.com/users/brianlagunas/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlagunas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlagunas/subscriptions","organizations_url":"https://api.github.com/users/brianlagunas/orgs","repos_url":"https://api.github.com/users/brianlagunas/repos","events_url":"https://api.github.com/users/brianlagunas/events{/privacy}","received_events_url":"https://api.github.com/users/brianlagunas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1064/commits","review_comments_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1064/comments","review_comment_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/1064/comments","statuses_url":"https://api.github.com/repos/PrismLibrary/Prism/statuses/c1f74d5bcdc888e7d809e33c8da3023da8c313da","head":{"label":"nuitsjp:fix-destroy-master-detail-page","ref":"fix-destroy-master-detail-page","sha":"c1f74d5bcdc888e7d809e33c8da3023da8c313da","user":{"login":"nuitsjp","id":16175660,"avatar_url":"https://avatars3.githubusercontent.com/u/16175660?v=3","gravatar_id":"","url":"https://api.github.com/users/nuitsjp","html_url":"https://github.com/nuitsjp","followers_url":"https://api.github.com/users/nuitsjp/followers","following_url":"https://api.github.com/users/nuitsjp/following{/other_user}","gists_url":"https://api.github.com/users/nuitsjp/gists{/gist_id}","starred_url":"https://api.github.com/users/nuitsjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuitsjp/subscriptions","organizations_url":"https://api.github.com/users/nuitsjp/orgs","repos_url":"https://api.github.com/users/nuitsjp/repos","events_url":"https://api.github.com/users/nuitsjp/events{/privacy}","received_events_url":"https://api.github.com/users/nuitsjp/received_events","type":"User","site_admin":false},"repo":{"id":77368184,"name":"Prism","full_name":"nuitsjp/Prism","owner":{"login":"nuitsjp","id":16175660,"avatar_url":"https://avatars3.githubusercontent.com/u/16175660?v=3","gravatar_id":"","url":"https://api.github.com/users/nuitsjp","html_url":"https://github.com/nuitsjp","followers_url":"https://api.github.com/users/nuitsjp/followers","following_url":"https://api.github.com/users/nuitsjp/following{/other_user}","gists_url":"https://api.github.com/users/nuitsjp/gists{/gist_id}","starred_url":"https://api.github.com/users/nuitsjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuitsjp/subscriptions","organizations_url":"https://api.github.com/users/nuitsjp/orgs","repos_url":"https://api.github.com/users/nuitsjp/repos","events_url":"https://api.github.com/users/nuitsjp/events{/privacy}","received_events_url":"https://api.github.com/users/nuitsjp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nuitsjp/Prism","description":"Prism is a framework for building loosely coupled, maintainable, and testable XAML applications in WPF, Windows 10 UWP, and Xamarin Forms.","fork":true,"url":"https://api.github.com/repos/nuitsjp/Prism","forks_url":"https://api.github.com/repos/nuitsjp/Prism/forks","keys_url":"https://api.github.com/repos/nuitsjp/Prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuitsjp/Prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuitsjp/Prism/teams","hooks_url":"https://api.github.com/repos/nuitsjp/Prism/hooks","issue_events_url":"https://api.github.com/repos/nuitsjp/Prism/issues/events{/number}","events_url":"https://api.github.com/repos/nuitsjp/Prism/events","assignees_url":"https://api.github.com/repos/nuitsjp/Prism/assignees{/user}","branches_url":"https://api.github.com/repos/nuitsjp/Prism/branches{/branch}","tags_url":"https://api.github.com/repos/nuitsjp/Prism/tags","blobs_url":"https://api.github.com/repos/nuitsjp/Prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuitsjp/Prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuitsjp/Prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuitsjp/Prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuitsjp/Prism/statuses/{sha}","languages_url":"https://api.github.com/repos/nuitsjp/Prism/languages","stargazers_url":"https://api.github.com/repos/nuitsjp/Prism/stargazers","contributors_url":"https://api.github.com/repos/nuitsjp/Prism/contributors","subscribers_url":"https://api.github.com/repos/nuitsjp/Prism/subscribers","subscription_url":"https://api.github.com/repos/nuitsjp/Prism/subscription","commits_url":"https://api.github.com/repos/nuitsjp/Prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuitsjp/Prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuitsjp/Prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuitsjp/Prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuitsjp/Prism/contents/{+path}","compare_url":"https://api.github.com/repos/nuitsjp/Prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuitsjp/Prism/merges","archive_url":"https://api.github.com/repos/nuitsjp/Prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuitsjp/Prism/downloads","issues_url":"https://api.github.com/repos/nuitsjp/Prism/issues{/number}","pulls_url":"https://api.github.com/repos/nuitsjp/Prism/pulls{/number}","milestones_url":"https://api.github.com/repos/nuitsjp/Prism/milestones{/number}","notifications_url":"https://api.github.com/repos/nuitsjp/Prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuitsjp/Prism/labels{/name}","releases_url":"https://api.github.com/repos/nuitsjp/Prism/releases{/id}","deployments_url":"https://api.github.com/repos/nuitsjp/Prism/deployments","created_at":"2016-12-26T07:59:33Z","updated_at":"2016-12-26T07:59:37Z","pushed_at":"2017-05-26T06:14:55Z","git_url":"git://github.com/nuitsjp/Prism.git","ssh_url":"git@github.com:nuitsjp/Prism.git","clone_url":"https://github.com/nuitsjp/Prism.git","svn_url":"https://github.com/nuitsjp/Prism","homepage":"","size":10779,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PrismLibrary:master","ref":"master","sha":"1e9bd24e41bc8e73b7b8c557186978f4173a3c72","user":{"login":"PrismLibrary","id":10503161,"avatar_url":"https://avatars2.githubusercontent.com/u/10503161?v=3","gravatar_id":"","url":"https://api.github.com/users/PrismLibrary","html_url":"https://github.com/PrismLibrary","followers_url":"https://api.github.com/users/PrismLibrary/followers","following_url":"https://api.github.com/users/PrismLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PrismLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismLibrary/subscriptions","organizations_url":"https://api.github.com/users/PrismLibrary/orgs","repos_url":"https://api.github.com/users/PrismLibrary/repos","events_url":"https://api.github.com/users/PrismLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PrismLibrary/received_events","type":"Organization","site_admin":false},"repo":{"id":31335300,"name":"Prism","full_name":"PrismLibrary/Prism","owner":{"login":"PrismLibrary","id":10503161,"avatar_url":"https://avatars2.githubusercontent.com/u/10503161?v=3","gravatar_id":"","url":"https://api.github.com/users/PrismLibrary","html_url":"https://github.com/PrismLibrary","followers_url":"https://api.github.com/users/PrismLibrary/followers","following_url":"https://api.github.com/users/PrismLibrary/following{/other_user}","gists_url":"https://api.github.com/users/PrismLibrary/gists{/gist_id}","starred_url":"https://api.github.com/users/PrismLibrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrismLibrary/subscriptions","organizations_url":"https://api.github.com/users/PrismLibrary/orgs","repos_url":"https://api.github.com/users/PrismLibrary/repos","events_url":"https://api.github.com/users/PrismLibrary/events{/privacy}","received_events_url":"https://api.github.com/users/PrismLibrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrismLibrary/Prism","description":"Prism is a framework for building loosely coupled, maintainable, and testable XAML applications in WPF, Windows 10 UWP, and Xamarin Forms.","fork":false,"url":"https://api.github.com/repos/PrismLibrary/Prism","forks_url":"https://api.github.com/repos/PrismLibrary/Prism/forks","keys_url":"https://api.github.com/repos/PrismLibrary/Prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrismLibrary/Prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrismLibrary/Prism/teams","hooks_url":"https://api.github.com/repos/PrismLibrary/Prism/hooks","issue_events_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/events{/number}","events_url":"https://api.github.com/repos/PrismLibrary/Prism/events","assignees_url":"https://api.github.com/repos/PrismLibrary/Prism/assignees{/user}","branches_url":"https://api.github.com/repos/PrismLibrary/Prism/branches{/branch}","tags_url":"https://api.github.com/repos/PrismLibrary/Prism/tags","blobs_url":"https://api.github.com/repos/PrismLibrary/Prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrismLibrary/Prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrismLibrary/Prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrismLibrary/Prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrismLibrary/Prism/statuses/{sha}","languages_url":"https://api.github.com/repos/PrismLibrary/Prism/languages","stargazers_url":"https://api.github.com/repos/PrismLibrary/Prism/stargazers","contributors_url":"https://api.github.com/repos/PrismLibrary/Prism/contributors","subscribers_url":"https://api.github.com/repos/PrismLibrary/Prism/subscribers","subscription_url":"https://api.github.com/repos/PrismLibrary/Prism/subscription","commits_url":"https://api.github.com/repos/PrismLibrary/Prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrismLibrary/Prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrismLibrary/Prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrismLibrary/Prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrismLibrary/Prism/contents/{+path}","compare_url":"https://api.github.com/repos/PrismLibrary/Prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrismLibrary/Prism/merges","archive_url":"https://api.github.com/repos/PrismLibrary/Prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrismLibrary/Prism/downloads","issues_url":"https://api.github.com/repos/PrismLibrary/Prism/issues{/number}","pulls_url":"https://api.github.com/repos/PrismLibrary/Prism/pulls{/number}","milestones_url":"https://api.github.com/repos/PrismLibrary/Prism/milestones{/number}","notifications_url":"https://api.github.com/repos/PrismLibrary/Prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrismLibrary/Prism/labels{/name}","releases_url":"https://api.github.com/repos/PrismLibrary/Prism/releases{/id}","deployments_url":"https://api.github.com/repos/PrismLibrary/Prism/deployments","created_at":"2015-02-25T20:54:32Z","updated_at":"2017-05-26T03:40:56Z","pushed_at":"2017-05-26T06:18:22Z","git_url":"git://github.com/PrismLibrary/Prism.git","ssh_url":"git@github.com:PrismLibrary/Prism.git","clone_url":"https://github.com/PrismLibrary/Prism.git","svn_url":"https://github.com/PrismLibrary/Prism","homepage":"","size":10755,"stargazers_count":1480,"watchers_count":1480,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":555,"mirror_url":null,"open_issues_count":45,"forks":555,"open_issues":45,"watchers":1480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1064"},"html":{"href":"https://github.com/PrismLibrary/Prism/pull/1064"},"issue":{"href":"https://api.github.com/repos/PrismLibrary/Prism/issues/1064"},"comments":{"href":"https://api.github.com/repos/PrismLibrary/Prism/issues/1064/comments"},"review_comments":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1064/comments"},"review_comment":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrismLibrary/Prism/pulls/1064/commits"},"statuses":{"href":"https://api.github.com/repos/PrismLibrary/Prism/statuses/c1f74d5bcdc888e7d809e33c8da3023da8c313da"}}}}
{"actor":{"display_login":"dansiegel"}}