{"action":"created","comment":{"url":"https://api.github.com/repos/tom472/mediabox/pulls/comments/154546237","pull_request_review_id":80723530,"id":154546237,"diff_hunk":"@@ -8,13 +8,17 @@ PUID=`id -u $localuname`\n PGID=`id -g $localuname`\n # Get Hostname\n thishost=`hostname`\n-# Get IP Address\n-locip=`hostname -I | awk '{print $1}'`\n-# Get Time Zone\n-time_zone=`cat /etc/timezone`\n+# Get IP Address and Time Zone\n+if [ `uname` == 'Darwin' ]; then\n+    locip=`(ifconfig en0 || ifconfig en1) | grep 'inet ' | awk '{print $2}'`\n+    time_zone=`ls -l /etc/localtime | sed -E 's/.*zoneinfo\\/(.*)$/\\1/'`\n+else\n+    locip=`hostname -I | awk '{print $1}'`\n+    time_zone=`cat /etc/timezone`\n+fi","path":"mediabox.sh","position":15,"original_position":15,"commit_id":"4cfb0327edd39c9d40398c28b105770d42701b61","original_commit_id":"4cfb0327edd39c9d40398c28b105770d42701b61","user":{"login":"tom472","id":413172,"avatar_url":"https://avatars1.githubusercontent.com/u/413172?v=4","gravatar_id":"","url":"https://api.github.com/users/tom472","html_url":"https://github.com/tom472","followers_url":"https://api.github.com/users/tom472/followers","following_url":"https://api.github.com/users/tom472/following{/other_user}","gists_url":"https://api.github.com/users/tom472/gists{/gist_id}","starred_url":"https://api.github.com/users/tom472/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom472/subscriptions","organizations_url":"https://api.github.com/users/tom472/orgs","repos_url":"https://api.github.com/users/tom472/repos","events_url":"https://api.github.com/users/tom472/events{/privacy}","received_events_url":"https://api.github.com/users/tom472/received_events","type":"User","site_admin":false},"body":"Pull this b/c mac related.","created_at":"2017-12-04T01:36:10Z","updated_at":"2017-12-04T01:36:10Z","html_url":"https://github.com/tom472/mediabox/pull/18#discussion_r154546237","pull_request_url":"https://api.github.com/repos/tom472/mediabox/pulls/18","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tom472/mediabox/pulls/comments/154546237"},"html":{"href":"https://github.com/tom472/mediabox/pull/18#discussion_r154546237"},"pull_request":{"href":"https://api.github.com/repos/tom472/mediabox/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/tom472/mediabox/pulls/18","id":155458494,"html_url":"https://github.com/tom472/mediabox/pull/18","diff_url":"https://github.com/tom472/mediabox/pull/18.diff","patch_url":"https://github.com/tom472/mediabox/pull/18.patch","issue_url":"https://api.github.com/repos/tom472/mediabox/issues/18","number":18,"state":"open","locked":false,"title":"Add Mac support, make media directory selectable","user":{"login":"mnkhouri","id":6535396,"avatar_url":"https://avatars0.githubusercontent.com/u/6535396?v=4","gravatar_id":"","url":"https://api.github.com/users/mnkhouri","html_url":"https://github.com/mnkhouri","followers_url":"https://api.github.com/users/mnkhouri/followers","following_url":"https://api.github.com/users/mnkhouri/following{/other_user}","gists_url":"https://api.github.com/users/mnkhouri/gists{/gist_id}","starred_url":"https://api.github.com/users/mnkhouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnkhouri/subscriptions","organizations_url":"https://api.github.com/users/mnkhouri/orgs","repos_url":"https://api.github.com/users/mnkhouri/repos","events_url":"https://api.github.com/users/mnkhouri/events{/privacy}","received_events_url":"https://api.github.com/users/mnkhouri/received_events","type":"User","site_admin":false},"body":"Thanks for the great set of configs! This was a joy to use :) I've made a couple changes that helped my situation (and might help others). I _think_ the changes I made are fully backwards-compatible, so you should see no change in behavior after merging this PR\r\n\r\nTwo changes required for mac support:\r\n1. different method to get IP address and time zone\r\n2. `sed -i` has different semantics -- instead use `perl -i -pe`\r\n\r\nOther major changes:\r\n1. Make the \"Media\" and \"Data/Config\" directories selectable\r\n\r\nSome other minor changes:\r\n1. Remove backticks from commands. AFAIK you only need them in order to capture the stdout, which doesn't seem needed in most of these places","created_at":"2017-11-29T21:34:06Z","updated_at":"2017-12-04T01:36:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2c70587b0f81e6657040a49ea46723baa426c64","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tom472/mediabox/pulls/18/commits","review_comments_url":"https://api.github.com/repos/tom472/mediabox/pulls/18/comments","review_comment_url":"https://api.github.com/repos/tom472/mediabox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tom472/mediabox/issues/18/comments","statuses_url":"https://api.github.com/repos/tom472/mediabox/statuses/4cfb0327edd39c9d40398c28b105770d42701b61","head":{"label":"mnkhouri:master","ref":"master","sha":"4cfb0327edd39c9d40398c28b105770d42701b61","user":{"login":"mnkhouri","id":6535396,"avatar_url":"https://avatars0.githubusercontent.com/u/6535396?v=4","gravatar_id":"","url":"https://api.github.com/users/mnkhouri","html_url":"https://github.com/mnkhouri","followers_url":"https://api.github.com/users/mnkhouri/followers","following_url":"https://api.github.com/users/mnkhouri/following{/other_user}","gists_url":"https://api.github.com/users/mnkhouri/gists{/gist_id}","starred_url":"https://api.github.com/users/mnkhouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnkhouri/subscriptions","organizations_url":"https://api.github.com/users/mnkhouri/orgs","repos_url":"https://api.github.com/users/mnkhouri/repos","events_url":"https://api.github.com/users/mnkhouri/events{/privacy}","received_events_url":"https://api.github.com/users/mnkhouri/received_events","type":"User","site_admin":false},"repo":{"id":112484593,"name":"mediabox","full_name":"mnkhouri/mediabox","owner":{"login":"mnkhouri","id":6535396,"avatar_url":"https://avatars0.githubusercontent.com/u/6535396?v=4","gravatar_id":"","url":"https://api.github.com/users/mnkhouri","html_url":"https://github.com/mnkhouri","followers_url":"https://api.github.com/users/mnkhouri/followers","following_url":"https://api.github.com/users/mnkhouri/following{/other_user}","gists_url":"https://api.github.com/users/mnkhouri/gists{/gist_id}","starred_url":"https://api.github.com/users/mnkhouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnkhouri/subscriptions","organizations_url":"https://api.github.com/users/mnkhouri/orgs","repos_url":"https://api.github.com/users/mnkhouri/repos","events_url":"https://api.github.com/users/mnkhouri/events{/privacy}","received_events_url":"https://api.github.com/users/mnkhouri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnkhouri/mediabox","description":"Container based media tools configuration","fork":true,"url":"https://api.github.com/repos/mnkhouri/mediabox","forks_url":"https://api.github.com/repos/mnkhouri/mediabox/forks","keys_url":"https://api.github.com/repos/mnkhouri/mediabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnkhouri/mediabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnkhouri/mediabox/teams","hooks_url":"https://api.github.com/repos/mnkhouri/mediabox/hooks","issue_events_url":"https://api.github.com/repos/mnkhouri/mediabox/issues/events{/number}","events_url":"https://api.github.com/repos/mnkhouri/mediabox/events","assignees_url":"https://api.github.com/repos/mnkhouri/mediabox/assignees{/user}","branches_url":"https://api.github.com/repos/mnkhouri/mediabox/branches{/branch}","tags_url":"https://api.github.com/repos/mnkhouri/mediabox/tags","blobs_url":"https://api.github.com/repos/mnkhouri/mediabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnkhouri/mediabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnkhouri/mediabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnkhouri/mediabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnkhouri/mediabox/statuses/{sha}","languages_url":"https://api.github.com/repos/mnkhouri/mediabox/languages","stargazers_url":"https://api.github.com/repos/mnkhouri/mediabox/stargazers","contributors_url":"https://api.github.com/repos/mnkhouri/mediabox/contributors","subscribers_url":"https://api.github.com/repos/mnkhouri/mediabox/subscribers","subscription_url":"https://api.github.com/repos/mnkhouri/mediabox/subscription","commits_url":"https://api.github.com/repos/mnkhouri/mediabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnkhouri/mediabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnkhouri/mediabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnkhouri/mediabox/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnkhouri/mediabox/contents/{+path}","compare_url":"https://api.github.com/repos/mnkhouri/mediabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnkhouri/mediabox/merges","archive_url":"https://api.github.com/repos/mnkhouri/mediabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnkhouri/mediabox/downloads","issues_url":"https://api.github.com/repos/mnkhouri/mediabox/issues{/number}","pulls_url":"https://api.github.com/repos/mnkhouri/mediabox/pulls{/number}","milestones_url":"https://api.github.com/repos/mnkhouri/mediabox/milestones{/number}","notifications_url":"https://api.github.com/repos/mnkhouri/mediabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnkhouri/mediabox/labels{/name}","releases_url":"https://api.github.com/repos/mnkhouri/mediabox/releases{/id}","deployments_url":"https://api.github.com/repos/mnkhouri/mediabox/deployments","created_at":"2017-11-29T14:21:15Z","updated_at":"2017-11-29T21:33:38Z","pushed_at":"2017-11-29T21:33:38Z","git_url":"git://github.com/mnkhouri/mediabox.git","ssh_url":"git@github.com:mnkhouri/mediabox.git","clone_url":"https://github.com/mnkhouri/mediabox.git","svn_url":"https://github.com/mnkhouri/mediabox","homepage":null,"size":84,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tom472:master","ref":"master","sha":"51f260ea0cdc9ace99189e7ab4511b881701303f","user":{"login":"tom472","id":413172,"avatar_url":"https://avatars1.githubusercontent.com/u/413172?v=4","gravatar_id":"","url":"https://api.github.com/users/tom472","html_url":"https://github.com/tom472","followers_url":"https://api.github.com/users/tom472/followers","following_url":"https://api.github.com/users/tom472/following{/other_user}","gists_url":"https://api.github.com/users/tom472/gists{/gist_id}","starred_url":"https://api.github.com/users/tom472/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom472/subscriptions","organizations_url":"https://api.github.com/users/tom472/orgs","repos_url":"https://api.github.com/users/tom472/repos","events_url":"https://api.github.com/users/tom472/events{/privacy}","received_events_url":"https://api.github.com/users/tom472/received_events","type":"User","site_admin":false},"repo":{"id":73589663,"name":"mediabox","full_name":"tom472/mediabox","owner":{"login":"tom472","id":413172,"avatar_url":"https://avatars1.githubusercontent.com/u/413172?v=4","gravatar_id":"","url":"https://api.github.com/users/tom472","html_url":"https://github.com/tom472","followers_url":"https://api.github.com/users/tom472/followers","following_url":"https://api.github.com/users/tom472/following{/other_user}","gists_url":"https://api.github.com/users/tom472/gists{/gist_id}","starred_url":"https://api.github.com/users/tom472/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom472/subscriptions","organizations_url":"https://api.github.com/users/tom472/orgs","repos_url":"https://api.github.com/users/tom472/repos","events_url":"https://api.github.com/users/tom472/events{/privacy}","received_events_url":"https://api.github.com/users/tom472/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tom472/mediabox","description":"Container based media tools configuration","fork":false,"url":"https://api.github.com/repos/tom472/mediabox","forks_url":"https://api.github.com/repos/tom472/mediabox/forks","keys_url":"https://api.github.com/repos/tom472/mediabox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tom472/mediabox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tom472/mediabox/teams","hooks_url":"https://api.github.com/repos/tom472/mediabox/hooks","issue_events_url":"https://api.github.com/repos/tom472/mediabox/issues/events{/number}","events_url":"https://api.github.com/repos/tom472/mediabox/events","assignees_url":"https://api.github.com/repos/tom472/mediabox/assignees{/user}","branches_url":"https://api.github.com/repos/tom472/mediabox/branches{/branch}","tags_url":"https://api.github.com/repos/tom472/mediabox/tags","blobs_url":"https://api.github.com/repos/tom472/mediabox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tom472/mediabox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tom472/mediabox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tom472/mediabox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tom472/mediabox/statuses/{sha}","languages_url":"https://api.github.com/repos/tom472/mediabox/languages","stargazers_url":"https://api.github.com/repos/tom472/mediabox/stargazers","contributors_url":"https://api.github.com/repos/tom472/mediabox/contributors","subscribers_url":"https://api.github.com/repos/tom472/mediabox/subscribers","subscription_url":"https://api.github.com/repos/tom472/mediabox/subscription","commits_url":"https://api.github.com/repos/tom472/mediabox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tom472/mediabox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tom472/mediabox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tom472/mediabox/issues/comments{/number}","contents_url":"https://api.github.com/repos/tom472/mediabox/contents/{+path}","compare_url":"https://api.github.com/repos/tom472/mediabox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tom472/mediabox/merges","archive_url":"https://api.github.com/repos/tom472/mediabox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tom472/mediabox/downloads","issues_url":"https://api.github.com/repos/tom472/mediabox/issues{/number}","pulls_url":"https://api.github.com/repos/tom472/mediabox/pulls{/number}","milestones_url":"https://api.github.com/repos/tom472/mediabox/milestones{/number}","notifications_url":"https://api.github.com/repos/tom472/mediabox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tom472/mediabox/labels{/name}","releases_url":"https://api.github.com/repos/tom472/mediabox/releases{/id}","deployments_url":"https://api.github.com/repos/tom472/mediabox/deployments","created_at":"2016-11-13T01:52:31Z","updated_at":"2017-12-03T05:15:38Z","pushed_at":"2017-11-29T21:34:06Z","git_url":"git://github.com/tom472/mediabox.git","ssh_url":"git@github.com:tom472/mediabox.git","clone_url":"https://github.com/tom472/mediabox.git","svn_url":"https://github.com/tom472/mediabox","homepage":null,"size":88,"stargazers_count":34,"watchers_count":34,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":1,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tom472/mediabox/pulls/18"},"html":{"href":"https://github.com/tom472/mediabox/pull/18"},"issue":{"href":"https://api.github.com/repos/tom472/mediabox/issues/18"},"comments":{"href":"https://api.github.com/repos/tom472/mediabox/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/tom472/mediabox/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/tom472/mediabox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tom472/mediabox/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/tom472/mediabox/statuses/4cfb0327edd39c9d40398c28b105770d42701b61"}},"author_association":"NONE"}}
{"actor":{"display_login":"tom472"}}