{"action":"opened","number":519,"pull_request":{"url":"https://api.github.com/repos/etsy/phan/pulls/519","id":105352453,"html_url":"https://github.com/etsy/phan/pull/519","diff_url":"https://github.com/etsy/phan/pull/519.diff","patch_url":"https://github.com/etsy/phan/pull/519.patch","issue_url":"https://api.github.com/repos/etsy/phan/issues/519","number":519,"state":"open","locked":false,"title":"Tighten up object checks and prevent impossible situation","user":{"login":"muglug","id":2292638,"avatar_url":"https://avatars.githubusercontent.com/u/2292638?v=3","gravatar_id":"","url":"https://api.github.com/users/muglug","html_url":"https://github.com/muglug","followers_url":"https://api.github.com/users/muglug/followers","following_url":"https://api.github.com/users/muglug/following{/other_user}","gists_url":"https://api.github.com/users/muglug/gists{/gist_id}","starred_url":"https://api.github.com/users/muglug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muglug/subscriptions","organizations_url":"https://api.github.com/users/muglug/orgs","repos_url":"https://api.github.com/users/muglug/repos","events_url":"https://api.github.com/users/muglug/events{/privacy}","received_events_url":"https://api.github.com/users/muglug/received_events","type":"User","site_admin":false},"body":"The first change removes an impossible situation (as far as I'm aware) in `PostOrderAnalysisVisitor::visitMethod` where an assertion happens, then an opposing `instanceof` check happens.\r\n\r\nThe second change just tightens up the `!is_object` checks to instead be specific about the type of object.","created_at":"2017-02-09T03:15:04Z","updated_at":"2017-02-09T03:15:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/etsy/phan/pulls/519/commits","review_comments_url":"https://api.github.com/repos/etsy/phan/pulls/519/comments","review_comment_url":"https://api.github.com/repos/etsy/phan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etsy/phan/issues/519/comments","statuses_url":"https://api.github.com/repos/etsy/phan/statuses/d41c60ee0abdb306321da35066668ba073762b8c","head":{"label":"muglug:impossible-postorder-types","ref":"impossible-postorder-types","sha":"d41c60ee0abdb306321da35066668ba073762b8c","user":{"login":"muglug","id":2292638,"avatar_url":"https://avatars.githubusercontent.com/u/2292638?v=3","gravatar_id":"","url":"https://api.github.com/users/muglug","html_url":"https://github.com/muglug","followers_url":"https://api.github.com/users/muglug/followers","following_url":"https://api.github.com/users/muglug/following{/other_user}","gists_url":"https://api.github.com/users/muglug/gists{/gist_id}","starred_url":"https://api.github.com/users/muglug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muglug/subscriptions","organizations_url":"https://api.github.com/users/muglug/orgs","repos_url":"https://api.github.com/users/muglug/repos","events_url":"https://api.github.com/users/muglug/events{/privacy}","received_events_url":"https://api.github.com/users/muglug/received_events","type":"User","site_admin":false},"repo":{"id":65581763,"name":"phan","full_name":"muglug/phan","owner":{"login":"muglug","id":2292638,"avatar_url":"https://avatars.githubusercontent.com/u/2292638?v=3","gravatar_id":"","url":"https://api.github.com/users/muglug","html_url":"https://github.com/muglug","followers_url":"https://api.github.com/users/muglug/followers","following_url":"https://api.github.com/users/muglug/following{/other_user}","gists_url":"https://api.github.com/users/muglug/gists{/gist_id}","starred_url":"https://api.github.com/users/muglug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muglug/subscriptions","organizations_url":"https://api.github.com/users/muglug/orgs","repos_url":"https://api.github.com/users/muglug/repos","events_url":"https://api.github.com/users/muglug/events{/privacy}","received_events_url":"https://api.github.com/users/muglug/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muglug/phan","description":"Static analyzer for PHP","fork":true,"url":"https://api.github.com/repos/muglug/phan","forks_url":"https://api.github.com/repos/muglug/phan/forks","keys_url":"https://api.github.com/repos/muglug/phan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muglug/phan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muglug/phan/teams","hooks_url":"https://api.github.com/repos/muglug/phan/hooks","issue_events_url":"https://api.github.com/repos/muglug/phan/issues/events{/number}","events_url":"https://api.github.com/repos/muglug/phan/events","assignees_url":"https://api.github.com/repos/muglug/phan/assignees{/user}","branches_url":"https://api.github.com/repos/muglug/phan/branches{/branch}","tags_url":"https://api.github.com/repos/muglug/phan/tags","blobs_url":"https://api.github.com/repos/muglug/phan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muglug/phan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muglug/phan/git/refs{/sha}","trees_url":"https://api.github.com/repos/muglug/phan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muglug/phan/statuses/{sha}","languages_url":"https://api.github.com/repos/muglug/phan/languages","stargazers_url":"https://api.github.com/repos/muglug/phan/stargazers","contributors_url":"https://api.github.com/repos/muglug/phan/contributors","subscribers_url":"https://api.github.com/repos/muglug/phan/subscribers","subscription_url":"https://api.github.com/repos/muglug/phan/subscription","commits_url":"https://api.github.com/repos/muglug/phan/commits{/sha}","git_commits_url":"https://api.github.com/repos/muglug/phan/git/commits{/sha}","comments_url":"https://api.github.com/repos/muglug/phan/comments{/number}","issue_comment_url":"https://api.github.com/repos/muglug/phan/issues/comments{/number}","contents_url":"https://api.github.com/repos/muglug/phan/contents/{+path}","compare_url":"https://api.github.com/repos/muglug/phan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muglug/phan/merges","archive_url":"https://api.github.com/repos/muglug/phan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muglug/phan/downloads","issues_url":"https://api.github.com/repos/muglug/phan/issues{/number}","pulls_url":"https://api.github.com/repos/muglug/phan/pulls{/number}","milestones_url":"https://api.github.com/repos/muglug/phan/milestones{/number}","notifications_url":"https://api.github.com/repos/muglug/phan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muglug/phan/labels{/name}","releases_url":"https://api.github.com/repos/muglug/phan/releases{/id}","deployments_url":"https://api.github.com/repos/muglug/phan/deployments","created_at":"2016-08-12T20:30:19Z","updated_at":"2016-08-12T20:30:20Z","pushed_at":"2017-02-09T03:12:08Z","git_url":"git://github.com/muglug/phan.git","ssh_url":"git@github.com:muglug/phan.git","clone_url":"https://github.com/muglug/phan.git","svn_url":"https://github.com/muglug/phan","homepage":null,"size":5281,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"etsy:master","ref":"master","sha":"e1ca35be88cb4cec45e01e9ef71eb6f2a5c14842","user":{"login":"etsy","id":193389,"avatar_url":"https://avatars.githubusercontent.com/u/193389?v=3","gravatar_id":"","url":"https://api.github.com/users/etsy","html_url":"https://github.com/etsy","followers_url":"https://api.github.com/users/etsy/followers","following_url":"https://api.github.com/users/etsy/following{/other_user}","gists_url":"https://api.github.com/users/etsy/gists{/gist_id}","starred_url":"https://api.github.com/users/etsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsy/subscriptions","organizations_url":"https://api.github.com/users/etsy/orgs","repos_url":"https://api.github.com/users/etsy/repos","events_url":"https://api.github.com/users/etsy/events{/privacy}","received_events_url":"https://api.github.com/users/etsy/received_events","type":"Organization","site_admin":false},"repo":{"id":44751102,"name":"phan","full_name":"etsy/phan","owner":{"login":"etsy","id":193389,"avatar_url":"https://avatars.githubusercontent.com/u/193389?v=3","gravatar_id":"","url":"https://api.github.com/users/etsy","html_url":"https://github.com/etsy","followers_url":"https://api.github.com/users/etsy/followers","following_url":"https://api.github.com/users/etsy/following{/other_user}","gists_url":"https://api.github.com/users/etsy/gists{/gist_id}","starred_url":"https://api.github.com/users/etsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsy/subscriptions","organizations_url":"https://api.github.com/users/etsy/orgs","repos_url":"https://api.github.com/users/etsy/repos","events_url":"https://api.github.com/users/etsy/events{/privacy}","received_events_url":"https://api.github.com/users/etsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etsy/phan","description":"Phan is a static analyzer for PHP. Phan prefers to avoid false-positives and attempts to prove incorrectness rather than correctness.","fork":false,"url":"https://api.github.com/repos/etsy/phan","forks_url":"https://api.github.com/repos/etsy/phan/forks","keys_url":"https://api.github.com/repos/etsy/phan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etsy/phan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etsy/phan/teams","hooks_url":"https://api.github.com/repos/etsy/phan/hooks","issue_events_url":"https://api.github.com/repos/etsy/phan/issues/events{/number}","events_url":"https://api.github.com/repos/etsy/phan/events","assignees_url":"https://api.github.com/repos/etsy/phan/assignees{/user}","branches_url":"https://api.github.com/repos/etsy/phan/branches{/branch}","tags_url":"https://api.github.com/repos/etsy/phan/tags","blobs_url":"https://api.github.com/repos/etsy/phan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etsy/phan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etsy/phan/git/refs{/sha}","trees_url":"https://api.github.com/repos/etsy/phan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etsy/phan/statuses/{sha}","languages_url":"https://api.github.com/repos/etsy/phan/languages","stargazers_url":"https://api.github.com/repos/etsy/phan/stargazers","contributors_url":"https://api.github.com/repos/etsy/phan/contributors","subscribers_url":"https://api.github.com/repos/etsy/phan/subscribers","subscription_url":"https://api.github.com/repos/etsy/phan/subscription","commits_url":"https://api.github.com/repos/etsy/phan/commits{/sha}","git_commits_url":"https://api.github.com/repos/etsy/phan/git/commits{/sha}","comments_url":"https://api.github.com/repos/etsy/phan/comments{/number}","issue_comment_url":"https://api.github.com/repos/etsy/phan/issues/comments{/number}","contents_url":"https://api.github.com/repos/etsy/phan/contents/{+path}","compare_url":"https://api.github.com/repos/etsy/phan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etsy/phan/merges","archive_url":"https://api.github.com/repos/etsy/phan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etsy/phan/downloads","issues_url":"https://api.github.com/repos/etsy/phan/issues{/number}","pulls_url":"https://api.github.com/repos/etsy/phan/pulls{/number}","milestones_url":"https://api.github.com/repos/etsy/phan/milestones{/number}","notifications_url":"https://api.github.com/repos/etsy/phan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etsy/phan/labels{/name}","releases_url":"https://api.github.com/repos/etsy/phan/releases{/id}","deployments_url":"https://api.github.com/repos/etsy/phan/deployments","created_at":"2015-10-22T14:34:09Z","updated_at":"2017-02-08T09:23:47Z","pushed_at":"2017-02-08T12:37:41Z","git_url":"git://github.com/etsy/phan.git","ssh_url":"git@github.com:etsy/phan.git","clone_url":"https://github.com/etsy/phan.git","svn_url":"https://github.com/etsy/phan","homepage":"","size":4220,"stargazers_count":1937,"watchers_count":1937,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"open_issues_count":68,"forks":149,"open_issues":68,"watchers":1937,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etsy/phan/pulls/519"},"html":{"href":"https://github.com/etsy/phan/pull/519"},"issue":{"href":"https://api.github.com/repos/etsy/phan/issues/519"},"comments":{"href":"https://api.github.com/repos/etsy/phan/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/etsy/phan/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/etsy/phan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etsy/phan/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/etsy/phan/statuses/d41c60ee0abdb306321da35066668ba073762b8c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":21,"changed_files":1}}
{"actor":{"display_login":"muglug"}}