{"action":"created","issue":{"url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/3230","repository_url":"https://api.github.com/repos/UM-USElab/gradecraft-development","labels_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/3230/labels{/name}","comments_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/3230/comments","events_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/3230/events","html_url":"https://github.com/UM-USElab/gradecraft-development/pull/3230","id":223103894,"number":3230,"title":"User lastname","user":{"login":"acousticrobot","id":1138350,"avatar_url":"https://avatars0.githubusercontent.com/u/1138350?v=3","gravatar_id":"","url":"https://api.github.com/users/acousticrobot","html_url":"https://github.com/acousticrobot","followers_url":"https://api.github.com/users/acousticrobot/followers","following_url":"https://api.github.com/users/acousticrobot/following{/other_user}","gists_url":"https://api.github.com/users/acousticrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/acousticrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acousticrobot/subscriptions","organizations_url":"https://api.github.com/users/acousticrobot/orgs","repos_url":"https://api.github.com/users/acousticrobot/repos","events_url":"https://api.github.com/users/acousticrobot/events{/privacy}","received_events_url":"https://api.github.com/users/acousticrobot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"chcholman","id":234276,"avatar_url":"https://avatars3.githubusercontent.com/u/234276?v=3","gravatar_id":"","url":"https://api.github.com/users/chcholman","html_url":"https://github.com/chcholman","followers_url":"https://api.github.com/users/chcholman/followers","following_url":"https://api.github.com/users/chcholman/following{/other_user}","gists_url":"https://api.github.com/users/chcholman/gists{/gist_id}","starred_url":"https://api.github.com/users/chcholman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcholman/subscriptions","organizations_url":"https://api.github.com/users/chcholman/orgs","repos_url":"https://api.github.com/users/chcholman/repos","events_url":"https://api.github.com/users/chcholman/events{/privacy}","received_events_url":"https://api.github.com/users/chcholman/received_events","type":"User","site_admin":false},"assignees":[{"login":"chcholman","id":234276,"avatar_url":"https://avatars3.githubusercontent.com/u/234276?v=3","gravatar_id":"","url":"https://api.github.com/users/chcholman","html_url":"https://github.com/chcholman","followers_url":"https://api.github.com/users/chcholman/followers","following_url":"https://api.github.com/users/chcholman/following{/other_user}","gists_url":"https://api.github.com/users/chcholman/gists{/gist_id}","starred_url":"https://api.github.com/users/chcholman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcholman/subscriptions","organizations_url":"https://api.github.com/users/chcholman/orgs","repos_url":"https://api.github.com/users/chcholman/repos","events_url":"https://api.github.com/users/chcholman/events{/privacy}","received_events_url":"https://api.github.com/users/chcholman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-04-20T15:19:51Z","updated_at":"2017-04-20T19:40:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/UM-USElab/gradecraft-development/pulls/3230","html_url":"https://github.com/UM-USElab/gradecraft-development/pull/3230","diff_url":"https://github.com/UM-USElab/gradecraft-development/pull/3230.diff","patch_url":"https://github.com/UM-USElab/gradecraft-development/pull/3230.patch"},"body":"### Status\r\n**READY, PENDING REVIEW OF COMMENT ON LINE 257**\r\n\r\n### Description\r\n  * This PR adds a unique last name to the user to avoid intermittent failures\r\n  * It also isolates the specs for teams and groups, reducing the runtime for `user_spec.rb` by about a minute and a half\r\n\r\nCait, can you look at the comment on `it \"returns 0 if the student has no score\"...` and let me know what you want me to do?  I think this spec dates back to before we added non-null constraints on the db and probably could be removed, but we may want to take a look at `score_for_course(course)` and refactor this as well."},"comment":{"url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/comments/295875490","html_url":"https://github.com/UM-USElab/gradecraft-development/pull/3230#issuecomment-295875490","issue_url":"https://api.github.com/repos/UM-USElab/gradecraft-development/issues/3230","id":295875490,"user":{"login":"chcholman","id":234276,"avatar_url":"https://avatars3.githubusercontent.com/u/234276?v=3","gravatar_id":"","url":"https://api.github.com/users/chcholman","html_url":"https://github.com/chcholman","followers_url":"https://api.github.com/users/chcholman/followers","following_url":"https://api.github.com/users/chcholman/following{/other_user}","gists_url":"https://api.github.com/users/chcholman/gists{/gist_id}","starred_url":"https://api.github.com/users/chcholman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcholman/subscriptions","organizations_url":"https://api.github.com/users/chcholman/orgs","repos_url":"https://api.github.com/users/chcholman/repos","events_url":"https://api.github.com/users/chcholman/events{/privacy}","received_events_url":"https://api.github.com/users/chcholman/received_events","type":"User","site_admin":false},"created_at":"2017-04-20T19:40:53Z","updated_at":"2017-04-20T19:40:53Z","body":"@acousticrobot It seems like we should both refactor the `score_for_course(course)` method, and can probably remove some of the tests here as well. We both added non-null contraints, and started storing students total values (previously we'd summed them on the fly), which I think is the legacy that caused the pieces we're seeing..."}}
{"actor":{"display_login":"chcholman"}}