{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/149687111","pull_request_review_id":75119064,"id":149687111,"diff_hunk":"@@ -276,6 +269,31 @@ else if (e instanceof ProvisioningException) {\n \t\t}\n \t}\n \n+\t@Deprecated\n+\tprivate void enhanceMessageChannel(MessageChannel inputChannel) {\n+\t\t((AbstractMessageChannel)inputChannel).addInterceptor(new ChannelInterceptorAdapter() {\n+\t\t\t@SuppressWarnings(\"unchecked\")\n+\t\t\t@Override\n+\t\t\tpublic Message<?> preSend(Message<?> message, MessageChannel channel) {\n+\t\t\t\tif (message.getPayload() instanceof byte[]) {\n+\t\t\t\t\tif (!message.getHeaders().containsKey(BinderHeaders.NATIVE_HEADERS_PRESENT)\n+\t\t\t\t\t\t\t&& EmbeddedHeaderUtils.mayHaveEmbeddedHeaders((byte[]) message.getPayload())) {\n+\t\t\t\t\t\tMessageValues messageValues;","path":"spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binder/AbstractMessageChannelBinder.java","position":81,"original_position":81,"commit_id":"ad89a419efe2307020ece8570febf661b1806783","original_commit_id":"ad89a419efe2307020ece8570febf661b1806783","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars3.githubusercontent.com/u/483832?v=4","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"@artembilan it should just happen automatically if the headerMode is set.\r\n\r\nThis comment is redundant - discussed with @olegz - this method is only called if the header mode is `embeddedHeaders` - I was thrown off by the deprecation.","created_at":"2017-11-08T14:41:30Z","updated_at":"2017-11-08T14:41:30Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/1125#discussion_r149687111","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/1125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments/149687111"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/1125#discussion_r149687111"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/1125"}},"in_reply_to_id":149680820},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/1125","id":151344701,"html_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/1125","diff_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/1125.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream/pull/1125.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/1125","number":1125,"state":"open","locked":false,"title":"Initial cleanup of AbstractMessageChannelBinder","user":{"login":"olegz","id":172397,"avatar_url":"https://avatars0.githubusercontent.com/u/172397?v=4","gravatar_id":"","url":"https://api.github.com/users/olegz","html_url":"https://github.com/olegz","followers_url":"https://api.github.com/users/olegz/followers","following_url":"https://api.github.com/users/olegz/following{/other_user}","gists_url":"https://api.github.com/users/olegz/gists{/gist_id}","starred_url":"https://api.github.com/users/olegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegz/subscriptions","organizations_url":"https://api.github.com/users/olegz/orgs","repos_url":"https://api.github.com/users/olegz/repos","events_url":"https://api.github.com/users/olegz/events{/privacy}","received_events_url":"https://api.github.com/users/olegz/received_events","type":"User","site_admin":false},"body":"Removed extra handler for embeddedHeaders in favor of ChannelInterceptor to avoid additional dispatch\r\nDeprecated HeaderMode","created_at":"2017-11-08T10:28:46Z","updated_at":"2017-11-08T14:41:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d825b04db200c27b5fbc69c581e1d2eee4d0b227","assignee":{"login":"olegz","id":172397,"avatar_url":"https://avatars0.githubusercontent.com/u/172397?v=4","gravatar_id":"","url":"https://api.github.com/users/olegz","html_url":"https://github.com/olegz","followers_url":"https://api.github.com/users/olegz/followers","following_url":"https://api.github.com/users/olegz/following{/other_user}","gists_url":"https://api.github.com/users/olegz/gists{/gist_id}","starred_url":"https://api.github.com/users/olegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegz/subscriptions","organizations_url":"https://api.github.com/users/olegz/orgs","repos_url":"https://api.github.com/users/olegz/repos","events_url":"https://api.github.com/users/olegz/events{/privacy}","received_events_url":"https://api.github.com/users/olegz/received_events","type":"User","site_admin":false},"assignees":[{"login":"olegz","id":172397,"avatar_url":"https://avatars0.githubusercontent.com/u/172397?v=4","gravatar_id":"","url":"https://api.github.com/users/olegz","html_url":"https://github.com/olegz","followers_url":"https://api.github.com/users/olegz/followers","following_url":"https://api.github.com/users/olegz/following{/other_user}","gists_url":"https://api.github.com/users/olegz/gists{/gist_id}","starred_url":"https://api.github.com/users/olegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegz/subscriptions","organizations_url":"https://api.github.com/users/olegz/orgs","repos_url":"https://api.github.com/users/olegz/repos","events_url":"https://api.github.com/users/olegz/events{/privacy}","received_events_url":"https://api.github.com/users/olegz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones/35","html_url":"https://github.com/spring-cloud/spring-cloud-stream/milestone/35","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones/35/labels","id":2862603,"number":35,"title":"2.0.0.M3","description":"","creator":{"login":"sabbyanandan","id":1562654,"avatar_url":"https://avatars1.githubusercontent.com/u/1562654?v=4","gravatar_id":"","url":"https://api.github.com/users/sabbyanandan","html_url":"https://github.com/sabbyanandan","followers_url":"https://api.github.com/users/sabbyanandan/followers","following_url":"https://api.github.com/users/sabbyanandan/following{/other_user}","gists_url":"https://api.github.com/users/sabbyanandan/gists{/gist_id}","starred_url":"https://api.github.com/users/sabbyanandan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabbyanandan/subscriptions","organizations_url":"https://api.github.com/users/sabbyanandan/orgs","repos_url":"https://api.github.com/users/sabbyanandan/repos","events_url":"https://api.github.com/users/sabbyanandan/events{/privacy}","received_events_url":"https://api.github.com/users/sabbyanandan/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":6,"state":"open","created_at":"2017-10-24T15:27:42Z","updated_at":"2017-11-08T13:54:10Z","due_on":"2017-11-08T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/1125/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/1125/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/1125/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/ad89a419efe2307020ece8570febf661b1806783","head":{"label":"olegz:AMCB_CL","ref":"AMCB_CL","sha":"ad89a419efe2307020ece8570febf661b1806783","user":{"login":"olegz","id":172397,"avatar_url":"https://avatars0.githubusercontent.com/u/172397?v=4","gravatar_id":"","url":"https://api.github.com/users/olegz","html_url":"https://github.com/olegz","followers_url":"https://api.github.com/users/olegz/followers","following_url":"https://api.github.com/users/olegz/following{/other_user}","gists_url":"https://api.github.com/users/olegz/gists{/gist_id}","starred_url":"https://api.github.com/users/olegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegz/subscriptions","organizations_url":"https://api.github.com/users/olegz/orgs","repos_url":"https://api.github.com/users/olegz/repos","events_url":"https://api.github.com/users/olegz/events{/privacy}","received_events_url":"https://api.github.com/users/olegz/received_events","type":"User","site_admin":false},"repo":{"id":87456271,"name":"spring-cloud-stream","full_name":"olegz/spring-cloud-stream","owner":{"login":"olegz","id":172397,"avatar_url":"https://avatars0.githubusercontent.com/u/172397?v=4","gravatar_id":"","url":"https://api.github.com/users/olegz","html_url":"https://github.com/olegz","followers_url":"https://api.github.com/users/olegz/followers","following_url":"https://api.github.com/users/olegz/following{/other_user}","gists_url":"https://api.github.com/users/olegz/gists{/gist_id}","starred_url":"https://api.github.com/users/olegz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olegz/subscriptions","organizations_url":"https://api.github.com/users/olegz/orgs","repos_url":"https://api.github.com/users/olegz/repos","events_url":"https://api.github.com/users/olegz/events{/privacy}","received_events_url":"https://api.github.com/users/olegz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olegz/spring-cloud-stream","description":"Event-Driven Microservices with Spring Integration","fork":true,"url":"https://api.github.com/repos/olegz/spring-cloud-stream","forks_url":"https://api.github.com/repos/olegz/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/olegz/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olegz/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olegz/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/olegz/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/olegz/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/olegz/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/olegz/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/olegz/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/olegz/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/olegz/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olegz/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olegz/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/olegz/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olegz/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/olegz/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/olegz/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/olegz/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/olegz/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/olegz/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/olegz/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/olegz/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/olegz/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/olegz/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/olegz/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/olegz/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olegz/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/olegz/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olegz/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/olegz/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/olegz/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/olegz/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/olegz/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olegz/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/olegz/spring-cloud-stream/releases{/id}","deployments_url":"https://api.github.com/repos/olegz/spring-cloud-stream/deployments","created_at":"2017-04-06T17:24:58Z","updated_at":"2017-04-06T17:25:00Z","pushed_at":"2017-11-08T10:27:55Z","git_url":"git://github.com/olegz/spring-cloud-stream.git","ssh_url":"git@github.com:olegz/spring-cloud-stream.git","clone_url":"https://github.com/olegz/spring-cloud-stream.git","svn_url":"https://github.com/olegz/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-stream","size":4604,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"a7fdf6dbb2c87319024e29898484e299bf4f4328","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":38764029,"name":"spring-cloud-stream","full_name":"spring-cloud/spring-cloud-stream","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars0.githubusercontent.com/u/7815877?v=4","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream","description":"Event-Driven Microservices with Spring Integration","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/deployments","created_at":"2015-07-08T15:51:38Z","updated_at":"2017-10-29T21:33:56Z","pushed_at":"2017-11-08T14:31:19Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream","homepage":"http://cloud.spring.io/spring-cloud-stream","size":4561,"stargazers_count":229,"watchers_count":229,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":69,"forks":152,"open_issues":69,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/1125"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream/pull/1125"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/1125"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/issues/1125/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/1125/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/pulls/1125/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream/statuses/ad89a419efe2307020ece8570febf661b1806783"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"garyrussell"}}