{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/aruba/issues/450","repository_url":"https://api.github.com/repos/cucumber/aruba","labels_url":"https://api.github.com/repos/cucumber/aruba/issues/450/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/aruba/issues/450/comments","events_url":"https://api.github.com/repos/cucumber/aruba/issues/450/events","html_url":"https://github.com/cucumber/aruba/pull/450","id":242458760,"number":450,"title":"Split up API spec files","user":{"login":"maxmeyer","id":114236,"avatar_url":"https://avatars7.githubusercontent.com/u/114236?v=4","gravatar_id":"","url":"https://api.github.com/users/maxmeyer","html_url":"https://github.com/maxmeyer","followers_url":"https://api.github.com/users/maxmeyer/followers","following_url":"https://api.github.com/users/maxmeyer/following{/other_user}","gists_url":"https://api.github.com/users/maxmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmeyer/subscriptions","organizations_url":"https://api.github.com/users/maxmeyer/orgs","repos_url":"https://api.github.com/users/maxmeyer/repos","events_url":"https://api.github.com/users/maxmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/maxmeyer/received_events","type":"User","site_admin":false},"labels":[{"id":211657836,"url":"https://api.github.com/repos/cucumber/aruba/labels/status/work-in-progress","name":"status/work-in-progress","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-12T17:35:50Z","updated_at":"2017-07-16T21:19:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cucumber/aruba/pulls/450","html_url":"https://github.com/cucumber/aruba/pull/450","diff_url":"https://github.com/cucumber/aruba/pull/450.diff","patch_url":"https://github.com/cucumber/aruba/pull/450.patch"},"body":"<!-- These sections are meant as guidance for you. If something doesn't fit, you can just skip it. -->\r\n\r\n## Summary\r\n\r\nThis PR cleans up the `spec`-directory - Focus: `spec/aruba/api`.\r\n\r\n<!--- Provide a general summary description of your changes -->\r\n\r\n## Motivation and Context\r\n\r\n* `spec/aruba/api_spec.rb is ~1000 lines long\r\n* The file is hard to maintain\r\n* To remove the deprecated methods all specs need to be removed as well, this should be easier if they are not all over one file.\r\n\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [x] Refactoring\r\n\r\n## Checklist:\r\n\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] I've added tests for my code\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n"},"comment":{"url":"https://api.github.com/repos/cucumber/aruba/issues/comments/315638083","html_url":"https://github.com/cucumber/aruba/pull/450#issuecomment-315638083","issue_url":"https://api.github.com/repos/cucumber/aruba/issues/450","id":315638083,"user":{"login":"maxmeyer","id":114236,"avatar_url":"https://avatars7.githubusercontent.com/u/114236?v=4","gravatar_id":"","url":"https://api.github.com/users/maxmeyer","html_url":"https://github.com/maxmeyer","followers_url":"https://api.github.com/users/maxmeyer/followers","following_url":"https://api.github.com/users/maxmeyer/following{/other_user}","gists_url":"https://api.github.com/users/maxmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/maxmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxmeyer/subscriptions","organizations_url":"https://api.github.com/users/maxmeyer/orgs","repos_url":"https://api.github.com/users/maxmeyer/repos","events_url":"https://api.github.com/users/maxmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/maxmeyer/received_events","type":"User","site_admin":false},"created_at":"2017-07-16T21:19:18Z","updated_at":"2017-07-16T21:19:18Z","body":"@mvz Sounds reasable, but my idea was to just break apart the `api_spec.rb`. Then start another PR where we start removing deprecated code and just remove the test file which belongs to the code."}}
{"actor":{"display_login":"maxmeyer"}}