{"action":"closed","issue":{"url":"https://api.github.com/repos/paul-buerkner/brms/issues/260","repository_url":"https://api.github.com/repos/paul-buerkner/brms","labels_url":"https://api.github.com/repos/paul-buerkner/brms/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/paul-buerkner/brms/issues/260/comments","events_url":"https://api.github.com/repos/paul-buerkner/brms/issues/260/events","html_url":"https://github.com/paul-buerkner/brms/issues/260","id":253913940,"number":260,"title":"brms should not touch ggplot theme on load","user":{"login":"tmalsburg","id":3817450,"avatar_url":"https://avatars0.githubusercontent.com/u/3817450?v=4","gravatar_id":"","url":"https://api.github.com/users/tmalsburg","html_url":"https://github.com/tmalsburg","followers_url":"https://api.github.com/users/tmalsburg/followers","following_url":"https://api.github.com/users/tmalsburg/following{/other_user}","gists_url":"https://api.github.com/users/tmalsburg/gists{/gist_id}","starred_url":"https://api.github.com/users/tmalsburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmalsburg/subscriptions","organizations_url":"https://api.github.com/users/tmalsburg/orgs","repos_url":"https://api.github.com/users/tmalsburg/repos","events_url":"https://api.github.com/users/tmalsburg/events{/privacy}","received_events_url":"https://api.github.com/users/tmalsburg/received_events","type":"User","site_admin":false},"labels":[{"id":225684805,"url":"https://api.github.com/repos/paul-buerkner/brms/labels/duplicate","name":"duplicate","color":"cccccc","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-30T08:12:40Z","updated_at":"2017-08-30T08:35:41Z","closed_at":"2017-08-30T08:35:41Z","author_association":"NONE","body":"Perhaps a matter of taste but I think brms should leave the default plotting theme untouched.  Basically what's happening is that I load brms somewhere in my Knitr document and then all plots after that position look differently than the plots before.  Of course, I can reset the default theme after loading brms that's not an ideal solution, because that theme is actually useful for the diagnostic plots produced by brms.\r\n\r\nI suggest that brms plotting functions use `bayesplot::theme_default()` as the default value for the theme argument in its plotting functions. This way we get an appropriate theme for diagnostic plots and brms doesn't mess up my own plots.  Alternatively, it may make sense to have a brms-specific theme setting such that people can set the theme used by brms once if they prefer something else without having to specify the theme every time they call a brms plotting function."}}
{"actor":{"display_login":"paul-buerkner"}}