{"action":"created","comment":{"url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/comments/110038329","pull_request_review_id":31181260,"id":110038329,"diff_hunk":"@@ -298,9 +308,26 @@ def acknowledge_alert(alert_id, by = nil, comment = nil)\n     #  thin        boolean, return lighter events (omits triggering data for trigger-generated events)\n     # @param [Hash] criteria optional query criteria\n     # @return [Array<Event>] List of events. Can be empty\n-    def list_events(*criteria)\n-      query = generate_query_params(*criteria)\n-      http_get('/events' + query).map { |e| Event.new(e) }\n+    def list_events(criteria = {})","path":"lib/hawkular/alerts/alerts_api.rb","position":27,"original_position":27,"commit_id":"759cb8093a1864b5f4b19162ebd291a1156555b9","original_commit_id":"759cb8093a1864b5f4b19162ebd291a1156555b9","user":{"login":"josejulio","id":3845764,"avatar_url":"https://avatars2.githubusercontent.com/u/3845764?v=3","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"body":"nitpicking, we could remove this method and just add an alias to events.","created_at":"2017-04-05T22:00:29Z","updated_at":"2017-04-05T22:00:44Z","html_url":"https://github.com/hawkular/hawkular-client-ruby/pull/204#discussion_r110038329","pull_request_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/204","_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/comments/110038329"},"html":{"href":"https://github.com/hawkular/hawkular-client-ruby/pull/204#discussion_r110038329"},"pull_request":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/204"}}},"pull_request":{"url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/204","id":114387401,"html_url":"https://github.com/hawkular/hawkular-client-ruby/pull/204","diff_url":"https://github.com/hawkular/hawkular-client-ruby/pull/204.diff","patch_url":"https://github.com/hawkular/hawkular-client-ruby/pull/204.patch","issue_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/issues/204","number":204,"state":"open","locked":false,"title":"Adding support to list alerts and events for multiple tenants","user":{"login":"israel-hdez","id":23639005,"avatar_url":"https://avatars0.githubusercontent.com/u/23639005?v=3","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"body":"Supported endpoints are:\r\n- hawkular/alerts/admin/alerts\r\n- hawkular/alerts/admin/events\r\n\r\nThis fixes hawkular/hawkular-client-ruby#176","created_at":"2017-04-05T14:16:55Z","updated_at":"2017-04-05T22:00:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cbc3a8976c14fe4ed3425e0b81026fb67ed1519","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/204/commits","review_comments_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/204/comments","review_comment_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/issues/204/comments","statuses_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/statuses/759cb8093a1864b5f4b19162ebd291a1156555b9","head":{"label":"israel-hdez:support_multitenant_operations","ref":"support_multitenant_operations","sha":"759cb8093a1864b5f4b19162ebd291a1156555b9","user":{"login":"israel-hdez","id":23639005,"avatar_url":"https://avatars0.githubusercontent.com/u/23639005?v=3","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"repo":{"id":87230001,"name":"hawkular-client-ruby","full_name":"israel-hdez/hawkular-client-ruby","owner":{"login":"israel-hdez","id":23639005,"avatar_url":"https://avatars0.githubusercontent.com/u/23639005?v=3","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/israel-hdez/hawkular-client-ruby","description":"Ruby client for Hawkular","fork":true,"url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby","forks_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/forks","keys_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/teams","hooks_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/hooks","issue_events_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/events","assignees_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/tags","blobs_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/languages","stargazers_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/stargazers","contributors_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/contributors","subscribers_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/subscribers","subscription_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/subscription","commits_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/merges","archive_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/downloads","issues_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/labels{/name}","releases_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/israel-hdez/hawkular-client-ruby/deployments","created_at":"2017-04-04T20:06:43Z","updated_at":"2017-04-04T20:06:45Z","pushed_at":"2017-04-05T21:28:21Z","git_url":"git://github.com/israel-hdez/hawkular-client-ruby.git","ssh_url":"git@github.com:israel-hdez/hawkular-client-ruby.git","clone_url":"https://github.com/israel-hdez/hawkular-client-ruby.git","svn_url":"https://github.com/israel-hdez/hawkular-client-ruby","homepage":"http://hawkular.org/","size":4983,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hawkular:master","ref":"master","sha":"d8ff8091d35f55fbf20eafb099b911e15c53a432","user":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars1.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"repo":{"id":39637373,"name":"hawkular-client-ruby","full_name":"hawkular/hawkular-client-ruby","owner":{"login":"hawkular","id":10179627,"avatar_url":"https://avatars1.githubusercontent.com/u/10179627?v=3","gravatar_id":"","url":"https://api.github.com/users/hawkular","html_url":"https://github.com/hawkular","followers_url":"https://api.github.com/users/hawkular/followers","following_url":"https://api.github.com/users/hawkular/following{/other_user}","gists_url":"https://api.github.com/users/hawkular/gists{/gist_id}","starred_url":"https://api.github.com/users/hawkular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawkular/subscriptions","organizations_url":"https://api.github.com/users/hawkular/orgs","repos_url":"https://api.github.com/users/hawkular/repos","events_url":"https://api.github.com/users/hawkular/events{/privacy}","received_events_url":"https://api.github.com/users/hawkular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hawkular/hawkular-client-ruby","description":"Ruby client for Hawkular","fork":false,"url":"https://api.github.com/repos/hawkular/hawkular-client-ruby","forks_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/forks","keys_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/teams","hooks_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/hooks","issue_events_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/events","assignees_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/tags","blobs_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/languages","stargazers_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/stargazers","contributors_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/contributors","subscribers_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/subscribers","subscription_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/subscription","commits_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/merges","archive_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/downloads","issues_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/labels{/name}","releases_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/hawkular/hawkular-client-ruby/deployments","created_at":"2015-07-24T14:05:43Z","updated_at":"2017-03-04T14:31:48Z","pushed_at":"2017-04-05T21:28:23Z","git_url":"git://github.com/hawkular/hawkular-client-ruby.git","ssh_url":"git@github.com:hawkular/hawkular-client-ruby.git","clone_url":"https://github.com/hawkular/hawkular-client-ruby.git","svn_url":"https://github.com/hawkular/hawkular-client-ruby","homepage":"http://hawkular.org/","size":4970,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":11,"forks":23,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/204"},"html":{"href":"https://github.com/hawkular/hawkular-client-ruby/pull/204"},"issue":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/issues/204"},"comments":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/hawkular/hawkular-client-ruby/statuses/759cb8093a1864b5f4b19162ebd291a1156555b9"}}}}
{"actor":{"display_login":"josejulio"}}