{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tmlibs/pulls/comments/153687023","pull_request_review_id":79729049,"id":153687023,"diff_hunk":"@@ -4,14 +4,18 @@ GOTOOLS = \\\n \tgithub.com/Masterminds/glide \\\n \tgithub.com/alecthomas/gometalinter\n \n+PACKAGES=$(shell go list ./... | grep -v '/vendor/')\n REPO:=github.com/tendermint/tmlibs\n \n all: test\n \n NOVENDOR = go list github.com/tendermint/tmlibs/... | grep -v /vendor/","path":"Makefile","position":9,"original_position":9,"commit_id":"160ba8200737a7c88eca48d37ead54e369b99709","original_commit_id":"160ba8200737a7c88eca48d37ead54e369b99709","user":{"login":"melekes","id":1282182,"avatar_url":"https://avatars2.githubusercontent.com/u/1282182?v=4","gravatar_id":"","url":"https://api.github.com/users/melekes","html_url":"https://github.com/melekes","followers_url":"https://api.github.com/users/melekes/followers","following_url":"https://api.github.com/users/melekes/following{/other_user}","gists_url":"https://api.github.com/users/melekes/gists{/gist_id}","starred_url":"https://api.github.com/users/melekes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melekes/subscriptions","organizations_url":"https://api.github.com/users/melekes/orgs","repos_url":"https://api.github.com/users/melekes/repos","events_url":"https://api.github.com/users/melekes/events{/privacy}","received_events_url":"https://api.github.com/users/melekes/received_events","type":"User","site_admin":false},"body":"this line can be removed now (it is identical to `PACKAGES`)","created_at":"2017-11-29T03:35:10Z","updated_at":"2017-11-29T03:35:10Z","html_url":"https://github.com/tendermint/tmlibs/pull/75#discussion_r153687023","pull_request_url":"https://api.github.com/repos/tendermint/tmlibs/pulls/75","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/comments/153687023"},"html":{"href":"https://github.com/tendermint/tmlibs/pull/75#discussion_r153687023"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/tendermint/tmlibs/pulls/75","id":150925818,"html_url":"https://github.com/tendermint/tmlibs/pull/75","diff_url":"https://github.com/tendermint/tmlibs/pull/75.diff","patch_url":"https://github.com/tendermint/tmlibs/pull/75.patch","issue_url":"https://api.github.com/repos/tendermint/tmlibs/issues/75","number":75,"state":"open","locked":false,"title":"change common start signature","user":{"login":"melekes","id":1282182,"avatar_url":"https://avatars2.githubusercontent.com/u/1282182?v=4","gravatar_id":"","url":"https://api.github.com/users/melekes","html_url":"https://github.com/melekes","followers_url":"https://api.github.com/users/melekes/followers","following_url":"https://api.github.com/users/melekes/following{/other_user}","gists_url":"https://api.github.com/users/melekes/gists{/gist_id}","starred_url":"https://api.github.com/users/melekes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melekes/subscriptions","organizations_url":"https://api.github.com/users/melekes/orgs","repos_url":"https://api.github.com/users/melekes/repos","events_url":"https://api.github.com/users/melekes/events{/privacy}","received_events_url":"https://api.github.com/users/melekes/received_events","type":"User","site_admin":false},"body":"Refs #45 ","created_at":"2017-11-06T18:30:12Z","updated_at":"2017-11-29T03:35:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5a1badd5414f4fa9f27982401fb2dfdda9917fd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tmlibs/pulls/75/commits","review_comments_url":"https://api.github.com/repos/tendermint/tmlibs/pulls/75/comments","review_comment_url":"https://api.github.com/repos/tendermint/tmlibs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tmlibs/issues/75/comments","statuses_url":"https://api.github.com/repos/tendermint/tmlibs/statuses/160ba8200737a7c88eca48d37ead54e369b99709","head":{"label":"tendermint:45-change-common-start-signature","ref":"45-change-common-start-signature","sha":"160ba8200737a7c88eca48d37ead54e369b99709","user":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":88674011,"name":"tmlibs","full_name":"tendermint/tmlibs","owner":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tmlibs","description":null,"fork":false,"url":"https://api.github.com/repos/tendermint/tmlibs","forks_url":"https://api.github.com/repos/tendermint/tmlibs/forks","keys_url":"https://api.github.com/repos/tendermint/tmlibs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tmlibs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tmlibs/teams","hooks_url":"https://api.github.com/repos/tendermint/tmlibs/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tmlibs/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tmlibs/events","assignees_url":"https://api.github.com/repos/tendermint/tmlibs/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tmlibs/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tmlibs/tags","blobs_url":"https://api.github.com/repos/tendermint/tmlibs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tmlibs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tmlibs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tmlibs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tmlibs/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tmlibs/languages","stargazers_url":"https://api.github.com/repos/tendermint/tmlibs/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tmlibs/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tmlibs/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tmlibs/subscription","commits_url":"https://api.github.com/repos/tendermint/tmlibs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tmlibs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tmlibs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tmlibs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tmlibs/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tmlibs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tmlibs/merges","archive_url":"https://api.github.com/repos/tendermint/tmlibs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tmlibs/downloads","issues_url":"https://api.github.com/repos/tendermint/tmlibs/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tmlibs/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tmlibs/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tmlibs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tmlibs/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tmlibs/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tmlibs/deployments","created_at":"2017-04-18T21:56:36Z","updated_at":"2017-11-28T03:43:58Z","pushed_at":"2017-11-29T03:04:08Z","git_url":"git://github.com/tendermint/tmlibs.git","ssh_url":"git@github.com:tendermint/tmlibs.git","clone_url":"https://github.com/tendermint/tmlibs.git","svn_url":"https://github.com/tendermint/tmlibs","homepage":null,"size":391,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":8,"open_issues":10,"watchers":14,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"ac0cf0b2e2e5246f331628a38e50ea7f0db54f8b","user":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":88674011,"name":"tmlibs","full_name":"tendermint/tmlibs","owner":{"login":"tendermint","id":7572940,"avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tendermint/tmlibs","description":null,"fork":false,"url":"https://api.github.com/repos/tendermint/tmlibs","forks_url":"https://api.github.com/repos/tendermint/tmlibs/forks","keys_url":"https://api.github.com/repos/tendermint/tmlibs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tmlibs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tmlibs/teams","hooks_url":"https://api.github.com/repos/tendermint/tmlibs/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tmlibs/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tmlibs/events","assignees_url":"https://api.github.com/repos/tendermint/tmlibs/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tmlibs/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tmlibs/tags","blobs_url":"https://api.github.com/repos/tendermint/tmlibs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tmlibs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tmlibs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tmlibs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tmlibs/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tmlibs/languages","stargazers_url":"https://api.github.com/repos/tendermint/tmlibs/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tmlibs/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tmlibs/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tmlibs/subscription","commits_url":"https://api.github.com/repos/tendermint/tmlibs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tmlibs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tmlibs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tmlibs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tmlibs/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tmlibs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tmlibs/merges","archive_url":"https://api.github.com/repos/tendermint/tmlibs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tmlibs/downloads","issues_url":"https://api.github.com/repos/tendermint/tmlibs/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tmlibs/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tmlibs/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tmlibs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tmlibs/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tmlibs/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tmlibs/deployments","created_at":"2017-04-18T21:56:36Z","updated_at":"2017-11-28T03:43:58Z","pushed_at":"2017-11-29T03:04:08Z","git_url":"git://github.com/tendermint/tmlibs.git","ssh_url":"git@github.com:tendermint/tmlibs.git","clone_url":"https://github.com/tendermint/tmlibs.git","svn_url":"https://github.com/tendermint/tmlibs","homepage":null,"size":391,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":8,"open_issues":10,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/75"},"html":{"href":"https://github.com/tendermint/tmlibs/pull/75"},"issue":{"href":"https://api.github.com/repos/tendermint/tmlibs/issues/75"},"comments":{"href":"https://api.github.com/repos/tendermint/tmlibs/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tmlibs/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tmlibs/statuses/160ba8200737a7c88eca48d37ead54e369b99709"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"melekes"}}