{"action":"closed","issue":{"url":"https://api.github.com/repos/z88dk/z88dk/issues/227","repository_url":"https://api.github.com/repos/z88dk/z88dk","labels_url":"https://api.github.com/repos/z88dk/z88dk/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/z88dk/z88dk/issues/227/comments","events_url":"https://api.github.com/repos/z88dk/z88dk/issues/227/events","html_url":"https://github.com/z88dk/z88dk/issues/227","id":225884425,"number":227,"title":"new c lib: terminal drivers cursor position in ascii stream should not be zero based","user":{"login":"aralbrec","id":13653828,"avatar_url":"https://avatars3.githubusercontent.com/u/13653828?v=3","gravatar_id":"","url":"https://api.github.com/users/aralbrec","html_url":"https://github.com/aralbrec","followers_url":"https://api.github.com/users/aralbrec/followers","following_url":"https://api.github.com/users/aralbrec/following{/other_user}","gists_url":"https://api.github.com/users/aralbrec/gists{/gist_id}","starred_url":"https://api.github.com/users/aralbrec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aralbrec/subscriptions","organizations_url":"https://api.github.com/users/aralbrec/orgs","repos_url":"https://api.github.com/users/aralbrec/repos","events_url":"https://api.github.com/users/aralbrec/events{/privacy}","received_events_url":"https://api.github.com/users/aralbrec/received_events","type":"User","site_admin":false},"labels":[{"id":592452001,"url":"https://api.github.com/repos/z88dk/z88dk/labels/newlib","name":"newlib","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-03T04:57:04Z","updated_at":"2017-06-14T06:59:41Z","closed_at":"2017-06-14T06:59:41Z","body":"I thought I would fix this when the tty drivers were re-implemented but since the fix should be easy, do it before the 1.99C release.\r\n\r\nThe z88dk-tty driver currently takes cursor position information as 0-based, meaning to move the cursor to a 0 coordinate you send the terminal a 0 byte.  However this means you can't store these control codes in strings because C will treat the embedded 0 bytes as string terminators.\r\n\r\nSo these should be changed to 1-based instead of 0-based.  I think that's what the standard is.\r\n\r\nAlso check the sp1_PrintString function which may suffer from the same problem.  Changes here may cause some compatibility problems as I have seen a few programs use it.\r\n"}}
{"actor":{"display_login":"aralbrec"}}