{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/2340","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/2340/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/2340/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/2340/events","html_url":"https://github.com/triplea-game/triplea/issues/2340","id":256165343,"number":2340,"title":"Still incorrect handling of Facility bombing","user":{"login":"panther2","id":20812775,"avatar_url":"https://avatars3.githubusercontent.com/u/20812775?v=4","gravatar_id":"","url":"https://api.github.com/users/panther2","html_url":"https://github.com/panther2","followers_url":"https://api.github.com/users/panther2/followers","following_url":"https://api.github.com/users/panther2/following{/other_user}","gists_url":"https://api.github.com/users/panther2/gists{/gist_id}","starred_url":"https://api.github.com/users/panther2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panther2/subscriptions","organizations_url":"https://api.github.com/users/panther2/orgs","repos_url":"https://api.github.com/users/panther2/repos","events_url":"https://api.github.com/users/panther2/events{/privacy}","received_events_url":"https://api.github.com/users/panther2/received_events","type":"User","site_admin":false},"labels":[{"id":406043325,"url":"https://api.github.com/repos/triplea-game/triplea/labels/category:%20game%20engine%20%3E%20game%20rules","name":"category: game engine > game rules","color":"bfdadc","default":false},{"id":287600415,"url":"https://api.github.com/repos/triplea-game/triplea/labels/close%20pending%20confirmation","name":"close pending confirmation","color":"e99695","default":false},{"id":241045289,"url":"https://api.github.com/repos/triplea-game/triplea/labels/type:%20bug","name":"type: bug","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars0.githubusercontent.com/u/1427689?v=4","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"assignees":[{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars0.githubusercontent.com/u/1427689?v=4","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},{"login":"panther2","id":20812775,"avatar_url":"https://avatars3.githubusercontent.com/u/20812775?v=4","gravatar_id":"","url":"https://api.github.com/users/panther2","html_url":"https://github.com/panther2","followers_url":"https://api.github.com/users/panther2/followers","following_url":"https://api.github.com/users/panther2/following{/other_user}","gists_url":"https://api.github.com/users/panther2/gists{/gist_id}","starred_url":"https://api.github.com/users/panther2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panther2/subscriptions","organizations_url":"https://api.github.com/users/panther2/orgs","repos_url":"https://api.github.com/users/panther2/repos","events_url":"https://api.github.com/users/panther2/events{/privacy}","received_events_url":"https://api.github.com/users/panther2/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-09-08T07:32:20Z","updated_at":"2017-09-09T17:58:30Z","closed_at":null,"author_association":"MEMBER","body":"<!--\r\nSave game files at the point of a problem help a lot. You can attach them to github issues by zipping them \r\nup first and then dragging and then dropping them into the github issue using the file attachment links provided by github.\r\n\r\nThe more detailed information you can provide when reporting problems the easier it is for us to pinpoint them. \r\nSometimes we can use exact error messages to search the code base and pinpoint where problems are. \r\nThis leads to faster fixes. The below information and anything more is of great benefit, we \r\nappreciate you reporting problems to the TripleA team\r\n-->\r\n\r\n### My Operating System:\r\n\r\nWin7.64\r\n\r\n### TripleA version:\r\n\r\n1.9.0.0.6507\r\n\r\n### Map:\r\n\r\nwwII_Global_1940\r\nwwII_v5\r\n\r\n### Any additional information that may help:\r\n\r\nThis is a follow-up of #2322 and #2337 .\r\n\r\nAt a first glance, everything seems to run fine now.\r\nNow the engine allows to choose to SBR correctly.\r\n\r\nBut starting (again) from this position \r\n[SBR_StartPosition.zip](https://github.com/triplea-game/triplea/files/1287053/SBR_StartPosition.zip)\r\nyou will realize that the max-damaged air- and naval-bases will not execute AA-fire against the tactical bombers. (Also the bombing itself is skipped, though this would be acceptable as further damage cannot be assigned.)\r\n\r\nAlso in these savegames\r\n\r\n[SBR_StartPositionFactoryFrance.zip](https://github.com/triplea-game/triplea/files/1287059/SBR_StartPositionFactoryFrance.zip)\r\n(Send any German (strat.) bomber to France.)\r\n\r\n[SBR_v5_StartPosition.zip](https://github.com/triplea-game/triplea/files/1287060/SBR_v5_StartPosition.zip)\r\n(Send bomber from Germany to UK.)\r\n\r\nyou will see that max-damaged factories don't fire their built-in AA-guns. (Also the bombing itself is skipped, though this would be acceptable as further damage cannot be assigned.)\r\nThough these two scenarios should not occur as the attacker can only lose planes and gain nothing - but in case they occur - maybe due to carelessness - AA-fire should occur, too.\r\n\r\nWhatever damage does not affect the self-defense antiaircraft ability of the facility.\r\n"},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/328293677","html_url":"https://github.com/triplea-game/triplea/issues/2340#issuecomment-328293677","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/2340","id":328293677,"user":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars0.githubusercontent.com/u/1427689?v=4","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"created_at":"2017-09-09T17:58:30Z","updated_at":"2017-09-09T17:58:30Z","author_association":"OWNER","body":"@panther2 Alright let's try this one more time (sorry for the multiple false starts). I tested that it allows AA and bombing even if there are only max damaged targets."}}
{"actor":{"display_login":"ron-murhammer"}}