{"action":"opened","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1635","repository_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt","labels_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1635/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1635/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/rustfmt/issues/1635/events","html_url":"https://github.com/rust-lang-nursery/rustfmt/issues/1635","id":233721542,"number":1635,"title":"Checkstyle produces invalid xml if rustfmt failed","user":{"login":"ahal","id":273734,"avatar_url":"https://avatars3.githubusercontent.com/u/273734?v=3","gravatar_id":"","url":"https://api.github.com/users/ahal","html_url":"https://github.com/ahal","followers_url":"https://api.github.com/users/ahal/followers","following_url":"https://api.github.com/users/ahal/following{/other_user}","gists_url":"https://api.github.com/users/ahal/gists{/gist_id}","starred_url":"https://api.github.com/users/ahal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahal/subscriptions","organizations_url":"https://api.github.com/users/ahal/orgs","repos_url":"https://api.github.com/users/ahal/repos","events_url":"https://api.github.com/users/ahal/events{/privacy}","received_events_url":"https://api.github.com/users/ahal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-05T21:52:07Z","updated_at":"2017-06-05T21:52:07Z","closed_at":null,"body":"STR\r\nFind a file with a line that's too long:\r\n$ rustfmt --write-mode=checkstyle file.rs\r\n\r\n    ...\r\n    <error line=\"1624\" severity=\"warning\" message=\"Should be `                   .clone())`\" /><error line=\"1633\" severity=\"warning\" message=\"Should be `                   .clone())`\" /><error line=\"1664\" severity=\"warning\" message=\"Should be `            Nullable::Value(ref x) =&gt; Json::Object(try!(x.to_marionette())),`\" /><error line=\"1684\" severity=\"warning\" message=\"Should be `        Ok(try_opt!(self.to_json().as_object(),`\" /><error line=\"1684\" severity=\"warning\" message=\"Should be `                    ErrorStatus::UnknownError,`\" /><error line=\"1684Rustfmt failed at /home/ahal/hg/mozilla-central/testing/geckodriver/src/prefs.rs:114: line exceeded maximum length (maximum: 100, found: 112) (sorry)\r\n    Rustfmt failed at /home/ahal/hg/mozilla-central/testing/geckodriver/src/prefs.rs:115: line exceeded maximum length (maximum: 100, found: 109) (sorry)\r\n    Rustfmt failed at /home/ahal/hg/mozilla-central/testing/geckodriver/src/marionette.rs:540: line exceeded maximum length (maximum: 100, found: 122) (sorry)\r\n    Rustfmt failed at /home/ahal/hg/mozilla-central/testing/geckodriver/src/marionette.rs:658: line exceeded maximum length (maximum: 100, found: 119) (sorry)\r\n    Rustfmt failed at /home/ahal/hg/mozilla-central/testing/geckodriver/src/marionette.rs:1442: line exceeded maximum length (maximum: 100, found: 108) (sorry)\r\n    Rustfmt failed at /home/ahal/hg/mozilla-central/testing/geckodriver/src/capabilities.rs:224: line exceeded maximum length (maximum: 100, found: 122) (sorry)\r\n    Rustfmt failed at /home/ahal/hg/mozilla-central/testing/geckodriver/src/capabilities.rs:229: line exceeded maximum length (maximum: 100, found: 105) (sorry)\r\n    \" severity=\"warning\" message=\"Should be `                    &quot;Expected an object&quot;)`\" /><error line=\"1684\" severity=\"warning\" message=\"Should be `                   .clone())`\" /><error line=\"1696\" severity=\"warning\" message=\"Should be `            FrameId::Element(ref x) =&gt; {`\" /><error line=\"1696\" severity=\"warning\" message=\"Should be `                data.insert(&quot;element&quot;.to_string(), Json::Object(try!(x.to_marionette())))`\" /><error line=\"1696\" severity=\"warning\" message=\"Should be `            }`\" /><error line=\"1696\" severity=\"warning\" message=\"Should be `            FrameId::Null =&gt; None,`\" /></file><file name=\"/home/ahal/hg/mozilla-central/testing/geckodriver/src/prefs.rs\"></file></checkstyle>\r\n\r\n\r\nThe \"Rustfmt failed\" messages seem to get printed right in the middle of the last \"error\" tag, causing the xml parser to fail. Ideally stuff like \"line too long\" would be incorporated into the xml tree, but at the very least would be nice if they got dumped at the end."}}
{"actor":{"display_login":"ahal"}}