{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments/115753461","pull_request_review_id":37318842,"id":115753461,"diff_hunk":"@@ -0,0 +1,228 @@\n+package io.iohk.ethereum.jsonrpc\n+\n+import io.iohk.ethereum.Fixtures\n+import io.iohk.ethereum.db.components.{SharedEphemDataSources, Storages}\n+import io.iohk.ethereum.domain.{Block, BlockchainImpl}\n+import io.iohk.ethereum.jsonrpc.JsonSerializers.{BlockResponseSerializer, QuantitiesSerializer}\n+import io.iohk.ethereum.network.p2p.messages.PV62.BlockBody\n+import org.json4s.{DefaultFormats, Extraction}\n+import org.json4s.JsonAST._\n+import org.scalatest.{Matchers, WordSpec}\n+import org.scalatest.prop.PropertyChecks\n+import org.spongycastle.util.encoders.Hex\n+\n+import scala.concurrent.ExecutionContext.Implicits.global\n+import scala.concurrent.Future\n+import scala.concurrent.Await\n+import scala.concurrent.duration.Duration\n+\n+class EthJsonRpcControllerSpec extends WordSpec with Matchers with PropertyChecks {","path":"src/test/scala/io/iohk/ethereum/jsonrpc/EthJsonRpcControllerSpec.scala","position":19,"original_position":19,"commit_id":"0e20f1eda2e845efbcead0d5ca2071283a4e4961","original_commit_id":"26566a09ca381a5afcaae22433d270182e70747d","user":{"login":"AlanVerbner","id":3750504,"avatar_url":"https://avatars0.githubusercontent.com/u/3750504?v=3","gravatar_id":"","url":"https://api.github.com/users/AlanVerbner","html_url":"https://github.com/AlanVerbner","followers_url":"https://api.github.com/users/AlanVerbner/followers","following_url":"https://api.github.com/users/AlanVerbner/following{/other_user}","gists_url":"https://api.github.com/users/AlanVerbner/gists{/gist_id}","starred_url":"https://api.github.com/users/AlanVerbner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlanVerbner/subscriptions","organizations_url":"https://api.github.com/users/AlanVerbner/orgs","repos_url":"https://api.github.com/users/AlanVerbner/repos","events_url":"https://api.github.com/users/AlanVerbner/events{/privacy}","received_events_url":"https://api.github.com/users/AlanVerbner/received_events","type":"User","site_admin":false},"body":"@rtkaczyk well... there are some optional fields in some responses I would like to test.\r\n\r\nThat being said, as @LukasGasior1 already followed that pattern, let's stick to it and tests corner cases if needed.","created_at":"2017-05-10T14:21:09Z","updated_at":"2017-05-10T14:21:09Z","html_url":"https://github.com/input-output-hk/etc-client/pull/179#discussion_r115753461","pull_request_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments/115753461"},"html":{"href":"https://github.com/input-output-hk/etc-client/pull/179#discussion_r115753461"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/179","id":119757814,"html_url":"https://github.com/input-output-hk/etc-client/pull/179","diff_url":"https://github.com/input-output-hk/etc-client/pull/179.diff","patch_url":"https://github.com/input-output-hk/etc-client/pull/179.patch","issue_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/179","number":179,"state":"open","locked":false,"title":"Added some eth_ methods","user":{"login":"ntallar","id":23455124,"avatar_url":"https://avatars3.githubusercontent.com/u/23455124?v=3","gravatar_id":"","url":"https://api.github.com/users/ntallar","html_url":"https://github.com/ntallar","followers_url":"https://api.github.com/users/ntallar/followers","following_url":"https://api.github.com/users/ntallar/following{/other_user}","gists_url":"https://api.github.com/users/ntallar/gists{/gist_id}","starred_url":"https://api.github.com/users/ntallar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntallar/subscriptions","organizations_url":"https://api.github.com/users/ntallar/orgs","repos_url":"https://api.github.com/users/ntallar/repos","events_url":"https://api.github.com/users/ntallar/events{/privacy}","received_events_url":"https://api.github.com/users/ntallar/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nIncludes the implementation of `eth_getBlockTransactionCountByHash`, `eth_getBlockByHash` and `eth_getUncleByBlockHashAndIndex` JSON RPC methods. Both the transaction and block objects (as described in https://github.com/ethereum/wiki/wiki/JSON-RPC) were implemented, as `TransactionResponse` and `BlockResponse` respectively.","created_at":"2017-05-09T21:27:28Z","updated_at":"2017-05-10T14:21:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c043e62996d2a56b8b26caecc0578b0ae563d736","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/179/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/179/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/179/comments","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/0e20f1eda2e845efbcead0d5ca2071283a4e4961","head":{"label":"input-output-hk:feature/rpcJsonBlockchainMethods","ref":"feature/rpcJsonBlockchainMethods","sha":"0e20f1eda2e845efbcead0d5ca2071283a4e4961","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"name":"etc-client","full_name":"input-output-hk/etc-client","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/etc-client","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/etc-client","forks_url":"https://api.github.com/repos/input-output-hk/etc-client/forks","keys_url":"https://api.github.com/repos/input-output-hk/etc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/etc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/etc-client/teams","hooks_url":"https://api.github.com/repos/input-output-hk/etc-client/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/etc-client/events","assignees_url":"https://api.github.com/repos/input-output-hk/etc-client/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/etc-client/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/etc-client/tags","blobs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/etc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/etc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/etc-client/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/etc-client/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/etc-client/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/etc-client/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/etc-client/subscription","commits_url":"https://api.github.com/repos/input-output-hk/etc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/etc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/etc-client/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/etc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/etc-client/merges","archive_url":"https://api.github.com/repos/input-output-hk/etc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/etc-client/downloads","issues_url":"https://api.github.com/repos/input-output-hk/etc-client/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/etc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/etc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/etc-client/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/etc-client/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/etc-client/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2017-04-25T14:05:03Z","pushed_at":"2017-05-10T14:19:55Z","git_url":"git://github.com/input-output-hk/etc-client.git","ssh_url":"git@github.com:input-output-hk/etc-client.git","clone_url":"https://github.com/input-output-hk/etc-client.git","svn_url":"https://github.com/input-output-hk/etc-client","homepage":null,"size":3880,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":7,"default_branch":"master"}},"base":{"label":"input-output-hk:phase/4/jsonrpc","ref":"phase/4/jsonrpc","sha":"ba2cddfdef4c0d6406aa86fa569bb368b5054431","user":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":76256113,"name":"etc-client","full_name":"input-output-hk/etc-client","owner":{"login":"input-output-hk","id":12909177,"avatar_url":"https://avatars0.githubusercontent.com/u/12909177?v=3","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/etc-client","description":"A Scala based client for Ethereum Classic. ","fork":false,"url":"https://api.github.com/repos/input-output-hk/etc-client","forks_url":"https://api.github.com/repos/input-output-hk/etc-client/forks","keys_url":"https://api.github.com/repos/input-output-hk/etc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/etc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/etc-client/teams","hooks_url":"https://api.github.com/repos/input-output-hk/etc-client/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/etc-client/events","assignees_url":"https://api.github.com/repos/input-output-hk/etc-client/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/etc-client/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/etc-client/tags","blobs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/etc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/etc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/etc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/etc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/etc-client/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/etc-client/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/etc-client/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/etc-client/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/etc-client/subscription","commits_url":"https://api.github.com/repos/input-output-hk/etc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/etc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/etc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/etc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/etc-client/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/etc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/etc-client/merges","archive_url":"https://api.github.com/repos/input-output-hk/etc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/etc-client/downloads","issues_url":"https://api.github.com/repos/input-output-hk/etc-client/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/etc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/etc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/etc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/etc-client/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/etc-client/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/etc-client/deployments","created_at":"2016-12-12T12:51:31Z","updated_at":"2017-04-25T14:05:03Z","pushed_at":"2017-05-10T14:19:55Z","git_url":"git://github.com/input-output-hk/etc-client.git","ssh_url":"git@github.com:input-output-hk/etc-client.git","clone_url":"https://github.com/input-output-hk/etc-client.git","svn_url":"https://github.com/input-output-hk/etc-client","homepage":null,"size":3880,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/179"},"html":{"href":"https://github.com/input-output-hk/etc-client/pull/179"},"issue":{"href":"https://api.github.com/repos/input-output-hk/etc-client/issues/179"},"comments":{"href":"https://api.github.com/repos/input-output-hk/etc-client/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/etc-client/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/etc-client/statuses/0e20f1eda2e845efbcead0d5ca2071283a4e4961"}}}}
{"actor":{"display_login":"AlanVerbner"}}