{"action":"created","issue":{"url":"https://api.github.com/repos/osuosl/streamwebs/issues/516","repository_url":"https://api.github.com/repos/osuosl/streamwebs","labels_url":"https://api.github.com/repos/osuosl/streamwebs/issues/516/labels{/name}","comments_url":"https://api.github.com/repos/osuosl/streamwebs/issues/516/comments","events_url":"https://api.github.com/repos/osuosl/streamwebs/issues/516/events","html_url":"https://github.com/osuosl/streamwebs/pull/516","id":269448126,"number":516,"title":"Escape the site.description for javascript and truncate","user":{"login":"ramereth","id":48997,"avatar_url":"https://avatars0.githubusercontent.com/u/48997?v=4","gravatar_id":"","url":"https://api.github.com/users/ramereth","html_url":"https://github.com/ramereth","followers_url":"https://api.github.com/users/ramereth/followers","following_url":"https://api.github.com/users/ramereth/following{/other_user}","gists_url":"https://api.github.com/users/ramereth/gists{/gist_id}","starred_url":"https://api.github.com/users/ramereth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramereth/subscriptions","organizations_url":"https://api.github.com/users/ramereth/orgs","repos_url":"https://api.github.com/users/ramereth/repos","events_url":"https://api.github.com/users/ramereth/events{/privacy}","received_events_url":"https://api.github.com/users/ramereth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-29T23:32:26Z","updated_at":"2017-10-30T19:42:58Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/osuosl/streamwebs/pulls/516","html_url":"https://github.com/osuosl/streamwebs/pull/516","diff_url":"https://github.com/osuosl/streamwebs/pull/516.diff","patch_url":"https://github.com/osuosl/streamwebs/pull/516.patch"},"body":"fixes #515 \r\n\r\n## Changes in this PR.\r\n- [x] Escape the site.description for javascript\r\n- [x] Truncate description to 50 words on popups\r\n\r\n## Testing this PR.\r\n1. Go to http://localhost:8000/sites/\r\n2. Click on a site\r\n\r\n### Expected Output.\r\nYou should see the map working properly again and when you click on a site, you should see a truncated description of 50 words or less.\r\n\r\n@hertelc I also have this running at http://streamwebs-dev.osuosl.org:8000/ if you want to check yourself.\r\n"},"comment":{"url":"https://api.github.com/repos/osuosl/streamwebs/issues/comments/340561388","html_url":"https://github.com/osuosl/streamwebs/pull/516#issuecomment-340561388","issue_url":"https://api.github.com/repos/osuosl/streamwebs/issues/516","id":340561388,"user":{"login":"hertelc","id":20323475,"avatar_url":"https://avatars2.githubusercontent.com/u/20323475?v=4","gravatar_id":"","url":"https://api.github.com/users/hertelc","html_url":"https://github.com/hertelc","followers_url":"https://api.github.com/users/hertelc/followers","following_url":"https://api.github.com/users/hertelc/following{/other_user}","gists_url":"https://api.github.com/users/hertelc/gists{/gist_id}","starred_url":"https://api.github.com/users/hertelc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hertelc/subscriptions","organizations_url":"https://api.github.com/users/hertelc/orgs","repos_url":"https://api.github.com/users/hertelc/repos","events_url":"https://api.github.com/users/hertelc/events{/privacy}","received_events_url":"https://api.github.com/users/hertelc/received_events","type":"User","site_admin":false},"created_at":"2017-10-30T19:42:58Z","updated_at":"2017-10-30T19:42:58Z","author_association":"COLLABORATOR","body":"Hi Renee,\r\n\r\nThe question is related to the map when searching for a site.\r\n\r\n1)      Old site: when you click on a location icon, you get a pop up with a picture and a clickable link with the name of the site.\r\n\r\n2)      Staging site: When you click on a location icon, you get a pop up with a clickable link to the name of the site and a description (no picture).\r\n\r\nWe weren’t sure why this changed and if it was a request…?\r\n\r\nThanks!\r\nCarrie\r\n\r\nCARRIE HERTEL, PMP, CASS Director – SDG, TL, IoT\r\nOregon State University | EECS/CASS | 541-737-6012\r\ncass.oregonstate.edu\r\n\r\nFrom: rensmere [mailto:notifications@github.com]\r\nSent: Monday, October 30, 2017 12:23 PM\r\nTo: osuosl/streamwebs <streamwebs@noreply.github.com>\r\nCc: Hertel, Carrie Lynn <carrie.hertel@oregonstate.edu>; Mention <mention@noreply.github.com>\r\nSubject: Re: [osuosl/streamwebs] Escape the site.description for javascript and truncate (#516)\r\n\r\nIf this is for me to answer I will need some more context. Thank you!\r\n\r\nRenee\r\n\r\nFrom: Lance Albertson <notifications@github.com<mailto:notifications@github.com>>\r\nReply-To: osuosl/streamwebs <reply@reply.github.com<mailto:reply@reply.github.com>>\r\nDate: Monday, October 30, 2017 at 8:37 AM\r\nTo: osuosl/streamwebs <streamwebs@noreply.github.com<mailto:streamwebs@noreply.github.com>>\r\nCc: \"O'Neill, Renee Anne\" <renee.oneill@oregonstate.edu<mailto:renee.oneill@oregonstate.edu>>, Mention <mention@noreply.github.com<mailto:mention@noreply.github.com>>\r\nSubject: Re: [osuosl/streamwebs] Escape the site.description for javascript and truncate (#516)\r\n\r\n\r\n@hertelc<https://github.com/hertelc> I'm not sure but I can look into it.\r\n\r\n@rensmere<https://github.com/rensmere> do you recall having a discussion regarding adding descriptions but removing images from the site search?\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://github.com/osuosl/streamwebs/pull/516#issuecomment-340483391>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APLZl8c27pq5r1eWJ8eRHWpri7F8NQRZks5sxe0cgaJpZM4QKhq2>.\r\n\r\n\r\n—\r\nYou are receiving this because you were mentioned.\r\nReply to this email directly, view it on GitHub<https://github.com/osuosl/streamwebs/pull/516#issuecomment-340555905>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATYck9Fs7y_1ppvTQbYt0gqCCkUvPB8Bks5sxiH2gaJpZM4QKhq2>.\r\n"}}
{"actor":{"display_login":"hertelc"}}