{"action":"created","comment":{"url":"https://api.github.com/repos/gradle/gradle/pulls/comments/119849364","pull_request_review_id":41767353,"id":119849364,"diff_hunk":"@@ -356,6 +363,44 @@ class OutputEventRendererTest extends OutputSpecification {\n         outputs.stdOut.readLines() == ['info']\n         outputs.stdErr == ''\n     }\n+\n+    def \"executor schedules at fixes rate\"() {\n+        given:\n+        def executor = Mock(ScheduledExecutorService)\n+        renderer.updateNowExecutor = executor\n+\n+        when:\n+        renderer.addConsole(console, true, true, new UnixConsoleMetaData(true, true))\n+\n+        then:\n+        1 * executor.scheduleAtFixedRate(_, _, _, TimeUnit.MILLISECONDS)\n+    }\n+\n+    def \"executor emits update now event when executing\"() {\n+        given:\n+        def listener = new TestOutputEventListener()\n+        renderer.addOutputEventListener(listener)\n+        renderer.addConsole(console, true, true, new UnixConsoleMetaData(true, true))\n+\n+        when:\n+        Thread.sleep(OutputEventRenderer.UPDATE_NOW_FLUSH_INITIAL_DELAY_MS + OutputEventRenderer.UPDATE_NOW_FLUSH_PERIOD_MS + 100)","path":"subprojects/logging/src/test/groovy/org/gradle/internal/logging/sink/OutputEventRendererTest.groovy","position":46,"original_position":46,"commit_id":"7fe936a51bc8662c22bbe4badd598e88466f5b95","original_commit_id":"b7d6cc18c12f1c0c84e24de09e84706e23365fd3","user":{"login":"lacasseio","id":22181740,"avatar_url":"https://avatars1.githubusercontent.com/u/22181740?v=3","gravatar_id":"","url":"https://api.github.com/users/lacasseio","html_url":"https://github.com/lacasseio","followers_url":"https://api.github.com/users/lacasseio/followers","following_url":"https://api.github.com/users/lacasseio/following{/other_user}","gists_url":"https://api.github.com/users/lacasseio/gists{/gist_id}","starred_url":"https://api.github.com/users/lacasseio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lacasseio/subscriptions","organizations_url":"https://api.github.com/users/lacasseio/orgs","repos_url":"https://api.github.com/users/lacasseio/repos","events_url":"https://api.github.com/users/lacasseio/events{/privacy}","received_events_url":"https://api.github.com/users/lacasseio/received_events","type":"User","site_admin":false},"body":"Look at how the tests were done in the other renderer, aka use catch the scheduled runnable and executed it when required as well as using `MockTimeProvider`.","created_at":"2017-06-02T12:57:38Z","updated_at":"2017-06-02T12:57:39Z","html_url":"https://github.com/gradle/gradle/pull/2234#discussion_r119849364","pull_request_url":"https://api.github.com/repos/gradle/gradle/pulls/2234","_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments/119849364"},"html":{"href":"https://github.com/gradle/gradle/pull/2234#discussion_r119849364"},"pull_request":{"href":"https://api.github.com/repos/gradle/gradle/pulls/2234"}}},"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/2234","id":123609746,"html_url":"https://github.com/gradle/gradle/pull/2234","diff_url":"https://github.com/gradle/gradle/pull/2234.diff","patch_url":"https://github.com/gradle/gradle/pull/2234.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/2234","number":2234,"state":"open","locked":false,"title":"Avoid rendering synchronization issues in console","user":{"login":"bmuschko","id":440872,"avatar_url":"https://avatars1.githubusercontent.com/u/440872?v=3","gravatar_id":"","url":"https://api.github.com/users/bmuschko","html_url":"https://github.com/bmuschko","followers_url":"https://api.github.com/users/bmuschko/followers","following_url":"https://api.github.com/users/bmuschko/following{/other_user}","gists_url":"https://api.github.com/users/bmuschko/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuschko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuschko/subscriptions","organizations_url":"https://api.github.com/users/bmuschko/orgs","repos_url":"https://api.github.com/users/bmuschko/repos","events_url":"https://api.github.com/users/bmuschko/events{/privacy}","received_events_url":"https://api.github.com/users/bmuschko/received_events","type":"User","site_admin":false},"body":"### Context\r\n\r\nSee issue https://github.com/gradle/gradle/issues/2210\r\n\r\n[Stage 2 passed](https://builds.gradle.org/viewType.html?buildTypeId=Gradle_Branches_Checkpoints_Stage2LinuxBasicCoverage&branch_Gradle_Branches_Checkpoints=bm%2Fconsole%2Fscheduler-move&tab=buildTypeStatusDiv), kicked off stage 3 and performance tests\r\n\r\n### Gradle Core Team Checklist\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [x] Verify documentation including proper use of `@since` and `@Incubating` annotations for all public APIs\r\n","created_at":"2017-06-01T22:46:08Z","updated_at":"2017-06-02T12:57:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"279af5c15aa84149df5d72e2c887c3a0a89c6e43","assignee":{"login":"bmuschko","id":440872,"avatar_url":"https://avatars1.githubusercontent.com/u/440872?v=3","gravatar_id":"","url":"https://api.github.com/users/bmuschko","html_url":"https://github.com/bmuschko","followers_url":"https://api.github.com/users/bmuschko/followers","following_url":"https://api.github.com/users/bmuschko/following{/other_user}","gists_url":"https://api.github.com/users/bmuschko/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuschko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuschko/subscriptions","organizations_url":"https://api.github.com/users/bmuschko/orgs","repos_url":"https://api.github.com/users/bmuschko/repos","events_url":"https://api.github.com/users/bmuschko/events{/privacy}","received_events_url":"https://api.github.com/users/bmuschko/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmuschko","id":440872,"avatar_url":"https://avatars1.githubusercontent.com/u/440872?v=3","gravatar_id":"","url":"https://api.github.com/users/bmuschko","html_url":"https://github.com/bmuschko","followers_url":"https://api.github.com/users/bmuschko/followers","following_url":"https://api.github.com/users/bmuschko/following{/other_user}","gists_url":"https://api.github.com/users/bmuschko/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuschko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuschko/subscriptions","organizations_url":"https://api.github.com/users/bmuschko/orgs","repos_url":"https://api.github.com/users/bmuschko/repos","events_url":"https://api.github.com/users/bmuschko/events{/privacy}","received_events_url":"https://api.github.com/users/bmuschko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/2234/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/2234/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/2234/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/7fe936a51bc8662c22bbe4badd598e88466f5b95","head":{"label":"gradle:bm/console/scheduler-move","ref":"bm/console/scheduler-move","sha":"7fe936a51bc8662c22bbe4badd598e88466f5b95","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars1.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars1.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2017-06-02T09:57:21Z","pushed_at":"2017-06-02T12:50:42Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":169888,"stargazers_count":4943,"watchers_count":4943,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1761,"mirror_url":null,"open_issues_count":642,"forks":1761,"open_issues":642,"watchers":4943,"default_branch":"master"}},"base":{"label":"gradle:release","ref":"release","sha":"3bf0278266e3315bf5a662bc6ce5f67a528a065e","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars1.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars1.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"Adaptable, fast automation for all","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2017-06-02T09:57:21Z","pushed_at":"2017-06-02T12:50:42Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"https://gradle.org","size":169888,"stargazers_count":4943,"watchers_count":4943,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1761,"mirror_url":null,"open_issues_count":642,"forks":1761,"open_issues":642,"watchers":4943,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/2234"},"html":{"href":"https://github.com/gradle/gradle/pull/2234"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/2234"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/2234/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/2234/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/2234/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/7fe936a51bc8662c22bbe4badd598e88466f5b95"}}}}
{"actor":{"display_login":"lacasseio"}}