{"action":"created","comment":{"url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments/113900617","pull_request_review_id":35327826,"id":113900617,"diff_hunk":"@@ -0,0 +1,124 @@\n+apply plugin: 'checkstyle'\n+apply plugin: 'findbugs'\n+apply plugin: 'pmd'\n+\n+\n+// Add checkstyle, findbugs, pmd and lint to the check task.\n+check.dependsOn 'checkstyle', 'findbugs', 'pmd', 'lint'\n+\n+def configDir = \"${project.rootDir}/config/quality\"\n+def reportsDir = \"${project.buildDir}/reports\"\n+\n+task checkstyle(type: Checkstyle) {\n+    configFile file(\"$configDir/checkstyle/checkstyle.xml\")\n+    configProperties.checkstyleSuppressionsPath = file(\"$configDir/checkstyle/suppressions.xml\").absolutePath\n+    source 'src'\n+    include '**/*.java'\n+    exclude '**/gen/**'\n+    classpath = files()\n+}\n+\n+task findbugs(type: FindBugs) {\n+    ignoreFailures = false\n+    effort = \"max\"\n+    reportLevel = \"high\"\n+    excludeFilter = file(\"$configDir/findbugs/findbugs-filter.xml\")","path":"config/quality.gradle","position":25,"original_position":25,"commit_id":"c822c1ded2c78fa8e1d96dddc1c41861dbb451a5","original_commit_id":"c822c1ded2c78fa8e1d96dddc1c41861dbb451a5","user":{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false},"body":"I have a separte file in that directory where I fileter some findbugs errors. The full path is config/quality/findbugs/findbugs-filter.xml","created_at":"2017-04-28T10:42:35Z","updated_at":"2017-04-28T10:42:35Z","html_url":"https://github.com/ericcornelissen/NervousFish/pull/20#discussion_r113900617","pull_request_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments/113900617"},"html":{"href":"https://github.com/ericcornelissen/NervousFish/pull/20#discussion_r113900617"},"pull_request":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/20","id":117805364,"html_url":"https://github.com/ericcornelissen/NervousFish/pull/20","diff_url":"https://github.com/ericcornelissen/NervousFish/pull/20.diff","patch_url":"https://github.com/ericcornelissen/NervousFish/pull/20.patch","issue_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/20","number":20,"state":"open","locked":false,"title":"Quality tools","user":{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false},"body":"These changes should bolster our programming quality by adding support within gradle for plugins like checkstyle, findbugs, pmd and lint. All have their own customizable rulesets and print their reports in the report directory (within app/build folders).","created_at":"2017-04-26T20:43:04Z","updated_at":"2017-04-28T10:42:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da9fc0435e9aeb2e5cc1ff1e15a418f584c8db9f","assignee":{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false},"assignees":[{"login":"TheBonheurs","id":10722451,"avatar_url":"https://avatars2.githubusercontent.com/u/10722451?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBonheurs","html_url":"https://github.com/TheBonheurs","followers_url":"https://api.github.com/users/TheBonheurs/followers","following_url":"https://api.github.com/users/TheBonheurs/following{/other_user}","gists_url":"https://api.github.com/users/TheBonheurs/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBonheurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBonheurs/subscriptions","organizations_url":"https://api.github.com/users/TheBonheurs/orgs","repos_url":"https://api.github.com/users/TheBonheurs/repos","events_url":"https://api.github.com/users/TheBonheurs/events{/privacy}","received_events_url":"https://api.github.com/users/TheBonheurs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/20/commits","review_comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/20/comments","review_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/20/comments","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/c822c1ded2c78fa8e1d96dddc1c41861dbb451a5","head":{"label":"ericcornelissen:quality-tools","ref":"quality-tools","sha":"c822c1ded2c78fa8e1d96dddc1c41861dbb451a5","user":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"repo":{"id":89348865,"name":"NervousFish","full_name":"ericcornelissen/NervousFish","owner":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericcornelissen/NervousFish","description":"An app for your :iphone: to exchange public-keys in a secure manner.","fork":false,"url":"https://api.github.com/repos/ericcornelissen/NervousFish","forks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/forks","keys_url":"https://api.github.com/repos/ericcornelissen/NervousFish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericcornelissen/NervousFish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericcornelissen/NervousFish/teams","hooks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/hooks","issue_events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/events{/number}","events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/events","assignees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/assignees{/user}","branches_url":"https://api.github.com/repos/ericcornelissen/NervousFish/branches{/branch}","tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/tags","blobs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/{sha}","languages_url":"https://api.github.com/repos/ericcornelissen/NervousFish/languages","stargazers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/stargazers","contributors_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contributors","subscribers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscribers","subscription_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscription","commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contents/{+path}","compare_url":"https://api.github.com/repos/ericcornelissen/NervousFish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericcornelissen/NervousFish/merges","archive_url":"https://api.github.com/repos/ericcornelissen/NervousFish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericcornelissen/NervousFish/downloads","issues_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues{/number}","pulls_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls{/number}","milestones_url":"https://api.github.com/repos/ericcornelissen/NervousFish/milestones{/number}","notifications_url":"https://api.github.com/repos/ericcornelissen/NervousFish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericcornelissen/NervousFish/labels{/name}","releases_url":"https://api.github.com/repos/ericcornelissen/NervousFish/releases{/id}","deployments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/deployments","created_at":"2017-04-25T10:37:48Z","updated_at":"2017-04-26T17:05:50Z","pushed_at":"2017-04-28T08:12:06Z","git_url":"git://github.com/ericcornelissen/NervousFish.git","ssh_url":"git@github.com:ericcornelissen/NervousFish.git","clone_url":"https://github.com/ericcornelissen/NervousFish.git","svn_url":"https://github.com/ericcornelissen/NervousFish","homepage":"","size":160,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":0,"default_branch":"develop"}},"base":{"label":"ericcornelissen:develop","ref":"develop","sha":"7b047dac36744f508b735b9a052f7ebdf2814b8b","user":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"repo":{"id":89348865,"name":"NervousFish","full_name":"ericcornelissen/NervousFish","owner":{"login":"ericcornelissen","id":3742559,"avatar_url":"https://avatars0.githubusercontent.com/u/3742559?v=3","gravatar_id":"","url":"https://api.github.com/users/ericcornelissen","html_url":"https://github.com/ericcornelissen","followers_url":"https://api.github.com/users/ericcornelissen/followers","following_url":"https://api.github.com/users/ericcornelissen/following{/other_user}","gists_url":"https://api.github.com/users/ericcornelissen/gists{/gist_id}","starred_url":"https://api.github.com/users/ericcornelissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericcornelissen/subscriptions","organizations_url":"https://api.github.com/users/ericcornelissen/orgs","repos_url":"https://api.github.com/users/ericcornelissen/repos","events_url":"https://api.github.com/users/ericcornelissen/events{/privacy}","received_events_url":"https://api.github.com/users/ericcornelissen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericcornelissen/NervousFish","description":"An app for your :iphone: to exchange public-keys in a secure manner.","fork":false,"url":"https://api.github.com/repos/ericcornelissen/NervousFish","forks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/forks","keys_url":"https://api.github.com/repos/ericcornelissen/NervousFish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericcornelissen/NervousFish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericcornelissen/NervousFish/teams","hooks_url":"https://api.github.com/repos/ericcornelissen/NervousFish/hooks","issue_events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/events{/number}","events_url":"https://api.github.com/repos/ericcornelissen/NervousFish/events","assignees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/assignees{/user}","branches_url":"https://api.github.com/repos/ericcornelissen/NervousFish/branches{/branch}","tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/tags","blobs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/{sha}","languages_url":"https://api.github.com/repos/ericcornelissen/NervousFish/languages","stargazers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/stargazers","contributors_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contributors","subscribers_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscribers","subscription_url":"https://api.github.com/repos/ericcornelissen/NervousFish/subscription","commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericcornelissen/NervousFish/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericcornelissen/NervousFish/contents/{+path}","compare_url":"https://api.github.com/repos/ericcornelissen/NervousFish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericcornelissen/NervousFish/merges","archive_url":"https://api.github.com/repos/ericcornelissen/NervousFish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericcornelissen/NervousFish/downloads","issues_url":"https://api.github.com/repos/ericcornelissen/NervousFish/issues{/number}","pulls_url":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls{/number}","milestones_url":"https://api.github.com/repos/ericcornelissen/NervousFish/milestones{/number}","notifications_url":"https://api.github.com/repos/ericcornelissen/NervousFish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericcornelissen/NervousFish/labels{/name}","releases_url":"https://api.github.com/repos/ericcornelissen/NervousFish/releases{/id}","deployments_url":"https://api.github.com/repos/ericcornelissen/NervousFish/deployments","created_at":"2017-04-25T10:37:48Z","updated_at":"2017-04-26T17:05:50Z","pushed_at":"2017-04-28T08:12:06Z","git_url":"git://github.com/ericcornelissen/NervousFish.git","ssh_url":"git@github.com:ericcornelissen/NervousFish.git","clone_url":"https://github.com/ericcornelissen/NervousFish.git","svn_url":"https://github.com/ericcornelissen/NervousFish","homepage":"","size":160,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":31,"forks":0,"open_issues":31,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/20"},"html":{"href":"https://github.com/ericcornelissen/NervousFish/pull/20"},"issue":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/20"},"comments":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/ericcornelissen/NervousFish/statuses/c822c1ded2c78fa8e1d96dddc1c41861dbb451a5"}}}}
{"actor":{"display_login":"TheBonheurs"}}