{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/100144336","pull_request_review_id":20841717,"id":100144336,"diff_hunk":"@@ -16,27 +17,28 @@ public DosDevices()\n         Initialize();\n     }\n \n+/*","path":"src/System.IO.Ports/tests/Legacy/SerialPort/DosDevices.cs","position":12,"original_position":12,"commit_id":"62607cac2b2d6d240bf57e6cba735214c81cbcda","original_commit_id":"62607cac2b2d6d240bf57e6cba735214c81cbcda","user":{"login":"JeremyKuhne","id":8184940,"avatar_url":"https://avatars.githubusercontent.com/u/8184940?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false},"body":"Why is this commented out?","created_at":"2017-02-08T19:09:28Z","updated_at":"2017-02-08T19:12:17Z","html_url":"https://github.com/dotnet/corefx/pull/15867#discussion_r100144336","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/15867","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/100144336"},"html":{"href":"https://github.com/dotnet/corefx/pull/15867#discussion_r100144336"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/15867"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/15867","id":104847669,"html_url":"https://github.com/dotnet/corefx/pull/15867","diff_url":"https://github.com/dotnet/corefx/pull/15867.diff","patch_url":"https://github.com/dotnet/corefx/pull/15867.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/15867","number":15867,"state":"open","locked":false,"title":"Migration of some additional legacy port tests","user":{"login":"willdean","id":1306085,"avatar_url":"https://avatars.githubusercontent.com/u/1306085?v=3","gravatar_id":"","url":"https://api.github.com/users/willdean","html_url":"https://github.com/willdean","followers_url":"https://api.github.com/users/willdean/followers","following_url":"https://api.github.com/users/willdean/following{/other_user}","gists_url":"https://api.github.com/users/willdean/gists{/gist_id}","starred_url":"https://api.github.com/users/willdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdean/subscriptions","organizations_url":"https://api.github.com/users/willdean/orgs","repos_url":"https://api.github.com/users/willdean/repos","events_url":"https://api.github.com/users/willdean/events{/privacy}","received_events_url":"https://api.github.com/users/willdean/received_events","type":"User","site_admin":false},"body":"This is not so much a real request for a pull as it is a request for a very basic review of my first PR to this project.  I'd be grateful if, in particular, @JeremyKuhne and @karelz could have a look and let me know if I'm completely on the wrong track here before I do dozens more files like this.\r\n\r\nThere are some clear issues emerging already:\r\n\r\n* There are subtle differences about the way USB serial port adaptors buffer data and handle handshaking which will probably require some test modification to pass - I've got one 'skip' in there at the moment because of this.\r\n* The legacy tests were all run in a `return bool` style, which allowed the test function a chance to robustly close ports before returning, which is vital if one test failure isn't going to bleed all over all the other tests.   Obviously XUnit throws itself out of the middle of a test, which means that I have had to add a lot of `try / finally` blocks to contain that throw while maintaining a similar code layout to the existing code.  In fact, almost every test is going to require the same sort of boilerplate which is rather unattractive.   Another approach would be to hoist the ownership of the various `SerialPort` objects out of the test methods into the test class, and then do some defensive clean-up in the `[Teardown]` methods (or whatever the XUnit equivalent is).    Or there's probably some `IDisposable` wrapper pattern which would be cleaner - I'm not 100% clear why the disposability of SerialPort isn't exploited here - maybe we should just have all `SerialPort` objects in `using` blocks?\r\n\r\nAny preferences here?\r\n\r\nTagging #15752","created_at":"2017-02-06T17:48:00Z","updated_at":"2017-02-08T19:12:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d669fef123322de8340c8a22ac44f2af1761eabc","assignee":{"login":"willdean","id":1306085,"avatar_url":"https://avatars.githubusercontent.com/u/1306085?v=3","gravatar_id":"","url":"https://api.github.com/users/willdean","html_url":"https://github.com/willdean","followers_url":"https://api.github.com/users/willdean/followers","following_url":"https://api.github.com/users/willdean/following{/other_user}","gists_url":"https://api.github.com/users/willdean/gists{/gist_id}","starred_url":"https://api.github.com/users/willdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdean/subscriptions","organizations_url":"https://api.github.com/users/willdean/orgs","repos_url":"https://api.github.com/users/willdean/repos","events_url":"https://api.github.com/users/willdean/events{/privacy}","received_events_url":"https://api.github.com/users/willdean/received_events","type":"User","site_admin":false},"assignees":[{"login":"willdean","id":1306085,"avatar_url":"https://avatars.githubusercontent.com/u/1306085?v=3","gravatar_id":"","url":"https://api.github.com/users/willdean","html_url":"https://github.com/willdean","followers_url":"https://api.github.com/users/willdean/followers","following_url":"https://api.github.com/users/willdean/following{/other_user}","gists_url":"https://api.github.com/users/willdean/gists{/gist_id}","starred_url":"https://api.github.com/users/willdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdean/subscriptions","organizations_url":"https://api.github.com/users/willdean/orgs","repos_url":"https://api.github.com/users/willdean/repos","events_url":"https://api.github.com/users/willdean/events{/privacy}","received_events_url":"https://api.github.com/users/willdean/received_events","type":"User","site_admin":false},{"login":"JeremyKuhne","id":8184940,"avatar_url":"https://avatars.githubusercontent.com/u/8184940?v=3","gravatar_id":"","url":"https://api.github.com/users/JeremyKuhne","html_url":"https://github.com/JeremyKuhne","followers_url":"https://api.github.com/users/JeremyKuhne/followers","following_url":"https://api.github.com/users/JeremyKuhne/following{/other_user}","gists_url":"https://api.github.com/users/JeremyKuhne/gists{/gist_id}","starred_url":"https://api.github.com/users/JeremyKuhne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeremyKuhne/subscriptions","organizations_url":"https://api.github.com/users/JeremyKuhne/orgs","repos_url":"https://api.github.com/users/JeremyKuhne/repos","events_url":"https://api.github.com/users/JeremyKuhne/events{/privacy}","received_events_url":"https://api.github.com/users/JeremyKuhne/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/15867/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/15867/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/15867/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/62607cac2b2d6d240bf57e6cba735214c81cbcda","head":{"label":"willdean:MigrateSerialPortTests","ref":"MigrateSerialPortTests","sha":"62607cac2b2d6d240bf57e6cba735214c81cbcda","user":{"login":"willdean","id":1306085,"avatar_url":"https://avatars.githubusercontent.com/u/1306085?v=3","gravatar_id":"","url":"https://api.github.com/users/willdean","html_url":"https://github.com/willdean","followers_url":"https://api.github.com/users/willdean/followers","following_url":"https://api.github.com/users/willdean/following{/other_user}","gists_url":"https://api.github.com/users/willdean/gists{/gist_id}","starred_url":"https://api.github.com/users/willdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdean/subscriptions","organizations_url":"https://api.github.com/users/willdean/orgs","repos_url":"https://api.github.com/users/willdean/repos","events_url":"https://api.github.com/users/willdean/events{/privacy}","received_events_url":"https://api.github.com/users/willdean/received_events","type":"User","site_admin":false},"repo":{"id":80405454,"name":"corefx","full_name":"willdean/corefx","owner":{"login":"willdean","id":1306085,"avatar_url":"https://avatars.githubusercontent.com/u/1306085?v=3","gravatar_id":"","url":"https://api.github.com/users/willdean","html_url":"https://github.com/willdean","followers_url":"https://api.github.com/users/willdean/followers","following_url":"https://api.github.com/users/willdean/following{/other_user}","gists_url":"https://api.github.com/users/willdean/gists{/gist_id}","starred_url":"https://api.github.com/users/willdean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willdean/subscriptions","organizations_url":"https://api.github.com/users/willdean/orgs","repos_url":"https://api.github.com/users/willdean/repos","events_url":"https://api.github.com/users/willdean/events{/privacy}","received_events_url":"https://api.github.com/users/willdean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willdean/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/willdean/corefx","forks_url":"https://api.github.com/repos/willdean/corefx/forks","keys_url":"https://api.github.com/repos/willdean/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willdean/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willdean/corefx/teams","hooks_url":"https://api.github.com/repos/willdean/corefx/hooks","issue_events_url":"https://api.github.com/repos/willdean/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/willdean/corefx/events","assignees_url":"https://api.github.com/repos/willdean/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/willdean/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/willdean/corefx/tags","blobs_url":"https://api.github.com/repos/willdean/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willdean/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willdean/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/willdean/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willdean/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/willdean/corefx/languages","stargazers_url":"https://api.github.com/repos/willdean/corefx/stargazers","contributors_url":"https://api.github.com/repos/willdean/corefx/contributors","subscribers_url":"https://api.github.com/repos/willdean/corefx/subscribers","subscription_url":"https://api.github.com/repos/willdean/corefx/subscription","commits_url":"https://api.github.com/repos/willdean/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/willdean/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/willdean/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/willdean/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/willdean/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/willdean/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willdean/corefx/merges","archive_url":"https://api.github.com/repos/willdean/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willdean/corefx/downloads","issues_url":"https://api.github.com/repos/willdean/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/willdean/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/willdean/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/willdean/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willdean/corefx/labels{/name}","releases_url":"https://api.github.com/repos/willdean/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/willdean/corefx/deployments","created_at":"2017-01-30T08:45:37Z","updated_at":"2017-01-30T08:46:15Z","pushed_at":"2017-02-08T17:03:07Z","git_url":"git://github.com/willdean/corefx.git","ssh_url":"git@github.com:willdean/corefx.git","clone_url":"https://github.com/willdean/corefx.git","svn_url":"https://github.com/willdean/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":132442,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"2b942aad5c4fae059e80b029a129fd5bb33be243","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-02-08T15:29:12Z","pushed_at":"2017-02-08T19:03:19Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":132637,"stargazers_count":11214,"watchers_count":11214,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2910,"mirror_url":null,"open_issues_count":1389,"forks":2910,"open_issues":1389,"watchers":11214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/15867"},"html":{"href":"https://github.com/dotnet/corefx/pull/15867"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/15867"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/15867/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/15867/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/15867/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/62607cac2b2d6d240bf57e6cba735214c81cbcda"}}}}
{"actor":{"display_login":"JeremyKuhne"}}