{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/comments/136559931","pull_request_review_id":60117012,"id":136559931,"diff_hunk":"@@ -0,0 +1,66 @@\n+import {__} from '../../common/translateFunction';\n+import * as _ from 'lodash';\n+\n+export default class DialogValidationService {\n+  public invalid: any = {};\n+\n+  /** @ngInject */\n+  constructor(private DialogEditor: any) {","path":"src/dialog-editor/services/dialogValidationService.ts","position":8,"original_position":8,"commit_id":"e40af5dec125ab057f863472cbfd1ba4451bd155","original_commit_id":"e40af5dec125ab057f863472cbfd1ba4451bd155","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"body":"Probably too late for such a design change now. But.. using services as a data/state store is quite common in angular world.\r\n\r\n(I guess it's not yet the time to move this to redux, right?)","created_at":"2017-09-01T12:11:04Z","updated_at":"2017-09-01T12:11:04Z","html_url":"https://github.com/ManageIQ/ui-components/pull/137#discussion_r136559931","pull_request_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/137","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/comments/136559931"},"html":{"href":"https://github.com/ManageIQ/ui-components/pull/137#discussion_r136559931"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/137"}},"in_reply_to_id":136380742},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/137","id":138705365,"html_url":"https://github.com/ManageIQ/ui-components/pull/137","diff_url":"https://github.com/ManageIQ/ui-components/pull/137.diff","patch_url":"https://github.com/ManageIQ/ui-components/pull/137.patch","issue_url":"https://api.github.com/repos/ManageIQ/ui-components/issues/137","number":137,"state":"open","locked":false,"title":"Dialog Editor Validations","user":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars3.githubusercontent.com/u/1187051?v=4","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"body":"taking the method from PR https://github.com/ManageIQ/manageiq-ui-classic/pull/2055 as a new service for Dialog validations:\r\n\r\n> \r\n> After these changes, it won't be possible to submit invalid dialog.\r\n> The methods are testing that\r\n> \r\n> - dialog has a name\r\n> - dialog has at least one tab\r\n> - every dialog tab have a name\r\n> - every dialog tab has at least one box\r\n> - every dialog box has a name\r\n> - every dialog box has at least one element\r\n> - every element has a name\r\n> \r\n> if one test fails, the `Save` buttons becomes disabled.\r\n> \r\n> Links\r\n> ----------------\r\n> * https://www.pivotaltracker.com/story/show/144481043\r\n> \r\n> Steps for Testing/QA\r\n> -------------------------------\r\n> \r\n> Automation -> Automate -> Customization -> Edit this / Add a new dialog in the Dialog Editor -> [see the screencast]\r\n> \r\n> ![screencast from 2017-08-30 16-21-22](https://user-images.githubusercontent.com/1187051/29877333-97ef6886-8d9f-11e7-9adf-c05b5a5c5790.gif)\r\n\r\n/cc @skateman @himdel @karelhala ","created_at":"2017-08-31T16:00:49Z","updated_at":"2017-09-01T12:11:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6884f48669a87abe276f71ec55c5a64df232205","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/137/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/137/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/ui-components/issues/137/comments","statuses_url":"https://api.github.com/repos/ManageIQ/ui-components/statuses/e40af5dec125ab057f863472cbfd1ba4451bd155","head":{"label":"romanblanco:dialog_editor_validations","ref":"dialog_editor_validations","sha":"e40af5dec125ab057f863472cbfd1ba4451bd155","user":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars3.githubusercontent.com/u/1187051?v=4","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"repo":{"id":78542629,"name":"ui-components","full_name":"romanblanco/ui-components","owner":{"login":"romanblanco","id":1187051,"avatar_url":"https://avatars3.githubusercontent.com/u/1187051?v=4","gravatar_id":"","url":"https://api.github.com/users/romanblanco","html_url":"https://github.com/romanblanco","followers_url":"https://api.github.com/users/romanblanco/followers","following_url":"https://api.github.com/users/romanblanco/following{/other_user}","gists_url":"https://api.github.com/users/romanblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/romanblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romanblanco/subscriptions","organizations_url":"https://api.github.com/users/romanblanco/orgs","repos_url":"https://api.github.com/users/romanblanco/repos","events_url":"https://api.github.com/users/romanblanco/events{/privacy}","received_events_url":"https://api.github.com/users/romanblanco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/romanblanco/ui-components","description":"Angular UI Components for ManageIQ","fork":true,"url":"https://api.github.com/repos/romanblanco/ui-components","forks_url":"https://api.github.com/repos/romanblanco/ui-components/forks","keys_url":"https://api.github.com/repos/romanblanco/ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romanblanco/ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romanblanco/ui-components/teams","hooks_url":"https://api.github.com/repos/romanblanco/ui-components/hooks","issue_events_url":"https://api.github.com/repos/romanblanco/ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/romanblanco/ui-components/events","assignees_url":"https://api.github.com/repos/romanblanco/ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/romanblanco/ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/romanblanco/ui-components/tags","blobs_url":"https://api.github.com/repos/romanblanco/ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romanblanco/ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romanblanco/ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/romanblanco/ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romanblanco/ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/romanblanco/ui-components/languages","stargazers_url":"https://api.github.com/repos/romanblanco/ui-components/stargazers","contributors_url":"https://api.github.com/repos/romanblanco/ui-components/contributors","subscribers_url":"https://api.github.com/repos/romanblanco/ui-components/subscribers","subscription_url":"https://api.github.com/repos/romanblanco/ui-components/subscription","commits_url":"https://api.github.com/repos/romanblanco/ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/romanblanco/ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/romanblanco/ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/romanblanco/ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/romanblanco/ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/romanblanco/ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romanblanco/ui-components/merges","archive_url":"https://api.github.com/repos/romanblanco/ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romanblanco/ui-components/downloads","issues_url":"https://api.github.com/repos/romanblanco/ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/romanblanco/ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/romanblanco/ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/romanblanco/ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romanblanco/ui-components/labels{/name}","releases_url":"https://api.github.com/repos/romanblanco/ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/romanblanco/ui-components/deployments","created_at":"2017-01-10T14:46:06Z","updated_at":"2017-01-10T14:46:09Z","pushed_at":"2017-09-01T10:54:47Z","git_url":"git://github.com/romanblanco/ui-components.git","ssh_url":"git@github.com:romanblanco/ui-components.git","clone_url":"https://github.com/romanblanco/ui-components.git","svn_url":"https://github.com/romanblanco/ui-components","homepage":"","size":1533,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"594bfe897803ad3fd6f22a68943e5c62ef92c0b3","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":64480586,"name":"ui-components","full_name":"ManageIQ/ui-components","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/ui-components","description":"Angular UI Components for ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/ui-components","forks_url":"https://api.github.com/repos/ManageIQ/ui-components/forks","keys_url":"https://api.github.com/repos/ManageIQ/ui-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/ui-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/ui-components/teams","hooks_url":"https://api.github.com/repos/ManageIQ/ui-components/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/ui-components/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/ui-components/events","assignees_url":"https://api.github.com/repos/ManageIQ/ui-components/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/ui-components/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/ui-components/tags","blobs_url":"https://api.github.com/repos/ManageIQ/ui-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/ui-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/ui-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/ui-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/ui-components/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/ui-components/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/ui-components/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/ui-components/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/ui-components/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/ui-components/subscription","commits_url":"https://api.github.com/repos/ManageIQ/ui-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/ui-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/ui-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/ui-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/ui-components/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/ui-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/ui-components/merges","archive_url":"https://api.github.com/repos/ManageIQ/ui-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/ui-components/downloads","issues_url":"https://api.github.com/repos/ManageIQ/ui-components/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/ui-components/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/ui-components/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/ui-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/ui-components/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/ui-components/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/ui-components/deployments","created_at":"2016-07-29T12:58:19Z","updated_at":"2017-07-27T20:09:27Z","pushed_at":"2017-09-01T11:37:54Z","git_url":"git://github.com/ManageIQ/ui-components.git","ssh_url":"git@github.com:ManageIQ/ui-components.git","clone_url":"https://github.com/ManageIQ/ui-components.git","svn_url":"https://github.com/ManageIQ/ui-components","homepage":"","size":1808,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":15,"forks":24,"open_issues":15,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/137"},"html":{"href":"https://github.com/ManageIQ/ui-components/pull/137"},"issue":{"href":"https://api.github.com/repos/ManageIQ/ui-components/issues/137"},"comments":{"href":"https://api.github.com/repos/ManageIQ/ui-components/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/ui-components/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/ui-components/statuses/e40af5dec125ab057f863472cbfd1ba4451bd155"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"himdel"}}