{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-multicluster-ingress/issues/41","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-multicluster-ingress","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-multicluster-ingress/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-multicluster-ingress/issues/41/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-multicluster-ingress/issues/41/events","html_url":"https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/41","id":270170206,"number":41,"title":"Add a few more usability flags and checks","user":{"login":"csbell","id":23373339,"avatar_url":"https://avatars1.githubusercontent.com/u/23373339?v=4","gravatar_id":"","url":"https://api.github.com/users/csbell","html_url":"https://github.com/csbell","followers_url":"https://api.github.com/users/csbell/followers","following_url":"https://api.github.com/users/csbell/following{/other_user}","gists_url":"https://api.github.com/users/csbell/gists{/gist_id}","starred_url":"https://api.github.com/users/csbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csbell/subscriptions","organizations_url":"https://api.github.com/users/csbell/orgs","repos_url":"https://api.github.com/users/csbell/repos","events_url":"https://api.github.com/users/csbell/events{/privacy}","received_events_url":"https://api.github.com/users/csbell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-11-01T01:55:52Z","updated_at":"2017-11-07T17:24:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-multicluster-ingress/pulls/41","html_url":"https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/41","diff_url":"https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/41.diff","patch_url":"https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/41.patch"},"body":"* -n or --namespace in create/delete\r\n* --static-ip in create\r\n\r\nAlso, error out if user forgets to provide a static ip (either by flag or in their spec).\r\n\r\nAddresses #33 and #19 \r\n\r\n@nikhiljindal @madhusudancs @perotinus\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/googlecloudplatform/k8s-multicluster-ingress/41)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-multicluster-ingress/issues/comments/342557664","html_url":"https://github.com/GoogleCloudPlatform/k8s-multicluster-ingress/pull/41#issuecomment-342557664","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/k8s-multicluster-ingress/issues/41","id":342557664,"user":{"login":"G-Harmon","id":32075130,"avatar_url":"https://avatars2.githubusercontent.com/u/32075130?v=4","gravatar_id":"","url":"https://api.github.com/users/G-Harmon","html_url":"https://github.com/G-Harmon","followers_url":"https://api.github.com/users/G-Harmon/followers","following_url":"https://api.github.com/users/G-Harmon/following{/other_user}","gists_url":"https://api.github.com/users/G-Harmon/gists{/gist_id}","starred_url":"https://api.github.com/users/G-Harmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G-Harmon/subscriptions","organizations_url":"https://api.github.com/users/G-Harmon/orgs","repos_url":"https://api.github.com/users/G-Harmon/repos","events_url":"https://api.github.com/users/G-Harmon/events{/privacy}","received_events_url":"https://api.github.com/users/G-Harmon/received_events","type":"User","site_admin":false},"created_at":"2017-11-07T17:24:46Z","updated_at":"2017-11-07T17:24:46Z","author_association":"COLLABORATOR","body":"\n\n\n\nReviewed 4 of 4 files at r2.\nReview status: 2 of 4 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[app/kubemci/cmd/create.go, line 90 at r3](https://reviewable.io:443/reviews/googlecloudplatform/k8s-multicluster-ingress/41#-KyMVQVDowpGPxo91P0H:-KyMVQVDowpGPxo91P0I:b-txv7pw) ([raw file](https://github.com/googlecloudplatform/k8s-multicluster-ingress/blob/c4a8370c113565753574f3469c5e9629517be743/app/kubemci/cmd/create.go#L90)):*\n> ```Go\n> \t// value, then 'force' is a no-op.\n> \tForceUpdate bool\n> \t// Name of the namespace for the ingress when none is provided (mismatch of option with spec causes an error).\n> ```\n\nIs it worth mentioning a namespace from the context? (I forget if that worked at all or not)\n\n---\n\n*[app/kubemci/cmd/create_test.go, line 131 at r2](https://reviewable.io:443/reviews/googlecloudplatform/k8s-multicluster-ingress/41#-KyMV0mjlvcXw9_EY5Ab:-KyMV0mjlvcXw9_EY5Ac:bf48naa) ([raw file](https://github.com/googlecloudplatform/k8s-multicluster-ingress/blob/2c1f3469a71bdf885e32b7a8cac5a082f5689c22/app/kubemci/cmd/create_test.go#L131)):*\n> ```Go\n> \trunFn := func() ([]string, map[string]kubeclient.Interface, error) {\n> \t\tvar ing v1beta1.Ingress\n> \t\tif err := unmarshallAndApplyDefaults(\"../../../testdata/ingress.yaml\", \"\", &ing); err != nil {\n> ```\n\nshould we have some new test exercising namespace and static-ip?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/googlecloudplatform/k8s-multicluster-ingress/41)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"G-Harmon"}}