{"action":"created","comment":{"url":"https://api.github.com/repos/dedis/onet/pulls/comments/136761749","pull_request_review_id":60344016,"id":136761749,"diff_hunk":"@@ -368,10 +378,16 @@ func (n *TreeNodeInstance) DispatchChannel(msgSlice []*ProtocolMsg) error {\n \t\treflect.ValueOf(n.channels[mt]).Send(out)\n \t} else {\n \t\tfor _, msg := range msgSlice {\n-\t\t\tout := n.channels[mt]\n+\t\t\tout := reflect.ValueOf(n.channels[mt])\n \t\t\tm := n.reflectCreate(to.Elem(), msg)\n \t\t\tlog.Lvl4(n.Name(), \"Dispatching msg type\", mt, \" to\", to, \" :\", m.Field(1).Interface())\n-\t\t\treflect.ValueOf(out).Send(m)\n+\t\t\tif out.Len() < out.Cap() {\n+\t\t\t\tout.Send(m)\n+\t\t\t} else {\n+\t\t\t\treturn fmt.Errorf(\"channel too small for msg %s in %s: \"+","path":"treenode.go","position":73,"original_position":73,"commit_id":"b0470b71dc65201796475b5b12a77cf025686cbd","original_commit_id":"b0470b71dc65201796475b5b12a77cf025686cbd","user":{"login":"ineiti","id":1545067,"avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false},"body":"that would mean that a rogue node could panic other nodes... I prefer not to panic there. Ideally it should stop the protocol, but I did not implement that.","created_at":"2017-09-04T07:49:53Z","updated_at":"2017-09-04T07:49:53Z","html_url":"https://github.com/dedis/onet/pull/223#discussion_r136761749","pull_request_url":"https://api.github.com/repos/dedis/onet/pulls/223","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dedis/onet/pulls/comments/136761749"},"html":{"href":"https://github.com/dedis/onet/pull/223#discussion_r136761749"},"pull_request":{"href":"https://api.github.com/repos/dedis/onet/pulls/223"}},"in_reply_to_id":136649419},"pull_request":{"url":"https://api.github.com/repos/dedis/onet/pulls/223","id":138943362,"html_url":"https://github.com/dedis/onet/pull/223","diff_url":"https://github.com/dedis/onet/pull/223.diff","patch_url":"https://github.com/dedis/onet/pull/223.patch","issue_url":"https://api.github.com/repos/dedis/onet/issues/223","number":223,"state":"open","locked":false,"title":"fail if receiving-channel is full","user":{"login":"ineiti","id":1545067,"avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false},"body":"Closes #219 ","created_at":"2017-09-01T17:59:41Z","updated_at":"2017-09-04T07:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e5f162cee0d6c6d389b217307fdc6158a02500","assignee":{"login":"ineiti","id":1545067,"avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false},"assignees":[{"login":"ineiti","id":1545067,"avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dedis/onet/pulls/223/commits","review_comments_url":"https://api.github.com/repos/dedis/onet/pulls/223/comments","review_comment_url":"https://api.github.com/repos/dedis/onet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dedis/onet/issues/223/comments","statuses_url":"https://api.github.com/repos/dedis/onet/statuses/b0470b71dc65201796475b5b12a77cf025686cbd","head":{"label":"dedis:channel_block_219","ref":"channel_block_219","sha":"b0470b71dc65201796475b5b12a77cf025686cbd","user":{"login":"dedis","id":3638331,"avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"repo":{"id":76370943,"name":"onet","full_name":"dedis/onet","owner":{"login":"dedis","id":3638331,"avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dedis/onet","description":"Cothority network library","fork":false,"url":"https://api.github.com/repos/dedis/onet","forks_url":"https://api.github.com/repos/dedis/onet/forks","keys_url":"https://api.github.com/repos/dedis/onet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedis/onet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedis/onet/teams","hooks_url":"https://api.github.com/repos/dedis/onet/hooks","issue_events_url":"https://api.github.com/repos/dedis/onet/issues/events{/number}","events_url":"https://api.github.com/repos/dedis/onet/events","assignees_url":"https://api.github.com/repos/dedis/onet/assignees{/user}","branches_url":"https://api.github.com/repos/dedis/onet/branches{/branch}","tags_url":"https://api.github.com/repos/dedis/onet/tags","blobs_url":"https://api.github.com/repos/dedis/onet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedis/onet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedis/onet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedis/onet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedis/onet/statuses/{sha}","languages_url":"https://api.github.com/repos/dedis/onet/languages","stargazers_url":"https://api.github.com/repos/dedis/onet/stargazers","contributors_url":"https://api.github.com/repos/dedis/onet/contributors","subscribers_url":"https://api.github.com/repos/dedis/onet/subscribers","subscription_url":"https://api.github.com/repos/dedis/onet/subscription","commits_url":"https://api.github.com/repos/dedis/onet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedis/onet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedis/onet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedis/onet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedis/onet/contents/{+path}","compare_url":"https://api.github.com/repos/dedis/onet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedis/onet/merges","archive_url":"https://api.github.com/repos/dedis/onet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedis/onet/downloads","issues_url":"https://api.github.com/repos/dedis/onet/issues{/number}","pulls_url":"https://api.github.com/repos/dedis/onet/pulls{/number}","milestones_url":"https://api.github.com/repos/dedis/onet/milestones{/number}","notifications_url":"https://api.github.com/repos/dedis/onet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedis/onet/labels{/name}","releases_url":"https://api.github.com/repos/dedis/onet/releases{/id}","deployments_url":"https://api.github.com/repos/dedis/onet/deployments","created_at":"2016-12-13T15:22:47Z","updated_at":"2017-05-22T08:16:46Z","pushed_at":"2017-09-01T17:59:42Z","git_url":"git://github.com/dedis/onet.git","ssh_url":"git@github.com:dedis/onet.git","clone_url":"https://github.com/dedis/onet.git","svn_url":"https://github.com/dedis/onet","homepage":"","size":616,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":28,"forks":5,"open_issues":28,"watchers":2,"default_branch":"master"}},"base":{"label":"dedis:v1.0","ref":"v1.0","sha":"a6aab2672a16f66097a16325b62af203bc5369e0","user":{"login":"dedis","id":3638331,"avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"repo":{"id":76370943,"name":"onet","full_name":"dedis/onet","owner":{"login":"dedis","id":3638331,"avatar_url":"https://avatars2.githubusercontent.com/u/3638331?v=4","gravatar_id":"","url":"https://api.github.com/users/dedis","html_url":"https://github.com/dedis","followers_url":"https://api.github.com/users/dedis/followers","following_url":"https://api.github.com/users/dedis/following{/other_user}","gists_url":"https://api.github.com/users/dedis/gists{/gist_id}","starred_url":"https://api.github.com/users/dedis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedis/subscriptions","organizations_url":"https://api.github.com/users/dedis/orgs","repos_url":"https://api.github.com/users/dedis/repos","events_url":"https://api.github.com/users/dedis/events{/privacy}","received_events_url":"https://api.github.com/users/dedis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dedis/onet","description":"Cothority network library","fork":false,"url":"https://api.github.com/repos/dedis/onet","forks_url":"https://api.github.com/repos/dedis/onet/forks","keys_url":"https://api.github.com/repos/dedis/onet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedis/onet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedis/onet/teams","hooks_url":"https://api.github.com/repos/dedis/onet/hooks","issue_events_url":"https://api.github.com/repos/dedis/onet/issues/events{/number}","events_url":"https://api.github.com/repos/dedis/onet/events","assignees_url":"https://api.github.com/repos/dedis/onet/assignees{/user}","branches_url":"https://api.github.com/repos/dedis/onet/branches{/branch}","tags_url":"https://api.github.com/repos/dedis/onet/tags","blobs_url":"https://api.github.com/repos/dedis/onet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedis/onet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedis/onet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedis/onet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedis/onet/statuses/{sha}","languages_url":"https://api.github.com/repos/dedis/onet/languages","stargazers_url":"https://api.github.com/repos/dedis/onet/stargazers","contributors_url":"https://api.github.com/repos/dedis/onet/contributors","subscribers_url":"https://api.github.com/repos/dedis/onet/subscribers","subscription_url":"https://api.github.com/repos/dedis/onet/subscription","commits_url":"https://api.github.com/repos/dedis/onet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedis/onet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedis/onet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedis/onet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedis/onet/contents/{+path}","compare_url":"https://api.github.com/repos/dedis/onet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedis/onet/merges","archive_url":"https://api.github.com/repos/dedis/onet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedis/onet/downloads","issues_url":"https://api.github.com/repos/dedis/onet/issues{/number}","pulls_url":"https://api.github.com/repos/dedis/onet/pulls{/number}","milestones_url":"https://api.github.com/repos/dedis/onet/milestones{/number}","notifications_url":"https://api.github.com/repos/dedis/onet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedis/onet/labels{/name}","releases_url":"https://api.github.com/repos/dedis/onet/releases{/id}","deployments_url":"https://api.github.com/repos/dedis/onet/deployments","created_at":"2016-12-13T15:22:47Z","updated_at":"2017-05-22T08:16:46Z","pushed_at":"2017-09-01T17:59:42Z","git_url":"git://github.com/dedis/onet.git","ssh_url":"git@github.com:dedis/onet.git","clone_url":"https://github.com/dedis/onet.git","svn_url":"https://github.com/dedis/onet","homepage":"","size":616,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":28,"forks":5,"open_issues":28,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dedis/onet/pulls/223"},"html":{"href":"https://github.com/dedis/onet/pull/223"},"issue":{"href":"https://api.github.com/repos/dedis/onet/issues/223"},"comments":{"href":"https://api.github.com/repos/dedis/onet/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/dedis/onet/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/dedis/onet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dedis/onet/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/dedis/onet/statuses/b0470b71dc65201796475b5b12a77cf025686cbd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ineiti"}}