{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/138252330","pull_request_review_id":62020912,"id":138252330,"diff_hunk":"@@ -104,14 +103,13 @@ def _init(self):\n             self.file_writer = None\n         self.saver = tf.train.Saver(max_to_keep=None)\n \n-    def train(self):\n+    def _train(self):\n         agents = self.agents\n         config = self.config\n         model = self.model\n-        j = self.j\n-        self.j += 1\n+        j = self.iteration","path":"python/ray/rllib/ppo/ppo.py","position":19,"original_position":19,"commit_id":"8fe0f974bd6fb1270359846c8d88b48a7c17194a","original_commit_id":"8fe0f974bd6fb1270359846c8d88b48a7c17194a","user":{"login":"pcmoritz","id":113316,"avatar_url":"https://avatars1.githubusercontent.com/u/113316?v=4","gravatar_id":"","url":"https://api.github.com/users/pcmoritz","html_url":"https://github.com/pcmoritz","followers_url":"https://api.github.com/users/pcmoritz/followers","following_url":"https://api.github.com/users/pcmoritz/following{/other_user}","gists_url":"https://api.github.com/users/pcmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/pcmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcmoritz/subscriptions","organizations_url":"https://api.github.com/users/pcmoritz/orgs","repos_url":"https://api.github.com/users/pcmoritz/repos","events_url":"https://api.github.com/users/pcmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/pcmoritz/received_events","type":"User","site_admin":false},"body":"want to get rid of \"j\" and replace with self.iteration? It was names that since it used to be a loop counter, but now \"iteration\" makes a whole lot more sense...","created_at":"2017-09-12T05:07:17Z","updated_at":"2017-09-12T05:07:17Z","html_url":"https://github.com/ray-project/ray/pull/965#discussion_r138252330","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/965","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/138252330"},"html":{"href":"https://github.com/ray-project/ray/pull/965#discussion_r138252330"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/965"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/965","id":140487653,"html_url":"https://github.com/ray-project/ray/pull/965","diff_url":"https://github.com/ray-project/ray/pull/965.diff","patch_url":"https://github.com/ray-project/ray/pull/965.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/965","number":965,"state":"open","locked":false,"title":"[rllib] Make sure to always record stats like time elapsed, timesteps","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-12T04:48:17Z","updated_at":"2017-09-12T05:07:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"816bf6b765a0e3a48dc20e9f461a06b6b4a62d08","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/965/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/965/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/965/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/8fe0f974bd6fb1270359846c8d88b48a7c17194a","head":{"label":"ericl:stats","ref":"stats","sha":"8fe0f974bd6fb1270359846c8d88b48a7c17194a","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"repo":{"id":91077004,"name":"ray","full_name":"ericl/ray","owner":{"login":"ericl","id":14922,"avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericl/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/ericl/ray","forks_url":"https://api.github.com/repos/ericl/ray/forks","keys_url":"https://api.github.com/repos/ericl/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericl/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericl/ray/teams","hooks_url":"https://api.github.com/repos/ericl/ray/hooks","issue_events_url":"https://api.github.com/repos/ericl/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ericl/ray/events","assignees_url":"https://api.github.com/repos/ericl/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ericl/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ericl/ray/tags","blobs_url":"https://api.github.com/repos/ericl/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericl/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericl/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericl/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericl/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ericl/ray/languages","stargazers_url":"https://api.github.com/repos/ericl/ray/stargazers","contributors_url":"https://api.github.com/repos/ericl/ray/contributors","subscribers_url":"https://api.github.com/repos/ericl/ray/subscribers","subscription_url":"https://api.github.com/repos/ericl/ray/subscription","commits_url":"https://api.github.com/repos/ericl/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericl/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericl/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericl/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericl/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ericl/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericl/ray/merges","archive_url":"https://api.github.com/repos/ericl/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericl/ray/downloads","issues_url":"https://api.github.com/repos/ericl/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ericl/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ericl/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ericl/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericl/ray/labels{/name}","releases_url":"https://api.github.com/repos/ericl/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ericl/ray/deployments","created_at":"2017-05-12T09:51:04Z","updated_at":"2017-05-12T09:51:06Z","pushed_at":"2017-09-12T04:47:23Z","git_url":"git://github.com/ericl/ray.git","ssh_url":"git@github.com:ericl/ray.git","clone_url":"https://github.com/ericl/ray.git","svn_url":"https://github.com/ericl/ray","homepage":"","size":5859,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"e17412a72b629d217c9f62ffff3cac5a28e7b904","user":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2017-09-11T11:28:07Z","pushed_at":"2017-09-12T04:48:18Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":5624,"stargazers_count":485,"watchers_count":485,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":151,"forks":108,"open_issues":151,"watchers":485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/965"},"html":{"href":"https://github.com/ray-project/ray/pull/965"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/965"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/965/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/965/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/965/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/8fe0f974bd6fb1270359846c8d88b48a7c17194a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pcmoritz"}}