{"action":"created","comment":{"url":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/comments/148958177","pull_request_review_id":74282248,"id":148958177,"diff_hunk":"@@ -15,11 +16,14 @@ def initialize(\n     app.config.from_object(settings)\n \n     if class_views is not None:\n-        # TODO:\n-        # - Run some verifications that class_views is formatted\n-        #   ('<SOME ROUTE>', ClassInheritedFromHTTPMethodView)\n         for route, view in class_views:\n-            sanic_jwt_auth_bp.add_route(view.as_view(), route)\n+            try:\n+                if issubclass(view, HTTPMethodView) and isinstance(route, str):\n+                    sanic_jwt_auth_bp.add_route(view.as_view(), route)\n+                else:\n+                    raise Exception(\"class_views should follow this format ('<SOME ROUTE>', ClassInheritedFromHTTPMethodView)\")","path":"sanic_jwt/__init__.py","position":21,"original_position":21,"commit_id":"5b957a9104506d0af7c906e4484f4adf9e1eec8e","original_commit_id":"5b957a9104506d0af7c906e4484f4adf9e1eec8e","user":{"login":"stefanm8","id":19982018,"avatar_url":"https://avatars1.githubusercontent.com/u/19982018?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanm8","html_url":"https://github.com/stefanm8","followers_url":"https://api.github.com/users/stefanm8/followers","following_url":"https://api.github.com/users/stefanm8/following{/other_user}","gists_url":"https://api.github.com/users/stefanm8/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanm8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanm8/subscriptions","organizations_url":"https://api.github.com/users/stefanm8/orgs","repos_url":"https://api.github.com/users/stefanm8/repos","events_url":"https://api.github.com/users/stefanm8/events{/privacy}","received_events_url":"https://api.github.com/users/stefanm8/received_events","type":"User","site_admin":false},"body":"Thank you for feedback I will come back with a patch","created_at":"2017-11-05T14:06:07Z","updated_at":"2017-11-05T14:06:07Z","html_url":"https://github.com/ahopkins/sanic-jwt/pull/17#discussion_r148958177","pull_request_url":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/comments/148958177"},"html":{"href":"https://github.com/ahopkins/sanic-jwt/pull/17#discussion_r148958177"},"pull_request":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/17"}},"in_reply_to_id":148954690},"pull_request":{"url":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/17","id":150645319,"html_url":"https://github.com/ahopkins/sanic-jwt/pull/17","diff_url":"https://github.com/ahopkins/sanic-jwt/pull/17.diff","patch_url":"https://github.com/ahopkins/sanic-jwt/pull/17.patch","issue_url":"https://api.github.com/repos/ahopkins/sanic-jwt/issues/17","number":17,"state":"open","locked":false,"title":"Added class_views validation","user":{"login":"stefanm8","id":19982018,"avatar_url":"https://avatars1.githubusercontent.com/u/19982018?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanm8","html_url":"https://github.com/stefanm8","followers_url":"https://api.github.com/users/stefanm8/followers","following_url":"https://api.github.com/users/stefanm8/following{/other_user}","gists_url":"https://api.github.com/users/stefanm8/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanm8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanm8/subscriptions","organizations_url":"https://api.github.com/users/stefanm8/orgs","repos_url":"https://api.github.com/users/stefanm8/repos","events_url":"https://api.github.com/users/stefanm8/events{/privacy}","received_events_url":"https://api.github.com/users/stefanm8/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-03T23:02:12Z","updated_at":"2017-11-05T14:06:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d8973a87d00ed54f9d1f2509e2874bbd168db18","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/17/commits","review_comments_url":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/17/comments","review_comment_url":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ahopkins/sanic-jwt/issues/17/comments","statuses_url":"https://api.github.com/repos/ahopkins/sanic-jwt/statuses/5b957a9104506d0af7c906e4484f4adf9e1eec8e","head":{"label":"stefanm8:master","ref":"master","sha":"5b957a9104506d0af7c906e4484f4adf9e1eec8e","user":{"login":"stefanm8","id":19982018,"avatar_url":"https://avatars1.githubusercontent.com/u/19982018?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanm8","html_url":"https://github.com/stefanm8","followers_url":"https://api.github.com/users/stefanm8/followers","following_url":"https://api.github.com/users/stefanm8/following{/other_user}","gists_url":"https://api.github.com/users/stefanm8/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanm8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanm8/subscriptions","organizations_url":"https://api.github.com/users/stefanm8/orgs","repos_url":"https://api.github.com/users/stefanm8/repos","events_url":"https://api.github.com/users/stefanm8/events{/privacy}","received_events_url":"https://api.github.com/users/stefanm8/received_events","type":"User","site_admin":false},"repo":{"id":107538163,"name":"sanic-jwt","full_name":"stefanm8/sanic-jwt","owner":{"login":"stefanm8","id":19982018,"avatar_url":"https://avatars1.githubusercontent.com/u/19982018?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanm8","html_url":"https://github.com/stefanm8","followers_url":"https://api.github.com/users/stefanm8/followers","following_url":"https://api.github.com/users/stefanm8/following{/other_user}","gists_url":"https://api.github.com/users/stefanm8/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanm8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanm8/subscriptions","organizations_url":"https://api.github.com/users/stefanm8/orgs","repos_url":"https://api.github.com/users/stefanm8/repos","events_url":"https://api.github.com/users/stefanm8/events{/privacy}","received_events_url":"https://api.github.com/users/stefanm8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanm8/sanic-jwt","description":"JWT endpoints for Sanic","fork":true,"url":"https://api.github.com/repos/stefanm8/sanic-jwt","forks_url":"https://api.github.com/repos/stefanm8/sanic-jwt/forks","keys_url":"https://api.github.com/repos/stefanm8/sanic-jwt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanm8/sanic-jwt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanm8/sanic-jwt/teams","hooks_url":"https://api.github.com/repos/stefanm8/sanic-jwt/hooks","issue_events_url":"https://api.github.com/repos/stefanm8/sanic-jwt/issues/events{/number}","events_url":"https://api.github.com/repos/stefanm8/sanic-jwt/events","assignees_url":"https://api.github.com/repos/stefanm8/sanic-jwt/assignees{/user}","branches_url":"https://api.github.com/repos/stefanm8/sanic-jwt/branches{/branch}","tags_url":"https://api.github.com/repos/stefanm8/sanic-jwt/tags","blobs_url":"https://api.github.com/repos/stefanm8/sanic-jwt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanm8/sanic-jwt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanm8/sanic-jwt/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanm8/sanic-jwt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanm8/sanic-jwt/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanm8/sanic-jwt/languages","stargazers_url":"https://api.github.com/repos/stefanm8/sanic-jwt/stargazers","contributors_url":"https://api.github.com/repos/stefanm8/sanic-jwt/contributors","subscribers_url":"https://api.github.com/repos/stefanm8/sanic-jwt/subscribers","subscription_url":"https://api.github.com/repos/stefanm8/sanic-jwt/subscription","commits_url":"https://api.github.com/repos/stefanm8/sanic-jwt/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanm8/sanic-jwt/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanm8/sanic-jwt/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanm8/sanic-jwt/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanm8/sanic-jwt/contents/{+path}","compare_url":"https://api.github.com/repos/stefanm8/sanic-jwt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanm8/sanic-jwt/merges","archive_url":"https://api.github.com/repos/stefanm8/sanic-jwt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanm8/sanic-jwt/downloads","issues_url":"https://api.github.com/repos/stefanm8/sanic-jwt/issues{/number}","pulls_url":"https://api.github.com/repos/stefanm8/sanic-jwt/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanm8/sanic-jwt/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanm8/sanic-jwt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanm8/sanic-jwt/labels{/name}","releases_url":"https://api.github.com/repos/stefanm8/sanic-jwt/releases{/id}","deployments_url":"https://api.github.com/repos/stefanm8/sanic-jwt/deployments","created_at":"2017-10-19T11:36:16Z","updated_at":"2017-10-19T11:36:18Z","pushed_at":"2017-11-03T22:57:51Z","git_url":"git://github.com/stefanm8/sanic-jwt.git","ssh_url":"git@github.com:stefanm8/sanic-jwt.git","clone_url":"https://github.com/stefanm8/sanic-jwt.git","svn_url":"https://github.com/stefanm8/sanic-jwt","homepage":"","size":47,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ahopkins:master","ref":"master","sha":"3859508b780c717c8a4bce017544f2eecf379682","user":{"login":"ahopkins","id":166269,"avatar_url":"https://avatars1.githubusercontent.com/u/166269?v=4","gravatar_id":"","url":"https://api.github.com/users/ahopkins","html_url":"https://github.com/ahopkins","followers_url":"https://api.github.com/users/ahopkins/followers","following_url":"https://api.github.com/users/ahopkins/following{/other_user}","gists_url":"https://api.github.com/users/ahopkins/gists{/gist_id}","starred_url":"https://api.github.com/users/ahopkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahopkins/subscriptions","organizations_url":"https://api.github.com/users/ahopkins/orgs","repos_url":"https://api.github.com/users/ahopkins/repos","events_url":"https://api.github.com/users/ahopkins/events{/privacy}","received_events_url":"https://api.github.com/users/ahopkins/received_events","type":"User","site_admin":false},"repo":{"id":99481053,"name":"sanic-jwt","full_name":"ahopkins/sanic-jwt","owner":{"login":"ahopkins","id":166269,"avatar_url":"https://avatars1.githubusercontent.com/u/166269?v=4","gravatar_id":"","url":"https://api.github.com/users/ahopkins","html_url":"https://github.com/ahopkins","followers_url":"https://api.github.com/users/ahopkins/followers","following_url":"https://api.github.com/users/ahopkins/following{/other_user}","gists_url":"https://api.github.com/users/ahopkins/gists{/gist_id}","starred_url":"https://api.github.com/users/ahopkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahopkins/subscriptions","organizations_url":"https://api.github.com/users/ahopkins/orgs","repos_url":"https://api.github.com/users/ahopkins/repos","events_url":"https://api.github.com/users/ahopkins/events{/privacy}","received_events_url":"https://api.github.com/users/ahopkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahopkins/sanic-jwt","description":"JWT endpoints for Sanic","fork":false,"url":"https://api.github.com/repos/ahopkins/sanic-jwt","forks_url":"https://api.github.com/repos/ahopkins/sanic-jwt/forks","keys_url":"https://api.github.com/repos/ahopkins/sanic-jwt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahopkins/sanic-jwt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahopkins/sanic-jwt/teams","hooks_url":"https://api.github.com/repos/ahopkins/sanic-jwt/hooks","issue_events_url":"https://api.github.com/repos/ahopkins/sanic-jwt/issues/events{/number}","events_url":"https://api.github.com/repos/ahopkins/sanic-jwt/events","assignees_url":"https://api.github.com/repos/ahopkins/sanic-jwt/assignees{/user}","branches_url":"https://api.github.com/repos/ahopkins/sanic-jwt/branches{/branch}","tags_url":"https://api.github.com/repos/ahopkins/sanic-jwt/tags","blobs_url":"https://api.github.com/repos/ahopkins/sanic-jwt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahopkins/sanic-jwt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahopkins/sanic-jwt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahopkins/sanic-jwt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahopkins/sanic-jwt/statuses/{sha}","languages_url":"https://api.github.com/repos/ahopkins/sanic-jwt/languages","stargazers_url":"https://api.github.com/repos/ahopkins/sanic-jwt/stargazers","contributors_url":"https://api.github.com/repos/ahopkins/sanic-jwt/contributors","subscribers_url":"https://api.github.com/repos/ahopkins/sanic-jwt/subscribers","subscription_url":"https://api.github.com/repos/ahopkins/sanic-jwt/subscription","commits_url":"https://api.github.com/repos/ahopkins/sanic-jwt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahopkins/sanic-jwt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahopkins/sanic-jwt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahopkins/sanic-jwt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahopkins/sanic-jwt/contents/{+path}","compare_url":"https://api.github.com/repos/ahopkins/sanic-jwt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahopkins/sanic-jwt/merges","archive_url":"https://api.github.com/repos/ahopkins/sanic-jwt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahopkins/sanic-jwt/downloads","issues_url":"https://api.github.com/repos/ahopkins/sanic-jwt/issues{/number}","pulls_url":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls{/number}","milestones_url":"https://api.github.com/repos/ahopkins/sanic-jwt/milestones{/number}","notifications_url":"https://api.github.com/repos/ahopkins/sanic-jwt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahopkins/sanic-jwt/labels{/name}","releases_url":"https://api.github.com/repos/ahopkins/sanic-jwt/releases{/id}","deployments_url":"https://api.github.com/repos/ahopkins/sanic-jwt/deployments","created_at":"2017-08-06T11:06:22Z","updated_at":"2017-11-03T20:55:35Z","pushed_at":"2017-11-05T13:20:51Z","git_url":"git://github.com/ahopkins/sanic-jwt.git","ssh_url":"git@github.com:ahopkins/sanic-jwt.git","clone_url":"https://github.com/ahopkins/sanic-jwt.git","svn_url":"https://github.com/ahopkins/sanic-jwt","homepage":"","size":46,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/17"},"html":{"href":"https://github.com/ahopkins/sanic-jwt/pull/17"},"issue":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/issues/17"},"comments":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/ahopkins/sanic-jwt/statuses/5b957a9104506d0af7c906e4484f4adf9e1eec8e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stefanm8"}}