{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/135886827","pull_request_review_id":59352020,"id":135886827,"diff_hunk":"@@ -34,7 +31,7 @@ var sizeOf       = require('image-size'),\n module.exports.getImageSizeFromUrl = function getImageSizeFromUrl(imagePath) {\n     return new Promise(function imageSizeRequest(resolve, reject) {","path":"core/server/utils/image-size-from-url.js","position":28,"original_position":19,"commit_id":"d4fa95d580a761200904a2d1b1a7873364cbd559","original_commit_id":"3cbdb1d860b45adbb76fa1b1377b179c72aeba1a","user":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"Yeah this should work 👍 ","created_at":"2017-08-29T19:18:00Z","updated_at":"2017-08-29T19:18:00Z","html_url":"https://github.com/TryGhost/Ghost/pull/8892#discussion_r135886827","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/8892","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/135886827"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/8892#discussion_r135886827"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/8892"}},"in_reply_to_id":133713997},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/8892","id":135573611,"html_url":"https://github.com/TryGhost/Ghost/pull/8892","diff_url":"https://github.com/TryGhost/Ghost/pull/8892.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/8892.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/8892","number":8892,"state":"open","locked":false,"title":"🙈 Used `got` to handle requests for image-size","user":{"login":"AileenCGN","id":8037602,"avatar_url":"https://avatars0.githubusercontent.com/u/8037602?v=4","gravatar_id":"","url":"https://api.github.com/users/AileenCGN","html_url":"https://github.com/AileenCGN","followers_url":"https://api.github.com/users/AileenCGN/followers","following_url":"https://api.github.com/users/AileenCGN/following{/other_user}","gists_url":"https://api.github.com/users/AileenCGN/gists{/gist_id}","starred_url":"https://api.github.com/users/AileenCGN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AileenCGN/subscriptions","organizations_url":"https://api.github.com/users/AileenCGN/orgs","repos_url":"https://api.github.com/users/AileenCGN/repos","events_url":"https://api.github.com/users/AileenCGN/events{/privacy}","received_events_url":"https://api.github.com/users/AileenCGN/received_events","type":"User","site_admin":false},"body":"refs #8589\r\nrefs #8868\r\n\r\nSwap `request` with `got` in `getImageSizeFromUrl` fn.\r\n\r\nTODOs:\r\n- [x] make redirects work\r\n- [x] fix tests\r\n- [x] check possible fix for #8885 -> done with #8915","created_at":"2017-08-14T10:58:48Z","updated_at":"2017-08-29T19:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c796a0b9b2186ebb8c2c829ae44020c65838eaf6","assignee":{"login":"ErisDS","id":101513,"avatar_url":"https://avatars1.githubusercontent.com/u/101513?v=4","gravatar_id":"","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false},"assignees":[{"login":"ErisDS","id":101513,"avatar_url":"https://avatars1.githubusercontent.com/u/101513?v=4","gravatar_id":"","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/8892/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/8892/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/8892/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/d4fa95d580a761200904a2d1b1a7873364cbd559","head":{"label":"AileenCGN:refactor-image-size-use-got","ref":"refactor-image-size-use-got","sha":"d4fa95d580a761200904a2d1b1a7873364cbd559","user":{"login":"AileenCGN","id":8037602,"avatar_url":"https://avatars0.githubusercontent.com/u/8037602?v=4","gravatar_id":"","url":"https://api.github.com/users/AileenCGN","html_url":"https://github.com/AileenCGN","followers_url":"https://api.github.com/users/AileenCGN/followers","following_url":"https://api.github.com/users/AileenCGN/following{/other_user}","gists_url":"https://api.github.com/users/AileenCGN/gists{/gist_id}","starred_url":"https://api.github.com/users/AileenCGN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AileenCGN/subscriptions","organizations_url":"https://api.github.com/users/AileenCGN/orgs","repos_url":"https://api.github.com/users/AileenCGN/repos","events_url":"https://api.github.com/users/AileenCGN/events{/privacy}","received_events_url":"https://api.github.com/users/AileenCGN/received_events","type":"User","site_admin":false},"repo":{"id":28513085,"name":"Ghost","full_name":"AileenCGN/Ghost","owner":{"login":"AileenCGN","id":8037602,"avatar_url":"https://avatars0.githubusercontent.com/u/8037602?v=4","gravatar_id":"","url":"https://api.github.com/users/AileenCGN","html_url":"https://github.com/AileenCGN","followers_url":"https://api.github.com/users/AileenCGN/followers","following_url":"https://api.github.com/users/AileenCGN/following{/other_user}","gists_url":"https://api.github.com/users/AileenCGN/gists{/gist_id}","starred_url":"https://api.github.com/users/AileenCGN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AileenCGN/subscriptions","organizations_url":"https://api.github.com/users/AileenCGN/orgs","repos_url":"https://api.github.com/users/AileenCGN/repos","events_url":"https://api.github.com/users/AileenCGN/events{/privacy}","received_events_url":"https://api.github.com/users/AileenCGN/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AileenCGN/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/AileenCGN/Ghost","forks_url":"https://api.github.com/repos/AileenCGN/Ghost/forks","keys_url":"https://api.github.com/repos/AileenCGN/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AileenCGN/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AileenCGN/Ghost/teams","hooks_url":"https://api.github.com/repos/AileenCGN/Ghost/hooks","issue_events_url":"https://api.github.com/repos/AileenCGN/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/AileenCGN/Ghost/events","assignees_url":"https://api.github.com/repos/AileenCGN/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/AileenCGN/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/AileenCGN/Ghost/tags","blobs_url":"https://api.github.com/repos/AileenCGN/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AileenCGN/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AileenCGN/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/AileenCGN/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AileenCGN/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/AileenCGN/Ghost/languages","stargazers_url":"https://api.github.com/repos/AileenCGN/Ghost/stargazers","contributors_url":"https://api.github.com/repos/AileenCGN/Ghost/contributors","subscribers_url":"https://api.github.com/repos/AileenCGN/Ghost/subscribers","subscription_url":"https://api.github.com/repos/AileenCGN/Ghost/subscription","commits_url":"https://api.github.com/repos/AileenCGN/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/AileenCGN/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/AileenCGN/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/AileenCGN/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/AileenCGN/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/AileenCGN/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AileenCGN/Ghost/merges","archive_url":"https://api.github.com/repos/AileenCGN/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AileenCGN/Ghost/downloads","issues_url":"https://api.github.com/repos/AileenCGN/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/AileenCGN/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/AileenCGN/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/AileenCGN/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AileenCGN/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/AileenCGN/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/AileenCGN/Ghost/deployments","created_at":"2014-12-26T14:42:30Z","updated_at":"2014-12-26T14:42:34Z","pushed_at":"2017-08-29T10:02:52Z","git_url":"git://github.com/AileenCGN/Ghost.git","ssh_url":"git@github.com:AileenCGN/Ghost.git","clone_url":"https://github.com/AileenCGN/Ghost.git","svn_url":"https://github.com/AileenCGN/Ghost","homepage":"https://ghost.org","size":23816,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"0c4fcfdbe3f3fa154301e8c9073e77b69da323b5","user":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"name":"Ghost","full_name":"TryGhost/Ghost","owner":{"login":"TryGhost","id":2178663,"avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TryGhost/Ghost","description":"A simple, powerful publishing platform","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ghost/deployments","created_at":"2013-05-04T11:09:13Z","updated_at":"2017-08-29T19:11:01Z","pushed_at":"2017-08-29T18:35:11Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":24411,"stargazers_count":23720,"watchers_count":23720,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5500,"mirror_url":null,"open_issues_count":108,"forks":5500,"open_issues":108,"watchers":23720,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/8892"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/8892"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/8892"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/8892/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/8892/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/8892/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/d4fa95d580a761200904a2d1b1a7873364cbd559"}}}}
{"actor":{"display_login":"kirrg001"}}