{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/136295485","pull_request_review_id":59811797,"id":136295485,"diff_hunk":"@@ -63,13 +63,22 @@ def install\n       # Upstream commit from 24 Feb 2017 https://hg.savannah.gnu.org/hgweb/octave/rev/a6e4157694ef\n       inreplace \"liboctave/system/file-stat.cc\",\n         \"inline file_stat::~file_stat () { }\", \"file_stat::~file_stat () { }\"\n+      inreplace \"scripts/java/module.mk\",\n+        \"-source 1.3 -target 1.3\", \"\" # necessary for java >1.8\n     end\n \n     # Default configuration passes all linker flags to mkoctfile, to be\n     # inserted into every oct/mex build. This is unnecessary and can cause\n     # cause linking problems.\n     inreplace \"src/mkoctfile.in.cc\", /%OCTAVE_CONF_OCT(AVE)?_LINK_(DEPS|OPTS)%/, '\"\"'\n \n+    # allow for recent Oracle Java (>=1.8) without requiring the old Apple Java 1.6\n+    # this is more or less the same as in http://savannah.gnu.org/patch/index.php?9439\n+    inreplace \"libinterp/octave-value/ov-java.cc\",","path":"Formula/octave.rb","position":33,"original_position":33,"commit_id":"8e15fd18272761318008be3a7fbb7975d662fb70","original_commit_id":"8e15fd18272761318008be3a7fbb7975d662fb70","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"body":"This inreplace and the one below are still needed for head?","created_at":"2017-08-31T10:05:22Z","updated_at":"2017-08-31T10:05:22Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/17343#discussion_r136295485","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/17343","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/136295485"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/17343#discussion_r136295485"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/17343"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/17343","id":138041391,"html_url":"https://github.com/Homebrew/homebrew-core/pull/17343","diff_url":"https://github.com/Homebrew/homebrew-core/pull/17343.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/17343.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/17343","number":17343,"state":"open","locked":false,"title":"Octave: fix java issues","user":{"login":"schoeps","id":868081,"avatar_url":"https://avatars1.githubusercontent.com/u/868081?v=4","gravatar_id":"","url":"https://api.github.com/users/schoeps","html_url":"https://github.com/schoeps","followers_url":"https://api.github.com/users/schoeps/followers","following_url":"https://api.github.com/users/schoeps/following{/other_user}","gists_url":"https://api.github.com/users/schoeps/gists{/gist_id}","starred_url":"https://api.github.com/users/schoeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoeps/subscriptions","organizations_url":"https://api.github.com/users/schoeps/orgs","repos_url":"https://api.github.com/users/schoeps/repos","events_url":"https://api.github.com/users/schoeps/events{/privacy}","received_events_url":"https://api.github.com/users/schoeps/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nsee https://github.com/Homebrew/homebrew-core/issues/16979","created_at":"2017-08-28T21:25:34Z","updated_at":"2017-08-31T10:05:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3def71f116b909e5f562a17f920c6e944f8b83b5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/17343/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/17343/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/17343/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/8e15fd18272761318008be3a7fbb7975d662fb70","head":{"label":"schoeps:master","ref":"master","sha":"8e15fd18272761318008be3a7fbb7975d662fb70","user":{"login":"schoeps","id":868081,"avatar_url":"https://avatars1.githubusercontent.com/u/868081?v=4","gravatar_id":"","url":"https://api.github.com/users/schoeps","html_url":"https://github.com/schoeps","followers_url":"https://api.github.com/users/schoeps/followers","following_url":"https://api.github.com/users/schoeps/following{/other_user}","gists_url":"https://api.github.com/users/schoeps/gists{/gist_id}","starred_url":"https://api.github.com/users/schoeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoeps/subscriptions","organizations_url":"https://api.github.com/users/schoeps/orgs","repos_url":"https://api.github.com/users/schoeps/repos","events_url":"https://api.github.com/users/schoeps/events{/privacy}","received_events_url":"https://api.github.com/users/schoeps/received_events","type":"User","site_admin":false},"repo":{"id":65294855,"name":"homebrew-core","full_name":"schoeps/homebrew-core","owner":{"login":"schoeps","id":868081,"avatar_url":"https://avatars1.githubusercontent.com/u/868081?v=4","gravatar_id":"","url":"https://api.github.com/users/schoeps","html_url":"https://github.com/schoeps","followers_url":"https://api.github.com/users/schoeps/followers","following_url":"https://api.github.com/users/schoeps/following{/other_user}","gists_url":"https://api.github.com/users/schoeps/gists{/gist_id}","starred_url":"https://api.github.com/users/schoeps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schoeps/subscriptions","organizations_url":"https://api.github.com/users/schoeps/orgs","repos_url":"https://api.github.com/users/schoeps/repos","events_url":"https://api.github.com/users/schoeps/events{/privacy}","received_events_url":"https://api.github.com/users/schoeps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schoeps/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/schoeps/homebrew-core","forks_url":"https://api.github.com/repos/schoeps/homebrew-core/forks","keys_url":"https://api.github.com/repos/schoeps/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schoeps/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schoeps/homebrew-core/teams","hooks_url":"https://api.github.com/repos/schoeps/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/schoeps/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/schoeps/homebrew-core/events","assignees_url":"https://api.github.com/repos/schoeps/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/schoeps/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/schoeps/homebrew-core/tags","blobs_url":"https://api.github.com/repos/schoeps/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schoeps/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schoeps/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/schoeps/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schoeps/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/schoeps/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/schoeps/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/schoeps/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/schoeps/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/schoeps/homebrew-core/subscription","commits_url":"https://api.github.com/repos/schoeps/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/schoeps/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/schoeps/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/schoeps/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/schoeps/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/schoeps/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schoeps/homebrew-core/merges","archive_url":"https://api.github.com/repos/schoeps/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schoeps/homebrew-core/downloads","issues_url":"https://api.github.com/repos/schoeps/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/schoeps/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/schoeps/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/schoeps/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schoeps/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/schoeps/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/schoeps/homebrew-core/deployments","created_at":"2016-08-09T12:55:22Z","updated_at":"2016-08-09T12:55:38Z","pushed_at":"2017-08-28T21:24:12Z","git_url":"git://github.com/schoeps/homebrew-core.git","ssh_url":"git@github.com:schoeps/homebrew-core.git","clone_url":"https://github.com/schoeps/homebrew-core.git","svn_url":"https://github.com/schoeps/homebrew-core","homepage":"http://brew.sh","size":133276,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"420482004c6f5f43e6f1c25bc00a53900ecd9ce7","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2017-08-31T05:00:48Z","pushed_at":"2017-08-31T10:05:21Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":134774,"stargazers_count":2007,"watchers_count":2007,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3090,"mirror_url":null,"open_issues_count":68,"forks":3090,"open_issues":68,"watchers":2007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/17343"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/17343"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/17343"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/17343/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/17343/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/17343/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/8e15fd18272761318008be3a7fbb7975d662fb70"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ilovezfs"}}