{"action":"created","comment":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/comments/94357307","pull_request_review_id":14882657,"id":94357307,"diff_hunk":"@@ -16,12 +16,7 @@ limitations under the License.\n To connect to Zeppelin, users will be asked to enter their credentials. Once logged, a user has access to all notes including other users notes.\n This a a first step toward full security as implemented by this pull request (https://github.com/apache/zeppelin/pull/53).\n \n-# Security setup\n-1. Secure the HTTP channel: Comment the line \"/** = anon\" and uncomment the line \"/** = authc\" in the file conf/shiro.ini. Read more about he shiro.ini file format at the following URL http://shiro.apache.org/configuration.html#Configuration-INISections.  \n-2. Secure the Websocket channel : Set to property \"zeppelin.anonymous.allowed\" to \"false\" in the file conf/zeppelin-site.xml. You can start by renaming conf/zeppelin-site.xml.template to conf/zeppelin-site.xml\n-3. Start Zeppelin : bin/zeppelin.sh\n-4. point your browser to http://localhost:8080\n-5. Login using one of the user/password combinations defined in the conf/shiro.ini file.\n+Please check [Shiro authentication in Apache Zeppelin](https://zeppelin.apache.org/docs/snapshot/security/shiroauthentication.html) in our official website for more detailed information(e.g. How to setup the security, How to configure user groups and permissions, and etc).","path":"SECURITY-README.md","position":10,"original_position":10,"commit_id":"d4b80b833cb36e6a0340daf4f7580941c84d06d7","original_commit_id":"d4b80b833cb36e6a0340daf4f7580941c84d06d7","user":{"login":"felixcheung","id":8969467,"avatar_url":"https://avatars.githubusercontent.com/u/8969467?v=3","gravatar_id":"","url":"https://api.github.com/users/felixcheung","html_url":"https://github.com/felixcheung","followers_url":"https://api.github.com/users/felixcheung/followers","following_url":"https://api.github.com/users/felixcheung/following{/other_user}","gists_url":"https://api.github.com/users/felixcheung/gists{/gist_id}","starred_url":"https://api.github.com/users/felixcheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixcheung/subscriptions","organizations_url":"https://api.github.com/users/felixcheung/orgs","repos_url":"https://api.github.com/users/felixcheung/repos","events_url":"https://api.github.com/users/felixcheung/events{/privacy}","received_events_url":"https://api.github.com/users/felixcheung/received_events","type":"User","site_admin":false},"body":"instead of https://zeppelin.apache.org/docs/snapshot\r\npoint to https://zeppelin.apache.org/docs/latest\r\n?","created_at":"2017-01-03T03:30:19Z","updated_at":"2017-01-03T03:30:19Z","html_url":"https://github.com/apache/zeppelin/pull/1829#discussion_r94357307","pull_request_url":"https://api.github.com/repos/apache/zeppelin/pulls/1829","_links":{"self":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/comments/94357307"},"html":{"href":"https://github.com/apache/zeppelin/pull/1829#discussion_r94357307"},"pull_request":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/1829"}}},"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/1829","id":99822209,"html_url":"https://github.com/apache/zeppelin/pull/1829","diff_url":"https://github.com/apache/zeppelin/pull/1829.diff","patch_url":"https://github.com/apache/zeppelin/pull/1829.patch","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/1829","number":1829,"state":"open","locked":false,"title":"[DOCS] Remove outdated 'Security Setup' section in SECURITY-README","user":{"login":"AhyoungRyu","id":10060731,"avatar_url":"https://avatars.githubusercontent.com/u/10060731?v=3","gravatar_id":"","url":"https://api.github.com/users/AhyoungRyu","html_url":"https://github.com/AhyoungRyu","followers_url":"https://api.github.com/users/AhyoungRyu/followers","following_url":"https://api.github.com/users/AhyoungRyu/following{/other_user}","gists_url":"https://api.github.com/users/AhyoungRyu/gists{/gist_id}","starred_url":"https://api.github.com/users/AhyoungRyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AhyoungRyu/subscriptions","organizations_url":"https://api.github.com/users/AhyoungRyu/orgs","repos_url":"https://api.github.com/users/AhyoungRyu/repos","events_url":"https://api.github.com/users/AhyoungRyu/events{/privacy}","received_events_url":"https://api.github.com/users/AhyoungRyu/received_events","type":"User","site_admin":false},"body":"### What is this PR for?\r\n[SECURITY-README.md](https://github.com/apache/zeppelin/blob/master/SECURITY-README.md) was added by #53 when Shiro auth was implemented for the first time. But I think we need to keep \"Security Setup\" information in one source; [Official docs website](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/security/shiroauthentication.html#security-setup) and guide ppl to see this official docs page so that `SECURITY-README.md` can only contain dev related contents (not step by step setup guide).\r\n\r\n### What type of PR is it?\r\nDocumentation\r\n\r\n### What is the Jira issue?\r\nN/A\r\n\r\n### How should this be tested?\r\nJust clicking \"View\" would be enough I guess :)\r\n\r\n\r\n### Questions:\r\n* Does the licenses files need update? N/A\r\n* Is there breaking changes for older versions? N/A\r\n* Does this needs documentation? N/A\r\n","created_at":"2017-01-01T12:14:30Z","updated_at":"2017-01-03T03:30:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d394cc8aa04a3870d6ace36ab70d8d7c488d035","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/zeppelin/pulls/1829/commits","review_comments_url":"https://api.github.com/repos/apache/zeppelin/pulls/1829/comments","review_comment_url":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/1829/comments","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/d4b80b833cb36e6a0340daf4f7580941c84d06d7","head":{"label":"AhyoungRyu:remove/duplicatedSection","ref":"remove/duplicatedSection","sha":"d4b80b833cb36e6a0340daf4f7580941c84d06d7","user":{"login":"AhyoungRyu","id":10060731,"avatar_url":"https://avatars.githubusercontent.com/u/10060731?v=3","gravatar_id":"","url":"https://api.github.com/users/AhyoungRyu","html_url":"https://github.com/AhyoungRyu","followers_url":"https://api.github.com/users/AhyoungRyu/followers","following_url":"https://api.github.com/users/AhyoungRyu/following{/other_user}","gists_url":"https://api.github.com/users/AhyoungRyu/gists{/gist_id}","starred_url":"https://api.github.com/users/AhyoungRyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AhyoungRyu/subscriptions","organizations_url":"https://api.github.com/users/AhyoungRyu/orgs","repos_url":"https://api.github.com/users/AhyoungRyu/repos","events_url":"https://api.github.com/users/AhyoungRyu/events{/privacy}","received_events_url":"https://api.github.com/users/AhyoungRyu/received_events","type":"User","site_admin":false},"repo":{"id":44792338,"name":"zeppelin","full_name":"AhyoungRyu/zeppelin","owner":{"login":"AhyoungRyu","id":10060731,"avatar_url":"https://avatars.githubusercontent.com/u/10060731?v=3","gravatar_id":"","url":"https://api.github.com/users/AhyoungRyu","html_url":"https://github.com/AhyoungRyu","followers_url":"https://api.github.com/users/AhyoungRyu/followers","following_url":"https://api.github.com/users/AhyoungRyu/following{/other_user}","gists_url":"https://api.github.com/users/AhyoungRyu/gists{/gist_id}","starred_url":"https://api.github.com/users/AhyoungRyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AhyoungRyu/subscriptions","organizations_url":"https://api.github.com/users/AhyoungRyu/orgs","repos_url":"https://api.github.com/users/AhyoungRyu/repos","events_url":"https://api.github.com/users/AhyoungRyu/events{/privacy}","received_events_url":"https://api.github.com/users/AhyoungRyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AhyoungRyu/zeppelin","description":"Mirror of Apache Zeppelin","fork":true,"url":"https://api.github.com/repos/AhyoungRyu/zeppelin","forks_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/forks","keys_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/teams","hooks_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/events","assignees_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/tags","blobs_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/languages","stargazers_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/subscription","commits_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/merges","archive_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/downloads","issues_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/AhyoungRyu/zeppelin/deployments","created_at":"2015-10-23T05:19:13Z","updated_at":"2016-11-01T03:08:51Z","pushed_at":"2017-01-03T03:00:32Z","git_url":"git://github.com/AhyoungRyu/zeppelin.git","ssh_url":"git@github.com:AhyoungRyu/zeppelin.git","clone_url":"https://github.com/AhyoungRyu/zeppelin.git","svn_url":"https://github.com/AhyoungRyu/zeppelin","homepage":"","size":49464,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"31b71f7391fab8ff5f7a0feb90f285eb98911902","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32848140,"name":"zeppelin","full_name":"apache/zeppelin","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/zeppelin","description":"Mirror of Apache Zeppelin","fork":false,"url":"https://api.github.com/repos/apache/zeppelin","forks_url":"https://api.github.com/repos/apache/zeppelin/forks","keys_url":"https://api.github.com/repos/apache/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zeppelin/teams","hooks_url":"https://api.github.com/repos/apache/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/apache/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zeppelin/events","assignees_url":"https://api.github.com/repos/apache/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zeppelin/tags","blobs_url":"https://api.github.com/repos/apache/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zeppelin/languages","stargazers_url":"https://api.github.com/repos/apache/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/apache/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/apache/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/apache/zeppelin/subscription","commits_url":"https://api.github.com/repos/apache/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zeppelin/merges","archive_url":"https://api.github.com/repos/apache/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zeppelin/downloads","issues_url":"https://api.github.com/repos/apache/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/apache/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zeppelin/deployments","created_at":"2015-03-25T07:00:06Z","updated_at":"2017-01-02T23:53:30Z","pushed_at":"2017-01-03T03:00:33Z","git_url":"git://github.com/apache/zeppelin.git","ssh_url":"git@github.com:apache/zeppelin.git","clone_url":"https://github.com/apache/zeppelin.git","svn_url":"https://github.com/apache/zeppelin","homepage":"","size":48395,"stargazers_count":2352,"watchers_count":2352,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1204,"mirror_url":"git://git.apache.org/incubator-zeppelin.git","open_issues_count":137,"forks":1204,"open_issues":137,"watchers":2352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/1829"},"html":{"href":"https://github.com/apache/zeppelin/pull/1829"},"issue":{"href":"https://api.github.com/repos/apache/zeppelin/issues/1829"},"comments":{"href":"https://api.github.com/repos/apache/zeppelin/issues/1829/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/1829/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/1829/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zeppelin/statuses/d4b80b833cb36e6a0340daf4f7580941c84d06d7"}}}}
{"actor":{"display_login":"felixcheung"}}