{"action":"created","issue":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/726","repository_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/726/labels{/name}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/726/comments","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/726/events","html_url":"https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/726","id":257346732,"number":726,"title":"New Saml1.1 token handler strips the attribute namespace during token validation","user":{"login":"leastprivilege","id":1454075,"avatar_url":"https://avatars0.githubusercontent.com/u/1454075?v=4","gravatar_id":"","url":"https://api.github.com/users/leastprivilege","html_url":"https://github.com/leastprivilege","followers_url":"https://api.github.com/users/leastprivilege/followers","following_url":"https://api.github.com/users/leastprivilege/following{/other_user}","gists_url":"https://api.github.com/users/leastprivilege/gists{/gist_id}","starred_url":"https://api.github.com/users/leastprivilege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leastprivilege/subscriptions","organizations_url":"https://api.github.com/users/leastprivilege/orgs","repos_url":"https://api.github.com/users/leastprivilege/repos","events_url":"https://api.github.com/users/leastprivilege/events{/privacy}","received_events_url":"https://api.github.com/users/leastprivilege/received_events","type":"User","site_admin":false},"labels":[{"id":99596199,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/labels/P1","name":"P1","color":"e11d21","default":false},{"id":138195332,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/labels/User%20reported","name":"User reported","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"ChenYan98","id":19174056,"avatar_url":"https://avatars0.githubusercontent.com/u/19174056?v=4","gravatar_id":"","url":"https://api.github.com/users/ChenYan98","html_url":"https://github.com/ChenYan98","followers_url":"https://api.github.com/users/ChenYan98/followers","following_url":"https://api.github.com/users/ChenYan98/following{/other_user}","gists_url":"https://api.github.com/users/ChenYan98/gists{/gist_id}","starred_url":"https://api.github.com/users/ChenYan98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChenYan98/subscriptions","organizations_url":"https://api.github.com/users/ChenYan98/orgs","repos_url":"https://api.github.com/users/ChenYan98/repos","events_url":"https://api.github.com/users/ChenYan98/events{/privacy}","received_events_url":"https://api.github.com/users/ChenYan98/received_events","type":"User","site_admin":false},"assignees":[{"login":"ChenYan98","id":19174056,"avatar_url":"https://avatars0.githubusercontent.com/u/19174056?v=4","gravatar_id":"","url":"https://api.github.com/users/ChenYan98","html_url":"https://github.com/ChenYan98","followers_url":"https://api.github.com/users/ChenYan98/followers","following_url":"https://api.github.com/users/ChenYan98/following{/other_user}","gists_url":"https://api.github.com/users/ChenYan98/gists{/gist_id}","starred_url":"https://api.github.com/users/ChenYan98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChenYan98/subscriptions","organizations_url":"https://api.github.com/users/ChenYan98/orgs","repos_url":"https://api.github.com/users/ChenYan98/repos","events_url":"https://api.github.com/users/ChenYan98/events{/privacy}","received_events_url":"https://api.github.com/users/ChenYan98/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/milestones/18","html_url":"https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/milestone/18","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/milestones/18/labels","id":2304639,"number":18,"title":"5.2.0","description":"Next planned 5.x release\r\nWill include:\r\nWsFed for net451 target\r\n1.6 net standard target\r\n\r\nWe moved the date out to accomidate WsFed for Core.\r\n\r\nAug 24th.\r\nMoved date out to support signedxml","creator":{"login":"brentschmaltz","id":3172421,"avatar_url":"https://avatars0.githubusercontent.com/u/3172421?v=4","gravatar_id":"","url":"https://api.github.com/users/brentschmaltz","html_url":"https://github.com/brentschmaltz","followers_url":"https://api.github.com/users/brentschmaltz/followers","following_url":"https://api.github.com/users/brentschmaltz/following{/other_user}","gists_url":"https://api.github.com/users/brentschmaltz/gists{/gist_id}","starred_url":"https://api.github.com/users/brentschmaltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brentschmaltz/subscriptions","organizations_url":"https://api.github.com/users/brentschmaltz/orgs","repos_url":"https://api.github.com/users/brentschmaltz/repos","events_url":"https://api.github.com/users/brentschmaltz/events{/privacy}","received_events_url":"https://api.github.com/users/brentschmaltz/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":41,"state":"open","created_at":"2017-02-07T02:44:26Z","updated_at":"2017-09-14T05:31:39Z","due_on":"2017-09-16T07:00:00Z","closed_at":null},"comments":3,"created_at":"2017-09-13T11:28:04Z","updated_at":"2017-09-14T20:20:51Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"which means the result ClaimsIdentity will only have claims that use the attribute name for the claim type - the attribute namespace is missing.\r\n\r\nThis is a radical change from the .NET Framework version of the token handler - and will make migration hard."},"comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/comments/329597705","html_url":"https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/726#issuecomment-329597705","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/726","id":329597705,"user":{"login":"ChenYan98","id":19174056,"avatar_url":"https://avatars0.githubusercontent.com/u/19174056?v=4","gravatar_id":"","url":"https://api.github.com/users/ChenYan98","html_url":"https://github.com/ChenYan98","followers_url":"https://api.github.com/users/ChenYan98/followers","following_url":"https://api.github.com/users/ChenYan98/following{/other_user}","gists_url":"https://api.github.com/users/ChenYan98/gists{/gist_id}","starred_url":"https://api.github.com/users/ChenYan98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChenYan98/subscriptions","organizations_url":"https://api.github.com/users/ChenYan98/orgs","repos_url":"https://api.github.com/users/ChenYan98/repos","events_url":"https://api.github.com/users/ChenYan98/events{/privacy}","received_events_url":"https://api.github.com/users/ChenYan98/received_events","type":"User","site_admin":false},"created_at":"2017-09-14T20:20:51Z","updated_at":"2017-09-14T20:20:51Z","author_association":"MEMBER","body":"According to my understanding, this is the bug we already found in #668 and it has been fixed in current code. @leastprivilege can you please check if the following code is what you are talking about. https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/668b50de3d8ad77e7b3f5dceb0ee79768c6e5104/src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSerializer.cs#L329\r\nand https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs#L661\r\n"}}
{"actor":{"display_login":"ChenYan98"}}