{"action":"created","comment":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/comments/154294660","pull_request_review_id":80435861,"id":154294660,"diff_hunk":"@@ -869,7 +869,7 @@ TAP_ESC::ioctl(file *filp, int cmd, unsigned long arg)\n \n \tcase MIXERIOCLOADBUF: {\n \t\t\tconst char *buf = (const char *)arg;\n-\t\t\tunsigned buflen = strnlen(buf, 1024);\n+\t\t\tunsigned buflen = strlen(buf);","path":"src/drivers/tap_esc/tap_esc.cpp","position":41,"original_position":41,"commit_id":"5f5143bacd00372fd3411c7cb0b6410e1bb836bb","original_commit_id":"64d7fd36f740ff6c81a29de6490ac23770af5200","user":{"login":"Lampoo","id":33611129,"avatar_url":"https://avatars1.githubusercontent.com/u/33611129?v=4","gravatar_id":"","url":"https://api.github.com/users/Lampoo","html_url":"https://github.com/Lampoo","followers_url":"https://api.github.com/users/Lampoo/followers","following_url":"https://api.github.com/users/Lampoo/following{/other_user}","gists_url":"https://api.github.com/users/Lampoo/gists{/gist_id}","starred_url":"https://api.github.com/users/Lampoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lampoo/subscriptions","organizations_url":"https://api.github.com/users/Lampoo/orgs","repos_url":"https://api.github.com/users/Lampoo/repos","events_url":"https://api.github.com/users/Lampoo/events{/privacy}","received_events_url":"https://api.github.com/users/Lampoo/received_events","type":"User","site_admin":false},"body":"@ChristophTobler I can see it is at :src/platforms/qurt/px4_layer/px4_qurt_impl.cpp:148:size_t strnlen(const char *s, size_t maxlen)","created_at":"2017-12-01T08:59:07Z","updated_at":"2017-12-01T08:59:07Z","html_url":"https://github.com/PX4/Firmware/pull/8394#discussion_r154294660","pull_request_url":"https://api.github.com/repos/PX4/Firmware/pulls/8394","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments/154294660"},"html":{"href":"https://github.com/PX4/Firmware/pull/8394#discussion_r154294660"},"pull_request":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/8394"}},"in_reply_to_id":154247583},"pull_request":{"url":"https://api.github.com/repos/PX4/Firmware/pulls/8394","id":155620504,"html_url":"https://github.com/PX4/Firmware/pull/8394","diff_url":"https://github.com/PX4/Firmware/pull/8394.diff","patch_url":"https://github.com/PX4/Firmware/pull/8394.patch","issue_url":"https://api.github.com/repos/PX4/Firmware/issues/8394","number":8394,"state":"open","locked":false,"title":"tap_esc: changes needed to run on qurt","user":{"login":"ChristophTobler","id":14769636,"avatar_url":"https://avatars1.githubusercontent.com/u/14769636?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristophTobler","html_url":"https://github.com/ChristophTobler","followers_url":"https://api.github.com/users/ChristophTobler/followers","following_url":"https://api.github.com/users/ChristophTobler/following{/other_user}","gists_url":"https://api.github.com/users/ChristophTobler/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristophTobler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristophTobler/subscriptions","organizations_url":"https://api.github.com/users/ChristophTobler/orgs","repos_url":"https://api.github.com/users/ChristophTobler/repos","events_url":"https://api.github.com/users/ChristophTobler/events{/privacy}","received_events_url":"https://api.github.com/users/ChristophTobler/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-30T14:23:42Z","updated_at":"2017-12-01T08:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9b6283e4d8dcccb29de55a049198b83c49f994e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PX4/Firmware/pulls/8394/commits","review_comments_url":"https://api.github.com/repos/PX4/Firmware/pulls/8394/comments","review_comment_url":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PX4/Firmware/issues/8394/comments","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/5f5143bacd00372fd3411c7cb0b6410e1bb836bb","head":{"label":"PX4:pr-tap_esc_qurt","ref":"pr-tap_esc_qurt","sha":"5f5143bacd00372fd3411c7cb0b6410e1bb836bb","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2017-12-01T03:23:11Z","pushed_at":"2017-12-01T08:33:55Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":93389,"stargazers_count":1426,"watchers_count":1426,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4032,"mirror_url":null,"archived":false,"open_issues_count":564,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4032,"open_issues":564,"watchers":1426,"default_branch":"master"}},"base":{"label":"PX4:master","ref":"master","sha":"fedc9abb02d8fdc558c05f3d87c5d3cb7bf30350","user":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"repo":{"id":5298790,"name":"Firmware","full_name":"PX4/Firmware","owner":{"login":"PX4","id":2096014,"avatar_url":"https://avatars3.githubusercontent.com/u/2096014?v=4","gravatar_id":"","url":"https://api.github.com/users/PX4","html_url":"https://github.com/PX4","followers_url":"https://api.github.com/users/PX4/followers","following_url":"https://api.github.com/users/PX4/following{/other_user}","gists_url":"https://api.github.com/users/PX4/gists{/gist_id}","starred_url":"https://api.github.com/users/PX4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PX4/subscriptions","organizations_url":"https://api.github.com/users/PX4/orgs","repos_url":"https://api.github.com/users/PX4/repos","events_url":"https://api.github.com/users/PX4/events{/privacy}","received_events_url":"https://api.github.com/users/PX4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PX4/Firmware","description":"PX4 Pro Autopilot Software","fork":false,"url":"https://api.github.com/repos/PX4/Firmware","forks_url":"https://api.github.com/repos/PX4/Firmware/forks","keys_url":"https://api.github.com/repos/PX4/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PX4/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PX4/Firmware/teams","hooks_url":"https://api.github.com/repos/PX4/Firmware/hooks","issue_events_url":"https://api.github.com/repos/PX4/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/PX4/Firmware/events","assignees_url":"https://api.github.com/repos/PX4/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/PX4/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/PX4/Firmware/tags","blobs_url":"https://api.github.com/repos/PX4/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PX4/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PX4/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/PX4/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PX4/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/PX4/Firmware/languages","stargazers_url":"https://api.github.com/repos/PX4/Firmware/stargazers","contributors_url":"https://api.github.com/repos/PX4/Firmware/contributors","subscribers_url":"https://api.github.com/repos/PX4/Firmware/subscribers","subscription_url":"https://api.github.com/repos/PX4/Firmware/subscription","commits_url":"https://api.github.com/repos/PX4/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/PX4/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/PX4/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/PX4/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/PX4/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/PX4/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PX4/Firmware/merges","archive_url":"https://api.github.com/repos/PX4/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PX4/Firmware/downloads","issues_url":"https://api.github.com/repos/PX4/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/PX4/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/PX4/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/PX4/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PX4/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/PX4/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/PX4/Firmware/deployments","created_at":"2012-08-04T21:19:36Z","updated_at":"2017-12-01T03:23:11Z","pushed_at":"2017-12-01T08:33:55Z","git_url":"git://github.com/PX4/Firmware.git","ssh_url":"git@github.com:PX4/Firmware.git","clone_url":"https://github.com/PX4/Firmware.git","svn_url":"https://github.com/PX4/Firmware","homepage":"http://px4.io","size":93389,"stargazers_count":1426,"watchers_count":1426,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4032,"mirror_url":null,"archived":false,"open_issues_count":564,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4032,"open_issues":564,"watchers":1426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/8394"},"html":{"href":"https://github.com/PX4/Firmware/pull/8394"},"issue":{"href":"https://api.github.com/repos/PX4/Firmware/issues/8394"},"comments":{"href":"https://api.github.com/repos/PX4/Firmware/issues/8394/comments"},"review_comments":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/8394/comments"},"review_comment":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PX4/Firmware/pulls/8394/commits"},"statuses":{"href":"https://api.github.com/repos/PX4/Firmware/statuses/5f5143bacd00372fd3411c7cb0b6410e1bb836bb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Lampoo"}}