{"push_id":2016742832,"size":11,"distinct_size":11,"ref":"refs/heads/make-zip-of-dox","head":"5acda7c03b05c93a7e45b9e4a2db527b26132f51","before":"c3f60711e1ffdf4071ae1a48ecd66c769e8ba9ee","commits":[{"sha":"dc1285d706e5d43fd51298fbd23085c62eb6b3fc","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Fix whitespace in validation rules\n\nReplace tabs with spaces and remove trailing whitespace.","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/dc1285d706e5d43fd51298fbd23085c62eb6b3fc"},{"sha":"1e6847198ddba2b58266204b84e9cbe0e70cbb62","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Clean up whitespace in form binders\n\nDelete trailing whitespace, replace tabs with spaces, and delete a few\nextraneous newlines.","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/1e6847198ddba2b58266204b84e9cbe0e70cbb62"},{"sha":"45a3b9db26156597d08b2d4a8dc82d191a28c4b1","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Extract helper to add unnamed address to model\n\nSeveral of the form binders use a simple, unprefixed set of address\nmodel variables. Extract the repeated code into a helper method in the\nbase class.\n\nRefactoring in preparation to alter behavior around address lines.\n\nIssue #8 Reduce code duplication\nIssue #292 Label all required fields","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/45a3b9db26156597d08b2d4a8dc82d191a28c4b1"},{"sha":"24c35fd1a30ddd3e139b3aac9226a05b02e37d3a","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Extract helper to add named address to model\n\nNote that we now bind `attentionTo` for some addresses which we did not\ndo previously; the bound value is `null`, and the page template never\nrefers to it. Binding a null value is not an error, as demonstrated by\nthe fact that we were binding the reimbursement county, which is also\nnever referred to and defaults to null.\n\nRefactoring in preparation to alter behavior around address lines.\n\nIssue #8 Reduce code duplication\nIssue #292 Label all required fields","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/24c35fd1a30ddd3e139b3aac9226a05b02e37d3a"},{"sha":"b078dc34f1c29c6cd1df2d40dd5b74f87652a65f","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Extract helper to read prefixed address\n\nSeveral of the form binders need to read an address from several model\nvariables with prefixed names. Extract the repeated code into a helper method\nin the base class.\n\nRefactoring in preparation to alter behavior around address lines.\n\nIssue #8 Reduce code duplication\nIssue #292 Label all required fields","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/b078dc34f1c29c6cd1df2d40dd5b74f87652a65f"},{"sha":"4e54e875eaf07cab9699c8a30f9ed95863206ece","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Extract helper to read indexed address\n\nSeveral of the form binders need to read multiple addresses from several\nmodel variables with indexed names. Extract the repeated code into a\nhelper method in the base class.\n\nRefactoring in preparation to alter behavior around address lines.\n\nIssue #8 Reduce code duplication\nIssue #292 Label all required fields","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/4e54e875eaf07cab9699c8a30f9ed95863206ece"},{"sha":"ce630db7ba251bc415d59d986367b7712fd570e6","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Extract helper to add indexed address to model\n\nSeveral of the form binders store multiple, indexed addresses into sets\nof model variables. Extract the repeated code into a helper method in\n the base class.\n\nRefactoring in preparation to alter behavior around address lines.\n\nIssue #8 Reduce code duplication\nIssue #292 Label all required fields","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/ce630db7ba251bc415d59d986367b7712fd570e6"},{"sha":"598016a4415893cc9b831e2a190bbd94ad157fcc","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Extract helper to add named indexed addrs to model\n\nSeveral of the form binders store multiple, indexed addresses with\ndistinct names into sets of model variables. Extract the repeated code\ninto a helper method in the base class.\n\nRefactoring in preparation to alter behavior around address lines.\n\nIssue #8 Reduce code duplication\nIssue #292 Label all required fields","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/598016a4415893cc9b831e2a190bbd94ad157fcc"},{"sha":"94b60ed6e1b524298f4b412eda7df823ab3c804f","author":{"name":"Jason Owen","email":"158e602a35675d2a0b685478824aa5995557a235@jasonaowen.net"},"message":"Prioritize first line of address fields\n\nThere was a Drools validation rule that required address line 2 to be\npresent if either line 1 or 2 were present. This mismatch with how we\ntypically use address fields in the United States was previously being\n\"fixed\" (or perhaps, more accurately, worked around) by testing (in Java\ncode) if the first line was empty, and if so switch lines 1 and 2. This\npattern was repeated in every place along the boundry between JSPs and\ncontrollers that dealt with addresses.\n\nOne of the places, dealing with the home residence address of the\nindividual ownership interest, did not properly switch the two address\nlines, leading to the second address line being marked as in error when\nneither are filled, rather than the first address line.\n\nI found the logic around switching the address lines very confusing, and\nso rather than fix the symptom, fix the underlying problem: update the\nDrools rule to prioritize address line one rather than address line two,\nand remove all the complexity around switching address lines everywhere\nelse.\n\nIssue #292 Label all required fields","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/94b60ed6e1b524298f4b412eda7df823ab3c804f"},{"sha":"15beb0df863b549dbfbf5ad944af312845833c72","author":{"name":"Jason Owen","email":"bd525e6d3a42bc16a25cf30a75c6392a53bc613a@gmail.com"},"message":"Merge pull request #451 from OpenTechStrategies/292-address-required\n\nFix missing individual owner home address error highlight","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/15beb0df863b549dbfbf5ad944af312845833c72"},{"sha":"5acda7c03b05c93a7e45b9e4a2db527b26132f51","author":{"name":"Sumana Harihareswara","email":"6b9c5a8cc63cc26393836cfe226b723cc4c2777b@changeset.nyc"},"message":"WIP making user docs bundle","distinct":true,"url":"https://api.github.com/repos/brainwane/psm/commits/5acda7c03b05c93a7e45b9e4a2db527b26132f51"}]}
{"actor":{"display_login":"brainwane"}}