{"action":"closed","number":1928,"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/1928","id":135394883,"html_url":"https://github.com/openshift/origin-web-console/pull/1928","diff_url":"https://github.com/openshift/origin-web-console/pull/1928.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/1928.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/1928","number":1928,"state":"closed","locked":false,"title":"[WIP] [DO_NOT_MERGE] POC: move routes to constants.js","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"Per previous conversations, moving routes to `constants.js` would provide an opportunity to override/modify the routes the web console responds to.  If this was done, it is assumed that a set of custom controllers, views, etc would likely be added via extensions as well.\r\n\r\n@spadgett @sspeiche ","created_at":"2017-08-11T18:40:29Z","updated_at":"2017-11-01T19:19:17Z","closed_at":"2017-11-01T19:19:17Z","merged_at":null,"merge_commit_sha":"c101236fcfcf5b67eef2a92bbe9302cf34207a92","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/1928/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/1928/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/1928/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/c60d51ac18e5d59e1a70c225c1531fcefad4971b","head":{"label":"benjaminapetersen:bpeterse/config-routes","ref":"bpeterse/config-routes","sha":"c60d51ac18e5d59e1a70c225c1531fcefad4971b","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"repo":{"id":58689425,"name":"origin-web-console","full_name":"benjaminapetersen/origin-web-console","owner":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminapetersen/origin-web-console","description":null,"fork":true,"url":"https://api.github.com/repos/benjaminapetersen/origin-web-console","forks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/forks","keys_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/teams","hooks_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/events","assignees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/tags","blobs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/subscription","commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/merges","archive_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/downloads","issues_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/benjaminapetersen/origin-web-console/deployments","created_at":"2016-05-13T01:31:58Z","updated_at":"2016-11-28T19:16:36Z","pushed_at":"2017-11-01T19:16:29Z","git_url":"git://github.com/benjaminapetersen/origin-web-console.git","ssh_url":"git@github.com:benjaminapetersen/origin-web-console.git","clone_url":"https://github.com/benjaminapetersen/origin-web-console.git","svn_url":"https://github.com/benjaminapetersen/origin-web-console","homepage":null,"size":59001,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"215a1b55761a1de74546d9b3549900b913f101cb","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2017-10-26T02:34:17Z","pushed_at":"2017-11-01T19:16:31Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":60576,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":123,"forks":137,"open_issues":123,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/1928"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/1928"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/1928"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/1928/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/1928/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/1928/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/c60d51ac18e5d59e1a70c225c1531fcefad4971b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":423,"deletions":393,"changed_files":2}}
{"actor":{"display_login":"benjaminapetersen"}}