{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/3688","repository_url":"https://api.github.com/repos/LMMS/lmms","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/3688/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/3688/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/3688/events","html_url":"https://github.com/LMMS/lmms/pull/3688","id":241390718,"number":3688,"title":"Add AppImage support to Linux builds","user":{"login":"tresf","id":6345473,"avatar_url":"https://avatars3.githubusercontent.com/u/6345473?v=3","gravatar_id":"","url":"https://api.github.com/users/tresf","html_url":"https://github.com/tresf","followers_url":"https://api.github.com/users/tresf/followers","following_url":"https://api.github.com/users/tresf/following{/other_user}","gists_url":"https://api.github.com/users/tresf/gists{/gist_id}","starred_url":"https://api.github.com/users/tresf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tresf/subscriptions","organizations_url":"https://api.github.com/users/tresf/orgs","repos_url":"https://api.github.com/users/tresf/repos","events_url":"https://api.github.com/users/tresf/events{/privacy}","received_events_url":"https://api.github.com/users/tresf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-07-07T21:57:44Z","updated_at":"2017-07-08T21:59:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/3688","html_url":"https://github.com/LMMS/lmms/pull/3688","diff_url":"https://github.com/LMMS/lmms/pull/3688.diff","patch_url":"https://github.com/LMMS/lmms/pull/3688.patch"},"body":"This will create an `.AppImage`  installer in the build directory.  Closes #3558 .\r\n\r\n**Usage:** `make appimage`\r\n\r\nSome caveats:\r\n1. `linuxdeployqt` has some unorthorox rules, the worst of them being installation must be prefixed by `/usr`.  This means our standard `build`, `target` directories can't be used, but instead some custom commands must be used.\r\n   * `CMAKE_INSTALL_PREFIX` must be `/usr` instead of the recommended `../target`\r\n   * `make [...] install` must be prefixed with a `DESTDIR` parameter, which is `../target`.\r\n   * You'll need to do `mkdir ../target/usr` now.\r\n   * If the above aren't true, a [warning appears](https://user-images.githubusercontent.com/6345473/27978355-f54ce0ea-633c-11e7-9675-075816eff6ac.png).\r\n2. Since `DESTDIR` isn't provided until build time, cmake knows nothing about it.  This is bad!  So I just assume the above is exact, which can cause some frustration to people using differently named build directories.\r\n3. I can't yet find a way to specify the [`DESTINATION` ](https://github.com/AppImage/AppImageKit#appimagetool-usage) parameter.  Perhaps @probonopd can shed some light.  I'm pretty sure `shellcheck` won't like the `*.AppImage` command.\r\n4. `RemoteZynAddSubFX` is temporarily broken until we can find a way to fix linking on that.  If it works for you, it's because you have Qt installed.  Machines without Qt won't be able to open the Zyn GUI until this is fixed.\r\n5. The icon isn't working.  Not sure what I'm missing there.\r\n6. Registering LMMS and associating its files isn't yet tested and needs some work.\r\n\r\n![image](https://user-images.githubusercontent.com/6345473/27978504-c53953ba-633d-11e7-8e46-71fd3518b7fd.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/313883420","html_url":"https://github.com/LMMS/lmms/pull/3688#issuecomment-313883420","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/3688","id":313883420,"user":{"login":"probonopd","id":2480569,"avatar_url":"https://avatars0.githubusercontent.com/u/2480569?v=3","gravatar_id":"","url":"https://api.github.com/users/probonopd","html_url":"https://github.com/probonopd","followers_url":"https://api.github.com/users/probonopd/followers","following_url":"https://api.github.com/users/probonopd/following{/other_user}","gists_url":"https://api.github.com/users/probonopd/gists{/gist_id}","starred_url":"https://api.github.com/users/probonopd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/probonopd/subscriptions","organizations_url":"https://api.github.com/users/probonopd/orgs","repos_url":"https://api.github.com/users/probonopd/repos","events_url":"https://api.github.com/users/probonopd/events{/privacy}","received_events_url":"https://api.github.com/users/probonopd/received_events","type":"User","site_admin":false},"created_at":"2017-07-08T21:59:00Z","updated_at":"2017-07-08T21:59:00Z","body":"`linuxeployqt` has no `DESTINATION` parameter. The name of the AppImage is automatically determined based on the `Name=` entry in the desktop file. (The message you see in the log comes from the underlying `appimagetool` that is being used.)\r\n\r\nYou don't need to use an `*.AppImage` command tough. Just replace the Asterisk with the real name, should be fine."}}
{"actor":{"display_login":"probonopd"}}