{"action":"created","comment":{"url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments/135327342","pull_request_review_id":58733280,"id":135327342,"diff_hunk":"@@ -99,6 +114,107 @@ const Metrics = SparkPlugin.extend({\n       eventPayload: payload\n     };\n     return this.callDiagnosticEventsBatcher.request(event);\n+  },\n+\n+  storeMetric(id, metricProps, metricType) {\n+    const tuple = {metric: metricProps, type: metricType};\n+    return this.metricMap.set(id, tuple);\n+  },\n+\n+  getMetrics() {","path":"packages/node_modules/@ciscospark/internal-plugin-metrics/src/metrics.js","position":81,"original_position":81,"commit_id":"568d7811100f3f3d37384a71026cbe9cdef7eb0f","original_commit_id":"568d7811100f3f3d37384a71026cbe9cdef7eb0f","user":{"login":"UWTech","id":4643729,"avatar_url":"https://avatars1.githubusercontent.com/u/4643729?v=4","gravatar_id":"","url":"https://api.github.com/users/UWTech","html_url":"https://github.com/UWTech","followers_url":"https://api.github.com/users/UWTech/followers","following_url":"https://api.github.com/users/UWTech/following{/other_user}","gists_url":"https://api.github.com/users/UWTech/gists{/gist_id}","starred_url":"https://api.github.com/users/UWTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UWTech/subscriptions","organizations_url":"https://api.github.com/users/UWTech/orgs","repos_url":"https://api.github.com/users/UWTech/repos","events_url":"https://api.github.com/users/UWTech/events{/privacy}","received_events_url":"https://api.github.com/users/UWTech/received_events","type":"User","site_admin":false},"body":"done\r\n","created_at":"2017-08-25T18:41:51Z","updated_at":"2017-08-25T18:41:51Z","html_url":"https://github.com/ciscospark/spark-js-sdk/pull/682#discussion_r135327342","pull_request_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/682","_links":{"self":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments/135327342"},"html":{"href":"https://github.com/ciscospark/spark-js-sdk/pull/682#discussion_r135327342"},"pull_request":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/682"}},"in_reply_to_id":135125465},"pull_request":{"url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/682","id":136567333,"html_url":"https://github.com/ciscospark/spark-js-sdk/pull/682","diff_url":"https://github.com/ciscospark/spark-js-sdk/pull/682.diff","patch_url":"https://github.com/ciscospark/spark-js-sdk/pull/682.patch","issue_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/682","number":682,"state":"open","locked":false,"title":"Shared metrics context (Client -> SDK, SDK -> Client)","user":{"login":"UWTech","id":4643729,"avatar_url":"https://avatars1.githubusercontent.com/u/4643729?v=4","gravatar_id":"","url":"https://api.github.com/users/UWTech","html_url":"https://github.com/UWTech","followers_url":"https://api.github.com/users/UWTech/followers","following_url":"https://api.github.com/users/UWTech/following{/other_user}","gists_url":"https://api.github.com/users/UWTech/gists{/gist_id}","starred_url":"https://api.github.com/users/UWTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UWTech/subscriptions","organizations_url":"https://api.github.com/users/UWTech/orgs","repos_url":"https://api.github.com/users/UWTech/repos","events_url":"https://api.github.com/users/UWTech/events{/privacy}","received_events_url":"https://api.github.com/users/UWTech/received_events","type":"User","site_admin":false},"body":"Add shared context for metrics between Client and SDK","created_at":"2017-08-18T21:24:22Z","updated_at":"2017-08-25T18:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73c3982c5b015b5f9448b23cb42638e29a1d96ea","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/682/commits","review_comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/682/comments","review_comment_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/682/comments","statuses_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/568d7811100f3f3d37384a71026cbe9cdef7eb0f","head":{"label":"UWTech:eamaguir-metrics","ref":"eamaguir-metrics","sha":"568d7811100f3f3d37384a71026cbe9cdef7eb0f","user":{"login":"UWTech","id":4643729,"avatar_url":"https://avatars1.githubusercontent.com/u/4643729?v=4","gravatar_id":"","url":"https://api.github.com/users/UWTech","html_url":"https://github.com/UWTech","followers_url":"https://api.github.com/users/UWTech/followers","following_url":"https://api.github.com/users/UWTech/following{/other_user}","gists_url":"https://api.github.com/users/UWTech/gists{/gist_id}","starred_url":"https://api.github.com/users/UWTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UWTech/subscriptions","organizations_url":"https://api.github.com/users/UWTech/orgs","repos_url":"https://api.github.com/users/UWTech/repos","events_url":"https://api.github.com/users/UWTech/events{/privacy}","received_events_url":"https://api.github.com/users/UWTech/received_events","type":"User","site_admin":false},"repo":{"id":100750829,"name":"spark-js-sdk","full_name":"UWTech/spark-js-sdk","owner":{"login":"UWTech","id":4643729,"avatar_url":"https://avatars1.githubusercontent.com/u/4643729?v=4","gravatar_id":"","url":"https://api.github.com/users/UWTech","html_url":"https://github.com/UWTech","followers_url":"https://api.github.com/users/UWTech/followers","following_url":"https://api.github.com/users/UWTech/following{/other_user}","gists_url":"https://api.github.com/users/UWTech/gists{/gist_id}","starred_url":"https://api.github.com/users/UWTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UWTech/subscriptions","organizations_url":"https://api.github.com/users/UWTech/orgs","repos_url":"https://api.github.com/users/UWTech/repos","events_url":"https://api.github.com/users/UWTech/events{/privacy}","received_events_url":"https://api.github.com/users/UWTech/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UWTech/spark-js-sdk","description":"JavaScript SDK for CiscoSpark","fork":true,"url":"https://api.github.com/repos/UWTech/spark-js-sdk","forks_url":"https://api.github.com/repos/UWTech/spark-js-sdk/forks","keys_url":"https://api.github.com/repos/UWTech/spark-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UWTech/spark-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UWTech/spark-js-sdk/teams","hooks_url":"https://api.github.com/repos/UWTech/spark-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/UWTech/spark-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/UWTech/spark-js-sdk/events","assignees_url":"https://api.github.com/repos/UWTech/spark-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/UWTech/spark-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/UWTech/spark-js-sdk/tags","blobs_url":"https://api.github.com/repos/UWTech/spark-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UWTech/spark-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UWTech/spark-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/UWTech/spark-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UWTech/spark-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/UWTech/spark-js-sdk/languages","stargazers_url":"https://api.github.com/repos/UWTech/spark-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/UWTech/spark-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/UWTech/spark-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/UWTech/spark-js-sdk/subscription","commits_url":"https://api.github.com/repos/UWTech/spark-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/UWTech/spark-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/UWTech/spark-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/UWTech/spark-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/UWTech/spark-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/UWTech/spark-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UWTech/spark-js-sdk/merges","archive_url":"https://api.github.com/repos/UWTech/spark-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UWTech/spark-js-sdk/downloads","issues_url":"https://api.github.com/repos/UWTech/spark-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/UWTech/spark-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/UWTech/spark-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/UWTech/spark-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UWTech/spark-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/UWTech/spark-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/UWTech/spark-js-sdk/deployments","created_at":"2017-08-18T21:17:24Z","updated_at":"2017-08-18T21:17:27Z","pushed_at":"2017-08-18T21:22:36Z","git_url":"git://github.com/UWTech/spark-js-sdk.git","ssh_url":"git@github.com:UWTech/spark-js-sdk.git","clone_url":"https://github.com/UWTech/spark-js-sdk.git","svn_url":"https://github.com/UWTech/spark-js-sdk","homepage":"https://ciscospark.github.io/spark-js-sdk/","size":40839,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciscospark:master","ref":"master","sha":"1a8bffede141b0a65ebde1f1eca4cc01c95e2c7b","user":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars0.githubusercontent.com/u/15900782?v=4","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"repo":{"id":62836827,"name":"spark-js-sdk","full_name":"ciscospark/spark-js-sdk","owner":{"login":"ciscospark","id":15900782,"avatar_url":"https://avatars0.githubusercontent.com/u/15900782?v=4","gravatar_id":"","url":"https://api.github.com/users/ciscospark","html_url":"https://github.com/ciscospark","followers_url":"https://api.github.com/users/ciscospark/followers","following_url":"https://api.github.com/users/ciscospark/following{/other_user}","gists_url":"https://api.github.com/users/ciscospark/gists{/gist_id}","starred_url":"https://api.github.com/users/ciscospark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciscospark/subscriptions","organizations_url":"https://api.github.com/users/ciscospark/orgs","repos_url":"https://api.github.com/users/ciscospark/repos","events_url":"https://api.github.com/users/ciscospark/events{/privacy}","received_events_url":"https://api.github.com/users/ciscospark/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciscospark/spark-js-sdk","description":"JavaScript SDK for CiscoSpark","fork":false,"url":"https://api.github.com/repos/ciscospark/spark-js-sdk","forks_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/forks","keys_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/teams","hooks_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/events","assignees_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/tags","blobs_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/languages","stargazers_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/subscription","commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/merges","archive_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/downloads","issues_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/ciscospark/spark-js-sdk/deployments","created_at":"2016-07-07T20:41:12Z","updated_at":"2017-07-25T08:33:51Z","pushed_at":"2017-08-25T00:59:23Z","git_url":"git://github.com/ciscospark/spark-js-sdk.git","ssh_url":"git@github.com:ciscospark/spark-js-sdk.git","clone_url":"https://github.com/ciscospark/spark-js-sdk.git","svn_url":"https://github.com/ciscospark/spark-js-sdk","homepage":"https://ciscospark.github.io/spark-js-sdk/","size":40835,"stargazers_count":39,"watchers_count":39,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":100,"forks":56,"open_issues":100,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/682"},"html":{"href":"https://github.com/ciscospark/spark-js-sdk/pull/682"},"issue":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/682"},"comments":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/issues/682/comments"},"review_comments":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/682/comments"},"review_comment":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/pulls/682/commits"},"statuses":{"href":"https://api.github.com/repos/ciscospark/spark-js-sdk/statuses/568d7811100f3f3d37384a71026cbe9cdef7eb0f"}}}}
{"actor":{"display_login":"UWTech"}}