{"action":"created","issue":{"url":"https://api.github.com/repos/endlessm/eos-updater/issues/47","repository_url":"https://api.github.com/repos/endlessm/eos-updater","labels_url":"https://api.github.com/repos/endlessm/eos-updater/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/endlessm/eos-updater/issues/47/comments","events_url":"https://api.github.com/repos/endlessm/eos-updater/issues/47/events","html_url":"https://github.com/endlessm/eos-updater/pull/47","id":203178370,"number":47,"title":"T14894 kinvolk","user":{"login":"pwithnall","id":53172,"avatar_url":"https://avatars.githubusercontent.com/u/53172?v=3","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pwithnall","id":53172,"avatar_url":"https://avatars.githubusercontent.com/u/53172?v=3","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false},"assignees":[{"login":"pwithnall","id":53172,"avatar_url":"https://avatars.githubusercontent.com/u/53172?v=3","gravatar_id":"","url":"https://api.github.com/users/pwithnall","html_url":"https://github.com/pwithnall","followers_url":"https://api.github.com/users/pwithnall/followers","following_url":"https://api.github.com/users/pwithnall/following{/other_user}","gists_url":"https://api.github.com/users/pwithnall/gists{/gist_id}","starred_url":"https://api.github.com/users/pwithnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwithnall/subscriptions","organizations_url":"https://api.github.com/users/pwithnall/orgs","repos_url":"https://api.github.com/users/pwithnall/repos","events_url":"https://api.github.com/users/pwithnall/events{/privacy}","received_events_url":"https://api.github.com/users/pwithnall/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-01-25T18:03:48Z","updated_at":"2017-02-13T18:54:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-updater/pulls/47","html_url":"https://github.com/endlessm/eos-updater/pull/47","diff_url":"https://github.com/endlessm/eos-updater/pull/47.diff","patch_url":"https://github.com/endlessm/eos-updater/pull/47.patch"},"body":"PR to merge the work by Kinvolk on adding LAN and USB support for `eos-updater`. The commits by Krzesimir have all been reviewed by Kinvolk and myself, so only need a cursory review — although their use of `/ostree/repo/extensions` for storing new metadata could do with some investigation. It’s probably best if I write this up in the task before anyone looks at it though. The commits by me all need review. They are either fixes for problems I’ve found through code review of the branch; or fixes for problems I found while reading the `eos-updater` code to get more familiar with it. I have deliberately not squashed my fixes into the commits from Kinvolk so they can be reviewed separately. However, I have rebased them to be in the right place in the commit history as much as I could.\r\n\r\nI am still in the process of testing this manually, and I am aware that one of the recent commits (e5cbfacb) broke `make check`. I will fix that tomorrow morning (did some debugging tonight and am not really sure what’s going on yet). I have not yet got LAN updates working with my local testing, although they may be closer to working with the latest patches on the branch — I haven’t yet had a chance to re-test due to `make check` failing.\r\n\r\nAccordingly, this cannot be merged yet; but will hopefully be mergeable by the end of the week. So if you could time your reviews accordingly, that would be great. Thanks!\r\n\r\n---\r\n\r\nhttps://phabricator.endlessm.com/T14894"},"comment":{"url":"https://api.github.com/repos/endlessm/eos-updater/issues/comments/279485884","html_url":"https://github.com/endlessm/eos-updater/pull/47#issuecomment-279485884","issue_url":"https://api.github.com/repos/endlessm/eos-updater/issues/47","id":279485884,"user":{"login":"dbnicholson","id":6495518,"avatar_url":"https://avatars.githubusercontent.com/u/6495518?v=3","gravatar_id":"","url":"https://api.github.com/users/dbnicholson","html_url":"https://github.com/dbnicholson","followers_url":"https://api.github.com/users/dbnicholson/followers","following_url":"https://api.github.com/users/dbnicholson/following{/other_user}","gists_url":"https://api.github.com/users/dbnicholson/gists{/gist_id}","starred_url":"https://api.github.com/users/dbnicholson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbnicholson/subscriptions","organizations_url":"https://api.github.com/users/dbnicholson/orgs","repos_url":"https://api.github.com/users/dbnicholson/repos","events_url":"https://api.github.com/users/dbnicholson/events{/privacy}","received_events_url":"https://api.github.com/users/dbnicholson/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T18:54:19Z","updated_at":"2017-02-13T18:54:19Z","body":"All looks good to me now. Do you still want review from others or should we merge?"}}
{"actor":{"display_login":"dbnicholson"}}