{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20801","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20801/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20801/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20801/events","html_url":"https://github.com/cockroachdb/cockroach/pull/20801","id":282949084,"number":20801,"title":"sql: reduce the async schema changer wait time to approx 30s","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars1.githubusercontent.com/u/11774212?v=4","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-12-18T16:55:57Z","updated_at":"2017-12-18T20:34:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/20801","html_url":"https://github.com/cockroachdb/cockroach/pull/20801","diff_url":"https://github.com/cockroachdb/cockroach/pull/20801.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/20801.patch"},"body":"This allows the async schema changer to kick in faster.\r\n\r\nThis change also fixes a bug in resetting the wait time. The\r\nwait time was being reset on a local variable.\r\n\r\nfixes #20488\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/352549659","html_url":"https://github.com/cockroachdb/cockroach/pull/20801#issuecomment-352549659","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/20801","id":352549659,"user":{"login":"lego","id":1161183,"avatar_url":"https://avatars0.githubusercontent.com/u/1161183?v=4","gravatar_id":"","url":"https://api.github.com/users/lego","html_url":"https://github.com/lego","followers_url":"https://api.github.com/users/lego/followers","following_url":"https://api.github.com/users/lego/following{/other_user}","gists_url":"https://api.github.com/users/lego/gists{/gist_id}","starred_url":"https://api.github.com/users/lego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lego/subscriptions","organizations_url":"https://api.github.com/users/lego/orgs","repos_url":"https://api.github.com/users/lego/repos","events_url":"https://api.github.com/users/lego/events{/privacy}","received_events_url":"https://api.github.com/users/lego/received_events","type":"User","site_admin":false},"created_at":"2017-12-18T20:34:05Z","updated_at":"2017-12-18T20:34:05Z","author_association":"MEMBER","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions, some commit checks pending.\n\n---\n\n*[pkg/sql/schema_changer.go, line 993 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/20801#-L0eYR9H0YvdX9tD1yqY-r1-993:-L0fJohbPgP335lt2hVV:b-qod7uq) ([raw file](https://github.com/cockroachdb/cockroach/blob/b68aab2ddb89c51e99d5d46a91c7b9d0de735550/pkg/sql/schema_changer.go#L993)):*\n<details><summary><i>Previously, vivekmenezes wrote…</i></summary><blockquote>\n\nah ha, sorry didn't see that there were applied to two tables. So the session will only return after the COMMIT once it sees both schema changes as having completed. The first one will be run by it and the second by the async path.\n</blockquote></details>\n\nBringing this in from direct messages: the retry continues as long as it's a retry-able error and until this succeeds, meaning it will indeed correctly wait for the async execution to finish before returning success here! I was working on the assumption it failed after a small-ish period of time. :)\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/20801)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"lego"}}