{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/146474657","pull_request_review_id":71419770,"id":146474657,"diff_hunk":"@@ -0,0 +1,44 @@\n+/***************************************************************************\n+                              qgsvscrollarea.h\n+                              ------------------------\n+  begin                : September 2017\n+  copyright            : (C) 2017 Sandro Mani\n+  email                : manisandro at gmail dot com\n+ ***************************************************************************/\n+\n+/***************************************************************************\n+ *                                                                         *\n+ *   This program is free software; you can redistribute it and/or modify  *\n+ *   it under the terms of the GNU General Public License as published by  *\n+ *   the Free Software Foundation; either version 2 of the License, or     *\n+ *   (at your option) any later version.                                   *\n+ *                                                                         *\n+ ***************************************************************************/\n+\n+#ifndef QGSVSCROLLAREA_H\n+#define QGSVSCROLLAREA_H\n+\n+#include \"qgis_gui.h\"\n+#include <QScrollArea>\n+\n+/**\n+ * \\ingroup gui\n+ * QgsVScrollArea is a QScrollArea subclass which only displays a vertical\n+ * scrollbar and fits the width to the contents.\n+ *\n+ * \\since QGIS 3.0\n+ */\n+class GUI_EXPORT QgsVScrollArea : public QScrollArea","path":"src/gui/qgsvscrollarea.h","position":31,"original_position":31,"commit_id":"8421a7e0d8fbe6d698517e40f53e84b559c4dcea","original_commit_id":"8421a7e0d8fbe6d698517e40f53e84b559c4dcea","user":{"login":"manisandro","id":1298852,"avatar_url":"https://avatars0.githubusercontent.com/u/1298852?v=4","gravatar_id":"","url":"https://api.github.com/users/manisandro","html_url":"https://github.com/manisandro","followers_url":"https://api.github.com/users/manisandro/followers","following_url":"https://api.github.com/users/manisandro/following{/other_user}","gists_url":"https://api.github.com/users/manisandro/gists{/gist_id}","starred_url":"https://api.github.com/users/manisandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manisandro/subscriptions","organizations_url":"https://api.github.com/users/manisandro/orgs","repos_url":"https://api.github.com/users/manisandro/repos","events_url":"https://api.github.com/users/manisandro/events{/privacy}","received_events_url":"https://api.github.com/users/manisandro/received_events","type":"User","site_admin":false},"body":"Ah yes, done in bb21395, thanks.","created_at":"2017-10-24T07:39:42Z","updated_at":"2017-10-24T07:39:43Z","html_url":"https://github.com/qgis/QGIS/pull/5410#discussion_r146474657","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/5410","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/146474657"},"html":{"href":"https://github.com/qgis/QGIS/pull/5410#discussion_r146474657"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/5410"}},"in_reply_to_id":146435095},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/5410","id":147657964,"html_url":"https://github.com/qgis/QGIS/pull/5410","diff_url":"https://github.com/qgis/QGIS/pull/5410.diff","patch_url":"https://github.com/qgis/QGIS/pull/5410.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/5410","number":5410,"state":"closed","locked":false,"title":"[FEATURE][Geometry checker] Support checking multiple layers at once, add new checks","user":{"login":"manisandro","id":1298852,"avatar_url":"https://avatars0.githubusercontent.com/u/1298852?v=4","gravatar_id":"","url":"https://api.github.com/users/manisandro","html_url":"https://github.com/manisandro","followers_url":"https://api.github.com/users/manisandro/followers","following_url":"https://api.github.com/users/manisandro/following{/other_user}","gists_url":"https://api.github.com/users/manisandro/gists{/gist_id}","starred_url":"https://api.github.com/users/manisandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manisandro/subscriptions","organizations_url":"https://api.github.com/users/manisandro/orgs","repos_url":"https://api.github.com/users/manisandro/repos","events_url":"https://api.github.com/users/manisandro/events{/privacy}","received_events_url":"https://api.github.com/users/manisandro/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis is a fairly big update to the geometry checker, which besides restoring it's functionality (currently it's completely broken):\r\n- Adds support for checking multiple layers at once\r\n- Adds a series of new checks:\r\n  * Linie Must Not Intersect With...\r\n  * Point Must be properly inside polygons\r\n  * Linie Must Not Intersect\r\n  * Linie Must Not Have Dangles\r\n  * Point Must Not Have Duplicates\r\n  * Point Must Be Covered By Line\r\n  * Linie must not intersect with layer\r\n- Moves the core components to qgis_analysis, the plugin now only contains the user interface\r\n- Adds tests for all checks\r\n\r\nThere might still be some rough edges here and there, so testing feedback is very welcome. Overall it should however already be pretty stable.\r\n","created_at":"2017-10-19T20:30:04Z","updated_at":"2017-10-24T07:39:43Z","closed_at":"2017-10-23T21:32:46Z","merged_at":"2017-10-23T21:32:46Z","merge_commit_sha":"ea0e09b322d484fcdee299171c5381146a2814a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/5410/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/5410/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/5410/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/8421a7e0d8fbe6d698517e40f53e84b559c4dcea","head":{"label":"manisandro:geomchecker","ref":"geomchecker","sha":"8421a7e0d8fbe6d698517e40f53e84b559c4dcea","user":{"login":"manisandro","id":1298852,"avatar_url":"https://avatars0.githubusercontent.com/u/1298852?v=4","gravatar_id":"","url":"https://api.github.com/users/manisandro","html_url":"https://github.com/manisandro","followers_url":"https://api.github.com/users/manisandro/followers","following_url":"https://api.github.com/users/manisandro/following{/other_user}","gists_url":"https://api.github.com/users/manisandro/gists{/gist_id}","starred_url":"https://api.github.com/users/manisandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manisandro/subscriptions","organizations_url":"https://api.github.com/users/manisandro/orgs","repos_url":"https://api.github.com/users/manisandro/repos","events_url":"https://api.github.com/users/manisandro/events{/privacy}","received_events_url":"https://api.github.com/users/manisandro/received_events","type":"User","site_admin":false},"repo":{"id":18176399,"name":"QGIS","full_name":"manisandro/QGIS","owner":{"login":"manisandro","id":1298852,"avatar_url":"https://avatars0.githubusercontent.com/u/1298852?v=4","gravatar_id":"","url":"https://api.github.com/users/manisandro","html_url":"https://github.com/manisandro","followers_url":"https://api.github.com/users/manisandro/followers","following_url":"https://api.github.com/users/manisandro/following{/other_user}","gists_url":"https://api.github.com/users/manisandro/gists{/gist_id}","starred_url":"https://api.github.com/users/manisandro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manisandro/subscriptions","organizations_url":"https://api.github.com/users/manisandro/orgs","repos_url":"https://api.github.com/users/manisandro/repos","events_url":"https://api.github.com/users/manisandro/events{/privacy}","received_events_url":"https://api.github.com/users/manisandro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manisandro/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/manisandro/QGIS","forks_url":"https://api.github.com/repos/manisandro/QGIS/forks","keys_url":"https://api.github.com/repos/manisandro/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manisandro/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manisandro/QGIS/teams","hooks_url":"https://api.github.com/repos/manisandro/QGIS/hooks","issue_events_url":"https://api.github.com/repos/manisandro/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/manisandro/QGIS/events","assignees_url":"https://api.github.com/repos/manisandro/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/manisandro/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/manisandro/QGIS/tags","blobs_url":"https://api.github.com/repos/manisandro/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manisandro/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manisandro/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/manisandro/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manisandro/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/manisandro/QGIS/languages","stargazers_url":"https://api.github.com/repos/manisandro/QGIS/stargazers","contributors_url":"https://api.github.com/repos/manisandro/QGIS/contributors","subscribers_url":"https://api.github.com/repos/manisandro/QGIS/subscribers","subscription_url":"https://api.github.com/repos/manisandro/QGIS/subscription","commits_url":"https://api.github.com/repos/manisandro/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/manisandro/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/manisandro/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/manisandro/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/manisandro/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/manisandro/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manisandro/QGIS/merges","archive_url":"https://api.github.com/repos/manisandro/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manisandro/QGIS/downloads","issues_url":"https://api.github.com/repos/manisandro/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/manisandro/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/manisandro/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/manisandro/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manisandro/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/manisandro/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/manisandro/QGIS/deployments","created_at":"2014-03-27T13:18:36Z","updated_at":"2016-09-21T06:53:02Z","pushed_at":"2017-10-24T07:38:24Z","git_url":"git://github.com/manisandro/QGIS.git","ssh_url":"git@github.com:manisandro/QGIS.git","clone_url":"https://github.com/manisandro/QGIS.git","svn_url":"https://github.com/manisandro/QGIS","homepage":"http://qgis.org","size":1249864,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"e3fc73f41eee2ed9bf1fc21952cdc5a8fa9c17ca","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2017-10-24T07:12:10Z","pushed_at":"2017-10-24T07:38:56Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1328911,"stargazers_count":1604,"watchers_count":1604,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1128,"mirror_url":null,"archived":false,"open_issues_count":108,"forks":1128,"open_issues":108,"watchers":1604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/5410"},"html":{"href":"https://github.com/qgis/QGIS/pull/5410"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/5410"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/5410/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/5410/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/5410/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/8421a7e0d8fbe6d698517e40f53e84b559c4dcea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"manisandro"}}