{"action":"created","comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/139854686","pull_request_review_id":63844395,"id":139854686,"diff_hunk":"@@ -436,11 +435,11 @@ public ServerSession getCoreSession() {\n    public ActiveMQServer getCoreServer() {\n       return this.server;\n    }\n-\n+/*","path":"artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQSession.java","position":null,"original_position":22,"commit_id":"8652b3f45be96188745bd06ec0d26c01ca00632b","original_commit_id":"f84d26ebb26b0c424ae90f994fc1aa673bbad88f","user":{"login":"gaohoward","id":686319,"avatar_url":"https://avatars2.githubusercontent.com/u/686319?v=4","gravatar_id":"","url":"https://api.github.com/users/gaohoward","html_url":"https://github.com/gaohoward","followers_url":"https://api.github.com/users/gaohoward/followers","following_url":"https://api.github.com/users/gaohoward/following{/other_user}","gists_url":"https://api.github.com/users/gaohoward/gists{/gist_id}","starred_url":"https://api.github.com/users/gaohoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaohoward/subscriptions","organizations_url":"https://api.github.com/users/gaohoward/orgs","repos_url":"https://api.github.com/users/gaohoward/repos","events_url":"https://api.github.com/users/gaohoward/events{/privacy}","received_events_url":"https://api.github.com/users/gaohoward/received_events","type":"User","site_admin":false},"body":"doh, forgot it. I think I commented it out back then thinking it might be used somewhere else.\r\nThanks @tabish121 . Branch updated.","created_at":"2017-09-20T01:03:08Z","updated_at":"2017-09-20T01:03:08Z","html_url":"https://github.com/apache/activemq-artemis/pull/1542#discussion_r139854686","pull_request_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1542","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/139854686"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/1542#discussion_r139854686"},"pull_request":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/1542"}},"in_reply_to_id":139834842},"pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1542","id":141729915,"html_url":"https://github.com/apache/activemq-artemis/pull/1542","diff_url":"https://github.com/apache/activemq-artemis/pull/1542.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/1542.patch","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/1542","number":1542,"state":"open","locked":false,"title":"ARTEMIS-1424 Openwire not work with different tightEncoding options","user":{"login":"gaohoward","id":686319,"avatar_url":"https://avatars2.githubusercontent.com/u/686319?v=4","gravatar_id":"","url":"https://api.github.com/users/gaohoward","html_url":"https://github.com/gaohoward","followers_url":"https://api.github.com/users/gaohoward/followers","following_url":"https://api.github.com/users/gaohoward/following{/other_user}","gists_url":"https://api.github.com/users/gaohoward/gists{/gist_id}","starred_url":"https://api.github.com/users/gaohoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaohoward/subscriptions","organizations_url":"https://api.github.com/users/gaohoward/orgs","repos_url":"https://api.github.com/users/gaohoward/repos","events_url":"https://api.github.com/users/gaohoward/events{/privacy}","received_events_url":"https://api.github.com/users/gaohoward/received_events","type":"User","site_admin":false},"body":"If message senders and receivers uses different\r\nwireformat.tightEncodingEnabled options, broker will get marshalling\r\nproblem. This is because when openwire messages are converted to\r\ncore messages, and later these core messages converted to openwire\r\nmessages, the broker uses a mashaller that comes with the connection\r\nused to carry the messages.\r\n\r\nFor example, if a producer sents a message using option \"wireformat\r\n.tightEncodingEnabled=false\" and a receiver tries to receive it\r\nusing 'true' for the same option, it'll never get it because the\r\nbroker will fail to use a \"tight encoding\" marshaller to\r\ndecode a 'loose encoded' message.\r\n\r\nTo fix the problem, we always use 'tight encoding' for internal\r\nmessage converters.","created_at":"2017-09-18T23:52:53Z","updated_at":"2017-09-20T01:03:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34f002b3dd1f39c18e8ee3e95507b94170793638","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1542/commits","review_comments_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1542/comments","review_comment_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/1542/comments","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/8652b3f45be96188745bd06ec0d26c01ca00632b","head":{"label":"gaohoward:gentmq-743","ref":"gentmq-743","sha":"8652b3f45be96188745bd06ec0d26c01ca00632b","user":{"login":"gaohoward","id":686319,"avatar_url":"https://avatars2.githubusercontent.com/u/686319?v=4","gravatar_id":"","url":"https://api.github.com/users/gaohoward","html_url":"https://github.com/gaohoward","followers_url":"https://api.github.com/users/gaohoward/followers","following_url":"https://api.github.com/users/gaohoward/following{/other_user}","gists_url":"https://api.github.com/users/gaohoward/gists{/gist_id}","starred_url":"https://api.github.com/users/gaohoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaohoward/subscriptions","organizations_url":"https://api.github.com/users/gaohoward/orgs","repos_url":"https://api.github.com/users/gaohoward/repos","events_url":"https://api.github.com/users/gaohoward/events{/privacy}","received_events_url":"https://api.github.com/users/gaohoward/received_events","type":"User","site_admin":false},"repo":{"id":36488671,"name":"activemq-artemis","full_name":"gaohoward/activemq-artemis","owner":{"login":"gaohoward","id":686319,"avatar_url":"https://avatars2.githubusercontent.com/u/686319?v=4","gravatar_id":"","url":"https://api.github.com/users/gaohoward","html_url":"https://github.com/gaohoward","followers_url":"https://api.github.com/users/gaohoward/followers","following_url":"https://api.github.com/users/gaohoward/following{/other_user}","gists_url":"https://api.github.com/users/gaohoward/gists{/gist_id}","starred_url":"https://api.github.com/users/gaohoward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaohoward/subscriptions","organizations_url":"https://api.github.com/users/gaohoward/orgs","repos_url":"https://api.github.com/users/gaohoward/repos","events_url":"https://api.github.com/users/gaohoward/events{/privacy}","received_events_url":"https://api.github.com/users/gaohoward/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaohoward/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":true,"url":"https://api.github.com/repos/gaohoward/activemq-artemis","forks_url":"https://api.github.com/repos/gaohoward/activemq-artemis/forks","keys_url":"https://api.github.com/repos/gaohoward/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaohoward/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaohoward/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/gaohoward/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/gaohoward/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/gaohoward/activemq-artemis/events","assignees_url":"https://api.github.com/repos/gaohoward/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/gaohoward/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/gaohoward/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/gaohoward/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaohoward/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaohoward/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaohoward/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaohoward/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/gaohoward/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/gaohoward/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/gaohoward/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/gaohoward/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/gaohoward/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/gaohoward/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaohoward/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaohoward/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaohoward/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaohoward/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/gaohoward/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaohoward/activemq-artemis/merges","archive_url":"https://api.github.com/repos/gaohoward/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaohoward/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/gaohoward/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/gaohoward/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/gaohoward/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/gaohoward/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaohoward/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/gaohoward/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/gaohoward/activemq-artemis/deployments","created_at":"2015-05-29T07:31:52Z","updated_at":"2015-05-29T07:32:02Z","pushed_at":"2017-09-20T01:01:18Z","git_url":"git://github.com/gaohoward/activemq-artemis.git","ssh_url":"git@github.com:gaohoward/activemq-artemis.git","clone_url":"https://github.com/gaohoward/activemq-artemis.git","svn_url":"https://github.com/gaohoward/activemq-artemis","homepage":"","size":45973,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bdb19842392de4dad68dd9b44b7c3a4b7d7d83cf","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36057260,"name":"activemq-artemis","full_name":"apache/activemq-artemis","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":false,"url":"https://api.github.com/repos/apache/activemq-artemis","forks_url":"https://api.github.com/repos/apache/activemq-artemis/forks","keys_url":"https://api.github.com/repos/apache/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/apache/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/apache/activemq-artemis/events","assignees_url":"https://api.github.com/repos/apache/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/apache/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/apache/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/apache/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/apache/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/apache/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/apache/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/apache/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/apache/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/apache/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/activemq-artemis/merges","archive_url":"https://api.github.com/repos/apache/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/apache/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/apache/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/apache/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/apache/activemq-artemis/deployments","created_at":"2015-05-22T07:00:05Z","updated_at":"2017-09-18T09:10:07Z","pushed_at":"2017-09-20T01:01:20Z","git_url":"git://github.com/apache/activemq-artemis.git","ssh_url":"git@github.com:apache/activemq-artemis.git","clone_url":"https://github.com/apache/activemq-artemis.git","svn_url":"https://github.com/apache/activemq-artemis","homepage":"","size":44747,"stargazers_count":226,"watchers_count":226,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":269,"mirror_url":"git://git.apache.org/activemq-artemis.git","open_issues_count":12,"forks":269,"open_issues":12,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/1542"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/1542"},"issue":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/1542"},"comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/1542/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/1542/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/1542/commits"},"statuses":{"href":"https://api.github.com/repos/apache/activemq-artemis/statuses/8652b3f45be96188745bd06ec0d26c01ca00632b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gaohoward"}}