{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/137106144","pull_request_review_id":60731089,"id":137106144,"diff_hunk":"@@ -0,0 +1,86 @@\n+import os\n+import time\n+\n+import requests\n+\n+from test_packaging import (\n+    _skipif_insufficient_resources\n+)\n+\n+DEMO_RESOURCE_REQUIREMENTS = {\n+    'number_of_nodes': 5,\n+    'node': {\n+        'disk': 0,\n+        'mem': 0,\n+        'cpus': 1\n+    }\n+}\n+\n+\n+def _get_tweeter_app_definition():\n+    response = requests.get('https://raw.githubusercontent.com/mesosphere/tweeter/master/tweeter.json')\n+    return response.json()\n+\n+\n+def _get_post_tweets_app_definition():\n+    response = requests.get('https://raw.githubusercontent.com/mesosphere/tweeter/master/post-tweets.json')\n+    return response.json()","path":"packages/dcos-integration-test/extra/test_tweeter_demo.py","position":30,"original_position":27,"commit_id":"a5733e02e1dcde4561c93ed8685a4e96e191468f","original_commit_id":"00d9fb9000ce885e8f37c0bdf9f03eb39a7eca54","user":{"login":"margaret","id":1811496,"avatar_url":"https://avatars1.githubusercontent.com/u/1811496?v=4","gravatar_id":"","url":"https://api.github.com/users/margaret","html_url":"https://github.com/margaret","followers_url":"https://api.github.com/users/margaret/followers","following_url":"https://api.github.com/users/margaret/following{/other_user}","gists_url":"https://api.github.com/users/margaret/gists{/gist_id}","starred_url":"https://api.github.com/users/margaret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margaret/subscriptions","organizations_url":"https://api.github.com/users/margaret/orgs","repos_url":"https://api.github.com/users/margaret/repos","events_url":"https://api.github.com/users/margaret/events{/privacy}","received_events_url":"https://api.github.com/users/margaret/received_events","type":"User","site_admin":false},"body":"Hm, I don't think either is wrong/right for something this simple. I like having one action per line even for common things like this because I have a simple mind :P I suppose you could argue that the git diff is better in the this case if there are two lines and you changed the URL, because then you wouldn't have to look to see if it was the formatting action or the get action that was changed 🤓 ","created_at":"2017-09-05T20:32:55Z","updated_at":"2017-09-05T20:32:56Z","html_url":"https://github.com/dcos/dcos/pull/1826#discussion_r137106144","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/1826","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/137106144"},"html":{"href":"https://github.com/dcos/dcos/pull/1826#discussion_r137106144"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1826"}},"in_reply_to_id":137093587},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/1826","id":135708018,"html_url":"https://github.com/dcos/dcos/pull/1826","diff_url":"https://github.com/dcos/dcos/pull/1826.diff","patch_url":"https://github.com/dcos/dcos/pull/1826.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/1826","number":1826,"state":"open","locked":false,"title":"Run the tweeter demo as an integration test","user":{"login":"margaret","id":1811496,"avatar_url":"https://avatars1.githubusercontent.com/u/1811496?v=4","gravatar_id":"","url":"https://api.github.com/users/margaret","html_url":"https://github.com/margaret","followers_url":"https://api.github.com/users/margaret/followers","following_url":"https://api.github.com/users/margaret/following{/other_user}","gists_url":"https://api.github.com/users/margaret/gists{/gist_id}","starred_url":"https://api.github.com/users/margaret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margaret/subscriptions","organizations_url":"https://api.github.com/users/margaret/orgs","repos_url":"https://api.github.com/users/margaret/repos","events_url":"https://api.github.com/users/margaret/events{/privacy}","received_events_url":"https://api.github.com/users/margaret/received_events","type":"User","site_admin":false},"body":"## High Level Description\r\n\r\nAdd the [Tweeter Demo](https://github.com/mesosphere/tweeter) as an integration test.\r\n\r\nThis will be skipped on the main CI integration tests. It has its own CI setup on [TeamCity CloudIntegrationTests TweeterDemo](https://teamcity.mesosphere.io/admin/editBuildParams.html?id=buildType:ClosedSource_Dcos_IntegrationTests_CloudIntegrationTests_TweeterDemo) where it will be the only test run on a cluster that has the correct number of nodes (the normal one does not have enough resources).\r\n\r\nThis test should only triggered by this specific PR (until this is merged — then it will run on all PRs).\r\n\r\nThings to be handled in separate PRs\r\n- selenium (or similar) tests for the webpage (test manually submitting a tweet)\r\n- test scaling the tweeter app up and down\r\n- (more general than tweeter demo) figure out a better way to handle integration test code that should be in OSS and enterprise that doesn't involve copy-pasting or importing the `open_source_tests` binary 😬 \r\n\r\n## Related Issues\r\n- [DCOS_OSS-1243](https://jira.mesosphere.com/browse/DCOS_OSS-1243) Add Tweeter Demo to Integration Test\r\n\r\n## Checklist for all PR's\r\n\r\n  - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [ ] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [ ] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n  - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n  - [ ] Test Results: [link to CI job test results for component]\r\n  - [ ] Code Coverage (if available): [link to code coverage report]\r\n___\r\n**PLEASE FILL IN THE TEMPLATE ABOVE** / **DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE**\r\n\r\n## Instructions and Review Process\r\n\r\n**What is the review process and when will my changes land?**\r\n\r\nAll PRs require 2 approvals using github's [pull request reviews](https://help.github.com/articles/about-pull-request-reviews/).\r\n\r\nReviewers should be:\r\n* Developers who understand the code being modified.\r\n* Developers responsible for code that interacts with or depends on the code being modified.\r\n\r\nIt is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has **2 ship-it's**, **no red reviews**, and **all tests are green** it will be included in the [next train](https://github.com/dcos/dcos/blob/master/contributing.md).\r\n","created_at":"2017-08-14T23:27:02Z","updated_at":"2017-09-05T20:32:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"223f9045c58951cc15722861a72e6a28b9de5343","assignee":null,"assignees":[],"requested_reviewers":[{"login":"orsenthil","id":332330,"avatar_url":"https://avatars3.githubusercontent.com/u/332330?v=4","gravatar_id":"","url":"https://api.github.com/users/orsenthil","html_url":"https://github.com/orsenthil","followers_url":"https://api.github.com/users/orsenthil/followers","following_url":"https://api.github.com/users/orsenthil/following{/other_user}","gists_url":"https://api.github.com/users/orsenthil/gists{/gist_id}","starred_url":"https://api.github.com/users/orsenthil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orsenthil/subscriptions","organizations_url":"https://api.github.com/users/orsenthil/orgs","repos_url":"https://api.github.com/users/orsenthil/repos","events_url":"https://api.github.com/users/orsenthil/events{/privacy}","received_events_url":"https://api.github.com/users/orsenthil/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/1826/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/1826/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/1826/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/a5733e02e1dcde4561c93ed8685a4e96e191468f","head":{"label":"margaret:tweeter_integration","ref":"tweeter_integration","sha":"a5733e02e1dcde4561c93ed8685a4e96e191468f","user":{"login":"margaret","id":1811496,"avatar_url":"https://avatars1.githubusercontent.com/u/1811496?v=4","gravatar_id":"","url":"https://api.github.com/users/margaret","html_url":"https://github.com/margaret","followers_url":"https://api.github.com/users/margaret/followers","following_url":"https://api.github.com/users/margaret/following{/other_user}","gists_url":"https://api.github.com/users/margaret/gists{/gist_id}","starred_url":"https://api.github.com/users/margaret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margaret/subscriptions","organizations_url":"https://api.github.com/users/margaret/orgs","repos_url":"https://api.github.com/users/margaret/repos","events_url":"https://api.github.com/users/margaret/events{/privacy}","received_events_url":"https://api.github.com/users/margaret/received_events","type":"User","site_admin":false},"repo":{"id":96910377,"name":"dcos","full_name":"margaret/dcos","owner":{"login":"margaret","id":1811496,"avatar_url":"https://avatars1.githubusercontent.com/u/1811496?v=4","gravatar_id":"","url":"https://api.github.com/users/margaret","html_url":"https://github.com/margaret","followers_url":"https://api.github.com/users/margaret/followers","following_url":"https://api.github.com/users/margaret/following{/other_user}","gists_url":"https://api.github.com/users/margaret/gists{/gist_id}","starred_url":"https://api.github.com/users/margaret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/margaret/subscriptions","organizations_url":"https://api.github.com/users/margaret/orgs","repos_url":"https://api.github.com/users/margaret/repos","events_url":"https://api.github.com/users/margaret/events{/privacy}","received_events_url":"https://api.github.com/users/margaret/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/margaret/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/margaret/dcos","forks_url":"https://api.github.com/repos/margaret/dcos/forks","keys_url":"https://api.github.com/repos/margaret/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/margaret/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/margaret/dcos/teams","hooks_url":"https://api.github.com/repos/margaret/dcos/hooks","issue_events_url":"https://api.github.com/repos/margaret/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/margaret/dcos/events","assignees_url":"https://api.github.com/repos/margaret/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/margaret/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/margaret/dcos/tags","blobs_url":"https://api.github.com/repos/margaret/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/margaret/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/margaret/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/margaret/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/margaret/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/margaret/dcos/languages","stargazers_url":"https://api.github.com/repos/margaret/dcos/stargazers","contributors_url":"https://api.github.com/repos/margaret/dcos/contributors","subscribers_url":"https://api.github.com/repos/margaret/dcos/subscribers","subscription_url":"https://api.github.com/repos/margaret/dcos/subscription","commits_url":"https://api.github.com/repos/margaret/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/margaret/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/margaret/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/margaret/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/margaret/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/margaret/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/margaret/dcos/merges","archive_url":"https://api.github.com/repos/margaret/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/margaret/dcos/downloads","issues_url":"https://api.github.com/repos/margaret/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/margaret/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/margaret/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/margaret/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/margaret/dcos/labels{/name}","releases_url":"https://api.github.com/repos/margaret/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/margaret/dcos/deployments","created_at":"2017-07-11T15:47:54Z","updated_at":"2017-07-11T15:47:56Z","pushed_at":"2017-09-05T20:23:34Z","git_url":"git://github.com/margaret/dcos.git","ssh_url":"git@github.com:margaret/dcos.git","clone_url":"https://github.com/margaret/dcos.git","svn_url":"https://github.com/margaret/dcos","homepage":"https://dcos.io","size":4763,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"00f0b33589919da3db3c021d810c46b0a43868c2","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2017-09-05T06:10:10Z","pushed_at":"2017-09-05T20:23:36Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":4793,"stargazers_count":1760,"watchers_count":1760,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":39,"forks":339,"open_issues":39,"watchers":1760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1826"},"html":{"href":"https://github.com/dcos/dcos/pull/1826"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/1826"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/1826/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1826/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1826/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/a5733e02e1dcde4561c93ed8685a4e96e191468f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"margaret"}}