{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/127045141","pull_request_review_id":49590158,"id":127045141,"diff_hunk":"@@ -922,13 +924,16 @@ def test_update_enrollment_with_expired_mode_throws_error(self):\n         mode.expiration_datetime = datetime.datetime(year=1970, month=1, day=1, tzinfo=pytz.utc)\n         mode.save()\n         self.assert_enrollment_status(\n-            as_server=True,\n+            as_server=server_call,\n             mode=CourseMode.VERIFIED,\n-            expected_status=status.HTTP_400_BAD_REQUEST\n+            expected_status=status.HTTP_200_OK if server_call else status.HTTP_400_BAD_REQUEST\n         )\n         course_mode, is_active = CourseEnrollment.enrollment_mode_for_user(self.user, self.course.id)\n         self.assertTrue(is_active)\n-        self.assertEqual(course_mode, CourseMode.DEFAULT_MODE_SLUG)\n+        if server_call:","path":"common/djangoapps/enrollment/tests/test_views.py","position":24,"original_position":24,"commit_id":"db91e0a1905f8c780f254898049fe377e090be93","original_commit_id":"db91e0a1905f8c780f254898049fe377e090be93","user":{"login":"clintonb","id":910510,"avatar_url":"https://avatars3.githubusercontent.com/u/910510?v=3","gravatar_id":"","url":"https://api.github.com/users/clintonb","html_url":"https://github.com/clintonb","followers_url":"https://api.github.com/users/clintonb/followers","following_url":"https://api.github.com/users/clintonb/following{/other_user}","gists_url":"https://api.github.com/users/clintonb/gists{/gist_id}","starred_url":"https://api.github.com/users/clintonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintonb/subscriptions","organizations_url":"https://api.github.com/users/clintonb/orgs","repos_url":"https://api.github.com/users/clintonb/repos","events_url":"https://api.github.com/users/clintonb/events{/privacy}","received_events_url":"https://api.github.com/users/clintonb/received_events","type":"User","site_admin":false},"body":"I don't care much for if-statements in tests. This would be cleaner if you passed the expected course mode as an argument via DDT.","created_at":"2017-07-12T19:10:25Z","updated_at":"2017-07-12T19:10:43Z","html_url":"https://github.com/edx/edx-platform/pull/15550#discussion_r127045141","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/15550","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/127045141"},"html":{"href":"https://github.com/edx/edx-platform/pull/15550#discussion_r127045141"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15550"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/15550","id":130205280,"html_url":"https://github.com/edx/edx-platform/pull/15550","diff_url":"https://github.com/edx/edx-platform/pull/15550.diff","patch_url":"https://github.com/edx/edx-platform/pull/15550.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/15550","number":15550,"state":"open","locked":false,"title":"Allow enrollment into expired seats if the api is called by ECOM service","user":{"login":"schenedx","id":16839373,"avatar_url":"https://avatars0.githubusercontent.com/u/16839373?v=3","gravatar_id":"","url":"https://api.github.com/users/schenedx","html_url":"https://github.com/schenedx","followers_url":"https://api.github.com/users/schenedx/followers","following_url":"https://api.github.com/users/schenedx/following{/other_user}","gists_url":"https://api.github.com/users/schenedx/gists{/gist_id}","starred_url":"https://api.github.com/users/schenedx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schenedx/subscriptions","organizations_url":"https://api.github.com/users/schenedx/orgs","repos_url":"https://api.github.com/users/schenedx/repos","events_url":"https://api.github.com/users/schenedx/events{/privacy}","received_events_url":"https://api.github.com/users/schenedx/received_events","type":"User","site_admin":false},"body":"LEARNER-683\r\nWith this change, if the ECOM service is upgrading the learner from audit to verify, or from verified to credit. Even if the seat has expired, as long as we collected the money, we should allow the enrollment to happen without error.\r\n\r\n@rlucioni @clintonb @douglashall Please review.","created_at":"2017-07-12T18:25:58Z","updated_at":"2017-07-12T19:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09f6e940bf97fc519f5961aafde8ca4f462f3260","assignee":null,"assignees":[],"requested_reviewers":[{"login":"douglashall","id":224634,"avatar_url":"https://avatars1.githubusercontent.com/u/224634?v=3","gravatar_id":"","url":"https://api.github.com/users/douglashall","html_url":"https://github.com/douglashall","followers_url":"https://api.github.com/users/douglashall/followers","following_url":"https://api.github.com/users/douglashall/following{/other_user}","gists_url":"https://api.github.com/users/douglashall/gists{/gist_id}","starred_url":"https://api.github.com/users/douglashall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglashall/subscriptions","organizations_url":"https://api.github.com/users/douglashall/orgs","repos_url":"https://api.github.com/users/douglashall/repos","events_url":"https://api.github.com/users/douglashall/events{/privacy}","received_events_url":"https://api.github.com/users/douglashall/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/15550/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/15550/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/15550/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/db91e0a1905f8c780f254898049fe377e090be93","head":{"label":"edx:LEARNER-683","ref":"LEARNER-683","sha":"db91e0a1905f8c780f254898049fe377e090be93","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-07-12T04:03:18Z","pushed_at":"2017-07-12T19:07:25Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":826407,"stargazers_count":3209,"watchers_count":3209,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1861,"mirror_url":null,"open_issues_count":177,"forks":1861,"open_issues":177,"watchers":3209,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"59794ea9c90e66c4cbc306be10ec2e492cf87d11","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars0.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2017-07-12T04:03:18Z","pushed_at":"2017-07-12T19:07:25Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":826407,"stargazers_count":3209,"watchers_count":3209,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1861,"mirror_url":null,"open_issues_count":177,"forks":1861,"open_issues":177,"watchers":3209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15550"},"html":{"href":"https://github.com/edx/edx-platform/pull/15550"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/15550"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/15550/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15550/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/15550/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/db91e0a1905f8c780f254898049fe377e090be93"}}}}
{"actor":{"display_login":"clintonb"}}