{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/147862423","pull_request_review_id":73018507,"id":147862423,"diff_hunk":"@@ -35,6 +35,9 @@ func LookupPatchMetadata(t reflect.Type, jsonField string) (\n \t\telemType = t.Elem()\n \t\treturn\n \t}\n+\tif t.Kind() == reflect.Slice || t.Kind() == reflect.Array {","path":"staging/src/k8s.io/apimachinery/third_party/forked/golang/json/fields.go","position":4,"original_position":4,"commit_id":"1a0c46a180330a60af0765e4d482cbc127aae869","original_commit_id":"8ecc213ae4b8dfbca67d1b35c606c3b2cda4cbf1","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"No, it means the type passed in can mean three different things, which is extremely hard to follow. Prior to this change, the type arg meant two different things. This change makes it worse. ","created_at":"2017-10-30T23:29:04Z","updated_at":"2017-10-30T23:29:04Z","html_url":"https://github.com/kubernetes/kubernetes/pull/51321#discussion_r147862423","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51321","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/147862423"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/51321#discussion_r147862423"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51321"}},"in_reply_to_id":147705820},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51321","id":137613628,"html_url":"https://github.com/kubernetes/kubernetes/pull/51321","diff_url":"https://github.com/kubernetes/kubernetes/pull/51321.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/51321.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51321","number":51321,"state":"open","locked":false,"title":"Kubectl apply and strategic merge patch using openapi","user":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"body":"- [x] support openapi in strategic merge patch\r\n- [x] test openapi in strategic merge patch\r\n- [x] kubectl apply use openapi to calculate diff be default. It will fall back to use baked-in types when openapi is not available.\r\n- [x] test openapi in kubectl apply\r\n\r\nFixes: kubernetes/kubectl#55\r\n\r\n```release-note\r\nkubectl apply use openapi to calculate diff be default. It will fall back to use baked-in types when openapi is not available.\r\n```\r\n\r\n/assign @apelisse ","created_at":"2017-08-25T07:18:43Z","updated_at":"2017-10-30T23:29:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17ae5eb628999cadd6c14cfd9fd22365f12591a6","assignee":{"login":"apelisse","id":1929644,"avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"assignees":[{"login":"apelisse","id":1929644,"avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/35","html_url":"https://github.com/kubernetes/kubernetes/milestone/35","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/35/labels","id":2422217,"number":35,"title":"v1.9","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":71,"state":"open","created_at":"2017-03-30T14:12:39Z","updated_at":"2017-10-30T22:45:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51321/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51321/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/51321/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1a0c46a180330a60af0765e4d482cbc127aae869","head":{"label":"mengqiy:kubectl_apply_openapi","ref":"kubectl_apply_openapi","sha":"1a0c46a180330a60af0765e4d482cbc127aae869","user":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"repo":{"id":65329041,"name":"kubernetes","full_name":"mengqiy/kubernetes","owner":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mengqiy/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/mengqiy/kubernetes","forks_url":"https://api.github.com/repos/mengqiy/kubernetes/forks","keys_url":"https://api.github.com/repos/mengqiy/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mengqiy/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mengqiy/kubernetes/teams","hooks_url":"https://api.github.com/repos/mengqiy/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mengqiy/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mengqiy/kubernetes/events","assignees_url":"https://api.github.com/repos/mengqiy/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mengqiy/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mengqiy/kubernetes/tags","blobs_url":"https://api.github.com/repos/mengqiy/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mengqiy/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mengqiy/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mengqiy/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mengqiy/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mengqiy/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mengqiy/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mengqiy/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mengqiy/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mengqiy/kubernetes/subscription","commits_url":"https://api.github.com/repos/mengqiy/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mengqiy/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mengqiy/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mengqiy/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mengqiy/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mengqiy/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mengqiy/kubernetes/merges","archive_url":"https://api.github.com/repos/mengqiy/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mengqiy/kubernetes/downloads","issues_url":"https://api.github.com/repos/mengqiy/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mengqiy/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mengqiy/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mengqiy/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mengqiy/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mengqiy/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mengqiy/kubernetes/deployments","created_at":"2016-08-09T21:18:55Z","updated_at":"2016-08-09T21:19:27Z","pushed_at":"2017-10-30T20:00:37Z","git_url":"git://github.com/mengqiy/kubernetes.git","ssh_url":"git@github.com:mengqiy/kubernetes.git","clone_url":"https://github.com/mengqiy/kubernetes.git","svn_url":"https://github.com/mengqiy/kubernetes","homepage":"http://kubernetes.io","size":501870,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"68b9fa2b891d2660b3b359e3b25a9fd7edf48e12","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-10-30T23:07:26Z","pushed_at":"2017-10-30T23:19:27Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":734405,"stargazers_count":28308,"watchers_count":28308,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10135,"mirror_url":null,"archived":false,"open_issues_count":5514,"forks":10135,"open_issues":5514,"watchers":28308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51321"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/51321"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/51321"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/51321/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51321/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/51321/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1a0c46a180330a60af0765e4d482cbc127aae869"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liggitt"}}