{"action":"opened","number":10921,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/10921","id":141483259,"html_url":"https://github.com/magento/magento2/pull/10921","diff_url":"https://github.com/magento/magento2/pull/10921.diff","patch_url":"https://github.com/magento/magento2/pull/10921.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/10921","number":10921,"state":"open","locked":false,"title":"#10611 Ignore request key check for error page to avoid redirect loop","user":{"login":"lbajsarowicz","id":1639941,"avatar_url":"https://avatars3.githubusercontent.com/u/1639941?v=4","gravatar_id":"","url":"https://api.github.com/users/lbajsarowicz","html_url":"https://github.com/lbajsarowicz","followers_url":"https://api.github.com/users/lbajsarowicz/followers","following_url":"https://api.github.com/users/lbajsarowicz/following{/other_user}","gists_url":"https://api.github.com/users/lbajsarowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/lbajsarowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbajsarowicz/subscriptions","organizations_url":"https://api.github.com/users/lbajsarowicz/orgs","repos_url":"https://api.github.com/users/lbajsarowicz/repos","events_url":"https://api.github.com/users/lbajsarowicz/events{/privacy}","received_events_url":"https://api.github.com/users/lbajsarowicz/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\nProblems described in the issue was caused by redirect occuring when request made to the application had incorrect URL key. This specific situation took place only when user had no access to any part of application. So finally trying to get access to `adminhtml/index` controller, he got redirected to `adminhtml/noroute/denied` that he also have no access because of incorrect URL key.\r\n\r\n### Fixed Issues (if relevant)\r\n<!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant  -->\r\n1. magento/magento2#10611 Magento admin gets in redirect loop when I login with a role that has no resources assigned\r\n\r\n### Manual testing scenarios\r\n<!--- Provide a set of unambiguous steps to test the proposed code change -->\r\n1. Create a user role with no resources assigned to it.\r\n2. Create an admin user with that role.\r\n3. Log in with that user.\r\n\r\n### Contribution checklist\r\n - [ x ] Pull request has a meaningful description of its purpose\r\n - [ x ] All commits are accompanied by meaningful commit messages\r\n - [ - ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ x ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2017-09-17T11:51:21Z","updated_at":"2017-09-17T11:51:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/10921/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/10921/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/10921/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/2f422ad42e5476a476ff095e3377baad9c616927","head":{"label":"lbajsarowicz:bug/10611-redirect-loop","ref":"bug/10611-redirect-loop","sha":"2f422ad42e5476a476ff095e3377baad9c616927","user":{"login":"lbajsarowicz","id":1639941,"avatar_url":"https://avatars3.githubusercontent.com/u/1639941?v=4","gravatar_id":"","url":"https://api.github.com/users/lbajsarowicz","html_url":"https://github.com/lbajsarowicz","followers_url":"https://api.github.com/users/lbajsarowicz/followers","following_url":"https://api.github.com/users/lbajsarowicz/following{/other_user}","gists_url":"https://api.github.com/users/lbajsarowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/lbajsarowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbajsarowicz/subscriptions","organizations_url":"https://api.github.com/users/lbajsarowicz/orgs","repos_url":"https://api.github.com/users/lbajsarowicz/repos","events_url":"https://api.github.com/users/lbajsarowicz/events{/privacy}","received_events_url":"https://api.github.com/users/lbajsarowicz/received_events","type":"User","site_admin":false},"repo":{"id":103823997,"name":"magento2","full_name":"lbajsarowicz/magento2","owner":{"login":"lbajsarowicz","id":1639941,"avatar_url":"https://avatars3.githubusercontent.com/u/1639941?v=4","gravatar_id":"","url":"https://api.github.com/users/lbajsarowicz","html_url":"https://github.com/lbajsarowicz","followers_url":"https://api.github.com/users/lbajsarowicz/followers","following_url":"https://api.github.com/users/lbajsarowicz/following{/other_user}","gists_url":"https://api.github.com/users/lbajsarowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/lbajsarowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbajsarowicz/subscriptions","organizations_url":"https://api.github.com/users/lbajsarowicz/orgs","repos_url":"https://api.github.com/users/lbajsarowicz/repos","events_url":"https://api.github.com/users/lbajsarowicz/events{/privacy}","received_events_url":"https://api.github.com/users/lbajsarowicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lbajsarowicz/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/lbajsarowicz/magento2","forks_url":"https://api.github.com/repos/lbajsarowicz/magento2/forks","keys_url":"https://api.github.com/repos/lbajsarowicz/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbajsarowicz/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbajsarowicz/magento2/teams","hooks_url":"https://api.github.com/repos/lbajsarowicz/magento2/hooks","issue_events_url":"https://api.github.com/repos/lbajsarowicz/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/lbajsarowicz/magento2/events","assignees_url":"https://api.github.com/repos/lbajsarowicz/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/lbajsarowicz/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/lbajsarowicz/magento2/tags","blobs_url":"https://api.github.com/repos/lbajsarowicz/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbajsarowicz/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbajsarowicz/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbajsarowicz/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbajsarowicz/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/lbajsarowicz/magento2/languages","stargazers_url":"https://api.github.com/repos/lbajsarowicz/magento2/stargazers","contributors_url":"https://api.github.com/repos/lbajsarowicz/magento2/contributors","subscribers_url":"https://api.github.com/repos/lbajsarowicz/magento2/subscribers","subscription_url":"https://api.github.com/repos/lbajsarowicz/magento2/subscription","commits_url":"https://api.github.com/repos/lbajsarowicz/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbajsarowicz/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbajsarowicz/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbajsarowicz/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbajsarowicz/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/lbajsarowicz/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbajsarowicz/magento2/merges","archive_url":"https://api.github.com/repos/lbajsarowicz/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbajsarowicz/magento2/downloads","issues_url":"https://api.github.com/repos/lbajsarowicz/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/lbajsarowicz/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/lbajsarowicz/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/lbajsarowicz/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbajsarowicz/magento2/labels{/name}","releases_url":"https://api.github.com/repos/lbajsarowicz/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/lbajsarowicz/magento2/deployments","created_at":"2017-09-17T11:35:19Z","updated_at":"2017-09-17T11:36:18Z","pushed_at":"2017-09-17T11:42:25Z","git_url":"git://github.com/lbajsarowicz/magento2.git","ssh_url":"git@github.com:lbajsarowicz/magento2.git","clone_url":"https://github.com/lbajsarowicz/magento2.git","svn_url":"https://github.com/lbajsarowicz/magento2","homepage":"http://www.magento.com","size":390533,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"magento:develop","ref":"develop","sha":"e649b4cc630dfa638271aebc9efd649c5f4bfca9","user":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2017-09-16T11:16:07Z","pushed_at":"2017-09-17T11:31:38Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":390533,"stargazers_count":4736,"watchers_count":4736,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3660,"mirror_url":null,"open_issues_count":2323,"forks":3660,"open_issues":2323,"watchers":4736,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/10921"},"html":{"href":"https://github.com/magento/magento2/pull/10921"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/10921"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/10921/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/10921/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/10921/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/2f422ad42e5476a476ff095e3377baad9c616927"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"lbajsarowicz"}}