{"action":"created","issue":{"url":"https://api.github.com/repos/SSSD/sssd/issues/402","repository_url":"https://api.github.com/repos/SSSD/sssd","labels_url":"https://api.github.com/repos/SSSD/sssd/issues/402/labels{/name}","comments_url":"https://api.github.com/repos/SSSD/sssd/issues/402/comments","events_url":"https://api.github.com/repos/SSSD/sssd/issues/402/events","html_url":"https://github.com/SSSD/sssd/pull/402","id":264359916,"number":402,"title":"LDAP: Allow autogenerating user-private groups","user":{"login":"jhrozek","id":715522,"avatar_url":"https://avatars1.githubusercontent.com/u/715522?v=4","gravatar_id":"","url":"https://api.github.com/users/jhrozek","html_url":"https://github.com/jhrozek","followers_url":"https://api.github.com/users/jhrozek/followers","following_url":"https://api.github.com/users/jhrozek/following{/other_user}","gists_url":"https://api.github.com/users/jhrozek/gists{/gist_id}","starred_url":"https://api.github.com/users/jhrozek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhrozek/subscriptions","organizations_url":"https://api.github.com/users/jhrozek/orgs","repos_url":"https://api.github.com/users/jhrozek/repos","events_url":"https://api.github.com/users/jhrozek/events{/privacy}","received_events_url":"https://api.github.com/users/jhrozek/received_events","type":"User","site_admin":false},"labels":[{"id":433528592,"url":"https://api.github.com/repos/SSSD/sssd/labels/Changes%20requested","name":"Changes requested","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"fidencio","id":112762,"avatar_url":"https://avatars0.githubusercontent.com/u/112762?v=4","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},"assignees":[{"login":"fidencio","id":112762,"avatar_url":"https://avatars0.githubusercontent.com/u/112762?v=4","gravatar_id":"","url":"https://api.github.com/users/fidencio","html_url":"https://github.com/fidencio","followers_url":"https://api.github.com/users/fidencio/followers","following_url":"https://api.github.com/users/fidencio/following{/other_user}","gists_url":"https://api.github.com/users/fidencio/gists{/gist_id}","starred_url":"https://api.github.com/users/fidencio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fidencio/subscriptions","organizations_url":"https://api.github.com/users/fidencio/orgs","repos_url":"https://api.github.com/users/fidencio/repos","events_url":"https://api.github.com/users/fidencio/events{/privacy}","received_events_url":"https://api.github.com/users/fidencio/received_events","type":"User","site_admin":false},{"login":"pbrezina","id":18548882,"avatar_url":"https://avatars1.githubusercontent.com/u/18548882?v=4","gravatar_id":"","url":"https://api.github.com/users/pbrezina","html_url":"https://github.com/pbrezina","followers_url":"https://api.github.com/users/pbrezina/followers","following_url":"https://api.github.com/users/pbrezina/following{/other_user}","gists_url":"https://api.github.com/users/pbrezina/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrezina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrezina/subscriptions","organizations_url":"https://api.github.com/users/pbrezina/orgs","repos_url":"https://api.github.com/users/pbrezina/repos","events_url":"https://api.github.com/users/pbrezina/events{/privacy}","received_events_url":"https://api.github.com/users/pbrezina/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2017-10-10T20:11:04Z","updated_at":"2017-10-19T18:55:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SSSD/sssd/pulls/402","html_url":"https://github.com/SSSD/sssd/pull/402","diff_url":"https://github.com/SSSD/sssd/pull/402.diff","patch_url":"https://github.com/SSSD/sssd/pull/402.patch"},"body":"This PR exposes the already existing feature that generates private groups\nfor user objects for the generic LDAP provider. Most of the work in the\nPR is tests and different corner cases, but there is also one commit that is\ntechnically backwards incompatible:\n    SYSDB: Prevent users and groups ID collision in MPG domains\n\nWithout checks for the collision, if an LDAP domain contains both a user\nentry and a group with the same gidNumber and the group is cached first,\nthen the user is requested and cached, at that point the responder search\nby ID would return two objects. Therefore we need to guard against the\nduplicate IDs.\n\nInstead of the backwards incompatible change, we could also enable the\ncheck if the domain is neither subdomain nor a id_provider=local domain or\nwe could prefer the user object if a group-by-GID search returns two results.\n\nBut both alternatives seem like quite a hack to me and at the same time I\nwasn't able to find a way where the change matters except for the local\ndomain -- and in that case I think the local domain doesn't matter as\na whole.\n\nI've also sent a design page to the\nsssd-devel mailing list, my WIP version is at\nhttps://pagure.io/fork/jhrozek/SSSD/docs/blob/mpg/f/design_pages/auto_private_groups.rst"},"comment":{"url":"https://api.github.com/repos/SSSD/sssd/issues/comments/338003698","html_url":"https://github.com/SSSD/sssd/pull/402#issuecomment-338003698","issue_url":"https://api.github.com/repos/SSSD/sssd/issues/402","id":338003698,"user":{"login":"jhrozek","id":715522,"avatar_url":"https://avatars1.githubusercontent.com/u/715522?v=4","gravatar_id":"","url":"https://api.github.com/users/jhrozek","html_url":"https://github.com/jhrozek","followers_url":"https://api.github.com/users/jhrozek/followers","following_url":"https://api.github.com/users/jhrozek/following{/other_user}","gists_url":"https://api.github.com/users/jhrozek/gists{/gist_id}","starred_url":"https://api.github.com/users/jhrozek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhrozek/subscriptions","organizations_url":"https://api.github.com/users/jhrozek/orgs","repos_url":"https://api.github.com/users/jhrozek/repos","events_url":"https://api.github.com/users/jhrozek/events{/privacy}","received_events_url":"https://api.github.com/users/jhrozek/received_events","type":"User","site_admin":false},"created_at":"2017-10-19T18:55:25Z","updated_at":"2017-10-19T18:55:25Z","author_association":"CONTRIBUTOR","body":"btw downstream tests were rescheduled with the new code and I'll post the results (job IDs) here later, when the tests finish."}}
{"actor":{"display_login":"jhrozek"}}