{"action":"created","comment":{"url":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/comments/130694496","pull_request_review_id":53598516,"id":130694496,"diff_hunk":"@@ -1149,15 +1151,17 @@ module.exports = function RequestHandlerModule(pb) {\n      * @param {Object} route\n      * @param {Object} route.path_vars\n      */\n-    RequestHandler.prototype.getPathVariables = function(route) {\n+    RequestHandler.prototype.getPathVariables = function(route, method) {\n         var pathVars = {};\n         var pathParts = this.url.pathname.split('/');\n-        Object.keys(route.path_vars).forEach(function(field) {\n-            pathVars[field] = pathParts[route.path_vars[field]];\n-        });\n+        let methodKey = !route.path_vars[method] && route.path_vars['ALL'] ? 'ALL' : method;","path":"include/http/request_handler.js","position":46,"original_position":46,"commit_id":"cee461c69c35dc25530a113af38b6c38b3ddb5a4","original_commit_id":"cee461c69c35dc25530a113af38b6c38b3ddb5a4","user":{"login":"seanpaw","id":10159282,"avatar_url":"https://avatars1.githubusercontent.com/u/10159282?v=4","gravatar_id":"","url":"https://api.github.com/users/seanpaw","html_url":"https://github.com/seanpaw","followers_url":"https://api.github.com/users/seanpaw/followers","following_url":"https://api.github.com/users/seanpaw/following{/other_user}","gists_url":"https://api.github.com/users/seanpaw/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpaw/subscriptions","organizations_url":"https://api.github.com/users/seanpaw/orgs","repos_url":"https://api.github.com/users/seanpaw/repos","events_url":"https://api.github.com/users/seanpaw/events{/privacy}","received_events_url":"https://api.github.com/users/seanpaw/received_events","type":"User","site_admin":false},"body":"have newrelic notice an error here","created_at":"2017-08-01T18:47:12Z","updated_at":"2017-08-01T18:47:12Z","html_url":"https://github.com/careerbuilder/pencilblue/pull/21#discussion_r130694496","pull_request_url":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/comments/130694496"},"html":{"href":"https://github.com/careerbuilder/pencilblue/pull/21#discussion_r130694496"},"pull_request":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/21","id":131182670,"html_url":"https://github.com/careerbuilder/pencilblue/pull/21","diff_url":"https://github.com/careerbuilder/pencilblue/pull/21.diff","patch_url":"https://github.com/careerbuilder/pencilblue/pull/21.patch","issue_url":"https://api.github.com/repos/careerbuilder/pencilblue/issues/21","number":21,"state":"open","locked":false,"title":"Added support for verb specific pathvars","user":{"login":"seanpaw","id":10159282,"avatar_url":"https://avatars1.githubusercontent.com/u/10159282?v=4","gravatar_id":"","url":"https://api.github.com/users/seanpaw","html_url":"https://github.com/seanpaw","followers_url":"https://api.github.com/users/seanpaw/followers","following_url":"https://api.github.com/users/seanpaw/following{/other_user}","gists_url":"https://api.github.com/users/seanpaw/gists{/gist_id}","starred_url":"https://api.github.com/users/seanpaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanpaw/subscriptions","organizations_url":"https://api.github.com/users/seanpaw/orgs","repos_url":"https://api.github.com/users/seanpaw/repos","events_url":"https://api.github.com/users/seanpaw/events{/privacy}","received_events_url":"https://api.github.com/users/seanpaw/received_events","type":"User","site_admin":false},"body":"Fixes #\r\n\r\n- [ ] Unit tests created and pass\r\n- [ ] JS Docs have been updated\r\n\r\n**Description:**\r\n\r\n\r\n\r\n@pencilblue/owners\r\n","created_at":"2017-07-18T20:44:31Z","updated_at":"2017-08-01T18:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dff67fc9f58dbcc4ee49d7d4a1f30bdbb68ca378","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/21/commits","review_comments_url":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/21/comments","review_comment_url":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/careerbuilder/pencilblue/issues/21/comments","statuses_url":"https://api.github.com/repos/careerbuilder/pencilblue/statuses/cee461c69c35dc25530a113af38b6c38b3ddb5a4","head":{"label":"careerbuilder:verbSpecificPathvars","ref":"verbSpecificPathvars","sha":"cee461c69c35dc25530a113af38b6c38b3ddb5a4","user":{"login":"careerbuilder","id":1043090,"avatar_url":"https://avatars0.githubusercontent.com/u/1043090?v=4","gravatar_id":"","url":"https://api.github.com/users/careerbuilder","html_url":"https://github.com/careerbuilder","followers_url":"https://api.github.com/users/careerbuilder/followers","following_url":"https://api.github.com/users/careerbuilder/following{/other_user}","gists_url":"https://api.github.com/users/careerbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/careerbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/careerbuilder/subscriptions","organizations_url":"https://api.github.com/users/careerbuilder/orgs","repos_url":"https://api.github.com/users/careerbuilder/repos","events_url":"https://api.github.com/users/careerbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/careerbuilder/received_events","type":"Organization","site_admin":false},"repo":{"id":50383161,"name":"pencilblue","full_name":"careerbuilder/pencilblue","owner":{"login":"careerbuilder","id":1043090,"avatar_url":"https://avatars0.githubusercontent.com/u/1043090?v=4","gravatar_id":"","url":"https://api.github.com/users/careerbuilder","html_url":"https://github.com/careerbuilder","followers_url":"https://api.github.com/users/careerbuilder/followers","following_url":"https://api.github.com/users/careerbuilder/following{/other_user}","gists_url":"https://api.github.com/users/careerbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/careerbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/careerbuilder/subscriptions","organizations_url":"https://api.github.com/users/careerbuilder/orgs","repos_url":"https://api.github.com/users/careerbuilder/repos","events_url":"https://api.github.com/users/careerbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/careerbuilder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/careerbuilder/pencilblue","description":"Business class content management for Node.js (plugins, server cluster management, data-driven pages)","fork":true,"url":"https://api.github.com/repos/careerbuilder/pencilblue","forks_url":"https://api.github.com/repos/careerbuilder/pencilblue/forks","keys_url":"https://api.github.com/repos/careerbuilder/pencilblue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/careerbuilder/pencilblue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/careerbuilder/pencilblue/teams","hooks_url":"https://api.github.com/repos/careerbuilder/pencilblue/hooks","issue_events_url":"https://api.github.com/repos/careerbuilder/pencilblue/issues/events{/number}","events_url":"https://api.github.com/repos/careerbuilder/pencilblue/events","assignees_url":"https://api.github.com/repos/careerbuilder/pencilblue/assignees{/user}","branches_url":"https://api.github.com/repos/careerbuilder/pencilblue/branches{/branch}","tags_url":"https://api.github.com/repos/careerbuilder/pencilblue/tags","blobs_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/refs{/sha}","trees_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/careerbuilder/pencilblue/statuses/{sha}","languages_url":"https://api.github.com/repos/careerbuilder/pencilblue/languages","stargazers_url":"https://api.github.com/repos/careerbuilder/pencilblue/stargazers","contributors_url":"https://api.github.com/repos/careerbuilder/pencilblue/contributors","subscribers_url":"https://api.github.com/repos/careerbuilder/pencilblue/subscribers","subscription_url":"https://api.github.com/repos/careerbuilder/pencilblue/subscription","commits_url":"https://api.github.com/repos/careerbuilder/pencilblue/commits{/sha}","git_commits_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/commits{/sha}","comments_url":"https://api.github.com/repos/careerbuilder/pencilblue/comments{/number}","issue_comment_url":"https://api.github.com/repos/careerbuilder/pencilblue/issues/comments{/number}","contents_url":"https://api.github.com/repos/careerbuilder/pencilblue/contents/{+path}","compare_url":"https://api.github.com/repos/careerbuilder/pencilblue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/careerbuilder/pencilblue/merges","archive_url":"https://api.github.com/repos/careerbuilder/pencilblue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/careerbuilder/pencilblue/downloads","issues_url":"https://api.github.com/repos/careerbuilder/pencilblue/issues{/number}","pulls_url":"https://api.github.com/repos/careerbuilder/pencilblue/pulls{/number}","milestones_url":"https://api.github.com/repos/careerbuilder/pencilblue/milestones{/number}","notifications_url":"https://api.github.com/repos/careerbuilder/pencilblue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/careerbuilder/pencilblue/labels{/name}","releases_url":"https://api.github.com/repos/careerbuilder/pencilblue/releases{/id}","deployments_url":"https://api.github.com/repos/careerbuilder/pencilblue/deployments","created_at":"2016-01-25T21:44:26Z","updated_at":"2016-01-25T21:44:28Z","pushed_at":"2017-07-28T19:52:16Z","git_url":"git://github.com/careerbuilder/pencilblue.git","ssh_url":"git@github.com:careerbuilder/pencilblue.git","clone_url":"https://github.com/careerbuilder/pencilblue.git","svn_url":"https://github.com/careerbuilder/pencilblue","homepage":"https://pencilblue.org","size":15129,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"careerbuilder:cms-dep","ref":"cms-dep","sha":"d445e75b46ce7b81ff41fc9bce728922870f85d4","user":{"login":"careerbuilder","id":1043090,"avatar_url":"https://avatars0.githubusercontent.com/u/1043090?v=4","gravatar_id":"","url":"https://api.github.com/users/careerbuilder","html_url":"https://github.com/careerbuilder","followers_url":"https://api.github.com/users/careerbuilder/followers","following_url":"https://api.github.com/users/careerbuilder/following{/other_user}","gists_url":"https://api.github.com/users/careerbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/careerbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/careerbuilder/subscriptions","organizations_url":"https://api.github.com/users/careerbuilder/orgs","repos_url":"https://api.github.com/users/careerbuilder/repos","events_url":"https://api.github.com/users/careerbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/careerbuilder/received_events","type":"Organization","site_admin":false},"repo":{"id":50383161,"name":"pencilblue","full_name":"careerbuilder/pencilblue","owner":{"login":"careerbuilder","id":1043090,"avatar_url":"https://avatars0.githubusercontent.com/u/1043090?v=4","gravatar_id":"","url":"https://api.github.com/users/careerbuilder","html_url":"https://github.com/careerbuilder","followers_url":"https://api.github.com/users/careerbuilder/followers","following_url":"https://api.github.com/users/careerbuilder/following{/other_user}","gists_url":"https://api.github.com/users/careerbuilder/gists{/gist_id}","starred_url":"https://api.github.com/users/careerbuilder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/careerbuilder/subscriptions","organizations_url":"https://api.github.com/users/careerbuilder/orgs","repos_url":"https://api.github.com/users/careerbuilder/repos","events_url":"https://api.github.com/users/careerbuilder/events{/privacy}","received_events_url":"https://api.github.com/users/careerbuilder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/careerbuilder/pencilblue","description":"Business class content management for Node.js (plugins, server cluster management, data-driven pages)","fork":true,"url":"https://api.github.com/repos/careerbuilder/pencilblue","forks_url":"https://api.github.com/repos/careerbuilder/pencilblue/forks","keys_url":"https://api.github.com/repos/careerbuilder/pencilblue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/careerbuilder/pencilblue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/careerbuilder/pencilblue/teams","hooks_url":"https://api.github.com/repos/careerbuilder/pencilblue/hooks","issue_events_url":"https://api.github.com/repos/careerbuilder/pencilblue/issues/events{/number}","events_url":"https://api.github.com/repos/careerbuilder/pencilblue/events","assignees_url":"https://api.github.com/repos/careerbuilder/pencilblue/assignees{/user}","branches_url":"https://api.github.com/repos/careerbuilder/pencilblue/branches{/branch}","tags_url":"https://api.github.com/repos/careerbuilder/pencilblue/tags","blobs_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/refs{/sha}","trees_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/careerbuilder/pencilblue/statuses/{sha}","languages_url":"https://api.github.com/repos/careerbuilder/pencilblue/languages","stargazers_url":"https://api.github.com/repos/careerbuilder/pencilblue/stargazers","contributors_url":"https://api.github.com/repos/careerbuilder/pencilblue/contributors","subscribers_url":"https://api.github.com/repos/careerbuilder/pencilblue/subscribers","subscription_url":"https://api.github.com/repos/careerbuilder/pencilblue/subscription","commits_url":"https://api.github.com/repos/careerbuilder/pencilblue/commits{/sha}","git_commits_url":"https://api.github.com/repos/careerbuilder/pencilblue/git/commits{/sha}","comments_url":"https://api.github.com/repos/careerbuilder/pencilblue/comments{/number}","issue_comment_url":"https://api.github.com/repos/careerbuilder/pencilblue/issues/comments{/number}","contents_url":"https://api.github.com/repos/careerbuilder/pencilblue/contents/{+path}","compare_url":"https://api.github.com/repos/careerbuilder/pencilblue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/careerbuilder/pencilblue/merges","archive_url":"https://api.github.com/repos/careerbuilder/pencilblue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/careerbuilder/pencilblue/downloads","issues_url":"https://api.github.com/repos/careerbuilder/pencilblue/issues{/number}","pulls_url":"https://api.github.com/repos/careerbuilder/pencilblue/pulls{/number}","milestones_url":"https://api.github.com/repos/careerbuilder/pencilblue/milestones{/number}","notifications_url":"https://api.github.com/repos/careerbuilder/pencilblue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/careerbuilder/pencilblue/labels{/name}","releases_url":"https://api.github.com/repos/careerbuilder/pencilblue/releases{/id}","deployments_url":"https://api.github.com/repos/careerbuilder/pencilblue/deployments","created_at":"2016-01-25T21:44:26Z","updated_at":"2016-01-25T21:44:28Z","pushed_at":"2017-07-28T19:52:16Z","git_url":"git://github.com/careerbuilder/pencilblue.git","ssh_url":"git@github.com:careerbuilder/pencilblue.git","clone_url":"https://github.com/careerbuilder/pencilblue.git","svn_url":"https://github.com/careerbuilder/pencilblue","homepage":"https://pencilblue.org","size":15129,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/21"},"html":{"href":"https://github.com/careerbuilder/pencilblue/pull/21"},"issue":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/issues/21"},"comments":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/careerbuilder/pencilblue/statuses/cee461c69c35dc25530a113af38b6c38b3ddb5a4"}}}}
{"actor":{"display_login":"seanpaw"}}