{"action":"created","issue":{"url":"https://api.github.com/repos/wal-g/wal-g/issues/24","repository_url":"https://api.github.com/repos/wal-g/wal-g","labels_url":"https://api.github.com/repos/wal-g/wal-g/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/wal-g/wal-g/issues/24/comments","events_url":"https://api.github.com/repos/wal-g/wal-g/issues/24/events","html_url":"https://github.com/wal-g/wal-g/pull/24","id":256500288,"number":24,"title":"GPG encryption","user":{"login":"x4m","id":6000069,"avatar_url":"https://avatars0.githubusercontent.com/u/6000069?v=4","gravatar_id":"","url":"https://api.github.com/users/x4m","html_url":"https://github.com/x4m","followers_url":"https://api.github.com/users/x4m/followers","following_url":"https://api.github.com/users/x4m/following{/other_user}","gists_url":"https://api.github.com/users/x4m/gists{/gist_id}","starred_url":"https://api.github.com/users/x4m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x4m/subscriptions","organizations_url":"https://api.github.com/users/x4m/orgs","repos_url":"https://api.github.com/users/x4m/repos","events_url":"https://api.github.com/users/x4m/events{/privacy}","received_events_url":"https://api.github.com/users/x4m/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-10T10:34:16Z","updated_at":"2017-09-11T05:57:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/wal-g/wal-g/pulls/24","html_url":"https://github.com/wal-g/wal-g/pull/24","diff_url":"https://github.com/wal-g/wal-g/pull/24.diff","patch_url":"https://github.com/wal-g/wal-g/pull/24.patch"},"body":"Hi! \r\nHere's encryption via Go implementation of OpenGPG.\r\nIt reads env var WALE_GPG_KEY_ID and asks gpg tool to export key. Than this key is feeded to OpenGPG.\r\n\r\nSome things:\r\n1. I use code from pull 16 for testing. It's very convenient to use local minio.io in testing. Let me drop these lines before the merge since it's this PR is about another feature\r\n2. Same thing on Postgres10 compatibility. I can push that small thing in another PR.\r\n3. There are few TODOs:\r\n3a. Checking that S3 bucket exists (now we keep trying to upload). I'm not planning to fix this in this PR\r\n3b. Cache key in user's HOME dir. Right now GPG is invoked on every run to obtain keys. I think it would be good to cache public keys to a file. I think it worth fixing in this PR.\r\n3c. Support for GPG passphrases. Currently, only passwordless keys will go, but I do not see this as an important limitation. I'd like to fix this in other PR.\r\n4. If you think there should be more tests, plz give me some ideas what else to test. Not encryption is embedded in all previous tests and one more test for encryption roundtrip introduced.\r\n\r\nAny thoughts, ideas, and code design considerations are welcome."},"comment":{"url":"https://api.github.com/repos/wal-g/wal-g/issues/comments/328424015","html_url":"https://github.com/wal-g/wal-g/pull/24#issuecomment-328424015","issue_url":"https://api.github.com/repos/wal-g/wal-g/issues/24","id":328424015,"user":{"login":"x4m","id":6000069,"avatar_url":"https://avatars0.githubusercontent.com/u/6000069?v=4","gravatar_id":"","url":"https://api.github.com/users/x4m","html_url":"https://github.com/x4m","followers_url":"https://api.github.com/users/x4m/followers","following_url":"https://api.github.com/users/x4m/following{/other_user}","gists_url":"https://api.github.com/users/x4m/gists{/gist_id}","starred_url":"https://api.github.com/users/x4m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x4m/subscriptions","organizations_url":"https://api.github.com/users/x4m/orgs","repos_url":"https://api.github.com/users/x4m/repos","events_url":"https://api.github.com/users/x4m/events{/privacy}","received_events_url":"https://api.github.com/users/x4m/received_events","type":"User","site_admin":false},"created_at":"2017-09-11T05:57:57Z","updated_at":"2017-09-11T05:57:57Z","author_association":"NONE","body":"Here is commit addressing point 3B\r\nhttps://github.com/x4m/wal-g/commit/5cb2c4fba9dcb2c39d447d65f75f881df90fd933\r\nIf everything is OK I can add it to this PR"}}
{"actor":{"display_login":"x4m"}}