{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/118760134","pull_request_review_id":40586303,"id":118760134,"diff_hunk":"@@ -501,21 +504,147 @@ func (v *Validator) certificateAuthorities(ctx context.Context, input *data.Data\n func (v *Validator) registries(ctx context.Context, input *data.Data, conf *config.VirtualContainerHostConfigSpec) {\n \tdefer trace.End(trace.Begin(\"\"))\n \n+\t// Check if CAs can be loaded\n+\tpool := x509.NewCertPool()","path":"lib/install/validate/validator.go","position":34,"original_position":28,"commit_id":"e99062b73e43f1a57e0e344918182a321b8e54d2","original_commit_id":"f2c155b2f112f29b2b477bad3160da0eaa8c4d12","user":{"login":"sflxn","id":1330508,"avatar_url":"https://avatars0.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false},"body":"#5268 ","created_at":"2017-05-26T18:11:44Z","updated_at":"2017-05-26T18:11:44Z","html_url":"https://github.com/vmware/vic/pull/5107#discussion_r118760134","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/5107","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/118760134"},"html":{"href":"https://github.com/vmware/vic/pull/5107#discussion_r118760134"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/5107"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/5107","id":120430838,"html_url":"https://github.com/vmware/vic/pull/5107","diff_url":"https://github.com/vmware/vic/pull/5107.diff","patch_url":"https://github.com/vmware/vic/pull/5107.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/5107","number":5107,"state":"open","locked":false,"title":"Add support for whitelisting registries","user":{"login":"sflxn","id":1330508,"avatar_url":"https://avatars0.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false},"body":"Add ability to put VCH into whitelist mode.  In whitelist\r\nmode, only registries specified in --whitelist-registry and\r\n--insecure-registry may be access.  In public mode, any\r\npublic registry or --insecure-registry may be access.\r\n\r\nRemoved caching of vch config from personality server.\r\nRegistry certs and registry lists are now created dynamically.\r\nThis was done to support dynamic config in the future.\r\n\r\nFixed docker login for insecure registries to support testing\r\nwhitelist + insecure registries installation.\r\n\r\nFixed docker info to display whitelist and insecure registries.\r\n\r\nAdd support for wildcard domains and CIDR registry format for\r\ndocker login and docker pull.\r\n\r\nAdded integration tests that also deploys Harbor to verify\r\na matrix of whitelist support in both vic-machine and docker\r\ninfo, docker login, docker pull.\r\n\r\nresolves #3586 and #4681\r\n","created_at":"2017-05-13T01:54:02Z","updated_at":"2017-05-26T18:11:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b45cb235bdf03d90893beaea1b0e66469933a4a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lcastellano","id":7454168,"avatar_url":"https://avatars0.githubusercontent.com/u/7454168?v=3","gravatar_id":"","url":"https://api.github.com/users/lcastellano","html_url":"https://github.com/lcastellano","followers_url":"https://api.github.com/users/lcastellano/followers","following_url":"https://api.github.com/users/lcastellano/following{/other_user}","gists_url":"https://api.github.com/users/lcastellano/gists{/gist_id}","starred_url":"https://api.github.com/users/lcastellano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcastellano/subscriptions","organizations_url":"https://api.github.com/users/lcastellano/orgs","repos_url":"https://api.github.com/users/lcastellano/repos","events_url":"https://api.github.com/users/lcastellano/events{/privacy}","received_events_url":"https://api.github.com/users/lcastellano/received_events","type":"User","site_admin":false},{"login":"rajanashok","id":21340516,"avatar_url":"https://avatars1.githubusercontent.com/u/21340516?v=3","gravatar_id":"","url":"https://api.github.com/users/rajanashok","html_url":"https://github.com/rajanashok","followers_url":"https://api.github.com/users/rajanashok/followers","following_url":"https://api.github.com/users/rajanashok/following{/other_user}","gists_url":"https://api.github.com/users/rajanashok/gists{/gist_id}","starred_url":"https://api.github.com/users/rajanashok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajanashok/subscriptions","organizations_url":"https://api.github.com/users/rajanashok/orgs","repos_url":"https://api.github.com/users/rajanashok/repos","events_url":"https://api.github.com/users/rajanashok/events{/privacy}","received_events_url":"https://api.github.com/users/rajanashok/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/5107/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/5107/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/5107/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/e99062b73e43f1a57e0e344918182a321b8e54d2","head":{"label":"sflxn:whitelist-registry","ref":"whitelist-registry","sha":"e99062b73e43f1a57e0e344918182a321b8e54d2","user":{"login":"sflxn","id":1330508,"avatar_url":"https://avatars0.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false},"repo":{"id":55453338,"name":"vic","full_name":"sflxn/vic","owner":{"login":"sflxn","id":1330508,"avatar_url":"https://avatars0.githubusercontent.com/u/1330508?v=3","gravatar_id":"","url":"https://api.github.com/users/sflxn","html_url":"https://github.com/sflxn","followers_url":"https://api.github.com/users/sflxn/followers","following_url":"https://api.github.com/users/sflxn/following{/other_user}","gists_url":"https://api.github.com/users/sflxn/gists{/gist_id}","starred_url":"https://api.github.com/users/sflxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sflxn/subscriptions","organizations_url":"https://api.github.com/users/sflxn/orgs","repos_url":"https://api.github.com/users/sflxn/repos","events_url":"https://api.github.com/users/sflxn/events{/privacy}","received_events_url":"https://api.github.com/users/sflxn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sflxn/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/sflxn/vic","forks_url":"https://api.github.com/repos/sflxn/vic/forks","keys_url":"https://api.github.com/repos/sflxn/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sflxn/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sflxn/vic/teams","hooks_url":"https://api.github.com/repos/sflxn/vic/hooks","issue_events_url":"https://api.github.com/repos/sflxn/vic/issues/events{/number}","events_url":"https://api.github.com/repos/sflxn/vic/events","assignees_url":"https://api.github.com/repos/sflxn/vic/assignees{/user}","branches_url":"https://api.github.com/repos/sflxn/vic/branches{/branch}","tags_url":"https://api.github.com/repos/sflxn/vic/tags","blobs_url":"https://api.github.com/repos/sflxn/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sflxn/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sflxn/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/sflxn/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sflxn/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/sflxn/vic/languages","stargazers_url":"https://api.github.com/repos/sflxn/vic/stargazers","contributors_url":"https://api.github.com/repos/sflxn/vic/contributors","subscribers_url":"https://api.github.com/repos/sflxn/vic/subscribers","subscription_url":"https://api.github.com/repos/sflxn/vic/subscription","commits_url":"https://api.github.com/repos/sflxn/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/sflxn/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/sflxn/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/sflxn/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/sflxn/vic/contents/{+path}","compare_url":"https://api.github.com/repos/sflxn/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sflxn/vic/merges","archive_url":"https://api.github.com/repos/sflxn/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sflxn/vic/downloads","issues_url":"https://api.github.com/repos/sflxn/vic/issues{/number}","pulls_url":"https://api.github.com/repos/sflxn/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/sflxn/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/sflxn/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sflxn/vic/labels{/name}","releases_url":"https://api.github.com/repos/sflxn/vic/releases{/id}","deployments_url":"https://api.github.com/repos/sflxn/vic/deployments","created_at":"2016-04-04T23:42:42Z","updated_at":"2016-11-15T20:36:35Z","pushed_at":"2017-05-26T00:32:04Z","git_url":"git://github.com/sflxn/vic.git","ssh_url":"git@github.com:sflxn/vic.git","clone_url":"https://github.com/sflxn/vic.git","svn_url":"https://github.com/sflxn/vic","homepage":null,"size":53944,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"cc08c10026c379cf077ef17ae167e889ed18e2a3","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2017-05-26T13:15:04Z","pushed_at":"2017-05-26T17:43:05Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"http://vmware.github.io/vic","size":64595,"stargazers_count":240,"watchers_count":240,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":792,"forks":97,"open_issues":792,"watchers":240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/5107"},"html":{"href":"https://github.com/vmware/vic/pull/5107"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/5107"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/5107/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/5107/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/5107/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/e99062b73e43f1a57e0e344918182a321b8e54d2"}}}}
{"actor":{"display_login":"sflxn"}}