{"action":"created","comment":{"url":"https://api.github.com/repos/dronecore/DroneCore/pulls/comments/136039063","pull_request_review_id":59521872,"id":136039063,"diff_hunk":"@@ -30,17 +59,83 @@ class DroneCore\n         CONNECTIONS_EXHAUSTED\n     };\n \n+    /**\n+     * Translates the ConnectionResult enum to a human-readable English string.\n+     */\n     static const char *connection_result_str(ConnectionResult);\n \n+    /**\n+     * Adds a UDP connection with the default arguments.\n+     *\n+     * This will listen on UDP port 14540 on localhost.\n+     *\n+     * @return the result of adding the connection.\n+     */\n     ConnectionResult add_udp_connection();\n+\n+    /**\n+     * Adds a UDP connection with a specific port number.","path":"include/dronecore.h","position":61,"original_position":61,"commit_id":"8e83ca1f62556cc1af6090ed1bf6e6a71926dbf3","original_commit_id":"7e893e161c770ae47c80ea92e87cf268cd70dc2d","user":{"login":"julianoes","id":1419688,"avatar_url":"https://avatars3.githubusercontent.com/u/1419688?v=4","gravatar_id":"","url":"https://api.github.com/users/julianoes","html_url":"https://github.com/julianoes","followers_url":"https://api.github.com/users/julianoes/followers","following_url":"https://api.github.com/users/julianoes/following{/other_user}","gists_url":"https://api.github.com/users/julianoes/gists{/gist_id}","starred_url":"https://api.github.com/users/julianoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianoes/subscriptions","organizations_url":"https://api.github.com/users/julianoes/orgs","repos_url":"https://api.github.com/users/julianoes/repos","events_url":"https://api.github.com/users/julianoes/events{/privacy}","received_events_url":"https://api.github.com/users/julianoes/received_events","type":"User","site_admin":false},"body":"This is the local port that it listens on, so I don't think it can be anything else than localhost. The packet can be sent from any remote IP though.\r\n\r\nIt's probably best to avoid mentioning localhost to avoid confusion.","created_at":"2017-08-30T11:15:11Z","updated_at":"2017-08-30T11:15:11Z","html_url":"https://github.com/dronecore/DroneCore/pull/42#discussion_r136039063","pull_request_url":"https://api.github.com/repos/dronecore/DroneCore/pulls/42","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dronecore/DroneCore/pulls/comments/136039063"},"html":{"href":"https://github.com/dronecore/DroneCore/pull/42#discussion_r136039063"},"pull_request":{"href":"https://api.github.com/repos/dronecore/DroneCore/pulls/42"}},"in_reply_to_id":135959706},"pull_request":{"url":"https://api.github.com/repos/dronecore/DroneCore/pulls/42","id":138146414,"html_url":"https://github.com/dronecore/DroneCore/pull/42","diff_url":"https://github.com/dronecore/DroneCore/pull/42.diff","patch_url":"https://github.com/dronecore/DroneCore/pull/42.patch","issue_url":"https://api.github.com/repos/dronecore/DroneCore/issues/42","number":42,"state":"open","locked":false,"title":"Add doxygen comments","user":{"login":"julianoes","id":1419688,"avatar_url":"https://avatars3.githubusercontent.com/u/1419688?v=4","gravatar_id":"","url":"https://api.github.com/users/julianoes","html_url":"https://github.com/julianoes","followers_url":"https://api.github.com/users/julianoes/followers","following_url":"https://api.github.com/users/julianoes/following{/other_user}","gists_url":"https://api.github.com/users/julianoes/gists{/gist_id}","starred_url":"https://api.github.com/users/julianoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianoes/subscriptions","organizations_url":"https://api.github.com/users/julianoes/orgs","repos_url":"https://api.github.com/users/julianoes/repos","events_url":"https://api.github.com/users/julianoes/events{/privacy}","received_events_url":"https://api.github.com/users/julianoes/received_events","type":"User","site_admin":false},"body":"This adds doxygen comments to the public facing headers.\r\n\r\nAddresses #13, #15.","created_at":"2017-08-29T10:52:08Z","updated_at":"2017-08-30T11:15:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c375821d90606ee3e8210f4c42f3089038cf0941","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dronecore/DroneCore/pulls/42/commits","review_comments_url":"https://api.github.com/repos/dronecore/DroneCore/pulls/42/comments","review_comment_url":"https://api.github.com/repos/dronecore/DroneCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dronecore/DroneCore/issues/42/comments","statuses_url":"https://api.github.com/repos/dronecore/DroneCore/statuses/8e83ca1f62556cc1af6090ed1bf6e6a71926dbf3","head":{"label":"dronecore:add-comments","ref":"add-comments","sha":"8e83ca1f62556cc1af6090ed1bf6e6a71926dbf3","user":{"login":"dronecore","id":31042455,"avatar_url":"https://avatars1.githubusercontent.com/u/31042455?v=4","gravatar_id":"","url":"https://api.github.com/users/dronecore","html_url":"https://github.com/dronecore","followers_url":"https://api.github.com/users/dronecore/followers","following_url":"https://api.github.com/users/dronecore/following{/other_user}","gists_url":"https://api.github.com/users/dronecore/gists{/gist_id}","starred_url":"https://api.github.com/users/dronecore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronecore/subscriptions","organizations_url":"https://api.github.com/users/dronecore/orgs","repos_url":"https://api.github.com/users/dronecore/repos","events_url":"https://api.github.com/users/dronecore/events{/privacy}","received_events_url":"https://api.github.com/users/dronecore/received_events","type":"Organization","site_admin":false},"repo":{"id":94815442,"name":"DroneCore","full_name":"dronecore/DroneCore","owner":{"login":"dronecore","id":31042455,"avatar_url":"https://avatars1.githubusercontent.com/u/31042455?v=4","gravatar_id":"","url":"https://api.github.com/users/dronecore","html_url":"https://github.com/dronecore","followers_url":"https://api.github.com/users/dronecore/followers","following_url":"https://api.github.com/users/dronecore/following{/other_user}","gists_url":"https://api.github.com/users/dronecore/gists{/gist_id}","starred_url":"https://api.github.com/users/dronecore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronecore/subscriptions","organizations_url":"https://api.github.com/users/dronecore/orgs","repos_url":"https://api.github.com/users/dronecore/repos","events_url":"https://api.github.com/users/dronecore/events{/privacy}","received_events_url":"https://api.github.com/users/dronecore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dronecore/DroneCore","description":"API and library for PX4 Autopilot using MAVLink written in C++11","fork":false,"url":"https://api.github.com/repos/dronecore/DroneCore","forks_url":"https://api.github.com/repos/dronecore/DroneCore/forks","keys_url":"https://api.github.com/repos/dronecore/DroneCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dronecore/DroneCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dronecore/DroneCore/teams","hooks_url":"https://api.github.com/repos/dronecore/DroneCore/hooks","issue_events_url":"https://api.github.com/repos/dronecore/DroneCore/issues/events{/number}","events_url":"https://api.github.com/repos/dronecore/DroneCore/events","assignees_url":"https://api.github.com/repos/dronecore/DroneCore/assignees{/user}","branches_url":"https://api.github.com/repos/dronecore/DroneCore/branches{/branch}","tags_url":"https://api.github.com/repos/dronecore/DroneCore/tags","blobs_url":"https://api.github.com/repos/dronecore/DroneCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dronecore/DroneCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dronecore/DroneCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/dronecore/DroneCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dronecore/DroneCore/statuses/{sha}","languages_url":"https://api.github.com/repos/dronecore/DroneCore/languages","stargazers_url":"https://api.github.com/repos/dronecore/DroneCore/stargazers","contributors_url":"https://api.github.com/repos/dronecore/DroneCore/contributors","subscribers_url":"https://api.github.com/repos/dronecore/DroneCore/subscribers","subscription_url":"https://api.github.com/repos/dronecore/DroneCore/subscription","commits_url":"https://api.github.com/repos/dronecore/DroneCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/dronecore/DroneCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/dronecore/DroneCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/dronecore/DroneCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/dronecore/DroneCore/contents/{+path}","compare_url":"https://api.github.com/repos/dronecore/DroneCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dronecore/DroneCore/merges","archive_url":"https://api.github.com/repos/dronecore/DroneCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dronecore/DroneCore/downloads","issues_url":"https://api.github.com/repos/dronecore/DroneCore/issues{/number}","pulls_url":"https://api.github.com/repos/dronecore/DroneCore/pulls{/number}","milestones_url":"https://api.github.com/repos/dronecore/DroneCore/milestones{/number}","notifications_url":"https://api.github.com/repos/dronecore/DroneCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dronecore/DroneCore/labels{/name}","releases_url":"https://api.github.com/repos/dronecore/DroneCore/releases{/id}","deployments_url":"https://api.github.com/repos/dronecore/DroneCore/deployments","created_at":"2017-06-19T19:54:57Z","updated_at":"2017-08-22T23:01:33Z","pushed_at":"2017-08-30T11:03:18Z","git_url":"git://github.com/dronecore/DroneCore.git","ssh_url":"git@github.com:dronecore/DroneCore.git","clone_url":"https://github.com/dronecore/DroneCore.git","svn_url":"https://github.com/dronecore/DroneCore","homepage":"","size":478,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":23,"forks":4,"open_issues":23,"watchers":6,"default_branch":"master"}},"base":{"label":"dronecore:master","ref":"master","sha":"4d12d19e377a292de5bd6bc62f3577b3f04843af","user":{"login":"dronecore","id":31042455,"avatar_url":"https://avatars1.githubusercontent.com/u/31042455?v=4","gravatar_id":"","url":"https://api.github.com/users/dronecore","html_url":"https://github.com/dronecore","followers_url":"https://api.github.com/users/dronecore/followers","following_url":"https://api.github.com/users/dronecore/following{/other_user}","gists_url":"https://api.github.com/users/dronecore/gists{/gist_id}","starred_url":"https://api.github.com/users/dronecore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronecore/subscriptions","organizations_url":"https://api.github.com/users/dronecore/orgs","repos_url":"https://api.github.com/users/dronecore/repos","events_url":"https://api.github.com/users/dronecore/events{/privacy}","received_events_url":"https://api.github.com/users/dronecore/received_events","type":"Organization","site_admin":false},"repo":{"id":94815442,"name":"DroneCore","full_name":"dronecore/DroneCore","owner":{"login":"dronecore","id":31042455,"avatar_url":"https://avatars1.githubusercontent.com/u/31042455?v=4","gravatar_id":"","url":"https://api.github.com/users/dronecore","html_url":"https://github.com/dronecore","followers_url":"https://api.github.com/users/dronecore/followers","following_url":"https://api.github.com/users/dronecore/following{/other_user}","gists_url":"https://api.github.com/users/dronecore/gists{/gist_id}","starred_url":"https://api.github.com/users/dronecore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dronecore/subscriptions","organizations_url":"https://api.github.com/users/dronecore/orgs","repos_url":"https://api.github.com/users/dronecore/repos","events_url":"https://api.github.com/users/dronecore/events{/privacy}","received_events_url":"https://api.github.com/users/dronecore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dronecore/DroneCore","description":"API and library for PX4 Autopilot using MAVLink written in C++11","fork":false,"url":"https://api.github.com/repos/dronecore/DroneCore","forks_url":"https://api.github.com/repos/dronecore/DroneCore/forks","keys_url":"https://api.github.com/repos/dronecore/DroneCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dronecore/DroneCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dronecore/DroneCore/teams","hooks_url":"https://api.github.com/repos/dronecore/DroneCore/hooks","issue_events_url":"https://api.github.com/repos/dronecore/DroneCore/issues/events{/number}","events_url":"https://api.github.com/repos/dronecore/DroneCore/events","assignees_url":"https://api.github.com/repos/dronecore/DroneCore/assignees{/user}","branches_url":"https://api.github.com/repos/dronecore/DroneCore/branches{/branch}","tags_url":"https://api.github.com/repos/dronecore/DroneCore/tags","blobs_url":"https://api.github.com/repos/dronecore/DroneCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dronecore/DroneCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dronecore/DroneCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/dronecore/DroneCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dronecore/DroneCore/statuses/{sha}","languages_url":"https://api.github.com/repos/dronecore/DroneCore/languages","stargazers_url":"https://api.github.com/repos/dronecore/DroneCore/stargazers","contributors_url":"https://api.github.com/repos/dronecore/DroneCore/contributors","subscribers_url":"https://api.github.com/repos/dronecore/DroneCore/subscribers","subscription_url":"https://api.github.com/repos/dronecore/DroneCore/subscription","commits_url":"https://api.github.com/repos/dronecore/DroneCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/dronecore/DroneCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/dronecore/DroneCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/dronecore/DroneCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/dronecore/DroneCore/contents/{+path}","compare_url":"https://api.github.com/repos/dronecore/DroneCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dronecore/DroneCore/merges","archive_url":"https://api.github.com/repos/dronecore/DroneCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dronecore/DroneCore/downloads","issues_url":"https://api.github.com/repos/dronecore/DroneCore/issues{/number}","pulls_url":"https://api.github.com/repos/dronecore/DroneCore/pulls{/number}","milestones_url":"https://api.github.com/repos/dronecore/DroneCore/milestones{/number}","notifications_url":"https://api.github.com/repos/dronecore/DroneCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dronecore/DroneCore/labels{/name}","releases_url":"https://api.github.com/repos/dronecore/DroneCore/releases{/id}","deployments_url":"https://api.github.com/repos/dronecore/DroneCore/deployments","created_at":"2017-06-19T19:54:57Z","updated_at":"2017-08-22T23:01:33Z","pushed_at":"2017-08-30T11:03:18Z","git_url":"git://github.com/dronecore/DroneCore.git","ssh_url":"git@github.com:dronecore/DroneCore.git","clone_url":"https://github.com/dronecore/DroneCore.git","svn_url":"https://github.com/dronecore/DroneCore","homepage":"","size":478,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":23,"forks":4,"open_issues":23,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dronecore/DroneCore/pulls/42"},"html":{"href":"https://github.com/dronecore/DroneCore/pull/42"},"issue":{"href":"https://api.github.com/repos/dronecore/DroneCore/issues/42"},"comments":{"href":"https://api.github.com/repos/dronecore/DroneCore/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/dronecore/DroneCore/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/dronecore/DroneCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dronecore/DroneCore/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/dronecore/DroneCore/statuses/8e83ca1f62556cc1af6090ed1bf6e6a71926dbf3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"julianoes"}}