{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/122587720","pull_request_review_id":44718055,"id":122587720,"diff_hunk":"@@ -0,0 +1,132 @@\n+/**\n+ * @license\n+ * Copyright 2013 Palantir Technologies, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+import * as utils from \"tsutils\";\n+import * as ts from \"typescript\";\n+\n+const OUTSIDE_CONSTRUCTOR = -1;\n+const DIRECTLY_INSIDE_CONSTRUCTOR = OUTSIDE_CONSTRUCTOR + 1;\n+\n+interface VariableModifications {\n+    toMember?: boolean;\n+    toStatic?: boolean;\n+}\n+\n+export type ParameterOrPropertyDeclaration = ts.ParameterDeclaration | ts.PropertyDeclaration;\n+\n+function typeIsOrHasBaseType(type: ts.Type, parentType: ts.Type) {\n+    if (type.symbol === undefined || parentType.symbol === undefined) {\n+        return false;\n+    }\n+\n+    for (const baseType of [type, ...type.getBaseTypes()]) {\n+        if (baseType.symbol !== undefined && baseType.symbol.name === parentType.symbol.name) {\n+            return true;\n+        }\n+    }\n+\n+    return false;\n+}\n+\n+export class ClassScope {\n+    private readonly privateModifiableMembers = new Map<string, ParameterOrPropertyDeclaration>();\n+    private readonly privateModifiableStatics = new Map<string, ParameterOrPropertyDeclaration>();\n+    private readonly variableModifications = new Map<string, VariableModifications>();\n+\n+    private readonly typeChecker: ts.TypeChecker;\n+    private readonly classType: ts.Type;\n+\n+    private constructorScopeDepth = OUTSIDE_CONSTRUCTOR;\n+\n+    public constructor(classNode: ts.Node, typeChecker: ts.TypeChecker) {\n+        this.classType = typeChecker.getTypeAtLocation(classNode);\n+        this.typeChecker = typeChecker;\n+    }\n+\n+    public addDeclaredVariable(node: ParameterOrPropertyDeclaration) {\n+        if (!utils.isModfierFlagSet(node, ts.ModifierFlags.Private)","path":"src/rules/prefer-readonly/classScope.ts","position":57,"original_position":61,"commit_id":"69543a4789a9b128bc20402b72b0449ae570cac5","original_commit_id":"569ac5ac91888d5bd68dfe1630a98d038cd91e43","user":{"login":"ajafff","id":11968040,"avatar_url":"https://avatars3.githubusercontent.com/u/11968040?v=3","gravatar_id":"","url":"https://api.github.com/users/ajafff","html_url":"https://github.com/ajafff","followers_url":"https://api.github.com/users/ajafff/followers","following_url":"https://api.github.com/users/ajafff/following{/other_user}","gists_url":"https://api.github.com/users/ajafff/gists{/gist_id}","starred_url":"https://api.github.com/users/ajafff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajafff/subscriptions","organizations_url":"https://api.github.com/users/ajafff/orgs","repos_url":"https://api.github.com/users/ajafff/repos","events_url":"https://api.github.com/users/ajafff/events{/privacy}","received_events_url":"https://api.github.com/users/ajafff/received_events","type":"User","site_admin":false},"body":"Is there a reason to still use the misnamed `isModfierFlagSet`?","created_at":"2017-06-18T10:38:00Z","updated_at":"2017-06-18T10:59:17Z","html_url":"https://github.com/palantir/tslint/pull/2896#discussion_r122587720","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/2896","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/122587720"},"html":{"href":"https://github.com/palantir/tslint/pull/2896#discussion_r122587720"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/2896"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/2896","id":124325447,"html_url":"https://github.com/palantir/tslint/pull/2896","diff_url":"https://github.com/palantir/tslint/pull/2896.diff","patch_url":"https://github.com/palantir/tslint/pull/2896.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/2896","number":2896,"state":"open","locked":false,"title":"Added prefer-readonly rule with fixes","user":{"login":"JoshuaKGoldberg","id":3335181,"avatar_url":"https://avatars2.githubusercontent.com/u/3335181?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaKGoldberg","html_url":"https://github.com/JoshuaKGoldberg","followers_url":"https://api.github.com/users/JoshuaKGoldberg/followers","following_url":"https://api.github.com/users/JoshuaKGoldberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKGoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKGoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKGoldberg/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKGoldberg/orgs","repos_url":"https://api.github.com/users/JoshuaKGoldberg/repos","events_url":"https://api.github.com/users/JoshuaKGoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKGoldberg/received_events","type":"User","site_admin":false},"body":"#### PR checklist\r\n\r\n- [x] Addresses an existing issue: #0000\r\n- [x] New feature, bugfix, or enhancement\r\n  - [x] Includes tests\r\n- [x] Documentation update\r\n\r\n#### Overview of change:\r\n\r\nAdds a `prefer-readonly` rule for private member variables that are never re-assigned.\r\n\r\n#### Is there anything you'd like reviewers to focus on?\r\n\r\nAm I missing any relevant test cases?\r\n\r\n#### CHANGELOG.md entry:\r\n\r\n[new-rule] `prefer-readonly`","created_at":"2017-06-07T02:40:41Z","updated_at":"2017-06-18T10:59:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79e761cd71afb61c7e43f55f34637a45f4c2c555","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/2896/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/2896/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/2896/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/69543a4789a9b128bc20402b72b0449ae570cac5","head":{"label":"JoshuaKGoldberg:prefer-readonly","ref":"prefer-readonly","sha":"69543a4789a9b128bc20402b72b0449ae570cac5","user":{"login":"JoshuaKGoldberg","id":3335181,"avatar_url":"https://avatars2.githubusercontent.com/u/3335181?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaKGoldberg","html_url":"https://github.com/JoshuaKGoldberg","followers_url":"https://api.github.com/users/JoshuaKGoldberg/followers","following_url":"https://api.github.com/users/JoshuaKGoldberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKGoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKGoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKGoldberg/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKGoldberg/orgs","repos_url":"https://api.github.com/users/JoshuaKGoldberg/repos","events_url":"https://api.github.com/users/JoshuaKGoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKGoldberg/received_events","type":"User","site_admin":false},"repo":{"id":54208042,"name":"tslint","full_name":"JoshuaKGoldberg/tslint","owner":{"login":"JoshuaKGoldberg","id":3335181,"avatar_url":"https://avatars2.githubusercontent.com/u/3335181?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshuaKGoldberg","html_url":"https://github.com/JoshuaKGoldberg","followers_url":"https://api.github.com/users/JoshuaKGoldberg/followers","following_url":"https://api.github.com/users/JoshuaKGoldberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKGoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKGoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKGoldberg/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKGoldberg/orgs","repos_url":"https://api.github.com/users/JoshuaKGoldberg/repos","events_url":"https://api.github.com/users/JoshuaKGoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKGoldberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoshuaKGoldberg/tslint","description":"An extensible linter for the TypeScript language.","fork":true,"url":"https://api.github.com/repos/JoshuaKGoldberg/tslint","forks_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/forks","keys_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/teams","hooks_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/hooks","issue_events_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/events","assignees_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/tags","blobs_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/languages","stargazers_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/stargazers","contributors_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/contributors","subscribers_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/subscribers","subscription_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/subscription","commits_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/merges","archive_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/downloads","issues_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/labels{/name}","releases_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/JoshuaKGoldberg/tslint/deployments","created_at":"2016-03-18T14:37:43Z","updated_at":"2016-03-18T14:37:45Z","pushed_at":"2017-06-18T08:21:59Z","git_url":"git://github.com/JoshuaKGoldberg/tslint.git","ssh_url":"git@github.com:JoshuaKGoldberg/tslint.git","clone_url":"https://github.com/JoshuaKGoldberg/tslint.git","svn_url":"https://github.com/JoshuaKGoldberg/tslint","homepage":"http://palantir.github.io/tslint/","size":12677,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"ce73397d5c892ba00b2000306df3a6150c0635de","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars3.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars3.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/tslint/deployments","created_at":"2013-07-25T22:19:18Z","updated_at":"2017-06-18T08:08:24Z","pushed_at":"2017-06-18T10:15:20Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":"http://palantir.github.io/tslint/","size":12766,"stargazers_count":1981,"watchers_count":1981,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":419,"mirror_url":null,"open_issues_count":398,"forks":419,"open_issues":398,"watchers":1981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/2896"},"html":{"href":"https://github.com/palantir/tslint/pull/2896"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/2896"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/2896/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/2896/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/2896/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/69543a4789a9b128bc20402b72b0449ae570cac5"}}}}
{"actor":{"display_login":"ajafff"}}