{"action":"created","comment":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments/104626771","pull_request_review_id":25470113,"id":104626771,"diff_hunk":"@@ -319,10 +357,81 @@ public Object clone() throws CloneNotSupportedException {\n     }\n \n     public enum ReplicationMode {\n-        CHAIN_REPLICATION,\n-        QUORUM_REPLICATION,\n-        REPLEX,\n-        NO_REPLICATION\n+        CHAIN_REPLICATION {\n+\n+            @Override\n+            public Boolean sealSegment(LayoutSegment layoutSegment, long sealEpoch, CorfuRuntime runtime)\n+                    throws QuorumUnreachableException {\n+\n+                Boolean success;\n+\n+                for (LayoutStripe layoutStripe : layoutSegment.getStripes()) {\n+                    success = false;\n+                    CompletableFuture<Boolean>[] logUnitSeaFutures = layoutStripe.getLogServers().stream()\n+                            .map(runtime::getRouter)\n+                            .map(x -> x.getClient(BaseClient.class))\n+                            .map(x -> x.setRemoteEpoch(sealEpoch))\n+                            .toArray(CompletableFuture[]::new);\n+\n+                    QuorumFutureFactory.CompositeFuture<Boolean> quorumFuture =","path":"runtime/src/main/java/org/corfudb/runtime/view/Layout.java","position":119,"original_position":119,"commit_id":"1094711b983a2776dcf41ffd319ee884dc132760","original_commit_id":"1094711b983a2776dcf41ffd319ee884dc132760","user":{"login":"no2chem","id":6496984,"avatar_url":"https://avatars3.githubusercontent.com/u/6496984?v=3","gravatar_id":"","url":"https://api.github.com/users/no2chem","html_url":"https://github.com/no2chem","followers_url":"https://api.github.com/users/no2chem/followers","following_url":"https://api.github.com/users/no2chem/following{/other_user}","gists_url":"https://api.github.com/users/no2chem/gists{/gist_id}","starred_url":"https://api.github.com/users/no2chem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no2chem/subscriptions","organizations_url":"https://api.github.com/users/no2chem/orgs","repos_url":"https://api.github.com/users/no2chem/repos","events_url":"https://api.github.com/users/no2chem/events{/privacy}","received_events_url":"https://api.github.com/users/no2chem/received_events","type":"User","site_admin":false},"body":"Interesting. Maybe we should rename QuorumFuturesFactory? @kspirov ","created_at":"2017-03-07T09:48:51Z","updated_at":"2017-03-07T09:50:05Z","html_url":"https://github.com/CorfuDB/CorfuDB/pull/462#discussion_r104626771","pull_request_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/462","_links":{"self":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments/104626771"},"html":{"href":"https://github.com/CorfuDB/CorfuDB/pull/462#discussion_r104626771"},"pull_request":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/462"}}},"pull_request":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/462","id":109367193,"html_url":"https://github.com/CorfuDB/CorfuDB/pull/462","diff_url":"https://github.com/CorfuDB/CorfuDB/pull/462.diff","patch_url":"https://github.com/CorfuDB/CorfuDB/pull/462.patch","issue_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/462","number":462,"state":"open","locked":false,"title":"Modifying epoch seal","user":{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars0.githubusercontent.com/u/10751367?v=3","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"body":"## Seal\r\n\r\n### Layout Seal\r\n- Wait for a quorum of layout servers to respond.\r\n- If respond received succeed and attempt to seal log unit servers.\r\n- If fail, fallback with quorumUnreachableException\r\n\r\n### LogUnit Seal\r\n- Chain Replication:\r\n  - Wait for one response from chain in every stripe.\r\n- Quorum Replication:\r\n  - Wait for quorum of log units to respond from every stripe.","created_at":"2017-03-06T22:47:51Z","updated_at":"2017-03-07T09:50:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9ee48fe51fe7b9f9d9cb3189f044be7bd1aa31f","assignee":{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars0.githubusercontent.com/u/10751367?v=3","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"assignees":[{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars0.githubusercontent.com/u/10751367?v=3","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/462/commits","review_comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/462/comments","review_comment_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/462/comments","statuses_url":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/1094711b983a2776dcf41ffd319ee884dc132760","head":{"label":"zalokhan:seal","ref":"seal","sha":"1094711b983a2776dcf41ffd319ee884dc132760","user":{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars0.githubusercontent.com/u/10751367?v=3","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"repo":{"id":66982229,"name":"CorfuDB","full_name":"zalokhan/CorfuDB","owner":{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars0.githubusercontent.com/u/10751367?v=3","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zalokhan/CorfuDB","description":"A cluster consistency platform","fork":true,"url":"https://api.github.com/repos/zalokhan/CorfuDB","forks_url":"https://api.github.com/repos/zalokhan/CorfuDB/forks","keys_url":"https://api.github.com/repos/zalokhan/CorfuDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalokhan/CorfuDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalokhan/CorfuDB/teams","hooks_url":"https://api.github.com/repos/zalokhan/CorfuDB/hooks","issue_events_url":"https://api.github.com/repos/zalokhan/CorfuDB/issues/events{/number}","events_url":"https://api.github.com/repos/zalokhan/CorfuDB/events","assignees_url":"https://api.github.com/repos/zalokhan/CorfuDB/assignees{/user}","branches_url":"https://api.github.com/repos/zalokhan/CorfuDB/branches{/branch}","tags_url":"https://api.github.com/repos/zalokhan/CorfuDB/tags","blobs_url":"https://api.github.com/repos/zalokhan/CorfuDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalokhan/CorfuDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalokhan/CorfuDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalokhan/CorfuDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalokhan/CorfuDB/statuses/{sha}","languages_url":"https://api.github.com/repos/zalokhan/CorfuDB/languages","stargazers_url":"https://api.github.com/repos/zalokhan/CorfuDB/stargazers","contributors_url":"https://api.github.com/repos/zalokhan/CorfuDB/contributors","subscribers_url":"https://api.github.com/repos/zalokhan/CorfuDB/subscribers","subscription_url":"https://api.github.com/repos/zalokhan/CorfuDB/subscription","commits_url":"https://api.github.com/repos/zalokhan/CorfuDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalokhan/CorfuDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalokhan/CorfuDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalokhan/CorfuDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalokhan/CorfuDB/contents/{+path}","compare_url":"https://api.github.com/repos/zalokhan/CorfuDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalokhan/CorfuDB/merges","archive_url":"https://api.github.com/repos/zalokhan/CorfuDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalokhan/CorfuDB/downloads","issues_url":"https://api.github.com/repos/zalokhan/CorfuDB/issues{/number}","pulls_url":"https://api.github.com/repos/zalokhan/CorfuDB/pulls{/number}","milestones_url":"https://api.github.com/repos/zalokhan/CorfuDB/milestones{/number}","notifications_url":"https://api.github.com/repos/zalokhan/CorfuDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalokhan/CorfuDB/labels{/name}","releases_url":"https://api.github.com/repos/zalokhan/CorfuDB/releases{/id}","deployments_url":"https://api.github.com/repos/zalokhan/CorfuDB/deployments","created_at":"2016-08-30T22:27:02Z","updated_at":"2016-08-30T22:27:04Z","pushed_at":"2017-03-06T22:46:39Z","git_url":"git://github.com/zalokhan/CorfuDB.git","ssh_url":"git@github.com:zalokhan/CorfuDB.git","clone_url":"https://github.com/zalokhan/CorfuDB.git","svn_url":"https://github.com/zalokhan/CorfuDB","homepage":"","size":95316,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CorfuDB:master","ref":"master","sha":"5c4b1451b13677268163d9a57a01bb10f9b8de60","user":{"login":"CorfuDB","id":10199273,"avatar_url":"https://avatars3.githubusercontent.com/u/10199273?v=3","gravatar_id":"","url":"https://api.github.com/users/CorfuDB","html_url":"https://github.com/CorfuDB","followers_url":"https://api.github.com/users/CorfuDB/followers","following_url":"https://api.github.com/users/CorfuDB/following{/other_user}","gists_url":"https://api.github.com/users/CorfuDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CorfuDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorfuDB/subscriptions","organizations_url":"https://api.github.com/users/CorfuDB/orgs","repos_url":"https://api.github.com/users/CorfuDB/repos","events_url":"https://api.github.com/users/CorfuDB/events{/privacy}","received_events_url":"https://api.github.com/users/CorfuDB/received_events","type":"Organization","site_admin":false},"repo":{"id":12960439,"name":"CorfuDB","full_name":"CorfuDB/CorfuDB","owner":{"login":"CorfuDB","id":10199273,"avatar_url":"https://avatars3.githubusercontent.com/u/10199273?v=3","gravatar_id":"","url":"https://api.github.com/users/CorfuDB","html_url":"https://github.com/CorfuDB","followers_url":"https://api.github.com/users/CorfuDB/followers","following_url":"https://api.github.com/users/CorfuDB/following{/other_user}","gists_url":"https://api.github.com/users/CorfuDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CorfuDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorfuDB/subscriptions","organizations_url":"https://api.github.com/users/CorfuDB/orgs","repos_url":"https://api.github.com/users/CorfuDB/repos","events_url":"https://api.github.com/users/CorfuDB/events{/privacy}","received_events_url":"https://api.github.com/users/CorfuDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CorfuDB/CorfuDB","description":"A cluster consistency platform","fork":false,"url":"https://api.github.com/repos/CorfuDB/CorfuDB","forks_url":"https://api.github.com/repos/CorfuDB/CorfuDB/forks","keys_url":"https://api.github.com/repos/CorfuDB/CorfuDB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CorfuDB/CorfuDB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CorfuDB/CorfuDB/teams","hooks_url":"https://api.github.com/repos/CorfuDB/CorfuDB/hooks","issue_events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/events{/number}","events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/events","assignees_url":"https://api.github.com/repos/CorfuDB/CorfuDB/assignees{/user}","branches_url":"https://api.github.com/repos/CorfuDB/CorfuDB/branches{/branch}","tags_url":"https://api.github.com/repos/CorfuDB/CorfuDB/tags","blobs_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/refs{/sha}","trees_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/{sha}","languages_url":"https://api.github.com/repos/CorfuDB/CorfuDB/languages","stargazers_url":"https://api.github.com/repos/CorfuDB/CorfuDB/stargazers","contributors_url":"https://api.github.com/repos/CorfuDB/CorfuDB/contributors","subscribers_url":"https://api.github.com/repos/CorfuDB/CorfuDB/subscribers","subscription_url":"https://api.github.com/repos/CorfuDB/CorfuDB/subscription","commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/commits{/sha}","git_commits_url":"https://api.github.com/repos/CorfuDB/CorfuDB/git/commits{/sha}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/comments{/number}","issue_comment_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/comments{/number}","contents_url":"https://api.github.com/repos/CorfuDB/CorfuDB/contents/{+path}","compare_url":"https://api.github.com/repos/CorfuDB/CorfuDB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CorfuDB/CorfuDB/merges","archive_url":"https://api.github.com/repos/CorfuDB/CorfuDB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CorfuDB/CorfuDB/downloads","issues_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues{/number}","pulls_url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls{/number}","milestones_url":"https://api.github.com/repos/CorfuDB/CorfuDB/milestones{/number}","notifications_url":"https://api.github.com/repos/CorfuDB/CorfuDB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CorfuDB/CorfuDB/labels{/name}","releases_url":"https://api.github.com/repos/CorfuDB/CorfuDB/releases{/id}","deployments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/deployments","created_at":"2013-09-19T22:02:36Z","updated_at":"2017-03-05T20:27:19Z","pushed_at":"2017-03-07T09:08:55Z","git_url":"git://github.com/CorfuDB/CorfuDB.git","ssh_url":"git@github.com:CorfuDB/CorfuDB.git","clone_url":"https://github.com/CorfuDB/CorfuDB.git","svn_url":"https://github.com/CorfuDB/CorfuDB","homepage":"","size":305906,"stargazers_count":166,"watchers_count":166,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":55,"forks":41,"open_issues":55,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/462"},"html":{"href":"https://github.com/CorfuDB/CorfuDB/pull/462"},"issue":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/462"},"comments":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/462/comments"},"review_comments":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/462/comments"},"review_comment":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/462/commits"},"statuses":{"href":"https://api.github.com/repos/CorfuDB/CorfuDB/statuses/1094711b983a2776dcf41ffd319ee884dc132760"}}}}
{"actor":{"display_login":"no2chem"}}