{"action":"created","comment":{"url":"https://api.github.com/repos/desktop/desktop/pulls/comments/124286332","pull_request_review_id":46561314,"id":124286332,"diff_hunk":"@@ -201,7 +201,7 @@ export class ToolbarDropdown extends React.Component<IToolbarDropdownProps, IToo\n     this.innerButton = null\n   }\n \n-  public componentDidUpdate = () => {\n+  public componentDidUpdate() {","path":"app/src/ui/toolbar/dropdown.tsx","position":5,"original_position":5,"commit_id":"4083ff86c894e35b6bead0ec09d91c616d38a6a6","original_commit_id":"4083ff86c894e35b6bead0ec09d91c616d38a6a6","user":{"login":"j-f1","id":25517624,"avatar_url":"https://avatars1.githubusercontent.com/u/25517624?v=3","gravatar_id":"","url":"https://api.github.com/users/j-f1","html_url":"https://github.com/j-f1","followers_url":"https://api.github.com/users/j-f1/followers","following_url":"https://api.github.com/users/j-f1/following{/other_user}","gists_url":"https://api.github.com/users/j-f1/gists{/gist_id}","starred_url":"https://api.github.com/users/j-f1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-f1/subscriptions","organizations_url":"https://api.github.com/users/j-f1/orgs","repos_url":"https://api.github.com/users/j-f1/repos","events_url":"https://api.github.com/users/j-f1/events{/privacy}","received_events_url":"https://api.github.com/users/j-f1/received_events","type":"User","site_admin":false},"body":"🤦 right. Thanks!","created_at":"2017-06-27T14:16:30Z","updated_at":"2017-06-27T14:16:31Z","html_url":"https://github.com/desktop/desktop/pull/2124#discussion_r124286332","pull_request_url":"https://api.github.com/repos/desktop/desktop/pulls/2124","_links":{"self":{"href":"https://api.github.com/repos/desktop/desktop/pulls/comments/124286332"},"html":{"href":"https://github.com/desktop/desktop/pull/2124#discussion_r124286332"},"pull_request":{"href":"https://api.github.com/repos/desktop/desktop/pulls/2124"}}},"pull_request":{"url":"https://api.github.com/repos/desktop/desktop/pulls/2124","id":127595555,"html_url":"https://github.com/desktop/desktop/pull/2124","diff_url":"https://github.com/desktop/desktop/pull/2124.diff","patch_url":"https://github.com/desktop/desktop/pull/2124.patch","issue_url":"https://api.github.com/repos/desktop/desktop/issues/2124","number":2124,"state":"open","locked":false,"title":"Update All The Reacts","user":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars1.githubusercontent.com/u/359239?v=3","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"body":"It's been a while since we bumped the `react*` packages, and there's been a bunch of changes to the related `@types/react*` packages. So let's do that.\r\n\r\nThis uncovered a bunch of changes to how the type declarations now work, and while I did love our use of `void` for the state type in `React.Component<TProps, TState>`, this confuses TypeScript as `setState` expects a type - even in cases when a component doesn't use it. So an empty `{}` isn't the exact same thing, but any accidental `setState` usages should fail.\r\n\r\nThe other thing that's changed is the `children` prop on components - React now declares this by default:\r\n\r\n```ts\r\n    interface Props<T> {\r\n        children?: ReactNode;\r\n        key?: Key;\r\n        ref?: Ref<T>;\r\n    }\r\n\r\n    type ReactNode = ReactChild | ReactFragment | boolean | null | undefined;\r\n```\r\n\r\nI didn't feel great about removing the places where `children` was already defined, because it is no longer clear which components will render `children` elements. The alternative, making it explicit everywhere and aligning it with the declaration that React provides, also didn't feel great. I'll ponder on this some more before marking this as ready for review.\r\n\r\nI'll also do a bunch of real testing to ensure nothing is now broken.\r\n\r\nOne upside: it did pick up that we had incorrectly declared an instance property for `componentDidUpdate` in `dropdown.tsx`, rather than declaring it as an instance member.\r\n\r\nEDIT: and the signature for `list.tsx`'s `ref` callback needs to take in `React.Component<any, any> | null` (it previously didn't). \r\n","created_at":"2017-06-27T01:28:42Z","updated_at":"2017-06-27T14:16:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"563e333506974161dfc9cb9311c89a934699c2c3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/desktop/desktop/pulls/2124/commits","review_comments_url":"https://api.github.com/repos/desktop/desktop/pulls/2124/comments","review_comment_url":"https://api.github.com/repos/desktop/desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/desktop/desktop/issues/2124/comments","statuses_url":"https://api.github.com/repos/desktop/desktop/statuses/4083ff86c894e35b6bead0ec09d91c616d38a6a6","head":{"label":"desktop:bump-all-the-reacts","ref":"bump-all-the-reacts","sha":"4083ff86c894e35b6bead0ec09d91c616d38a6a6","user":{"login":"desktop","id":13171334,"avatar_url":"https://avatars3.githubusercontent.com/u/13171334?v=3","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"repo":{"id":58559694,"name":"desktop","full_name":"desktop/desktop","owner":{"login":"desktop","id":13171334,"avatar_url":"https://avatars3.githubusercontent.com/u/13171334?v=3","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/desktop/desktop","description":"Simple collaboration from your desktop","fork":false,"url":"https://api.github.com/repos/desktop/desktop","forks_url":"https://api.github.com/repos/desktop/desktop/forks","keys_url":"https://api.github.com/repos/desktop/desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desktop/desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desktop/desktop/teams","hooks_url":"https://api.github.com/repos/desktop/desktop/hooks","issue_events_url":"https://api.github.com/repos/desktop/desktop/issues/events{/number}","events_url":"https://api.github.com/repos/desktop/desktop/events","assignees_url":"https://api.github.com/repos/desktop/desktop/assignees{/user}","branches_url":"https://api.github.com/repos/desktop/desktop/branches{/branch}","tags_url":"https://api.github.com/repos/desktop/desktop/tags","blobs_url":"https://api.github.com/repos/desktop/desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desktop/desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desktop/desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/desktop/desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desktop/desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/desktop/desktop/languages","stargazers_url":"https://api.github.com/repos/desktop/desktop/stargazers","contributors_url":"https://api.github.com/repos/desktop/desktop/contributors","subscribers_url":"https://api.github.com/repos/desktop/desktop/subscribers","subscription_url":"https://api.github.com/repos/desktop/desktop/subscription","commits_url":"https://api.github.com/repos/desktop/desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/desktop/desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/desktop/desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/desktop/desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/desktop/desktop/contents/{+path}","compare_url":"https://api.github.com/repos/desktop/desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desktop/desktop/merges","archive_url":"https://api.github.com/repos/desktop/desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desktop/desktop/downloads","issues_url":"https://api.github.com/repos/desktop/desktop/issues{/number}","pulls_url":"https://api.github.com/repos/desktop/desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/desktop/desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/desktop/desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desktop/desktop/labels{/name}","releases_url":"https://api.github.com/repos/desktop/desktop/releases{/id}","deployments_url":"https://api.github.com/repos/desktop/desktop/deployments","created_at":"2016-05-11T15:59:00Z","updated_at":"2017-06-27T10:29:59Z","pushed_at":"2017-06-27T02:07:29Z","git_url":"git://github.com/desktop/desktop.git","ssh_url":"git@github.com:desktop/desktop.git","clone_url":"https://github.com/desktop/desktop.git","svn_url":"https://github.com/desktop/desktop","homepage":"https://desktop.github.com","size":14300,"stargazers_count":2219,"watchers_count":2219,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":213,"mirror_url":null,"open_issues_count":284,"forks":213,"open_issues":284,"watchers":2219,"default_branch":"master"}},"base":{"label":"desktop:master","ref":"master","sha":"d8ae429c2541ae0b2964c8dfe7dfd7396a9056ae","user":{"login":"desktop","id":13171334,"avatar_url":"https://avatars3.githubusercontent.com/u/13171334?v=3","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"repo":{"id":58559694,"name":"desktop","full_name":"desktop/desktop","owner":{"login":"desktop","id":13171334,"avatar_url":"https://avatars3.githubusercontent.com/u/13171334?v=3","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/desktop/desktop","description":"Simple collaboration from your desktop","fork":false,"url":"https://api.github.com/repos/desktop/desktop","forks_url":"https://api.github.com/repos/desktop/desktop/forks","keys_url":"https://api.github.com/repos/desktop/desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desktop/desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desktop/desktop/teams","hooks_url":"https://api.github.com/repos/desktop/desktop/hooks","issue_events_url":"https://api.github.com/repos/desktop/desktop/issues/events{/number}","events_url":"https://api.github.com/repos/desktop/desktop/events","assignees_url":"https://api.github.com/repos/desktop/desktop/assignees{/user}","branches_url":"https://api.github.com/repos/desktop/desktop/branches{/branch}","tags_url":"https://api.github.com/repos/desktop/desktop/tags","blobs_url":"https://api.github.com/repos/desktop/desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desktop/desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desktop/desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/desktop/desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desktop/desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/desktop/desktop/languages","stargazers_url":"https://api.github.com/repos/desktop/desktop/stargazers","contributors_url":"https://api.github.com/repos/desktop/desktop/contributors","subscribers_url":"https://api.github.com/repos/desktop/desktop/subscribers","subscription_url":"https://api.github.com/repos/desktop/desktop/subscription","commits_url":"https://api.github.com/repos/desktop/desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/desktop/desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/desktop/desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/desktop/desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/desktop/desktop/contents/{+path}","compare_url":"https://api.github.com/repos/desktop/desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desktop/desktop/merges","archive_url":"https://api.github.com/repos/desktop/desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desktop/desktop/downloads","issues_url":"https://api.github.com/repos/desktop/desktop/issues{/number}","pulls_url":"https://api.github.com/repos/desktop/desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/desktop/desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/desktop/desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desktop/desktop/labels{/name}","releases_url":"https://api.github.com/repos/desktop/desktop/releases{/id}","deployments_url":"https://api.github.com/repos/desktop/desktop/deployments","created_at":"2016-05-11T15:59:00Z","updated_at":"2017-06-27T10:29:59Z","pushed_at":"2017-06-27T02:07:29Z","git_url":"git://github.com/desktop/desktop.git","ssh_url":"git@github.com:desktop/desktop.git","clone_url":"https://github.com/desktop/desktop.git","svn_url":"https://github.com/desktop/desktop","homepage":"https://desktop.github.com","size":14300,"stargazers_count":2219,"watchers_count":2219,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":213,"mirror_url":null,"open_issues_count":284,"forks":213,"open_issues":284,"watchers":2219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/desktop/desktop/pulls/2124"},"html":{"href":"https://github.com/desktop/desktop/pull/2124"},"issue":{"href":"https://api.github.com/repos/desktop/desktop/issues/2124"},"comments":{"href":"https://api.github.com/repos/desktop/desktop/issues/2124/comments"},"review_comments":{"href":"https://api.github.com/repos/desktop/desktop/pulls/2124/comments"},"review_comment":{"href":"https://api.github.com/repos/desktop/desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/desktop/desktop/pulls/2124/commits"},"statuses":{"href":"https://api.github.com/repos/desktop/desktop/statuses/4083ff86c894e35b6bead0ec09d91c616d38a6a6"}}}}
{"actor":{"display_login":"j-f1"}}