{"action":"created","issue":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1842","repository_url":"https://api.github.com/repos/kaldi-asr/kaldi","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1842/labels{/name}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1842/comments","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1842/events","html_url":"https://github.com/kaldi-asr/kaldi/issues/1842","id":252648205,"number":1842,"title":"Missing header subfolder in compressed-matrix.h include directive","user":{"login":"flavajav","id":5039453,"avatar_url":"https://avatars3.githubusercontent.com/u/5039453?v=4","gravatar_id":"","url":"https://api.github.com/users/flavajav","html_url":"https://github.com/flavajav","followers_url":"https://api.github.com/users/flavajav/followers","following_url":"https://api.github.com/users/flavajav/following{/other_user}","gists_url":"https://api.github.com/users/flavajav/gists{/gist_id}","starred_url":"https://api.github.com/users/flavajav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flavajav/subscriptions","organizations_url":"https://api.github.com/users/flavajav/orgs","repos_url":"https://api.github.com/users/flavajav/repos","events_url":"https://api.github.com/users/flavajav/events{/privacy}","received_events_url":"https://api.github.com/users/flavajav/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-24T15:54:24Z","updated_at":"2017-09-06T14:01:30Z","closed_at":"2017-09-06T14:01:30Z","author_association":"NONE","body":"In the file `src/matrix/compressed-matrix.h`, the following include directive needs to be corrected from\r\n```c++\r\n#include \"kaldi-matrix.h\"\r\n```\r\nto\r\n```c++\r\n#include \"matrix/kaldi-matrix.h\"\r\n```\r\nas it is, for example, in the file `src/matrix/sparse-matrix.h`. This does not affect the compilation of Kaldi proper since the corresponding object file is compiled from within the `src/matrix/` folder and thus `kaldi-matrix.h` is found since the invoking folder (in this case, `src/matrix/`) is by default included in the header search path. However, when writing new code in a completely separate location using `-I<kaldi-header-root-folder>` which somewhere includes `matrix/compressed-matrix.h`, compilation will fail with a \"kaldi-matrix.h file not found\" message (unless, of course, `-I<kaldi-header-root-folder>/matrix` is also added to the compiler flags).\r\n\r\nIt's not a big deal and there's an easy workaround, but I thought I'd mention it, especially since it should also prove to be a very quick issue to close."},"comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments/327492621","html_url":"https://github.com/kaldi-asr/kaldi/issues/1842#issuecomment-327492621","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1842","id":327492621,"user":{"login":"jtrmal","id":11054175,"avatar_url":"https://avatars2.githubusercontent.com/u/11054175?v=4","gravatar_id":"","url":"https://api.github.com/users/jtrmal","html_url":"https://github.com/jtrmal","followers_url":"https://api.github.com/users/jtrmal/followers","following_url":"https://api.github.com/users/jtrmal/following{/other_user}","gists_url":"https://api.github.com/users/jtrmal/gists{/gist_id}","starred_url":"https://api.github.com/users/jtrmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtrmal/subscriptions","organizations_url":"https://api.github.com/users/jtrmal/orgs","repos_url":"https://api.github.com/users/jtrmal/repos","events_url":"https://api.github.com/users/jtrmal/events{/privacy}","received_events_url":"https://api.github.com/users/jtrmal/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T14:01:30Z","updated_at":"2017-09-06T14:01:30Z","author_association":"CONTRIBUTOR","body":"Addressed, closing."}}
{"actor":{"display_login":"jtrmal"}}