{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/110779120","pull_request_review_id":31976483,"id":110779120,"diff_hunk":"@@ -11,9 +11,109 @@\n \n node_names.uniq!\n \n-authfile = \"#{testdir}/auth.conf\"\n-authconf = node_names.map do |node_name|\n-  %Q[\n+if @options[:is_puppetserver]\n+  step \"Ensure legacy auth.conf is disabled for test\" do\n+    modify_tk_config(master, options['puppetserver-config'], {'jruby-puppet' => {'use-legacy-auth-conf' => false}})\n+  end\n+\n+  teardown do\n+    modify_tk_config(master, options['puppetserver-config'], {'jruby-puppet' => {'use-legacy-auth-conf' => true}})","path":"acceptance/tests/allow_arbitrary_node_name_fact_for_agent.rb","position":13,"original_position":13,"commit_id":"9dafd41ca370259ba79b335f5e4b229a17399b8f","original_commit_id":"9dafd41ca370259ba79b335f5e4b229a17399b8f","user":{"login":"camlow325","id":5652737,"avatar_url":"https://avatars3.githubusercontent.com/u/5652737?v=3","gravatar_id":"","url":"https://api.github.com/users/camlow325","html_url":"https://github.com/camlow325","followers_url":"https://api.github.com/users/camlow325/followers","following_url":"https://api.github.com/users/camlow325/following{/other_user}","gists_url":"https://api.github.com/users/camlow325/gists{/gist_id}","starred_url":"https://api.github.com/users/camlow325/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camlow325/subscriptions","organizations_url":"https://api.github.com/users/camlow325/orgs","repos_url":"https://api.github.com/users/camlow325/repos","events_url":"https://api.github.com/users/camlow325/events{/privacy}","received_events_url":"https://api.github.com/users/camlow325/received_events","type":"User","site_admin":false},"body":"Seems like this step should just set the value back to whatever it was to start with, which might have been `false`, the new default.  Another option could be to just back up the `puppetserver-config` file in its entirety and restore it as part of the teardown.  I did something like that with the [collect_default_metrics](https://github.com/puppetlabs/puppetserver/blob/97be028c37709701a47abf10ead39d2a152bd32f/acceptance/suites/tests/metrics/collect_default_metrics.rb#L13-L19) test in Puppet Server.","created_at":"2017-04-10T22:36:06Z","updated_at":"2017-04-10T22:36:06Z","html_url":"https://github.com/puppetlabs/puppet/pull/5793#discussion_r110779120","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5793","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/110779120"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5793#discussion_r110779120"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5793"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5793","id":115192932,"html_url":"https://github.com/puppetlabs/puppet/pull/5793","diff_url":"https://github.com/puppetlabs/puppet/pull/5793.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5793.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5793","number":5793,"state":"open","locked":false,"title":"(REVIEW) (SERVER-1766) Use tk-auth rules when running acceptance under puppetserver","user":{"login":"adrienthebo","id":172194,"avatar_url":"https://avatars2.githubusercontent.com/u/172194?v=3","gravatar_id":"","url":"https://api.github.com/users/adrienthebo","html_url":"https://github.com/adrienthebo","followers_url":"https://api.github.com/users/adrienthebo/followers","following_url":"https://api.github.com/users/adrienthebo/following{/other_user}","gists_url":"https://api.github.com/users/adrienthebo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienthebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienthebo/subscriptions","organizations_url":"https://api.github.com/users/adrienthebo/orgs","repos_url":"https://api.github.com/users/adrienthebo/repos","events_url":"https://api.github.com/users/adrienthebo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienthebo/received_events","type":"User","site_admin":false},"body":"/cc @rlinehan @jpinsonault @camlow325 \r\n\r\nIf we like this approach I can apply it to other instances where we need to modify auth.conf.\r\n","created_at":"2017-04-10T21:08:50Z","updated_at":"2017-04-10T22:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e79e6468a942a23a92745879c0099e4bdf5af5ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5793/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5793/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5793/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/9dafd41ca370259ba79b335f5e4b229a17399b8f","head":{"label":"adrienthebo:server-1766-puppetserver-tk-auth","ref":"server-1766-puppetserver-tk-auth","sha":"9dafd41ca370259ba79b335f5e4b229a17399b8f","user":{"login":"adrienthebo","id":172194,"avatar_url":"https://avatars2.githubusercontent.com/u/172194?v=3","gravatar_id":"","url":"https://api.github.com/users/adrienthebo","html_url":"https://github.com/adrienthebo","followers_url":"https://api.github.com/users/adrienthebo/followers","following_url":"https://api.github.com/users/adrienthebo/following{/other_user}","gists_url":"https://api.github.com/users/adrienthebo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienthebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienthebo/subscriptions","organizations_url":"https://api.github.com/users/adrienthebo/orgs","repos_url":"https://api.github.com/users/adrienthebo/repos","events_url":"https://api.github.com/users/adrienthebo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienthebo/received_events","type":"User","site_admin":false},"repo":{"id":4814986,"name":"puppet","full_name":"adrienthebo/puppet","owner":{"login":"adrienthebo","id":172194,"avatar_url":"https://avatars2.githubusercontent.com/u/172194?v=3","gravatar_id":"","url":"https://api.github.com/users/adrienthebo","html_url":"https://github.com/adrienthebo","followers_url":"https://api.github.com/users/adrienthebo/followers","following_url":"https://api.github.com/users/adrienthebo/following{/other_user}","gists_url":"https://api.github.com/users/adrienthebo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienthebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienthebo/subscriptions","organizations_url":"https://api.github.com/users/adrienthebo/orgs","repos_url":"https://api.github.com/users/adrienthebo/repos","events_url":"https://api.github.com/users/adrienthebo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienthebo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrienthebo/puppet","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/adrienthebo/puppet","forks_url":"https://api.github.com/repos/adrienthebo/puppet/forks","keys_url":"https://api.github.com/repos/adrienthebo/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrienthebo/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrienthebo/puppet/teams","hooks_url":"https://api.github.com/repos/adrienthebo/puppet/hooks","issue_events_url":"https://api.github.com/repos/adrienthebo/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/adrienthebo/puppet/events","assignees_url":"https://api.github.com/repos/adrienthebo/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/adrienthebo/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/adrienthebo/puppet/tags","blobs_url":"https://api.github.com/repos/adrienthebo/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrienthebo/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrienthebo/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrienthebo/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrienthebo/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/adrienthebo/puppet/languages","stargazers_url":"https://api.github.com/repos/adrienthebo/puppet/stargazers","contributors_url":"https://api.github.com/repos/adrienthebo/puppet/contributors","subscribers_url":"https://api.github.com/repos/adrienthebo/puppet/subscribers","subscription_url":"https://api.github.com/repos/adrienthebo/puppet/subscription","commits_url":"https://api.github.com/repos/adrienthebo/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrienthebo/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrienthebo/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrienthebo/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrienthebo/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/adrienthebo/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrienthebo/puppet/merges","archive_url":"https://api.github.com/repos/adrienthebo/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrienthebo/puppet/downloads","issues_url":"https://api.github.com/repos/adrienthebo/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/adrienthebo/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/adrienthebo/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/adrienthebo/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrienthebo/puppet/labels{/name}","releases_url":"https://api.github.com/repos/adrienthebo/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/adrienthebo/puppet/deployments","created_at":"2012-06-28T00:10:44Z","updated_at":"2014-06-17T23:02:57Z","pushed_at":"2017-04-10T21:09:51Z","git_url":"git://github.com/adrienthebo/puppet.git","ssh_url":"git@github.com:adrienthebo/puppet.git","clone_url":"https://github.com/adrienthebo/puppet.git","svn_url":"https://github.com/adrienthebo/puppet","homepage":"http://www.puppetlabs.com/puppet/introduction/","size":55031,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"4b09fbc293a7e02d8541331965e9570a154e0c90","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars3.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":910744,"name":"puppet","full_name":"puppetlabs/puppet","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars3.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet","forks_url":"https://api.github.com/repos/puppetlabs/puppet/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppet/deployments","created_at":"2010-09-14T19:26:44Z","updated_at":"2017-04-10T17:01:23Z","pushed_at":"2017-04-10T22:14:14Z","git_url":"git://github.com/puppetlabs/puppet.git","ssh_url":"git@github.com:puppetlabs/puppet.git","clone_url":"https://github.com/puppetlabs/puppet.git","svn_url":"https://github.com/puppetlabs/puppet","homepage":"https://puppet.com/puppet/what-is-puppet","size":55189,"stargazers_count":4412,"watchers_count":4412,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1825,"mirror_url":null,"open_issues_count":92,"forks":1825,"open_issues":92,"watchers":4412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5793"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/5793"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5793"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/issues/5793/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5793/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/5793/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet/statuses/9dafd41ca370259ba79b335f5e4b229a17399b8f"}}}}
{"actor":{"display_login":"camlow325"}}