{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/COLLADA2GLTF/issues/83","repository_url":"https://api.github.com/repos/KhronosGroup/COLLADA2GLTF","labels_url":"https://api.github.com/repos/KhronosGroup/COLLADA2GLTF/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/COLLADA2GLTF/issues/83/comments","events_url":"https://api.github.com/repos/KhronosGroup/COLLADA2GLTF/issues/83/events","html_url":"https://github.com/KhronosGroup/COLLADA2GLTF/pull/83","id":253186512,"number":83,"title":"Adds support for outputting glTF 1.0","user":{"login":"lasalvavida","id":2489570,"avatar_url":"https://avatars0.githubusercontent.com/u/2489570?v=4","gravatar_id":"","url":"https://api.github.com/users/lasalvavida","html_url":"https://github.com/lasalvavida","followers_url":"https://api.github.com/users/lasalvavida/followers","following_url":"https://api.github.com/users/lasalvavida/following{/other_user}","gists_url":"https://api.github.com/users/lasalvavida/gists{/gist_id}","starred_url":"https://api.github.com/users/lasalvavida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasalvavida/subscriptions","organizations_url":"https://api.github.com/users/lasalvavida/orgs","repos_url":"https://api.github.com/users/lasalvavida/repos","events_url":"https://api.github.com/users/lasalvavida/events{/privacy}","received_events_url":"https://api.github.com/users/lasalvavida/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":42,"created_at":"2017-08-27T20:12:15Z","updated_at":"2017-09-24T09:29:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/KhronosGroup/COLLADA2GLTF/pulls/83","html_url":"https://github.com/KhronosGroup/COLLADA2GLTF/pull/83","diff_url":"https://github.com/KhronosGroup/COLLADA2GLTF/pull/83.diff","patch_url":"https://github.com/KhronosGroup/COLLADA2GLTF/pull/83.patch"},"body":"This is for #69. \r\n\r\nAdds support to the new converter for outputting glTF 1.0 with `-v 1.0` or `--version 1.0`. I've done some preliminary testing, but this should be tested thoroughly before it gets merged.\r\n\r\nAny help testing it is much appreciated.\r\n\r\n@pjcozzi \r\n@cx20\r\n@lexaknyazev \r\n\r\nOnce this merges, #37 will merge into master shortly thereafter since there's really no reason to keep the old converter on master anymore. It will be parked on a `1.0-legacy` branch. Any issues marked legacy will be closed as long as their issues are corrected by the new converter in 1.0 mode."},"comment":{"url":"https://api.github.com/repos/KhronosGroup/COLLADA2GLTF/issues/comments/331698264","html_url":"https://github.com/KhronosGroup/COLLADA2GLTF/pull/83#issuecomment-331698264","issue_url":"https://api.github.com/repos/KhronosGroup/COLLADA2GLTF/issues/83","id":331698264,"user":{"login":"cx20","id":1833979,"avatar_url":"https://avatars3.githubusercontent.com/u/1833979?v=4","gravatar_id":"","url":"https://api.github.com/users/cx20","html_url":"https://github.com/cx20","followers_url":"https://api.github.com/users/cx20/followers","following_url":"https://api.github.com/users/cx20/following{/other_user}","gists_url":"https://api.github.com/users/cx20/gists{/gist_id}","starred_url":"https://api.github.com/users/cx20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cx20/subscriptions","organizations_url":"https://api.github.com/users/cx20/orgs","repos_url":"https://api.github.com/users/cx20/repos","events_url":"https://api.github.com/users/cx20/events{/privacy}","received_events_url":"https://api.github.com/users/cx20/received_events","type":"User","site_admin":false},"created_at":"2017-09-24T09:29:04Z","updated_at":"2017-09-24T09:29:04Z","author_association":"NONE","body":"@javagl\r\n\r\n> When taking out the scaling factor of the root node, the other matrices **and** the geometry (!) have to be adjusted accordingly.\r\n\r\nAs you pointed out, I confirmed that you can display with camera by modifying both matrix and geometry.\r\n\r\nbefore:\r\n![image](https://user-images.githubusercontent.com/1833979/30781019-ad8057de-a152-11e7-88bc-014f77b227c7.png)\r\n\r\nafter:\r\n![image](https://user-images.githubusercontent.com/1833979/30781024-c1fd548c-a152-11e7-8cbb-fcd5fe1c3ddd.png)\r\n\r\ncamera result:\r\n![image](https://user-images.githubusercontent.com/1833979/30781033-d9b74ff6-a152-11e7-8d8b-624731eb407a.png)\r\n\r\nIt was not displayed only by changing ``zfar`` / ``znear``.\r\nI think that it was because I was using jgltf release 5. (It was not displayed even in jgltf release 4)"}}
{"actor":{"display_login":"cx20"}}