{"action":"created","issue":{"url":"https://api.github.com/repos/RackHD/RackHD/issues/554","repository_url":"https://api.github.com/repos/RackHD/RackHD","labels_url":"https://api.github.com/repos/RackHD/RackHD/issues/554/labels{/name}","comments_url":"https://api.github.com/repos/RackHD/RackHD/issues/554/comments","events_url":"https://api.github.com/repos/RackHD/RackHD/issues/554/events","html_url":"https://github.com/RackHD/RackHD/pull/554","id":198182029,"number":554,"title":" rac-3789 run_last.d symlink should be relative rather than absolute","user":{"login":"stuart-stanley","id":10092278,"avatar_url":"https://avatars.githubusercontent.com/u/10092278?v=3","gravatar_id":"","url":"https://api.github.com/users/stuart-stanley","html_url":"https://github.com/stuart-stanley","followers_url":"https://api.github.com/users/stuart-stanley/followers","following_url":"https://api.github.com/users/stuart-stanley/following{/other_user}","gists_url":"https://api.github.com/users/stuart-stanley/gists{/gist_id}","starred_url":"https://api.github.com/users/stuart-stanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuart-stanley/subscriptions","organizations_url":"https://api.github.com/users/stuart-stanley/orgs","repos_url":"https://api.github.com/users/stuart-stanley/repos","events_url":"https://api.github.com/users/stuart-stanley/events{/privacy}","received_events_url":"https://api.github.com/users/stuart-stanley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-12-30T18:52:11Z","updated_at":"2017-01-04T16:14:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RackHD/RackHD/pulls/554","html_url":"https://github.com/RackHD/RackHD/pull/554","diff_url":"https://github.com/RackHD/RackHD/pull/554.diff","patch_url":"https://github.com/RackHD/RackHD/pull/554.patch"},"body":"Primary changes:\r\n* changed abs symlink to be a link within the same dir\r\n* added logger_get_logging_dir to infra-logging (for test use)\r\n\r\nTDD changes:\r\n* fixed 'collect_only' check so it works when testing the plugins as well as when the plugin is used!\r\n* added test_infra_logging.py as location for tests of the infra-logging stuff.\r\n** added setup to ask infra-logging (via the logger_get_logging_dir from above) where to look\r\n** added canary test to make sure tests are being invoked\r\n** added test to check the run_last.d is there, is a symlink, and points to something valid\r\n** added fail-before-change, pass-after-change test to make sure the symlink doesn't start with a '/'. I.E., it's relative.\r\n* changed test_stream_base to use nose-created singleton for StreamMonitorPlugin instance.\r\n\r\nNearby-changes:\r\n* change both test and test/stream-monitor's mkenv.sh's to upgrade the venv pip. This speeds up generation of the virtual-env's signifigently and appears to finally get rid of errors based on trying to compile things.\r\n* removed wheel pinned to 0.24.0 from requirements.txt (this is taken care of automagically)\r\n* removed bogus __name__ == '__main__' code from infra_logging.py\r\n\r\n\r\n@RackHD/corecommitters @johren @hohene @gpaulos @larry-dean @jimturnquist @keedya @panpan0000 @changev @anhou \r\n\r\n(note: reviewer list built up from \"people I think _might_ be interested in this\" ;) )\r\nThis is NOT needed for phase-1, but should not hurt anything. It also paves the way to be able to test rac-3817 (getting captured data back to pre-pull-544 levels)"},"comment":{"url":"https://api.github.com/repos/RackHD/RackHD/issues/comments/270411264","html_url":"https://github.com/RackHD/RackHD/pull/554#issuecomment-270411264","issue_url":"https://api.github.com/repos/RackHD/RackHD/issues/554","id":270411264,"user":{"login":"hohene","id":14117170,"avatar_url":"https://avatars.githubusercontent.com/u/14117170?v=3","gravatar_id":"","url":"https://api.github.com/users/hohene","html_url":"https://github.com/hohene","followers_url":"https://api.github.com/users/hohene/followers","following_url":"https://api.github.com/users/hohene/following{/other_user}","gists_url":"https://api.github.com/users/hohene/gists{/gist_id}","starred_url":"https://api.github.com/users/hohene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hohene/subscriptions","organizations_url":"https://api.github.com/users/hohene/orgs","repos_url":"https://api.github.com/users/hohene/repos","events_url":"https://api.github.com/users/hohene/events{/privacy}","received_events_url":"https://api.github.com/users/hohene/received_events","type":"User","site_admin":false},"created_at":"2017-01-04T16:14:16Z","updated_at":"2017-01-04T16:14:16Z","body":"Ran test suite with latest updates.  +1"}}
{"actor":{"display_login":"hohene"}}