{"action":"opened","number":580,"pull_request":{"url":"https://api.github.com/repos/arsduo/koala/pulls/580","id":107096681,"html_url":"https://github.com/arsduo/koala/pull/580","diff_url":"https://github.com/arsduo/koala/pull/580.diff","patch_url":"https://github.com/arsduo/koala/pull/580.patch","issue_url":"https://api.github.com/repos/arsduo/koala/issues/580","number":580,"state":"open","locked":false,"title":"Batch API no longer inherits from API (take 2)","user":{"login":"arsduo","id":48325,"avatar_url":"https://avatars.githubusercontent.com/u/48325?v=3","gravatar_id":"","url":"https://api.github.com/users/arsduo","html_url":"https://github.com/arsduo","followers_url":"https://api.github.com/users/arsduo/followers","following_url":"https://api.github.com/users/arsduo/following{/other_user}","gists_url":"https://api.github.com/users/arsduo/gists{/gist_id}","starred_url":"https://api.github.com/users/arsduo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsduo/subscriptions","organizations_url":"https://api.github.com/users/arsduo/orgs","repos_url":"https://api.github.com/users/arsduo/repos","events_url":"https://api.github.com/users/arsduo/events{/privacy}","received_events_url":"https://api.github.com/users/arsduo/received_events","type":"User","site_admin":false},"body":"When I and others first wrote the GraphBatchAPI, I had it inherit from API. As with all inheritance, this resulted in the two classes being entangled with each other; changes to the private implementation logic in one impacted the other, making it harder to refactor for 3.0.\n\nAs it turns out, GraphBatchAPI doesn't actually need to depend on the original API. A few simple changes (moving graph_call to API so that GraphAPIMethods just contain convenience methods) allow us to dramatically simplify the batch API implementation and make this a compositional relationship rather than an inheritance-based one.\n\nThis PR also merges in #551 (addressing the merge conflicts). This is take 2 -- the first attempt to merge it squashed the commits, losing contributor information.","created_at":"2017-02-21T00:38:28Z","updated_at":"2017-02-21T00:38:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arsduo/koala/pulls/580/commits","review_comments_url":"https://api.github.com/repos/arsduo/koala/pulls/580/comments","review_comment_url":"https://api.github.com/repos/arsduo/koala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arsduo/koala/issues/580/comments","statuses_url":"https://api.github.com/repos/arsduo/koala/statuses/9bb75647402e114d824b9c1068e0a21f20b22304","head":{"label":"arsduo:acuppy-reduce-complexity-batch-api","ref":"acuppy-reduce-complexity-batch-api","sha":"9bb75647402e114d824b9c1068e0a21f20b22304","user":{"login":"arsduo","id":48325,"avatar_url":"https://avatars.githubusercontent.com/u/48325?v=3","gravatar_id":"","url":"https://api.github.com/users/arsduo","html_url":"https://github.com/arsduo","followers_url":"https://api.github.com/users/arsduo/followers","following_url":"https://api.github.com/users/arsduo/following{/other_user}","gists_url":"https://api.github.com/users/arsduo/gists{/gist_id}","starred_url":"https://api.github.com/users/arsduo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsduo/subscriptions","organizations_url":"https://api.github.com/users/arsduo/orgs","repos_url":"https://api.github.com/users/arsduo/repos","events_url":"https://api.github.com/users/arsduo/events{/privacy}","received_events_url":"https://api.github.com/users/arsduo/received_events","type":"User","site_admin":false},"repo":{"id":623018,"name":"koala","full_name":"arsduo/koala","owner":{"login":"arsduo","id":48325,"avatar_url":"https://avatars.githubusercontent.com/u/48325?v=3","gravatar_id":"","url":"https://api.github.com/users/arsduo","html_url":"https://github.com/arsduo","followers_url":"https://api.github.com/users/arsduo/followers","following_url":"https://api.github.com/users/arsduo/following{/other_user}","gists_url":"https://api.github.com/users/arsduo/gists{/gist_id}","starred_url":"https://api.github.com/users/arsduo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsduo/subscriptions","organizations_url":"https://api.github.com/users/arsduo/orgs","repos_url":"https://api.github.com/users/arsduo/repos","events_url":"https://api.github.com/users/arsduo/events{/privacy}","received_events_url":"https://api.github.com/users/arsduo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arsduo/koala","description":"A lightweight, flexible library for Facebook with support for OAuth authentication, the Graph and REST APIs, realtime updates, and test users.","fork":false,"url":"https://api.github.com/repos/arsduo/koala","forks_url":"https://api.github.com/repos/arsduo/koala/forks","keys_url":"https://api.github.com/repos/arsduo/koala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arsduo/koala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arsduo/koala/teams","hooks_url":"https://api.github.com/repos/arsduo/koala/hooks","issue_events_url":"https://api.github.com/repos/arsduo/koala/issues/events{/number}","events_url":"https://api.github.com/repos/arsduo/koala/events","assignees_url":"https://api.github.com/repos/arsduo/koala/assignees{/user}","branches_url":"https://api.github.com/repos/arsduo/koala/branches{/branch}","tags_url":"https://api.github.com/repos/arsduo/koala/tags","blobs_url":"https://api.github.com/repos/arsduo/koala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arsduo/koala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arsduo/koala/git/refs{/sha}","trees_url":"https://api.github.com/repos/arsduo/koala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arsduo/koala/statuses/{sha}","languages_url":"https://api.github.com/repos/arsduo/koala/languages","stargazers_url":"https://api.github.com/repos/arsduo/koala/stargazers","contributors_url":"https://api.github.com/repos/arsduo/koala/contributors","subscribers_url":"https://api.github.com/repos/arsduo/koala/subscribers","subscription_url":"https://api.github.com/repos/arsduo/koala/subscription","commits_url":"https://api.github.com/repos/arsduo/koala/commits{/sha}","git_commits_url":"https://api.github.com/repos/arsduo/koala/git/commits{/sha}","comments_url":"https://api.github.com/repos/arsduo/koala/comments{/number}","issue_comment_url":"https://api.github.com/repos/arsduo/koala/issues/comments{/number}","contents_url":"https://api.github.com/repos/arsduo/koala/contents/{+path}","compare_url":"https://api.github.com/repos/arsduo/koala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arsduo/koala/merges","archive_url":"https://api.github.com/repos/arsduo/koala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arsduo/koala/downloads","issues_url":"https://api.github.com/repos/arsduo/koala/issues{/number}","pulls_url":"https://api.github.com/repos/arsduo/koala/pulls{/number}","milestones_url":"https://api.github.com/repos/arsduo/koala/milestones{/number}","notifications_url":"https://api.github.com/repos/arsduo/koala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arsduo/koala/labels{/name}","releases_url":"https://api.github.com/repos/arsduo/koala/releases{/id}","deployments_url":"https://api.github.com/repos/arsduo/koala/deployments","created_at":"2010-04-22T07:14:55Z","updated_at":"2017-02-20T16:07:05Z","pushed_at":"2017-02-21T00:36:16Z","git_url":"git://github.com/arsduo/koala.git","ssh_url":"git@github.com:arsduo/koala.git","clone_url":"https://github.com/arsduo/koala.git","svn_url":"https://github.com/arsduo/koala","homepage":"http://developers.facebook.com/","size":1964,"stargazers_count":3146,"watchers_count":3146,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":425,"mirror_url":null,"open_issues_count":39,"forks":425,"open_issues":39,"watchers":3146,"default_branch":"master"}},"base":{"label":"arsduo:master","ref":"master","sha":"64437629b88c5a69d6898ade430611e00153f7b5","user":{"login":"arsduo","id":48325,"avatar_url":"https://avatars.githubusercontent.com/u/48325?v=3","gravatar_id":"","url":"https://api.github.com/users/arsduo","html_url":"https://github.com/arsduo","followers_url":"https://api.github.com/users/arsduo/followers","following_url":"https://api.github.com/users/arsduo/following{/other_user}","gists_url":"https://api.github.com/users/arsduo/gists{/gist_id}","starred_url":"https://api.github.com/users/arsduo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsduo/subscriptions","organizations_url":"https://api.github.com/users/arsduo/orgs","repos_url":"https://api.github.com/users/arsduo/repos","events_url":"https://api.github.com/users/arsduo/events{/privacy}","received_events_url":"https://api.github.com/users/arsduo/received_events","type":"User","site_admin":false},"repo":{"id":623018,"name":"koala","full_name":"arsduo/koala","owner":{"login":"arsduo","id":48325,"avatar_url":"https://avatars.githubusercontent.com/u/48325?v=3","gravatar_id":"","url":"https://api.github.com/users/arsduo","html_url":"https://github.com/arsduo","followers_url":"https://api.github.com/users/arsduo/followers","following_url":"https://api.github.com/users/arsduo/following{/other_user}","gists_url":"https://api.github.com/users/arsduo/gists{/gist_id}","starred_url":"https://api.github.com/users/arsduo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arsduo/subscriptions","organizations_url":"https://api.github.com/users/arsduo/orgs","repos_url":"https://api.github.com/users/arsduo/repos","events_url":"https://api.github.com/users/arsduo/events{/privacy}","received_events_url":"https://api.github.com/users/arsduo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arsduo/koala","description":"A lightweight, flexible library for Facebook with support for OAuth authentication, the Graph and REST APIs, realtime updates, and test users.","fork":false,"url":"https://api.github.com/repos/arsduo/koala","forks_url":"https://api.github.com/repos/arsduo/koala/forks","keys_url":"https://api.github.com/repos/arsduo/koala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arsduo/koala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arsduo/koala/teams","hooks_url":"https://api.github.com/repos/arsduo/koala/hooks","issue_events_url":"https://api.github.com/repos/arsduo/koala/issues/events{/number}","events_url":"https://api.github.com/repos/arsduo/koala/events","assignees_url":"https://api.github.com/repos/arsduo/koala/assignees{/user}","branches_url":"https://api.github.com/repos/arsduo/koala/branches{/branch}","tags_url":"https://api.github.com/repos/arsduo/koala/tags","blobs_url":"https://api.github.com/repos/arsduo/koala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arsduo/koala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arsduo/koala/git/refs{/sha}","trees_url":"https://api.github.com/repos/arsduo/koala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arsduo/koala/statuses/{sha}","languages_url":"https://api.github.com/repos/arsduo/koala/languages","stargazers_url":"https://api.github.com/repos/arsduo/koala/stargazers","contributors_url":"https://api.github.com/repos/arsduo/koala/contributors","subscribers_url":"https://api.github.com/repos/arsduo/koala/subscribers","subscription_url":"https://api.github.com/repos/arsduo/koala/subscription","commits_url":"https://api.github.com/repos/arsduo/koala/commits{/sha}","git_commits_url":"https://api.github.com/repos/arsduo/koala/git/commits{/sha}","comments_url":"https://api.github.com/repos/arsduo/koala/comments{/number}","issue_comment_url":"https://api.github.com/repos/arsduo/koala/issues/comments{/number}","contents_url":"https://api.github.com/repos/arsduo/koala/contents/{+path}","compare_url":"https://api.github.com/repos/arsduo/koala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arsduo/koala/merges","archive_url":"https://api.github.com/repos/arsduo/koala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arsduo/koala/downloads","issues_url":"https://api.github.com/repos/arsduo/koala/issues{/number}","pulls_url":"https://api.github.com/repos/arsduo/koala/pulls{/number}","milestones_url":"https://api.github.com/repos/arsduo/koala/milestones{/number}","notifications_url":"https://api.github.com/repos/arsduo/koala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arsduo/koala/labels{/name}","releases_url":"https://api.github.com/repos/arsduo/koala/releases{/id}","deployments_url":"https://api.github.com/repos/arsduo/koala/deployments","created_at":"2010-04-22T07:14:55Z","updated_at":"2017-02-20T16:07:05Z","pushed_at":"2017-02-21T00:36:16Z","git_url":"git://github.com/arsduo/koala.git","ssh_url":"git@github.com:arsduo/koala.git","clone_url":"https://github.com/arsduo/koala.git","svn_url":"https://github.com/arsduo/koala","homepage":"http://developers.facebook.com/","size":1964,"stargazers_count":3146,"watchers_count":3146,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":425,"mirror_url":null,"open_issues_count":39,"forks":425,"open_issues":39,"watchers":3146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arsduo/koala/pulls/580"},"html":{"href":"https://github.com/arsduo/koala/pull/580"},"issue":{"href":"https://api.github.com/repos/arsduo/koala/issues/580"},"comments":{"href":"https://api.github.com/repos/arsduo/koala/issues/580/comments"},"review_comments":{"href":"https://api.github.com/repos/arsduo/koala/pulls/580/comments"},"review_comment":{"href":"https://api.github.com/repos/arsduo/koala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arsduo/koala/pulls/580/commits"},"statuses":{"href":"https://api.github.com/repos/arsduo/koala/statuses/9bb75647402e114d824b9c1068e0a21f20b22304"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":10,"additions":154,"deletions":109,"changed_files":6}}
{"actor":{"display_login":"arsduo"}}