{"action":"created","comment":{"url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/comments/121281357","pull_request_review_id":43319523,"id":121281357,"diff_hunk":"@@ -124,8 +291,141 @@ namespace dynamicgraph\n \t  q_urdf[idx]=q_sot[m_urdf_to_sot[idx]];\t\n \treturn true;\n       }\n+      \n+      bool RobotUtil::\n+      velocity_urdf_to_sot(Eigen::ConstRefVector v_urdf, Eigen::RefVector v_sot)\n+      {\n+\tassert(q_urdf.size()==m_nbJoints+6);\n+\tassert(q_sot.size()==m_nbJoints+6);\n+\t\n+\tif (m_nbJoints==0)\n+\t  {\n+\t    SEND_MSG(\"velocity_urdf_to_sot should be called\", MSG_TYPE_ERROR);\n+\t    return false;\n+\t  }\n+\n+        v_sot.head<6>() = v_urdf.head<6>();\n+        joints_urdf_to_sot(v_urdf.tail(m_nbJoints), \n+\t\t\t   v_sot.tail(m_nbJoints));\n+\treturn true;\n+      }\n+\n+      bool RobotUtil::\n+      velocity_sot_to_urdf(Eigen::ConstRefVector v_sot, Eigen::RefVector v_urdf)\n+      {\n+\tassert(q_urdf.size()==m_nbJoints+6);","path":"src/common.cpp","position":316,"original_position":286,"commit_id":"a71123ad7891639edd73c49bc2373bead47eef7e","original_commit_id":"a71123ad7891639edd73c49bc2373bead47eef7e","user":{"login":"olivier-stasse","id":400341,"avatar_url":"https://avatars1.githubusercontent.com/u/400341?v=3","gravatar_id":"","url":"https://api.github.com/users/olivier-stasse","html_url":"https://github.com/olivier-stasse","followers_url":"https://api.github.com/users/olivier-stasse/followers","following_url":"https://api.github.com/users/olivier-stasse/following{/other_user}","gists_url":"https://api.github.com/users/olivier-stasse/gists{/gist_id}","starred_url":"https://api.github.com/users/olivier-stasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivier-stasse/subscriptions","organizations_url":"https://api.github.com/users/olivier-stasse/orgs","repos_url":"https://api.github.com/users/olivier-stasse/repos","events_url":"https://api.github.com/users/olivier-stasse/events{/privacy}","received_events_url":"https://api.github.com/users/olivier-stasse/received_events","type":"User","site_admin":false},"body":"same thing fixed in https://github.com/stack-of-tasks/sot-torque-control/pull/22\r\n","created_at":"2017-06-11T13:13:40Z","updated_at":"2017-06-11T13:13:40Z","html_url":"https://github.com/stack-of-tasks/sot-torque-control/pull/19#discussion_r121281357","pull_request_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/comments/121281357"},"html":{"href":"https://github.com/stack-of-tasks/sot-torque-control/pull/19#discussion_r121281357"},"pull_request":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/19","id":121796290,"html_url":"https://github.com/stack-of-tasks/sot-torque-control/pull/19","diff_url":"https://github.com/stack-of-tasks/sot-torque-control/pull/19.diff","patch_url":"https://github.com/stack-of-tasks/sot-torque-control/pull/19.patch","issue_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/issues/19","number":19,"state":"closed","locked":false,"title":"Sot v3 - Making the code independent from HRP-2","user":{"login":"olivier-stasse","id":400341,"avatar_url":"https://avatars1.githubusercontent.com/u/400341?v=3","gravatar_id":"","url":"https://api.github.com/users/olivier-stasse","html_url":"https://github.com/olivier-stasse","followers_url":"https://api.github.com/users/olivier-stasse/followers","following_url":"https://api.github.com/users/olivier-stasse/following{/other_user}","gists_url":"https://api.github.com/users/olivier-stasse/gists{/gist_id}","starred_url":"https://api.github.com/users/olivier-stasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivier-stasse/subscriptions","organizations_url":"https://api.github.com/users/olivier-stasse/orgs","repos_url":"https://api.github.com/users/olivier-stasse/repos","events_url":"https://api.github.com/users/olivier-stasse/events{/privacy}","received_events_url":"https://api.github.com/users/olivier-stasse/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-22T14:52:50Z","updated_at":"2017-06-11T13:13:40Z","closed_at":"2017-06-10T22:43:32Z","merged_at":null,"merge_commit_sha":"e62793cc10cd3ea490fd44fde08e03a7006e8780","assignee":null,"assignees":[],"requested_reviewers":[{"login":"proyan","id":12423606,"avatar_url":"https://avatars0.githubusercontent.com/u/12423606?v=3","gravatar_id":"","url":"https://api.github.com/users/proyan","html_url":"https://github.com/proyan","followers_url":"https://api.github.com/users/proyan/followers","following_url":"https://api.github.com/users/proyan/following{/other_user}","gists_url":"https://api.github.com/users/proyan/gists{/gist_id}","starred_url":"https://api.github.com/users/proyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/proyan/subscriptions","organizations_url":"https://api.github.com/users/proyan/orgs","repos_url":"https://api.github.com/users/proyan/repos","events_url":"https://api.github.com/users/proyan/events{/privacy}","received_events_url":"https://api.github.com/users/proyan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/19/commits","review_comments_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/19/comments","review_comment_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/issues/19/comments","statuses_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/statuses/a71123ad7891639edd73c49bc2373bead47eef7e","head":{"label":"olivier-stasse:sot-v3","ref":"sot-v3","sha":"a71123ad7891639edd73c49bc2373bead47eef7e","user":{"login":"olivier-stasse","id":400341,"avatar_url":"https://avatars1.githubusercontent.com/u/400341?v=3","gravatar_id":"","url":"https://api.github.com/users/olivier-stasse","html_url":"https://github.com/olivier-stasse","followers_url":"https://api.github.com/users/olivier-stasse/followers","following_url":"https://api.github.com/users/olivier-stasse/following{/other_user}","gists_url":"https://api.github.com/users/olivier-stasse/gists{/gist_id}","starred_url":"https://api.github.com/users/olivier-stasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivier-stasse/subscriptions","organizations_url":"https://api.github.com/users/olivier-stasse/orgs","repos_url":"https://api.github.com/users/olivier-stasse/repos","events_url":"https://api.github.com/users/olivier-stasse/events{/privacy}","received_events_url":"https://api.github.com/users/olivier-stasse/received_events","type":"User","site_admin":false},"repo":{"id":91174845,"name":"sot-torque-control","full_name":"olivier-stasse/sot-torque-control","owner":{"login":"olivier-stasse","id":400341,"avatar_url":"https://avatars1.githubusercontent.com/u/400341?v=3","gravatar_id":"","url":"https://api.github.com/users/olivier-stasse","html_url":"https://github.com/olivier-stasse","followers_url":"https://api.github.com/users/olivier-stasse/followers","following_url":"https://api.github.com/users/olivier-stasse/following{/other_user}","gists_url":"https://api.github.com/users/olivier-stasse/gists{/gist_id}","starred_url":"https://api.github.com/users/olivier-stasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivier-stasse/subscriptions","organizations_url":"https://api.github.com/users/olivier-stasse/orgs","repos_url":"https://api.github.com/users/olivier-stasse/repos","events_url":"https://api.github.com/users/olivier-stasse/events{/privacy}","received_events_url":"https://api.github.com/users/olivier-stasse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olivier-stasse/sot-torque-control","description":"Collection of dynamic-graph entities aimed at implementing torque control on different robots.","fork":true,"url":"https://api.github.com/repos/olivier-stasse/sot-torque-control","forks_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/forks","keys_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/teams","hooks_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/hooks","issue_events_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/issues/events{/number}","events_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/events","assignees_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/assignees{/user}","branches_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/branches{/branch}","tags_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/tags","blobs_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/statuses/{sha}","languages_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/languages","stargazers_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/stargazers","contributors_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/contributors","subscribers_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/subscribers","subscription_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/subscription","commits_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/contents/{+path}","compare_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/merges","archive_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/downloads","issues_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/issues{/number}","pulls_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/pulls{/number}","milestones_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/milestones{/number}","notifications_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/labels{/name}","releases_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/releases{/id}","deployments_url":"https://api.github.com/repos/olivier-stasse/sot-torque-control/deployments","created_at":"2017-05-13T13:03:59Z","updated_at":"2017-05-13T13:04:01Z","pushed_at":"2017-06-10T22:37:28Z","git_url":"git://github.com/olivier-stasse/sot-torque-control.git","ssh_url":"git@github.com:olivier-stasse/sot-torque-control.git","clone_url":"https://github.com/olivier-stasse/sot-torque-control.git","svn_url":"https://github.com/olivier-stasse/sot-torque-control","homepage":null,"size":420,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stack-of-tasks:sot-v3","ref":"sot-v3","sha":"cfab5cd8fd926cc3e1b9477bf6bea3ad3161aecb","user":{"login":"stack-of-tasks","id":3725101,"avatar_url":"https://avatars2.githubusercontent.com/u/3725101?v=3","gravatar_id":"","url":"https://api.github.com/users/stack-of-tasks","html_url":"https://github.com/stack-of-tasks","followers_url":"https://api.github.com/users/stack-of-tasks/followers","following_url":"https://api.github.com/users/stack-of-tasks/following{/other_user}","gists_url":"https://api.github.com/users/stack-of-tasks/gists{/gist_id}","starred_url":"https://api.github.com/users/stack-of-tasks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack-of-tasks/subscriptions","organizations_url":"https://api.github.com/users/stack-of-tasks/orgs","repos_url":"https://api.github.com/users/stack-of-tasks/repos","events_url":"https://api.github.com/users/stack-of-tasks/events{/privacy}","received_events_url":"https://api.github.com/users/stack-of-tasks/received_events","type":"Organization","site_admin":false},"repo":{"id":87088326,"name":"sot-torque-control","full_name":"stack-of-tasks/sot-torque-control","owner":{"login":"stack-of-tasks","id":3725101,"avatar_url":"https://avatars2.githubusercontent.com/u/3725101?v=3","gravatar_id":"","url":"https://api.github.com/users/stack-of-tasks","html_url":"https://github.com/stack-of-tasks","followers_url":"https://api.github.com/users/stack-of-tasks/followers","following_url":"https://api.github.com/users/stack-of-tasks/following{/other_user}","gists_url":"https://api.github.com/users/stack-of-tasks/gists{/gist_id}","starred_url":"https://api.github.com/users/stack-of-tasks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stack-of-tasks/subscriptions","organizations_url":"https://api.github.com/users/stack-of-tasks/orgs","repos_url":"https://api.github.com/users/stack-of-tasks/repos","events_url":"https://api.github.com/users/stack-of-tasks/events{/privacy}","received_events_url":"https://api.github.com/users/stack-of-tasks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stack-of-tasks/sot-torque-control","description":"Collection of dynamic-graph entities aimed at implementing torque control on different robots.","fork":false,"url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control","forks_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/forks","keys_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/teams","hooks_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/hooks","issue_events_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/issues/events{/number}","events_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/events","assignees_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/assignees{/user}","branches_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/branches{/branch}","tags_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/tags","blobs_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/statuses/{sha}","languages_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/languages","stargazers_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/stargazers","contributors_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/contributors","subscribers_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/subscribers","subscription_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/subscription","commits_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/contents/{+path}","compare_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/merges","archive_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/downloads","issues_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/issues{/number}","pulls_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls{/number}","milestones_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/milestones{/number}","notifications_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/labels{/name}","releases_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/releases{/id}","deployments_url":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/deployments","created_at":"2017-04-03T15:14:33Z","updated_at":"2017-04-03T15:15:00Z","pushed_at":"2017-06-10T22:41:40Z","git_url":"git://github.com/stack-of-tasks/sot-torque-control.git","ssh_url":"git@github.com:stack-of-tasks/sot-torque-control.git","clone_url":"https://github.com/stack-of-tasks/sot-torque-control.git","svn_url":"https://github.com/stack-of-tasks/sot-torque-control","homepage":null,"size":338,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":15,"forks":3,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/19"},"html":{"href":"https://github.com/stack-of-tasks/sot-torque-control/pull/19"},"issue":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/issues/19"},"comments":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/stack-of-tasks/sot-torque-control/statuses/a71123ad7891639edd73c49bc2373bead47eef7e"}}}}
{"actor":{"display_login":"olivier-stasse"}}