{"action":"created","issue":{"url":"https://api.github.com/repos/lbenet/2017-2_TSFisComputacional-1/issues/57","repository_url":"https://api.github.com/repos/lbenet/2017-2_TSFisComputacional-1","labels_url":"https://api.github.com/repos/lbenet/2017-2_TSFisComputacional-1/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/lbenet/2017-2_TSFisComputacional-1/issues/57/comments","events_url":"https://api.github.com/repos/lbenet/2017-2_TSFisComputacional-1/issues/57/events","html_url":"https://github.com/lbenet/2017-2_TSFisComputacional-1/pull/57","id":223243529,"number":57,"title":"Tarea 5","user":{"login":"H-Cote","id":25462726,"avatar_url":"https://avatars2.githubusercontent.com/u/25462726?v=3","gravatar_id":"","url":"https://api.github.com/users/H-Cote","html_url":"https://github.com/H-Cote","followers_url":"https://api.github.com/users/H-Cote/followers","following_url":"https://api.github.com/users/H-Cote/following{/other_user}","gists_url":"https://api.github.com/users/H-Cote/gists{/gist_id}","starred_url":"https://api.github.com/users/H-Cote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/H-Cote/subscriptions","organizations_url":"https://api.github.com/users/H-Cote/orgs","repos_url":"https://api.github.com/users/H-Cote/repos","events_url":"https://api.github.com/users/H-Cote/events{/privacy}","received_events_url":"https://api.github.com/users/H-Cote/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-04-21T00:53:46Z","updated_at":"2017-05-16T18:20:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lbenet/2017-2_TSFisComputacional-1/pulls/57","html_url":"https://github.com/lbenet/2017-2_TSFisComputacional-1/pull/57","diff_url":"https://github.com/lbenet/2017-2_TSFisComputacional-1/pull/57.diff","patch_url":"https://github.com/lbenet/2017-2_TSFisComputacional-1/pull/57.patch"},"body":"Inicio el ejercicio 1. "},"comment":{"url":"https://api.github.com/repos/lbenet/2017-2_TSFisComputacional-1/issues/comments/301870709","html_url":"https://github.com/lbenet/2017-2_TSFisComputacional-1/pull/57#issuecomment-301870709","issue_url":"https://api.github.com/repos/lbenet/2017-2_TSFisComputacional-1/issues/57","id":301870709,"user":{"login":"lbenet","id":5237744,"avatar_url":"https://avatars3.githubusercontent.com/u/5237744?v=3","gravatar_id":"","url":"https://api.github.com/users/lbenet","html_url":"https://github.com/lbenet","followers_url":"https://api.github.com/users/lbenet/followers","following_url":"https://api.github.com/users/lbenet/following{/other_user}","gists_url":"https://api.github.com/users/lbenet/gists{/gist_id}","starred_url":"https://api.github.com/users/lbenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbenet/subscriptions","organizations_url":"https://api.github.com/users/lbenet/orgs","repos_url":"https://api.github.com/users/lbenet/repos","events_url":"https://api.github.com/users/lbenet/events{/privacy}","received_events_url":"https://api.github.com/users/lbenet/received_events","type":"User","site_admin":false},"created_at":"2017-05-16T18:20:36Z","updated_at":"2017-05-16T18:20:36Z","body":"Algunos comentarios sobre la última versión:\r\n\r\n- Tu definición de `*` da como resultado un polinomio cuyo grado es la suma de los grados. Eso no está mal, pero *no* es práctico para la integración de Taylor. Esto mismo ocurre con el operador `^`. Insisto, no está mal, pero puede llegar a ser impráctico.\r\n\r\n- Hay algo chueco en la definición de `/`. En principio funciona, pero nota lo siguiente:\r\n```julia\r\njulia> include(\"taylor.jl\")\r\nTy\r\n\r\njulia> using Ty\r\n\r\njulia> uno = Taylor([1], 4)\r\nTy.Taylor{Int64}([1,0,0,0,0],4)\r\n\r\njulia> x = Taylor([0,1], 4)\r\nTy.Taylor{Int64}([0,1,0,0,0],4)\r\n\r\njulia> uno / (uno - x)\r\nTy.Taylor{Float64}([1.0,1.0,1.0,1.0,1.0,0.0],5)\r\n```\r\nLo que me inquieta del resultado anterior es que el último coeficiente (`0.0`) ya que es incorrecto; el resultado es una serie geométrica, cosa que está bien, excepto por el último coeficiente. \r\n\r\n- Un problema más sensible está en `==`. Por ejemplo, usando\r\n```julia\r\njulia> a = Taylor([0,1], 3)\r\nTy.Taylor{Int64}([0,1,0,0],3)\r\n\r\njulia> b = Taylor([0,1], 3)\r\nTy.Taylor{Int64}([0,1,0,0],3)\r\n```\r\nel resultado de `a == b` **no** es el que se espera. Lo mismo ocurre si defines `c = Taylor([0,1],5)`. Nota que todos estos polinomios son el mismo(!), excepto por la cola de ceros que no es importante.\r\n\r\n- La potencia `^` tiene otro problema, que se puede ver a continuación (además de la sutileza que te hice notar arriba):\r\n```julia\r\njulia> a = Taylor([1,1],2)\r\nTy.Taylor{Int64}([1,1,0],2)\r\n\r\njulia> a^3\r\nTy.Taylor{Float64}([1.0,3.0,3.0,0.0,0.0,0.0,0.0],6)\r\n```\r\nEl cuato coeficiente, es decir, el que corresponde al grado 3, **no** es correcto. Quizás esto se debe a que sólo querías calcular hasta grado 2 (que es el grado de `a`), pero rellenas de cero hasta el grado 6...\r\n"}}
{"actor":{"display_login":"lbenet"}}