{"action":"created","issue":{"url":"https://api.github.com/repos/openaps/oref0/issues/725","repository_url":"https://api.github.com/repos/openaps/oref0","labels_url":"https://api.github.com/repos/openaps/oref0/issues/725/labels{/name}","comments_url":"https://api.github.com/repos/openaps/oref0/issues/725/comments","events_url":"https://api.github.com/repos/openaps/oref0/issues/725/events","html_url":"https://github.com/openaps/oref0/pull/725","id":265974419,"number":725,"title":"fix broken safety checks with a single pump-loop type","user":{"login":"scottleibrand","id":6982790,"avatar_url":"https://avatars1.githubusercontent.com/u/6982790?v=4","gravatar_id":"","url":"https://api.github.com/users/scottleibrand","html_url":"https://github.com/scottleibrand","followers_url":"https://api.github.com/users/scottleibrand/followers","following_url":"https://api.github.com/users/scottleibrand/following{/other_user}","gists_url":"https://api.github.com/users/scottleibrand/gists{/gist_id}","starred_url":"https://api.github.com/users/scottleibrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottleibrand/subscriptions","organizations_url":"https://api.github.com/users/scottleibrand/orgs","repos_url":"https://api.github.com/users/scottleibrand/repos","events_url":"https://api.github.com/users/scottleibrand/events{/privacy}","received_events_url":"https://api.github.com/users/scottleibrand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openaps/oref0/milestones/3","html_url":"https://github.com/openaps/oref0/milestone/3","labels_url":"https://api.github.com/repos/openaps/oref0/milestones/3/labels","id":2838409,"number":3,"title":"0.6.0-dev2","description":null,"creator":{"login":"scottleibrand","id":6982790,"avatar_url":"https://avatars1.githubusercontent.com/u/6982790?v=4","gravatar_id":"","url":"https://api.github.com/users/scottleibrand","html_url":"https://github.com/scottleibrand","followers_url":"https://api.github.com/users/scottleibrand/followers","following_url":"https://api.github.com/users/scottleibrand/following{/other_user}","gists_url":"https://api.github.com/users/scottleibrand/gists{/gist_id}","starred_url":"https://api.github.com/users/scottleibrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottleibrand/subscriptions","organizations_url":"https://api.github.com/users/scottleibrand/orgs","repos_url":"https://api.github.com/users/scottleibrand/repos","events_url":"https://api.github.com/users/scottleibrand/events{/privacy}","received_events_url":"https://api.github.com/users/scottleibrand/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":7,"state":"open","created_at":"2017-10-15T20:57:09Z","updated_at":"2017-10-17T04:44:57Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-10-17T02:38:15Z","updated_at":"2017-10-17T13:04:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openaps/oref0/pulls/725","html_url":"https://github.com/openaps/oref0/pull/725","diff_url":"https://github.com/openaps/oref0/pull/725.diff","patch_url":"https://github.com/openaps/oref0/pull/725.patch"},"body":"Per https://github.com/openaps/oref0/issues/720 the recently added safety checks caused a regression for users of the non-SMB pump-loop.  To fix that, and make sure that future changes to oref0-pump-loop are more thoroughly tested, this deprecates the old pump-loop and consolidates both SMB and non-SMB use cases onto the one formerly known as smb_pump_loop.  The actual bolus commands are not executed if --microbolus is not passed, but everything else is done the same for both loop types.  This results in some extra status checks for non-SMB users, but that shouldn't hurt anything, and helps avoid problems like we saw with the safety checks making assumptions about the state of various data files that weren't met when the basal-only pump-loop did things in a different order."},"comment":{"url":"https://api.github.com/repos/openaps/oref0/issues/comments/337224567","html_url":"https://github.com/openaps/oref0/pull/725#issuecomment-337224567","issue_url":"https://api.github.com/repos/openaps/oref0/issues/725","id":337224567,"user":{"login":"bdr1177","id":8519000,"avatar_url":"https://avatars2.githubusercontent.com/u/8519000?v=4","gravatar_id":"","url":"https://api.github.com/users/bdr1177","html_url":"https://github.com/bdr1177","followers_url":"https://api.github.com/users/bdr1177/followers","following_url":"https://api.github.com/users/bdr1177/following{/other_user}","gists_url":"https://api.github.com/users/bdr1177/gists{/gist_id}","starred_url":"https://api.github.com/users/bdr1177/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdr1177/subscriptions","organizations_url":"https://api.github.com/users/bdr1177/orgs","repos_url":"https://api.github.com/users/bdr1177/repos","events_url":"https://api.github.com/users/bdr1177/events{/privacy}","received_events_url":"https://api.github.com/users/bdr1177/received_events","type":"User","site_admin":false},"created_at":"2017-10-17T13:04:13Z","updated_at":"2017-10-17T13:04:13Z","author_association":"NONE","body":"I'll plan to test this tonight."}}
{"actor":{"display_login":"bdr1177"}}