{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/32034","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/32034/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/32034/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/32034/events","html_url":"https://github.com/ansible/ansible/pull/32034","id":267626855,"number":32034,"title":"Documentation update about dashes in subnet names","user":{"login":"srvvr","id":32300982,"avatar_url":"https://avatars0.githubusercontent.com/u/32300982?v=4","gravatar_id":"","url":"https://api.github.com/users/srvvr","html_url":"https://github.com/srvvr","followers_url":"https://api.github.com/users/srvvr/followers","following_url":"https://api.github.com/users/srvvr/following{/other_user}","gists_url":"https://api.github.com/users/srvvr/gists{/gist_id}","starred_url":"https://api.github.com/users/srvvr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srvvr/subscriptions","organizations_url":"https://api.github.com/users/srvvr/orgs","repos_url":"https://api.github.com/users/srvvr/repos","events_url":"https://api.github.com/users/srvvr/events{/privacy}","received_events_url":"https://api.github.com/users/srvvr/received_events","type":"User","site_admin":false},"labels":[{"id":686214011,"url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.5","name":"affects_2.5","color":"ededed","default":false},{"id":379680333,"url":"https://api.github.com/repos/ansible/ansible/labels/aws","name":"aws","color":"c5def5","default":false},{"id":266246971,"url":"https://api.github.com/repos/ansible/ansible/labels/backport","name":"backport","color":"00ff00","default":false},{"id":61528803,"url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":513708749,"url":"https://api.github.com/repos/ansible/ansible/labels/committer_review","name":"committer_review","color":"ededed","default":false},{"id":48464763,"url":"https://api.github.com/repos/ansible/ansible/labels/docs_pull_request","name":"docs_pull_request","color":"0052cc","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":723150340,"url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"ededed","default":false},{"id":669975544,"url":"https://api.github.com/repos/ansible/ansible/labels/support:certified","name":"support:certified","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-10-23T11:05:27Z","updated_at":"2017-10-25T12:17:51Z","closed_at":"2017-10-25T12:17:51Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/32034","html_url":"https://github.com/ansible/ansible/pull/32034","diff_url":"https://github.com/ansible/ansible/pull/32034.diff","patch_url":"https://github.com/ansible/ansible/pull/32034.patch"},"body":"Subnets whose names contain dashes don't get associated to newly created or updated NACLs. Therefore I updated the documentation of this module.\r\n\r\n##### SUMMARY\r\nI ran into the behavior that subnets with dashes in their names don't get associated with NACLs. \r\nSince this seems to be a yaml-behavior that I wasn't aware of, I had to change my subnet names. In the module's documentation dashes are used. My pull request changes and corrects the module documentation accordingly.\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Docs Pull Request\r\n\r\n##### COMPONENT NAME\r\n~/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\n$ ansible --version\r\nansible 2.4.0.0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = [u'/Users/ABC/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible\r\n  executable location = /usr/local/bin/ansible\r\n  python version = 2.7.14 (default, Sep 25 2017, 09:53:22) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.37)]\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/339310875","html_url":"https://github.com/ansible/ansible/pull/32034#issuecomment-339310875","issue_url":"https://api.github.com/repos/ansible/ansible/issues/32034","id":339310875,"user":{"login":"willthames","id":391807,"avatar_url":"https://avatars2.githubusercontent.com/u/391807?v=4","gravatar_id":"","url":"https://api.github.com/users/willthames","html_url":"https://github.com/willthames","followers_url":"https://api.github.com/users/willthames/followers","following_url":"https://api.github.com/users/willthames/following{/other_user}","gists_url":"https://api.github.com/users/willthames/gists{/gist_id}","starred_url":"https://api.github.com/users/willthames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willthames/subscriptions","organizations_url":"https://api.github.com/users/willthames/orgs","repos_url":"https://api.github.com/users/willthames/repos","events_url":"https://api.github.com/users/willthames/events{/privacy}","received_events_url":"https://api.github.com/users/willthames/received_events","type":"User","site_admin":false},"created_at":"2017-10-25T12:17:51Z","updated_at":"2017-10-25T12:17:51Z","author_association":"CONTRIBUTOR","body":"https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/ec2_vpc_nacl.py#L523\r\n\r\nOh, it's because it starts with `subnet-`. It thinks it's a subnet ID. We can consider this a bug (it wouldn't be hard to do `subnet-[a-f0-9]{8}` or similar) but not a docs bug. Could you raise a new issue for this and I'll get it fixed."}}
{"actor":{"display_login":"willthames"}}