{"action":"created","comment":{"url":"https://api.github.com/repos/pravega/pravega/pulls/comments/149860848","pull_request_review_id":75323263,"id":149860848,"diff_hunk":"@@ -73,14 +75,15 @@ public RevisionedImpl applyTo(RevisionedImpl oldState, Revision newRevision) {\n         @Override\n         public RevisionedImpl create(String scopedSteamName, Revision revision) {\n             latch.awaitUninterruptibly();\n-            return new RevisionedImpl(scopedSteamName, new RevisionImpl(revision.asImpl().getSegment(), num, num));\n+            return new RevisionedImpl(scopedSteamName, new RevisionImpl(revision.asImpl().getSegment(), num, num),\n+                                      \"\" + num);","path":"client/src/test/java/io/pravega/client/state/impl/SynchronizerTest.java","position":29,"original_position":29,"commit_id":"94ee6a9e5c42b7f1871f6fd8dfcef16ed31c9503","original_commit_id":"94ee6a9e5c42b7f1871f6fd8dfcef16ed31c9503","user":{"login":"shrids","id":11114165,"avatar_url":"https://avatars1.githubusercontent.com/u/11114165?v=4","gravatar_id":"","url":"https://api.github.com/users/shrids","html_url":"https://github.com/shrids","followers_url":"https://api.github.com/users/shrids/followers","following_url":"https://api.github.com/users/shrids/following{/other_user}","gists_url":"https://api.github.com/users/shrids/gists{/gist_id}","starred_url":"https://api.github.com/users/shrids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrids/subscriptions","organizations_url":"https://api.github.com/users/shrids/orgs","repos_url":"https://api.github.com/users/shrids/repos","events_url":"https://api.github.com/users/shrids/events{/privacy}","received_events_url":"https://api.github.com/users/shrids/received_events","type":"User","site_admin":false},"body":"we can use String.valueOf(num)  for this pattern","created_at":"2017-11-09T03:45:16Z","updated_at":"2017-11-09T03:49:31Z","html_url":"https://github.com/pravega/pravega/pull/2048#discussion_r149860848","pull_request_url":"https://api.github.com/repos/pravega/pravega/pulls/2048","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments/149860848"},"html":{"href":"https://github.com/pravega/pravega/pull/2048#discussion_r149860848"},"pull_request":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2048"}}},"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/2048","id":150653969,"html_url":"https://github.com/pravega/pravega/pull/2048","diff_url":"https://github.com/pravega/pravega/pull/2048.diff","patch_url":"https://github.com/pravega/pravega/pull/2048.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/2048","number":2048,"state":"open","locked":false,"title":"Issue 2043: Add return value to StateSynchronizer.update()","user":{"login":"tkaitchuck","id":4756752,"avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},"body":"**Change log description**\r\nAdds a user-supplied return value to update on on StateSynchronizer.\r\n\r\n**Purpose of the change**\r\nFixes #2043 . It was too easy to make the mistake of attempting to use the wrong value when update() invoked the update generation function more than once. This adds an API to support this feature, which should make it harder to make this mistake.\r\n\r\n**What the code does**\r\nAllows the update generator that is passed to update() to have a user-defined return value that is passed back to the caller of update.\r\n\r\n**How to verify it**\r\nAll existing tests should pass, new tests have been added to cover the new feature.","created_at":"2017-11-04T00:43:23Z","updated_at":"2017-11-09T03:49:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e452200b8773a36445bcdb35363f51c8dac9460","assignee":{"login":"fpj","id":572920,"avatar_url":"https://avatars3.githubusercontent.com/u/572920?v=4","gravatar_id":"","url":"https://api.github.com/users/fpj","html_url":"https://github.com/fpj","followers_url":"https://api.github.com/users/fpj/followers","following_url":"https://api.github.com/users/fpj/following{/other_user}","gists_url":"https://api.github.com/users/fpj/gists{/gist_id}","starred_url":"https://api.github.com/users/fpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpj/subscriptions","organizations_url":"https://api.github.com/users/fpj/orgs","repos_url":"https://api.github.com/users/fpj/repos","events_url":"https://api.github.com/users/fpj/events{/privacy}","received_events_url":"https://api.github.com/users/fpj/received_events","type":"User","site_admin":false},"assignees":[{"login":"fpj","id":572920,"avatar_url":"https://avatars3.githubusercontent.com/u/572920?v=4","gravatar_id":"","url":"https://api.github.com/users/fpj","html_url":"https://github.com/fpj","followers_url":"https://api.github.com/users/fpj/followers","following_url":"https://api.github.com/users/fpj/following{/other_user}","gists_url":"https://api.github.com/users/fpj/gists{/gist_id}","starred_url":"https://api.github.com/users/fpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpj/subscriptions","organizations_url":"https://api.github.com/users/fpj/orgs","repos_url":"https://api.github.com/users/fpj/repos","events_url":"https://api.github.com/users/fpj/events{/privacy}","received_events_url":"https://api.github.com/users/fpj/received_events","type":"User","site_admin":false},{"login":"shrids","id":11114165,"avatar_url":"https://avatars1.githubusercontent.com/u/11114165?v=4","gravatar_id":"","url":"https://api.github.com/users/shrids","html_url":"https://github.com/shrids","followers_url":"https://api.github.com/users/shrids/followers","following_url":"https://api.github.com/users/shrids/following{/other_user}","gists_url":"https://api.github.com/users/shrids/gists{/gist_id}","starred_url":"https://api.github.com/users/shrids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrids/subscriptions","organizations_url":"https://api.github.com/users/shrids/orgs","repos_url":"https://api.github.com/users/shrids/repos","events_url":"https://api.github.com/users/shrids/events{/privacy}","received_events_url":"https://api.github.com/users/shrids/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fpj","id":572920,"avatar_url":"https://avatars3.githubusercontent.com/u/572920?v=4","gravatar_id":"","url":"https://api.github.com/users/fpj","html_url":"https://github.com/fpj","followers_url":"https://api.github.com/users/fpj/followers","following_url":"https://api.github.com/users/fpj/following{/other_user}","gists_url":"https://api.github.com/users/fpj/gists{/gist_id}","starred_url":"https://api.github.com/users/fpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpj/subscriptions","organizations_url":"https://api.github.com/users/fpj/orgs","repos_url":"https://api.github.com/users/fpj/repos","events_url":"https://api.github.com/users/fpj/events{/privacy}","received_events_url":"https://api.github.com/users/fpj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/2048/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/2048/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/2048/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/94ee6a9e5c42b7f1871f6fd8dfcef16ed31c9503","head":{"label":"tkaitchuck:bugfix-updateResult","ref":"bugfix-updateResult","sha":"94ee6a9e5c42b7f1871f6fd8dfcef16ed31c9503","user":{"login":"tkaitchuck","id":4756752,"avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},"repo":{"id":90919636,"name":"pravega-1","full_name":"tkaitchuck/pravega-1","owner":{"login":"tkaitchuck","id":4756752,"avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkaitchuck/pravega-1","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/tkaitchuck/pravega-1","forks_url":"https://api.github.com/repos/tkaitchuck/pravega-1/forks","keys_url":"https://api.github.com/repos/tkaitchuck/pravega-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkaitchuck/pravega-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkaitchuck/pravega-1/teams","hooks_url":"https://api.github.com/repos/tkaitchuck/pravega-1/hooks","issue_events_url":"https://api.github.com/repos/tkaitchuck/pravega-1/issues/events{/number}","events_url":"https://api.github.com/repos/tkaitchuck/pravega-1/events","assignees_url":"https://api.github.com/repos/tkaitchuck/pravega-1/assignees{/user}","branches_url":"https://api.github.com/repos/tkaitchuck/pravega-1/branches{/branch}","tags_url":"https://api.github.com/repos/tkaitchuck/pravega-1/tags","blobs_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkaitchuck/pravega-1/statuses/{sha}","languages_url":"https://api.github.com/repos/tkaitchuck/pravega-1/languages","stargazers_url":"https://api.github.com/repos/tkaitchuck/pravega-1/stargazers","contributors_url":"https://api.github.com/repos/tkaitchuck/pravega-1/contributors","subscribers_url":"https://api.github.com/repos/tkaitchuck/pravega-1/subscribers","subscription_url":"https://api.github.com/repos/tkaitchuck/pravega-1/subscription","commits_url":"https://api.github.com/repos/tkaitchuck/pravega-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkaitchuck/pravega-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkaitchuck/pravega-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkaitchuck/pravega-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkaitchuck/pravega-1/contents/{+path}","compare_url":"https://api.github.com/repos/tkaitchuck/pravega-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkaitchuck/pravega-1/merges","archive_url":"https://api.github.com/repos/tkaitchuck/pravega-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkaitchuck/pravega-1/downloads","issues_url":"https://api.github.com/repos/tkaitchuck/pravega-1/issues{/number}","pulls_url":"https://api.github.com/repos/tkaitchuck/pravega-1/pulls{/number}","milestones_url":"https://api.github.com/repos/tkaitchuck/pravega-1/milestones{/number}","notifications_url":"https://api.github.com/repos/tkaitchuck/pravega-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkaitchuck/pravega-1/labels{/name}","releases_url":"https://api.github.com/repos/tkaitchuck/pravega-1/releases{/id}","deployments_url":"https://api.github.com/repos/tkaitchuck/pravega-1/deployments","created_at":"2017-05-11T00:19:21Z","updated_at":"2017-05-11T00:19:25Z","pushed_at":"2017-11-04T00:53:40Z","git_url":"git://github.com/tkaitchuck/pravega-1.git","ssh_url":"git@github.com:tkaitchuck/pravega-1.git","clone_url":"https://github.com/tkaitchuck/pravega-1.git","svn_url":"https://github.com/tkaitchuck/pravega-1","homepage":"http://pravega.io","size":20853,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"6ac7f3fbfa6442c2fa834e602347dcab62affdfb","user":{"login":"pravega","id":25698199,"avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"name":"pravega","full_name":"pravega/pravega","owner":{"login":"pravega","id":25698199,"avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2017-11-06T04:05:33Z","pushed_at":"2017-11-09T03:35:31Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":21398,"stargazers_count":131,"watchers_count":131,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":300,"forks":48,"open_issues":300,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2048"},"html":{"href":"https://github.com/pravega/pravega/pull/2048"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/2048"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/2048/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2048/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2048/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/94ee6a9e5c42b7f1871f6fd8dfcef16ed31c9503"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"shrids"}}