{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls/1","id":109293560,"html_url":"https://github.com/adeptoas/sweet-modal-vue/pull/1","diff_url":"https://github.com/adeptoas/sweet-modal-vue/pull/1.diff","patch_url":"https://github.com/adeptoas/sweet-modal-vue/pull/1.patch","issue_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/issues/1","number":1,"state":"closed","locked":false,"title":"Moved vue to dev-dependencies and added it as a peerDependency.","user":{"login":"jbjorge","id":1926428,"avatar_url":"https://avatars2.githubusercontent.com/u/1926428?v=3","gravatar_id":"","url":"https://api.github.com/users/jbjorge","html_url":"https://github.com/jbjorge","followers_url":"https://api.github.com/users/jbjorge/followers","following_url":"https://api.github.com/users/jbjorge/following{/other_user}","gists_url":"https://api.github.com/users/jbjorge/gists{/gist_id}","starred_url":"https://api.github.com/users/jbjorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbjorge/subscriptions","organizations_url":"https://api.github.com/users/jbjorge/orgs","repos_url":"https://api.github.com/users/jbjorge/repos","events_url":"https://api.github.com/users/jbjorge/events{/privacy}","received_events_url":"https://api.github.com/users/jbjorge/received_events","type":"User","site_admin":false},"body":"Hi and thanks for a nice vue-module! :)\r\n\r\nIt currently installs a copy of vue when fetching it from npm, which will result in two versions of vue bundled with whatever code that uses this. The better approach is to have vue as a devDependency for local development and as a peerDependency for installs from npm.\r\nHaven't set up peerDependencies before, so I hope i did it correctly.","created_at":"2017-03-06T16:19:56Z","updated_at":"2017-03-08T15:32:08Z","closed_at":"2017-03-08T15:32:08Z","merged_at":"2017-03-08T15:32:08Z","merge_commit_sha":"a029f653ec88e68d810bb13dd9941a4997b8967d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls/1/commits","review_comments_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls/1/comments","review_comment_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/issues/1/comments","statuses_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/statuses/855acf7fbba1e92f21398c4757ce9568a797a516","head":{"label":"jbjorge:vue-as-peerdep","ref":"vue-as-peerdep","sha":"855acf7fbba1e92f21398c4757ce9568a797a516","user":{"login":"jbjorge","id":1926428,"avatar_url":"https://avatars2.githubusercontent.com/u/1926428?v=3","gravatar_id":"","url":"https://api.github.com/users/jbjorge","html_url":"https://github.com/jbjorge","followers_url":"https://api.github.com/users/jbjorge/followers","following_url":"https://api.github.com/users/jbjorge/following{/other_user}","gists_url":"https://api.github.com/users/jbjorge/gists{/gist_id}","starred_url":"https://api.github.com/users/jbjorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbjorge/subscriptions","organizations_url":"https://api.github.com/users/jbjorge/orgs","repos_url":"https://api.github.com/users/jbjorge/repos","events_url":"https://api.github.com/users/jbjorge/events{/privacy}","received_events_url":"https://api.github.com/users/jbjorge/received_events","type":"User","site_admin":false},"repo":{"id":84092972,"name":"sweet-modal-vue","full_name":"jbjorge/sweet-modal-vue","owner":{"login":"jbjorge","id":1926428,"avatar_url":"https://avatars2.githubusercontent.com/u/1926428?v=3","gravatar_id":"","url":"https://api.github.com/users/jbjorge","html_url":"https://github.com/jbjorge","followers_url":"https://api.github.com/users/jbjorge/followers","following_url":"https://api.github.com/users/jbjorge/following{/other_user}","gists_url":"https://api.github.com/users/jbjorge/gists{/gist_id}","starred_url":"https://api.github.com/users/jbjorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbjorge/subscriptions","organizations_url":"https://api.github.com/users/jbjorge/orgs","repos_url":"https://api.github.com/users/jbjorge/repos","events_url":"https://api.github.com/users/jbjorge/events{/privacy}","received_events_url":"https://api.github.com/users/jbjorge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbjorge/sweet-modal-vue","description":"The sweetest library to happen to modals.","fork":true,"url":"https://api.github.com/repos/jbjorge/sweet-modal-vue","forks_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/forks","keys_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/teams","hooks_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/hooks","issue_events_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/issues/events{/number}","events_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/events","assignees_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/assignees{/user}","branches_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/branches{/branch}","tags_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/tags","blobs_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/languages","stargazers_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/stargazers","contributors_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/contributors","subscribers_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/subscribers","subscription_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/subscription","commits_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/contents/{+path}","compare_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/merges","archive_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/downloads","issues_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/issues{/number}","pulls_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/labels{/name}","releases_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/releases{/id}","deployments_url":"https://api.github.com/repos/jbjorge/sweet-modal-vue/deployments","created_at":"2017-03-06T16:03:42Z","updated_at":"2017-03-06T16:03:44Z","pushed_at":"2017-03-06T16:15:41Z","git_url":"git://github.com/jbjorge/sweet-modal-vue.git","ssh_url":"git@github.com:jbjorge/sweet-modal-vue.git","clone_url":"https://github.com/jbjorge/sweet-modal-vue.git","svn_url":"https://github.com/jbjorge/sweet-modal-vue","homepage":null,"size":899,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adeptoas:master","ref":"master","sha":"7af969a3d9973425ee541d6e527deeabd801556a","user":{"login":"adeptoas","id":11876893,"avatar_url":"https://avatars1.githubusercontent.com/u/11876893?v=3","gravatar_id":"","url":"https://api.github.com/users/adeptoas","html_url":"https://github.com/adeptoas","followers_url":"https://api.github.com/users/adeptoas/followers","following_url":"https://api.github.com/users/adeptoas/following{/other_user}","gists_url":"https://api.github.com/users/adeptoas/gists{/gist_id}","starred_url":"https://api.github.com/users/adeptoas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeptoas/subscriptions","organizations_url":"https://api.github.com/users/adeptoas/orgs","repos_url":"https://api.github.com/users/adeptoas/repos","events_url":"https://api.github.com/users/adeptoas/events{/privacy}","received_events_url":"https://api.github.com/users/adeptoas/received_events","type":"Organization","site_admin":false},"repo":{"id":83697037,"name":"sweet-modal-vue","full_name":"adeptoas/sweet-modal-vue","owner":{"login":"adeptoas","id":11876893,"avatar_url":"https://avatars1.githubusercontent.com/u/11876893?v=3","gravatar_id":"","url":"https://api.github.com/users/adeptoas","html_url":"https://github.com/adeptoas","followers_url":"https://api.github.com/users/adeptoas/followers","following_url":"https://api.github.com/users/adeptoas/following{/other_user}","gists_url":"https://api.github.com/users/adeptoas/gists{/gist_id}","starred_url":"https://api.github.com/users/adeptoas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adeptoas/subscriptions","organizations_url":"https://api.github.com/users/adeptoas/orgs","repos_url":"https://api.github.com/users/adeptoas/repos","events_url":"https://api.github.com/users/adeptoas/events{/privacy}","received_events_url":"https://api.github.com/users/adeptoas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adeptoas/sweet-modal-vue","description":"The sweetest library to happen to modals.","fork":false,"url":"https://api.github.com/repos/adeptoas/sweet-modal-vue","forks_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/forks","keys_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/teams","hooks_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/hooks","issue_events_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/issues/events{/number}","events_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/events","assignees_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/assignees{/user}","branches_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/branches{/branch}","tags_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/tags","blobs_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/languages","stargazers_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/stargazers","contributors_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/contributors","subscribers_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/subscribers","subscription_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/subscription","commits_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/contents/{+path}","compare_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/merges","archive_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/downloads","issues_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/issues{/number}","pulls_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/labels{/name}","releases_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/releases{/id}","deployments_url":"https://api.github.com/repos/adeptoas/sweet-modal-vue/deployments","created_at":"2017-03-02T16:02:35Z","updated_at":"2017-03-04T07:07:06Z","pushed_at":"2017-03-08T15:32:08Z","git_url":"git://github.com/adeptoas/sweet-modal-vue.git","ssh_url":"git@github.com:adeptoas/sweet-modal-vue.git","clone_url":"https://github.com/adeptoas/sweet-modal-vue.git","svn_url":"https://github.com/adeptoas/sweet-modal-vue","homepage":null,"size":899,"stargazers_count":3,"watchers_count":3,"language":"Vue","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls/1"},"html":{"href":"https://github.com/adeptoas/sweet-modal-vue/pull/1"},"issue":{"href":"https://api.github.com/repos/adeptoas/sweet-modal-vue/issues/1"},"comments":{"href":"https://api.github.com/repos/adeptoas/sweet-modal-vue/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adeptoas/sweet-modal-vue/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/adeptoas/sweet-modal-vue/statuses/855acf7fbba1e92f21398c4757ce9568a797a516"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bluefirex","id":357398,"avatar_url":"https://avatars1.githubusercontent.com/u/357398?v=3","gravatar_id":"","url":"https://api.github.com/users/bluefirex","html_url":"https://github.com/bluefirex","followers_url":"https://api.github.com/users/bluefirex/followers","following_url":"https://api.github.com/users/bluefirex/following{/other_user}","gists_url":"https://api.github.com/users/bluefirex/gists{/gist_id}","starred_url":"https://api.github.com/users/bluefirex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluefirex/subscriptions","organizations_url":"https://api.github.com/users/bluefirex/orgs","repos_url":"https://api.github.com/users/bluefirex/repos","events_url":"https://api.github.com/users/bluefirex/events{/privacy}","received_events_url":"https://api.github.com/users/bluefirex/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"bluefirex"}}