{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/101903826","pull_request_review_id":22647542,"id":101903826,"diff_hunk":"@@ -580,12 +582,30 @@ public SearchResults apply(MetadataDataset input) throws Exception {\n   }\n \n   @Override\n-  public void rebuildIndexes(MetadataScope scope) throws DatasetManagementException, IOException {\n+  public void rebuildIndexes(MetadataScope scope,\n+                             RetryStrategy retryStrategy) {\n     byte[] row = null;\n-    while ((row = rebuildIndex(row, scope)) != null) {\n+    while ((row = rebuildIndexesWithRetries(scope, row, retryStrategy)) != null) {\n       LOG.debug(\"Completed a batch for rebuilding {} metadata indexes.\", scope);\n     }\n+  }\n \n+  private byte[] rebuildIndexesWithRetries(final MetadataScope scope,","path":"cdap-data-fabric/src/main/java/co/cask/cdap/data2/metadata/store/DefaultMetadataStore.java","position":null,"original_position":23,"commit_id":"0cf3f2f7855930a9d6845f6a3b2c43ee3452b007","original_commit_id":"843bbe8f235f0d25e02f5c60debda02986b472d2","user":{"login":"anew","id":483004,"avatar_url":"https://avatars.githubusercontent.com/u/483004?v=3","gravatar_id":"","url":"https://api.github.com/users/anew","html_url":"https://github.com/anew","followers_url":"https://api.github.com/users/anew/followers","following_url":"https://api.github.com/users/anew/following{/other_user}","gists_url":"https://api.github.com/users/anew/gists{/gist_id}","starred_url":"https://api.github.com/users/anew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anew/subscriptions","organizations_url":"https://api.github.com/users/anew/orgs","repos_url":"https://api.github.com/users/anew/repos","events_url":"https://api.github.com/users/anew/events{/privacy}","received_events_url":"https://api.github.com/users/anew/received_events","type":"User","site_admin":false},"body":"Ok, I am not sure how the old method was throwing IOException and DatasetManagementException, and why that is now not possible any more, simply because you now retry inside the loop. But not a biggie.  ","created_at":"2017-02-18T22:15:51Z","updated_at":"2017-02-18T22:16:15Z","html_url":"https://github.com/caskdata/cdap/pull/8009#discussion_r101903826","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/8009","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/101903826"},"html":{"href":"https://github.com/caskdata/cdap/pull/8009#discussion_r101903826"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/8009"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/8009","id":106550279,"html_url":"https://github.com/caskdata/cdap/pull/8009","diff_url":"https://github.com/caskdata/cdap/pull/8009.diff","patch_url":"https://github.com/caskdata/cdap/pull/8009.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/8009","number":8009,"state":"open","locked":false,"title":"MetadataService to upgrade Metadata instead of the UpgrdeTool ","user":{"login":"deepakwadhwani","id":22896289,"avatar_url":"https://avatars.githubusercontent.com/u/22896289?v=3","gravatar_id":"","url":"https://api.github.com/users/deepakwadhwani","html_url":"https://github.com/deepakwadhwani","followers_url":"https://api.github.com/users/deepakwadhwani/followers","following_url":"https://api.github.com/users/deepakwadhwani/following{/other_user}","gists_url":"https://api.github.com/users/deepakwadhwani/gists{/gist_id}","starred_url":"https://api.github.com/users/deepakwadhwani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepakwadhwani/subscriptions","organizations_url":"https://api.github.com/users/deepakwadhwani/orgs","repos_url":"https://api.github.com/users/deepakwadhwani/repos","events_url":"https://api.github.com/users/deepakwadhwani/events{/privacy}","received_events_url":"https://api.github.com/users/deepakwadhwani/received_events","type":"User","site_admin":false},"body":"CDAP-7835: Upgrade MetadataDataset without running upgrade tool\r\nClean DUT: http://builds.cask.co/browse/CDAP-DUT5460-1\r\nRUT running: http://builds.cask.co/browse/CDAP-RUT598-1","created_at":"2017-02-16T15:35:35Z","updated_at":"2017-02-18T22:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d23a93a3d442a82b94f7d54d6dede69e7a90dda","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/8009/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/8009/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/8009/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/0cf3f2f7855930a9d6845f6a3b2c43ee3452b007","head":{"label":"caskdata:bugfix/metadata","ref":"bugfix/metadata","sha":"0cf3f2f7855930a9d6845f6a3b2c43ee3452b007","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2017-02-17T21:32:40Z","pushed_at":"2017-02-18T22:10:48Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"","size":484537,"stargazers_count":158,"watchers_count":158,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":35,"forks":75,"open_issues":35,"watchers":158,"default_branch":"release/4.1"}},"base":{"label":"caskdata:release/4.1","ref":"release/4.1","sha":"2c41c6b2366eb01db53a7de977b8db5d14e41920","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2017-02-17T21:32:40Z","pushed_at":"2017-02-18T22:10:48Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"","size":484537,"stargazers_count":158,"watchers_count":158,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":35,"forks":75,"open_issues":35,"watchers":158,"default_branch":"release/4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/8009"},"html":{"href":"https://github.com/caskdata/cdap/pull/8009"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/8009"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/8009/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/8009/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/8009/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/0cf3f2f7855930a9d6845f6a3b2c43ee3452b007"}}}}
{"actor":{"display_login":"anew"}}