{"action":"created","comment":{"url":"https://api.github.com/repos/prooph/event-store/pulls/comments/94391775","pull_request_review_id":14917444,"id":94391775,"diff_hunk":"@@ -0,0 +1,327 @@\n+<?php\n+/**\n+ * This file is part of the prooph/service-bus.\n+ * (c) 2014-2016 prooph software GmbH <contact@prooph.de>\n+ * (c) 2015-2016 Sascha-Oliver Prolic <saschaprolic@googlemail.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace ProophTest\\EventStore\\Aggregate;\n+\n+use PHPUnit_Framework_TestCase as TestCase;\n+use Prooph\\EventStore\\Aggregate\\AggregateTranslatorConfiguration;\n+use Prooph\\EventStore\\Aggregate\\AggregateType;\n+use Prooph\\EventStore\\Aggregate\\AggregateTypeProvider;\n+use ProophTest\\EventStore\\Mock\\Post;\n+use ProophTest\\EventStore\\Mock\\User;\n+\n+/**\n+ * Class AggregateTypeTest\n+ *\n+ * @package ProophTest\\EventStore\\Aggregate\n+ */\n+class AggregateTranslatorConfigurationTest extends TestCase\n+{\n+    /**\n+     * @var AggregateTranslatorConfiguration\n+     */\n+    private $config;\n+\n+    protected function setUp()\n+    {\n+        parent::setUp();\n+        $this->config = AggregateTranslatorConfiguration::createWithDefaults();\n+    }\n+\n+    /**\n+     * @test\n+     * @skipped\n+     * @expectedException \\InvalidArgumentException","path":"tests/Aggregate/AggregateTranslatorConfigurationTest.php","position":41,"original_position":41,"commit_id":"90a1ec62b19ee2f11376616c84fd1823cf7b9df3","original_commit_id":"90a1ec62b19ee2f11376616c84fd1823cf7b9df3","user":{"login":"prolic","id":394428,"avatar_url":"https://avatars.githubusercontent.com/u/394428?v=3","gravatar_id":"","url":"https://api.github.com/users/prolic","html_url":"https://github.com/prolic","followers_url":"https://api.github.com/users/prolic/followers","following_url":"https://api.github.com/users/prolic/following{/other_user}","gists_url":"https://api.github.com/users/prolic/gists{/gist_id}","starred_url":"https://api.github.com/users/prolic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prolic/subscriptions","organizations_url":"https://api.github.com/users/prolic/orgs","repos_url":"https://api.github.com/users/prolic/repos","events_url":"https://api.github.com/users/prolic/events{/privacy}","received_events_url":"https://api.github.com/users/prolic/received_events","type":"User","site_admin":false},"body":"ah this is for master branch, not develop, sorry, my bad.\r\n\r\nwould you consider another PR for develop?","created_at":"2017-01-03T11:36:33Z","updated_at":"2017-01-03T11:36:33Z","html_url":"https://github.com/prooph/event-store/pull/238#discussion_r94391775","pull_request_url":"https://api.github.com/repos/prooph/event-store/pulls/238","_links":{"self":{"href":"https://api.github.com/repos/prooph/event-store/pulls/comments/94391775"},"html":{"href":"https://github.com/prooph/event-store/pull/238#discussion_r94391775"},"pull_request":{"href":"https://api.github.com/repos/prooph/event-store/pulls/238"}}},"pull_request":{"url":"https://api.github.com/repos/prooph/event-store/pulls/238","id":99840917,"html_url":"https://github.com/prooph/event-store/pull/238","diff_url":"https://github.com/prooph/event-store/pull/238.diff","patch_url":"https://github.com/prooph/event-store/pull/238.patch","issue_url":"https://api.github.com/repos/prooph/event-store/issues/238","number":238,"state":"open","locked":false,"title":"outsourced configuration from ConfigurableAggregateTranslator","user":{"login":"dropdevcoding","id":3219267,"avatar_url":"https://avatars.githubusercontent.com/u/3219267?v=3","gravatar_id":"","url":"https://api.github.com/users/dropdevcoding","html_url":"https://github.com/dropdevcoding","followers_url":"https://api.github.com/users/dropdevcoding/followers","following_url":"https://api.github.com/users/dropdevcoding/following{/other_user}","gists_url":"https://api.github.com/users/dropdevcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/dropdevcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropdevcoding/subscriptions","organizations_url":"https://api.github.com/users/dropdevcoding/orgs","repos_url":"https://api.github.com/users/dropdevcoding/repos","events_url":"https://api.github.com/users/dropdevcoding/events{/privacy}","received_events_url":"https://api.github.com/users/dropdevcoding/received_events","type":"User","site_admin":false},"body":"some more tests and docs have to be added","created_at":"2017-01-02T06:54:42Z","updated_at":"2017-01-03T11:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"533274113eb99a5fb3ce4fd458f57cfeeadfc2f9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prooph/event-store/pulls/238/commits","review_comments_url":"https://api.github.com/repos/prooph/event-store/pulls/238/comments","review_comment_url":"https://api.github.com/repos/prooph/event-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prooph/event-store/issues/238/comments","statuses_url":"https://api.github.com/repos/prooph/event-store/statuses/90a1ec62b19ee2f11376616c84fd1823cf7b9df3","head":{"label":"dropdevcoding:outsource_aggregate_translator_configuration","ref":"outsource_aggregate_translator_configuration","sha":"90a1ec62b19ee2f11376616c84fd1823cf7b9df3","user":{"login":"dropdevcoding","id":3219267,"avatar_url":"https://avatars.githubusercontent.com/u/3219267?v=3","gravatar_id":"","url":"https://api.github.com/users/dropdevcoding","html_url":"https://github.com/dropdevcoding","followers_url":"https://api.github.com/users/dropdevcoding/followers","following_url":"https://api.github.com/users/dropdevcoding/following{/other_user}","gists_url":"https://api.github.com/users/dropdevcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/dropdevcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropdevcoding/subscriptions","organizations_url":"https://api.github.com/users/dropdevcoding/orgs","repos_url":"https://api.github.com/users/dropdevcoding/repos","events_url":"https://api.github.com/users/dropdevcoding/events{/privacy}","received_events_url":"https://api.github.com/users/dropdevcoding/received_events","type":"User","site_admin":false},"repo":{"id":77789414,"name":"event-store","full_name":"dropdevcoding/event-store","owner":{"login":"dropdevcoding","id":3219267,"avatar_url":"https://avatars.githubusercontent.com/u/3219267?v=3","gravatar_id":"","url":"https://api.github.com/users/dropdevcoding","html_url":"https://github.com/dropdevcoding","followers_url":"https://api.github.com/users/dropdevcoding/followers","following_url":"https://api.github.com/users/dropdevcoding/following{/other_user}","gists_url":"https://api.github.com/users/dropdevcoding/gists{/gist_id}","starred_url":"https://api.github.com/users/dropdevcoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropdevcoding/subscriptions","organizations_url":"https://api.github.com/users/dropdevcoding/orgs","repos_url":"https://api.github.com/users/dropdevcoding/repos","events_url":"https://api.github.com/users/dropdevcoding/events{/privacy}","received_events_url":"https://api.github.com/users/dropdevcoding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dropdevcoding/event-store","description":"PHP 5.5+ EventStore Implementation.","fork":true,"url":"https://api.github.com/repos/dropdevcoding/event-store","forks_url":"https://api.github.com/repos/dropdevcoding/event-store/forks","keys_url":"https://api.github.com/repos/dropdevcoding/event-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropdevcoding/event-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropdevcoding/event-store/teams","hooks_url":"https://api.github.com/repos/dropdevcoding/event-store/hooks","issue_events_url":"https://api.github.com/repos/dropdevcoding/event-store/issues/events{/number}","events_url":"https://api.github.com/repos/dropdevcoding/event-store/events","assignees_url":"https://api.github.com/repos/dropdevcoding/event-store/assignees{/user}","branches_url":"https://api.github.com/repos/dropdevcoding/event-store/branches{/branch}","tags_url":"https://api.github.com/repos/dropdevcoding/event-store/tags","blobs_url":"https://api.github.com/repos/dropdevcoding/event-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropdevcoding/event-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropdevcoding/event-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropdevcoding/event-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropdevcoding/event-store/statuses/{sha}","languages_url":"https://api.github.com/repos/dropdevcoding/event-store/languages","stargazers_url":"https://api.github.com/repos/dropdevcoding/event-store/stargazers","contributors_url":"https://api.github.com/repos/dropdevcoding/event-store/contributors","subscribers_url":"https://api.github.com/repos/dropdevcoding/event-store/subscribers","subscription_url":"https://api.github.com/repos/dropdevcoding/event-store/subscription","commits_url":"https://api.github.com/repos/dropdevcoding/event-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropdevcoding/event-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropdevcoding/event-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropdevcoding/event-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropdevcoding/event-store/contents/{+path}","compare_url":"https://api.github.com/repos/dropdevcoding/event-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropdevcoding/event-store/merges","archive_url":"https://api.github.com/repos/dropdevcoding/event-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropdevcoding/event-store/downloads","issues_url":"https://api.github.com/repos/dropdevcoding/event-store/issues{/number}","pulls_url":"https://api.github.com/repos/dropdevcoding/event-store/pulls{/number}","milestones_url":"https://api.github.com/repos/dropdevcoding/event-store/milestones{/number}","notifications_url":"https://api.github.com/repos/dropdevcoding/event-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropdevcoding/event-store/labels{/name}","releases_url":"https://api.github.com/repos/dropdevcoding/event-store/releases{/id}","deployments_url":"https://api.github.com/repos/dropdevcoding/event-store/deployments","created_at":"2017-01-01T17:41:33Z","updated_at":"2017-01-01T17:41:36Z","pushed_at":"2017-01-02T19:41:17Z","git_url":"git://github.com/dropdevcoding/event-store.git","ssh_url":"git@github.com:dropdevcoding/event-store.git","clone_url":"https://github.com/dropdevcoding/event-store.git","svn_url":"https://github.com/dropdevcoding/event-store","homepage":"http://getprooph.org","size":957,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prooph:master","ref":"master","sha":"6a602459723e2b61ea388e48e57303f7bbc0abf2","user":{"login":"prooph","id":7341005,"avatar_url":"https://avatars.githubusercontent.com/u/7341005?v=3","gravatar_id":"","url":"https://api.github.com/users/prooph","html_url":"https://github.com/prooph","followers_url":"https://api.github.com/users/prooph/followers","following_url":"https://api.github.com/users/prooph/following{/other_user}","gists_url":"https://api.github.com/users/prooph/gists{/gist_id}","starred_url":"https://api.github.com/users/prooph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prooph/subscriptions","organizations_url":"https://api.github.com/users/prooph/orgs","repos_url":"https://api.github.com/users/prooph/repos","events_url":"https://api.github.com/users/prooph/events{/privacy}","received_events_url":"https://api.github.com/users/prooph/received_events","type":"Organization","site_admin":false},"repo":{"id":18950794,"name":"event-store","full_name":"prooph/event-store","owner":{"login":"prooph","id":7341005,"avatar_url":"https://avatars.githubusercontent.com/u/7341005?v=3","gravatar_id":"","url":"https://api.github.com/users/prooph","html_url":"https://github.com/prooph","followers_url":"https://api.github.com/users/prooph/followers","following_url":"https://api.github.com/users/prooph/following{/other_user}","gists_url":"https://api.github.com/users/prooph/gists{/gist_id}","starred_url":"https://api.github.com/users/prooph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prooph/subscriptions","organizations_url":"https://api.github.com/users/prooph/orgs","repos_url":"https://api.github.com/users/prooph/repos","events_url":"https://api.github.com/users/prooph/events{/privacy}","received_events_url":"https://api.github.com/users/prooph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prooph/event-store","description":"PHP 5.5+ EventStore Implementation.","fork":false,"url":"https://api.github.com/repos/prooph/event-store","forks_url":"https://api.github.com/repos/prooph/event-store/forks","keys_url":"https://api.github.com/repos/prooph/event-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prooph/event-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prooph/event-store/teams","hooks_url":"https://api.github.com/repos/prooph/event-store/hooks","issue_events_url":"https://api.github.com/repos/prooph/event-store/issues/events{/number}","events_url":"https://api.github.com/repos/prooph/event-store/events","assignees_url":"https://api.github.com/repos/prooph/event-store/assignees{/user}","branches_url":"https://api.github.com/repos/prooph/event-store/branches{/branch}","tags_url":"https://api.github.com/repos/prooph/event-store/tags","blobs_url":"https://api.github.com/repos/prooph/event-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prooph/event-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prooph/event-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/prooph/event-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prooph/event-store/statuses/{sha}","languages_url":"https://api.github.com/repos/prooph/event-store/languages","stargazers_url":"https://api.github.com/repos/prooph/event-store/stargazers","contributors_url":"https://api.github.com/repos/prooph/event-store/contributors","subscribers_url":"https://api.github.com/repos/prooph/event-store/subscribers","subscription_url":"https://api.github.com/repos/prooph/event-store/subscription","commits_url":"https://api.github.com/repos/prooph/event-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/prooph/event-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/prooph/event-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/prooph/event-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/prooph/event-store/contents/{+path}","compare_url":"https://api.github.com/repos/prooph/event-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prooph/event-store/merges","archive_url":"https://api.github.com/repos/prooph/event-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prooph/event-store/downloads","issues_url":"https://api.github.com/repos/prooph/event-store/issues{/number}","pulls_url":"https://api.github.com/repos/prooph/event-store/pulls{/number}","milestones_url":"https://api.github.com/repos/prooph/event-store/milestones{/number}","notifications_url":"https://api.github.com/repos/prooph/event-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prooph/event-store/labels{/name}","releases_url":"https://api.github.com/repos/prooph/event-store/releases{/id}","deployments_url":"https://api.github.com/repos/prooph/event-store/deployments","created_at":"2014-04-19T21:00:37Z","updated_at":"2016-12-30T18:33:41Z","pushed_at":"2017-01-03T10:50:31Z","git_url":"git://github.com/prooph/event-store.git","ssh_url":"git@github.com:prooph/event-store.git","clone_url":"https://github.com/prooph/event-store.git","svn_url":"https://github.com/prooph/event-store","homepage":"http://getprooph.org","size":975,"stargazers_count":148,"watchers_count":148,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":10,"forks":21,"open_issues":10,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prooph/event-store/pulls/238"},"html":{"href":"https://github.com/prooph/event-store/pull/238"},"issue":{"href":"https://api.github.com/repos/prooph/event-store/issues/238"},"comments":{"href":"https://api.github.com/repos/prooph/event-store/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/prooph/event-store/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/prooph/event-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prooph/event-store/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/prooph/event-store/statuses/90a1ec62b19ee2f11376616c84fd1823cf7b9df3"}}}}
{"actor":{"display_login":"prolic"}}