{"push_id":1495134048,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"48ea08eac24a1abd57da65f4fab5c2b2290ae851","before":"4a90f5451c278eb9868439b8cfaefad0d27bf8ec","commits":[{"sha":"a946d42369d18045236bde532e63f4bbfc61610c","author":{"name":"carlosgc@webkit.org","email":"f0d8198c2f2c7571e9504148b3ae623d3bc1c7c7@webkit.org"},"message":"[GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer\nhttps://bugs.webkit.org/show_bug.cgi?id=166886\n\nReviewed by Xabier Rodriguez-Calvar.\n\nThis patch doesn't change the behavior, so it's covered by existing Web Audio tests. It replaces pointers with\nsmart pointers, uses WTF::Vector instead of GSList and simplifies the code to map/unmap GstBuffers.\n\n* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:\n(webKitWebAudioSrcConstructed):\n(webKitWebAudioSrcFinalize):\n(webKitWebAudioSrcLoop):\n(webKitWebAudioSrcChangeState):\n* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:\n(WTF::derefGPtr<GstBufferList>):\n(WTF::adoptGRef):\n(WTF::refGPtr<GstBufferPool>):\n(WTF::derefGPtr<GstBufferPool>):\n* platform/graphics/gstreamer/GRefPtrGStreamer.h:\n* platform/graphics/gstreamer/GStreamerUtilities.cpp:\n(WebCore::mapGstBuffer):\n* platform/graphics/gstreamer/GStreamerUtilities.h:\n* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:\n(StreamingClient::createReadBuffer):\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@210584 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/a946d42369d18045236bde532e63f4bbfc61610c"},{"sha":"48ea08eac24a1abd57da65f4fab5c2b2290ae851","author":{"name":"utatane.tea@gmail.com","email":"5b6caba828616d83be87379dfbd4f472729de13f@gmail.com"},"message":"Decouple module loading initiator from ScriptElement\nhttps://bugs.webkit.org/show_bug.cgi?id=166888\n\nReviewed by Saam Barati and Ryosuke Niwa.\n\nSource/JavaScriptCore:\n\nAdd ScriptFetcher and JSScriptFetcher.\n\n* CMakeLists.txt:\n* JavaScriptCore.xcodeproj/project.pbxproj:\n* builtins/ModuleLoaderPrototype.js:\n(requestFetch):\n(requestInstantiate):\n(requestSatisfy):\n(requestInstantiateAll):\n(requestLink):\n(moduleEvaluation):\n(loadAndEvaluateModule):\n(importModule):\n* llint/LLIntData.cpp:\n(JSC::LLInt::Data::performAssertions):\n* llint/LowLevelInterpreter.asm:\n* runtime/Completion.cpp:\n(JSC::loadAndEvaluateModule):\n(JSC::loadModule):\n(JSC::linkAndEvaluateModule):\n* runtime/Completion.h:\n* runtime/JSModuleLoader.cpp:\n(JSC::JSModuleLoader::loadAndEvaluateModule):\n(JSC::JSModuleLoader::loadModule):\n(JSC::JSModuleLoader::linkAndEvaluateModule):\n(JSC::JSModuleLoader::resolve):\n(JSC::JSModuleLoader::fetch):\n(JSC::JSModuleLoader::instantiate):\n(JSC::JSModuleLoader::evaluate):\n* runtime/JSModuleLoader.h:\n* runtime/JSScriptFetcher.cpp: Copied from Source/WebCore/dom/LoadableScript.cpp.\n(JSC::JSScriptFetcher::destroy):\n* runtime/JSScriptFetcher.h: Added.\n(JSC::JSScriptFetcher::createStructure):\n(JSC::JSScriptFetcher::create):\n(JSC::JSScriptFetcher::fetcher):\n(JSC::JSScriptFetcher::JSScriptFetcher):\n* runtime/JSType.h:\n* runtime/ScriptFetcher.h: Copied from Source/WebCore/dom/LoadableScript.cpp.\n(JSC::ScriptFetcher::~ScriptFetcher):\n* runtime/VM.cpp:\n(JSC::VM::VM):\n* runtime/VM.h:\n\nSource/WebCore:\n\nPreviously, we use ScriptElement (JSElement for ScriptElement) as the module loading initiator.\nThis element is used to transfer the metadata like charset throughout the module pipeline.\nAs a result, our module loader in the browser side is tightly coupled with ScriptElement.\nIt is not good since it prevent us from using the module loader in the non-DOM environment like\nWeb Workers.\n\nSo we decouple the necessary informations from ScriptElement. We move these information to\nLoadableScript. And we use JSScriptFetcher to transfer LoadableScript through the JS implemented\nmodule loader pipeline. We select LoadableScript instead of LoadableModuleScript since this initiator\ninformation will be leveraged even in classic scripts once we implement the dynamic import.\n\nNo behavior change.\n\n* ForwardingHeaders/runtime/JSScriptFetcher.h: Copied from Source/WebCore/dom/LoadableScript.cpp.\n* ForwardingHeaders/runtime/ScriptFetcher.h: Copied from Source/WebCore/dom/LoadableScript.cpp.\n* bindings/js/CachedModuleScript.cpp:\n(WebCore::CachedModuleScript::create):\n(WebCore::CachedModuleScript::load):\n(WebCore::CachedModuleScript::CachedModuleScript): Deleted.\n* bindings/js/CachedModuleScript.h:\nNow we can merge CachedModuleScript to LoadableScript. But we do not do this in this patch since\nwe focus on decoupling the initiator information from ScriptElement.\n\n(WebCore::CachedModuleScript::nonce): Deleted.\n(WebCore::CachedModuleScript::crossOriginMode): Deleted.\n* bindings/js/CachedModuleScriptLoader.cpp:\n(WebCore::CachedModuleScriptLoader::load):\n* bindings/js/CachedModuleScriptLoader.h:\n* bindings/js/JSDOMWindowBase.cpp:\n(WebCore::JSDOMWindowBase::moduleLoaderResolve):\n(WebCore::JSDOMWindowBase::moduleLoaderFetch):\n(WebCore::JSDOMWindowBase::moduleLoaderEvaluate):\n* bindings/js/JSMainThreadExecState.h:\n(WebCore::JSMainThreadExecState::loadModule):\n(WebCore::JSMainThreadExecState::linkAndEvaluateModule):\n* bindings/js/ScriptController.cpp:\n(WebCore::ScriptController::loadModuleScriptInWorld):\n(WebCore::ScriptController::loadModuleScript):\n(WebCore::ScriptController::linkAndEvaluateModuleScriptInWorld):\n(WebCore::ScriptController::linkAndEvaluateModuleScript):\n* bindings/js/ScriptController.h:\n* bindings/js/ScriptModuleLoader.cpp:\n(WebCore::ScriptModuleLoader::fetch):\n* bindings/js/ScriptModuleLoader.h:\n* dom/LoadableClassicScript.cpp:\n(WebCore::LoadableClassicScript::create):\n(WebCore::LoadableClassicScript::~LoadableClassicScript):\n(WebCore::LoadableClassicScript::isLoaded):\n(WebCore::LoadableClassicScript::error):\n(WebCore::LoadableClassicScript::wasCanceled):\n(WebCore::LoadableClassicScript::notifyFinished):\n(WebCore::LoadableClassicScript::load):\n* dom/LoadableClassicScript.h:\n* dom/LoadableModuleScript.cpp:\n(WebCore::LoadableModuleScript::create):\n(WebCore::LoadableModuleScript::LoadableModuleScript):\n(WebCore::LoadableModuleScript::load):\n* dom/LoadableModuleScript.h:\n* dom/LoadableScript.cpp:\n(WebCore::LoadableScript::requestScriptWithCache):\n* dom/LoadableScript.h:\n(WebCore::LoadableScript::LoadableScript):\n* dom/ScriptElement.cpp:\n(WebCore::ScriptElement::requestClassicScript):\n(WebCore::ScriptElement::requestModuleScript):\n(WebCore::ScriptElement::executeModuleScript):\n(WebCore::ScriptElement::requestScriptWithCacheForModuleScript): Deleted.\n(WebCore::ScriptElement::requestScriptWithCache): Deleted.\n* dom/ScriptElement.h:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@210585 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/48ea08eac24a1abd57da65f4fab5c2b2290ae851"}]}
{"actor":{"display_login":"kisg"}}