{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/117655464","pull_request_review_id":39378487,"id":117655464,"diff_hunk":"@@ -244,6 +244,21 @@ oppia.controller('StateInteraction', [\n                   stateCustomizationArgsService.displayed).length > 0);\n               }\n \n+              $scope.areCustomizationArgsValid = function() {\n+                if (!stateCustomizationArgsService.displayed) {\n+                  return false;\n+                }\n+                var validationService =\n+                  $injector.get(\n+                    INTERACTION_SPECS[\n+                      $scope.stateInteractionIdService.displayed].id +\n+                    'ValidationService');\n+                var warningsList =\n+                  validationService.getCustomizationArgsWarnings(\n+                    stateCustomizationArgsService.displayed);\n+                return warningsList.length == 0;","path":"core/templates/dev/head/pages/exploration_editor/editor_tab/StateInteraction.js","position":55,"original_position":55,"commit_id":"63f181d2427da3b6347c7bb6db0b3bb461b18c51","original_commit_id":"63f181d2427da3b6347c7bb6db0b3bb461b18c51","user":{"login":"juansaba","id":4760286,"avatar_url":"https://avatars1.githubusercontent.com/u/4760286?v=3","gravatar_id":"","url":"https://api.github.com/users/juansaba","html_url":"https://github.com/juansaba","followers_url":"https://api.github.com/users/juansaba/followers","following_url":"https://api.github.com/users/juansaba/following{/other_user}","gists_url":"https://api.github.com/users/juansaba/gists{/gist_id}","starred_url":"https://api.github.com/users/juansaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juansaba/subscriptions","organizations_url":"https://api.github.com/users/juansaba/orgs","repos_url":"https://api.github.com/users/juansaba/repos","events_url":"https://api.github.com/users/juansaba/events{/privacy}","received_events_url":"https://api.github.com/users/juansaba/received_events","type":"User","site_admin":false},"body":"Ok, there may be a problem in the linter then, cause I always run the frontend tests and the linter is run when pushing, and I didn't get an error on this. Just saying ;)","created_at":"2017-05-22T03:04:59Z","updated_at":"2017-05-22T03:04:59Z","html_url":"https://github.com/oppia/oppia/pull/3449#discussion_r117655464","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/3449","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/117655464"},"html":{"href":"https://github.com/oppia/oppia/pull/3449#discussion_r117655464"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3449"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/3449","id":121637937,"html_url":"https://github.com/oppia/oppia/pull/3449","diff_url":"https://github.com/oppia/oppia/pull/3449.diff","patch_url":"https://github.com/oppia/oppia/pull/3449.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/3449","number":3449,"state":"open","locked":false,"title":"Fix #3417: Make region names editable in-place","user":{"login":"juansaba","id":4760286,"avatar_url":"https://avatars1.githubusercontent.com/u/4760286?v=3","gravatar_id":"","url":"https://api.github.com/users/juansaba","html_url":"https://github.com/juansaba","followers_url":"https://api.github.com/users/juansaba/followers","following_url":"https://api.github.com/users/juansaba/following{/other_user}","gists_url":"https://api.github.com/users/juansaba/gists{/gist_id}","starred_url":"https://api.github.com/users/juansaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juansaba/subscriptions","organizations_url":"https://api.github.com/users/juansaba/orgs","repos_url":"https://api.github.com/users/juansaba/repos","events_url":"https://api.github.com/users/juansaba/events{/privacy}","received_events_url":"https://api.github.com/users/juansaba/received_events","type":"User","site_admin":false},"body":"Aside from implementing the feature described in the issue, I also did the following things:\r\n\r\n- Removed the temporary list of labels {labelsList} since it was not necessary.\r\n- Updated the resetEditor() function so that it would reset ALL the variables in the $scope. Previously, only a few variables were cleared but many other variables remained with their old values, so when the user when back and select a different image, the leftovers from the old image and region lists would cause all sorts of trouble.\r\n- Fixed the \"duplicate label\" message. There was a bug where this message would persist even after fixing the problem. This also happened after resetEditor() and then selecting a new image.\r\n- I also updated the image displayed when selecting type of interaction, that used to show two regions called \"1\" and \"2\". I replaced it with regions \"Earth\" and \"Saturn\", which make more sense for the actual image being displayed and sends the message to the user that regions should have meaningful names (see final image below).\r\n- Finally, this PR also makes the \"Save Interaction\" button disabled if there are customization args warnings.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/4760286/26018306/d908ca16-3722-11e7-9abe-dcb64ea4f77d.png)\r\n","created_at":"2017-05-20T21:03:32Z","updated_at":"2017-05-22T03:04:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59d48c63550485b1fc5cb8ece3095036c7754685","assignee":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars3.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"assignees":[{"login":"seanlip","id":10575562,"avatar_url":"https://avatars3.githubusercontent.com/u/10575562?v=3","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/3449/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/3449/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/3449/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/63f181d2427da3b6347c7bb6db0b3bb461b18c51","head":{"label":"juansaba:images-region-names","ref":"images-region-names","sha":"63f181d2427da3b6347c7bb6db0b3bb461b18c51","user":{"login":"juansaba","id":4760286,"avatar_url":"https://avatars1.githubusercontent.com/u/4760286?v=3","gravatar_id":"","url":"https://api.github.com/users/juansaba","html_url":"https://github.com/juansaba","followers_url":"https://api.github.com/users/juansaba/followers","following_url":"https://api.github.com/users/juansaba/following{/other_user}","gists_url":"https://api.github.com/users/juansaba/gists{/gist_id}","starred_url":"https://api.github.com/users/juansaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juansaba/subscriptions","organizations_url":"https://api.github.com/users/juansaba/orgs","repos_url":"https://api.github.com/users/juansaba/repos","events_url":"https://api.github.com/users/juansaba/events{/privacy}","received_events_url":"https://api.github.com/users/juansaba/received_events","type":"User","site_admin":false},"repo":{"id":88286071,"name":"oppia","full_name":"juansaba/oppia","owner":{"login":"juansaba","id":4760286,"avatar_url":"https://avatars1.githubusercontent.com/u/4760286?v=3","gravatar_id":"","url":"https://api.github.com/users/juansaba","html_url":"https://github.com/juansaba","followers_url":"https://api.github.com/users/juansaba/followers","following_url":"https://api.github.com/users/juansaba/following{/other_user}","gists_url":"https://api.github.com/users/juansaba/gists{/gist_id}","starred_url":"https://api.github.com/users/juansaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juansaba/subscriptions","organizations_url":"https://api.github.com/users/juansaba/orgs","repos_url":"https://api.github.com/users/juansaba/repos","events_url":"https://api.github.com/users/juansaba/events{/privacy}","received_events_url":"https://api.github.com/users/juansaba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juansaba/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/juansaba/oppia","forks_url":"https://api.github.com/repos/juansaba/oppia/forks","keys_url":"https://api.github.com/repos/juansaba/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juansaba/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juansaba/oppia/teams","hooks_url":"https://api.github.com/repos/juansaba/oppia/hooks","issue_events_url":"https://api.github.com/repos/juansaba/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/juansaba/oppia/events","assignees_url":"https://api.github.com/repos/juansaba/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/juansaba/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/juansaba/oppia/tags","blobs_url":"https://api.github.com/repos/juansaba/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juansaba/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juansaba/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/juansaba/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juansaba/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/juansaba/oppia/languages","stargazers_url":"https://api.github.com/repos/juansaba/oppia/stargazers","contributors_url":"https://api.github.com/repos/juansaba/oppia/contributors","subscribers_url":"https://api.github.com/repos/juansaba/oppia/subscribers","subscription_url":"https://api.github.com/repos/juansaba/oppia/subscription","commits_url":"https://api.github.com/repos/juansaba/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/juansaba/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/juansaba/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/juansaba/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/juansaba/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/juansaba/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juansaba/oppia/merges","archive_url":"https://api.github.com/repos/juansaba/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juansaba/oppia/downloads","issues_url":"https://api.github.com/repos/juansaba/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/juansaba/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/juansaba/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/juansaba/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juansaba/oppia/labels{/name}","releases_url":"https://api.github.com/repos/juansaba/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/juansaba/oppia/deployments","created_at":"2017-04-14T16:55:28Z","updated_at":"2017-04-14T16:55:34Z","pushed_at":"2017-05-20T20:59:27Z","git_url":"git://github.com/juansaba/oppia.git","ssh_url":"git@github.com:juansaba/oppia.git","clone_url":"https://github.com/juansaba/oppia.git","svn_url":"https://github.com/juansaba/oppia","homepage":"https://www.oppia.org","size":51516,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"55e43584534462eadddb9ae94f31511a2267cb2f","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars2.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars2.githubusercontent.com/u/11620230?v=3","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2017-05-21T08:51:45Z","pushed_at":"2017-05-22T03:00:06Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":51649,"stargazers_count":309,"watchers_count":309,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":430,"mirror_url":null,"open_issues_count":357,"forks":430,"open_issues":357,"watchers":309,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3449"},"html":{"href":"https://github.com/oppia/oppia/pull/3449"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/3449"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/3449/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3449/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3449/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/63f181d2427da3b6347c7bb6db0b3bb461b18c51"}}}}
{"actor":{"display_login":"juansaba"}}