{"action":"created","comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments/115504851","pull_request_review_id":37047518,"id":115504851,"diff_hunk":"@@ -32,7 +37,7 @@ public static EditPostPreviewFragment newInstance(SiteModel site, PostModel post\n         EditPostPreviewFragment fragment = new EditPostPreviewFragment();\n         Bundle bundle = new Bundle();\n         bundle.putSerializable(WordPress.SITE, site);\n-        bundle.putSerializable(EditPostActivity.EXTRA_POST, post);\n+        bundle.putInt(EditPostActivity.EXTRA_POST_LOCAL_ID, post.getId());","path":"WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostPreviewFragment.java","position":22,"original_position":22,"commit_id":"008f33c89bd13d53b09ee337c2025991db49aad8","original_commit_id":"008f33c89bd13d53b09ee337c2025991db49aad8","user":{"login":"maxme","id":40213,"avatar_url":"https://avatars1.githubusercontent.com/u/40213?v=3","gravatar_id":"","url":"https://api.github.com/users/maxme","html_url":"https://github.com/maxme","followers_url":"https://api.github.com/users/maxme/followers","following_url":"https://api.github.com/users/maxme/following{/other_user}","gists_url":"https://api.github.com/users/maxme/gists{/gist_id}","starred_url":"https://api.github.com/users/maxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxme/subscriptions","organizations_url":"https://api.github.com/users/maxme/orgs","repos_url":"https://api.github.com/users/maxme/repos","events_url":"https://api.github.com/users/maxme/events{/privacy}","received_events_url":"https://api.github.com/users/maxme/received_events","type":"User","site_admin":false},"body":"I would add a comment to explain why we switched from `putSerializable` to `putInt` (and why we're still doing it for the site).","created_at":"2017-05-09T14:31:16Z","updated_at":"2017-05-09T14:31:16Z","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/5856#discussion_r115504851","pull_request_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/5856","_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments/115504851"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Android/pull/5856#discussion_r115504851"},"pull_request":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/5856"}}},"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/5856","id":119672411,"html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/5856","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/5856.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/5856.patch","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/5856","number":5856,"state":"open","locked":false,"title":"Pass post id instead of post model within intents and extras","user":{"login":"oguzkocer","id":662023,"avatar_url":"https://avatars3.githubusercontent.com/u/662023?v=3","gravatar_id":"","url":"https://api.github.com/users/oguzkocer","html_url":"https://github.com/oguzkocer","followers_url":"https://api.github.com/users/oguzkocer/followers","following_url":"https://api.github.com/users/oguzkocer/following{/other_user}","gists_url":"https://api.github.com/users/oguzkocer/gists{/gist_id}","starred_url":"https://api.github.com/users/oguzkocer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oguzkocer/subscriptions","organizations_url":"https://api.github.com/users/oguzkocer/orgs","repos_url":"https://api.github.com/users/oguzkocer/repos","events_url":"https://api.github.com/users/oguzkocer/events{/privacy}","received_events_url":"https://api.github.com/users/oguzkocer/received_events","type":"User","site_admin":false},"body":"Fixes #5456. This is a possible fix to our `TransactionTooLargeException ` crash. Unfortunately we do not have enough details about the crashes to make sure we have the right fix for it, so we have to keep trying until we figure it out. Having said that I think this is a step in the right direction. I think, unless it's mandatory, we should always try to pass ids instead of whole objects between activities. It makes the code more robust as well as prevent issues like this one.\r\n\r\nOriginally, I was working on the `release/7.3` branch for this, so we could fix it asap. However, I believe this fix looks deceptively simple yet can cause some unseen issues, so I think it's just safer to target `develop`. We don't want to introduce more crashes while trying to fix one.\r\n\r\nThe changes are straightforward, however I got a little worried about the config changes (re-creating fragments and activities) since we don't pass the cached version of the post anymore and a new version from the DB is retrieved. As far as I can tell from the code, we do snyc the changes before this happens and my tests didn't result in anything lost, but it'd be good if we can test it out further.\r\n\r\nTo test:\r\n* Go into the post list, open a post, edit it, rotate the screen, assign featured images etc. Anything you can think of when a cached post might be purged and the DB version is used. For such a small PR, it actually requires some rigorous testing.\r\n\r\n@aforcier Since this is posts related, do you mind reviewing this one, I'd feel more comfortable if I got the :shipit: from you!\r\n\r\n/cc @mzorz @maxme @theck13 (since you were all interested in this issue)","created_at":"2017-05-09T14:26:50Z","updated_at":"2017-05-09T14:31:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0efb315fef1d5417372e39ca1949cc6e8ad9e5f9","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/87","html_url":"https://github.com/wordpress-mobile/WordPress-Android/milestone/87","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/87/labels","id":2377350,"number":87,"title":"7.4","description":"","creator":{"login":"maxme","id":40213,"avatar_url":"https://avatars1.githubusercontent.com/u/40213?v=3","gravatar_id":"","url":"https://api.github.com/users/maxme","html_url":"https://github.com/maxme","followers_url":"https://api.github.com/users/maxme/followers","following_url":"https://api.github.com/users/maxme/following{/other_user}","gists_url":"https://api.github.com/users/maxme/gists{/gist_id}","starred_url":"https://api.github.com/users/maxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxme/subscriptions","organizations_url":"https://api.github.com/users/maxme/orgs","repos_url":"https://api.github.com/users/maxme/repos","events_url":"https://api.github.com/users/maxme/events{/privacy}","received_events_url":"https://api.github.com/users/maxme/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":6,"state":"open","created_at":"2017-03-10T13:12:56Z","updated_at":"2017-05-09T14:26:50Z","due_on":"2017-05-22T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/5856/commits","review_comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/5856/comments","review_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/5856/comments","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/008f33c89bd13d53b09ee337c2025991db49aad8","head":{"label":"wordpress-mobile:crash/transaction-too-large-exception","ref":"crash/transaction-too-large-exception","sha":"008f33c89bd13d53b09ee337c2025991db49aad8","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars1.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9306568,"name":"WordPress-Android","full_name":"wordpress-mobile/WordPress-Android","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars1.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-Android","description":"WordPress for Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/deployments","created_at":"2013-04-08T20:52:40Z","updated_at":"2017-05-09T01:46:09Z","pushed_at":"2017-05-09T14:26:51Z","git_url":"git://github.com/wordpress-mobile/WordPress-Android.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Android.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Android.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Android","homepage":"http://android.wordpress.org","size":169971,"stargazers_count":1423,"watchers_count":1423,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":798,"mirror_url":null,"open_issues_count":295,"forks":798,"open_issues":295,"watchers":1423,"default_branch":"develop"}},"base":{"label":"wordpress-mobile:develop","ref":"develop","sha":"364e6cb972d347d2b4dfbddc1b7810ed2b310d7d","user":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars1.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":9306568,"name":"WordPress-Android","full_name":"wordpress-mobile/WordPress-Android","owner":{"login":"wordpress-mobile","id":1306301,"avatar_url":"https://avatars1.githubusercontent.com/u/1306301?v=3","gravatar_id":"","url":"https://api.github.com/users/wordpress-mobile","html_url":"https://github.com/wordpress-mobile","followers_url":"https://api.github.com/users/wordpress-mobile/followers","following_url":"https://api.github.com/users/wordpress-mobile/following{/other_user}","gists_url":"https://api.github.com/users/wordpress-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/wordpress-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordpress-mobile/subscriptions","organizations_url":"https://api.github.com/users/wordpress-mobile/orgs","repos_url":"https://api.github.com/users/wordpress-mobile/repos","events_url":"https://api.github.com/users/wordpress-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/wordpress-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wordpress-mobile/WordPress-Android","description":"WordPress for Android","fork":false,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","forks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/forks","keys_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/teams","hooks_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/hooks","issue_events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/events{/number}","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/events","assignees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/assignees{/user}","branches_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/branches{/branch}","tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/tags","blobs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/languages","stargazers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/stargazers","contributors_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contributors","subscribers_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscribers","subscription_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/subscription","commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/contents/{+path}","compare_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/merges","archive_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/downloads","issues_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues{/number}","pulls_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels{/name}","releases_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/releases{/id}","deployments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/deployments","created_at":"2013-04-08T20:52:40Z","updated_at":"2017-05-09T01:46:09Z","pushed_at":"2017-05-09T14:26:51Z","git_url":"git://github.com/wordpress-mobile/WordPress-Android.git","ssh_url":"git@github.com:wordpress-mobile/WordPress-Android.git","clone_url":"https://github.com/wordpress-mobile/WordPress-Android.git","svn_url":"https://github.com/wordpress-mobile/WordPress-Android","homepage":"http://android.wordpress.org","size":169971,"stargazers_count":1423,"watchers_count":1423,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":798,"mirror_url":null,"open_issues_count":295,"forks":798,"open_issues":295,"watchers":1423,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/5856"},"html":{"href":"https://github.com/wordpress-mobile/WordPress-Android/pull/5856"},"issue":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/5856"},"comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/5856/comments"},"review_comments":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/5856/comments"},"review_comment":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/5856/commits"},"statuses":{"href":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/statuses/008f33c89bd13d53b09ee337c2025991db49aad8"}}}}
{"actor":{"display_login":"maxme"}}