{"action":"created","issue":{"url":"https://api.github.com/repos/LSSTDESC/overview_paper/issues/9","repository_url":"https://api.github.com/repos/LSSTDESC/overview_paper","labels_url":"https://api.github.com/repos/LSSTDESC/overview_paper/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/LSSTDESC/overview_paper/issues/9/comments","events_url":"https://api.github.com/repos/LSSTDESC/overview_paper/issues/9/events","html_url":"https://github.com/LSSTDESC/overview_paper/pull/9","id":275218080,"number":9,"title":"modifications from Rachel M","user":{"login":"rmandelb","id":1454906,"avatar_url":"https://avatars3.githubusercontent.com/u/1454906?v=4","gravatar_id":"","url":"https://api.github.com/users/rmandelb","html_url":"https://github.com/rmandelb","followers_url":"https://api.github.com/users/rmandelb/followers","following_url":"https://api.github.com/users/rmandelb/following{/other_user}","gists_url":"https://api.github.com/users/rmandelb/gists{/gist_id}","starred_url":"https://api.github.com/users/rmandelb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmandelb/subscriptions","organizations_url":"https://api.github.com/users/rmandelb/orgs","repos_url":"https://api.github.com/users/rmandelb/repos","events_url":"https://api.github.com/users/rmandelb/events{/privacy}","received_events_url":"https://api.github.com/users/rmandelb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-11-20T02:13:52Z","updated_at":"2017-11-20T17:05:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/LSSTDESC/overview_paper/pulls/9","html_url":"https://github.com/LSSTDESC/overview_paper/pull/9","diff_url":"https://github.com/LSSTDESC/overview_paper/pull/9.diff","patch_url":"https://github.com/LSSTDESC/overview_paper/pull/9.patch"},"body":"There are a number of modifications to the text in this PR.  For the full list of what I was trying to accomplish, see https://github.com/LSSTDESC/overview_paper/issues/8.  A few notes:\r\n\r\n- I did some minimal reference updating, in places where things were egregiously out of date.  The text would improve from more of this, but there's not a lot of time before the end of the day on Monday so I went with critical things only.\r\n\r\n- There was (in section 4.1) an estimate of 1-2% photo-z accuracy (sigma_z/(1+z)) for the gold sample.  I thought this was supposed to be 3-5% according to the latest DESC estimates, so I changed it.  @sschmidt23 @morriscb can you please confirm?\r\n\r\n- Section 2.1.1 had strong claims about multi-fitting being needed, whereas in practice no decisions have been made about whether certain galaxy properties will be measured in a multi-fit or stack-fit approach.  I was going to change this to be a little more vague, but I noticed that similar assertions are made in section 3.3, which is not our responsibility to update.  @drphilmarshall - do you know who is updating section 3.3?  I would like to touch base with whoever it is to make sure consistent statements end up in both places.\r\n\r\n- Parameter constraint figures 22-24 appear to be based on out-of-date assumptions about the photo-z quality, shear sample properties, usable scales, etc. from what I can tell (some details are not actually explained on the figure).  Not sure what we can do about this on such short notice, however!"},"comment":{"url":"https://api.github.com/repos/LSSTDESC/overview_paper/issues/comments/345761094","html_url":"https://github.com/LSSTDESC/overview_paper/pull/9#issuecomment-345761094","issue_url":"https://api.github.com/repos/LSSTDESC/overview_paper/issues/9","id":345761094,"user":{"login":"drphilmarshall","id":710903,"avatar_url":"https://avatars2.githubusercontent.com/u/710903?v=4","gravatar_id":"","url":"https://api.github.com/users/drphilmarshall","html_url":"https://github.com/drphilmarshall","followers_url":"https://api.github.com/users/drphilmarshall/followers","following_url":"https://api.github.com/users/drphilmarshall/following{/other_user}","gists_url":"https://api.github.com/users/drphilmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/drphilmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drphilmarshall/subscriptions","organizations_url":"https://api.github.com/users/drphilmarshall/orgs","repos_url":"https://api.github.com/users/drphilmarshall/repos","events_url":"https://api.github.com/users/drphilmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/drphilmarshall/received_events","type":"User","site_admin":false},"created_at":"2017-11-20T17:05:04Z","updated_at":"2017-11-20T17:05:04Z","author_association":"NONE","body":"@rmandelb Re figures 22-24: How about we retain Fig 22 (contours) and Fig 24 (fractional errors on distance and growth of structure) from the Science Book, but comment out Figure 23 (galaxy power spectrum, with old assumptions written on the figure). Reducing the number of figures will not be a bad thing, I think. We would need to adjust the text not to refer to Fig 23, and explain the assumptions going into Fig 22 and 24. What do you think?"}}
{"actor":{"display_login":"drphilmarshall"}}