{"action":"created","issue":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/573","repository_url":"https://api.github.com/repos/openpgpjs/openpgpjs","labels_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/573/labels{/name}","comments_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/573/comments","events_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/573/events","html_url":"https://github.com/openpgpjs/openpgpjs/issues/573","id":250761082,"number":573,"title":"Unknown Armor Headers should not lead to abort processing","user":{"login":"pbrunschwig","id":12988906,"avatar_url":"https://avatars2.githubusercontent.com/u/12988906?v=4","gravatar_id":"","url":"https://api.github.com/users/pbrunschwig","html_url":"https://github.com/pbrunschwig","followers_url":"https://api.github.com/users/pbrunschwig/followers","following_url":"https://api.github.com/users/pbrunschwig/following{/other_user}","gists_url":"https://api.github.com/users/pbrunschwig/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrunschwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrunschwig/subscriptions","organizations_url":"https://api.github.com/users/pbrunschwig/orgs","repos_url":"https://api.github.com/users/pbrunschwig/repos","events_url":"https://api.github.com/users/pbrunschwig/events{/privacy}","received_events_url":"https://api.github.com/users/pbrunschwig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-16T21:10:03Z","updated_at":"2017-08-19T17:09:29Z","closed_at":null,"body":"In the course of Autocrypt, we are defining new headers for ASCII Armored messages (e.g for the Autocrypt Setup Message). The current implementation of openpgpjs I tried (v2.5.4) however breaks at this point.\r\n\r\nThe comment in the code above verifyHeaders() is:\r\n\r\n> _Verify armored headers. RFC4880, section 6.3: \"OpenPGP should consider improperly formatted Armor Headers to be corruption of the ASCII Armor.\"_\r\n\r\n\r\nHowever, the sentence just following in RFC 4880 says: \r\n\r\n> \"Unknown keys should be reported to the user, but OpenPGP should continue to process the message.\"\r\n\r\nAn unknown header is not improperly formatted just because it is unknown. As long as the header is compliant to the specification, it should not lead to throwing an error.\r\n\r\nPS. In case you wonder why I'm reporting this at all: I integrated openpgpjs in Enigmail, currently only for processing of symmetrically encrypted messages and for analyzing key data before import."},"comment":{"url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/comments/323535515","html_url":"https://github.com/openpgpjs/openpgpjs/issues/573#issuecomment-323535515","issue_url":"https://api.github.com/repos/openpgpjs/openpgpjs/issues/573","id":323535515,"user":{"login":"pbrunschwig","id":12988906,"avatar_url":"https://avatars2.githubusercontent.com/u/12988906?v=4","gravatar_id":"","url":"https://api.github.com/users/pbrunschwig","html_url":"https://github.com/pbrunschwig","followers_url":"https://api.github.com/users/pbrunschwig/followers","following_url":"https://api.github.com/users/pbrunschwig/following{/other_user}","gists_url":"https://api.github.com/users/pbrunschwig/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrunschwig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrunschwig/subscriptions","organizations_url":"https://api.github.com/users/pbrunschwig/orgs","repos_url":"https://api.github.com/users/pbrunschwig/repos","events_url":"https://api.github.com/users/pbrunschwig/events{/privacy}","received_events_url":"https://api.github.com/users/pbrunschwig/received_events","type":"User","site_admin":false},"created_at":"2017-08-19T17:09:29Z","updated_at":"2017-08-19T17:09:29Z","body":"PR created"}}
{"actor":{"display_login":"pbrunschwig"}}