{"action":"created","comment":{"url":"https://api.github.com/repos/milseman/swift/pulls/comments/157277699","pull_request_review_id":83899599,"id":157277699,"diff_hunk":"@@ -1127,3 +1010,141 @@ extension _StringGuts {\n     }\n   }\n }\n+\n+extension _StringGuts : Sequence {","path":"stdlib/public/core/StringGuts.swift","position":129,"original_position":129,"commit_id":"308f7270bd268a1e08fded3f71c4a3f3f5e9580e","original_commit_id":"308f7270bd268a1e08fded3f71c4a3f3f5e9580e","user":{"login":"lorentey","id":608696,"avatar_url":"https://avatars3.githubusercontent.com/u/608696?v=4","gravatar_id":"","url":"https://api.github.com/users/lorentey","html_url":"https://github.com/lorentey","followers_url":"https://api.github.com/users/lorentey/followers","following_url":"https://api.github.com/users/lorentey/following{/other_user}","gists_url":"https://api.github.com/users/lorentey/gists{/gist_id}","starred_url":"https://api.github.com/users/lorentey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorentey/subscriptions","organizations_url":"https://api.github.com/users/lorentey/orgs","repos_url":"https://api.github.com/users/lorentey/repos","events_url":"https://api.github.com/users/lorentey/events{/privacy}","received_events_url":"https://api.github.com/users/lorentey/received_events","type":"User","site_admin":false},"body":"The conformance is completely unnecessary; I'll remove it.\r\n\r\nThe `Iterator` made it easier to get `UTF8View` off `_StringCore`. We may or may not decide to keep it, although a single buffering iterator is one way to remove those ugly distinct iterator properties from `UnicodeScalarView`...","created_at":"2017-12-15T19:13:07Z","updated_at":"2017-12-15T19:13:08Z","html_url":"https://github.com/milseman/swift/pull/14#discussion_r157277699","pull_request_url":"https://api.github.com/repos/milseman/swift/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/milseman/swift/pulls/comments/157277699"},"html":{"href":"https://github.com/milseman/swift/pull/14#discussion_r157277699"},"pull_request":{"href":"https://api.github.com/repos/milseman/swift/pulls/14"}},"in_reply_to_id":157273512},"pull_request":{"url":"https://api.github.com/repos/milseman/swift/pulls/14","id":158593207,"html_url":"https://github.com/milseman/swift/pull/14","diff_url":"https://github.com/milseman/swift/pull/14.diff","patch_url":"https://github.com/milseman/swift/pull/14.patch","issue_url":"https://api.github.com/repos/milseman/swift/issues/14","number":14,"state":"open","locked":false,"title":"Remove `_LegacyStringCore` and `_StringBuffer`","user":{"login":"lorentey","id":608696,"avatar_url":"https://avatars3.githubusercontent.com/u/608696?v=4","gravatar_id":"","url":"https://api.github.com/users/lorentey","html_url":"https://github.com/lorentey","followers_url":"https://api.github.com/users/lorentey/followers","following_url":"https://api.github.com/users/lorentey/following{/other_user}","gists_url":"https://api.github.com/users/lorentey/gists{/gist_id}","starred_url":"https://api.github.com/users/lorentey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorentey/subscriptions","organizations_url":"https://api.github.com/users/lorentey/orgs","repos_url":"https://api.github.com/users/lorentey/repos","events_url":"https://api.github.com/users/lorentey/events{/privacy}","received_events_url":"https://api.github.com/users/lorentey/received_events","type":"User","site_admin":false},"body":"This PR eliminates the remaining usages of `_LegacyStringCore` and `_StringBuffer`, and removes them from the standard library. ","created_at":"2017-12-15T12:32:57Z","updated_at":"2017-12-15T19:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7f65ff7846c92a59b32dac0c3aa92adc76bc4c0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/milseman/swift/pulls/14/commits","review_comments_url":"https://api.github.com/repos/milseman/swift/pulls/14/comments","review_comment_url":"https://api.github.com/repos/milseman/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/milseman/swift/issues/14/comments","statuses_url":"https://api.github.com/repos/milseman/swift/statuses/308f7270bd268a1e08fded3f71c4a3f3f5e9580e","head":{"label":"lorentey:string_guts","ref":"string_guts","sha":"308f7270bd268a1e08fded3f71c4a3f3f5e9580e","user":{"login":"lorentey","id":608696,"avatar_url":"https://avatars3.githubusercontent.com/u/608696?v=4","gravatar_id":"","url":"https://api.github.com/users/lorentey","html_url":"https://github.com/lorentey","followers_url":"https://api.github.com/users/lorentey/followers","following_url":"https://api.github.com/users/lorentey/following{/other_user}","gists_url":"https://api.github.com/users/lorentey/gists{/gist_id}","starred_url":"https://api.github.com/users/lorentey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorentey/subscriptions","organizations_url":"https://api.github.com/users/lorentey/orgs","repos_url":"https://api.github.com/users/lorentey/repos","events_url":"https://api.github.com/users/lorentey/events{/privacy}","received_events_url":"https://api.github.com/users/lorentey/received_events","type":"User","site_admin":false},"repo":{"id":50289371,"name":"swift","full_name":"lorentey/swift","owner":{"login":"lorentey","id":608696,"avatar_url":"https://avatars3.githubusercontent.com/u/608696?v=4","gravatar_id":"","url":"https://api.github.com/users/lorentey","html_url":"https://github.com/lorentey","followers_url":"https://api.github.com/users/lorentey/followers","following_url":"https://api.github.com/users/lorentey/following{/other_user}","gists_url":"https://api.github.com/users/lorentey/gists{/gist_id}","starred_url":"https://api.github.com/users/lorentey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorentey/subscriptions","organizations_url":"https://api.github.com/users/lorentey/orgs","repos_url":"https://api.github.com/users/lorentey/repos","events_url":"https://api.github.com/users/lorentey/events{/privacy}","received_events_url":"https://api.github.com/users/lorentey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lorentey/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/lorentey/swift","forks_url":"https://api.github.com/repos/lorentey/swift/forks","keys_url":"https://api.github.com/repos/lorentey/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorentey/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorentey/swift/teams","hooks_url":"https://api.github.com/repos/lorentey/swift/hooks","issue_events_url":"https://api.github.com/repos/lorentey/swift/issues/events{/number}","events_url":"https://api.github.com/repos/lorentey/swift/events","assignees_url":"https://api.github.com/repos/lorentey/swift/assignees{/user}","branches_url":"https://api.github.com/repos/lorentey/swift/branches{/branch}","tags_url":"https://api.github.com/repos/lorentey/swift/tags","blobs_url":"https://api.github.com/repos/lorentey/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorentey/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorentey/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorentey/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorentey/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/lorentey/swift/languages","stargazers_url":"https://api.github.com/repos/lorentey/swift/stargazers","contributors_url":"https://api.github.com/repos/lorentey/swift/contributors","subscribers_url":"https://api.github.com/repos/lorentey/swift/subscribers","subscription_url":"https://api.github.com/repos/lorentey/swift/subscription","commits_url":"https://api.github.com/repos/lorentey/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorentey/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorentey/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorentey/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorentey/swift/contents/{+path}","compare_url":"https://api.github.com/repos/lorentey/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorentey/swift/merges","archive_url":"https://api.github.com/repos/lorentey/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorentey/swift/downloads","issues_url":"https://api.github.com/repos/lorentey/swift/issues{/number}","pulls_url":"https://api.github.com/repos/lorentey/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/lorentey/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/lorentey/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorentey/swift/labels{/name}","releases_url":"https://api.github.com/repos/lorentey/swift/releases{/id}","deployments_url":"https://api.github.com/repos/lorentey/swift/deployments","created_at":"2016-01-24T13:42:07Z","updated_at":"2016-01-24T13:42:21Z","pushed_at":"2017-12-15T17:45:50Z","git_url":"git://github.com/lorentey/swift.git","ssh_url":"git@github.com:lorentey/swift.git","clone_url":"https://github.com/lorentey/swift.git","svn_url":"https://github.com/lorentey/swift","homepage":"https://swift.org/","size":235470,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"milseman:string_guts","ref":"string_guts","sha":"8dce2a9d8e215c1ba5f716219d380b851586c410","user":{"login":"milseman","id":235334,"avatar_url":"https://avatars0.githubusercontent.com/u/235334?v=4","gravatar_id":"","url":"https://api.github.com/users/milseman","html_url":"https://github.com/milseman","followers_url":"https://api.github.com/users/milseman/followers","following_url":"https://api.github.com/users/milseman/following{/other_user}","gists_url":"https://api.github.com/users/milseman/gists{/gist_id}","starred_url":"https://api.github.com/users/milseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milseman/subscriptions","organizations_url":"https://api.github.com/users/milseman/orgs","repos_url":"https://api.github.com/users/milseman/repos","events_url":"https://api.github.com/users/milseman/events{/privacy}","received_events_url":"https://api.github.com/users/milseman/received_events","type":"User","site_admin":false},"repo":{"id":49166817,"name":"swift","full_name":"milseman/swift","owner":{"login":"milseman","id":235334,"avatar_url":"https://avatars0.githubusercontent.com/u/235334?v=4","gravatar_id":"","url":"https://api.github.com/users/milseman","html_url":"https://github.com/milseman","followers_url":"https://api.github.com/users/milseman/followers","following_url":"https://api.github.com/users/milseman/following{/other_user}","gists_url":"https://api.github.com/users/milseman/gists{/gist_id}","starred_url":"https://api.github.com/users/milseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milseman/subscriptions","organizations_url":"https://api.github.com/users/milseman/orgs","repos_url":"https://api.github.com/users/milseman/repos","events_url":"https://api.github.com/users/milseman/events{/privacy}","received_events_url":"https://api.github.com/users/milseman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milseman/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/milseman/swift","forks_url":"https://api.github.com/repos/milseman/swift/forks","keys_url":"https://api.github.com/repos/milseman/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milseman/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milseman/swift/teams","hooks_url":"https://api.github.com/repos/milseman/swift/hooks","issue_events_url":"https://api.github.com/repos/milseman/swift/issues/events{/number}","events_url":"https://api.github.com/repos/milseman/swift/events","assignees_url":"https://api.github.com/repos/milseman/swift/assignees{/user}","branches_url":"https://api.github.com/repos/milseman/swift/branches{/branch}","tags_url":"https://api.github.com/repos/milseman/swift/tags","blobs_url":"https://api.github.com/repos/milseman/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milseman/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milseman/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/milseman/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milseman/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/milseman/swift/languages","stargazers_url":"https://api.github.com/repos/milseman/swift/stargazers","contributors_url":"https://api.github.com/repos/milseman/swift/contributors","subscribers_url":"https://api.github.com/repos/milseman/swift/subscribers","subscription_url":"https://api.github.com/repos/milseman/swift/subscription","commits_url":"https://api.github.com/repos/milseman/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/milseman/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/milseman/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/milseman/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/milseman/swift/contents/{+path}","compare_url":"https://api.github.com/repos/milseman/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milseman/swift/merges","archive_url":"https://api.github.com/repos/milseman/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milseman/swift/downloads","issues_url":"https://api.github.com/repos/milseman/swift/issues{/number}","pulls_url":"https://api.github.com/repos/milseman/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/milseman/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/milseman/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milseman/swift/labels{/name}","releases_url":"https://api.github.com/repos/milseman/swift/releases{/id}","deployments_url":"https://api.github.com/repos/milseman/swift/deployments","created_at":"2016-01-06T22:55:53Z","updated_at":"2017-08-14T22:06:25Z","pushed_at":"2017-12-15T12:32:58Z","git_url":"git://github.com/milseman/swift.git","ssh_url":"git@github.com:milseman/swift.git","clone_url":"https://github.com/milseman/swift.git","svn_url":"https://github.com/milseman/swift","homepage":"https://swift.org/","size":231649,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/milseman/swift/pulls/14"},"html":{"href":"https://github.com/milseman/swift/pull/14"},"issue":{"href":"https://api.github.com/repos/milseman/swift/issues/14"},"comments":{"href":"https://api.github.com/repos/milseman/swift/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/milseman/swift/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/milseman/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/milseman/swift/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/milseman/swift/statuses/308f7270bd268a1e08fded3f71c4a3f3f5e9580e"}},"author_association":"NONE"}}
{"actor":{"display_login":"lorentey"}}