{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/145781498","pull_request_review_id":70633436,"id":145781498,"diff_hunk":"@@ -1052,9 +1051,6 @@ inline GenTreePtr Compiler::gtNewIconHandleNode(\n \n #if defined(LATE_DISASM)\n     node = new (this, LargeOpOpcode()) GenTreeIntCon(TYP_I_IMPL, value, fields DEBUGARG(/*largeNode*/ true));\n-\n-    node->gtIntCon.gtIconHdl.gtIconHdl1 = handle1;","path":"src/jit/compiler.hpp","position":15,"original_position":15,"commit_id":"99e6a6b20c57038472b99ffd107c12dc08aa4e09","original_commit_id":"99e6a6b20c57038472b99ffd107c12dc08aa4e09","user":{"login":"briansull","id":11621884,"avatar_url":"https://avatars2.githubusercontent.com/u/11621884?v=4","gravatar_id":"","url":"https://api.github.com/users/briansull","html_url":"https://github.com/briansull","followers_url":"https://api.github.com/users/briansull/followers","following_url":"https://api.github.com/users/briansull/following{/other_user}","gists_url":"https://api.github.com/users/briansull/gists{/gist_id}","starred_url":"https://api.github.com/users/briansull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansull/subscriptions","organizations_url":"https://api.github.com/users/briansull/orgs","repos_url":"https://api.github.com/users/briansull/repos","events_url":"https://api.github.com/users/briansull/events{/privacy}","received_events_url":"https://api.github.com/users/briansull/received_events","type":"User","site_admin":false},"body":"I plan on investigating this further and fixing it in an upcoming change","created_at":"2017-10-19T18:14:50Z","updated_at":"2017-10-19T18:14:50Z","html_url":"https://github.com/dotnet/coreclr/pull/14582#discussion_r145781498","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/14582","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/145781498"},"html":{"href":"https://github.com/dotnet/coreclr/pull/14582#discussion_r145781498"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14582"}},"in_reply_to_id":145770141},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/14582","id":147448601,"html_url":"https://github.com/dotnet/coreclr/pull/14582","diff_url":"https://github.com/dotnet/coreclr/pull/14582.diff","patch_url":"https://github.com/dotnet/coreclr/pull/14582.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/14582","number":14582,"state":"open","locked":false,"title":"Cleanup IconHandle nodes","user":{"login":"briansull","id":11621884,"avatar_url":"https://avatars2.githubusercontent.com/u/11621884?v=4","gravatar_id":"","url":"https://api.github.com/users/briansull","html_url":"https://github.com/briansull","followers_url":"https://api.github.com/users/briansull/followers","following_url":"https://api.github.com/users/briansull/following{/other_user}","gists_url":"https://api.github.com/users/briansull/gists{/gist_id}","starred_url":"https://api.github.com/users/briansull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansull/subscriptions","organizations_url":"https://api.github.com/users/briansull/orgs","repos_url":"https://api.github.com/users/briansull/repos","events_url":"https://api.github.com/users/briansull/events{/privacy}","received_events_url":"https://api.github.com/users/briansull/received_events","type":"User","site_admin":false},"body":" Removed unused fields of Icon nodes:\r\n - The union of gtIconHdl1, gtIconHdl2 and gtIconCPX, gtIIconCls is not used\r\n\r\nRemoved unused handle args from gtNewIconHandleNode and gtNewIcomEmbHndNode","created_at":"2017-10-19T01:31:27Z","updated_at":"2017-10-19T18:14:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aa4e82e9ac6fa3eef5d1b04a1a762de4c6d3779","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/14582/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/14582/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/14582/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/99e6a6b20c57038472b99ffd107c12dc08aa4e09","head":{"label":"briansull:cleanup-iconhdl","ref":"cleanup-iconhdl","sha":"99e6a6b20c57038472b99ffd107c12dc08aa4e09","user":{"login":"briansull","id":11621884,"avatar_url":"https://avatars2.githubusercontent.com/u/11621884?v=4","gravatar_id":"","url":"https://api.github.com/users/briansull","html_url":"https://github.com/briansull","followers_url":"https://api.github.com/users/briansull/followers","following_url":"https://api.github.com/users/briansull/following{/other_user}","gists_url":"https://api.github.com/users/briansull/gists{/gist_id}","starred_url":"https://api.github.com/users/briansull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansull/subscriptions","organizations_url":"https://api.github.com/users/briansull/orgs","repos_url":"https://api.github.com/users/briansull/repos","events_url":"https://api.github.com/users/briansull/events{/privacy}","received_events_url":"https://api.github.com/users/briansull/received_events","type":"User","site_admin":false},"repo":{"id":32836344,"name":"coreclr","full_name":"briansull/coreclr","owner":{"login":"briansull","id":11621884,"avatar_url":"https://avatars2.githubusercontent.com/u/11621884?v=4","gravatar_id":"","url":"https://api.github.com/users/briansull","html_url":"https://github.com/briansull","followers_url":"https://api.github.com/users/briansull/followers","following_url":"https://api.github.com/users/briansull/following{/other_user}","gists_url":"https://api.github.com/users/briansull/gists{/gist_id}","starred_url":"https://api.github.com/users/briansull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansull/subscriptions","organizations_url":"https://api.github.com/users/briansull/orgs","repos_url":"https://api.github.com/users/briansull/repos","events_url":"https://api.github.com/users/briansull/events{/privacy}","received_events_url":"https://api.github.com/users/briansull/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/briansull/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/briansull/coreclr","forks_url":"https://api.github.com/repos/briansull/coreclr/forks","keys_url":"https://api.github.com/repos/briansull/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briansull/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briansull/coreclr/teams","hooks_url":"https://api.github.com/repos/briansull/coreclr/hooks","issue_events_url":"https://api.github.com/repos/briansull/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/briansull/coreclr/events","assignees_url":"https://api.github.com/repos/briansull/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/briansull/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/briansull/coreclr/tags","blobs_url":"https://api.github.com/repos/briansull/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briansull/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briansull/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/briansull/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briansull/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/briansull/coreclr/languages","stargazers_url":"https://api.github.com/repos/briansull/coreclr/stargazers","contributors_url":"https://api.github.com/repos/briansull/coreclr/contributors","subscribers_url":"https://api.github.com/repos/briansull/coreclr/subscribers","subscription_url":"https://api.github.com/repos/briansull/coreclr/subscription","commits_url":"https://api.github.com/repos/briansull/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/briansull/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/briansull/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/briansull/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/briansull/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/briansull/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briansull/coreclr/merges","archive_url":"https://api.github.com/repos/briansull/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briansull/coreclr/downloads","issues_url":"https://api.github.com/repos/briansull/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/briansull/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/briansull/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/briansull/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briansull/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/briansull/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/briansull/coreclr/deployments","created_at":"2015-03-25T01:52:49Z","updated_at":"2016-01-12T22:16:55Z","pushed_at":"2017-10-19T02:15:11Z","git_url":"git://github.com/briansull/coreclr.git","ssh_url":"git@github.com:briansull/coreclr.git","clone_url":"https://github.com/briansull/coreclr.git","svn_url":"https://github.com/briansull/coreclr","homepage":"","size":184977,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"344e2e7b535e3406a1eccaf8627609e803e37c63","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-10-19T14:45:48Z","pushed_at":"2017-10-19T18:07:27Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":187074,"stargazers_count":8498,"watchers_count":8498,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2135,"mirror_url":null,"open_issues_count":1493,"forks":2135,"open_issues":1493,"watchers":8498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14582"},"html":{"href":"https://github.com/dotnet/coreclr/pull/14582"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/14582"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/14582/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14582/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14582/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/99e6a6b20c57038472b99ffd107c12dc08aa4e09"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"briansull"}}