{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/97560604","pull_request_review_id":18172856,"id":97560604,"diff_hunk":"@@ -567,8 +579,13 @@ def f(self, _method=method, *args, **kwargs):\n # groupby & aggregate methods\n for method in ['count', 'size']:\n \n-    def f(self, _method=method):\n-        return self._downsample(_method)\n+    if method == \"size\":","path":"pandas/tseries/resample.py","position":32,"original_position":32,"commit_id":"427234faf8371a1238bee6c6db6f5e7acc415234","original_commit_id":"427234faf8371a1238bee6c6db6f5e7acc415234","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars.githubusercontent.com/u/953992?v=3","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"I don't think any of this is necessary, ``_wrap_results`` can handle all of this","created_at":"2017-01-24T14:43:45Z","updated_at":"2017-01-24T14:45:15Z","html_url":"https://github.com/pandas-dev/pandas/pull/15093#discussion_r97560604","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/97560604"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/15093#discussion_r97560604"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093","id":100768917,"html_url":"https://github.com/pandas-dev/pandas/pull/15093","diff_url":"https://github.com/pandas-dev/pandas/pull/15093.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/15093.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/15093","number":15093,"state":"open","locked":false,"title":"BUG: Inconsistent return type for downsampling on resample of empty DataFrame","user":{"login":"discort","id":4944021,"avatar_url":"https://avatars.githubusercontent.com/u/4944021?v=3","gravatar_id":"","url":"https://api.github.com/users/discort","html_url":"https://github.com/discort","followers_url":"https://api.github.com/users/discort/followers","following_url":"https://api.github.com/users/discort/following{/other_user}","gists_url":"https://api.github.com/users/discort/gists{/gist_id}","starred_url":"https://api.github.com/users/discort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discort/subscriptions","organizations_url":"https://api.github.com/users/discort/orgs","repos_url":"https://api.github.com/users/discort/repos","events_url":"https://api.github.com/users/discort/events{/privacy}","received_events_url":"https://api.github.com/users/discort/received_events","type":"User","site_admin":false},"body":" - [x] closes #14962\r\n - [x] tests added / passed\r\n - [x] passes ``git diff upstream/master | flake8 --diff``\r\n - [x] whatsnew entry\r\n","created_at":"2017-01-09T21:58:41Z","updated_at":"2017-01-24T14:45:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c26f442d02bc98560804c58b7ecc2f9bf963048","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/15093/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/427234faf8371a1238bee6c6db6f5e7acc415234","head":{"label":"discort:fix_14962_bug","ref":"fix_14962_bug","sha":"427234faf8371a1238bee6c6db6f5e7acc415234","user":{"login":"discort","id":4944021,"avatar_url":"https://avatars.githubusercontent.com/u/4944021?v=3","gravatar_id":"","url":"https://api.github.com/users/discort","html_url":"https://github.com/discort","followers_url":"https://api.github.com/users/discort/followers","following_url":"https://api.github.com/users/discort/following{/other_user}","gists_url":"https://api.github.com/users/discort/gists{/gist_id}","starred_url":"https://api.github.com/users/discort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discort/subscriptions","organizations_url":"https://api.github.com/users/discort/orgs","repos_url":"https://api.github.com/users/discort/repos","events_url":"https://api.github.com/users/discort/events{/privacy}","received_events_url":"https://api.github.com/users/discort/received_events","type":"User","site_admin":false},"repo":{"id":74369521,"name":"pandas","full_name":"discort/pandas","owner":{"login":"discort","id":4944021,"avatar_url":"https://avatars.githubusercontent.com/u/4944021?v=3","gravatar_id":"","url":"https://api.github.com/users/discort","html_url":"https://github.com/discort","followers_url":"https://api.github.com/users/discort/followers","following_url":"https://api.github.com/users/discort/following{/other_user}","gists_url":"https://api.github.com/users/discort/gists{/gist_id}","starred_url":"https://api.github.com/users/discort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discort/subscriptions","organizations_url":"https://api.github.com/users/discort/orgs","repos_url":"https://api.github.com/users/discort/repos","events_url":"https://api.github.com/users/discort/events{/privacy}","received_events_url":"https://api.github.com/users/discort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/discort/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/discort/pandas","forks_url":"https://api.github.com/repos/discort/pandas/forks","keys_url":"https://api.github.com/repos/discort/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discort/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discort/pandas/teams","hooks_url":"https://api.github.com/repos/discort/pandas/hooks","issue_events_url":"https://api.github.com/repos/discort/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/discort/pandas/events","assignees_url":"https://api.github.com/repos/discort/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/discort/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/discort/pandas/tags","blobs_url":"https://api.github.com/repos/discort/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discort/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discort/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/discort/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discort/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/discort/pandas/languages","stargazers_url":"https://api.github.com/repos/discort/pandas/stargazers","contributors_url":"https://api.github.com/repos/discort/pandas/contributors","subscribers_url":"https://api.github.com/repos/discort/pandas/subscribers","subscription_url":"https://api.github.com/repos/discort/pandas/subscription","commits_url":"https://api.github.com/repos/discort/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/discort/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/discort/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/discort/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/discort/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/discort/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discort/pandas/merges","archive_url":"https://api.github.com/repos/discort/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discort/pandas/downloads","issues_url":"https://api.github.com/repos/discort/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/discort/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/discort/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/discort/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discort/pandas/labels{/name}","releases_url":"https://api.github.com/repos/discort/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/discort/pandas/deployments","created_at":"2016-11-21T14:05:11Z","updated_at":"2016-11-21T14:05:18Z","pushed_at":"2017-01-23T19:54:56Z","git_url":"git://github.com/discort/pandas.git","ssh_url":"git@github.com:discort/pandas.git","clone_url":"https://github.com/discort/pandas.git","svn_url":"https://github.com/discort/pandas","homepage":"http://pandas.pydata.org","size":87265,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"be3f2aea4a8ad3f6bf4eb84e6ca3269abff5fcfb","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars.githubusercontent.com/u/21206976?v=3","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars.githubusercontent.com/u/21206976?v=3","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-01-24T13:58:00Z","pushed_at":"2017-01-24T14:41:38Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":87569,"stargazers_count":8291,"watchers_count":8291,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3332,"mirror_url":null,"open_issues_count":1850,"forks":3332,"open_issues":1850,"watchers":8291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/15093"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/15093"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/15093/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/15093/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/427234faf8371a1238bee6c6db6f5e7acc415234"}}}}
{"actor":{"display_login":"jreback"}}