{"action":"created","issue":{"url":"https://api.github.com/repos/mobify/platform-scaffold/issues/1003","repository_url":"https://api.github.com/repos/mobify/platform-scaffold","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/1003/labels{/name}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/1003/comments","events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/1003/events","html_url":"https://github.com/mobify/platform-scaffold/pull/1003","id":256103551,"number":1003,"title":"WEB-1533: merlins alt tag audit","user":{"login":"jnurse","id":1301857,"avatar_url":"https://avatars2.githubusercontent.com/u/1301857?v=4","gravatar_id":"","url":"https://api.github.com/users/jnurse","html_url":"https://github.com/jnurse","followers_url":"https://api.github.com/users/jnurse/followers","following_url":"https://api.github.com/users/jnurse/following{/other_user}","gists_url":"https://api.github.com/users/jnurse/gists{/gist_id}","starred_url":"https://api.github.com/users/jnurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnurse/subscriptions","organizations_url":"https://api.github.com/users/jnurse/orgs","repos_url":"https://api.github.com/users/jnurse/repos","events_url":"https://api.github.com/users/jnurse/events{/privacy}","received_events_url":"https://api.github.com/users/jnurse/received_events","type":"User","site_admin":false},"labels":[{"id":402885657,"url":"https://api.github.com/repos/mobify/platform-scaffold/labels/ready%20for%20review","name":"ready for review","color":"0e8a16","default":false},{"id":520512961,"url":"https://api.github.com/repos/mobify/platform-scaffold/labels/web","name":"web","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-07T23:55:44Z","updated_at":"2017-09-08T19:02:14Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/1003","html_url":"https://github.com/mobify/platform-scaffold/pull/1003","diff_url":"https://github.com/mobify/platform-scaffold/pull/1003.diff","patch_url":"https://github.com/mobify/platform-scaffold/pull/1003.patch"},"body":"This PR adds missing alt tags to images on the site. It resolves images included directly in the project and images parsed from Merlins. The SFCC audit will be in a separate PR. \r\n\r\n **JIRA**: https://mobify.atlassian.net/browse/WEB-1533\r\n **Linked PRs**: n/a\r\n\r\n## Changes\r\n- Added alt tags to banners on the homepage\r\n- Added alt tags to merlins PDP parsing\r\n- Added alt tag to image in cart remove item modal\r\n- Added alt tag to empty account order list image\r\n- Added alt tag to image in account remove address modal\r\n- Added alt tag to image in wishlist remove item modal\r\n\r\n## Todos\r\n- [ ] (if applicable) analytics events instrumented to measure impact of change\r\n- [ ] Add a high-level description of your changes to the CHANGELOG.md, including a link to the PR with your changes\r\n\r\n## How to test-drive this PR\r\n- Run `npm start`\r\n- Preview [Merlin's Potions](https://preview.mobify.com/?url=https%3A%2F%2Fwww.merlinspotions.com%2F&site_folder=https%3A%2F%2Flocalhost%3A8443%2Floader.js&disabled=0&domain=&scope=1)\r\n- navigate through the site and check that no images are included without alt tags\r\n"},"comment":{"url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments/328187872","html_url":"https://github.com/mobify/platform-scaffold/pull/1003#issuecomment-328187872","issue_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/1003","id":328187872,"user":{"login":"jeffkamo","id":734535,"avatar_url":"https://avatars0.githubusercontent.com/u/734535?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffkamo","html_url":"https://github.com/jeffkamo","followers_url":"https://api.github.com/users/jeffkamo/followers","following_url":"https://api.github.com/users/jeffkamo/following{/other_user}","gists_url":"https://api.github.com/users/jeffkamo/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkamo/subscriptions","organizations_url":"https://api.github.com/users/jeffkamo/orgs","repos_url":"https://api.github.com/users/jeffkamo/repos","events_url":"https://api.github.com/users/jeffkamo/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkamo/received_events","type":"User","site_admin":false},"created_at":"2017-09-08T19:02:14Z","updated_at":"2017-09-08T19:02:14Z","author_association":"MEMBER","body":"Looks like all that's left is just a broken test:\r\n\r\n```\r\nFAIL  app/connectors/_merlins-connector/home/parser.test.js\r\n```"}}
{"actor":{"display_login":"jeffkamo"}}