{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/nsaechao/pants/pulls/3","id":133823266,"html_url":"https://github.com/nsaechao/pants/pull/3","diff_url":"https://github.com/nsaechao/pants/pull/3.diff","patch_url":"https://github.com/nsaechao/pants/pull/3.patch","issue_url":"https://api.github.com/repos/nsaechao/pants/issues/3","number":3,"state":"closed","locked":false,"title":"Add lint and fmt goal for javascript style rules checking","user":{"login":"nsaechao","id":19673210,"avatar_url":"https://avatars3.githubusercontent.com/u/19673210?v=4","gravatar_id":"","url":"https://api.github.com/users/nsaechao","html_url":"https://github.com/nsaechao","followers_url":"https://api.github.com/users/nsaechao/followers","following_url":"https://api.github.com/users/nsaechao/following{/other_user}","gists_url":"https://api.github.com/users/nsaechao/gists{/gist_id}","starred_url":"https://api.github.com/users/nsaechao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsaechao/subscriptions","organizations_url":"https://api.github.com/users/nsaechao/orgs","repos_url":"https://api.github.com/users/nsaechao/repos","events_url":"https://api.github.com/users/nsaechao/events{/privacy}","received_events_url":"https://api.github.com/users/nsaechao/received_events","type":"User","site_admin":false},"body":"### Problem\r\n\r\nBring javascript lint and fmt support to Pants.\r\n\r\n### Solution\r\n\r\n1.) Added a pluggable javascriptstyle node package that implements eslint for javascript style checking and fixing. The dependencies are locked down by a yarn.lock and package.json for deterministic installation. \r\n2.) Add lint and fmt goals that finds all .js/.jsx source files in node targets and then run the javascriptstyle rules against them.\r\n3.) Includes 3 configurable options: --skip, --fail-slow, and --javascriptstyle-dir.\r\n\r\n### Result\r\n\r\nAllows javascript developers to easily lint and format their javascript code according to a uniform set of rules in the pants ecosystem similar to python/scala support.","created_at":"2017-08-02T22:30:04Z","updated_at":"2017-08-02T22:31:27Z","closed_at":"2017-08-02T22:31:27Z","merged_at":"2017-08-02T22:31:27Z","merge_commit_sha":"54e61ae693cd93506ebafb18cea9d7bfc5cfb885","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nsaechao/pants/pulls/3/commits","review_comments_url":"https://api.github.com/repos/nsaechao/pants/pulls/3/comments","review_comment_url":"https://api.github.com/repos/nsaechao/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nsaechao/pants/issues/3/comments","statuses_url":"https://api.github.com/repos/nsaechao/pants/statuses/3888611547340d4197d9e6f54c11f6a98860878f","head":{"label":"nsaechao:nsaechao/add_eslinter_goal","ref":"nsaechao/add_eslinter_goal","sha":"3888611547340d4197d9e6f54c11f6a98860878f","user":{"login":"nsaechao","id":19673210,"avatar_url":"https://avatars3.githubusercontent.com/u/19673210?v=4","gravatar_id":"","url":"https://api.github.com/users/nsaechao","html_url":"https://github.com/nsaechao","followers_url":"https://api.github.com/users/nsaechao/followers","following_url":"https://api.github.com/users/nsaechao/following{/other_user}","gists_url":"https://api.github.com/users/nsaechao/gists{/gist_id}","starred_url":"https://api.github.com/users/nsaechao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsaechao/subscriptions","organizations_url":"https://api.github.com/users/nsaechao/orgs","repos_url":"https://api.github.com/users/nsaechao/repos","events_url":"https://api.github.com/users/nsaechao/events{/privacy}","received_events_url":"https://api.github.com/users/nsaechao/received_events","type":"User","site_admin":false},"repo":{"id":66316042,"name":"pants","full_name":"nsaechao/pants","owner":{"login":"nsaechao","id":19673210,"avatar_url":"https://avatars3.githubusercontent.com/u/19673210?v=4","gravatar_id":"","url":"https://api.github.com/users/nsaechao","html_url":"https://github.com/nsaechao","followers_url":"https://api.github.com/users/nsaechao/followers","following_url":"https://api.github.com/users/nsaechao/following{/other_user}","gists_url":"https://api.github.com/users/nsaechao/gists{/gist_id}","starred_url":"https://api.github.com/users/nsaechao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsaechao/subscriptions","organizations_url":"https://api.github.com/users/nsaechao/orgs","repos_url":"https://api.github.com/users/nsaechao/repos","events_url":"https://api.github.com/users/nsaechao/events{/privacy}","received_events_url":"https://api.github.com/users/nsaechao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsaechao/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/nsaechao/pants","forks_url":"https://api.github.com/repos/nsaechao/pants/forks","keys_url":"https://api.github.com/repos/nsaechao/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsaechao/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsaechao/pants/teams","hooks_url":"https://api.github.com/repos/nsaechao/pants/hooks","issue_events_url":"https://api.github.com/repos/nsaechao/pants/issues/events{/number}","events_url":"https://api.github.com/repos/nsaechao/pants/events","assignees_url":"https://api.github.com/repos/nsaechao/pants/assignees{/user}","branches_url":"https://api.github.com/repos/nsaechao/pants/branches{/branch}","tags_url":"https://api.github.com/repos/nsaechao/pants/tags","blobs_url":"https://api.github.com/repos/nsaechao/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsaechao/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsaechao/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsaechao/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsaechao/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/nsaechao/pants/languages","stargazers_url":"https://api.github.com/repos/nsaechao/pants/stargazers","contributors_url":"https://api.github.com/repos/nsaechao/pants/contributors","subscribers_url":"https://api.github.com/repos/nsaechao/pants/subscribers","subscription_url":"https://api.github.com/repos/nsaechao/pants/subscription","commits_url":"https://api.github.com/repos/nsaechao/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsaechao/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsaechao/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsaechao/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsaechao/pants/contents/{+path}","compare_url":"https://api.github.com/repos/nsaechao/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsaechao/pants/merges","archive_url":"https://api.github.com/repos/nsaechao/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsaechao/pants/downloads","issues_url":"https://api.github.com/repos/nsaechao/pants/issues{/number}","pulls_url":"https://api.github.com/repos/nsaechao/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/nsaechao/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/nsaechao/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsaechao/pants/labels{/name}","releases_url":"https://api.github.com/repos/nsaechao/pants/releases{/id}","deployments_url":"https://api.github.com/repos/nsaechao/pants/deployments","created_at":"2016-08-22T23:38:10Z","updated_at":"2016-08-22T23:38:16Z","pushed_at":"2017-08-02T22:31:27Z","git_url":"git://github.com/nsaechao/pants.git","ssh_url":"git@github.com:nsaechao/pants.git","clone_url":"https://github.com/nsaechao/pants.git","svn_url":"https://github.com/nsaechao/pants","homepage":"http://pantsbuild.github.io/","size":79592,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nsaechao:master","ref":"master","sha":"053a704d25a4d22534b7c8f33a679a8bba79e013","user":{"login":"nsaechao","id":19673210,"avatar_url":"https://avatars3.githubusercontent.com/u/19673210?v=4","gravatar_id":"","url":"https://api.github.com/users/nsaechao","html_url":"https://github.com/nsaechao","followers_url":"https://api.github.com/users/nsaechao/followers","following_url":"https://api.github.com/users/nsaechao/following{/other_user}","gists_url":"https://api.github.com/users/nsaechao/gists{/gist_id}","starred_url":"https://api.github.com/users/nsaechao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsaechao/subscriptions","organizations_url":"https://api.github.com/users/nsaechao/orgs","repos_url":"https://api.github.com/users/nsaechao/repos","events_url":"https://api.github.com/users/nsaechao/events{/privacy}","received_events_url":"https://api.github.com/users/nsaechao/received_events","type":"User","site_admin":false},"repo":{"id":66316042,"name":"pants","full_name":"nsaechao/pants","owner":{"login":"nsaechao","id":19673210,"avatar_url":"https://avatars3.githubusercontent.com/u/19673210?v=4","gravatar_id":"","url":"https://api.github.com/users/nsaechao","html_url":"https://github.com/nsaechao","followers_url":"https://api.github.com/users/nsaechao/followers","following_url":"https://api.github.com/users/nsaechao/following{/other_user}","gists_url":"https://api.github.com/users/nsaechao/gists{/gist_id}","starred_url":"https://api.github.com/users/nsaechao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsaechao/subscriptions","organizations_url":"https://api.github.com/users/nsaechao/orgs","repos_url":"https://api.github.com/users/nsaechao/repos","events_url":"https://api.github.com/users/nsaechao/events{/privacy}","received_events_url":"https://api.github.com/users/nsaechao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nsaechao/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/nsaechao/pants","forks_url":"https://api.github.com/repos/nsaechao/pants/forks","keys_url":"https://api.github.com/repos/nsaechao/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nsaechao/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nsaechao/pants/teams","hooks_url":"https://api.github.com/repos/nsaechao/pants/hooks","issue_events_url":"https://api.github.com/repos/nsaechao/pants/issues/events{/number}","events_url":"https://api.github.com/repos/nsaechao/pants/events","assignees_url":"https://api.github.com/repos/nsaechao/pants/assignees{/user}","branches_url":"https://api.github.com/repos/nsaechao/pants/branches{/branch}","tags_url":"https://api.github.com/repos/nsaechao/pants/tags","blobs_url":"https://api.github.com/repos/nsaechao/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nsaechao/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nsaechao/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/nsaechao/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nsaechao/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/nsaechao/pants/languages","stargazers_url":"https://api.github.com/repos/nsaechao/pants/stargazers","contributors_url":"https://api.github.com/repos/nsaechao/pants/contributors","subscribers_url":"https://api.github.com/repos/nsaechao/pants/subscribers","subscription_url":"https://api.github.com/repos/nsaechao/pants/subscription","commits_url":"https://api.github.com/repos/nsaechao/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/nsaechao/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/nsaechao/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/nsaechao/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/nsaechao/pants/contents/{+path}","compare_url":"https://api.github.com/repos/nsaechao/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nsaechao/pants/merges","archive_url":"https://api.github.com/repos/nsaechao/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nsaechao/pants/downloads","issues_url":"https://api.github.com/repos/nsaechao/pants/issues{/number}","pulls_url":"https://api.github.com/repos/nsaechao/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/nsaechao/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/nsaechao/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nsaechao/pants/labels{/name}","releases_url":"https://api.github.com/repos/nsaechao/pants/releases{/id}","deployments_url":"https://api.github.com/repos/nsaechao/pants/deployments","created_at":"2016-08-22T23:38:10Z","updated_at":"2016-08-22T23:38:16Z","pushed_at":"2017-08-02T22:31:27Z","git_url":"git://github.com/nsaechao/pants.git","ssh_url":"git@github.com:nsaechao/pants.git","clone_url":"https://github.com/nsaechao/pants.git","svn_url":"https://github.com/nsaechao/pants","homepage":"http://pantsbuild.github.io/","size":79592,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nsaechao/pants/pulls/3"},"html":{"href":"https://github.com/nsaechao/pants/pull/3"},"issue":{"href":"https://api.github.com/repos/nsaechao/pants/issues/3"},"comments":{"href":"https://api.github.com/repos/nsaechao/pants/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/nsaechao/pants/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/nsaechao/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nsaechao/pants/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/nsaechao/pants/statuses/3888611547340d4197d9e6f54c11f6a98860878f"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nsaechao","id":19673210,"avatar_url":"https://avatars3.githubusercontent.com/u/19673210?v=4","gravatar_id":"","url":"https://api.github.com/users/nsaechao","html_url":"https://github.com/nsaechao","followers_url":"https://api.github.com/users/nsaechao/followers","following_url":"https://api.github.com/users/nsaechao/following{/other_user}","gists_url":"https://api.github.com/users/nsaechao/gists{/gist_id}","starred_url":"https://api.github.com/users/nsaechao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsaechao/subscriptions","organizations_url":"https://api.github.com/users/nsaechao/orgs","repos_url":"https://api.github.com/users/nsaechao/repos","events_url":"https://api.github.com/users/nsaechao/events{/privacy}","received_events_url":"https://api.github.com/users/nsaechao/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":1528,"deletions":4,"changed_files":16}}
{"actor":{"display_login":"nsaechao"}}