{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/26184","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/26184/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/26184/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/26184/events","html_url":"https://github.com/Microsoft/vscode/issues/26184","id":226938571,"number":26184,"title":"Diff tabs opened from the `Source Control` panel no longer in preview mode","user":{"login":"cateyes99","id":19678455,"avatar_url":"https://avatars2.githubusercontent.com/u/19678455?v=3","gravatar_id":"","url":"https://api.github.com/users/cateyes99","html_url":"https://github.com/cateyes99","followers_url":"https://api.github.com/users/cateyes99/followers","following_url":"https://api.github.com/users/cateyes99/following{/other_user}","gists_url":"https://api.github.com/users/cateyes99/gists{/gist_id}","starred_url":"https://api.github.com/users/cateyes99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cateyes99/subscriptions","organizations_url":"https://api.github.com/users/cateyes99/orgs","repos_url":"https://api.github.com/users/cateyes99/repos","events_url":"https://api.github.com/users/cateyes99/events{/privacy}","received_events_url":"https://api.github.com/users/cateyes99/received_events","type":"User","site_admin":false},"labels":[{"id":256129993,"url":"https://api.github.com/repos/Microsoft/vscode/labels/bug","name":"bug","color":"8D6673","default":true},{"id":296835379,"url":"https://api.github.com/repos/Microsoft/vscode/labels/git","name":"git","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars0.githubusercontent.com/u/22350?v=3","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"assignees":[{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars0.githubusercontent.com/u/22350?v=3","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/8","html_url":"https://github.com/Microsoft/vscode/milestone/8","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/8/labels","id":1412124,"number":8,"title":"Backlog","description":"Work not yet planned for a specific release.","creator":{"login":"chrisdias","id":1487073,"avatar_url":"https://avatars3.githubusercontent.com/u/1487073?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdias","html_url":"https://github.com/chrisdias","followers_url":"https://api.github.com/users/chrisdias/followers","following_url":"https://api.github.com/users/chrisdias/following{/other_user}","gists_url":"https://api.github.com/users/chrisdias/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdias/subscriptions","organizations_url":"https://api.github.com/users/chrisdias/orgs","repos_url":"https://api.github.com/users/chrisdias/repos","events_url":"https://api.github.com/users/chrisdias/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdias/received_events","type":"User","site_admin":false},"open_issues":2158,"closed_issues":1893,"state":"open","created_at":"2015-11-15T10:30:19Z","updated_at":"2017-05-09T10:26:13Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2017-05-08T05:04:30Z","updated_at":"2017-05-09T10:28:01Z","closed_at":null,"body":"<!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode -->\r\n\r\n- VSCode Version: 1.12.1\r\n- OS Version: OS X EI Capitan 10.11.3\r\n\r\nSteps to Reproduce:\r\n\r\n1. Open some project from GitHub.\r\n2. Make some changes to a file A.cs, and save it.\r\n\r\n3.a Stay on the editor of A.cs, and click the button of `Open Changes` on the top right corner above the editor.\r\n4.a A diff tab opened to show the difference between the changed A.cs and the version in GitHub. Before version 1.12, this diff tab will be open in the preview mode (the tab title font is in __*italic*__), now the new diff tab is just a normal tab.\r\n\r\n3.b Open the `Source Control` panel, click A.cs.\r\n4.b A diff tab opened to show the difference between the changed A.cs and the version in GitHub. Before version 1.12, this diff tab will be open in the preview mode (the tab title font is in __*italic*__), now the new diff tab is just a normal tab.\r\n\r\n5. If I have 50 files changed, and iterate the changes in the 50 files from `Source Control` panel, it will open 50 diff tabs for me! This new behaviour isn't very desired. The old behaviour in the previous versions is much more convenient and consistent with opening files from the `Explorer` panel."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/300124453","html_url":"https://github.com/Microsoft/vscode/issues/26184#issuecomment-300124453","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/26184","id":300124453,"user":{"login":"bpasero","id":900690,"avatar_url":"https://avatars0.githubusercontent.com/u/900690?v=3","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"created_at":"2017-05-09T10:28:01Z","updated_at":"2017-05-09T10:28:01Z","body":"I think the extension should not decide to set the preview flag unless really making sure that something does not open as preview (e.g. a usecase I can see is to open a playground to the side of the current editor that should not go away), otherwise the extension should not set the preview flag explicitly and let the workbench handle this. Otherwise settings like `\"workbench.editor.enablePreview\": false` are ignored, which is bad."}}
{"actor":{"display_login":"bpasero"}}