{"action":"created","issue":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/511","repository_url":"https://api.github.com/repos/ciena-frost/ember-frost-core","labels_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/511/comments","events_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/511/events","html_url":"https://github.com/ciena-frost/ember-frost-core/pull/511","id":270051062,"number":511,"title":"Make run loop aware adjustments","user":{"login":"EWhite613","id":9057680,"avatar_url":"https://avatars3.githubusercontent.com/u/9057680?v=4","gravatar_id":"","url":"https://api.github.com/users/EWhite613","html_url":"https://github.com/EWhite613","followers_url":"https://api.github.com/users/EWhite613/followers","following_url":"https://api.github.com/users/EWhite613/following{/other_user}","gists_url":"https://api.github.com/users/EWhite613/gists{/gist_id}","starred_url":"https://api.github.com/users/EWhite613/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EWhite613/subscriptions","organizations_url":"https://api.github.com/users/EWhite613/orgs","repos_url":"https://api.github.com/users/EWhite613/repos","events_url":"https://api.github.com/users/EWhite613/events{/privacy}","received_events_url":"https://api.github.com/users/EWhite613/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-31T17:36:30Z","updated_at":"2017-10-31T18:10:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-core/pulls/511","html_url":"https://github.com/ciena-frost/ember-frost-core/pull/511","diff_url":"https://github.com/ciena-frost/ember-frost-core/pull/511.diff","patch_url":"https://github.com/ciena-frost/ember-frost-core/pull/511.patch"},"body":"**This project uses [semver](http://semver.org), please check the scope of this pr:**\r\n\r\n- [ ] #none# - documentation fixes and/or test additions\r\n- [x] #patch# - backwards-compatible bug fix\r\n- [ ] #minor# - adding functionality in a backwards-compatible manner\r\n- [ ] #major# - incompatible API change\r\n\r\n# CHANGELOG\r\n\r\n* Fix frost-select-dropdown breaking in tests because `autorun loop is disabled`\r\n* Add pre-cautionary run-loop on frost-scroll onMouseEnter\r\n"},"comment":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/comments/340853018","html_url":"https://github.com/ciena-frost/ember-frost-core/pull/511#issuecomment-340853018","issue_url":"https://api.github.com/repos/ciena-frost/ember-frost-core/issues/511","id":340853018,"user":{"login":"EWhite613","id":9057680,"avatar_url":"https://avatars3.githubusercontent.com/u/9057680?v=4","gravatar_id":"","url":"https://api.github.com/users/EWhite613","html_url":"https://github.com/EWhite613","followers_url":"https://api.github.com/users/EWhite613/followers","following_url":"https://api.github.com/users/EWhite613/following{/other_user}","gists_url":"https://api.github.com/users/EWhite613/gists{/gist_id}","starred_url":"https://api.github.com/users/EWhite613/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EWhite613/subscriptions","organizations_url":"https://api.github.com/users/EWhite613/orgs","repos_url":"https://api.github.com/users/EWhite613/repos","events_url":"https://api.github.com/users/EWhite613/events{/privacy}","received_events_url":"https://api.github.com/users/EWhite613/received_events","type":"User","site_admin":false},"created_at":"2017-10-31T18:10:26Z","updated_at":"2017-10-31T18:10:26Z","author_association":"MEMBER","body":"@notmessenger I removed it based on your comment. Our consuming app doesn't make use of that callback, it just looked suspect ( I was thinking the same like @sophypal consumers could be doing things that required a run loop)\r\n\r\n> breaking in tests because autorun loop is disabled\r\nWas mainly directed at `frost-select-dropdown` because I could verify in our consuming app by disabling the autorun loop and running the same logic from our test cases (that cause `Error: Assertion Failed: You have turned on testing mode, which disabled the runloop's autorun. You will need to wrap any code with asynchronous side-effects in a run` ) that the async logic wasn't running in the Ember run loop based on the stack trace from the error. "}}
{"actor":{"display_login":"EWhite613"}}