{"action":"created","issue":{"url":"https://api.github.com/repos/LLNL/spack/issues/5950","repository_url":"https://api.github.com/repos/LLNL/spack","labels_url":"https://api.github.com/repos/LLNL/spack/issues/5950/labels{/name}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/5950/comments","events_url":"https://api.github.com/repos/LLNL/spack/issues/5950/events","html_url":"https://github.com/LLNL/spack/pull/5950","id":268454621,"number":5950,"title":"Colorize \"Installing pkg_name\"","user":{"login":"certik","id":20568,"avatar_url":"https://avatars3.githubusercontent.com/u/20568?v=4","gravatar_id":"","url":"https://api.github.com/users/certik","html_url":"https://github.com/certik","followers_url":"https://api.github.com/users/certik/followers","following_url":"https://api.github.com/users/certik/following{/other_user}","gists_url":"https://api.github.com/users/certik/gists{/gist_id}","starred_url":"https://api.github.com/users/certik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certik/subscriptions","organizations_url":"https://api.github.com/users/certik/orgs","repos_url":"https://api.github.com/users/certik/repos","events_url":"https://api.github.com/users/certik/events{/privacy}","received_events_url":"https://api.github.com/users/certik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-25T15:59:53Z","updated_at":"2017-10-25T20:16:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/5950","html_url":"https://github.com/LLNL/spack/pull/5950","diff_url":"https://github.com/LLNL/spack/pull/5950.diff","patch_url":"https://github.com/LLNL/spack/pull/5950.patch"},"body":"Now one can quickly visually see in the terminal which packages are installed\r\nand where each package begins and ends in the log.\r\n\r\nHere is how it looks like now:\r\n\r\n![terminal_colors](https://user-images.githubusercontent.com/20568/32008916-c92cb240-b96a-11e7-847d-672a4cbc8435.png)\r\n\r\nThe line\r\n```\r\n==> Installing openmpi\r\n```\r\nnow becomes redundant, but I left it there, since the colorized output is produced by a different mechanism than the `tty.message` output, and I don't know if you want to perhaps keep the `tty` output.\r\n\r\nI can also change the colors etc. But it's now much more usable to see what package is being built."},"comment":{"url":"https://api.github.com/repos/LLNL/spack/issues/comments/339457354","html_url":"https://github.com/LLNL/spack/pull/5950#issuecomment-339457354","issue_url":"https://api.github.com/repos/LLNL/spack/issues/5950","id":339457354,"user":{"login":"tgamblin","id":299842,"avatar_url":"https://avatars3.githubusercontent.com/u/299842?v=4","gravatar_id":"","url":"https://api.github.com/users/tgamblin","html_url":"https://github.com/tgamblin","followers_url":"https://api.github.com/users/tgamblin/followers","following_url":"https://api.github.com/users/tgamblin/following{/other_user}","gists_url":"https://api.github.com/users/tgamblin/gists{/gist_id}","starred_url":"https://api.github.com/users/tgamblin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgamblin/subscriptions","organizations_url":"https://api.github.com/users/tgamblin/orgs","repos_url":"https://api.github.com/users/tgamblin/repos","events_url":"https://api.github.com/users/tgamblin/events{/privacy}","received_events_url":"https://api.github.com/users/tgamblin/received_events","type":"User","site_admin":false},"created_at":"2017-10-25T20:16:27Z","updated_at":"2017-10-25T20:16:27Z","author_association":"OWNER","body":"Cool.  I like it.  I guess the only other question is whether you'd prefer what homebrew does:\r\n\r\n<img width=\"596\" alt=\"screen shot 2017-10-25 at 9 42 18 pm\" src=\"https://user-images.githubusercontent.com/299842/32020780-917fdbe4-b9d1-11e7-92e2-49cadfa1631b.png\">\r\n\r\nThey use \"bright white\" on dark terminals, but seem to automatically use bold black on white terminals:\r\n\r\n<img width=\"749\" alt=\"screen shot 2017-10-25 at 10 13 51 pm\" src=\"https://user-images.githubusercontent.com/299842/32020839-d1bd52ae-b9d1-11e7-93d4-9765ee9949f4.png\">\r\n\r\nNot sure how to get that to detect and fail over gracefully.  The bright colors need to be specified directly, as brightness isn't a separate modifier like bold.  So we'd either need to know from somewhere what the user's background looks like, or there is some part of ANSI color that I am missing.\r\n\r\nI think the scheme you've already got should look nice on both dark and light terminals, though it is on my list for someday to make the colors more customizable."}}
{"actor":{"display_login":"tgamblin"}}