{"action":"created","comment":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/158432668","pull_request_review_id":85243903,"id":158432668,"diff_hunk":"@@ -266,6 +260,22 @@ export default {\n       const first = range.find(v => this.isAllowed(type, v))\n \n       return first || value\n+    },\n+    currentPeriod (val) {\n+      if (val && !(val instanceof Date)) {\n+        return val.match(/pm/i) ? 'pm' : 'am'\n+      }\n+\n+      let value = new Date()\n+      if (val instanceof Date) {\n+        value = val","path":"src/components/VTimePicker/VTimePicker.js","position":59,"original_position":59,"commit_id":"c38c922d80b4f5c5e705acd4d965f918da4c9eb7","original_commit_id":"c38c922d80b4f5c5e705acd4d965f918da4c9eb7","user":{"login":"KaelWD","id":16421948,"avatar_url":"https://avatars2.githubusercontent.com/u/16421948?v=4","gravatar_id":"","url":"https://api.github.com/users/KaelWD","html_url":"https://github.com/KaelWD","followers_url":"https://api.github.com/users/KaelWD/followers","following_url":"https://api.github.com/users/KaelWD/following{/other_user}","gists_url":"https://api.github.com/users/KaelWD/gists{/gist_id}","starred_url":"https://api.github.com/users/KaelWD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaelWD/subscriptions","organizations_url":"https://api.github.com/users/KaelWD/orgs","repos_url":"https://api.github.com/users/KaelWD/repos","events_url":"https://api.github.com/users/KaelWD/events{/privacy}","received_events_url":"https://api.github.com/users/KaelWD/received_events","type":"User","site_admin":false},"body":"Don't create a new instance if you're just going to throw it away on the next line","created_at":"2017-12-22T05:49:06Z","updated_at":"2017-12-22T05:49:06Z","html_url":"https://github.com/vuetifyjs/vuetify/pull/2856#discussion_r158432668","pull_request_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2856","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/158432668"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/2856#discussion_r158432668"},"pull_request":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2856"}}},"pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2856","id":159802552,"html_url":"https://github.com/vuetifyjs/vuetify/pull/2856","diff_url":"https://github.com/vuetifyjs/vuetify/pull/2856.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/2856.patch","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/2856","number":2856,"state":"open","locked":false,"title":"fix(v-time-picker): Component breaks when `pm` is selected","user":{"login":"hikaruworld","id":1309468,"avatar_url":"https://avatars0.githubusercontent.com/u/1309468?v=4","gravatar_id":"","url":"https://api.github.com/users/hikaruworld","html_url":"https://github.com/hikaruworld","followers_url":"https://api.github.com/users/hikaruworld/followers","following_url":"https://api.github.com/users/hikaruworld/following{/other_user}","gists_url":"https://api.github.com/users/hikaruworld/gists{/gist_id}","starred_url":"https://api.github.com/users/hikaruworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hikaruworld/subscriptions","organizations_url":"https://api.github.com/users/hikaruworld/orgs","repos_url":"https://api.github.com/users/hikaruworld/repos","events_url":"https://api.github.com/users/hikaruworld/events{/privacy}","received_events_url":"https://api.github.com/users/hikaruworld/received_events","type":"User","site_admin":false},"body":"fixes #2855\r\n\r\n`period` and `inputTime#get` infinite loop when select `pm`.\r\n`inputTime#get` avoided resetting `this.period`\r\n\r\n\r\n","created_at":"2017-12-22T05:28:04Z","updated_at":"2017-12-22T05:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39541d5ded038998273925f1da15c6b1e87c47cb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2856/commits","review_comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2856/comments","review_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/2856/comments","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/c38c922d80b4f5c5e705acd4d965f918da4c9eb7","head":{"label":"hikaruworld:issue/time-picker-change-pm-broken","ref":"issue/time-picker-change-pm-broken","sha":"c38c922d80b4f5c5e705acd4d965f918da4c9eb7","user":{"login":"hikaruworld","id":1309468,"avatar_url":"https://avatars0.githubusercontent.com/u/1309468?v=4","gravatar_id":"","url":"https://api.github.com/users/hikaruworld","html_url":"https://github.com/hikaruworld","followers_url":"https://api.github.com/users/hikaruworld/followers","following_url":"https://api.github.com/users/hikaruworld/following{/other_user}","gists_url":"https://api.github.com/users/hikaruworld/gists{/gist_id}","starred_url":"https://api.github.com/users/hikaruworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hikaruworld/subscriptions","organizations_url":"https://api.github.com/users/hikaruworld/orgs","repos_url":"https://api.github.com/users/hikaruworld/repos","events_url":"https://api.github.com/users/hikaruworld/events{/privacy}","received_events_url":"https://api.github.com/users/hikaruworld/received_events","type":"User","site_admin":false},"repo":{"id":115059530,"name":"vuetify","full_name":"hikaruworld/vuetify","owner":{"login":"hikaruworld","id":1309468,"avatar_url":"https://avatars0.githubusercontent.com/u/1309468?v=4","gravatar_id":"","url":"https://api.github.com/users/hikaruworld","html_url":"https://github.com/hikaruworld","followers_url":"https://api.github.com/users/hikaruworld/followers","following_url":"https://api.github.com/users/hikaruworld/following{/other_user}","gists_url":"https://api.github.com/users/hikaruworld/gists{/gist_id}","starred_url":"https://api.github.com/users/hikaruworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hikaruworld/subscriptions","organizations_url":"https://api.github.com/users/hikaruworld/orgs","repos_url":"https://api.github.com/users/hikaruworld/repos","events_url":"https://api.github.com/users/hikaruworld/events{/privacy}","received_events_url":"https://api.github.com/users/hikaruworld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hikaruworld/vuetify","description":"Material Component Framework for Vue.js 2","fork":true,"url":"https://api.github.com/repos/hikaruworld/vuetify","forks_url":"https://api.github.com/repos/hikaruworld/vuetify/forks","keys_url":"https://api.github.com/repos/hikaruworld/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hikaruworld/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hikaruworld/vuetify/teams","hooks_url":"https://api.github.com/repos/hikaruworld/vuetify/hooks","issue_events_url":"https://api.github.com/repos/hikaruworld/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/hikaruworld/vuetify/events","assignees_url":"https://api.github.com/repos/hikaruworld/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/hikaruworld/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/hikaruworld/vuetify/tags","blobs_url":"https://api.github.com/repos/hikaruworld/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hikaruworld/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hikaruworld/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/hikaruworld/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hikaruworld/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/hikaruworld/vuetify/languages","stargazers_url":"https://api.github.com/repos/hikaruworld/vuetify/stargazers","contributors_url":"https://api.github.com/repos/hikaruworld/vuetify/contributors","subscribers_url":"https://api.github.com/repos/hikaruworld/vuetify/subscribers","subscription_url":"https://api.github.com/repos/hikaruworld/vuetify/subscription","commits_url":"https://api.github.com/repos/hikaruworld/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/hikaruworld/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/hikaruworld/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/hikaruworld/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/hikaruworld/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/hikaruworld/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hikaruworld/vuetify/merges","archive_url":"https://api.github.com/repos/hikaruworld/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hikaruworld/vuetify/downloads","issues_url":"https://api.github.com/repos/hikaruworld/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/hikaruworld/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/hikaruworld/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/hikaruworld/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hikaruworld/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/hikaruworld/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/hikaruworld/vuetify/deployments","created_at":"2017-12-22T00:35:55Z","updated_at":"2017-12-22T00:35:58Z","pushed_at":"2017-12-22T04:49:30Z","git_url":"git://github.com/hikaruworld/vuetify.git","ssh_url":"git@github.com:hikaruworld/vuetify.git","clone_url":"https://github.com/hikaruworld/vuetify.git","svn_url":"https://github.com/hikaruworld/vuetify","homepage":"https://vuetifyjs.com","size":11510,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"vuetifyjs:master","ref":"master","sha":"d6b13514e6d5899a6e26ea5006fb29b2f019ee1c","user":{"login":"vuetifyjs","id":22138497,"avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"name":"vuetify","full_name":"vuetifyjs/vuetify","owner":{"login":"vuetifyjs","id":22138497,"avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vuetifyjs/vuetify","description":"Material Component Framework for Vue.js 2","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2017-12-22T04:14:37Z","pushed_at":"2017-12-22T05:28:05Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":11512,"stargazers_count":7225,"watchers_count":7225,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":585,"mirror_url":null,"archived":false,"open_issues_count":215,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":585,"open_issues":215,"watchers":7225,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2856"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/2856"},"issue":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/2856"},"comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/2856/comments"},"review_comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2856/comments"},"review_comment":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2856/commits"},"statuses":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/c38c922d80b4f5c5e705acd4d965f918da4c9eb7"}},"author_association":"NONE"}}
{"actor":{"display_login":"KaelWD"}}