{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/comments/109381265","pull_request_review_id":30477318,"id":109381265,"diff_hunk":"@@ -437,7 +437,7 @@ def pack(self, img_seq=None):\n             doc.build(PDFTransformer.get_elements(survey, self.response))\n \n             # Create page images from PDF\n-            img_tfr = ImageTransformer(self.log, survey, self.response)\n+            img_tfr = ImageTransformer(self.log, survey, self.response, self.ids.seq_nr)","path":"transform/transformers/MWSSTransformer.py","position":5,"original_position":5,"commit_id":"43f3d6eec9b7cc7d076ba3aee8d52e2a5cb21268","original_commit_id":"43f3d6eec9b7cc7d076ba3aee8d52e2a5cb21268","user":{"login":"JamesGardiner","id":9960163,"avatar_url":"https://avatars0.githubusercontent.com/u/9960163?v=3","gravatar_id":"","url":"https://api.github.com/users/JamesGardiner","html_url":"https://github.com/JamesGardiner","followers_url":"https://api.github.com/users/JamesGardiner/followers","following_url":"https://api.github.com/users/JamesGardiner/following{/other_user}","gists_url":"https://api.github.com/users/JamesGardiner/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesGardiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesGardiner/subscriptions","organizations_url":"https://api.github.com/users/JamesGardiner/orgs","repos_url":"https://api.github.com/users/JamesGardiner/repos","events_url":"https://api.github.com/users/JamesGardiner/events{/privacy}","received_events_url":"https://api.github.com/users/JamesGardiner/received_events","type":"User","site_admin":false},"body":"Happy to approve once we show that defaulting to 0 in `seq_nr` doesn't cause further issues downstream via unit tests","created_at":"2017-04-03T10:12:14Z","updated_at":"2017-04-03T10:13:02Z","html_url":"https://github.com/ONSdigital/sdx-transform-cs/pull/63#discussion_r109381265","pull_request_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/comments/109381265"},"html":{"href":"https://github.com/ONSdigital/sdx-transform-cs/pull/63#discussion_r109381265"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/63","id":113648835,"html_url":"https://github.com/ONSdigital/sdx-transform-cs/pull/63","diff_url":"https://github.com/ONSdigital/sdx-transform-cs/pull/63.diff","patch_url":"https://github.com/ONSdigital/sdx-transform-cs/pull/63.patch","issue_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues/63","number":63,"state":"open","locked":false,"title":"Feature/fix sequence number defaulting in image receipt","user":{"login":"tundish","id":4272886,"avatar_url":"https://avatars1.githubusercontent.com/u/4272886?v=3","gravatar_id":"","url":"https://api.github.com/users/tundish","html_url":"https://github.com/tundish","followers_url":"https://api.github.com/users/tundish/followers","following_url":"https://api.github.com/users/tundish/following{/other_user}","gists_url":"https://api.github.com/users/tundish/gists{/gist_id}","starred_url":"https://api.github.com/users/tundish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tundish/subscriptions","organizations_url":"https://api.github.com/users/tundish/orgs","repos_url":"https://api.github.com/users/tundish/repos","events_url":"https://api.github.com/users/tundish/events{/privacy}","received_events_url":"https://api.github.com/users/tundish/received_events","type":"User","site_admin":false},"body":"This fixes the following issue seen in MWSS survey:\r\nImage receipt files (names of the form EDC_134_YYYYMMDD_XXXX.csv where XXXX is a sequence number) were being created with sequence number stuck at 1000.\r\n\r\nThis was because MWSSTransformer failed to pass the sequence number to ImageTransformer.\r\nImageTransformer defaults to 1000.","created_at":"2017-03-31T13:25:01Z","updated_at":"2017-04-03T10:13:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fc09d106711c52362a330063a027f74934827c8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/63/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/63/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues/63/comments","statuses_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/statuses/43f3d6eec9b7cc7d076ba3aee8d52e2a5cb21268","head":{"label":"ONSdigital:feature/fix_sequence_number_defaulting_in_image_receipt","ref":"feature/fix_sequence_number_defaulting_in_image_receipt","sha":"43f3d6eec9b7cc7d076ba3aee8d52e2a5cb21268","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars3.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":59762598,"name":"sdx-transform-cs","full_name":"ONSdigital/sdx-transform-cs","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars3.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/sdx-transform-cs","description":null,"fork":false,"url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs","forks_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/forks","keys_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/teams","hooks_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/events","assignees_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/tags","blobs_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/subscription","commits_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/merges","archive_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/downloads","issues_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/deployments","created_at":"2016-05-26T15:41:26Z","updated_at":"2016-12-12T16:32:56Z","pushed_at":"2017-03-31T13:25:01Z","git_url":"git://github.com/ONSdigital/sdx-transform-cs.git","ssh_url":"git@github.com:ONSdigital/sdx-transform-cs.git","clone_url":"https://github.com/ONSdigital/sdx-transform-cs.git","svn_url":"https://github.com/ONSdigital/sdx-transform-cs","homepage":null,"size":267,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"ONSdigital:develop","ref":"develop","sha":"0a936f37ca80e80a350697d80d08260eb42c2420","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars3.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":59762598,"name":"sdx-transform-cs","full_name":"ONSdigital/sdx-transform-cs","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars3.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/sdx-transform-cs","description":null,"fork":false,"url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs","forks_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/forks","keys_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/teams","hooks_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/events","assignees_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/tags","blobs_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/subscription","commits_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/merges","archive_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/downloads","issues_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/deployments","created_at":"2016-05-26T15:41:26Z","updated_at":"2016-12-12T16:32:56Z","pushed_at":"2017-03-31T13:25:01Z","git_url":"git://github.com/ONSdigital/sdx-transform-cs.git","ssh_url":"git@github.com:ONSdigital/sdx-transform-cs.git","clone_url":"https://github.com/ONSdigital/sdx-transform-cs.git","svn_url":"https://github.com/ONSdigital/sdx-transform-cs","homepage":null,"size":267,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/63"},"html":{"href":"https://github.com/ONSdigital/sdx-transform-cs/pull/63"},"issue":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues/63"},"comments":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/sdx-transform-cs/statuses/43f3d6eec9b7cc7d076ba3aee8d52e2a5cb21268"}}}}
{"actor":{"display_login":"JamesGardiner"}}