{"action":"created","comment":{"url":"https://api.github.com/repos/graknlabs/grakn/pulls/comments/152953934","pull_request_review_id":78892871,"id":152953934,"diff_hunk":"@@ -1,145 +0,0 @@\n-/*\n- * Grakn - A Distributed Semantic Database\n- * Copyright (C) 2016  Grakn Labs Limited\n- *\n- * Grakn is free software: you can redistribute it and/or modify\n- * it under the terms of the GNU General Public License as published by\n- * the Free Software Foundation, either version 3 of the License, or\n- * (at your option) any later version.\n- *\n- * Grakn is distributed in the hope that it will be useful,\n- * but WITHOUT ANY WARRANTY; without even the implied warranty of\n- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n- * GNU General Public License for more details.\n- *\n- * You should have received a copy of the GNU General Public License\n- * along with Grakn. If not, see <http://www.gnu.org/licenses/gpl.txt>.\n- */\n-\n-package ai.grakn.graql.internal.printer;\n-\n-import ai.grakn.concept.Attribute;\n-import ai.grakn.concept.AttributeType;\n-import ai.grakn.concept.ConceptId;\n-import ai.grakn.concept.Rule;\n-import ai.grakn.graql.Printer;\n-import ai.grakn.test.rule.SampleKBContext;\n-import ai.grakn.test.kbs.MovieKB;\n-import ai.grakn.util.Schema;\n-import com.google.common.collect.ImmutableList;\n-import com.google.common.collect.ImmutableMap;\n-import com.google.common.collect.Lists;\n-import mjson.Json;\n-import org.junit.Before;\n-import org.junit.ClassRule;\n-import org.junit.Test;\n-\n-import java.util.HashMap;\n-import java.util.Map;\n-import java.util.Optional;\n-\n-import static org.junit.Assert.assertEquals;\n-\n-public class JsonPrinterTest {","path":"grakn-graql/src/test/java/ai/grakn/graql/internal/printer/JsonPrinterTest.java","position":43,"original_position":43,"commit_id":"3ae072b6a30f121d97484d07c6ac8b39bb6ad651","original_commit_id":"ddf2720deb244d3f4e1cfce70ae82ff3b34f22f2","user":{"login":"aelred","id":4632588,"avatar_url":"https://avatars1.githubusercontent.com/u/4632588?v=4","gravatar_id":"","url":"https://api.github.com/users/aelred","html_url":"https://github.com/aelred","followers_url":"https://api.github.com/users/aelred/followers","following_url":"https://api.github.com/users/aelred/following{/other_user}","gists_url":"https://api.github.com/users/aelred/gists{/gist_id}","starred_url":"https://api.github.com/users/aelred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aelred/subscriptions","organizations_url":"https://api.github.com/users/aelred/orgs","repos_url":"https://api.github.com/users/aelred/repos","events_url":"https://api.github.com/users/aelred/events{/privacy}","received_events_url":"https://api.github.com/users/aelred/received_events","type":"User","site_admin":false},"body":"This class still exists! If we delete the test, we should delete `JsonPrinter` too.","created_at":"2017-11-24T11:53:54Z","updated_at":"2017-11-24T11:54:04Z","html_url":"https://github.com/graknlabs/grakn/pull/2420#discussion_r152953934","pull_request_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2420","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/comments/152953934"},"html":{"href":"https://github.com/graknlabs/grakn/pull/2420#discussion_r152953934"},"pull_request":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2420"}}},"pull_request":{"url":"https://api.github.com/repos/graknlabs/grakn/pulls/2420","id":154427766,"html_url":"https://github.com/graknlabs/grakn/pull/2420","diff_url":"https://github.com/graknlabs/grakn/pull/2420.diff","patch_url":"https://github.com/graknlabs/grakn/pull/2420.patch","issue_url":"https://api.github.com/repos/graknlabs/grakn/issues/2420","number":2420,"state":"open","locked":false,"title":"Change GraqlControllerResponse to Jackson Objects","user":{"login":"fppt","id":4279814,"avatar_url":"https://avatars0.githubusercontent.com/u/4279814?v=4","gravatar_id":"","url":"https://api.github.com/users/fppt","html_url":"https://github.com/fppt","followers_url":"https://api.github.com/users/fppt/followers","following_url":"https://api.github.com/users/fppt/following{/other_user}","gists_url":"https://api.github.com/users/fppt/gists{/gist_id}","starred_url":"https://api.github.com/users/fppt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fppt/subscriptions","organizations_url":"https://api.github.com/users/fppt/orgs","repos_url":"https://api.github.com/users/fppt/repos","events_url":"https://api.github.com/users/fppt/events{/privacy}","received_events_url":"https://api.github.com/users/fppt/received_events","type":"User","site_admin":false},"body":"This is very high impact and will break dashboard for sure. ","created_at":"2017-11-23T17:43:35Z","updated_at":"2017-11-24T11:54:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"017bfe5cb27d4a0904bb13653e769eada517a37a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2420/commits","review_comments_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2420/comments","review_comment_url":"https://api.github.com/repos/graknlabs/grakn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graknlabs/grakn/issues/2420/comments","statuses_url":"https://api.github.com/repos/graknlabs/grakn/statuses/3ae072b6a30f121d97484d07c6ac8b39bb6ad651","head":{"label":"fppt:more-jacksonising-part-4","ref":"more-jacksonising-part-4","sha":"3ae072b6a30f121d97484d07c6ac8b39bb6ad651","user":{"login":"fppt","id":4279814,"avatar_url":"https://avatars0.githubusercontent.com/u/4279814?v=4","gravatar_id":"","url":"https://api.github.com/users/fppt","html_url":"https://github.com/fppt","followers_url":"https://api.github.com/users/fppt/followers","following_url":"https://api.github.com/users/fppt/following{/other_user}","gists_url":"https://api.github.com/users/fppt/gists{/gist_id}","starred_url":"https://api.github.com/users/fppt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fppt/subscriptions","organizations_url":"https://api.github.com/users/fppt/orgs","repos_url":"https://api.github.com/users/fppt/repos","events_url":"https://api.github.com/users/fppt/events{/privacy}","received_events_url":"https://api.github.com/users/fppt/received_events","type":"User","site_admin":false},"repo":{"id":65722027,"name":"grakn","full_name":"fppt/grakn","owner":{"login":"fppt","id":4279814,"avatar_url":"https://avatars0.githubusercontent.com/u/4279814?v=4","gravatar_id":"","url":"https://api.github.com/users/fppt","html_url":"https://github.com/fppt","followers_url":"https://api.github.com/users/fppt/followers","following_url":"https://api.github.com/users/fppt/following{/other_user}","gists_url":"https://api.github.com/users/fppt/gists{/gist_id}","starred_url":"https://api.github.com/users/fppt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fppt/subscriptions","organizations_url":"https://api.github.com/users/fppt/orgs","repos_url":"https://api.github.com/users/fppt/repos","events_url":"https://api.github.com/users/fppt/events{/privacy}","received_events_url":"https://api.github.com/users/fppt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fppt/grakn","description":"A Knowledge Graph Platform","fork":true,"url":"https://api.github.com/repos/fppt/grakn","forks_url":"https://api.github.com/repos/fppt/grakn/forks","keys_url":"https://api.github.com/repos/fppt/grakn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fppt/grakn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fppt/grakn/teams","hooks_url":"https://api.github.com/repos/fppt/grakn/hooks","issue_events_url":"https://api.github.com/repos/fppt/grakn/issues/events{/number}","events_url":"https://api.github.com/repos/fppt/grakn/events","assignees_url":"https://api.github.com/repos/fppt/grakn/assignees{/user}","branches_url":"https://api.github.com/repos/fppt/grakn/branches{/branch}","tags_url":"https://api.github.com/repos/fppt/grakn/tags","blobs_url":"https://api.github.com/repos/fppt/grakn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fppt/grakn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fppt/grakn/git/refs{/sha}","trees_url":"https://api.github.com/repos/fppt/grakn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fppt/grakn/statuses/{sha}","languages_url":"https://api.github.com/repos/fppt/grakn/languages","stargazers_url":"https://api.github.com/repos/fppt/grakn/stargazers","contributors_url":"https://api.github.com/repos/fppt/grakn/contributors","subscribers_url":"https://api.github.com/repos/fppt/grakn/subscribers","subscription_url":"https://api.github.com/repos/fppt/grakn/subscription","commits_url":"https://api.github.com/repos/fppt/grakn/commits{/sha}","git_commits_url":"https://api.github.com/repos/fppt/grakn/git/commits{/sha}","comments_url":"https://api.github.com/repos/fppt/grakn/comments{/number}","issue_comment_url":"https://api.github.com/repos/fppt/grakn/issues/comments{/number}","contents_url":"https://api.github.com/repos/fppt/grakn/contents/{+path}","compare_url":"https://api.github.com/repos/fppt/grakn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fppt/grakn/merges","archive_url":"https://api.github.com/repos/fppt/grakn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fppt/grakn/downloads","issues_url":"https://api.github.com/repos/fppt/grakn/issues{/number}","pulls_url":"https://api.github.com/repos/fppt/grakn/pulls{/number}","milestones_url":"https://api.github.com/repos/fppt/grakn/milestones{/number}","notifications_url":"https://api.github.com/repos/fppt/grakn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fppt/grakn/labels{/name}","releases_url":"https://api.github.com/repos/fppt/grakn/releases{/id}","deployments_url":"https://api.github.com/repos/fppt/grakn/deployments","created_at":"2016-08-15T09:47:35Z","updated_at":"2016-11-30T07:02:41Z","pushed_at":"2017-11-24T11:37:29Z","git_url":"git://github.com/fppt/grakn.git","ssh_url":"git@github.com:fppt/grakn.git","clone_url":"https://github.com/fppt/grakn.git","svn_url":"https://github.com/fppt/grakn","homepage":"https://grakn.ai","size":42251,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graknlabs:master","ref":"master","sha":"0a8035ad26bbf2baa78813167116e62c4f604961","user":{"login":"graknlabs","id":10490615,"avatar_url":"https://avatars1.githubusercontent.com/u/10490615?v=4","gravatar_id":"","url":"https://api.github.com/users/graknlabs","html_url":"https://github.com/graknlabs","followers_url":"https://api.github.com/users/graknlabs/followers","following_url":"https://api.github.com/users/graknlabs/following{/other_user}","gists_url":"https://api.github.com/users/graknlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/graknlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graknlabs/subscriptions","organizations_url":"https://api.github.com/users/graknlabs/orgs","repos_url":"https://api.github.com/users/graknlabs/repos","events_url":"https://api.github.com/users/graknlabs/events{/privacy}","received_events_url":"https://api.github.com/users/graknlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63110867,"name":"grakn","full_name":"graknlabs/grakn","owner":{"login":"graknlabs","id":10490615,"avatar_url":"https://avatars1.githubusercontent.com/u/10490615?v=4","gravatar_id":"","url":"https://api.github.com/users/graknlabs","html_url":"https://github.com/graknlabs","followers_url":"https://api.github.com/users/graknlabs/followers","following_url":"https://api.github.com/users/graknlabs/following{/other_user}","gists_url":"https://api.github.com/users/graknlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/graknlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graknlabs/subscriptions","organizations_url":"https://api.github.com/users/graknlabs/orgs","repos_url":"https://api.github.com/users/graknlabs/repos","events_url":"https://api.github.com/users/graknlabs/events{/privacy}","received_events_url":"https://api.github.com/users/graknlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graknlabs/grakn","description":"A Hyper-Relational Database for Knowledge-Oriented System","fork":false,"url":"https://api.github.com/repos/graknlabs/grakn","forks_url":"https://api.github.com/repos/graknlabs/grakn/forks","keys_url":"https://api.github.com/repos/graknlabs/grakn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graknlabs/grakn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graknlabs/grakn/teams","hooks_url":"https://api.github.com/repos/graknlabs/grakn/hooks","issue_events_url":"https://api.github.com/repos/graknlabs/grakn/issues/events{/number}","events_url":"https://api.github.com/repos/graknlabs/grakn/events","assignees_url":"https://api.github.com/repos/graknlabs/grakn/assignees{/user}","branches_url":"https://api.github.com/repos/graknlabs/grakn/branches{/branch}","tags_url":"https://api.github.com/repos/graknlabs/grakn/tags","blobs_url":"https://api.github.com/repos/graknlabs/grakn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graknlabs/grakn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graknlabs/grakn/git/refs{/sha}","trees_url":"https://api.github.com/repos/graknlabs/grakn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graknlabs/grakn/statuses/{sha}","languages_url":"https://api.github.com/repos/graknlabs/grakn/languages","stargazers_url":"https://api.github.com/repos/graknlabs/grakn/stargazers","contributors_url":"https://api.github.com/repos/graknlabs/grakn/contributors","subscribers_url":"https://api.github.com/repos/graknlabs/grakn/subscribers","subscription_url":"https://api.github.com/repos/graknlabs/grakn/subscription","commits_url":"https://api.github.com/repos/graknlabs/grakn/commits{/sha}","git_commits_url":"https://api.github.com/repos/graknlabs/grakn/git/commits{/sha}","comments_url":"https://api.github.com/repos/graknlabs/grakn/comments{/number}","issue_comment_url":"https://api.github.com/repos/graknlabs/grakn/issues/comments{/number}","contents_url":"https://api.github.com/repos/graknlabs/grakn/contents/{+path}","compare_url":"https://api.github.com/repos/graknlabs/grakn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graknlabs/grakn/merges","archive_url":"https://api.github.com/repos/graknlabs/grakn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graknlabs/grakn/downloads","issues_url":"https://api.github.com/repos/graknlabs/grakn/issues{/number}","pulls_url":"https://api.github.com/repos/graknlabs/grakn/pulls{/number}","milestones_url":"https://api.github.com/repos/graknlabs/grakn/milestones{/number}","notifications_url":"https://api.github.com/repos/graknlabs/grakn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graknlabs/grakn/labels{/name}","releases_url":"https://api.github.com/repos/graknlabs/grakn/releases{/id}","deployments_url":"https://api.github.com/repos/graknlabs/grakn/deployments","created_at":"2016-07-11T23:59:57Z","updated_at":"2017-11-23T15:55:46Z","pushed_at":"2017-11-24T11:52:24Z","git_url":"git://github.com/graknlabs/grakn.git","ssh_url":"git@github.com:graknlabs/grakn.git","clone_url":"https://github.com/graknlabs/grakn.git","svn_url":"https://github.com/graknlabs/grakn","homepage":"https://grakn.ai","size":41799,"stargazers_count":674,"watchers_count":674,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":96,"mirror_url":null,"archived":false,"open_issues_count":35,"forks":96,"open_issues":35,"watchers":674,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2420"},"html":{"href":"https://github.com/graknlabs/grakn/pull/2420"},"issue":{"href":"https://api.github.com/repos/graknlabs/grakn/issues/2420"},"comments":{"href":"https://api.github.com/repos/graknlabs/grakn/issues/2420/comments"},"review_comments":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2420/comments"},"review_comment":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2420/commits"},"statuses":{"href":"https://api.github.com/repos/graknlabs/grakn/statuses/3ae072b6a30f121d97484d07c6ac8b39bb6ad651"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aelred"}}