{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/comments/109007909","pull_request_review_id":30081300,"id":109007909,"diff_hunk":"@@ -118,3 +118,30 @@ Gateway_CreateFromJson creates a new gateway using information contained within\n **SRS_GATEWAY_JSON_17_002: [** This function shall return `NULL` if starting the gateway fails. **]**\n \n **SRS_GATEWAY_JSON_14_008: [** This function shall return `NULL` upon any memory allocation failure. **]**\n+\n+\n+## Gateway_UpdateFromJson\n+```\n+extern int Gateway_UpdateFromJson(GATEWAY_HANDLE gw, const char* json_content);\n+```\n+Gateway_UpdateFromJson adds loades, modules or links based on a well-formed JSON configuration content.\n+\n+**SRS_GATEWAY_JSON_04_003: [** If `json_content` is NULL the function shall return NULL. **]**\n+\n+**SRS_GATEWAY_JSON_04_004: [** If `gw` is NULL the function shall return NULL.\n+ **]**\n+\n+**SRS_GATEWAY_JSON_04_005: [** The function shall use *parson* to parse the JSON string to a *parson* `JSON_Value` structure. **]**","path":"core/devdoc/gateway_createfromjson_requirements.md","position":26,"original_position":26,"commit_id":"3b2ad7dcc5c0a12a9f4bff836169252be7afc8fd","original_commit_id":"3b2ad7dcc5c0a12a9f4bff836169252be7afc8fd","user":{"login":"aribeironovaes","id":9369967,"avatar_url":"https://avatars1.githubusercontent.com/u/9369967?v=3","gravatar_id":"","url":"https://api.github.com/users/aribeironovaes","html_url":"https://github.com/aribeironovaes","followers_url":"https://api.github.com/users/aribeironovaes/followers","following_url":"https://api.github.com/users/aribeironovaes/following{/other_user}","gists_url":"https://api.github.com/users/aribeironovaes/gists{/gist_id}","starred_url":"https://api.github.com/users/aribeironovaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aribeironovaes/subscriptions","organizations_url":"https://api.github.com/users/aribeironovaes/orgs","repos_url":"https://api.github.com/users/aribeironovaes/repos","events_url":"https://api.github.com/users/aribeironovaes/events{/privacy}","received_events_url":"https://api.github.com/users/aribeironovaes/received_events","type":"User","site_admin":false},"body":"Yep, we don't have to. But I'm mimic the requirement from Create from Json method.\r\n\r\n---\r\nIn reply to: [108959959](https://github.com/Azure/azure-iot-gateway-sdk/pull/189#discussion_r108959959) [](ancestors = 108959959)","created_at":"2017-03-30T18:52:00Z","updated_at":"2017-03-30T18:52:00Z","html_url":"https://github.com/Azure/azure-iot-gateway-sdk/pull/189#discussion_r109007909","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/comments/109007909"},"html":{"href":"https://github.com/Azure/azure-iot-gateway-sdk/pull/189#discussion_r109007909"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/189","id":113100967,"html_url":"https://github.com/Azure/azure-iot-gateway-sdk/pull/189","diff_url":"https://github.com/Azure/azure-iot-gateway-sdk/pull/189.diff","patch_url":"https://github.com/Azure/azure-iot-gateway-sdk/pull/189.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/issues/189","number":189,"state":"open","locked":false,"title":"New configure gateway from jsonapi","user":{"login":"aribeironovaes","id":9369967,"avatar_url":"https://avatars1.githubusercontent.com/u/9369967?v=3","gravatar_id":"","url":"https://api.github.com/users/aribeironovaes","html_url":"https://github.com/aribeironovaes","followers_url":"https://api.github.com/users/aribeironovaes/followers","following_url":"https://api.github.com/users/aribeironovaes/following{/other_user}","gists_url":"https://api.github.com/users/aribeironovaes/gists{/gist_id}","starred_url":"https://api.github.com/users/aribeironovaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aribeironovaes/subscriptions","organizations_url":"https://api.github.com/users/aribeironovaes/orgs","repos_url":"https://api.github.com/users/aribeironovaes/repos","events_url":"https://api.github.com/users/aribeironovaes/events{/privacy}","received_events_url":"https://api.github.com/users/aribeironovaes/received_events","type":"User","site_admin":false},"body":"Commits will be property SQUASHED. ","created_at":"2017-03-29T01:29:55Z","updated_at":"2017-03-30T18:52:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3e249636b025781366678ec492ed8bd79c275ce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/189/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/189/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/issues/189/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/statuses/3b2ad7dcc5c0a12a9f4bff836169252be7afc8fd","head":{"label":"aribeironovaes:newConfigureGatewayFromJSONAPI","ref":"newConfigureGatewayFromJSONAPI","sha":"3b2ad7dcc5c0a12a9f4bff836169252be7afc8fd","user":{"login":"aribeironovaes","id":9369967,"avatar_url":"https://avatars1.githubusercontent.com/u/9369967?v=3","gravatar_id":"","url":"https://api.github.com/users/aribeironovaes","html_url":"https://github.com/aribeironovaes","followers_url":"https://api.github.com/users/aribeironovaes/followers","following_url":"https://api.github.com/users/aribeironovaes/following{/other_user}","gists_url":"https://api.github.com/users/aribeironovaes/gists{/gist_id}","starred_url":"https://api.github.com/users/aribeironovaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aribeironovaes/subscriptions","organizations_url":"https://api.github.com/users/aribeironovaes/orgs","repos_url":"https://api.github.com/users/aribeironovaes/repos","events_url":"https://api.github.com/users/aribeironovaes/events{/privacy}","received_events_url":"https://api.github.com/users/aribeironovaes/received_events","type":"User","site_admin":false},"repo":{"id":59329640,"name":"azure-iot-gateway-sdk","full_name":"aribeironovaes/azure-iot-gateway-sdk","owner":{"login":"aribeironovaes","id":9369967,"avatar_url":"https://avatars1.githubusercontent.com/u/9369967?v=3","gravatar_id":"","url":"https://api.github.com/users/aribeironovaes","html_url":"https://github.com/aribeironovaes","followers_url":"https://api.github.com/users/aribeironovaes/followers","following_url":"https://api.github.com/users/aribeironovaes/following{/other_user}","gists_url":"https://api.github.com/users/aribeironovaes/gists{/gist_id}","starred_url":"https://api.github.com/users/aribeironovaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aribeironovaes/subscriptions","organizations_url":"https://api.github.com/users/aribeironovaes/orgs","repos_url":"https://api.github.com/users/aribeironovaes/repos","events_url":"https://api.github.com/users/aribeironovaes/events{/privacy}","received_events_url":"https://api.github.com/users/aribeironovaes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aribeironovaes/azure-iot-gateway-sdk","description":"Azure IoT Gateway SDK","fork":true,"url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk","forks_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/forks","keys_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/teams","hooks_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/hooks","issue_events_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/events","assignees_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/tags","blobs_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/languages","stargazers_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/stargazers","contributors_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/contributors","subscribers_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/subscribers","subscription_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/subscription","commits_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/merges","archive_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/downloads","issues_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aribeironovaes/azure-iot-gateway-sdk/deployments","created_at":"2016-05-20T22:17:09Z","updated_at":"2017-01-12T00:55:58Z","pushed_at":"2017-03-29T01:27:59Z","git_url":"git://github.com/aribeironovaes/azure-iot-gateway-sdk.git","ssh_url":"git@github.com:aribeironovaes/azure-iot-gateway-sdk.git","clone_url":"https://github.com/aribeironovaes/azure-iot-gateway-sdk.git","svn_url":"https://github.com/aribeironovaes/azure-iot-gateway-sdk","homepage":"http://azure.github.io/azure-iot-gateway-sdk/","size":7325,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:newConfigureGatewayFromJSONAPI","ref":"newConfigureGatewayFromJSONAPI","sha":"4bf63184a4d8dff88570ab22d8ec6e61ef565dc5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":56637079,"name":"azure-iot-gateway-sdk","full_name":"Azure/azure-iot-gateway-sdk","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-iot-gateway-sdk","description":"Azure IoT Gateway SDK","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk","forks_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/deployments","created_at":"2016-04-19T22:35:41Z","updated_at":"2017-03-30T15:31:13Z","pushed_at":"2017-03-30T14:53:55Z","git_url":"git://github.com/Azure/azure-iot-gateway-sdk.git","ssh_url":"git@github.com:Azure/azure-iot-gateway-sdk.git","clone_url":"https://github.com/Azure/azure-iot-gateway-sdk.git","svn_url":"https://github.com/Azure/azure-iot-gateway-sdk","homepage":"http://azure.github.io/azure-iot-gateway-sdk/","size":8251,"stargazers_count":115,"watchers_count":115,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":95,"mirror_url":null,"open_issues_count":16,"forks":95,"open_issues":16,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/189"},"html":{"href":"https://github.com/Azure/azure-iot-gateway-sdk/pull/189"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/issues/189"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-gateway-sdk/statuses/3b2ad7dcc5c0a12a9f4bff836169252be7afc8fd"}}}}
{"actor":{"display_login":"aribeironovaes"}}