{"action":"created","issue":{"url":"https://api.github.com/repos/twitter/heron/issues/1839","repository_url":"https://api.github.com/repos/twitter/heron","labels_url":"https://api.github.com/repos/twitter/heron/issues/1839/labels{/name}","comments_url":"https://api.github.com/repos/twitter/heron/issues/1839/comments","events_url":"https://api.github.com/repos/twitter/heron/issues/1839/events","html_url":"https://github.com/twitter/heron/pull/1839","id":226490276,"number":1839,"title":"Fail Heron-instance fast for errors","user":{"login":"maosongfu","id":3028698,"avatar_url":"https://avatars1.githubusercontent.com/u/3028698?v=3","gravatar_id":"","url":"https://api.github.com/users/maosongfu","html_url":"https://github.com/maosongfu","followers_url":"https://api.github.com/users/maosongfu/followers","following_url":"https://api.github.com/users/maosongfu/following{/other_user}","gists_url":"https://api.github.com/users/maosongfu/gists{/gist_id}","starred_url":"https://api.github.com/users/maosongfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maosongfu/subscriptions","organizations_url":"https://api.github.com/users/maosongfu/orgs","repos_url":"https://api.github.com/users/maosongfu/repos","events_url":"https://api.github.com/users/maosongfu/events{/privacy}","received_events_url":"https://api.github.com/users/maosongfu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-05T07:06:01Z","updated_at":"2017-05-05T16:54:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/1839","html_url":"https://github.com/twitter/heron/pull/1839","diff_url":"https://github.com/twitter/heron/pull/1839.diff","patch_url":"https://github.com/twitter/heron/pull/1839.patch"},"body":"Currently heron-instance will try best-effort to clean the resources,\r\nwhen uncaught exceptions happen. However, if it meets an error, for instance,\r\n\"java.lang.OutOfMemoryError: Java heap space\", any consequent operations are not guaranteed to be done,\r\nand it can lead the process to a bad state, for instance, hanging forever.\r\n\r\nThis pull request fixes it by making heron-instance fail fast for errors. And this issue is raised by ADs team from Twitter.\r\n\r\nTested with LocalScheduler."},"comment":{"url":"https://api.github.com/repos/twitter/heron/issues/comments/299518156","html_url":"https://github.com/twitter/heron/pull/1839#issuecomment-299518156","issue_url":"https://api.github.com/repos/twitter/heron/issues/1839","id":299518156,"user":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars3.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"created_at":"2017-05-05T16:54:56Z","updated_at":"2017-05-05T16:54:56Z","body":"Shall we also update comments [here](https://github.com/twitter/heron/pull/1839/files#diff-cf2b0320c00a0fc85f039efe83786ecfR215)?"}}
{"actor":{"display_login":"objmagic"}}