{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/9182","repository_url":"https://api.github.com/repos/mozilla/pdf.js","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9182/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9182/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9182/events","html_url":"https://github.com/mozilla/pdf.js/pull/9182","id":276366646,"number":9182,"title":"Don't display error messages, in the default viewer, for PDF files other than the current one","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars0.githubusercontent.com/u/2692120?v=4","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"labels":[{"id":164429,"url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-viewer","name":"1-viewer","color":"DDDDDD","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-23T13:01:12Z","updated_at":"2017-11-23T20:59:11Z","closed_at":"2017-11-23T20:58:33Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9182","html_url":"https://github.com/mozilla/pdf.js/pull/9182","diff_url":"https://github.com/mozilla/pdf.js/pull/9182.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/9182.patch"},"body":"We've never attempted to limit the errors displayed in the default viewer to the current PDF file, but that's not really been a problem before. However after PR #7926, it's now possible to get password related error messages for *previously* opened PDF files in the default viewer.\r\n\r\n**STR:**\r\n 1. Open a password protected PDF file, e.g. `issue6010_1.pdf` from the test-suite.\r\n 2. Cancel the password prompt.\r\n 3. Open any new PDF file in the viewer.\r\n\r\n**AR:**\r\nThe error UI is displayed, with a `No password given` message.\r\n\r\n**ER:**\r\nNo error displayed, since it's only relevent for a now closed PDF file.\r\n\r\nThis is obviously a minor issue, caused by us now rejecting the still pending `pdfLoadingTask` during the `PDFViewerApplication.close` call, but I don't think that it (generally) makes sense to show errors if they're not relevant to the *currently* displayed PDF file."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/346696658","html_url":"https://github.com/mozilla/pdf.js/pull/9182#issuecomment-346696658","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9182","id":346696658,"user":{"login":"timvandermeij","id":1993262,"avatar_url":"https://avatars1.githubusercontent.com/u/1993262?v=4","gravatar_id":"","url":"https://api.github.com/users/timvandermeij","html_url":"https://github.com/timvandermeij","followers_url":"https://api.github.com/users/timvandermeij/followers","following_url":"https://api.github.com/users/timvandermeij/following{/other_user}","gists_url":"https://api.github.com/users/timvandermeij/gists{/gist_id}","starred_url":"https://api.github.com/users/timvandermeij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvandermeij/subscriptions","organizations_url":"https://api.github.com/users/timvandermeij/orgs","repos_url":"https://api.github.com/users/timvandermeij/repos","events_url":"https://api.github.com/users/timvandermeij/events{/privacy}","received_events_url":"https://api.github.com/users/timvandermeij/received_events","type":"User","site_admin":false},"created_at":"2017-11-23T20:59:11Z","updated_at":"2017-11-23T20:59:11Z","author_association":"CONTRIBUTOR","body":"Thank you! I think I noticed this before, but couldn't find a way to reproduce; nice that you managed to do so."}}
{"actor":{"display_login":"timvandermeij"}}