{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/omi/pulls/comments/98807658","pull_request_review_id":19461934,"id":98807658,"diff_hunk":"@@ -36,6 +36,7 @@\n #define HTTPRECVTRACEFILE LOGDIR \"/omiserver-recv.trc\"\n #define HTTPCLIENTSENDTRACEFILE LOGDIR \"/omiclient-send.trc\"\n #define HTTPCLIENTRECVTRACEFILE LOGDIR \"/omiclient-recv.trc\"\n+#define NTLMCREDSFILE CONFIG_CREDSDIR \"/ntlm\"","path":"Unix/base/paths.c","position":4,"original_position":4,"commit_id":"c139105fb0426e9bed4e979584a1ec16a145b224","original_commit_id":"c139105fb0426e9bed4e979584a1ec16a145b224","user":{"login":"jeffaco","id":13700943,"avatar_url":"https://avatars.githubusercontent.com/u/13700943?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffaco","html_url":"https://github.com/jeffaco","followers_url":"https://api.github.com/users/jeffaco/followers","following_url":"https://api.github.com/users/jeffaco/following{/other_user}","gists_url":"https://api.github.com/users/jeffaco/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffaco/subscriptions","organizations_url":"https://api.github.com/users/jeffaco/orgs","repos_url":"https://api.github.com/users/jeffaco/repos","events_url":"https://api.github.com/users/jeffaco/events{/privacy}","received_events_url":"https://api.github.com/users/jeffaco/received_events","type":"User","site_admin":false},"body":"According to Paul, he would like the location of this file read from omiserver.conf. Talk to him and bring closure to this issue please.","created_at":"2017-02-01T00:47:11Z","updated_at":"2017-02-01T00:51:37Z","html_url":"https://github.com/Microsoft/omi/pull/216#discussion_r98807658","pull_request_url":"https://api.github.com/repos/Microsoft/omi/pulls/216","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/omi/pulls/comments/98807658"},"html":{"href":"https://github.com/Microsoft/omi/pull/216#discussion_r98807658"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/omi/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/omi/pulls/216","id":104053195,"html_url":"https://github.com/Microsoft/omi/pull/216","diff_url":"https://github.com/Microsoft/omi/pull/216.diff","patch_url":"https://github.com/Microsoft/omi/pull/216.patch","issue_url":"https://api.github.com/repos/Microsoft/omi/issues/216","number":216,"state":"open","locked":false,"title":"Create NTLM cred file control in omiserver","user":{"login":"yakman2020","id":13686849,"avatar_url":"https://avatars.githubusercontent.com/u/13686849?v=3","gravatar_id":"","url":"https://api.github.com/users/yakman2020","html_url":"https://github.com/yakman2020","followers_url":"https://api.github.com/users/yakman2020/followers","following_url":"https://api.github.com/users/yakman2020/following{/other_user}","gists_url":"https://api.github.com/users/yakman2020/gists{/gist_id}","starred_url":"https://api.github.com/users/yakman2020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yakman2020/subscriptions","organizations_url":"https://api.github.com/users/yakman2020/orgs","repos_url":"https://api.github.com/users/yakman2020/repos","events_url":"https://api.github.com/users/yakman2020/events{/privacy}","received_events_url":"https://api.github.com/users/yakman2020/received_events","type":"User","site_admin":false},"body":"@Microsoft/omi-devs \r\n\r\nElminates the need  for  the NTLM_USER_FILE env var.\r\nIgnores NTLM_USER_FILE if set","created_at":"2017-02-01T00:28:23Z","updated_at":"2017-02-01T00:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5606f9df62602048d3c471dddaccc182d50d5b87","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/omi/pulls/216/commits","review_comments_url":"https://api.github.com/repos/Microsoft/omi/pulls/216/comments","review_comment_url":"https://api.github.com/repos/Microsoft/omi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/omi/issues/216/comments","statuses_url":"https://api.github.com/repos/Microsoft/omi/statuses/c139105fb0426e9bed4e979584a1ec16a145b224","head":{"label":"Microsoft:v-brucc/server-auth-file","ref":"v-brucc/server-auth-file","sha":"c139105fb0426e9bed4e979584a1ec16a145b224","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":46681501,"name":"omi","full_name":"Microsoft/omi","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/omi","description":"Open Management Infrastructure","fork":false,"url":"https://api.github.com/repos/Microsoft/omi","forks_url":"https://api.github.com/repos/Microsoft/omi/forks","keys_url":"https://api.github.com/repos/Microsoft/omi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/omi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/omi/teams","hooks_url":"https://api.github.com/repos/Microsoft/omi/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/omi/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/omi/events","assignees_url":"https://api.github.com/repos/Microsoft/omi/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/omi/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/omi/tags","blobs_url":"https://api.github.com/repos/Microsoft/omi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/omi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/omi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/omi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/omi/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/omi/languages","stargazers_url":"https://api.github.com/repos/Microsoft/omi/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/omi/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/omi/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/omi/subscription","commits_url":"https://api.github.com/repos/Microsoft/omi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/omi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/omi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/omi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/omi/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/omi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/omi/merges","archive_url":"https://api.github.com/repos/Microsoft/omi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/omi/downloads","issues_url":"https://api.github.com/repos/Microsoft/omi/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/omi/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/omi/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/omi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/omi/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/omi/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/omi/deployments","created_at":"2015-11-22T21:39:24Z","updated_at":"2017-01-22T12:40:31Z","pushed_at":"2017-02-01T00:29:12Z","git_url":"git://github.com/Microsoft/omi.git","ssh_url":"git@github.com:Microsoft/omi.git","clone_url":"https://github.com/Microsoft/omi.git","svn_url":"https://github.com/Microsoft/omi","homepage":null,"size":22199,"stargazers_count":67,"watchers_count":67,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":67,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"f0890ffb3f62be23e1abe5d4848ec5853aba59cb","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":46681501,"name":"omi","full_name":"Microsoft/omi","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/omi","description":"Open Management Infrastructure","fork":false,"url":"https://api.github.com/repos/Microsoft/omi","forks_url":"https://api.github.com/repos/Microsoft/omi/forks","keys_url":"https://api.github.com/repos/Microsoft/omi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/omi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/omi/teams","hooks_url":"https://api.github.com/repos/Microsoft/omi/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/omi/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/omi/events","assignees_url":"https://api.github.com/repos/Microsoft/omi/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/omi/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/omi/tags","blobs_url":"https://api.github.com/repos/Microsoft/omi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/omi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/omi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/omi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/omi/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/omi/languages","stargazers_url":"https://api.github.com/repos/Microsoft/omi/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/omi/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/omi/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/omi/subscription","commits_url":"https://api.github.com/repos/Microsoft/omi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/omi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/omi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/omi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/omi/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/omi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/omi/merges","archive_url":"https://api.github.com/repos/Microsoft/omi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/omi/downloads","issues_url":"https://api.github.com/repos/Microsoft/omi/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/omi/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/omi/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/omi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/omi/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/omi/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/omi/deployments","created_at":"2015-11-22T21:39:24Z","updated_at":"2017-01-22T12:40:31Z","pushed_at":"2017-02-01T00:29:12Z","git_url":"git://github.com/Microsoft/omi.git","ssh_url":"git@github.com:Microsoft/omi.git","clone_url":"https://github.com/Microsoft/omi.git","svn_url":"https://github.com/Microsoft/omi","homepage":null,"size":22199,"stargazers_count":67,"watchers_count":67,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/omi/pulls/216"},"html":{"href":"https://github.com/Microsoft/omi/pull/216"},"issue":{"href":"https://api.github.com/repos/Microsoft/omi/issues/216"},"comments":{"href":"https://api.github.com/repos/Microsoft/omi/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/omi/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/omi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/omi/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/omi/statuses/c139105fb0426e9bed4e979584a1ec16a145b224"}}}}
{"actor":{"display_login":"jeffaco"}}