{"action":"created","comment":{"url":"https://api.github.com/repos/onivim/oni/pulls/comments/150980372","pull_request_review_id":76614729,"id":150980372,"diff_hunk":"@@ -27,7 +28,8 @@ const mergeSpawnOptions = (originalSpawnOptions: ChildProcess.ExecOptions | Chil\n         },\n     }\n \n-    const existingPath = process.env.Path || process.env.PATH\n+    const shellEnvironment = shellEnv.sync()","path":"browser/src/Plugins/Api/Process.ts","position":null,"original_position":11,"commit_id":"1e42b0eea4b4d4c8084cd6f3854af76d2da1f986","original_commit_id":"629ebdd49bad66de99057a6ebe63043fee19bfaf","user":{"login":"Akin909","id":22454918,"avatar_url":"https://avatars2.githubusercontent.com/u/22454918?v=4","gravatar_id":"","url":"https://api.github.com/users/Akin909","html_url":"https://github.com/Akin909","followers_url":"https://api.github.com/users/Akin909/followers","following_url":"https://api.github.com/users/Akin909/following{/other_user}","gists_url":"https://api.github.com/users/Akin909/gists{/gist_id}","starred_url":"https://api.github.com/users/Akin909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akin909/subscriptions","organizations_url":"https://api.github.com/users/Akin909/orgs","repos_url":"https://api.github.com/users/Akin909/repos","events_url":"https://api.github.com/users/Akin909/events{/privacy}","received_events_url":"https://api.github.com/users/Akin909/received_events","type":"User","site_admin":false},"body":"I opted for option one here and used async await and added returned promise typings up to the call sites hopefully this doesn't clash with #938 ","created_at":"2017-11-14T22:16:06Z","updated_at":"2017-11-14T22:16:07Z","html_url":"https://github.com/onivim/oni/pull/934#discussion_r150980372","pull_request_url":"https://api.github.com/repos/onivim/oni/pulls/934","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/onivim/oni/pulls/comments/150980372"},"html":{"href":"https://github.com/onivim/oni/pull/934#discussion_r150980372"},"pull_request":{"href":"https://api.github.com/repos/onivim/oni/pulls/934"}},"in_reply_to_id":150909555},"pull_request":{"url":"https://api.github.com/repos/onivim/oni/pulls/934","id":152364922,"html_url":"https://github.com/onivim/oni/pull/934","diff_url":"https://github.com/onivim/oni/pull/934.diff","patch_url":"https://github.com/onivim/oni/pull/934.patch","issue_url":"https://api.github.com/repos/onivim/oni/issues/934","number":934,"state":"open","locked":false,"title":"Feature/incorporate shell env package","user":{"login":"Akin909","id":22454918,"avatar_url":"https://avatars2.githubusercontent.com/u/22454918?v=4","gravatar_id":"","url":"https://api.github.com/users/Akin909","html_url":"https://github.com/Akin909","followers_url":"https://api.github.com/users/Akin909/followers","following_url":"https://api.github.com/users/Akin909/following{/other_user}","gists_url":"https://api.github.com/users/Akin909/gists{/gist_id}","starred_url":"https://api.github.com/users/Akin909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akin909/subscriptions","organizations_url":"https://api.github.com/users/Akin909/orgs","repos_url":"https://api.github.com/users/Akin909/repos","events_url":"https://api.github.com/users/Akin909/events{/privacy}","received_events_url":"https://api.github.com/users/Akin909/received_events","type":"User","site_admin":false},"body":"I had another go adding `shell-env` I previously tried `shell-path` a similar more focused module with no success. I haven't added explicit error handling as from the source code the fn only throw an error if it's passed an incorrect argument (I havent passed it any in which case it always returns a string)\r\n\r\nShell env on the other hand seems to be working, It required a few dependencies which I added. I also added a `shell-env.d.ts` as it required typings though I haven't fleshed this out  (wasn't entirely sure how).","created_at":"2017-11-13T22:28:32Z","updated_at":"2017-11-14T22:16:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85a494202f0e18b532bbb1e2e5d00014f2c8739d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/onivim/oni/pulls/934/commits","review_comments_url":"https://api.github.com/repos/onivim/oni/pulls/934/comments","review_comment_url":"https://api.github.com/repos/onivim/oni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onivim/oni/issues/934/comments","statuses_url":"https://api.github.com/repos/onivim/oni/statuses/1e42b0eea4b4d4c8084cd6f3854af76d2da1f986","head":{"label":"Akin909:feature/incorporate-shell-env-package","ref":"feature/incorporate-shell-env-package","sha":"1e42b0eea4b4d4c8084cd6f3854af76d2da1f986","user":{"login":"Akin909","id":22454918,"avatar_url":"https://avatars2.githubusercontent.com/u/22454918?v=4","gravatar_id":"","url":"https://api.github.com/users/Akin909","html_url":"https://github.com/Akin909","followers_url":"https://api.github.com/users/Akin909/followers","following_url":"https://api.github.com/users/Akin909/following{/other_user}","gists_url":"https://api.github.com/users/Akin909/gists{/gist_id}","starred_url":"https://api.github.com/users/Akin909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akin909/subscriptions","organizations_url":"https://api.github.com/users/Akin909/orgs","repos_url":"https://api.github.com/users/Akin909/repos","events_url":"https://api.github.com/users/Akin909/events{/privacy}","received_events_url":"https://api.github.com/users/Akin909/received_events","type":"User","site_admin":false},"repo":{"id":110439908,"name":"oni","full_name":"Akin909/oni","owner":{"login":"Akin909","id":22454918,"avatar_url":"https://avatars2.githubusercontent.com/u/22454918?v=4","gravatar_id":"","url":"https://api.github.com/users/Akin909","html_url":"https://github.com/Akin909","followers_url":"https://api.github.com/users/Akin909/followers","following_url":"https://api.github.com/users/Akin909/following{/other_user}","gists_url":"https://api.github.com/users/Akin909/gists{/gist_id}","starred_url":"https://api.github.com/users/Akin909/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akin909/subscriptions","organizations_url":"https://api.github.com/users/Akin909/orgs","repos_url":"https://api.github.com/users/Akin909/repos","events_url":"https://api.github.com/users/Akin909/events{/privacy}","received_events_url":"https://api.github.com/users/Akin909/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Akin909/oni","description":"Oni: An IDE powered by Neovim","fork":true,"url":"https://api.github.com/repos/Akin909/oni","forks_url":"https://api.github.com/repos/Akin909/oni/forks","keys_url":"https://api.github.com/repos/Akin909/oni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Akin909/oni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Akin909/oni/teams","hooks_url":"https://api.github.com/repos/Akin909/oni/hooks","issue_events_url":"https://api.github.com/repos/Akin909/oni/issues/events{/number}","events_url":"https://api.github.com/repos/Akin909/oni/events","assignees_url":"https://api.github.com/repos/Akin909/oni/assignees{/user}","branches_url":"https://api.github.com/repos/Akin909/oni/branches{/branch}","tags_url":"https://api.github.com/repos/Akin909/oni/tags","blobs_url":"https://api.github.com/repos/Akin909/oni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Akin909/oni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Akin909/oni/git/refs{/sha}","trees_url":"https://api.github.com/repos/Akin909/oni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Akin909/oni/statuses/{sha}","languages_url":"https://api.github.com/repos/Akin909/oni/languages","stargazers_url":"https://api.github.com/repos/Akin909/oni/stargazers","contributors_url":"https://api.github.com/repos/Akin909/oni/contributors","subscribers_url":"https://api.github.com/repos/Akin909/oni/subscribers","subscription_url":"https://api.github.com/repos/Akin909/oni/subscription","commits_url":"https://api.github.com/repos/Akin909/oni/commits{/sha}","git_commits_url":"https://api.github.com/repos/Akin909/oni/git/commits{/sha}","comments_url":"https://api.github.com/repos/Akin909/oni/comments{/number}","issue_comment_url":"https://api.github.com/repos/Akin909/oni/issues/comments{/number}","contents_url":"https://api.github.com/repos/Akin909/oni/contents/{+path}","compare_url":"https://api.github.com/repos/Akin909/oni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Akin909/oni/merges","archive_url":"https://api.github.com/repos/Akin909/oni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Akin909/oni/downloads","issues_url":"https://api.github.com/repos/Akin909/oni/issues{/number}","pulls_url":"https://api.github.com/repos/Akin909/oni/pulls{/number}","milestones_url":"https://api.github.com/repos/Akin909/oni/milestones{/number}","notifications_url":"https://api.github.com/repos/Akin909/oni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Akin909/oni/labels{/name}","releases_url":"https://api.github.com/repos/Akin909/oni/releases{/id}","deployments_url":"https://api.github.com/repos/Akin909/oni/deployments","created_at":"2017-11-12T14:37:46Z","updated_at":"2017-11-12T14:37:49Z","pushed_at":"2017-11-14T22:13:39Z","git_url":"git://github.com/Akin909/oni.git","ssh_url":"git@github.com:Akin909/oni.git","clone_url":"https://github.com/Akin909/oni.git","svn_url":"https://github.com/Akin909/oni","homepage":"http://onivim.io","size":33479,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onivim:master","ref":"master","sha":"27feb67aeb17f2d604fc6af4c82b4651d8a9f024","user":{"login":"onivim","id":31161891,"avatar_url":"https://avatars1.githubusercontent.com/u/31161891?v=4","gravatar_id":"","url":"https://api.github.com/users/onivim","html_url":"https://github.com/onivim","followers_url":"https://api.github.com/users/onivim/followers","following_url":"https://api.github.com/users/onivim/following{/other_user}","gists_url":"https://api.github.com/users/onivim/gists{/gist_id}","starred_url":"https://api.github.com/users/onivim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onivim/subscriptions","organizations_url":"https://api.github.com/users/onivim/orgs","repos_url":"https://api.github.com/users/onivim/repos","events_url":"https://api.github.com/users/onivim/events{/privacy}","received_events_url":"https://api.github.com/users/onivim/received_events","type":"Organization","site_admin":false},"repo":{"id":73929422,"name":"oni","full_name":"onivim/oni","owner":{"login":"onivim","id":31161891,"avatar_url":"https://avatars1.githubusercontent.com/u/31161891?v=4","gravatar_id":"","url":"https://api.github.com/users/onivim","html_url":"https://github.com/onivim","followers_url":"https://api.github.com/users/onivim/followers","following_url":"https://api.github.com/users/onivim/following{/other_user}","gists_url":"https://api.github.com/users/onivim/gists{/gist_id}","starred_url":"https://api.github.com/users/onivim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onivim/subscriptions","organizations_url":"https://api.github.com/users/onivim/orgs","repos_url":"https://api.github.com/users/onivim/repos","events_url":"https://api.github.com/users/onivim/events{/privacy}","received_events_url":"https://api.github.com/users/onivim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onivim/oni","description":"Oni: An IDE powered by Neovim","fork":false,"url":"https://api.github.com/repos/onivim/oni","forks_url":"https://api.github.com/repos/onivim/oni/forks","keys_url":"https://api.github.com/repos/onivim/oni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onivim/oni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onivim/oni/teams","hooks_url":"https://api.github.com/repos/onivim/oni/hooks","issue_events_url":"https://api.github.com/repos/onivim/oni/issues/events{/number}","events_url":"https://api.github.com/repos/onivim/oni/events","assignees_url":"https://api.github.com/repos/onivim/oni/assignees{/user}","branches_url":"https://api.github.com/repos/onivim/oni/branches{/branch}","tags_url":"https://api.github.com/repos/onivim/oni/tags","blobs_url":"https://api.github.com/repos/onivim/oni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onivim/oni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onivim/oni/git/refs{/sha}","trees_url":"https://api.github.com/repos/onivim/oni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onivim/oni/statuses/{sha}","languages_url":"https://api.github.com/repos/onivim/oni/languages","stargazers_url":"https://api.github.com/repos/onivim/oni/stargazers","contributors_url":"https://api.github.com/repos/onivim/oni/contributors","subscribers_url":"https://api.github.com/repos/onivim/oni/subscribers","subscription_url":"https://api.github.com/repos/onivim/oni/subscription","commits_url":"https://api.github.com/repos/onivim/oni/commits{/sha}","git_commits_url":"https://api.github.com/repos/onivim/oni/git/commits{/sha}","comments_url":"https://api.github.com/repos/onivim/oni/comments{/number}","issue_comment_url":"https://api.github.com/repos/onivim/oni/issues/comments{/number}","contents_url":"https://api.github.com/repos/onivim/oni/contents/{+path}","compare_url":"https://api.github.com/repos/onivim/oni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onivim/oni/merges","archive_url":"https://api.github.com/repos/onivim/oni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onivim/oni/downloads","issues_url":"https://api.github.com/repos/onivim/oni/issues{/number}","pulls_url":"https://api.github.com/repos/onivim/oni/pulls{/number}","milestones_url":"https://api.github.com/repos/onivim/oni/milestones{/number}","notifications_url":"https://api.github.com/repos/onivim/oni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onivim/oni/labels{/name}","releases_url":"https://api.github.com/repos/onivim/oni/releases{/id}","deployments_url":"https://api.github.com/repos/onivim/oni/deployments","created_at":"2016-11-16T14:42:55Z","updated_at":"2017-11-14T21:57:53Z","pushed_at":"2017-11-14T22:13:41Z","git_url":"git://github.com/onivim/oni.git","ssh_url":"git@github.com:onivim/oni.git","clone_url":"https://github.com/onivim/oni.git","svn_url":"https://github.com/onivim/oni","homepage":"http://onivim.io","size":33512,"stargazers_count":4052,"watchers_count":4052,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":139,"forks":115,"open_issues":139,"watchers":4052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onivim/oni/pulls/934"},"html":{"href":"https://github.com/onivim/oni/pull/934"},"issue":{"href":"https://api.github.com/repos/onivim/oni/issues/934"},"comments":{"href":"https://api.github.com/repos/onivim/oni/issues/934/comments"},"review_comments":{"href":"https://api.github.com/repos/onivim/oni/pulls/934/comments"},"review_comment":{"href":"https://api.github.com/repos/onivim/oni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onivim/oni/pulls/934/commits"},"statuses":{"href":"https://api.github.com/repos/onivim/oni/statuses/1e42b0eea4b4d4c8084cd6f3854af76d2da1f986"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Akin909"}}