{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/156802562","pull_request_review_id":83339316,"id":156802562,"diff_hunk":"@@ -0,0 +1,53 @@\n+// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using System.Text;\n+\n+#if IS_DESKTOP\n+using System.Security.Cryptography.Pkcs;\n+#endif\n+\n+namespace NuGet.Packaging.Signing\n+{\n+    public sealed class Timestamp\n+    {\n+#if IS_DESKTOP\n+\n+        /// <summary>\n+        /// Upper limit of Timestamp.\n+        /// </summary>\n+        public DateTimeOffset UpperLimit { get; }\n+\n+        /// <summary>\n+        /// Lower limit of Timestamp.\n+        /// </summary>\n+        public DateTimeOffset LowerLimit { get; }\n+\n+        /// <summary>\n+        /// Time timestamp was created by the Time Stamp Authority.\n+        /// </summary>\n+        public DateTimeOffset GeneralizedTime { get; }","path":"src/NuGet.Core/NuGet.Packaging/Signing/Timestamp/Timestamp.cs","position":31,"original_position":31,"commit_id":"ec4cbc9316a66dc78da6d2b8351f672df4eafcf8","original_commit_id":"ec4cbc9316a66dc78da6d2b8351f672df4eafcf8","user":{"login":"PatoBeltran","id":2132567,"avatar_url":"https://avatars2.githubusercontent.com/u/2132567?v=4","gravatar_id":"","url":"https://api.github.com/users/PatoBeltran","html_url":"https://github.com/PatoBeltran","followers_url":"https://api.github.com/users/PatoBeltran/followers","following_url":"https://api.github.com/users/PatoBeltran/following{/other_user}","gists_url":"https://api.github.com/users/PatoBeltran/gists{/gist_id}","starred_url":"https://api.github.com/users/PatoBeltran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatoBeltran/subscriptions","organizations_url":"https://api.github.com/users/PatoBeltran/orgs","repos_url":"https://api.github.com/users/PatoBeltran/repos","events_url":"https://api.github.com/users/PatoBeltran/events{/privacy}","received_events_url":"https://api.github.com/users/PatoBeltran/received_events","type":"User","site_admin":false},"body":"This is never set in the constructor ","created_at":"2017-12-13T22:18:44Z","updated_at":"2017-12-13T22:18:44Z","html_url":"https://github.com/NuGet/NuGet.Client/pull/1861#discussion_r156802562","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1861","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/156802562"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/1861#discussion_r156802562"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1861"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1861","id":157395365,"html_url":"https://github.com/NuGet/NuGet.Client/pull/1861","diff_url":"https://github.com/NuGet/NuGet.Client/pull/1861.diff","patch_url":"https://github.com/NuGet/NuGet.Client/pull/1861.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/1861","number":1861,"state":"open","locked":false,"title":"Return signature timestamp","user":{"login":"onovotny","id":1427284,"avatar_url":"https://avatars2.githubusercontent.com/u/1427284?v=4","gravatar_id":"","url":"https://api.github.com/users/onovotny","html_url":"https://github.com/onovotny","followers_url":"https://api.github.com/users/onovotny/followers","following_url":"https://api.github.com/users/onovotny/following{/other_user}","gists_url":"https://api.github.com/users/onovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/onovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onovotny/subscriptions","organizations_url":"https://api.github.com/users/onovotny/orgs","repos_url":"https://api.github.com/users/onovotny/repos","events_url":"https://api.github.com/users/onovotny/events{/privacy}","received_events_url":"https://api.github.com/users/onovotny/received_events","type":"User","site_admin":false},"body":"## Bug\r\nFixes: https://github.com/NuGet/Home/issues/6294\r\nRegression: Yes/No  \r\nIf Regression then when did it last work:   \r\nIf Regression then how are we preventing it in future:   \r\n\r\n## Fix\r\nDetails: Return the timestamp in the signature\r\n\r\n## Testing/Validation\r\nTests Added: Yes/No  \r\nReason for not adding tests:  \r\nValidation done:  \r\n\r\n/cc @dtivel @rido-min @PatoBeltran ","created_at":"2017-12-09T17:13:33Z","updated_at":"2017-12-13T22:18:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f23434ee6868b117dc16edbc40591b7d5fd482a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1861/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1861/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/1861/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/ec4cbc9316a66dc78da6d2b8351f672df4eafcf8","head":{"label":"onovotny:timestamp-in-sig","ref":"timestamp-in-sig","sha":"ec4cbc9316a66dc78da6d2b8351f672df4eafcf8","user":{"login":"onovotny","id":1427284,"avatar_url":"https://avatars2.githubusercontent.com/u/1427284?v=4","gravatar_id":"","url":"https://api.github.com/users/onovotny","html_url":"https://github.com/onovotny","followers_url":"https://api.github.com/users/onovotny/followers","following_url":"https://api.github.com/users/onovotny/following{/other_user}","gists_url":"https://api.github.com/users/onovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/onovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onovotny/subscriptions","organizations_url":"https://api.github.com/users/onovotny/orgs","repos_url":"https://api.github.com/users/onovotny/repos","events_url":"https://api.github.com/users/onovotny/events{/privacy}","received_events_url":"https://api.github.com/users/onovotny/received_events","type":"User","site_admin":false},"repo":{"id":50244675,"name":"NuGet.Client","full_name":"onovotny/NuGet.Client","owner":{"login":"onovotny","id":1427284,"avatar_url":"https://avatars2.githubusercontent.com/u/1427284?v=4","gravatar_id":"","url":"https://api.github.com/users/onovotny","html_url":"https://github.com/onovotny","followers_url":"https://api.github.com/users/onovotny/followers","following_url":"https://api.github.com/users/onovotny/following{/other_user}","gists_url":"https://api.github.com/users/onovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/onovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onovotny/subscriptions","organizations_url":"https://api.github.com/users/onovotny/orgs","repos_url":"https://api.github.com/users/onovotny/repos","events_url":"https://api.github.com/users/onovotny/events{/privacy}","received_events_url":"https://api.github.com/users/onovotny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/onovotny/NuGet.Client","description":"Core client libraries for NuGet Services","fork":true,"url":"https://api.github.com/repos/onovotny/NuGet.Client","forks_url":"https://api.github.com/repos/onovotny/NuGet.Client/forks","keys_url":"https://api.github.com/repos/onovotny/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onovotny/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onovotny/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/onovotny/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/onovotny/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/onovotny/NuGet.Client/events","assignees_url":"https://api.github.com/repos/onovotny/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/onovotny/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/onovotny/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/onovotny/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onovotny/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onovotny/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/onovotny/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onovotny/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/onovotny/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/onovotny/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/onovotny/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/onovotny/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/onovotny/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/onovotny/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/onovotny/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/onovotny/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/onovotny/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/onovotny/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/onovotny/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onovotny/NuGet.Client/merges","archive_url":"https://api.github.com/repos/onovotny/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onovotny/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/onovotny/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/onovotny/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/onovotny/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/onovotny/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onovotny/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/onovotny/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/onovotny/NuGet.Client/deployments","created_at":"2016-01-23T15:38:03Z","updated_at":"2016-01-23T15:38:13Z","pushed_at":"2017-12-12T03:36:23Z","git_url":"git://github.com/onovotny/NuGet.Client.git","ssh_url":"git@github.com:onovotny/NuGet.Client.git","clone_url":"https://github.com/onovotny/NuGet.Client.git","svn_url":"https://github.com/onovotny/NuGet.Client","homepage":null,"size":30332,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"2b9dafbdc8f5eed8a20b4974fc1b1111c6428292","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":19330736,"name":"NuGet.Client","full_name":"NuGet/NuGet.Client","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Client","description":"Core client libraries for NuGet Services","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Client","forks_url":"https://api.github.com/repos/NuGet/NuGet.Client/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Client/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Client/deployments","created_at":"2014-04-30T23:46:11Z","updated_at":"2017-12-13T01:17:12Z","pushed_at":"2017-12-13T22:08:21Z","git_url":"git://github.com/NuGet/NuGet.Client.git","ssh_url":"git@github.com:NuGet/NuGet.Client.git","clone_url":"https://github.com/NuGet/NuGet.Client.git","svn_url":"https://github.com/NuGet/NuGet.Client","homepage":null,"size":32668,"stargazers_count":223,"watchers_count":223,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":258,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":258,"open_issues":10,"watchers":223,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1861"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/1861"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/1861"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/1861/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1861/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1861/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/ec4cbc9316a66dc78da6d2b8351f672df4eafcf8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PatoBeltran"}}