{"action":"created","comment":{"url":"https://api.github.com/repos/mbohlool/kubernetes/pulls/comments/135938352","pull_request_review_id":59411064,"id":135938352,"diff_hunk":"@@ -384,3 +385,65 @@ func crdExistsInDiscovery(client apiextensionsclientset.Interface, crd *apiexten\n \t}\n \treturn false, nil\n }\n+\n+// TestOpenAPIPresence validates that various paths exist in the\n+// complete delegation chain of the server. If the chain is not wired\n+// up correctly this test should fail; this is largely a smoke test to\n+// ensure that the complete delegation chain is complete.","path":"cmd/kube-apiserver/app/testing/server_test.go","position":16,"original_position":16,"commit_id":"c07dc09c5d59d1c9ca914623051504d16fe95b43","original_commit_id":"c07dc09c5d59d1c9ca914623051504d16fe95b43","user":{"login":"mbohlool","id":1613024,"avatar_url":"https://avatars3.githubusercontent.com/u/1613024?v=4","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false},"body":"as far as I can tell, a successful hack/update-openapi-spec.sh does the same.","created_at":"2017-08-29T23:35:52Z","updated_at":"2017-08-29T23:35:52Z","html_url":"https://github.com/mbohlool/kubernetes/pull/1#discussion_r135938352","pull_request_url":"https://api.github.com/repos/mbohlool/kubernetes/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mbohlool/kubernetes/pulls/comments/135938352"},"html":{"href":"https://github.com/mbohlool/kubernetes/pull/1#discussion_r135938352"},"pull_request":{"href":"https://api.github.com/repos/mbohlool/kubernetes/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/mbohlool/kubernetes/pulls/1","id":138155917,"html_url":"https://github.com/mbohlool/kubernetes/pull/1","diff_url":"https://github.com/mbohlool/kubernetes/pull/1.diff","patch_url":"https://github.com/mbohlool/kubernetes/pull/1.patch","issue_url":"https://api.github.com/repos/mbohlool/kubernetes/issues/1","number":1,"state":"open","locked":false,"title":"Add tests to verify OpenAPI presence","user":{"login":"frobware","id":943903,"avatar_url":"https://avatars1.githubusercontent.com/u/943903?v=4","gravatar_id":"","url":"https://api.github.com/users/frobware","html_url":"https://github.com/frobware","followers_url":"https://api.github.com/users/frobware/followers","following_url":"https://api.github.com/users/frobware/following{/other_user}","gists_url":"https://api.github.com/users/frobware/gists{/gist_id}","starred_url":"https://api.github.com/users/frobware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frobware/subscriptions","organizations_url":"https://api.github.com/users/frobware/orgs","repos_url":"https://api.github.com/users/frobware/repos","events_url":"https://api.github.com/users/frobware/events{/privacy}","received_events_url":"https://api.github.com/users/frobware/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nThe unit test validates that the path '/apis/apiextensions.k8s.io' is\r\nboth enabled and discovered in the test server delegation chain.\r\n\r\n**Which issue this PR fixes** \r\n\r\nUnit test case for #50011.\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis is dependent on PR #50864.\r\n\r\n**Release note**:\r\n\r\n```release-note\r\n```","created_at":"2017-08-29T11:38:35Z","updated_at":"2017-08-29T23:35:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7059c497c073a775b3aee64801bffd613841505f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mbohlool/kubernetes/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mbohlool/kubernetes/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mbohlool/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mbohlool/kubernetes/issues/1/comments","statuses_url":"https://api.github.com/repos/mbohlool/kubernetes/statuses/c07dc09c5d59d1c9ca914623051504d16fe95b43","head":{"label":"frobware:update_openapi_aggr-with-unit-test-case","ref":"update_openapi_aggr-with-unit-test-case","sha":"c07dc09c5d59d1c9ca914623051504d16fe95b43","user":{"login":"frobware","id":943903,"avatar_url":"https://avatars1.githubusercontent.com/u/943903?v=4","gravatar_id":"","url":"https://api.github.com/users/frobware","html_url":"https://github.com/frobware","followers_url":"https://api.github.com/users/frobware/followers","following_url":"https://api.github.com/users/frobware/following{/other_user}","gists_url":"https://api.github.com/users/frobware/gists{/gist_id}","starred_url":"https://api.github.com/users/frobware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frobware/subscriptions","organizations_url":"https://api.github.com/users/frobware/orgs","repos_url":"https://api.github.com/users/frobware/repos","events_url":"https://api.github.com/users/frobware/events{/privacy}","received_events_url":"https://api.github.com/users/frobware/received_events","type":"User","site_admin":false},"repo":{"id":98171733,"name":"kubernetes","full_name":"frobware/kubernetes","owner":{"login":"frobware","id":943903,"avatar_url":"https://avatars1.githubusercontent.com/u/943903?v=4","gravatar_id":"","url":"https://api.github.com/users/frobware","html_url":"https://github.com/frobware","followers_url":"https://api.github.com/users/frobware/followers","following_url":"https://api.github.com/users/frobware/following{/other_user}","gists_url":"https://api.github.com/users/frobware/gists{/gist_id}","starred_url":"https://api.github.com/users/frobware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frobware/subscriptions","organizations_url":"https://api.github.com/users/frobware/orgs","repos_url":"https://api.github.com/users/frobware/repos","events_url":"https://api.github.com/users/frobware/events{/privacy}","received_events_url":"https://api.github.com/users/frobware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frobware/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/frobware/kubernetes","forks_url":"https://api.github.com/repos/frobware/kubernetes/forks","keys_url":"https://api.github.com/repos/frobware/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frobware/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frobware/kubernetes/teams","hooks_url":"https://api.github.com/repos/frobware/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/frobware/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/frobware/kubernetes/events","assignees_url":"https://api.github.com/repos/frobware/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/frobware/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/frobware/kubernetes/tags","blobs_url":"https://api.github.com/repos/frobware/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frobware/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frobware/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/frobware/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frobware/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/frobware/kubernetes/languages","stargazers_url":"https://api.github.com/repos/frobware/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/frobware/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/frobware/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/frobware/kubernetes/subscription","commits_url":"https://api.github.com/repos/frobware/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/frobware/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/frobware/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/frobware/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/frobware/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/frobware/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frobware/kubernetes/merges","archive_url":"https://api.github.com/repos/frobware/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frobware/kubernetes/downloads","issues_url":"https://api.github.com/repos/frobware/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/frobware/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/frobware/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/frobware/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frobware/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/frobware/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/frobware/kubernetes/deployments","created_at":"2017-07-24T09:10:46Z","updated_at":"2017-07-24T09:11:45Z","pushed_at":"2017-08-29T21:29:34Z","git_url":"git://github.com/frobware/kubernetes.git","ssh_url":"git@github.com:frobware/kubernetes.git","clone_url":"https://github.com/frobware/kubernetes.git","svn_url":"https://github.com/frobware/kubernetes","homepage":"http://kubernetes.io","size":464582,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mbohlool:update_openapi_aggr","ref":"update_openapi_aggr","sha":"6184cfd7a9d558a69dcd2039321dbaafb9079b9e","user":{"login":"mbohlool","id":1613024,"avatar_url":"https://avatars3.githubusercontent.com/u/1613024?v=4","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false},"repo":{"id":58666689,"name":"kubernetes","full_name":"mbohlool/kubernetes","owner":{"login":"mbohlool","id":1613024,"avatar_url":"https://avatars3.githubusercontent.com/u/1613024?v=4","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbohlool/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/mbohlool/kubernetes","forks_url":"https://api.github.com/repos/mbohlool/kubernetes/forks","keys_url":"https://api.github.com/repos/mbohlool/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbohlool/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbohlool/kubernetes/teams","hooks_url":"https://api.github.com/repos/mbohlool/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mbohlool/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mbohlool/kubernetes/events","assignees_url":"https://api.github.com/repos/mbohlool/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mbohlool/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mbohlool/kubernetes/tags","blobs_url":"https://api.github.com/repos/mbohlool/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbohlool/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbohlool/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbohlool/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbohlool/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mbohlool/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mbohlool/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mbohlool/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mbohlool/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mbohlool/kubernetes/subscription","commits_url":"https://api.github.com/repos/mbohlool/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbohlool/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbohlool/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbohlool/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbohlool/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mbohlool/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbohlool/kubernetes/merges","archive_url":"https://api.github.com/repos/mbohlool/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbohlool/kubernetes/downloads","issues_url":"https://api.github.com/repos/mbohlool/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mbohlool/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mbohlool/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mbohlool/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbohlool/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mbohlool/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mbohlool/kubernetes/deployments","created_at":"2016-05-12T18:30:33Z","updated_at":"2016-05-12T18:30:48Z","pushed_at":"2017-08-29T23:22:27Z","git_url":"git://github.com/mbohlool/kubernetes.git","ssh_url":"git@github.com:mbohlool/kubernetes.git","clone_url":"https://github.com/mbohlool/kubernetes.git","svn_url":"https://github.com/mbohlool/kubernetes","homepage":"http://kubernetes.io","size":462476,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mbohlool/kubernetes/pulls/1"},"html":{"href":"https://github.com/mbohlool/kubernetes/pull/1"},"issue":{"href":"https://api.github.com/repos/mbohlool/kubernetes/issues/1"},"comments":{"href":"https://api.github.com/repos/mbohlool/kubernetes/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mbohlool/kubernetes/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mbohlool/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mbohlool/kubernetes/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mbohlool/kubernetes/statuses/c07dc09c5d59d1c9ca914623051504d16fe95b43"}},"author_association":"NONE"}}
{"actor":{"display_login":"mbohlool"}}