{"action":"created","issue":{"url":"https://api.github.com/repos/redhat-developer/opencompose/issues/139","repository_url":"https://api.github.com/repos/redhat-developer/opencompose","labels_url":"https://api.github.com/repos/redhat-developer/opencompose/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/redhat-developer/opencompose/issues/139/comments","events_url":"https://api.github.com/repos/redhat-developer/opencompose/issues/139/events","html_url":"https://github.com/redhat-developer/opencompose/issues/139","id":231257556,"number":139,"title":"Validate generated Kubernetes artifacts","user":{"login":"containscafeine","id":9133660,"avatar_url":"https://avatars2.githubusercontent.com/u/9133660?v=3","gravatar_id":"","url":"https://api.github.com/users/containscafeine","html_url":"https://github.com/containscafeine","followers_url":"https://api.github.com/users/containscafeine/followers","following_url":"https://api.github.com/users/containscafeine/following{/other_user}","gists_url":"https://api.github.com/users/containscafeine/gists{/gist_id}","starred_url":"https://api.github.com/users/containscafeine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containscafeine/subscriptions","organizations_url":"https://api.github.com/users/containscafeine/orgs","repos_url":"https://api.github.com/users/containscafeine/repos","events_url":"https://api.github.com/users/containscafeine/events{/privacy}","received_events_url":"https://api.github.com/users/containscafeine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-25T07:00:36Z","updated_at":"2017-06-01T13:15:08Z","closed_at":null,"body":"It'd be great if we start validating the generated Kubernetes artifacts against https://github.com/kubernetes/kubernetes/blob/master/pkg/api/validation/validation.go"},"comment":{"url":"https://api.github.com/repos/redhat-developer/opencompose/issues/comments/305489545","html_url":"https://github.com/redhat-developer/opencompose/issues/139#issuecomment-305489545","issue_url":"https://api.github.com/repos/redhat-developer/opencompose/issues/139","id":305489545,"user":{"login":"containscafeine","id":9133660,"avatar_url":"https://avatars2.githubusercontent.com/u/9133660?v=3","gravatar_id":"","url":"https://api.github.com/users/containscafeine","html_url":"https://github.com/containscafeine","followers_url":"https://api.github.com/users/containscafeine/followers","following_url":"https://api.github.com/users/containscafeine/following{/other_user}","gists_url":"https://api.github.com/users/containscafeine/gists{/gist_id}","starred_url":"https://api.github.com/users/containscafeine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containscafeine/subscriptions","organizations_url":"https://api.github.com/users/containscafeine/orgs","repos_url":"https://api.github.com/users/containscafeine/repos","events_url":"https://api.github.com/users/containscafeine/events{/privacy}","received_events_url":"https://api.github.com/users/containscafeine/received_events","type":"User","site_admin":false},"created_at":"2017-06-01T13:15:08Z","updated_at":"2017-06-01T13:15:08Z","body":"When we will do this, we will required the following -\r\n\r\ncommit message:\r\n```\r\nThis commit updates glide.yaml to include pkg/api/validation from\r\nk8s.io/kubernetes, which is being used to validate generated\r\nKubernets objects.\r\n\r\nThis also fixes the version of github.com/pelletier/go-buffruneio\r\nto v0.1.0. This change is unrelated to the inclusion of\r\npkg/api/validation mentioned above. This has been done because\r\ngithub.com/spf13/viper uses github.com/pelletier/go-toml(master)\r\ngithub.com/pelletier/go-toml(master) uses github.com/pelletier/go-buffruneio(master)\r\nk8s.io/kubernetes(v1.5.7) uses github.com/pelletier/go-buffruneio(v0.1.0)\r\nThis breaks our code.\r\nHence, pinning github.com/pelletier/go-buffruneio to v0.1.0 (same as in\r\nGodeps.json for k8s.io/kubernetes) makes\r\ngithub.com/pelletier/go-toml in github.com/spf13/viper use the\r\nolder version, which does not break our code.\r\n\r\nAfter making the changes in glide.yaml, the vendor/ directory\r\nwas updated using the `glide update --strip-vendor` and\r\n`glide-vc --only-code --no-tests --no-test-imports --no-legal-files`\r\ncommands.\r\n```\r\n\r\nglide.yaml -\r\n```yaml\r\npackage: github.com/redhat-developer/opencompose\r\nimport:\r\n- package: github.com/ghodss/yaml\r\n- package: github.com/spf13/cobra\r\n- package: github.com/spf13/pflag\r\n- package: github.com/spf13/viper\r\n- package: k8s.io/client-go\r\n  version: ^2.0.0\r\n  subpackages:\r\n  - pkg/api/v1\r\n  - pkg/runtime\r\n- package: gopkg.in/yaml.v2\r\n  version: 4c78c975fe7c825c6d1466c42be594d1d6f3aba6\r\n- package: k8s.io/kubernetes\r\n  version: v1.5.7\r\n  subpackages:\r\n  - pkg/api/validation\r\n\r\n# github.com/spf13/viper uses github.com/pelletier/go-toml(master)\r\n# github.com/pelletier/go-toml(master) uses github.com/pelletier/go-buffruneio(master)\r\n# k8s.io/kubernetes(v1.5.7) uses github.com/pelletier/go-buffruneio(v0.1.0)\r\n# This breaks our code.\r\n# Hence, pinning github.com/pelletier/go-buffruneio to v0.1.0 (same as in Godeps.json for k8s.io/kubernetes) makes github.com/pelletier/go-toml in github.com/spf13/viper use the older version, which does not break our code.\r\n- package: github.com/pelletier/go-buffruneio\r\n  version: v0.1.0\r\n\r\n```"}}
{"actor":{"display_login":"containscafeine"}}