{"action":"closed","number":21,"pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls/21","id":132832752,"html_url":"https://github.com/Islandora/islandora_newspaper_batch/pull/21","diff_url":"https://github.com/Islandora/islandora_newspaper_batch/pull/21.diff","patch_url":"https://github.com/Islandora/islandora_newspaper_batch/pull/21.patch","issue_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/issues/21","number":21,"state":"closed","locked":false,"title":"add ocr/hocr ignore options","user":{"login":"qadan","id":3406327,"avatar_url":"https://avatars1.githubusercontent.com/u/3406327?v=4","gravatar_id":"","url":"https://api.github.com/users/qadan","html_url":"https://github.com/qadan","followers_url":"https://api.github.com/users/qadan/followers","following_url":"https://api.github.com/users/qadan/following{/other_user}","gists_url":"https://api.github.com/users/qadan/gists{/gist_id}","starred_url":"https://api.github.com/users/qadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qadan/subscriptions","organizations_url":"https://api.github.com/users/qadan/orgs","repos_url":"https://api.github.com/users/qadan/repos","events_url":"https://api.github.com/users/qadan/events{/privacy}","received_events_url":"https://api.github.com/users/qadan/received_events","type":"User","site_admin":false},"body":"**JIRA Ticket**: https://jira.duraspace.org/browse/ISLANDORA-2012\r\n\r\n* Other Relevant Links: Hard-requirement on https://github.com/Islandora/islandora_ocr/pull/81\r\n\r\n# What does this Pull Request do?\r\nAdds the option to ignore OCR/HOCR derivative generation when batch ingesting newspaper issues through the UI/Drush.\r\nAlso some language updates to clarify some odd things.\r\n\r\n# What's new?\r\n* Options in the newspaper issue batch ingest UI to opt out of OCR/HOCR derivative generation individually, not just one for both.\r\n* A new flag, --do_not_generate_hocr, to opt out of HOCR derivative generation on Drush batches.\r\n* The --do_not_generate_ocr flag now only opts out of OCR derivative generation.\r\n\r\n# How should this be tested?\r\n* Run the UI newspaper issue batch ingest and test each of the OCR/HOCR opt-out options.\r\n* Run the drush newspaper issue batch ingest with the --do_not_generate_ocr and/or the --do_not_generate_hocr flags.\r\nIn all cases, OCR/HOCR should only be generated if it isn't opted out of.\r\n\r\n# Additional Notes:\r\nThis has the potential to impact shell scripts that perform Drush scripting given the splitting of --do_not_generate_ocr into --do_not_generate_ocr and --do_not_generate_hocr. Shell scripts that currently rely on this flag would need to be updated to have flags split out.\r\n\r\n# Interested parties\r\n@jordandukart bein' the person on the thing\r\n","created_at":"2017-07-27T19:59:26Z","updated_at":"2017-11-20T22:14:39Z","closed_at":"2017-11-20T22:14:39Z","merged_at":"2017-11-20T22:14:39Z","merge_commit_sha":"d5ee08c216efc00cec400195c2b057849736b995","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/issues/21/comments","statuses_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/statuses/ae5e749b84133e0dc4f45a7dd581d2222c73a1e1","head":{"label":"qadan:7.x-ISLANDORA-2012","ref":"7.x-ISLANDORA-2012","sha":"ae5e749b84133e0dc4f45a7dd581d2222c73a1e1","user":{"login":"qadan","id":3406327,"avatar_url":"https://avatars1.githubusercontent.com/u/3406327?v=4","gravatar_id":"","url":"https://api.github.com/users/qadan","html_url":"https://github.com/qadan","followers_url":"https://api.github.com/users/qadan/followers","following_url":"https://api.github.com/users/qadan/following{/other_user}","gists_url":"https://api.github.com/users/qadan/gists{/gist_id}","starred_url":"https://api.github.com/users/qadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qadan/subscriptions","organizations_url":"https://api.github.com/users/qadan/orgs","repos_url":"https://api.github.com/users/qadan/repos","events_url":"https://api.github.com/users/qadan/events{/privacy}","received_events_url":"https://api.github.com/users/qadan/received_events","type":"User","site_admin":false},"repo":{"id":98573984,"name":"islandora_newspaper_batch","full_name":"qadan/islandora_newspaper_batch","owner":{"login":"qadan","id":3406327,"avatar_url":"https://avatars1.githubusercontent.com/u/3406327?v=4","gravatar_id":"","url":"https://api.github.com/users/qadan","html_url":"https://github.com/qadan","followers_url":"https://api.github.com/users/qadan/followers","following_url":"https://api.github.com/users/qadan/following{/other_user}","gists_url":"https://api.github.com/users/qadan/gists{/gist_id}","starred_url":"https://api.github.com/users/qadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qadan/subscriptions","organizations_url":"https://api.github.com/users/qadan/orgs","repos_url":"https://api.github.com/users/qadan/repos","events_url":"https://api.github.com/users/qadan/events{/privacy}","received_events_url":"https://api.github.com/users/qadan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qadan/islandora_newspaper_batch","description":"Extends the Islandora batch framework to provide the option to add newspaper issues and pages to an existing newspaper object.","fork":true,"url":"https://api.github.com/repos/qadan/islandora_newspaper_batch","forks_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/forks","keys_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/teams","hooks_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/hooks","issue_events_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/issues/events{/number}","events_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/events","assignees_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/assignees{/user}","branches_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/branches{/branch}","tags_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/tags","blobs_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/git/refs{/sha}","trees_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/statuses/{sha}","languages_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/languages","stargazers_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/stargazers","contributors_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/contributors","subscribers_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/subscribers","subscription_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/subscription","commits_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/commits{/sha}","git_commits_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/git/commits{/sha}","comments_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/comments{/number}","issue_comment_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/issues/comments{/number}","contents_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/contents/{+path}","compare_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/merges","archive_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/downloads","issues_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/issues{/number}","pulls_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/pulls{/number}","milestones_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/milestones{/number}","notifications_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/labels{/name}","releases_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/releases{/id}","deployments_url":"https://api.github.com/repos/qadan/islandora_newspaper_batch/deployments","created_at":"2017-07-27T19:41:18Z","updated_at":"2017-07-27T19:41:20Z","pushed_at":"2017-11-03T12:21:47Z","git_url":"git://github.com/qadan/islandora_newspaper_batch.git","ssh_url":"git@github.com:qadan/islandora_newspaper_batch.git","clone_url":"https://github.com/qadan/islandora_newspaper_batch.git","svn_url":"https://github.com/qadan/islandora_newspaper_batch","homepage":"http://islandora.ca/","size":67,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x"}},"base":{"label":"Islandora:7.x","ref":"7.x","sha":"2fcc51dcd04f5046d47110771a9ab675566b96f8","user":{"login":"Islandora","id":494054,"avatar_url":"https://avatars3.githubusercontent.com/u/494054?v=4","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"repo":{"id":35852750,"name":"islandora_newspaper_batch","full_name":"Islandora/islandora_newspaper_batch","owner":{"login":"Islandora","id":494054,"avatar_url":"https://avatars3.githubusercontent.com/u/494054?v=4","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Islandora/islandora_newspaper_batch","description":"Extends the Islandora batch framework to provide the option to add newspaper issues and pages to an existing newspaper object.","fork":false,"url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch","forks_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/forks","keys_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/teams","hooks_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/hooks","issue_events_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/issues/events{/number}","events_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/events","assignees_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/assignees{/user}","branches_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/branches{/branch}","tags_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/tags","blobs_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/statuses/{sha}","languages_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/languages","stargazers_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/stargazers","contributors_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/contributors","subscribers_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/subscribers","subscription_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/subscription","commits_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/contents/{+path}","compare_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/merges","archive_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/downloads","issues_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/issues{/number}","pulls_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls{/number}","milestones_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/milestones{/number}","notifications_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/labels{/name}","releases_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/releases{/id}","deployments_url":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/deployments","created_at":"2015-05-19T01:46:43Z","updated_at":"2017-11-13T03:12:40Z","pushed_at":"2017-11-20T22:14:39Z","git_url":"git://github.com/Islandora/islandora_newspaper_batch.git","ssh_url":"git@github.com:Islandora/islandora_newspaper_batch.git","clone_url":"https://github.com/Islandora/islandora_newspaper_batch.git","svn_url":"https://github.com/Islandora/islandora_newspaper_batch","homepage":"http://islandora.ca/","size":77,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":18,"open_issues":0,"watchers":2,"default_branch":"7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls/21"},"html":{"href":"https://github.com/Islandora/islandora_newspaper_batch/pull/21"},"issue":{"href":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/issues/21"},"comments":{"href":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Islandora/islandora_newspaper_batch/statuses/ae5e749b84133e0dc4f45a7dd581d2222c73a1e1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"DiegoPino","id":6946023,"avatar_url":"https://avatars2.githubusercontent.com/u/6946023?v=4","gravatar_id":"","url":"https://api.github.com/users/DiegoPino","html_url":"https://github.com/DiegoPino","followers_url":"https://api.github.com/users/DiegoPino/followers","following_url":"https://api.github.com/users/DiegoPino/following{/other_user}","gists_url":"https://api.github.com/users/DiegoPino/gists{/gist_id}","starred_url":"https://api.github.com/users/DiegoPino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DiegoPino/subscriptions","organizations_url":"https://api.github.com/users/DiegoPino/orgs","repos_url":"https://api.github.com/users/DiegoPino/repos","events_url":"https://api.github.com/users/DiegoPino/events{/privacy}","received_events_url":"https://api.github.com/users/DiegoPino/received_events","type":"User","site_admin":false},"comments":3,"review_comments":4,"maintainer_can_modify":false,"commits":4,"additions":22,"deletions":10,"changed_files":3}}
{"actor":{"display_login":"DiegoPino"}}