{"action":"closed","number":161,"pull_request":{"url":"https://api.github.com/repos/paypal/downshift/pulls/161","id":138522038,"html_url":"https://github.com/paypal/downshift/pull/161","diff_url":"https://github.com/paypal/downshift/pull/161.diff","patch_url":"https://github.com/paypal/downshift/pull/161.patch","issue_url":"https://api.github.com/repos/paypal/downshift/issues/161","number":161,"state":"closed","locked":false,"title":"feat(enter): make enter work inside form","user":{"login":"codiemullins","id":74193,"avatar_url":"https://avatars1.githubusercontent.com/u/74193?v=4","gravatar_id":"","url":"https://api.github.com/users/codiemullins","html_url":"https://github.com/codiemullins","followers_url":"https://api.github.com/users/codiemullins/followers","following_url":"https://api.github.com/users/codiemullins/following{/other_user}","gists_url":"https://api.github.com/users/codiemullins/gists{/gist_id}","starred_url":"https://api.github.com/users/codiemullins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codiemullins/subscriptions","organizations_url":"https://api.github.com/users/codiemullins/orgs","repos_url":"https://api.github.com/users/codiemullins/repos","events_url":"https://api.github.com/users/codiemullins/events{/privacy}","received_events_url":"https://api.github.com/users/codiemullins/received_events","type":"User","site_admin":false},"body":"<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n**What**: Allow `enter` key to submit form, if downshift is inside a `form` tag.\r\n\r\n<!-- Why are these changes necessary? -->\r\n**Why**: So form can be submitted with `enter` key if focus is on downshift input.\r\n\r\n<!-- How were these changes implemented? -->\r\n**How**: Moved `event.preventDefault()` so it only executes if menu is open\r\n\r\n<!-- Have you done all of these things?  -->\r\n**Checklist**:\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n- [ ] Documentation - N/A\r\n- [x] Tests (kind of, added a story book... may need unit test? Wasn't sure)\r\n- [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n- [x] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->\r\n\r\n<!-- feel free to add additional comments -->\r\n","created_at":"2017-08-30T20:36:05Z","updated_at":"2017-08-30T20:40:01Z","closed_at":"2017-08-30T20:40:01Z","merged_at":"2017-08-30T20:40:01Z","merge_commit_sha":"47ee3b82d8aa9233b0f1c904e01ce7cb59fb437d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/downshift/pulls/161/commits","review_comments_url":"https://api.github.com/repos/paypal/downshift/pulls/161/comments","review_comment_url":"https://api.github.com/repos/paypal/downshift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/downshift/issues/161/comments","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/ae542b04e35205bd0236532aaddb5d7089ad2aa4","head":{"label":"codiemullins:master","ref":"master","sha":"ae542b04e35205bd0236532aaddb5d7089ad2aa4","user":{"login":"codiemullins","id":74193,"avatar_url":"https://avatars1.githubusercontent.com/u/74193?v=4","gravatar_id":"","url":"https://api.github.com/users/codiemullins","html_url":"https://github.com/codiemullins","followers_url":"https://api.github.com/users/codiemullins/followers","following_url":"https://api.github.com/users/codiemullins/following{/other_user}","gists_url":"https://api.github.com/users/codiemullins/gists{/gist_id}","starred_url":"https://api.github.com/users/codiemullins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codiemullins/subscriptions","organizations_url":"https://api.github.com/users/codiemullins/orgs","repos_url":"https://api.github.com/users/codiemullins/repos","events_url":"https://api.github.com/users/codiemullins/events{/privacy}","received_events_url":"https://api.github.com/users/codiemullins/received_events","type":"User","site_admin":false},"repo":{"id":101923180,"name":"downshift","full_name":"codiemullins/downshift","owner":{"login":"codiemullins","id":74193,"avatar_url":"https://avatars1.githubusercontent.com/u/74193?v=4","gravatar_id":"","url":"https://api.github.com/users/codiemullins","html_url":"https://github.com/codiemullins","followers_url":"https://api.github.com/users/codiemullins/followers","following_url":"https://api.github.com/users/codiemullins/following{/other_user}","gists_url":"https://api.github.com/users/codiemullins/gists{/gist_id}","starred_url":"https://api.github.com/users/codiemullins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codiemullins/subscriptions","organizations_url":"https://api.github.com/users/codiemullins/orgs","repos_url":"https://api.github.com/users/codiemullins/repos","events_url":"https://api.github.com/users/codiemullins/events{/privacy}","received_events_url":"https://api.github.com/users/codiemullins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codiemullins/downshift","description":"🏎 Primitives to build simple, flexible, WAI-ARIA compliant enhanced input React components","fork":true,"url":"https://api.github.com/repos/codiemullins/downshift","forks_url":"https://api.github.com/repos/codiemullins/downshift/forks","keys_url":"https://api.github.com/repos/codiemullins/downshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codiemullins/downshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codiemullins/downshift/teams","hooks_url":"https://api.github.com/repos/codiemullins/downshift/hooks","issue_events_url":"https://api.github.com/repos/codiemullins/downshift/issues/events{/number}","events_url":"https://api.github.com/repos/codiemullins/downshift/events","assignees_url":"https://api.github.com/repos/codiemullins/downshift/assignees{/user}","branches_url":"https://api.github.com/repos/codiemullins/downshift/branches{/branch}","tags_url":"https://api.github.com/repos/codiemullins/downshift/tags","blobs_url":"https://api.github.com/repos/codiemullins/downshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codiemullins/downshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codiemullins/downshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/codiemullins/downshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codiemullins/downshift/statuses/{sha}","languages_url":"https://api.github.com/repos/codiemullins/downshift/languages","stargazers_url":"https://api.github.com/repos/codiemullins/downshift/stargazers","contributors_url":"https://api.github.com/repos/codiemullins/downshift/contributors","subscribers_url":"https://api.github.com/repos/codiemullins/downshift/subscribers","subscription_url":"https://api.github.com/repos/codiemullins/downshift/subscription","commits_url":"https://api.github.com/repos/codiemullins/downshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/codiemullins/downshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/codiemullins/downshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/codiemullins/downshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/codiemullins/downshift/contents/{+path}","compare_url":"https://api.github.com/repos/codiemullins/downshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codiemullins/downshift/merges","archive_url":"https://api.github.com/repos/codiemullins/downshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codiemullins/downshift/downloads","issues_url":"https://api.github.com/repos/codiemullins/downshift/issues{/number}","pulls_url":"https://api.github.com/repos/codiemullins/downshift/pulls{/number}","milestones_url":"https://api.github.com/repos/codiemullins/downshift/milestones{/number}","notifications_url":"https://api.github.com/repos/codiemullins/downshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codiemullins/downshift/labels{/name}","releases_url":"https://api.github.com/repos/codiemullins/downshift/releases{/id}","deployments_url":"https://api.github.com/repos/codiemullins/downshift/deployments","created_at":"2017-08-30T19:56:31Z","updated_at":"2017-08-30T19:56:32Z","pushed_at":"2017-08-30T20:30:28Z","git_url":"git://github.com/codiemullins/downshift.git","ssh_url":"git@github.com:codiemullins/downshift.git","clone_url":"https://github.com/codiemullins/downshift.git","svn_url":"https://github.com/codiemullins/downshift","homepage":"https://www.npmjs.com/package/downshift","size":343,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"3bafbcdc2ae3fc6f5837236a5159b297c5c9867c","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":98315735,"name":"downshift","full_name":"paypal/downshift","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/downshift","description":"🏎 Primitives to build simple, flexible, WAI-ARIA compliant enhanced input React components","fork":false,"url":"https://api.github.com/repos/paypal/downshift","forks_url":"https://api.github.com/repos/paypal/downshift/forks","keys_url":"https://api.github.com/repos/paypal/downshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/downshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/downshift/teams","hooks_url":"https://api.github.com/repos/paypal/downshift/hooks","issue_events_url":"https://api.github.com/repos/paypal/downshift/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/downshift/events","assignees_url":"https://api.github.com/repos/paypal/downshift/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/downshift/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/downshift/tags","blobs_url":"https://api.github.com/repos/paypal/downshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/downshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/downshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/downshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/downshift/languages","stargazers_url":"https://api.github.com/repos/paypal/downshift/stargazers","contributors_url":"https://api.github.com/repos/paypal/downshift/contributors","subscribers_url":"https://api.github.com/repos/paypal/downshift/subscribers","subscription_url":"https://api.github.com/repos/paypal/downshift/subscription","commits_url":"https://api.github.com/repos/paypal/downshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/downshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/downshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/downshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/downshift/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/downshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/downshift/merges","archive_url":"https://api.github.com/repos/paypal/downshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/downshift/downloads","issues_url":"https://api.github.com/repos/paypal/downshift/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/downshift/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/downshift/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/downshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/downshift/labels{/name}","releases_url":"https://api.github.com/repos/paypal/downshift/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/downshift/deployments","created_at":"2017-07-25T14:31:42Z","updated_at":"2017-08-30T20:29:16Z","pushed_at":"2017-08-30T20:40:01Z","git_url":"git://github.com/paypal/downshift.git","ssh_url":"git@github.com:paypal/downshift.git","clone_url":"https://github.com/paypal/downshift.git","svn_url":"https://github.com/paypal/downshift","homepage":"https://www.npmjs.com/package/downshift","size":343,"stargazers_count":1566,"watchers_count":1566,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":5,"forks":70,"open_issues":5,"watchers":1566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/downshift/pulls/161"},"html":{"href":"https://github.com/paypal/downshift/pull/161"},"issue":{"href":"https://api.github.com/repos/paypal/downshift/issues/161"},"comments":{"href":"https://api.github.com/repos/paypal/downshift/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/downshift/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/downshift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/downshift/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/downshift/statuses/ae542b04e35205bd0236532aaddb5d7089ad2aa4"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":37,"deletions":6,"changed_files":5}}
{"actor":{"display_login":"kentcdodds"}}