{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/nuclide/issues/1231","repository_url":"https://api.github.com/repos/facebook/nuclide","labels_url":"https://api.github.com/repos/facebook/nuclide/issues/1231/labels{/name}","comments_url":"https://api.github.com/repos/facebook/nuclide/issues/1231/comments","events_url":"https://api.github.com/repos/facebook/nuclide/issues/1231/events","html_url":"https://github.com/facebook/nuclide/issues/1231","id":241726576,"number":1231,"title":"Tab switching with Ctrl+PageUp / Ctrl+PageDown does not work in 0.236","user":{"login":"fsi","id":917409,"avatar_url":"https://avatars2.githubusercontent.com/u/917409?v=3","gravatar_id":"","url":"https://api.github.com/users/fsi","html_url":"https://github.com/fsi","followers_url":"https://api.github.com/users/fsi/followers","following_url":"https://api.github.com/users/fsi/following{/other_user}","gists_url":"https://api.github.com/users/fsi/gists{/gist_id}","starred_url":"https://api.github.com/users/fsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsi/subscriptions","organizations_url":"https://api.github.com/users/fsi/orgs","repos_url":"https://api.github.com/users/fsi/repos","events_url":"https://api.github.com/users/fsi/events{/privacy}","received_events_url":"https://api.github.com/users/fsi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-10T14:11:46Z","updated_at":"2017-07-10T18:14:28Z","closed_at":null,"body":"### Issue and Steps to Reproduce\r\nI am used to switching to the next/previous tab in the editor with Ctrl+PageUp and Ctrl+PageDown combinations, which is a usual combination in browsers and editors alike. It used to work in atom editor with nuclide until I upgraded to nuclide 0.236.0\r\n\r\nIn it, coming from this particular commit, these keybindings are overriden to do the same as Ctrl+Home and Ctrl+End: https://github.com/facebook/nuclide/commit/b79fb35952386ee7b7f0933639e93fd6b5c81a44 \r\n\r\nSteps to reproduce:\r\n1. open a few files in different editor tabs\r\n2. press ctrl+pagedown or ctrl+pageup\r\n\r\n### Expected Behavior\r\nEditor should switch to the next/previous tab\r\n\r\n### Actual Behavior\r\nEditor goes to the beginning/end of currently open tab\r\n\r\n### Versions\r\n* Atom: 1.18.0\r\n* Nuclide: 0.236.0\r\n* Client OS: linux\r\n* Server OS (optional):\r\n\r\n### Additional Details\r\n* Installed packages (`apm ls --installed`):\r\n```\r\n├── busy-signal@1.4.3\r\n├── highlight-selected@0.13.1\r\n├── intentions@1.1.2\r\n├── language-babel@2.66.1\r\n├── language-graphql@0.9.0\r\n├── linter@2.2.0 (disabled)\r\n├── linter-eslint@8.2.1\r\n├── linter-ui-default@1.6.2\r\n├── nuclide@0.236.0\r\n├── nuclide-format-js@0.0.36\r\n├── prettier-atom@0.36.1\r\n├── set-syntax@0.3.2\r\n└── tool-bar@1.1.0\r\n```\r\n\r\nTo mitigate this I had to add this to my keymap.cson file:\r\n```\r\n$ cat ~/.atom/keymap.cson \r\n'.platform-win32 atom-workspace, .platform-linux atom-workspace':\r\n  'ctrl-pageup': 'pane:show-previous-item'\r\n  'ctrl-pagedown': 'pane:show-next-item'\r\n```"},"comment":{"url":"https://api.github.com/repos/facebook/nuclide/issues/comments/314189738","html_url":"https://github.com/facebook/nuclide/issues/1231#issuecomment-314189738","issue_url":"https://api.github.com/repos/facebook/nuclide/issues/1231","id":314189738,"user":{"login":"ebluestein","id":25541021,"avatar_url":"https://avatars3.githubusercontent.com/u/25541021?v=3","gravatar_id":"","url":"https://api.github.com/users/ebluestein","html_url":"https://github.com/ebluestein","followers_url":"https://api.github.com/users/ebluestein/followers","following_url":"https://api.github.com/users/ebluestein/following{/other_user}","gists_url":"https://api.github.com/users/ebluestein/gists{/gist_id}","starred_url":"https://api.github.com/users/ebluestein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebluestein/subscriptions","organizations_url":"https://api.github.com/users/ebluestein/orgs","repos_url":"https://api.github.com/users/ebluestein/repos","events_url":"https://api.github.com/users/ebluestein/events{/privacy}","received_events_url":"https://api.github.com/users/ebluestein/received_events","type":"User","site_admin":false},"created_at":"2017-07-10T18:14:28Z","updated_at":"2017-07-10T18:14:28Z","body":"@fsi thank you for the detailed report. This change was made to mimic the keybindings of the file tree in Windows Explorer, but I see that this conflicts with what people are used to in Chrome and other browsers.\r\n\r\nWe're going revert that change, look for this to be fixed in next week's release."}}
{"actor":{"display_login":"ebluestein"}}