{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/sdk/pulls/comments/102984110","pull_request_review_id":23760709,"id":102984110,"diff_hunk":"@@ -182,29 +204,25 @@ public IEnumerable<string> GetTopLevelDependencies()\n             return privateAssetsToExclude;\n         }\n         private static HashSet<string> GetIntersection(\n-          IDictionary<string, LockFileTargetLibrary> collection1,\n-          IDictionary<string, LockFileTargetLibrary> collection2)\n+          IDictionary<string, HashSet<PackageIdentity>> packagesToBeFiltered,\n+          IDictionary<string, LockFileTargetLibrary> packagesToBePublished)\n         {\n-            var exclusionList = new HashSet<string>();\n-            var iterated = collection1;\n-            var lookup = collection2;\n-\n-            if (collection1.Count > collection2.Count)\n-            {\n-                iterated = collection2;\n-                lookup = collection1;\n-            }\n-            foreach (var entry in iterated)\n+            var exclusionList = new HashSet<string>(StringComparer.OrdinalIgnoreCase);\n+            \n+            foreach (var entry in packagesToBePublished)\n             {\n-                LockFileTargetLibrary library = lookup[entry.Key];\n-\n-                if (library != null)\n+                var entryKey = entry.Key.ToLower();","path":"src/Tasks/Microsoft.NET.Build.Tasks/ProjectContext.cs","position":99,"original_position":99,"commit_id":"c06fc8726e50f07c3ba36cb84e2530086522f14f","original_commit_id":"c06fc8726e50f07c3ba36cb84e2530086522f14f","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"No need to use ToLower.  Use an ignore-case comparer in the HashSet/Dictionary.","created_at":"2017-02-24T16:58:37Z","updated_at":"2017-02-24T16:58:37Z","html_url":"https://github.com/dotnet/sdk/pull/890#discussion_r102984110","pull_request_url":"https://api.github.com/repos/dotnet/sdk/pulls/890","_links":{"self":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/comments/102984110"},"html":{"href":"https://github.com/dotnet/sdk/pull/890#discussion_r102984110"},"pull_request":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/890"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/sdk/pulls/890","id":106891055,"html_url":"https://github.com/dotnet/sdk/pull/890","diff_url":"https://github.com/dotnet/sdk/pull/890.diff","patch_url":"https://github.com/dotnet/sdk/pull/890.patch","issue_url":"https://api.github.com/repos/dotnet/sdk/issues/890","number":890,"state":"open","locked":false,"title":"Creating Cache Artifact","user":{"login":"ramarag","id":10203266,"avatar_url":"https://avatars.githubusercontent.com/u/10203266?v=3","gravatar_id":"","url":"https://api.github.com/users/ramarag","html_url":"https://github.com/ramarag","followers_url":"https://api.github.com/users/ramarag/followers","following_url":"https://api.github.com/users/ramarag/following{/other_user}","gists_url":"https://api.github.com/users/ramarag/gists{/gist_id}","starred_url":"https://api.github.com/users/ramarag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramarag/subscriptions","organizations_url":"https://api.github.com/users/ramarag/orgs","repos_url":"https://api.github.com/users/ramarag/repos","events_url":"https://api.github.com/users/ramarag/events{/privacy}","received_events_url":"https://api.github.com/users/ramarag/received_events","type":"User","site_admin":false},"body":"With this change\r\n\r\ndotnet-cache can cache packages with different versions at the same time, it further produces an artifact.xml which has the list of all the packages cached during dotnet-cache.\r\n\r\nThis artifact.xml should be used with publish filter option to remove the files which are already cached\r\n\r\n@gkhanna79 @eerhardt @nguerrera PTAL","created_at":"2017-02-19T06:55:30Z","updated_at":"2017-02-24T16:58:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30c36e4d336d56d5419e94ecba4599cfe41c220d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/sdk/pulls/890/commits","review_comments_url":"https://api.github.com/repos/dotnet/sdk/pulls/890/comments","review_comment_url":"https://api.github.com/repos/dotnet/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/sdk/issues/890/comments","statuses_url":"https://api.github.com/repos/dotnet/sdk/statuses/c06fc8726e50f07c3ba36cb84e2530086522f14f","head":{"label":"ramarag:cache_artifact","ref":"cache_artifact","sha":"c06fc8726e50f07c3ba36cb84e2530086522f14f","user":{"login":"ramarag","id":10203266,"avatar_url":"https://avatars.githubusercontent.com/u/10203266?v=3","gravatar_id":"","url":"https://api.github.com/users/ramarag","html_url":"https://github.com/ramarag","followers_url":"https://api.github.com/users/ramarag/followers","following_url":"https://api.github.com/users/ramarag/following{/other_user}","gists_url":"https://api.github.com/users/ramarag/gists{/gist_id}","starred_url":"https://api.github.com/users/ramarag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramarag/subscriptions","organizations_url":"https://api.github.com/users/ramarag/orgs","repos_url":"https://api.github.com/users/ramarag/repos","events_url":"https://api.github.com/users/ramarag/events{/privacy}","received_events_url":"https://api.github.com/users/ramarag/received_events","type":"User","site_admin":false},"repo":{"id":76906039,"name":"sdk","full_name":"ramarag/sdk","owner":{"login":"ramarag","id":10203266,"avatar_url":"https://avatars.githubusercontent.com/u/10203266?v=3","gravatar_id":"","url":"https://api.github.com/users/ramarag","html_url":"https://github.com/ramarag","followers_url":"https://api.github.com/users/ramarag/followers","following_url":"https://api.github.com/users/ramarag/following{/other_user}","gists_url":"https://api.github.com/users/ramarag/gists{/gist_id}","starred_url":"https://api.github.com/users/ramarag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramarag/subscriptions","organizations_url":"https://api.github.com/users/ramarag/orgs","repos_url":"https://api.github.com/users/ramarag/repos","events_url":"https://api.github.com/users/ramarag/events{/privacy}","received_events_url":"https://api.github.com/users/ramarag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramarag/sdk","description":"Core functionality needed to create .NET Core projects, that is shared between VisualStudio and CLI","fork":true,"url":"https://api.github.com/repos/ramarag/sdk","forks_url":"https://api.github.com/repos/ramarag/sdk/forks","keys_url":"https://api.github.com/repos/ramarag/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramarag/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramarag/sdk/teams","hooks_url":"https://api.github.com/repos/ramarag/sdk/hooks","issue_events_url":"https://api.github.com/repos/ramarag/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/ramarag/sdk/events","assignees_url":"https://api.github.com/repos/ramarag/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/ramarag/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/ramarag/sdk/tags","blobs_url":"https://api.github.com/repos/ramarag/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramarag/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramarag/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramarag/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramarag/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/ramarag/sdk/languages","stargazers_url":"https://api.github.com/repos/ramarag/sdk/stargazers","contributors_url":"https://api.github.com/repos/ramarag/sdk/contributors","subscribers_url":"https://api.github.com/repos/ramarag/sdk/subscribers","subscription_url":"https://api.github.com/repos/ramarag/sdk/subscription","commits_url":"https://api.github.com/repos/ramarag/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramarag/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramarag/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramarag/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramarag/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/ramarag/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramarag/sdk/merges","archive_url":"https://api.github.com/repos/ramarag/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramarag/sdk/downloads","issues_url":"https://api.github.com/repos/ramarag/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/ramarag/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/ramarag/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/ramarag/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramarag/sdk/labels{/name}","releases_url":"https://api.github.com/repos/ramarag/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/ramarag/sdk/deployments","created_at":"2016-12-19T23:38:04Z","updated_at":"2016-12-19T23:38:07Z","pushed_at":"2017-02-24T06:50:21Z","git_url":"git://github.com/ramarag/sdk.git","ssh_url":"git@github.com:ramarag/sdk.git","clone_url":"https://github.com/ramarag/sdk.git","svn_url":"https://github.com/ramarag/sdk","homepage":"htts://dot.net/core","size":1752,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:future","ref":"future","sha":"5adcbb6623fe4023ed45eb33d97488a0108bcd6b","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":63984307,"name":"sdk","full_name":"dotnet/sdk","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/sdk","description":"Core functionality needed to create .NET Core projects, that is shared between Visual Studio and CLI","fork":false,"url":"https://api.github.com/repos/dotnet/sdk","forks_url":"https://api.github.com/repos/dotnet/sdk/forks","keys_url":"https://api.github.com/repos/dotnet/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/sdk/teams","hooks_url":"https://api.github.com/repos/dotnet/sdk/hooks","issue_events_url":"https://api.github.com/repos/dotnet/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/sdk/events","assignees_url":"https://api.github.com/repos/dotnet/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/sdk/tags","blobs_url":"https://api.github.com/repos/dotnet/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/sdk/languages","stargazers_url":"https://api.github.com/repos/dotnet/sdk/stargazers","contributors_url":"https://api.github.com/repos/dotnet/sdk/contributors","subscribers_url":"https://api.github.com/repos/dotnet/sdk/subscribers","subscription_url":"https://api.github.com/repos/dotnet/sdk/subscription","commits_url":"https://api.github.com/repos/dotnet/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/sdk/merges","archive_url":"https://api.github.com/repos/dotnet/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/sdk/downloads","issues_url":"https://api.github.com/repos/dotnet/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/sdk/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/sdk/deployments","created_at":"2016-07-22T21:26:02Z","updated_at":"2017-02-23T08:48:02Z","pushed_at":"2017-02-24T06:50:22Z","git_url":"git://github.com/dotnet/sdk.git","ssh_url":"git@github.com:dotnet/sdk.git","clone_url":"https://github.com/dotnet/sdk.git","svn_url":"https://github.com/dotnet/sdk","homepage":"https://dot.net/core","size":1809,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":161,"forks":54,"open_issues":161,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/890"},"html":{"href":"https://github.com/dotnet/sdk/pull/890"},"issue":{"href":"https://api.github.com/repos/dotnet/sdk/issues/890"},"comments":{"href":"https://api.github.com/repos/dotnet/sdk/issues/890/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/890/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/890/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/sdk/statuses/c06fc8726e50f07c3ba36cb84e2530086522f14f"}}}}
{"actor":{"display_login":"eerhardt"}}