{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/159160110","pull_request_review_id":86066376,"id":159160110,"diff_hunk":"@@ -111,6 +116,15 @@\n #define MI_MAKE_WRITE_PAGE(x)      ((x)->u.Hard.Writable = 1)\n #endif\n \n+\n+/* Macros to identify the page fault reason from the error code */\n+//#define MI_IS_NOT_PRESENT_FAULT(FaultCode) !BooleanFlagOn(FaultCode, 0x1)\n+//#define MI_IS_PROTECTION_FAULT(FaultCode) BooleanFlagOn(FaultCode, 0x1)\n+#define MI_IS_WRITE_ACCESS(FaultCode) BooleanFlagOn(FaultCode, 0x2)\n+//#define MI_IS_SUPERVISOR_ACCESS(FaultCode) BooleanFlagOn(FaultCode, 0x4)","path":"ntoskrnl/include/internal/i386/mm.h","position":21,"original_position":21,"commit_id":"bee29ef499f7ffd6946650ef852ce09691a21f7e","original_commit_id":"bee29ef499f7ffd6946650ef852ce09691a21f7e","user":{"login":"ThFabba","id":18138474,"avatar_url":"https://avatars3.githubusercontent.com/u/18138474?v=4","gravatar_id":"","url":"https://api.github.com/users/ThFabba","html_url":"https://github.com/ThFabba","followers_url":"https://api.github.com/users/ThFabba/followers","following_url":"https://api.github.com/users/ThFabba/following{/other_user}","gists_url":"https://api.github.com/users/ThFabba/gists{/gist_id}","starred_url":"https://api.github.com/users/ThFabba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThFabba/subscriptions","organizations_url":"https://api.github.com/users/ThFabba/orgs","repos_url":"https://api.github.com/users/ThFabba/repos","events_url":"https://api.github.com/users/ThFabba/events{/privacy}","received_events_url":"https://api.github.com/users/ThFabba/received_events","type":"User","site_admin":false},"body":"This one too, of course.","created_at":"2018-01-01T17:36:13Z","updated_at":"2018-01-01T17:36:13Z","html_url":"https://github.com/reactos/reactos/pull/256#discussion_r159160110","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/256","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/159160110"},"html":{"href":"https://github.com/reactos/reactos/pull/256#discussion_r159160110"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/256","id":160653677,"html_url":"https://github.com/reactos/reactos/pull/256","diff_url":"https://github.com/reactos/reactos/pull/256.diff","patch_url":"https://github.com/reactos/reactos/pull/256.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/256","number":256,"state":"open","locked":false,"title":"Pass page fault code to Mm(Arm)AccessFault and implement NX support","user":{"login":"tkreuzer","id":313067,"avatar_url":"https://avatars1.githubusercontent.com/u/313067?v=4","gravatar_id":"","url":"https://api.github.com/users/tkreuzer","html_url":"https://github.com/tkreuzer","followers_url":"https://api.github.com/users/tkreuzer/followers","following_url":"https://api.github.com/users/tkreuzer/following{/other_user}","gists_url":"https://api.github.com/users/tkreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkreuzer/subscriptions","organizations_url":"https://api.github.com/users/tkreuzer/orgs","repos_url":"https://api.github.com/users/tkreuzer/repos","events_url":"https://api.github.com/users/tkreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/tkreuzer/received_events","type":"User","site_admin":false},"body":"[NTOS:MM] Pass page fault code to Mm(Arm)AccessFault and implement handling of NX faults\r\n","created_at":"2018-01-01T16:45:49Z","updated_at":"2018-01-01T17:36:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"274ed94599dbbe22661158f1c11f25910bbed7b1","assignee":{"login":"tkreuzer","id":313067,"avatar_url":"https://avatars1.githubusercontent.com/u/313067?v=4","gravatar_id":"","url":"https://api.github.com/users/tkreuzer","html_url":"https://github.com/tkreuzer","followers_url":"https://api.github.com/users/tkreuzer/followers","following_url":"https://api.github.com/users/tkreuzer/following{/other_user}","gists_url":"https://api.github.com/users/tkreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkreuzer/subscriptions","organizations_url":"https://api.github.com/users/tkreuzer/orgs","repos_url":"https://api.github.com/users/tkreuzer/repos","events_url":"https://api.github.com/users/tkreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/tkreuzer/received_events","type":"User","site_admin":false},"assignees":[{"login":"tkreuzer","id":313067,"avatar_url":"https://avatars1.githubusercontent.com/u/313067?v=4","gravatar_id":"","url":"https://api.github.com/users/tkreuzer","html_url":"https://github.com/tkreuzer","followers_url":"https://api.github.com/users/tkreuzer/followers","following_url":"https://api.github.com/users/tkreuzer/following{/other_user}","gists_url":"https://api.github.com/users/tkreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkreuzer/subscriptions","organizations_url":"https://api.github.com/users/tkreuzer/orgs","repos_url":"https://api.github.com/users/tkreuzer/repos","events_url":"https://api.github.com/users/tkreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/tkreuzer/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zefklop","id":1056020,"avatar_url":"https://avatars0.githubusercontent.com/u/1056020?v=4","gravatar_id":"","url":"https://api.github.com/users/zefklop","html_url":"https://github.com/zefklop","followers_url":"https://api.github.com/users/zefklop/followers","following_url":"https://api.github.com/users/zefklop/following{/other_user}","gists_url":"https://api.github.com/users/zefklop/gists{/gist_id}","starred_url":"https://api.github.com/users/zefklop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zefklop/subscriptions","organizations_url":"https://api.github.com/users/zefklop/orgs","repos_url":"https://api.github.com/users/zefklop/repos","events_url":"https://api.github.com/users/zefklop/events{/privacy}","received_events_url":"https://api.github.com/users/zefklop/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/256/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/256/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/256/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/bee29ef499f7ffd6946650ef852ce09691a21f7e","head":{"label":"tkreuzer:amd64/pagefault_NX","ref":"amd64/pagefault_NX","sha":"bee29ef499f7ffd6946650ef852ce09691a21f7e","user":{"login":"tkreuzer","id":313067,"avatar_url":"https://avatars1.githubusercontent.com/u/313067?v=4","gravatar_id":"","url":"https://api.github.com/users/tkreuzer","html_url":"https://github.com/tkreuzer","followers_url":"https://api.github.com/users/tkreuzer/followers","following_url":"https://api.github.com/users/tkreuzer/following{/other_user}","gists_url":"https://api.github.com/users/tkreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkreuzer/subscriptions","organizations_url":"https://api.github.com/users/tkreuzer/orgs","repos_url":"https://api.github.com/users/tkreuzer/repos","events_url":"https://api.github.com/users/tkreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/tkreuzer/received_events","type":"User","site_admin":false},"repo":{"id":105639030,"name":"reactos","full_name":"tkreuzer/reactos","owner":{"login":"tkreuzer","id":313067,"avatar_url":"https://avatars1.githubusercontent.com/u/313067?v=4","gravatar_id":"","url":"https://api.github.com/users/tkreuzer","html_url":"https://github.com/tkreuzer","followers_url":"https://api.github.com/users/tkreuzer/followers","following_url":"https://api.github.com/users/tkreuzer/following{/other_user}","gists_url":"https://api.github.com/users/tkreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/tkreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkreuzer/subscriptions","organizations_url":"https://api.github.com/users/tkreuzer/orgs","repos_url":"https://api.github.com/users/tkreuzer/repos","events_url":"https://api.github.com/users/tkreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/tkreuzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkreuzer/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/tkreuzer/reactos","forks_url":"https://api.github.com/repos/tkreuzer/reactos/forks","keys_url":"https://api.github.com/repos/tkreuzer/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkreuzer/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkreuzer/reactos/teams","hooks_url":"https://api.github.com/repos/tkreuzer/reactos/hooks","issue_events_url":"https://api.github.com/repos/tkreuzer/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/tkreuzer/reactos/events","assignees_url":"https://api.github.com/repos/tkreuzer/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/tkreuzer/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/tkreuzer/reactos/tags","blobs_url":"https://api.github.com/repos/tkreuzer/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkreuzer/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkreuzer/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkreuzer/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkreuzer/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/tkreuzer/reactos/languages","stargazers_url":"https://api.github.com/repos/tkreuzer/reactos/stargazers","contributors_url":"https://api.github.com/repos/tkreuzer/reactos/contributors","subscribers_url":"https://api.github.com/repos/tkreuzer/reactos/subscribers","subscription_url":"https://api.github.com/repos/tkreuzer/reactos/subscription","commits_url":"https://api.github.com/repos/tkreuzer/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkreuzer/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkreuzer/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkreuzer/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkreuzer/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/tkreuzer/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkreuzer/reactos/merges","archive_url":"https://api.github.com/repos/tkreuzer/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkreuzer/reactos/downloads","issues_url":"https://api.github.com/repos/tkreuzer/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/tkreuzer/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/tkreuzer/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/tkreuzer/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkreuzer/reactos/labels{/name}","releases_url":"https://api.github.com/repos/tkreuzer/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/tkreuzer/reactos/deployments","created_at":"2017-10-03T10:25:57Z","updated_at":"2017-10-03T10:28:25Z","pushed_at":"2018-01-01T16:42:01Z","git_url":"git://github.com/tkreuzer/reactos.git","ssh_url":"git@github.com:tkreuzer/reactos.git","clone_url":"https://github.com/tkreuzer/reactos.git","svn_url":"https://github.com/tkreuzer/reactos","homepage":null,"size":461675,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"2b4d5c5cffe649845f552440a076b269a0aec339","user":{"login":"reactos","id":1056157,"avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"name":"reactos","full_name":"reactos/reactos","owner":{"login":"reactos","id":1056157,"avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-01-01T14:00:30Z","pushed_at":"2018-01-01T17:35:58Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":461269,"stargazers_count":3008,"watchers_count":3008,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":161,"open_issues":40,"watchers":3008,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/256"},"html":{"href":"https://github.com/reactos/reactos/pull/256"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/256"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/bee29ef499f7ffd6946650ef852ce09691a21f7e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ThFabba"}}