{"action":"created","comment":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments/111094872","pull_request_review_id":32307171,"id":111094872,"diff_hunk":"@@ -933,14 +1339,19 @@ Blocks.prototype.loadBlocksOffset = function (limit, offset, verify, cb) {\n \n \t\t\t\t\tif (!check.verified) {\n \t\t\t\t\t\tlibrary.logger.error(['Block', block.id, 'verification failed'].join(' '), check.errors.join(', '));\n+\t\t\t\t\t\t// Return first error from checks\n \t\t\t\t\t\treturn setImmediate(cb, check.errors[0]);\n \t\t\t\t\t}\n \t\t\t\t}\n \t\t\t\tif (block.id === genesisblock.block.id) {\n \t\t\t\t\t__private.applyGenesisBlock(block, cb);\n \t\t\t\t} else {\n+\t\t\t\t\t// Apply block - broadcast: false, saveBlock: false\n+\t\t\t\t\t// FIXME: Looks like we missing some validations here, because applyBlock is different than processBlock used elesewhere\n+\t\t\t\t\t// - that need to be checked and adjusted to be consistent","path":"modules/blocks.js","position":932,"original_position":932,"commit_id":"4fa59d97c087c45c03d3e5ecf6175f8f2ce72146","original_commit_id":"4fa59d97c087c45c03d3e5ecf6175f8f2ce72146","user":{"login":"Isabello","id":16565680,"avatar_url":"https://avatars2.githubusercontent.com/u/16565680?v=3","gravatar_id":"","url":"https://api.github.com/users/Isabello","html_url":"https://github.com/Isabello","followers_url":"https://api.github.com/users/Isabello/followers","following_url":"https://api.github.com/users/Isabello/following{/other_user}","gists_url":"https://api.github.com/users/Isabello/gists{/gist_id}","starred_url":"https://api.github.com/users/Isabello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Isabello/subscriptions","organizations_url":"https://api.github.com/users/Isabello/orgs","repos_url":"https://api.github.com/users/Isabello/repos","events_url":"https://api.github.com/users/Isabello/events{/privacy}","received_events_url":"https://api.github.com/users/Isabello/received_events","type":"User","site_admin":false},"body":"Consistency should be verified and fixed ","created_at":"2017-04-12T08:49:59Z","updated_at":"2017-04-12T08:51:25Z","html_url":"https://github.com/LiskHQ/lisk/pull/553#discussion_r111094872","pull_request_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/553","_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments/111094872"},"html":{"href":"https://github.com/LiskHQ/lisk/pull/553#discussion_r111094872"},"pull_request":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/553"}}},"pull_request":{"url":"https://api.github.com/repos/LiskHQ/lisk/pulls/553","id":115481086,"html_url":"https://github.com/LiskHQ/lisk/pull/553","diff_url":"https://github.com/LiskHQ/lisk/pull/553.diff","patch_url":"https://github.com/LiskHQ/lisk/pull/553.patch","issue_url":"https://api.github.com/repos/LiskHQ/lisk/issues/553","number":553,"state":"open","locked":false,"title":"Initial documentation for blocks module","user":{"login":"4miners","id":22824146,"avatar_url":"https://avatars3.githubusercontent.com/u/22824146?v=3","gravatar_id":"","url":"https://api.github.com/users/4miners","html_url":"https://github.com/4miners","followers_url":"https://api.github.com/users/4miners/followers","following_url":"https://api.github.com/users/4miners/following{/other_user}","gists_url":"https://api.github.com/users/4miners/gists{/gist_id}","starred_url":"https://api.github.com/users/4miners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4miners/subscriptions","organizations_url":"https://api.github.com/users/4miners/orgs","repos_url":"https://api.github.com/users/4miners/repos","events_url":"https://api.github.com/users/4miners/events{/privacy}","received_events_url":"https://api.github.com/users/4miners/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-12T07:41:00Z","updated_at":"2017-04-12T08:51:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b361e439e990792daad4c64987d6b45d073b0321","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/553/commits","review_comments_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/553/comments","review_comment_url":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/issues/553/comments","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/4fa59d97c087c45c03d3e5ecf6175f8f2ce72146","head":{"label":"4miners:542-jsdoc","ref":"542-jsdoc","sha":"4fa59d97c087c45c03d3e5ecf6175f8f2ce72146","user":{"login":"4miners","id":22824146,"avatar_url":"https://avatars3.githubusercontent.com/u/22824146?v=3","gravatar_id":"","url":"https://api.github.com/users/4miners","html_url":"https://github.com/4miners","followers_url":"https://api.github.com/users/4miners/followers","following_url":"https://api.github.com/users/4miners/following{/other_user}","gists_url":"https://api.github.com/users/4miners/gists{/gist_id}","starred_url":"https://api.github.com/users/4miners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4miners/subscriptions","organizations_url":"https://api.github.com/users/4miners/orgs","repos_url":"https://api.github.com/users/4miners/repos","events_url":"https://api.github.com/users/4miners/events{/privacy}","received_events_url":"https://api.github.com/users/4miners/received_events","type":"User","site_admin":false},"repo":{"id":74883233,"name":"lisk","full_name":"4miners/lisk","owner":{"login":"4miners","id":22824146,"avatar_url":"https://avatars3.githubusercontent.com/u/22824146?v=3","gravatar_id":"","url":"https://api.github.com/users/4miners","html_url":"https://github.com/4miners","followers_url":"https://api.github.com/users/4miners/followers","following_url":"https://api.github.com/users/4miners/following{/other_user}","gists_url":"https://api.github.com/users/4miners/gists{/gist_id}","starred_url":"https://api.github.com/users/4miners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4miners/subscriptions","organizations_url":"https://api.github.com/users/4miners/orgs","repos_url":"https://api.github.com/users/4miners/repos","events_url":"https://api.github.com/users/4miners/events{/privacy}","received_events_url":"https://api.github.com/users/4miners/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/4miners/lisk","description":"Lisk blockchain application platform and crypto-currency","fork":true,"url":"https://api.github.com/repos/4miners/lisk","forks_url":"https://api.github.com/repos/4miners/lisk/forks","keys_url":"https://api.github.com/repos/4miners/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/4miners/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/4miners/lisk/teams","hooks_url":"https://api.github.com/repos/4miners/lisk/hooks","issue_events_url":"https://api.github.com/repos/4miners/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/4miners/lisk/events","assignees_url":"https://api.github.com/repos/4miners/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/4miners/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/4miners/lisk/tags","blobs_url":"https://api.github.com/repos/4miners/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/4miners/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/4miners/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/4miners/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/4miners/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/4miners/lisk/languages","stargazers_url":"https://api.github.com/repos/4miners/lisk/stargazers","contributors_url":"https://api.github.com/repos/4miners/lisk/contributors","subscribers_url":"https://api.github.com/repos/4miners/lisk/subscribers","subscription_url":"https://api.github.com/repos/4miners/lisk/subscription","commits_url":"https://api.github.com/repos/4miners/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/4miners/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/4miners/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/4miners/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/4miners/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/4miners/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/4miners/lisk/merges","archive_url":"https://api.github.com/repos/4miners/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/4miners/lisk/downloads","issues_url":"https://api.github.com/repos/4miners/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/4miners/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/4miners/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/4miners/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/4miners/lisk/labels{/name}","releases_url":"https://api.github.com/repos/4miners/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/4miners/lisk/deployments","created_at":"2016-11-27T11:23:58Z","updated_at":"2016-11-27T11:24:00Z","pushed_at":"2017-04-12T07:38:16Z","git_url":"git://github.com/4miners/lisk.git","ssh_url":"git@github.com:4miners/lisk.git","clone_url":"https://github.com/4miners/lisk.git","svn_url":"https://github.com/4miners/lisk","homepage":"https://lisk.io/","size":4127,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"LiskHQ:542-jsdoc","ref":"542-jsdoc","sha":"440cc780a07a9e8ee3d7ef909f19007bbdc45617","user":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars2.githubusercontent.com/u/16600915?v=3","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":50873641,"name":"lisk","full_name":"LiskHQ/lisk","owner":{"login":"LiskHQ","id":16600915,"avatar_url":"https://avatars2.githubusercontent.com/u/16600915?v=3","gravatar_id":"","url":"https://api.github.com/users/LiskHQ","html_url":"https://github.com/LiskHQ","followers_url":"https://api.github.com/users/LiskHQ/followers","following_url":"https://api.github.com/users/LiskHQ/following{/other_user}","gists_url":"https://api.github.com/users/LiskHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LiskHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiskHQ/subscriptions","organizations_url":"https://api.github.com/users/LiskHQ/orgs","repos_url":"https://api.github.com/users/LiskHQ/repos","events_url":"https://api.github.com/users/LiskHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LiskHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LiskHQ/lisk","description":"📟 Lisk cryptocurrency and blockchain application platform","fork":false,"url":"https://api.github.com/repos/LiskHQ/lisk","forks_url":"https://api.github.com/repos/LiskHQ/lisk/forks","keys_url":"https://api.github.com/repos/LiskHQ/lisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LiskHQ/lisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LiskHQ/lisk/teams","hooks_url":"https://api.github.com/repos/LiskHQ/lisk/hooks","issue_events_url":"https://api.github.com/repos/LiskHQ/lisk/issues/events{/number}","events_url":"https://api.github.com/repos/LiskHQ/lisk/events","assignees_url":"https://api.github.com/repos/LiskHQ/lisk/assignees{/user}","branches_url":"https://api.github.com/repos/LiskHQ/lisk/branches{/branch}","tags_url":"https://api.github.com/repos/LiskHQ/lisk/tags","blobs_url":"https://api.github.com/repos/LiskHQ/lisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LiskHQ/lisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LiskHQ/lisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/LiskHQ/lisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LiskHQ/lisk/statuses/{sha}","languages_url":"https://api.github.com/repos/LiskHQ/lisk/languages","stargazers_url":"https://api.github.com/repos/LiskHQ/lisk/stargazers","contributors_url":"https://api.github.com/repos/LiskHQ/lisk/contributors","subscribers_url":"https://api.github.com/repos/LiskHQ/lisk/subscribers","subscription_url":"https://api.github.com/repos/LiskHQ/lisk/subscription","commits_url":"https://api.github.com/repos/LiskHQ/lisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/LiskHQ/lisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/LiskHQ/lisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/LiskHQ/lisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/LiskHQ/lisk/contents/{+path}","compare_url":"https://api.github.com/repos/LiskHQ/lisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LiskHQ/lisk/merges","archive_url":"https://api.github.com/repos/LiskHQ/lisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LiskHQ/lisk/downloads","issues_url":"https://api.github.com/repos/LiskHQ/lisk/issues{/number}","pulls_url":"https://api.github.com/repos/LiskHQ/lisk/pulls{/number}","milestones_url":"https://api.github.com/repos/LiskHQ/lisk/milestones{/number}","notifications_url":"https://api.github.com/repos/LiskHQ/lisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LiskHQ/lisk/labels{/name}","releases_url":"https://api.github.com/repos/LiskHQ/lisk/releases{/id}","deployments_url":"https://api.github.com/repos/LiskHQ/lisk/deployments","created_at":"2016-02-01T21:45:35Z","updated_at":"2017-04-08T11:08:17Z","pushed_at":"2017-04-12T08:48:45Z","git_url":"git://github.com/LiskHQ/lisk.git","ssh_url":"git@github.com:LiskHQ/lisk.git","clone_url":"https://github.com/LiskHQ/lisk.git","svn_url":"https://github.com/LiskHQ/lisk","homepage":"https://lisk.io/","size":4233,"stargazers_count":192,"watchers_count":192,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":73,"forks":76,"open_issues":73,"watchers":192,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/553"},"html":{"href":"https://github.com/LiskHQ/lisk/pull/553"},"issue":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/553"},"comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/issues/553/comments"},"review_comments":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/553/comments"},"review_comment":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LiskHQ/lisk/pulls/553/commits"},"statuses":{"href":"https://api.github.com/repos/LiskHQ/lisk/statuses/4fa59d97c087c45c03d3e5ecf6175f8f2ce72146"}}}}
{"actor":{"display_login":"Isabello"}}