{"action":"created","issue":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/11078","repository_url":"https://api.github.com/repos/mrdoob/three.js","labels_url":"https://api.github.com/repos/mrdoob/three.js/issues/11078/labels{/name}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/11078/comments","events_url":"https://api.github.com/repos/mrdoob/three.js/issues/11078/events","html_url":"https://github.com/mrdoob/three.js/pull/11078","id":217595519,"number":11078,"title":"Docs: index.html refactored","user":{"login":"jostschmithals","id":5700294,"avatar_url":"https://avatars2.githubusercontent.com/u/5700294?v=3","gravatar_id":"","url":"https://api.github.com/users/jostschmithals","html_url":"https://github.com/jostschmithals","followers_url":"https://api.github.com/users/jostschmithals/followers","following_url":"https://api.github.com/users/jostschmithals/following{/other_user}","gists_url":"https://api.github.com/users/jostschmithals/gists{/gist_id}","starred_url":"https://api.github.com/users/jostschmithals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jostschmithals/subscriptions","organizations_url":"https://api.github.com/users/jostschmithals/orgs","repos_url":"https://api.github.com/users/jostschmithals/repos","events_url":"https://api.github.com/users/jostschmithals/events{/privacy}","received_events_url":"https://api.github.com/users/jostschmithals/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-03-28T15:16:33Z","updated_at":"2017-04-01T00:01:38Z","closed_at":"2017-04-01T00:01:31Z","pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/11078","html_url":"https://github.com/mrdoob/three.js/pull/11078","diff_url":"https://github.com/mrdoob/three.js/pull/11078.diff","patch_url":"https://github.com/mrdoob/three.js/pull/11078.patch"},"body":"This PR with a complete refactoring of the doc’s index.html (and some additional changes in the associated files) was done to handle the following issues:\r\n\r\n-\tVisitors coming from google are trapped on the subpages (links not working, no navigation panel) #10937\r\n-\tThe path structure of the URL fragments used by index.html for the iframes is different from the original path structure of the subpages (for example ... docs/api/renderers/webgl/plugins/LensFlarePlugin.html \r\nvs. … docs/#Developer_Reference/WebGLRenderer.Plugins/LensFlarePlugin https://github.com/mrdoob/three.js/pull/10948#issuecomment-288449044\r\n-\tBrowser navigation (back/forward arrows) is not working #11052\r\n- Right click on a link in the navigation panel displays in the new tab only the navigation panel with a blank content area, instead of the correct content\r\n-\tThe status bar displays `https://threejs.org.docs/#`, when clicking a link in the navigation panel (which is useless), and it displays `javascript:window.parent.goTo(‘…’)`, when clicking on a link in the content area - which is irritating especially in those cases where instead of moving to another content  only a tooltip with the basic JavaScript type (“Float”, “Array”) is displayed\r\n-\tSome other (minor) issues\r\n\r\n_(List edited after review)_\r\n\r\nOn this occasion I tried to make the whole code structure more transparent and to improve the code style, too (see #11073).\r\n\r\nEspecially Edge was behaving differently in several cases. So there are some things in the code a little more inconvenient than it actually should have been. I hope, this is now working in all browsers (not only on Windows?). \r\n\r\nPlease test it and find the bugs ;-) \r\n\r\n-----\r\n\r\nLinks to subpages without navigation like\r\n… `docs/api/core/Geometry.html`\r\nare now displayed as iframes of the index page, the URL fragment reflecting the original path structure:\r\n... `docs/#api/core/Geometry`\r\n\r\nLinks to anchors in subpages like \r\n… `docs/api/core/Geometry.html#morphTargets`\r\nare now displayed as \r\n... `docs/#api/core/Geometry.morphTargets`\r\nsince '#' is not allowed inside an URL fragment (according to RFC 3986)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mrdoob/three.js/issues/comments/290873169","html_url":"https://github.com/mrdoob/three.js/pull/11078#issuecomment-290873169","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/11078","id":290873169,"user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars3.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"created_at":"2017-04-01T00:01:38Z","updated_at":"2017-04-01T00:01:38Z","body":"Thanks!"}}
{"actor":{"display_login":"mrdoob"}}