{"action":"created","comment":{"url":"https://api.github.com/repos/NetSys/quilt/pulls/comments/95021012","pull_request_review_id":15567385,"id":95021012,"diff_hunk":"@@ -363,11 +363,17 @@ OuterLoop:\n ","path":"cluster/amazon/amazon.go","position":1,"original_position":1,"commit_id":"e94b3ff1bdb3526625efa8f1f21b6de785ccdd1a","original_commit_id":"e94b3ff1bdb3526625efa8f1f21b6de785ccdd1a","user":{"login":"mmussomele","id":8631959,"avatar_url":"https://avatars.githubusercontent.com/u/8631959?v=3","gravatar_id":"","url":"https://api.github.com/users/mmussomele","html_url":"https://github.com/mmussomele","followers_url":"https://api.github.com/users/mmussomele/followers","following_url":"https://api.github.com/users/mmussomele/following{/other_user}","gists_url":"https://api.github.com/users/mmussomele/gists{/gist_id}","starred_url":"https://api.github.com/users/mmussomele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmussomele/subscriptions","organizations_url":"https://api.github.com/users/mmussomele/orgs","repos_url":"https://api.github.com/users/mmussomele/repos","events_url":"https://api.github.com/users/mmussomele/events{/privacy}","received_events_url":"https://api.github.com/users/mmussomele/received_events","type":"User","site_admin":false},"body":"Yea I'll reword it","created_at":"2017-01-06T21:12:31Z","updated_at":"2017-01-06T21:12:31Z","html_url":"https://github.com/NetSys/quilt/pull/684#discussion_r95021012","pull_request_url":"https://api.github.com/repos/NetSys/quilt/pulls/684","_links":{"self":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/comments/95021012"},"html":{"href":"https://github.com/NetSys/quilt/pull/684#discussion_r95021012"},"pull_request":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/684"}}},"pull_request":{"url":"https://api.github.com/repos/NetSys/quilt/pulls/684","id":100391211,"html_url":"https://github.com/NetSys/quilt/pull/684","diff_url":"https://github.com/NetSys/quilt/pull/684.diff","patch_url":"https://github.com/NetSys/quilt/pull/684.patch","issue_url":"https://api.github.com/repos/NetSys/quilt/issues/684","number":684,"state":"open","locked":false,"title":"amazon: Change wait to require machines to be instantiated","user":{"login":"mmussomele","id":8631959,"avatar_url":"https://avatars.githubusercontent.com/u/8631959?v=3","gravatar_id":"","url":"https://api.github.com/users/mmussomele","html_url":"https://github.com/mmussomele","followers_url":"https://api.github.com/users/mmussomele/followers","following_url":"https://api.github.com/users/mmussomele/following{/other_user}","gists_url":"https://api.github.com/users/mmussomele/gists{/gist_id}","starred_url":"https://api.github.com/users/mmussomele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmussomele/subscriptions","organizations_url":"https://api.github.com/users/mmussomele/orgs","repos_url":"https://api.github.com/users/mmussomele/repos","events_url":"https://api.github.com/users/mmussomele/events{/privacy}","received_events_url":"https://api.github.com/users/mmussomele/received_events","type":"User","site_admin":false},"body":"When listing machines on Amazon, it was possible to get a response\r\nbetween the assignment of cloud IDs but before fields such as the\r\nmachine's IP and size were filled in on Amazon's end. This caused\r\nthe cluster's join to fail, booting twice as many machines as needed.\r\nThe Amazon wait() function now requires machines to have both a\r\ncloud ID and a size before returning.","created_at":"2017-01-06T00:37:28Z","updated_at":"2017-01-06T21:12:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b17e2697d07d89de060d3a265efd0a529d641a2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetSys/quilt/pulls/684/commits","review_comments_url":"https://api.github.com/repos/NetSys/quilt/pulls/684/comments","review_comment_url":"https://api.github.com/repos/NetSys/quilt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetSys/quilt/issues/684/comments","statuses_url":"https://api.github.com/repos/NetSys/quilt/statuses/e94b3ff1bdb3526625efa8f1f21b6de785ccdd1a","head":{"label":"mmussomele:wait","ref":"wait","sha":"e94b3ff1bdb3526625efa8f1f21b6de785ccdd1a","user":{"login":"mmussomele","id":8631959,"avatar_url":"https://avatars.githubusercontent.com/u/8631959?v=3","gravatar_id":"","url":"https://api.github.com/users/mmussomele","html_url":"https://github.com/mmussomele","followers_url":"https://api.github.com/users/mmussomele/followers","following_url":"https://api.github.com/users/mmussomele/following{/other_user}","gists_url":"https://api.github.com/users/mmussomele/gists{/gist_id}","starred_url":"https://api.github.com/users/mmussomele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmussomele/subscriptions","organizations_url":"https://api.github.com/users/mmussomele/orgs","repos_url":"https://api.github.com/users/mmussomele/repos","events_url":"https://api.github.com/users/mmussomele/events{/privacy}","received_events_url":"https://api.github.com/users/mmussomele/received_events","type":"User","site_admin":false},"repo":{"id":59638410,"name":"quilt","full_name":"mmussomele/quilt","owner":{"login":"mmussomele","id":8631959,"avatar_url":"https://avatars.githubusercontent.com/u/8631959?v=3","gravatar_id":"","url":"https://api.github.com/users/mmussomele","html_url":"https://github.com/mmussomele","followers_url":"https://api.github.com/users/mmussomele/followers","following_url":"https://api.github.com/users/mmussomele/following{/other_user}","gists_url":"https://api.github.com/users/mmussomele/gists{/gist_id}","starred_url":"https://api.github.com/users/mmussomele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmussomele/subscriptions","organizations_url":"https://api.github.com/users/mmussomele/orgs","repos_url":"https://api.github.com/users/mmussomele/repos","events_url":"https://api.github.com/users/mmussomele/events{/privacy}","received_events_url":"https://api.github.com/users/mmussomele/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmussomele/quilt","description":"Quilt","fork":true,"url":"https://api.github.com/repos/mmussomele/quilt","forks_url":"https://api.github.com/repos/mmussomele/quilt/forks","keys_url":"https://api.github.com/repos/mmussomele/quilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmussomele/quilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmussomele/quilt/teams","hooks_url":"https://api.github.com/repos/mmussomele/quilt/hooks","issue_events_url":"https://api.github.com/repos/mmussomele/quilt/issues/events{/number}","events_url":"https://api.github.com/repos/mmussomele/quilt/events","assignees_url":"https://api.github.com/repos/mmussomele/quilt/assignees{/user}","branches_url":"https://api.github.com/repos/mmussomele/quilt/branches{/branch}","tags_url":"https://api.github.com/repos/mmussomele/quilt/tags","blobs_url":"https://api.github.com/repos/mmussomele/quilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmussomele/quilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmussomele/quilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmussomele/quilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmussomele/quilt/statuses/{sha}","languages_url":"https://api.github.com/repos/mmussomele/quilt/languages","stargazers_url":"https://api.github.com/repos/mmussomele/quilt/stargazers","contributors_url":"https://api.github.com/repos/mmussomele/quilt/contributors","subscribers_url":"https://api.github.com/repos/mmussomele/quilt/subscribers","subscription_url":"https://api.github.com/repos/mmussomele/quilt/subscription","commits_url":"https://api.github.com/repos/mmussomele/quilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmussomele/quilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmussomele/quilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmussomele/quilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmussomele/quilt/contents/{+path}","compare_url":"https://api.github.com/repos/mmussomele/quilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmussomele/quilt/merges","archive_url":"https://api.github.com/repos/mmussomele/quilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmussomele/quilt/downloads","issues_url":"https://api.github.com/repos/mmussomele/quilt/issues{/number}","pulls_url":"https://api.github.com/repos/mmussomele/quilt/pulls{/number}","milestones_url":"https://api.github.com/repos/mmussomele/quilt/milestones{/number}","notifications_url":"https://api.github.com/repos/mmussomele/quilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmussomele/quilt/labels{/name}","releases_url":"https://api.github.com/repos/mmussomele/quilt/releases{/id}","deployments_url":"https://api.github.com/repos/mmussomele/quilt/deployments","created_at":"2016-05-25T06:53:25Z","updated_at":"2016-10-24T07:59:43Z","pushed_at":"2017-01-06T18:31:16Z","git_url":"git://github.com/mmussomele/quilt.git","ssh_url":"git@github.com:mmussomele/quilt.git","clone_url":"https://github.com/mmussomele/quilt.git","svn_url":"https://github.com/mmussomele/quilt","homepage":"","size":17905,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NetSys:master","ref":"master","sha":"3bb02e6467a849e6250a9a68c5814c2a8a949f61","user":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"repo":{"id":43390663,"name":"quilt","full_name":"NetSys/quilt","owner":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetSys/quilt","description":"Quilt","fork":false,"url":"https://api.github.com/repos/NetSys/quilt","forks_url":"https://api.github.com/repos/NetSys/quilt/forks","keys_url":"https://api.github.com/repos/NetSys/quilt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetSys/quilt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetSys/quilt/teams","hooks_url":"https://api.github.com/repos/NetSys/quilt/hooks","issue_events_url":"https://api.github.com/repos/NetSys/quilt/issues/events{/number}","events_url":"https://api.github.com/repos/NetSys/quilt/events","assignees_url":"https://api.github.com/repos/NetSys/quilt/assignees{/user}","branches_url":"https://api.github.com/repos/NetSys/quilt/branches{/branch}","tags_url":"https://api.github.com/repos/NetSys/quilt/tags","blobs_url":"https://api.github.com/repos/NetSys/quilt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetSys/quilt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetSys/quilt/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetSys/quilt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetSys/quilt/statuses/{sha}","languages_url":"https://api.github.com/repos/NetSys/quilt/languages","stargazers_url":"https://api.github.com/repos/NetSys/quilt/stargazers","contributors_url":"https://api.github.com/repos/NetSys/quilt/contributors","subscribers_url":"https://api.github.com/repos/NetSys/quilt/subscribers","subscription_url":"https://api.github.com/repos/NetSys/quilt/subscription","commits_url":"https://api.github.com/repos/NetSys/quilt/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetSys/quilt/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetSys/quilt/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetSys/quilt/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetSys/quilt/contents/{+path}","compare_url":"https://api.github.com/repos/NetSys/quilt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetSys/quilt/merges","archive_url":"https://api.github.com/repos/NetSys/quilt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetSys/quilt/downloads","issues_url":"https://api.github.com/repos/NetSys/quilt/issues{/number}","pulls_url":"https://api.github.com/repos/NetSys/quilt/pulls{/number}","milestones_url":"https://api.github.com/repos/NetSys/quilt/milestones{/number}","notifications_url":"https://api.github.com/repos/NetSys/quilt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetSys/quilt/labels{/name}","releases_url":"https://api.github.com/repos/NetSys/quilt/releases{/id}","deployments_url":"https://api.github.com/repos/NetSys/quilt/deployments","created_at":"2015-09-29T19:52:32Z","updated_at":"2017-01-04T23:53:30Z","pushed_at":"2017-01-06T20:59:16Z","git_url":"git://github.com/NetSys/quilt.git","ssh_url":"git@github.com:NetSys/quilt.git","clone_url":"https://github.com/NetSys/quilt.git","svn_url":"https://github.com/NetSys/quilt","homepage":"","size":17609,"stargazers_count":63,"watchers_count":63,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":9,"forks":21,"open_issues":9,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/684"},"html":{"href":"https://github.com/NetSys/quilt/pull/684"},"issue":{"href":"https://api.github.com/repos/NetSys/quilt/issues/684"},"comments":{"href":"https://api.github.com/repos/NetSys/quilt/issues/684/comments"},"review_comments":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/684/comments"},"review_comment":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetSys/quilt/pulls/684/commits"},"statuses":{"href":"https://api.github.com/repos/NetSys/quilt/statuses/e94b3ff1bdb3526625efa8f1f21b6de785ccdd1a"}}}}
{"actor":{"display_login":"mmussomele"}}