{"action":"created","issue":{"url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/53","repository_url":"https://api.github.com/repos/xwp/wp-core-media-widgets","labels_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/53/comments","events_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/53/events","html_url":"https://github.com/xwp/wp-core-media-widgets/pull/53","id":220073906,"number":53,"title":"Add media-video-widget","user":{"login":"timmyc","id":22080,"avatar_url":"https://avatars3.githubusercontent.com/u/22080?v=3","gravatar_id":"","url":"https://api.github.com/users/timmyc","html_url":"https://github.com/timmyc","followers_url":"https://api.github.com/users/timmyc/followers","following_url":"https://api.github.com/users/timmyc/following{/other_user}","gists_url":"https://api.github.com/users/timmyc/gists{/gist_id}","starred_url":"https://api.github.com/users/timmyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmyc/subscriptions","organizations_url":"https://api.github.com/users/timmyc/orgs","repos_url":"https://api.github.com/users/timmyc/repos","events_url":"https://api.github.com/users/timmyc/events{/privacy}","received_events_url":"https://api.github.com/users/timmyc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2017-04-07T00:35:27Z","updated_at":"2017-04-14T10:21:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xwp/wp-core-media-widgets/pulls/53","html_url":"https://github.com/xwp/wp-core-media-widgets/pull/53","diff_url":"https://github.com/xwp/wp-core-media-widgets/pull/53.diff","patch_url":"https://github.com/xwp/wp-core-media-widgets/pull/53.patch"},"body":"Closes #32\r\n\r\nStill very much a work-in-progress\r\n\r\nTODO\r\n- [ ] Add qunit tests\r\n- [x] Add phpunit test coverage\r\n- [x] Fix preview rendering\r\n- [ ] Determine which media states to track in `editMedia` ( add-video-source, select-poster-image, add-track )\r\n- [ ] Placeholder image to be shown while poster image loads\r\n- [ ] Fallback icon/image for external videos other than YouTube and Vimeo\r\n- [ ] Show preview of embed in “Insert from URL” frame. At least a poster frame should be shown while we wait for an embed proxy endpoint. Once there is an embed proxy endpoint, we might be able to override `EmbedLink#fetch` to source the data from the endpoint instead of from the `parse-embed` admin-ajax request, though presumably this would be done in core as well."},"comment":{"url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/comments/294131744","html_url":"https://github.com/xwp/wp-core-media-widgets/pull/53#issuecomment-294131744","issue_url":"https://api.github.com/repos/xwp/wp-core-media-widgets/issues/53","id":294131744,"user":{"login":"swissspidy","id":841956,"avatar_url":"https://avatars2.githubusercontent.com/u/841956?v=3","gravatar_id":"","url":"https://api.github.com/users/swissspidy","html_url":"https://github.com/swissspidy","followers_url":"https://api.github.com/users/swissspidy/followers","following_url":"https://api.github.com/users/swissspidy/following{/other_user}","gists_url":"https://api.github.com/users/swissspidy/gists{/gist_id}","starred_url":"https://api.github.com/users/swissspidy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swissspidy/subscriptions","organizations_url":"https://api.github.com/users/swissspidy/orgs","repos_url":"https://api.github.com/users/swissspidy/repos","events_url":"https://api.github.com/users/swissspidy/events{/privacy}","received_events_url":"https://api.github.com/users/swissspidy/received_events","type":"User","site_admin":false},"created_at":"2017-04-14T10:21:31Z","updated_at":"2017-04-14T10:21:31Z","body":"> I think the reason for why post_ID is required is because currently WP will cache oEmbed responses in postmeta\r\n\r\nThat's correct. There's a ticket for that though: https://core.trac.wordpress.org/ticket/34115\r\n\r\n> An oEmbed endpoint, via the REST API or via admin-ajax, would essentially be implementing the guts of `\\WP_oEmbed::get_html()`, minus the `data2html()` call at the end\r\n\r\nIndeed. We can extract that part into a new `\\WP_oEmbed::get_data()` method that can be used by a proxy endpoint. I'm happy to help with that if needed. It's probably easiest to do this in a core ticket."}}
{"actor":{"display_login":"swissspidy"}}