{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-github/pulls/comments/132748350","pull_request_review_id":55866335,"id":132748350,"diff_hunk":"@@ -281,7 +283,9 @@ func (c *Client) NewUploadRequest(urlStr string, reader io.Reader, size int64, m\n \t\treturn nil, err\n \t}\n \n-\tu := c.UploadURL.ResolveReference(rel)\n+\tu := *c.BaseURL","path":"github/github.go","position":34,"original_position":34,"commit_id":"9829b9e833bf57f5740e1bdacc9966baa10630cd","original_commit_id":"9829b9e833bf57f5740e1bdacc9966baa10630cd","user":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars3.githubusercontent.com/u/1924134?v=4","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"body":"I don't think it's valid to change `c.UploadURL` for `c.BaseURL`.","created_at":"2017-08-11T17:59:01Z","updated_at":"2017-08-11T17:59:01Z","html_url":"https://github.com/google/go-github/pull/690#discussion_r132748350","pull_request_url":"https://api.github.com/repos/google/go-github/pulls/690","_links":{"self":{"href":"https://api.github.com/repos/google/go-github/pulls/comments/132748350"},"html":{"href":"https://github.com/google/go-github/pull/690#discussion_r132748350"},"pull_request":{"href":"https://api.github.com/repos/google/go-github/pulls/690"}}},"pull_request":{"url":"https://api.github.com/repos/google/go-github/pulls/690","id":135350084,"html_url":"https://github.com/google/go-github/pull/690","diff_url":"https://github.com/google/go-github/pull/690.diff","patch_url":"https://github.com/google/go-github/pull/690.patch","issue_url":"https://api.github.com/repos/google/go-github/issues/690","number":690,"state":"open","locked":false,"title":"Fix so that BaseURL can be used without the trailing slash","user":{"login":"178inaba","id":12012186,"avatar_url":"https://avatars1.githubusercontent.com/u/12012186?v=4","gravatar_id":"","url":"https://api.github.com/users/178inaba","html_url":"https://github.com/178inaba","followers_url":"https://api.github.com/users/178inaba/followers","following_url":"https://api.github.com/users/178inaba/following{/other_user}","gists_url":"https://api.github.com/users/178inaba/gists{/gist_id}","starred_url":"https://api.github.com/users/178inaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/178inaba/subscriptions","organizations_url":"https://api.github.com/users/178inaba/orgs","repos_url":"https://api.github.com/users/178inaba/repos","events_url":"https://api.github.com/users/178inaba/events{/privacy}","received_events_url":"https://api.github.com/users/178inaba/received_events","type":"User","site_admin":false},"body":"If there is no trailing slash in BaseURL, I think that it is ideal to have the same result as when there is a trailing slash.","created_at":"2017-08-11T14:38:06Z","updated_at":"2017-08-11T17:59:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eb480cd992ae9b5c0a152db903523d878cd1956","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-github/pulls/690/commits","review_comments_url":"https://api.github.com/repos/google/go-github/pulls/690/comments","review_comment_url":"https://api.github.com/repos/google/go-github/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-github/issues/690/comments","statuses_url":"https://api.github.com/repos/google/go-github/statuses/9829b9e833bf57f5740e1bdacc9966baa10630cd","head":{"label":"178inaba:trailing_slash","ref":"trailing_slash","sha":"9829b9e833bf57f5740e1bdacc9966baa10630cd","user":{"login":"178inaba","id":12012186,"avatar_url":"https://avatars1.githubusercontent.com/u/12012186?v=4","gravatar_id":"","url":"https://api.github.com/users/178inaba","html_url":"https://github.com/178inaba","followers_url":"https://api.github.com/users/178inaba/followers","following_url":"https://api.github.com/users/178inaba/following{/other_user}","gists_url":"https://api.github.com/users/178inaba/gists{/gist_id}","starred_url":"https://api.github.com/users/178inaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/178inaba/subscriptions","organizations_url":"https://api.github.com/users/178inaba/orgs","repos_url":"https://api.github.com/users/178inaba/repos","events_url":"https://api.github.com/users/178inaba/events{/privacy}","received_events_url":"https://api.github.com/users/178inaba/received_events","type":"User","site_admin":false},"repo":{"id":100038676,"name":"go-github","full_name":"178inaba/go-github","owner":{"login":"178inaba","id":12012186,"avatar_url":"https://avatars1.githubusercontent.com/u/12012186?v=4","gravatar_id":"","url":"https://api.github.com/users/178inaba","html_url":"https://github.com/178inaba","followers_url":"https://api.github.com/users/178inaba/followers","following_url":"https://api.github.com/users/178inaba/following{/other_user}","gists_url":"https://api.github.com/users/178inaba/gists{/gist_id}","starred_url":"https://api.github.com/users/178inaba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/178inaba/subscriptions","organizations_url":"https://api.github.com/users/178inaba/orgs","repos_url":"https://api.github.com/users/178inaba/repos","events_url":"https://api.github.com/users/178inaba/events{/privacy}","received_events_url":"https://api.github.com/users/178inaba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/178inaba/go-github","description":"Go library for accessing the GitHub API","fork":true,"url":"https://api.github.com/repos/178inaba/go-github","forks_url":"https://api.github.com/repos/178inaba/go-github/forks","keys_url":"https://api.github.com/repos/178inaba/go-github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/178inaba/go-github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/178inaba/go-github/teams","hooks_url":"https://api.github.com/repos/178inaba/go-github/hooks","issue_events_url":"https://api.github.com/repos/178inaba/go-github/issues/events{/number}","events_url":"https://api.github.com/repos/178inaba/go-github/events","assignees_url":"https://api.github.com/repos/178inaba/go-github/assignees{/user}","branches_url":"https://api.github.com/repos/178inaba/go-github/branches{/branch}","tags_url":"https://api.github.com/repos/178inaba/go-github/tags","blobs_url":"https://api.github.com/repos/178inaba/go-github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/178inaba/go-github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/178inaba/go-github/git/refs{/sha}","trees_url":"https://api.github.com/repos/178inaba/go-github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/178inaba/go-github/statuses/{sha}","languages_url":"https://api.github.com/repos/178inaba/go-github/languages","stargazers_url":"https://api.github.com/repos/178inaba/go-github/stargazers","contributors_url":"https://api.github.com/repos/178inaba/go-github/contributors","subscribers_url":"https://api.github.com/repos/178inaba/go-github/subscribers","subscription_url":"https://api.github.com/repos/178inaba/go-github/subscription","commits_url":"https://api.github.com/repos/178inaba/go-github/commits{/sha}","git_commits_url":"https://api.github.com/repos/178inaba/go-github/git/commits{/sha}","comments_url":"https://api.github.com/repos/178inaba/go-github/comments{/number}","issue_comment_url":"https://api.github.com/repos/178inaba/go-github/issues/comments{/number}","contents_url":"https://api.github.com/repos/178inaba/go-github/contents/{+path}","compare_url":"https://api.github.com/repos/178inaba/go-github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/178inaba/go-github/merges","archive_url":"https://api.github.com/repos/178inaba/go-github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/178inaba/go-github/downloads","issues_url":"https://api.github.com/repos/178inaba/go-github/issues{/number}","pulls_url":"https://api.github.com/repos/178inaba/go-github/pulls{/number}","milestones_url":"https://api.github.com/repos/178inaba/go-github/milestones{/number}","notifications_url":"https://api.github.com/repos/178inaba/go-github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/178inaba/go-github/labels{/name}","releases_url":"https://api.github.com/repos/178inaba/go-github/releases{/id}","deployments_url":"https://api.github.com/repos/178inaba/go-github/deployments","created_at":"2017-08-11T14:13:18Z","updated_at":"2017-08-11T14:13:20Z","pushed_at":"2017-08-11T14:32:35Z","git_url":"git://github.com/178inaba/go-github.git","ssh_url":"git@github.com:178inaba/go-github.git","clone_url":"https://github.com/178inaba/go-github.git","svn_url":"https://github.com/178inaba/go-github","homepage":"http://godoc.org/github.com/google/go-github/github","size":1570,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e2cc29a3d2e4df2d76c1d847823d7ed081d7d1bd","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":10270722,"name":"go-github","full_name":"google/go-github","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/go-github","description":"Go library for accessing the GitHub API","fork":false,"url":"https://api.github.com/repos/google/go-github","forks_url":"https://api.github.com/repos/google/go-github/forks","keys_url":"https://api.github.com/repos/google/go-github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-github/teams","hooks_url":"https://api.github.com/repos/google/go-github/hooks","issue_events_url":"https://api.github.com/repos/google/go-github/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-github/events","assignees_url":"https://api.github.com/repos/google/go-github/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-github/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-github/tags","blobs_url":"https://api.github.com/repos/google/go-github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-github/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-github/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-github/languages","stargazers_url":"https://api.github.com/repos/google/go-github/stargazers","contributors_url":"https://api.github.com/repos/google/go-github/contributors","subscribers_url":"https://api.github.com/repos/google/go-github/subscribers","subscription_url":"https://api.github.com/repos/google/go-github/subscription","commits_url":"https://api.github.com/repos/google/go-github/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-github/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-github/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-github/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-github/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-github/merges","archive_url":"https://api.github.com/repos/google/go-github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-github/downloads","issues_url":"https://api.github.com/repos/google/go-github/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-github/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-github/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-github/labels{/name}","releases_url":"https://api.github.com/repos/google/go-github/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-github/deployments","created_at":"2013-05-24T16:42:58Z","updated_at":"2017-08-11T16:12:31Z","pushed_at":"2017-08-11T17:19:44Z","git_url":"git://github.com/google/go-github.git","ssh_url":"git@github.com:google/go-github.git","clone_url":"https://github.com/google/go-github.git","svn_url":"https://github.com/google/go-github","homepage":"http://godoc.org/github.com/google/go-github/github","size":1570,"stargazers_count":2797,"watchers_count":2797,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":657,"mirror_url":null,"open_issues_count":45,"forks":657,"open_issues":45,"watchers":2797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-github/pulls/690"},"html":{"href":"https://github.com/google/go-github/pull/690"},"issue":{"href":"https://api.github.com/repos/google/go-github/issues/690"},"comments":{"href":"https://api.github.com/repos/google/go-github/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-github/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-github/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-github/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-github/statuses/9829b9e833bf57f5740e1bdacc9966baa10630cd"}}}}
{"actor":{"display_login":"shurcooL"}}