{"action":"opened","number":1160,"pull_request":{"url":"https://api.github.com/repos/axios/axios/pulls/1160","id":150424259,"html_url":"https://github.com/axios/axios/pull/1160","diff_url":"https://github.com/axios/axios/pull/1160.diff","patch_url":"https://github.com/axios/axios/pull/1160.patch","issue_url":"https://api.github.com/repos/axios/axios/issues/1160","number":1160,"state":"open","locked":false,"title":"Move `window` defined check before window.XMLHttpRequest check","user":{"login":"owap","id":8496383,"avatar_url":"https://avatars0.githubusercontent.com/u/8496383?v=4","gravatar_id":"","url":"https://api.github.com/users/owap","html_url":"https://github.com/owap","followers_url":"https://api.github.com/users/owap/followers","following_url":"https://api.github.com/users/owap/following{/other_user}","gists_url":"https://api.github.com/users/owap/gists{/gist_id}","starred_url":"https://api.github.com/users/owap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owap/subscriptions","organizations_url":"https://api.github.com/users/owap/orgs","repos_url":"https://api.github.com/users/owap/repos","events_url":"https://api.github.com/users/owap/events{/privacy}","received_events_url":"https://api.github.com/users/owap/received_events","type":"User","site_admin":false},"body":"There was an error being thrown due to the fact that we were checking for the `XMLHttpRequest` property on the `window` object before asserting that `window` was defined.\r\n\r\nBuy moving the window defined check ahead of the `window.XMLHttpRequest` check, the error is eliminated!","created_at":"2017-11-02T22:58:49Z","updated_at":"2017-11-02T22:58:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/axios/axios/pulls/1160/commits","review_comments_url":"https://api.github.com/repos/axios/axios/pulls/1160/comments","review_comment_url":"https://api.github.com/repos/axios/axios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/axios/axios/issues/1160/comments","statuses_url":"https://api.github.com/repos/axios/axios/statuses/468e90993d4ee556a4cf414fb1d6b6f7b99ed98a","head":{"label":"owap:undefined-window","ref":"undefined-window","sha":"468e90993d4ee556a4cf414fb1d6b6f7b99ed98a","user":{"login":"owap","id":8496383,"avatar_url":"https://avatars0.githubusercontent.com/u/8496383?v=4","gravatar_id":"","url":"https://api.github.com/users/owap","html_url":"https://github.com/owap","followers_url":"https://api.github.com/users/owap/followers","following_url":"https://api.github.com/users/owap/following{/other_user}","gists_url":"https://api.github.com/users/owap/gists{/gist_id}","starred_url":"https://api.github.com/users/owap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owap/subscriptions","organizations_url":"https://api.github.com/users/owap/orgs","repos_url":"https://api.github.com/users/owap/repos","events_url":"https://api.github.com/users/owap/events{/privacy}","received_events_url":"https://api.github.com/users/owap/received_events","type":"User","site_admin":false},"repo":{"id":109326448,"name":"axios","full_name":"owap/axios","owner":{"login":"owap","id":8496383,"avatar_url":"https://avatars0.githubusercontent.com/u/8496383?v=4","gravatar_id":"","url":"https://api.github.com/users/owap","html_url":"https://github.com/owap","followers_url":"https://api.github.com/users/owap/followers","following_url":"https://api.github.com/users/owap/following{/other_user}","gists_url":"https://api.github.com/users/owap/gists{/gist_id}","starred_url":"https://api.github.com/users/owap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owap/subscriptions","organizations_url":"https://api.github.com/users/owap/orgs","repos_url":"https://api.github.com/users/owap/repos","events_url":"https://api.github.com/users/owap/events{/privacy}","received_events_url":"https://api.github.com/users/owap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/owap/axios","description":"Promise based HTTP client for the browser and node.js","fork":true,"url":"https://api.github.com/repos/owap/axios","forks_url":"https://api.github.com/repos/owap/axios/forks","keys_url":"https://api.github.com/repos/owap/axios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owap/axios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owap/axios/teams","hooks_url":"https://api.github.com/repos/owap/axios/hooks","issue_events_url":"https://api.github.com/repos/owap/axios/issues/events{/number}","events_url":"https://api.github.com/repos/owap/axios/events","assignees_url":"https://api.github.com/repos/owap/axios/assignees{/user}","branches_url":"https://api.github.com/repos/owap/axios/branches{/branch}","tags_url":"https://api.github.com/repos/owap/axios/tags","blobs_url":"https://api.github.com/repos/owap/axios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owap/axios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owap/axios/git/refs{/sha}","trees_url":"https://api.github.com/repos/owap/axios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owap/axios/statuses/{sha}","languages_url":"https://api.github.com/repos/owap/axios/languages","stargazers_url":"https://api.github.com/repos/owap/axios/stargazers","contributors_url":"https://api.github.com/repos/owap/axios/contributors","subscribers_url":"https://api.github.com/repos/owap/axios/subscribers","subscription_url":"https://api.github.com/repos/owap/axios/subscription","commits_url":"https://api.github.com/repos/owap/axios/commits{/sha}","git_commits_url":"https://api.github.com/repos/owap/axios/git/commits{/sha}","comments_url":"https://api.github.com/repos/owap/axios/comments{/number}","issue_comment_url":"https://api.github.com/repos/owap/axios/issues/comments{/number}","contents_url":"https://api.github.com/repos/owap/axios/contents/{+path}","compare_url":"https://api.github.com/repos/owap/axios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owap/axios/merges","archive_url":"https://api.github.com/repos/owap/axios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owap/axios/downloads","issues_url":"https://api.github.com/repos/owap/axios/issues{/number}","pulls_url":"https://api.github.com/repos/owap/axios/pulls{/number}","milestones_url":"https://api.github.com/repos/owap/axios/milestones{/number}","notifications_url":"https://api.github.com/repos/owap/axios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owap/axios/labels{/name}","releases_url":"https://api.github.com/repos/owap/axios/releases{/id}","deployments_url":"https://api.github.com/repos/owap/axios/deployments","created_at":"2017-11-02T22:43:56Z","updated_at":"2017-11-02T22:43:59Z","pushed_at":"2017-11-02T22:57:20Z","git_url":"git://github.com/owap/axios.git","ssh_url":"git@github.com:owap/axios.git","clone_url":"https://github.com/owap/axios.git","svn_url":"https://github.com/owap/axios","homepage":"","size":2362,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"axios:master","ref":"master","sha":"1ee5494038f74198f70e53835960948f9654ed0f","user":{"login":"axios","id":32372333,"avatar_url":"https://avatars1.githubusercontent.com/u/32372333?v=4","gravatar_id":"","url":"https://api.github.com/users/axios","html_url":"https://github.com/axios","followers_url":"https://api.github.com/users/axios/followers","following_url":"https://api.github.com/users/axios/following{/other_user}","gists_url":"https://api.github.com/users/axios/gists{/gist_id}","starred_url":"https://api.github.com/users/axios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axios/subscriptions","organizations_url":"https://api.github.com/users/axios/orgs","repos_url":"https://api.github.com/users/axios/repos","events_url":"https://api.github.com/users/axios/events{/privacy}","received_events_url":"https://api.github.com/users/axios/received_events","type":"Organization","site_admin":false},"repo":{"id":23088740,"name":"axios","full_name":"axios/axios","owner":{"login":"axios","id":32372333,"avatar_url":"https://avatars1.githubusercontent.com/u/32372333?v=4","gravatar_id":"","url":"https://api.github.com/users/axios","html_url":"https://github.com/axios","followers_url":"https://api.github.com/users/axios/followers","following_url":"https://api.github.com/users/axios/following{/other_user}","gists_url":"https://api.github.com/users/axios/gists{/gist_id}","starred_url":"https://api.github.com/users/axios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axios/subscriptions","organizations_url":"https://api.github.com/users/axios/orgs","repos_url":"https://api.github.com/users/axios/repos","events_url":"https://api.github.com/users/axios/events{/privacy}","received_events_url":"https://api.github.com/users/axios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/axios/axios","description":"Promise based HTTP client for the browser and node.js","fork":false,"url":"https://api.github.com/repos/axios/axios","forks_url":"https://api.github.com/repos/axios/axios/forks","keys_url":"https://api.github.com/repos/axios/axios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axios/axios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axios/axios/teams","hooks_url":"https://api.github.com/repos/axios/axios/hooks","issue_events_url":"https://api.github.com/repos/axios/axios/issues/events{/number}","events_url":"https://api.github.com/repos/axios/axios/events","assignees_url":"https://api.github.com/repos/axios/axios/assignees{/user}","branches_url":"https://api.github.com/repos/axios/axios/branches{/branch}","tags_url":"https://api.github.com/repos/axios/axios/tags","blobs_url":"https://api.github.com/repos/axios/axios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axios/axios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axios/axios/git/refs{/sha}","trees_url":"https://api.github.com/repos/axios/axios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axios/axios/statuses/{sha}","languages_url":"https://api.github.com/repos/axios/axios/languages","stargazers_url":"https://api.github.com/repos/axios/axios/stargazers","contributors_url":"https://api.github.com/repos/axios/axios/contributors","subscribers_url":"https://api.github.com/repos/axios/axios/subscribers","subscription_url":"https://api.github.com/repos/axios/axios/subscription","commits_url":"https://api.github.com/repos/axios/axios/commits{/sha}","git_commits_url":"https://api.github.com/repos/axios/axios/git/commits{/sha}","comments_url":"https://api.github.com/repos/axios/axios/comments{/number}","issue_comment_url":"https://api.github.com/repos/axios/axios/issues/comments{/number}","contents_url":"https://api.github.com/repos/axios/axios/contents/{+path}","compare_url":"https://api.github.com/repos/axios/axios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axios/axios/merges","archive_url":"https://api.github.com/repos/axios/axios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axios/axios/downloads","issues_url":"https://api.github.com/repos/axios/axios/issues{/number}","pulls_url":"https://api.github.com/repos/axios/axios/pulls{/number}","milestones_url":"https://api.github.com/repos/axios/axios/milestones{/number}","notifications_url":"https://api.github.com/repos/axios/axios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axios/axios/labels{/name}","releases_url":"https://api.github.com/repos/axios/axios/releases{/id}","deployments_url":"https://api.github.com/repos/axios/axios/deployments","created_at":"2014-08-18T22:30:27Z","updated_at":"2017-11-02T22:05:57Z","pushed_at":"2017-11-02T22:51:17Z","git_url":"git://github.com/axios/axios.git","ssh_url":"git@github.com:axios/axios.git","clone_url":"https://github.com/axios/axios.git","svn_url":"https://github.com/axios/axios","homepage":"","size":2362,"stargazers_count":29676,"watchers_count":29676,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1986,"mirror_url":null,"archived":false,"open_issues_count":164,"forks":1986,"open_issues":164,"watchers":29676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/axios/axios/pulls/1160"},"html":{"href":"https://github.com/axios/axios/pull/1160"},"issue":{"href":"https://api.github.com/repos/axios/axios/issues/1160"},"comments":{"href":"https://api.github.com/repos/axios/axios/issues/1160/comments"},"review_comments":{"href":"https://api.github.com/repos/axios/axios/pulls/1160/comments"},"review_comment":{"href":"https://api.github.com/repos/axios/axios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/axios/axios/pulls/1160/commits"},"statuses":{"href":"https://api.github.com/repos/axios/axios/statuses/468e90993d4ee556a4cf414fb1d6b6f7b99ed98a"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"owap"}}