{"action":"opened","number":50600,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50600","id":135549582,"html_url":"https://github.com/kubernetes/kubernetes/pull/50600","diff_url":"https://github.com/kubernetes/kubernetes/pull/50600.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/50600.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50600","number":50600,"state":"open","locked":false,"title":"Add UT for pkg/kubectl/deployment.go","user":{"login":"mathspanda","id":8100956,"avatar_url":"https://avatars0.githubusercontent.com/u/8100956?v=4","gravatar_id":"","url":"https://api.github.com/users/mathspanda","html_url":"https://github.com/mathspanda","followers_url":"https://api.github.com/users/mathspanda/followers","following_url":"https://api.github.com/users/mathspanda/following{/other_user}","gists_url":"https://api.github.com/users/mathspanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mathspanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathspanda/subscriptions","organizations_url":"https://api.github.com/users/mathspanda/orgs","repos_url":"https://api.github.com/users/mathspanda/repos","events_url":"https://api.github.com/users/mathspanda/events{/privacy}","received_events_url":"https://api.github.com/users/mathspanda/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nI find there is no UT for pkg/kubectl/deployment.go. This PR Adds some UTs for it.\r\n\r\n/sig cli","created_at":"2017-08-14T08:28:29Z","updated_at":"2017-08-14T08:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50600/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50600/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50600/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/abd2ff5e3b00c6d9d0b846d02a39a4a8613e60e8","head":{"label":"mathspanda:kubectl-deploy-ut","ref":"kubectl-deploy-ut","sha":"abd2ff5e3b00c6d9d0b846d02a39a4a8613e60e8","user":{"login":"mathspanda","id":8100956,"avatar_url":"https://avatars0.githubusercontent.com/u/8100956?v=4","gravatar_id":"","url":"https://api.github.com/users/mathspanda","html_url":"https://github.com/mathspanda","followers_url":"https://api.github.com/users/mathspanda/followers","following_url":"https://api.github.com/users/mathspanda/following{/other_user}","gists_url":"https://api.github.com/users/mathspanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mathspanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathspanda/subscriptions","organizations_url":"https://api.github.com/users/mathspanda/orgs","repos_url":"https://api.github.com/users/mathspanda/repos","events_url":"https://api.github.com/users/mathspanda/events{/privacy}","received_events_url":"https://api.github.com/users/mathspanda/received_events","type":"User","site_admin":false},"repo":{"id":98962136,"name":"kubernetes","full_name":"mathspanda/kubernetes","owner":{"login":"mathspanda","id":8100956,"avatar_url":"https://avatars0.githubusercontent.com/u/8100956?v=4","gravatar_id":"","url":"https://api.github.com/users/mathspanda","html_url":"https://github.com/mathspanda","followers_url":"https://api.github.com/users/mathspanda/followers","following_url":"https://api.github.com/users/mathspanda/following{/other_user}","gists_url":"https://api.github.com/users/mathspanda/gists{/gist_id}","starred_url":"https://api.github.com/users/mathspanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathspanda/subscriptions","organizations_url":"https://api.github.com/users/mathspanda/orgs","repos_url":"https://api.github.com/users/mathspanda/repos","events_url":"https://api.github.com/users/mathspanda/events{/privacy}","received_events_url":"https://api.github.com/users/mathspanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mathspanda/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/mathspanda/kubernetes","forks_url":"https://api.github.com/repos/mathspanda/kubernetes/forks","keys_url":"https://api.github.com/repos/mathspanda/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mathspanda/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mathspanda/kubernetes/teams","hooks_url":"https://api.github.com/repos/mathspanda/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mathspanda/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mathspanda/kubernetes/events","assignees_url":"https://api.github.com/repos/mathspanda/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mathspanda/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mathspanda/kubernetes/tags","blobs_url":"https://api.github.com/repos/mathspanda/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mathspanda/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mathspanda/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mathspanda/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mathspanda/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mathspanda/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mathspanda/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mathspanda/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mathspanda/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mathspanda/kubernetes/subscription","commits_url":"https://api.github.com/repos/mathspanda/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mathspanda/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mathspanda/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mathspanda/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mathspanda/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mathspanda/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mathspanda/kubernetes/merges","archive_url":"https://api.github.com/repos/mathspanda/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mathspanda/kubernetes/downloads","issues_url":"https://api.github.com/repos/mathspanda/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mathspanda/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mathspanda/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mathspanda/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mathspanda/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mathspanda/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mathspanda/kubernetes/deployments","created_at":"2017-08-01T05:19:22Z","updated_at":"2017-08-01T05:20:02Z","pushed_at":"2017-08-14T08:22:44Z","git_url":"git://github.com/mathspanda/kubernetes.git","ssh_url":"git@github.com:mathspanda/kubernetes.git","clone_url":"https://github.com/mathspanda/kubernetes.git","svn_url":"https://github.com/mathspanda/kubernetes","homepage":"http://kubernetes.io","size":451881,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"7d9e77d62e842040571ab1c9cdbe41489d43ecd5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-08-14T08:22:55Z","pushed_at":"2017-08-14T08:07:30Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":676271,"stargazers_count":25852,"watchers_count":25852,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9216,"mirror_url":null,"open_issues_count":5196,"forks":9216,"open_issues":5196,"watchers":25852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50600"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/50600"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50600"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50600/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50600/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50600/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/abd2ff5e3b00c6d9d0b846d02a39a4a8613e60e8"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":98,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"mathspanda"}}