{"action":"created","issue":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1848","repository_url":"https://api.github.com/repos/DynamoDS/DynamoRevit","labels_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1848/labels{/name}","comments_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1848/comments","events_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1848/events","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/1848","id":272681433,"number":1848,"title":"use fromexisting constructor for creating family from name via document","user":{"login":"mjkkirschner","id":508936,"avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-09T18:56:57Z","updated_at":"2017-11-09T19:10:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/pulls/1848","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/1848","diff_url":"https://github.com/DynamoDS/DynamoRevit/pull/1848.diff","patch_url":"https://github.com/DynamoDS/DynamoRevit/pull/1848.patch"},"body":"\r\n### Purpose\r\n\r\nwhen we create families using the byBame node this implies that the elements already exist in the document and are revit owned - use the from existing constructor to set the `RevitOwned` bool to false.\r\n\r\nadd a test which checks the total number of families before and after removing this node from the graph.\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [x] The level of testing this PR includes is appropriate\r\n- [x] User facing strings, if any, are extracted into `*.resx` files\r\n- [x] Snapshot of UI changes, if any.\r\n\r\n### Reviewers\r\n\r\n@ColinDayOrg \r\n\r\n### FYIs\r\n\r\n@QilongTang "},"comment":{"url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/comments/343259461","html_url":"https://github.com/DynamoDS/DynamoRevit/pull/1848#issuecomment-343259461","issue_url":"https://api.github.com/repos/DynamoDS/DynamoRevit/issues/1848","id":343259461,"user":{"login":"ColinDayOrg","id":10959111,"avatar_url":"https://avatars0.githubusercontent.com/u/10959111?v=4","gravatar_id":"","url":"https://api.github.com/users/ColinDayOrg","html_url":"https://github.com/ColinDayOrg","followers_url":"https://api.github.com/users/ColinDayOrg/followers","following_url":"https://api.github.com/users/ColinDayOrg/following{/other_user}","gists_url":"https://api.github.com/users/ColinDayOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/ColinDayOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ColinDayOrg/subscriptions","organizations_url":"https://api.github.com/users/ColinDayOrg/orgs","repos_url":"https://api.github.com/users/ColinDayOrg/repos","events_url":"https://api.github.com/users/ColinDayOrg/events{/privacy}","received_events_url":"https://api.github.com/users/ColinDayOrg/received_events","type":"User","site_admin":false},"created_at":"2017-11-09T19:10:32Z","updated_at":"2017-11-09T19:10:32Z","author_association":"NONE","body":"A couple of comments about the comments in the code (minor, change them if you agree, but I'm ok if it stays as it is), but other than that LGTM."}}
{"actor":{"display_login":"ColinDayOrg"}}