{"action":"created","issue":{"url":"https://api.github.com/repos/bigsinger/AndroidIdChanger/issues/25","repository_url":"https://api.github.com/repos/bigsinger/AndroidIdChanger","labels_url":"https://api.github.com/repos/bigsinger/AndroidIdChanger/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/bigsinger/AndroidIdChanger/issues/25/comments","events_url":"https://api.github.com/repos/bigsinger/AndroidIdChanger/issues/25/events","html_url":"https://github.com/bigsinger/AndroidIdChanger/issues/25","id":267568324,"number":25,"title":"DEBUG: Improve logs","user":{"login":"lars18th","id":9989964,"avatar_url":"https://avatars1.githubusercontent.com/u/9989964?v=4","gravatar_id":"","url":"https://api.github.com/users/lars18th","html_url":"https://github.com/lars18th","followers_url":"https://api.github.com/users/lars18th/followers","following_url":"https://api.github.com/users/lars18th/following{/other_user}","gists_url":"https://api.github.com/users/lars18th/gists{/gist_id}","starred_url":"https://api.github.com/users/lars18th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lars18th/subscriptions","organizations_url":"https://api.github.com/users/lars18th/orgs","repos_url":"https://api.github.com/users/lars18th/repos","events_url":"https://api.github.com/users/lars18th/events{/privacy}","received_events_url":"https://api.github.com/users/lars18th/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-10-23T07:36:37Z","updated_at":"2017-11-08T13:26:39Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nIn the lasted vesion (v1.12) in the logs isn't writed the hooked values. Without this it's impossible to debug which value is used.\r\n\r\nI suggest to change to something like this:\r\n\r\n```\r\n        //////////////////////////////////////////////////////////////////////////\r\n        // FINGERPRINT\r\n        if (Constant.HARDCODED) {\r\n            modValue = \"Meizu/meizu_mx3/mx3:4.4.4/KTU84P/m35x.Flyme_OS_3.7.3.20140909113158:user/release-keys\";\r\n        } else {\r\n            modValue = PhoneInfoUtils.getValue(\"FingerPrint\");\r\n        }\r\n        if (TextUtils.isEmpty(modValue)) {\r\n            XposedLog.logd(\"HookerPhone.hook(): no hook FINGERPRINT, it's  null\");\r\n        } else {\r\n            final String hookValue = modValue;\r\n            try {\r\n                XposedHelpers.setStaticObjectField(Build.class, \"FINGERPRINT\", hookValue);\r\n                XposedLog.logd(\"HookerPhone.hook(): hooked FINGERPRINT with \" + hookValue);\r\n            } catch (Exception e) {\r\n                XposedLog.logd(\"HookerPhone.hook() : error hooking FINGERPRINT\");\r\n            }\r\n        }\r\n        //////////////////////////////////////////////////////////////////////////\r\n\r\n```\r\n\r\nThis will be usefull too when multiple calls are done (like with IMEI) and some exception is triggered. With this will be more easy to find which call fails.\r\n\r\nYou agree?\r\n"},"comment":{"url":"https://api.github.com/repos/bigsinger/AndroidIdChanger/issues/comments/342816754","html_url":"https://github.com/bigsinger/AndroidIdChanger/issues/25#issuecomment-342816754","issue_url":"https://api.github.com/repos/bigsinger/AndroidIdChanger/issues/25","id":342816754,"user":{"login":"lars18th","id":9989964,"avatar_url":"https://avatars1.githubusercontent.com/u/9989964?v=4","gravatar_id":"","url":"https://api.github.com/users/lars18th","html_url":"https://github.com/lars18th","followers_url":"https://api.github.com/users/lars18th/followers","following_url":"https://api.github.com/users/lars18th/following{/other_user}","gists_url":"https://api.github.com/users/lars18th/gists{/gist_id}","starred_url":"https://api.github.com/users/lars18th/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lars18th/subscriptions","organizations_url":"https://api.github.com/users/lars18th/orgs","repos_url":"https://api.github.com/users/lars18th/repos","events_url":"https://api.github.com/users/lars18th/events{/privacy}","received_events_url":"https://api.github.com/users/lars18th/received_events","type":"User","site_admin":false},"created_at":"2017-11-08T13:26:39Z","updated_at":"2017-11-08T13:26:39Z","author_association":"NONE","body":"Hi @bigsinger ,\r\n\r\nUpdated to v1.16. And I continue witout seeing the logs.\r\nAny idea why?\r\n"}}
{"actor":{"display_login":"lars18th"}}