{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/comments/131009012","pull_request_review_id":53945429,"id":131009012,"diff_hunk":"@@ -32,13 +34,16 @@ def __init__(self, cert, key, insecure=False):\n \n         # set proxy if valid proxy_configuration path is detected\n         proxy_conf_path = configuration.get_proxy_configuration_path()\n-        if configuration.get_proxy_configuration_path() != configuration.DEFAULT_PROXY_CONFIGURATION_PATH \\\n+        if proxy_conf_path != configuration.DEFAULT_PROXY_CONFIGURATION_PATH \\\n                 and os.path.isfile(proxy_conf_path):\n-            proxy_conf_file = open(configuration.get_proxy_configuration_path(), \"r\")\n-            proxy_configuration = proxy_conf_file.readline().strip()\n-            if proxy_configuration != \"\":\n-                self.proxy_configuration = proxy_configuration\n-            proxy_conf_file.close()\n+            if util.assert_file_read_permission(configuration.get_proxy_configuration_path()) is False:","path":"Providers/nxOMSAutomationWorker/automationworker/worker/httpclientfactory.py","position":23,"original_position":23,"commit_id":"adc81aa66f21a81fd55638d571f7a62d0e993b7b","original_commit_id":"adc81aa66f21a81fd55638d571f7a62d0e993b7b","user":{"login":"lagalbra","id":21086952,"avatar_url":"https://avatars0.githubusercontent.com/u/21086952?v=4","gravatar_id":"","url":"https://api.github.com/users/lagalbra","html_url":"https://github.com/lagalbra","followers_url":"https://api.github.com/users/lagalbra/followers","following_url":"https://api.github.com/users/lagalbra/following{/other_user}","gists_url":"https://api.github.com/users/lagalbra/gists{/gist_id}","starred_url":"https://api.github.com/users/lagalbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagalbra/subscriptions","organizations_url":"https://api.github.com/users/lagalbra/orgs","repos_url":"https://api.github.com/users/lagalbra/repos","events_url":"https://api.github.com/users/lagalbra/events{/privacy}","received_events_url":"https://api.github.com/users/lagalbra/received_events","type":"User","site_admin":false},"body":"Why don't you re-use the variable `proxy_conf_path` here?","created_at":"2017-08-02T22:03:59Z","updated_at":"2017-08-02T22:30:14Z","html_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux/pull/299#discussion_r131009012","pull_request_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/299","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/comments/131009012"},"html":{"href":"https://github.com/Microsoft/PowerShell-DSC-for-Linux/pull/299#discussion_r131009012"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/299"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/299","id":133810578,"html_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux/pull/299","diff_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux/pull/299.diff","patch_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux/pull/299.patch","issue_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues/299","number":299,"state":"open","locked":false,"title":"Bugfixes, folder permissions, and improved logging.","user":{"login":"D1v38om83r","id":22455821,"avatar_url":"https://avatars3.githubusercontent.com/u/22455821?v=4","gravatar_id":"","url":"https://api.github.com/users/D1v38om83r","html_url":"https://github.com/D1v38om83r","followers_url":"https://api.github.com/users/D1v38om83r/followers","following_url":"https://api.github.com/users/D1v38om83r/following{/other_user}","gists_url":"https://api.github.com/users/D1v38om83r/gists{/gist_id}","starred_url":"https://api.github.com/users/D1v38om83r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D1v38om83r/subscriptions","organizations_url":"https://api.github.com/users/D1v38om83r/orgs","repos_url":"https://api.github.com/users/D1v38om83r/repos","events_url":"https://api.github.com/users/D1v38om83r/events{/privacy}","received_events_url":"https://api.github.com/users/D1v38om83r/received_events","type":"User","site_admin":false},"body":"Added more detailed traces, fixed permission bug, made changes to the agentID file\r\nIncluded worker changes for pre-requisite checks, gpg keyrings, worker crash logging","created_at":"2017-08-02T21:16:06Z","updated_at":"2017-08-02T22:30:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51748e34c32bbc8079b73b767cc5228926afd556","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/299/commits","review_comments_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/299/comments","review_comment_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues/299/comments","statuses_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/statuses/adc81aa66f21a81fd55638d571f7a62d0e993b7b","head":{"label":"Microsoft:bhbrahma-nxOMSAutomationWorker","ref":"bhbrahma-nxOMSAutomationWorker","sha":"adc81aa66f21a81fd55638d571f7a62d0e993b7b","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":19926695,"name":"PowerShell-DSC-for-Linux","full_name":"Microsoft/PowerShell-DSC-for-Linux","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux","description":"PowerShell Desired State Configuration - for Linux","fork":false,"url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux","forks_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/forks","keys_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/teams","hooks_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/events","assignees_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/tags","blobs_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/languages","stargazers_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/subscription","commits_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/merges","archive_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/downloads","issues_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/deployments","created_at":"2014-05-19T02:18:59Z","updated_at":"2017-07-25T21:26:39Z","pushed_at":"2017-08-02T21:40:51Z","git_url":"git://github.com/Microsoft/PowerShell-DSC-for-Linux.git","ssh_url":"git@github.com:Microsoft/PowerShell-DSC-for-Linux.git","clone_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux.git","svn_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux","homepage":"","size":23465,"stargazers_count":188,"watchers_count":188,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":24,"forks":53,"open_issues":24,"watchers":188,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5f1cd6f719562312a72400756b298186da4b23c8","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":19926695,"name":"PowerShell-DSC-for-Linux","full_name":"Microsoft/PowerShell-DSC-for-Linux","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux","description":"PowerShell Desired State Configuration - for Linux","fork":false,"url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux","forks_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/forks","keys_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/teams","hooks_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/events","assignees_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/tags","blobs_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/languages","stargazers_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/subscription","commits_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/merges","archive_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/downloads","issues_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/deployments","created_at":"2014-05-19T02:18:59Z","updated_at":"2017-07-25T21:26:39Z","pushed_at":"2017-08-02T21:40:51Z","git_url":"git://github.com/Microsoft/PowerShell-DSC-for-Linux.git","ssh_url":"git@github.com:Microsoft/PowerShell-DSC-for-Linux.git","clone_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux.git","svn_url":"https://github.com/Microsoft/PowerShell-DSC-for-Linux","homepage":"","size":23465,"stargazers_count":188,"watchers_count":188,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":24,"forks":53,"open_issues":24,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/299"},"html":{"href":"https://github.com/Microsoft/PowerShell-DSC-for-Linux/pull/299"},"issue":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues/299"},"comments":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/PowerShell-DSC-for-Linux/statuses/adc81aa66f21a81fd55638d571f7a62d0e993b7b"}}}}
{"actor":{"display_login":"lagalbra"}}