{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/96980184","pull_request_review_id":17580744,"id":96980184,"diff_hunk":"@@ -1,5 +1,14 @@\n --- ../src-base/minecraft/net/minecraft/world/ChunkCache.java\n +++ ../src-work/minecraft/net/minecraft/world/ChunkCache.java\n+@@ -61,7 +61,7 @@\n+     @Nullable\n+     public TileEntity func_175625_s(BlockPos p_175625_1_)\n+     {\n+-        return this.func_190300_a(p_175625_1_, Chunk.EnumCreateEntityType.IMMEDIATE);\n++        return this.func_190300_a(p_175625_1_, Chunk.EnumCreateEntityType.QUEUED); // Forge: don't modify world from other threads","path":"patches/minecraft/net/minecraft/world/ChunkCache.java.patch","position":null,"original_position":8,"commit_id":"63085f56d67fb88780f830fdc132d912fba421d6","original_commit_id":"fdbe0d8d56b7bc31b9272f15ef76bdb45dfaaf44","user":{"login":"bs2609","id":1447117,"avatar_url":"https://avatars.githubusercontent.com/u/1447117?v=3","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"body":"Done. #blamemezz if there's any issues","created_at":"2017-01-19T23:07:35Z","updated_at":"2017-01-19T23:07:35Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3643#discussion_r96980184","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3643","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/96980184"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3643#discussion_r96980184"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3643"}}},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3643","id":102259949,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3643","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3643.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3643.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3643","number":3643,"state":"open","locked":false,"title":"Patch ChunkCache.getTileEntity for thread safety","user":{"login":"bs2609","id":1447117,"avatar_url":"https://avatars.githubusercontent.com/u/1447117?v=3","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"body":"See [this](https://github.com/MinecraftForge/Documentation/pull/81) Forge documentation PR for details.\r\n\r\nThis changes `ChunkCache#getTileEntity` to pass `QUEUED` instead of `IMMEDIATE` as the type.\r\nMissing tile entities will be added to a (concurrent) queue and created during the chunk's next update tick.\r\n\r\nThis will cause the method to return `null` if there is tile entity at the position queried, but the function is annotated `@Nullable`, and currently has a chance of just throwing a `ConcurrentModificationException` anyway, so there shouldn't be any working mods broken by this change.","created_at":"2017-01-19T12:47:15Z","updated_at":"2017-01-19T23:07:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f196ca576cadbd216348886c52dce07e1a21aeac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3643/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3643/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3643/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/63085f56d67fb88780f830fdc132d912fba421d6","head":{"label":"bs2609:chunk-cache-patch","ref":"chunk-cache-patch","sha":"63085f56d67fb88780f830fdc132d912fba421d6","user":{"login":"bs2609","id":1447117,"avatar_url":"https://avatars.githubusercontent.com/u/1447117?v=3","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"repo":{"id":69063094,"name":"MinecraftForge","full_name":"bs2609/MinecraftForge","owner":{"login":"bs2609","id":1447117,"avatar_url":"https://avatars.githubusercontent.com/u/1447117?v=3","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bs2609/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/bs2609/MinecraftForge","forks_url":"https://api.github.com/repos/bs2609/MinecraftForge/forks","keys_url":"https://api.github.com/repos/bs2609/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bs2609/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bs2609/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/bs2609/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/bs2609/MinecraftForge/events","assignees_url":"https://api.github.com/repos/bs2609/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/bs2609/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/bs2609/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bs2609/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/bs2609/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/bs2609/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/bs2609/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/bs2609/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/bs2609/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/bs2609/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/bs2609/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/bs2609/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/bs2609/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bs2609/MinecraftForge/merges","archive_url":"https://api.github.com/repos/bs2609/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bs2609/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/bs2609/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/bs2609/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/bs2609/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bs2609/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/bs2609/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/bs2609/MinecraftForge/deployments","created_at":"2016-09-23T21:50:44Z","updated_at":"2016-09-23T21:50:49Z","pushed_at":"2017-01-19T23:06:54Z","git_url":"git://github.com/bs2609/MinecraftForge.git","ssh_url":"git@github.com:bs2609/MinecraftForge.git","clone_url":"https://github.com/bs2609/MinecraftForge.git","svn_url":"https://github.com/bs2609/MinecraftForge","homepage":"","size":88539,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.11.x"}},"base":{"label":"MinecraftForge:1.11.x","ref":"1.11.x","sha":"bbc107de96a438496ae85223ca1b2a3d8478228f","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars.githubusercontent.com/u/1390178?v=3","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2017-01-19T21:44:13Z","pushed_at":"2017-01-19T23:06:56Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":88572,"stargazers_count":1684,"watchers_count":1684,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":855,"mirror_url":null,"open_issues_count":248,"forks":855,"open_issues":248,"watchers":1684,"default_branch":"1.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3643"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3643"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3643"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3643/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3643/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3643/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/63085f56d67fb88780f830fdc132d912fba421d6"}}}}
{"actor":{"display_login":"bs2609"}}