{"action":"opened","number":363,"pull_request":{"url":"https://api.github.com/repos/travis-ci/worker/pulls/363","id":139563341,"html_url":"https://github.com/travis-ci/worker/pull/363","diff_url":"https://github.com/travis-ci/worker/pull/363.diff","patch_url":"https://github.com/travis-ci/worker/pull/363.patch","issue_url":"https://api.github.com/repos/travis-ci/worker/issues/363","number":363,"state":"open","locked":false,"title":"Handle nil incoming job in multi-source job queue","user":{"login":"meatballhat","id":45143,"avatar_url":"https://avatars0.githubusercontent.com/u/45143?v=4","gravatar_id":"","url":"https://api.github.com/users/meatballhat","html_url":"https://github.com/meatballhat","followers_url":"https://api.github.com/users/meatballhat/followers","following_url":"https://api.github.com/users/meatballhat/following{/other_user}","gists_url":"https://api.github.com/users/meatballhat/gists{/gist_id}","starred_url":"https://api.github.com/users/meatballhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meatballhat/subscriptions","organizations_url":"https://api.github.com/users/meatballhat/orgs","repos_url":"https://api.github.com/users/meatballhat/repos","events_url":"https://api.github.com/users/meatballhat/events{/privacy}","received_events_url":"https://api.github.com/users/meatballhat/received_events","type":"User","site_admin":false},"body":"## What is the problem that this PR is trying to fix?\r\n\r\nThe production rollout of v3.0.0 on GCE seems to have introduced this panic:\r\n\r\n```\r\ntravis-worker: panic: runtime error: invalid memory address or nil pointer dereference \r\ntravis-worker: [signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0xa82dfc] \r\ntravis-worker: goroutine 210 [running]: \r\ntravis-worker: github.com/travis-ci/worker.(*MultiSourceJobQueue).Jobs.func1(0xc420163ef0,0xc42000c4e0,0xc420631320, 0x1053520, 0xc4201c0880) \r\ntravis-worker:     /home/travis/gopath/src/github.com/travis-ci/worker/multi_source_job_queue.go:59 +0x30c \r\ntravis-worker: created by github.com/travis-ci/worker.(*MultiSourceJobQueue).Jobs \r\ntravis-worker:     /home/travis/gopath/src/github.com/travis-ci/worker/multi_source_job_queue.go:79 +0x5b9 \r\n```\r\n\r\n## What approach did you choose and why?\r\n\r\nI decided to check for `nil`, and if so, log and continue.  AFAICT neither the AMQP nor the HTTP job queue should send a `nil` job to this channel, so I think there's at least one other bug lurking...\r\n\r\n## How can you test this?\r\n\r\nIt compiles!  Also, deploy to AWS staging :grin:\r\n\r\n## What feedback would you like, if any?\r\n\r\nShould this be approached differently?  Is a `panic` correct?\r\n","created_at":"2017-09-06T13:33:52Z","updated_at":"2017-09-06T13:33:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"meatballhat","id":45143,"avatar_url":"https://avatars0.githubusercontent.com/u/45143?v=4","gravatar_id":"","url":"https://api.github.com/users/meatballhat","html_url":"https://github.com/meatballhat","followers_url":"https://api.github.com/users/meatballhat/followers","following_url":"https://api.github.com/users/meatballhat/following{/other_user}","gists_url":"https://api.github.com/users/meatballhat/gists{/gist_id}","starred_url":"https://api.github.com/users/meatballhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meatballhat/subscriptions","organizations_url":"https://api.github.com/users/meatballhat/orgs","repos_url":"https://api.github.com/users/meatballhat/repos","events_url":"https://api.github.com/users/meatballhat/events{/privacy}","received_events_url":"https://api.github.com/users/meatballhat/received_events","type":"User","site_admin":false},"assignees":[{"login":"meatballhat","id":45143,"avatar_url":"https://avatars0.githubusercontent.com/u/45143?v=4","gravatar_id":"","url":"https://api.github.com/users/meatballhat","html_url":"https://github.com/meatballhat","followers_url":"https://api.github.com/users/meatballhat/followers","following_url":"https://api.github.com/users/meatballhat/following{/other_user}","gists_url":"https://api.github.com/users/meatballhat/gists{/gist_id}","starred_url":"https://api.github.com/users/meatballhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meatballhat/subscriptions","organizations_url":"https://api.github.com/users/meatballhat/orgs","repos_url":"https://api.github.com/users/meatballhat/repos","events_url":"https://api.github.com/users/meatballhat/events{/privacy}","received_events_url":"https://api.github.com/users/meatballhat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/travis-ci/worker/pulls/363/commits","review_comments_url":"https://api.github.com/repos/travis-ci/worker/pulls/363/comments","review_comment_url":"https://api.github.com/repos/travis-ci/worker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/travis-ci/worker/issues/363/comments","statuses_url":"https://api.github.com/repos/travis-ci/worker/statuses/e21481ddf3cf81113f3c2ad5a7cc9d983f242eb6","head":{"label":"travis-ci:meat-msjq-panic","ref":"meat-msjq-panic","sha":"e21481ddf3cf81113f3c2ad5a7cc9d983f242eb6","user":{"login":"travis-ci","id":639823,"avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":27410275,"name":"worker","full_name":"travis-ci/worker","owner":{"login":"travis-ci","id":639823,"avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/travis-ci/worker","description":"Worker runs your Travis CI jobs","fork":false,"url":"https://api.github.com/repos/travis-ci/worker","forks_url":"https://api.github.com/repos/travis-ci/worker/forks","keys_url":"https://api.github.com/repos/travis-ci/worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-ci/worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-ci/worker/teams","hooks_url":"https://api.github.com/repos/travis-ci/worker/hooks","issue_events_url":"https://api.github.com/repos/travis-ci/worker/issues/events{/number}","events_url":"https://api.github.com/repos/travis-ci/worker/events","assignees_url":"https://api.github.com/repos/travis-ci/worker/assignees{/user}","branches_url":"https://api.github.com/repos/travis-ci/worker/branches{/branch}","tags_url":"https://api.github.com/repos/travis-ci/worker/tags","blobs_url":"https://api.github.com/repos/travis-ci/worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-ci/worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-ci/worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-ci/worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-ci/worker/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-ci/worker/languages","stargazers_url":"https://api.github.com/repos/travis-ci/worker/stargazers","contributors_url":"https://api.github.com/repos/travis-ci/worker/contributors","subscribers_url":"https://api.github.com/repos/travis-ci/worker/subscribers","subscription_url":"https://api.github.com/repos/travis-ci/worker/subscription","commits_url":"https://api.github.com/repos/travis-ci/worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-ci/worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-ci/worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-ci/worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-ci/worker/contents/{+path}","compare_url":"https://api.github.com/repos/travis-ci/worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-ci/worker/merges","archive_url":"https://api.github.com/repos/travis-ci/worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-ci/worker/downloads","issues_url":"https://api.github.com/repos/travis-ci/worker/issues{/number}","pulls_url":"https://api.github.com/repos/travis-ci/worker/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-ci/worker/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-ci/worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-ci/worker/labels{/name}","releases_url":"https://api.github.com/repos/travis-ci/worker/releases{/id}","deployments_url":"https://api.github.com/repos/travis-ci/worker/deployments","created_at":"2014-12-02T02:02:55Z","updated_at":"2017-09-05T12:00:28Z","pushed_at":"2017-09-06T13:24:34Z","git_url":"git://github.com/travis-ci/worker.git","ssh_url":"git@github.com:travis-ci/worker.git","clone_url":"https://github.com/travis-ci/worker.git","svn_url":"https://github.com/travis-ci/worker","homepage":"","size":4411,"stargazers_count":129,"watchers_count":129,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":15,"forks":34,"open_issues":15,"watchers":129,"default_branch":"master"}},"base":{"label":"travis-ci:master","ref":"master","sha":"8ae99b600790291455419538b971604aebfc0465","user":{"login":"travis-ci","id":639823,"avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":27410275,"name":"worker","full_name":"travis-ci/worker","owner":{"login":"travis-ci","id":639823,"avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/travis-ci/worker","description":"Worker runs your Travis CI jobs","fork":false,"url":"https://api.github.com/repos/travis-ci/worker","forks_url":"https://api.github.com/repos/travis-ci/worker/forks","keys_url":"https://api.github.com/repos/travis-ci/worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-ci/worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-ci/worker/teams","hooks_url":"https://api.github.com/repos/travis-ci/worker/hooks","issue_events_url":"https://api.github.com/repos/travis-ci/worker/issues/events{/number}","events_url":"https://api.github.com/repos/travis-ci/worker/events","assignees_url":"https://api.github.com/repos/travis-ci/worker/assignees{/user}","branches_url":"https://api.github.com/repos/travis-ci/worker/branches{/branch}","tags_url":"https://api.github.com/repos/travis-ci/worker/tags","blobs_url":"https://api.github.com/repos/travis-ci/worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-ci/worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-ci/worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-ci/worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-ci/worker/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-ci/worker/languages","stargazers_url":"https://api.github.com/repos/travis-ci/worker/stargazers","contributors_url":"https://api.github.com/repos/travis-ci/worker/contributors","subscribers_url":"https://api.github.com/repos/travis-ci/worker/subscribers","subscription_url":"https://api.github.com/repos/travis-ci/worker/subscription","commits_url":"https://api.github.com/repos/travis-ci/worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-ci/worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-ci/worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-ci/worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-ci/worker/contents/{+path}","compare_url":"https://api.github.com/repos/travis-ci/worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-ci/worker/merges","archive_url":"https://api.github.com/repos/travis-ci/worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-ci/worker/downloads","issues_url":"https://api.github.com/repos/travis-ci/worker/issues{/number}","pulls_url":"https://api.github.com/repos/travis-ci/worker/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-ci/worker/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-ci/worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-ci/worker/labels{/name}","releases_url":"https://api.github.com/repos/travis-ci/worker/releases{/id}","deployments_url":"https://api.github.com/repos/travis-ci/worker/deployments","created_at":"2014-12-02T02:02:55Z","updated_at":"2017-09-05T12:00:28Z","pushed_at":"2017-09-06T13:24:34Z","git_url":"git://github.com/travis-ci/worker.git","ssh_url":"git@github.com:travis-ci/worker.git","clone_url":"https://github.com/travis-ci/worker.git","svn_url":"https://github.com/travis-ci/worker","homepage":"","size":4411,"stargazers_count":129,"watchers_count":129,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":15,"forks":34,"open_issues":15,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/travis-ci/worker/pulls/363"},"html":{"href":"https://github.com/travis-ci/worker/pull/363"},"issue":{"href":"https://api.github.com/repos/travis-ci/worker/issues/363"},"comments":{"href":"https://api.github.com/repos/travis-ci/worker/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/travis-ci/worker/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/travis-ci/worker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/travis-ci/worker/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/travis-ci/worker/statuses/e21481ddf3cf81113f3c2ad5a7cc9d983f242eb6"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"meatballhat"}}