{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments/156269689","pull_request_review_id":82718150,"id":156269689,"diff_hunk":"@@ -0,0 +1,152 @@\n+syntax = \"proto3\";\n+\n+// [#proto-status: draft]\n+\n+package envoy.api.v2;\n+\n+\n+import \"google/protobuf/struct.proto\";\n+import \"google/protobuf/timestamp.proto\";\n+import \"google/rpc/status.proto\";\n+\n+// Authorization service.\n+// Primarily responds with OK or NOT OK.\n+service Authorization {\n+   rpc Check(CheckRequest) returns (CheckResponse);\n+}\n+\n+message CheckRequest {\n+    // The name of the tenant for multi-tenant support.\n+    string tenant_name = 1;\n+\n+    // The request attributes.\n+    AttributeContext attributes = 2;\n+}\n+\n+message CheckResponse {\n+    // Status OK allows the request. Any other response indicates the request should be denied.\n+    google.rpc.Status status = 1;\n+}\n+\n+// An attribute is a piece of metadata that describes an activity on a network.\n+// For example, the size of an HTTP request, or the status code of an HTTP response.\n+//\n+// Each attribute has a type and a name, which is logically defined as a proto message field.\n+// The fields follow the Istio attribute vocabulary.\n+// https://istio.io/docs/reference/config/mixer/attribute-vocabulary.html\n+// The field type becomes the attribute type, and the field path becomes the attribute name.\n+// For example, the attribute `source.ip` maps to field `AttributeContext.source.ip`.\n+message AttributeContext {\n+  // This message defines attributes for a node that handles a network request.\n+  // The node can be either a service or an application that sends, forwards,\n+  // or receives the request. Service peers should fill in the `service`,\n+  // `principal`, and `labels` as appropriate.\n+  message Peer {\n+    // The IP address of the peer.\n+    string ip = 1;\n+\n+    // The network port of the peer.\n+    int64 port = 2;\n+\n+    // The canonical service name of the peer.\n+    string service = 3;\n+\n+    // The labels associated with the peer.\n+    // These could be pod labels for Kubernetes or tags for VMs.\n+    // The source of the labels could be an X.509 certificate or other configuration.","path":"api/external_auth.proto","position":55,"original_position":56,"commit_id":"79ceac59d74b8d56bef02570ea0dc3bf778718bf","original_commit_id":"49a4e05c3cf4aacbd96880df7c5b44131d6d4f3a","user":{"login":"wora","id":6994853,"avatar_url":"https://avatars3.githubusercontent.com/u/6994853?v=4","gravatar_id":"","url":"https://api.github.com/users/wora","html_url":"https://github.com/wora","followers_url":"https://api.github.com/users/wora/followers","following_url":"https://api.github.com/users/wora/following{/other_user}","gists_url":"https://api.github.com/users/wora/gists{/gist_id}","starred_url":"https://api.github.com/users/wora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wora/subscriptions","organizations_url":"https://api.github.com/users/wora/orgs","repos_url":"https://api.github.com/users/wora/repos","events_url":"https://api.github.com/users/wora/events{/privacy}","received_events_url":"https://api.github.com/users/wora/received_events","type":"User","site_admin":false},"body":"We can drop it for now.","created_at":"2017-12-12T04:35:13Z","updated_at":"2017-12-12T04:35:13Z","html_url":"https://github.com/envoyproxy/data-plane-api/pull/296#discussion_r156269689","pull_request_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/296","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments/156269689"},"html":{"href":"https://github.com/envoyproxy/data-plane-api/pull/296#discussion_r156269689"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/296"}},"in_reply_to_id":154501317},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/296","id":155491380,"html_url":"https://github.com/envoyproxy/data-plane-api/pull/296","diff_url":"https://github.com/envoyproxy/data-plane-api/pull/296.diff","patch_url":"https://github.com/envoyproxy/data-plane-api/pull/296.patch","issue_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/296","number":296,"state":"open","locked":false,"title":"External auth filter2","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"This PR proposes an external auth filter API with the following characteristics.\r\n\r\n1. All information related to authorization is schematized.\r\n2. Information is schematized without using envoy-specific abstractions.\r\n3. The api is aligned with Istio Authorization Check (Mixer Check) api.\r\n4. Adds `map<string, string> request_context` to pass additional information to the server.\r\n\r\nThis is proposed as an alternative to https://github.com/envoyproxy/data-plane-api/pull/222\r\n\r\n","created_at":"2017-11-30T00:43:52Z","updated_at":"2017-12-12T04:35:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90a76968e5998fac851b2af43aec9375d3477a41","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/296/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/296/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/296/comments","statuses_url":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/79ceac59d74b8d56bef02570ea0dc3bf778718bf","head":{"label":"mandarjog:auth2","ref":"auth2","sha":"79ceac59d74b8d56bef02570ea0dc3bf778718bf","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"repo":{"id":112490608,"name":"data-plane-api","full_name":"mandarjog/data-plane-api","owner":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandarjog/data-plane-api","description":"Envoy REST/proto API definitions","fork":true,"url":"https://api.github.com/repos/mandarjog/data-plane-api","forks_url":"https://api.github.com/repos/mandarjog/data-plane-api/forks","keys_url":"https://api.github.com/repos/mandarjog/data-plane-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandarjog/data-plane-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandarjog/data-plane-api/teams","hooks_url":"https://api.github.com/repos/mandarjog/data-plane-api/hooks","issue_events_url":"https://api.github.com/repos/mandarjog/data-plane-api/issues/events{/number}","events_url":"https://api.github.com/repos/mandarjog/data-plane-api/events","assignees_url":"https://api.github.com/repos/mandarjog/data-plane-api/assignees{/user}","branches_url":"https://api.github.com/repos/mandarjog/data-plane-api/branches{/branch}","tags_url":"https://api.github.com/repos/mandarjog/data-plane-api/tags","blobs_url":"https://api.github.com/repos/mandarjog/data-plane-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandarjog/data-plane-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandarjog/data-plane-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandarjog/data-plane-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandarjog/data-plane-api/statuses/{sha}","languages_url":"https://api.github.com/repos/mandarjog/data-plane-api/languages","stargazers_url":"https://api.github.com/repos/mandarjog/data-plane-api/stargazers","contributors_url":"https://api.github.com/repos/mandarjog/data-plane-api/contributors","subscribers_url":"https://api.github.com/repos/mandarjog/data-plane-api/subscribers","subscription_url":"https://api.github.com/repos/mandarjog/data-plane-api/subscription","commits_url":"https://api.github.com/repos/mandarjog/data-plane-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandarjog/data-plane-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandarjog/data-plane-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandarjog/data-plane-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandarjog/data-plane-api/contents/{+path}","compare_url":"https://api.github.com/repos/mandarjog/data-plane-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandarjog/data-plane-api/merges","archive_url":"https://api.github.com/repos/mandarjog/data-plane-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandarjog/data-plane-api/downloads","issues_url":"https://api.github.com/repos/mandarjog/data-plane-api/issues{/number}","pulls_url":"https://api.github.com/repos/mandarjog/data-plane-api/pulls{/number}","milestones_url":"https://api.github.com/repos/mandarjog/data-plane-api/milestones{/number}","notifications_url":"https://api.github.com/repos/mandarjog/data-plane-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandarjog/data-plane-api/labels{/name}","releases_url":"https://api.github.com/repos/mandarjog/data-plane-api/releases{/id}","deployments_url":"https://api.github.com/repos/mandarjog/data-plane-api/deployments","created_at":"2017-11-29T15:12:28Z","updated_at":"2017-11-29T15:12:30Z","pushed_at":"2017-12-04T18:41:24Z","git_url":"git://github.com/mandarjog/data-plane-api.git","ssh_url":"git@github.com:mandarjog/data-plane-api.git","clone_url":"https://github.com/mandarjog/data-plane-api.git","svn_url":"https://github.com/mandarjog/data-plane-api","homepage":null,"size":856,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"9852d446f2b1e336ca1ce3b037ae7929dbf41d66","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":90675549,"name":"data-plane-api","full_name":"envoyproxy/data-plane-api","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/data-plane-api","description":"Envoy REST/proto API definitions","fork":false,"url":"https://api.github.com/repos/envoyproxy/data-plane-api","forks_url":"https://api.github.com/repos/envoyproxy/data-plane-api/forks","keys_url":"https://api.github.com/repos/envoyproxy/data-plane-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/data-plane-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/data-plane-api/teams","hooks_url":"https://api.github.com/repos/envoyproxy/data-plane-api/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/data-plane-api/events","assignees_url":"https://api.github.com/repos/envoyproxy/data-plane-api/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/data-plane-api/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/data-plane-api/tags","blobs_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/data-plane-api/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/data-plane-api/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/data-plane-api/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/data-plane-api/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/data-plane-api/subscription","commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/data-plane-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/data-plane-api/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/data-plane-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/data-plane-api/merges","archive_url":"https://api.github.com/repos/envoyproxy/data-plane-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/data-plane-api/downloads","issues_url":"https://api.github.com/repos/envoyproxy/data-plane-api/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/data-plane-api/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/data-plane-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/data-plane-api/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/data-plane-api/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/data-plane-api/deployments","created_at":"2017-05-08T21:50:29Z","updated_at":"2017-12-11T23:39:11Z","pushed_at":"2017-12-12T02:19:42Z","git_url":"git://github.com/envoyproxy/data-plane-api.git","ssh_url":"git@github.com:envoyproxy/data-plane-api.git","clone_url":"https://github.com/envoyproxy/data-plane-api.git","svn_url":"https://github.com/envoyproxy/data-plane-api","homepage":null,"size":867,"stargazers_count":55,"watchers_count":55,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":46,"open_issues":16,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/296"},"html":{"href":"https://github.com/envoyproxy/data-plane-api/pull/296"},"issue":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/296"},"comments":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/data-plane-api/statuses/79ceac59d74b8d56bef02570ea0dc3bf778718bf"}},"author_association":"NONE"}}
{"actor":{"display_login":"wora"}}