{"action":"created","comment":{"url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/comments/114869967","pull_request_review_id":36367661,"id":114869967,"diff_hunk":"@@ -10,4 +10,299 @@\n \n #include \"HDF5ReaderP.h\"\n \n-#include <iostream> //needs to go away, this is just for demo purposes\n+#include \"adios2/ADIOSMPI.h\"\n+\n+namespace adios\n+{\n+\n+HDF5Reader::HDF5Reader(ADIOS &adios, const std::string name,\n+                       const std::string accessMode, MPI_Comm mpiComm,\n+                       const Method &method)\n+: Engine(adios, \"HDF5Reader\", name, accessMode, mpiComm, method,\n+         \" HDF5Reader constructor (or call to ADIOS Open).\\n\")\n+{\n+    Init();\n+    MPI_Comm_rank(mpiComm, &_mpi_rank);\n+    MPI_Comm_size(mpiComm, &_mpi_size);\n+}\n+\n+HDF5Reader::~HDF5Reader() {}\n+\n+void HDF5Reader::Init()\n+{\n+    if (m_AccessMode != \"r\" && m_AccessMode != \"read\")\n+    {\n+        throw std::invalid_argument(\n+            \"ERROR: HDF5Reader doesn't support access mode \" + m_AccessMode +\n+            \", in call to ADIOS Open or HDF5Reader constructor\\n\");\n+    }\n+\n+    _H5File.H5_Init(m_Name, m_MPIComm, false);\n+    _H5File.GetNumTimeSteps();\n+}\n+\n+Variable<void> *HDF5Reader::InquireVariable(const std::string &variableName,\n+                                            const bool readIn)\n+{\n+    std::cout << \"Not implemented: HDF5Reder::InquireVariable()\" << std::endl;\n+}\n+\n+Variable<char> *HDF5Reader::InquireVariableChar(const std::string &variableName,\n+                                                const bool readIn)\n+{\n+}\n+\n+Variable<unsigned char> *\n+HDF5Reader::InquireVariableUChar(const std::string &variableName,\n+                                 const bool readIn)\n+{\n+}\n+\n+Variable<short> *\n+HDF5Reader::InquireVariableShort(const std::string &variableName,\n+                                 const bool readIn)\n+{\n+}\n+\n+Variable<unsigned short> *\n+HDF5Reader::InquireVariableUShort(const std::string &variableName,\n+                                  const bool readIn)\n+{\n+}\n+\n+Variable<int> *HDF5Reader::InquireVariableInt(const std::string &variableName,\n+                                              const bool)\n+{\n+}\n+\n+Variable<unsigned int> *\n+HDF5Reader::InquireVariableUInt(const std::string &variableName, const bool)\n+{\n+}\n+\n+Variable<long int> *\n+HDF5Reader::InquireVariableLInt(const std::string &variableName, const bool)\n+{\n+}\n+\n+Variable<unsigned long int> *\n+HDF5Reader::InquireVariableULInt(const std::string &variableName, const bool)\n+{\n+}\n+\n+Variable<long long int> *\n+HDF5Reader::InquireVariableLLInt(const std::string &variableName, const bool)\n+{\n+}\n+\n+Variable<unsigned long long int> *\n+HDF5Reader::InquireVariableULLInt(const std::string &variableName, const bool)\n+{\n+}\n+\n+Variable<float> *\n+HDF5Reader::InquireVariableFloat(const std::string &variableName, const bool)\n+{\n+}\n+\n+Variable<double> *\n+HDF5Reader::InquireVariableDouble(const std::string &variableName, const bool)","path":"source/adios2/engine/hdf5/HDF5ReaderP.cpp","position":111,"original_position":101,"commit_id":"59b28696cd6f8d65e6a10da114d6e1bf457c6fce","original_commit_id":"bc341401c627ed19e136bcfaa577e39a3108df87","user":{"login":"guj","id":7468822,"avatar_url":"https://avatars2.githubusercontent.com/u/7468822?v=3","gravatar_id":"","url":"https://api.github.com/users/guj","html_url":"https://github.com/guj","followers_url":"https://api.github.com/users/guj/followers","following_url":"https://api.github.com/users/guj/following{/other_user}","gists_url":"https://api.github.com/users/guj/gists{/gist_id}","starred_url":"https://api.github.com/users/guj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guj/subscriptions","organizations_url":"https://api.github.com/users/guj/orgs","repos_url":"https://api.github.com/users/guj/repos","events_url":"https://api.github.com/users/guj/events{/privacy}","received_events_url":"https://api.github.com/users/guj/received_events","type":"User","site_admin":false},"body":"I added null return, for now. \r\n\r\nThis function has a body now, because I noticed ReadMe(), which is not inherited from any parent class, was not touched during compilation, unless I call it from a parent class function, like InquireVariableDouble().\r\n\r\nDo you know why?","created_at":"2017-05-04T19:42:02Z","updated_at":"2017-05-04T19:42:02Z","html_url":"https://github.com/ornladios/ADIOS2/pull/101#discussion_r114869967","pull_request_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/101","_links":{"self":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/comments/114869967"},"html":{"href":"https://github.com/ornladios/ADIOS2/pull/101#discussion_r114869967"},"pull_request":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/101","id":118607389,"html_url":"https://github.com/ornladios/ADIOS2/pull/101","diff_url":"https://github.com/ornladios/ADIOS2/pull/101.diff","patch_url":"https://github.com/ornladios/ADIOS2/pull/101.patch","issue_url":"https://api.github.com/repos/ornladios/ADIOS2/issues/101","number":101,"state":"open","locked":false,"title":"Hdf5","user":{"login":"guj","id":7468822,"avatar_url":"https://avatars2.githubusercontent.com/u/7468822?v=3","gravatar_id":"","url":"https://api.github.com/users/guj","html_url":"https://github.com/guj","followers_url":"https://api.github.com/users/guj/followers","following_url":"https://api.github.com/users/guj/following{/other_user}","gists_url":"https://api.github.com/users/guj/gists{/gist_id}","starred_url":"https://api.github.com/users/guj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guj/subscriptions","organizations_url":"https://api.github.com/users/guj/orgs","repos_url":"https://api.github.com/users/guj/repos","events_url":"https://api.github.com/users/guj/events{/privacy}","received_events_url":"https://api.github.com/users/guj/received_events","type":"User","site_admin":false},"body":"added timestep and read write. \r\nlooks like I need to merge with master? structure was changed\r\n\r\nfor using reader in current write-read test, see helloHDF5Writer.cpp at the end of write section, there is a few lines to read what was written.","created_at":"2017-05-02T17:39:02Z","updated_at":"2017-05-04T19:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ebf7e7bbebfc1ba8b16943d8d0ac4352f6bd349","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/101/commits","review_comments_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/101/comments","review_comment_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ornladios/ADIOS2/issues/101/comments","statuses_url":"https://api.github.com/repos/ornladios/ADIOS2/statuses/59b28696cd6f8d65e6a10da114d6e1bf457c6fce","head":{"label":"guj:hdf5","ref":"hdf5","sha":"59b28696cd6f8d65e6a10da114d6e1bf457c6fce","user":{"login":"guj","id":7468822,"avatar_url":"https://avatars2.githubusercontent.com/u/7468822?v=3","gravatar_id":"","url":"https://api.github.com/users/guj","html_url":"https://github.com/guj","followers_url":"https://api.github.com/users/guj/followers","following_url":"https://api.github.com/users/guj/following{/other_user}","gists_url":"https://api.github.com/users/guj/gists{/gist_id}","starred_url":"https://api.github.com/users/guj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guj/subscriptions","organizations_url":"https://api.github.com/users/guj/orgs","repos_url":"https://api.github.com/users/guj/repos","events_url":"https://api.github.com/users/guj/events{/privacy}","received_events_url":"https://api.github.com/users/guj/received_events","type":"User","site_admin":false},"repo":{"id":87505007,"name":"ADIOS2","full_name":"guj/ADIOS2","owner":{"login":"guj","id":7468822,"avatar_url":"https://avatars2.githubusercontent.com/u/7468822?v=3","gravatar_id":"","url":"https://api.github.com/users/guj","html_url":"https://github.com/guj","followers_url":"https://api.github.com/users/guj/followers","following_url":"https://api.github.com/users/guj/following{/other_user}","gists_url":"https://api.github.com/users/guj/gists{/gist_id}","starred_url":"https://api.github.com/users/guj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guj/subscriptions","organizations_url":"https://api.github.com/users/guj/orgs","repos_url":"https://api.github.com/users/guj/repos","events_url":"https://api.github.com/users/guj/events{/privacy}","received_events_url":"https://api.github.com/users/guj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guj/ADIOS2","description":"Next generation of ADIOS developed in the Exascale Computing Program","fork":true,"url":"https://api.github.com/repos/guj/ADIOS2","forks_url":"https://api.github.com/repos/guj/ADIOS2/forks","keys_url":"https://api.github.com/repos/guj/ADIOS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guj/ADIOS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guj/ADIOS2/teams","hooks_url":"https://api.github.com/repos/guj/ADIOS2/hooks","issue_events_url":"https://api.github.com/repos/guj/ADIOS2/issues/events{/number}","events_url":"https://api.github.com/repos/guj/ADIOS2/events","assignees_url":"https://api.github.com/repos/guj/ADIOS2/assignees{/user}","branches_url":"https://api.github.com/repos/guj/ADIOS2/branches{/branch}","tags_url":"https://api.github.com/repos/guj/ADIOS2/tags","blobs_url":"https://api.github.com/repos/guj/ADIOS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guj/ADIOS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guj/ADIOS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/guj/ADIOS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guj/ADIOS2/statuses/{sha}","languages_url":"https://api.github.com/repos/guj/ADIOS2/languages","stargazers_url":"https://api.github.com/repos/guj/ADIOS2/stargazers","contributors_url":"https://api.github.com/repos/guj/ADIOS2/contributors","subscribers_url":"https://api.github.com/repos/guj/ADIOS2/subscribers","subscription_url":"https://api.github.com/repos/guj/ADIOS2/subscription","commits_url":"https://api.github.com/repos/guj/ADIOS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/guj/ADIOS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/guj/ADIOS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/guj/ADIOS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/guj/ADIOS2/contents/{+path}","compare_url":"https://api.github.com/repos/guj/ADIOS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guj/ADIOS2/merges","archive_url":"https://api.github.com/repos/guj/ADIOS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guj/ADIOS2/downloads","issues_url":"https://api.github.com/repos/guj/ADIOS2/issues{/number}","pulls_url":"https://api.github.com/repos/guj/ADIOS2/pulls{/number}","milestones_url":"https://api.github.com/repos/guj/ADIOS2/milestones{/number}","notifications_url":"https://api.github.com/repos/guj/ADIOS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guj/ADIOS2/labels{/name}","releases_url":"https://api.github.com/repos/guj/ADIOS2/releases{/id}","deployments_url":"https://api.github.com/repos/guj/ADIOS2/deployments","created_at":"2017-04-07T04:41:07Z","updated_at":"2017-04-07T04:41:08Z","pushed_at":"2017-05-04T17:57:08Z","git_url":"git://github.com/guj/ADIOS2.git","ssh_url":"git@github.com:guj/ADIOS2.git","clone_url":"https://github.com/guj/ADIOS2.git","svn_url":"https://github.com/guj/ADIOS2","homepage":null,"size":3174,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ornladios:master","ref":"master","sha":"88f261e94afb32832fe3b312b92014ee2eec307e","user":{"login":"ornladios","id":3661939,"avatar_url":"https://avatars2.githubusercontent.com/u/3661939?v=3","gravatar_id":"","url":"https://api.github.com/users/ornladios","html_url":"https://github.com/ornladios","followers_url":"https://api.github.com/users/ornladios/followers","following_url":"https://api.github.com/users/ornladios/following{/other_user}","gists_url":"https://api.github.com/users/ornladios/gists{/gist_id}","starred_url":"https://api.github.com/users/ornladios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ornladios/subscriptions","organizations_url":"https://api.github.com/users/ornladios/orgs","repos_url":"https://api.github.com/users/ornladios/repos","events_url":"https://api.github.com/users/ornladios/events{/privacy}","received_events_url":"https://api.github.com/users/ornladios/received_events","type":"Organization","site_admin":false},"repo":{"id":75750830,"name":"ADIOS2","full_name":"ornladios/ADIOS2","owner":{"login":"ornladios","id":3661939,"avatar_url":"https://avatars2.githubusercontent.com/u/3661939?v=3","gravatar_id":"","url":"https://api.github.com/users/ornladios","html_url":"https://github.com/ornladios","followers_url":"https://api.github.com/users/ornladios/followers","following_url":"https://api.github.com/users/ornladios/following{/other_user}","gists_url":"https://api.github.com/users/ornladios/gists{/gist_id}","starred_url":"https://api.github.com/users/ornladios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ornladios/subscriptions","organizations_url":"https://api.github.com/users/ornladios/orgs","repos_url":"https://api.github.com/users/ornladios/repos","events_url":"https://api.github.com/users/ornladios/events{/privacy}","received_events_url":"https://api.github.com/users/ornladios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ornladios/ADIOS2","description":"Next generation of ADIOS developed in the Exascale Computing Program","fork":false,"url":"https://api.github.com/repos/ornladios/ADIOS2","forks_url":"https://api.github.com/repos/ornladios/ADIOS2/forks","keys_url":"https://api.github.com/repos/ornladios/ADIOS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ornladios/ADIOS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ornladios/ADIOS2/teams","hooks_url":"https://api.github.com/repos/ornladios/ADIOS2/hooks","issue_events_url":"https://api.github.com/repos/ornladios/ADIOS2/issues/events{/number}","events_url":"https://api.github.com/repos/ornladios/ADIOS2/events","assignees_url":"https://api.github.com/repos/ornladios/ADIOS2/assignees{/user}","branches_url":"https://api.github.com/repos/ornladios/ADIOS2/branches{/branch}","tags_url":"https://api.github.com/repos/ornladios/ADIOS2/tags","blobs_url":"https://api.github.com/repos/ornladios/ADIOS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ornladios/ADIOS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ornladios/ADIOS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ornladios/ADIOS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ornladios/ADIOS2/statuses/{sha}","languages_url":"https://api.github.com/repos/ornladios/ADIOS2/languages","stargazers_url":"https://api.github.com/repos/ornladios/ADIOS2/stargazers","contributors_url":"https://api.github.com/repos/ornladios/ADIOS2/contributors","subscribers_url":"https://api.github.com/repos/ornladios/ADIOS2/subscribers","subscription_url":"https://api.github.com/repos/ornladios/ADIOS2/subscription","commits_url":"https://api.github.com/repos/ornladios/ADIOS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ornladios/ADIOS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ornladios/ADIOS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ornladios/ADIOS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ornladios/ADIOS2/contents/{+path}","compare_url":"https://api.github.com/repos/ornladios/ADIOS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ornladios/ADIOS2/merges","archive_url":"https://api.github.com/repos/ornladios/ADIOS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ornladios/ADIOS2/downloads","issues_url":"https://api.github.com/repos/ornladios/ADIOS2/issues{/number}","pulls_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls{/number}","milestones_url":"https://api.github.com/repos/ornladios/ADIOS2/milestones{/number}","notifications_url":"https://api.github.com/repos/ornladios/ADIOS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ornladios/ADIOS2/labels{/name}","releases_url":"https://api.github.com/repos/ornladios/ADIOS2/releases{/id}","deployments_url":"https://api.github.com/repos/ornladios/ADIOS2/deployments","created_at":"2016-12-06T16:39:55Z","updated_at":"2017-04-20T21:25:50Z","pushed_at":"2017-05-04T17:57:09Z","git_url":"git://github.com/ornladios/ADIOS2.git","ssh_url":"git@github.com:ornladios/ADIOS2.git","clone_url":"https://github.com/ornladios/ADIOS2.git","svn_url":"https://github.com/ornladios/ADIOS2","homepage":null,"size":3152,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/101"},"html":{"href":"https://github.com/ornladios/ADIOS2/pull/101"},"issue":{"href":"https://api.github.com/repos/ornladios/ADIOS2/issues/101"},"comments":{"href":"https://api.github.com/repos/ornladios/ADIOS2/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/ornladios/ADIOS2/statuses/59b28696cd6f8d65e6a10da114d6e1bf457c6fce"}}}}
{"actor":{"display_login":"guj"}}