{"action":"created","comment":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/comments/134444888","pull_request_review_id":57735345,"id":134444888,"diff_hunk":"@@ -93,6 +96,14 @@\n         java.security.Security.setProperty(\"networkaddress.cache.ttl\", \"30\");\n     }\n \n+    /**\n+     * Thread-safe, shared static instance for all requests. Registry is also static, so does not\n+     * make much difference to inject. If you wanted to inject, you could do so rather easily using\n+     * CDI injection.\n+     */\n+    private static final RequestMetrics metrics =\n+            new DropwizardRequestMetrics(MetricRegistryFactory.getMetricRegistry());","path":"crud/src/main/java/com/redhat/lightblue/rest/crud/AbstractCrudResource.java","position":null,"original_position":20,"commit_id":"6fd935f7a41fb6b9242462405a2b05b72eeaee32","original_commit_id":"2304c59546a580043a967a91ca015d8efb39d864","user":{"login":"svkm102","id":9564516,"avatar_url":"https://avatars0.githubusercontent.com/u/9564516?v=4","gravatar_id":"","url":"https://api.github.com/users/svkm102","html_url":"https://github.com/svkm102","followers_url":"https://api.github.com/users/svkm102/followers","following_url":"https://api.github.com/users/svkm102/following{/other_user}","gists_url":"https://api.github.com/users/svkm102/gists{/gist_id}","starred_url":"https://api.github.com/users/svkm102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svkm102/subscriptions","organizations_url":"https://api.github.com/users/svkm102/orgs","repos_url":"https://api.github.com/users/svkm102/repos","events_url":"https://api.github.com/users/svkm102/events{/privacy}","received_events_url":"https://api.github.com/users/svkm102/received_events","type":"User","site_admin":false},"body":"Changed getMetricRegistry() to getJmxMetricRegistry() for clarity.","created_at":"2017-08-22T10:44:03Z","updated_at":"2017-08-22T10:44:03Z","html_url":"https://github.com/lightblue-platform/lightblue-rest/pull/300#discussion_r134444888","pull_request_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/300","_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/comments/134444888"},"html":{"href":"https://github.com/lightblue-platform/lightblue-rest/pull/300#discussion_r134444888"},"pull_request":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/300"}}},"pull_request":{"url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/300","id":135274105,"html_url":"https://github.com/lightblue-platform/lightblue-rest/pull/300","diff_url":"https://github.com/lightblue-platform/lightblue-rest/pull/300.diff","patch_url":"https://github.com/lightblue-platform/lightblue-rest/pull/300.patch","issue_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/300","number":300,"state":"open","locked":false,"title":"Move metrics in lbcore","user":{"login":"svkm102","id":9564516,"avatar_url":"https://avatars0.githubusercontent.com/u/9564516?v=4","gravatar_id":"","url":"https://api.github.com/users/svkm102","html_url":"https://github.com/svkm102","followers_url":"https://api.github.com/users/svkm102/followers","following_url":"https://api.github.com/users/svkm102/following{/other_user}","gists_url":"https://api.github.com/users/svkm102/gists{/gist_id}","starred_url":"https://api.github.com/users/svkm102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svkm102/subscriptions","organizations_url":"https://api.github.com/users/svkm102/orgs","repos_url":"https://api.github.com/users/svkm102/repos","events_url":"https://api.github.com/users/svkm102/events{/privacy}","received_events_url":"https://api.github.com/users/svkm102/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-11T06:33:24Z","updated_at":"2017-08-22T10:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4d5c8c7e5404e6e2bc4e4d747d12f8183809c38","assignee":null,"assignees":[],"requested_reviewers":[{"login":"derek63","id":990017,"avatar_url":"https://avatars3.githubusercontent.com/u/990017?v=4","gravatar_id":"","url":"https://api.github.com/users/derek63","html_url":"https://github.com/derek63","followers_url":"https://api.github.com/users/derek63/followers","following_url":"https://api.github.com/users/derek63/following{/other_user}","gists_url":"https://api.github.com/users/derek63/gists{/gist_id}","starred_url":"https://api.github.com/users/derek63/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derek63/subscriptions","organizations_url":"https://api.github.com/users/derek63/orgs","repos_url":"https://api.github.com/users/derek63/repos","events_url":"https://api.github.com/users/derek63/events{/privacy}","received_events_url":"https://api.github.com/users/derek63/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/300/commits","review_comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/300/comments","review_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/300/comments","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/statuses/6fd935f7a41fb6b9242462405a2b05b72eeaee32","head":{"label":"svkm102:metrics-refractoring","ref":"metrics-refractoring","sha":"6fd935f7a41fb6b9242462405a2b05b72eeaee32","user":{"login":"svkm102","id":9564516,"avatar_url":"https://avatars0.githubusercontent.com/u/9564516?v=4","gravatar_id":"","url":"https://api.github.com/users/svkm102","html_url":"https://github.com/svkm102","followers_url":"https://api.github.com/users/svkm102/followers","following_url":"https://api.github.com/users/svkm102/following{/other_user}","gists_url":"https://api.github.com/users/svkm102/gists{/gist_id}","starred_url":"https://api.github.com/users/svkm102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svkm102/subscriptions","organizations_url":"https://api.github.com/users/svkm102/orgs","repos_url":"https://api.github.com/users/svkm102/repos","events_url":"https://api.github.com/users/svkm102/events{/privacy}","received_events_url":"https://api.github.com/users/svkm102/received_events","type":"User","site_admin":false},"repo":{"id":96506599,"name":"lightblue-rest","full_name":"svkm102/lightblue-rest","owner":{"login":"svkm102","id":9564516,"avatar_url":"https://avatars0.githubusercontent.com/u/9564516?v=4","gravatar_id":"","url":"https://api.github.com/users/svkm102","html_url":"https://github.com/svkm102","followers_url":"https://api.github.com/users/svkm102/followers","following_url":"https://api.github.com/users/svkm102/following{/other_user}","gists_url":"https://api.github.com/users/svkm102/gists{/gist_id}","starred_url":"https://api.github.com/users/svkm102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svkm102/subscriptions","organizations_url":"https://api.github.com/users/svkm102/orgs","repos_url":"https://api.github.com/users/svkm102/repos","events_url":"https://api.github.com/users/svkm102/events{/privacy}","received_events_url":"https://api.github.com/users/svkm102/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svkm102/lightblue-rest","description":"Data access  layer as service REST API","fork":true,"url":"https://api.github.com/repos/svkm102/lightblue-rest","forks_url":"https://api.github.com/repos/svkm102/lightblue-rest/forks","keys_url":"https://api.github.com/repos/svkm102/lightblue-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svkm102/lightblue-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svkm102/lightblue-rest/teams","hooks_url":"https://api.github.com/repos/svkm102/lightblue-rest/hooks","issue_events_url":"https://api.github.com/repos/svkm102/lightblue-rest/issues/events{/number}","events_url":"https://api.github.com/repos/svkm102/lightblue-rest/events","assignees_url":"https://api.github.com/repos/svkm102/lightblue-rest/assignees{/user}","branches_url":"https://api.github.com/repos/svkm102/lightblue-rest/branches{/branch}","tags_url":"https://api.github.com/repos/svkm102/lightblue-rest/tags","blobs_url":"https://api.github.com/repos/svkm102/lightblue-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svkm102/lightblue-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svkm102/lightblue-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/svkm102/lightblue-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svkm102/lightblue-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/svkm102/lightblue-rest/languages","stargazers_url":"https://api.github.com/repos/svkm102/lightblue-rest/stargazers","contributors_url":"https://api.github.com/repos/svkm102/lightblue-rest/contributors","subscribers_url":"https://api.github.com/repos/svkm102/lightblue-rest/subscribers","subscription_url":"https://api.github.com/repos/svkm102/lightblue-rest/subscription","commits_url":"https://api.github.com/repos/svkm102/lightblue-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/svkm102/lightblue-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/svkm102/lightblue-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/svkm102/lightblue-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/svkm102/lightblue-rest/contents/{+path}","compare_url":"https://api.github.com/repos/svkm102/lightblue-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svkm102/lightblue-rest/merges","archive_url":"https://api.github.com/repos/svkm102/lightblue-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svkm102/lightblue-rest/downloads","issues_url":"https://api.github.com/repos/svkm102/lightblue-rest/issues{/number}","pulls_url":"https://api.github.com/repos/svkm102/lightblue-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/svkm102/lightblue-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/svkm102/lightblue-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svkm102/lightblue-rest/labels{/name}","releases_url":"https://api.github.com/repos/svkm102/lightblue-rest/releases{/id}","deployments_url":"https://api.github.com/repos/svkm102/lightblue-rest/deployments","created_at":"2017-07-07T06:30:03Z","updated_at":"2017-07-07T06:30:04Z","pushed_at":"2017-08-22T10:43:53Z","git_url":"git://github.com/svkm102/lightblue-rest.git","ssh_url":"git@github.com:svkm102/lightblue-rest.git","clone_url":"https://github.com/svkm102/lightblue-rest.git","svn_url":"https://github.com/svkm102/lightblue-rest","homepage":"","size":12914,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lightblue-platform:master","ref":"master","sha":"e54c859783ceb820ce085643b78e8050746ddf4d","user":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars1.githubusercontent.com/u/7061725?v=4","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":23001404,"name":"lightblue-rest","full_name":"lightblue-platform/lightblue-rest","owner":{"login":"lightblue-platform","id":7061725,"avatar_url":"https://avatars1.githubusercontent.com/u/7061725?v=4","gravatar_id":"","url":"https://api.github.com/users/lightblue-platform","html_url":"https://github.com/lightblue-platform","followers_url":"https://api.github.com/users/lightblue-platform/followers","following_url":"https://api.github.com/users/lightblue-platform/following{/other_user}","gists_url":"https://api.github.com/users/lightblue-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/lightblue-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightblue-platform/subscriptions","organizations_url":"https://api.github.com/users/lightblue-platform/orgs","repos_url":"https://api.github.com/users/lightblue-platform/repos","events_url":"https://api.github.com/users/lightblue-platform/events{/privacy}","received_events_url":"https://api.github.com/users/lightblue-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lightblue-platform/lightblue-rest","description":"Data access  layer as service REST API","fork":false,"url":"https://api.github.com/repos/lightblue-platform/lightblue-rest","forks_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/forks","keys_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/teams","hooks_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/hooks","issue_events_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/events{/number}","events_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/events","assignees_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/assignees{/user}","branches_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/branches{/branch}","tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/tags","blobs_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/refs{/sha}","trees_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/statuses/{sha}","languages_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/languages","stargazers_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/stargazers","contributors_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/contributors","subscribers_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/subscribers","subscription_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/subscription","commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/commits{/sha}","git_commits_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/git/commits{/sha}","comments_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/comments{/number}","issue_comment_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/comments{/number}","contents_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/contents/{+path}","compare_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/merges","archive_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/downloads","issues_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues{/number}","pulls_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls{/number}","milestones_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/milestones{/number}","notifications_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/labels{/name}","releases_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/releases{/id}","deployments_url":"https://api.github.com/repos/lightblue-platform/lightblue-rest/deployments","created_at":"2014-08-15T19:59:57Z","updated_at":"2017-02-06T20:05:27Z","pushed_at":"2017-08-22T10:43:54Z","git_url":"git://github.com/lightblue-platform/lightblue-rest.git","ssh_url":"git@github.com:lightblue-platform/lightblue-rest.git","clone_url":"https://github.com/lightblue-platform/lightblue-rest.git","svn_url":"https://github.com/lightblue-platform/lightblue-rest","homepage":"","size":12762,"stargazers_count":7,"watchers_count":7,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":45,"forks":14,"open_issues":45,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/300"},"html":{"href":"https://github.com/lightblue-platform/lightblue-rest/pull/300"},"issue":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/300"},"comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/lightblue-platform/lightblue-rest/statuses/6fd935f7a41fb6b9242462405a2b05b72eeaee32"}}}}
{"actor":{"display_login":"svkm102"}}