{"action":"created","comment":{"url":"https://api.github.com/repos/istio/proxy/pulls/comments/102387071","pull_request_review_id":23140023,"id":102387071,"diff_hunk":"@@ -49,3 +49,51 @@ This Proxy will use Envoy and talk to Mixer server.\n   curl http://localhost:9090/echo -d \"hello world\"\n ```\n \n+## How to configurate HTTP filters\n+\n+This module has two HTTP filters:\n+1. mixer filter: intercept all HTTP requests, call the mixer.\n+2. send_attribute filter: Send some attributes to next hop istio/proxy with mixer filter.\n+\n+### *mixer* filter:\n+\n+This filter will intercept all HTTP requests and call Mixer. Here is its config:\n+\n+```\n+   \"filters\": [\n+      \"type\": \"both\",\n+      \"name\": \"mixer\",\n+      \"config\": {\n+         \"mixer_server\": \"${MIXER_SERVER}\",","path":"src/envoy/mixer/README.md","position":19,"original_position":19,"commit_id":"800c08864f04379b5888bc61d8f15248624faf13","original_commit_id":"800c08864f04379b5888bc61d8f15248624faf13","user":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars.githubusercontent.com/u/8202871?v=3","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"So it gets overriden during config gen? Then it sounds fine. In that case I would say use some non colliding variables like __Mixer__server__","created_at":"2017-02-22T05:35:33Z","updated_at":"2017-02-22T05:35:33Z","html_url":"https://github.com/istio/proxy/pull/115#discussion_r102387071","pull_request_url":"https://api.github.com/repos/istio/proxy/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments/102387071"},"html":{"href":"https://github.com/istio/proxy/pull/115#discussion_r102387071"},"pull_request":{"href":"https://api.github.com/repos/istio/proxy/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/istio/proxy/pulls/115","id":107330074,"html_url":"https://github.com/istio/proxy/pull/115","diff_url":"https://github.com/istio/proxy/pull/115.diff","patch_url":"https://github.com/istio/proxy/pull/115.patch","issue_url":"https://api.github.com/repos/istio/proxy/issues/115","number":115,"state":"open","locked":false,"title":"Add send_attribute filter.","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars.githubusercontent.com/u/11790727?v=3","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"This filter can send some attributes to the next hop istio/proxy.  It can be used as outbound istio/proxy.","created_at":"2017-02-22T03:48:27Z","updated_at":"2017-02-22T05:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4367a1a811d274cf85b995b1d737a5fd6dcd6314","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/proxy/pulls/115/commits","review_comments_url":"https://api.github.com/repos/istio/proxy/pulls/115/comments","review_comment_url":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/proxy/issues/115/comments","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/800c08864f04379b5888bc61d8f15248624faf13","head":{"label":"qiwzhang:add_header","ref":"add_header","sha":"800c08864f04379b5888bc61d8f15248624faf13","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars.githubusercontent.com/u/11790727?v=3","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"repo":{"id":75326074,"name":"proxy","full_name":"qiwzhang/proxy","owner":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars.githubusercontent.com/u/11790727?v=3","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qiwzhang/proxy","description":"The istio proxy implementations","fork":true,"url":"https://api.github.com/repos/qiwzhang/proxy","forks_url":"https://api.github.com/repos/qiwzhang/proxy/forks","keys_url":"https://api.github.com/repos/qiwzhang/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qiwzhang/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qiwzhang/proxy/teams","hooks_url":"https://api.github.com/repos/qiwzhang/proxy/hooks","issue_events_url":"https://api.github.com/repos/qiwzhang/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/qiwzhang/proxy/events","assignees_url":"https://api.github.com/repos/qiwzhang/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/qiwzhang/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/qiwzhang/proxy/tags","blobs_url":"https://api.github.com/repos/qiwzhang/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qiwzhang/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qiwzhang/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/qiwzhang/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qiwzhang/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/qiwzhang/proxy/languages","stargazers_url":"https://api.github.com/repos/qiwzhang/proxy/stargazers","contributors_url":"https://api.github.com/repos/qiwzhang/proxy/contributors","subscribers_url":"https://api.github.com/repos/qiwzhang/proxy/subscribers","subscription_url":"https://api.github.com/repos/qiwzhang/proxy/subscription","commits_url":"https://api.github.com/repos/qiwzhang/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/qiwzhang/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/qiwzhang/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/qiwzhang/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/qiwzhang/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/qiwzhang/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qiwzhang/proxy/merges","archive_url":"https://api.github.com/repos/qiwzhang/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qiwzhang/proxy/downloads","issues_url":"https://api.github.com/repos/qiwzhang/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/qiwzhang/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/qiwzhang/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/qiwzhang/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qiwzhang/proxy/labels{/name}","releases_url":"https://api.github.com/repos/qiwzhang/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/qiwzhang/proxy/deployments","created_at":"2016-12-01T19:36:57Z","updated_at":"2016-12-01T18:51:04Z","pushed_at":"2017-02-22T03:55:57Z","git_url":"git://github.com/qiwzhang/proxy.git","ssh_url":"git@github.com:qiwzhang/proxy.git","clone_url":"https://github.com/qiwzhang/proxy.git","svn_url":"https://github.com/qiwzhang/proxy","homepage":null,"size":539,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"d09325482e840f9ea73b96791535e88b04387a55","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75322405,"name":"proxy","full_name":"istio/proxy","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/proxy","description":"The istio proxy implementations","fork":false,"url":"https://api.github.com/repos/istio/proxy","forks_url":"https://api.github.com/repos/istio/proxy/forks","keys_url":"https://api.github.com/repos/istio/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/proxy/teams","hooks_url":"https://api.github.com/repos/istio/proxy/hooks","issue_events_url":"https://api.github.com/repos/istio/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/istio/proxy/events","assignees_url":"https://api.github.com/repos/istio/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/istio/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/istio/proxy/tags","blobs_url":"https://api.github.com/repos/istio/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/proxy/languages","stargazers_url":"https://api.github.com/repos/istio/proxy/stargazers","contributors_url":"https://api.github.com/repos/istio/proxy/contributors","subscribers_url":"https://api.github.com/repos/istio/proxy/subscribers","subscription_url":"https://api.github.com/repos/istio/proxy/subscription","commits_url":"https://api.github.com/repos/istio/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/istio/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/proxy/merges","archive_url":"https://api.github.com/repos/istio/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/proxy/downloads","issues_url":"https://api.github.com/repos/istio/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/istio/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/proxy/labels{/name}","releases_url":"https://api.github.com/repos/istio/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/istio/proxy/deployments","created_at":"2016-12-01T18:51:04Z","updated_at":"2017-02-20T18:11:57Z","pushed_at":"2017-02-22T03:55:58Z","git_url":"git://github.com/istio/proxy.git","ssh_url":"git@github.com:istio/proxy.git","clone_url":"https://github.com/istio/proxy.git","svn_url":"https://github.com/istio/proxy","homepage":"","size":581,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":8,"forks":17,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/115"},"html":{"href":"https://github.com/istio/proxy/pull/115"},"issue":{"href":"https://api.github.com/repos/istio/proxy/issues/115"},"comments":{"href":"https://api.github.com/repos/istio/proxy/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/proxy/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/proxy/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/istio/proxy/statuses/800c08864f04379b5888bc61d8f15248624faf13"}}}}
{"actor":{"display_login":"rshriram"}}