{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/MartijnDwars/web-push/pulls/26","id":119322358,"html_url":"https://github.com/MartijnDwars/web-push/pull/26","diff_url":"https://github.com/MartijnDwars/web-push/pull/26.diff","patch_url":"https://github.com/MartijnDwars/web-push/pull/26.patch","issue_url":"https://api.github.com/repos/MartijnDwars/web-push/issues/26","number":26,"state":"closed","locked":false,"title":"Vapid update","user":{"login":"MartijnDwars","id":426811,"avatar_url":"https://avatars1.githubusercontent.com/u/426811?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnDwars","html_url":"https://github.com/MartijnDwars","followers_url":"https://api.github.com/users/MartijnDwars/followers","following_url":"https://api.github.com/users/MartijnDwars/following{/other_user}","gists_url":"https://api.github.com/users/MartijnDwars/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnDwars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnDwars/subscriptions","organizations_url":"https://api.github.com/users/MartijnDwars/orgs","repos_url":"https://api.github.com/users/MartijnDwars/repos","events_url":"https://api.github.com/users/MartijnDwars/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnDwars/received_events","type":"User","site_admin":false},"body":"- Change the authorization header to use \"WebPush\" instead of \"Bearer\" (fixes #18).\r\n\r\n- Use [Web Push Testing Service](https://github.com/GoogleChrome/web-push-testing-service) for testing. WPTS seems quite stable and it takes are of many browser inconsistencies, such as whitelisting notifications for the test site.\r\n\r\n- Remove SauceLabs for integration testing. With SauceLabs, my push notifications never arrived at the browser. I suspect the Sauce Connect tunnel is the culprit here (which also does SSL bumping). Debugging was also very tedious (launching and inspecting the VM is incredibly slow).\r\n\r\n- Remove the `pom.xml`, because it makes no sense to have both a Gradle and Maven build configuration. The gradle wrapper is commited, so anyone should be able to build the project.\r\n\r\n- Add async API. Call `sendAsync` on the `PushService` to get a `Future<HttpResonse>`. If you want execution to block until the response is available, call `.get()` on the future.","created_at":"2017-05-07T01:25:37Z","updated_at":"2017-05-07T01:50:07Z","closed_at":"2017-05-07T01:50:07Z","merged_at":"2017-05-07T01:50:07Z","merge_commit_sha":"fd1f3911b9d23f331bc45e5b1f0c5b2422475648","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MartijnDwars/web-push/pulls/26/commits","review_comments_url":"https://api.github.com/repos/MartijnDwars/web-push/pulls/26/comments","review_comment_url":"https://api.github.com/repos/MartijnDwars/web-push/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MartijnDwars/web-push/issues/26/comments","statuses_url":"https://api.github.com/repos/MartijnDwars/web-push/statuses/e4c68b3569d7389b71c1a84512cb7db8d9d8ba59","head":{"label":"MartijnDwars:vapid-update","ref":"vapid-update","sha":"e4c68b3569d7389b71c1a84512cb7db8d9d8ba59","user":{"login":"MartijnDwars","id":426811,"avatar_url":"https://avatars1.githubusercontent.com/u/426811?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnDwars","html_url":"https://github.com/MartijnDwars","followers_url":"https://api.github.com/users/MartijnDwars/followers","following_url":"https://api.github.com/users/MartijnDwars/following{/other_user}","gists_url":"https://api.github.com/users/MartijnDwars/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnDwars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnDwars/subscriptions","organizations_url":"https://api.github.com/users/MartijnDwars/orgs","repos_url":"https://api.github.com/users/MartijnDwars/repos","events_url":"https://api.github.com/users/MartijnDwars/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnDwars/received_events","type":"User","site_admin":false},"repo":{"id":53700230,"name":"web-push","full_name":"MartijnDwars/web-push","owner":{"login":"MartijnDwars","id":426811,"avatar_url":"https://avatars1.githubusercontent.com/u/426811?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnDwars","html_url":"https://github.com/MartijnDwars","followers_url":"https://api.github.com/users/MartijnDwars/followers","following_url":"https://api.github.com/users/MartijnDwars/following{/other_user}","gists_url":"https://api.github.com/users/MartijnDwars/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnDwars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnDwars/subscriptions","organizations_url":"https://api.github.com/users/MartijnDwars/orgs","repos_url":"https://api.github.com/users/MartijnDwars/repos","events_url":"https://api.github.com/users/MartijnDwars/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnDwars/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MartijnDwars/web-push","description":"Web Push library for Java","fork":false,"url":"https://api.github.com/repos/MartijnDwars/web-push","forks_url":"https://api.github.com/repos/MartijnDwars/web-push/forks","keys_url":"https://api.github.com/repos/MartijnDwars/web-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MartijnDwars/web-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MartijnDwars/web-push/teams","hooks_url":"https://api.github.com/repos/MartijnDwars/web-push/hooks","issue_events_url":"https://api.github.com/repos/MartijnDwars/web-push/issues/events{/number}","events_url":"https://api.github.com/repos/MartijnDwars/web-push/events","assignees_url":"https://api.github.com/repos/MartijnDwars/web-push/assignees{/user}","branches_url":"https://api.github.com/repos/MartijnDwars/web-push/branches{/branch}","tags_url":"https://api.github.com/repos/MartijnDwars/web-push/tags","blobs_url":"https://api.github.com/repos/MartijnDwars/web-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MartijnDwars/web-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MartijnDwars/web-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/MartijnDwars/web-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MartijnDwars/web-push/statuses/{sha}","languages_url":"https://api.github.com/repos/MartijnDwars/web-push/languages","stargazers_url":"https://api.github.com/repos/MartijnDwars/web-push/stargazers","contributors_url":"https://api.github.com/repos/MartijnDwars/web-push/contributors","subscribers_url":"https://api.github.com/repos/MartijnDwars/web-push/subscribers","subscription_url":"https://api.github.com/repos/MartijnDwars/web-push/subscription","commits_url":"https://api.github.com/repos/MartijnDwars/web-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/MartijnDwars/web-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/MartijnDwars/web-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/MartijnDwars/web-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/MartijnDwars/web-push/contents/{+path}","compare_url":"https://api.github.com/repos/MartijnDwars/web-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MartijnDwars/web-push/merges","archive_url":"https://api.github.com/repos/MartijnDwars/web-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MartijnDwars/web-push/downloads","issues_url":"https://api.github.com/repos/MartijnDwars/web-push/issues{/number}","pulls_url":"https://api.github.com/repos/MartijnDwars/web-push/pulls{/number}","milestones_url":"https://api.github.com/repos/MartijnDwars/web-push/milestones{/number}","notifications_url":"https://api.github.com/repos/MartijnDwars/web-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MartijnDwars/web-push/labels{/name}","releases_url":"https://api.github.com/repos/MartijnDwars/web-push/releases{/id}","deployments_url":"https://api.github.com/repos/MartijnDwars/web-push/deployments","created_at":"2016-03-11T22:23:02Z","updated_at":"2017-03-24T18:35:04Z","pushed_at":"2017-05-07T01:50:07Z","git_url":"git://github.com/MartijnDwars/web-push.git","ssh_url":"git@github.com:MartijnDwars/web-push.git","clone_url":"https://github.com/MartijnDwars/web-push.git","svn_url":"https://github.com/MartijnDwars/web-push","homepage":"","size":295,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":26,"default_branch":"master"}},"base":{"label":"MartijnDwars:master","ref":"master","sha":"34c1ce79eace8841153dec50702a34eb050e5157","user":{"login":"MartijnDwars","id":426811,"avatar_url":"https://avatars1.githubusercontent.com/u/426811?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnDwars","html_url":"https://github.com/MartijnDwars","followers_url":"https://api.github.com/users/MartijnDwars/followers","following_url":"https://api.github.com/users/MartijnDwars/following{/other_user}","gists_url":"https://api.github.com/users/MartijnDwars/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnDwars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnDwars/subscriptions","organizations_url":"https://api.github.com/users/MartijnDwars/orgs","repos_url":"https://api.github.com/users/MartijnDwars/repos","events_url":"https://api.github.com/users/MartijnDwars/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnDwars/received_events","type":"User","site_admin":false},"repo":{"id":53700230,"name":"web-push","full_name":"MartijnDwars/web-push","owner":{"login":"MartijnDwars","id":426811,"avatar_url":"https://avatars1.githubusercontent.com/u/426811?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnDwars","html_url":"https://github.com/MartijnDwars","followers_url":"https://api.github.com/users/MartijnDwars/followers","following_url":"https://api.github.com/users/MartijnDwars/following{/other_user}","gists_url":"https://api.github.com/users/MartijnDwars/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnDwars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnDwars/subscriptions","organizations_url":"https://api.github.com/users/MartijnDwars/orgs","repos_url":"https://api.github.com/users/MartijnDwars/repos","events_url":"https://api.github.com/users/MartijnDwars/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnDwars/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MartijnDwars/web-push","description":"Web Push library for Java","fork":false,"url":"https://api.github.com/repos/MartijnDwars/web-push","forks_url":"https://api.github.com/repos/MartijnDwars/web-push/forks","keys_url":"https://api.github.com/repos/MartijnDwars/web-push/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MartijnDwars/web-push/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MartijnDwars/web-push/teams","hooks_url":"https://api.github.com/repos/MartijnDwars/web-push/hooks","issue_events_url":"https://api.github.com/repos/MartijnDwars/web-push/issues/events{/number}","events_url":"https://api.github.com/repos/MartijnDwars/web-push/events","assignees_url":"https://api.github.com/repos/MartijnDwars/web-push/assignees{/user}","branches_url":"https://api.github.com/repos/MartijnDwars/web-push/branches{/branch}","tags_url":"https://api.github.com/repos/MartijnDwars/web-push/tags","blobs_url":"https://api.github.com/repos/MartijnDwars/web-push/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MartijnDwars/web-push/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MartijnDwars/web-push/git/refs{/sha}","trees_url":"https://api.github.com/repos/MartijnDwars/web-push/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MartijnDwars/web-push/statuses/{sha}","languages_url":"https://api.github.com/repos/MartijnDwars/web-push/languages","stargazers_url":"https://api.github.com/repos/MartijnDwars/web-push/stargazers","contributors_url":"https://api.github.com/repos/MartijnDwars/web-push/contributors","subscribers_url":"https://api.github.com/repos/MartijnDwars/web-push/subscribers","subscription_url":"https://api.github.com/repos/MartijnDwars/web-push/subscription","commits_url":"https://api.github.com/repos/MartijnDwars/web-push/commits{/sha}","git_commits_url":"https://api.github.com/repos/MartijnDwars/web-push/git/commits{/sha}","comments_url":"https://api.github.com/repos/MartijnDwars/web-push/comments{/number}","issue_comment_url":"https://api.github.com/repos/MartijnDwars/web-push/issues/comments{/number}","contents_url":"https://api.github.com/repos/MartijnDwars/web-push/contents/{+path}","compare_url":"https://api.github.com/repos/MartijnDwars/web-push/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MartijnDwars/web-push/merges","archive_url":"https://api.github.com/repos/MartijnDwars/web-push/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MartijnDwars/web-push/downloads","issues_url":"https://api.github.com/repos/MartijnDwars/web-push/issues{/number}","pulls_url":"https://api.github.com/repos/MartijnDwars/web-push/pulls{/number}","milestones_url":"https://api.github.com/repos/MartijnDwars/web-push/milestones{/number}","notifications_url":"https://api.github.com/repos/MartijnDwars/web-push/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MartijnDwars/web-push/labels{/name}","releases_url":"https://api.github.com/repos/MartijnDwars/web-push/releases{/id}","deployments_url":"https://api.github.com/repos/MartijnDwars/web-push/deployments","created_at":"2016-03-11T22:23:02Z","updated_at":"2017-03-24T18:35:04Z","pushed_at":"2017-05-07T01:50:07Z","git_url":"git://github.com/MartijnDwars/web-push.git","ssh_url":"git@github.com:MartijnDwars/web-push.git","clone_url":"https://github.com/MartijnDwars/web-push.git","svn_url":"https://github.com/MartijnDwars/web-push","homepage":"","size":295,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MartijnDwars/web-push/pulls/26"},"html":{"href":"https://github.com/MartijnDwars/web-push/pull/26"},"issue":{"href":"https://api.github.com/repos/MartijnDwars/web-push/issues/26"},"comments":{"href":"https://api.github.com/repos/MartijnDwars/web-push/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/MartijnDwars/web-push/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/MartijnDwars/web-push/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MartijnDwars/web-push/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/MartijnDwars/web-push/statuses/e4c68b3569d7389b71c1a84512cb7db8d9d8ba59"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MartijnDwars","id":426811,"avatar_url":"https://avatars1.githubusercontent.com/u/426811?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnDwars","html_url":"https://github.com/MartijnDwars","followers_url":"https://api.github.com/users/MartijnDwars/followers","following_url":"https://api.github.com/users/MartijnDwars/following{/other_user}","gists_url":"https://api.github.com/users/MartijnDwars/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnDwars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnDwars/subscriptions","organizations_url":"https://api.github.com/users/MartijnDwars/orgs","repos_url":"https://api.github.com/users/MartijnDwars/repos","events_url":"https://api.github.com/users/MartijnDwars/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnDwars/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":21,"additions":639,"deletions":5393,"changed_files":75}}
{"actor":{"display_login":"MartijnDwars"}}