{"action":"created","comment":{"url":"https://api.github.com/repos/apache/samza/pulls/comments/142201200","pull_request_review_id":66527950,"id":142201200,"diff_hunk":"@@ -595,10 +604,14 @@ public void onFailure(TaskCallback callback, Throwable t) {\n     private final Set<SystemStreamPartition> processingSspSet;\n     private final TaskName taskName;\n     private final TaskInstanceMetrics taskMetrics;\n+    private final Counter taskMetricsCompletedCounter;","path":"samza-core/src/main/java/org/apache/samza/task/AsyncRunLoop.java","position":48,"original_position":48,"commit_id":"e84685ab65548b120478d92e55167a562432bf14","original_commit_id":"e84685ab65548b120478d92e55167a562432bf14","user":{"login":"nickpan47","id":9955590,"avatar_url":"https://avatars0.githubusercontent.com/u/9955590?v=4","gravatar_id":"","url":"https://api.github.com/users/nickpan47","html_url":"https://github.com/nickpan47","followers_url":"https://api.github.com/users/nickpan47/followers","following_url":"https://api.github.com/users/nickpan47/following{/other_user}","gists_url":"https://api.github.com/users/nickpan47/gists{/gist_id}","starred_url":"https://api.github.com/users/nickpan47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickpan47/subscriptions","organizations_url":"https://api.github.com/users/nickpan47/orgs","repos_url":"https://api.github.com/users/nickpan47/repos","events_url":"https://api.github.com/users/nickpan47/events{/privacy}","received_events_url":"https://api.github.com/users/nickpan47/received_events","type":"User","site_admin":false},"body":"Same here. Please follow the current pattern of instantiating metric in TaskInstanceMetrics","created_at":"2017-10-02T17:22:13Z","updated_at":"2017-10-02T17:25:24Z","html_url":"https://github.com/apache/samza/pull/306#discussion_r142201200","pull_request_url":"https://api.github.com/repos/apache/samza/pulls/306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/comments/142201200"},"html":{"href":"https://github.com/apache/samza/pull/306#discussion_r142201200"},"pull_request":{"href":"https://api.github.com/repos/apache/samza/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/306","id":143761735,"html_url":"https://github.com/apache/samza/pull/306","diff_url":"https://github.com/apache/samza/pull/306.diff","patch_url":"https://github.com/apache/samza/pull/306.patch","issue_url":"https://api.github.com/repos/apache/samza/issues/306","number":306,"state":"open","locked":false,"title":"SAMZA-1429: Add callback success/failure metrics to async tasks","user":{"login":"dnishimura","id":512169,"avatar_url":"https://avatars1.githubusercontent.com/u/512169?v=4","gravatar_id":"","url":"https://api.github.com/users/dnishimura","html_url":"https://github.com/dnishimura","followers_url":"https://api.github.com/users/dnishimura/followers","following_url":"https://api.github.com/users/dnishimura/following{/other_user}","gists_url":"https://api.github.com/users/dnishimura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnishimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnishimura/subscriptions","organizations_url":"https://api.github.com/users/dnishimura/orgs","repos_url":"https://api.github.com/users/dnishimura/repos","events_url":"https://api.github.com/users/dnishimura/events{/privacy}","received_events_url":"https://api.github.com/users/dnishimura/received_events","type":"User","site_admin":false},"body":"@jmakes & @nickpan47 please take a look when you get the chance.","created_at":"2017-09-28T21:35:57Z","updated_at":"2017-10-02T17:25:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be9585c205f26cc6bdd442f00d8e2715b68f4be3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/samza/pulls/306/commits","review_comments_url":"https://api.github.com/repos/apache/samza/pulls/306/comments","review_comment_url":"https://api.github.com/repos/apache/samza/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/samza/issues/306/comments","statuses_url":"https://api.github.com/repos/apache/samza/statuses/e84685ab65548b120478d92e55167a562432bf14","head":{"label":"dnishimura:samza-1429-async-metrics","ref":"samza-1429-async-metrics","sha":"e84685ab65548b120478d92e55167a562432bf14","user":{"login":"dnishimura","id":512169,"avatar_url":"https://avatars1.githubusercontent.com/u/512169?v=4","gravatar_id":"","url":"https://api.github.com/users/dnishimura","html_url":"https://github.com/dnishimura","followers_url":"https://api.github.com/users/dnishimura/followers","following_url":"https://api.github.com/users/dnishimura/following{/other_user}","gists_url":"https://api.github.com/users/dnishimura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnishimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnishimura/subscriptions","organizations_url":"https://api.github.com/users/dnishimura/orgs","repos_url":"https://api.github.com/users/dnishimura/repos","events_url":"https://api.github.com/users/dnishimura/events{/privacy}","received_events_url":"https://api.github.com/users/dnishimura/received_events","type":"User","site_admin":false},"repo":{"id":102049608,"name":"samza","full_name":"dnishimura/samza","owner":{"login":"dnishimura","id":512169,"avatar_url":"https://avatars1.githubusercontent.com/u/512169?v=4","gravatar_id":"","url":"https://api.github.com/users/dnishimura","html_url":"https://github.com/dnishimura","followers_url":"https://api.github.com/users/dnishimura/followers","following_url":"https://api.github.com/users/dnishimura/following{/other_user}","gists_url":"https://api.github.com/users/dnishimura/gists{/gist_id}","starred_url":"https://api.github.com/users/dnishimura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnishimura/subscriptions","organizations_url":"https://api.github.com/users/dnishimura/orgs","repos_url":"https://api.github.com/users/dnishimura/repos","events_url":"https://api.github.com/users/dnishimura/events{/privacy}","received_events_url":"https://api.github.com/users/dnishimura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnishimura/samza","description":"Mirror of Apache Samza","fork":true,"url":"https://api.github.com/repos/dnishimura/samza","forks_url":"https://api.github.com/repos/dnishimura/samza/forks","keys_url":"https://api.github.com/repos/dnishimura/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnishimura/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnishimura/samza/teams","hooks_url":"https://api.github.com/repos/dnishimura/samza/hooks","issue_events_url":"https://api.github.com/repos/dnishimura/samza/issues/events{/number}","events_url":"https://api.github.com/repos/dnishimura/samza/events","assignees_url":"https://api.github.com/repos/dnishimura/samza/assignees{/user}","branches_url":"https://api.github.com/repos/dnishimura/samza/branches{/branch}","tags_url":"https://api.github.com/repos/dnishimura/samza/tags","blobs_url":"https://api.github.com/repos/dnishimura/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnishimura/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnishimura/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnishimura/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnishimura/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/dnishimura/samza/languages","stargazers_url":"https://api.github.com/repos/dnishimura/samza/stargazers","contributors_url":"https://api.github.com/repos/dnishimura/samza/contributors","subscribers_url":"https://api.github.com/repos/dnishimura/samza/subscribers","subscription_url":"https://api.github.com/repos/dnishimura/samza/subscription","commits_url":"https://api.github.com/repos/dnishimura/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnishimura/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnishimura/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnishimura/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnishimura/samza/contents/{+path}","compare_url":"https://api.github.com/repos/dnishimura/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnishimura/samza/merges","archive_url":"https://api.github.com/repos/dnishimura/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnishimura/samza/downloads","issues_url":"https://api.github.com/repos/dnishimura/samza/issues{/number}","pulls_url":"https://api.github.com/repos/dnishimura/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/dnishimura/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/dnishimura/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnishimura/samza/labels{/name}","releases_url":"https://api.github.com/repos/dnishimura/samza/releases{/id}","deployments_url":"https://api.github.com/repos/dnishimura/samza/deployments","created_at":"2017-08-31T22:09:13Z","updated_at":"2017-08-31T22:09:17Z","pushed_at":"2017-09-28T21:23:00Z","git_url":"git://github.com/dnishimura/samza.git","ssh_url":"git@github.com:dnishimura/samza.git","clone_url":"https://github.com/dnishimura/samza.git","svn_url":"https://github.com/dnishimura/samza","homepage":null,"size":17431,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f16ba2692ef85a624ce5f9050ddb6b9bce3dbf6c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32199982,"name":"samza","full_name":"apache/samza","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/samza","description":"Mirror of Apache Samza","fork":false,"url":"https://api.github.com/repos/apache/samza","forks_url":"https://api.github.com/repos/apache/samza/forks","keys_url":"https://api.github.com/repos/apache/samza/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/samza/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/samza/teams","hooks_url":"https://api.github.com/repos/apache/samza/hooks","issue_events_url":"https://api.github.com/repos/apache/samza/issues/events{/number}","events_url":"https://api.github.com/repos/apache/samza/events","assignees_url":"https://api.github.com/repos/apache/samza/assignees{/user}","branches_url":"https://api.github.com/repos/apache/samza/branches{/branch}","tags_url":"https://api.github.com/repos/apache/samza/tags","blobs_url":"https://api.github.com/repos/apache/samza/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/samza/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/samza/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/samza/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/samza/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/samza/languages","stargazers_url":"https://api.github.com/repos/apache/samza/stargazers","contributors_url":"https://api.github.com/repos/apache/samza/contributors","subscribers_url":"https://api.github.com/repos/apache/samza/subscribers","subscription_url":"https://api.github.com/repos/apache/samza/subscription","commits_url":"https://api.github.com/repos/apache/samza/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/samza/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/samza/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/samza/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/samza/contents/{+path}","compare_url":"https://api.github.com/repos/apache/samza/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/samza/merges","archive_url":"https://api.github.com/repos/apache/samza/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/samza/downloads","issues_url":"https://api.github.com/repos/apache/samza/issues{/number}","pulls_url":"https://api.github.com/repos/apache/samza/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/samza/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/samza/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/samza/labels{/name}","releases_url":"https://api.github.com/repos/apache/samza/releases{/id}","deployments_url":"https://api.github.com/repos/apache/samza/deployments","created_at":"2015-03-14T07:00:05Z","updated_at":"2017-10-02T04:04:41Z","pushed_at":"2017-09-29T22:43:13Z","git_url":"git://github.com/apache/samza.git","ssh_url":"git@github.com:apache/samza.git","clone_url":"https://github.com/apache/samza.git","svn_url":"https://github.com/apache/samza","homepage":null,"size":17563,"stargazers_count":363,"watchers_count":363,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":"git://git.apache.org/samza.git","open_issues_count":31,"forks":166,"open_issues":31,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/samza/pulls/306"},"html":{"href":"https://github.com/apache/samza/pull/306"},"issue":{"href":"https://api.github.com/repos/apache/samza/issues/306"},"comments":{"href":"https://api.github.com/repos/apache/samza/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/samza/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/samza/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/samza/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/apache/samza/statuses/e84685ab65548b120478d92e55167a562432bf14"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nickpan47"}}