{"action":"created","comment":{"url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/comments/99446098","pull_request_review_id":20128760,"id":99446098,"diff_hunk":"@@ -91,24 +89,27 @@ public TaskReport run(TaskSource taskSource, Schema schema, int taskIndex, PageO\n         T task = taskSource.loadTask(this.taskClass);\n         ServiceResponseMapper serviceResponseMapper =\n             this.serviceResponseMapperBuilder.buildServiceResponseMapper(task);\n+\n+        TaskReport taskReport = null;\n         try (PageBuilder pageBuilder = new PageBuilder(Exec.getBufferAllocator(), schema, output)) {\n             try (AutoCloseableClient<T> clientWrapper = new AutoCloseableClient<T>(task, this.clientCreator)) {\n                 RetryHelper retryHelper = new RetryHelper(\n                     clientWrapper.getClient(),\n                     task.getRetryLimit(),\n                     task.getInitialRetryWait(),\n                     task.getMaxRetryWait());\n-                this.serviceDataIngester.ingestServiceData(task,\n-                                         retryHelper,\n-                                         serviceResponseMapper.createRecordImporter(),\n-                                         taskIndex,\n-                                         pageBuilder);\n+                taskReport = this.serviceDataIngester.ingestServiceData(","path":"src/main/java/org/embulk/base/restclient/RestClientInputPluginBaseUnsafe.java","position":42,"original_position":42,"commit_id":"1fc4fb2ea06cc0675e5a57acfe1ee6798fc15616","original_commit_id":"1fc4fb2ea06cc0675e5a57acfe1ee6798fc15616","user":{"login":"dmikurube","id":723722,"avatar_url":"https://avatars.githubusercontent.com/u/723722?v=3","gravatar_id":"","url":"https://api.github.com/users/dmikurube","html_url":"https://github.com/dmikurube","followers_url":"https://api.github.com/users/dmikurube/followers","following_url":"https://api.github.com/users/dmikurube/following{/other_user}","gists_url":"https://api.github.com/users/dmikurube/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikurube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikurube/subscriptions","organizations_url":"https://api.github.com/users/dmikurube/orgs","repos_url":"https://api.github.com/users/dmikurube/repos","events_url":"https://api.github.com/users/dmikurube/events{/privacy}","received_events_url":"https://api.github.com/users/dmikurube/received_events","type":"User","site_admin":false},"body":"Ahh, exactly we just `return` here. We have `finally` there...","created_at":"2017-02-03T23:55:01Z","updated_at":"2017-02-03T23:55:01Z","html_url":"https://github.com/dmikurube/embulk-base-restclient/pull/37#discussion_r99446098","pull_request_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/comments/99446098"},"html":{"href":"https://github.com/dmikurube/embulk-base-restclient/pull/37#discussion_r99446098"},"pull_request":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/37"}}},"pull_request":{"url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/37","id":104616749,"html_url":"https://github.com/dmikurube/embulk-base-restclient/pull/37","diff_url":"https://github.com/dmikurube/embulk-base-restclient/pull/37.diff","patch_url":"https://github.com/dmikurube/embulk-base-restclient/pull/37.patch","issue_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues/37","number":37,"state":"open","locked":false,"title":"Remove |TaskReportBuildable|, and return |TaskReport| from |ingestServiceData|.","user":{"login":"dmikurube","id":723722,"avatar_url":"https://avatars.githubusercontent.com/u/723722?v=3","gravatar_id":"","url":"https://api.github.com/users/dmikurube","html_url":"https://github.com/dmikurube","followers_url":"https://api.github.com/users/dmikurube/followers","following_url":"https://api.github.com/users/dmikurube/following{/other_user}","gists_url":"https://api.github.com/users/dmikurube/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikurube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikurube/subscriptions","organizations_url":"https://api.github.com/users/dmikurube/orgs","repos_url":"https://api.github.com/users/dmikurube/repos","events_url":"https://api.github.com/users/dmikurube/events{/privacy}","received_events_url":"https://api.github.com/users/dmikurube/received_events","type":"User","site_admin":false},"body":"@muga Sorry, found that `TaskReportBuildable` was useless just from `Task`. Changed `ingestServiceData` to return `TaskReport` by itself, and removed `TaskReportBuildable`.","created_at":"2017-02-03T21:39:44Z","updated_at":"2017-02-03T23:55:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5a0cc7f7f9e69af51ddda135059f7ae1312a2d2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/37/commits","review_comments_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/37/comments","review_comment_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues/37/comments","statuses_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/statuses/1fc4fb2ea06cc0675e5a57acfe1ee6798fc15616","head":{"label":"dmikurube:remove-TaskReportBuildable","ref":"remove-TaskReportBuildable","sha":"1fc4fb2ea06cc0675e5a57acfe1ee6798fc15616","user":{"login":"dmikurube","id":723722,"avatar_url":"https://avatars.githubusercontent.com/u/723722?v=3","gravatar_id":"","url":"https://api.github.com/users/dmikurube","html_url":"https://github.com/dmikurube","followers_url":"https://api.github.com/users/dmikurube/followers","following_url":"https://api.github.com/users/dmikurube/following{/other_user}","gists_url":"https://api.github.com/users/dmikurube/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikurube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikurube/subscriptions","organizations_url":"https://api.github.com/users/dmikurube/orgs","repos_url":"https://api.github.com/users/dmikurube/repos","events_url":"https://api.github.com/users/dmikurube/events{/privacy}","received_events_url":"https://api.github.com/users/dmikurube/received_events","type":"User","site_admin":false},"repo":{"id":77013049,"name":"embulk-base-restclient","full_name":"dmikurube/embulk-base-restclient","owner":{"login":"dmikurube","id":723722,"avatar_url":"https://avatars.githubusercontent.com/u/723722?v=3","gravatar_id":"","url":"https://api.github.com/users/dmikurube","html_url":"https://github.com/dmikurube","followers_url":"https://api.github.com/users/dmikurube/followers","following_url":"https://api.github.com/users/dmikurube/following{/other_user}","gists_url":"https://api.github.com/users/dmikurube/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikurube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikurube/subscriptions","organizations_url":"https://api.github.com/users/dmikurube/orgs","repos_url":"https://api.github.com/users/dmikurube/repos","events_url":"https://api.github.com/users/dmikurube/events{/privacy}","received_events_url":"https://api.github.com/users/dmikurube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmikurube/embulk-base-restclient","description":"Base class library for Embulk plugins to access RESTful services","fork":true,"url":"https://api.github.com/repos/dmikurube/embulk-base-restclient","forks_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/forks","keys_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/teams","hooks_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/hooks","issue_events_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues/events{/number}","events_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/events","assignees_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/assignees{/user}","branches_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/branches{/branch}","tags_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/tags","blobs_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/statuses/{sha}","languages_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/languages","stargazers_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/stargazers","contributors_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/contributors","subscribers_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/subscribers","subscription_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/subscription","commits_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/contents/{+path}","compare_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/merges","archive_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/downloads","issues_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues{/number}","pulls_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls{/number}","milestones_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/milestones{/number}","notifications_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/labels{/name}","releases_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/releases{/id}","deployments_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/deployments","created_at":"2016-12-21T03:37:32Z","updated_at":"2017-02-03T22:09:00Z","pushed_at":"2017-02-03T21:55:49Z","git_url":"git://github.com/dmikurube/embulk-base-restclient.git","ssh_url":"git@github.com:dmikurube/embulk-base-restclient.git","clone_url":"https://github.com/dmikurube/embulk-base-restclient.git","svn_url":"https://github.com/dmikurube/embulk-base-restclient","homepage":"","size":186,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"dmikurube:master","ref":"master","sha":"37e210386364230c32d41c42b4df28ae0022de50","user":{"login":"dmikurube","id":723722,"avatar_url":"https://avatars.githubusercontent.com/u/723722?v=3","gravatar_id":"","url":"https://api.github.com/users/dmikurube","html_url":"https://github.com/dmikurube","followers_url":"https://api.github.com/users/dmikurube/followers","following_url":"https://api.github.com/users/dmikurube/following{/other_user}","gists_url":"https://api.github.com/users/dmikurube/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikurube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikurube/subscriptions","organizations_url":"https://api.github.com/users/dmikurube/orgs","repos_url":"https://api.github.com/users/dmikurube/repos","events_url":"https://api.github.com/users/dmikurube/events{/privacy}","received_events_url":"https://api.github.com/users/dmikurube/received_events","type":"User","site_admin":false},"repo":{"id":77013049,"name":"embulk-base-restclient","full_name":"dmikurube/embulk-base-restclient","owner":{"login":"dmikurube","id":723722,"avatar_url":"https://avatars.githubusercontent.com/u/723722?v=3","gravatar_id":"","url":"https://api.github.com/users/dmikurube","html_url":"https://github.com/dmikurube","followers_url":"https://api.github.com/users/dmikurube/followers","following_url":"https://api.github.com/users/dmikurube/following{/other_user}","gists_url":"https://api.github.com/users/dmikurube/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikurube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikurube/subscriptions","organizations_url":"https://api.github.com/users/dmikurube/orgs","repos_url":"https://api.github.com/users/dmikurube/repos","events_url":"https://api.github.com/users/dmikurube/events{/privacy}","received_events_url":"https://api.github.com/users/dmikurube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmikurube/embulk-base-restclient","description":"Base class library for Embulk plugins to access RESTful services","fork":true,"url":"https://api.github.com/repos/dmikurube/embulk-base-restclient","forks_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/forks","keys_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/teams","hooks_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/hooks","issue_events_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues/events{/number}","events_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/events","assignees_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/assignees{/user}","branches_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/branches{/branch}","tags_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/tags","blobs_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/statuses/{sha}","languages_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/languages","stargazers_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/stargazers","contributors_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/contributors","subscribers_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/subscribers","subscription_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/subscription","commits_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/contents/{+path}","compare_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/merges","archive_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/downloads","issues_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues{/number}","pulls_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls{/number}","milestones_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/milestones{/number}","notifications_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/labels{/name}","releases_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/releases{/id}","deployments_url":"https://api.github.com/repos/dmikurube/embulk-base-restclient/deployments","created_at":"2016-12-21T03:37:32Z","updated_at":"2017-02-03T22:09:00Z","pushed_at":"2017-02-03T21:55:49Z","git_url":"git://github.com/dmikurube/embulk-base-restclient.git","ssh_url":"git@github.com:dmikurube/embulk-base-restclient.git","clone_url":"https://github.com/dmikurube/embulk-base-restclient.git","svn_url":"https://github.com/dmikurube/embulk-base-restclient","homepage":"","size":186,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/37"},"html":{"href":"https://github.com/dmikurube/embulk-base-restclient/pull/37"},"issue":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues/37"},"comments":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/dmikurube/embulk-base-restclient/statuses/1fc4fb2ea06cc0675e5a57acfe1ee6798fc15616"}}}}
{"actor":{"display_login":"dmikurube"}}