{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/115052558","pull_request_review_id":36569318,"id":115052558,"diff_hunk":"@@ -892,6 +894,114 @@ func TestDeleteWithNamespace(t *testing.T) {\n \t}\n }\n \n+func TestWatch(t *testing.T) {","path":"pkg/storage/tpr/storage_interface_test.go","position":20,"original_position":20,"commit_id":"cfff27ae8731cb99c84e1ae4b7c0571149497330","original_commit_id":"cfff27ae8731cb99c84e1ae4b7c0571149497330","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars1.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"body":"I learned the hard way that each test case should be repeated 1. for a resource type that is _not_ namespaced 2. for a resource type that _is_. Things will slip through the cracks if we don't explicitly test both of those scenarios.","created_at":"2017-05-05T17:48:54Z","updated_at":"2017-05-05T17:48:54Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/782#discussion_r115052558","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/782","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/115052558"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/782#discussion_r115052558"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/782"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/782","id":118426903,"html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/782","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/782.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/782.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/782","number":782,"state":"open","locked":false,"title":"Adding unit tests for TPR based watch & watch-list","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars2.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/kubernetes-incubator/service-catalog/issues/774","created_at":"2017-05-01T19:38:22Z","updated_at":"2017-05-05T17:48:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a18b81b6b3babc7044464dd6f51bd96106619262","assignee":{"login":"arschles","id":70865,"avatar_url":"https://avatars2.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"assignees":[{"login":"arschles","id":70865,"avatar_url":"https://avatars2.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones/12","html_url":"https://github.com/kubernetes-incubator/service-catalog/milestone/12","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones/12/labels","id":2486956,"number":12,"title":"0.0.6","description":"This is an alpha release milestone. Please see the roadmap for a description of what's in it: https://github.com/kubernetes-incubator/service-catalog/wiki/Roadmap\r\n","creator":{"login":"arschles","id":70865,"avatar_url":"https://avatars2.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":11,"state":"open","created_at":"2017-04-27T20:35:26Z","updated_at":"2017-05-05T17:07:20Z","due_on":"2017-05-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/782/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/782/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/782/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/cfff27ae8731cb99c84e1ae4b7c0571149497330","head":{"label":"arschles:tpr-watch-unit","ref":"tpr-watch-unit","sha":"cfff27ae8731cb99c84e1ae4b7c0571149497330","user":{"login":"arschles","id":70865,"avatar_url":"https://avatars2.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"repo":{"id":70734213,"name":"kubernetes-incubator-service-catalog","full_name":"arschles/kubernetes-incubator-service-catalog","owner":{"login":"arschles","id":70865,"avatar_url":"https://avatars2.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arschles/kubernetes-incubator-service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":true,"url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog","forks_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/forks","keys_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/teams","hooks_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/hooks","issue_events_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/events","assignees_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/tags","blobs_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/languages","stargazers_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/stargazers","contributors_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/contributors","subscribers_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/subscribers","subscription_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/subscription","commits_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/merges","archive_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/downloads","issues_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/arschles/kubernetes-incubator-service-catalog/deployments","created_at":"2016-10-12T19:28:49Z","updated_at":"2016-10-12T19:29:01Z","pushed_at":"2017-05-04T22:20:26Z","git_url":"git://github.com/arschles/kubernetes-incubator-service-catalog.git","ssh_url":"git@github.com:arschles/kubernetes-incubator-service-catalog.git","clone_url":"https://github.com/arschles/kubernetes-incubator-service-catalog.git","svn_url":"https://github.com/arschles/kubernetes-incubator-service-catalog","homepage":"","size":67750,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"b71cdb1e733075b6527db7f2b0ea5409f57222ef","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2017-05-05T12:28:32Z","pushed_at":"2017-05-05T05:05:55Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":67588,"stargazers_count":125,"watchers_count":125,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":104,"forks":59,"open_issues":104,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/782"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/782"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/782"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/782/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/782/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/782/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/cfff27ae8731cb99c84e1ae4b7c0571149497330"}}}}
{"actor":{"display_login":"krancour"}}