{"action":"created","comment":{"url":"https://api.github.com/repos/interledger/rfcs/pulls/comments/108437522","pull_request_review_id":29467282,"id":108437522,"diff_hunk":"@@ -605,25 +603,17 @@ The ledger plugin's ILP address prefix. This is used to determine whether a give\n \n The prefix may be configured, automatically detected, or hard-coded, depending on the ledger. For example, a Bitcoin ledger plugin may have the address hard-coded, while a [`five-bells-ledger`](https://github.com/interledger/five-bells-ledger) would use an API call to get the prefix.\n \n-#### precision\n-<code>**precision**:Number</code>\n-\n-The total number of digits (base 10) of precision allowed by the ledger.\n-\n-#### scale\n-<code>**scale**:Number</code>\n-\n-The number of digits allowed after the decimal point.\n-\n #### currencyCode\n <code>**currencyCode**:String</code>\n \n-The ISO 4217 currency code (if any) used by the ledger.\n+The ISO 4217 currency code (if any) used by the ledger. A custom all-caps three-letter code, not used by ISO 4217, otherwise. Ledger administrators who choose a custom currency code MAY request their chosen currency code be listed by software modules that map currency codes to currency symbols, for instance on node package manager (npm) in the case of JavaScript. The currencyCode is only meaningful in combination with the currencyScale (below).","path":"0004-ledger-plugin-interface/0004-ledger-plugin-interface.md","position":63,"original_position":63,"commit_id":"e487467373e7e1d327e5d6dbdc8d0528a9aeb72d","original_commit_id":"e487467373e7e1d327e5d6dbdc8d0528a9aeb72d","user":{"login":"sharafian","id":3362563,"avatar_url":"https://avatars3.githubusercontent.com/u/3362563?v=3","gravatar_id":"","url":"https://api.github.com/users/sharafian","html_url":"https://github.com/sharafian","followers_url":"https://api.github.com/users/sharafian/followers","following_url":"https://api.github.com/users/sharafian/following{/other_user}","gists_url":"https://api.github.com/users/sharafian/gists{/gist_id}","starred_url":"https://api.github.com/users/sharafian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharafian/subscriptions","organizations_url":"https://api.github.com/users/sharafian/orgs","repos_url":"https://api.github.com/users/sharafian/repos","events_url":"https://api.github.com/users/sharafian/events{/privacy}","received_events_url":"https://api.github.com/users/sharafian/received_events","type":"User","site_admin":false},"body":"Should have a link for ISO 4217","created_at":"2017-03-28T14:31:21Z","updated_at":"2017-03-28T14:34:25Z","html_url":"https://github.com/interledger/rfcs/pull/177#discussion_r108437522","pull_request_url":"https://api.github.com/repos/interledger/rfcs/pulls/177","_links":{"self":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/comments/108437522"},"html":{"href":"https://github.com/interledger/rfcs/pull/177#discussion_r108437522"},"pull_request":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/interledger/rfcs/pulls/177","id":112708821,"html_url":"https://github.com/interledger/rfcs/pull/177","diff_url":"https://github.com/interledger/rfcs/pull/177.diff","patch_url":"https://github.com/interledger/rfcs/pull/177.patch","issue_url":"https://api.github.com/repos/interledger/rfcs/issues/177","number":177,"state":"open","locked":false,"title":"docs(0004,0009): Rename scale to currencyScale, deprecate currencySymbol","user":{"login":"michielbdejong","id":408412,"avatar_url":"https://avatars1.githubusercontent.com/u/408412?v=3","gravatar_id":"","url":"https://api.github.com/users/michielbdejong","html_url":"https://github.com/michielbdejong","followers_url":"https://api.github.com/users/michielbdejong/followers","following_url":"https://api.github.com/users/michielbdejong/following{/other_user}","gists_url":"https://api.github.com/users/michielbdejong/gists{/gist_id}","starred_url":"https://api.github.com/users/michielbdejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michielbdejong/subscriptions","organizations_url":"https://api.github.com/users/michielbdejong/orgs","repos_url":"https://api.github.com/users/michielbdejong/repos","events_url":"https://api.github.com/users/michielbdejong/events{/privacy}","received_events_url":"https://api.github.com/users/michielbdejong/received_events","type":"User","site_admin":false},"body":"Since we switched to integers on transfers and ledger balances, `scale` is always zero, so that's useless in ledgerInfo. However, `currencyScale` is needed now. At the same time, deprecated `currencySymbol` since symbols, like colors, and human languages are a UI thing and not a concern of the ledger plugin. IMHO, the plugin interface should only deal with machine-readable data, not with human-computer interface.","created_at":"2017-03-27T10:03:28Z","updated_at":"2017-03-28T14:34:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31ea533e5aad74be880925a2c3c4b3903aa667d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/interledger/rfcs/pulls/177/commits","review_comments_url":"https://api.github.com/repos/interledger/rfcs/pulls/177/comments","review_comment_url":"https://api.github.com/repos/interledger/rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledger/rfcs/issues/177/comments","statuses_url":"https://api.github.com/repos/interledger/rfcs/statuses/e487467373e7e1d327e5d6dbdc8d0528a9aeb72d","head":{"label":"interledger:mj-currency_scale","ref":"mj-currency_scale","sha":"e487467373e7e1d327e5d6dbdc8d0528a9aeb72d","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars3.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":41705345,"name":"rfcs","full_name":"interledger/rfcs","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars3.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/rfcs","description":"A set of draft specifications for enabling interledger payments","fork":false,"url":"https://api.github.com/repos/interledger/rfcs","forks_url":"https://api.github.com/repos/interledger/rfcs/forks","keys_url":"https://api.github.com/repos/interledger/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/rfcs/teams","hooks_url":"https://api.github.com/repos/interledger/rfcs/hooks","issue_events_url":"https://api.github.com/repos/interledger/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/rfcs/events","assignees_url":"https://api.github.com/repos/interledger/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/rfcs/tags","blobs_url":"https://api.github.com/repos/interledger/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/rfcs/languages","stargazers_url":"https://api.github.com/repos/interledger/rfcs/stargazers","contributors_url":"https://api.github.com/repos/interledger/rfcs/contributors","subscribers_url":"https://api.github.com/repos/interledger/rfcs/subscribers","subscription_url":"https://api.github.com/repos/interledger/rfcs/subscription","commits_url":"https://api.github.com/repos/interledger/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/rfcs/merges","archive_url":"https://api.github.com/repos/interledger/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/rfcs/downloads","issues_url":"https://api.github.com/repos/interledger/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/interledger/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/rfcs/deployments","created_at":"2015-08-31T23:17:16Z","updated_at":"2017-03-27T01:56:19Z","pushed_at":"2017-03-28T14:04:14Z","git_url":"git://github.com/interledger/rfcs.git","ssh_url":"git@github.com:interledger/rfcs.git","clone_url":"https://github.com/interledger/rfcs.git","svn_url":"https://github.com/interledger/rfcs","homepage":null,"size":1009,"stargazers_count":40,"watchers_count":40,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":26,"forks":16,"open_issues":26,"watchers":40,"default_branch":"master"}},"base":{"label":"interledger:master","ref":"master","sha":"17ddc42865b13718a84e2fed85a5f931b64c2c9c","user":{"login":"interledger","id":14062960,"avatar_url":"https://avatars3.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"repo":{"id":41705345,"name":"rfcs","full_name":"interledger/rfcs","owner":{"login":"interledger","id":14062960,"avatar_url":"https://avatars3.githubusercontent.com/u/14062960?v=3","gravatar_id":"","url":"https://api.github.com/users/interledger","html_url":"https://github.com/interledger","followers_url":"https://api.github.com/users/interledger/followers","following_url":"https://api.github.com/users/interledger/following{/other_user}","gists_url":"https://api.github.com/users/interledger/gists{/gist_id}","starred_url":"https://api.github.com/users/interledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledger/subscriptions","organizations_url":"https://api.github.com/users/interledger/orgs","repos_url":"https://api.github.com/users/interledger/repos","events_url":"https://api.github.com/users/interledger/events{/privacy}","received_events_url":"https://api.github.com/users/interledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledger/rfcs","description":"A set of draft specifications for enabling interledger payments","fork":false,"url":"https://api.github.com/repos/interledger/rfcs","forks_url":"https://api.github.com/repos/interledger/rfcs/forks","keys_url":"https://api.github.com/repos/interledger/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledger/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledger/rfcs/teams","hooks_url":"https://api.github.com/repos/interledger/rfcs/hooks","issue_events_url":"https://api.github.com/repos/interledger/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/interledger/rfcs/events","assignees_url":"https://api.github.com/repos/interledger/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/interledger/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/interledger/rfcs/tags","blobs_url":"https://api.github.com/repos/interledger/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledger/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledger/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledger/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledger/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/interledger/rfcs/languages","stargazers_url":"https://api.github.com/repos/interledger/rfcs/stargazers","contributors_url":"https://api.github.com/repos/interledger/rfcs/contributors","subscribers_url":"https://api.github.com/repos/interledger/rfcs/subscribers","subscription_url":"https://api.github.com/repos/interledger/rfcs/subscription","commits_url":"https://api.github.com/repos/interledger/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledger/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledger/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledger/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledger/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/interledger/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledger/rfcs/merges","archive_url":"https://api.github.com/repos/interledger/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledger/rfcs/downloads","issues_url":"https://api.github.com/repos/interledger/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/interledger/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/interledger/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/interledger/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledger/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/interledger/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/interledger/rfcs/deployments","created_at":"2015-08-31T23:17:16Z","updated_at":"2017-03-27T01:56:19Z","pushed_at":"2017-03-28T14:04:14Z","git_url":"git://github.com/interledger/rfcs.git","ssh_url":"git@github.com:interledger/rfcs.git","clone_url":"https://github.com/interledger/rfcs.git","svn_url":"https://github.com/interledger/rfcs","homepage":null,"size":1009,"stargazers_count":40,"watchers_count":40,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":26,"forks":16,"open_issues":26,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/177"},"html":{"href":"https://github.com/interledger/rfcs/pull/177"},"issue":{"href":"https://api.github.com/repos/interledger/rfcs/issues/177"},"comments":{"href":"https://api.github.com/repos/interledger/rfcs/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledger/rfcs/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/interledger/rfcs/statuses/e487467373e7e1d327e5d6dbdc8d0528a9aeb72d"}}}}
{"actor":{"display_login":"sharafian"}}