{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/98879759","pull_request_review_id":19534758,"id":98879759,"diff_hunk":"@@ -187,7 +187,7 @@ func initStartFlags() {\n \tstartFlagSet.Int(cpus, constants.DefaultCPUS, \"Number of CPU cores to allocate to the Minishift VM.\")\n \tstartFlagSet.String(humanReadableDiskSize, constants.DefaultDiskSize, \"Disk size to allocate to the Minishift VM. Use the format <size><unit>, where unit = b, k, m or g.\")\n \tstartFlagSet.String(hostOnlyCIDR, \"192.168.99.1/24\", \"The CIDR to be used for the minishift VM. (Only supported with VirtualBox driver.)\")\n-\tstartFlagSet.StringSliceVar(&dockerEnv, \"docker-env\", nil, \"Environment variables to pass to the Docker daemon. Use the format <key>=<value>.\")\n+\tstartFlagSet.StringArrayVar(&dockerEnv, \"docker-env\", nil, \"Environment variables to pass to the Docker daemon. Use the format <key>=<value>.\")","path":"cmd/minikube/cmd/start.go","position":5,"original_position":5,"commit_id":"9be5ea50104a64d592f52f14c008c8c6dc2068db","original_commit_id":"9be5ea50104a64d592f52f14c008c8c6dc2068db","user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2017-02-01T12:03:08Z","updated_at":"2017-02-01T12:49:28Z","html_url":"https://github.com/minishift/minishift/pull/350#discussion_r98879759","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/350","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/98879759"},"html":{"href":"https://github.com/minishift/minishift/pull/350#discussion_r98879759"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/350","id":103896036,"html_url":"https://github.com/minishift/minishift/pull/350","diff_url":"https://github.com/minishift/minishift/pull/350.diff","patch_url":"https://github.com/minishift/minishift/pull/350.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/350","number":350,"state":"open","locked":false,"title":"Fix #345 docker-env doesn't behave as expected when ',' in the string","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars.githubusercontent.com/u/410007?v=3","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"body":"This patch will fix docker-env issue and it does require latest version of pflag which comes from viper plugin and since https://github.com/spf13/viper/pull/205 is already merged which was holding us to use fork of this project.\r\n\r\n```\r\n./minikube start --docker-env HTTP_PROXY=http://fedora:fedora123@10.70.49.109:3128 --docker-env NO_PROXY=\"*xip.io,localhost,172.11.2.1\" --iso-url=file:/Users/prkumar/minishift-centos7.iso --show-libmachine-logs --cpus 4 --memory 4096\r\nStarting local OpenShift cluster using 'virtualbox' hypervisor...\r\nDocker Config Options [HTTP_PROXY=http://fedora:fedora123@10.70.49.109:3128 NO_PROXY=*xip.io,localhost,172.11.2.1]\r\n```","created_at":"2017-01-31T09:16:27Z","updated_at":"2017-02-01T12:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2507b2d3f1a226aa827e560676807db826617a7","assignee":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"assignees":[{"login":"hferentschik","id":296354,"avatar_url":"https://avatars.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/350/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/350/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/350/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/9be5ea50104a64d592f52f14c008c8c6dc2068db","head":{"label":"praveenkumar:issue_345","ref":"issue_345","sha":"9be5ea50104a64d592f52f14c008c8c6dc2068db","user":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars.githubusercontent.com/u/410007?v=3","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"repo":{"id":74443040,"name":"minishift","full_name":"praveenkumar/minishift","owner":{"login":"praveenkumar","id":410007,"avatar_url":"https://avatars.githubusercontent.com/u/410007?v=3","gravatar_id":"","url":"https://api.github.com/users/praveenkumar","html_url":"https://github.com/praveenkumar","followers_url":"https://api.github.com/users/praveenkumar/followers","following_url":"https://api.github.com/users/praveenkumar/following{/other_user}","gists_url":"https://api.github.com/users/praveenkumar/gists{/gist_id}","starred_url":"https://api.github.com/users/praveenkumar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveenkumar/subscriptions","organizations_url":"https://api.github.com/users/praveenkumar/orgs","repos_url":"https://api.github.com/users/praveenkumar/repos","events_url":"https://api.github.com/users/praveenkumar/events{/privacy}","received_events_url":"https://api.github.com/users/praveenkumar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/praveenkumar/minishift","description":null,"fork":true,"url":"https://api.github.com/repos/praveenkumar/minishift","forks_url":"https://api.github.com/repos/praveenkumar/minishift/forks","keys_url":"https://api.github.com/repos/praveenkumar/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praveenkumar/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praveenkumar/minishift/teams","hooks_url":"https://api.github.com/repos/praveenkumar/minishift/hooks","issue_events_url":"https://api.github.com/repos/praveenkumar/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/praveenkumar/minishift/events","assignees_url":"https://api.github.com/repos/praveenkumar/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/praveenkumar/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/praveenkumar/minishift/tags","blobs_url":"https://api.github.com/repos/praveenkumar/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praveenkumar/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praveenkumar/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/praveenkumar/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praveenkumar/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/praveenkumar/minishift/languages","stargazers_url":"https://api.github.com/repos/praveenkumar/minishift/stargazers","contributors_url":"https://api.github.com/repos/praveenkumar/minishift/contributors","subscribers_url":"https://api.github.com/repos/praveenkumar/minishift/subscribers","subscription_url":"https://api.github.com/repos/praveenkumar/minishift/subscription","commits_url":"https://api.github.com/repos/praveenkumar/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/praveenkumar/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/praveenkumar/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/praveenkumar/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/praveenkumar/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/praveenkumar/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praveenkumar/minishift/merges","archive_url":"https://api.github.com/repos/praveenkumar/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praveenkumar/minishift/downloads","issues_url":"https://api.github.com/repos/praveenkumar/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/praveenkumar/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/praveenkumar/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/praveenkumar/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praveenkumar/minishift/labels{/name}","releases_url":"https://api.github.com/repos/praveenkumar/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/praveenkumar/minishift/deployments","created_at":"2016-11-22T06:46:12Z","updated_at":"2016-11-22T06:46:15Z","pushed_at":"2017-02-01T08:42:23Z","git_url":"git://github.com/praveenkumar/minishift.git","ssh_url":"git@github.com:praveenkumar/minishift.git","clone_url":"https://github.com/praveenkumar/minishift.git","svn_url":"https://github.com/praveenkumar/minishift","homepage":null,"size":154924,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"2b6acc1d11e819d155555a5bf3b3aaa0ad618404","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-01-31T00:20:06Z","pushed_at":"2017-02-01T11:21:04Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":154893,"stargazers_count":132,"watchers_count":132,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":35,"mirror_url":null,"open_issues_count":80,"forks":35,"open_issues":80,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/350"},"html":{"href":"https://github.com/minishift/minishift/pull/350"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/350"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/9be5ea50104a64d592f52f14c008c8c6dc2068db"}}}}
{"actor":{"display_login":"hferentschik"}}