{"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/comments/131362436","pull_request_review_id":54334294,"id":131362436,"diff_hunk":"@@ -0,0 +1,68 @@\n+Feature:\n+  As an employee contributing greater than £40,000 per year to my pension\n+  In order to get a clear picture of the impact on my take-home pay.\n+  I want the results to reflect the fact that I will not get tax relief\n+  for any contribution over £40,000 per year.\n+\n+  Background:\n+    Given I am on the Your Details step\n+\n+    Scenario: Limit tax relief when above yearly figures\n+      Given I fill in my details:\n+        | age | gender | salary | salary_frequency | contribution |\n+        | 25  | male   | 80000  | per Year         | Full         |\n+      And I click the Next button\n+      And I fill in my contributions:\n+        | your_contribution | employer_contribution |\n+        | 60                | 1                     |\n+      When I move on to the results page\n+      Then I should see on the results page:\n+        | £48,000.00 | £48,000.00 | £48,000.00 |\n+        | £8,000.00  | £8,000.00  | £8,000.00  |\n+        | £800.00    | £1,600.00  | £2,400.00  |\n+        | £48,800.00 | £49,600.00 | £50,400.00 |\n+\n+    Scenario: Limit tax relief when above weekly figures\n+      Given I fill in my details:\n+        | age | gender | salary | salary_frequency | contribution |\n+        | 25  | female | 1200   | per Week         | Full         |\n+      And I click the Next button\n+      And I fill in my contributions:\n+        | your_contribution | employer_contribution |\n+        | 65                | 1                     |\n+      When I move on to the results page\n+      Then I should see on the results page:\n+        | £780.00 | £780.00 | £780.00 |\n+        | £153.85 | £153.85 | £153.85 |\n+        | £12.00  | £24.00  | £36.00  |\n+        | £792.00 | £804.00 | £816.00 |\n+\n+    Scenario: Limit tax relief when above monthly figures\n+      Given I fill in my details:\n+        | age | gender | salary | salary_frequency | contribution |\n+        | 23  | female | 4000   | per Month        | Full         |\n+      And I click the Next button\n+      And I fill in my contributions:\n+        | your_contribution | employer_contribution |\n+        | 90                | 1                     |\n+      When I move on to the results page\n+      Then I should see on the results page:\n+        | £3,600.00 | £3,600.00 | £3,600.00 |\n+        | £666.67   | £666.67   | £666.67   |\n+        | £40.00    | £80.00    | £120.00   |\n+        | £3,640.00 | £3,680.00 | £3,720.00  |\n+\n+    Scenario: Limit tax relief when above per 4 weeks figures\n+      Given I fill in my details:\n+        | age | gender | salary | salary_frequency | contribution |\n+        | 23  | female | 5000   | per 4 weeks      | Full         |\n+      And I click the Next button\n+      And I fill in my contributions:\n+        | your_contribution | employer_contribution |","path":"features/_your_results/limit_tax_relief.feature","position":61,"original_position":61,"commit_id":"94d1363d6f3065850ef0817d60a3509e5acd0d7c","original_commit_id":"94d1363d6f3065850ef0817d60a3509e5acd0d7c","user":{"login":"willhall88","id":7126705,"avatar_url":"https://avatars1.githubusercontent.com/u/7126705?v=4","gravatar_id":"","url":"https://api.github.com/users/willhall88","html_url":"https://github.com/willhall88","followers_url":"https://api.github.com/users/willhall88/followers","following_url":"https://api.github.com/users/willhall88/following{/other_user}","gists_url":"https://api.github.com/users/willhall88/gists{/gist_id}","starred_url":"https://api.github.com/users/willhall88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willhall88/subscriptions","organizations_url":"https://api.github.com/users/willhall88/orgs","repos_url":"https://api.github.com/users/willhall88/repos","events_url":"https://api.github.com/users/willhall88/events{/privacy}","received_events_url":"https://api.github.com/users/willhall88/received_events","type":"User","site_admin":false},"body":"Similarly. is the `your_contribution` that is changing across these scenarios vital to the tests? Does having `65` or `90` affect the outcome path? If not then I think it confuses the feature. ","created_at":"2017-08-04T10:47:21Z","updated_at":"2017-08-04T10:52:52Z","html_url":"https://github.com/moneyadviceservice/wpcc/pull/77#discussion_r131362436","pull_request_url":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/77","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/comments/131362436"},"html":{"href":"https://github.com/moneyadviceservice/wpcc/pull/77#discussion_r131362436"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/77","id":133695722,"html_url":"https://github.com/moneyadviceservice/wpcc/pull/77","diff_url":"https://github.com/moneyadviceservice/wpcc/pull/77.diff","patch_url":"https://github.com/moneyadviceservice/wpcc/pull/77.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/wpcc/issues/77","number":77,"state":"open","locked":false,"title":"8407 limit tax relief","user":{"login":"tomas-stefano","id":27509,"avatar_url":"https://avatars3.githubusercontent.com/u/27509?v=4","gravatar_id":"","url":"https://api.github.com/users/tomas-stefano","html_url":"https://github.com/tomas-stefano","followers_url":"https://api.github.com/users/tomas-stefano/followers","following_url":"https://api.github.com/users/tomas-stefano/following{/other_user}","gists_url":"https://api.github.com/users/tomas-stefano/gists{/gist_id}","starred_url":"https://api.github.com/users/tomas-stefano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomas-stefano/subscriptions","organizations_url":"https://api.github.com/users/tomas-stefano/orgs","repos_url":"https://api.github.com/users/tomas-stefano/repos","events_url":"https://api.github.com/users/tomas-stefano/events{/privacy}","received_events_url":"https://api.github.com/users/tomas-stefano/received_events","type":"User","site_admin":false},"body":"TP: https://moneyadviceservice.tpondemand.com/entity/8407\r\n\r\nThis PR adds the feature of where an employee contribution percentage amounts to an annual contribution greater than £40,000 the results page should limit annual tax relief to £8000 (20% of £40,000).\r\n\r\nThis PR also addresses other frequencies as well.","created_at":"2017-08-02T12:28:18Z","updated_at":"2017-08-04T10:52:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b35ad40a1e17aee84329ee86d190650883e7db98","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/77/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/77/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moneyadviceservice/wpcc/issues/77/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/wpcc/statuses/94d1363d6f3065850ef0817d60a3509e5acd0d7c","head":{"label":"moneyadviceservice:8407-limit-tax-relief","ref":"8407-limit-tax-relief","sha":"94d1363d6f3065850ef0817d60a3509e5acd0d7c","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":94420334,"name":"wpcc","full_name":"moneyadviceservice/wpcc","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/wpcc","description":"Workplace Pension Cost Calculator","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/wpcc","forks_url":"https://api.github.com/repos/moneyadviceservice/wpcc/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/wpcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/wpcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/wpcc/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/wpcc/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/wpcc/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/wpcc/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/wpcc/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/wpcc/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/wpcc/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/wpcc/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/wpcc/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/wpcc/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/wpcc/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/wpcc/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/wpcc/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/wpcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/wpcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/wpcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/wpcc/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/wpcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/wpcc/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/wpcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/wpcc/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/wpcc/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/wpcc/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/wpcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/wpcc/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/wpcc/releases{/id}","deployments_url":"https://api.github.com/repos/moneyadviceservice/wpcc/deployments","created_at":"2017-06-15T08:54:11Z","updated_at":"2017-06-23T14:48:47Z","pushed_at":"2017-08-04T10:47:34Z","git_url":"git://github.com/moneyadviceservice/wpcc.git","ssh_url":"git@github.com:moneyadviceservice/wpcc.git","clone_url":"https://github.com/moneyadviceservice/wpcc.git","svn_url":"https://github.com/moneyadviceservice/wpcc","homepage":null,"size":398,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"9f4f6fe428704e33ecadfb49a4fbd8125a167301","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":94420334,"name":"wpcc","full_name":"moneyadviceservice/wpcc","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars1.githubusercontent.com/u/2064781?v=4","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/wpcc","description":"Workplace Pension Cost Calculator","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/wpcc","forks_url":"https://api.github.com/repos/moneyadviceservice/wpcc/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/wpcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/wpcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/wpcc/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/wpcc/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/wpcc/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/wpcc/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/wpcc/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/wpcc/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/wpcc/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/wpcc/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/wpcc/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/wpcc/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/wpcc/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/wpcc/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/wpcc/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/wpcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/wpcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/wpcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/wpcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/wpcc/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/wpcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/wpcc/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/wpcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/wpcc/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/wpcc/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/wpcc/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/wpcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/wpcc/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/wpcc/releases{/id}","deployments_url":"https://api.github.com/repos/moneyadviceservice/wpcc/deployments","created_at":"2017-06-15T08:54:11Z","updated_at":"2017-06-23T14:48:47Z","pushed_at":"2017-08-04T10:47:34Z","git_url":"git://github.com/moneyadviceservice/wpcc.git","ssh_url":"git@github.com:moneyadviceservice/wpcc.git","clone_url":"https://github.com/moneyadviceservice/wpcc.git","svn_url":"https://github.com/moneyadviceservice/wpcc","homepage":null,"size":398,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/77"},"html":{"href":"https://github.com/moneyadviceservice/wpcc/pull/77"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/issues/77"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/wpcc/statuses/94d1363d6f3065850ef0817d60a3509e5acd0d7c"}}}}
{"actor":{"display_login":"willhall88"}}