{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/138276206","pull_request_review_id":62047455,"id":138276206,"diff_hunk":"@@ -4233,9 +4253,46 @@ int RootClingMain(int argc,\n \n    ROOT::TMetaUtils::SetPathsForRelocatability(clingArgs);\n \n+   // FIXME: This line is from TModuleGenerator, but we can't reuse this code\n+   // at this point because TModuleGenerator needs a CompilerInstance (and we\n+   // currently create the arguments for creating said CompilerInstance).\n+   bool isPCH = (dictpathname == \"allDict.cxx\");\n+   StringRef moduleName;\n+   // Adding -fmodules to the args will break lexing with __CINT__ defined,\n+   // and we actually do lex with __CINT__ and reuse this variable later,\n+   // we have to copy it now.\n+   auto clingArgsInterpreter = clingArgs;\n+   if (!isPCH && getenv(\"ROOT_MODULES\")) {\n+      // We just pass -fmodules, the CIFactory will do the rest and configure\n+      // clang correctly once it sees this flag.\n+      clingArgsInterpreter.push_back(\"-fmodules\");\n+\n+      // Specify the module name that we can lookup the module in the modulemap.\n+      std::string outputFile = llvm::sys::path::stem(sharedLibraryPathName).str();\n+      // Try to get the module name in the modulemap based on the filepath.\n+      moduleName = llvm::sys::path::filename(outputFile);\n+      moduleName.consume_front(\"lib\");\n+      moduleName.consume_back(\"_rdict.pcm\");\n+\n+      clingArgsInterpreter.push_back(\"-fmodule-name\");\n+      clingArgsInterpreter.push_back(moduleName.str());\n+\n+      // Set the C++ modules output directory to the directory where we generate\n+      // the shared library.\n+      clingArgsInterpreter.push_back(\"-fmodules-cache-path=\" +\n+                                     llvm::sys::path::parent_path(sharedLibraryPathName).str());\n+\n+      // If the user has passed ROOT_MODULES with the value 'DEBUG', then we\n+      // enable remarks in clang for building on-demand modules. This is useful\n+      // to figure out when and why on-demand modules are built by clang.\n+      if (llvm::StringRef(getenv(\"ROOT_MODULES\")) == \"DEBUG\") {","path":"core/dictgen/src/rootcling_impl.cxx","position":159,"original_position":159,"commit_id":"f4173eebd2c940cfa48ba9971ad01aeae249fe45","original_commit_id":"6302c0b75b5a7dc5371c83d56493e04653bda62e","user":{"login":"Teemperor","id":736001,"avatar_url":"https://avatars0.githubusercontent.com/u/736001?v=4","gravatar_id":"","url":"https://api.github.com/users/Teemperor","html_url":"https://github.com/Teemperor","followers_url":"https://api.github.com/users/Teemperor/followers","following_url":"https://api.github.com/users/Teemperor/following{/other_user}","gists_url":"https://api.github.com/users/Teemperor/gists{/gist_id}","starred_url":"https://api.github.com/users/Teemperor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teemperor/subscriptions","organizations_url":"https://api.github.com/users/Teemperor/orgs","repos_url":"https://api.github.com/users/Teemperor/repos","events_url":"https://api.github.com/users/Teemperor/events{/privacy}","received_events_url":"https://api.github.com/users/Teemperor/received_events","type":"User","site_admin":false},"body":"Yes, it's an artifact when I tried to move out ROOT-specific code from CIFactory to rootcling. FIxed!","created_at":"2017-09-12T07:58:01Z","updated_at":"2017-09-12T07:58:01Z","html_url":"https://github.com/root-project/root/pull/930#discussion_r138276206","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/930","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/138276206"},"html":{"href":"https://github.com/root-project/root/pull/930#discussion_r138276206"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/930"}},"in_reply_to_id":138016012},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/930","id":139100838,"html_url":"https://github.com/root-project/root/pull/930","diff_url":"https://github.com/root-project/root/pull/930.diff","patch_url":"https://github.com/root-project/root/pull/930.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/930","number":930,"state":"open","locked":false,"title":"[cxxmodules] Start generating modules in rootcling.","user":{"login":"Teemperor","id":736001,"avatar_url":"https://avatars0.githubusercontent.com/u/736001?v=4","gravatar_id":"","url":"https://api.github.com/users/Teemperor","html_url":"https://github.com/Teemperor","followers_url":"https://api.github.com/users/Teemperor/followers","following_url":"https://api.github.com/users/Teemperor/following{/other_user}","gists_url":"https://api.github.com/users/Teemperor/gists{/gist_id}","starred_url":"https://api.github.com/users/Teemperor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teemperor/subscriptions","organizations_url":"https://api.github.com/users/Teemperor/orgs","repos_url":"https://api.github.com/users/Teemperor/repos","events_url":"https://api.github.com/users/Teemperor/events{/privacy}","received_events_url":"https://api.github.com/users/Teemperor/received_events","type":"User","site_admin":false},"body":"See the specific commits for changes.","created_at":"2017-09-04T07:56:03Z","updated_at":"2017-09-12T07:58:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7406367dc8bc68e24482fa4a75bc78cd698fdf29","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pcanal","id":5175087,"avatar_url":"https://avatars3.githubusercontent.com/u/5175087?v=4","gravatar_id":"","url":"https://api.github.com/users/pcanal","html_url":"https://github.com/pcanal","followers_url":"https://api.github.com/users/pcanal/followers","following_url":"https://api.github.com/users/pcanal/following{/other_user}","gists_url":"https://api.github.com/users/pcanal/gists{/gist_id}","starred_url":"https://api.github.com/users/pcanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcanal/subscriptions","organizations_url":"https://api.github.com/users/pcanal/orgs","repos_url":"https://api.github.com/users/pcanal/repos","events_url":"https://api.github.com/users/pcanal/events{/privacy}","received_events_url":"https://api.github.com/users/pcanal/received_events","type":"User","site_admin":false},{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/930/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/930/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/930/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/f4173eebd2c940cfa48ba9971ad01aeae249fe45","head":{"label":"Teemperor:EnableModulesCIFactory","ref":"EnableModulesCIFactory","sha":"f4173eebd2c940cfa48ba9971ad01aeae249fe45","user":{"login":"Teemperor","id":736001,"avatar_url":"https://avatars0.githubusercontent.com/u/736001?v=4","gravatar_id":"","url":"https://api.github.com/users/Teemperor","html_url":"https://github.com/Teemperor","followers_url":"https://api.github.com/users/Teemperor/followers","following_url":"https://api.github.com/users/Teemperor/following{/other_user}","gists_url":"https://api.github.com/users/Teemperor/gists{/gist_id}","starred_url":"https://api.github.com/users/Teemperor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teemperor/subscriptions","organizations_url":"https://api.github.com/users/Teemperor/orgs","repos_url":"https://api.github.com/users/Teemperor/repos","events_url":"https://api.github.com/users/Teemperor/events{/privacy}","received_events_url":"https://api.github.com/users/Teemperor/received_events","type":"User","site_admin":false},"repo":{"id":80839440,"name":"root","full_name":"Teemperor/root","owner":{"login":"Teemperor","id":736001,"avatar_url":"https://avatars0.githubusercontent.com/u/736001?v=4","gravatar_id":"","url":"https://api.github.com/users/Teemperor","html_url":"https://github.com/Teemperor","followers_url":"https://api.github.com/users/Teemperor/followers","following_url":"https://api.github.com/users/Teemperor/following{/other_user}","gists_url":"https://api.github.com/users/Teemperor/gists{/gist_id}","starred_url":"https://api.github.com/users/Teemperor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teemperor/subscriptions","organizations_url":"https://api.github.com/users/Teemperor/orgs","repos_url":"https://api.github.com/users/Teemperor/repos","events_url":"https://api.github.com/users/Teemperor/events{/privacy}","received_events_url":"https://api.github.com/users/Teemperor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Teemperor/root","description":"Mirror of official ROOT git repository","fork":true,"url":"https://api.github.com/repos/Teemperor/root","forks_url":"https://api.github.com/repos/Teemperor/root/forks","keys_url":"https://api.github.com/repos/Teemperor/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teemperor/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teemperor/root/teams","hooks_url":"https://api.github.com/repos/Teemperor/root/hooks","issue_events_url":"https://api.github.com/repos/Teemperor/root/issues/events{/number}","events_url":"https://api.github.com/repos/Teemperor/root/events","assignees_url":"https://api.github.com/repos/Teemperor/root/assignees{/user}","branches_url":"https://api.github.com/repos/Teemperor/root/branches{/branch}","tags_url":"https://api.github.com/repos/Teemperor/root/tags","blobs_url":"https://api.github.com/repos/Teemperor/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teemperor/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teemperor/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teemperor/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teemperor/root/statuses/{sha}","languages_url":"https://api.github.com/repos/Teemperor/root/languages","stargazers_url":"https://api.github.com/repos/Teemperor/root/stargazers","contributors_url":"https://api.github.com/repos/Teemperor/root/contributors","subscribers_url":"https://api.github.com/repos/Teemperor/root/subscribers","subscription_url":"https://api.github.com/repos/Teemperor/root/subscription","commits_url":"https://api.github.com/repos/Teemperor/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teemperor/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teemperor/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teemperor/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teemperor/root/contents/{+path}","compare_url":"https://api.github.com/repos/Teemperor/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teemperor/root/merges","archive_url":"https://api.github.com/repos/Teemperor/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teemperor/root/downloads","issues_url":"https://api.github.com/repos/Teemperor/root/issues{/number}","pulls_url":"https://api.github.com/repos/Teemperor/root/pulls{/number}","milestones_url":"https://api.github.com/repos/Teemperor/root/milestones{/number}","notifications_url":"https://api.github.com/repos/Teemperor/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teemperor/root/labels{/name}","releases_url":"https://api.github.com/repos/Teemperor/root/releases{/id}","deployments_url":"https://api.github.com/repos/Teemperor/root/deployments","created_at":"2017-02-03T15:05:07Z","updated_at":"2017-02-03T15:06:07Z","pushed_at":"2017-09-12T07:52:44Z","git_url":"git://github.com/Teemperor/root.git","ssh_url":"git@github.com:Teemperor/root.git","clone_url":"https://github.com/Teemperor/root.git","svn_url":"https://github.com/Teemperor/root","homepage":"http://root.cern.ch","size":660833,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"2ebbb748ad3851f18835a3328998c307ed5fbc9e","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official ROOT repository","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2017-09-11T16:18:09Z","pushed_at":"2017-09-12T07:52:46Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"","size":661085,"stargazers_count":394,"watchers_count":394,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":48,"forks":293,"open_issues":48,"watchers":394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/930"},"html":{"href":"https://github.com/root-project/root/pull/930"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/930"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/930/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/930/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/930/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/f4173eebd2c940cfa48ba9971ad01aeae249fe45"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Teemperor"}}