{"action":"opened","number":12229,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/12229","id":155150660,"html_url":"https://github.com/ampproject/amphtml/pull/12229","diff_url":"https://github.com/ampproject/amphtml/pull/12229.diff","patch_url":"https://github.com/ampproject/amphtml/pull/12229.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/12229","number":12229,"state":"open","locked":false,"title":"Calculate correct documentHeight for short AMP docs","user":{"login":"peterjosling","id":930324,"avatar_url":"https://avatars2.githubusercontent.com/u/930324?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjosling","html_url":"https://github.com/peterjosling","followers_url":"https://api.github.com/users/peterjosling/followers","following_url":"https://api.github.com/users/peterjosling/following{/other_user}","gists_url":"https://api.github.com/users/peterjosling/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjosling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjosling/subscriptions","organizations_url":"https://api.github.com/users/peterjosling/orgs","repos_url":"https://api.github.com/users/peterjosling/repos","events_url":"https://api.github.com/users/peterjosling/events{/privacy}","received_events_url":"https://api.github.com/users/peterjosling/received_events","type":"User","site_admin":false},"body":"Handles the edge case of AMP documents which are shorter than their\r\ncontaining viewport, which causes documentHeight to be scrollHeight,\r\nwhich is the height of the viewport. Should be a no-op for docs which\r\nare already taller than the viewport.\r\n\r\nRe-implements changes made in\r\nhttps://github.com/ampproject/amphtml/commit/ac741f6d448305570659d0eae3c11c9049ae0fef,\r\nwhich were reverted before merging.\r\n\r\nFixes #12172 \r\n","created_at":"2017-11-28T18:37:33Z","updated_at":"2017-11-28T18:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/12229/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/12229/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/12229/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/bd4561f58069c2fa3dc03bcc73e0ea6e3bf727c8","head":{"label":"peterjosling:short_document_fix","ref":"short_document_fix","sha":"bd4561f58069c2fa3dc03bcc73e0ea6e3bf727c8","user":{"login":"peterjosling","id":930324,"avatar_url":"https://avatars2.githubusercontent.com/u/930324?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjosling","html_url":"https://github.com/peterjosling","followers_url":"https://api.github.com/users/peterjosling/followers","following_url":"https://api.github.com/users/peterjosling/following{/other_user}","gists_url":"https://api.github.com/users/peterjosling/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjosling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjosling/subscriptions","organizations_url":"https://api.github.com/users/peterjosling/orgs","repos_url":"https://api.github.com/users/peterjosling/repos","events_url":"https://api.github.com/users/peterjosling/events{/privacy}","received_events_url":"https://api.github.com/users/peterjosling/received_events","type":"User","site_admin":false},"repo":{"id":107135455,"name":"amphtml","full_name":"peterjosling/amphtml","owner":{"login":"peterjosling","id":930324,"avatar_url":"https://avatars2.githubusercontent.com/u/930324?v=4","gravatar_id":"","url":"https://api.github.com/users/peterjosling","html_url":"https://github.com/peterjosling","followers_url":"https://api.github.com/users/peterjosling/followers","following_url":"https://api.github.com/users/peterjosling/following{/other_user}","gists_url":"https://api.github.com/users/peterjosling/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjosling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjosling/subscriptions","organizations_url":"https://api.github.com/users/peterjosling/orgs","repos_url":"https://api.github.com/users/peterjosling/repos","events_url":"https://api.github.com/users/peterjosling/events{/privacy}","received_events_url":"https://api.github.com/users/peterjosling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterjosling/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/peterjosling/amphtml","forks_url":"https://api.github.com/repos/peterjosling/amphtml/forks","keys_url":"https://api.github.com/repos/peterjosling/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterjosling/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterjosling/amphtml/teams","hooks_url":"https://api.github.com/repos/peterjosling/amphtml/hooks","issue_events_url":"https://api.github.com/repos/peterjosling/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/peterjosling/amphtml/events","assignees_url":"https://api.github.com/repos/peterjosling/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/peterjosling/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/peterjosling/amphtml/tags","blobs_url":"https://api.github.com/repos/peterjosling/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterjosling/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterjosling/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterjosling/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterjosling/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/peterjosling/amphtml/languages","stargazers_url":"https://api.github.com/repos/peterjosling/amphtml/stargazers","contributors_url":"https://api.github.com/repos/peterjosling/amphtml/contributors","subscribers_url":"https://api.github.com/repos/peterjosling/amphtml/subscribers","subscription_url":"https://api.github.com/repos/peterjosling/amphtml/subscription","commits_url":"https://api.github.com/repos/peterjosling/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterjosling/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterjosling/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterjosling/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterjosling/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/peterjosling/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterjosling/amphtml/merges","archive_url":"https://api.github.com/repos/peterjosling/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterjosling/amphtml/downloads","issues_url":"https://api.github.com/repos/peterjosling/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/peterjosling/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/peterjosling/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/peterjosling/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterjosling/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/peterjosling/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/peterjosling/amphtml/deployments","created_at":"2017-10-16T14:02:24Z","updated_at":"2017-10-16T14:02:34Z","pushed_at":"2017-11-28T18:35:30Z","git_url":"git://github.com/peterjosling/amphtml.git","ssh_url":"git@github.com:peterjosling/amphtml.git","clone_url":"https://github.com/peterjosling/amphtml.git","svn_url":"https://github.com/peterjosling/amphtml","homepage":"https://www.ampproject.org","size":290086,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"733095904d7de4d6a39960d93e9d16c285ed6f65","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-11-28T17:57:57Z","pushed_at":"2017-11-28T18:30:32Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":291341,"stargazers_count":10748,"watchers_count":10748,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2067,"mirror_url":null,"archived":false,"open_issues_count":1127,"forks":2067,"open_issues":1127,"watchers":10748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/12229"},"html":{"href":"https://github.com/ampproject/amphtml/pull/12229"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/12229"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/12229/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/12229/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/12229/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/bd4561f58069c2fa3dc03bcc73e0ea6e3bf727c8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":94,"deletions":23,"changed_files":8}}
{"actor":{"display_login":"peterjosling"}}