{"push_id":1534752733,"size":12,"distinct_size":1,"ref":"refs/heads/modern-media-controls","head":"e179e14ed52e4424289caf188b6e5fdea914201f","before":"868d0340db615dcf3a2150edba5cf23d24a26dcc","commits":[{"sha":"50ec0e2333f327d96bc3ac84e8c61ddb432c0eca","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"In iOS, we should take background assertion when accessing localstorage databases.\nhttps://bugs.webkit.org/show_bug.cgi?id=165478\n\nSource/WebCore:\n\nMove WebSQLiteDatabaseTrackerClient from WebKitLegacy to WebCore so that it can be accessible from\nWebKit1 and WebKit2. Previously, to avoid dependencies on UIKit, WebKitLegacy introduced several\nglobal methods for UIKit to setup the start/end background task blocks on runtime (WebKitSetStartBackgroundTaskBlock,\nWebKitSetInvalidWebBackgroundTaskIdentifier and WebKitSetEndBackgroundTaskBlock). Since we have to\nmove the background task handling to WebCore, to avoid adding WebCore dependencies on UIKit, this\npatch introdues a new WebCore class WebBackgroundTaskController which holds the start/end background\ntask blocks. The existing WebKitSetStartBackgroundTaskBlock and WebKitSetEndBackgroundTaskBlock methods\nin WebKit1 will use WebBackgroundTaskController to store the blocks set by UIKit.\n\nPatch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02\nReviewed by Brady Eidson.\n\nNo new test since this is code refactoring.\n\n* WebCore.xcodeproj/project.pbxproj: Add a new class WebBackgroundTaskController to the project. Also move\n    WebSQLiteDatabaseTrackerClient from WebKitLegacy to WebCore.\n* platform/ios/WebBackgroundTaskController.h: Use properties to hold the blocks for starting or ending background tasks.\n* platform/ios/WebBackgroundTaskController.mm:\n(+[WebBackgroundTaskController sharedController]):\n(-[WebBackgroundTaskController dealloc]):\n(-[WebBackgroundTaskController startBackgroundTaskWithExpirationHandler:]): Start a background task with a expiration handler;\n    to start the background task, we will use backgroundTaskStartBlock set up by UIKit.\n(-[WebBackgroundTaskController endBackgroundTaskWithIdentifier:]): Call backgroundTaskEndBlack to end a background task.\n* platform/ios/WebSQLiteDatabaseTrackerClient.h: Copied from Source/WebKit/ios/Storage/WebSQLiteDatabaseTrackerClient.h.\n* platform/ios/WebSQLiteDatabaseTrackerClient.mm: Copied from Source/WebKit/ios/Storage/WebSQLiteDatabaseTrackerClient.mm.\n(WebCore::WebSQLiteDatabaseTrackerClient::sharedWebSQLiteDatabaseTrackerClient): Make WebSQLiteDatabaseTrackerClient a singleton.\n(WebCore::WebSQLiteDatabaseTrackerClient::WebSQLiteDatabaseTrackerClient):\n(WebCore::WebSQLiteDatabaseTrackerClient::~WebSQLiteDatabaseTrackerClient):\n(WebCore::WebSQLiteDatabaseTrackerClient::willBeginFirstTransaction): Use a utility class WebDatabaseTransactionBackgroundTaskController\n    to schedule database transaction background task.\n(WebCore::WebSQLiteDatabaseTrackerClient::didFinishLastTransaction): Use WebDatabaseTransactionBackgroundTaskController to stop\n    databas transaction background task.\n(transactionBackgroundTaskIdentifierLock: Moved from Source/WebKit/mac/Storage/WebDatabaseManager.mm.\n(setTransactionBackgroundTaskIdentifier): Ditto.\n(getTransactionBackgroundTaskIdentifier): Ditto.\n(+[WebDatabaseTransactionBackgroundTaskController startBackgroundTask]): Ditto.\n(+[WebDatabaseTransactionBackgroundTaskController endBackgroundTask]): Ditto.\n\nSource/WebKit:\n\nPatch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02\nReviewed by Brady Eidson.\n\n* WebKit.xcodeproj/project.pbxproj: Moved WebSQLiteDatabaseTrackerClient to WebCore.\n\nSource/WebKit/ios:\n\nMove application background task handling code from WebKit to WebCore.\n\nPatch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02\nReviewed by Brady Eidson.\n\n* Misc/WebUIKitSupport.h: Remove several methods that only used internally for background\n    task handling. They are not needed in WebKit any more since background task handling\n    is moved to WebCore and wrapped in WebBackgroundTaskController class.\n* Misc/WebUIKitSupport.mm:\n(WebKitSetInvalidWebBackgroundTaskIdentifier): Instead of storing the value in a static global\n    variable, save it in WebBackgroundTaskController.\n(WebKitSetStartBackgroundTaskBlock): Ditto.\n(WebKitSetEndBackgroundTaskBlock): Ditto.\n\nSource/WebKit/mac:\n\nMove database transaction background task handling code from WebDatabaseManager to\nWebCore's WebSQLiteDatabaseTrackerClient.\n\nPatch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02\nReviewed by Brady Eidson.\n\n* Storage/WebDatabaseManager.mm:\n* Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.\n* WebCoreSupport/WebApplicationCache.mm:\n(+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.\n* WebView/WebView.mm:\n(-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.\n\nSource/WebKit2:\n\nJust like in WebKit1, when initializing a WKWebView, initialize the database transaction\ntracker client. Also, we should set up the start and end background task blocks here. In\nWebKit1, this is done inside UIKit.\n\nPatch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02\nReviewed by Brady Eidson.\n\n* UIProcess/API/Cocoa/WKWebView.mm:\n(-[WKWebView _initializeWithConfiguration:]):\n(-[WKWebView _setUpSQLiteDatabaseTrackerClient]): Set up the start/end background task blocks\n    and database transaction tracker client.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211551 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/50ec0e2333f327d96bc3ac84e8c61ddb432c0eca"},{"sha":"66f701ff0de4fa81893569b77d2c3fbfba96545d","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"Removed unused m_errorHandlingModeReentry from Interpreter\nhttps://bugs.webkit.org/show_bug.cgi?id=167726\n\nPatch by Joseph Pecoraro <pecoraro@apple.com> on 2017-02-02\nReviewed by Yusuke Suzuki.\n\n* interpreter/Interpreter.cpp:\n(JSC::Interpreter::Interpreter):\n* interpreter/Interpreter.h:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211552 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/66f701ff0de4fa81893569b77d2c3fbfba96545d"},{"sha":"51e8fe443218753e25e1917e43b74365032be460","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"Removed unused m_navigationStart from NavigatorGamepad\nhttps://bugs.webkit.org/show_bug.cgi?id=167722\n\nPatch by Joseph Pecoraro <pecoraro@apple.com> on 2017-02-02\nReviewed by Yusuke Suzuki.\n\n* Modules/gamepad/NavigatorGamepad.cpp:\n(WebCore::NavigatorGamepad::NavigatorGamepad):\n(WebCore::NavigatorGamepad::from):\n* Modules/gamepad/NavigatorGamepad.h:\n(WebCore::NavigatorGamepad::navigationStart): Deleted.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211553 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/51e8fe443218753e25e1917e43b74365032be460"},{"sha":"d3e89ea45ad1d8df6be1ca3dd3ea526745ec6f9b","author":{"name":"utatane.tea@gmail.com","email":"5b6caba828616d83be87379dfbd4f472729de13f@gmail.com"},"message":"Web Inspector: Upgrade Esprima to the latest one to support dynamic import\nhttps://bugs.webkit.org/show_bug.cgi?id=167698\n\nReviewed by Joseph Pecoraro.\n\nSource/WebInspectorUI:\n\n* UserInterface/External/Esprima/esprima.js:\nUpdate to Esprima@5307e30 (4.0.0-dev).\n\n* UserInterface/Models/ScriptSyntaxTree.js:\n(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration.gatherIdentifiers):\n(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):\n(WebInspector.ScriptSyntaxTree.prototype._recurse):\n(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):\n(WebInspector.ScriptSyntaxTree):\n* UserInterface/Workers/Formatter/ESTreeWalker.js:\n(ESTreeWalker.prototype._walkChildren):\n(ESTreeWalker):\nAdd new nodes, SpreadProperty, RestProperty, and Import.\nSpreadProperty and RestProperty are the part of ES2018 rest and spread properties.\nhttps://github.com/sebmarkbage/ecmascript-rest-spread\nImport is dynamic import node. The syntax is similar to Super.\nhttps://github.com/tc39/proposal-dynamic-import\n\n* UserInterface/Workers/Formatter/EsprimaFormatter.js:\n(EsprimaFormatter.prototype._handleTokenAtNode):\n\nLayoutTests:\n\n* inspector/formatting/formatting-javascript-expected.txt:\n* inspector/formatting/formatting-javascript.html:\n* inspector/formatting/resources/javascript-tests/import-expected.js: Added.\n(async.load):\n* inspector/formatting/resources/javascript-tests/import.js: Added.\n(async.load):\n* inspector/formatting/resources/javascript-tests/object-array-literal-expected.js:\n* inspector/formatting/resources/javascript-tests/object-array-literal.js:\n* inspector/formatting/resources/javascript-tests/variable-declaration-expected.js:\n* inspector/formatting/resources/javascript-tests/variable-declaration.js:\n* inspector/formatting/resources/utilities.js:\n(TestPage.registerInitializer.):\n(TestPage.registerInitializer):\nFix a bug which occurs when output is not expected one.\n\n* inspector/model/parse-script-syntax-tree-expected.txt:\n* inspector/model/parse-script-syntax-tree.html:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211554 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/d3e89ea45ad1d8df6be1ca3dd3ea526745ec6f9b"},{"sha":"b53f71c933fa0656aff88f4158d723da16db06c2","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"Removed unused EventHandler members\nhttps://bugs.webkit.org/show_bug.cgi?id=167723\n\nPatch by Joseph Pecoraro <pecoraro@apple.com> on 2017-02-02\nReviewed by Yusuke Suzuki.\n\n* page/EventHandler.cpp:\n(WebCore::EventHandler::clear):\n(WebCore::EventHandler::handleWheelEvent):\n* page/EventHandler.h:\nRemove unused members.\n\n* editing/FrameSelection.cpp:\n* html/HTMLTextAreaElement.cpp:\n* rendering/RenderObject.cpp:\n* rendering/RenderSlider.cpp:\nRemove unnecessary includes.\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211555 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/b53f71c933fa0656aff88f4158d723da16db06c2"},{"sha":"93ddd0aabecb4734ec8ed595cced3085e80328ac","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"LayoutTest media/modern-media-controls/rewind-button/rewind-button.html is a flaky timeout\nhttps://bugs.webkit.org/show_bug.cgi?id=167352\n\nUnreviewed test gardening.\n\nPatch by Antoine Quint <graouts@apple.com> on 2017-02-02\n\n* platform/mac-wk1/TestExpectations:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211556 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/93ddd0aabecb4734ec8ed595cced3085e80328ac"},{"sha":"4f58a09fff430d3521e8beaa007f1947ed38f8de","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure\nhttps://bugs.webkit.org/show_bug.cgi?id=164571\n\nUnreviewed test gardening.\n\nPatch by Antoine Quint <graouts@apple.com> on 2017-02-02\n\n* platform/mac-wk1/TestExpectations:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211557 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/4f58a09fff430d3521e8beaa007f1947ed38f8de"},{"sha":"171668617159fd878d881b450dc4913d6a03a76a","author":{"name":"commit-queue@webkit.org","email":"bf5a5ee7740adc2e16c9908c58a0c6d4239e6078@webkit.org"},"message":"LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html is a flaky failure\nhttps://bugs.webkit.org/show_bug.cgi?id=167372\n\nUnreviewed test gardening.\n\nPatch by Antoine Quint <graouts@apple.com> on 2017-02-02\n\n* platform/mac-wk1/TestExpectations:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211558 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/171668617159fd878d881b450dc4913d6a03a76a"},{"sha":"d7d29ef4e6077d25e3f0fb9748ea7f96aa89bf74","author":{"name":"ryanhaddad@apple.com","email":"044732395dbd3a6b887403c0dc03a062a8c4066e@apple.com"},"message":"Unreviewed, rolling out r211529.\n\nThis change caused the test to fail on macOS.\n\nReverted changeset:\n\n\"Clean up css3/filters/backdrop/backdrop-filter-with-clip-\npath.html expected results.\"\nhttp://trac.webkit.org/changeset/211529\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211559 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/d7d29ef4e6077d25e3f0fb9748ea7f96aa89bf74"},{"sha":"a73ebb89f2545910e328cf485052ee992ccba50c","author":{"name":"ryanhaddad@apple.com","email":"044732395dbd3a6b887403c0dc03a062a8c4066e@apple.com"},"message":"Skip fast/visual-viewport/ios/bottom-bar-with-keyboard.html on ios-simulator.\n\nUnreviewed test gardening.\n\n* platform/ios-simulator/TestExpectations:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211560 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/a73ebb89f2545910e328cf485052ee992ccba50c"},{"sha":"166433ee7e2d5ba987b97165fd0cd1dea2972ac7","author":{"name":"graouts@webkit.org","email":"707822a6054eb24ecb3c3cd12d7b302f419ccc2c@webkit.org"},"message":"LayoutTest media/modern-media-controls/buttons-container/buttons-container-buttons-property.html is a flaky timeout\nhttps://bugs.webkit.org/show_bug.cgi?id=167371\n\nUnreviewed test gardening.\n\n* platform/mac-wk1/TestExpectations:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@211561 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":false,"url":"https://api.github.com/repos/graouts/webkit/commits/166433ee7e2d5ba987b97165fd0cd1dea2972ac7"},{"sha":"e179e14ed52e4424289caf188b6e5fdea914201f","author":{"name":"Antoine Quint","email":"707822a6054eb24ecb3c3cd12d7b302f419ccc2c@apple.com"},"message":"Modern media controls.","distinct":true,"url":"https://api.github.com/repos/graouts/webkit/commits/e179e14ed52e4424289caf188b6e5fdea914201f"}]}
{"actor":{"display_login":"graouts"}}