{"action":"created","issue":{"url":"https://api.github.com/repos/h2oai/h2o-3/issues/833","repository_url":"https://api.github.com/repos/h2oai/h2o-3","labels_url":"https://api.github.com/repos/h2oai/h2o-3/issues/833/labels{/name}","comments_url":"https://api.github.com/repos/h2oai/h2o-3/issues/833/comments","events_url":"https://api.github.com/repos/h2oai/h2o-3/issues/833/events","html_url":"https://github.com/h2oai/h2o-3/pull/833","id":208575427,"number":833,"title":"Found seed that will work for pyunit_imbalanced_gbm.py.","user":{"login":"wendycwong","id":7231712,"avatar_url":"https://avatars.githubusercontent.com/u/7231712?v=3","gravatar_id":"","url":"https://api.github.com/users/wendycwong","html_url":"https://github.com/wendycwong","followers_url":"https://api.github.com/users/wendycwong/followers","following_url":"https://api.github.com/users/wendycwong/following{/other_user}","gists_url":"https://api.github.com/users/wendycwong/gists{/gist_id}","starred_url":"https://api.github.com/users/wendycwong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendycwong/subscriptions","organizations_url":"https://api.github.com/users/wendycwong/orgs","repos_url":"https://api.github.com/users/wendycwong/repos","events_url":"https://api.github.com/users/wendycwong/events{/privacy}","received_events_url":"https://api.github.com/users/wendycwong/received_events","type":"User","site_admin":false},"labels":[{"id":483856122,"url":"https://api.github.com/repos/h2oai/h2o-3/labels/python","name":"python","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":{"login":"vpatryshev","id":241195,"avatar_url":"https://avatars.githubusercontent.com/u/241195?v=3","gravatar_id":"","url":"https://api.github.com/users/vpatryshev","html_url":"https://github.com/vpatryshev","followers_url":"https://api.github.com/users/vpatryshev/followers","following_url":"https://api.github.com/users/vpatryshev/following{/other_user}","gists_url":"https://api.github.com/users/vpatryshev/gists{/gist_id}","starred_url":"https://api.github.com/users/vpatryshev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpatryshev/subscriptions","organizations_url":"https://api.github.com/users/vpatryshev/orgs","repos_url":"https://api.github.com/users/vpatryshev/repos","events_url":"https://api.github.com/users/vpatryshev/events{/privacy}","received_events_url":"https://api.github.com/users/vpatryshev/received_events","type":"User","site_admin":false},"assignees":[{"login":"vpatryshev","id":241195,"avatar_url":"https://avatars.githubusercontent.com/u/241195?v=3","gravatar_id":"","url":"https://api.github.com/users/vpatryshev","html_url":"https://github.com/vpatryshev","followers_url":"https://api.github.com/users/vpatryshev/followers","following_url":"https://api.github.com/users/vpatryshev/following{/other_user}","gists_url":"https://api.github.com/users/vpatryshev/gists{/gist_id}","starred_url":"https://api.github.com/users/vpatryshev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpatryshev/subscriptions","organizations_url":"https://api.github.com/users/vpatryshev/orgs","repos_url":"https://api.github.com/users/vpatryshev/repos","events_url":"https://api.github.com/users/vpatryshev/events{/privacy}","received_events_url":"https://api.github.com/users/vpatryshev/received_events","type":"User","site_admin":false},{"login":"arnocandel","id":6147661,"avatar_url":"https://avatars.githubusercontent.com/u/6147661?v=3","gravatar_id":"","url":"https://api.github.com/users/arnocandel","html_url":"https://github.com/arnocandel","followers_url":"https://api.github.com/users/arnocandel/followers","following_url":"https://api.github.com/users/arnocandel/following{/other_user}","gists_url":"https://api.github.com/users/arnocandel/gists{/gist_id}","starred_url":"https://api.github.com/users/arnocandel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnocandel/subscriptions","organizations_url":"https://api.github.com/users/arnocandel/orgs","repos_url":"https://api.github.com/users/arnocandel/repos","events_url":"https://api.github.com/users/arnocandel/events{/privacy}","received_events_url":"https://api.github.com/users/arnocandel/received_events","type":"User","site_admin":false},{"login":"navdeep-G","id":10055668,"avatar_url":"https://avatars.githubusercontent.com/u/10055668?v=3","gravatar_id":"","url":"https://api.github.com/users/navdeep-G","html_url":"https://github.com/navdeep-G","followers_url":"https://api.github.com/users/navdeep-G/followers","following_url":"https://api.github.com/users/navdeep-G/following{/other_user}","gists_url":"https://api.github.com/users/navdeep-G/gists{/gist_id}","starred_url":"https://api.github.com/users/navdeep-G/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navdeep-G/subscriptions","organizations_url":"https://api.github.com/users/navdeep-G/orgs","repos_url":"https://api.github.com/users/navdeep-G/repos","events_url":"https://api.github.com/users/navdeep-G/events{/privacy}","received_events_url":"https://api.github.com/users/navdeep-G/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-02-17T22:31:00Z","updated_at":"2017-02-19T02:16:29Z","closed_at":"2017-02-18T23:03:33Z","pull_request":{"url":"https://api.github.com/repos/h2oai/h2o-3/pulls/833","html_url":"https://github.com/h2oai/h2o-3/pull/833","diff_url":"https://github.com/h2oai/h2o-3/pull/833.diff","patch_url":"https://github.com/h2oai/h2o-3/pull/833.patch"},"body":"Set the seed for pyunit_imbalanced_gbm.py to make it pass."},"comment":{"url":"https://api.github.com/repos/h2oai/h2o-3/issues/comments/280890348","html_url":"https://github.com/h2oai/h2o-3/pull/833#issuecomment-280890348","issue_url":"https://api.github.com/repos/h2oai/h2o-3/issues/833","id":280890348,"user":{"login":"arnocandel","id":6147661,"avatar_url":"https://avatars.githubusercontent.com/u/6147661?v=3","gravatar_id":"","url":"https://api.github.com/users/arnocandel","html_url":"https://github.com/arnocandel","followers_url":"https://api.github.com/users/arnocandel/followers","following_url":"https://api.github.com/users/arnocandel/following{/other_user}","gists_url":"https://api.github.com/users/arnocandel/gists{/gist_id}","starred_url":"https://api.github.com/users/arnocandel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnocandel/subscriptions","organizations_url":"https://api.github.com/users/arnocandel/orgs","repos_url":"https://api.github.com/users/arnocandel/repos","events_url":"https://api.github.com/users/arnocandel/events{/privacy}","received_events_url":"https://api.github.com/users/arnocandel/received_events","type":"User","site_admin":false},"created_at":"2017-02-19T02:16:29Z","updated_at":"2017-02-19T02:16:29Z","body":"Yes - both approaches have merit and that's what we do. If we don't record the seed, it's a bug. This particular test's error cannot be reasonably absolutely bounded, so setting a seed is better than intermittent failures. It still tests something.\n\n> On Feb 18, 2017, at 5:05 PM, Vlad Patryshev <notifications@github.com> wrote:\n> \n> If you do not hard-code a seed in a unittest, it's not a unittest, because\n> you can't reproduce.\n> On the other hand, there's a lot of advantage to run on random data. But\n> the seeds should be recorded in the logs, so if something fails, we would\n> be able to reproduce the error.\n> \n> Thanks,\n> -Vlad\n> \n> On Fri, Feb 17, 2017 at 4:07 PM, Pasha Stetsenko <notifications@github.com>\n> wrote:\n> \n> > @arnocandel <https://github.com/arnocandel>\n> > As a general rule, we should avoid hard-coding seeds into tests. Ideally,\n> > a test would choose a seed randomly, then report it to the log file (like\n> > here: 3b3f768\n> > <https://github.com/h2oai/h2o-3/pull/831/commits/3b3f768f3b43cb3bd78ee49487794e26da144427>),\n> > and then use that seed. If a test works for some seeds and not for others,\n> > then it's just a lousy test (which might be the case here). Now, a lousy\n> > test is better than no test at all; and it might be that the test is not\n> > really fixable (which might be the case here) -- however in general using\n> > fixed seeds should be avoided...\n> >\n> > —\n> > You are receiving this because you were assigned.\n> > Reply to this email directly, view it on GitHub\n> > <https://github.com/h2oai/h2o-3/pull/833#issuecomment-280800615>, or mute\n> > the thread\n> > <https://github.com/notifications/unsubscribe-auth/AAOuKwXvAlAn2cgjkur-U6Jioc48No8aks5rdjYwgaJpZM4ME1Qt>\n> > .\n> >\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"arnocandel"}}