{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/141336157","pull_request_review_id":65533465,"id":141336157,"diff_hunk":"@@ -114,6 +114,12 @@ under the License.\n \t\t\t<groupId>joda-time</groupId>\n \t\t\t<artifactId>joda-time</artifactId>\n \t\t</dependency>\n+\t\t<!-- FOR RFC 4180 Compliant CSV Parser -->\n+\t\t<dependency>","path":"flink-libraries/flink-table/pom.xml","position":5,"original_position":5,"commit_id":"9e6c9cd528055798a98db17aab2cf727cb038890","original_commit_id":"977da4649ab01b3c924640c03883312a5c2f1427","user":{"login":"uybhatti","id":15379673,"avatar_url":"https://avatars2.githubusercontent.com/u/15379673?v=4","gravatar_id":"","url":"https://api.github.com/users/uybhatti","html_url":"https://github.com/uybhatti","followers_url":"https://api.github.com/users/uybhatti/followers","following_url":"https://api.github.com/users/uybhatti/following{/other_user}","gists_url":"https://api.github.com/users/uybhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/uybhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uybhatti/subscriptions","organizations_url":"https://api.github.com/users/uybhatti/orgs","repos_url":"https://api.github.com/users/uybhatti/repos","events_url":"https://api.github.com/users/uybhatti/events{/privacy}","received_events_url":"https://api.github.com/users/uybhatti/received_events","type":"User","site_admin":false},"body":"I think it's better to move this functionality into `flink-connectors` as  `flink-connector-csv`, what do you think?","created_at":"2017-09-27T13:07:41Z","updated_at":"2017-09-27T13:07:42Z","html_url":"https://github.com/apache/flink/pull/4660#discussion_r141336157","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/4660","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/141336157"},"html":{"href":"https://github.com/apache/flink/pull/4660#discussion_r141336157"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/4660"}},"in_reply_to_id":139293599},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/4660","id":140034031,"html_url":"https://github.com/apache/flink/pull/4660","diff_url":"https://github.com/apache/flink/pull/4660.diff","patch_url":"https://github.com/apache/flink/pull/4660.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/4660","number":4660,"state":"open","locked":false,"title":"[FLINK-7050][table] Add support of RFC compliant CSV parser for Table Source","user":{"login":"uybhatti","id":15379673,"avatar_url":"https://avatars2.githubusercontent.com/u/15379673?v=4","gravatar_id":"","url":"https://api.github.com/users/uybhatti","html_url":"https://github.com/uybhatti","followers_url":"https://api.github.com/users/uybhatti/followers","following_url":"https://api.github.com/users/uybhatti/following{/other_user}","gists_url":"https://api.github.com/users/uybhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/uybhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uybhatti/subscriptions","organizations_url":"https://api.github.com/users/uybhatti/orgs","repos_url":"https://api.github.com/users/uybhatti/repos","events_url":"https://api.github.com/users/uybhatti/events{/privacy}","received_events_url":"https://api.github.com/users/uybhatti/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nCurrently CsvInputFormat is not compliant with RFC 4180 standards and we can't correctly parse fields containing double quotes, line delimiter or field delimiter.\r\n\r\n\r\n## Brief change log\r\n\r\n  - RFCCsvInputFormat is added to support RFC 4180 standards.\r\n  - Also we added RFCRowCsvInputFormat, RFCTupleCsvInputFormat and RFCCsvTableSource for this purpose.\r\n  - New dependency for Jackson parser is added in pom.xml of flink-table. \r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n  - RFCCsvInputFormatTest and RFCRowCsvInputFormatTest are added to test the added CSV Input Format functionality.\r\n  - TableSourceTest#testRFCCsvTableSourceBuilder is added for RFCCsvTableSource.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): **yes**\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**\r\n  - The serializers: **no**\r\n  - The runtime per-record code paths (performance sensitive): **no**\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **yes**\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? **yes**\r\n  - If yes, how is the feature documented? **not documented yet**\r\n","created_at":"2017-09-08T13:11:34Z","updated_at":"2017-09-27T13:07:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"855f588e6a526fd6c30458306b7039341ca28a02","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/4660/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/4660/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/4660/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/9e6c9cd528055798a98db17aab2cf727cb038890","head":{"label":"uybhatti:FLINK-7050","ref":"FLINK-7050","sha":"9e6c9cd528055798a98db17aab2cf727cb038890","user":{"login":"uybhatti","id":15379673,"avatar_url":"https://avatars2.githubusercontent.com/u/15379673?v=4","gravatar_id":"","url":"https://api.github.com/users/uybhatti","html_url":"https://github.com/uybhatti","followers_url":"https://api.github.com/users/uybhatti/followers","following_url":"https://api.github.com/users/uybhatti/following{/other_user}","gists_url":"https://api.github.com/users/uybhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/uybhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uybhatti/subscriptions","organizations_url":"https://api.github.com/users/uybhatti/orgs","repos_url":"https://api.github.com/users/uybhatti/repos","events_url":"https://api.github.com/users/uybhatti/events{/privacy}","received_events_url":"https://api.github.com/users/uybhatti/received_events","type":"User","site_admin":false},"repo":{"id":96781810,"name":"flink","full_name":"uybhatti/flink","owner":{"login":"uybhatti","id":15379673,"avatar_url":"https://avatars2.githubusercontent.com/u/15379673?v=4","gravatar_id":"","url":"https://api.github.com/users/uybhatti","html_url":"https://github.com/uybhatti","followers_url":"https://api.github.com/users/uybhatti/followers","following_url":"https://api.github.com/users/uybhatti/following{/other_user}","gists_url":"https://api.github.com/users/uybhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/uybhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uybhatti/subscriptions","organizations_url":"https://api.github.com/users/uybhatti/orgs","repos_url":"https://api.github.com/users/uybhatti/repos","events_url":"https://api.github.com/users/uybhatti/events{/privacy}","received_events_url":"https://api.github.com/users/uybhatti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uybhatti/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/uybhatti/flink","forks_url":"https://api.github.com/repos/uybhatti/flink/forks","keys_url":"https://api.github.com/repos/uybhatti/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uybhatti/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uybhatti/flink/teams","hooks_url":"https://api.github.com/repos/uybhatti/flink/hooks","issue_events_url":"https://api.github.com/repos/uybhatti/flink/issues/events{/number}","events_url":"https://api.github.com/repos/uybhatti/flink/events","assignees_url":"https://api.github.com/repos/uybhatti/flink/assignees{/user}","branches_url":"https://api.github.com/repos/uybhatti/flink/branches{/branch}","tags_url":"https://api.github.com/repos/uybhatti/flink/tags","blobs_url":"https://api.github.com/repos/uybhatti/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uybhatti/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uybhatti/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/uybhatti/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uybhatti/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/uybhatti/flink/languages","stargazers_url":"https://api.github.com/repos/uybhatti/flink/stargazers","contributors_url":"https://api.github.com/repos/uybhatti/flink/contributors","subscribers_url":"https://api.github.com/repos/uybhatti/flink/subscribers","subscription_url":"https://api.github.com/repos/uybhatti/flink/subscription","commits_url":"https://api.github.com/repos/uybhatti/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/uybhatti/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/uybhatti/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/uybhatti/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/uybhatti/flink/contents/{+path}","compare_url":"https://api.github.com/repos/uybhatti/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uybhatti/flink/merges","archive_url":"https://api.github.com/repos/uybhatti/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uybhatti/flink/downloads","issues_url":"https://api.github.com/repos/uybhatti/flink/issues{/number}","pulls_url":"https://api.github.com/repos/uybhatti/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/uybhatti/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/uybhatti/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uybhatti/flink/labels{/name}","releases_url":"https://api.github.com/repos/uybhatti/flink/releases{/id}","deployments_url":"https://api.github.com/repos/uybhatti/flink/deployments","created_at":"2017-07-10T13:39:13Z","updated_at":"2017-07-10T13:39:36Z","pushed_at":"2017-09-27T12:59:21Z","git_url":"git://github.com/uybhatti/flink.git","ssh_url":"git@github.com:uybhatti/flink.git","clone_url":"https://github.com/uybhatti/flink.git","svn_url":"https://github.com/uybhatti/flink","homepage":null,"size":133328,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"59eab45458b3b1637ccbc5dafd326cc84ffb9655","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2017-09-26T19:03:13Z","pushed_at":"2017-09-27T12:59:23Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":134077,"stargazers_count":2726,"watchers_count":2726,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1901,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":315,"forks":1901,"open_issues":315,"watchers":2726,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/4660"},"html":{"href":"https://github.com/apache/flink/pull/4660"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/4660"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/4660/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/4660/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/4660/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/9e6c9cd528055798a98db17aab2cf727cb038890"}},"author_association":"NONE"}}
{"actor":{"display_login":"uybhatti"}}