{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris/pulls/comments/144029863","pull_request_review_id":68627402,"id":144029863,"diff_hunk":"@@ -2139,25 +2140,23 @@ class NDB_BVL_Instrument extends NDB_Page\n \n             $config = NDB_Config::singleton();\n             $paths  = $config->getSetting('paths');\n-            if (empty($subtest)) {\n-                // check if the file/class exists\n-                $BasePath = $paths['base'] . 'project/instruments/';\n-                $TestName = $this->testName;\n-                if (file_exists(\n-                    $BasePath\n-                    . \"NDB_BVL_Instrument_$TestName.class.inc\"\n-                )\n-                    || file_exists($BasePath . \"$TestName.linst\")\n-                ) {\n-                    // save possible changes from the control panel...\n-                    $success = $controlPanel->save();\n-                }\n-\n-                // display the control panel\n-                $html = $controlPanel->display();\n-                return $html;\n \n+            // check if the file/class exists","path":"php/libraries/NDB_BVL_Instrument.class.inc","position":88,"original_position":88,"commit_id":"8a5a27533ec6ff3299642ad19be0f1765c9a29da","original_commit_id":"8a5a27533ec6ff3299642ad19be0f1765c9a29da","user":{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"body":"the `$subtest` variable was never defined, so `empty($subtest)` was always true, so I just removed the if statement.","created_at":"2017-10-11T14:31:53Z","updated_at":"2017-10-11T14:36:08Z","html_url":"https://github.com/aces/Loris/pull/3175#discussion_r144029863","pull_request_url":"https://api.github.com/repos/aces/Loris/pulls/3175","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments/144029863"},"html":{"href":"https://github.com/aces/Loris/pull/3175#discussion_r144029863"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris/pulls/3175"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris/pulls/3175","id":145965901,"html_url":"https://github.com/aces/Loris/pull/3175","diff_url":"https://github.com/aces/Loris/pull/3175.diff","patch_url":"https://github.com/aces/Loris/pull/3175.patch","issue_url":"https://api.github.com/repos/aces/Loris/issues/3175","number":3175,"state":"open","locked":false,"title":"Remove unused variable declarations and fix problems identified by PHPMD","user":{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"body":"This adds the unused code ruleset of PHPMD to Travis, and fixes any errors\r\nthat were identified.","created_at":"2017-10-11T14:28:28Z","updated_at":"2017-10-11T14:36:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36ace02a413d477ba146611a1959a0899b6d16d8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aces/Loris/pulls/3175/commits","review_comments_url":"https://api.github.com/repos/aces/Loris/pulls/3175/comments","review_comment_url":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris/issues/3175/comments","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/8a5a27533ec6ff3299642ad19be0f1765c9a29da","head":{"label":"driusan:RemoveUnusedCode","ref":"RemoveUnusedCode","sha":"8a5a27533ec6ff3299642ad19be0f1765c9a29da","user":{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"repo":{"id":25378793,"name":"Loris","full_name":"driusan/Loris","owner":{"login":"driusan","id":498329,"avatar_url":"https://avatars0.githubusercontent.com/u/498329?v=4","gravatar_id":"","url":"https://api.github.com/users/driusan","html_url":"https://github.com/driusan","followers_url":"https://api.github.com/users/driusan/followers","following_url":"https://api.github.com/users/driusan/following{/other_user}","gists_url":"https://api.github.com/users/driusan/gists{/gist_id}","starred_url":"https://api.github.com/users/driusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driusan/subscriptions","organizations_url":"https://api.github.com/users/driusan/orgs","repos_url":"https://api.github.com/users/driusan/repos","events_url":"https://api.github.com/users/driusan/events{/privacy}","received_events_url":"https://api.github.com/users/driusan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/driusan/Loris","description":"LORIS (Longitudinal Online Research and Imaging System) is a web-accessible database solution for neuroimaging.","fork":true,"url":"https://api.github.com/repos/driusan/Loris","forks_url":"https://api.github.com/repos/driusan/Loris/forks","keys_url":"https://api.github.com/repos/driusan/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/driusan/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/driusan/Loris/teams","hooks_url":"https://api.github.com/repos/driusan/Loris/hooks","issue_events_url":"https://api.github.com/repos/driusan/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/driusan/Loris/events","assignees_url":"https://api.github.com/repos/driusan/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/driusan/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/driusan/Loris/tags","blobs_url":"https://api.github.com/repos/driusan/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/driusan/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/driusan/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/driusan/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/driusan/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/driusan/Loris/languages","stargazers_url":"https://api.github.com/repos/driusan/Loris/stargazers","contributors_url":"https://api.github.com/repos/driusan/Loris/contributors","subscribers_url":"https://api.github.com/repos/driusan/Loris/subscribers","subscription_url":"https://api.github.com/repos/driusan/Loris/subscription","commits_url":"https://api.github.com/repos/driusan/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/driusan/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/driusan/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/driusan/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/driusan/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/driusan/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/driusan/Loris/merges","archive_url":"https://api.github.com/repos/driusan/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/driusan/Loris/downloads","issues_url":"https://api.github.com/repos/driusan/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/driusan/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/driusan/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/driusan/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/driusan/Loris/labels{/name}","releases_url":"https://api.github.com/repos/driusan/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/driusan/Loris/deployments","created_at":"2014-10-17T21:57:06Z","updated_at":"2017-05-25T19:35:05Z","pushed_at":"2017-10-11T14:27:30Z","git_url":"git://github.com/driusan/Loris.git","ssh_url":"git@github.com:driusan/Loris.git","clone_url":"https://github.com/driusan/Loris.git","svn_url":"https://github.com/driusan/Loris","homepage":"","size":71269,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"aces:major","ref":"major","sha":"12135e9d606706c11ff88652e7c28d32af922b46","user":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":1125630,"name":"Loris","full_name":"aces/Loris","owner":{"login":"aces","id":472868,"avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aces/Loris","description":"LORIS is a web-accessible database solution for longitudinal multi-site studies.","fork":false,"url":"https://api.github.com/repos/aces/Loris","forks_url":"https://api.github.com/repos/aces/Loris/forks","keys_url":"https://api.github.com/repos/aces/Loris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris/teams","hooks_url":"https://api.github.com/repos/aces/Loris/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris/events","assignees_url":"https://api.github.com/repos/aces/Loris/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris/tags","blobs_url":"https://api.github.com/repos/aces/Loris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris/languages","stargazers_url":"https://api.github.com/repos/aces/Loris/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris/subscription","commits_url":"https://api.github.com/repos/aces/Loris/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris/merges","archive_url":"https://api.github.com/repos/aces/Loris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris/downloads","issues_url":"https://api.github.com/repos/aces/Loris/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris/deployments","created_at":"2010-11-30T14:57:57Z","updated_at":"2017-10-01T08:46:55Z","pushed_at":"2017-10-11T14:28:29Z","git_url":"git://github.com/aces/Loris.git","ssh_url":"git@github.com:aces/Loris.git","clone_url":"https://github.com/aces/Loris.git","svn_url":"https://github.com/aces/Loris","homepage":"","size":70552,"stargazers_count":53,"watchers_count":53,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":136,"forks":79,"open_issues":136,"watchers":53,"default_branch":"minor"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris/pulls/3175"},"html":{"href":"https://github.com/aces/Loris/pull/3175"},"issue":{"href":"https://api.github.com/repos/aces/Loris/issues/3175"},"comments":{"href":"https://api.github.com/repos/aces/Loris/issues/3175/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris/pulls/3175/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris/pulls/3175/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris/statuses/8a5a27533ec6ff3299642ad19be0f1765c9a29da"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"driusan"}}