{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24498","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24498/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24498/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24498/events","html_url":"https://github.com/NixOS/nixpkgs/pull/24498","id":218391081,"number":24498,"title":"openvswitch: 2.5.0 -> 2.5.2","user":{"login":"volth","id":508305,"avatar_url":"https://avatars0.githubusercontent.com/u/508305?v=3","gravatar_id":"","url":"https://api.github.com/users/volth","html_url":"https://github.com/volth","followers_url":"https://api.github.com/users/volth/followers","following_url":"https://api.github.com/users/volth/following{/other_user}","gists_url":"https://api.github.com/users/volth/gists{/gist_id}","starred_url":"https://api.github.com/users/volth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volth/subscriptions","organizations_url":"https://api.github.com/users/volth/orgs","repos_url":"https://api.github.com/users/volth/repos","events_url":"https://api.github.com/users/volth/events{/privacy}","received_events_url":"https://api.github.com/users/volth/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-31T03:51:42Z","updated_at":"2017-04-10T00:53:09Z","closed_at":"2017-04-01T17:49:49Z","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/24498","html_url":"https://github.com/NixOS/nixpkgs/pull/24498","diff_url":"https://github.com/NixOS/nixpkgs/pull/24498.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/24498.patch"},"body":"###### Motivation for this change\r\n\r\nMinor bugfix update in LTS 2.5.x branch (the latest version now is 2.7.0)\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/292826209","html_url":"https://github.com/NixOS/nixpkgs/pull/24498#issuecomment-292826209","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/24498","id":292826209,"user":{"login":"volth","id":508305,"avatar_url":"https://avatars0.githubusercontent.com/u/508305?v=3","gravatar_id":"","url":"https://api.github.com/users/volth","html_url":"https://github.com/volth","followers_url":"https://api.github.com/users/volth/followers","following_url":"https://api.github.com/users/volth/following{/other_user}","gists_url":"https://api.github.com/users/volth/gists{/gist_id}","starred_url":"https://api.github.com/users/volth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volth/subscriptions","organizations_url":"https://api.github.com/users/volth/orgs","repos_url":"https://api.github.com/users/volth/repos","events_url":"https://api.github.com/users/volth/events{/privacy}","received_events_url":"https://api.github.com/users/volth/received_events","type":"User","site_admin":false},"created_at":"2017-04-10T00:53:09Z","updated_at":"2017-04-10T00:53:09Z","body":"This PR might break ```ipsec``` functionality of NixOS (when ```config.virtualisation.vswitch.ipsec = true```) because ```2.5.2``` has a bit more paths to patch in the python scripts than ```2.5.0```.\r\n\r\nOn the the other hand:\r\n * ```ipsec``` seems broken even with ```2.5.0``` for unrelated reason (yet unknown, so far I failed to bring ```ipsec``` to work with ```2.5.0```)\r\n * ipsec support is deprecated in ```2.6.x``` and removed in ```2.7.0```, so if we want to support ```config.virtualisation.vswitch.ipsec``` it should be done another way, not relying on the support provided by ```openvswitch```'s scripts.\r\n\r\ncc: @offlinehacker - Jaka, it seems that you use (or used) ```openvswitch``` + ```ipsec``` in production (as far as I remember from the video about nixos and kubernates) ?"}}
{"actor":{"display_login":"volth"}}