{"action":"created","issue":{"url":"https://api.github.com/repos/druid-io/druid/issues/3855","repository_url":"https://api.github.com/repos/druid-io/druid","labels_url":"https://api.github.com/repos/druid-io/druid/issues/3855/labels{/name}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/3855/comments","events_url":"https://api.github.com/repos/druid-io/druid/issues/3855/events","html_url":"https://github.com/druid-io/druid/pull/3855","id":201346352,"number":3855,"title":"improvements to coordinator lookups management","user":{"login":"himanshug","id":246308,"avatar_url":"https://avatars2.githubusercontent.com/u/246308?v=3","gravatar_id":"","url":"https://api.github.com/users/himanshug","html_url":"https://github.com/himanshug","followers_url":"https://api.github.com/users/himanshug/followers","following_url":"https://api.github.com/users/himanshug/following{/other_user}","gists_url":"https://api.github.com/users/himanshug/gists{/gist_id}","starred_url":"https://api.github.com/users/himanshug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanshug/subscriptions","organizations_url":"https://api.github.com/users/himanshug/orgs","repos_url":"https://api.github.com/users/himanshug/repos","events_url":"https://api.github.com/users/himanshug/events{/privacy}","received_events_url":"https://api.github.com/users/himanshug/received_events","type":"User","site_admin":false},"labels":[{"id":321808195,"url":"https://api.github.com/repos/druid-io/druid/labels/Improvement","name":"Improvement","color":"0052cc","default":false},{"id":283617667,"url":"https://api.github.com/repos/druid-io/druid/labels/Incompatible","name":"Incompatible","color":"5319e7","default":false},{"id":297508895,"url":"https://api.github.com/repos/druid-io/druid/labels/Release%20Notes","name":"Release Notes","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"leventov","id":609240,"avatar_url":"https://avatars3.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"assignees":[{"login":"leventov","id":609240,"avatar_url":"https://avatars3.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},{"login":"drcrallen","id":8213081,"avatar_url":"https://avatars1.githubusercontent.com/u/8213081?v=3","gravatar_id":"","url":"https://api.github.com/users/drcrallen","html_url":"https://github.com/drcrallen","followers_url":"https://api.github.com/users/drcrallen/followers","following_url":"https://api.github.com/users/drcrallen/following{/other_user}","gists_url":"https://api.github.com/users/drcrallen/gists{/gist_id}","starred_url":"https://api.github.com/users/drcrallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcrallen/subscriptions","organizations_url":"https://api.github.com/users/drcrallen/orgs","repos_url":"https://api.github.com/users/drcrallen/repos","events_url":"https://api.github.com/users/drcrallen/events{/privacy}","received_events_url":"https://api.github.com/users/drcrallen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/druid-io/druid/milestones/19","html_url":"https://github.com/druid-io/druid/milestone/19","labels_url":"https://api.github.com/repos/druid-io/druid/milestones/19/labels","id":1571408,"number":19,"title":"0.10.1","description":"","creator":{"login":"fjy","id":428325,"avatar_url":"https://avatars3.githubusercontent.com/u/428325?v=3","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":0,"state":"open","created_at":"2016-02-08T22:01:01Z","updated_at":"2017-02-28T18:17:53Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2017-01-17T17:01:58Z","updated_at":"2017-02-28T18:19:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/3855","html_url":"https://github.com/druid-io/druid/pull/3855","diff_url":"https://github.com/druid-io/druid/pull/3855.diff","patch_url":"https://github.com/druid-io/druid/pull/3855.patch"},"body":"PR for https://github.com/druid-io/druid/issues/3821\r\n\r\nMost major changes are done to LookupCoordinatorManager and LookupReferencesManager. This will not be backward compatible in that users will now have to specify version explicitly in addition to lookup specs when making requests for lookup adds/updates to coordinator.\r\n\r\nwhat changed?\r\n- LookupExtractorFactory.replaces(LookupExtractorFactory other) is deprecated and kept only to allow smooth transition from 0.9.x to 0.10.x\r\n- Versioning of the lookups is managed via wrapping LookupExtractorFactory and is managed by druid core. LookupReferencesManager now stores LookupExtractorFactoryContainer which is just a wrapper on LookupExtractorFactory with a version. Also Coordinator would accept LookupExtractorFactoryContainer in user requests, so user would explicitly provide a version.\r\n- Improvements to LookupCoordinatorManager loop that manages lookups\r\n- New Lookup Listener endpoint to accept request for batch add and drop of lookups\r\n- LookupReferencesManager now manages add/delete requests asynchronously in single thread\r\n- provide backward compatibility with older lookup specs stored in db, this code would read them from \"lookups\" key in config table, convert them and store them in new \"lookupsConfig\" key in the config table\r\n\r\n\r\nRelease Notes -\r\nAll coordinators should be stopped and then started with newer druid version. There should never be a situation where one coordinator is running 0.9.x while other coordinator is running 0.10.x\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/druid-io/druid/issues/comments/283120779","html_url":"https://github.com/druid-io/druid/pull/3855#issuecomment-283120779","issue_url":"https://api.github.com/repos/druid-io/druid/issues/3855","id":283120779,"user":{"login":"gianm","id":1214075,"avatar_url":"https://avatars0.githubusercontent.com/u/1214075?v=3","gravatar_id":"","url":"https://api.github.com/users/gianm","html_url":"https://github.com/gianm","followers_url":"https://api.github.com/users/gianm/followers","following_url":"https://api.github.com/users/gianm/following{/other_user}","gists_url":"https://api.github.com/users/gianm/gists{/gist_id}","starred_url":"https://api.github.com/users/gianm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianm/subscriptions","organizations_url":"https://api.github.com/users/gianm/orgs","repos_url":"https://api.github.com/users/gianm/repos","events_url":"https://api.github.com/users/gianm/events{/privacy}","received_events_url":"https://api.github.com/users/gianm/received_events","type":"User","site_admin":false},"created_at":"2017-02-28T18:19:46Z","updated_at":"2017-02-28T18:19:46Z","body":"Pushing to 0.10.1 as discussed in the dev sync"}}
{"actor":{"display_login":"gianm"}}