{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/141298670","pull_request_review_id":65489416,"id":141298670,"diff_hunk":"@@ -0,0 +1,36 @@\n+/*\n+ * Copyright (c) 2017 Intel Corporation\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+/* Convert a byte stream from stdin to hex list that can be included into\n+ * a zephyr application. This program is run in the host. It reads input from\n+ * stdin and sends output to stdout.\n+ */\n+\n+#include <stdio.h>\n+\n+int main(void)","path":"scripts/basic/stdin2hex.c","position":14,"original_position":14,"commit_id":"6cb4f05c1999c50df1055b1f3147974dc36fb56c","original_commit_id":"2c7bed9001159c55951a9de0ddb1ca5c859e404f","user":{"login":"jukkar","id":1098415,"avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false},"body":"You are looking the old code, this is already changed in latest version. Currently the latest version of this set is part of #980 and I will split the functionality from that PR after it matures a bit more. It is just PITA in github that I need to do these tweaks to get things reviewed in smaller and suitable chunks..","created_at":"2017-09-27T10:02:20Z","updated_at":"2017-09-27T10:02:20Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/1271#discussion_r141298670","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1271","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/141298670"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/1271#discussion_r141298670"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1271"}},"in_reply_to_id":139325098},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1271","id":137890917,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/1271","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/1271.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/1271.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/1271","number":1271,"state":"open","locked":false,"title":"Initial websocket support","user":{"login":"jukkar","id":1098415,"avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false},"body":"This PR adds support for server side websockets. It also provides HTTP(S) support implemented on top of net-app API, as HTTP is used when creating websocket connection. Eventually we might consider deprecating existing HTTP library and API and replace it by this library.\r\n\r\nThe WS API has some similarities with HTTP library API but is more simpler. Compared to HTTP library, more responsibility of the HTTP connection is moved from library to application. For example the connection timeouts needs to be handled in application which simplifies the library logic.\r\n\r\nAs the WS library uses net-app API, the TLS is automatically supported if needed. A simple sample application ws-echo-server is provided that demonstrates how the server side library works. The WS connectivity has been tested with wsdump.py program found in websocket-client python package.\r\n\r\nThis PR contains also few patches from IP address parsing branch (ipaddr-parse) as those patches are not yet merged, just ignore these patches or if you have comments about them, add those to PR #1198 instead. Only the last two patches have WS server support implemented.\r\n\r\nThings to do:\r\n* client role support\r\n* more testing and making sure things work as expected\r\n* bug fixing","created_at":"2017-08-28T08:00:14Z","updated_at":"2017-09-27T10:02:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f31465b499c52ca74b978131ef7a864db639158e","assignee":{"login":"jukkar","id":1098415,"avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false},"assignees":[{"login":"jukkar","id":1098415,"avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tbursztyka","id":1608406,"avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones/6","html_url":"https://github.com/zephyrproject-rtos/zephyr/milestone/6","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones/6/labels","id":2607212,"number":6,"title":"v1.10","description":"","creator":{"login":"nashif","id":180017,"avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":19,"state":"open","created_at":"2017-06-27T13:34:13Z","updated_at":"2017-09-26T09:56:52Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1271/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1271/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/1271/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/6cb4f05c1999c50df1055b1f3147974dc36fb56c","head":{"label":"jukkar:websocket","ref":"websocket","sha":"6cb4f05c1999c50df1055b1f3147974dc36fb56c","user":{"login":"jukkar","id":1098415,"avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false},"repo":{"id":89706131,"name":"zephyr","full_name":"jukkar/zephyr","owner":{"login":"jukkar","id":1098415,"avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jukkar/zephyr","description":"Mirror of the zephyr repo on https://gerrit.zephyrproject.org","fork":true,"url":"https://api.github.com/repos/jukkar/zephyr","forks_url":"https://api.github.com/repos/jukkar/zephyr/forks","keys_url":"https://api.github.com/repos/jukkar/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jukkar/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jukkar/zephyr/teams","hooks_url":"https://api.github.com/repos/jukkar/zephyr/hooks","issue_events_url":"https://api.github.com/repos/jukkar/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/jukkar/zephyr/events","assignees_url":"https://api.github.com/repos/jukkar/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/jukkar/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/jukkar/zephyr/tags","blobs_url":"https://api.github.com/repos/jukkar/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jukkar/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jukkar/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jukkar/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jukkar/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/jukkar/zephyr/languages","stargazers_url":"https://api.github.com/repos/jukkar/zephyr/stargazers","contributors_url":"https://api.github.com/repos/jukkar/zephyr/contributors","subscribers_url":"https://api.github.com/repos/jukkar/zephyr/subscribers","subscription_url":"https://api.github.com/repos/jukkar/zephyr/subscription","commits_url":"https://api.github.com/repos/jukkar/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jukkar/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jukkar/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jukkar/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/jukkar/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/jukkar/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jukkar/zephyr/merges","archive_url":"https://api.github.com/repos/jukkar/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jukkar/zephyr/downloads","issues_url":"https://api.github.com/repos/jukkar/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/jukkar/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/jukkar/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/jukkar/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jukkar/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/jukkar/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/jukkar/zephyr/deployments","created_at":"2017-04-28T12:57:50Z","updated_at":"2017-04-28T12:58:26Z","pushed_at":"2017-09-27T08:40:20Z","git_url":"git://github.com/jukkar/zephyr.git","ssh_url":"git@github.com:jukkar/zephyr.git","clone_url":"https://github.com/jukkar/zephyr.git","svn_url":"https://github.com/jukkar/zephyr","homepage":null,"size":86197,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"1685ffdba0e00e125613ccedfed82353fe4fd146","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2017-09-27T07:50:53Z","pushed_at":"2017-09-27T09:41:22Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"http://zephyrproject.org/doc","size":87989,"stargazers_count":364,"watchers_count":364,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":286,"mirror_url":null,"open_issues_count":673,"forks":286,"open_issues":673,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1271"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/1271"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/1271"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/1271/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1271/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1271/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/6cb4f05c1999c50df1055b1f3147974dc36fb56c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jukkar"}}