{"action":"created","comment":{"url":"https://api.github.com/repos/u-root/u-root/pulls/comments/152610190","pull_request_review_id":78498242,"id":152610190,"diff_hunk":"@@ -67,6 +74,9 @@ func rm(files []string) error {\n \t\t}\n \n \t\tif err := f(file); err != nil {\n+\t\t\tif flags.f && os.IsNotExist(err) {","path":"cmds/rm/rm.go","position":42,"original_position":42,"commit_id":"85db4cd1674b7388a2ed0815f6755c8f7f2b9c09","original_commit_id":"85db4cd1674b7388a2ed0815f6755c8f7f2b9c09","user":{"login":"bensallen","id":1652762,"avatar_url":"https://avatars1.githubusercontent.com/u/1652762?v=4","gravatar_id":"","url":"https://api.github.com/users/bensallen","html_url":"https://github.com/bensallen","followers_url":"https://api.github.com/users/bensallen/followers","following_url":"https://api.github.com/users/bensallen/following{/other_user}","gists_url":"https://api.github.com/users/bensallen/gists{/gist_id}","starred_url":"https://api.github.com/users/bensallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensallen/subscriptions","organizations_url":"https://api.github.com/users/bensallen/orgs","repos_url":"https://api.github.com/users/bensallen/repos","events_url":"https://api.github.com/users/bensallen/events{/privacy}","received_events_url":"https://api.github.com/users/bensallen/received_events","type":"User","site_admin":false},"body":"The force flag should also cause `rm` to ignore os.IsPermission(err) to match coreutils behavior.","created_at":"2017-11-22T16:09:02Z","updated_at":"2017-11-22T16:09:20Z","html_url":"https://github.com/u-root/u-root/pull/467#discussion_r152610190","pull_request_url":"https://api.github.com/repos/u-root/u-root/pulls/467","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/u-root/u-root/pulls/comments/152610190"},"html":{"href":"https://github.com/u-root/u-root/pull/467#discussion_r152610190"},"pull_request":{"href":"https://api.github.com/repos/u-root/u-root/pulls/467"}}},"pull_request":{"url":"https://api.github.com/repos/u-root/u-root/pulls/467","id":154148677,"html_url":"https://github.com/u-root/u-root/pull/467","diff_url":"https://github.com/u-root/u-root/pull/467.diff","patch_url":"https://github.com/u-root/u-root/pull/467.patch","issue_url":"https://api.github.com/repos/u-root/u-root/issues/467","number":467,"state":"open","locked":false,"title":"cmds/rm: Add force flag","user":{"login":"vladimiroff","id":150954,"avatar_url":"https://avatars2.githubusercontent.com/u/150954?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimiroff","html_url":"https://github.com/vladimiroff","followers_url":"https://api.github.com/users/vladimiroff/followers","following_url":"https://api.github.com/users/vladimiroff/following{/other_user}","gists_url":"https://api.github.com/users/vladimiroff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimiroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimiroff/subscriptions","organizations_url":"https://api.github.com/users/vladimiroff/orgs","repos_url":"https://api.github.com/users/vladimiroff/repos","events_url":"https://api.github.com/users/vladimiroff/events{/privacy}","received_events_url":"https://api.github.com/users/vladimiroff/received_events","type":"User","site_admin":false},"body":"The force flags disables interactive mode (if enabled) and ignores\r\nerrors when trying to delete nonexistent file(s).\r\n\r\nThis allows to invoke `rm` on multiple files and be sure that they will\r\nall be deleted even if one or more is missing. Suppose we have a folder\r\n`foo/` with files `a` and `c` in there. On `rm foo/a foo/b foo/c` only\r\n`foo/a` will get deleted, because `foo/b` is missing and thus the\r\ncommand will fail. On `rm -f foo/a foo/b foo/c` on the other hand, the\r\ncommand will succeed and both `foo/a` and `foo/c` will be deleted.\r\n\r\nFixes #335.\r\n\r\nSigned-off-by: Kiril Vladimiroff <kiril@vladimiroff.org>","created_at":"2017-11-22T13:08:34Z","updated_at":"2017-11-22T16:09:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba557687929cf275235c16b7263ff8c5760af7df","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/u-root/u-root/pulls/467/commits","review_comments_url":"https://api.github.com/repos/u-root/u-root/pulls/467/comments","review_comment_url":"https://api.github.com/repos/u-root/u-root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/u-root/u-root/issues/467/comments","statuses_url":"https://api.github.com/repos/u-root/u-root/statuses/85db4cd1674b7388a2ed0815f6755c8f7f2b9c09","head":{"label":"vladimiroff:rm-f","ref":"rm-f","sha":"85db4cd1674b7388a2ed0815f6755c8f7f2b9c09","user":{"login":"vladimiroff","id":150954,"avatar_url":"https://avatars2.githubusercontent.com/u/150954?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimiroff","html_url":"https://github.com/vladimiroff","followers_url":"https://api.github.com/users/vladimiroff/followers","following_url":"https://api.github.com/users/vladimiroff/following{/other_user}","gists_url":"https://api.github.com/users/vladimiroff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimiroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimiroff/subscriptions","organizations_url":"https://api.github.com/users/vladimiroff/orgs","repos_url":"https://api.github.com/users/vladimiroff/repos","events_url":"https://api.github.com/users/vladimiroff/events{/privacy}","received_events_url":"https://api.github.com/users/vladimiroff/received_events","type":"User","site_admin":false},"repo":{"id":111685141,"name":"u-root","full_name":"vladimiroff/u-root","owner":{"login":"vladimiroff","id":150954,"avatar_url":"https://avatars2.githubusercontent.com/u/150954?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimiroff","html_url":"https://github.com/vladimiroff","followers_url":"https://api.github.com/users/vladimiroff/followers","following_url":"https://api.github.com/users/vladimiroff/following{/other_user}","gists_url":"https://api.github.com/users/vladimiroff/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimiroff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimiroff/subscriptions","organizations_url":"https://api.github.com/users/vladimiroff/orgs","repos_url":"https://api.github.com/users/vladimiroff/repos","events_url":"https://api.github.com/users/vladimiroff/events{/privacy}","received_events_url":"https://api.github.com/users/vladimiroff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vladimiroff/u-root","description":"A universal root. u-root creates a root file system (initramfs) containing a busybox-like set of tools in Go.","fork":true,"url":"https://api.github.com/repos/vladimiroff/u-root","forks_url":"https://api.github.com/repos/vladimiroff/u-root/forks","keys_url":"https://api.github.com/repos/vladimiroff/u-root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vladimiroff/u-root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vladimiroff/u-root/teams","hooks_url":"https://api.github.com/repos/vladimiroff/u-root/hooks","issue_events_url":"https://api.github.com/repos/vladimiroff/u-root/issues/events{/number}","events_url":"https://api.github.com/repos/vladimiroff/u-root/events","assignees_url":"https://api.github.com/repos/vladimiroff/u-root/assignees{/user}","branches_url":"https://api.github.com/repos/vladimiroff/u-root/branches{/branch}","tags_url":"https://api.github.com/repos/vladimiroff/u-root/tags","blobs_url":"https://api.github.com/repos/vladimiroff/u-root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vladimiroff/u-root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vladimiroff/u-root/git/refs{/sha}","trees_url":"https://api.github.com/repos/vladimiroff/u-root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vladimiroff/u-root/statuses/{sha}","languages_url":"https://api.github.com/repos/vladimiroff/u-root/languages","stargazers_url":"https://api.github.com/repos/vladimiroff/u-root/stargazers","contributors_url":"https://api.github.com/repos/vladimiroff/u-root/contributors","subscribers_url":"https://api.github.com/repos/vladimiroff/u-root/subscribers","subscription_url":"https://api.github.com/repos/vladimiroff/u-root/subscription","commits_url":"https://api.github.com/repos/vladimiroff/u-root/commits{/sha}","git_commits_url":"https://api.github.com/repos/vladimiroff/u-root/git/commits{/sha}","comments_url":"https://api.github.com/repos/vladimiroff/u-root/comments{/number}","issue_comment_url":"https://api.github.com/repos/vladimiroff/u-root/issues/comments{/number}","contents_url":"https://api.github.com/repos/vladimiroff/u-root/contents/{+path}","compare_url":"https://api.github.com/repos/vladimiroff/u-root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vladimiroff/u-root/merges","archive_url":"https://api.github.com/repos/vladimiroff/u-root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vladimiroff/u-root/downloads","issues_url":"https://api.github.com/repos/vladimiroff/u-root/issues{/number}","pulls_url":"https://api.github.com/repos/vladimiroff/u-root/pulls{/number}","milestones_url":"https://api.github.com/repos/vladimiroff/u-root/milestones{/number}","notifications_url":"https://api.github.com/repos/vladimiroff/u-root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vladimiroff/u-root/labels{/name}","releases_url":"https://api.github.com/repos/vladimiroff/u-root/releases{/id}","deployments_url":"https://api.github.com/repos/vladimiroff/u-root/deployments","created_at":"2017-11-22T13:04:51Z","updated_at":"2017-11-22T13:04:53Z","pushed_at":"2017-11-22T13:05:08Z","git_url":"git://github.com/vladimiroff/u-root.git","ssh_url":"git@github.com:vladimiroff/u-root.git","clone_url":"https://github.com/vladimiroff/u-root.git","svn_url":"https://github.com/vladimiroff/u-root","homepage":"http://u-root.tk","size":25247,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"u-root:master","ref":"master","sha":"b34aa2c43af424dd53718db6008874029b33a20d","user":{"login":"u-root","id":13317538,"avatar_url":"https://avatars3.githubusercontent.com/u/13317538?v=4","gravatar_id":"","url":"https://api.github.com/users/u-root","html_url":"https://github.com/u-root","followers_url":"https://api.github.com/users/u-root/followers","following_url":"https://api.github.com/users/u-root/following{/other_user}","gists_url":"https://api.github.com/users/u-root/gists{/gist_id}","starred_url":"https://api.github.com/users/u-root/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u-root/subscriptions","organizations_url":"https://api.github.com/users/u-root/orgs","repos_url":"https://api.github.com/users/u-root/repos","events_url":"https://api.github.com/users/u-root/events{/privacy}","received_events_url":"https://api.github.com/users/u-root/received_events","type":"Organization","site_admin":false},"repo":{"id":46462030,"name":"u-root","full_name":"u-root/u-root","owner":{"login":"u-root","id":13317538,"avatar_url":"https://avatars3.githubusercontent.com/u/13317538?v=4","gravatar_id":"","url":"https://api.github.com/users/u-root","html_url":"https://github.com/u-root","followers_url":"https://api.github.com/users/u-root/followers","following_url":"https://api.github.com/users/u-root/following{/other_user}","gists_url":"https://api.github.com/users/u-root/gists{/gist_id}","starred_url":"https://api.github.com/users/u-root/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u-root/subscriptions","organizations_url":"https://api.github.com/users/u-root/orgs","repos_url":"https://api.github.com/users/u-root/repos","events_url":"https://api.github.com/users/u-root/events{/privacy}","received_events_url":"https://api.github.com/users/u-root/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/u-root/u-root","description":"A universal root. u-root creates a root file system (initramfs) containing a busybox-like set of tools in Go.","fork":false,"url":"https://api.github.com/repos/u-root/u-root","forks_url":"https://api.github.com/repos/u-root/u-root/forks","keys_url":"https://api.github.com/repos/u-root/u-root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/u-root/u-root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/u-root/u-root/teams","hooks_url":"https://api.github.com/repos/u-root/u-root/hooks","issue_events_url":"https://api.github.com/repos/u-root/u-root/issues/events{/number}","events_url":"https://api.github.com/repos/u-root/u-root/events","assignees_url":"https://api.github.com/repos/u-root/u-root/assignees{/user}","branches_url":"https://api.github.com/repos/u-root/u-root/branches{/branch}","tags_url":"https://api.github.com/repos/u-root/u-root/tags","blobs_url":"https://api.github.com/repos/u-root/u-root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/u-root/u-root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/u-root/u-root/git/refs{/sha}","trees_url":"https://api.github.com/repos/u-root/u-root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/u-root/u-root/statuses/{sha}","languages_url":"https://api.github.com/repos/u-root/u-root/languages","stargazers_url":"https://api.github.com/repos/u-root/u-root/stargazers","contributors_url":"https://api.github.com/repos/u-root/u-root/contributors","subscribers_url":"https://api.github.com/repos/u-root/u-root/subscribers","subscription_url":"https://api.github.com/repos/u-root/u-root/subscription","commits_url":"https://api.github.com/repos/u-root/u-root/commits{/sha}","git_commits_url":"https://api.github.com/repos/u-root/u-root/git/commits{/sha}","comments_url":"https://api.github.com/repos/u-root/u-root/comments{/number}","issue_comment_url":"https://api.github.com/repos/u-root/u-root/issues/comments{/number}","contents_url":"https://api.github.com/repos/u-root/u-root/contents/{+path}","compare_url":"https://api.github.com/repos/u-root/u-root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/u-root/u-root/merges","archive_url":"https://api.github.com/repos/u-root/u-root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/u-root/u-root/downloads","issues_url":"https://api.github.com/repos/u-root/u-root/issues{/number}","pulls_url":"https://api.github.com/repos/u-root/u-root/pulls{/number}","milestones_url":"https://api.github.com/repos/u-root/u-root/milestones{/number}","notifications_url":"https://api.github.com/repos/u-root/u-root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/u-root/u-root/labels{/name}","releases_url":"https://api.github.com/repos/u-root/u-root/releases{/id}","deployments_url":"https://api.github.com/repos/u-root/u-root/deployments","created_at":"2015-11-19T02:28:59Z","updated_at":"2017-11-22T16:00:55Z","pushed_at":"2017-11-22T13:08:35Z","git_url":"git://github.com/u-root/u-root.git","ssh_url":"git@github.com:u-root/u-root.git","clone_url":"https://github.com/u-root/u-root.git","svn_url":"https://github.com/u-root/u-root","homepage":"http://u-root.tk","size":26909,"stargazers_count":332,"watchers_count":332,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":33,"forks":44,"open_issues":33,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/u-root/u-root/pulls/467"},"html":{"href":"https://github.com/u-root/u-root/pull/467"},"issue":{"href":"https://api.github.com/repos/u-root/u-root/issues/467"},"comments":{"href":"https://api.github.com/repos/u-root/u-root/issues/467/comments"},"review_comments":{"href":"https://api.github.com/repos/u-root/u-root/pulls/467/comments"},"review_comment":{"href":"https://api.github.com/repos/u-root/u-root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/u-root/u-root/pulls/467/commits"},"statuses":{"href":"https://api.github.com/repos/u-root/u-root/statuses/85db4cd1674b7388a2ed0815f6755c8f7f2b9c09"}},"author_association":"NONE"}}
{"actor":{"display_login":"bensallen"}}