{"action":"created","comment":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/comments/149336933","pull_request_review_id":74712308,"id":149336933,"diff_hunk":"@@ -67,10 +63,10 @@ mine(Block, Attempts, InitialNonce, MaxNonce) ->\n \n %% Internal functions\n \n--spec get_txs_to_mine(trees()) -> {ok, list(signed_tx()), non_neg_integer()} | {error, term()}.\n-get_txs_to_mine(Trees) ->\n+-spec get_txs_to_mine() -> {ok, list(signed_tx()), non_neg_integer()} | {error, term()}.\n+get_txs_to_mine() ->\n     {ok, Txs0} = aec_tx_pool:peek(aec_governance:max_txs_in_block() - 1),\n-    case create_coinbase_tx(Trees) of\n+    case create_coinbase_tx() of","path":"apps/aecore/src/aec_mining.erl","position":34,"original_position":34,"commit_id":"b0950fb9b0ddef9653a720486627c09ffff17c8c","original_commit_id":"b0950fb9b0ddef9653a720486627c09ffff17c8c","user":{"login":"lucafavatella","id":1344255,"avatar_url":"https://avatars0.githubusercontent.com/u/1344255?v=4","gravatar_id":"","url":"https://api.github.com/users/lucafavatella","html_url":"https://github.com/lucafavatella","followers_url":"https://api.github.com/users/lucafavatella/followers","following_url":"https://api.github.com/users/lucafavatella/following{/other_user}","gists_url":"https://api.github.com/users/lucafavatella/gists{/gist_id}","starred_url":"https://api.github.com/users/lucafavatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucafavatella/subscriptions","organizations_url":"https://api.github.com/users/lucafavatella/orgs","repos_url":"https://api.github.com/users/lucafavatella/repos","events_url":"https://api.github.com/users/lucafavatella/events{/privacy}","received_events_url":"https://api.github.com/users/lucafavatella/received_events","type":"User","site_admin":false},"body":"I see that other transactions in the block are not passed to creation of the signed coinbase tx, as the amount is not part of the coinbase tx. Ok.","created_at":"2017-11-07T11:13:09Z","updated_at":"2017-11-07T11:13:10Z","html_url":"https://github.com/aeternity/epoch/pull/322#discussion_r149336933","pull_request_url":"https://api.github.com/repos/aeternity/epoch/pulls/322","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments/149336933"},"html":{"href":"https://github.com/aeternity/epoch/pull/322#discussion_r149336933"},"pull_request":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/322"}}},"pull_request":{"url":"https://api.github.com/repos/aeternity/epoch/pulls/322","id":150789128,"html_url":"https://github.com/aeternity/epoch/pull/322","diff_url":"https://github.com/aeternity/epoch/pull/322.diff","patch_url":"https://github.com/aeternity/epoch/pull/322.patch","issue_url":"https://api.github.com/repos/aeternity/epoch/issues/322","number":322,"state":"open","locked":false,"title":"PT-152575233 Add all block transactions' fees to miner's account","user":{"login":"zp-sd","id":28924437,"avatar_url":"https://avatars1.githubusercontent.com/u/28924437?v=4","gravatar_id":"","url":"https://api.github.com/users/zp-sd","html_url":"https://github.com/zp-sd","followers_url":"https://api.github.com/users/zp-sd/followers","following_url":"https://api.github.com/users/zp-sd/following{/other_user}","gists_url":"https://api.github.com/users/zp-sd/gists{/gist_id}","starred_url":"https://api.github.com/users/zp-sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zp-sd/subscriptions","organizations_url":"https://api.github.com/users/zp-sd/orgs","repos_url":"https://api.github.com/users/zp-sd/repos","events_url":"https://api.github.com/users/zp-sd/events{/privacy}","received_events_url":"https://api.github.com/users/zp-sd/received_events","type":"User","site_admin":false},"body":"* Remove trees() argument from aec_tx:new/2\r\n* [Finishes #152575233]","created_at":"2017-11-06T07:54:18Z","updated_at":"2017-11-07T11:13:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de63d1c6b25f40055621253e8373adf8354d8846","assignee":null,"assignees":[],"requested_reviewers":[{"login":"happi","id":158428,"avatar_url":"https://avatars2.githubusercontent.com/u/158428?v=4","gravatar_id":"","url":"https://api.github.com/users/happi","html_url":"https://github.com/happi","followers_url":"https://api.github.com/users/happi/followers","following_url":"https://api.github.com/users/happi/following{/other_user}","gists_url":"https://api.github.com/users/happi/gists{/gist_id}","starred_url":"https://api.github.com/users/happi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/happi/subscriptions","organizations_url":"https://api.github.com/users/happi/orgs","repos_url":"https://api.github.com/users/happi/repos","events_url":"https://api.github.com/users/happi/events{/privacy}","received_events_url":"https://api.github.com/users/happi/received_events","type":"User","site_admin":false},{"login":"uwiger","id":160216,"avatar_url":"https://avatars3.githubusercontent.com/u/160216?v=4","gravatar_id":"","url":"https://api.github.com/users/uwiger","html_url":"https://github.com/uwiger","followers_url":"https://api.github.com/users/uwiger/followers","following_url":"https://api.github.com/users/uwiger/following{/other_user}","gists_url":"https://api.github.com/users/uwiger/gists{/gist_id}","starred_url":"https://api.github.com/users/uwiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uwiger/subscriptions","organizations_url":"https://api.github.com/users/uwiger/orgs","repos_url":"https://api.github.com/users/uwiger/repos","events_url":"https://api.github.com/users/uwiger/events{/privacy}","received_events_url":"https://api.github.com/users/uwiger/received_events","type":"User","site_admin":false},{"login":"velzevur","id":4035918,"avatar_url":"https://avatars3.githubusercontent.com/u/4035918?v=4","gravatar_id":"","url":"https://api.github.com/users/velzevur","html_url":"https://github.com/velzevur","followers_url":"https://api.github.com/users/velzevur/followers","following_url":"https://api.github.com/users/velzevur/following{/other_user}","gists_url":"https://api.github.com/users/velzevur/gists{/gist_id}","starred_url":"https://api.github.com/users/velzevur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/velzevur/subscriptions","organizations_url":"https://api.github.com/users/velzevur/orgs","repos_url":"https://api.github.com/users/velzevur/repos","events_url":"https://api.github.com/users/velzevur/events{/privacy}","received_events_url":"https://api.github.com/users/velzevur/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aeternity/epoch/pulls/322/commits","review_comments_url":"https://api.github.com/repos/aeternity/epoch/pulls/322/comments","review_comment_url":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aeternity/epoch/issues/322/comments","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/b0950fb9b0ddef9653a720486627c09ffff17c8c","head":{"label":"zp-sd:pt-152575233-add-tx-fees-to-miners-account","ref":"pt-152575233-add-tx-fees-to-miners-account","sha":"b0950fb9b0ddef9653a720486627c09ffff17c8c","user":{"login":"zp-sd","id":28924437,"avatar_url":"https://avatars1.githubusercontent.com/u/28924437?v=4","gravatar_id":"","url":"https://api.github.com/users/zp-sd","html_url":"https://github.com/zp-sd","followers_url":"https://api.github.com/users/zp-sd/followers","following_url":"https://api.github.com/users/zp-sd/following{/other_user}","gists_url":"https://api.github.com/users/zp-sd/gists{/gist_id}","starred_url":"https://api.github.com/users/zp-sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zp-sd/subscriptions","organizations_url":"https://api.github.com/users/zp-sd/orgs","repos_url":"https://api.github.com/users/zp-sd/repos","events_url":"https://api.github.com/users/zp-sd/events{/privacy}","received_events_url":"https://api.github.com/users/zp-sd/received_events","type":"User","site_admin":false},"repo":{"id":108105154,"name":"epoch","full_name":"zp-sd/epoch","owner":{"login":"zp-sd","id":28924437,"avatar_url":"https://avatars1.githubusercontent.com/u/28924437?v=4","gravatar_id":"","url":"https://api.github.com/users/zp-sd","html_url":"https://github.com/zp-sd","followers_url":"https://api.github.com/users/zp-sd/followers","following_url":"https://api.github.com/users/zp-sd/following{/other_user}","gists_url":"https://api.github.com/users/zp-sd/gists{/gist_id}","starred_url":"https://api.github.com/users/zp-sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zp-sd/subscriptions","organizations_url":"https://api.github.com/users/zp-sd/orgs","repos_url":"https://api.github.com/users/zp-sd/repos","events_url":"https://api.github.com/users/zp-sd/events{/privacy}","received_events_url":"https://api.github.com/users/zp-sd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zp-sd/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":true,"url":"https://api.github.com/repos/zp-sd/epoch","forks_url":"https://api.github.com/repos/zp-sd/epoch/forks","keys_url":"https://api.github.com/repos/zp-sd/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zp-sd/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zp-sd/epoch/teams","hooks_url":"https://api.github.com/repos/zp-sd/epoch/hooks","issue_events_url":"https://api.github.com/repos/zp-sd/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/zp-sd/epoch/events","assignees_url":"https://api.github.com/repos/zp-sd/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/zp-sd/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/zp-sd/epoch/tags","blobs_url":"https://api.github.com/repos/zp-sd/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zp-sd/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zp-sd/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/zp-sd/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zp-sd/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/zp-sd/epoch/languages","stargazers_url":"https://api.github.com/repos/zp-sd/epoch/stargazers","contributors_url":"https://api.github.com/repos/zp-sd/epoch/contributors","subscribers_url":"https://api.github.com/repos/zp-sd/epoch/subscribers","subscription_url":"https://api.github.com/repos/zp-sd/epoch/subscription","commits_url":"https://api.github.com/repos/zp-sd/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/zp-sd/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/zp-sd/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/zp-sd/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/zp-sd/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/zp-sd/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zp-sd/epoch/merges","archive_url":"https://api.github.com/repos/zp-sd/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zp-sd/epoch/downloads","issues_url":"https://api.github.com/repos/zp-sd/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/zp-sd/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/zp-sd/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/zp-sd/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zp-sd/epoch/labels{/name}","releases_url":"https://api.github.com/repos/zp-sd/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/zp-sd/epoch/deployments","created_at":"2017-10-24T09:27:02Z","updated_at":"2017-10-24T09:27:04Z","pushed_at":"2017-11-07T10:41:28Z","git_url":"git://github.com/zp-sd/epoch.git","ssh_url":"git@github.com:zp-sd/epoch.git","clone_url":"https://github.com/zp-sd/epoch.git","svn_url":"https://github.com/zp-sd/epoch","homepage":"http://www.aeternity.com","size":1416,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aeternity:master","ref":"master","sha":"f7effa6e00b3ad1c88ac2cd4da9cfd3d2ce03967","user":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"repo":{"id":99802036,"name":"epoch","full_name":"aeternity/epoch","owner":{"login":"aeternity","id":21989234,"avatar_url":"https://avatars1.githubusercontent.com/u/21989234?v=4","gravatar_id":"","url":"https://api.github.com/users/aeternity","html_url":"https://github.com/aeternity","followers_url":"https://api.github.com/users/aeternity/followers","following_url":"https://api.github.com/users/aeternity/following{/other_user}","gists_url":"https://api.github.com/users/aeternity/gists{/gist_id}","starred_url":"https://api.github.com/users/aeternity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeternity/subscriptions","organizations_url":"https://api.github.com/users/aeternity/orgs","repos_url":"https://api.github.com/users/aeternity/repos","events_url":"https://api.github.com/users/aeternity/events{/privacy}","received_events_url":"https://api.github.com/users/aeternity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aeternity/epoch","description":"æternity testnet: solving scalability problems by making sense of state-channels ","fork":false,"url":"https://api.github.com/repos/aeternity/epoch","forks_url":"https://api.github.com/repos/aeternity/epoch/forks","keys_url":"https://api.github.com/repos/aeternity/epoch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeternity/epoch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeternity/epoch/teams","hooks_url":"https://api.github.com/repos/aeternity/epoch/hooks","issue_events_url":"https://api.github.com/repos/aeternity/epoch/issues/events{/number}","events_url":"https://api.github.com/repos/aeternity/epoch/events","assignees_url":"https://api.github.com/repos/aeternity/epoch/assignees{/user}","branches_url":"https://api.github.com/repos/aeternity/epoch/branches{/branch}","tags_url":"https://api.github.com/repos/aeternity/epoch/tags","blobs_url":"https://api.github.com/repos/aeternity/epoch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeternity/epoch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeternity/epoch/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeternity/epoch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeternity/epoch/statuses/{sha}","languages_url":"https://api.github.com/repos/aeternity/epoch/languages","stargazers_url":"https://api.github.com/repos/aeternity/epoch/stargazers","contributors_url":"https://api.github.com/repos/aeternity/epoch/contributors","subscribers_url":"https://api.github.com/repos/aeternity/epoch/subscribers","subscription_url":"https://api.github.com/repos/aeternity/epoch/subscription","commits_url":"https://api.github.com/repos/aeternity/epoch/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeternity/epoch/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeternity/epoch/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeternity/epoch/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeternity/epoch/contents/{+path}","compare_url":"https://api.github.com/repos/aeternity/epoch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeternity/epoch/merges","archive_url":"https://api.github.com/repos/aeternity/epoch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeternity/epoch/downloads","issues_url":"https://api.github.com/repos/aeternity/epoch/issues{/number}","pulls_url":"https://api.github.com/repos/aeternity/epoch/pulls{/number}","milestones_url":"https://api.github.com/repos/aeternity/epoch/milestones{/number}","notifications_url":"https://api.github.com/repos/aeternity/epoch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeternity/epoch/labels{/name}","releases_url":"https://api.github.com/repos/aeternity/epoch/releases{/id}","deployments_url":"https://api.github.com/repos/aeternity/epoch/deployments","created_at":"2017-08-09T11:44:30Z","updated_at":"2017-11-06T21:38:33Z","pushed_at":"2017-11-07T10:48:47Z","git_url":"git://github.com/aeternity/epoch.git","ssh_url":"git@github.com:aeternity/epoch.git","clone_url":"https://github.com/aeternity/epoch.git","svn_url":"https://github.com/aeternity/epoch","homepage":"http://www.aeternity.com","size":1439,"stargazers_count":78,"watchers_count":78,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":14,"open_issues":9,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/322"},"html":{"href":"https://github.com/aeternity/epoch/pull/322"},"issue":{"href":"https://api.github.com/repos/aeternity/epoch/issues/322"},"comments":{"href":"https://api.github.com/repos/aeternity/epoch/issues/322/comments"},"review_comments":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/322/comments"},"review_comment":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aeternity/epoch/pulls/322/commits"},"statuses":{"href":"https://api.github.com/repos/aeternity/epoch/statuses/b0950fb9b0ddef9653a720486627c09ffff17c8c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucafavatella"}}