{"action":"created","comment":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/131099185","pull_request_review_id":54044514,"id":131099185,"diff_hunk":"@@ -691,7 +691,8 @@ def pre_callback(self, ldap, dn, entry_attrs, attrs_list, *keys, **options):\n             # save the password so it can be displayed in post_callback\n             setattr(context, 'randompassword', entry_attrs['userpassword'])\n \n-        entry_attrs['usercertificate'] = options.get('usercertificate', [])\n+        entry_attrs['usercertificate'] = list(\n+            options.get('usercertificate', []))","path":"ipaserver/plugins/host.py","position":6,"original_position":6,"commit_id":"8720f891cead4e8d04063e69eb5ac7dcb3192704","original_commit_id":"8720f891cead4e8d04063e69eb5ac7dcb3192704","user":{"login":"flo-renaud","id":21310191,"avatar_url":"https://avatars3.githubusercontent.com/u/21310191?v=4","gravatar_id":"","url":"https://api.github.com/users/flo-renaud","html_url":"https://github.com/flo-renaud","followers_url":"https://api.github.com/users/flo-renaud/followers","following_url":"https://api.github.com/users/flo-renaud/following{/other_user}","gists_url":"https://api.github.com/users/flo-renaud/gists{/gist_id}","starred_url":"https://api.github.com/users/flo-renaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flo-renaud/subscriptions","organizations_url":"https://api.github.com/users/flo-renaud/orgs","repos_url":"https://api.github.com/users/flo-renaud/repos","events_url":"https://api.github.com/users/flo-renaud/events{/privacy}","received_events_url":"https://api.github.com/users/flo-renaud/received_events","type":"User","site_admin":false},"body":"unless I'm mistaken, this line is not needed at all. The entry_attrs already contains the usercertificate attribute as a list (because the class inherits from LDAPCreate).","created_at":"2017-08-03T09:51:45Z","updated_at":"2017-08-03T09:53:26Z","html_url":"https://github.com/freeipa/freeipa/pull/949#discussion_r131099185","pull_request_url":"https://api.github.com/repos/freeipa/freeipa/pulls/949","_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments/131099185"},"html":{"href":"https://github.com/freeipa/freeipa/pull/949#discussion_r131099185"},"pull_request":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/949"}}},"pull_request":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/949","id":133486403,"html_url":"https://github.com/freeipa/freeipa/pull/949","diff_url":"https://github.com/freeipa/freeipa/pull/949.diff","patch_url":"https://github.com/freeipa/freeipa/pull/949.patch","issue_url":"https://api.github.com/repos/freeipa/freeipa/issues/949","number":949,"state":"open","locked":false,"title":"host, service: fix adding host/svc with a cert","user":{"login":"stlaz","id":718169,"avatar_url":"https://avatars0.githubusercontent.com/u/718169?v=4","gravatar_id":"","url":"https://api.github.com/users/stlaz","html_url":"https://github.com/stlaz","followers_url":"https://api.github.com/users/stlaz/followers","following_url":"https://api.github.com/users/stlaz/following{/other_user}","gists_url":"https://api.github.com/users/stlaz/gists{/gist_id}","starred_url":"https://api.github.com/users/stlaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlaz/subscriptions","organizations_url":"https://api.github.com/users/stlaz/orgs","repos_url":"https://api.github.com/users/stlaz/repos","events_url":"https://api.github.com/users/stlaz/events{/privacy}","received_events_url":"https://api.github.com/users/stlaz/received_events","type":"User","site_admin":false},"body":"ipaldap.LDAPEntry expects that entry attributes, if multi-valued,\r\nare lists.\r\n\r\nThe recent cert refactoring made it possible to pass certificate\r\nvalues from options directly to LDAPEntry instance but options\r\nstore multi-values as tuples. This caused crashes since the\r\nwhole tuple was stuck in a list instead of the values of the\r\ntuples to be extracted in the list.\r\n\r\nhttps://pagure.io/freeipa/issue/7077","created_at":"2017-08-01T14:24:29Z","updated_at":"2017-08-03T09:53:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcf6ef4deb062951904bef1b358ca66785d625cb","assignee":{"login":"flo-renaud","id":21310191,"avatar_url":"https://avatars3.githubusercontent.com/u/21310191?v=4","gravatar_id":"","url":"https://api.github.com/users/flo-renaud","html_url":"https://github.com/flo-renaud","followers_url":"https://api.github.com/users/flo-renaud/followers","following_url":"https://api.github.com/users/flo-renaud/following{/other_user}","gists_url":"https://api.github.com/users/flo-renaud/gists{/gist_id}","starred_url":"https://api.github.com/users/flo-renaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flo-renaud/subscriptions","organizations_url":"https://api.github.com/users/flo-renaud/orgs","repos_url":"https://api.github.com/users/flo-renaud/repos","events_url":"https://api.github.com/users/flo-renaud/events{/privacy}","received_events_url":"https://api.github.com/users/flo-renaud/received_events","type":"User","site_admin":false},"assignees":[{"login":"flo-renaud","id":21310191,"avatar_url":"https://avatars3.githubusercontent.com/u/21310191?v=4","gravatar_id":"","url":"https://api.github.com/users/flo-renaud","html_url":"https://github.com/flo-renaud","followers_url":"https://api.github.com/users/flo-renaud/followers","following_url":"https://api.github.com/users/flo-renaud/following{/other_user}","gists_url":"https://api.github.com/users/flo-renaud/gists{/gist_id}","starred_url":"https://api.github.com/users/flo-renaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flo-renaud/subscriptions","organizations_url":"https://api.github.com/users/flo-renaud/orgs","repos_url":"https://api.github.com/users/flo-renaud/repos","events_url":"https://api.github.com/users/flo-renaud/events{/privacy}","received_events_url":"https://api.github.com/users/flo-renaud/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"frasertweedale","id":2331938,"avatar_url":"https://avatars2.githubusercontent.com/u/2331938?v=4","gravatar_id":"","url":"https://api.github.com/users/frasertweedale","html_url":"https://github.com/frasertweedale","followers_url":"https://api.github.com/users/frasertweedale/followers","following_url":"https://api.github.com/users/frasertweedale/following{/other_user}","gists_url":"https://api.github.com/users/frasertweedale/gists{/gist_id}","starred_url":"https://api.github.com/users/frasertweedale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frasertweedale/subscriptions","organizations_url":"https://api.github.com/users/frasertweedale/orgs","repos_url":"https://api.github.com/users/frasertweedale/repos","events_url":"https://api.github.com/users/frasertweedale/events{/privacy}","received_events_url":"https://api.github.com/users/frasertweedale/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/freeipa/freeipa/pulls/949/commits","review_comments_url":"https://api.github.com/repos/freeipa/freeipa/pulls/949/comments","review_comment_url":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeipa/freeipa/issues/949/comments","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/8720f891cead4e8d04063e69eb5ac7dcb3192704","head":{"label":"stlaz:hostsrv_crt","ref":"hostsrv_crt","sha":"8720f891cead4e8d04063e69eb5ac7dcb3192704","user":{"login":"stlaz","id":718169,"avatar_url":"https://avatars0.githubusercontent.com/u/718169?v=4","gravatar_id":"","url":"https://api.github.com/users/stlaz","html_url":"https://github.com/stlaz","followers_url":"https://api.github.com/users/stlaz/followers","following_url":"https://api.github.com/users/stlaz/following{/other_user}","gists_url":"https://api.github.com/users/stlaz/gists{/gist_id}","starred_url":"https://api.github.com/users/stlaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlaz/subscriptions","organizations_url":"https://api.github.com/users/stlaz/orgs","repos_url":"https://api.github.com/users/stlaz/repos","events_url":"https://api.github.com/users/stlaz/events{/privacy}","received_events_url":"https://api.github.com/users/stlaz/received_events","type":"User","site_admin":false},"repo":{"id":56499127,"name":"freeipa","full_name":"stlaz/freeipa","owner":{"login":"stlaz","id":718169,"avatar_url":"https://avatars0.githubusercontent.com/u/718169?v=4","gravatar_id":"","url":"https://api.github.com/users/stlaz","html_url":"https://github.com/stlaz","followers_url":"https://api.github.com/users/stlaz/followers","following_url":"https://api.github.com/users/stlaz/following{/other_user}","gists_url":"https://api.github.com/users/stlaz/gists{/gist_id}","starred_url":"https://api.github.com/users/stlaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stlaz/subscriptions","organizations_url":"https://api.github.com/users/stlaz/orgs","repos_url":"https://api.github.com/users/stlaz/repos","events_url":"https://api.github.com/users/stlaz/events{/privacy}","received_events_url":"https://api.github.com/users/stlaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stlaz/freeipa","description":"FreeIPA mirror, this fork adds timerules to the current access control system (branch timerules)","fork":true,"url":"https://api.github.com/repos/stlaz/freeipa","forks_url":"https://api.github.com/repos/stlaz/freeipa/forks","keys_url":"https://api.github.com/repos/stlaz/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stlaz/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stlaz/freeipa/teams","hooks_url":"https://api.github.com/repos/stlaz/freeipa/hooks","issue_events_url":"https://api.github.com/repos/stlaz/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/stlaz/freeipa/events","assignees_url":"https://api.github.com/repos/stlaz/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/stlaz/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/stlaz/freeipa/tags","blobs_url":"https://api.github.com/repos/stlaz/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stlaz/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stlaz/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/stlaz/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stlaz/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/stlaz/freeipa/languages","stargazers_url":"https://api.github.com/repos/stlaz/freeipa/stargazers","contributors_url":"https://api.github.com/repos/stlaz/freeipa/contributors","subscribers_url":"https://api.github.com/repos/stlaz/freeipa/subscribers","subscription_url":"https://api.github.com/repos/stlaz/freeipa/subscription","commits_url":"https://api.github.com/repos/stlaz/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/stlaz/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/stlaz/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/stlaz/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/stlaz/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/stlaz/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stlaz/freeipa/merges","archive_url":"https://api.github.com/repos/stlaz/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stlaz/freeipa/downloads","issues_url":"https://api.github.com/repos/stlaz/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/stlaz/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/stlaz/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/stlaz/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stlaz/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/stlaz/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/stlaz/freeipa/deployments","created_at":"2016-04-18T10:34:59Z","updated_at":"2017-03-14T08:21:14Z","pushed_at":"2017-08-03T07:30:20Z","git_url":"git://github.com/stlaz/freeipa.git","ssh_url":"git@github.com:stlaz/freeipa.git","clone_url":"https://github.com/stlaz/freeipa.git","svn_url":"https://github.com/stlaz/freeipa","homepage":"http://freeipa.org/","size":41903,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeipa:master","ref":"master","sha":"8f92a9bdc16129d506d4c46388f16c9d12ec3b65","user":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars2.githubusercontent.com/u/10979201?v=4","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"repo":{"id":4340318,"name":"freeipa","full_name":"freeipa/freeipa","owner":{"login":"freeipa","id":10979201,"avatar_url":"https://avatars2.githubusercontent.com/u/10979201?v=4","gravatar_id":"","url":"https://api.github.com/users/freeipa","html_url":"https://github.com/freeipa","followers_url":"https://api.github.com/users/freeipa/followers","following_url":"https://api.github.com/users/freeipa/following{/other_user}","gists_url":"https://api.github.com/users/freeipa/gists{/gist_id}","starred_url":"https://api.github.com/users/freeipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeipa/subscriptions","organizations_url":"https://api.github.com/users/freeipa/orgs","repos_url":"https://api.github.com/users/freeipa/repos","events_url":"https://api.github.com/users/freeipa/events{/privacy}","received_events_url":"https://api.github.com/users/freeipa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeipa/freeipa","description":"Mirror of FreeIPA, an integrated security information management solution","fork":false,"url":"https://api.github.com/repos/freeipa/freeipa","forks_url":"https://api.github.com/repos/freeipa/freeipa/forks","keys_url":"https://api.github.com/repos/freeipa/freeipa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeipa/freeipa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeipa/freeipa/teams","hooks_url":"https://api.github.com/repos/freeipa/freeipa/hooks","issue_events_url":"https://api.github.com/repos/freeipa/freeipa/issues/events{/number}","events_url":"https://api.github.com/repos/freeipa/freeipa/events","assignees_url":"https://api.github.com/repos/freeipa/freeipa/assignees{/user}","branches_url":"https://api.github.com/repos/freeipa/freeipa/branches{/branch}","tags_url":"https://api.github.com/repos/freeipa/freeipa/tags","blobs_url":"https://api.github.com/repos/freeipa/freeipa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeipa/freeipa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeipa/freeipa/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeipa/freeipa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeipa/freeipa/statuses/{sha}","languages_url":"https://api.github.com/repos/freeipa/freeipa/languages","stargazers_url":"https://api.github.com/repos/freeipa/freeipa/stargazers","contributors_url":"https://api.github.com/repos/freeipa/freeipa/contributors","subscribers_url":"https://api.github.com/repos/freeipa/freeipa/subscribers","subscription_url":"https://api.github.com/repos/freeipa/freeipa/subscription","commits_url":"https://api.github.com/repos/freeipa/freeipa/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeipa/freeipa/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeipa/freeipa/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeipa/freeipa/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeipa/freeipa/contents/{+path}","compare_url":"https://api.github.com/repos/freeipa/freeipa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeipa/freeipa/merges","archive_url":"https://api.github.com/repos/freeipa/freeipa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeipa/freeipa/downloads","issues_url":"https://api.github.com/repos/freeipa/freeipa/issues{/number}","pulls_url":"https://api.github.com/repos/freeipa/freeipa/pulls{/number}","milestones_url":"https://api.github.com/repos/freeipa/freeipa/milestones{/number}","notifications_url":"https://api.github.com/repos/freeipa/freeipa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeipa/freeipa/labels{/name}","releases_url":"https://api.github.com/repos/freeipa/freeipa/releases{/id}","deployments_url":"https://api.github.com/repos/freeipa/freeipa/deployments","created_at":"2012-05-15T20:34:40Z","updated_at":"2017-07-20T09:41:23Z","pushed_at":"2017-08-03T09:29:39Z","git_url":"git://github.com/freeipa/freeipa.git","ssh_url":"git@github.com:freeipa/freeipa.git","clone_url":"https://github.com/freeipa/freeipa.git","svn_url":"https://github.com/freeipa/freeipa","homepage":"http://www.freeipa.org","size":42866,"stargazers_count":105,"watchers_count":105,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":48,"forks":95,"open_issues":48,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/949"},"html":{"href":"https://github.com/freeipa/freeipa/pull/949"},"issue":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/949"},"comments":{"href":"https://api.github.com/repos/freeipa/freeipa/issues/949/comments"},"review_comments":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/949/comments"},"review_comment":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeipa/freeipa/pulls/949/commits"},"statuses":{"href":"https://api.github.com/repos/freeipa/freeipa/statuses/8720f891cead4e8d04063e69eb5ac7dcb3192704"}}}}
{"actor":{"display_login":"flo-renaud"}}