{"action":"created","issue":{"url":"https://api.github.com/repos/grommet/grommet/issues/1370","repository_url":"https://api.github.com/repos/grommet/grommet","labels_url":"https://api.github.com/repos/grommet/grommet/issues/1370/labels{/name}","comments_url":"https://api.github.com/repos/grommet/grommet/issues/1370/comments","events_url":"https://api.github.com/repos/grommet/grommet/issues/1370/events","html_url":"https://github.com/grommet/grommet/pull/1370","id":232770852,"number":1370,"title":"Allow routed Anchor links to open in new tab via CMD + Click","user":{"login":"leonardodino","id":8649362,"avatar_url":"https://avatars1.githubusercontent.com/u/8649362?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardodino","html_url":"https://github.com/leonardodino","followers_url":"https://api.github.com/users/leonardodino/followers","following_url":"https://api.github.com/users/leonardodino/following{/other_user}","gists_url":"https://api.github.com/users/leonardodino/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardodino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardodino/subscriptions","organizations_url":"https://api.github.com/users/leonardodino/orgs","repos_url":"https://api.github.com/users/leonardodino/repos","events_url":"https://api.github.com/users/leonardodino/events{/privacy}","received_events_url":"https://api.github.com/users/leonardodino/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-06-01T05:37:50Z","updated_at":"2017-06-02T04:47:45Z","closed_at":"2017-06-01T16:59:37Z","pull_request":{"url":"https://api.github.com/repos/grommet/grommet/pulls/1370","html_url":"https://github.com/grommet/grommet/pull/1370","diff_url":"https://github.com/grommet/grommet/pull/1370.diff","patch_url":"https://github.com/grommet/grommet/pull/1370.patch"},"body":"<!--- Provide a general summary of the PR in the Title above -->\r\n\r\n#### What does this PR do?\r\nPrevent JS to interfere with shortcuts to open a link in a new tab.\r\n\r\n#### Where should the reviewer start?\r\nthis [diff](https://github.com/grommet/grommet/pull/1370/commits/cb51da2770ba84a81bc0157249068fa9b38f4346) on `src/js/components/Anchor.js`. \r\n\r\n#### What testing has been done on this PR?\r\n`pre-commit` hooks + local testing\r\n\r\n#### How should this be manually tested?\r\nLinking the project and cmd+clicking some links\r\n\r\n#### Any background context you want to provide?\r\nI think it's frustrating for SPA's to break this native behavior.\r\n\r\n#### What are the relevant issues?\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n#### Do the grommet docs need to be updated?\r\nNo, it's just a fix.\r\n\r\n#### Should this PR be mentioned in the release notes?\r\n\r\n#### Is this change backwards compatible or is it a breaking change?\r\nbackwards compatible."},"comment":{"url":"https://api.github.com/repos/grommet/grommet/issues/comments/305688663","html_url":"https://github.com/grommet/grommet/pull/1370#issuecomment-305688663","issue_url":"https://api.github.com/repos/grommet/grommet/issues/1370","id":305688663,"user":{"login":"leonardodino","id":8649362,"avatar_url":"https://avatars1.githubusercontent.com/u/8649362?v=3","gravatar_id":"","url":"https://api.github.com/users/leonardodino","html_url":"https://github.com/leonardodino","followers_url":"https://api.github.com/users/leonardodino/followers","following_url":"https://api.github.com/users/leonardodino/following{/other_user}","gists_url":"https://api.github.com/users/leonardodino/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardodino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardodino/subscriptions","organizations_url":"https://api.github.com/users/leonardodino/orgs","repos_url":"https://api.github.com/users/leonardodino/repos","events_url":"https://api.github.com/users/leonardodino/events{/privacy}","received_events_url":"https://api.github.com/users/leonardodino/received_events","type":"User","site_admin":false},"created_at":"2017-06-02T04:47:45Z","updated_at":"2017-06-02T04:47:45Z","body":"Thanks for the quick answer :D @alansouzati \r\n\r\nShould I make this change to the `<Button>` component too? another PR?\r\nAs far as i can see *(a quick search)* these are the only components that use direct router navigation.\r\n\r\nValeu! :v:"}}
{"actor":{"display_login":"leonardodino"}}