{"action":"created","issue":{"url":"https://api.github.com/repos/pentaho/mondrian/issues/807","repository_url":"https://api.github.com/repos/pentaho/mondrian","labels_url":"https://api.github.com/repos/pentaho/mondrian/issues/807/labels{/name}","comments_url":"https://api.github.com/repos/pentaho/mondrian/issues/807/comments","events_url":"https://api.github.com/repos/pentaho/mondrian/issues/807/events","html_url":"https://github.com/pentaho/mondrian/pull/807","id":199867225,"number":807,"title":"[MONDRIAN-2358] If ordinalColumn does not have a 1:1 relation w/ leve…","user":{"login":"stanislau-strelchanka","id":17829444,"avatar_url":"https://avatars.githubusercontent.com/u/17829444?v=3","gravatar_id":"","url":"https://api.github.com/users/stanislau-strelchanka","html_url":"https://github.com/stanislau-strelchanka","followers_url":"https://api.github.com/users/stanislau-strelchanka/followers","following_url":"https://api.github.com/users/stanislau-strelchanka/following{/other_user}","gists_url":"https://api.github.com/users/stanislau-strelchanka/gists{/gist_id}","starred_url":"https://api.github.com/users/stanislau-strelchanka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanislau-strelchanka/subscriptions","organizations_url":"https://api.github.com/users/stanislau-strelchanka/orgs","repos_url":"https://api.github.com/users/stanislau-strelchanka/repos","events_url":"https://api.github.com/users/stanislau-strelchanka/events{/privacy}","received_events_url":"https://api.github.com/users/stanislau-strelchanka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-10T16:25:22Z","updated_at":"2017-01-10T17:06:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pentaho/mondrian/pulls/807","html_url":"https://github.com/pentaho/mondrian/pull/807","diff_url":"https://github.com/pentaho/mondrian/pull/807.diff","patch_url":"https://github.com/pentaho/mondrian/pull/807.patch"},"body":"[MONDRIAN-2358] If ordinalColumn does not have a 1:1 relation w/ level name, no error is given and inconsistent results can occur"},"comment":{"url":"https://api.github.com/repos/pentaho/mondrian/issues/comments/271634321","html_url":"https://github.com/pentaho/mondrian/pull/807#issuecomment-271634321","issue_url":"https://api.github.com/repos/pentaho/mondrian/issues/807","id":271634321,"user":{"login":"wingman-pentaho","id":18704365,"avatar_url":"https://avatars.githubusercontent.com/u/18704365?v=3","gravatar_id":"","url":"https://api.github.com/users/wingman-pentaho","html_url":"https://github.com/wingman-pentaho","followers_url":"https://api.github.com/users/wingman-pentaho/followers","following_url":"https://api.github.com/users/wingman-pentaho/following{/other_user}","gists_url":"https://api.github.com/users/wingman-pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/wingman-pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingman-pentaho/subscriptions","organizations_url":"https://api.github.com/users/wingman-pentaho/orgs","repos_url":"https://api.github.com/users/wingman-pentaho/repos","events_url":"https://api.github.com/users/wingman-pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/wingman-pentaho/received_events","type":"User","site_admin":false},"created_at":"2017-01-10T17:06:24Z","updated_at":"2017-01-10T17:06:24Z","body":"### Build Completed\n\n:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.\n\n#### Build Commands\n\n```sh\nmvn -B -fn -DrunITs=true -f pom.xml clean install && mvn -B -f pom.xml site\n```\n\n#### Cleanup Commands\n```sh\nmvn -B -f pom.xml build-helper:remove-project-artifact\n```\n\n#### Changed files\n\n```console\n  mondrian/src/it/java/mondrian/rolap/OrderKeyOneToOneCheckTest.java\n  mondrian/src/it/java/mondrian/test/Main.java\n  mondrian/src/main/java/mondrian/rolap/SqlMemberSource.java\n  mondrian/src/main/java/mondrian/rolap/SqlTupleReader.java\n```\n\nStill Broken Tests:\n======================\n###### mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderNoWildcards:\n\n:red_circle: `junit.framework.AssertionFailedError`\n\n```java\njunit.framework.AssertionFailedError: \nSegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header\nSchema:[FoodMart]\nChecksum:[4079ae1a3e5190690712b752a45ee209]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_department=('Dairy')}\n    {product_class.product_family=('Drink')}\n    {time_by_day.the_year=('1997')}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]\n, *Segment Header\n```\n###### mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderThreeSegs:\n\n:red_circle: `junit.framework.AssertionFailedError`\n\n```java\njunit.framework.AssertionFailedError: \nSegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header\nSchema:[FoodMart]\nChecksum:[4079ae1a3e5190690712b752a45ee209]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_department=('Dairy')}\n    {product_class.product_family=('Drink')}\n    {time_by_day.the_year=('1997')}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]\n, *Segment Header\n```\n###### mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithData:\n\n:red_circle: `junit.framework.AssertionFailedError`\n\n```java\njunit.framework.AssertionFailedError: \nSegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header\nSchema:[FoodMart]\nChecksum:[4079ae1a3e5190690712b752a45ee209]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_department=('Dairy')}\n    {product_class.product_family=('Drink')}\n    {time_by_day.the_year=('1997')}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[85d83d3e873198a09ac235cfdb2864b8d310b6b4de8d0c2dbd2e94801f21e204]\n, *Segment Header\n```\n###### mondrian.rolap.agg.SegmentBuilderTest.testSameRollupRegardlessOfSegmentOrderWithEmptySegmentBody:\n\n:red_circle: `junit.framework.AssertionFailedError`\n\n```java\njunit.framework.AssertionFailedError: \nSegmentMap is empty. No segmentIds matched test parameters. Full segment cache: [*Segment Header\nSchema:[FoodMart]\nChecksum:[4079ae1a3e5190690712b752a45ee209]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {time_by_day.month_of_year=('2','3','4','5','6','7')}\n    {time_by_day.quarter=('Q1','Q2','Q3')}\n    {time_by_day.the_year=('1998')}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[208c5162e6bb49ceb217eab3621f4fc0209f73265c291a3f8aa673aee775de81]\n, *Segment\n```\n###### mondrian.rolap.CacheControlTest.testFlush:\n\n:red_circle: `junit.framework.ComparisonFailure`\n\n```java\njunit.framework.ComparisonFailure: \nexpected:<...7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_family=(*)}\n    {time_by_day.quarter=(*)}\n    {time_by_day.the_year=(*)}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]\n*Segment Header\nSchema:[FoodMart]\nChecksum:[7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_family=(*)}\n    \n```\n###### mondrian.rolap.CacheControlTest.testMondrian1094:\n\n:red_circle: `junit.framework.ComparisonFailure`\n\n```java\njunit.framework.ComparisonFailure: \nexpected:<...7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {store.store_country=('USA')}\n    {time_by_day.the_year=('1997')}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[1491d28d8de0649874b1c13ef4f142406776a2ed46ad27fd21dff9e9306c75d7]\ndiscard segment - it cannot be constrained and maintain consistency:\n*Segment Header\nSchema:[FoodMart]\nChecksum:[7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    \n```\n###### mondrian.rolap.CacheControlTest.testPartialFlush:\n\n:red_circle: `junit.framework.ComparisonFailure`\n\n```java\njunit.framework.ComparisonFailure: \nexpected:<...7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_family=(*)}\n    {time_by_day.quarter=(*)}\n    {time_by_day.the_year=(*)}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]\n*Segment Header\nSchema:[FoodMart]\nChecksum:[7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_family=(*)}\n    \n```\n###### mondrian.rolap.CacheControlTest.testPartialFlush_2:\n\n:red_circle: `junit.framework.ComparisonFailure`\n\n```java\njunit.framework.ComparisonFailure: \nexpected:<...7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {customer.gender=('M')}\n    {time_by_day.the_year=('1997')}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[956eb6693e4890a305b086aab9fa5f3b33f541e8eb1321e2e4c5f01cff475fa4]\nCache state after flush:\n*Segment Header\nSchema:[FoodMart]\nChecksum:[7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {customer.gender=('M')}\n    {time_by_day.the_year=\n```\n###### mondrian.rolap.CacheControlTest.testPartialFlushRange:\n\n:red_circle: `junit.framework.ComparisonFailure`\n\n```java\njunit.framework.ComparisonFailure: \nexpected:<...7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_family=(*)}\n    {time_by_day.quarter=(*)}\n    {time_by_day.the_year=(*)}]\nExcluded Regions:[]\nCompound Predicates:[]\nID:[81b691ea51d52148d99bccac888d5eebc210cfd1a3424b4f59b2ad59323da286]\n*Segment Header\nSchema:[FoodMart]\nChecksum:[7b4af973b0d21f364b0a746f5565cb03]\nCube:[Sales]\nMeasure:[Unit Sales]\nAxes:[\n    {product_class.product_family=(*)}\n    \n```\n\n#### Integration test coverage change\n\nThese statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to [Jacoco's documentation](http://eclemma.org/jacoco/trunk/doc/counters.html).\n\n###### mondrian.rolap.agg.SegmentCacheManager.AbortException\n * Complexity Change:  + 100.00%\n * Instruction Change:  + 100.00%\n * Line Change:  + 100.00%\n * Method Change:  + 100.00%\n\n###### mondrian.rolap.agg.SegmentCacheManager.Actor\n * Branch Change:  + 25.00%\n * Complexity Change:  + 12.50%\n * Instruction Change:  + 9.80%\n * Line Change:  + 8.62%\n\n###### mondrian.rolap.agg.SegmentLoader\n * Branch Change:  + 2.00%\n * Complexity Change:  + 2.40%\n * Instruction Change:  + 1.29%\n * Line Change:  + .89%\n\n###### mondrian.rolap.agg.SegmentLoader.2.new SegmentCacheManager.Command() {...}\n * Branch Change:  + 33.33%\n * Complexity Change:  + 33.33%\n * Instruction Change:  + 6.78%\n * Line Change:  + 6.67%\n\n###### mondrian.rolap.BatchLoader\n * Branch Change:  + 1.00%\n * Complexity Change:  + 1.61%\n * Instruction Change:  + 1.30%\n * Line Change:  + .94%\n\n###### mondrian.rolap.cache.SegmentCacheIndexImpl\n * Branch Change:  + .93%\n * Instruction Change:  + .33%\n\n###### mondrian.rolap.FastBatchingCellReader\n * Branch Change: **-.98%**:small_red_triangle_down:\n * Complexity Change: **-1.54%**:small_red_triangle_down:\n\n###### mondrian.rolap.RolapStatisticsCache\n * Branch Change:  + 7.14%\n * Complexity Change:  + 9.52%\n * Instruction Change:  + .56%\n * Line Change:  + 2.50%\n\n###### mondrian.rolap.SqlMemberSource\n * Branch Change:  + .59%\n * Complexity Change:  + .32%\n * Instruction Change:  + .62%\n * Line Change:  + .45%\n\n###### mondrian.rolap.SqlTupleReader\n * Instruction Change:  + .06%\n * Line Change:  + .05%\n\n###### mondrian.rolap.SqlTupleReader.Target\n * Branch Change:  + .59%\n * Complexity Change:  + .69%\n * Instruction Change:  + .34%\n * Line Change:  + .20%\n\n###### mondrian.server.MonitorImpl.Handler\n * Branch Change: **-2.27%**:small_red_triangle_down:\n * Complexity Change: **-1.85%**:small_red_triangle_down:\n * Instruction Change: **-.42%**:small_red_triangle_down:\n * Line Change: **-.50%**:small_red_triangle_down:\n\n###### mondrian.spi.impl.JdbcStatisticsProvider\n * Branch Change:  + 5.00%\n * Complexity Change:  + 13.33%\n * Instruction Change:  + 7.11%\n * Line Change:  + 4.26%\n * Method Change:  + 20.00%\n\n#### License header violations\n\n> :heavy_exclamation_mark: Copyright year is not the current year on mondrian/src/it/java/mondrian/test/Main.java. Found 2016. Was expecting 2017\n\n> :heavy_exclamation_mark: Copyright year is not the current year on mondrian/src/main/java/mondrian/rolap/SqlMemberSource.java. Found 2016. Was expecting 2017\n\n> :heavy_exclamation_mark: Copyright year is not the current year on mondrian/src/main/java/mondrian/rolap/SqlTupleReader.java. Found 2016. Was expecting 2017"}}
{"actor":{"display_login":"wingman-pentaho"}}