{"action":"created","comment":{"url":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/comments/135660692","pull_request_review_id":59096256,"id":135660692,"diff_hunk":"@@ -0,0 +1,16 @@\n+\"use strict\";\n+\n+class Constants {\n+\tconstructor() {\n+\t}\n+\n+\tstatic get CURRENT_RAID_ID() {\n+\t\treturn \"current\";\n+\t}\n+\n+\tstatic get UNDEFINED_END_TIME() {\n+\t\treturn \"unset\";\n+\t}\n+}\n+\n+module.exports = Constants","path":"app/constants.js","position":16,"original_position":16,"commit_id":"89db1f3f4dca02c67751b4ec8c09fdf6704c1622","original_commit_id":"89db1f3f4dca02c67751b4ec8c09fdf6704c1622","user":{"login":"ForcedUnknown","id":31086074,"avatar_url":"https://avatars3.githubusercontent.com/u/31086074?v=4","gravatar_id":"","url":"https://api.github.com/users/ForcedUnknown","html_url":"https://github.com/ForcedUnknown","followers_url":"https://api.github.com/users/ForcedUnknown/followers","following_url":"https://api.github.com/users/ForcedUnknown/following{/other_user}","gists_url":"https://api.github.com/users/ForcedUnknown/gists{/gist_id}","starred_url":"https://api.github.com/users/ForcedUnknown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForcedUnknown/subscriptions","organizations_url":"https://api.github.com/users/ForcedUnknown/orgs","repos_url":"https://api.github.com/users/ForcedUnknown/repos","events_url":"https://api.github.com/users/ForcedUnknown/events{/privacy}","received_events_url":"https://api.github.com/users/ForcedUnknown/received_events","type":"User","site_admin":false},"body":"Out of curiosity, if this is a class for constants, why have a class and not a const object?","created_at":"2017-08-28T23:27:44Z","updated_at":"2017-08-28T23:27:44Z","html_url":"https://github.com/ForcedUnknown/discord-bot/pull/14#discussion_r135660692","pull_request_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/comments/135660692"},"html":{"href":"https://github.com/ForcedUnknown/discord-bot/pull/14#discussion_r135660692"},"pull_request":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/14","id":137868594,"html_url":"https://github.com/ForcedUnknown/discord-bot/pull/14","diff_url":"https://github.com/ForcedUnknown/discord-bot/pull/14.diff","patch_url":"https://github.com/ForcedUnknown/discord-bot/pull/14.patch","issue_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/issues/14","number":14,"state":"open","locked":false,"title":"Major refactoring of commands","user":{"login":"Googer","id":1251442,"avatar_url":"https://avatars2.githubusercontent.com/u/1251442?v=4","gravatar_id":"","url":"https://api.github.com/users/Googer","html_url":"https://github.com/Googer","followers_url":"https://api.github.com/users/Googer/followers","following_url":"https://api.github.com/users/Googer/following{/other_user}","gists_url":"https://api.github.com/users/Googer/gists{/gist_id}","starred_url":"https://api.github.com/users/Googer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Googer/subscriptions","organizations_url":"https://api.github.com/users/Googer/orgs","repos_url":"https://api.github.com/users/Googer/repos","events_url":"https://api.github.com/users/Googer/events{/privacy}","received_events_url":"https://api.github.com/users/Googer/received_events","type":"User","site_admin":false},"body":"Most commands refactored to use Commando's formal arguments system and custom typing with validators - start-time and status aren't really touched, and start-time isn't currently really used for anything (pulled out of displays and for use in raid deletion for the moment).  It's an easy re-add if that functionality is truly needed.\r\n\r\nAlso of note is end-time (whether set during creation or after the fact with the end-time command) is currently just a simple h:mm type of input for setting end time in the input form of specifying current remaining time as of the command's run time.  With the built-in help, command validation, and ability to amend it with the end-time command this is likely perfectly acceptable.","created_at":"2017-08-28T04:17:08Z","updated_at":"2017-08-28T23:27:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84e47301ed3faab0197dc66c11044122f4fc6f20","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/14/commits","review_comments_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/14/comments","review_comment_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/issues/14/comments","statuses_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/statuses/89db1f3f4dca02c67751b4ec8c09fdf6704c1622","head":{"label":"Googer:master","ref":"master","sha":"89db1f3f4dca02c67751b4ec8c09fdf6704c1622","user":{"login":"Googer","id":1251442,"avatar_url":"https://avatars2.githubusercontent.com/u/1251442?v=4","gravatar_id":"","url":"https://api.github.com/users/Googer","html_url":"https://github.com/Googer","followers_url":"https://api.github.com/users/Googer/followers","following_url":"https://api.github.com/users/Googer/following{/other_user}","gists_url":"https://api.github.com/users/Googer/gists{/gist_id}","starred_url":"https://api.github.com/users/Googer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Googer/subscriptions","organizations_url":"https://api.github.com/users/Googer/orgs","repos_url":"https://api.github.com/users/Googer/repos","events_url":"https://api.github.com/users/Googer/events{/privacy}","received_events_url":"https://api.github.com/users/Googer/received_events","type":"User","site_admin":false},"repo":{"id":100746849,"name":"discord-bot","full_name":"Googer/discord-bot","owner":{"login":"Googer","id":1251442,"avatar_url":"https://avatars2.githubusercontent.com/u/1251442?v=4","gravatar_id":"","url":"https://api.github.com/users/Googer","html_url":"https://github.com/Googer","followers_url":"https://api.github.com/users/Googer/followers","following_url":"https://api.github.com/users/Googer/following{/other_user}","gists_url":"https://api.github.com/users/Googer/gists{/gist_id}","starred_url":"https://api.github.com/users/Googer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Googer/subscriptions","organizations_url":"https://api.github.com/users/Googer/orgs","repos_url":"https://api.github.com/users/Googer/repos","events_url":"https://api.github.com/users/Googer/events{/privacy}","received_events_url":"https://api.github.com/users/Googer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Googer/discord-bot","description":null,"fork":true,"url":"https://api.github.com/repos/Googer/discord-bot","forks_url":"https://api.github.com/repos/Googer/discord-bot/forks","keys_url":"https://api.github.com/repos/Googer/discord-bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Googer/discord-bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Googer/discord-bot/teams","hooks_url":"https://api.github.com/repos/Googer/discord-bot/hooks","issue_events_url":"https://api.github.com/repos/Googer/discord-bot/issues/events{/number}","events_url":"https://api.github.com/repos/Googer/discord-bot/events","assignees_url":"https://api.github.com/repos/Googer/discord-bot/assignees{/user}","branches_url":"https://api.github.com/repos/Googer/discord-bot/branches{/branch}","tags_url":"https://api.github.com/repos/Googer/discord-bot/tags","blobs_url":"https://api.github.com/repos/Googer/discord-bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Googer/discord-bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Googer/discord-bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Googer/discord-bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Googer/discord-bot/statuses/{sha}","languages_url":"https://api.github.com/repos/Googer/discord-bot/languages","stargazers_url":"https://api.github.com/repos/Googer/discord-bot/stargazers","contributors_url":"https://api.github.com/repos/Googer/discord-bot/contributors","subscribers_url":"https://api.github.com/repos/Googer/discord-bot/subscribers","subscription_url":"https://api.github.com/repos/Googer/discord-bot/subscription","commits_url":"https://api.github.com/repos/Googer/discord-bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Googer/discord-bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Googer/discord-bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Googer/discord-bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Googer/discord-bot/contents/{+path}","compare_url":"https://api.github.com/repos/Googer/discord-bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Googer/discord-bot/merges","archive_url":"https://api.github.com/repos/Googer/discord-bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Googer/discord-bot/downloads","issues_url":"https://api.github.com/repos/Googer/discord-bot/issues{/number}","pulls_url":"https://api.github.com/repos/Googer/discord-bot/pulls{/number}","milestones_url":"https://api.github.com/repos/Googer/discord-bot/milestones{/number}","notifications_url":"https://api.github.com/repos/Googer/discord-bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Googer/discord-bot/labels{/name}","releases_url":"https://api.github.com/repos/Googer/discord-bot/releases{/id}","deployments_url":"https://api.github.com/repos/Googer/discord-bot/deployments","created_at":"2017-08-18T20:13:26Z","updated_at":"2017-08-18T20:13:28Z","pushed_at":"2017-08-28T20:28:32Z","git_url":"git://github.com/Googer/discord-bot.git","ssh_url":"git@github.com:Googer/discord-bot.git","clone_url":"https://github.com/Googer/discord-bot.git","svn_url":"https://github.com/Googer/discord-bot","homepage":null,"size":3243,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ForcedUnknown:master","ref":"master","sha":"fd47b5fb280a3c394c5b29045d0a69b26e3a38b3","user":{"login":"ForcedUnknown","id":31086074,"avatar_url":"https://avatars3.githubusercontent.com/u/31086074?v=4","gravatar_id":"","url":"https://api.github.com/users/ForcedUnknown","html_url":"https://github.com/ForcedUnknown","followers_url":"https://api.github.com/users/ForcedUnknown/followers","following_url":"https://api.github.com/users/ForcedUnknown/following{/other_user}","gists_url":"https://api.github.com/users/ForcedUnknown/gists{/gist_id}","starred_url":"https://api.github.com/users/ForcedUnknown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForcedUnknown/subscriptions","organizations_url":"https://api.github.com/users/ForcedUnknown/orgs","repos_url":"https://api.github.com/users/ForcedUnknown/repos","events_url":"https://api.github.com/users/ForcedUnknown/events{/privacy}","received_events_url":"https://api.github.com/users/ForcedUnknown/received_events","type":"User","site_admin":false},"repo":{"id":100660075,"name":"discord-bot","full_name":"ForcedUnknown/discord-bot","owner":{"login":"ForcedUnknown","id":31086074,"avatar_url":"https://avatars3.githubusercontent.com/u/31086074?v=4","gravatar_id":"","url":"https://api.github.com/users/ForcedUnknown","html_url":"https://github.com/ForcedUnknown","followers_url":"https://api.github.com/users/ForcedUnknown/followers","following_url":"https://api.github.com/users/ForcedUnknown/following{/other_user}","gists_url":"https://api.github.com/users/ForcedUnknown/gists{/gist_id}","starred_url":"https://api.github.com/users/ForcedUnknown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ForcedUnknown/subscriptions","organizations_url":"https://api.github.com/users/ForcedUnknown/orgs","repos_url":"https://api.github.com/users/ForcedUnknown/repos","events_url":"https://api.github.com/users/ForcedUnknown/events{/privacy}","received_events_url":"https://api.github.com/users/ForcedUnknown/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ForcedUnknown/discord-bot","description":null,"fork":false,"url":"https://api.github.com/repos/ForcedUnknown/discord-bot","forks_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/forks","keys_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/teams","hooks_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/hooks","issue_events_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/issues/events{/number}","events_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/events","assignees_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/assignees{/user}","branches_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/branches{/branch}","tags_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/tags","blobs_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/statuses/{sha}","languages_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/languages","stargazers_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/stargazers","contributors_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/contributors","subscribers_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/subscribers","subscription_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/subscription","commits_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/contents/{+path}","compare_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/merges","archive_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/downloads","issues_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/issues{/number}","pulls_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls{/number}","milestones_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/milestones{/number}","notifications_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/labels{/name}","releases_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/releases{/id}","deployments_url":"https://api.github.com/repos/ForcedUnknown/discord-bot/deployments","created_at":"2017-08-18T01:28:35Z","updated_at":"2017-08-18T01:28:42Z","pushed_at":"2017-08-28T20:28:33Z","git_url":"git://github.com/ForcedUnknown/discord-bot.git","ssh_url":"git@github.com:ForcedUnknown/discord-bot.git","clone_url":"https://github.com/ForcedUnknown/discord-bot.git","svn_url":"https://github.com/ForcedUnknown/discord-bot","homepage":null,"size":3214,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/14"},"html":{"href":"https://github.com/ForcedUnknown/discord-bot/pull/14"},"issue":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/issues/14"},"comments":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/ForcedUnknown/discord-bot/statuses/89db1f3f4dca02c67751b4ec8c09fdf6704c1622"}}}}
{"actor":{"display_login":"ForcedUnknown"}}