{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-weex/pulls/comments/152569002","pull_request_review_id":78449278,"id":152569002,"diff_hunk":"@@ -42,6 +43,31 @@ - (void)setViewport:(NSDictionary *)viewportArguments\n     } else {\n         viewportWidthFloat = [WXConvert CGFloat:viewportWidth];\n     }\n+    NSString *viewportFit = viewportArguments[@\"viewport-fit\"];\n+    if (viewportFit) {\n+        // handle viewport-fit for iPhone X\n+        // viewportFit can be `cover`,`contain`\n+        \n+        //handle cover\n+        if ([viewportFit isEqualToString:@\"cover\"]) {\n+            WXPerformBlockSyncOnMainThread(^{\n+                weexInstance.frame = [UIScreen mainScreen].bounds;","path":"ios/sdk/WeexSDK/Sources/Module/WXMetaModule.m","position":20,"original_position":20,"commit_id":"cf2b612771181d6b510320a40145edd56c0c206f","original_commit_id":"cf2b612771181d6b510320a40145edd56c0c206f","user":{"login":"CYJB","id":1865234,"avatar_url":"https://avatars2.githubusercontent.com/u/1865234?v=4","gravatar_id":"","url":"https://api.github.com/users/CYJB","html_url":"https://github.com/CYJB","followers_url":"https://api.github.com/users/CYJB/followers","following_url":"https://api.github.com/users/CYJB/following{/other_user}","gists_url":"https://api.github.com/users/CYJB/gists{/gist_id}","starred_url":"https://api.github.com/users/CYJB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CYJB/subscriptions","organizations_url":"https://api.github.com/users/CYJB/orgs","repos_url":"https://api.github.com/users/CYJB/repos","events_url":"https://api.github.com/users/CYJB/events{/privacy}","received_events_url":"https://api.github.com/users/CYJB/received_events","type":"User","site_admin":false},"body":"frame of weexInstance should never changed","created_at":"2017-11-22T13:49:52Z","updated_at":"2017-11-22T13:49:52Z","html_url":"https://github.com/apache/incubator-weex/pull/901#discussion_r152569002","pull_request_url":"https://api.github.com/repos/apache/incubator-weex/pulls/901","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-weex/pulls/comments/152569002"},"html":{"href":"https://github.com/apache/incubator-weex/pull/901#discussion_r152569002"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-weex/pulls/901"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-weex/pulls/901","id":154138047,"html_url":"https://github.com/apache/incubator-weex/pull/901","diff_url":"https://github.com/apache/incubator-weex/pull/901.diff","patch_url":"https://github.com/apache/incubator-weex/pull/901.patch","issue_url":"https://api.github.com/repos/apache/incubator-weex/issues/901","number":901,"state":"open","locked":false,"title":"[WEEX-137][iOS] support iPhone X safe area css env value and set viewport via meta module.","user":{"login":"acton393","id":11631084,"avatar_url":"https://avatars2.githubusercontent.com/u/11631084?v=4","gravatar_id":"","url":"https://api.github.com/users/acton393","html_url":"https://github.com/acton393","followers_url":"https://api.github.com/users/acton393/followers","following_url":"https://api.github.com/users/acton393/following{/other_user}","gists_url":"https://api.github.com/users/acton393/gists{/gist_id}","starred_url":"https://api.github.com/users/acton393/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acton393/subscriptions","organizations_url":"https://api.github.com/users/acton393/orgs","repos_url":"https://api.github.com/users/acton393/repos","events_url":"https://api.github.com/users/acton393/events{/privacy}","received_events_url":"https://api.github.com/users/acton393/received_events","type":"User","site_admin":false},"body":"[WEEX-137][iOS] support iPhone X safe area css env value and set viewport via meta module.\r\n\r\nBug: 137","created_at":"2017-11-22T12:16:33Z","updated_at":"2017-11-22T13:49:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b75b614f3b33d362a6e888c129c3da419d315750","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-weex/pulls/901/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-weex/pulls/901/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-weex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-weex/issues/901/comments","statuses_url":"https://api.github.com/repos/apache/incubator-weex/statuses/cf2b612771181d6b510320a40145edd56c0c206f","head":{"label":"acton393:ios-feature-support-safearea","ref":"ios-feature-support-safearea","sha":"cf2b612771181d6b510320a40145edd56c0c206f","user":{"login":"acton393","id":11631084,"avatar_url":"https://avatars2.githubusercontent.com/u/11631084?v=4","gravatar_id":"","url":"https://api.github.com/users/acton393","html_url":"https://github.com/acton393","followers_url":"https://api.github.com/users/acton393/followers","following_url":"https://api.github.com/users/acton393/following{/other_user}","gists_url":"https://api.github.com/users/acton393/gists{/gist_id}","starred_url":"https://api.github.com/users/acton393/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acton393/subscriptions","organizations_url":"https://api.github.com/users/acton393/orgs","repos_url":"https://api.github.com/users/acton393/repos","events_url":"https://api.github.com/users/acton393/events{/privacy}","received_events_url":"https://api.github.com/users/acton393/received_events","type":"User","site_admin":false},"repo":{"id":83516877,"name":"incubator-weex","full_name":"acton393/incubator-weex","owner":{"login":"acton393","id":11631084,"avatar_url":"https://avatars2.githubusercontent.com/u/11631084?v=4","gravatar_id":"","url":"https://api.github.com/users/acton393","html_url":"https://github.com/acton393","followers_url":"https://api.github.com/users/acton393/followers","following_url":"https://api.github.com/users/acton393/following{/other_user}","gists_url":"https://api.github.com/users/acton393/gists{/gist_id}","starred_url":"https://api.github.com/users/acton393/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acton393/subscriptions","organizations_url":"https://api.github.com/users/acton393/orgs","repos_url":"https://api.github.com/users/acton393/repos","events_url":"https://api.github.com/users/acton393/events{/privacy}","received_events_url":"https://api.github.com/users/acton393/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acton393/incubator-weex","description":"Mirror of Apache Weex","fork":true,"url":"https://api.github.com/repos/acton393/incubator-weex","forks_url":"https://api.github.com/repos/acton393/incubator-weex/forks","keys_url":"https://api.github.com/repos/acton393/incubator-weex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acton393/incubator-weex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acton393/incubator-weex/teams","hooks_url":"https://api.github.com/repos/acton393/incubator-weex/hooks","issue_events_url":"https://api.github.com/repos/acton393/incubator-weex/issues/events{/number}","events_url":"https://api.github.com/repos/acton393/incubator-weex/events","assignees_url":"https://api.github.com/repos/acton393/incubator-weex/assignees{/user}","branches_url":"https://api.github.com/repos/acton393/incubator-weex/branches{/branch}","tags_url":"https://api.github.com/repos/acton393/incubator-weex/tags","blobs_url":"https://api.github.com/repos/acton393/incubator-weex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acton393/incubator-weex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acton393/incubator-weex/git/refs{/sha}","trees_url":"https://api.github.com/repos/acton393/incubator-weex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acton393/incubator-weex/statuses/{sha}","languages_url":"https://api.github.com/repos/acton393/incubator-weex/languages","stargazers_url":"https://api.github.com/repos/acton393/incubator-weex/stargazers","contributors_url":"https://api.github.com/repos/acton393/incubator-weex/contributors","subscribers_url":"https://api.github.com/repos/acton393/incubator-weex/subscribers","subscription_url":"https://api.github.com/repos/acton393/incubator-weex/subscription","commits_url":"https://api.github.com/repos/acton393/incubator-weex/commits{/sha}","git_commits_url":"https://api.github.com/repos/acton393/incubator-weex/git/commits{/sha}","comments_url":"https://api.github.com/repos/acton393/incubator-weex/comments{/number}","issue_comment_url":"https://api.github.com/repos/acton393/incubator-weex/issues/comments{/number}","contents_url":"https://api.github.com/repos/acton393/incubator-weex/contents/{+path}","compare_url":"https://api.github.com/repos/acton393/incubator-weex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acton393/incubator-weex/merges","archive_url":"https://api.github.com/repos/acton393/incubator-weex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acton393/incubator-weex/downloads","issues_url":"https://api.github.com/repos/acton393/incubator-weex/issues{/number}","pulls_url":"https://api.github.com/repos/acton393/incubator-weex/pulls{/number}","milestones_url":"https://api.github.com/repos/acton393/incubator-weex/milestones{/number}","notifications_url":"https://api.github.com/repos/acton393/incubator-weex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acton393/incubator-weex/labels{/name}","releases_url":"https://api.github.com/repos/acton393/incubator-weex/releases{/id}","deployments_url":"https://api.github.com/repos/acton393/incubator-weex/deployments","created_at":"2017-03-01T05:48:09Z","updated_at":"2017-10-18T01:36:31Z","pushed_at":"2017-11-22T12:15:30Z","git_url":"git://github.com/acton393/incubator-weex.git","ssh_url":"git@github.com:acton393/incubator-weex.git","clone_url":"https://github.com/acton393/incubator-weex.git","svn_url":"https://github.com/acton393/incubator-weex","homepage":null,"size":161501,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b2a28229e529431cb749d2fcd6bf0419c68db321","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":78186814,"name":"incubator-weex","full_name":"apache/incubator-weex","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-weex","description":"Mirror of Apache Weex","fork":false,"url":"https://api.github.com/repos/apache/incubator-weex","forks_url":"https://api.github.com/repos/apache/incubator-weex/forks","keys_url":"https://api.github.com/repos/apache/incubator-weex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-weex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-weex/teams","hooks_url":"https://api.github.com/repos/apache/incubator-weex/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-weex/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-weex/events","assignees_url":"https://api.github.com/repos/apache/incubator-weex/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-weex/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-weex/tags","blobs_url":"https://api.github.com/repos/apache/incubator-weex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-weex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-weex/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-weex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-weex/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-weex/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-weex/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-weex/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-weex/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-weex/subscription","commits_url":"https://api.github.com/repos/apache/incubator-weex/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-weex/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-weex/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-weex/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-weex/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-weex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-weex/merges","archive_url":"https://api.github.com/repos/apache/incubator-weex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-weex/downloads","issues_url":"https://api.github.com/repos/apache/incubator-weex/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-weex/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-weex/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-weex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-weex/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-weex/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-weex/deployments","created_at":"2017-01-06T08:00:06Z","updated_at":"2017-11-22T13:41:58Z","pushed_at":"2017-11-22T12:16:34Z","git_url":"git://github.com/apache/incubator-weex.git","ssh_url":"git@github.com:apache/incubator-weex.git","clone_url":"https://github.com/apache/incubator-weex.git","svn_url":"https://github.com/apache/incubator-weex","homepage":null,"size":161325,"stargazers_count":6368,"watchers_count":6368,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":877,"mirror_url":"git://git.apache.org/incubator-weex.git","archived":false,"open_issues_count":10,"forks":877,"open_issues":10,"watchers":6368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-weex/pulls/901"},"html":{"href":"https://github.com/apache/incubator-weex/pull/901"},"issue":{"href":"https://api.github.com/repos/apache/incubator-weex/issues/901"},"comments":{"href":"https://api.github.com/repos/apache/incubator-weex/issues/901/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-weex/pulls/901/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-weex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-weex/pulls/901/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-weex/statuses/cf2b612771181d6b510320a40145edd56c0c206f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CYJB"}}