{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/150405152","pull_request_review_id":75954204,"id":150405152,"diff_hunk":"@@ -22,6 +22,34 @@ class HostJSTest < IntegrationTestWithJavascript\n     SETTINGS[:organizations_enabled] = true\n   end\n \n+  describe 'multiple hosts selection' do\n+    setup do\n+      FactoryBot.create(:host)\n+      FactoryBot.create(:host)\n+    end\n+\n+    test 'hosts counter should refer to per_page value first (max prespective)' do\n+      Setting[:entries_per_page] = 2\n+      visit hosts_path(per_page: 3)\n+      check 'check_all'\n+      assert page.has_text?(:all, \"All 3 hosts on this page are selected\")","path":"test/integration/host_js_test.rb","position":14,"original_position":14,"commit_id":"7d903fb312f2fb54b1fdf182c02d47ceeb11f2a8","original_commit_id":"7d903fb312f2fb54b1fdf182c02d47ceeb11f2a8","user":{"login":"amirfefer","id":11807069,"avatar_url":"https://avatars2.githubusercontent.com/u/11807069?v=4","gravatar_id":"","url":"https://api.github.com/users/amirfefer","html_url":"https://github.com/amirfefer","followers_url":"https://api.github.com/users/amirfefer/followers","following_url":"https://api.github.com/users/amirfefer/following{/other_user}","gists_url":"https://api.github.com/users/amirfefer/gists{/gist_id}","starred_url":"https://api.github.com/users/amirfefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirfefer/subscriptions","organizations_url":"https://api.github.com/users/amirfefer/orgs","repos_url":"https://api.github.com/users/amirfefer/repos","events_url":"https://api.github.com/users/amirfefer/events{/privacy}","received_events_url":"https://api.github.com/users/amirfefer/received_events","type":"User","site_admin":false},"body":"It's not related to hosts fixtures, one host is created before each test (as you can see at line 17).","created_at":"2017-11-12T09:51:44Z","updated_at":"2017-11-12T09:51:44Z","html_url":"https://github.com/theforeman/foreman/pull/4937#discussion_r150405152","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/4937","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/150405152"},"html":{"href":"https://github.com/theforeman/foreman/pull/4937#discussion_r150405152"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/4937"}},"in_reply_to_id":150404473},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/4937","id":148116372,"html_url":"https://github.com/theforeman/foreman/pull/4937","diff_url":"https://github.com/theforeman/foreman/pull/4937.diff","patch_url":"https://github.com/theforeman/foreman/pull/4937.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/4937","number":4937,"state":"open","locked":false,"title":"Fixes #21425 - host selection alert should refer to param per_page","user":{"login":"amirfefer","id":11807069,"avatar_url":"https://avatars2.githubusercontent.com/u/11807069?v=4","gravatar_id":"","url":"https://api.github.com/users/amirfefer","html_url":"https://github.com/amirfefer","followers_url":"https://api.github.com/users/amirfefer/followers","following_url":"https://api.github.com/users/amirfefer/following{/other_user}","gists_url":"https://api.github.com/users/amirfefer/gists{/gist_id}","starred_url":"https://api.github.com/users/amirfefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirfefer/subscriptions","organizations_url":"https://api.github.com/users/amirfefer/orgs","repos_url":"https://api.github.com/users/amirfefer/repos","events_url":"https://api.github.com/users/amirfefer/events{/privacy}","received_events_url":"https://api.github.com/users/amirfefer/received_events","type":"User","site_admin":false},"body":"Multiple host selection alert only mention settings[:per_page],\r\nthough pagination has been changed, now the user can change per_page via select box\r\n\r\nThis may lead to miscount hosts amount :\r\n![hosts_selection](https://user-images.githubusercontent.com/11807069/31888757-f48785e8-b805-11e7-90ee-7fba5e9bee0e.png)\r\n","created_at":"2017-10-23T12:26:06Z","updated_at":"2017-11-12T09:51:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d556a35bf1548378ae5ced104f82910b33352995","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/4937/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/4937/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/4937/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/7d903fb312f2fb54b1fdf182c02d47ceeb11f2a8","head":{"label":"amirfefer:21425","ref":"21425","sha":"7d903fb312f2fb54b1fdf182c02d47ceeb11f2a8","user":{"login":"amirfefer","id":11807069,"avatar_url":"https://avatars2.githubusercontent.com/u/11807069?v=4","gravatar_id":"","url":"https://api.github.com/users/amirfefer","html_url":"https://github.com/amirfefer","followers_url":"https://api.github.com/users/amirfefer/followers","following_url":"https://api.github.com/users/amirfefer/following{/other_user}","gists_url":"https://api.github.com/users/amirfefer/gists{/gist_id}","starred_url":"https://api.github.com/users/amirfefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirfefer/subscriptions","organizations_url":"https://api.github.com/users/amirfefer/orgs","repos_url":"https://api.github.com/users/amirfefer/repos","events_url":"https://api.github.com/users/amirfefer/events{/privacy}","received_events_url":"https://api.github.com/users/amirfefer/received_events","type":"User","site_admin":false},"repo":{"id":39390219,"name":"foreman","full_name":"amirfefer/foreman","owner":{"login":"amirfefer","id":11807069,"avatar_url":"https://avatars2.githubusercontent.com/u/11807069?v=4","gravatar_id":"","url":"https://api.github.com/users/amirfefer","html_url":"https://github.com/amirfefer","followers_url":"https://api.github.com/users/amirfefer/followers","following_url":"https://api.github.com/users/amirfefer/following{/other_user}","gists_url":"https://api.github.com/users/amirfefer/gists{/gist_id}","starred_url":"https://api.github.com/users/amirfefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirfefer/subscriptions","organizations_url":"https://api.github.com/users/amirfefer/orgs","repos_url":"https://api.github.com/users/amirfefer/repos","events_url":"https://api.github.com/users/amirfefer/events{/privacy}","received_events_url":"https://api.github.com/users/amirfefer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amirfefer/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/amirfefer/foreman","forks_url":"https://api.github.com/repos/amirfefer/foreman/forks","keys_url":"https://api.github.com/repos/amirfefer/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amirfefer/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amirfefer/foreman/teams","hooks_url":"https://api.github.com/repos/amirfefer/foreman/hooks","issue_events_url":"https://api.github.com/repos/amirfefer/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/amirfefer/foreman/events","assignees_url":"https://api.github.com/repos/amirfefer/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/amirfefer/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/amirfefer/foreman/tags","blobs_url":"https://api.github.com/repos/amirfefer/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amirfefer/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amirfefer/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/amirfefer/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amirfefer/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/amirfefer/foreman/languages","stargazers_url":"https://api.github.com/repos/amirfefer/foreman/stargazers","contributors_url":"https://api.github.com/repos/amirfefer/foreman/contributors","subscribers_url":"https://api.github.com/repos/amirfefer/foreman/subscribers","subscription_url":"https://api.github.com/repos/amirfefer/foreman/subscription","commits_url":"https://api.github.com/repos/amirfefer/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/amirfefer/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/amirfefer/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/amirfefer/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/amirfefer/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/amirfefer/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amirfefer/foreman/merges","archive_url":"https://api.github.com/repos/amirfefer/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amirfefer/foreman/downloads","issues_url":"https://api.github.com/repos/amirfefer/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/amirfefer/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/amirfefer/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/amirfefer/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amirfefer/foreman/labels{/name}","releases_url":"https://api.github.com/repos/amirfefer/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/amirfefer/foreman/deployments","created_at":"2015-07-20T14:57:37Z","updated_at":"2015-07-20T14:57:41Z","pushed_at":"2017-11-09T13:13:20Z","git_url":"git://github.com/amirfefer/foreman.git","ssh_url":"git@github.com:amirfefer/foreman.git","clone_url":"https://github.com/amirfefer/foreman.git","svn_url":"https://github.com/amirfefer/foreman","homepage":"http://theforeman.org","size":53860,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"7ab3f34668887e3035b6a8f799e2c180f8135381","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2017-11-09T21:53:55Z","pushed_at":"2017-11-12T09:34:46Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":62243,"stargazers_count":1318,"watchers_count":1318,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":649,"mirror_url":null,"archived":false,"open_issues_count":109,"forks":649,"open_issues":109,"watchers":1318,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/4937"},"html":{"href":"https://github.com/theforeman/foreman/pull/4937"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/4937"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/4937/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/4937/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/4937/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/7d903fb312f2fb54b1fdf182c02d47ceeb11f2a8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"amirfefer"}}