{"action":"closed","number":19164,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/19164","id":145787292,"html_url":"https://github.com/cockroachdb/cockroach/pull/19164","diff_url":"https://github.com/cockroachdb/cockroach/pull/19164.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/19164.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/19164","number":19164,"state":"closed","locked":false,"title":"storage: always handle Raft Ready before quiesce request","user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"body":"Fixes #19082.\r\n\r\nThe test was failing when a leader applied a request and immediately quiesced.\r\nThis was because the followers were batching the processing of the commit\r\n`MsgApp` (do we have a better name for this?) and the quiesce message. Since we\r\nnow defer the handling of Raft's `Ready` struct to the last request in a batch\r\n(#19056), we were letting the quiesce message decide if both messages should\r\nhandle the `Ready` state. Since the quiesce message returned early because it\r\ndoesn't need to handle the state, neither request ended up doing so. This\r\nresulted in the entry never applying.\r\n\r\nRight now this is a quick way to fix this specific flake, but there are other\r\nplaces where `processRaftRequest` can return early (with and without an error)\r\nand that may indicate that there are other times where we still need to handle\r\nRaft's `Ready` struct. We might need to maintain the condition\r\n`deferringRaftReadyHandling` state some other way to assure that it's performed\r\nwhenever any requests in the batch want it.","created_at":"2017-10-10T20:01:37Z","updated_at":"2017-10-12T19:58:49Z","closed_at":"2017-10-12T19:58:49Z","merged_at":"2017-10-12T19:58:49Z","merge_commit_sha":"28a231bb53278b7df3f78ea61a9a89fc742b45d3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"a-robinson","id":7085343,"avatar_url":"https://avatars3.githubusercontent.com/u/7085343?v=4","gravatar_id":"","url":"https://api.github.com/users/a-robinson","html_url":"https://github.com/a-robinson","followers_url":"https://api.github.com/users/a-robinson/followers","following_url":"https://api.github.com/users/a-robinson/following{/other_user}","gists_url":"https://api.github.com/users/a-robinson/gists{/gist_id}","starred_url":"https://api.github.com/users/a-robinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-robinson/subscriptions","organizations_url":"https://api.github.com/users/a-robinson/orgs","repos_url":"https://api.github.com/users/a-robinson/repos","events_url":"https://api.github.com/users/a-robinson/events{/privacy}","received_events_url":"https://api.github.com/users/a-robinson/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/19164/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/19164/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/19164/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/9e79ce6c619df9b6632f1e3299ecdb0a030551d0","head":{"label":"nvanbenschoten:nvanbenschoten/fixRangeScan","ref":"nvanbenschoten/fixRangeScan","sha":"9e79ce6c619df9b6632f1e3299ecdb0a030551d0","user":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"repo":{"id":42610470,"name":"cockroach","full_name":"nvanbenschoten/cockroach","owner":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nvanbenschoten/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/nvanbenschoten/cockroach","forks_url":"https://api.github.com/repos/nvanbenschoten/cockroach/forks","keys_url":"https://api.github.com/repos/nvanbenschoten/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvanbenschoten/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvanbenschoten/cockroach/teams","hooks_url":"https://api.github.com/repos/nvanbenschoten/cockroach/hooks","issue_events_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/nvanbenschoten/cockroach/events","assignees_url":"https://api.github.com/repos/nvanbenschoten/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/nvanbenschoten/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/nvanbenschoten/cockroach/tags","blobs_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvanbenschoten/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/nvanbenschoten/cockroach/languages","stargazers_url":"https://api.github.com/repos/nvanbenschoten/cockroach/stargazers","contributors_url":"https://api.github.com/repos/nvanbenschoten/cockroach/contributors","subscribers_url":"https://api.github.com/repos/nvanbenschoten/cockroach/subscribers","subscription_url":"https://api.github.com/repos/nvanbenschoten/cockroach/subscription","commits_url":"https://api.github.com/repos/nvanbenschoten/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvanbenschoten/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvanbenschoten/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvanbenschoten/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/nvanbenschoten/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvanbenschoten/cockroach/merges","archive_url":"https://api.github.com/repos/nvanbenschoten/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvanbenschoten/cockroach/downloads","issues_url":"https://api.github.com/repos/nvanbenschoten/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/nvanbenschoten/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/nvanbenschoten/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/nvanbenschoten/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvanbenschoten/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/nvanbenschoten/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/nvanbenschoten/cockroach/deployments","created_at":"2015-09-16T20:04:21Z","updated_at":"2016-01-13T21:23:53Z","pushed_at":"2017-10-12T09:10:22Z","git_url":"git://github.com/nvanbenschoten/cockroach.git","ssh_url":"git@github.com:nvanbenschoten/cockroach.git","clone_url":"https://github.com/nvanbenschoten/cockroach.git","svn_url":"https://github.com/nvanbenschoten/cockroach","homepage":null,"size":462089,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"359532ca24405996b21d0a8ab6e6c5549dde60b6","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2017-10-12T18:50:50Z","pushed_at":"2017-10-12T19:58:49Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":870961,"stargazers_count":11264,"watchers_count":11264,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1119,"mirror_url":null,"open_issues_count":1275,"forks":1119,"open_issues":1275,"watchers":11264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/19164"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/19164"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/19164"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/19164/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/19164/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/19164/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/9e79ce6c619df9b6632f1e3299ecdb0a030551d0"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nvanbenschoten","id":5438456,"avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":321,"deletions":227,"changed_files":4}}
{"actor":{"display_login":"nvanbenschoten"}}