{"action":"created","issue":{"url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/8","repository_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI","labels_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/8/comments","events_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/8/events","html_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/8","id":208911127,"number":8,"title":"Fixing variable naming mismatch","user":{"login":"pedroserano","id":12992264,"avatar_url":"https://avatars.githubusercontent.com/u/12992264?v=3","gravatar_id":"","url":"https://api.github.com/users/pedroserano","html_url":"https://github.com/pedroserano","followers_url":"https://api.github.com/users/pedroserano/followers","following_url":"https://api.github.com/users/pedroserano/following{/other_user}","gists_url":"https://api.github.com/users/pedroserano/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroserano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroserano/subscriptions","organizations_url":"https://api.github.com/users/pedroserano/orgs","repos_url":"https://api.github.com/users/pedroserano/repos","events_url":"https://api.github.com/users/pedroserano/events{/privacy}","received_events_url":"https://api.github.com/users/pedroserano/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-20T15:26:30Z","updated_at":"2017-02-23T08:33:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/pulls/8","html_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/8","diff_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/8.diff","patch_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/8.patch"},"body":"Fixes the undefined call problem when calling for isOccupied for both js scripts and the homebridge plugin - the variable works when the name 'sensor' matches 'sensor' - like the other functions of the fan (light, fan, etc all match their variables)."},"comment":{"url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/comments/281928159","html_url":"https://github.com/sean9keenan/BigAssFansAPI/pull/8#issuecomment-281928159","issue_url":"https://api.github.com/repos/sean9keenan/BigAssFansAPI/issues/8","id":281928159,"user":{"login":"sean9keenan","id":2107356,"avatar_url":"https://avatars.githubusercontent.com/u/2107356?v=3","gravatar_id":"","url":"https://api.github.com/users/sean9keenan","html_url":"https://github.com/sean9keenan","followers_url":"https://api.github.com/users/sean9keenan/followers","following_url":"https://api.github.com/users/sean9keenan/following{/other_user}","gists_url":"https://api.github.com/users/sean9keenan/gists{/gist_id}","starred_url":"https://api.github.com/users/sean9keenan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sean9keenan/subscriptions","organizations_url":"https://api.github.com/users/sean9keenan/orgs","repos_url":"https://api.github.com/users/sean9keenan/repos","events_url":"https://api.github.com/users/sean9keenan/events{/privacy}","received_events_url":"https://api.github.com/users/sean9keenan/received_events","type":"User","site_admin":false},"created_at":"2017-02-23T08:33:09Z","updated_at":"2017-02-23T08:33:09Z","body":"Ahhh, awesome! Thanks for catching this, I see you also have a PR in the corresponding Homebridge API! As soon as this gets merged in I'll promote it on NPM and then merge in the Homebridge one.\r\n\r\nTwo quick things:\r\n\r\n- Did you test the `smartmodeactual` or `smartmodestate` functions? It's possible that those are supposed to be their own `smartmode` property (and I just _completely_ messed up that section of the code) - but I forget what the dump from wireshark looks like, so it's possible that they are under the `sensor`.\r\n- It's not a huge deal - but I figure I'd mention it because some people really care: It's good practice to squash your commits just to make the commit history cleaner.\r\n\r\nIn case you haven't done this before: The way I normally do this is by running `git rebase --interactive` (Passing in the commit you want to go back to), eg in this case you can do `git rebase --interactive \tc49882c` and then either squash your commits or just pick the last one. And then pushing the branch again - but this time since you've changed the history you'll have to push with `--force`. If you do this it will automatically update the history on this PR, even though you've changed the history."}}
{"actor":{"display_login":"sean9keenan"}}