{"action":"created","comment":{"url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/comments/120873862","pull_request_review_id":42873930,"id":120873862,"diff_hunk":"@@ -79,8 +97,14 @@ def _update(self, provider, update):\n             except KeyError:\n                 logger.warning('missing move_path')\n                 move_dest_path = None\n+            try:\n+                move_dest_path_error = os.path.join(config.get('path', ''), config['move_path_error'])","path":"superdesk/io/feeding_services/ftp.py","position":30,"original_position":30,"commit_id":"f319e41952c4268d87549d31c6159d04fe814378","original_commit_id":"9de470bd84ab18a8fff755e7f4ef3e0fcbc5dc48","user":{"login":"jerome-poisson","id":18259501,"avatar_url":"https://avatars3.githubusercontent.com/u/18259501?v=3","gravatar_id":"","url":"https://api.github.com/users/jerome-poisson","html_url":"https://github.com/jerome-poisson","followers_url":"https://api.github.com/users/jerome-poisson/followers","following_url":"https://api.github.com/users/jerome-poisson/following{/other_user}","gists_url":"https://api.github.com/users/jerome-poisson/gists{/gist_id}","starred_url":"https://api.github.com/users/jerome-poisson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerome-poisson/subscriptions","organizations_url":"https://api.github.com/users/jerome-poisson/orgs","repos_url":"https://api.github.com/users/jerome-poisson/repos","events_url":"https://api.github.com/users/jerome-poisson/events{/privacy}","received_events_url":"https://api.github.com/users/jerome-poisson/received_events","type":"User","site_admin":false},"body":"it has not been requested, I just thought one may want to move on success but not on error, but I may be wrong.","created_at":"2017-06-08T12:26:57Z","updated_at":"2017-06-08T12:26:57Z","html_url":"https://github.com/superdesk/superdesk-core/pull/953#discussion_r120873862","pull_request_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/953","_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/comments/120873862"},"html":{"href":"https://github.com/superdesk/superdesk-core/pull/953#discussion_r120873862"},"pull_request":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/953"}}},"pull_request":{"url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/953","id":124433026,"html_url":"https://github.com/superdesk/superdesk-core/pull/953","diff_url":"https://github.com/superdesk/superdesk-core/pull/953.diff","patch_url":"https://github.com/superdesk/superdesk-core/pull/953.patch","issue_url":"https://api.github.com/repos/superdesk/superdesk-core/issues/953","number":953,"state":"open","locked":false,"title":"[INGEST] [FEEDING SERVICE] [FTP] better failure handling","user":{"login":"jerome-poisson","id":18259501,"avatar_url":"https://avatars3.githubusercontent.com/u/18259501?v=3","gravatar_id":"","url":"https://api.github.com/users/jerome-poisson","html_url":"https://github.com/jerome-poisson","followers_url":"https://api.github.com/users/jerome-poisson/followers","following_url":"https://api.github.com/users/jerome-poisson/following{/other_user}","gists_url":"https://api.github.com/users/jerome-poisson/gists{/gist_id}","starred_url":"https://api.github.com/users/jerome-poisson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerome-poisson/subscriptions","organizations_url":"https://api.github.com/users/jerome-poisson/orgs","repos_url":"https://api.github.com/users/jerome-poisson/repos","events_url":"https://api.github.com/users/jerome-poisson/events{/privacy}","received_events_url":"https://api.github.com/users/jerome-poisson/received_events","type":"User","site_admin":false},"body":"FTP feeding service was failing the whole ingestion if one file could\r\nnot be ingested e.g. because of parsing error. This commit fixes it.\r\n\r\nIn addition, the new move path on error feature is handled: if a file\r\ncan't be ingested, and the move is activated and move path error is set,\r\nthe file will be moved to the requested directory.\r\n\r\nSDESK-1452","created_at":"2017-06-07T14:22:33Z","updated_at":"2017-06-08T12:26:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31a157cc3fd766027029162687a2c8981a65ec76","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/superdesk/superdesk-core/milestones/11","html_url":"https://github.com/superdesk/superdesk-core/milestone/11","labels_url":"https://api.github.com/repos/superdesk/superdesk-core/milestones/11/labels","id":2561467,"number":11,"title":"1.9","description":"","creator":{"login":"petrjasek","id":179249,"avatar_url":"https://avatars2.githubusercontent.com/u/179249?v=3","gravatar_id":"","url":"https://api.github.com/users/petrjasek","html_url":"https://github.com/petrjasek","followers_url":"https://api.github.com/users/petrjasek/followers","following_url":"https://api.github.com/users/petrjasek/following{/other_user}","gists_url":"https://api.github.com/users/petrjasek/gists{/gist_id}","starred_url":"https://api.github.com/users/petrjasek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrjasek/subscriptions","organizations_url":"https://api.github.com/users/petrjasek/orgs","repos_url":"https://api.github.com/users/petrjasek/repos","events_url":"https://api.github.com/users/petrjasek/events{/privacy}","received_events_url":"https://api.github.com/users/petrjasek/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2017-06-05T08:28:02Z","updated_at":"2017-06-08T06:37:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/953/commits","review_comments_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/953/comments","review_comment_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superdesk/superdesk-core/issues/953/comments","statuses_url":"https://api.github.com/repos/superdesk/superdesk-core/statuses/f319e41952c4268d87549d31c6159d04fe814378","head":{"label":"jerome-poisson:SDESK-1452","ref":"SDESK-1452","sha":"f319e41952c4268d87549d31c6159d04fe814378","user":{"login":"jerome-poisson","id":18259501,"avatar_url":"https://avatars3.githubusercontent.com/u/18259501?v=3","gravatar_id":"","url":"https://api.github.com/users/jerome-poisson","html_url":"https://github.com/jerome-poisson","followers_url":"https://api.github.com/users/jerome-poisson/followers","following_url":"https://api.github.com/users/jerome-poisson/following{/other_user}","gists_url":"https://api.github.com/users/jerome-poisson/gists{/gist_id}","starred_url":"https://api.github.com/users/jerome-poisson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerome-poisson/subscriptions","organizations_url":"https://api.github.com/users/jerome-poisson/orgs","repos_url":"https://api.github.com/users/jerome-poisson/repos","events_url":"https://api.github.com/users/jerome-poisson/events{/privacy}","received_events_url":"https://api.github.com/users/jerome-poisson/received_events","type":"User","site_admin":false},"repo":{"id":55399604,"name":"superdesk-core","full_name":"jerome-poisson/superdesk-core","owner":{"login":"jerome-poisson","id":18259501,"avatar_url":"https://avatars3.githubusercontent.com/u/18259501?v=3","gravatar_id":"","url":"https://api.github.com/users/jerome-poisson","html_url":"https://github.com/jerome-poisson","followers_url":"https://api.github.com/users/jerome-poisson/followers","following_url":"https://api.github.com/users/jerome-poisson/following{/other_user}","gists_url":"https://api.github.com/users/jerome-poisson/gists{/gist_id}","starred_url":"https://api.github.com/users/jerome-poisson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerome-poisson/subscriptions","organizations_url":"https://api.github.com/users/jerome-poisson/orgs","repos_url":"https://api.github.com/users/jerome-poisson/repos","events_url":"https://api.github.com/users/jerome-poisson/events{/privacy}","received_events_url":"https://api.github.com/users/jerome-poisson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jerome-poisson/superdesk-core","description":"common server modules for superdesk","fork":true,"url":"https://api.github.com/repos/jerome-poisson/superdesk-core","forks_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/forks","keys_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/teams","hooks_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/hooks","issue_events_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/issues/events{/number}","events_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/events","assignees_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/assignees{/user}","branches_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/branches{/branch}","tags_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/tags","blobs_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/languages","stargazers_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/stargazers","contributors_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/contributors","subscribers_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/subscribers","subscription_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/subscription","commits_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/contents/{+path}","compare_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/merges","archive_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/downloads","issues_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/issues{/number}","pulls_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/labels{/name}","releases_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/releases{/id}","deployments_url":"https://api.github.com/repos/jerome-poisson/superdesk-core/deployments","created_at":"2016-04-04T09:35:09Z","updated_at":"2016-04-04T09:35:11Z","pushed_at":"2017-06-08T08:08:53Z","git_url":"git://github.com/jerome-poisson/superdesk-core.git","ssh_url":"git@github.com:jerome-poisson/superdesk-core.git","clone_url":"https://github.com/jerome-poisson/superdesk-core.git","svn_url":"https://github.com/jerome-poisson/superdesk-core","homepage":"","size":9574,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superdesk:master","ref":"master","sha":"82bc40e9f5c19fc4f25801333df6af5a8aa1018e","user":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars1.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"repo":{"id":41092776,"name":"superdesk-core","full_name":"superdesk/superdesk-core","owner":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars1.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superdesk/superdesk-core","description":"Common server modules for superdesk","fork":false,"url":"https://api.github.com/repos/superdesk/superdesk-core","forks_url":"https://api.github.com/repos/superdesk/superdesk-core/forks","keys_url":"https://api.github.com/repos/superdesk/superdesk-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superdesk/superdesk-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superdesk/superdesk-core/teams","hooks_url":"https://api.github.com/repos/superdesk/superdesk-core/hooks","issue_events_url":"https://api.github.com/repos/superdesk/superdesk-core/issues/events{/number}","events_url":"https://api.github.com/repos/superdesk/superdesk-core/events","assignees_url":"https://api.github.com/repos/superdesk/superdesk-core/assignees{/user}","branches_url":"https://api.github.com/repos/superdesk/superdesk-core/branches{/branch}","tags_url":"https://api.github.com/repos/superdesk/superdesk-core/tags","blobs_url":"https://api.github.com/repos/superdesk/superdesk-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superdesk/superdesk-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superdesk/superdesk-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/superdesk/superdesk-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superdesk/superdesk-core/statuses/{sha}","languages_url":"https://api.github.com/repos/superdesk/superdesk-core/languages","stargazers_url":"https://api.github.com/repos/superdesk/superdesk-core/stargazers","contributors_url":"https://api.github.com/repos/superdesk/superdesk-core/contributors","subscribers_url":"https://api.github.com/repos/superdesk/superdesk-core/subscribers","subscription_url":"https://api.github.com/repos/superdesk/superdesk-core/subscription","commits_url":"https://api.github.com/repos/superdesk/superdesk-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/superdesk/superdesk-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/superdesk/superdesk-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/superdesk/superdesk-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/superdesk/superdesk-core/contents/{+path}","compare_url":"https://api.github.com/repos/superdesk/superdesk-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superdesk/superdesk-core/merges","archive_url":"https://api.github.com/repos/superdesk/superdesk-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superdesk/superdesk-core/downloads","issues_url":"https://api.github.com/repos/superdesk/superdesk-core/issues{/number}","pulls_url":"https://api.github.com/repos/superdesk/superdesk-core/pulls{/number}","milestones_url":"https://api.github.com/repos/superdesk/superdesk-core/milestones{/number}","notifications_url":"https://api.github.com/repos/superdesk/superdesk-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superdesk/superdesk-core/labels{/name}","releases_url":"https://api.github.com/repos/superdesk/superdesk-core/releases{/id}","deployments_url":"https://api.github.com/repos/superdesk/superdesk-core/deployments","created_at":"2015-08-20T11:46:19Z","updated_at":"2017-03-19T05:16:10Z","pushed_at":"2017-06-08T08:08:55Z","git_url":"git://github.com/superdesk/superdesk-core.git","ssh_url":"git@github.com:superdesk/superdesk-core.git","clone_url":"https://github.com/superdesk/superdesk-core.git","svn_url":"https://github.com/superdesk/superdesk-core","homepage":"https://superdesk.readthedocs.io/","size":9730,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":5,"forks":35,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/953"},"html":{"href":"https://github.com/superdesk/superdesk-core/pull/953"},"issue":{"href":"https://api.github.com/repos/superdesk/superdesk-core/issues/953"},"comments":{"href":"https://api.github.com/repos/superdesk/superdesk-core/issues/953/comments"},"review_comments":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/953/comments"},"review_comment":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superdesk/superdesk-core/pulls/953/commits"},"statuses":{"href":"https://api.github.com/repos/superdesk/superdesk-core/statuses/f319e41952c4268d87549d31c6159d04fe814378"}}}}
{"actor":{"display_login":"jerome-poisson"}}