{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/vic/issues/6370","repository_url":"https://api.github.com/repos/vmware/vic","labels_url":"https://api.github.com/repos/vmware/vic/issues/6370/labels{/name}","comments_url":"https://api.github.com/repos/vmware/vic/issues/6370/comments","events_url":"https://api.github.com/repos/vmware/vic/issues/6370/events","html_url":"https://github.com/vmware/vic/issues/6370","id":258150208,"number":6370,"title":"Docker exec following a docker restart of a node container results in unknown task ID error","user":{"login":"mhagen-vmware","id":19393273,"avatar_url":"https://avatars0.githubusercontent.com/u/19393273?v=4","gravatar_id":"","url":"https://api.github.com/users/mhagen-vmware","html_url":"https://github.com/mhagen-vmware","followers_url":"https://api.github.com/users/mhagen-vmware/followers","following_url":"https://api.github.com/users/mhagen-vmware/following{/other_user}","gists_url":"https://api.github.com/users/mhagen-vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/mhagen-vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhagen-vmware/subscriptions","organizations_url":"https://api.github.com/users/mhagen-vmware/orgs","repos_url":"https://api.github.com/users/mhagen-vmware/repos","events_url":"https://api.github.com/users/mhagen-vmware/events{/privacy}","received_events_url":"https://api.github.com/users/mhagen-vmware/received_events","type":"User","site_admin":false},"labels":[{"id":310959982,"url":"https://api.github.com/repos/vmware/vic/labels/kind/bug","name":"kind/bug","color":"bfd4f2","default":false},{"id":465799667,"url":"https://api.github.com/repos/vmware/vic/labels/kind/customer-found","name":"kind/customer-found","color":"bfd4f2","default":false},{"id":520246519,"url":"https://api.github.com/repos/vmware/vic/labels/priority/high","name":"priority/high","color":"b60205","default":false},{"id":680163399,"url":"https://api.github.com/repos/vmware/vic/labels/team/foundation","name":"team/foundation","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"matthewavery","id":8620942,"avatar_url":"https://avatars2.githubusercontent.com/u/8620942?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewavery","html_url":"https://github.com/matthewavery","followers_url":"https://api.github.com/users/matthewavery/followers","following_url":"https://api.github.com/users/matthewavery/following{/other_user}","gists_url":"https://api.github.com/users/matthewavery/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewavery/subscriptions","organizations_url":"https://api.github.com/users/matthewavery/orgs","repos_url":"https://api.github.com/users/matthewavery/repos","events_url":"https://api.github.com/users/matthewavery/events{/privacy}","received_events_url":"https://api.github.com/users/matthewavery/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewavery","id":8620942,"avatar_url":"https://avatars2.githubusercontent.com/u/8620942?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewavery","html_url":"https://github.com/matthewavery","followers_url":"https://api.github.com/users/matthewavery/followers","following_url":"https://api.github.com/users/matthewavery/following{/other_user}","gists_url":"https://api.github.com/users/matthewavery/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewavery/subscriptions","organizations_url":"https://api.github.com/users/matthewavery/orgs","repos_url":"https://api.github.com/users/matthewavery/repos","events_url":"https://api.github.com/users/matthewavery/events{/privacy}","received_events_url":"https://api.github.com/users/matthewavery/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vmware/vic/milestones/86","html_url":"https://github.com/vmware/vic/milestone/86","labels_url":"https://api.github.com/repos/vmware/vic/milestones/86/labels","id":2864915,"number":86,"title":"Sprint 20 Foundation","description":"High Priority Issues, ops-user","creator":{"login":"cgtexmex","id":726112,"avatar_url":"https://avatars2.githubusercontent.com/u/726112?v=4","gravatar_id":"","url":"https://api.github.com/users/cgtexmex","html_url":"https://github.com/cgtexmex","followers_url":"https://api.github.com/users/cgtexmex/followers","following_url":"https://api.github.com/users/cgtexmex/following{/other_user}","gists_url":"https://api.github.com/users/cgtexmex/gists{/gist_id}","starred_url":"https://api.github.com/users/cgtexmex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgtexmex/subscriptions","organizations_url":"https://api.github.com/users/cgtexmex/orgs","repos_url":"https://api.github.com/users/cgtexmex/repos","events_url":"https://api.github.com/users/cgtexmex/events{/privacy}","received_events_url":"https://api.github.com/users/cgtexmex/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":5,"state":"open","created_at":"2017-10-25T14:29:30Z","updated_at":"2017-11-13T18:26:09Z","due_on":"2017-11-08T08:00:00Z","closed_at":null},"comments":14,"created_at":"2017-09-15T20:05:35Z","updated_at":"2017-11-14T00:15:12Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"```\r\nanon@anon-Latitude-E7450:~/vic$ docker -H 192.168.254.178:2376 --tls restart node1\r\nnode1\r\nanon@anon-Latitude-E7450:~/vic$ docker -H 192.168.254.178:2376 --tls exec -it node1 /bin/bash\r\nServer error from portlayer: Unknown task ID: e76d137a9d9d136cffd1353f6c902d571a14b2abdaeb8220868fe0408d607739\r\nError response from daemon: Server error from portlayer: [GET /tasks][500] inspectInternalServerError  &{Code:0 Message:unknown task ID: e76d137a9d9d136cffd1353f6c902d571a14b2abdaeb8220868fe0408d607739}\r\n```\r\n\r\n[container-logs.zip](https://github.com/vmware/vic/files/1307639/container-logs.zip)\r\n"},"comment":{"url":"https://api.github.com/repos/vmware/vic/issues/comments/344102761","html_url":"https://github.com/vmware/vic/issues/6370#issuecomment-344102761","issue_url":"https://api.github.com/repos/vmware/vic/issues/6370","id":344102761,"user":{"login":"matthewavery","id":8620942,"avatar_url":"https://avatars2.githubusercontent.com/u/8620942?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewavery","html_url":"https://github.com/matthewavery","followers_url":"https://api.github.com/users/matthewavery/followers","following_url":"https://api.github.com/users/matthewavery/following{/other_user}","gists_url":"https://api.github.com/users/matthewavery/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewavery/subscriptions","organizations_url":"https://api.github.com/users/matthewavery/orgs","repos_url":"https://api.github.com/users/matthewavery/repos","events_url":"https://api.github.com/users/matthewavery/events{/privacy}","received_events_url":"https://api.github.com/users/matthewavery/received_events","type":"User","site_admin":false},"created_at":"2017-11-14T00:15:12Z","updated_at":"2017-11-14T00:15:12Z","author_association":"CONTRIBUTOR","body":"per a deep anlysis with @hickeng : \r\n\r\n```\r\n\r\nTHINGS TO DO:\r\n\r\n1. Move TASKINSPECT to container proxy and update the call to use the same handle as everything else in Container Exec Start. TaskInspection should go in the retry with everything else. and the handle should be retrieved above that. \r\n\r\n2. make sure everything in start is moved to be inside the retry. If we get a concurrent mod error then we must try everything from scratch with a new handle. \r\n\r\n3. We need to change TaskInspect from the portlayer perspective to behave like this: \r\n\r\nfunc Inspect(op *trace.Operation, h interface{}, id string) (*executor.SessionConfig, error) {\r\n    defer trace.End(trace.Begin(id))\r\n\r\n    handle, ok := h.(*exec.Handle)\r\n    if !ok {\r\n        return nil, fmt.Errorf(\"Type assertion failed for %#+v\", handle)\r\n    }\r\n\r\n    stasks := handle.ExecConfig.Sessions\r\n    etasks := handle.ExecConfig.Execs\r\n\r\n    op.Debugf(\"target task ID: %s\", id)\r\n    op.Debugf(\"session tasks during inspect: %s\", stasks)\r\n    op.Debugf(\"exec tasks during inspect: %s\", etasks)\r\n\r\n    if _, ok := stasks[id]; ok {\r\n        return stasks[id], nil\r\n    }\r\n\r\n    if _, ok := etasks[id]; ok {\r\n        return etasks[id], nil\r\n    }\r\n\r\n    return nil, fmt.Errorf(\"Cannot find task %s\", id)\r\n}\r\n\r\n4. IMPORTANT: if TaskInspect gives us a 404 we must properly interpret this in the personality. ExecTaskInspect --> 404 --> likely the container was turned off. That should be the order of interpretation. \r\n\r\n5. We need to handle concurrent modification errors properly in the exec path... We cannot just throw the entire packaged error into a `500` error string. \r\n\r\n6. more to come... from notes on my desk... \r\n```"}}
{"actor":{"display_login":"matthewavery"}}