{"action":"created","issue":{"url":"https://api.github.com/repos/robisim74/angular-library-starter/issues/16","repository_url":"https://api.github.com/repos/robisim74/angular-library-starter","labels_url":"https://api.github.com/repos/robisim74/angular-library-starter/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/robisim74/angular-library-starter/issues/16/comments","events_url":"https://api.github.com/repos/robisim74/angular-library-starter/issues/16/events","html_url":"https://github.com/robisim74/angular-library-starter/issues/16","id":240441193,"number":16,"title":"Dependency with angular-cli","user":{"login":"jotak","id":2153442,"avatar_url":"https://avatars2.githubusercontent.com/u/2153442?v=3","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-04T14:45:57Z","updated_at":"2017-07-04T19:59:53Z","closed_at":null,"body":"Hi,\r\n\r\nThe doc says there's nothing to do while loading the built library from angular-cli. However we need to configure all external dependencies in the downstream app' .angular-cli.json, no? Or maybe there's something I'm doing wrong.\r\n\r\nBasically I use this library-starter to build a component library, and need moment.js imported. My downstream app doesn't explicitly require moment.js, it's just needed for the library. But if I don't manually add the link in angular-cli.json it won't load it. So, am I missing something, or is it like I suspect, all 'transitive' dependencies must be explicitly linked downstream?"},"comment":{"url":"https://api.github.com/repos/robisim74/angular-library-starter/issues/comments/312942436","html_url":"https://github.com/robisim74/angular-library-starter/issues/16#issuecomment-312942436","issue_url":"https://api.github.com/repos/robisim74/angular-library-starter/issues/16","id":312942436,"user":{"login":"robisim74","id":14012361,"avatar_url":"https://avatars0.githubusercontent.com/u/14012361?v=3","gravatar_id":"","url":"https://api.github.com/users/robisim74","html_url":"https://github.com/robisim74","followers_url":"https://api.github.com/users/robisim74/followers","following_url":"https://api.github.com/users/robisim74/following{/other_user}","gists_url":"https://api.github.com/users/robisim74/gists{/gist_id}","starred_url":"https://api.github.com/users/robisim74/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robisim74/subscriptions","organizations_url":"https://api.github.com/users/robisim74/orgs","repos_url":"https://api.github.com/users/robisim74/repos","events_url":"https://api.github.com/users/robisim74/events{/privacy}","received_events_url":"https://api.github.com/users/robisim74/received_events","type":"User","site_admin":false},"created_at":"2017-07-04T19:59:53Z","updated_at":"2017-07-04T19:59:53Z","body":"> we need to configure all external dependencies in the downstream app angular-cli.json\r\n\r\nNo, you don't need, just import what you need:\r\n`import { ArithmeticModule } from 'angular-library-starter';`\r\n\r\nIf your library depends on a javascript library (_moment.js_), you need a further configuration: here you can find an example: https://github.com/damienbod/angular-auth-oidc-client. In this library, we manage a javascript library (jsrsasign): see in particular what was done in the _package.json_ and _rollup.config.js_ files. But maybe with _moment.js_ it is still different if it provides the typescript definition file.\r\n\r\nIn any case the host app must install the javascript library, unless you do not want to include it in your  library (not recommended).\r\n\r\nGreetings"}}
{"actor":{"display_login":"robisim74"}}