{"action":"created","comment":{"url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/comments/156526774","pull_request_review_id":83019241,"id":156526774,"diff_hunk":"@@ -0,0 +1,24 @@\n+#pragma once\n+\n+#include <QJsonObject>\n+\n+#include \"network.hpp\"\n+#include \"serverconnection.hpp\"\n+#include \"server.hpp\"\n+\n+class SendAfter : public QThread {","path":"include/network/SendAfter.hpp","position":null,"original_position":9,"commit_id":"7e9965eb6fdd99b65316c9cf6df4487b2c8cd8db","original_commit_id":"74a8a19126af5fd6ebbb43d9d82e63983376e360","user":{"login":"FooB4r","id":18214834,"avatar_url":"https://avatars3.githubusercontent.com/u/18214834?v=4","gravatar_id":"","url":"https://api.github.com/users/FooB4r","html_url":"https://github.com/FooB4r","followers_url":"https://api.github.com/users/FooB4r/followers","following_url":"https://api.github.com/users/FooB4r/following{/other_user}","gists_url":"https://api.github.com/users/FooB4r/gists{/gist_id}","starred_url":"https://api.github.com/users/FooB4r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FooB4r/subscriptions","organizations_url":"https://api.github.com/users/FooB4r/orgs","repos_url":"https://api.github.com/users/FooB4r/repos","events_url":"https://api.github.com/users/FooB4r/events{/privacy}","received_events_url":"https://api.github.com/users/FooB4r/received_events","type":"User","site_admin":false},"body":"Well i wrote `delete this` in my code, i can now RIP","created_at":"2017-12-12T23:31:23Z","updated_at":"2017-12-12T23:31:24Z","html_url":"https://github.com/fanfaresimulator/fanfaresimulator/pull/39#discussion_r156526774","pull_request_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/comments/156526774"},"html":{"href":"https://github.com/fanfaresimulator/fanfaresimulator/pull/39#discussion_r156526774"},"pull_request":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/39"}},"in_reply_to_id":156512069},"pull_request":{"url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/39","id":157950732,"html_url":"https://github.com/fanfaresimulator/fanfaresimulator/pull/39","diff_url":"https://github.com/fanfaresimulator/fanfaresimulator/pull/39.diff","patch_url":"https://github.com/fanfaresimulator/fanfaresimulator/pull/39.patch","issue_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues/39","number":39,"state":"open","locked":false,"title":"Ping Fix Issue#35","user":{"login":"FooB4r","id":18214834,"avatar_url":"https://avatars3.githubusercontent.com/u/18214834?v=4","gravatar_id":"","url":"https://api.github.com/users/FooB4r","html_url":"https://github.com/FooB4r","followers_url":"https://api.github.com/users/FooB4r/followers","following_url":"https://api.github.com/users/FooB4r/following{/other_user}","gists_url":"https://api.github.com/users/FooB4r/gists{/gist_id}","starred_url":"https://api.github.com/users/FooB4r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FooB4r/subscriptions","organizations_url":"https://api.github.com/users/FooB4r/orgs","repos_url":"https://api.github.com/users/FooB4r/repos","events_url":"https://api.github.com/users/FooB4r/events{/privacy}","received_events_url":"https://api.github.com/users/FooB4r/received_events","type":"User","site_admin":false},"body":"Well Added 2 classes \r\n- DelayEstimator which determines an average ping for each player\r\n- SendAfter that allow for synchronous messages\r\n\r\nThere are still some problems remaining \r\n- When the game starts, the cilents don't receive the pings (maybe due to engine ?), the server is still sending though\r\n- I had to comment this line in network/server.cpp, because delete later caused segfault when the client disconnected, problem is now \r\n```\r\nconnect(clientConnection, &QAbstractSocket::disconnected, clientConnection, &QObject::deleteLater);\r\n```\r\n\r\n","created_at":"2017-12-12T22:01:03Z","updated_at":"2017-12-12T23:31:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a57bbddb9fc61dee76467a99adece37c86016b27","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sathouel","id":17556843,"avatar_url":"https://avatars1.githubusercontent.com/u/17556843?v=4","gravatar_id":"","url":"https://api.github.com/users/sathouel","html_url":"https://github.com/sathouel","followers_url":"https://api.github.com/users/sathouel/followers","following_url":"https://api.github.com/users/sathouel/following{/other_user}","gists_url":"https://api.github.com/users/sathouel/gists{/gist_id}","starred_url":"https://api.github.com/users/sathouel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathouel/subscriptions","organizations_url":"https://api.github.com/users/sathouel/orgs","repos_url":"https://api.github.com/users/sathouel/repos","events_url":"https://api.github.com/users/sathouel/events{/privacy}","received_events_url":"https://api.github.com/users/sathouel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/39/commits","review_comments_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/39/comments","review_comment_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues/39/comments","statuses_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/statuses/7e9965eb6fdd99b65316c9cf6df4487b2c8cd8db","head":{"label":"fanfaresimulator:ping#35","ref":"ping#35","sha":"7e9965eb6fdd99b65316c9cf6df4487b2c8cd8db","user":{"login":"fanfaresimulator","id":33068970,"avatar_url":"https://avatars1.githubusercontent.com/u/33068970?v=4","gravatar_id":"","url":"https://api.github.com/users/fanfaresimulator","html_url":"https://github.com/fanfaresimulator","followers_url":"https://api.github.com/users/fanfaresimulator/followers","following_url":"https://api.github.com/users/fanfaresimulator/following{/other_user}","gists_url":"https://api.github.com/users/fanfaresimulator/gists{/gist_id}","starred_url":"https://api.github.com/users/fanfaresimulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanfaresimulator/subscriptions","organizations_url":"https://api.github.com/users/fanfaresimulator/orgs","repos_url":"https://api.github.com/users/fanfaresimulator/repos","events_url":"https://api.github.com/users/fanfaresimulator/events{/privacy}","received_events_url":"https://api.github.com/users/fanfaresimulator/received_events","type":"Organization","site_admin":false},"repo":{"id":108316453,"name":"fanfaresimulator","full_name":"fanfaresimulator/fanfaresimulator","owner":{"login":"fanfaresimulator","id":33068970,"avatar_url":"https://avatars1.githubusercontent.com/u/33068970?v=4","gravatar_id":"","url":"https://api.github.com/users/fanfaresimulator","html_url":"https://github.com/fanfaresimulator","followers_url":"https://api.github.com/users/fanfaresimulator/followers","following_url":"https://api.github.com/users/fanfaresimulator/following{/other_user}","gists_url":"https://api.github.com/users/fanfaresimulator/gists{/gist_id}","starred_url":"https://api.github.com/users/fanfaresimulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanfaresimulator/subscriptions","organizations_url":"https://api.github.com/users/fanfaresimulator/orgs","repos_url":"https://api.github.com/users/fanfaresimulator/repos","events_url":"https://api.github.com/users/fanfaresimulator/events{/privacy}","received_events_url":"https://api.github.com/users/fanfaresimulator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fanfaresimulator/fanfaresimulator","description":"Fanfare Simulator 2k (name subject to change)","fork":false,"url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator","forks_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/forks","keys_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/teams","hooks_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/hooks","issue_events_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues/events{/number}","events_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/events","assignees_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/assignees{/user}","branches_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/branches{/branch}","tags_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/tags","blobs_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/statuses/{sha}","languages_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/languages","stargazers_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/stargazers","contributors_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/contributors","subscribers_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/subscribers","subscription_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/subscription","commits_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/contents/{+path}","compare_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/merges","archive_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/downloads","issues_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues{/number}","pulls_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls{/number}","milestones_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/milestones{/number}","notifications_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/labels{/name}","releases_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/releases{/id}","deployments_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/deployments","created_at":"2017-10-25T19:30:44Z","updated_at":"2017-12-12T22:18:19Z","pushed_at":"2017-12-12T23:22:41Z","git_url":"git://github.com/fanfaresimulator/fanfaresimulator.git","ssh_url":"git@github.com:fanfaresimulator/fanfaresimulator.git","clone_url":"https://github.com/fanfaresimulator/fanfaresimulator.git","svn_url":"https://github.com/fanfaresimulator/fanfaresimulator","homepage":"","size":38285,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":2,"open_issues":8,"watchers":3,"default_branch":"master"}},"base":{"label":"fanfaresimulator:master","ref":"master","sha":"c60375e9941972d006ee5cf72b3942336b7d4f31","user":{"login":"fanfaresimulator","id":33068970,"avatar_url":"https://avatars1.githubusercontent.com/u/33068970?v=4","gravatar_id":"","url":"https://api.github.com/users/fanfaresimulator","html_url":"https://github.com/fanfaresimulator","followers_url":"https://api.github.com/users/fanfaresimulator/followers","following_url":"https://api.github.com/users/fanfaresimulator/following{/other_user}","gists_url":"https://api.github.com/users/fanfaresimulator/gists{/gist_id}","starred_url":"https://api.github.com/users/fanfaresimulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanfaresimulator/subscriptions","organizations_url":"https://api.github.com/users/fanfaresimulator/orgs","repos_url":"https://api.github.com/users/fanfaresimulator/repos","events_url":"https://api.github.com/users/fanfaresimulator/events{/privacy}","received_events_url":"https://api.github.com/users/fanfaresimulator/received_events","type":"Organization","site_admin":false},"repo":{"id":108316453,"name":"fanfaresimulator","full_name":"fanfaresimulator/fanfaresimulator","owner":{"login":"fanfaresimulator","id":33068970,"avatar_url":"https://avatars1.githubusercontent.com/u/33068970?v=4","gravatar_id":"","url":"https://api.github.com/users/fanfaresimulator","html_url":"https://github.com/fanfaresimulator","followers_url":"https://api.github.com/users/fanfaresimulator/followers","following_url":"https://api.github.com/users/fanfaresimulator/following{/other_user}","gists_url":"https://api.github.com/users/fanfaresimulator/gists{/gist_id}","starred_url":"https://api.github.com/users/fanfaresimulator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanfaresimulator/subscriptions","organizations_url":"https://api.github.com/users/fanfaresimulator/orgs","repos_url":"https://api.github.com/users/fanfaresimulator/repos","events_url":"https://api.github.com/users/fanfaresimulator/events{/privacy}","received_events_url":"https://api.github.com/users/fanfaresimulator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fanfaresimulator/fanfaresimulator","description":"Fanfare Simulator 2k (name subject to change)","fork":false,"url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator","forks_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/forks","keys_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/teams","hooks_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/hooks","issue_events_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues/events{/number}","events_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/events","assignees_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/assignees{/user}","branches_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/branches{/branch}","tags_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/tags","blobs_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/statuses/{sha}","languages_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/languages","stargazers_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/stargazers","contributors_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/contributors","subscribers_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/subscribers","subscription_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/subscription","commits_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/contents/{+path}","compare_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/merges","archive_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/downloads","issues_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues{/number}","pulls_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls{/number}","milestones_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/milestones{/number}","notifications_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/labels{/name}","releases_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/releases{/id}","deployments_url":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/deployments","created_at":"2017-10-25T19:30:44Z","updated_at":"2017-12-12T22:18:19Z","pushed_at":"2017-12-12T23:22:41Z","git_url":"git://github.com/fanfaresimulator/fanfaresimulator.git","ssh_url":"git@github.com:fanfaresimulator/fanfaresimulator.git","clone_url":"https://github.com/fanfaresimulator/fanfaresimulator.git","svn_url":"https://github.com/fanfaresimulator/fanfaresimulator","homepage":"","size":38285,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":2,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/39"},"html":{"href":"https://github.com/fanfaresimulator/fanfaresimulator/pull/39"},"issue":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues/39"},"comments":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/fanfaresimulator/fanfaresimulator/statuses/7e9965eb6fdd99b65316c9cf6df4487b2c8cd8db"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FooB4r"}}