{"action":"created","issue":{"url":"https://api.github.com/repos/jonashaag/klaus/issues/195","repository_url":"https://api.github.com/repos/jonashaag/klaus","labels_url":"https://api.github.com/repos/jonashaag/klaus/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/jonashaag/klaus/issues/195/comments","events_url":"https://api.github.com/repos/jonashaag/klaus/issues/195/events","html_url":"https://github.com/jonashaag/klaus/issues/195","id":239396809,"number":195,"title":"Improve Apache docs","user":{"login":"jonashaag","id":175722,"avatar_url":"https://avatars2.githubusercontent.com/u/175722?v=3","gravatar_id":"","url":"https://api.github.com/users/jonashaag","html_url":"https://github.com/jonashaag","followers_url":"https://api.github.com/users/jonashaag/followers","following_url":"https://api.github.com/users/jonashaag/following{/other_user}","gists_url":"https://api.github.com/users/jonashaag/gists{/gist_id}","starred_url":"https://api.github.com/users/jonashaag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonashaag/subscriptions","organizations_url":"https://api.github.com/users/jonashaag/orgs","repos_url":"https://api.github.com/users/jonashaag/repos","events_url":"https://api.github.com/users/jonashaag/events{/privacy}","received_events_url":"https://api.github.com/users/jonashaag/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-06-29T08:04:42Z","updated_at":"2017-06-30T12:37:49Z","closed_at":null,"body":"@jahir\r\n\r\nWhile what you wrote here works: https://github.com/jonashaag/klaus/wiki/Apache---mod_wsgi-deployment/_compare/a759371%5E...a759371\r\n\r\nIt doesn't actually make a lot of sense to put these values into environment variables in the first place. We could simply directly call `make_autoreloading_app` with the config values."},"comment":{"url":"https://api.github.com/repos/jonashaag/klaus/issues/comments/312256171","html_url":"https://github.com/jonashaag/klaus/issues/195#issuecomment-312256171","issue_url":"https://api.github.com/repos/jonashaag/klaus/issues/195","id":312256171,"user":{"login":"jonashaag","id":175722,"avatar_url":"https://avatars2.githubusercontent.com/u/175722?v=3","gravatar_id":"","url":"https://api.github.com/users/jonashaag","html_url":"https://github.com/jonashaag","followers_url":"https://api.github.com/users/jonashaag/followers","following_url":"https://api.github.com/users/jonashaag/following{/other_user}","gists_url":"https://api.github.com/users/jonashaag/gists{/gist_id}","starred_url":"https://api.github.com/users/jonashaag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonashaag/subscriptions","organizations_url":"https://api.github.com/users/jonashaag/orgs","repos_url":"https://api.github.com/users/jonashaag/repos","events_url":"https://api.github.com/users/jonashaag/events{/privacy}","received_events_url":"https://api.github.com/users/jonashaag/received_events","type":"User","site_admin":false},"created_at":"2017-06-30T12:37:49Z","updated_at":"2017-06-30T12:37:49Z","body":"Hm... Flask documentation says\r\n\r\n> Please make sure in advance that any app.run() calls you might have in your application file are inside an if `__name__ == '__main__'`: block or moved to a separate file. Just make sure it’s not called because this will always start a local WSGI server which we do not want if we deploy that application to mod_wsgi.\r\n\r\nhttp://flask.pocoo.org/docs/0.12/deploying/mod_wsgi/\r\n\r\nWhich is an indicator that `__name__ != '__main__'` with mod_wsgi, so this wouldn't work. On the other hand, the Flask documentation has that warning for uWSGI as well, and it seems to work for you anyways. So not sure what `__name__` is set to for all these servers.\r\n\r\n\r\n\r\n> Not sure what you mean by\r\n> ignore the application object\r\n\r\nWell, simply use `from wsgi_autoreload import make_autoreloading_app` and ignore that module's `application` object (but don't move it into a `if __name__` block either). This requires that merely instantiating the `application` object does not have any side effects, of course."}}
{"actor":{"display_login":"jonashaag"}}