{"action":"created","comment":{"url":"https://api.github.com/repos/concretecloud/chirp/pulls/comments/107230758","pull_request_review_id":28190803,"id":107230758,"diff_hunk":"@@ -577,6 +641,7 @@ ch_chirp_init(\n {\n     uv_mutex_lock(&_ch_libchirp_mutex);\n     int tmp_err;","path":"src/chirp.c","position":191,"original_position":191,"commit_id":"ea7f37dfb07f74f56ef7375710ed2523fab9498e","original_commit_id":"ea7f37dfb07f74f56ef7375710ed2523fab9498e","user":{"login":"ganwell","id":1186530,"avatar_url":"https://avatars0.githubusercontent.com/u/1186530?v=3","gravatar_id":"","url":"https://api.github.com/users/ganwell","html_url":"https://github.com/ganwell","followers_url":"https://api.github.com/users/ganwell/followers","following_url":"https://api.github.com/users/ganwell/following{/other_user}","gists_url":"https://api.github.com/users/ganwell/gists{/gist_id}","starred_url":"https://api.github.com/users/ganwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganwell/subscriptions","organizations_url":"https://api.github.com/users/ganwell/orgs","repos_url":"https://api.github.com/users/ganwell/repos","events_url":"https://api.github.com/users/ganwell/events{/privacy}","received_events_url":"https://api.github.com/users/ganwell/received_events","type":"User","site_admin":false},"body":"Save the start/done callbacks","created_at":"2017-03-21T18:01:24Z","updated_at":"2017-03-21T18:01:24Z","html_url":"https://github.com/concretecloud/chirp/pull/62#discussion_r107230758","pull_request_url":"https://api.github.com/repos/concretecloud/chirp/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/concretecloud/chirp/pulls/comments/107230758"},"html":{"href":"https://github.com/concretecloud/chirp/pull/62#discussion_r107230758"},"pull_request":{"href":"https://api.github.com/repos/concretecloud/chirp/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/concretecloud/chirp/pulls/62","id":111803305,"html_url":"https://github.com/concretecloud/chirp/pull/62","diff_url":"https://github.com/concretecloud/chirp/pull/62.diff","patch_url":"https://github.com/concretecloud/chirp/pull/62.patch","issue_url":"https://api.github.com/repos/concretecloud/chirp/issues/62","number":62,"state":"open","locked":false,"title":"Making connect ssl handshake work","user":{"login":"ganwell","id":1186530,"avatar_url":"https://avatars0.githubusercontent.com/u/1186530?v=3","gravatar_id":"","url":"https://api.github.com/users/ganwell","html_url":"https://github.com/ganwell","followers_url":"https://api.github.com/users/ganwell/followers","following_url":"https://api.github.com/users/ganwell/following{/other_user}","gists_url":"https://api.github.com/users/ganwell/gists{/gist_id}","starred_url":"https://api.github.com/users/ganwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganwell/subscriptions","organizations_url":"https://api.github.com/users/ganwell/orgs","repos_url":"https://api.github.com/users/ganwell/repos","events_url":"https://api.github.com/users/ganwell/events{/privacy}","received_events_url":"https://api.github.com/users/ganwell/received_events","type":"User","site_admin":false},"body":"Up to now only the accept (incoming connection) ssl handshake worked.\r\nThis commit fixes everything that was in the way.\r\n\r\n* New errors CH_SHUTDOWN, CH_CANNOT_CONNECT\r\n* On error always call the send_cb via shutdown\r\n* Consistently call and clear the send_cb and the msg pointer\r\n* Always allocate buffers when connection is initialized (libuv would\r\n  call the ch_cn_read_alloc_cb too late\r\n\r\nOther changes:\r\n\r\n* Added features to README\r\n* Use gcc as default in alpine docker builds\r\n* Binaries depend on libchirp.so and libchirp_test.a\r\n* Development mantra\r\n* Enable intersphinx to libuv\r\n* Move the link to the sglib doc to toplevel\r\n* Introduce disable encryption setting\r\n* Replace numbers with names ie CH_ID_SIZE\r\n* Added forward declarations for public headers in order to make\r\n  it consistently using the typedefs\r\n* Get rid of the suggested size: always use 64k buffers\r\n* Fix makefile overriding LDFLAGS\r\n* Get rid of the _gen_ functions, they had no more purpose\r\n* Get rid of CH_GET_CHIRP macro, it hid what is going on and was bad for\r\n  readability\r\n* Introduce callbacks when chirp is ready and when it is finished\r\n  (start_cb, done_cb)\r\n* Move ch_rd_free, ch_wr_free to shutdown_cb so they can issue\r\n  uv_close() calls\r\n* Default load is -1, which means no load detected","created_at":"2017-03-21T15:16:06Z","updated_at":"2017-03-21T18:01:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"418f8f72a11120a330b4ce96303f13d9a20ac3eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/concretecloud/chirp/pulls/62/commits","review_comments_url":"https://api.github.com/repos/concretecloud/chirp/pulls/62/comments","review_comment_url":"https://api.github.com/repos/concretecloud/chirp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concretecloud/chirp/issues/62/comments","statuses_url":"https://api.github.com/repos/concretecloud/chirp/statuses/ea7f37dfb07f74f56ef7375710ed2523fab9498e","head":{"label":"ganwell:next","ref":"next","sha":"ea7f37dfb07f74f56ef7375710ed2523fab9498e","user":{"login":"ganwell","id":1186530,"avatar_url":"https://avatars0.githubusercontent.com/u/1186530?v=3","gravatar_id":"","url":"https://api.github.com/users/ganwell","html_url":"https://github.com/ganwell","followers_url":"https://api.github.com/users/ganwell/followers","following_url":"https://api.github.com/users/ganwell/following{/other_user}","gists_url":"https://api.github.com/users/ganwell/gists{/gist_id}","starred_url":"https://api.github.com/users/ganwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganwell/subscriptions","organizations_url":"https://api.github.com/users/ganwell/orgs","repos_url":"https://api.github.com/users/ganwell/repos","events_url":"https://api.github.com/users/ganwell/events{/privacy}","received_events_url":"https://api.github.com/users/ganwell/received_events","type":"User","site_admin":false},"repo":{"id":83028631,"name":"chirp","full_name":"ganwell/chirp","owner":{"login":"ganwell","id":1186530,"avatar_url":"https://avatars0.githubusercontent.com/u/1186530?v=3","gravatar_id":"","url":"https://api.github.com/users/ganwell","html_url":"https://github.com/ganwell","followers_url":"https://api.github.com/users/ganwell/followers","following_url":"https://api.github.com/users/ganwell/following{/other_user}","gists_url":"https://api.github.com/users/ganwell/gists{/gist_id}","starred_url":"https://api.github.com/users/ganwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganwell/subscriptions","organizations_url":"https://api.github.com/users/ganwell/orgs","repos_url":"https://api.github.com/users/ganwell/repos","events_url":"https://api.github.com/users/ganwell/events{/privacy}","received_events_url":"https://api.github.com/users/ganwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ganwell/chirp","description":"Message-passing and actor-based programming for everyone","fork":true,"url":"https://api.github.com/repos/ganwell/chirp","forks_url":"https://api.github.com/repos/ganwell/chirp/forks","keys_url":"https://api.github.com/repos/ganwell/chirp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ganwell/chirp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ganwell/chirp/teams","hooks_url":"https://api.github.com/repos/ganwell/chirp/hooks","issue_events_url":"https://api.github.com/repos/ganwell/chirp/issues/events{/number}","events_url":"https://api.github.com/repos/ganwell/chirp/events","assignees_url":"https://api.github.com/repos/ganwell/chirp/assignees{/user}","branches_url":"https://api.github.com/repos/ganwell/chirp/branches{/branch}","tags_url":"https://api.github.com/repos/ganwell/chirp/tags","blobs_url":"https://api.github.com/repos/ganwell/chirp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ganwell/chirp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ganwell/chirp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ganwell/chirp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ganwell/chirp/statuses/{sha}","languages_url":"https://api.github.com/repos/ganwell/chirp/languages","stargazers_url":"https://api.github.com/repos/ganwell/chirp/stargazers","contributors_url":"https://api.github.com/repos/ganwell/chirp/contributors","subscribers_url":"https://api.github.com/repos/ganwell/chirp/subscribers","subscription_url":"https://api.github.com/repos/ganwell/chirp/subscription","commits_url":"https://api.github.com/repos/ganwell/chirp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ganwell/chirp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ganwell/chirp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ganwell/chirp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ganwell/chirp/contents/{+path}","compare_url":"https://api.github.com/repos/ganwell/chirp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ganwell/chirp/merges","archive_url":"https://api.github.com/repos/ganwell/chirp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ganwell/chirp/downloads","issues_url":"https://api.github.com/repos/ganwell/chirp/issues{/number}","pulls_url":"https://api.github.com/repos/ganwell/chirp/pulls{/number}","milestones_url":"https://api.github.com/repos/ganwell/chirp/milestones{/number}","notifications_url":"https://api.github.com/repos/ganwell/chirp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ganwell/chirp/labels{/name}","releases_url":"https://api.github.com/repos/ganwell/chirp/releases{/id}","deployments_url":"https://api.github.com/repos/ganwell/chirp/deployments","created_at":"2017-02-24T10:09:19Z","updated_at":"2017-02-24T10:09:20Z","pushed_at":"2017-03-21T17:55:10Z","git_url":"git://github.com/ganwell/chirp.git","ssh_url":"git@github.com:ganwell/chirp.git","clone_url":"https://github.com/ganwell/chirp.git","svn_url":"https://github.com/ganwell/chirp","homepage":"https://github.com/concretecloud/chirp","size":283,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"concretecloud:master","ref":"master","sha":"4c46f0d7a7141bf0ebd1658cccc3b99c17a89b2e","user":{"login":"concretecloud","id":13970141,"avatar_url":"https://avatars0.githubusercontent.com/u/13970141?v=3","gravatar_id":"","url":"https://api.github.com/users/concretecloud","html_url":"https://github.com/concretecloud","followers_url":"https://api.github.com/users/concretecloud/followers","following_url":"https://api.github.com/users/concretecloud/following{/other_user}","gists_url":"https://api.github.com/users/concretecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/concretecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concretecloud/subscriptions","organizations_url":"https://api.github.com/users/concretecloud/orgs","repos_url":"https://api.github.com/users/concretecloud/repos","events_url":"https://api.github.com/users/concretecloud/events{/privacy}","received_events_url":"https://api.github.com/users/concretecloud/received_events","type":"Organization","site_admin":false},"repo":{"id":81990316,"name":"chirp","full_name":"concretecloud/chirp","owner":{"login":"concretecloud","id":13970141,"avatar_url":"https://avatars0.githubusercontent.com/u/13970141?v=3","gravatar_id":"","url":"https://api.github.com/users/concretecloud","html_url":"https://github.com/concretecloud","followers_url":"https://api.github.com/users/concretecloud/followers","following_url":"https://api.github.com/users/concretecloud/following{/other_user}","gists_url":"https://api.github.com/users/concretecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/concretecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concretecloud/subscriptions","organizations_url":"https://api.github.com/users/concretecloud/orgs","repos_url":"https://api.github.com/users/concretecloud/repos","events_url":"https://api.github.com/users/concretecloud/events{/privacy}","received_events_url":"https://api.github.com/users/concretecloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concretecloud/chirp","description":"Message-passing and actor-based programming for everyone","fork":false,"url":"https://api.github.com/repos/concretecloud/chirp","forks_url":"https://api.github.com/repos/concretecloud/chirp/forks","keys_url":"https://api.github.com/repos/concretecloud/chirp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concretecloud/chirp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concretecloud/chirp/teams","hooks_url":"https://api.github.com/repos/concretecloud/chirp/hooks","issue_events_url":"https://api.github.com/repos/concretecloud/chirp/issues/events{/number}","events_url":"https://api.github.com/repos/concretecloud/chirp/events","assignees_url":"https://api.github.com/repos/concretecloud/chirp/assignees{/user}","branches_url":"https://api.github.com/repos/concretecloud/chirp/branches{/branch}","tags_url":"https://api.github.com/repos/concretecloud/chirp/tags","blobs_url":"https://api.github.com/repos/concretecloud/chirp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concretecloud/chirp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concretecloud/chirp/git/refs{/sha}","trees_url":"https://api.github.com/repos/concretecloud/chirp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concretecloud/chirp/statuses/{sha}","languages_url":"https://api.github.com/repos/concretecloud/chirp/languages","stargazers_url":"https://api.github.com/repos/concretecloud/chirp/stargazers","contributors_url":"https://api.github.com/repos/concretecloud/chirp/contributors","subscribers_url":"https://api.github.com/repos/concretecloud/chirp/subscribers","subscription_url":"https://api.github.com/repos/concretecloud/chirp/subscription","commits_url":"https://api.github.com/repos/concretecloud/chirp/commits{/sha}","git_commits_url":"https://api.github.com/repos/concretecloud/chirp/git/commits{/sha}","comments_url":"https://api.github.com/repos/concretecloud/chirp/comments{/number}","issue_comment_url":"https://api.github.com/repos/concretecloud/chirp/issues/comments{/number}","contents_url":"https://api.github.com/repos/concretecloud/chirp/contents/{+path}","compare_url":"https://api.github.com/repos/concretecloud/chirp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concretecloud/chirp/merges","archive_url":"https://api.github.com/repos/concretecloud/chirp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concretecloud/chirp/downloads","issues_url":"https://api.github.com/repos/concretecloud/chirp/issues{/number}","pulls_url":"https://api.github.com/repos/concretecloud/chirp/pulls{/number}","milestones_url":"https://api.github.com/repos/concretecloud/chirp/milestones{/number}","notifications_url":"https://api.github.com/repos/concretecloud/chirp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concretecloud/chirp/labels{/name}","releases_url":"https://api.github.com/repos/concretecloud/chirp/releases{/id}","deployments_url":"https://api.github.com/repos/concretecloud/chirp/deployments","created_at":"2017-02-14T21:21:14Z","updated_at":"2017-02-26T16:29:52Z","pushed_at":"2017-03-21T17:55:12Z","git_url":"git://github.com/concretecloud/chirp.git","ssh_url":"git@github.com:concretecloud/chirp.git","clone_url":"https://github.com/concretecloud/chirp.git","svn_url":"https://github.com/concretecloud/chirp","homepage":"https://github.com/concretecloud/chirp","size":266,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":12,"forks":3,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concretecloud/chirp/pulls/62"},"html":{"href":"https://github.com/concretecloud/chirp/pull/62"},"issue":{"href":"https://api.github.com/repos/concretecloud/chirp/issues/62"},"comments":{"href":"https://api.github.com/repos/concretecloud/chirp/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/concretecloud/chirp/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/concretecloud/chirp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concretecloud/chirp/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/concretecloud/chirp/statuses/ea7f37dfb07f74f56ef7375710ed2523fab9498e"}}}}
{"actor":{"display_login":"ganwell"}}