{"action":"opened","number":166,"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls/166","id":116750535,"html_url":"https://github.com/alphagov/govuk-content-navigation/pull/166","diff_url":"https://github.com/alphagov/govuk-content-navigation/pull/166.diff","patch_url":"https://github.com/alphagov/govuk-content-navigation/pull/166.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues/166","number":166,"state":"open","locked":false,"title":"Refactor taxons and taxon presenter","user":{"login":"alecgibson","id":12036746,"avatar_url":"https://avatars3.githubusercontent.com/u/12036746?v=3","gravatar_id":"","url":"https://api.github.com/users/alecgibson","html_url":"https://github.com/alecgibson","followers_url":"https://api.github.com/users/alecgibson/followers","following_url":"https://api.github.com/users/alecgibson/following{/other_user}","gists_url":"https://api.github.com/users/alecgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alecgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alecgibson/subscriptions","organizations_url":"https://api.github.com/users/alecgibson/orgs","repos_url":"https://api.github.com/users/alecgibson/repos","events_url":"https://api.github.com/users/alecgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alecgibson/received_events","type":"User","site_admin":false},"body":"We recently dropped the reliance on a hard-coded JSON file that provided\r\nour taxonomy. As a result, taxons are now fetched asynchronously, which\r\nled to a restructuring where they rely heavily on promises.\r\n\r\nThis refactor focuses primarily on tidying up the taxon class, making\r\nit responsible for fetching its own data asynchronously, and returning\r\na promise that will resolve once all the requested information has been\r\ngathered.\r\n\r\nThis refactoring also affects the taxon presenter (which is obviously\r\ntightly coupled to the taxon class) as well as a couple of other classes\r\nthat had previously used the taxon class.\r\n\r\nViews have been updated to use the new taxon API, but this mostly\r\ninvolved renaming properties.\r\n\r\n### Trello\r\n\r\nhttps://trello.com/c/EYVmmFJp/36-spike-how-we-could-fetch-the-taxonomy-from-the-content-store-instead-of-downloading-it-from-content-tagger","created_at":"2017-04-20T11:36:54Z","updated_at":"2017-04-20T11:36:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls/166/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls/166/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues/166/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/statuses/d8bd0b9ada75dd4e007dff85e87d4105f3817c84","head":{"label":"alphagov:refactor-taxons","ref":"refactor-taxons","sha":"d8bd0b9ada75dd4e007dff85e87d4105f3817c84","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":66287759,"name":"govuk-content-navigation","full_name":"alphagov/govuk-content-navigation","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-content-navigation","description":"Prototype for new GOV.UK navigation","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-content-navigation","forks_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/deployments","created_at":"2016-08-22T16:08:58Z","updated_at":"2017-04-04T21:50:09Z","pushed_at":"2017-04-20T11:35:41Z","git_url":"git://github.com/alphagov/govuk-content-navigation.git","ssh_url":"git@github.com:alphagov/govuk-content-navigation.git","clone_url":"https://github.com/alphagov/govuk-content-navigation.git","svn_url":"https://github.com/alphagov/govuk-content-navigation","homepage":"https://govuk-nav-prototype.herokuapp.com/","size":34565,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"488a00496243372d9053d30bbff0ae21e82ad178","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":66287759,"name":"govuk-content-navigation","full_name":"alphagov/govuk-content-navigation","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-content-navigation","description":"Prototype for new GOV.UK navigation","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-content-navigation","forks_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-content-navigation/deployments","created_at":"2016-08-22T16:08:58Z","updated_at":"2017-04-04T21:50:09Z","pushed_at":"2017-04-20T11:35:41Z","git_url":"git://github.com/alphagov/govuk-content-navigation.git","ssh_url":"git@github.com:alphagov/govuk-content-navigation.git","clone_url":"https://github.com/alphagov/govuk-content-navigation.git","svn_url":"https://github.com/alphagov/govuk-content-navigation","homepage":"https://govuk-nav-prototype.herokuapp.com/","size":34565,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls/166"},"html":{"href":"https://github.com/alphagov/govuk-content-navigation/pull/166"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues/166"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-content-navigation/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-content-navigation/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-content-navigation/statuses/d8bd0b9ada75dd4e007dff85e87d4105f3817c84"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":628,"deletions":504,"changed_files":22}}
{"actor":{"display_login":"alecgibson"}}