{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/132502837","pull_request_review_id":55590861,"id":132502837,"diff_hunk":"@@ -153,49 +152,12 @@ public function getParent()\n     }\n \n     /**\n-     * Finds and registers Commands.\n-     *\n-     * Override this method if your bundle commands do not follow the conventions:\n-     *\n-     * * Commands are in the 'Command' sub-directory\n-     * * Commands extend Symfony\\Component\\Console\\Command\\Command\n+     * Registers console commands.\n      *\n      * @param Application $application An Application instance\n      */\n     public function registerCommands(Application $application)\n     {\n-        if (!is_dir($dir = $this->getPath().'/Command')) {\n-            return;\n-        }\n-\n-        if (!class_exists('Symfony\\Component\\Finder\\Finder')) {\n-            throw new \\RuntimeException('You need the symfony/finder component to register bundle commands.');\n-        }\n-\n-        $finder = new Finder();\n-        $finder->files()->name('*Command.php')->in($dir);\n-\n-        $prefix = $this->getNamespace().'\\\\Command';\n-        foreach ($finder as $file) {\n-            $ns = $prefix;\n-            if ($relativePath = $file->getRelativePath()) {\n-                $ns .= '\\\\'.str_replace('/', '\\\\', $relativePath);\n-            }\n-            $class = $ns.'\\\\'.$file->getBasename('.php');\n-            if ($this->container) {\n-                $commandIds = $this->container->hasParameter('console.command.ids') ? $this->container->getParameter('console.command.ids') : array();","path":"src/Symfony/Component/HttpKernel/Bundle/Bundle.php","position":43,"original_position":43,"commit_id":"2090f0778b62007f59357f274a50d82a7bd4b1ba","original_commit_id":"2090f0778b62007f59357f274a50d82a7bd4b1ba","user":{"login":"ro0NL","id":1047696,"avatar_url":"https://avatars0.githubusercontent.com/u/1047696?v=4","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"body":"should we deprecate this param as well? `console.command.ids`","created_at":"2017-08-10T16:26:54Z","updated_at":"2017-08-10T16:26:54Z","html_url":"https://github.com/symfony/symfony/pull/23857#discussion_r132502837","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/23857","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/132502837"},"html":{"href":"https://github.com/symfony/symfony/pull/23857#discussion_r132502837"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/23857"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/23857","id":135156648,"html_url":"https://github.com/symfony/symfony/pull/23857","diff_url":"https://github.com/symfony/symfony/pull/23857.diff","patch_url":"https://github.com/symfony/symfony/pull/23857.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/23857","number":23857,"state":"open","locked":false,"title":"[HttpKernel] Remove convention based commands registration","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars0.githubusercontent.com/u/7502063?v=4","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | n/a\r\n","created_at":"2017-08-10T15:36:48Z","updated_at":"2017-08-10T16:26:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6bb362aaeeb9487b5597738dc940bf5a90a56f9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/12","html_url":"https://github.com/symfony/symfony/milestone/12","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/12/labels","id":2119145,"number":12,"title":"4.0","description":"https://symfony.com/roadmap?version=4.0#checker","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":86,"state":"open","created_at":"2016-11-07T14:50:40Z","updated_at":"2017-08-10T16:07:17Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/23857/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/23857/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/23857/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/2090f0778b62007f59357f274a50d82a7bd4b1ba","head":{"label":"chalasr:remove-commands-convention","ref":"remove-commands-convention","sha":"2090f0778b62007f59357f274a50d82a7bd4b1ba","user":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars0.githubusercontent.com/u/7502063?v=4","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"repo":{"id":56510160,"name":"symfony","full_name":"chalasr/symfony","owner":{"login":"chalasr","id":7502063,"avatar_url":"https://avatars0.githubusercontent.com/u/7502063?v=4","gravatar_id":"","url":"https://api.github.com/users/chalasr","html_url":"https://github.com/chalasr","followers_url":"https://api.github.com/users/chalasr/followers","following_url":"https://api.github.com/users/chalasr/following{/other_user}","gists_url":"https://api.github.com/users/chalasr/gists{/gist_id}","starred_url":"https://api.github.com/users/chalasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalasr/subscriptions","organizations_url":"https://api.github.com/users/chalasr/orgs","repos_url":"https://api.github.com/users/chalasr/repos","events_url":"https://api.github.com/users/chalasr/events{/privacy}","received_events_url":"https://api.github.com/users/chalasr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chalasr/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/chalasr/symfony","forks_url":"https://api.github.com/repos/chalasr/symfony/forks","keys_url":"https://api.github.com/repos/chalasr/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chalasr/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chalasr/symfony/teams","hooks_url":"https://api.github.com/repos/chalasr/symfony/hooks","issue_events_url":"https://api.github.com/repos/chalasr/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/chalasr/symfony/events","assignees_url":"https://api.github.com/repos/chalasr/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/chalasr/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/chalasr/symfony/tags","blobs_url":"https://api.github.com/repos/chalasr/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chalasr/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chalasr/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/chalasr/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chalasr/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/chalasr/symfony/languages","stargazers_url":"https://api.github.com/repos/chalasr/symfony/stargazers","contributors_url":"https://api.github.com/repos/chalasr/symfony/contributors","subscribers_url":"https://api.github.com/repos/chalasr/symfony/subscribers","subscription_url":"https://api.github.com/repos/chalasr/symfony/subscription","commits_url":"https://api.github.com/repos/chalasr/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/chalasr/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/chalasr/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/chalasr/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/chalasr/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/chalasr/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chalasr/symfony/merges","archive_url":"https://api.github.com/repos/chalasr/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chalasr/symfony/downloads","issues_url":"https://api.github.com/repos/chalasr/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/chalasr/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/chalasr/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/chalasr/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chalasr/symfony/labels{/name}","releases_url":"https://api.github.com/repos/chalasr/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/chalasr/symfony/deployments","created_at":"2016-04-18T13:30:14Z","updated_at":"2017-07-29T12:52:52Z","pushed_at":"2017-08-10T16:16:39Z","git_url":"git://github.com/chalasr/symfony.git","ssh_url":"git@github.com:chalasr/symfony.git","clone_url":"https://github.com/chalasr/symfony.git","svn_url":"https://github.com/chalasr/symfony","homepage":"symfony.com","size":96785,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"9295a4f1eba9ed9050c7aba634bf1b15ef649b65","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-08-10T13:41:12Z","pushed_at":"2017-08-10T16:16:41Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":100519,"stargazers_count":14967,"watchers_count":14967,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5643,"mirror_url":null,"open_issues_count":833,"forks":5643,"open_issues":833,"watchers":14967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/23857"},"html":{"href":"https://github.com/symfony/symfony/pull/23857"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/23857"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/23857/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/23857/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/23857/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/2090f0778b62007f59357f274a50d82a7bd4b1ba"}}}}
{"actor":{"display_login":"ro0NL"}}