{"action":"created","issue":{"url":"https://api.github.com/repos/jamestalmage/cli-table2/issues/42","repository_url":"https://api.github.com/repos/jamestalmage/cli-table2","labels_url":"https://api.github.com/repos/jamestalmage/cli-table2/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/jamestalmage/cli-table2/issues/42/comments","events_url":"https://api.github.com/repos/jamestalmage/cli-table2/issues/42/events","html_url":"https://github.com/jamestalmage/cli-table2/pull/42","id":284163604,"number":42,"title":"Add support for mid-top, mid-bottom, mid-left, mid-right character options","user":{"login":"kleinfreund","id":5774638,"avatar_url":"https://avatars2.githubusercontent.com/u/5774638?v=4","gravatar_id":"","url":"https://api.github.com/users/kleinfreund","html_url":"https://github.com/kleinfreund","followers_url":"https://api.github.com/users/kleinfreund/followers","following_url":"https://api.github.com/users/kleinfreund/following{/other_user}","gists_url":"https://api.github.com/users/kleinfreund/gists{/gist_id}","starred_url":"https://api.github.com/users/kleinfreund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleinfreund/subscriptions","organizations_url":"https://api.github.com/users/kleinfreund/orgs","repos_url":"https://api.github.com/users/kleinfreund/repos","events_url":"https://api.github.com/users/kleinfreund/events{/privacy}","received_events_url":"https://api.github.com/users/kleinfreund/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-22T13:28:52Z","updated_at":"2017-12-23T02:32:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jamestalmage/cli-table2/pulls/42","html_url":"https://github.com/jamestalmage/cli-table2/pull/42","diff_url":"https://github.com/jamestalmage/cli-table2/pull/42.diff","patch_url":"https://github.com/jamestalmage/cli-table2/pull/42.patch"},"body":"\r\nThis PR adds support for configuring the mid-top, mid-bottom, mid-left and mid-right characters of a table. This solves the following issue:\r\n\r\n```\r\n╔═══════════════════╤════╗\r\n║ greetings         │    ║\r\n╟───────╤───────────┼────╢\r\n║ hello │ world     │ :) ║\r\n║       ╟───────────╢    ║\r\n║       │ beautiful │    ║\r\n╟───────╧───────────┼────╢\r\n║ greetings         │    ║\r\n╚═══════════════════╧════╝\r\n```\r\n\r\nThe second row is surrounded by rows that span across two columns. With custom characters, one could not change the `╤` and `╧` character individually. Similarly, the center cells can now close with a custom characters to columns spanning across rows.\r\n\r\nThe following table layout is now possible.\r\n\r\n```\r\n╔═══════════════════╤════╗\r\n║ greetings         │    ║\r\n╟───────┬───────────┼────╢\r\n║ hello │ world     │ :) ║\r\n║       ├───────────┤    ║\r\n║       │ beautiful │    ║\r\n╟───────┴───────────┼────╢\r\n║ greetings         │    ║\r\n╚═══════════════════╧════╝\r\n```\r\n\r\nI tried updating/extending all references to related configuration options. I did not add any tests as I’m not quite familar with writing them how it has been done.\r\n\r\nPlease let me know if further adjustments need to be made. I’d be happy updating the PR accordingly.\r\n\r\n---\r\n\r\nThe current naming scheme is a bit inconsistent. It doesn’t support describing all character options accurately.\r\n\r\nThe name `left-mid` refers to `╟` in the example above, while `mid-left` refers to `├`. I understand that changes to existing names are not possible without breaking things. Maybe, in the future, a better naming scheme can be used. It might make use of an additional qualifier specifying whether the characters is for an outer (e.g. `╟`) or inner cell (e.g. `├`)."},"comment":{"url":"https://api.github.com/repos/jamestalmage/cli-table2/issues/comments/353701965","html_url":"https://github.com/jamestalmage/cli-table2/pull/42#issuecomment-353701965","issue_url":"https://api.github.com/repos/jamestalmage/cli-table2/issues/42","id":353701965,"user":{"login":"jamestalmage","id":4082216,"avatar_url":"https://avatars0.githubusercontent.com/u/4082216?v=4","gravatar_id":"","url":"https://api.github.com/users/jamestalmage","html_url":"https://github.com/jamestalmage","followers_url":"https://api.github.com/users/jamestalmage/followers","following_url":"https://api.github.com/users/jamestalmage/following{/other_user}","gists_url":"https://api.github.com/users/jamestalmage/gists{/gist_id}","starred_url":"https://api.github.com/users/jamestalmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamestalmage/subscriptions","organizations_url":"https://api.github.com/users/jamestalmage/orgs","repos_url":"https://api.github.com/users/jamestalmage/repos","events_url":"https://api.github.com/users/jamestalmage/events{/privacy}","received_events_url":"https://api.github.com/users/jamestalmage/received_events","type":"User","site_admin":false},"created_at":"2017-12-23T02:32:27Z","updated_at":"2017-12-23T02:32:27Z","author_association":"OWNER","body":"That naming is too confusing considering the existing names. Let's come up with something better.\r\n\r\nI am open to suggestions, but what about `internalUp: '┴', internalDown: '┬', internalLeft....`? I don't love that either, so please brainstorm something better if you can.\r\n\r\n"}}
{"actor":{"display_login":"jamestalmage"}}