{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/97098237","pull_request_review_id":17703899,"id":97098237,"diff_hunk":"@@ -509,9 +498,22 @@ std::string expr2javat::convert(\n   else if(src.id()==\"pod_constructor\")\n     return \"pod_constructor\";\n   else if(src.id()==ID_virtual_function)\n-    return convert_function(src, \"VIRTUAL_FUNCTION\", precedence=16);\n+  {\n+    return \"VIRTUAL_FUNCTION(\" +\n+      id2string(src.get(ID_C_class)) +\n+      \".\" +\n+      id2string(src.get(ID_component_name)) +\n+      \")\";\n+  }\n   else if(src.id()==ID_java_string_literal)\n-    return '\"'+id2string(src.get(ID_value))+'\"'; // Todo: add escaping as needed\n+    return '\"'+id2string(src.get(ID_value))+'\"'; // TODO: add escaping as needed\n+  else if(src.id()==ID_constant && (type.id()==ID_bool || type.id()==ID_c_bool))","path":"src/java_bytecode/expr2java.cpp","position":139,"original_position":139,"commit_id":"96889b94916d7356a0fc878b0e597379b4ca8f6b","original_commit_id":"aae0420cfdbd42c4b27a70c99e023c7be3fa2bea","user":{"login":"mgudemann","id":2590540,"avatar_url":"https://avatars.githubusercontent.com/u/2590540?v=3","gravatar_id":"","url":"https://api.github.com/users/mgudemann","html_url":"https://github.com/mgudemann","followers_url":"https://api.github.com/users/mgudemann/followers","following_url":"https://api.github.com/users/mgudemann/following{/other_user}","gists_url":"https://api.github.com/users/mgudemann/gists{/gist_id}","starred_url":"https://api.github.com/users/mgudemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgudemann/subscriptions","organizations_url":"https://api.github.com/users/mgudemann/orgs","repos_url":"https://api.github.com/users/mgudemann/repos","events_url":"https://api.github.com/users/mgudemann/events{/privacy}","received_events_url":"https://api.github.com/users/mgudemann/received_events","type":"User","site_admin":false},"body":"It's exactly 79 chars wide","created_at":"2017-01-20T15:50:50Z","updated_at":"2017-01-20T15:50:50Z","html_url":"https://github.com/diffblue/cbmc/pull/425#discussion_r97098237","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/425","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/97098237"},"html":{"href":"https://github.com/diffblue/cbmc/pull/425#discussion_r97098237"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/425","id":101158750,"html_url":"https://github.com/diffblue/cbmc/pull/425","diff_url":"https://github.com/diffblue/cbmc/pull/425.diff","patch_url":"https://github.com/diffblue/cbmc/pull/425.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/425","number":425,"state":"open","locked":false,"title":"Clean pr java front end","user":{"login":"mgudemann","id":2590540,"avatar_url":"https://avatars.githubusercontent.com/u/2590540?v=3","gravatar_id":"","url":"https://api.github.com/users/mgudemann","html_url":"https://github.com/mgudemann","followers_url":"https://api.github.com/users/mgudemann/followers","following_url":"https://api.github.com/users/mgudemann/following{/other_user}","gists_url":"https://api.github.com/users/mgudemann/gists{/gist_id}","starred_url":"https://api.github.com/users/mgudemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgudemann/subscriptions","organizations_url":"https://api.github.com/users/mgudemann/orgs","repos_url":"https://api.github.com/users/mgudemann/repos","events_url":"https://api.github.com/users/mgudemann/events{/privacy}","received_events_url":"https://api.github.com/users/mgudemann/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-11T22:19:40Z","updated_at":"2017-01-20T15:50:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2f3a7d5b00a469d2aa41a61e319af3a1bb0c4bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/425/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/425/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/425/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/96889b94916d7356a0fc878b0e597379b4ca8f6b","head":{"label":"mgudemann:clean_pr_java_front_end","ref":"clean_pr_java_front_end","sha":"96889b94916d7356a0fc878b0e597379b4ca8f6b","user":{"login":"mgudemann","id":2590540,"avatar_url":"https://avatars.githubusercontent.com/u/2590540?v=3","gravatar_id":"","url":"https://api.github.com/users/mgudemann","html_url":"https://github.com/mgudemann","followers_url":"https://api.github.com/users/mgudemann/followers","following_url":"https://api.github.com/users/mgudemann/following{/other_user}","gists_url":"https://api.github.com/users/mgudemann/gists{/gist_id}","starred_url":"https://api.github.com/users/mgudemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgudemann/subscriptions","organizations_url":"https://api.github.com/users/mgudemann/orgs","repos_url":"https://api.github.com/users/mgudemann/repos","events_url":"https://api.github.com/users/mgudemann/events{/privacy}","received_events_url":"https://api.github.com/users/mgudemann/received_events","type":"User","site_admin":false},"repo":{"id":78655092,"name":"cbmc","full_name":"mgudemann/cbmc","owner":{"login":"mgudemann","id":2590540,"avatar_url":"https://avatars.githubusercontent.com/u/2590540?v=3","gravatar_id":"","url":"https://api.github.com/users/mgudemann","html_url":"https://github.com/mgudemann","followers_url":"https://api.github.com/users/mgudemann/followers","following_url":"https://api.github.com/users/mgudemann/following{/other_user}","gists_url":"https://api.github.com/users/mgudemann/gists{/gist_id}","starred_url":"https://api.github.com/users/mgudemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgudemann/subscriptions","organizations_url":"https://api.github.com/users/mgudemann/orgs","repos_url":"https://api.github.com/users/mgudemann/repos","events_url":"https://api.github.com/users/mgudemann/events{/privacy}","received_events_url":"https://api.github.com/users/mgudemann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgudemann/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/mgudemann/cbmc","forks_url":"https://api.github.com/repos/mgudemann/cbmc/forks","keys_url":"https://api.github.com/repos/mgudemann/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgudemann/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgudemann/cbmc/teams","hooks_url":"https://api.github.com/repos/mgudemann/cbmc/hooks","issue_events_url":"https://api.github.com/repos/mgudemann/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/mgudemann/cbmc/events","assignees_url":"https://api.github.com/repos/mgudemann/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/mgudemann/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/mgudemann/cbmc/tags","blobs_url":"https://api.github.com/repos/mgudemann/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgudemann/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgudemann/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgudemann/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgudemann/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/mgudemann/cbmc/languages","stargazers_url":"https://api.github.com/repos/mgudemann/cbmc/stargazers","contributors_url":"https://api.github.com/repos/mgudemann/cbmc/contributors","subscribers_url":"https://api.github.com/repos/mgudemann/cbmc/subscribers","subscription_url":"https://api.github.com/repos/mgudemann/cbmc/subscription","commits_url":"https://api.github.com/repos/mgudemann/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgudemann/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgudemann/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgudemann/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgudemann/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/mgudemann/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgudemann/cbmc/merges","archive_url":"https://api.github.com/repos/mgudemann/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgudemann/cbmc/downloads","issues_url":"https://api.github.com/repos/mgudemann/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/mgudemann/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/mgudemann/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/mgudemann/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgudemann/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/mgudemann/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/mgudemann/cbmc/deployments","created_at":"2017-01-11T16:02:18Z","updated_at":"2017-01-11T16:02:29Z","pushed_at":"2017-01-20T14:40:14Z","git_url":"git://github.com/mgudemann/cbmc.git","ssh_url":"git@github.com:mgudemann/cbmc.git","clone_url":"https://github.com/mgudemann/cbmc.git","svn_url":"https://github.com/mgudemann/cbmc","homepage":"http://www.cprover.org/cbmc","size":15907,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:master","ref":"master","sha":"2ff33efad8ef397168348b52d776d4cfbf073a00","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2017-01-19T22:11:12Z","pushed_at":"2017-01-20T15:09:27Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":15862,"stargazers_count":32,"watchers_count":32,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":158,"forks":37,"open_issues":158,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/425"},"html":{"href":"https://github.com/diffblue/cbmc/pull/425"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/425"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/96889b94916d7356a0fc878b0e597379b4ca8f6b"}}}}
{"actor":{"display_login":"mgudemann"}}