{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments/154133158","pull_request_review_id":80249800,"id":154133158,"diff_hunk":"@@ -353,6 +356,16 @@ trait RuntimeAttributesValidation[ValidatedType] {\n     }\n   }\n \n+  def validateOptionalWomExpression(wdlExpressionMaybe: Option[WomExpression]): Boolean = {","path":"backend/src/main/scala/cromwell/backend/validation/RuntimeAttributesValidation.scala","position":39,"original_position":39,"commit_id":"6a3ed786a1ba0788c15e30c43723c87ad68b13f4","original_commit_id":"6a3ed786a1ba0788c15e30c43723c87ad68b13f4","user":{"login":"danbills","id":165320,"avatar_url":"https://avatars1.githubusercontent.com/u/165320?v=4","gravatar_id":"","url":"https://api.github.com/users/danbills","html_url":"https://github.com/danbills","followers_url":"https://api.github.com/users/danbills/followers","following_url":"https://api.github.com/users/danbills/following{/other_user}","gists_url":"https://api.github.com/users/danbills/gists{/gist_id}","starred_url":"https://api.github.com/users/danbills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbills/subscriptions","organizations_url":"https://api.github.com/users/danbills/orgs","repos_url":"https://api.github.com/users/danbills/repos","events_url":"https://api.github.com/users/danbills/events{/privacy}","received_events_url":"https://api.github.com/users/danbills/received_events","type":"User","site_admin":false},"body":"could potentially DRY this up w.r.t. `validateOptionalWomValue`","created_at":"2017-11-30T16:44:43Z","updated_at":"2017-11-30T16:44:43Z","html_url":"https://github.com/broadinstitute/cromwell/pull/2954#discussion_r154133158","pull_request_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/2954","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments/154133158"},"html":{"href":"https://github.com/broadinstitute/cromwell/pull/2954#discussion_r154133158"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/2954"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/2954","id":155660203,"html_url":"https://github.com/broadinstitute/cromwell/pull/2954","diff_url":"https://github.com/broadinstitute/cromwell/pull/2954.diff","patch_url":"https://github.com/broadinstitute/cromwell/pull/2954.patch","issue_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/2954","number":2954,"state":"open","locked":false,"title":"Reinstate runtime attributes","user":{"login":"danbills","id":165320,"avatar_url":"https://avatars1.githubusercontent.com/u/165320?v=4","gravatar_id":"","url":"https://api.github.com/users/danbills","html_url":"https://github.com/danbills","followers_url":"https://api.github.com/users/danbills/followers","following_url":"https://api.github.com/users/danbills/following{/other_user}","gists_url":"https://api.github.com/users/danbills/gists{/gist_id}","starred_url":"https://api.github.com/users/danbills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbills/subscriptions","organizations_url":"https://api.github.com/users/danbills/orgs","repos_url":"https://api.github.com/users/danbills/repos","events_url":"https://api.github.com/users/danbills/events{/privacy}","received_events_url":"https://api.github.com/users/danbills/received_events","type":"User","site_admin":false},"body":"As `WomValue` can now be represented in `WomExpression` using `ValueAsExpression`, this validation  was reinstated.","created_at":"2017-11-30T16:43:13Z","updated_at":"2017-11-30T16:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"038812b12fd40f00ea1c5182d2d6414302d6f0c2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/2954/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/2954/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/2954/comments","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/6a3ed786a1ba0788c15e30c43723c87ad68b13f4","head":{"label":"broadinstitute:db_runtime_attributes","ref":"db_runtime_attributes","sha":"6a3ed786a1ba0788c15e30c43723c87ad68b13f4","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34136406,"name":"cromwell","full_name":"broadinstitute/cromwell","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/cromwell","description":"Workflow Execution Engine using WDL","fork":false,"url":"https://api.github.com/repos/broadinstitute/cromwell","forks_url":"https://api.github.com/repos/broadinstitute/cromwell/forks","keys_url":"https://api.github.com/repos/broadinstitute/cromwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/cromwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/cromwell/teams","hooks_url":"https://api.github.com/repos/broadinstitute/cromwell/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/cromwell/events","assignees_url":"https://api.github.com/repos/broadinstitute/cromwell/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/cromwell/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/cromwell/tags","blobs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/cromwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/cromwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/cromwell/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/cromwell/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/cromwell/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/cromwell/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/cromwell/subscription","commits_url":"https://api.github.com/repos/broadinstitute/cromwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/cromwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/cromwell/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/cromwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/cromwell/merges","archive_url":"https://api.github.com/repos/broadinstitute/cromwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/cromwell/downloads","issues_url":"https://api.github.com/repos/broadinstitute/cromwell/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/cromwell/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/cromwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/cromwell/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/cromwell/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/cromwell/deployments","created_at":"2015-04-17T19:39:36Z","updated_at":"2017-11-29T11:29:36Z","pushed_at":"2017-11-30T16:43:14Z","git_url":"git://github.com/broadinstitute/cromwell.git","ssh_url":"git@github.com:broadinstitute/cromwell.git","clone_url":"https://github.com/broadinstitute/cromwell.git","svn_url":"https://github.com/broadinstitute/cromwell","homepage":"","size":13783,"stargazers_count":182,"watchers_count":182,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":357,"license":null,"forks":50,"open_issues":357,"watchers":182,"default_branch":"29_hotfix"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"f57e08721beadf6a28800648ce70e356dd2ee586","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34136406,"name":"cromwell","full_name":"broadinstitute/cromwell","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/cromwell","description":"Workflow Execution Engine using WDL","fork":false,"url":"https://api.github.com/repos/broadinstitute/cromwell","forks_url":"https://api.github.com/repos/broadinstitute/cromwell/forks","keys_url":"https://api.github.com/repos/broadinstitute/cromwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/cromwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/cromwell/teams","hooks_url":"https://api.github.com/repos/broadinstitute/cromwell/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/cromwell/events","assignees_url":"https://api.github.com/repos/broadinstitute/cromwell/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/cromwell/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/cromwell/tags","blobs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/cromwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/cromwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/cromwell/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/cromwell/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/cromwell/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/cromwell/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/cromwell/subscription","commits_url":"https://api.github.com/repos/broadinstitute/cromwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/cromwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/cromwell/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/cromwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/cromwell/merges","archive_url":"https://api.github.com/repos/broadinstitute/cromwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/cromwell/downloads","issues_url":"https://api.github.com/repos/broadinstitute/cromwell/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/cromwell/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/cromwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/cromwell/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/cromwell/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/cromwell/deployments","created_at":"2015-04-17T19:39:36Z","updated_at":"2017-11-29T11:29:36Z","pushed_at":"2017-11-30T16:43:14Z","git_url":"git://github.com/broadinstitute/cromwell.git","ssh_url":"git@github.com:broadinstitute/cromwell.git","clone_url":"https://github.com/broadinstitute/cromwell.git","svn_url":"https://github.com/broadinstitute/cromwell","homepage":"","size":13783,"stargazers_count":182,"watchers_count":182,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":357,"license":null,"forks":50,"open_issues":357,"watchers":182,"default_branch":"29_hotfix"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/2954"},"html":{"href":"https://github.com/broadinstitute/cromwell/pull/2954"},"issue":{"href":"https://api.github.com/repos/broadinstitute/cromwell/issues/2954"},"comments":{"href":"https://api.github.com/repos/broadinstitute/cromwell/issues/2954/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/2954/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/2954/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/cromwell/statuses/6a3ed786a1ba0788c15e30c43723c87ad68b13f4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danbills"}}