{"action":"created","issue":{"url":"https://api.github.com/repos/Shippable/admiral/issues/683","repository_url":"https://api.github.com/repos/Shippable/admiral","labels_url":"https://api.github.com/repos/Shippable/admiral/issues/683/labels{/name}","comments_url":"https://api.github.com/repos/Shippable/admiral/issues/683/comments","events_url":"https://api.github.com/repos/Shippable/admiral/issues/683/events","html_url":"https://github.com/Shippable/admiral/issues/683","id":230345914,"number":683,"title":"[bug] Cannot bring up new machines in RC","user":{"login":"shrivara","id":40004,"avatar_url":"https://avatars1.githubusercontent.com/u/40004?v=3","gravatar_id":"","url":"https://api.github.com/users/shrivara","html_url":"https://github.com/shrivara","followers_url":"https://api.github.com/users/shrivara/followers","following_url":"https://api.github.com/users/shrivara/following{/other_user}","gists_url":"https://api.github.com/users/shrivara/gists{/gist_id}","starred_url":"https://api.github.com/users/shrivara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrivara/subscriptions","organizations_url":"https://api.github.com/users/shrivara/orgs","repos_url":"https://api.github.com/users/shrivara/repos","events_url":"https://api.github.com/users/shrivara/events{/privacy}","received_events_url":"https://api.github.com/users/shrivara/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"ric03uec","id":1110988,"avatar_url":"https://avatars2.githubusercontent.com/u/1110988?v=3","gravatar_id":"","url":"https://api.github.com/users/ric03uec","html_url":"https://github.com/ric03uec","followers_url":"https://api.github.com/users/ric03uec/followers","following_url":"https://api.github.com/users/ric03uec/following{/other_user}","gists_url":"https://api.github.com/users/ric03uec/gists{/gist_id}","starred_url":"https://api.github.com/users/ric03uec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ric03uec/subscriptions","organizations_url":"https://api.github.com/users/ric03uec/orgs","repos_url":"https://api.github.com/users/ric03uec/repos","events_url":"https://api.github.com/users/ric03uec/events{/privacy}","received_events_url":"https://api.github.com/users/ric03uec/received_events","type":"User","site_admin":false},"assignees":[{"login":"ric03uec","id":1110988,"avatar_url":"https://avatars2.githubusercontent.com/u/1110988?v=3","gravatar_id":"","url":"https://api.github.com/users/ric03uec","html_url":"https://github.com/ric03uec","followers_url":"https://api.github.com/users/ric03uec/followers","following_url":"https://api.github.com/users/ric03uec/following{/other_user}","gists_url":"https://api.github.com/users/ric03uec/gists{/gist_id}","starred_url":"https://api.github.com/users/ric03uec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ric03uec/subscriptions","organizations_url":"https://api.github.com/users/ric03uec/orgs","repos_url":"https://api.github.com/users/ric03uec/repos","events_url":"https://api.github.com/users/ric03uec/events{/privacy}","received_events_url":"https://api.github.com/users/ric03uec/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-05-22T10:05:30Z","updated_at":"2017-05-22T22:14:27Z","closed_at":"2017-05-22T22:14:27Z","body":"We tried to bring up new machines in RC today. We ran the following steps:\r\n1. Remove `machines1`.\r\n2. Remove `machines2`.\r\n3. Add `machines3` with new IP.\r\n4. Add `machines4` with new IP.\r\n5. Run the command to add SSH keys on the `machines3`, `machines4`(after running `sudo su`).\r\n6. Run initialise. \r\n\r\nWe ran into the following problems:\r\n* First, `secrets` machine was not initialising because port was a string \"8200\" and it would fail [this](https://github.com/Shippable/admiral/blob/master/api/state/initialize.js#L106) validation. We couldn't find a way to update this in the UI. So, we updated this to a number in DB.\r\n* We found a few more ports stored as strings(although we didn't check if these had `isNumber` validations) and we fixed them all.\r\n* After we fixed this, `secrets` would still fail to initialize as it attempted to unseal an already sealed Vault. There are a few issues in the initialize call. Its not making the [right call](https://github.com/Shippable/admiral/blob/master/api/secrets/initialize.js#L354)(doesn't return `isSealed` in response) to obtain sealed status. The [condition to check if unseal](https://github.com/Shippable/admiral/blob/master/api/secrets/initialize.js#L474) is required is wrong.\r\n\r\nWe didn't proceed beyond this and attempted to bring up the machines using base instead to unblock everyone.\r\n\r\n**Update:** Bringing up new machines using base also failed as a few required envs aren't set from base. Didn't realize that admiral has completely different flow. Since, we didn't want to break existing `systemSettings` by removing it, we left it as it is. This is the [PR](https://github.com/Shippable/infra/commit/e8047fa626e3feb22ddfcac00c70270f8a0f85ab) used to bring up new machines. If admiral will have problems with base initialised machines, new machines can be brought up similarly. \r\n\r\nhttps://github.com/Shippable/pm/issues/8413"},"comment":{"url":"https://api.github.com/repos/Shippable/admiral/issues/comments/303234627","html_url":"https://github.com/Shippable/admiral/issues/683#issuecomment-303234627","issue_url":"https://api.github.com/repos/Shippable/admiral/issues/683","id":303234627,"user":{"login":"ric03uec","id":1110988,"avatar_url":"https://avatars2.githubusercontent.com/u/1110988?v=3","gravatar_id":"","url":"https://api.github.com/users/ric03uec","html_url":"https://github.com/ric03uec","followers_url":"https://api.github.com/users/ric03uec/followers","following_url":"https://api.github.com/users/ric03uec/following{/other_user}","gists_url":"https://api.github.com/users/ric03uec/gists{/gist_id}","starred_url":"https://api.github.com/users/ric03uec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ric03uec/subscriptions","organizations_url":"https://api.github.com/users/ric03uec/orgs","repos_url":"https://api.github.com/users/ric03uec/repos","events_url":"https://api.github.com/users/ric03uec/events{/privacy}","received_events_url":"https://api.github.com/users/ric03uec/received_events","type":"User","site_admin":false},"created_at":"2017-05-22T22:14:27Z","updated_at":"2017-05-22T22:14:27Z","body":"this is now working in RC, closing"}}
{"actor":{"display_login":"ric03uec"}}