{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50349","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50349/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50349/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50349/events","html_url":"https://github.com/kubernetes/kubernetes/pull/50349","id":248894795,"number":50349,"title":"Update cli verification to match new conventions","user":{"login":"tcharding","id":12626037,"avatar_url":"https://avatars2.githubusercontent.com/u/12626037?v=4","gravatar_id":"","url":"https://api.github.com/users/tcharding","html_url":"https://github.com/tcharding","followers_url":"https://api.github.com/users/tcharding/followers","following_url":"https://api.github.com/users/tcharding/following{/other_user}","gists_url":"https://api.github.com/users/tcharding/gists{/gist_id}","starred_url":"https://api.github.com/users/tcharding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcharding/subscriptions","organizations_url":"https://api.github.com/users/tcharding/orgs","repos_url":"https://api.github.com/users/tcharding/repos","events_url":"https://api.github.com/users/tcharding/events{/privacy}","received_events_url":"https://api.github.com/users/tcharding/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":116801185,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/documentation","name":"kind/documentation","color":"c7def8","default":false},{"id":573014062,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":450823910,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cli","name":"sig/cli","color":"d2b48c","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-08-09T01:52:38Z","updated_at":"2017-08-09T21:38:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50349","html_url":"https://github.com/kubernetes/kubernetes/pull/50349","diff_url":"https://github.com/kubernetes/kubernetes/pull/50349.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/50349.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nPR #885 merged recently updating the conventions for cli Examples (arguments to `templates.Examples()`). This PR updates `cmd_sanity.go` so that the new conventions are verified when running `hack/verify-cli-conventions.sh`. This PR also fixes up all the warnings thrown by the additional verification.\r\n\r\n**Special notes for your reviewer**:\r\n\r\nIdea for this PR suggested by @fabianofranz in the comments of #885.\r\n\r\nUnspecified by the conventions (and as far as I can tell in the k8s project) was when to wrap lines. The choice was made to wrap lines only after the end of a sentence (this relates to Example comments only).\r\n\r\nAll Examples should now be reasonably uniform. If it is decided the format needs modification this PR should at least make it easier to do so by script instead of by hand.\r\n\r\n**Release note**:\r\n```release-note\r\nClean up and make uniform all examples in kubectl help command.\r\n```\r\n\r\n/sig cli\r\n/kind documentation\r\n/kind cleanup"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/321388649","html_url":"https://github.com/kubernetes/kubernetes/pull/50349#issuecomment-321388649","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50349","id":321388649,"user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars0.githubusercontent.com/u/158611?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"created_at":"2017-08-09T21:38:12Z","updated_at":"2017-08-09T21:38:12Z","body":"I remember we explicitly decided to not prefix `$` to the examples some time ago.\r\n\r\nAsking more people's opinions: @kubernetes/sig-cli-proposals @kubernetes/sig-cli-api-reviews "}}
{"actor":{"display_login":"fabianofranz"}}