{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/97408831","pull_request_review_id":18016736,"id":97408831,"diff_hunk":"@@ -830,6 +877,7 @@ public void testDateParse()\n \n         assertInvalidFunction(\"date_parse('3.0123456789', '%s.%f')\", \"Invalid format: \\\"3.0123456789\\\" is malformed at \\\"9\\\"\");\n         assertInvalidFunction(\"date_parse('%Y-%M-%d', '')\", \"Both printing and parsing not supported\");\n+        assertInvalidFunction(\"date_parse('2013-05-17t', '%Y-%m-%D')\", \"Invalid format: \\\"2013-05-17t\\\" is malformed at \\\"17t\\\"\");","path":"presto-main/src/test/java/com/facebook/presto/operator/scalar/TestDateTimeFunctions.java","position":90,"original_position":90,"commit_id":"332703cd536aad70c1ec4dd9da13262f8acd896c","original_commit_id":"332703cd536aad70c1ec4dd9da13262f8acd896c","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"Add a few more invalid test cases:\r\n* `32nd`\r\n* `0st`\r\n* `30th` for February\r\n","created_at":"2017-01-23T20:31:36Z","updated_at":"2017-01-23T20:37:26Z","html_url":"https://github.com/prestodb/presto/pull/7127#discussion_r97408831","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/7127","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/97408831"},"html":{"href":"https://github.com/prestodb/presto/pull/7127#discussion_r97408831"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7127"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/7127","id":102167425,"html_url":"https://github.com/prestodb/presto/pull/7127","diff_url":"https://github.com/prestodb/presto/pull/7127.diff","patch_url":"https://github.com/prestodb/presto/pull/7127.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/7127","number":7127,"state":"open","locked":false,"title":"Support English month suffix formatter for MySQL date functions #6025","user":{"login":"thezhangwei","id":157053,"avatar_url":"https://avatars.githubusercontent.com/u/157053?v=3","gravatar_id":"","url":"https://api.github.com/users/thezhangwei","html_url":"https://github.com/thezhangwei","followers_url":"https://api.github.com/users/thezhangwei/followers","following_url":"https://api.github.com/users/thezhangwei/following{/other_user}","gists_url":"https://api.github.com/users/thezhangwei/gists{/gist_id}","starred_url":"https://api.github.com/users/thezhangwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezhangwei/subscriptions","organizations_url":"https://api.github.com/users/thezhangwei/orgs","repos_url":"https://api.github.com/users/thezhangwei/repos","events_url":"https://api.github.com/users/thezhangwei/events{/privacy}","received_events_url":"https://api.github.com/users/thezhangwei/received_events","type":"User","site_admin":false},"body":"#6025 \r\n\r\nAs discussed in the issue, I created a custom DateTimePrinter, DateTimeParser that handles %D.\r\nI also added more unittest.\r\n@electrum @cberner ","created_at":"2017-01-18T22:54:42Z","updated_at":"2017-01-23T20:37:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f1adf9e8802a474c0977b8ecff183dca8aaf6f3","assignee":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"assignees":[{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},{"login":"cberner","id":842688,"avatar_url":"https://avatars.githubusercontent.com/u/842688?v=3","gravatar_id":"","url":"https://api.github.com/users/cberner","html_url":"https://github.com/cberner","followers_url":"https://api.github.com/users/cberner/followers","following_url":"https://api.github.com/users/cberner/following{/other_user}","gists_url":"https://api.github.com/users/cberner/gists{/gist_id}","starred_url":"https://api.github.com/users/cberner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cberner/subscriptions","organizations_url":"https://api.github.com/users/cberner/orgs","repos_url":"https://api.github.com/users/cberner/repos","events_url":"https://api.github.com/users/cberner/events{/privacy}","received_events_url":"https://api.github.com/users/cberner/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/7127/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/7127/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/7127/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/332703cd536aad70c1ec4dd9da13262f8acd896c","head":{"label":"thezhangwei:support-english-suffix-date-formatter","ref":"support-english-suffix-date-formatter","sha":"332703cd536aad70c1ec4dd9da13262f8acd896c","user":{"login":"thezhangwei","id":157053,"avatar_url":"https://avatars.githubusercontent.com/u/157053?v=3","gravatar_id":"","url":"https://api.github.com/users/thezhangwei","html_url":"https://github.com/thezhangwei","followers_url":"https://api.github.com/users/thezhangwei/followers","following_url":"https://api.github.com/users/thezhangwei/following{/other_user}","gists_url":"https://api.github.com/users/thezhangwei/gists{/gist_id}","starred_url":"https://api.github.com/users/thezhangwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezhangwei/subscriptions","organizations_url":"https://api.github.com/users/thezhangwei/orgs","repos_url":"https://api.github.com/users/thezhangwei/repos","events_url":"https://api.github.com/users/thezhangwei/events{/privacy}","received_events_url":"https://api.github.com/users/thezhangwei/received_events","type":"User","site_admin":false},"repo":{"id":78894981,"name":"presto","full_name":"thezhangwei/presto","owner":{"login":"thezhangwei","id":157053,"avatar_url":"https://avatars.githubusercontent.com/u/157053?v=3","gravatar_id":"","url":"https://api.github.com/users/thezhangwei","html_url":"https://github.com/thezhangwei","followers_url":"https://api.github.com/users/thezhangwei/followers","following_url":"https://api.github.com/users/thezhangwei/following{/other_user}","gists_url":"https://api.github.com/users/thezhangwei/gists{/gist_id}","starred_url":"https://api.github.com/users/thezhangwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thezhangwei/subscriptions","organizations_url":"https://api.github.com/users/thezhangwei/orgs","repos_url":"https://api.github.com/users/thezhangwei/repos","events_url":"https://api.github.com/users/thezhangwei/events{/privacy}","received_events_url":"https://api.github.com/users/thezhangwei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thezhangwei/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/thezhangwei/presto","forks_url":"https://api.github.com/repos/thezhangwei/presto/forks","keys_url":"https://api.github.com/repos/thezhangwei/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thezhangwei/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thezhangwei/presto/teams","hooks_url":"https://api.github.com/repos/thezhangwei/presto/hooks","issue_events_url":"https://api.github.com/repos/thezhangwei/presto/issues/events{/number}","events_url":"https://api.github.com/repos/thezhangwei/presto/events","assignees_url":"https://api.github.com/repos/thezhangwei/presto/assignees{/user}","branches_url":"https://api.github.com/repos/thezhangwei/presto/branches{/branch}","tags_url":"https://api.github.com/repos/thezhangwei/presto/tags","blobs_url":"https://api.github.com/repos/thezhangwei/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thezhangwei/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thezhangwei/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/thezhangwei/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thezhangwei/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/thezhangwei/presto/languages","stargazers_url":"https://api.github.com/repos/thezhangwei/presto/stargazers","contributors_url":"https://api.github.com/repos/thezhangwei/presto/contributors","subscribers_url":"https://api.github.com/repos/thezhangwei/presto/subscribers","subscription_url":"https://api.github.com/repos/thezhangwei/presto/subscription","commits_url":"https://api.github.com/repos/thezhangwei/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/thezhangwei/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/thezhangwei/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/thezhangwei/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/thezhangwei/presto/contents/{+path}","compare_url":"https://api.github.com/repos/thezhangwei/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thezhangwei/presto/merges","archive_url":"https://api.github.com/repos/thezhangwei/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thezhangwei/presto/downloads","issues_url":"https://api.github.com/repos/thezhangwei/presto/issues{/number}","pulls_url":"https://api.github.com/repos/thezhangwei/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/thezhangwei/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/thezhangwei/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thezhangwei/presto/labels{/name}","releases_url":"https://api.github.com/repos/thezhangwei/presto/releases{/id}","deployments_url":"https://api.github.com/repos/thezhangwei/presto/deployments","created_at":"2017-01-13T23:29:45Z","updated_at":"2017-01-13T23:30:01Z","pushed_at":"2017-01-20T22:50:00Z","git_url":"git://github.com/thezhangwei/presto.git","ssh_url":"git@github.com:thezhangwei/presto.git","clone_url":"https://github.com/thezhangwei/presto.git","svn_url":"https://github.com/thezhangwei/presto","homepage":"https://prestodb.io","size":65133,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"f20d677b8203f10728649c8f4b038f68a08dd909","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2017-01-23T18:14:56Z","pushed_at":"2017-01-23T20:36:12Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":65509,"stargazers_count":5525,"watchers_count":5525,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1751,"mirror_url":null,"open_issues_count":887,"forks":1751,"open_issues":887,"watchers":5525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7127"},"html":{"href":"https://github.com/prestodb/presto/pull/7127"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/7127"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/7127/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7127/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7127/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/332703cd536aad70c1ec4dd9da13262f8acd896c"}}}}
{"actor":{"display_login":"electrum"}}