{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/110067245","pull_request_review_id":31211766,"id":110067245,"diff_hunk":"@@ -137,6 +137,9 @@ func (k kops) Up() error {\n \tif k.image != \"\" {\n \t\tcreateArgs = append(createArgs, \"--image\", k.image)\n \t}\n+\tif os.Getenv(\"KOPS_ARGS\") != \"\" {","path":"kubetest/kops.go","position":4,"original_position":4,"commit_id":"7b8a8b822687d5bb6881452a9c2718d20de95daf","original_commit_id":"7b8a8b822687d5bb6881452a9c2718d20de95daf","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars1.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"Please make this a kubetest flag. `--kopsArgs` `--kops-args` or something similar.","created_at":"2017-04-06T02:09:27Z","updated_at":"2017-04-06T02:09:27Z","html_url":"https://github.com/kubernetes/test-infra/pull/2405#discussion_r110067245","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2405","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/110067245"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/2405#discussion_r110067245"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2405"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2405","id":114249420,"html_url":"https://github.com/kubernetes/test-infra/pull/2405","diff_url":"https://github.com/kubernetes/test-infra/pull/2405.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/2405.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/2405","number":2405,"state":"open","locked":false,"title":"Add KOPS_ARGS for passing arbitrary args to 'kops create cluster'","user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars3.githubusercontent.com/u/13111288?v=3","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"body":"This small change could let me pass any arbitrary args without having to continue making too many PRs/changes to kops.go (or worse somehow maintain my own fork of it.) \r\n\r\nI agree for sure that a 'kops cli pass-thru' as mentioned here https://github.com/kubernetes/test-infra/pull/2019 would be ideal but since I'm apparnetly the only one using these scripts outside of official CI and I'm not sure how to implement it properly, this should be enough for now :)","created_at":"2017-04-04T21:35:19Z","updated_at":"2017-04-06T02:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97e2ccc1d3904e505779b3ab8aa910cab428a1d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2405/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2405/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/2405/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/7b8a8b822687d5bb6881452a9c2718d20de95daf","head":{"label":"wongma7:kops-dns","ref":"kops-dns","sha":"7b8a8b822687d5bb6881452a9c2718d20de95daf","user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars3.githubusercontent.com/u/13111288?v=3","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"repo":{"id":82956764,"name":"test-infra","full_name":"wongma7/test-infra","owner":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars3.githubusercontent.com/u/13111288?v=3","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wongma7/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/wongma7/test-infra","forks_url":"https://api.github.com/repos/wongma7/test-infra/forks","keys_url":"https://api.github.com/repos/wongma7/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wongma7/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wongma7/test-infra/teams","hooks_url":"https://api.github.com/repos/wongma7/test-infra/hooks","issue_events_url":"https://api.github.com/repos/wongma7/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/wongma7/test-infra/events","assignees_url":"https://api.github.com/repos/wongma7/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/wongma7/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/wongma7/test-infra/tags","blobs_url":"https://api.github.com/repos/wongma7/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wongma7/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wongma7/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/wongma7/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wongma7/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/wongma7/test-infra/languages","stargazers_url":"https://api.github.com/repos/wongma7/test-infra/stargazers","contributors_url":"https://api.github.com/repos/wongma7/test-infra/contributors","subscribers_url":"https://api.github.com/repos/wongma7/test-infra/subscribers","subscription_url":"https://api.github.com/repos/wongma7/test-infra/subscription","commits_url":"https://api.github.com/repos/wongma7/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/wongma7/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/wongma7/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/wongma7/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/wongma7/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/wongma7/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wongma7/test-infra/merges","archive_url":"https://api.github.com/repos/wongma7/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wongma7/test-infra/downloads","issues_url":"https://api.github.com/repos/wongma7/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/wongma7/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/wongma7/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/wongma7/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wongma7/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/wongma7/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/wongma7/test-infra/deployments","created_at":"2017-02-23T18:10:39Z","updated_at":"2017-02-23T18:10:42Z","pushed_at":"2017-04-04T20:23:07Z","git_url":"git://github.com/wongma7/test-infra.git","ssh_url":"git@github.com:wongma7/test-infra.git","clone_url":"https://github.com/wongma7/test-infra.git","svn_url":"https://github.com/wongma7/test-infra","homepage":null,"size":16156,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f5acbdb60b8f1c3b46346ab02f8827087f32d6b2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2017-03-29T13:07:30Z","pushed_at":"2017-04-05T23:41:11Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":16974,"stargazers_count":70,"watchers_count":70,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":182,"forks":120,"open_issues":182,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2405"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/2405"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/2405"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/2405/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2405/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2405/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/7b8a8b822687d5bb6881452a9c2718d20de95daf"}}}}
{"actor":{"display_login":"fejta"}}