{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/bosh-cli/issues/7","repository_url":"https://api.github.com/repos/cloudfoundry/bosh-cli","labels_url":"https://api.github.com/repos/cloudfoundry/bosh-cli/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/bosh-cli/issues/7/comments","events_url":"https://api.github.com/repos/cloudfoundry/bosh-cli/issues/7/events","html_url":"https://github.com/cloudfoundry/bosh-cli/issues/7","id":175626228,"number":7,"title":"`update-cloud-config` (and `update-runtime-config`) should show a diff before confirmation","user":{"login":"jaresty","id":1313844,"avatar_url":"https://avatars1.githubusercontent.com/u/1313844?v=4","gravatar_id":"","url":"https://api.github.com/users/jaresty","html_url":"https://github.com/jaresty","followers_url":"https://api.github.com/users/jaresty/followers","following_url":"https://api.github.com/users/jaresty/following{/other_user}","gists_url":"https://api.github.com/users/jaresty/gists{/gist_id}","starred_url":"https://api.github.com/users/jaresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaresty/subscriptions","organizations_url":"https://api.github.com/users/jaresty/orgs","repos_url":"https://api.github.com/users/jaresty/repos","events_url":"https://api.github.com/users/jaresty/events{/privacy}","received_events_url":"https://api.github.com/users/jaresty/received_events","type":"User","site_admin":false},"labels":[{"id":434547179,"url":"https://api.github.com/repos/cloudfoundry/bosh-cli/labels/planned-enhancement","name":"planned-enhancement","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-07T22:56:19Z","updated_at":"2017-09-06T12:51:59Z","closed_at":"2017-08-16T23:04:14Z","author_association":"MEMBER","body":"When running `bosh deploy`, we get a nice diff of the changes we are going to apply:\n\n```\ngosh deploy -d cf --var-files=deployments/cf/env-vars.yml  deployments/cf/cf-deployment.yml\nUsing environment '104.198.99.5' as user 'admin'\n\nUsing deployment 'cf'\n\n  networks:\n  - name: private\n    subnets:\n    - range: 10.0.16.0/20\n      cloud_properties:\n+       ephemeral_external_ip: true\n    - range: 10.0.32.0/19\n      cloud_properties:\n+       ephemeral_external_ip: true\n```\n\nWhen running `gosh update-cloud-config`, however, we do not see any diff; just a confirmation question:\n\n```\ngosh update-cloud-config deployments/cf/cloud-config.yml\nUsing environment 'xxx' as user 'admin'\n\nContinue? [yN]: y\n\nSucceeded\n```\n\nIt would be nice if we could see a diff of the cloud config when we are updating it, rather than having to wait until running `bosh deploy` to see the changes. Of course, the new properties will not be applied to existing deployments until `deploy` is run, so perhaps the diff should note that, too.\n\n```\ngosh --version\nversion 0.0.54-a29688a-2016-09-06T16:34:29Z\n\nExit code 1\n```\n"},"comment":{"url":"https://api.github.com/repos/cloudfoundry/bosh-cli/issues/comments/327473466","html_url":"https://github.com/cloudfoundry/bosh-cli/issues/7#issuecomment-327473466","issue_url":"https://api.github.com/repos/cloudfoundry/bosh-cli/issues/7","id":327473466,"user":{"login":"geofffranks","id":7180882,"avatar_url":"https://avatars0.githubusercontent.com/u/7180882?v=4","gravatar_id":"","url":"https://api.github.com/users/geofffranks","html_url":"https://github.com/geofffranks","followers_url":"https://api.github.com/users/geofffranks/followers","following_url":"https://api.github.com/users/geofffranks/following{/other_user}","gists_url":"https://api.github.com/users/geofffranks/gists{/gist_id}","starred_url":"https://api.github.com/users/geofffranks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geofffranks/subscriptions","organizations_url":"https://api.github.com/users/geofffranks/orgs","repos_url":"https://api.github.com/users/geofffranks/repos","events_url":"https://api.github.com/users/geofffranks/events{/privacy}","received_events_url":"https://api.github.com/users/geofffranks/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T12:51:59Z","updated_at":"2017-09-06T12:51:59Z","author_association":"NONE","body":"This might warrant being added to the release notes of v2.0.30?"}}
{"actor":{"display_login":"geofffranks"}}