{"action":"closed","number":506,"pull_request":{"url":"https://api.github.com/repos/open-policy-agent/opa/pulls/506","id":153175644,"html_url":"https://github.com/open-policy-agent/opa/pull/506","diff_url":"https://github.com/open-policy-agent/opa/pull/506.diff","patch_url":"https://github.com/open-policy-agent/opa/pull/506.patch","issue_url":"https://api.github.com/repos/open-policy-agent/opa/issues/506","number":506,"state":"closed","locked":false,"title":"Fix eval of objects/sets containing vars","user":{"login":"tsandall","id":238885,"avatar_url":"https://avatars0.githubusercontent.com/u/238885?v=4","gravatar_id":"","url":"https://api.github.com/users/tsandall","html_url":"https://github.com/tsandall","followers_url":"https://api.github.com/users/tsandall/followers","following_url":"https://api.github.com/users/tsandall/following{/other_user}","gists_url":"https://api.github.com/users/tsandall/gists{/gist_id}","starred_url":"https://api.github.com/users/tsandall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsandall/subscriptions","organizations_url":"https://api.github.com/users/tsandall/orgs","repos_url":"https://api.github.com/users/tsandall/repos","events_url":"https://api.github.com/users/tsandall/events{/privacy}","received_events_url":"https://api.github.com/users/tsandall/received_events","type":"User","site_admin":false},"body":"If object keys (or set elements) are vars, then they must be plugged\r\nbefore lookup is attempted, otherwise lookup will fail and expression\r\nwill be undefined. This could result in poor performance if rule outputs\r\nare large enough. In that case, we could revisit how the rule outputs\r\nare constructed (e.g., we could construct outputs with the first level\r\nof set/object plugged and propagate binding lists for each key/value\r\npair.)\r\n\r\nAlso, updated test runner to accept OPA_TRACE_TEST environment var to\r\nselectively enable tracing output. This is useful for debugging\r\npurposes.\r\n\r\nFixes #505","created_at":"2017-11-16T23:13:15Z","updated_at":"2017-11-16T23:17:02Z","closed_at":"2017-11-16T23:17:01Z","merged_at":"2017-11-16T23:17:01Z","merge_commit_sha":"a06d52ebc46febde3a90bb0eddc4ce6563197eab","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-policy-agent/opa/pulls/506/commits","review_comments_url":"https://api.github.com/repos/open-policy-agent/opa/pulls/506/comments","review_comment_url":"https://api.github.com/repos/open-policy-agent/opa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-policy-agent/opa/issues/506/comments","statuses_url":"https://api.github.com/repos/open-policy-agent/opa/statuses/46e8c74b548c539fc5f080cbe4b71168605167b7","head":{"label":"tsandall:fix-505","ref":"fix-505","sha":"46e8c74b548c539fc5f080cbe4b71168605167b7","user":{"login":"tsandall","id":238885,"avatar_url":"https://avatars0.githubusercontent.com/u/238885?v=4","gravatar_id":"","url":"https://api.github.com/users/tsandall","html_url":"https://github.com/tsandall","followers_url":"https://api.github.com/users/tsandall/followers","following_url":"https://api.github.com/users/tsandall/following{/other_user}","gists_url":"https://api.github.com/users/tsandall/gists{/gist_id}","starred_url":"https://api.github.com/users/tsandall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsandall/subscriptions","organizations_url":"https://api.github.com/users/tsandall/orgs","repos_url":"https://api.github.com/users/tsandall/repos","events_url":"https://api.github.com/users/tsandall/events{/privacy}","received_events_url":"https://api.github.com/users/tsandall/received_events","type":"User","site_admin":false},"repo":{"id":51776679,"name":"opa","full_name":"tsandall/opa","owner":{"login":"tsandall","id":238885,"avatar_url":"https://avatars0.githubusercontent.com/u/238885?v=4","gravatar_id":"","url":"https://api.github.com/users/tsandall","html_url":"https://github.com/tsandall","followers_url":"https://api.github.com/users/tsandall/followers","following_url":"https://api.github.com/users/tsandall/following{/other_user}","gists_url":"https://api.github.com/users/tsandall/gists{/gist_id}","starred_url":"https://api.github.com/users/tsandall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsandall/subscriptions","organizations_url":"https://api.github.com/users/tsandall/orgs","repos_url":"https://api.github.com/users/tsandall/repos","events_url":"https://api.github.com/users/tsandall/events{/privacy}","received_events_url":"https://api.github.com/users/tsandall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsandall/opa","description":"An open source project to policy-enable your service.","fork":true,"url":"https://api.github.com/repos/tsandall/opa","forks_url":"https://api.github.com/repos/tsandall/opa/forks","keys_url":"https://api.github.com/repos/tsandall/opa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsandall/opa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsandall/opa/teams","hooks_url":"https://api.github.com/repos/tsandall/opa/hooks","issue_events_url":"https://api.github.com/repos/tsandall/opa/issues/events{/number}","events_url":"https://api.github.com/repos/tsandall/opa/events","assignees_url":"https://api.github.com/repos/tsandall/opa/assignees{/user}","branches_url":"https://api.github.com/repos/tsandall/opa/branches{/branch}","tags_url":"https://api.github.com/repos/tsandall/opa/tags","blobs_url":"https://api.github.com/repos/tsandall/opa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsandall/opa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsandall/opa/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsandall/opa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsandall/opa/statuses/{sha}","languages_url":"https://api.github.com/repos/tsandall/opa/languages","stargazers_url":"https://api.github.com/repos/tsandall/opa/stargazers","contributors_url":"https://api.github.com/repos/tsandall/opa/contributors","subscribers_url":"https://api.github.com/repos/tsandall/opa/subscribers","subscription_url":"https://api.github.com/repos/tsandall/opa/subscription","commits_url":"https://api.github.com/repos/tsandall/opa/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsandall/opa/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsandall/opa/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsandall/opa/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsandall/opa/contents/{+path}","compare_url":"https://api.github.com/repos/tsandall/opa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsandall/opa/merges","archive_url":"https://api.github.com/repos/tsandall/opa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsandall/opa/downloads","issues_url":"https://api.github.com/repos/tsandall/opa/issues{/number}","pulls_url":"https://api.github.com/repos/tsandall/opa/pulls{/number}","milestones_url":"https://api.github.com/repos/tsandall/opa/milestones{/number}","notifications_url":"https://api.github.com/repos/tsandall/opa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsandall/opa/labels{/name}","releases_url":"https://api.github.com/repos/tsandall/opa/releases{/id}","deployments_url":"https://api.github.com/repos/tsandall/opa/deployments","created_at":"2016-02-15T18:37:20Z","updated_at":"2016-10-26T00:18:52Z","pushed_at":"2017-11-16T23:13:04Z","git_url":"git://github.com/tsandall/opa.git","ssh_url":"git@github.com:tsandall/opa.git","clone_url":"https://github.com/tsandall/opa.git","svn_url":"https://github.com/tsandall/opa","homepage":"","size":20225,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-policy-agent:master","ref":"master","sha":"02871a45046ca48188fc9feeca031144544c138c","user":{"login":"open-policy-agent","id":16468693,"avatar_url":"https://avatars3.githubusercontent.com/u/16468693?v=4","gravatar_id":"","url":"https://api.github.com/users/open-policy-agent","html_url":"https://github.com/open-policy-agent","followers_url":"https://api.github.com/users/open-policy-agent/followers","following_url":"https://api.github.com/users/open-policy-agent/following{/other_user}","gists_url":"https://api.github.com/users/open-policy-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/open-policy-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-policy-agent/subscriptions","organizations_url":"https://api.github.com/users/open-policy-agent/orgs","repos_url":"https://api.github.com/users/open-policy-agent/repos","events_url":"https://api.github.com/users/open-policy-agent/events{/privacy}","received_events_url":"https://api.github.com/users/open-policy-agent/received_events","type":"Organization","site_admin":false},"repo":{"id":48714685,"name":"opa","full_name":"open-policy-agent/opa","owner":{"login":"open-policy-agent","id":16468693,"avatar_url":"https://avatars3.githubusercontent.com/u/16468693?v=4","gravatar_id":"","url":"https://api.github.com/users/open-policy-agent","html_url":"https://github.com/open-policy-agent","followers_url":"https://api.github.com/users/open-policy-agent/followers","following_url":"https://api.github.com/users/open-policy-agent/following{/other_user}","gists_url":"https://api.github.com/users/open-policy-agent/gists{/gist_id}","starred_url":"https://api.github.com/users/open-policy-agent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-policy-agent/subscriptions","organizations_url":"https://api.github.com/users/open-policy-agent/orgs","repos_url":"https://api.github.com/users/open-policy-agent/repos","events_url":"https://api.github.com/users/open-policy-agent/events{/privacy}","received_events_url":"https://api.github.com/users/open-policy-agent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-policy-agent/opa","description":"An open source project to policy-enable your service.","fork":false,"url":"https://api.github.com/repos/open-policy-agent/opa","forks_url":"https://api.github.com/repos/open-policy-agent/opa/forks","keys_url":"https://api.github.com/repos/open-policy-agent/opa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-policy-agent/opa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-policy-agent/opa/teams","hooks_url":"https://api.github.com/repos/open-policy-agent/opa/hooks","issue_events_url":"https://api.github.com/repos/open-policy-agent/opa/issues/events{/number}","events_url":"https://api.github.com/repos/open-policy-agent/opa/events","assignees_url":"https://api.github.com/repos/open-policy-agent/opa/assignees{/user}","branches_url":"https://api.github.com/repos/open-policy-agent/opa/branches{/branch}","tags_url":"https://api.github.com/repos/open-policy-agent/opa/tags","blobs_url":"https://api.github.com/repos/open-policy-agent/opa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-policy-agent/opa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-policy-agent/opa/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-policy-agent/opa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-policy-agent/opa/statuses/{sha}","languages_url":"https://api.github.com/repos/open-policy-agent/opa/languages","stargazers_url":"https://api.github.com/repos/open-policy-agent/opa/stargazers","contributors_url":"https://api.github.com/repos/open-policy-agent/opa/contributors","subscribers_url":"https://api.github.com/repos/open-policy-agent/opa/subscribers","subscription_url":"https://api.github.com/repos/open-policy-agent/opa/subscription","commits_url":"https://api.github.com/repos/open-policy-agent/opa/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-policy-agent/opa/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-policy-agent/opa/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-policy-agent/opa/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-policy-agent/opa/contents/{+path}","compare_url":"https://api.github.com/repos/open-policy-agent/opa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-policy-agent/opa/merges","archive_url":"https://api.github.com/repos/open-policy-agent/opa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-policy-agent/opa/downloads","issues_url":"https://api.github.com/repos/open-policy-agent/opa/issues{/number}","pulls_url":"https://api.github.com/repos/open-policy-agent/opa/pulls{/number}","milestones_url":"https://api.github.com/repos/open-policy-agent/opa/milestones{/number}","notifications_url":"https://api.github.com/repos/open-policy-agent/opa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-policy-agent/opa/labels{/name}","releases_url":"https://api.github.com/repos/open-policy-agent/opa/releases{/id}","deployments_url":"https://api.github.com/repos/open-policy-agent/opa/deployments","created_at":"2015-12-28T22:08:25Z","updated_at":"2017-11-15T01:13:06Z","pushed_at":"2017-11-16T23:17:01Z","git_url":"git://github.com/open-policy-agent/opa.git","ssh_url":"git@github.com:open-policy-agent/opa.git","clone_url":"https://github.com/open-policy-agent/opa.git","svn_url":"https://github.com/open-policy-agent/opa","homepage":"http://openpolicyagent.org","size":21613,"stargazers_count":85,"watchers_count":85,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":41,"forks":24,"open_issues":41,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-policy-agent/opa/pulls/506"},"html":{"href":"https://github.com/open-policy-agent/opa/pull/506"},"issue":{"href":"https://api.github.com/repos/open-policy-agent/opa/issues/506"},"comments":{"href":"https://api.github.com/repos/open-policy-agent/opa/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/open-policy-agent/opa/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/open-policy-agent/opa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-policy-agent/opa/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/open-policy-agent/opa/statuses/46e8c74b548c539fc5f080cbe4b71168605167b7"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tsandall","id":238885,"avatar_url":"https://avatars0.githubusercontent.com/u/238885?v=4","gravatar_id":"","url":"https://api.github.com/users/tsandall","html_url":"https://github.com/tsandall","followers_url":"https://api.github.com/users/tsandall/followers","following_url":"https://api.github.com/users/tsandall/following{/other_user}","gists_url":"https://api.github.com/users/tsandall/gists{/gist_id}","starred_url":"https://api.github.com/users/tsandall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsandall/subscriptions","organizations_url":"https://api.github.com/users/tsandall/orgs","repos_url":"https://api.github.com/users/tsandall/repos","events_url":"https://api.github.com/users/tsandall/events{/privacy}","received_events_url":"https://api.github.com/users/tsandall/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":63,"deletions":16,"changed_files":2}}
{"actor":{"display_login":"tsandall"}}