{"action":"created","comment":{"url":"https://api.github.com/repos/jarun/nnn/pulls/comments/144186682","pull_request_review_id":68807826,"id":144186682,"diff_hunk":"@@ -23,15 +23,11 @@\n #endif\n #include <sys/inotify.h>\n #define LINUX_INOTIFY\n-#if !defined(__GLIBC__)\n-#include <sys/types.h>\n-#endif\n #endif\n #include <sys/resource.h>\n #include <sys/stat.h>\n #include <sys/statvfs.h>\n #if defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) || defined(__APPLE__)","path":"nnn.c","position":11,"original_position":11,"commit_id":"ffaf5a42cd5a9d6fca7ae49d12d114f42664259d","original_commit_id":"ffaf5a42cd5a9d6fca7ae49d12d114f42664259d","user":{"login":"jarun","id":5959286,"avatar_url":"https://avatars3.githubusercontent.com/u/5959286?v=4","gravatar_id":"","url":"https://api.github.com/users/jarun","html_url":"https://github.com/jarun","followers_url":"https://api.github.com/users/jarun/followers","following_url":"https://api.github.com/users/jarun/following{/other_user}","gists_url":"https://api.github.com/users/jarun/gists{/gist_id}","starred_url":"https://api.github.com/users/jarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarun/subscriptions","organizations_url":"https://api.github.com/users/jarun/orgs","repos_url":"https://api.github.com/users/jarun/repos","events_url":"https://api.github.com/users/jarun/events{/privacy}","received_events_url":"https://api.github.com/users/jarun/received_events","type":"User","site_admin":false},"body":"Why can't we do the following:\r\n\r\n#if defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) || defined(__APPLE__) || !defined(__GLIBC__)","created_at":"2017-10-12T03:22:53Z","updated_at":"2017-10-12T03:22:53Z","html_url":"https://github.com/jarun/nnn/pull/55#discussion_r144186682","pull_request_url":"https://api.github.com/repos/jarun/nnn/pulls/55","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jarun/nnn/pulls/comments/144186682"},"html":{"href":"https://github.com/jarun/nnn/pull/55#discussion_r144186682"},"pull_request":{"href":"https://api.github.com/repos/jarun/nnn/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/jarun/nnn/pulls/55","id":146105211,"html_url":"https://github.com/jarun/nnn/pull/55","diff_url":"https://github.com/jarun/nnn/pull/55.diff","patch_url":"https://github.com/jarun/nnn/pull/55.patch","issue_url":"https://api.github.com/repos/jarun/nnn/issues/55","number":55,"state":"open","locked":false,"title":"simplify sys/types.h inclusion","user":{"login":"maxice8","id":30738253,"avatar_url":"https://avatars3.githubusercontent.com/u/30738253?v=4","gravatar_id":"","url":"https://api.github.com/users/maxice8","html_url":"https://github.com/maxice8","followers_url":"https://api.github.com/users/maxice8/followers","following_url":"https://api.github.com/users/maxice8/following{/other_user}","gists_url":"https://api.github.com/users/maxice8/gists{/gist_id}","starred_url":"https://api.github.com/users/maxice8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxice8/subscriptions","organizations_url":"https://api.github.com/users/maxice8/orgs","repos_url":"https://api.github.com/users/maxice8/repos","events_url":"https://api.github.com/users/maxice8/events{/privacy}","received_events_url":"https://api.github.com/users/maxice8/received_events","type":"User","site_admin":false},"body":"- Remove the musl specific inclusion, there is no harm in adding it on\r\nglibc\r\n- remove from the *BSD nest and make it included in all cases","created_at":"2017-10-12T02:40:52Z","updated_at":"2017-10-12T03:22:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1af83152685d5b8782bae7745ef477aefea921ba","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jarun/nnn/pulls/55/commits","review_comments_url":"https://api.github.com/repos/jarun/nnn/pulls/55/comments","review_comment_url":"https://api.github.com/repos/jarun/nnn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jarun/nnn/issues/55/comments","statuses_url":"https://api.github.com/repos/jarun/nnn/statuses/ffaf5a42cd5a9d6fca7ae49d12d114f42664259d","head":{"label":"maxice8:simplify-types_h","ref":"simplify-types_h","sha":"ffaf5a42cd5a9d6fca7ae49d12d114f42664259d","user":{"login":"maxice8","id":30738253,"avatar_url":"https://avatars3.githubusercontent.com/u/30738253?v=4","gravatar_id":"","url":"https://api.github.com/users/maxice8","html_url":"https://github.com/maxice8","followers_url":"https://api.github.com/users/maxice8/followers","following_url":"https://api.github.com/users/maxice8/following{/other_user}","gists_url":"https://api.github.com/users/maxice8/gists{/gist_id}","starred_url":"https://api.github.com/users/maxice8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxice8/subscriptions","organizations_url":"https://api.github.com/users/maxice8/orgs","repos_url":"https://api.github.com/users/maxice8/repos","events_url":"https://api.github.com/users/maxice8/events{/privacy}","received_events_url":"https://api.github.com/users/maxice8/received_events","type":"User","site_admin":false},"repo":{"id":106635306,"name":"nnn","full_name":"maxice8/nnn","owner":{"login":"maxice8","id":30738253,"avatar_url":"https://avatars3.githubusercontent.com/u/30738253?v=4","gravatar_id":"","url":"https://api.github.com/users/maxice8","html_url":"https://github.com/maxice8","followers_url":"https://api.github.com/users/maxice8/followers","following_url":"https://api.github.com/users/maxice8/following{/other_user}","gists_url":"https://api.github.com/users/maxice8/gists{/gist_id}","starred_url":"https://api.github.com/users/maxice8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxice8/subscriptions","organizations_url":"https://api.github.com/users/maxice8/orgs","repos_url":"https://api.github.com/users/maxice8/repos","events_url":"https://api.github.com/users/maxice8/events{/privacy}","received_events_url":"https://api.github.com/users/maxice8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxice8/nnn","description":":dolphin: The missing terminal file browser for X","fork":true,"url":"https://api.github.com/repos/maxice8/nnn","forks_url":"https://api.github.com/repos/maxice8/nnn/forks","keys_url":"https://api.github.com/repos/maxice8/nnn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxice8/nnn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxice8/nnn/teams","hooks_url":"https://api.github.com/repos/maxice8/nnn/hooks","issue_events_url":"https://api.github.com/repos/maxice8/nnn/issues/events{/number}","events_url":"https://api.github.com/repos/maxice8/nnn/events","assignees_url":"https://api.github.com/repos/maxice8/nnn/assignees{/user}","branches_url":"https://api.github.com/repos/maxice8/nnn/branches{/branch}","tags_url":"https://api.github.com/repos/maxice8/nnn/tags","blobs_url":"https://api.github.com/repos/maxice8/nnn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxice8/nnn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxice8/nnn/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxice8/nnn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxice8/nnn/statuses/{sha}","languages_url":"https://api.github.com/repos/maxice8/nnn/languages","stargazers_url":"https://api.github.com/repos/maxice8/nnn/stargazers","contributors_url":"https://api.github.com/repos/maxice8/nnn/contributors","subscribers_url":"https://api.github.com/repos/maxice8/nnn/subscribers","subscription_url":"https://api.github.com/repos/maxice8/nnn/subscription","commits_url":"https://api.github.com/repos/maxice8/nnn/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxice8/nnn/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxice8/nnn/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxice8/nnn/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxice8/nnn/contents/{+path}","compare_url":"https://api.github.com/repos/maxice8/nnn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxice8/nnn/merges","archive_url":"https://api.github.com/repos/maxice8/nnn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxice8/nnn/downloads","issues_url":"https://api.github.com/repos/maxice8/nnn/issues{/number}","pulls_url":"https://api.github.com/repos/maxice8/nnn/pulls{/number}","milestones_url":"https://api.github.com/repos/maxice8/nnn/milestones{/number}","notifications_url":"https://api.github.com/repos/maxice8/nnn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxice8/nnn/labels{/name}","releases_url":"https://api.github.com/repos/maxice8/nnn/releases{/id}","deployments_url":"https://api.github.com/repos/maxice8/nnn/deployments","created_at":"2017-10-12T02:38:40Z","updated_at":"2017-10-12T02:38:42Z","pushed_at":"2017-10-12T02:40:14Z","git_url":"git://github.com/maxice8/nnn.git","ssh_url":"git@github.com:maxice8/nnn.git","clone_url":"https://github.com/maxice8/nnn.git","svn_url":"https://github.com/maxice8/nnn","homepage":"","size":901,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jarun:master","ref":"master","sha":"6dfccce55d197fd1940c7201b954a215cdaa3dcf","user":{"login":"jarun","id":5959286,"avatar_url":"https://avatars3.githubusercontent.com/u/5959286?v=4","gravatar_id":"","url":"https://api.github.com/users/jarun","html_url":"https://github.com/jarun","followers_url":"https://api.github.com/users/jarun/followers","following_url":"https://api.github.com/users/jarun/following{/other_user}","gists_url":"https://api.github.com/users/jarun/gists{/gist_id}","starred_url":"https://api.github.com/users/jarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarun/subscriptions","organizations_url":"https://api.github.com/users/jarun/orgs","repos_url":"https://api.github.com/users/jarun/repos","events_url":"https://api.github.com/users/jarun/events{/privacy}","received_events_url":"https://api.github.com/users/jarun/received_events","type":"User","site_admin":false},"repo":{"id":66150122,"name":"nnn","full_name":"jarun/nnn","owner":{"login":"jarun","id":5959286,"avatar_url":"https://avatars3.githubusercontent.com/u/5959286?v=4","gravatar_id":"","url":"https://api.github.com/users/jarun","html_url":"https://github.com/jarun","followers_url":"https://api.github.com/users/jarun/followers","following_url":"https://api.github.com/users/jarun/following{/other_user}","gists_url":"https://api.github.com/users/jarun/gists{/gist_id}","starred_url":"https://api.github.com/users/jarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarun/subscriptions","organizations_url":"https://api.github.com/users/jarun/orgs","repos_url":"https://api.github.com/users/jarun/repos","events_url":"https://api.github.com/users/jarun/events{/privacy}","received_events_url":"https://api.github.com/users/jarun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jarun/nnn","description":":dolphin: The missing terminal file browser for X","fork":false,"url":"https://api.github.com/repos/jarun/nnn","forks_url":"https://api.github.com/repos/jarun/nnn/forks","keys_url":"https://api.github.com/repos/jarun/nnn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jarun/nnn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jarun/nnn/teams","hooks_url":"https://api.github.com/repos/jarun/nnn/hooks","issue_events_url":"https://api.github.com/repos/jarun/nnn/issues/events{/number}","events_url":"https://api.github.com/repos/jarun/nnn/events","assignees_url":"https://api.github.com/repos/jarun/nnn/assignees{/user}","branches_url":"https://api.github.com/repos/jarun/nnn/branches{/branch}","tags_url":"https://api.github.com/repos/jarun/nnn/tags","blobs_url":"https://api.github.com/repos/jarun/nnn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jarun/nnn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jarun/nnn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jarun/nnn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jarun/nnn/statuses/{sha}","languages_url":"https://api.github.com/repos/jarun/nnn/languages","stargazers_url":"https://api.github.com/repos/jarun/nnn/stargazers","contributors_url":"https://api.github.com/repos/jarun/nnn/contributors","subscribers_url":"https://api.github.com/repos/jarun/nnn/subscribers","subscription_url":"https://api.github.com/repos/jarun/nnn/subscription","commits_url":"https://api.github.com/repos/jarun/nnn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jarun/nnn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jarun/nnn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jarun/nnn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jarun/nnn/contents/{+path}","compare_url":"https://api.github.com/repos/jarun/nnn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jarun/nnn/merges","archive_url":"https://api.github.com/repos/jarun/nnn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jarun/nnn/downloads","issues_url":"https://api.github.com/repos/jarun/nnn/issues{/number}","pulls_url":"https://api.github.com/repos/jarun/nnn/pulls{/number}","milestones_url":"https://api.github.com/repos/jarun/nnn/milestones{/number}","notifications_url":"https://api.github.com/repos/jarun/nnn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jarun/nnn/labels{/name}","releases_url":"https://api.github.com/repos/jarun/nnn/releases{/id}","deployments_url":"https://api.github.com/repos/jarun/nnn/deployments","created_at":"2016-08-20T14:10:14Z","updated_at":"2017-10-11T18:15:37Z","pushed_at":"2017-10-12T02:40:53Z","git_url":"git://github.com/jarun/nnn.git","ssh_url":"git@github.com:jarun/nnn.git","clone_url":"https://github.com/jarun/nnn.git","svn_url":"https://github.com/jarun/nnn","homepage":"","size":901,"stargazers_count":439,"watchers_count":439,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":2,"forks":24,"open_issues":2,"watchers":439,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jarun/nnn/pulls/55"},"html":{"href":"https://github.com/jarun/nnn/pull/55"},"issue":{"href":"https://api.github.com/repos/jarun/nnn/issues/55"},"comments":{"href":"https://api.github.com/repos/jarun/nnn/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/jarun/nnn/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/jarun/nnn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jarun/nnn/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/jarun/nnn/statuses/ffaf5a42cd5a9d6fca7ae49d12d114f42664259d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jarun"}}