{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/comments/127301114","pull_request_review_id":49872476,"id":127301114,"diff_hunk":"@@ -255,7 +255,7 @@ SET @prior_rocksdb_merge_buf_size = @@rocksdb_merge_buf_size;\n \n SET global rocksdb_strict_collation_check = off;\n SET session rocksdb_merge_combine_read_size = 566;\n-SET session rocksdb_merge_buf_size = 336;\n+SET session rocksdb_merge_buf_size = 340;","path":"mysql-test/suite/rocksdb/t/add_index_inplace.test","position":5,"original_position":5,"commit_id":"f879c0a087f654ec3b82da1d6418508a48b654bd","original_commit_id":"51bf64cbb83f28811f5f2010abc26a3e4a8a1c91","user":{"login":"pbjc","id":3849047,"avatar_url":"https://avatars0.githubusercontent.com/u/3849047?v=3","gravatar_id":"","url":"https://api.github.com/users/pbjc","html_url":"https://github.com/pbjc","followers_url":"https://api.github.com/users/pbjc/followers","following_url":"https://api.github.com/users/pbjc/following{/other_user}","gists_url":"https://api.github.com/users/pbjc/gists{/gist_id}","starred_url":"https://api.github.com/users/pbjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbjc/subscriptions","organizations_url":"https://api.github.com/users/pbjc/orgs","repos_url":"https://api.github.com/users/pbjc/repos","events_url":"https://api.github.com/users/pbjc/events{/privacy}","received_events_url":"https://api.github.com/users/pbjc/received_events","type":"User","site_admin":false},"body":"Update: The bitmap is now used only for partially covering key parts and is not stored if there are no such key parts.","created_at":"2017-07-13T18:52:17Z","updated_at":"2017-07-13T18:52:17Z","html_url":"https://github.com/facebook/mysql-5.6/pull/639#discussion_r127301114","pull_request_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/639","_links":{"self":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/comments/127301114"},"html":{"href":"https://github.com/facebook/mysql-5.6/pull/639#discussion_r127301114"},"pull_request":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/639"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/639","id":126629423,"html_url":"https://github.com/facebook/mysql-5.6/pull/639","diff_url":"https://github.com/facebook/mysql-5.6/pull/639.diff","patch_url":"https://github.com/facebook/mysql-5.6/pull/639.patch","issue_url":"https://api.github.com/repos/facebook/mysql-5.6/issues/639","number":639,"state":"open","locked":false,"title":"Support covering secondary key lookups for varchars","user":{"login":"pbjc","id":3849047,"avatar_url":"https://avatars0.githubusercontent.com/u/3849047?v=3","gravatar_id":"","url":"https://api.github.com/users/pbjc","html_url":"https://github.com/pbjc","followers_url":"https://api.github.com/users/pbjc/followers","following_url":"https://api.github.com/users/pbjc/following{/other_user}","gists_url":"https://api.github.com/users/pbjc/gists{/gist_id}","starred_url":"https://api.github.com/users/pbjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbjc/subscriptions","organizations_url":"https://api.github.com/users/pbjc/orgs","repos_url":"https://api.github.com/users/pbjc/repos","events_url":"https://api.github.com/users/pbjc/events{/privacy}","received_events_url":"https://api.github.com/users/pbjc/received_events","type":"User","site_admin":false},"body":"Addresses #303. Changes:\r\n- Adds a status var called `ROCKSDB_COVERED_SECONDARY_KEY_LOOKUPS` which is incremented when we avoid reading a record via a keyread.\r\n- Bumps the SK format version.\r\n- Modifies `Rdb_key_def::pack_record` to store, for secondary indexes using unpack_info (i.e. containing varchars or strings), a 2-byte bitmap in the unpack info after the header. This is the \"covered bitmap\", where each bit corresponds to a keypart. A bit is set if that keypart contains the entire column value. Bits are only used currently for varchar columns, but could later be extended to blobs/text.\r\n- Modifies `unpack_record` to reflect `pack_record` changes.\r\n- Adds a new data tag for unpack_info called `RDB_UNPACK_COVERED_DATA_TAG`. This is used in place of `RDB_UNPACK_DATA_TAG` to indicate a covered bitmap is present in unpack_info.\r\n- Backwards-compatible with older formats.\r\n- Adds `Rdb_key_def::covers_lookup()`, which returns true if all of the columns requested by a query are covered by the secondary key. This is used in `read_row_from_secondary_key` and `secondary_index_read`.\r\n\r\nNote: This doesn't support blobs/text yet, like the example in #303, since we currently skip unpacking blobs in unpack_record.","created_at":"2017-06-20T21:04:00Z","updated_at":"2017-07-13T18:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f189aad8871dbfda7f4c052cbd9b67c30e67649","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alxyang","id":2774449,"avatar_url":"https://avatars3.githubusercontent.com/u/2774449?v=3","gravatar_id":"","url":"https://api.github.com/users/alxyang","html_url":"https://github.com/alxyang","followers_url":"https://api.github.com/users/alxyang/followers","following_url":"https://api.github.com/users/alxyang/following{/other_user}","gists_url":"https://api.github.com/users/alxyang/gists{/gist_id}","starred_url":"https://api.github.com/users/alxyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxyang/subscriptions","organizations_url":"https://api.github.com/users/alxyang/orgs","repos_url":"https://api.github.com/users/alxyang/repos","events_url":"https://api.github.com/users/alxyang/events{/privacy}","received_events_url":"https://api.github.com/users/alxyang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/639/commits","review_comments_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/639/comments","review_comment_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/mysql-5.6/issues/639/comments","statuses_url":"https://api.github.com/repos/facebook/mysql-5.6/statuses/f879c0a087f654ec3b82da1d6418508a48b654bd","head":{"label":"pbjc:covering-sk-lookup-text","ref":"covering-sk-lookup-text","sha":"f879c0a087f654ec3b82da1d6418508a48b654bd","user":{"login":"pbjc","id":3849047,"avatar_url":"https://avatars0.githubusercontent.com/u/3849047?v=3","gravatar_id":"","url":"https://api.github.com/users/pbjc","html_url":"https://github.com/pbjc","followers_url":"https://api.github.com/users/pbjc/followers","following_url":"https://api.github.com/users/pbjc/following{/other_user}","gists_url":"https://api.github.com/users/pbjc/gists{/gist_id}","starred_url":"https://api.github.com/users/pbjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbjc/subscriptions","organizations_url":"https://api.github.com/users/pbjc/orgs","repos_url":"https://api.github.com/users/pbjc/repos","events_url":"https://api.github.com/users/pbjc/events{/privacy}","received_events_url":"https://api.github.com/users/pbjc/received_events","type":"User","site_admin":false},"repo":{"id":93085713,"name":"mysql-5.6","full_name":"pbjc/mysql-5.6","owner":{"login":"pbjc","id":3849047,"avatar_url":"https://avatars0.githubusercontent.com/u/3849047?v=3","gravatar_id":"","url":"https://api.github.com/users/pbjc","html_url":"https://github.com/pbjc","followers_url":"https://api.github.com/users/pbjc/followers","following_url":"https://api.github.com/users/pbjc/following{/other_user}","gists_url":"https://api.github.com/users/pbjc/gists{/gist_id}","starred_url":"https://api.github.com/users/pbjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbjc/subscriptions","organizations_url":"https://api.github.com/users/pbjc/orgs","repos_url":"https://api.github.com/users/pbjc/repos","events_url":"https://api.github.com/users/pbjc/events{/privacy}","received_events_url":"https://api.github.com/users/pbjc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbjc/mysql-5.6","description":"Facebook's branch of the Oracle MySQL v5.6 database. This includes MyRocks.","fork":true,"url":"https://api.github.com/repos/pbjc/mysql-5.6","forks_url":"https://api.github.com/repos/pbjc/mysql-5.6/forks","keys_url":"https://api.github.com/repos/pbjc/mysql-5.6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbjc/mysql-5.6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbjc/mysql-5.6/teams","hooks_url":"https://api.github.com/repos/pbjc/mysql-5.6/hooks","issue_events_url":"https://api.github.com/repos/pbjc/mysql-5.6/issues/events{/number}","events_url":"https://api.github.com/repos/pbjc/mysql-5.6/events","assignees_url":"https://api.github.com/repos/pbjc/mysql-5.6/assignees{/user}","branches_url":"https://api.github.com/repos/pbjc/mysql-5.6/branches{/branch}","tags_url":"https://api.github.com/repos/pbjc/mysql-5.6/tags","blobs_url":"https://api.github.com/repos/pbjc/mysql-5.6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbjc/mysql-5.6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbjc/mysql-5.6/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbjc/mysql-5.6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbjc/mysql-5.6/statuses/{sha}","languages_url":"https://api.github.com/repos/pbjc/mysql-5.6/languages","stargazers_url":"https://api.github.com/repos/pbjc/mysql-5.6/stargazers","contributors_url":"https://api.github.com/repos/pbjc/mysql-5.6/contributors","subscribers_url":"https://api.github.com/repos/pbjc/mysql-5.6/subscribers","subscription_url":"https://api.github.com/repos/pbjc/mysql-5.6/subscription","commits_url":"https://api.github.com/repos/pbjc/mysql-5.6/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbjc/mysql-5.6/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbjc/mysql-5.6/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbjc/mysql-5.6/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbjc/mysql-5.6/contents/{+path}","compare_url":"https://api.github.com/repos/pbjc/mysql-5.6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbjc/mysql-5.6/merges","archive_url":"https://api.github.com/repos/pbjc/mysql-5.6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbjc/mysql-5.6/downloads","issues_url":"https://api.github.com/repos/pbjc/mysql-5.6/issues{/number}","pulls_url":"https://api.github.com/repos/pbjc/mysql-5.6/pulls{/number}","milestones_url":"https://api.github.com/repos/pbjc/mysql-5.6/milestones{/number}","notifications_url":"https://api.github.com/repos/pbjc/mysql-5.6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbjc/mysql-5.6/labels{/name}","releases_url":"https://api.github.com/repos/pbjc/mysql-5.6/releases{/id}","deployments_url":"https://api.github.com/repos/pbjc/mysql-5.6/deployments","created_at":"2017-06-01T18:06:00Z","updated_at":"2017-06-01T18:06:58Z","pushed_at":"2017-07-13T18:39:00Z","git_url":"git://github.com/pbjc/mysql-5.6.git","ssh_url":"git@github.com:pbjc/mysql-5.6.git","clone_url":"https://github.com/pbjc/mysql-5.6.git","svn_url":"https://github.com/pbjc/mysql-5.6","homepage":"https://github.com/facebook/mysql-5.6","size":365322,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"fb-mysql-5.6.35"}},"base":{"label":"facebook:fb-mysql-5.6.35","ref":"fb-mysql-5.6.35","sha":"20e993f5435391eb828cb653e953f759e2e960d1","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":9454675,"name":"mysql-5.6","full_name":"facebook/mysql-5.6","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/mysql-5.6","description":"Facebook's branch of the Oracle MySQL v5.6 database. This includes MyRocks.","fork":false,"url":"https://api.github.com/repos/facebook/mysql-5.6","forks_url":"https://api.github.com/repos/facebook/mysql-5.6/forks","keys_url":"https://api.github.com/repos/facebook/mysql-5.6/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/mysql-5.6/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/mysql-5.6/teams","hooks_url":"https://api.github.com/repos/facebook/mysql-5.6/hooks","issue_events_url":"https://api.github.com/repos/facebook/mysql-5.6/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/mysql-5.6/events","assignees_url":"https://api.github.com/repos/facebook/mysql-5.6/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/mysql-5.6/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/mysql-5.6/tags","blobs_url":"https://api.github.com/repos/facebook/mysql-5.6/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/mysql-5.6/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/mysql-5.6/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/mysql-5.6/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/mysql-5.6/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/mysql-5.6/languages","stargazers_url":"https://api.github.com/repos/facebook/mysql-5.6/stargazers","contributors_url":"https://api.github.com/repos/facebook/mysql-5.6/contributors","subscribers_url":"https://api.github.com/repos/facebook/mysql-5.6/subscribers","subscription_url":"https://api.github.com/repos/facebook/mysql-5.6/subscription","commits_url":"https://api.github.com/repos/facebook/mysql-5.6/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/mysql-5.6/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/mysql-5.6/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/mysql-5.6/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/mysql-5.6/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/mysql-5.6/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/mysql-5.6/merges","archive_url":"https://api.github.com/repos/facebook/mysql-5.6/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/mysql-5.6/downloads","issues_url":"https://api.github.com/repos/facebook/mysql-5.6/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/mysql-5.6/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/mysql-5.6/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/mysql-5.6/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/mysql-5.6/labels{/name}","releases_url":"https://api.github.com/repos/facebook/mysql-5.6/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/mysql-5.6/deployments","created_at":"2013-04-15T17:54:43Z","updated_at":"2017-07-13T01:10:59Z","pushed_at":"2017-07-13T18:39:02Z","git_url":"git://github.com/facebook/mysql-5.6.git","ssh_url":"git@github.com:facebook/mysql-5.6.git","clone_url":"https://github.com/facebook/mysql-5.6.git","svn_url":"https://github.com/facebook/mysql-5.6","homepage":"https://github.com/facebook/mysql-5.6","size":413600,"stargazers_count":983,"watchers_count":983,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":346,"mirror_url":null,"open_issues_count":83,"forks":346,"open_issues":83,"watchers":983,"default_branch":"fb-mysql-5.6.35"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/639"},"html":{"href":"https://github.com/facebook/mysql-5.6/pull/639"},"issue":{"href":"https://api.github.com/repos/facebook/mysql-5.6/issues/639"},"comments":{"href":"https://api.github.com/repos/facebook/mysql-5.6/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/mysql-5.6/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/mysql-5.6/statuses/f879c0a087f654ec3b82da1d6418508a48b654bd"}}}}
{"actor":{"display_login":"pbjc"}}