{"action":"created","issue":{"url":"https://api.github.com/repos/ros/ros_comm/issues/1129","repository_url":"https://api.github.com/repos/ros/ros_comm","labels_url":"https://api.github.com/repos/ros/ros_comm/issues/1129/labels{/name}","comments_url":"https://api.github.com/repos/ros/ros_comm/issues/1129/comments","events_url":"https://api.github.com/repos/ros/ros_comm/issues/1129/events","html_url":"https://github.com/ros/ros_comm/pull/1129","id":249402276,"number":1129,"title":"improve SteadyTimer tests","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-08-10T16:20:06Z","updated_at":"2017-08-10T21:09:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ros/ros_comm/pulls/1129","html_url":"https://github.com/ros/ros_comm/pull/1129","diff_url":"https://github.com/ros/ros_comm/pull/1129.diff","patch_url":"https://github.com/ros/ros_comm/pull/1129.patch"},"body":"Rebased and squashed #1120 in the hope that it further reduces the flakyness of the SteadyTimer test."},"comment":{"url":"https://api.github.com/repos/ros/ros_comm/issues/comments/321674009","html_url":"https://github.com/ros/ros_comm/pull/1129#issuecomment-321674009","issue_url":"https://api.github.com/repos/ros/ros_comm/issues/1129","id":321674009,"user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T21:09:02Z","updated_at":"2017-08-10T21:09:02Z","body":"With the introduction of `SteadyTime` the `TimerManager` has been switch to use that instead of `WallTime`. I would expect that the test coverage for the new `SteadyTimer` is at least as good as the existing test coverage for `WallTimer`. So just removing the test is imo not an option. In fact the tests for these two timers should even be identical (and pass) in order to justify that this change likely doesn't  introduce any regressions."}}
{"actor":{"display_login":"dirk-thomas"}}