{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/31458","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/31458/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/31458/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/31458/events","html_url":"https://github.com/NixOS/nixpkgs/pull/31458","id":272774463,"number":31458,"title":"ibus-with-plugins: fix ibus-setup","user":{"login":"cstrahan","id":143982,"avatar_url":"https://avatars0.githubusercontent.com/u/143982?v=4","gravatar_id":"","url":"https://api.github.com/users/cstrahan","html_url":"https://github.com/cstrahan","followers_url":"https://api.github.com/users/cstrahan/followers","following_url":"https://api.github.com/users/cstrahan/following{/other_user}","gists_url":"https://api.github.com/users/cstrahan/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrahan/subscriptions","organizations_url":"https://api.github.com/users/cstrahan/orgs","repos_url":"https://api.github.com/users/cstrahan/repos","events_url":"https://api.github.com/users/cstrahan/events{/privacy}","received_events_url":"https://api.github.com/users/cstrahan/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731734101,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100","name":"10.rebuild-linux: 11-100","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-11-10T00:05:53Z","updated_at":"2017-11-10T21:23:11Z","closed_at":"2017-11-10T21:23:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/31458","html_url":"https://github.com/NixOS/nixpkgs/pull/31458","diff_url":"https://github.com/NixOS/nixpkgs/pull/31458.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/31458.patch"},"body":"This makes ibus-daemon find ibus-setup through a env var,\r\nso we can continue to leave Python out of the ibus closure.\r\n\r\n###### Motivation for this change\r\n\r\nFixes: #31454, #30265\r\n\r\nRelated to: #31094\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/343590490","html_url":"https://github.com/NixOS/nixpkgs/pull/31458#issuecomment-343590490","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/31458","id":343590490,"user":{"login":"cstrahan","id":143982,"avatar_url":"https://avatars0.githubusercontent.com/u/143982?v=4","gravatar_id":"","url":"https://api.github.com/users/cstrahan","html_url":"https://github.com/cstrahan","followers_url":"https://api.github.com/users/cstrahan/followers","following_url":"https://api.github.com/users/cstrahan/following{/other_user}","gists_url":"https://api.github.com/users/cstrahan/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrahan/subscriptions","organizations_url":"https://api.github.com/users/cstrahan/orgs","repos_url":"https://api.github.com/users/cstrahan/repos","events_url":"https://api.github.com/users/cstrahan/events{/privacy}","received_events_url":"https://api.github.com/users/cstrahan/received_events","type":"User","site_admin":false},"created_at":"2017-11-10T21:23:11Z","updated_at":"2017-11-10T21:23:11Z","author_association":"CONTRIBUTOR","body":"@yegortimoshenko\r\n\r\n> I disagree with this approach. I think python3.buildEnv should be patched so that it doesn't pull in dev paths. pygobject3 itself or python3 don't:\r\n\r\nMy chief concern is this: @edolstra has stated that he won't accept having python in the `ibus` closure -- he hasn't expressed any concern with having an `ibus-with-plugins` require a python env which in turn depends on `ibus.out`/`ibus.dev`. So I see your concern as being orthogonal (though perfectly valid) to my own, and that's why I say that I'd like to get this (or something similar) merged first.\r\n\r\nActually, there's only one other valid option that'll satisfy Eelco's requirements, though I consider it a bad design: put `ibus-setup` back in `${ibus.out}/bin`, but overwrite the contents so that it's a simple script that  invokes `python $out/share/ibus/setup/main.py \"$@\"` (note that we're expecting that `python` is on `$PATH`, and _not_ referring to any particular store path). Now, when someone runs the wrapped `ibus-daemon` (from the `ibus-with-plugins` package) the `$PATH`/`$PYTHONPATH`/etc will be set up such that the unwrapped `ibus-setup` will inherit all the env vars that it needs and execute properly. **But here's the catch:** we'll still need to wrap `ibus-setup` in `ibus-with-plugins` so that users can execute `ibus-setup` directly, rather than through the `ibus-daemon` applet. My intuition tells me that it's a bit odd to execute (wrapped `ibus-daemon`) which executes (unwrapped `ibus-setup`), while still putting a wrapped `ibus-setup` on the path. Also, with my approach the unwrapped `ibus That approach isn't wrong, it just makes the logic a little more nuanced ( The upside, though, is that we don't need any patches.\r\n\r\n(Correct me if I'm not interpreting your point correctly.)"}}
{"actor":{"display_login":"cstrahan"}}