{"action":"created","issue":{"url":"https://api.github.com/repos/apereo/cas/issues/2970","repository_url":"https://api.github.com/repos/apereo/cas","labels_url":"https://api.github.com/repos/apereo/cas/issues/2970/labels{/name}","comments_url":"https://api.github.com/repos/apereo/cas/issues/2970/comments","events_url":"https://api.github.com/repos/apereo/cas/issues/2970/events","html_url":"https://github.com/apereo/cas/pull/2970","id":262739085,"number":2970,"title":"SAML2ClientLogoutAction Fix - Use Specific SAML2 Client [branch master]","user":{"login":"jkacer","id":8087002,"avatar_url":"https://avatars3.githubusercontent.com/u/8087002?v=4","gravatar_id":"","url":"https://api.github.com/users/jkacer","html_url":"https://github.com/jkacer","followers_url":"https://api.github.com/users/jkacer/followers","following_url":"https://api.github.com/users/jkacer/following{/other_user}","gists_url":"https://api.github.com/users/jkacer/gists{/gist_id}","starred_url":"https://api.github.com/users/jkacer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkacer/subscriptions","organizations_url":"https://api.github.com/users/jkacer/orgs","repos_url":"https://api.github.com/users/jkacer/repos","events_url":"https://api.github.com/users/jkacer/events{/privacy}","received_events_url":"https://api.github.com/users/jkacer/received_events","type":"User","site_admin":false},"labels":[{"id":114069504,"url":"https://api.github.com/repos/apereo/cas/labels/Improvement","name":"Improvement","color":"009800","default":false},{"id":266643234,"url":"https://api.github.com/repos/apereo/cas/labels/Logout%20&%20SLO","name":"Logout & SLO","color":"1d76db","default":false},{"id":465463780,"url":"https://api.github.com/repos/apereo/cas/labels/SAML2%20Protocol","name":"SAML2 Protocol","color":"1d76db","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/apereo/cas/milestones/58","html_url":"https://github.com/apereo/cas/milestone/58","labels_url":"https://api.github.com/repos/apereo/cas/milestones/58/labels","id":2546417,"number":58,"title":"5.2.0-RC4","description":"CAS 5.2.0-RC4 Feature Release Candidate","creator":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars1.githubusercontent.com/u/1205228?v=4","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":23,"state":"open","created_at":"2017-05-27T18:15:22Z","updated_at":"2017-10-04T11:24:19Z","due_on":"2017-10-16T07:00:00Z","closed_at":null},"comments":3,"created_at":"2017-10-04T10:31:25Z","updated_at":"2017-10-04T11:29:52Z","closed_at":"2017-10-04T11:24:12Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apereo/cas/pulls/2970","html_url":"https://github.com/apereo/cas/pull/2970","diff_url":"https://github.com/apereo/cas/pull/2970.diff","patch_url":"https://github.com/apereo/cas/pull/2970.patch"},"body":"This is the same pull request as #2967 , just for the master branch.\r\n\r\n--\r\n\r\nWe encountered a little issue with the SAML2 Client Logout Action with PAC4J. This pull request should fix it for CAS 5.1.\r\nThe action took a random (any) SAML2 client from all PAC4J clients. This worked fine if there were\r\nexactly 1 SAML2 client in the system and just this client was used. However, it did not work if no PAC4J client was used (standard login) or if there were more than 1 SAML2 client.\r\nNow, the SAML2ClientLogoutAction now takes into account the currently used PAC4J client, which is resolved from the PAC4J user profile.\r\n\r\nTo test:\r\n- Configure CAS with PAC4J and at least 2 different SAML2 clients\r\n- Log in using SAML\r\n- Log out\r\n- The logout should take you to the correct IdP server (provided it supports single logout)\r\n- Log in without SAML\r\n- Log out\r\n- You should end on the CAS Logout screen. You should not be redirected anywhere (this was happening with more SAML clients configured but not used for login).\r\n\r\nAssumption:\r\n\r\n- The PAC4J user profile should be in the user session during logout, accessible with PAC4J Profile Manager. Currently this is not true but can be achieved, we already have working code for that; we will discuss it with PAC4J developers, as suggested on the CAS DEV list.\r\n\r\nThank you!"},"comment":{"url":"https://api.github.com/repos/apereo/cas/issues/comments/334126781","html_url":"https://github.com/apereo/cas/pull/2970#issuecomment-334126781","issue_url":"https://api.github.com/repos/apereo/cas/issues/2970","id":334126781,"user":{"login":"jkacer","id":8087002,"avatar_url":"https://avatars3.githubusercontent.com/u/8087002?v=4","gravatar_id":"","url":"https://api.github.com/users/jkacer","html_url":"https://github.com/jkacer","followers_url":"https://api.github.com/users/jkacer/followers","following_url":"https://api.github.com/users/jkacer/following{/other_user}","gists_url":"https://api.github.com/users/jkacer/gists{/gist_id}","starred_url":"https://api.github.com/users/jkacer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkacer/subscriptions","organizations_url":"https://api.github.com/users/jkacer/orgs","repos_url":"https://api.github.com/users/jkacer/repos","events_url":"https://api.github.com/users/jkacer/events{/privacy}","received_events_url":"https://api.github.com/users/jkacer/received_events","type":"User","site_admin":false},"created_at":"2017-10-04T11:29:52Z","updated_at":"2017-10-04T11:29:52Z","author_association":"CONTRIBUTOR","body":"Yes, I hope to start the discussion today, I must publish the materials first. I'll put a comment to the CAS DEV mailing list where we started."}}
{"actor":{"display_login":"jkacer"}}