{"action":"created","comment":{"url":"https://api.github.com/repos/openclonk/openclonk/pulls/comments/113525951","pull_request_review_id":34922086,"id":113525951,"diff_hunk":"@@ -87,9 +87,8 @@ bool StdScheduler::DoScheduleProcs(int iTimeout)\n \t// Iterate over the index because procedures may be added or removed during execution\n \t// (If they are removed, we skip one execution, which doesn't really matter in practice)\n \tauto tNow = C4TimeMilliseconds::Now();\n-\tfor (size_t i_proc = 0u; i_proc < procs.size(); ++i_proc)","path":"src/platform/StdSchedulerWin32.cpp","position":4,"original_position":4,"commit_id":"57fef90bf4192e07b8b5cbe2070e69cd03453ef5","original_commit_id":"57fef90bf4192e07b8b5cbe2070e69cd03453ef5","user":{"login":"lluchs","id":516527,"avatar_url":"https://avatars0.githubusercontent.com/u/516527?v=3","gravatar_id":"","url":"https://api.github.com/users/lluchs","html_url":"https://github.com/lluchs","followers_url":"https://api.github.com/users/lluchs/followers","following_url":"https://api.github.com/users/lluchs/following{/other_user}","gists_url":"https://api.github.com/users/lluchs/gists{/gist_id}","starred_url":"https://api.github.com/users/lluchs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluchs/subscriptions","organizations_url":"https://api.github.com/users/lluchs/orgs","repos_url":"https://api.github.com/users/lluchs/repos","events_url":"https://api.github.com/users/lluchs/events{/privacy}","received_events_url":"https://api.github.com/users/lluchs/received_events","type":"User","site_admin":false},"body":"This transformation is invalid, as the comment above explains. There are a couple more replacements like this one throughout the patch where I don't know whether iterator invalidation is an issue. I guess we'll see if anything crashes.","created_at":"2017-04-26T18:16:49Z","updated_at":"2017-04-26T18:26:20Z","html_url":"https://github.com/openclonk/openclonk/pull/41#discussion_r113525951","pull_request_url":"https://api.github.com/repos/openclonk/openclonk/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/openclonk/openclonk/pulls/comments/113525951"},"html":{"href":"https://github.com/openclonk/openclonk/pull/41#discussion_r113525951"},"pull_request":{"href":"https://api.github.com/repos/openclonk/openclonk/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/openclonk/openclonk/pulls/41","id":117501323,"html_url":"https://github.com/openclonk/openclonk/pull/41","diff_url":"https://github.com/openclonk/openclonk/pull/41.diff","patch_url":"https://github.com/openclonk/openclonk/pull/41.patch","issue_url":"https://api.github.com/repos/openclonk/openclonk/issues/41","number":41,"state":"open","locked":false,"title":"Automatic fixes using clang-tidy","user":{"login":"tusharpm","id":3054805,"avatar_url":"https://avatars3.githubusercontent.com/u/3054805?v=3","gravatar_id":"","url":"https://api.github.com/users/tusharpm","html_url":"https://github.com/tusharpm","followers_url":"https://api.github.com/users/tusharpm/followers","following_url":"https://api.github.com/users/tusharpm/following{/other_user}","gists_url":"https://api.github.com/users/tusharpm/gists{/gist_id}","starred_url":"https://api.github.com/users/tusharpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusharpm/subscriptions","organizations_url":"https://api.github.com/users/tusharpm/orgs","repos_url":"https://api.github.com/users/tusharpm/repos","events_url":"https://api.github.com/users/tusharpm/events{/privacy}","received_events_url":"https://api.github.com/users/tusharpm/received_events","type":"User","site_admin":false},"body":"Following [the discussion on the forum](http://forum.openclonk.org/topic_show.pl?pid=33027), I ran a batch script to run clang-tidy with \"modernize\" checks enabled to make changes to the cpp files (no modifications to the header files, and files in thirdparty).\r\nI have cleaned up the machine errors I could find, and as pointed out by others in the discussion.\r\n\r\nMost of the changes can be summarized as follows:\r\n- use C++ headers from the standard instead of the C-style ones.\r\n- use bool literals (`false` or `true` instead of `0` or `1` respectively)\r\n- use of null pointer (`nullptr` instead of `0`)\r\n- change string-literals containing escape sequences to raw-string-literals.\r\n- change for loops to range-for loops wherever applicable.\r\n- use emplace (and similar) for containers wherever applicable.\r\n- use `auto` instead of type names in select places (mostly range-for loop variable). I've reverted most usages of `auto` (501 to be exact) [as requested on the forum](http://forum.openclonk.org/topic_show.pl?pid=33014).\r\n\r\nAfter the change, I've built the solution locally on Windows (MSVC), and Travis builds succeeded.","created_at":"2017-04-25T14:38:53Z","updated_at":"2017-04-26T18:26:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d11c0fb74824199faf6ee5ab729251a20e89d29","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openclonk/openclonk/pulls/41/commits","review_comments_url":"https://api.github.com/repos/openclonk/openclonk/pulls/41/comments","review_comment_url":"https://api.github.com/repos/openclonk/openclonk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openclonk/openclonk/issues/41/comments","statuses_url":"https://api.github.com/repos/openclonk/openclonk/statuses/57fef90bf4192e07b8b5cbe2070e69cd03453ef5","head":{"label":"tusharpm:clangtidy-noauto","ref":"clangtidy-noauto","sha":"57fef90bf4192e07b8b5cbe2070e69cd03453ef5","user":{"login":"tusharpm","id":3054805,"avatar_url":"https://avatars3.githubusercontent.com/u/3054805?v=3","gravatar_id":"","url":"https://api.github.com/users/tusharpm","html_url":"https://github.com/tusharpm","followers_url":"https://api.github.com/users/tusharpm/followers","following_url":"https://api.github.com/users/tusharpm/following{/other_user}","gists_url":"https://api.github.com/users/tusharpm/gists{/gist_id}","starred_url":"https://api.github.com/users/tusharpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusharpm/subscriptions","organizations_url":"https://api.github.com/users/tusharpm/orgs","repos_url":"https://api.github.com/users/tusharpm/repos","events_url":"https://api.github.com/users/tusharpm/events{/privacy}","received_events_url":"https://api.github.com/users/tusharpm/received_events","type":"User","site_admin":false},"repo":{"id":85454140,"name":"openclonk","full_name":"tusharpm/openclonk","owner":{"login":"tusharpm","id":3054805,"avatar_url":"https://avatars3.githubusercontent.com/u/3054805?v=3","gravatar_id":"","url":"https://api.github.com/users/tusharpm","html_url":"https://github.com/tusharpm","followers_url":"https://api.github.com/users/tusharpm/followers","following_url":"https://api.github.com/users/tusharpm/following{/other_user}","gists_url":"https://api.github.com/users/tusharpm/gists{/gist_id}","starred_url":"https://api.github.com/users/tusharpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tusharpm/subscriptions","organizations_url":"https://api.github.com/users/tusharpm/orgs","repos_url":"https://api.github.com/users/tusharpm/repos","events_url":"https://api.github.com/users/tusharpm/events{/privacy}","received_events_url":"https://api.github.com/users/tusharpm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tusharpm/openclonk","description":"A free multiplayer action game where you control small and nimble humanoids","fork":true,"url":"https://api.github.com/repos/tusharpm/openclonk","forks_url":"https://api.github.com/repos/tusharpm/openclonk/forks","keys_url":"https://api.github.com/repos/tusharpm/openclonk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tusharpm/openclonk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tusharpm/openclonk/teams","hooks_url":"https://api.github.com/repos/tusharpm/openclonk/hooks","issue_events_url":"https://api.github.com/repos/tusharpm/openclonk/issues/events{/number}","events_url":"https://api.github.com/repos/tusharpm/openclonk/events","assignees_url":"https://api.github.com/repos/tusharpm/openclonk/assignees{/user}","branches_url":"https://api.github.com/repos/tusharpm/openclonk/branches{/branch}","tags_url":"https://api.github.com/repos/tusharpm/openclonk/tags","blobs_url":"https://api.github.com/repos/tusharpm/openclonk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tusharpm/openclonk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tusharpm/openclonk/git/refs{/sha}","trees_url":"https://api.github.com/repos/tusharpm/openclonk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tusharpm/openclonk/statuses/{sha}","languages_url":"https://api.github.com/repos/tusharpm/openclonk/languages","stargazers_url":"https://api.github.com/repos/tusharpm/openclonk/stargazers","contributors_url":"https://api.github.com/repos/tusharpm/openclonk/contributors","subscribers_url":"https://api.github.com/repos/tusharpm/openclonk/subscribers","subscription_url":"https://api.github.com/repos/tusharpm/openclonk/subscription","commits_url":"https://api.github.com/repos/tusharpm/openclonk/commits{/sha}","git_commits_url":"https://api.github.com/repos/tusharpm/openclonk/git/commits{/sha}","comments_url":"https://api.github.com/repos/tusharpm/openclonk/comments{/number}","issue_comment_url":"https://api.github.com/repos/tusharpm/openclonk/issues/comments{/number}","contents_url":"https://api.github.com/repos/tusharpm/openclonk/contents/{+path}","compare_url":"https://api.github.com/repos/tusharpm/openclonk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tusharpm/openclonk/merges","archive_url":"https://api.github.com/repos/tusharpm/openclonk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tusharpm/openclonk/downloads","issues_url":"https://api.github.com/repos/tusharpm/openclonk/issues{/number}","pulls_url":"https://api.github.com/repos/tusharpm/openclonk/pulls{/number}","milestones_url":"https://api.github.com/repos/tusharpm/openclonk/milestones{/number}","notifications_url":"https://api.github.com/repos/tusharpm/openclonk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tusharpm/openclonk/labels{/name}","releases_url":"https://api.github.com/repos/tusharpm/openclonk/releases{/id}","deployments_url":"https://api.github.com/repos/tusharpm/openclonk/deployments","created_at":"2017-03-19T05:51:32Z","updated_at":"2017-03-19T05:51:42Z","pushed_at":"2017-04-26T12:35:51Z","git_url":"git://github.com/tusharpm/openclonk.git","ssh_url":"git@github.com:tusharpm/openclonk.git","clone_url":"https://github.com/tusharpm/openclonk.git","svn_url":"https://github.com/tusharpm/openclonk","homepage":"http://www.openclonk.org/","size":282473,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openclonk:master","ref":"master","sha":"6f1470dbbdf8157e26d957b791d6780f4983fd76","user":{"login":"openclonk","id":4697210,"avatar_url":"https://avatars3.githubusercontent.com/u/4697210?v=3","gravatar_id":"","url":"https://api.github.com/users/openclonk","html_url":"https://github.com/openclonk","followers_url":"https://api.github.com/users/openclonk/followers","following_url":"https://api.github.com/users/openclonk/following{/other_user}","gists_url":"https://api.github.com/users/openclonk/gists{/gist_id}","starred_url":"https://api.github.com/users/openclonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openclonk/subscriptions","organizations_url":"https://api.github.com/users/openclonk/orgs","repos_url":"https://api.github.com/users/openclonk/repos","events_url":"https://api.github.com/users/openclonk/events{/privacy}","received_events_url":"https://api.github.com/users/openclonk/received_events","type":"Organization","site_admin":false},"repo":{"id":10687368,"name":"openclonk","full_name":"openclonk/openclonk","owner":{"login":"openclonk","id":4697210,"avatar_url":"https://avatars3.githubusercontent.com/u/4697210?v=3","gravatar_id":"","url":"https://api.github.com/users/openclonk","html_url":"https://github.com/openclonk","followers_url":"https://api.github.com/users/openclonk/followers","following_url":"https://api.github.com/users/openclonk/following{/other_user}","gists_url":"https://api.github.com/users/openclonk/gists{/gist_id}","starred_url":"https://api.github.com/users/openclonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openclonk/subscriptions","organizations_url":"https://api.github.com/users/openclonk/orgs","repos_url":"https://api.github.com/users/openclonk/repos","events_url":"https://api.github.com/users/openclonk/events{/privacy}","received_events_url":"https://api.github.com/users/openclonk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openclonk/openclonk","description":"A free multiplayer action game where you control small and nimble humanoids","fork":false,"url":"https://api.github.com/repos/openclonk/openclonk","forks_url":"https://api.github.com/repos/openclonk/openclonk/forks","keys_url":"https://api.github.com/repos/openclonk/openclonk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openclonk/openclonk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openclonk/openclonk/teams","hooks_url":"https://api.github.com/repos/openclonk/openclonk/hooks","issue_events_url":"https://api.github.com/repos/openclonk/openclonk/issues/events{/number}","events_url":"https://api.github.com/repos/openclonk/openclonk/events","assignees_url":"https://api.github.com/repos/openclonk/openclonk/assignees{/user}","branches_url":"https://api.github.com/repos/openclonk/openclonk/branches{/branch}","tags_url":"https://api.github.com/repos/openclonk/openclonk/tags","blobs_url":"https://api.github.com/repos/openclonk/openclonk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openclonk/openclonk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openclonk/openclonk/git/refs{/sha}","trees_url":"https://api.github.com/repos/openclonk/openclonk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openclonk/openclonk/statuses/{sha}","languages_url":"https://api.github.com/repos/openclonk/openclonk/languages","stargazers_url":"https://api.github.com/repos/openclonk/openclonk/stargazers","contributors_url":"https://api.github.com/repos/openclonk/openclonk/contributors","subscribers_url":"https://api.github.com/repos/openclonk/openclonk/subscribers","subscription_url":"https://api.github.com/repos/openclonk/openclonk/subscription","commits_url":"https://api.github.com/repos/openclonk/openclonk/commits{/sha}","git_commits_url":"https://api.github.com/repos/openclonk/openclonk/git/commits{/sha}","comments_url":"https://api.github.com/repos/openclonk/openclonk/comments{/number}","issue_comment_url":"https://api.github.com/repos/openclonk/openclonk/issues/comments{/number}","contents_url":"https://api.github.com/repos/openclonk/openclonk/contents/{+path}","compare_url":"https://api.github.com/repos/openclonk/openclonk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openclonk/openclonk/merges","archive_url":"https://api.github.com/repos/openclonk/openclonk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openclonk/openclonk/downloads","issues_url":"https://api.github.com/repos/openclonk/openclonk/issues{/number}","pulls_url":"https://api.github.com/repos/openclonk/openclonk/pulls{/number}","milestones_url":"https://api.github.com/repos/openclonk/openclonk/milestones{/number}","notifications_url":"https://api.github.com/repos/openclonk/openclonk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openclonk/openclonk/labels{/name}","releases_url":"https://api.github.com/repos/openclonk/openclonk/releases{/id}","deployments_url":"https://api.github.com/repos/openclonk/openclonk/deployments","created_at":"2013-06-14T11:13:11Z","updated_at":"2017-04-10T09:33:33Z","pushed_at":"2017-04-26T12:35:53Z","git_url":"git://github.com/openclonk/openclonk.git","ssh_url":"git@github.com:openclonk/openclonk.git","clone_url":"https://github.com/openclonk/openclonk.git","svn_url":"https://github.com/openclonk/openclonk","homepage":"http://www.openclonk.org/","size":282443,"stargazers_count":78,"watchers_count":78,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":3,"forks":29,"open_issues":3,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openclonk/openclonk/pulls/41"},"html":{"href":"https://github.com/openclonk/openclonk/pull/41"},"issue":{"href":"https://api.github.com/repos/openclonk/openclonk/issues/41"},"comments":{"href":"https://api.github.com/repos/openclonk/openclonk/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/openclonk/openclonk/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/openclonk/openclonk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openclonk/openclonk/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/openclonk/openclonk/statuses/57fef90bf4192e07b8b5cbe2070e69cd03453ef5"}}}}
{"actor":{"display_login":"lluchs"}}