{"action":"created","comment":{"url":"https://api.github.com/repos/bumptech/glide/pulls/comments/111826235","pull_request_review_id":33095546,"id":111826235,"diff_hunk":"@@ -185,13 +185,12 @@ private static void initGlide(Context context) {\n           annotationGeneratedModule.getExcludedModuleClasses();\n       for (Iterator<GlideModule> iterator = manifestModules.iterator(); iterator.hasNext();) {\n         GlideModule current = iterator.next();\n-        if (!excludedModuleClasses.contains(current.getClass())) {\n-          continue;\n+        if (excludedModuleClasses.contains(current.getClass())) {\n+          if (Log.isLoggable(TAG, Log.DEBUG)) {\n+            Log.d(TAG, \"RootGlideModule excludes manifest GlideModule: \" + current.getClass());","path":"library/src/main/java/com/bumptech/glide/Glide.java","position":8,"original_position":8,"commit_id":"a89093339b639f1ce47d84af1a6773a4f8b74224","original_commit_id":"a89093339b639f1ce47d84af1a6773a4f8b74224","user":{"login":"TWiStErRob","id":2906988,"avatar_url":"https://avatars3.githubusercontent.com/u/2906988?v=3","gravatar_id":"","url":"https://api.github.com/users/TWiStErRob","html_url":"https://github.com/TWiStErRob","followers_url":"https://api.github.com/users/TWiStErRob/followers","following_url":"https://api.github.com/users/TWiStErRob/following{/other_user}","gists_url":"https://api.github.com/users/TWiStErRob/gists{/gist_id}","starred_url":"https://api.github.com/users/TWiStErRob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWiStErRob/subscriptions","organizations_url":"https://api.github.com/users/TWiStErRob/orgs","repos_url":"https://api.github.com/users/TWiStErRob/repos","events_url":"https://api.github.com/users/TWiStErRob/events{/privacy}","received_events_url":"https://api.github.com/users/TWiStErRob/received_events","type":"User","site_admin":false},"body":"Any particular reason to reduce the amount of info logged? Changing to `current.getClass()` loses information in the logs. Consider for example if for some reason there are two modules exists of the same type, seeing the `hashCode` may be most helpful to realize if it's the same object or there are two instances for some reason.","created_at":"2017-04-17T21:29:06Z","updated_at":"2017-04-17T21:30:18Z","html_url":"https://github.com/bumptech/glide/pull/1860#discussion_r111826235","pull_request_url":"https://api.github.com/repos/bumptech/glide/pulls/1860","_links":{"self":{"href":"https://api.github.com/repos/bumptech/glide/pulls/comments/111826235"},"html":{"href":"https://github.com/bumptech/glide/pull/1860#discussion_r111826235"},"pull_request":{"href":"https://api.github.com/repos/bumptech/glide/pulls/1860"}}},"pull_request":{"url":"https://api.github.com/repos/bumptech/glide/pulls/1860","id":116116289,"html_url":"https://github.com/bumptech/glide/pull/1860","diff_url":"https://github.com/bumptech/glide/pull/1860.diff","patch_url":"https://github.com/bumptech/glide/pull/1860.patch","issue_url":"https://api.github.com/repos/bumptech/glide/issues/1860","number":1860,"state":"open","locked":false,"title":"Replace the unnecessary continue syntax.","user":{"login":"christmasjason","id":10961194,"avatar_url":"https://avatars2.githubusercontent.com/u/10961194?v=3","gravatar_id":"","url":"https://api.github.com/users/christmasjason","html_url":"https://github.com/christmasjason","followers_url":"https://api.github.com/users/christmasjason/followers","following_url":"https://api.github.com/users/christmasjason/following{/other_user}","gists_url":"https://api.github.com/users/christmasjason/gists{/gist_id}","starred_url":"https://api.github.com/users/christmasjason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christmasjason/subscriptions","organizations_url":"https://api.github.com/users/christmasjason/orgs","repos_url":"https://api.github.com/users/christmasjason/repos","events_url":"https://api.github.com/users/christmasjason/events{/privacy}","received_events_url":"https://api.github.com/users/christmasjason/received_events","type":"User","site_admin":false},"body":"Replace the unnecessary continue syntax.\r\n\r\n<!-- Make sure you've run `gradlew clean check jar assemble` before commit. -->\r\n<!-- Don't forget that you can always force push to your private branches to make changes. -->\r\n<!-- Please make sure there are no weird commits in the change set by rebasing to latest upstream. -->\r\n<!-- Please squash typo/checkstyle/review fix commits into the base commit. -->\r\n\r\n## Description\r\n<!-- Please describe the changes you made on a high level. -->\r\n<!-- Make sure you reference the GitHub issue here if this change is related to one. -->\r\n\r\n## Motivation and Context\r\n<!-- Why is this change required? What problem does it solve? -->\r\n<!-- If it's fixing a bug reference it or provide repro steps. -->\r\n\r\n<!-- If you have any issues feel free to create the PR anyway, we'll help to resolve them. -->","created_at":"2017-04-17T10:01:04Z","updated_at":"2017-04-17T21:30:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94db1e4bdd00d6d4cd4dba0f35f3b12d3db6f10a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bumptech/glide/pulls/1860/commits","review_comments_url":"https://api.github.com/repos/bumptech/glide/pulls/1860/comments","review_comment_url":"https://api.github.com/repos/bumptech/glide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bumptech/glide/issues/1860/comments","statuses_url":"https://api.github.com/repos/bumptech/glide/statuses/a89093339b639f1ce47d84af1a6773a4f8b74224","head":{"label":"christmasjason:patch-1","ref":"patch-1","sha":"a89093339b639f1ce47d84af1a6773a4f8b74224","user":{"login":"christmasjason","id":10961194,"avatar_url":"https://avatars2.githubusercontent.com/u/10961194?v=3","gravatar_id":"","url":"https://api.github.com/users/christmasjason","html_url":"https://github.com/christmasjason","followers_url":"https://api.github.com/users/christmasjason/followers","following_url":"https://api.github.com/users/christmasjason/following{/other_user}","gists_url":"https://api.github.com/users/christmasjason/gists{/gist_id}","starred_url":"https://api.github.com/users/christmasjason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christmasjason/subscriptions","organizations_url":"https://api.github.com/users/christmasjason/orgs","repos_url":"https://api.github.com/users/christmasjason/repos","events_url":"https://api.github.com/users/christmasjason/events{/privacy}","received_events_url":"https://api.github.com/users/christmasjason/received_events","type":"User","site_admin":false},"repo":{"id":88495354,"name":"glide","full_name":"christmasjason/glide","owner":{"login":"christmasjason","id":10961194,"avatar_url":"https://avatars2.githubusercontent.com/u/10961194?v=3","gravatar_id":"","url":"https://api.github.com/users/christmasjason","html_url":"https://github.com/christmasjason","followers_url":"https://api.github.com/users/christmasjason/followers","following_url":"https://api.github.com/users/christmasjason/following{/other_user}","gists_url":"https://api.github.com/users/christmasjason/gists{/gist_id}","starred_url":"https://api.github.com/users/christmasjason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christmasjason/subscriptions","organizations_url":"https://api.github.com/users/christmasjason/orgs","repos_url":"https://api.github.com/users/christmasjason/repos","events_url":"https://api.github.com/users/christmasjason/events{/privacy}","received_events_url":"https://api.github.com/users/christmasjason/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christmasjason/glide","description":"An image loading and caching library for Android focused on smooth scrolling","fork":true,"url":"https://api.github.com/repos/christmasjason/glide","forks_url":"https://api.github.com/repos/christmasjason/glide/forks","keys_url":"https://api.github.com/repos/christmasjason/glide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christmasjason/glide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christmasjason/glide/teams","hooks_url":"https://api.github.com/repos/christmasjason/glide/hooks","issue_events_url":"https://api.github.com/repos/christmasjason/glide/issues/events{/number}","events_url":"https://api.github.com/repos/christmasjason/glide/events","assignees_url":"https://api.github.com/repos/christmasjason/glide/assignees{/user}","branches_url":"https://api.github.com/repos/christmasjason/glide/branches{/branch}","tags_url":"https://api.github.com/repos/christmasjason/glide/tags","blobs_url":"https://api.github.com/repos/christmasjason/glide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christmasjason/glide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christmasjason/glide/git/refs{/sha}","trees_url":"https://api.github.com/repos/christmasjason/glide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christmasjason/glide/statuses/{sha}","languages_url":"https://api.github.com/repos/christmasjason/glide/languages","stargazers_url":"https://api.github.com/repos/christmasjason/glide/stargazers","contributors_url":"https://api.github.com/repos/christmasjason/glide/contributors","subscribers_url":"https://api.github.com/repos/christmasjason/glide/subscribers","subscription_url":"https://api.github.com/repos/christmasjason/glide/subscription","commits_url":"https://api.github.com/repos/christmasjason/glide/commits{/sha}","git_commits_url":"https://api.github.com/repos/christmasjason/glide/git/commits{/sha}","comments_url":"https://api.github.com/repos/christmasjason/glide/comments{/number}","issue_comment_url":"https://api.github.com/repos/christmasjason/glide/issues/comments{/number}","contents_url":"https://api.github.com/repos/christmasjason/glide/contents/{+path}","compare_url":"https://api.github.com/repos/christmasjason/glide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christmasjason/glide/merges","archive_url":"https://api.github.com/repos/christmasjason/glide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christmasjason/glide/downloads","issues_url":"https://api.github.com/repos/christmasjason/glide/issues{/number}","pulls_url":"https://api.github.com/repos/christmasjason/glide/pulls{/number}","milestones_url":"https://api.github.com/repos/christmasjason/glide/milestones{/number}","notifications_url":"https://api.github.com/repos/christmasjason/glide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christmasjason/glide/labels{/name}","releases_url":"https://api.github.com/repos/christmasjason/glide/releases{/id}","deployments_url":"https://api.github.com/repos/christmasjason/glide/deployments","created_at":"2017-04-17T09:56:12Z","updated_at":"2017-04-17T09:56:15Z","pushed_at":"2017-04-17T10:29:42Z","git_url":"git://github.com/christmasjason/glide.git","ssh_url":"git@github.com:christmasjason/glide.git","clone_url":"https://github.com/christmasjason/glide.git","svn_url":"https://github.com/christmasjason/glide","homepage":null,"size":25305,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bumptech:master","ref":"master","sha":"980ac625618f5e979aab925f928cade00a5de325","user":{"login":"bumptech","id":423539,"avatar_url":"https://avatars3.githubusercontent.com/u/423539?v=3","gravatar_id":"","url":"https://api.github.com/users/bumptech","html_url":"https://github.com/bumptech","followers_url":"https://api.github.com/users/bumptech/followers","following_url":"https://api.github.com/users/bumptech/following{/other_user}","gists_url":"https://api.github.com/users/bumptech/gists{/gist_id}","starred_url":"https://api.github.com/users/bumptech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bumptech/subscriptions","organizations_url":"https://api.github.com/users/bumptech/orgs","repos_url":"https://api.github.com/users/bumptech/repos","events_url":"https://api.github.com/users/bumptech/events{/privacy}","received_events_url":"https://api.github.com/users/bumptech/received_events","type":"Organization","site_admin":false},"repo":{"id":11267509,"name":"glide","full_name":"bumptech/glide","owner":{"login":"bumptech","id":423539,"avatar_url":"https://avatars3.githubusercontent.com/u/423539?v=3","gravatar_id":"","url":"https://api.github.com/users/bumptech","html_url":"https://github.com/bumptech","followers_url":"https://api.github.com/users/bumptech/followers","following_url":"https://api.github.com/users/bumptech/following{/other_user}","gists_url":"https://api.github.com/users/bumptech/gists{/gist_id}","starred_url":"https://api.github.com/users/bumptech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bumptech/subscriptions","organizations_url":"https://api.github.com/users/bumptech/orgs","repos_url":"https://api.github.com/users/bumptech/repos","events_url":"https://api.github.com/users/bumptech/events{/privacy}","received_events_url":"https://api.github.com/users/bumptech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bumptech/glide","description":"An image loading and caching library for Android focused on smooth scrolling","fork":false,"url":"https://api.github.com/repos/bumptech/glide","forks_url":"https://api.github.com/repos/bumptech/glide/forks","keys_url":"https://api.github.com/repos/bumptech/glide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bumptech/glide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bumptech/glide/teams","hooks_url":"https://api.github.com/repos/bumptech/glide/hooks","issue_events_url":"https://api.github.com/repos/bumptech/glide/issues/events{/number}","events_url":"https://api.github.com/repos/bumptech/glide/events","assignees_url":"https://api.github.com/repos/bumptech/glide/assignees{/user}","branches_url":"https://api.github.com/repos/bumptech/glide/branches{/branch}","tags_url":"https://api.github.com/repos/bumptech/glide/tags","blobs_url":"https://api.github.com/repos/bumptech/glide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bumptech/glide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bumptech/glide/git/refs{/sha}","trees_url":"https://api.github.com/repos/bumptech/glide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bumptech/glide/statuses/{sha}","languages_url":"https://api.github.com/repos/bumptech/glide/languages","stargazers_url":"https://api.github.com/repos/bumptech/glide/stargazers","contributors_url":"https://api.github.com/repos/bumptech/glide/contributors","subscribers_url":"https://api.github.com/repos/bumptech/glide/subscribers","subscription_url":"https://api.github.com/repos/bumptech/glide/subscription","commits_url":"https://api.github.com/repos/bumptech/glide/commits{/sha}","git_commits_url":"https://api.github.com/repos/bumptech/glide/git/commits{/sha}","comments_url":"https://api.github.com/repos/bumptech/glide/comments{/number}","issue_comment_url":"https://api.github.com/repos/bumptech/glide/issues/comments{/number}","contents_url":"https://api.github.com/repos/bumptech/glide/contents/{+path}","compare_url":"https://api.github.com/repos/bumptech/glide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bumptech/glide/merges","archive_url":"https://api.github.com/repos/bumptech/glide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bumptech/glide/downloads","issues_url":"https://api.github.com/repos/bumptech/glide/issues{/number}","pulls_url":"https://api.github.com/repos/bumptech/glide/pulls{/number}","milestones_url":"https://api.github.com/repos/bumptech/glide/milestones{/number}","notifications_url":"https://api.github.com/repos/bumptech/glide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bumptech/glide/labels{/name}","releases_url":"https://api.github.com/repos/bumptech/glide/releases{/id}","deployments_url":"https://api.github.com/repos/bumptech/glide/deployments","created_at":"2013-07-08T22:52:33Z","updated_at":"2017-04-17T20:37:40Z","pushed_at":"2017-04-17T16:21:27Z","git_url":"git://github.com/bumptech/glide.git","ssh_url":"git@github.com:bumptech/glide.git","clone_url":"https://github.com/bumptech/glide.git","svn_url":"https://github.com/bumptech/glide","homepage":null,"size":25311,"stargazers_count":14710,"watchers_count":14710,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3052,"mirror_url":null,"open_issues_count":282,"forks":3052,"open_issues":282,"watchers":14710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bumptech/glide/pulls/1860"},"html":{"href":"https://github.com/bumptech/glide/pull/1860"},"issue":{"href":"https://api.github.com/repos/bumptech/glide/issues/1860"},"comments":{"href":"https://api.github.com/repos/bumptech/glide/issues/1860/comments"},"review_comments":{"href":"https://api.github.com/repos/bumptech/glide/pulls/1860/comments"},"review_comment":{"href":"https://api.github.com/repos/bumptech/glide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bumptech/glide/pulls/1860/commits"},"statuses":{"href":"https://api.github.com/repos/bumptech/glide/statuses/a89093339b639f1ce47d84af1a6773a4f8b74224"}}}}
{"actor":{"display_login":"TWiStErRob"}}