{"action":"created","comment":{"url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments/138845873","pull_request_review_id":62694858,"id":138845873,"diff_hunk":"@@ -36,11 +36,16 @@ def autocomplete(*args):\n import pdc_client\n \n \n+# Default path to plugins. This line will be replaced when installing with real\n+# install plugin path (usually '/usr/share/pdc-client/plugins').\n+DEFAULT_PLUGIN_DIR = os.path.join(os.path.dirname(__file__), 'plugins')\n+\n # A list of paths to directories where plugins should be loaded from.\n # The purpose of the plugins is to extend the default behaviour.\n-LOCAL_DIR = os.path.join(os.path.dirname(__file__), 'plugins')\n-INSTALLED_DIR = os.path.join('/usr/share/pdc-client', 'plugins')\n-PLUGIN_DIRS = [LOCAL_DIR] if os.path.exists(LOCAL_DIR) else [INSTALLED_DIR]\n+PLUGIN_DIRS = os.getenv('PDC_CLIENT_PLUGIN_PATH', '').split(':')\n+PLUGIN_DIRS = [path for path in PLUGIN_DIRS if path]","path":"pdc_client/runner.py","position":14,"original_position":14,"commit_id":"b61e72905b80f5aca274ea5eaad9a2da7b4a1c8e","original_commit_id":"b61e72905b80f5aca274ea5eaad9a2da7b4a1c8e","user":{"login":"hluk","id":38054,"avatar_url":"https://avatars1.githubusercontent.com/u/38054?v=4","gravatar_id":"","url":"https://api.github.com/users/hluk","html_url":"https://github.com/hluk","followers_url":"https://api.github.com/users/hluk/followers","following_url":"https://api.github.com/users/hluk/following{/other_user}","gists_url":"https://api.github.com/users/hluk/gists{/gist_id}","starred_url":"https://api.github.com/users/hluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hluk/subscriptions","organizations_url":"https://api.github.com/users/hluk/orgs","repos_url":"https://api.github.com/users/hluk/repos","events_url":"https://api.github.com/users/hluk/events{/privacy}","received_events_url":"https://api.github.com/users/hluk/received_events","type":"User","site_admin":false},"body":"Just reusing the variable. Perhaps I should put it under one assignment and multiple lines.","created_at":"2017-09-14T09:46:34Z","updated_at":"2017-09-14T09:46:34Z","html_url":"https://github.com/product-definition-center/pdc-client/pull/121#discussion_r138845873","pull_request_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/121","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments/138845873"},"html":{"href":"https://github.com/product-definition-center/pdc-client/pull/121#discussion_r138845873"},"pull_request":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/121"}},"in_reply_to_id":138831734},"pull_request":{"url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/121","id":139792052,"html_url":"https://github.com/product-definition-center/pdc-client/pull/121","diff_url":"https://github.com/product-definition-center/pdc-client/pull/121.diff","patch_url":"https://github.com/product-definition-center/pdc-client/pull/121.patch","issue_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/121","number":121,"state":"open","locked":false,"title":"Fix installing plugins and running tests","user":{"login":"hluk","id":38054,"avatar_url":"https://avatars1.githubusercontent.com/u/38054?v=4","gravatar_id":"","url":"https://api.github.com/users/hluk","html_url":"https://github.com/hluk","followers_url":"https://api.github.com/users/hluk/followers","following_url":"https://api.github.com/users/hluk/following{/other_user}","gists_url":"https://api.github.com/users/hluk/gists{/gist_id}","starred_url":"https://api.github.com/users/hluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hluk/subscriptions","organizations_url":"https://api.github.com/users/hluk/orgs","repos_url":"https://api.github.com/users/hluk/repos","events_url":"https://api.github.com/users/hluk/events{/privacy}","received_events_url":"https://api.github.com/users/hluk/received_events","type":"User","site_admin":false},"body":"Few things happening here:\r\n1. Merge branch 'release'\r\n2. Revert removing comments from downstream\r\n3. Improve installing plugins\r\n    \r\n    Install bytecode for plugins only for correct version of Python.\r\n    \r\n    Replaces default plugin path in code with real installation path to\r\n    plugins.\r\n    \r\n    JIRA: PDC-2193\r\n4. Fix running tests when building rpm","created_at":"2017-09-07T12:27:54Z","updated_at":"2017-09-14T09:46:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba2bf31aca3a22cb984bc29e86514eeec58cdb36","assignee":null,"assignees":[],"requested_reviewers":[{"login":"simozhan","id":1744192,"avatar_url":"https://avatars0.githubusercontent.com/u/1744192?v=4","gravatar_id":"","url":"https://api.github.com/users/simozhan","html_url":"https://github.com/simozhan","followers_url":"https://api.github.com/users/simozhan/followers","following_url":"https://api.github.com/users/simozhan/following{/other_user}","gists_url":"https://api.github.com/users/simozhan/gists{/gist_id}","starred_url":"https://api.github.com/users/simozhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simozhan/subscriptions","organizations_url":"https://api.github.com/users/simozhan/orgs","repos_url":"https://api.github.com/users/simozhan/repos","events_url":"https://api.github.com/users/simozhan/events{/privacy}","received_events_url":"https://api.github.com/users/simozhan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/121/commits","review_comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/121/comments","review_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/121/comments","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/b61e72905b80f5aca274ea5eaad9a2da7b4a1c8e","head":{"label":"hluk:fix-installing-plugins","ref":"fix-installing-plugins","sha":"b61e72905b80f5aca274ea5eaad9a2da7b4a1c8e","user":{"login":"hluk","id":38054,"avatar_url":"https://avatars1.githubusercontent.com/u/38054?v=4","gravatar_id":"","url":"https://api.github.com/users/hluk","html_url":"https://github.com/hluk","followers_url":"https://api.github.com/users/hluk/followers","following_url":"https://api.github.com/users/hluk/following{/other_user}","gists_url":"https://api.github.com/users/hluk/gists{/gist_id}","starred_url":"https://api.github.com/users/hluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hluk/subscriptions","organizations_url":"https://api.github.com/users/hluk/orgs","repos_url":"https://api.github.com/users/hluk/repos","events_url":"https://api.github.com/users/hluk/events{/privacy}","received_events_url":"https://api.github.com/users/hluk/received_events","type":"User","site_admin":false},"repo":{"id":95637783,"name":"pdc-client","full_name":"hluk/pdc-client","owner":{"login":"hluk","id":38054,"avatar_url":"https://avatars1.githubusercontent.com/u/38054?v=4","gravatar_id":"","url":"https://api.github.com/users/hluk","html_url":"https://github.com/hluk","followers_url":"https://api.github.com/users/hluk/followers","following_url":"https://api.github.com/users/hluk/following{/other_user}","gists_url":"https://api.github.com/users/hluk/gists{/gist_id}","starred_url":"https://api.github.com/users/hluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hluk/subscriptions","organizations_url":"https://api.github.com/users/hluk/orgs","repos_url":"https://api.github.com/users/hluk/repos","events_url":"https://api.github.com/users/hluk/events{/privacy}","received_events_url":"https://api.github.com/users/hluk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hluk/pdc-client","description":"Client for Product Definition Center (PDC) in Python","fork":true,"url":"https://api.github.com/repos/hluk/pdc-client","forks_url":"https://api.github.com/repos/hluk/pdc-client/forks","keys_url":"https://api.github.com/repos/hluk/pdc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hluk/pdc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hluk/pdc-client/teams","hooks_url":"https://api.github.com/repos/hluk/pdc-client/hooks","issue_events_url":"https://api.github.com/repos/hluk/pdc-client/issues/events{/number}","events_url":"https://api.github.com/repos/hluk/pdc-client/events","assignees_url":"https://api.github.com/repos/hluk/pdc-client/assignees{/user}","branches_url":"https://api.github.com/repos/hluk/pdc-client/branches{/branch}","tags_url":"https://api.github.com/repos/hluk/pdc-client/tags","blobs_url":"https://api.github.com/repos/hluk/pdc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hluk/pdc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hluk/pdc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/hluk/pdc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hluk/pdc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/hluk/pdc-client/languages","stargazers_url":"https://api.github.com/repos/hluk/pdc-client/stargazers","contributors_url":"https://api.github.com/repos/hluk/pdc-client/contributors","subscribers_url":"https://api.github.com/repos/hluk/pdc-client/subscribers","subscription_url":"https://api.github.com/repos/hluk/pdc-client/subscription","commits_url":"https://api.github.com/repos/hluk/pdc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/hluk/pdc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/hluk/pdc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/hluk/pdc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/hluk/pdc-client/contents/{+path}","compare_url":"https://api.github.com/repos/hluk/pdc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hluk/pdc-client/merges","archive_url":"https://api.github.com/repos/hluk/pdc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hluk/pdc-client/downloads","issues_url":"https://api.github.com/repos/hluk/pdc-client/issues{/number}","pulls_url":"https://api.github.com/repos/hluk/pdc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/hluk/pdc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/hluk/pdc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hluk/pdc-client/labels{/name}","releases_url":"https://api.github.com/repos/hluk/pdc-client/releases{/id}","deployments_url":"https://api.github.com/repos/hluk/pdc-client/deployments","created_at":"2017-06-28T06:45:44Z","updated_at":"2017-06-28T06:45:45Z","pushed_at":"2017-09-13T11:29:26Z","git_url":"git://github.com/hluk/pdc-client.git","ssh_url":"git@github.com:hluk/pdc-client.git","clone_url":"https://github.com/hluk/pdc-client.git","svn_url":"https://github.com/hluk/pdc-client","homepage":"","size":688,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"product-definition-center:master","ref":"master","sha":"3b4555bc124cd6fff3a18658dec88f2e77ba7e65","user":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars3.githubusercontent.com/u/15812210?v=4","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"repo":{"id":46246883,"name":"pdc-client","full_name":"product-definition-center/pdc-client","owner":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars3.githubusercontent.com/u/15812210?v=4","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/product-definition-center/pdc-client","description":"Client for Product Definition Center (PDC) in Python","fork":false,"url":"https://api.github.com/repos/product-definition-center/pdc-client","forks_url":"https://api.github.com/repos/product-definition-center/pdc-client/forks","keys_url":"https://api.github.com/repos/product-definition-center/pdc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/product-definition-center/pdc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/product-definition-center/pdc-client/teams","hooks_url":"https://api.github.com/repos/product-definition-center/pdc-client/hooks","issue_events_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/events{/number}","events_url":"https://api.github.com/repos/product-definition-center/pdc-client/events","assignees_url":"https://api.github.com/repos/product-definition-center/pdc-client/assignees{/user}","branches_url":"https://api.github.com/repos/product-definition-center/pdc-client/branches{/branch}","tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/tags","blobs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/product-definition-center/pdc-client/languages","stargazers_url":"https://api.github.com/repos/product-definition-center/pdc-client/stargazers","contributors_url":"https://api.github.com/repos/product-definition-center/pdc-client/contributors","subscribers_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscribers","subscription_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscription","commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/product-definition-center/pdc-client/contents/{+path}","compare_url":"https://api.github.com/repos/product-definition-center/pdc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/product-definition-center/pdc-client/merges","archive_url":"https://api.github.com/repos/product-definition-center/pdc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/product-definition-center/pdc-client/downloads","issues_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues{/number}","pulls_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/product-definition-center/pdc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/product-definition-center/pdc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/product-definition-center/pdc-client/labels{/name}","releases_url":"https://api.github.com/repos/product-definition-center/pdc-client/releases{/id}","deployments_url":"https://api.github.com/repos/product-definition-center/pdc-client/deployments","created_at":"2015-11-16T02:23:01Z","updated_at":"2017-04-04T19:38:22Z","pushed_at":"2017-09-12T15:09:17Z","git_url":"git://github.com/product-definition-center/pdc-client.git","ssh_url":"git@github.com:product-definition-center/pdc-client.git","clone_url":"https://github.com/product-definition-center/pdc-client.git","svn_url":"https://github.com/product-definition-center/pdc-client","homepage":"","size":734,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":5,"forks":14,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/121"},"html":{"href":"https://github.com/product-definition-center/pdc-client/pull/121"},"issue":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/issues/121"},"comments":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/b61e72905b80f5aca274ea5eaad9a2da7b4a1c8e"}},"author_association":"NONE"}}
{"actor":{"display_login":"hluk"}}