{"action":"created","comment":{"url":"https://api.github.com/repos/plabus/tmLQCD/pulls/comments/112491158","pull_request_review_id":33810915,"id":112491158,"diff_hunk":"@@ -949,16 +960,25 @@ int invert_eo_qphix(spinor * const Even_new,\n          solver_params,\n          compression);\n     }\n+#ifdef QPHIX_MIC_SOURCE\n   } else if (precision < rsdTarget<float>::value) {\n+#else\n+  } else {\n+#endif\n     if (QPHIX_SOALEN > VECLEN_SP) {\n       masterPrintf(\"SOALEN=%d is greater than the single prec VECLEN=%d\\n\", QPHIX_SOALEN,\n                    VECLEN_SP);\n       abort();\n     }\n     masterPrintf(\"# INITIALIZING QPHIX SOLVER\\n\");\n     masterPrintf(\"# USING SINGLE PRECISION\\n\");\n+    _initQphix(0, nullptr, qphix_input_By, qphix_input_Bz, qphix_input_NCores,\n+           qphix_input_Sy, qphix_input_Sz,\n+           qphix_input_PadXY, qphix_input_PadXYZ, qphix_input_MinCt,\n+           compression, QPHIX_FLOAT_PREC);\n+\n     if (compress12) {\n-      return invert_eo_qphix_helper<float, VECLEN_DP, QPHIX_SOALEN, true>\n+      return invert_eo_qphix_helper<float, VECLEN_SP, QPHIX_SOALEN, true>","path":"qphix_interface.cpp","position":132,"original_position":132,"commit_id":"c83944bfbe4ca8008a88a30fe02b74e6702da62e","original_commit_id":"c83944bfbe4ca8008a88a30fe02b74e6702da62e","user":{"login":"kostrzewa","id":1325246,"avatar_url":"https://avatars2.githubusercontent.com/u/1325246?v=3","gravatar_id":"","url":"https://api.github.com/users/kostrzewa","html_url":"https://github.com/kostrzewa","followers_url":"https://api.github.com/users/kostrzewa/followers","following_url":"https://api.github.com/users/kostrzewa/following{/other_user}","gists_url":"https://api.github.com/users/kostrzewa/gists{/gist_id}","starred_url":"https://api.github.com/users/kostrzewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostrzewa/subscriptions","organizations_url":"https://api.github.com/users/kostrzewa/orgs","repos_url":"https://api.github.com/users/kostrzewa/repos","events_url":"https://api.github.com/users/kostrzewa/events{/privacy}","received_events_url":"https://api.github.com/users/kostrzewa/received_events","type":"User","site_admin":false},"body":"is this correct? Whatever I do here, I get segfaults","created_at":"2017-04-20T15:55:14Z","updated_at":"2017-04-20T15:55:14Z","html_url":"https://github.com/plabus/tmLQCD/pull/3#discussion_r112491158","pull_request_url":"https://api.github.com/repos/plabus/tmLQCD/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/plabus/tmLQCD/pulls/comments/112491158"},"html":{"href":"https://github.com/plabus/tmLQCD/pull/3#discussion_r112491158"},"pull_request":{"href":"https://api.github.com/repos/plabus/tmLQCD/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/plabus/tmLQCD/pulls/3","id":116804970,"html_url":"https://github.com/plabus/tmLQCD/pull/3","diff_url":"https://github.com/plabus/tmLQCD/pull/3.diff","patch_url":"https://github.com/plabus/tmLQCD/pull/3.patch","issue_url":"https://api.github.com/repos/plabus/tmLQCD/issues/3","number":3,"state":"open","locked":false,"title":"first attempt to properly pass parameters to qphix from input file","user":{"login":"kostrzewa","id":1325246,"avatar_url":"https://avatars2.githubusercontent.com/u/1325246?v=3","gravatar_id":"","url":"https://api.github.com/users/kostrzewa","html_url":"https://github.com/kostrzewa","followers_url":"https://api.github.com/users/kostrzewa/followers","following_url":"https://api.github.com/users/kostrzewa/following{/other_user}","gists_url":"https://api.github.com/users/kostrzewa/gists{/gist_id}","starred_url":"https://api.github.com/users/kostrzewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostrzewa/subscriptions","organizations_url":"https://api.github.com/users/kostrzewa/orgs","repos_url":"https://api.github.com/users/kostrzewa/repos","events_url":"https://api.github.com/users/kostrzewa/events{/privacy}","received_events_url":"https://api.github.com/users/kostrzewa/received_events","type":"User","site_admin":false},"body":"1) pass parameters to qphix from input file, new \"BeginExternalInverter QPHIX\"\r\n   structure implemented for this purpose (warning: no correctness checks here)\r\n\r\n2) move _initQphix call into invert_eo_qphix\r\n\r\n3) add sample file to call qphix Wilson inverter\r\n\r\n4) use angled brackets to include qphix headers\r\n\r\ncaveats: single precision results in a segfault, only the Wilson operator is currently supported","created_at":"2017-04-20T15:51:19Z","updated_at":"2017-04-20T15:55:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"730d886322f289c23e6c7e8b89eeb62132d6944f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/plabus/tmLQCD/pulls/3/commits","review_comments_url":"https://api.github.com/repos/plabus/tmLQCD/pulls/3/comments","review_comment_url":"https://api.github.com/repos/plabus/tmLQCD/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plabus/tmLQCD/issues/3/comments","statuses_url":"https://api.github.com/repos/plabus/tmLQCD/statuses/c83944bfbe4ca8008a88a30fe02b74e6702da62e","head":{"label":"kostrzewa:juelich_qphix_devel","ref":"juelich_qphix_devel","sha":"c83944bfbe4ca8008a88a30fe02b74e6702da62e","user":{"login":"kostrzewa","id":1325246,"avatar_url":"https://avatars2.githubusercontent.com/u/1325246?v=3","gravatar_id":"","url":"https://api.github.com/users/kostrzewa","html_url":"https://github.com/kostrzewa","followers_url":"https://api.github.com/users/kostrzewa/followers","following_url":"https://api.github.com/users/kostrzewa/following{/other_user}","gists_url":"https://api.github.com/users/kostrzewa/gists{/gist_id}","starred_url":"https://api.github.com/users/kostrzewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostrzewa/subscriptions","organizations_url":"https://api.github.com/users/kostrzewa/orgs","repos_url":"https://api.github.com/users/kostrzewa/repos","events_url":"https://api.github.com/users/kostrzewa/events{/privacy}","received_events_url":"https://api.github.com/users/kostrzewa/received_events","type":"User","site_admin":false},"repo":{"id":3169830,"name":"tmLQCD","full_name":"kostrzewa/tmLQCD","owner":{"login":"kostrzewa","id":1325246,"avatar_url":"https://avatars2.githubusercontent.com/u/1325246?v=3","gravatar_id":"","url":"https://api.github.com/users/kostrzewa","html_url":"https://github.com/kostrzewa","followers_url":"https://api.github.com/users/kostrzewa/followers","following_url":"https://api.github.com/users/kostrzewa/following{/other_user}","gists_url":"https://api.github.com/users/kostrzewa/gists{/gist_id}","starred_url":"https://api.github.com/users/kostrzewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kostrzewa/subscriptions","organizations_url":"https://api.github.com/users/kostrzewa/orgs","repos_url":"https://api.github.com/users/kostrzewa/repos","events_url":"https://api.github.com/users/kostrzewa/events{/privacy}","received_events_url":"https://api.github.com/users/kostrzewa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kostrzewa/tmLQCD","description":"tmLQCD is a freely available software suite providing a set of tools to be used in lattice QCD simulations. This is mainly a (P)HMC implementation for Wilson and Wilson twisted mass fermions and inverter for different versions of the Dirac operator.  The code is fully parallelised and ships with optimisations for various modern architectures, such as commodity PC clusters and the Blue Gene family. ","fork":true,"url":"https://api.github.com/repos/kostrzewa/tmLQCD","forks_url":"https://api.github.com/repos/kostrzewa/tmLQCD/forks","keys_url":"https://api.github.com/repos/kostrzewa/tmLQCD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kostrzewa/tmLQCD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kostrzewa/tmLQCD/teams","hooks_url":"https://api.github.com/repos/kostrzewa/tmLQCD/hooks","issue_events_url":"https://api.github.com/repos/kostrzewa/tmLQCD/issues/events{/number}","events_url":"https://api.github.com/repos/kostrzewa/tmLQCD/events","assignees_url":"https://api.github.com/repos/kostrzewa/tmLQCD/assignees{/user}","branches_url":"https://api.github.com/repos/kostrzewa/tmLQCD/branches{/branch}","tags_url":"https://api.github.com/repos/kostrzewa/tmLQCD/tags","blobs_url":"https://api.github.com/repos/kostrzewa/tmLQCD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kostrzewa/tmLQCD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kostrzewa/tmLQCD/git/refs{/sha}","trees_url":"https://api.github.com/repos/kostrzewa/tmLQCD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kostrzewa/tmLQCD/statuses/{sha}","languages_url":"https://api.github.com/repos/kostrzewa/tmLQCD/languages","stargazers_url":"https://api.github.com/repos/kostrzewa/tmLQCD/stargazers","contributors_url":"https://api.github.com/repos/kostrzewa/tmLQCD/contributors","subscribers_url":"https://api.github.com/repos/kostrzewa/tmLQCD/subscribers","subscription_url":"https://api.github.com/repos/kostrzewa/tmLQCD/subscription","commits_url":"https://api.github.com/repos/kostrzewa/tmLQCD/commits{/sha}","git_commits_url":"https://api.github.com/repos/kostrzewa/tmLQCD/git/commits{/sha}","comments_url":"https://api.github.com/repos/kostrzewa/tmLQCD/comments{/number}","issue_comment_url":"https://api.github.com/repos/kostrzewa/tmLQCD/issues/comments{/number}","contents_url":"https://api.github.com/repos/kostrzewa/tmLQCD/contents/{+path}","compare_url":"https://api.github.com/repos/kostrzewa/tmLQCD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kostrzewa/tmLQCD/merges","archive_url":"https://api.github.com/repos/kostrzewa/tmLQCD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kostrzewa/tmLQCD/downloads","issues_url":"https://api.github.com/repos/kostrzewa/tmLQCD/issues{/number}","pulls_url":"https://api.github.com/repos/kostrzewa/tmLQCD/pulls{/number}","milestones_url":"https://api.github.com/repos/kostrzewa/tmLQCD/milestones{/number}","notifications_url":"https://api.github.com/repos/kostrzewa/tmLQCD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kostrzewa/tmLQCD/labels{/name}","releases_url":"https://api.github.com/repos/kostrzewa/tmLQCD/releases{/id}","deployments_url":"https://api.github.com/repos/kostrzewa/tmLQCD/deployments","created_at":"2012-01-13T09:50:00Z","updated_at":"2017-03-23T13:27:09Z","pushed_at":"2017-04-20T15:50:08Z","git_url":"git://github.com/kostrzewa/tmLQCD.git","ssh_url":"git@github.com:kostrzewa/tmLQCD.git","clone_url":"https://github.com/kostrzewa/tmLQCD.git","svn_url":"https://github.com/kostrzewa/tmLQCD","homepage":"http://www.itkp.uni-bonn.de/~urbach/software.html","size":25267,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"plabus:qphix_devel","ref":"qphix_devel","sha":"c17b5d9aef99b6b4fbd0a715baf6fab854fb5aae","user":{"login":"plabus","id":14872390,"avatar_url":"https://avatars3.githubusercontent.com/u/14872390?v=3","gravatar_id":"","url":"https://api.github.com/users/plabus","html_url":"https://github.com/plabus","followers_url":"https://api.github.com/users/plabus/followers","following_url":"https://api.github.com/users/plabus/following{/other_user}","gists_url":"https://api.github.com/users/plabus/gists{/gist_id}","starred_url":"https://api.github.com/users/plabus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plabus/subscriptions","organizations_url":"https://api.github.com/users/plabus/orgs","repos_url":"https://api.github.com/users/plabus/repos","events_url":"https://api.github.com/users/plabus/events{/privacy}","received_events_url":"https://api.github.com/users/plabus/received_events","type":"User","site_admin":false},"repo":{"id":69468975,"name":"tmLQCD","full_name":"plabus/tmLQCD","owner":{"login":"plabus","id":14872390,"avatar_url":"https://avatars3.githubusercontent.com/u/14872390?v=3","gravatar_id":"","url":"https://api.github.com/users/plabus","html_url":"https://github.com/plabus","followers_url":"https://api.github.com/users/plabus/followers","following_url":"https://api.github.com/users/plabus/following{/other_user}","gists_url":"https://api.github.com/users/plabus/gists{/gist_id}","starred_url":"https://api.github.com/users/plabus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plabus/subscriptions","organizations_url":"https://api.github.com/users/plabus/orgs","repos_url":"https://api.github.com/users/plabus/repos","events_url":"https://api.github.com/users/plabus/events{/privacy}","received_events_url":"https://api.github.com/users/plabus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/plabus/tmLQCD","description":"tmLQCD is a freely available software suite providing a set of tools to be used in lattice QCD simulations. This is mainly a (P)HMC implementation for Wilson and Wilson twisted mass fermions and inverter for different versions of the Dirac operator.  The code is fully parallelised and ships with optimisations for various modern architectures, such as commodity PC clusters and the Blue Gene family. ","fork":true,"url":"https://api.github.com/repos/plabus/tmLQCD","forks_url":"https://api.github.com/repos/plabus/tmLQCD/forks","keys_url":"https://api.github.com/repos/plabus/tmLQCD/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plabus/tmLQCD/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plabus/tmLQCD/teams","hooks_url":"https://api.github.com/repos/plabus/tmLQCD/hooks","issue_events_url":"https://api.github.com/repos/plabus/tmLQCD/issues/events{/number}","events_url":"https://api.github.com/repos/plabus/tmLQCD/events","assignees_url":"https://api.github.com/repos/plabus/tmLQCD/assignees{/user}","branches_url":"https://api.github.com/repos/plabus/tmLQCD/branches{/branch}","tags_url":"https://api.github.com/repos/plabus/tmLQCD/tags","blobs_url":"https://api.github.com/repos/plabus/tmLQCD/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plabus/tmLQCD/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plabus/tmLQCD/git/refs{/sha}","trees_url":"https://api.github.com/repos/plabus/tmLQCD/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plabus/tmLQCD/statuses/{sha}","languages_url":"https://api.github.com/repos/plabus/tmLQCD/languages","stargazers_url":"https://api.github.com/repos/plabus/tmLQCD/stargazers","contributors_url":"https://api.github.com/repos/plabus/tmLQCD/contributors","subscribers_url":"https://api.github.com/repos/plabus/tmLQCD/subscribers","subscription_url":"https://api.github.com/repos/plabus/tmLQCD/subscription","commits_url":"https://api.github.com/repos/plabus/tmLQCD/commits{/sha}","git_commits_url":"https://api.github.com/repos/plabus/tmLQCD/git/commits{/sha}","comments_url":"https://api.github.com/repos/plabus/tmLQCD/comments{/number}","issue_comment_url":"https://api.github.com/repos/plabus/tmLQCD/issues/comments{/number}","contents_url":"https://api.github.com/repos/plabus/tmLQCD/contents/{+path}","compare_url":"https://api.github.com/repos/plabus/tmLQCD/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plabus/tmLQCD/merges","archive_url":"https://api.github.com/repos/plabus/tmLQCD/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plabus/tmLQCD/downloads","issues_url":"https://api.github.com/repos/plabus/tmLQCD/issues{/number}","pulls_url":"https://api.github.com/repos/plabus/tmLQCD/pulls{/number}","milestones_url":"https://api.github.com/repos/plabus/tmLQCD/milestones{/number}","notifications_url":"https://api.github.com/repos/plabus/tmLQCD/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plabus/tmLQCD/labels{/name}","releases_url":"https://api.github.com/repos/plabus/tmLQCD/releases{/id}","deployments_url":"https://api.github.com/repos/plabus/tmLQCD/deployments","created_at":"2016-09-28T13:59:59Z","updated_at":"2017-02-21T15:53:28Z","pushed_at":"2017-04-20T15:51:20Z","git_url":"git://github.com/plabus/tmLQCD.git","ssh_url":"git@github.com:plabus/tmLQCD.git","clone_url":"https://github.com/plabus/tmLQCD.git","svn_url":"https://github.com/plabus/tmLQCD","homepage":"http://www.itkp.uni-bonn.de/~urbach/software.html","size":25153,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plabus/tmLQCD/pulls/3"},"html":{"href":"https://github.com/plabus/tmLQCD/pull/3"},"issue":{"href":"https://api.github.com/repos/plabus/tmLQCD/issues/3"},"comments":{"href":"https://api.github.com/repos/plabus/tmLQCD/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/plabus/tmLQCD/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/plabus/tmLQCD/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plabus/tmLQCD/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/plabus/tmLQCD/statuses/c83944bfbe4ca8008a88a30fe02b74e6702da62e"}}}}
{"actor":{"display_login":"kostrzewa"}}