{"action":"created","comment":{"url":"https://api.github.com/repos/darwinfroese/hacksite/pulls/comments/143341675","pull_request_review_id":67844002,"id":143341675,"diff_hunk":"@@ -229,6 +229,44 @@ func (b *boltDB) GetAccount(username string) (models.Account, error) {\n \t\t\t\taccount = acc\n \t\t\t\treturn nil\n \t\t\t}\n+\n+\t\t}\n+\n+\t\treturn fmt.Errorf(\"no matching account found\")","path":"server/pkg/database/boltDB.go","position":18,"original_position":7,"commit_id":"810e62a91f5d117a47f926f18d33d385aef55b11","original_commit_id":"b299abaaad614de396b7216c59fd0d95a03c66cd","user":{"login":"darwinfroese","id":1874884,"avatar_url":"https://avatars2.githubusercontent.com/u/1874884?v=4","gravatar_id":"","url":"https://api.github.com/users/darwinfroese","html_url":"https://github.com/darwinfroese","followers_url":"https://api.github.com/users/darwinfroese/followers","following_url":"https://api.github.com/users/darwinfroese/following{/other_user}","gists_url":"https://api.github.com/users/darwinfroese/gists{/gist_id}","starred_url":"https://api.github.com/users/darwinfroese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darwinfroese/subscriptions","organizations_url":"https://api.github.com/users/darwinfroese/orgs","repos_url":"https://api.github.com/users/darwinfroese/repos","events_url":"https://api.github.com/users/darwinfroese/events{/privacy}","received_events_url":"https://api.github.com/users/darwinfroese/received_events","type":"User","site_admin":false},"body":"No, how you have it is perfect. Bolt stores one value as a lookup value so you would have to store the account three times. \n\nIt's a bit of a performance hit but I think it should be better with a switch to Dynamo DB for production in the future. ","created_at":"2017-10-07T22:05:11Z","updated_at":"2017-10-07T22:05:11Z","html_url":"https://github.com/darwinfroese/hacksite/pull/28#discussion_r143341675","pull_request_url":"https://api.github.com/repos/darwinfroese/hacksite/pulls/28","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/darwinfroese/hacksite/pulls/comments/143341675"},"html":{"href":"https://github.com/darwinfroese/hacksite/pull/28#discussion_r143341675"},"pull_request":{"href":"https://api.github.com/repos/darwinfroese/hacksite/pulls/28"}},"in_reply_to_id":143338888},"pull_request":{"url":"https://api.github.com/repos/darwinfroese/hacksite/pulls/28","id":145301151,"html_url":"https://github.com/darwinfroese/hacksite/pull/28","diff_url":"https://github.com/darwinfroese/hacksite/pull/28.diff","patch_url":"https://github.com/darwinfroese/hacksite/pull/28.patch","issue_url":"https://api.github.com/repos/darwinfroese/hacksite/issues/28","number":28,"state":"open","locked":false,"title":"Outridair 1","user":{"login":"The-Outrider","id":6240904,"avatar_url":"https://avatars2.githubusercontent.com/u/6240904?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Outrider","html_url":"https://github.com/The-Outrider","followers_url":"https://api.github.com/users/The-Outrider/followers","following_url":"https://api.github.com/users/The-Outrider/following{/other_user}","gists_url":"https://api.github.com/users/The-Outrider/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Outrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Outrider/subscriptions","organizations_url":"https://api.github.com/users/The-Outrider/orgs","repos_url":"https://api.github.com/users/The-Outrider/repos","events_url":"https://api.github.com/users/The-Outrider/events{/privacy}","received_events_url":"https://api.github.com/users/The-Outrider/received_events","type":"User","site_admin":false},"body":"# Feature Request, Username and Email checks before submission - Issue #1 \r\n\r\nI created the server side validation logic for checking if a username and email already exists by making a copy of the \"GetAccount\" method with \"GetAccountByEmail\" making the checks and sending error messages to the client. \r\n\r\nAlso... I added a new Vue library called [Vee-Validate ](http://vee-validate.logaretm.com/index.html#about) to do client side validation of the fields and updated the CreateAccount.Vue file .\r\n\r\n### Notes\r\nSome talking points... I'm a total golang noob => if anything in the code seems strange or doesn't make sense, assume I have no idea what I am doing. I come from a NodeJs // PHP background looking to get a \"real\" server-side language under my belt.\r\n\r\nBe sure to run a `yarn install` to get the new Vue package\r\n\r\n@darwinfroese\r\n","created_at":"2017-10-07T17:40:24Z","updated_at":"2017-10-07T22:05:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8331823a6b78083ca3bbcc3c15ccf2f33e8cbd76","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/darwinfroese/hacksite/pulls/28/commits","review_comments_url":"https://api.github.com/repos/darwinfroese/hacksite/pulls/28/comments","review_comment_url":"https://api.github.com/repos/darwinfroese/hacksite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darwinfroese/hacksite/issues/28/comments","statuses_url":"https://api.github.com/repos/darwinfroese/hacksite/statuses/810e62a91f5d117a47f926f18d33d385aef55b11","head":{"label":"The-Outrider:outridair_1","ref":"outridair_1","sha":"810e62a91f5d117a47f926f18d33d385aef55b11","user":{"login":"The-Outrider","id":6240904,"avatar_url":"https://avatars2.githubusercontent.com/u/6240904?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Outrider","html_url":"https://github.com/The-Outrider","followers_url":"https://api.github.com/users/The-Outrider/followers","following_url":"https://api.github.com/users/The-Outrider/following{/other_user}","gists_url":"https://api.github.com/users/The-Outrider/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Outrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Outrider/subscriptions","organizations_url":"https://api.github.com/users/The-Outrider/orgs","repos_url":"https://api.github.com/users/The-Outrider/repos","events_url":"https://api.github.com/users/The-Outrider/events{/privacy}","received_events_url":"https://api.github.com/users/The-Outrider/received_events","type":"User","site_admin":false},"repo":{"id":105607372,"name":"hacksite","full_name":"The-Outrider/hacksite","owner":{"login":"The-Outrider","id":6240904,"avatar_url":"https://avatars2.githubusercontent.com/u/6240904?v=4","gravatar_id":"","url":"https://api.github.com/users/The-Outrider","html_url":"https://github.com/The-Outrider","followers_url":"https://api.github.com/users/The-Outrider/followers","following_url":"https://api.github.com/users/The-Outrider/following{/other_user}","gists_url":"https://api.github.com/users/The-Outrider/gists{/gist_id}","starred_url":"https://api.github.com/users/The-Outrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/The-Outrider/subscriptions","organizations_url":"https://api.github.com/users/The-Outrider/orgs","repos_url":"https://api.github.com/users/The-Outrider/repos","events_url":"https://api.github.com/users/The-Outrider/events{/privacy}","received_events_url":"https://api.github.com/users/The-Outrider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/The-Outrider/hacksite","description":"My take on the traditional todo list app focusing on making project completion more acheivable. Current version is insecure and always changing!","fork":true,"url":"https://api.github.com/repos/The-Outrider/hacksite","forks_url":"https://api.github.com/repos/The-Outrider/hacksite/forks","keys_url":"https://api.github.com/repos/The-Outrider/hacksite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/The-Outrider/hacksite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/The-Outrider/hacksite/teams","hooks_url":"https://api.github.com/repos/The-Outrider/hacksite/hooks","issue_events_url":"https://api.github.com/repos/The-Outrider/hacksite/issues/events{/number}","events_url":"https://api.github.com/repos/The-Outrider/hacksite/events","assignees_url":"https://api.github.com/repos/The-Outrider/hacksite/assignees{/user}","branches_url":"https://api.github.com/repos/The-Outrider/hacksite/branches{/branch}","tags_url":"https://api.github.com/repos/The-Outrider/hacksite/tags","blobs_url":"https://api.github.com/repos/The-Outrider/hacksite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/The-Outrider/hacksite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/The-Outrider/hacksite/git/refs{/sha}","trees_url":"https://api.github.com/repos/The-Outrider/hacksite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/The-Outrider/hacksite/statuses/{sha}","languages_url":"https://api.github.com/repos/The-Outrider/hacksite/languages","stargazers_url":"https://api.github.com/repos/The-Outrider/hacksite/stargazers","contributors_url":"https://api.github.com/repos/The-Outrider/hacksite/contributors","subscribers_url":"https://api.github.com/repos/The-Outrider/hacksite/subscribers","subscription_url":"https://api.github.com/repos/The-Outrider/hacksite/subscription","commits_url":"https://api.github.com/repos/The-Outrider/hacksite/commits{/sha}","git_commits_url":"https://api.github.com/repos/The-Outrider/hacksite/git/commits{/sha}","comments_url":"https://api.github.com/repos/The-Outrider/hacksite/comments{/number}","issue_comment_url":"https://api.github.com/repos/The-Outrider/hacksite/issues/comments{/number}","contents_url":"https://api.github.com/repos/The-Outrider/hacksite/contents/{+path}","compare_url":"https://api.github.com/repos/The-Outrider/hacksite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/The-Outrider/hacksite/merges","archive_url":"https://api.github.com/repos/The-Outrider/hacksite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/The-Outrider/hacksite/downloads","issues_url":"https://api.github.com/repos/The-Outrider/hacksite/issues{/number}","pulls_url":"https://api.github.com/repos/The-Outrider/hacksite/pulls{/number}","milestones_url":"https://api.github.com/repos/The-Outrider/hacksite/milestones{/number}","notifications_url":"https://api.github.com/repos/The-Outrider/hacksite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/The-Outrider/hacksite/labels{/name}","releases_url":"https://api.github.com/repos/The-Outrider/hacksite/releases{/id}","deployments_url":"https://api.github.com/repos/The-Outrider/hacksite/deployments","created_at":"2017-10-03T02:35:36Z","updated_at":"2017-10-03T02:35:37Z","pushed_at":"2017-10-07T22:04:01Z","git_url":"git://github.com/The-Outrider/hacksite.git","ssh_url":"git@github.com:The-Outrider/hacksite.git","clone_url":"https://github.com/The-Outrider/hacksite.git","svn_url":"https://github.com/The-Outrider/hacksite","homepage":"http://hacksite.iamdarwin.ca","size":259,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"darwinfroese:master","ref":"master","sha":"8f1eac2f82f2a55d6b31630204052ead4e15a8ec","user":{"login":"darwinfroese","id":1874884,"avatar_url":"https://avatars2.githubusercontent.com/u/1874884?v=4","gravatar_id":"","url":"https://api.github.com/users/darwinfroese","html_url":"https://github.com/darwinfroese","followers_url":"https://api.github.com/users/darwinfroese/followers","following_url":"https://api.github.com/users/darwinfroese/following{/other_user}","gists_url":"https://api.github.com/users/darwinfroese/gists{/gist_id}","starred_url":"https://api.github.com/users/darwinfroese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darwinfroese/subscriptions","organizations_url":"https://api.github.com/users/darwinfroese/orgs","repos_url":"https://api.github.com/users/darwinfroese/repos","events_url":"https://api.github.com/users/darwinfroese/events{/privacy}","received_events_url":"https://api.github.com/users/darwinfroese/received_events","type":"User","site_admin":false},"repo":{"id":100887937,"name":"hacksite","full_name":"darwinfroese/hacksite","owner":{"login":"darwinfroese","id":1874884,"avatar_url":"https://avatars2.githubusercontent.com/u/1874884?v=4","gravatar_id":"","url":"https://api.github.com/users/darwinfroese","html_url":"https://github.com/darwinfroese","followers_url":"https://api.github.com/users/darwinfroese/followers","following_url":"https://api.github.com/users/darwinfroese/following{/other_user}","gists_url":"https://api.github.com/users/darwinfroese/gists{/gist_id}","starred_url":"https://api.github.com/users/darwinfroese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darwinfroese/subscriptions","organizations_url":"https://api.github.com/users/darwinfroese/orgs","repos_url":"https://api.github.com/users/darwinfroese/repos","events_url":"https://api.github.com/users/darwinfroese/events{/privacy}","received_events_url":"https://api.github.com/users/darwinfroese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darwinfroese/hacksite","description":"My take on the traditional todo list app focusing on making project completion more acheivable. Current version is insecure and always changing!","fork":false,"url":"https://api.github.com/repos/darwinfroese/hacksite","forks_url":"https://api.github.com/repos/darwinfroese/hacksite/forks","keys_url":"https://api.github.com/repos/darwinfroese/hacksite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darwinfroese/hacksite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darwinfroese/hacksite/teams","hooks_url":"https://api.github.com/repos/darwinfroese/hacksite/hooks","issue_events_url":"https://api.github.com/repos/darwinfroese/hacksite/issues/events{/number}","events_url":"https://api.github.com/repos/darwinfroese/hacksite/events","assignees_url":"https://api.github.com/repos/darwinfroese/hacksite/assignees{/user}","branches_url":"https://api.github.com/repos/darwinfroese/hacksite/branches{/branch}","tags_url":"https://api.github.com/repos/darwinfroese/hacksite/tags","blobs_url":"https://api.github.com/repos/darwinfroese/hacksite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darwinfroese/hacksite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darwinfroese/hacksite/git/refs{/sha}","trees_url":"https://api.github.com/repos/darwinfroese/hacksite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darwinfroese/hacksite/statuses/{sha}","languages_url":"https://api.github.com/repos/darwinfroese/hacksite/languages","stargazers_url":"https://api.github.com/repos/darwinfroese/hacksite/stargazers","contributors_url":"https://api.github.com/repos/darwinfroese/hacksite/contributors","subscribers_url":"https://api.github.com/repos/darwinfroese/hacksite/subscribers","subscription_url":"https://api.github.com/repos/darwinfroese/hacksite/subscription","commits_url":"https://api.github.com/repos/darwinfroese/hacksite/commits{/sha}","git_commits_url":"https://api.github.com/repos/darwinfroese/hacksite/git/commits{/sha}","comments_url":"https://api.github.com/repos/darwinfroese/hacksite/comments{/number}","issue_comment_url":"https://api.github.com/repos/darwinfroese/hacksite/issues/comments{/number}","contents_url":"https://api.github.com/repos/darwinfroese/hacksite/contents/{+path}","compare_url":"https://api.github.com/repos/darwinfroese/hacksite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darwinfroese/hacksite/merges","archive_url":"https://api.github.com/repos/darwinfroese/hacksite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darwinfroese/hacksite/downloads","issues_url":"https://api.github.com/repos/darwinfroese/hacksite/issues{/number}","pulls_url":"https://api.github.com/repos/darwinfroese/hacksite/pulls{/number}","milestones_url":"https://api.github.com/repos/darwinfroese/hacksite/milestones{/number}","notifications_url":"https://api.github.com/repos/darwinfroese/hacksite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darwinfroese/hacksite/labels{/name}","releases_url":"https://api.github.com/repos/darwinfroese/hacksite/releases{/id}","deployments_url":"https://api.github.com/repos/darwinfroese/hacksite/deployments","created_at":"2017-08-20T20:47:18Z","updated_at":"2017-10-03T18:43:24Z","pushed_at":"2017-10-07T22:04:02Z","git_url":"git://github.com/darwinfroese/hacksite.git","ssh_url":"git@github.com:darwinfroese/hacksite.git","clone_url":"https://github.com/darwinfroese/hacksite.git","svn_url":"https://github.com/darwinfroese/hacksite","homepage":"https://hacksite.iamdarwin.ca","size":251,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":17,"forks":3,"open_issues":17,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/darwinfroese/hacksite/pulls/28"},"html":{"href":"https://github.com/darwinfroese/hacksite/pull/28"},"issue":{"href":"https://api.github.com/repos/darwinfroese/hacksite/issues/28"},"comments":{"href":"https://api.github.com/repos/darwinfroese/hacksite/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/darwinfroese/hacksite/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/darwinfroese/hacksite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darwinfroese/hacksite/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/darwinfroese/hacksite/statuses/810e62a91f5d117a47f926f18d33d385aef55b11"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"darwinfroese"}}