{"action":"created","comment":{"url":"https://api.github.com/repos/frida/frida-gum/pulls/comments/155767206","pull_request_review_id":82141906,"id":155767206,"diff_hunk":"@@ -2479,8 +2483,13 @@ gum_exec_block_write_call_invoke_code (GumExecBlock * block,\n   gconstpointer try_second = cw->code + 2;\n   gconstpointer jump_to_cached = cw->code + 3;\n   gconstpointer resolve_dynamically = cw->code + 4;\n+  gconstpointer keep_this_blr = cw->code + 5;\n   gpointer ret_real_address, ret_code_address;\n \n+  GumBranchTarget next_insn_as_target = { 0, };\n+  next_insn_as_target.absolute_address = gc->instruction->end;\n+  next_insn_as_target.reg = ARM64_REG_INVALID;\n+","path":"gum/backend-arm64/gumstalker-arm64.c","position":28,"original_position":28,"commit_id":"81f833885fcb6e8dd4529c1251908823af5b81bf","original_commit_id":"81f833885fcb6e8dd4529c1251908823af5b81bf","user":{"login":"oleavr","id":735197,"avatar_url":"https://avatars3.githubusercontent.com/u/735197?v=4","gravatar_id":"","url":"https://api.github.com/users/oleavr","html_url":"https://github.com/oleavr","followers_url":"https://api.github.com/users/oleavr/followers","following_url":"https://api.github.com/users/oleavr/following{/other_user}","gists_url":"https://api.github.com/users/oleavr/gists{/gist_id}","starred_url":"https://api.github.com/users/oleavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleavr/subscriptions","organizations_url":"https://api.github.com/users/oleavr/orgs","repos_url":"https://api.github.com/users/oleavr/repos","events_url":"https://api.github.com/users/oleavr/events{/privacy}","received_events_url":"https://api.github.com/users/oleavr/received_events","type":"User","site_admin":false},"body":"Would be good to move this down to the local scope (as it's only used there).","created_at":"2017-12-08T12:29:57Z","updated_at":"2017-12-08T12:43:30Z","html_url":"https://github.com/frida/frida-gum/pull/248#discussion_r155767206","pull_request_url":"https://api.github.com/repos/frida/frida-gum/pulls/248","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/comments/155767206"},"html":{"href":"https://github.com/frida/frida-gum/pull/248#discussion_r155767206"},"pull_request":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/frida/frida-gum/pulls/248","id":157204698,"html_url":"https://github.com/frida/frida-gum/pull/248","diff_url":"https://github.com/frida/frida-gum/pull/248.diff","patch_url":"https://github.com/frida/frida-gum/pull/248.patch","issue_url":"https://api.github.com/repos/frida/frida-gum/issues/248","number":248,"state":"open","locked":false,"title":"Add feature for the stalker exclusion when BLR","user":{"login":"akiannillo","id":8834392,"avatar_url":"https://avatars0.githubusercontent.com/u/8834392?v=4","gravatar_id":"","url":"https://api.github.com/users/akiannillo","html_url":"https://github.com/akiannillo","followers_url":"https://api.github.com/users/akiannillo/followers","following_url":"https://api.github.com/users/akiannillo/following{/other_user}","gists_url":"https://api.github.com/users/akiannillo/gists{/gist_id}","starred_url":"https://api.github.com/users/akiannillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akiannillo/subscriptions","organizations_url":"https://api.github.com/users/akiannillo/orgs","repos_url":"https://api.github.com/users/akiannillo/repos","events_url":"https://api.github.com/users/akiannillo/events{/privacy}","received_events_url":"https://api.github.com/users/akiannillo/received_events","type":"User","site_admin":false},"body":"I modified the virtualize branch instruction function in the stalker, added two tests, and a script to run test with android arm 64.\r\n\r\nI have only a doubt whether to add something for the unfollow me, such in [L554](https://github.com/frida/frida-gum/blob/master/gum/backend-arm64/gumstalker-arm64.c#L554).\r\n\r\n(new performance duration ratio is at most 1.15)","created_at":"2017-12-08T10:02:59Z","updated_at":"2017-12-08T12:43:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"573bea3936355ebb7d68fe1840758b28c994faa6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/frida/frida-gum/pulls/248/commits","review_comments_url":"https://api.github.com/repos/frida/frida-gum/pulls/248/comments","review_comment_url":"https://api.github.com/repos/frida/frida-gum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frida/frida-gum/issues/248/comments","statuses_url":"https://api.github.com/repos/frida/frida-gum/statuses/81f833885fcb6e8dd4529c1251908823af5b81bf","head":{"label":"akiannillo:addfeature/exclude-blr","ref":"addfeature/exclude-blr","sha":"81f833885fcb6e8dd4529c1251908823af5b81bf","user":{"login":"akiannillo","id":8834392,"avatar_url":"https://avatars0.githubusercontent.com/u/8834392?v=4","gravatar_id":"","url":"https://api.github.com/users/akiannillo","html_url":"https://github.com/akiannillo","followers_url":"https://api.github.com/users/akiannillo/followers","following_url":"https://api.github.com/users/akiannillo/following{/other_user}","gists_url":"https://api.github.com/users/akiannillo/gists{/gist_id}","starred_url":"https://api.github.com/users/akiannillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akiannillo/subscriptions","organizations_url":"https://api.github.com/users/akiannillo/orgs","repos_url":"https://api.github.com/users/akiannillo/repos","events_url":"https://api.github.com/users/akiannillo/events{/privacy}","received_events_url":"https://api.github.com/users/akiannillo/received_events","type":"User","site_admin":false},"repo":{"id":113458267,"name":"frida-gum","full_name":"akiannillo/frida-gum","owner":{"login":"akiannillo","id":8834392,"avatar_url":"https://avatars0.githubusercontent.com/u/8834392?v=4","gravatar_id":"","url":"https://api.github.com/users/akiannillo","html_url":"https://github.com/akiannillo","followers_url":"https://api.github.com/users/akiannillo/followers","following_url":"https://api.github.com/users/akiannillo/following{/other_user}","gists_url":"https://api.github.com/users/akiannillo/gists{/gist_id}","starred_url":"https://api.github.com/users/akiannillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akiannillo/subscriptions","organizations_url":"https://api.github.com/users/akiannillo/orgs","repos_url":"https://api.github.com/users/akiannillo/repos","events_url":"https://api.github.com/users/akiannillo/events{/privacy}","received_events_url":"https://api.github.com/users/akiannillo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akiannillo/frida-gum","description":"Low-level code instrumentation library used by frida-core","fork":true,"url":"https://api.github.com/repos/akiannillo/frida-gum","forks_url":"https://api.github.com/repos/akiannillo/frida-gum/forks","keys_url":"https://api.github.com/repos/akiannillo/frida-gum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akiannillo/frida-gum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akiannillo/frida-gum/teams","hooks_url":"https://api.github.com/repos/akiannillo/frida-gum/hooks","issue_events_url":"https://api.github.com/repos/akiannillo/frida-gum/issues/events{/number}","events_url":"https://api.github.com/repos/akiannillo/frida-gum/events","assignees_url":"https://api.github.com/repos/akiannillo/frida-gum/assignees{/user}","branches_url":"https://api.github.com/repos/akiannillo/frida-gum/branches{/branch}","tags_url":"https://api.github.com/repos/akiannillo/frida-gum/tags","blobs_url":"https://api.github.com/repos/akiannillo/frida-gum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akiannillo/frida-gum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akiannillo/frida-gum/git/refs{/sha}","trees_url":"https://api.github.com/repos/akiannillo/frida-gum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akiannillo/frida-gum/statuses/{sha}","languages_url":"https://api.github.com/repos/akiannillo/frida-gum/languages","stargazers_url":"https://api.github.com/repos/akiannillo/frida-gum/stargazers","contributors_url":"https://api.github.com/repos/akiannillo/frida-gum/contributors","subscribers_url":"https://api.github.com/repos/akiannillo/frida-gum/subscribers","subscription_url":"https://api.github.com/repos/akiannillo/frida-gum/subscription","commits_url":"https://api.github.com/repos/akiannillo/frida-gum/commits{/sha}","git_commits_url":"https://api.github.com/repos/akiannillo/frida-gum/git/commits{/sha}","comments_url":"https://api.github.com/repos/akiannillo/frida-gum/comments{/number}","issue_comment_url":"https://api.github.com/repos/akiannillo/frida-gum/issues/comments{/number}","contents_url":"https://api.github.com/repos/akiannillo/frida-gum/contents/{+path}","compare_url":"https://api.github.com/repos/akiannillo/frida-gum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akiannillo/frida-gum/merges","archive_url":"https://api.github.com/repos/akiannillo/frida-gum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akiannillo/frida-gum/downloads","issues_url":"https://api.github.com/repos/akiannillo/frida-gum/issues{/number}","pulls_url":"https://api.github.com/repos/akiannillo/frida-gum/pulls{/number}","milestones_url":"https://api.github.com/repos/akiannillo/frida-gum/milestones{/number}","notifications_url":"https://api.github.com/repos/akiannillo/frida-gum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akiannillo/frida-gum/labels{/name}","releases_url":"https://api.github.com/repos/akiannillo/frida-gum/releases{/id}","deployments_url":"https://api.github.com/repos/akiannillo/frida-gum/deployments","created_at":"2017-12-07T14:07:13Z","updated_at":"2017-12-07T14:07:16Z","pushed_at":"2017-12-08T09:56:59Z","git_url":"git://github.com/akiannillo/frida-gum.git","ssh_url":"git@github.com:akiannillo/frida-gum.git","clone_url":"https://github.com/akiannillo/frida-gum.git","svn_url":"https://github.com/akiannillo/frida-gum","homepage":"","size":20397,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"frida:master","ref":"master","sha":"511f2992f4320d380d117fa5bfcc3ec8817c1054","user":{"login":"frida","id":4073090,"avatar_url":"https://avatars3.githubusercontent.com/u/4073090?v=4","gravatar_id":"","url":"https://api.github.com/users/frida","html_url":"https://github.com/frida","followers_url":"https://api.github.com/users/frida/followers","following_url":"https://api.github.com/users/frida/following{/other_user}","gists_url":"https://api.github.com/users/frida/gists{/gist_id}","starred_url":"https://api.github.com/users/frida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frida/subscriptions","organizations_url":"https://api.github.com/users/frida/orgs","repos_url":"https://api.github.com/users/frida/repos","events_url":"https://api.github.com/users/frida/events{/privacy}","received_events_url":"https://api.github.com/users/frida/received_events","type":"Organization","site_admin":false},"repo":{"id":9340574,"name":"frida-gum","full_name":"frida/frida-gum","owner":{"login":"frida","id":4073090,"avatar_url":"https://avatars3.githubusercontent.com/u/4073090?v=4","gravatar_id":"","url":"https://api.github.com/users/frida","html_url":"https://github.com/frida","followers_url":"https://api.github.com/users/frida/followers","following_url":"https://api.github.com/users/frida/following{/other_user}","gists_url":"https://api.github.com/users/frida/gists{/gist_id}","starred_url":"https://api.github.com/users/frida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frida/subscriptions","organizations_url":"https://api.github.com/users/frida/orgs","repos_url":"https://api.github.com/users/frida/repos","events_url":"https://api.github.com/users/frida/events{/privacy}","received_events_url":"https://api.github.com/users/frida/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frida/frida-gum","description":"Low-level code instrumentation library used by frida-core","fork":false,"url":"https://api.github.com/repos/frida/frida-gum","forks_url":"https://api.github.com/repos/frida/frida-gum/forks","keys_url":"https://api.github.com/repos/frida/frida-gum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frida/frida-gum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frida/frida-gum/teams","hooks_url":"https://api.github.com/repos/frida/frida-gum/hooks","issue_events_url":"https://api.github.com/repos/frida/frida-gum/issues/events{/number}","events_url":"https://api.github.com/repos/frida/frida-gum/events","assignees_url":"https://api.github.com/repos/frida/frida-gum/assignees{/user}","branches_url":"https://api.github.com/repos/frida/frida-gum/branches{/branch}","tags_url":"https://api.github.com/repos/frida/frida-gum/tags","blobs_url":"https://api.github.com/repos/frida/frida-gum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frida/frida-gum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frida/frida-gum/git/refs{/sha}","trees_url":"https://api.github.com/repos/frida/frida-gum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frida/frida-gum/statuses/{sha}","languages_url":"https://api.github.com/repos/frida/frida-gum/languages","stargazers_url":"https://api.github.com/repos/frida/frida-gum/stargazers","contributors_url":"https://api.github.com/repos/frida/frida-gum/contributors","subscribers_url":"https://api.github.com/repos/frida/frida-gum/subscribers","subscription_url":"https://api.github.com/repos/frida/frida-gum/subscription","commits_url":"https://api.github.com/repos/frida/frida-gum/commits{/sha}","git_commits_url":"https://api.github.com/repos/frida/frida-gum/git/commits{/sha}","comments_url":"https://api.github.com/repos/frida/frida-gum/comments{/number}","issue_comment_url":"https://api.github.com/repos/frida/frida-gum/issues/comments{/number}","contents_url":"https://api.github.com/repos/frida/frida-gum/contents/{+path}","compare_url":"https://api.github.com/repos/frida/frida-gum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frida/frida-gum/merges","archive_url":"https://api.github.com/repos/frida/frida-gum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frida/frida-gum/downloads","issues_url":"https://api.github.com/repos/frida/frida-gum/issues{/number}","pulls_url":"https://api.github.com/repos/frida/frida-gum/pulls{/number}","milestones_url":"https://api.github.com/repos/frida/frida-gum/milestones{/number}","notifications_url":"https://api.github.com/repos/frida/frida-gum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frida/frida-gum/labels{/name}","releases_url":"https://api.github.com/repos/frida/frida-gum/releases{/id}","deployments_url":"https://api.github.com/repos/frida/frida-gum/deployments","created_at":"2013-04-10T07:25:56Z","updated_at":"2017-12-05T08:44:08Z","pushed_at":"2017-12-08T10:03:00Z","git_url":"git://github.com/frida/frida-gum.git","ssh_url":"git@github.com:frida/frida-gum.git","clone_url":"https://github.com/frida/frida-gum.git","svn_url":"https://github.com/frida/frida-gum","homepage":"","size":20387,"stargazers_count":100,"watchers_count":100,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":48,"open_issues":24,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/248"},"html":{"href":"https://github.com/frida/frida-gum/pull/248"},"issue":{"href":"https://api.github.com/repos/frida/frida-gum/issues/248"},"comments":{"href":"https://api.github.com/repos/frida/frida-gum/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frida/frida-gum/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/frida/frida-gum/statuses/81f833885fcb6e8dd4529c1251908823af5b81bf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"oleavr"}}