{"action":"created","comment":{"url":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/comments/107485681","pull_request_review_id":28461489,"id":107485681,"diff_hunk":"@@ -33,11 +33,18 @@ void ADCTask::loop() {\n   int bat1_adc = adc.analogRead(bat1_analog, ADC_0);\n   int bat2_adc = adc.analogRead(bat2_analog, ADC_0);\n   int bat3_adc = adc.analogRead(bat3_analog, ADC_0);\n+    \n+  //permits rudder sensor on bat3 input.  Eventually should move rudder sensor calcs to a separate task","path":"lib/KBox/src/tasks/ADCTask.cpp","position":5,"original_position":5,"commit_id":"a10acb1c4acc983db1f49db44b66ae73aff45af8","original_commit_id":"4157c50a5df25f1ea2332f45033c7a99dcd249e3","user":{"login":"matrixlinks","id":26550885,"avatar_url":"https://avatars2.githubusercontent.com/u/26550885?v=3","gravatar_id":"","url":"https://api.github.com/users/matrixlinks","html_url":"https://github.com/matrixlinks","followers_url":"https://api.github.com/users/matrixlinks/followers","following_url":"https://api.github.com/users/matrixlinks/following{/other_user}","gists_url":"https://api.github.com/users/matrixlinks/gists{/gist_id}","starred_url":"https://api.github.com/users/matrixlinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrixlinks/subscriptions","organizations_url":"https://api.github.com/users/matrixlinks/orgs","repos_url":"https://api.github.com/users/matrixlinks/repos","events_url":"https://api.github.com/users/matrixlinks/events{/privacy}","received_events_url":"https://api.github.com/users/matrixlinks/received_events","type":"User","site_admin":false},"body":"I was just taking a shortcut here for now.  I assume the better solution is to create a separate RudderSensor task and move the relevant code into that.","created_at":"2017-03-22T17:50:47Z","updated_at":"2017-03-22T17:50:47Z","html_url":"https://github.com/sarfata/kbox-firmware/pull/28#discussion_r107485681","pull_request_url":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/comments/107485681"},"html":{"href":"https://github.com/sarfata/kbox-firmware/pull/28#discussion_r107485681"},"pull_request":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/28","id":111862677,"html_url":"https://github.com/sarfata/kbox-firmware/pull/28","diff_url":"https://github.com/sarfata/kbox-firmware/pull/28.diff","patch_url":"https://github.com/sarfata/kbox-firmware/pull/28.patch","issue_url":"https://api.github.com/repos/sarfata/kbox-firmware/issues/28","number":28,"state":"open","locked":false,"title":"Rigm edits","user":{"login":"matrixlinks","id":26550885,"avatar_url":"https://avatars2.githubusercontent.com/u/26550885?v=3","gravatar_id":"","url":"https://api.github.com/users/matrixlinks","html_url":"https://github.com/matrixlinks","followers_url":"https://api.github.com/users/matrixlinks/followers","following_url":"https://api.github.com/users/matrixlinks/following{/other_user}","gists_url":"https://api.github.com/users/matrixlinks/gists{/gist_id}","starred_url":"https://api.github.com/users/matrixlinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrixlinks/subscriptions","organizations_url":"https://api.github.com/users/matrixlinks/orgs","repos_url":"https://api.github.com/users/matrixlinks/repos","events_url":"https://api.github.com/users/matrixlinks/events{/privacy}","received_events_url":"https://api.github.com/users/matrixlinks/received_events","type":"User","site_admin":false},"body":"Change to enable configuring Kbox orientation and autopilot functionality","created_at":"2017-03-21T19:41:33Z","updated_at":"2017-03-22T17:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34cafb19d703f7a4537614480a7dae6e96e881a5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/28/commits","review_comments_url":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/28/comments","review_comment_url":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sarfata/kbox-firmware/issues/28/comments","statuses_url":"https://api.github.com/repos/sarfata/kbox-firmware/statuses/a10acb1c4acc983db1f49db44b66ae73aff45af8","head":{"label":"matrixlinks:RIGM-edits","ref":"RIGM-edits","sha":"a10acb1c4acc983db1f49db44b66ae73aff45af8","user":{"login":"matrixlinks","id":26550885,"avatar_url":"https://avatars2.githubusercontent.com/u/26550885?v=3","gravatar_id":"","url":"https://api.github.com/users/matrixlinks","html_url":"https://github.com/matrixlinks","followers_url":"https://api.github.com/users/matrixlinks/followers","following_url":"https://api.github.com/users/matrixlinks/following{/other_user}","gists_url":"https://api.github.com/users/matrixlinks/gists{/gist_id}","starred_url":"https://api.github.com/users/matrixlinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrixlinks/subscriptions","organizations_url":"https://api.github.com/users/matrixlinks/orgs","repos_url":"https://api.github.com/users/matrixlinks/repos","events_url":"https://api.github.com/users/matrixlinks/events{/privacy}","received_events_url":"https://api.github.com/users/matrixlinks/received_events","type":"User","site_admin":false},"repo":{"id":85737145,"name":"kbox-firmware","full_name":"matrixlinks/kbox-firmware","owner":{"login":"matrixlinks","id":26550885,"avatar_url":"https://avatars2.githubusercontent.com/u/26550885?v=3","gravatar_id":"","url":"https://api.github.com/users/matrixlinks","html_url":"https://github.com/matrixlinks","followers_url":"https://api.github.com/users/matrixlinks/followers","following_url":"https://api.github.com/users/matrixlinks/following{/other_user}","gists_url":"https://api.github.com/users/matrixlinks/gists{/gist_id}","starred_url":"https://api.github.com/users/matrixlinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrixlinks/subscriptions","organizations_url":"https://api.github.com/users/matrixlinks/orgs","repos_url":"https://api.github.com/users/matrixlinks/repos","events_url":"https://api.github.com/users/matrixlinks/events{/privacy}","received_events_url":"https://api.github.com/users/matrixlinks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matrixlinks/kbox-firmware","description":"KBox Firmware","fork":true,"url":"https://api.github.com/repos/matrixlinks/kbox-firmware","forks_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/forks","keys_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/teams","hooks_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/hooks","issue_events_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/events","assignees_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/tags","blobs_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/languages","stargazers_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/stargazers","contributors_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/contributors","subscribers_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/subscribers","subscription_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/subscription","commits_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/merges","archive_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/downloads","issues_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/labels{/name}","releases_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/matrixlinks/kbox-firmware/deployments","created_at":"2017-03-21T18:09:31Z","updated_at":"2017-03-21T18:09:33Z","pushed_at":"2017-03-22T10:01:24Z","git_url":"git://github.com/matrixlinks/kbox-firmware.git","ssh_url":"git@github.com:matrixlinks/kbox-firmware.git","clone_url":"https://github.com/matrixlinks/kbox-firmware.git","svn_url":"https://github.com/matrixlinks/kbox-firmware","homepage":"","size":9099,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sarfata:master","ref":"master","sha":"8a33cf952f55832b3d0a1797e8de6fcf0e35f244","user":{"login":"sarfata","id":779005,"avatar_url":"https://avatars3.githubusercontent.com/u/779005?v=3","gravatar_id":"","url":"https://api.github.com/users/sarfata","html_url":"https://github.com/sarfata","followers_url":"https://api.github.com/users/sarfata/followers","following_url":"https://api.github.com/users/sarfata/following{/other_user}","gists_url":"https://api.github.com/users/sarfata/gists{/gist_id}","starred_url":"https://api.github.com/users/sarfata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarfata/subscriptions","organizations_url":"https://api.github.com/users/sarfata/orgs","repos_url":"https://api.github.com/users/sarfata/repos","events_url":"https://api.github.com/users/sarfata/events{/privacy}","received_events_url":"https://api.github.com/users/sarfata/received_events","type":"User","site_admin":false},"repo":{"id":48160160,"name":"kbox-firmware","full_name":"sarfata/kbox-firmware","owner":{"login":"sarfata","id":779005,"avatar_url":"https://avatars3.githubusercontent.com/u/779005?v=3","gravatar_id":"","url":"https://api.github.com/users/sarfata","html_url":"https://github.com/sarfata","followers_url":"https://api.github.com/users/sarfata/followers","following_url":"https://api.github.com/users/sarfata/following{/other_user}","gists_url":"https://api.github.com/users/sarfata/gists{/gist_id}","starred_url":"https://api.github.com/users/sarfata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarfata/subscriptions","organizations_url":"https://api.github.com/users/sarfata/orgs","repos_url":"https://api.github.com/users/sarfata/repos","events_url":"https://api.github.com/users/sarfata/events{/privacy}","received_events_url":"https://api.github.com/users/sarfata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarfata/kbox-firmware","description":"KBox Firmware","fork":false,"url":"https://api.github.com/repos/sarfata/kbox-firmware","forks_url":"https://api.github.com/repos/sarfata/kbox-firmware/forks","keys_url":"https://api.github.com/repos/sarfata/kbox-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarfata/kbox-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarfata/kbox-firmware/teams","hooks_url":"https://api.github.com/repos/sarfata/kbox-firmware/hooks","issue_events_url":"https://api.github.com/repos/sarfata/kbox-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/sarfata/kbox-firmware/events","assignees_url":"https://api.github.com/repos/sarfata/kbox-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/sarfata/kbox-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/sarfata/kbox-firmware/tags","blobs_url":"https://api.github.com/repos/sarfata/kbox-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarfata/kbox-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarfata/kbox-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarfata/kbox-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarfata/kbox-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/sarfata/kbox-firmware/languages","stargazers_url":"https://api.github.com/repos/sarfata/kbox-firmware/stargazers","contributors_url":"https://api.github.com/repos/sarfata/kbox-firmware/contributors","subscribers_url":"https://api.github.com/repos/sarfata/kbox-firmware/subscribers","subscription_url":"https://api.github.com/repos/sarfata/kbox-firmware/subscription","commits_url":"https://api.github.com/repos/sarfata/kbox-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarfata/kbox-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarfata/kbox-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarfata/kbox-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarfata/kbox-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/sarfata/kbox-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarfata/kbox-firmware/merges","archive_url":"https://api.github.com/repos/sarfata/kbox-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarfata/kbox-firmware/downloads","issues_url":"https://api.github.com/repos/sarfata/kbox-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/sarfata/kbox-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/sarfata/kbox-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/sarfata/kbox-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarfata/kbox-firmware/labels{/name}","releases_url":"https://api.github.com/repos/sarfata/kbox-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/sarfata/kbox-firmware/deployments","created_at":"2015-12-17T07:47:33Z","updated_at":"2017-02-16T15:54:40Z","pushed_at":"2017-03-22T10:01:25Z","git_url":"git://github.com/sarfata/kbox-firmware.git","ssh_url":"git@github.com:sarfata/kbox-firmware.git","clone_url":"https://github.com/sarfata/kbox-firmware.git","svn_url":"https://github.com/sarfata/kbox-firmware","homepage":"","size":9079,"stargazers_count":12,"watchers_count":12,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/28"},"html":{"href":"https://github.com/sarfata/kbox-firmware/pull/28"},"issue":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/issues/28"},"comments":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/sarfata/kbox-firmware/statuses/a10acb1c4acc983db1f49db44b66ae73aff45af8"}}}}
{"actor":{"display_login":"matrixlinks"}}