{"action":"created","issue":{"url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/126","repository_url":"https://api.github.com/repos/google/google-auth-library-nodejs","labels_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/126/comments","events_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/126/events","html_url":"https://github.com/google/google-auth-library-nodejs/pull/126","id":210420467,"number":126,"title":"Remove lodash.noop lib dependency","user":{"login":"SkeLLLa","id":2273103,"avatar_url":"https://avatars.githubusercontent.com/u/2273103?v=3","gravatar_id":"","url":"https://api.github.com/users/SkeLLLa","html_url":"https://github.com/SkeLLLa","followers_url":"https://api.github.com/users/SkeLLLa/followers","following_url":"https://api.github.com/users/SkeLLLa/following{/other_user}","gists_url":"https://api.github.com/users/SkeLLLa/gists{/gist_id}","starred_url":"https://api.github.com/users/SkeLLLa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkeLLLa/subscriptions","organizations_url":"https://api.github.com/users/SkeLLLa/orgs","repos_url":"https://api.github.com/users/SkeLLLa/repos","events_url":"https://api.github.com/users/SkeLLLa/events{/privacy}","received_events_url":"https://api.github.com/users/SkeLLLa/received_events","type":"User","site_admin":false},"labels":[{"id":203213148,"url":"https://api.github.com/repos/google/google-auth-library-nodejs/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-02-27T08:45:41Z","updated_at":"2017-02-27T18:29:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/google-auth-library-nodejs/pulls/126","html_url":"https://github.com/google/google-auth-library-nodejs/pull/126","diff_url":"https://github.com/google/google-auth-library-nodejs/pull/126.diff","patch_url":"https://github.com/google/google-auth-library-nodejs/pull/126.patch"},"body":"Lodash noop lib is useless and it's better to use just:\r\n```js\r\nvar noop = Function;\r\n```\r\n\r\nBecause of following reasons:\r\n* It's shorter\r\n* It's faster\r\n* It doesn't take space in node_modules\r\n* It will not fail in case of deletion of lodash.noop\r\n* It will not take space in package.json and yarn.lock\r\n* Even lodash devs removed lodash.noop from their code."},"comment":{"url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/comments/282806876","html_url":"https://github.com/google/google-auth-library-nodejs/pull/126#issuecomment-282806876","issue_url":"https://api.github.com/repos/google/google-auth-library-nodejs/issues/126","id":282806876,"user":{"login":"jmdobry","id":1213510,"avatar_url":"https://avatars.githubusercontent.com/u/1213510?v=3","gravatar_id":"","url":"https://api.github.com/users/jmdobry","html_url":"https://github.com/jmdobry","followers_url":"https://api.github.com/users/jmdobry/followers","following_url":"https://api.github.com/users/jmdobry/following{/other_user}","gists_url":"https://api.github.com/users/jmdobry/gists{/gist_id}","starred_url":"https://api.github.com/users/jmdobry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmdobry/subscriptions","organizations_url":"https://api.github.com/users/jmdobry/orgs","repos_url":"https://api.github.com/users/jmdobry/repos","events_url":"https://api.github.com/users/jmdobry/events{/privacy}","received_events_url":"https://api.github.com/users/jmdobry/received_events","type":"User","site_admin":false},"created_at":"2017-02-27T18:29:44Z","updated_at":"2017-02-27T18:29:44Z","body":"With `var noop = Function.prototype;` we can avoid 4 extra function instances _and_ avoid modifying `utils.js`.\r\n\r\nUltimately though, I don't think this lib should be using noop at all, the callback should be mandatory (breaking change) where the lib is currently falling back to the noop."}}
{"actor":{"display_login":"jmdobry"}}