{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/comments/127385986","pull_request_review_id":49964611,"id":127385986,"diff_hunk":"@@ -16,7 +16,7 @@ public QueueLengthDataStore(IQueueLengthCalculator calculator)\n             get { return calculator.GetQueueLengths().Select(kvp => new KeyValuePair<string, JObject>(kvp.Key, new JObject(new JProperty(\"Count\", kvp.Value)))); }\n         }\n \n-        public void Store(JObject data)\n+        public void Store(string endpointName, string instanceId, JObject data)","path":"src/ServiceControl.Monitoring/QueueLength/QueueLengthDataStore.cs","position":5,"original_position":5,"commit_id":"ba61aef9a5db0be9d13c0dd382d5a5ec333b7809","original_commit_id":"ba61aef9a5db0be9d13c0dd382d5a5ec333b7809","user":{"login":"mikeminutillo","id":124014,"avatar_url":"https://avatars4.githubusercontent.com/u/124014?v=4","gravatar_id":"","url":"https://api.github.com/users/mikeminutillo","html_url":"https://github.com/mikeminutillo","followers_url":"https://api.github.com/users/mikeminutillo/followers","following_url":"https://api.github.com/users/mikeminutillo/following{/other_user}","gists_url":"https://api.github.com/users/mikeminutillo/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeminutillo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeminutillo/subscriptions","organizations_url":"https://api.github.com/users/mikeminutillo/orgs","repos_url":"https://api.github.com/users/mikeminutillo/repos","events_url":"https://api.github.com/users/mikeminutillo/events{/privacy}","received_events_url":"https://api.github.com/users/mikeminutillo/received_events","type":"User","site_admin":false},"body":"Why is this needed? These values don't get used.","created_at":"2017-07-14T05:14:04Z","updated_at":"2017-07-14T05:17:52Z","html_url":"https://github.com/Particular/ServiceControl.Monitoring/pull/30#discussion_r127385986","pull_request_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/comments/127385986"},"html":{"href":"https://github.com/Particular/ServiceControl.Monitoring/pull/30#discussion_r127385986"},"pull_request":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/30","id":130318868,"html_url":"https://github.com/Particular/ServiceControl.Monitoring/pull/30","diff_url":"https://github.com/Particular/ServiceControl.Monitoring/pull/30.diff","patch_url":"https://github.com/Particular/ServiceControl.Monitoring/pull/30.patch","issue_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/30","number":30,"state":"open","locked":false,"title":"Storing timing data per endpoint instance","user":{"login":"tmasternak","id":1092707,"avatar_url":"https://avatars4.githubusercontent.com/u/1092707?v=3","gravatar_id":"","url":"https://api.github.com/users/tmasternak","html_url":"https://github.com/tmasternak","followers_url":"https://api.github.com/users/tmasternak/followers","following_url":"https://api.github.com/users/tmasternak/following{/other_user}","gists_url":"https://api.github.com/users/tmasternak/gists{/gist_id}","starred_url":"https://api.github.com/users/tmasternak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmasternak/subscriptions","organizations_url":"https://api.github.com/users/tmasternak/orgs","repos_url":"https://api.github.com/users/tmasternak/repos","events_url":"https://api.github.com/users/tmasternak/events{/privacy}","received_events_url":"https://api.github.com/users/tmasternak/received_events","type":"User","site_admin":false},"body":"Connects to https://github.com/Particular/ServiceControl/issues/979\r\n\r\n### Goal\r\nStore information about number of physical instances for given logical endpoint.\r\n\r\n### PoA\r\n - [x] Parse `instanceId` passed from `NServiceBus.Metrics`\r\n - [x] Store information about known physical instances \r\n - [x] Expose number of physical instances in data returned form API \r\n - [x] Update ATT to newest version of `NServiceBus.Metrics`\r\n\r\n/cc: @WilliamBZA","created_at":"2017-07-13T08:58:07Z","updated_at":"2017-07-14T05:17:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5eac5406479e88c2331a29cf67bd1984c369a5cb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"WojcikMike","id":604826,"avatar_url":"https://avatars6.githubusercontent.com/u/604826?v=4","gravatar_id":"","url":"https://api.github.com/users/WojcikMike","html_url":"https://github.com/WojcikMike","followers_url":"https://api.github.com/users/WojcikMike/followers","following_url":"https://api.github.com/users/WojcikMike/following{/other_user}","gists_url":"https://api.github.com/users/WojcikMike/gists{/gist_id}","starred_url":"https://api.github.com/users/WojcikMike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WojcikMike/subscriptions","organizations_url":"https://api.github.com/users/WojcikMike/orgs","repos_url":"https://api.github.com/users/WojcikMike/repos","events_url":"https://api.github.com/users/WojcikMike/events{/privacy}","received_events_url":"https://api.github.com/users/WojcikMike/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/30/commits","review_comments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/30/comments","review_comment_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/30/comments","statuses_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/statuses/ba61aef9a5db0be9d13c0dd382d5a5ec333b7809","head":{"label":"Particular:storing-timing-data-per-endpoint-instance","ref":"storing-timing-data-per-endpoint-instance","sha":"ba61aef9a5db0be9d13c0dd382d5a5ec333b7809","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars4.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":87170155,"name":"ServiceControl.Monitoring","full_name":"Particular/ServiceControl.Monitoring","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars4.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl.Monitoring","description":"A standalone service gathering metrics from endpoints and providing them with an http endpoint","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring","forks_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/deployments","created_at":"2017-04-04T09:42:31Z","updated_at":"2017-06-26T05:25:39Z","pushed_at":"2017-07-13T18:06:50Z","git_url":"git://github.com/Particular/ServiceControl.Monitoring.git","ssh_url":"git@github.com:Particular/ServiceControl.Monitoring.git","clone_url":"https://github.com/Particular/ServiceControl.Monitoring.git","svn_url":"https://github.com/Particular/ServiceControl.Monitoring","homepage":null,"size":697,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"788db818a9e5010b54819c32d742c401356552e0","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars4.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":87170155,"name":"ServiceControl.Monitoring","full_name":"Particular/ServiceControl.Monitoring","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars4.githubusercontent.com/u/5038441?v=4","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceControl.Monitoring","description":"A standalone service gathering metrics from endpoints and providing them with an http endpoint","fork":false,"url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring","forks_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/forks","keys_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/events","assignees_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/merges","archive_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/deployments","created_at":"2017-04-04T09:42:31Z","updated_at":"2017-06-26T05:25:39Z","pushed_at":"2017-07-13T18:06:50Z","git_url":"git://github.com/Particular/ServiceControl.Monitoring.git","ssh_url":"git@github.com:Particular/ServiceControl.Monitoring.git","clone_url":"https://github.com/Particular/ServiceControl.Monitoring.git","svn_url":"https://github.com/Particular/ServiceControl.Monitoring","homepage":null,"size":697,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/30"},"html":{"href":"https://github.com/Particular/ServiceControl.Monitoring/pull/30"},"issue":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/30"},"comments":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/ServiceControl.Monitoring/statuses/ba61aef9a5db0be9d13c0dd382d5a5ec333b7809"}}}}
{"actor":{"display_login":"mikeminutillo"}}