{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/comments/134289445","pull_request_review_id":57564418,"id":134289445,"diff_hunk":"@@ -7,12 +7,17 @@\n          src=\"images/pin.svg\"\n          (click)=\"pinPart()\" />\n \n-    <nav id=\"site-tabs\">\n+    <nav id=\"site-tabs\" role=\"tablist\" #siteTabs>\n         <div *ngFor=\"let info of tabInfos\"\n             class=\"site-tab-label\"\n             [class.inactive-label]=\"!info.active\"\n             [class.closeable]=\"info.closeable\"\n-            (click)=\"selectTab(info)\">\n+            (click)=\"selectTab(info)\"\n+            [tabindex]=\"info.active ? 0 : -1\"\n+            (keydown)=\"onKeyPress($event, info)\"\n+            role=\"tab\"\n+            aria-controls=\"site-tabs\"\n+            aria-selected=\"info.active ? 0 : -1\">","path":"AzureFunctions.AngularClient/src/app/site/site-dashboard/site-dashboard.component.html","position":16,"original_position":16,"commit_id":"1b1ce0da0f8f71bcd3d318d582688d310748c037","original_commit_id":"1b1ce0da0f8f71bcd3d318d582688d310748c037","user":{"login":"ehamai","id":5695405,"avatar_url":"https://avatars2.githubusercontent.com/u/5695405?v=4","gravatar_id":"","url":"https://api.github.com/users/ehamai","html_url":"https://github.com/ehamai","followers_url":"https://api.github.com/users/ehamai/followers","following_url":"https://api.github.com/users/ehamai/following{/other_user}","gists_url":"https://api.github.com/users/ehamai/gists{/gist_id}","starred_url":"https://api.github.com/users/ehamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehamai/subscriptions","organizations_url":"https://api.github.com/users/ehamai/orgs","repos_url":"https://api.github.com/users/ehamai/repos","events_url":"https://api.github.com/users/ehamai/events{/privacy}","received_events_url":"https://api.github.com/users/ehamai/received_events","type":"User","site_admin":false},"body":">aria-selected=\"info.active ? 0 : -1\" [](start = 12, length = 36)\r\n\r\nSince you're doing an expression for aria-selected, you need to treat it as a dynamic binding ([aria-selected]) otherwise it will be treated as a literal.","created_at":"2017-08-21T17:38:00Z","updated_at":"2017-08-21T17:38:00Z","html_url":"https://github.com/Azure/azure-functions-ux/pull/1708#discussion_r134289445","pull_request_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1708","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/comments/134289445"},"html":{"href":"https://github.com/Azure/azure-functions-ux/pull/1708#discussion_r134289445"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1708"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1708","id":136574185,"html_url":"https://github.com/Azure/azure-functions-ux/pull/1708","diff_url":"https://github.com/Azure/azure-functions-ux/pull/1708.diff","patch_url":"https://github.com/Azure/azure-functions-ux/pull/1708.patch","issue_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1708","number":1708,"state":"open","locked":false,"title":"Make function app tabs accessible ","user":{"login":"agruning","id":8560637,"avatar_url":"https://avatars0.githubusercontent.com/u/8560637?v=4","gravatar_id":"","url":"https://api.github.com/users/agruning","html_url":"https://github.com/agruning","followers_url":"https://api.github.com/users/agruning/followers","following_url":"https://api.github.com/users/agruning/following{/other_user}","gists_url":"https://api.github.com/users/agruning/gists{/gist_id}","starred_url":"https://api.github.com/users/agruning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agruning/subscriptions","organizations_url":"https://api.github.com/users/agruning/orgs","repos_url":"https://api.github.com/users/agruning/repos","events_url":"https://api.github.com/users/agruning/events{/privacy}","received_events_url":"https://api.github.com/users/agruning/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-18T22:16:57Z","updated_at":"2017-08-21T17:38:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14f7a40d6a5fb0bb95492af6eaaec7dec49d4d87","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ahmelsayed","id":645740,"avatar_url":"https://avatars0.githubusercontent.com/u/645740?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmelsayed","html_url":"https://github.com/ahmelsayed","followers_url":"https://api.github.com/users/ahmelsayed/followers","following_url":"https://api.github.com/users/ahmelsayed/following{/other_user}","gists_url":"https://api.github.com/users/ahmelsayed/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmelsayed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmelsayed/subscriptions","organizations_url":"https://api.github.com/users/ahmelsayed/orgs","repos_url":"https://api.github.com/users/ahmelsayed/repos","events_url":"https://api.github.com/users/ahmelsayed/events{/privacy}","received_events_url":"https://api.github.com/users/ahmelsayed/received_events","type":"User","site_admin":false},{"login":"andimarc","id":5387224,"avatar_url":"https://avatars1.githubusercontent.com/u/5387224?v=4","gravatar_id":"","url":"https://api.github.com/users/andimarc","html_url":"https://github.com/andimarc","followers_url":"https://api.github.com/users/andimarc/followers","following_url":"https://api.github.com/users/andimarc/following{/other_user}","gists_url":"https://api.github.com/users/andimarc/gists{/gist_id}","starred_url":"https://api.github.com/users/andimarc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andimarc/subscriptions","organizations_url":"https://api.github.com/users/andimarc/orgs","repos_url":"https://api.github.com/users/andimarc/repos","events_url":"https://api.github.com/users/andimarc/events{/privacy}","received_events_url":"https://api.github.com/users/andimarc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1708/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1708/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1708/comments","statuses_url":"https://api.github.com/repos/Azure/azure-functions-ux/statuses/1b1ce0da0f8f71bcd3d318d582688d310748c037","head":{"label":"agruning:algrunin-accessTabs","ref":"algrunin-accessTabs","sha":"1b1ce0da0f8f71bcd3d318d582688d310748c037","user":{"login":"agruning","id":8560637,"avatar_url":"https://avatars0.githubusercontent.com/u/8560637?v=4","gravatar_id":"","url":"https://api.github.com/users/agruning","html_url":"https://github.com/agruning","followers_url":"https://api.github.com/users/agruning/followers","following_url":"https://api.github.com/users/agruning/following{/other_user}","gists_url":"https://api.github.com/users/agruning/gists{/gist_id}","starred_url":"https://api.github.com/users/agruning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agruning/subscriptions","organizations_url":"https://api.github.com/users/agruning/orgs","repos_url":"https://api.github.com/users/agruning/repos","events_url":"https://api.github.com/users/agruning/events{/privacy}","received_events_url":"https://api.github.com/users/agruning/received_events","type":"User","site_admin":false},"repo":{"id":96829653,"name":"azure-functions-ux","full_name":"agruning/azure-functions-ux","owner":{"login":"agruning","id":8560637,"avatar_url":"https://avatars0.githubusercontent.com/u/8560637?v=4","gravatar_id":"","url":"https://api.github.com/users/agruning","html_url":"https://github.com/agruning","followers_url":"https://api.github.com/users/agruning/followers","following_url":"https://api.github.com/users/agruning/following{/other_user}","gists_url":"https://api.github.com/users/agruning/gists{/gist_id}","starred_url":"https://api.github.com/users/agruning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agruning/subscriptions","organizations_url":"https://api.github.com/users/agruning/orgs","repos_url":"https://api.github.com/users/agruning/repos","events_url":"https://api.github.com/users/agruning/events{/privacy}","received_events_url":"https://api.github.com/users/agruning/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agruning/azure-functions-ux","description":"Azure Functions UX","fork":true,"url":"https://api.github.com/repos/agruning/azure-functions-ux","forks_url":"https://api.github.com/repos/agruning/azure-functions-ux/forks","keys_url":"https://api.github.com/repos/agruning/azure-functions-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agruning/azure-functions-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agruning/azure-functions-ux/teams","hooks_url":"https://api.github.com/repos/agruning/azure-functions-ux/hooks","issue_events_url":"https://api.github.com/repos/agruning/azure-functions-ux/issues/events{/number}","events_url":"https://api.github.com/repos/agruning/azure-functions-ux/events","assignees_url":"https://api.github.com/repos/agruning/azure-functions-ux/assignees{/user}","branches_url":"https://api.github.com/repos/agruning/azure-functions-ux/branches{/branch}","tags_url":"https://api.github.com/repos/agruning/azure-functions-ux/tags","blobs_url":"https://api.github.com/repos/agruning/azure-functions-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agruning/azure-functions-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agruning/azure-functions-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/agruning/azure-functions-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agruning/azure-functions-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/agruning/azure-functions-ux/languages","stargazers_url":"https://api.github.com/repos/agruning/azure-functions-ux/stargazers","contributors_url":"https://api.github.com/repos/agruning/azure-functions-ux/contributors","subscribers_url":"https://api.github.com/repos/agruning/azure-functions-ux/subscribers","subscription_url":"https://api.github.com/repos/agruning/azure-functions-ux/subscription","commits_url":"https://api.github.com/repos/agruning/azure-functions-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/agruning/azure-functions-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/agruning/azure-functions-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/agruning/azure-functions-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/agruning/azure-functions-ux/contents/{+path}","compare_url":"https://api.github.com/repos/agruning/azure-functions-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agruning/azure-functions-ux/merges","archive_url":"https://api.github.com/repos/agruning/azure-functions-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agruning/azure-functions-ux/downloads","issues_url":"https://api.github.com/repos/agruning/azure-functions-ux/issues{/number}","pulls_url":"https://api.github.com/repos/agruning/azure-functions-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/agruning/azure-functions-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/agruning/azure-functions-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agruning/azure-functions-ux/labels{/name}","releases_url":"https://api.github.com/repos/agruning/azure-functions-ux/releases{/id}","deployments_url":"https://api.github.com/repos/agruning/azure-functions-ux/deployments","created_at":"2017-07-10T23:20:18Z","updated_at":"2017-07-10T23:20:20Z","pushed_at":"2017-08-21T17:32:03Z","git_url":"git://github.com/agruning/azure-functions-ux.git","ssh_url":"git@github.com:agruning/azure-functions-ux.git","clone_url":"https://github.com/agruning/azure-functions-ux.git","svn_url":"https://github.com/agruning/azure-functions-ux","homepage":"https://functions.azure.com","size":9593,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"d20c98c291c17c6485fb3b0903d94b78f9a7f8df","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":50877831,"name":"azure-functions-ux","full_name":"Azure/azure-functions-ux","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-functions-ux","description":"Azure Functions UX","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-ux","forks_url":"https://api.github.com/repos/Azure/azure-functions-ux/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-ux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-ux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-ux/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-ux/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-ux/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-ux/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-ux/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-ux/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-ux/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-ux/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-ux/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-ux/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-ux/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-ux/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-ux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-ux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-ux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-ux/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-ux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-ux/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-ux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-ux/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-ux/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-ux/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-ux/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-ux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-ux/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-ux/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-ux/deployments","created_at":"2016-02-01T23:01:22Z","updated_at":"2017-08-15T22:10:23Z","pushed_at":"2017-08-21T17:32:05Z","git_url":"git://github.com/Azure/azure-functions-ux.git","ssh_url":"git@github.com:Azure/azure-functions-ux.git","clone_url":"https://github.com/Azure/azure-functions-ux.git","svn_url":"https://github.com/Azure/azure-functions-ux","homepage":"https://functions.azure.com","size":10100,"stargazers_count":123,"watchers_count":123,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":172,"forks":43,"open_issues":172,"watchers":123,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1708"},"html":{"href":"https://github.com/Azure/azure-functions-ux/pull/1708"},"issue":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1708"},"comments":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/issues/1708/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1708/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/pulls/1708/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-functions-ux/statuses/1b1ce0da0f8f71bcd3d318d582688d310748c037"}}}}
{"actor":{"display_login":"ehamai"}}