{"action":"created","comment":{"url":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments/112861760","pull_request_review_id":34206952,"id":112861760,"diff_hunk":"@@ -43,6 +43,8 @@ The following fields contain the primary properties that constitute a Descriptor\n \n     This OPTIONAL property contains arbitrary metadata for this descriptor.\n     This OPTIONAL property MUST use the [annotation rules](annotations.md#rules).\n+ \n+Descriptors pointing to [`application/vnd.oci.image.manifest.v1+json`](manifest.md) SHOULD include the extended field `platform`, see [Image Index Property Descriptions](https://github.com/qianzhangxa/image-spec/blob/master/image-index.md#image-index-property-descriptions) for details.","path":"descriptor.md","position":5,"original_position":5,"commit_id":"7c00faf3732f3eceeaf87362c0ebc7225697ad80","original_commit_id":"7c00faf3732f3eceeaf87362c0ebc7225697ad80","user":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars1.githubusercontent.com/u/9248427?v=3","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"body":"The link target needs to be `image-index.md#image-index-property-descriptions`.\r\n\r\nAlso, if this is going to be merged, I think \"This property (`platform`) SHOULD be present if its target is platform-specific.\" in `image-index.md` should be updated to \"This property SHOULD be present\"","created_at":"2017-04-24T04:00:20Z","updated_at":"2017-04-24T04:00:20Z","html_url":"https://github.com/opencontainers/image-spec/pull/649#discussion_r112861760","pull_request_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/649","_links":{"self":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments/112861760"},"html":{"href":"https://github.com/opencontainers/image-spec/pull/649#discussion_r112861760"},"pull_request":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/649"}}},"pull_request":{"url":"https://api.github.com/repos/opencontainers/image-spec/pulls/649","id":116893310,"html_url":"https://github.com/opencontainers/image-spec/pull/649","diff_url":"https://github.com/opencontainers/image-spec/pull/649.diff","patch_url":"https://github.com/opencontainers/image-spec/pull/649.patch","issue_url":"https://api.github.com/repos/opencontainers/image-spec/issues/649","number":649,"state":"open","locked":false,"title":"descriptor.md: add descriptions for the extended field","user":{"login":"qianzhangxa","id":16984932,"avatar_url":"https://avatars2.githubusercontent.com/u/16984932?v=3","gravatar_id":"","url":"https://api.github.com/users/qianzhangxa","html_url":"https://github.com/qianzhangxa","followers_url":"https://api.github.com/users/qianzhangxa/followers","following_url":"https://api.github.com/users/qianzhangxa/following{/other_user}","gists_url":"https://api.github.com/users/qianzhangxa/gists{/gist_id}","starred_url":"https://api.github.com/users/qianzhangxa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qianzhangxa/subscriptions","organizations_url":"https://api.github.com/users/qianzhangxa/orgs","repos_url":"https://api.github.com/users/qianzhangxa/repos","events_url":"https://api.github.com/users/qianzhangxa/events{/privacy}","received_events_url":"https://api.github.com/users/qianzhangxa/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Qian Zhang <zhq527725@gmail.com>","created_at":"2017-04-21T00:59:56Z","updated_at":"2017-04-24T04:00:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a71566ffe7bc43f22da3ce2c8d2c723e152935ad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/649/commits","review_comments_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/649/comments","review_comment_url":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencontainers/image-spec/issues/649/comments","statuses_url":"https://api.github.com/repos/opencontainers/image-spec/statuses/7c00faf3732f3eceeaf87362c0ebc7225697ad80","head":{"label":"qianzhangxa:master","ref":"master","sha":"7c00faf3732f3eceeaf87362c0ebc7225697ad80","user":{"login":"qianzhangxa","id":16984932,"avatar_url":"https://avatars2.githubusercontent.com/u/16984932?v=3","gravatar_id":"","url":"https://api.github.com/users/qianzhangxa","html_url":"https://github.com/qianzhangxa","followers_url":"https://api.github.com/users/qianzhangxa/followers","following_url":"https://api.github.com/users/qianzhangxa/following{/other_user}","gists_url":"https://api.github.com/users/qianzhangxa/gists{/gist_id}","starred_url":"https://api.github.com/users/qianzhangxa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qianzhangxa/subscriptions","organizations_url":"https://api.github.com/users/qianzhangxa/orgs","repos_url":"https://api.github.com/users/qianzhangxa/repos","events_url":"https://api.github.com/users/qianzhangxa/events{/privacy}","received_events_url":"https://api.github.com/users/qianzhangxa/received_events","type":"User","site_admin":false},"repo":{"id":79528121,"name":"image-spec","full_name":"qianzhangxa/image-spec","owner":{"login":"qianzhangxa","id":16984932,"avatar_url":"https://avatars2.githubusercontent.com/u/16984932?v=3","gravatar_id":"","url":"https://api.github.com/users/qianzhangxa","html_url":"https://github.com/qianzhangxa","followers_url":"https://api.github.com/users/qianzhangxa/followers","following_url":"https://api.github.com/users/qianzhangxa/following{/other_user}","gists_url":"https://api.github.com/users/qianzhangxa/gists{/gist_id}","starred_url":"https://api.github.com/users/qianzhangxa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qianzhangxa/subscriptions","organizations_url":"https://api.github.com/users/qianzhangxa/orgs","repos_url":"https://api.github.com/users/qianzhangxa/repos","events_url":"https://api.github.com/users/qianzhangxa/events{/privacy}","received_events_url":"https://api.github.com/users/qianzhangxa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qianzhangxa/image-spec","description":"OCI Image Format","fork":true,"url":"https://api.github.com/repos/qianzhangxa/image-spec","forks_url":"https://api.github.com/repos/qianzhangxa/image-spec/forks","keys_url":"https://api.github.com/repos/qianzhangxa/image-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qianzhangxa/image-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qianzhangxa/image-spec/teams","hooks_url":"https://api.github.com/repos/qianzhangxa/image-spec/hooks","issue_events_url":"https://api.github.com/repos/qianzhangxa/image-spec/issues/events{/number}","events_url":"https://api.github.com/repos/qianzhangxa/image-spec/events","assignees_url":"https://api.github.com/repos/qianzhangxa/image-spec/assignees{/user}","branches_url":"https://api.github.com/repos/qianzhangxa/image-spec/branches{/branch}","tags_url":"https://api.github.com/repos/qianzhangxa/image-spec/tags","blobs_url":"https://api.github.com/repos/qianzhangxa/image-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qianzhangxa/image-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qianzhangxa/image-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/qianzhangxa/image-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qianzhangxa/image-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/qianzhangxa/image-spec/languages","stargazers_url":"https://api.github.com/repos/qianzhangxa/image-spec/stargazers","contributors_url":"https://api.github.com/repos/qianzhangxa/image-spec/contributors","subscribers_url":"https://api.github.com/repos/qianzhangxa/image-spec/subscribers","subscription_url":"https://api.github.com/repos/qianzhangxa/image-spec/subscription","commits_url":"https://api.github.com/repos/qianzhangxa/image-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/qianzhangxa/image-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/qianzhangxa/image-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/qianzhangxa/image-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/qianzhangxa/image-spec/contents/{+path}","compare_url":"https://api.github.com/repos/qianzhangxa/image-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qianzhangxa/image-spec/merges","archive_url":"https://api.github.com/repos/qianzhangxa/image-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qianzhangxa/image-spec/downloads","issues_url":"https://api.github.com/repos/qianzhangxa/image-spec/issues{/number}","pulls_url":"https://api.github.com/repos/qianzhangxa/image-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/qianzhangxa/image-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/qianzhangxa/image-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qianzhangxa/image-spec/labels{/name}","releases_url":"https://api.github.com/repos/qianzhangxa/image-spec/releases{/id}","deployments_url":"https://api.github.com/repos/qianzhangxa/image-spec/deployments","created_at":"2017-01-20T05:24:19Z","updated_at":"2017-01-20T05:24:21Z","pushed_at":"2017-04-21T00:56:46Z","git_url":"git://github.com/qianzhangxa/image-spec.git","ssh_url":"git@github.com:qianzhangxa/image-spec.git","clone_url":"https://github.com/qianzhangxa/image-spec.git","svn_url":"https://github.com/qianzhangxa/image-spec","homepage":"https://www.opencontainers.org/","size":4655,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencontainers:master","ref":"master","sha":"a82c09852aba4978e3d16bb0cd583d5e2f4a63c9","user":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars2.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"repo":{"id":54503347,"name":"image-spec","full_name":"opencontainers/image-spec","owner":{"login":"opencontainers","id":12563465,"avatar_url":"https://avatars2.githubusercontent.com/u/12563465?v=3","gravatar_id":"","url":"https://api.github.com/users/opencontainers","html_url":"https://github.com/opencontainers","followers_url":"https://api.github.com/users/opencontainers/followers","following_url":"https://api.github.com/users/opencontainers/following{/other_user}","gists_url":"https://api.github.com/users/opencontainers/gists{/gist_id}","starred_url":"https://api.github.com/users/opencontainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencontainers/subscriptions","organizations_url":"https://api.github.com/users/opencontainers/orgs","repos_url":"https://api.github.com/users/opencontainers/repos","events_url":"https://api.github.com/users/opencontainers/events{/privacy}","received_events_url":"https://api.github.com/users/opencontainers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencontainers/image-spec","description":"OCI Image Format","fork":false,"url":"https://api.github.com/repos/opencontainers/image-spec","forks_url":"https://api.github.com/repos/opencontainers/image-spec/forks","keys_url":"https://api.github.com/repos/opencontainers/image-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencontainers/image-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencontainers/image-spec/teams","hooks_url":"https://api.github.com/repos/opencontainers/image-spec/hooks","issue_events_url":"https://api.github.com/repos/opencontainers/image-spec/issues/events{/number}","events_url":"https://api.github.com/repos/opencontainers/image-spec/events","assignees_url":"https://api.github.com/repos/opencontainers/image-spec/assignees{/user}","branches_url":"https://api.github.com/repos/opencontainers/image-spec/branches{/branch}","tags_url":"https://api.github.com/repos/opencontainers/image-spec/tags","blobs_url":"https://api.github.com/repos/opencontainers/image-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencontainers/image-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencontainers/image-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencontainers/image-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencontainers/image-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/opencontainers/image-spec/languages","stargazers_url":"https://api.github.com/repos/opencontainers/image-spec/stargazers","contributors_url":"https://api.github.com/repos/opencontainers/image-spec/contributors","subscribers_url":"https://api.github.com/repos/opencontainers/image-spec/subscribers","subscription_url":"https://api.github.com/repos/opencontainers/image-spec/subscription","commits_url":"https://api.github.com/repos/opencontainers/image-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencontainers/image-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencontainers/image-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencontainers/image-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencontainers/image-spec/contents/{+path}","compare_url":"https://api.github.com/repos/opencontainers/image-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencontainers/image-spec/merges","archive_url":"https://api.github.com/repos/opencontainers/image-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencontainers/image-spec/downloads","issues_url":"https://api.github.com/repos/opencontainers/image-spec/issues{/number}","pulls_url":"https://api.github.com/repos/opencontainers/image-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/opencontainers/image-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/opencontainers/image-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencontainers/image-spec/labels{/name}","releases_url":"https://api.github.com/repos/opencontainers/image-spec/releases{/id}","deployments_url":"https://api.github.com/repos/opencontainers/image-spec/deployments","created_at":"2016-03-22T19:34:41Z","updated_at":"2017-04-21T03:24:40Z","pushed_at":"2017-04-21T00:59:57Z","git_url":"git://github.com/opencontainers/image-spec.git","ssh_url":"git@github.com:opencontainers/image-spec.git","clone_url":"https://github.com/opencontainers/image-spec.git","svn_url":"https://github.com/opencontainers/image-spec","homepage":"https://www.opencontainers.org/","size":4655,"stargazers_count":237,"watchers_count":237,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":45,"forks":66,"open_issues":45,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/649"},"html":{"href":"https://github.com/opencontainers/image-spec/pull/649"},"issue":{"href":"https://api.github.com/repos/opencontainers/image-spec/issues/649"},"comments":{"href":"https://api.github.com/repos/opencontainers/image-spec/issues/649/comments"},"review_comments":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/649/comments"},"review_comment":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencontainers/image-spec/pulls/649/commits"},"statuses":{"href":"https://api.github.com/repos/opencontainers/image-spec/statuses/7c00faf3732f3eceeaf87362c0ebc7225697ad80"}}}}
{"actor":{"display_login":"AkihiroSuda"}}