{"action":"created","issue":{"url":"https://api.github.com/repos/apache/samza/issues/342","repository_url":"https://api.github.com/repos/apache/samza","labels_url":"https://api.github.com/repos/apache/samza/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/apache/samza/issues/342/comments","events_url":"https://api.github.com/repos/apache/samza/issues/342/events","html_url":"https://github.com/apache/samza/pull/342","id":268849309,"number":342,"title":"SAMZA-1471: SystemConsumers should not poll ssp that hit end of stream","user":{"login":"lhaiesp","id":2789450,"avatar_url":"https://avatars0.githubusercontent.com/u/2789450?v=4","gravatar_id":"","url":"https://api.github.com/users/lhaiesp","html_url":"https://github.com/lhaiesp","followers_url":"https://api.github.com/users/lhaiesp/followers","following_url":"https://api.github.com/users/lhaiesp/following{/other_user}","gists_url":"https://api.github.com/users/lhaiesp/gists{/gist_id}","starred_url":"https://api.github.com/users/lhaiesp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhaiesp/subscriptions","organizations_url":"https://api.github.com/users/lhaiesp/orgs","repos_url":"https://api.github.com/users/lhaiesp/repos","events_url":"https://api.github.com/users/lhaiesp/events{/privacy}","received_events_url":"https://api.github.com/users/lhaiesp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-26T17:40:58Z","updated_at":"2017-10-26T22:08:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/342","html_url":"https://github.com/apache/samza/pull/342","diff_url":"https://github.com/apache/samza/pull/342.diff","patch_url":"https://github.com/apache/samza/pull/342.patch"},"body":"When SystemConsumers poll from SSPs that have hit end of stream, obviously there will be no data return and the poll will exhaust the timeout. This would cause performance issue."},"comment":{"url":"https://api.github.com/repos/apache/samza/issues/comments/339815454","html_url":"https://github.com/apache/samza/pull/342#issuecomment-339815454","issue_url":"https://api.github.com/repos/apache/samza/issues/342","id":339815454,"user":{"login":"vjagadish1989","id":18561937,"avatar_url":"https://avatars3.githubusercontent.com/u/18561937?v=4","gravatar_id":"","url":"https://api.github.com/users/vjagadish1989","html_url":"https://github.com/vjagadish1989","followers_url":"https://api.github.com/users/vjagadish1989/followers","following_url":"https://api.github.com/users/vjagadish1989/following{/other_user}","gists_url":"https://api.github.com/users/vjagadish1989/gists{/gist_id}","starred_url":"https://api.github.com/users/vjagadish1989/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vjagadish1989/subscriptions","organizations_url":"https://api.github.com/users/vjagadish1989/orgs","repos_url":"https://api.github.com/users/vjagadish1989/repos","events_url":"https://api.github.com/users/vjagadish1989/events{/privacy}","received_events_url":"https://api.github.com/users/vjagadish1989/received_events","type":"User","site_admin":false},"created_at":"2017-10-26T22:08:41Z","updated_at":"2017-10-26T22:08:41Z","author_association":"CONTRIBUTOR","body":"@prateekm @lhaiesp @xinyuiscool \r\n\r\nCan we keep emptySSPBySystem and endOfStreamSSPs separate concepts? (instead of removing an end of stream SSP from the set of empty SSPs)\r\n\r\nAtleast the semantic meaning of emptySSPs == the set of SSPs that we have no buffered messages for, and endOfStreamSSPs == the set of SSPs that are at EOS is maintained.\r\n\r\nIf the only intention is to prevent that SSP from being polled we can add a check during poll to filter out end of stream SSPs. In other words, an SSP is polled iff. both these conditions are true:\r\n1. If we don't have buffered messages for it\r\n2. If we have not reached end of stream"}}
{"actor":{"display_login":"vjagadish1989"}}