{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/147499525","pull_request_review_id":72610250,"id":147499525,"diff_hunk":"@@ -344,14 +332,17 @@ loadBalancerNamespaceBundleMaxTopics=1000\n loadBalancerNamespaceBundleMaxSessions=1000\n \n # maximum msgRate (in + out) in a bundle, otherwise bundle split will be triggered\n-loadBalancerNamespaceBundleMaxMsgRate=1000\n+loadBalancerNamespaceBundleMaxMsgRate=5000","path":"conf/broker.conf","position":49,"original_position":49,"commit_id":"d6fc412434c692fd00694dc5f4ee00148efa7110","original_commit_id":"d6fc412434c692fd00694dc5f4ee00148efa7110","user":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"body":"yes, I was also thinking to increase to higher value. I will change it to 30K.","created_at":"2017-10-27T19:39:11Z","updated_at":"2017-10-27T19:39:11Z","html_url":"https://github.com/apache/incubator-pulsar/pull/865#discussion_r147499525","pull_request_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/865","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/147499525"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/865#discussion_r147499525"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/865"}},"in_reply_to_id":147498361},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/865","id":149075448,"html_url":"https://github.com/apache/incubator-pulsar/pull/865","diff_url":"https://github.com/apache/incubator-pulsar/pull/865.diff","patch_url":"https://github.com/apache/incubator-pulsar/pull/865.patch","issue_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/865","number":865,"state":"open","locked":false,"title":"Cleanup load-manager configuration and make ModularLoadManager default load-manager","user":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"body":"### Motivation\r\n\r\nWe have introduced [ModularLoadManager](https://pulsar.incubator.apache.org/docs/v1.19.0-incubating/admin/ModularLoadManager/) in `1.17` release and it considers more variables to distribute load across the brokers. Therefore, we can change default load-manager as `ModularLoadManager` and clean up configuration which are not required by `ModularLoadManager`.\r\n\r\n### Modifications\r\n\r\n- Make default `ModularLoadManager` as default load-manager\r\n- Deprecate configuration which is not used by `ModularLoadManager`\r\n- Tune load-balancer configuration value\r\n- Remove not used config from `broker.conf` and `standalone.conf`\r\n- By default: Enable bundle-split and unloading bundle by load-balancer\r\n\r\n### Result\r\n\r\nIt will enable `ModularLoadManager` with enabled configuration for splitting bundle and unloading split bundles.\r\n","created_at":"2017-10-27T00:21:23Z","updated_at":"2017-10-27T19:39:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2330964d0d09a6ab371a6fbdd4dbab13b688a9d","assignee":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"assignees":[{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/10","html_url":"https://github.com/apache/incubator-pulsar/milestone/10","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/10/labels","id":2697842,"number":10,"title":"1.21.0-incubating","description":"","creator":{"login":"merlimat","id":62500,"avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":59,"state":"open","created_at":"2017-08-12T15:08:20Z","updated_at":"2017-10-27T18:58:08Z","due_on":"2017-10-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/865/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/865/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/865/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/d6fc412434c692fd00694dc5f4ee00148efa7110","head":{"label":"rdhabalia:default_load","ref":"default_load","sha":"d6fc412434c692fd00694dc5f4ee00148efa7110","user":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"repo":{"id":67649596,"name":"pulsar","full_name":"rdhabalia/pulsar","owner":{"login":"rdhabalia","id":2898254,"avatar_url":"https://avatars2.githubusercontent.com/u/2898254?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhabalia","html_url":"https://github.com/rdhabalia","followers_url":"https://api.github.com/users/rdhabalia/followers","following_url":"https://api.github.com/users/rdhabalia/following{/other_user}","gists_url":"https://api.github.com/users/rdhabalia/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhabalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhabalia/subscriptions","organizations_url":"https://api.github.com/users/rdhabalia/orgs","repos_url":"https://api.github.com/users/rdhabalia/repos","events_url":"https://api.github.com/users/rdhabalia/events{/privacy}","received_events_url":"https://api.github.com/users/rdhabalia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdhabalia/pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/rdhabalia/pulsar","forks_url":"https://api.github.com/repos/rdhabalia/pulsar/forks","keys_url":"https://api.github.com/repos/rdhabalia/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdhabalia/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdhabalia/pulsar/teams","hooks_url":"https://api.github.com/repos/rdhabalia/pulsar/hooks","issue_events_url":"https://api.github.com/repos/rdhabalia/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/rdhabalia/pulsar/events","assignees_url":"https://api.github.com/repos/rdhabalia/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/rdhabalia/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/rdhabalia/pulsar/tags","blobs_url":"https://api.github.com/repos/rdhabalia/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdhabalia/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdhabalia/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdhabalia/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdhabalia/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/rdhabalia/pulsar/languages","stargazers_url":"https://api.github.com/repos/rdhabalia/pulsar/stargazers","contributors_url":"https://api.github.com/repos/rdhabalia/pulsar/contributors","subscribers_url":"https://api.github.com/repos/rdhabalia/pulsar/subscribers","subscription_url":"https://api.github.com/repos/rdhabalia/pulsar/subscription","commits_url":"https://api.github.com/repos/rdhabalia/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdhabalia/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdhabalia/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdhabalia/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdhabalia/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/rdhabalia/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdhabalia/pulsar/merges","archive_url":"https://api.github.com/repos/rdhabalia/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdhabalia/pulsar/downloads","issues_url":"https://api.github.com/repos/rdhabalia/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/rdhabalia/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/rdhabalia/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/rdhabalia/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdhabalia/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/rdhabalia/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/rdhabalia/pulsar/deployments","created_at":"2016-09-07T22:57:02Z","updated_at":"2016-09-07T22:57:05Z","pushed_at":"2017-10-27T17:29:08Z","git_url":"git://github.com/rdhabalia/pulsar.git","ssh_url":"git@github.com:rdhabalia/pulsar.git","clone_url":"https://github.com/rdhabalia/pulsar.git","svn_url":"https://github.com/rdhabalia/pulsar","homepage":"","size":8245,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6bd024da113587c1b92d56ed735d49d97d3bfb78","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"name":"incubator-pulsar","full_name":"apache/incubator-pulsar","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/incubator-pulsar","forks_url":"https://api.github.com/repos/apache/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/apache/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/apache/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/apache/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2017-10-27T07:05:19Z","pushed_at":"2017-10-27T17:29:09Z","git_url":"git://github.com/apache/incubator-pulsar.git","ssh_url":"git@github.com:apache/incubator-pulsar.git","clone_url":"https://github.com/apache/incubator-pulsar.git","svn_url":"https://github.com/apache/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":9937,"stargazers_count":1327,"watchers_count":1327,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":291,"mirror_url":null,"archived":false,"open_issues_count":91,"forks":291,"open_issues":91,"watchers":1327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/865"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/865"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/865"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/865/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/865/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/865/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pulsar/statuses/d6fc412434c692fd00694dc5f4ee00148efa7110"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rdhabalia"}}