{"action":"closed","number":3708,"pull_request":{"url":"https://api.github.com/repos/python/mypy/pulls/3708","id":130247669,"html_url":"https://github.com/python/mypy/pull/3708","diff_url":"https://github.com/python/mypy/pull/3708.diff","patch_url":"https://github.com/python/mypy/pull/3708.patch","issue_url":"https://api.github.com/repos/python/mypy/issues/3708","number":3708,"state":"closed","locked":false,"title":"Fix bug in cache updates and improve cache logging","user":{"login":"gvanrossum","id":2894642,"avatar_url":"https://avatars0.githubusercontent.com/u/2894642?v=3","gravatar_id":"","url":"https://api.github.com/users/gvanrossum","html_url":"https://github.com/gvanrossum","followers_url":"https://api.github.com/users/gvanrossum/followers","following_url":"https://api.github.com/users/gvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/gvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/gvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvanrossum/subscriptions","organizations_url":"https://api.github.com/users/gvanrossum/orgs","repos_url":"https://api.github.com/users/gvanrossum/repos","events_url":"https://api.github.com/users/gvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/gvanrossum/received_events","type":"User","site_admin":false},"body":"This started out as an attempt to make the logging messages around cache freshness/updates more useful, but I ended up discovering a bug in the code that updates the cache meta file when the mtime or path of the file has changes but size and source hash are the same. It wrote a list instead of a dict! This is a bug in a feature announced in 0.520 so should be included in 0.521 if/when we release it.\r\n\r\nI also decided to ignore `debug_cache` when comparing options (since it only affects the JSON style -- it's still a per-file option but changing it no longer invalidates the cache)\r\n\r\nAnd I made the `--skip-version-check` option strictly ignore the platform (since it's undocumented I can make it do what I want, and this is more useful for my one use case).","created_at":"2017-07-12T22:08:08Z","updated_at":"2017-07-13T02:01:07Z","closed_at":"2017-07-13T02:01:07Z","merged_at":"2017-07-13T02:01:07Z","merge_commit_sha":"6d75649e1e13152432f79751fa384956148929c1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/mypy/pulls/3708/commits","review_comments_url":"https://api.github.com/repos/python/mypy/pulls/3708/comments","review_comment_url":"https://api.github.com/repos/python/mypy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/mypy/issues/3708/comments","statuses_url":"https://api.github.com/repos/python/mypy/statuses/d0267e2cc7d361725ce76437d5ca4c6023842d23","head":{"label":"gvanrossum:cache-logging","ref":"cache-logging","sha":"d0267e2cc7d361725ce76437d5ca4c6023842d23","user":{"login":"gvanrossum","id":2894642,"avatar_url":"https://avatars0.githubusercontent.com/u/2894642?v=3","gravatar_id":"","url":"https://api.github.com/users/gvanrossum","html_url":"https://github.com/gvanrossum","followers_url":"https://api.github.com/users/gvanrossum/followers","following_url":"https://api.github.com/users/gvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/gvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/gvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvanrossum/subscriptions","organizations_url":"https://api.github.com/users/gvanrossum/orgs","repos_url":"https://api.github.com/users/gvanrossum/repos","events_url":"https://api.github.com/users/gvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/gvanrossum/received_events","type":"User","site_admin":false},"repo":{"id":93563696,"name":"mypy","full_name":"gvanrossum/mypy","owner":{"login":"gvanrossum","id":2894642,"avatar_url":"https://avatars0.githubusercontent.com/u/2894642?v=3","gravatar_id":"","url":"https://api.github.com/users/gvanrossum","html_url":"https://github.com/gvanrossum","followers_url":"https://api.github.com/users/gvanrossum/followers","following_url":"https://api.github.com/users/gvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/gvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/gvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvanrossum/subscriptions","organizations_url":"https://api.github.com/users/gvanrossum/orgs","repos_url":"https://api.github.com/users/gvanrossum/repos","events_url":"https://api.github.com/users/gvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/gvanrossum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gvanrossum/mypy","description":"Optional static typing for Python 2 and 3 (PEP484)","fork":true,"url":"https://api.github.com/repos/gvanrossum/mypy","forks_url":"https://api.github.com/repos/gvanrossum/mypy/forks","keys_url":"https://api.github.com/repos/gvanrossum/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gvanrossum/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gvanrossum/mypy/teams","hooks_url":"https://api.github.com/repos/gvanrossum/mypy/hooks","issue_events_url":"https://api.github.com/repos/gvanrossum/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/gvanrossum/mypy/events","assignees_url":"https://api.github.com/repos/gvanrossum/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/gvanrossum/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/gvanrossum/mypy/tags","blobs_url":"https://api.github.com/repos/gvanrossum/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gvanrossum/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gvanrossum/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gvanrossum/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gvanrossum/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/gvanrossum/mypy/languages","stargazers_url":"https://api.github.com/repos/gvanrossum/mypy/stargazers","contributors_url":"https://api.github.com/repos/gvanrossum/mypy/contributors","subscribers_url":"https://api.github.com/repos/gvanrossum/mypy/subscribers","subscription_url":"https://api.github.com/repos/gvanrossum/mypy/subscription","commits_url":"https://api.github.com/repos/gvanrossum/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gvanrossum/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gvanrossum/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gvanrossum/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gvanrossum/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/gvanrossum/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gvanrossum/mypy/merges","archive_url":"https://api.github.com/repos/gvanrossum/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gvanrossum/mypy/downloads","issues_url":"https://api.github.com/repos/gvanrossum/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/gvanrossum/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/gvanrossum/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/gvanrossum/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gvanrossum/mypy/labels{/name}","releases_url":"https://api.github.com/repos/gvanrossum/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/gvanrossum/mypy/deployments","created_at":"2017-06-06T21:04:01Z","updated_at":"2017-06-25T12:31:42Z","pushed_at":"2017-07-13T01:53:26Z","git_url":"git://github.com/gvanrossum/mypy.git","ssh_url":"git@github.com:gvanrossum/mypy.git","clone_url":"https://github.com/gvanrossum/mypy.git","svn_url":"https://github.com/gvanrossum/mypy","homepage":"http://www.mypy-lang.org/","size":21261,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"c10657969f1afd74e8857e29de870027a3ddfd26","user":{"login":"python","id":1525981,"avatar_url":"https://avatars0.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":7053637,"name":"mypy","full_name":"python/mypy","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars0.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/mypy","description":"Optional static typing for Python 2 and 3 (PEP484)","fork":false,"url":"https://api.github.com/repos/python/mypy","forks_url":"https://api.github.com/repos/python/mypy/forks","keys_url":"https://api.github.com/repos/python/mypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/mypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/mypy/teams","hooks_url":"https://api.github.com/repos/python/mypy/hooks","issue_events_url":"https://api.github.com/repos/python/mypy/issues/events{/number}","events_url":"https://api.github.com/repos/python/mypy/events","assignees_url":"https://api.github.com/repos/python/mypy/assignees{/user}","branches_url":"https://api.github.com/repos/python/mypy/branches{/branch}","tags_url":"https://api.github.com/repos/python/mypy/tags","blobs_url":"https://api.github.com/repos/python/mypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/mypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/mypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/mypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/mypy/statuses/{sha}","languages_url":"https://api.github.com/repos/python/mypy/languages","stargazers_url":"https://api.github.com/repos/python/mypy/stargazers","contributors_url":"https://api.github.com/repos/python/mypy/contributors","subscribers_url":"https://api.github.com/repos/python/mypy/subscribers","subscription_url":"https://api.github.com/repos/python/mypy/subscription","commits_url":"https://api.github.com/repos/python/mypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/mypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/mypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/mypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/mypy/contents/{+path}","compare_url":"https://api.github.com/repos/python/mypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/mypy/merges","archive_url":"https://api.github.com/repos/python/mypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/mypy/downloads","issues_url":"https://api.github.com/repos/python/mypy/issues{/number}","pulls_url":"https://api.github.com/repos/python/mypy/pulls{/number}","milestones_url":"https://api.github.com/repos/python/mypy/milestones{/number}","notifications_url":"https://api.github.com/repos/python/mypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/mypy/labels{/name}","releases_url":"https://api.github.com/repos/python/mypy/releases{/id}","deployments_url":"https://api.github.com/repos/python/mypy/deployments","created_at":"2012-12-07T13:30:23Z","updated_at":"2017-07-12T17:44:06Z","pushed_at":"2017-07-13T02:01:07Z","git_url":"git://github.com/python/mypy.git","ssh_url":"git@github.com:python/mypy.git","clone_url":"https://github.com/python/mypy.git","svn_url":"https://github.com/python/mypy","homepage":"http://www.mypy-lang.org/","size":21297,"stargazers_count":2687,"watchers_count":2687,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":689,"forks":330,"open_issues":689,"watchers":2687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/mypy/pulls/3708"},"html":{"href":"https://github.com/python/mypy/pull/3708"},"issue":{"href":"https://api.github.com/repos/python/mypy/issues/3708"},"comments":{"href":"https://api.github.com/repos/python/mypy/issues/3708/comments"},"review_comments":{"href":"https://api.github.com/repos/python/mypy/pulls/3708/comments"},"review_comment":{"href":"https://api.github.com/repos/python/mypy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/mypy/pulls/3708/commits"},"statuses":{"href":"https://api.github.com/repos/python/mypy/statuses/d0267e2cc7d361725ce76437d5ca4c6023842d23"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gvanrossum","id":2894642,"avatar_url":"https://avatars0.githubusercontent.com/u/2894642?v=3","gravatar_id":"","url":"https://api.github.com/users/gvanrossum","html_url":"https://github.com/gvanrossum","followers_url":"https://api.github.com/users/gvanrossum/followers","following_url":"https://api.github.com/users/gvanrossum/following{/other_user}","gists_url":"https://api.github.com/users/gvanrossum/gists{/gist_id}","starred_url":"https://api.github.com/users/gvanrossum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gvanrossum/subscriptions","organizations_url":"https://api.github.com/users/gvanrossum/orgs","repos_url":"https://api.github.com/users/gvanrossum/repos","events_url":"https://api.github.com/users/gvanrossum/events{/privacy}","received_events_url":"https://api.github.com/users/gvanrossum/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":3,"additions":58,"deletions":25,"changed_files":2}}
{"actor":{"display_login":"gvanrossum"}}