{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/129001301","pull_request_review_id":51703896,"id":129001301,"diff_hunk":"@@ -0,0 +1,64 @@\n+#include \"MantidAlgorithms/ChangePulsetime2.h\"\n+#include \"MantidAPI/WorkspaceFactory.h\"\n+#include \"MantidDataObjects/EventWorkspace.h\"\n+#include \"MantidKernel/ArrayProperty.h\"\n+#include \"MantidKernel/System.h\"\n+\n+namespace Mantid {\n+namespace Algorithms {\n+\n+// Register the algorithm into the AlgorithmFactory\n+DECLARE_ALGORITHM(ChangePulsetime2)\n+\n+using namespace Mantid::Kernel;\n+using namespace Mantid::API;\n+using namespace Mantid::DataObjects;\n+using std::size_t;\n+\n+//----------------------------------------------------------------------------------------------\n+/** Initialize the algorithm's properties.\n+ */\n+void ChangePulsetime2::init() {\n+  declareIndexProperty<EventWorkspace>(\n+      \"InputWorkspace\", IndexType::WorkspaceIndex, \"An input event workspace.\");\n+  declareProperty(\n+      make_unique<PropertyWithValue<double>>(\"TimeOffset\", Direction::Input),\n+      \"Number of seconds (a float) to add to each event's pulse \"\n+      \"time. Required.\");\n+  declareProperty(make_unique<WorkspaceProperty<EventWorkspace>>(\n+                      \"OutputWorkspace\", \"\", Direction::Output),\n+                  \"An output event workspace.\");\n+}\n+\n+//----------------------------------------------------------------------------------------------\n+/** Execute the algorithm.\n+ */\n+void ChangePulsetime2::exec() {\n+  EventWorkspace_const_sptr in_ws;\n+  Indexing::SpectrumIndexSet indexSet(0);","path":"Framework/Algorithms/src/ChangePulsetime2.cpp","position":37,"original_position":38,"commit_id":"2ca51c634958f8fa3ece95e3892318905463c046","original_commit_id":"c2149b9265e97e6849bdfe8d3c47f7092f82847a","user":{"login":"martyngigg","id":733773,"avatar_url":"https://avatars2.githubusercontent.com/u/733773?v=4","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2017-07-24T10:26:37Z","updated_at":"2017-07-24T10:29:05Z","html_url":"https://github.com/mantidproject/mantid/pull/19940#discussion_r129001301","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/19940","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/129001301"},"html":{"href":"https://github.com/mantidproject/mantid/pull/19940#discussion_r129001301"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/19940"}}},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/19940","id":127936209,"html_url":"https://github.com/mantidproject/mantid/pull/19940","diff_url":"https://github.com/mantidproject/mantid/pull/19940.diff","patch_url":"https://github.com/mantidproject/mantid/pull/19940.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/19940","number":19940,"state":"open","locked":false,"title":"IndexProperty Implementation Prototype","user":{"login":"LamarMoore","id":15360272,"avatar_url":"https://avatars1.githubusercontent.com/u/15360272?v=4","gravatar_id":"","url":"https://api.github.com/users/LamarMoore","html_url":"https://github.com/LamarMoore","followers_url":"https://api.github.com/users/LamarMoore/followers","following_url":"https://api.github.com/users/LamarMoore/following{/other_user}","gists_url":"https://api.github.com/users/LamarMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/LamarMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LamarMoore/subscriptions","organizations_url":"https://api.github.com/users/LamarMoore/orgs","repos_url":"https://api.github.com/users/LamarMoore/repos","events_url":"https://api.github.com/users/LamarMoore/events{/privacy}","received_events_url":"https://api.github.com/users/LamarMoore/received_events","type":"User","site_admin":false},"body":"**DO NOT MERGE**\r\n**NOT READY FOR REVIEW**\r\nThis is an alternative implementation to the implementation of an IndexProperty see [here](https://github.com/mantidproject/mantid/pull/19699) for the first attempt. This [design](https://github.com/mantidproject/documents/pull/42) outlines the rational behind developing this property type. \r\n\r\n**To test:**\r\nCode review. Ensure the property displays correctly in the GUI and can be accessed from python correctly. The `ChangePulsetime2` algorithm was implemented specifically to demonstrate the use of this property.\r\n\r\nFixes #19130. <!-- and fix #xxxx or close #xxxx xor resolves #xxxx -->\r\n\r\n**Release Notes** \r\nRelease notes need to be updated in due course and the concepts pages.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2017-06-28T14:27:58Z","updated_at":"2017-07-24T10:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f247db13190d6c4298d114a477f900c3fae858e3","assignee":{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars1.githubusercontent.com/u/12912489?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false},"assignees":[{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars1.githubusercontent.com/u/12912489?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/62","html_url":"https://github.com/mantidproject/mantid/milestone/62","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/62/labels","id":2064900,"number":62,"title":"Release 3.11","description":"Code Freeze:  15th Sept |\r\nBeta Test:  20th Sept-3rd\r\n","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":265,"closed_issues":198,"state":"open","created_at":"2016-10-12T13:15:39Z","updated_at":"2017-07-24T09:57:10Z","due_on":"2017-10-09T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/19940/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/19940/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/19940/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/2ca51c634958f8fa3ece95e3892318905463c046","head":{"label":"mantidproject:index_property_prototype2","ref":"index_property_prototype2","sha":"2ca51c634958f8fa3ece95e3892318905463c046","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2017-07-11T15:16:39Z","pushed_at":"2017-07-24T10:24:46Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":433450,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":1653,"forks":43,"open_issues":1653,"watchers":60,"default_branch":"master"}},"base":{"label":"mantidproject:master","ref":"master","sha":"e7638e2f086b66c2d4e6170339af283624fc4c99","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2017-07-11T15:16:39Z","pushed_at":"2017-07-24T10:24:46Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"git@github.com:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":433450,"stargazers_count":60,"watchers_count":60,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":1653,"forks":43,"open_issues":1653,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/19940"},"html":{"href":"https://github.com/mantidproject/mantid/pull/19940"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/19940"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/19940/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/19940/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/19940/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/2ca51c634958f8fa3ece95e3892318905463c046"}}}}
{"actor":{"display_login":"martyngigg"}}