{"action":"closed","number":14227,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/14227","id":107837846,"html_url":"https://github.com/joomla/joomla-cms/pull/14227","diff_url":"https://github.com/joomla/joomla-cms/pull/14227.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/14227.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/14227","number":14227,"state":"closed","locked":false,"title":"Tag model should respect published state and ACL","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #14222.\r\n\r\n### Summary of Changes\r\nProperly check published state of tag and check against view levels\r\n\r\n### Testing Instructions\r\n* Assign a tag to an article.\r\n* Visit the article in frontend and click on the tag so you get tot he tag view. Make sure you're not logged in with a user.\r\n* Unpublish the tag in backend.\r\n* Reload the tag view -> Should create an error but instead still shows fine.\r\n* Publish the tag again and change the access level to \"Registered\".\r\n* Reload the tag view again -> Should create an error but instead still shows fine.\r\n\r\n### Expected result\r\nBoth reloads should create an error since we don't have access to that tag.\r\n\r\n### Actual result\r\nView shows fine, ignoring access and published state.\r\n\r\n### Documentation Changes Required\r\nNone\r\n\r\n### Disclaimer\r\nGiven which component we are talking about, I fully expect additional related issues. This PR doesn't try to solve everything :smile: ","created_at":"2017-02-24T14:24:31Z","updated_at":"2017-02-26T13:05:06Z","closed_at":"2017-02-26T13:05:06Z","merged_at":"2017-02-26T13:05:06Z","merge_commit_sha":"bdbc3076be9e72c784bfc85042ba94dc08924343","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14","html_url":"https://github.com/joomla/joomla-cms/milestone/14","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/14/labels","id":1750036,"number":14,"title":"Joomla 3.7.0","description":"","creator":{"login":"brianteeman","id":1296369,"avatar_url":"https://avatars.githubusercontent.com/u/1296369?v=3","gravatar_id":"","url":"https://api.github.com/users/brianteeman","html_url":"https://github.com/brianteeman","followers_url":"https://api.github.com/users/brianteeman/followers","following_url":"https://api.github.com/users/brianteeman/following{/other_user}","gists_url":"https://api.github.com/users/brianteeman/gists{/gist_id}","starred_url":"https://api.github.com/users/brianteeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianteeman/subscriptions","organizations_url":"https://api.github.com/users/brianteeman/orgs","repos_url":"https://api.github.com/users/brianteeman/repos","events_url":"https://api.github.com/users/brianteeman/events{/privacy}","received_events_url":"https://api.github.com/users/brianteeman/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":941,"state":"open","created_at":"2016-05-05T16:42:34Z","updated_at":"2017-02-26T13:05:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/14227/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/14227/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/14227/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/ed4f37ac801c40485c0b0ad432dd81ecff8bb710","head":{"label":"Bakual:FixTagViewPermissions","ref":"FixTagViewPermissions","sha":"ed4f37ac801c40485c0b0ad432dd81ecff8bb710","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"repo":{"id":5132763,"name":"joomla-cms","full_name":"Bakual/joomla-cms","owner":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bakual/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Bakual/joomla-cms","forks_url":"https://api.github.com/repos/Bakual/joomla-cms/forks","keys_url":"https://api.github.com/repos/Bakual/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bakual/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bakual/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Bakual/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Bakual/joomla-cms/events","assignees_url":"https://api.github.com/repos/Bakual/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Bakual/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Bakual/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bakual/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bakual/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bakual/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Bakual/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Bakual/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Bakual/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Bakual/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Bakual/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Bakual/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bakual/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bakual/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bakual/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Bakual/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bakual/joomla-cms/merges","archive_url":"https://api.github.com/repos/Bakual/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bakual/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Bakual/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Bakual/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Bakual/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Bakual/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bakual/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Bakual/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Bakual/joomla-cms/deployments","created_at":"2012-07-21T10:15:11Z","updated_at":"2016-10-24T18:26:51Z","pushed_at":"2017-02-25T12:56:17Z","git_url":"git://github.com/Bakual/joomla-cms.git","ssh_url":"git@github.com:Bakual/joomla-cms.git","clone_url":"https://github.com/Bakual/joomla-cms.git","svn_url":"https://github.com/Bakual/joomla-cms","homepage":"http://joomla.org","size":183547,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"f06b352ab256b06e82d015981ad475433142770b","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-02-26T07:42:21Z","pushed_at":"2017-02-26T13:05:06Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":183086,"stargazers_count":2275,"watchers_count":2275,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2406,"mirror_url":null,"open_issues_count":656,"forks":2406,"open_issues":656,"watchers":2275,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/14227"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/14227"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/14227"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/14227/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/14227/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/14227/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/ed4f37ac801c40485c0b0ad432dd81ecff8bb710"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"rdeutz"}}