{"action":"created","issue":{"url":"https://api.github.com/repos/stwe/DatatablesBundle/issues/654","repository_url":"https://api.github.com/repos/stwe/DatatablesBundle","labels_url":"https://api.github.com/repos/stwe/DatatablesBundle/issues/654/labels{/name}","comments_url":"https://api.github.com/repos/stwe/DatatablesBundle/issues/654/comments","events_url":"https://api.github.com/repos/stwe/DatatablesBundle/issues/654/events","html_url":"https://github.com/stwe/DatatablesBundle/pull/654","id":246977855,"number":654,"title":"Fix: recordsTotal calculation issue","user":{"login":"ronisaha","id":1433652,"avatar_url":"https://avatars2.githubusercontent.com/u/1433652?v=4","gravatar_id":"","url":"https://api.github.com/users/ronisaha","html_url":"https://github.com/ronisaha","followers_url":"https://api.github.com/users/ronisaha/followers","following_url":"https://api.github.com/users/ronisaha/following{/other_user}","gists_url":"https://api.github.com/users/ronisaha/gists{/gist_id}","starred_url":"https://api.github.com/users/ronisaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronisaha/subscriptions","organizations_url":"https://api.github.com/users/ronisaha/orgs","repos_url":"https://api.github.com/users/ronisaha/repos","events_url":"https://api.github.com/users/ronisaha/events{/privacy}","received_events_url":"https://api.github.com/users/ronisaha/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-01T07:23:55Z","updated_at":"2017-08-15T18:19:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stwe/DatatablesBundle/pulls/654","html_url":"https://github.com/stwe/DatatablesBundle/pull/654","diff_url":"https://github.com/stwe/DatatablesBundle/pull/654.diff","patch_url":"https://github.com/stwe/DatatablesBundle/pull/654.patch"},"body":"To fix #639 we can use doctrine Criteria instead of modifying query builder. \r\n\r\ncriteria is more reusable.\r\nI've defined a baseCriteria  property to perform the base filter and other filter option should be used as it is.\r\nThis way the total count would be as per user expectation."},"comment":{"url":"https://api.github.com/repos/stwe/DatatablesBundle/issues/comments/322546626","html_url":"https://github.com/stwe/DatatablesBundle/pull/654#issuecomment-322546626","issue_url":"https://api.github.com/repos/stwe/DatatablesBundle/issues/654","id":322546626,"user":{"login":"Seb33300","id":915273,"avatar_url":"https://avatars3.githubusercontent.com/u/915273?v=4","gravatar_id":"","url":"https://api.github.com/users/Seb33300","html_url":"https://github.com/Seb33300","followers_url":"https://api.github.com/users/Seb33300/followers","following_url":"https://api.github.com/users/Seb33300/following{/other_user}","gists_url":"https://api.github.com/users/Seb33300/gists{/gist_id}","starred_url":"https://api.github.com/users/Seb33300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Seb33300/subscriptions","organizations_url":"https://api.github.com/users/Seb33300/orgs","repos_url":"https://api.github.com/users/Seb33300/repos","events_url":"https://api.github.com/users/Seb33300/events{/privacy}","received_events_url":"https://api.github.com/users/Seb33300/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T18:19:07Z","updated_at":"2017-08-15T18:19:07Z","body":"If we want to filter the query builder, we can just modify it as explained here:\r\nhttps://github.com/stwe/DatatablesBundle/issues/604\r\n\r\n`getCountAllResults()` should make the count on the current query builder instead of creating a new one."}}
{"actor":{"display_login":"Seb33300"}}