{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/comments/120377458","pull_request_review_id":42334299,"id":120377458,"diff_hunk":"@@ -43,21 +43,38 @@ check_result_msg() {\n   fi\n }\n \n+build_image() {\n+  local path=$1\n+  local name=$2\n+  if ! image_exists ${name}; then\n+    echo \"Building Docker image ${name} ...\"\n+    if [ ! -d \"${path}\" ]; then\n+      echo \"No directory found at given location '${path}'. Skipping this image.\"\n+      return\n+    fi\n+    pushd ${path} &>/dev/null\n+      docker build -f Dockerfile.rhel7 -t ${name} .\n+      check_result_msg $? \"Building Docker image ${name} FAILED!\"\n+    popd &>/dev/null\n+  fi\n+}\n+\n+test_images() {\n+  local path=$1\n+  echo \"Running tests...\"\n+  ${path}/run\n+  check_result_msg $? \"Tests FAILED!\"\n+}\n+\n # TODO: build 1.0 1.1 \n VERSIONS=\"${VERSIONS:-2.0}\"\n \n for v in ${VERSIONS}; do\n-  img_name=\"dotnet/$(image_name ${v})\"\n-  pushd ${v} &>/dev/null\n-    if ! image_exists ${img_name}; then\n-      echo \"Building Docker image ${img_name} ...\"\n-      docker build -f Dockerfile.rhel7 -t ${img_name} .\n-      check_result_msg $? \"Building Docker image ${img_name} FAILED!\"\n-    fi\n-    echo \"Running tests on image ${img_name} ...\"\n-    ./test/run\n-    check_result_msg $? \"Tests for image ${img_name} FAILED!\"\n-  popd &>/dev/null\n+  build_name=\"dotnet/$(image_name ${v})\"\n+  runtime_name=\"${build_name}-runtime\"\n+  build_image \"${v}/runtime\" \"${runtime_name}\"","path":"build.sh","position":44,"original_position":44,"commit_id":"af67ebadfd01530217ea5e6e12c556b0d431178d","original_commit_id":"af67ebadfd01530217ea5e6e12c556b0d431178d","user":{"login":"aslicerh","id":27015499,"avatar_url":"https://avatars2.githubusercontent.com/u/27015499?v=3","gravatar_id":"","url":"https://api.github.com/users/aslicerh","html_url":"https://github.com/aslicerh","followers_url":"https://api.github.com/users/aslicerh/followers","following_url":"https://api.github.com/users/aslicerh/following{/other_user}","gists_url":"https://api.github.com/users/aslicerh/gists{/gist_id}","starred_url":"https://api.github.com/users/aslicerh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslicerh/subscriptions","organizations_url":"https://api.github.com/users/aslicerh/orgs","repos_url":"https://api.github.com/users/aslicerh/repos","events_url":"https://api.github.com/users/aslicerh/events{/privacy}","received_events_url":"https://api.github.com/users/aslicerh/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-06-06T14:31:29Z","updated_at":"2017-06-06T14:31:29Z","html_url":"https://github.com/redhat-developer/s2i-dotnetcore/pull/84#discussion_r120377458","pull_request_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/comments/120377458"},"html":{"href":"https://github.com/redhat-developer/s2i-dotnetcore/pull/84#discussion_r120377458"},"pull_request":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/84","id":123984580,"html_url":"https://github.com/redhat-developer/s2i-dotnetcore/pull/84","diff_url":"https://github.com/redhat-developer/s2i-dotnetcore/pull/84.diff","patch_url":"https://github.com/redhat-developer/s2i-dotnetcore/pull/84.patch","issue_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/issues/84","number":84,"state":"open","locked":false,"title":"Create runtime and build images.","user":{"login":"aslicerh","id":27015499,"avatar_url":"https://avatars2.githubusercontent.com/u/27015499?v=3","gravatar_id":"","url":"https://api.github.com/users/aslicerh","html_url":"https://github.com/aslicerh","followers_url":"https://api.github.com/users/aslicerh/followers","following_url":"https://api.github.com/users/aslicerh/following{/other_user}","gists_url":"https://api.github.com/users/aslicerh/gists{/gist_id}","starred_url":"https://api.github.com/users/aslicerh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslicerh/subscriptions","organizations_url":"https://api.github.com/users/aslicerh/orgs","repos_url":"https://api.github.com/users/aslicerh/repos","events_url":"https://api.github.com/users/aslicerh/events{/privacy}","received_events_url":"https://api.github.com/users/aslicerh/received_events","type":"User","site_admin":false},"body":"Existing files moved from \\<ver\\>/\\<stuff\\> to \\<ver\\>/build/\\<stuff\\>.\r\nFiles for building runtime images can be found at \\<ver\\>/runtime/\\<stuff\\>.\r\nTest files are still located at \\<ver\\>/test.\r\n\r\nAs part of this the test script needed to be reworked a bit so that it didn't assume only one current and valid image.","created_at":"2017-06-05T14:10:38Z","updated_at":"2017-06-06T14:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f86a56ca32bbcf57417bf94e3601f707511f9e2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/84/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/84/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/issues/84/comments","statuses_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/statuses/af67ebadfd01530217ea5e6e12c556b0d431178d","head":{"label":"aslicerh:2.0-dev-runtime","ref":"2.0-dev-runtime","sha":"af67ebadfd01530217ea5e6e12c556b0d431178d","user":{"login":"aslicerh","id":27015499,"avatar_url":"https://avatars2.githubusercontent.com/u/27015499?v=3","gravatar_id":"","url":"https://api.github.com/users/aslicerh","html_url":"https://github.com/aslicerh","followers_url":"https://api.github.com/users/aslicerh/followers","following_url":"https://api.github.com/users/aslicerh/following{/other_user}","gists_url":"https://api.github.com/users/aslicerh/gists{/gist_id}","starred_url":"https://api.github.com/users/aslicerh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslicerh/subscriptions","organizations_url":"https://api.github.com/users/aslicerh/orgs","repos_url":"https://api.github.com/users/aslicerh/repos","events_url":"https://api.github.com/users/aslicerh/events{/privacy}","received_events_url":"https://api.github.com/users/aslicerh/received_events","type":"User","site_admin":false},"repo":{"id":87557598,"name":"s2i-dotnetcore","full_name":"aslicerh/s2i-dotnetcore","owner":{"login":"aslicerh","id":27015499,"avatar_url":"https://avatars2.githubusercontent.com/u/27015499?v=3","gravatar_id":"","url":"https://api.github.com/users/aslicerh","html_url":"https://github.com/aslicerh","followers_url":"https://api.github.com/users/aslicerh/followers","following_url":"https://api.github.com/users/aslicerh/following{/other_user}","gists_url":"https://api.github.com/users/aslicerh/gists{/gist_id}","starred_url":"https://api.github.com/users/aslicerh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslicerh/subscriptions","organizations_url":"https://api.github.com/users/aslicerh/orgs","repos_url":"https://api.github.com/users/aslicerh/repos","events_url":"https://api.github.com/users/aslicerh/events{/privacy}","received_events_url":"https://api.github.com/users/aslicerh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aslicerh/s2i-dotnetcore","description":".NET Core OpenShift builder images","fork":true,"url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore","forks_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/forks","keys_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/teams","hooks_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/hooks","issue_events_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/issues/events{/number}","events_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/events","assignees_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/assignees{/user}","branches_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/branches{/branch}","tags_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/tags","blobs_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/statuses/{sha}","languages_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/languages","stargazers_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/stargazers","contributors_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/contributors","subscribers_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/subscribers","subscription_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/subscription","commits_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/contents/{+path}","compare_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/merges","archive_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/downloads","issues_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/issues{/number}","pulls_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/pulls{/number}","milestones_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/milestones{/number}","notifications_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/labels{/name}","releases_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/releases{/id}","deployments_url":"https://api.github.com/repos/aslicerh/s2i-dotnetcore/deployments","created_at":"2017-04-07T14:56:10Z","updated_at":"2017-04-07T14:56:11Z","pushed_at":"2017-06-05T13:59:01Z","git_url":"git://github.com/aslicerh/s2i-dotnetcore.git","ssh_url":"git@github.com:aslicerh/s2i-dotnetcore.git","clone_url":"https://github.com/aslicerh/s2i-dotnetcore.git","svn_url":"https://github.com/aslicerh/s2i-dotnetcore","homepage":"","size":177,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-developer:2.0-dev","ref":"2.0-dev","sha":"a5a8f61a1f6eb6d50dcdaab3e2ba9c17b195fd30","user":{"login":"redhat-developer","id":11033755,"avatar_url":"https://avatars3.githubusercontent.com/u/11033755?v=3","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":64212806,"name":"s2i-dotnetcore","full_name":"redhat-developer/s2i-dotnetcore","owner":{"login":"redhat-developer","id":11033755,"avatar_url":"https://avatars3.githubusercontent.com/u/11033755?v=3","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redhat-developer/s2i-dotnetcore","description":".NET Core OpenShift builder images","fork":false,"url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore","forks_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/forks","keys_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/teams","hooks_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/events","assignees_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/tags","blobs_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/subscription","commits_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/merges","archive_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/downloads","issues_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/deployments","created_at":"2016-07-26T10:32:02Z","updated_at":"2017-05-20T18:13:11Z","pushed_at":"2017-06-05T14:10:39Z","git_url":"git://github.com/redhat-developer/s2i-dotnetcore.git","ssh_url":"git@github.com:redhat-developer/s2i-dotnetcore.git","clone_url":"https://github.com/redhat-developer/s2i-dotnetcore.git","svn_url":"https://github.com/redhat-developer/s2i-dotnetcore","homepage":"","size":168,"stargazers_count":11,"watchers_count":11,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":8,"forks":66,"open_issues":8,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/84"},"html":{"href":"https://github.com/redhat-developer/s2i-dotnetcore/pull/84"},"issue":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/issues/84"},"comments":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/s2i-dotnetcore/statuses/af67ebadfd01530217ea5e6e12c556b0d431178d"}}}}
{"actor":{"display_login":"aslicerh"}}