{"action":"created","comment":{"url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/comments/100858453","pull_request_review_id":21573579,"id":100858453,"diff_hunk":"@@ -1,23 +1,68 @@\n ---\n-notifications:\n-  webhooks: https://galaxy.ansible.com/api/v1/notifications/\n-language: python\n-python: \"2.7\"\n+services: docker\n \n env:\n-  - ANSIBLE_VERSION=latest\n-  - ANSIBLE_VERSION=1.9.4\n+  - distro: centos6\n+    version: latest\n+    init: /sbin/init\n+\n+  - distro: centos7\n+    init: /usr/lib/systemd/systemd\n+    run_opts: \"--privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro\"\n+    version: latest\n+\n+  - distro: oracle6\n+    version: latest\n+    init: /sbin/init\n+\n+  - distro: oracle7\n+    init: /usr/lib/systemd/systemd\n+    run_opts: \"--privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro\"\n+    version: latest\n+\n+  - distro: ubuntu1604\n+    version: latest\n+    init: /lib/systemd/systemd\n+    run_opts: \"--privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro\"\n+\n+  - distro: ubuntu1404\n+    version: latest\n+    init: /sbin/init\n+\n+  - distro: ubuntu1204\n+    version: latest\n+    init: /sbin/init\n+\n+  - distro: debian7\n+    version: latest\n+    init: /sbin/init\n+\n+  - distro: debian8\n+    version: latest\n+    init: /sbin/init\n+\n+  - distro: debian9\n+    version: latest\n+    init: /lib/systemd/systemd\n+    run_opts: \"--privileged --volume=/sys/fs/cgroup:/sys/fs/cgroup:ro\"\n \n before_install:\n- - sudo apt-get update -qq\n- - sudo apt-get install -qq python-apt python-pycurl\n-install:\n-  - if [ \"$ANSIBLE_VERSION\" = \"latest\" ]; then pip install ansible; else pip install ansible==$ANSIBLE_VERSION; fi\n-  - echo -e 'localhost ansible_connection=local' > spec/inventory\n-  - echo -e '[defaults]\\nroles_path = ../\\nhostfile = ./spec/inventory' > ansible.cfg\n+  # Pull container\n+  - 'docker pull rndmh3ro/docker-${distro}-ansible:${version}'\n \n script:\n-  - ansible-galaxy install -r requirements.yml\n-  - ansible-playbook --syntax-check spec/travis.yml\n-  - ansible-playbook --sudo -v --diff spec/travis.yml\n-  - ansible-playbook --sudo -v --diff spec/travis.yml --extra-vars \"nginx_remove_default_site=false\"\n+  - container_id=$(mktemp)\n+  # Run container in detached state.\n+  - 'docker run --detach --volume=\"${PWD}\":/etc/ansible/roles/ansible-nginx-hardening:ro ${run_opts} rndmh3ro/docker-${distro}-ansible:${version} \"${init}\" > \"${container_id}\"'\n+\n+  # Install ansible galaxy requirements\n+  - 'docker exec \"$(cat ${container_id})\" ansible-galaxy install -r /etc/ansible/roles/ansible-nginx-hardening/requirements.yml -p /etc/ansible/roles/'\n+\n+  # Test role.\n+  - 'docker exec \"$(cat ${container_id})\" ansible-playbook /etc/ansible/roles/ansible-nginx-hardening/default.yml'","path":".travis.yml","position":78,"original_position":78,"commit_id":"0735552d100fa44416c6f8601d20b0ad4057090f","original_commit_id":"0735552d100fa44416c6f8601d20b0ad4057090f","user":{"login":"artem-sidorenko","id":1645670,"avatar_url":"https://avatars.githubusercontent.com/u/1645670?v=3","gravatar_id":"","url":"https://api.github.com/users/artem-sidorenko","html_url":"https://github.com/artem-sidorenko","followers_url":"https://api.github.com/users/artem-sidorenko/followers","following_url":"https://api.github.com/users/artem-sidorenko/following{/other_user}","gists_url":"https://api.github.com/users/artem-sidorenko/gists{/gist_id}","starred_url":"https://api.github.com/users/artem-sidorenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artem-sidorenko/subscriptions","organizations_url":"https://api.github.com/users/artem-sidorenko/orgs","repos_url":"https://api.github.com/users/artem-sidorenko/repos","events_url":"https://api.github.com/users/artem-sidorenko/events{/privacy}","received_events_url":"https://api.github.com/users/artem-sidorenko/received_events","type":"User","site_admin":false},"body":"(just asking) what is the reason of not using the kitchen here? Its somehow redundant, you have a kitchen configuration for docker, but CI runs it completely without it","created_at":"2017-02-13T18:11:13Z","updated_at":"2017-02-13T18:12:11Z","html_url":"https://github.com/dev-sec/ansible-nginx-hardening/pull/8#discussion_r100858453","pull_request_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/comments/100858453"},"html":{"href":"https://github.com/dev-sec/ansible-nginx-hardening/pull/8#discussion_r100858453"},"pull_request":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/8","id":102624413,"html_url":"https://github.com/dev-sec/ansible-nginx-hardening/pull/8","diff_url":"https://github.com/dev-sec/ansible-nginx-hardening/pull/8.diff","patch_url":"https://github.com/dev-sec/ansible-nginx-hardening/pull/8.patch","issue_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues/8","number":8,"state":"open","locked":false,"title":"use new Docker images","user":{"login":"rndmh3ro","id":3198961,"avatar_url":"https://avatars.githubusercontent.com/u/3198961?v=3","gravatar_id":"","url":"https://api.github.com/users/rndmh3ro","html_url":"https://github.com/rndmh3ro","followers_url":"https://api.github.com/users/rndmh3ro/followers","following_url":"https://api.github.com/users/rndmh3ro/following{/other_user}","gists_url":"https://api.github.com/users/rndmh3ro/gists{/gist_id}","starred_url":"https://api.github.com/users/rndmh3ro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rndmh3ro/subscriptions","organizations_url":"https://api.github.com/users/rndmh3ro/orgs","repos_url":"https://api.github.com/users/rndmh3ro/repos","events_url":"https://api.github.com/users/rndmh3ro/events{/privacy}","received_events_url":"https://api.github.com/users/rndmh3ro/received_events","type":"User","site_admin":false},"body":"This uses my own docker images (https://github.com/rndmh3ro/docker-ansible). These are just the base images with pre-installed Docker to save time and hassle when testing the roles.\r\nThis also enables full travis testing of all supported operating systems!\r\n\r\nThis too removes ansible 1.9 support, to better test the role. Also there's no more support for Ansible < 2.0, see https://groups.google.com/forum/#!topic/ansible-devel/6-6FdxZ94kc.\r\n\r\nThere are no changes in the nginx-configuration itself. Though the tests will fail. I'll fix this once this PR is merged.","created_at":"2017-01-22T15:27:53Z","updated_at":"2017-02-13T18:12:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c97990dcd953fd7487b55c027f0d73d1d8ac4c85","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/8/commits","review_comments_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/8/comments","review_comment_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues/8/comments","statuses_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/statuses/0735552d100fa44416c6f8601d20b0ad4057090f","head":{"label":"dev-sec:docker","ref":"docker","sha":"0735552d100fa44416c6f8601d20b0ad4057090f","user":{"login":"dev-sec","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/dev-sec","html_url":"https://github.com/dev-sec","followers_url":"https://api.github.com/users/dev-sec/followers","following_url":"https://api.github.com/users/dev-sec/following{/other_user}","gists_url":"https://api.github.com/users/dev-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-sec/subscriptions","organizations_url":"https://api.github.com/users/dev-sec/orgs","repos_url":"https://api.github.com/users/dev-sec/repos","events_url":"https://api.github.com/users/dev-sec/events{/privacy}","received_events_url":"https://api.github.com/users/dev-sec/received_events","type":"Organization","site_admin":false},"repo":{"id":64212361,"name":"ansible-nginx-hardening","full_name":"dev-sec/ansible-nginx-hardening","owner":{"login":"dev-sec","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/dev-sec","html_url":"https://github.com/dev-sec","followers_url":"https://api.github.com/users/dev-sec/followers","following_url":"https://api.github.com/users/dev-sec/following{/other_user}","gists_url":"https://api.github.com/users/dev-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-sec/subscriptions","organizations_url":"https://api.github.com/users/dev-sec/orgs","repos_url":"https://api.github.com/users/dev-sec/repos","events_url":"https://api.github.com/users/dev-sec/events{/privacy}","received_events_url":"https://api.github.com/users/dev-sec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dev-sec/ansible-nginx-hardening","description":"This Ansible role provides secure nginx configurations.","fork":false,"url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening","forks_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/forks","keys_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/teams","hooks_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/hooks","issue_events_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/events","assignees_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/tags","blobs_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/languages","stargazers_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/stargazers","contributors_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/contributors","subscribers_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/subscribers","subscription_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/subscription","commits_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/merges","archive_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/downloads","issues_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/labels{/name}","releases_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/releases{/id}","deployments_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/deployments","created_at":"2016-07-26T10:24:29Z","updated_at":"2017-02-13T04:52:49Z","pushed_at":"2017-01-22T15:27:53Z","git_url":"git://github.com/dev-sec/ansible-nginx-hardening.git","ssh_url":"git@github.com:dev-sec/ansible-nginx-hardening.git","clone_url":"https://github.com/dev-sec/ansible-nginx-hardening.git","svn_url":"https://github.com/dev-sec/ansible-nginx-hardening","homepage":"http://dev-sec.io/","size":21,"stargazers_count":31,"watchers_count":31,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":31,"default_branch":"master"}},"base":{"label":"dev-sec:master","ref":"master","sha":"e79556ccba9739ce0e33a788f9bdeea5bc4899bf","user":{"login":"dev-sec","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/dev-sec","html_url":"https://github.com/dev-sec","followers_url":"https://api.github.com/users/dev-sec/followers","following_url":"https://api.github.com/users/dev-sec/following{/other_user}","gists_url":"https://api.github.com/users/dev-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-sec/subscriptions","organizations_url":"https://api.github.com/users/dev-sec/orgs","repos_url":"https://api.github.com/users/dev-sec/repos","events_url":"https://api.github.com/users/dev-sec/events{/privacy}","received_events_url":"https://api.github.com/users/dev-sec/received_events","type":"Organization","site_admin":false},"repo":{"id":64212361,"name":"ansible-nginx-hardening","full_name":"dev-sec/ansible-nginx-hardening","owner":{"login":"dev-sec","id":11883542,"avatar_url":"https://avatars.githubusercontent.com/u/11883542?v=3","gravatar_id":"","url":"https://api.github.com/users/dev-sec","html_url":"https://github.com/dev-sec","followers_url":"https://api.github.com/users/dev-sec/followers","following_url":"https://api.github.com/users/dev-sec/following{/other_user}","gists_url":"https://api.github.com/users/dev-sec/gists{/gist_id}","starred_url":"https://api.github.com/users/dev-sec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev-sec/subscriptions","organizations_url":"https://api.github.com/users/dev-sec/orgs","repos_url":"https://api.github.com/users/dev-sec/repos","events_url":"https://api.github.com/users/dev-sec/events{/privacy}","received_events_url":"https://api.github.com/users/dev-sec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dev-sec/ansible-nginx-hardening","description":"This Ansible role provides secure nginx configurations.","fork":false,"url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening","forks_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/forks","keys_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/teams","hooks_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/hooks","issue_events_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues/events{/number}","events_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/events","assignees_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/assignees{/user}","branches_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/branches{/branch}","tags_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/tags","blobs_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/refs{/sha}","trees_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/statuses/{sha}","languages_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/languages","stargazers_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/stargazers","contributors_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/contributors","subscribers_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/subscribers","subscription_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/subscription","commits_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/commits{/sha}","git_commits_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/git/commits{/sha}","comments_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/comments{/number}","issue_comment_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues/comments{/number}","contents_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/contents/{+path}","compare_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/merges","archive_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/downloads","issues_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues{/number}","pulls_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls{/number}","milestones_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/milestones{/number}","notifications_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/labels{/name}","releases_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/releases{/id}","deployments_url":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/deployments","created_at":"2016-07-26T10:24:29Z","updated_at":"2017-02-13T04:52:49Z","pushed_at":"2017-01-22T15:27:53Z","git_url":"git://github.com/dev-sec/ansible-nginx-hardening.git","ssh_url":"git@github.com:dev-sec/ansible-nginx-hardening.git","clone_url":"https://github.com/dev-sec/ansible-nginx-hardening.git","svn_url":"https://github.com/dev-sec/ansible-nginx-hardening","homepage":"http://dev-sec.io/","size":21,"stargazers_count":31,"watchers_count":31,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/8"},"html":{"href":"https://github.com/dev-sec/ansible-nginx-hardening/pull/8"},"issue":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues/8"},"comments":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/dev-sec/ansible-nginx-hardening/statuses/0735552d100fa44416c6f8601d20b0ad4057090f"}}}}
{"actor":{"display_login":"artem-sidorenko"}}