{"action":"created","comment":{"url":"https://api.github.com/repos/frida/frida-java/pulls/comments/99443400","pull_request_review_id":20125496,"id":99443400,"diff_hunk":"@@ -39,6 +40,99 @@ public void replacementPropagatesExceptions() {\n         thrown.expectMessage(\"Already dead\");\n         badger.die();\n     }\n+    \n+    static private String failString = null;\n+    static private void Fail( String msg )\n+    {\n+      failString = msg;\n+    }\n+    \n+    @Test\n+    public void TestNewInterface() {","path":"test/re/frida/MethodTest.java","position":20,"original_position":20,"commit_id":"c6a6b01fcdadb9afb5a6921c0c89b2d4f7008368","original_commit_id":"c6a6b01fcdadb9afb5a6921c0c89b2d4f7008368","user":{"login":"oleavr","id":735197,"avatar_url":"https://avatars.githubusercontent.com/u/735197?v=3","gravatar_id":"","url":"https://api.github.com/users/oleavr","html_url":"https://github.com/oleavr","followers_url":"https://api.github.com/users/oleavr/followers","following_url":"https://api.github.com/users/oleavr/following{/other_user}","gists_url":"https://api.github.com/users/oleavr/gists{/gist_id}","starred_url":"https://api.github.com/users/oleavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleavr/subscriptions","organizations_url":"https://api.github.com/users/oleavr/orgs","repos_url":"https://api.github.com/users/oleavr/repos","events_url":"https://api.github.com/users/oleavr/events{/privacy}","received_events_url":"https://api.github.com/users/oleavr/received_events","type":"User","site_admin":false},"body":"Should follow the `camelCase()` style here and below, and also avoid `test` as a prefix since it's already implicit from the class. I tried to follow the examples in the JUnit docs for naming, so in this case perhaps something like `interfaceCannotBeInstantiated()` or something like that.","created_at":"2017-02-03T23:29:02Z","updated_at":"2017-02-03T23:40:56Z","html_url":"https://github.com/frida/frida-java/pull/14#discussion_r99443400","pull_request_url":"https://api.github.com/repos/frida/frida-java/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/frida/frida-java/pulls/comments/99443400"},"html":{"href":"https://github.com/frida/frida-java/pull/14#discussion_r99443400"},"pull_request":{"href":"https://api.github.com/repos/frida/frida-java/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/frida/frida-java/pulls/14","id":104626684,"html_url":"https://github.com/frida/frida-java/pull/14","diff_url":"https://github.com/frida/frida-java/pull/14.diff","patch_url":"https://github.com/frida/frida-java/pull/14.patch","issue_url":"https://api.github.com/repos/frida/frida-java/issues/14","number":14,"state":"open","locked":false,"title":"add some more tests","user":{"login":"giantpune","id":543833,"avatar_url":"https://avatars.githubusercontent.com/u/543833?v=3","gravatar_id":"","url":"https://api.github.com/users/giantpune","html_url":"https://github.com/giantpune","followers_url":"https://api.github.com/users/giantpune/followers","following_url":"https://api.github.com/users/giantpune/following{/other_user}","gists_url":"https://api.github.com/users/giantpune/gists{/gist_id}","starred_url":"https://api.github.com/users/giantpune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantpune/subscriptions","organizations_url":"https://api.github.com/users/giantpune/orgs","repos_url":"https://api.github.com/users/giantpune/repos","events_url":"https://api.github.com/users/giantpune/events{/privacy}","received_events_url":"https://api.github.com/users/giantpune/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-03T22:46:24Z","updated_at":"2017-02-03T23:40:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fef6bba9e05b7d19fcf28072353eefa781fc27a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/frida/frida-java/pulls/14/commits","review_comments_url":"https://api.github.com/repos/frida/frida-java/pulls/14/comments","review_comment_url":"https://api.github.com/repos/frida/frida-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frida/frida-java/issues/14/comments","statuses_url":"https://api.github.com/repos/frida/frida-java/statuses/c6a6b01fcdadb9afb5a6921c0c89b2d4f7008368","head":{"label":"giantpune:fix/add_interface_test","ref":"fix/add_interface_test","sha":"c6a6b01fcdadb9afb5a6921c0c89b2d4f7008368","user":{"login":"giantpune","id":543833,"avatar_url":"https://avatars.githubusercontent.com/u/543833?v=3","gravatar_id":"","url":"https://api.github.com/users/giantpune","html_url":"https://github.com/giantpune","followers_url":"https://api.github.com/users/giantpune/followers","following_url":"https://api.github.com/users/giantpune/following{/other_user}","gists_url":"https://api.github.com/users/giantpune/gists{/gist_id}","starred_url":"https://api.github.com/users/giantpune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantpune/subscriptions","organizations_url":"https://api.github.com/users/giantpune/orgs","repos_url":"https://api.github.com/users/giantpune/repos","events_url":"https://api.github.com/users/giantpune/events{/privacy}","received_events_url":"https://api.github.com/users/giantpune/received_events","type":"User","site_admin":false},"repo":{"id":80859023,"name":"frida-java","full_name":"giantpune/frida-java","owner":{"login":"giantpune","id":543833,"avatar_url":"https://avatars.githubusercontent.com/u/543833?v=3","gravatar_id":"","url":"https://api.github.com/users/giantpune","html_url":"https://github.com/giantpune","followers_url":"https://api.github.com/users/giantpune/followers","following_url":"https://api.github.com/users/giantpune/following{/other_user}","gists_url":"https://api.github.com/users/giantpune/gists{/gist_id}","starred_url":"https://api.github.com/users/giantpune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantpune/subscriptions","organizations_url":"https://api.github.com/users/giantpune/orgs","repos_url":"https://api.github.com/users/giantpune/repos","events_url":"https://api.github.com/users/giantpune/events{/privacy}","received_events_url":"https://api.github.com/users/giantpune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/giantpune/frida-java","description":"Java runtime interop from Frida","fork":true,"url":"https://api.github.com/repos/giantpune/frida-java","forks_url":"https://api.github.com/repos/giantpune/frida-java/forks","keys_url":"https://api.github.com/repos/giantpune/frida-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantpune/frida-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantpune/frida-java/teams","hooks_url":"https://api.github.com/repos/giantpune/frida-java/hooks","issue_events_url":"https://api.github.com/repos/giantpune/frida-java/issues/events{/number}","events_url":"https://api.github.com/repos/giantpune/frida-java/events","assignees_url":"https://api.github.com/repos/giantpune/frida-java/assignees{/user}","branches_url":"https://api.github.com/repos/giantpune/frida-java/branches{/branch}","tags_url":"https://api.github.com/repos/giantpune/frida-java/tags","blobs_url":"https://api.github.com/repos/giantpune/frida-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantpune/frida-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantpune/frida-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantpune/frida-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantpune/frida-java/statuses/{sha}","languages_url":"https://api.github.com/repos/giantpune/frida-java/languages","stargazers_url":"https://api.github.com/repos/giantpune/frida-java/stargazers","contributors_url":"https://api.github.com/repos/giantpune/frida-java/contributors","subscribers_url":"https://api.github.com/repos/giantpune/frida-java/subscribers","subscription_url":"https://api.github.com/repos/giantpune/frida-java/subscription","commits_url":"https://api.github.com/repos/giantpune/frida-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantpune/frida-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantpune/frida-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantpune/frida-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantpune/frida-java/contents/{+path}","compare_url":"https://api.github.com/repos/giantpune/frida-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantpune/frida-java/merges","archive_url":"https://api.github.com/repos/giantpune/frida-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantpune/frida-java/downloads","issues_url":"https://api.github.com/repos/giantpune/frida-java/issues{/number}","pulls_url":"https://api.github.com/repos/giantpune/frida-java/pulls{/number}","milestones_url":"https://api.github.com/repos/giantpune/frida-java/milestones{/number}","notifications_url":"https://api.github.com/repos/giantpune/frida-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantpune/frida-java/labels{/name}","releases_url":"https://api.github.com/repos/giantpune/frida-java/releases{/id}","deployments_url":"https://api.github.com/repos/giantpune/frida-java/deployments","created_at":"2017-02-03T18:50:39Z","updated_at":"2017-02-03T18:50:41Z","pushed_at":"2017-02-03T22:45:44Z","git_url":"git://github.com/giantpune/frida-java.git","ssh_url":"git@github.com:giantpune/frida-java.git","clone_url":"https://github.com/giantpune/frida-java.git","svn_url":"https://github.com/giantpune/frida-java","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"frida:master","ref":"master","sha":"a816f9d33041ee581c191eb6bda11f14fba18b91","user":{"login":"frida","id":4073090,"avatar_url":"https://avatars.githubusercontent.com/u/4073090?v=3","gravatar_id":"","url":"https://api.github.com/users/frida","html_url":"https://github.com/frida","followers_url":"https://api.github.com/users/frida/followers","following_url":"https://api.github.com/users/frida/following{/other_user}","gists_url":"https://api.github.com/users/frida/gists{/gist_id}","starred_url":"https://api.github.com/users/frida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frida/subscriptions","organizations_url":"https://api.github.com/users/frida/orgs","repos_url":"https://api.github.com/users/frida/repos","events_url":"https://api.github.com/users/frida/events{/privacy}","received_events_url":"https://api.github.com/users/frida/received_events","type":"Organization","site_admin":false},"repo":{"id":72156066,"name":"frida-java","full_name":"frida/frida-java","owner":{"login":"frida","id":4073090,"avatar_url":"https://avatars.githubusercontent.com/u/4073090?v=3","gravatar_id":"","url":"https://api.github.com/users/frida","html_url":"https://github.com/frida","followers_url":"https://api.github.com/users/frida/followers","following_url":"https://api.github.com/users/frida/following{/other_user}","gists_url":"https://api.github.com/users/frida/gists{/gist_id}","starred_url":"https://api.github.com/users/frida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frida/subscriptions","organizations_url":"https://api.github.com/users/frida/orgs","repos_url":"https://api.github.com/users/frida/repos","events_url":"https://api.github.com/users/frida/events{/privacy}","received_events_url":"https://api.github.com/users/frida/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frida/frida-java","description":"Java runtime interop from Frida","fork":false,"url":"https://api.github.com/repos/frida/frida-java","forks_url":"https://api.github.com/repos/frida/frida-java/forks","keys_url":"https://api.github.com/repos/frida/frida-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frida/frida-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frida/frida-java/teams","hooks_url":"https://api.github.com/repos/frida/frida-java/hooks","issue_events_url":"https://api.github.com/repos/frida/frida-java/issues/events{/number}","events_url":"https://api.github.com/repos/frida/frida-java/events","assignees_url":"https://api.github.com/repos/frida/frida-java/assignees{/user}","branches_url":"https://api.github.com/repos/frida/frida-java/branches{/branch}","tags_url":"https://api.github.com/repos/frida/frida-java/tags","blobs_url":"https://api.github.com/repos/frida/frida-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frida/frida-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frida/frida-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/frida/frida-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frida/frida-java/statuses/{sha}","languages_url":"https://api.github.com/repos/frida/frida-java/languages","stargazers_url":"https://api.github.com/repos/frida/frida-java/stargazers","contributors_url":"https://api.github.com/repos/frida/frida-java/contributors","subscribers_url":"https://api.github.com/repos/frida/frida-java/subscribers","subscription_url":"https://api.github.com/repos/frida/frida-java/subscription","commits_url":"https://api.github.com/repos/frida/frida-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/frida/frida-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/frida/frida-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/frida/frida-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/frida/frida-java/contents/{+path}","compare_url":"https://api.github.com/repos/frida/frida-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frida/frida-java/merges","archive_url":"https://api.github.com/repos/frida/frida-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frida/frida-java/downloads","issues_url":"https://api.github.com/repos/frida/frida-java/issues{/number}","pulls_url":"https://api.github.com/repos/frida/frida-java/pulls{/number}","milestones_url":"https://api.github.com/repos/frida/frida-java/milestones{/number}","notifications_url":"https://api.github.com/repos/frida/frida-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frida/frida-java/labels{/name}","releases_url":"https://api.github.com/repos/frida/frida-java/releases{/id}","deployments_url":"https://api.github.com/repos/frida/frida-java/deployments","created_at":"2016-10-27T23:21:21Z","updated_at":"2017-01-26T02:23:43Z","pushed_at":"2017-02-03T22:46:25Z","git_url":"git://github.com/frida/frida-java.git","ssh_url":"git@github.com:frida/frida-java.git","clone_url":"https://github.com/frida/frida-java.git","svn_url":"https://github.com/frida/frida-java","homepage":null,"size":120,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/frida/frida-java/pulls/14"},"html":{"href":"https://github.com/frida/frida-java/pull/14"},"issue":{"href":"https://api.github.com/repos/frida/frida-java/issues/14"},"comments":{"href":"https://api.github.com/repos/frida/frida-java/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/frida/frida-java/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/frida/frida-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frida/frida-java/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/frida/frida-java/statuses/c6a6b01fcdadb9afb5a6921c0c89b2d4f7008368"}}}}
{"actor":{"display_login":"oleavr"}}