{"action":"closed","number":85,"pull_request":{"url":"https://api.github.com/repos/Nickersoft/push.js/pulls/85","id":99892821,"html_url":"https://github.com/Nickersoft/push.js/pull/85","diff_url":"https://github.com/Nickersoft/push.js/pull/85.diff","patch_url":"https://github.com/Nickersoft/push.js/pull/85.patch","issue_url":"https://api.github.com/repos/Nickersoft/push.js/issues/85","number":85,"state":"closed","locked":false,"title":"Bypass requestPermission call if permission is already non-default","user":{"login":"mshick","id":277401,"avatar_url":"https://avatars.githubusercontent.com/u/277401?v=3","gravatar_id":"","url":"https://api.github.com/users/mshick","html_url":"https://github.com/mshick","followers_url":"https://api.github.com/users/mshick/followers","following_url":"https://api.github.com/users/mshick/following{/other_user}","gists_url":"https://api.github.com/users/mshick/gists{/gist_id}","starred_url":"https://api.github.com/users/mshick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshick/subscriptions","organizations_url":"https://api.github.com/users/mshick/orgs","repos_url":"https://api.github.com/users/mshick/repos","events_url":"https://api.github.com/users/mshick/events{/privacy}","received_events_url":"https://api.github.com/users/mshick/received_events","type":"User","site_admin":false},"body":"Per issue #84. It seems like the issue is that Fluid apps have a pre-set `Notification.permission` value and will not fire the `Notification.requestPermission` callback. \r\n\r\nThe following PR changes the `Push.request` method to first check for an existing, non-default `Notification.permission` value before attempting to request permissions.\r\n\r\nAlso included is a simple test to ensure `requestPermission` is not called if `Push.get` returns a non-default value.\r\n\r\nKarma test are passing with FF, and I've personally tested in latest Chrome, Fluid and Safari. All appear to work correctly.","created_at":"2017-01-02T21:15:01Z","updated_at":"2017-01-03T21:44:01Z","closed_at":"2017-01-03T21:44:01Z","merged_at":"2017-01-03T21:44:01Z","merge_commit_sha":"0df73f67b941612b470b89f41cbe78296647d1a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nickersoft/push.js/pulls/85/commits","review_comments_url":"https://api.github.com/repos/Nickersoft/push.js/pulls/85/comments","review_comment_url":"https://api.github.com/repos/Nickersoft/push.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nickersoft/push.js/issues/85/comments","statuses_url":"https://api.github.com/repos/Nickersoft/push.js/statuses/cee10eb03f6b71ec2173690fdd99cb849307a2cd","head":{"label":"mshick:master","ref":"master","sha":"cee10eb03f6b71ec2173690fdd99cb849307a2cd","user":{"login":"mshick","id":277401,"avatar_url":"https://avatars.githubusercontent.com/u/277401?v=3","gravatar_id":"","url":"https://api.github.com/users/mshick","html_url":"https://github.com/mshick","followers_url":"https://api.github.com/users/mshick/followers","following_url":"https://api.github.com/users/mshick/following{/other_user}","gists_url":"https://api.github.com/users/mshick/gists{/gist_id}","starred_url":"https://api.github.com/users/mshick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshick/subscriptions","organizations_url":"https://api.github.com/users/mshick/orgs","repos_url":"https://api.github.com/users/mshick/repos","events_url":"https://api.github.com/users/mshick/events{/privacy}","received_events_url":"https://api.github.com/users/mshick/received_events","type":"User","site_admin":false},"repo":{"id":77861903,"name":"push.js","full_name":"mshick/push.js","owner":{"login":"mshick","id":277401,"avatar_url":"https://avatars.githubusercontent.com/u/277401?v=3","gravatar_id":"","url":"https://api.github.com/users/mshick","html_url":"https://github.com/mshick","followers_url":"https://api.github.com/users/mshick/followers","following_url":"https://api.github.com/users/mshick/following{/other_user}","gists_url":"https://api.github.com/users/mshick/gists{/gist_id}","starred_url":"https://api.github.com/users/mshick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshick/subscriptions","organizations_url":"https://api.github.com/users/mshick/orgs","repos_url":"https://api.github.com/users/mshick/repos","events_url":"https://api.github.com/users/mshick/events{/privacy}","received_events_url":"https://api.github.com/users/mshick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mshick/push.js","description":"A compact, cross-browser solution for the JavaScript Notifications API","fork":true,"url":"https://api.github.com/repos/mshick/push.js","forks_url":"https://api.github.com/repos/mshick/push.js/forks","keys_url":"https://api.github.com/repos/mshick/push.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mshick/push.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mshick/push.js/teams","hooks_url":"https://api.github.com/repos/mshick/push.js/hooks","issue_events_url":"https://api.github.com/repos/mshick/push.js/issues/events{/number}","events_url":"https://api.github.com/repos/mshick/push.js/events","assignees_url":"https://api.github.com/repos/mshick/push.js/assignees{/user}","branches_url":"https://api.github.com/repos/mshick/push.js/branches{/branch}","tags_url":"https://api.github.com/repos/mshick/push.js/tags","blobs_url":"https://api.github.com/repos/mshick/push.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mshick/push.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mshick/push.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mshick/push.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mshick/push.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mshick/push.js/languages","stargazers_url":"https://api.github.com/repos/mshick/push.js/stargazers","contributors_url":"https://api.github.com/repos/mshick/push.js/contributors","subscribers_url":"https://api.github.com/repos/mshick/push.js/subscribers","subscription_url":"https://api.github.com/repos/mshick/push.js/subscription","commits_url":"https://api.github.com/repos/mshick/push.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mshick/push.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mshick/push.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mshick/push.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mshick/push.js/contents/{+path}","compare_url":"https://api.github.com/repos/mshick/push.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mshick/push.js/merges","archive_url":"https://api.github.com/repos/mshick/push.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mshick/push.js/downloads","issues_url":"https://api.github.com/repos/mshick/push.js/issues{/number}","pulls_url":"https://api.github.com/repos/mshick/push.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mshick/push.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mshick/push.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mshick/push.js/labels{/name}","releases_url":"https://api.github.com/repos/mshick/push.js/releases{/id}","deployments_url":"https://api.github.com/repos/mshick/push.js/deployments","created_at":"2017-01-02T21:08:09Z","updated_at":"2017-01-02T21:08:12Z","pushed_at":"2017-01-02T21:08:56Z","git_url":"git://github.com/mshick/push.js.git","ssh_url":"git@github.com:mshick/push.js.git","clone_url":"https://github.com/mshick/push.js.git","svn_url":"https://github.com/mshick/push.js","homepage":"http://nickersoft.github.io/push.js","size":247,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Nickersoft:master","ref":"master","sha":"a8b79803a4da9ad4e0ade75a1ef13c871860b662","user":{"login":"Nickersoft","id":2104129,"avatar_url":"https://avatars.githubusercontent.com/u/2104129?v=3","gravatar_id":"","url":"https://api.github.com/users/Nickersoft","html_url":"https://github.com/Nickersoft","followers_url":"https://api.github.com/users/Nickersoft/followers","following_url":"https://api.github.com/users/Nickersoft/following{/other_user}","gists_url":"https://api.github.com/users/Nickersoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Nickersoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nickersoft/subscriptions","organizations_url":"https://api.github.com/users/Nickersoft/orgs","repos_url":"https://api.github.com/users/Nickersoft/repos","events_url":"https://api.github.com/users/Nickersoft/events{/privacy}","received_events_url":"https://api.github.com/users/Nickersoft/received_events","type":"User","site_admin":false},"repo":{"id":39357088,"name":"push.js","full_name":"Nickersoft/push.js","owner":{"login":"Nickersoft","id":2104129,"avatar_url":"https://avatars.githubusercontent.com/u/2104129?v=3","gravatar_id":"","url":"https://api.github.com/users/Nickersoft","html_url":"https://github.com/Nickersoft","followers_url":"https://api.github.com/users/Nickersoft/followers","following_url":"https://api.github.com/users/Nickersoft/following{/other_user}","gists_url":"https://api.github.com/users/Nickersoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Nickersoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nickersoft/subscriptions","organizations_url":"https://api.github.com/users/Nickersoft/orgs","repos_url":"https://api.github.com/users/Nickersoft/repos","events_url":"https://api.github.com/users/Nickersoft/events{/privacy}","received_events_url":"https://api.github.com/users/Nickersoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nickersoft/push.js","description":"A compact, cross-browser solution for the JavaScript Notifications API","fork":false,"url":"https://api.github.com/repos/Nickersoft/push.js","forks_url":"https://api.github.com/repos/Nickersoft/push.js/forks","keys_url":"https://api.github.com/repos/Nickersoft/push.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nickersoft/push.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nickersoft/push.js/teams","hooks_url":"https://api.github.com/repos/Nickersoft/push.js/hooks","issue_events_url":"https://api.github.com/repos/Nickersoft/push.js/issues/events{/number}","events_url":"https://api.github.com/repos/Nickersoft/push.js/events","assignees_url":"https://api.github.com/repos/Nickersoft/push.js/assignees{/user}","branches_url":"https://api.github.com/repos/Nickersoft/push.js/branches{/branch}","tags_url":"https://api.github.com/repos/Nickersoft/push.js/tags","blobs_url":"https://api.github.com/repos/Nickersoft/push.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nickersoft/push.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nickersoft/push.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nickersoft/push.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nickersoft/push.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Nickersoft/push.js/languages","stargazers_url":"https://api.github.com/repos/Nickersoft/push.js/stargazers","contributors_url":"https://api.github.com/repos/Nickersoft/push.js/contributors","subscribers_url":"https://api.github.com/repos/Nickersoft/push.js/subscribers","subscription_url":"https://api.github.com/repos/Nickersoft/push.js/subscription","commits_url":"https://api.github.com/repos/Nickersoft/push.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nickersoft/push.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nickersoft/push.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nickersoft/push.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nickersoft/push.js/contents/{+path}","compare_url":"https://api.github.com/repos/Nickersoft/push.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nickersoft/push.js/merges","archive_url":"https://api.github.com/repos/Nickersoft/push.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nickersoft/push.js/downloads","issues_url":"https://api.github.com/repos/Nickersoft/push.js/issues{/number}","pulls_url":"https://api.github.com/repos/Nickersoft/push.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Nickersoft/push.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Nickersoft/push.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nickersoft/push.js/labels{/name}","releases_url":"https://api.github.com/repos/Nickersoft/push.js/releases{/id}","deployments_url":"https://api.github.com/repos/Nickersoft/push.js/deployments","created_at":"2015-07-20T01:46:04Z","updated_at":"2017-01-03T10:51:03Z","pushed_at":"2017-01-03T21:44:02Z","git_url":"git://github.com/Nickersoft/push.js.git","ssh_url":"git@github.com:Nickersoft/push.js.git","clone_url":"https://github.com/Nickersoft/push.js.git","svn_url":"https://github.com/Nickersoft/push.js","homepage":"http://nickersoft.github.io/push.js","size":260,"stargazers_count":5544,"watchers_count":5544,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":236,"mirror_url":null,"open_issues_count":12,"forks":236,"open_issues":12,"watchers":5544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nickersoft/push.js/pulls/85"},"html":{"href":"https://github.com/Nickersoft/push.js/pull/85"},"issue":{"href":"https://api.github.com/repos/Nickersoft/push.js/issues/85"},"comments":{"href":"https://api.github.com/repos/Nickersoft/push.js/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/Nickersoft/push.js/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/Nickersoft/push.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nickersoft/push.js/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/Nickersoft/push.js/statuses/cee10eb03f6b71ec2173690fdd99cb849307a2cd"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Nickersoft","id":2104129,"avatar_url":"https://avatars.githubusercontent.com/u/2104129?v=3","gravatar_id":"","url":"https://api.github.com/users/Nickersoft","html_url":"https://github.com/Nickersoft","followers_url":"https://api.github.com/users/Nickersoft/followers","following_url":"https://api.github.com/users/Nickersoft/following{/other_user}","gists_url":"https://api.github.com/users/Nickersoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Nickersoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nickersoft/subscriptions","organizations_url":"https://api.github.com/users/Nickersoft/orgs","repos_url":"https://api.github.com/users/Nickersoft/repos","events_url":"https://api.github.com/users/Nickersoft/events{/privacy}","received_events_url":"https://api.github.com/users/Nickersoft/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":17,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"Nickersoft"}}