{"action":"closed","number":20024,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20024","id":130622626,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/20024","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/20024.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/20024.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20024","number":20024,"state":"closed","locked":false,"title":"Core/VMaps: Fix no collision triangles","user":{"login":"Golrag","id":6825243,"avatar_url":"https://avatars1.githubusercontent.com/u/6825243?v=4","gravatar_id":"","url":"https://api.github.com/users/Golrag","html_url":"https://github.com/Golrag","followers_url":"https://api.github.com/users/Golrag/followers","following_url":"https://api.github.com/users/Golrag/following{/other_user}","gists_url":"https://api.github.com/users/Golrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Golrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golrag/subscriptions","organizations_url":"https://api.github.com/users/Golrag/orgs","repos_url":"https://api.github.com/users/Golrag/repos","events_url":"https://api.github.com/users/Golrag/events{/privacy}","received_events_url":"https://api.github.com/users/Golrag/received_events","type":"User","site_admin":false},"body":"<!--- (**********************************)\r\n      (** Fill in the following fields **)\r\n      (**********************************) --->\r\n\r\n**Changes proposed:**\r\n\r\n-  Fix collision check when generating vmaps\r\n\r\n**Target branch(es):** 3.3.5/master\r\n\r\n- 3.3.5\r\n- master\r\n\r\n**Issues addressed:** Closes https://github.com/TrinityCore/TrinityCore/issues/19865\r\n\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc.)\r\n- Builds\r\n- Tested in game\r\n\r\n**Notes:**\r\n- Reextracting vmaps\r\n\r\n\r\n\r\n<!--- Notes\r\n- Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request.\r\n- If this PR only contains SQL files, open a new issue instead and post or link the SQL in the issue.\r\n- When adding new SQL files, name them 9999_99_99_99_db_name.sql to reduce the chance of possible merge conflicts.\r\n--->\r\n","created_at":"2017-07-14T16:12:03Z","updated_at":"2017-11-22T14:16:37Z","closed_at":"2017-11-22T14:16:37Z","merged_at":"2017-11-22T14:16:37Z","merge_commit_sha":"9614f9d8cf295d4135346d59e67fa47b51d2ed88","assignee":{"login":"Warpten","id":563936,"avatar_url":"https://avatars3.githubusercontent.com/u/563936?v=4","gravatar_id":"","url":"https://api.github.com/users/Warpten","html_url":"https://github.com/Warpten","followers_url":"https://api.github.com/users/Warpten/followers","following_url":"https://api.github.com/users/Warpten/following{/other_user}","gists_url":"https://api.github.com/users/Warpten/gists{/gist_id}","starred_url":"https://api.github.com/users/Warpten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warpten/subscriptions","organizations_url":"https://api.github.com/users/Warpten/orgs","repos_url":"https://api.github.com/users/Warpten/repos","events_url":"https://api.github.com/users/Warpten/events{/privacy}","received_events_url":"https://api.github.com/users/Warpten/received_events","type":"User","site_admin":false},"assignees":[{"login":"Warpten","id":563936,"avatar_url":"https://avatars3.githubusercontent.com/u/563936?v=4","gravatar_id":"","url":"https://api.github.com/users/Warpten","html_url":"https://github.com/Warpten","followers_url":"https://api.github.com/users/Warpten/followers","following_url":"https://api.github.com/users/Warpten/following{/other_user}","gists_url":"https://api.github.com/users/Warpten/gists{/gist_id}","starred_url":"https://api.github.com/users/Warpten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warpten/subscriptions","organizations_url":"https://api.github.com/users/Warpten/orgs","repos_url":"https://api.github.com/users/Warpten/repos","events_url":"https://api.github.com/users/Warpten/events{/privacy}","received_events_url":"https://api.github.com/users/Warpten/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20024/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20024/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20024/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/89d641f1e68d11359a2398ff51d3d6eee1470ae8","head":{"label":"Golrag:fix_collision","ref":"fix_collision","sha":"89d641f1e68d11359a2398ff51d3d6eee1470ae8","user":{"login":"Golrag","id":6825243,"avatar_url":"https://avatars1.githubusercontent.com/u/6825243?v=4","gravatar_id":"","url":"https://api.github.com/users/Golrag","html_url":"https://github.com/Golrag","followers_url":"https://api.github.com/users/Golrag/followers","following_url":"https://api.github.com/users/Golrag/following{/other_user}","gists_url":"https://api.github.com/users/Golrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Golrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golrag/subscriptions","organizations_url":"https://api.github.com/users/Golrag/orgs","repos_url":"https://api.github.com/users/Golrag/repos","events_url":"https://api.github.com/users/Golrag/events{/privacy}","received_events_url":"https://api.github.com/users/Golrag/received_events","type":"User","site_admin":false},"repo":{"id":23447727,"name":"TrinityCore","full_name":"Golrag/TrinityCore","owner":{"login":"Golrag","id":6825243,"avatar_url":"https://avatars1.githubusercontent.com/u/6825243?v=4","gravatar_id":"","url":"https://api.github.com/users/Golrag","html_url":"https://github.com/Golrag","followers_url":"https://api.github.com/users/Golrag/followers","following_url":"https://api.github.com/users/Golrag/following{/other_user}","gists_url":"https://api.github.com/users/Golrag/gists{/gist_id}","starred_url":"https://api.github.com/users/Golrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Golrag/subscriptions","organizations_url":"https://api.github.com/users/Golrag/orgs","repos_url":"https://api.github.com/users/Golrag/repos","events_url":"https://api.github.com/users/Golrag/events{/privacy}","received_events_url":"https://api.github.com/users/Golrag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Golrag/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Golrag/TrinityCore","forks_url":"https://api.github.com/repos/Golrag/TrinityCore/forks","keys_url":"https://api.github.com/repos/Golrag/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Golrag/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Golrag/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Golrag/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Golrag/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Golrag/TrinityCore/events","assignees_url":"https://api.github.com/repos/Golrag/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Golrag/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Golrag/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Golrag/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Golrag/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Golrag/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Golrag/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Golrag/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Golrag/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Golrag/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Golrag/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Golrag/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Golrag/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Golrag/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Golrag/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Golrag/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Golrag/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Golrag/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Golrag/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Golrag/TrinityCore/merges","archive_url":"https://api.github.com/repos/Golrag/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Golrag/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Golrag/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Golrag/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Golrag/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Golrag/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Golrag/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Golrag/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/Golrag/TrinityCore/deployments","created_at":"2014-08-29T00:44:35Z","updated_at":"2016-09-29T12:41:54Z","pushed_at":"2017-11-10T11:29:17Z","git_url":"git://github.com/Golrag/TrinityCore.git","ssh_url":"git@github.com:Golrag/TrinityCore.git","clone_url":"https://github.com/Golrag/TrinityCore.git","svn_url":"https://github.com/Golrag/TrinityCore","homepage":"http://www.trinitycore.org","size":455757,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"6.x"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"9c1a426202baf40412bb3ce8f97a9ac0820c9dfd","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars3.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars3.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework (master = 7.2.5.24742, 3.3.5 = 3.3.5a.12340)","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2017-11-21T13:40:01Z","pushed_at":"2017-11-22T14:16:37Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":464094,"stargazers_count":4060,"watchers_count":4060,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3933,"mirror_url":null,"archived":false,"open_issues_count":1548,"forks":3933,"open_issues":1548,"watchers":4060,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20024"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/20024"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20024"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/20024/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20024/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/20024/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/89d641f1e68d11359a2398ff51d3d6eee1470ae8"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Warpten","id":563936,"avatar_url":"https://avatars3.githubusercontent.com/u/563936?v=4","gravatar_id":"","url":"https://api.github.com/users/Warpten","html_url":"https://github.com/Warpten","followers_url":"https://api.github.com/users/Warpten/followers","following_url":"https://api.github.com/users/Warpten/following{/other_user}","gists_url":"https://api.github.com/users/Warpten/gists{/gist_id}","starred_url":"https://api.github.com/users/Warpten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warpten/subscriptions","organizations_url":"https://api.github.com/users/Warpten/orgs","repos_url":"https://api.github.com/users/Warpten/repos","events_url":"https://api.github.com/users/Warpten/events{/privacy}","received_events_url":"https://api.github.com/users/Warpten/received_events","type":"User","site_admin":false},"comments":27,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"Warpten"}}