{"action":"created","issue":{"url":"https://api.github.com/repos/juju/charm-helpers/issues/58","repository_url":"https://api.github.com/repos/juju/charm-helpers","labels_url":"https://api.github.com/repos/juju/charm-helpers/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/juju/charm-helpers/issues/58/comments","events_url":"https://api.github.com/repos/juju/charm-helpers/issues/58/events","html_url":"https://github.com/juju/charm-helpers/pull/58","id":275631529,"number":58,"title":"SSL File writing should use byte mode","user":{"login":"ChrisMacNaughton","id":429739,"avatar_url":"https://avatars1.githubusercontent.com/u/429739?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisMacNaughton","html_url":"https://github.com/ChrisMacNaughton","followers_url":"https://api.github.com/users/ChrisMacNaughton/followers","following_url":"https://api.github.com/users/ChrisMacNaughton/following{/other_user}","gists_url":"https://api.github.com/users/ChrisMacNaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisMacNaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisMacNaughton/subscriptions","organizations_url":"https://api.github.com/users/ChrisMacNaughton/orgs","repos_url":"https://api.github.com/users/ChrisMacNaughton/repos","events_url":"https://api.github.com/users/ChrisMacNaughton/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisMacNaughton/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-21T08:56:32Z","updated_at":"2017-12-19T11:22:52Z","closed_at":"2017-11-21T10:46:41Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/juju/charm-helpers/pulls/58","html_url":"https://github.com/juju/charm-helpers/pull/58","diff_url":"https://github.com/juju/charm-helpers/pull/58.diff","patch_url":"https://github.com/juju/charm-helpers/pull/58.patch"},"body":"Closes #57"},"comment":{"url":"https://api.github.com/repos/juju/charm-helpers/issues/comments/352720694","html_url":"https://github.com/juju/charm-helpers/pull/58#issuecomment-352720694","issue_url":"https://api.github.com/repos/juju/charm-helpers/issues/58","id":352720694,"user":{"login":"tbaumann","id":76476,"avatar_url":"https://avatars3.githubusercontent.com/u/76476?v=4","gravatar_id":"","url":"https://api.github.com/users/tbaumann","html_url":"https://github.com/tbaumann","followers_url":"https://api.github.com/users/tbaumann/followers","following_url":"https://api.github.com/users/tbaumann/following{/other_user}","gists_url":"https://api.github.com/users/tbaumann/gists{/gist_id}","starred_url":"https://api.github.com/users/tbaumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbaumann/subscriptions","organizations_url":"https://api.github.com/users/tbaumann/orgs","repos_url":"https://api.github.com/users/tbaumann/repos","events_url":"https://api.github.com/users/tbaumann/events{/privacy}","received_events_url":"https://api.github.com/users/tbaumann/received_events","type":"User","site_admin":false},"created_at":"2017-12-19T11:22:52Z","updated_at":"2017-12-19T11:22:52Z","author_association":"NONE","body":"Sorry guys. That breaks the string comparison.\r\n`if old_cert and old_cert == ca_cert:`\r\n\r\nI suppose using open() with 'rb' in retrieve_ca_cert() and using '=' for comparison in above line brings that in line. Use binary all the way."}}
{"actor":{"display_login":"tbaumann"}}