{"action":"created","issue":{"url":"https://api.github.com/repos/IQSS/dataverse/issues/2998","repository_url":"https://api.github.com/repos/IQSS/dataverse","labels_url":"https://api.github.com/repos/IQSS/dataverse/issues/2998/labels{/name}","comments_url":"https://api.github.com/repos/IQSS/dataverse/issues/2998/comments","events_url":"https://api.github.com/repos/IQSS/dataverse/issues/2998/events","html_url":"https://github.com/IQSS/dataverse/issues/2998","id":138480724,"number":2998,"title":"Be more permissive in what we consider a valid email address to be","user":{"login":"pdurbin","id":21006,"avatar_url":"https://avatars2.githubusercontent.com/u/21006?v=4","gravatar_id":"","url":"https://api.github.com/users/pdurbin","html_url":"https://github.com/pdurbin","followers_url":"https://api.github.com/users/pdurbin/followers","following_url":"https://api.github.com/users/pdurbin/following{/other_user}","gists_url":"https://api.github.com/users/pdurbin/gists{/gist_id}","starred_url":"https://api.github.com/users/pdurbin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdurbin/subscriptions","organizations_url":"https://api.github.com/users/pdurbin/orgs","repos_url":"https://api.github.com/users/pdurbin/repos","events_url":"https://api.github.com/users/pdurbin/events{/privacy}","received_events_url":"https://api.github.com/users/pdurbin/received_events","type":"User","site_admin":false},"labels":[{"id":317519223,"url":"https://api.github.com/repos/IQSS/dataverse/labels/Component:%20Account%20&%20User%20Info","name":"Component: Account & User Info","color":"c7def8","default":false},{"id":414097218,"url":"https://api.github.com/repos/IQSS/dataverse/labels/Status:%20Development","name":"Status: Development","color":"ededed","default":false},{"id":112723901,"url":"https://api.github.com/repos/IQSS/dataverse/labels/Type:%20Suggestion","name":"Type: Suggestion","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"oscardssmith","id":11729272,"avatar_url":"https://avatars2.githubusercontent.com/u/11729272?v=4","gravatar_id":"","url":"https://api.github.com/users/oscardssmith","html_url":"https://github.com/oscardssmith","followers_url":"https://api.github.com/users/oscardssmith/followers","following_url":"https://api.github.com/users/oscardssmith/following{/other_user}","gists_url":"https://api.github.com/users/oscardssmith/gists{/gist_id}","starred_url":"https://api.github.com/users/oscardssmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscardssmith/subscriptions","organizations_url":"https://api.github.com/users/oscardssmith/orgs","repos_url":"https://api.github.com/users/oscardssmith/repos","events_url":"https://api.github.com/users/oscardssmith/events{/privacy}","received_events_url":"https://api.github.com/users/oscardssmith/received_events","type":"User","site_admin":false},"assignees":[{"login":"oscardssmith","id":11729272,"avatar_url":"https://avatars2.githubusercontent.com/u/11729272?v=4","gravatar_id":"","url":"https://api.github.com/users/oscardssmith","html_url":"https://github.com/oscardssmith","followers_url":"https://api.github.com/users/oscardssmith/followers","following_url":"https://api.github.com/users/oscardssmith/following{/other_user}","gists_url":"https://api.github.com/users/oscardssmith/gists{/gist_id}","starred_url":"https://api.github.com/users/oscardssmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscardssmith/subscriptions","organizations_url":"https://api.github.com/users/oscardssmith/orgs","repos_url":"https://api.github.com/users/oscardssmith/repos","events_url":"https://api.github.com/users/oscardssmith/events{/privacy}","received_events_url":"https://api.github.com/users/oscardssmith/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2016-03-04T13:47:56Z","updated_at":"2017-07-19T16:55:43Z","closed_at":null,"body":"While working on #2512 and testing with random email addresses from the https://randomuser.me API, I observed that certain email addresses were treated as invalid. Examples include:\n- michélle.pereboom@example.com\n- begüm.vriezen@example.com\n- lótus.gonçalves@example.com\n- رونیکا.محمدخان@example.com\n\nIs https://randomuser.me slipping us bad email addresses or is Dataverse being too strict about what is considered a valid email address?\n\nThe first three addresses above pass http://sphinx.mythic-beasts.com/~pdw/cgi-bin/emailvalidate but رونیکا.محمدخان@example.com does not. Locally, if I upgrade [Validator – Commons Validator](https://commons.apache.org/proper/commons-validator/) from 1.4.0 to 1.5.0, all the addresses above are considered valid. I'll push a test for this.\n\nhttps://en.wikipedia.org/wiki/Email_address says \"In addition to the above ASCII characters, international characters above U+007F, encoded as UTF-8, are permitted by RFC 6531, though mail systems may restrict which characters to use when assigning local parts.\"\n\nHere's a screenshot of how a user can't be created because of an email address that doesn't pass validation:\n\n![screen shot 2016-03-03 at 12 10 50 pm](https://cloud.githubusercontent.com/assets/21006/13528664/81cbc41c-e1e5-11e5-9a76-5c1e9220ba5b.png)\n\nHow strict do we want Dataverse to be with regard to email addresses?\n"},"comment":{"url":"https://api.github.com/repos/IQSS/dataverse/issues/comments/316449749","html_url":"https://github.com/IQSS/dataverse/issues/2998#issuecomment-316449749","issue_url":"https://api.github.com/repos/IQSS/dataverse/issues/2998","id":316449749,"user":{"login":"djbrooke","id":7773392,"avatar_url":"https://avatars2.githubusercontent.com/u/7773392?v=4","gravatar_id":"","url":"https://api.github.com/users/djbrooke","html_url":"https://github.com/djbrooke","followers_url":"https://api.github.com/users/djbrooke/followers","following_url":"https://api.github.com/users/djbrooke/following{/other_user}","gists_url":"https://api.github.com/users/djbrooke/gists{/gist_id}","starred_url":"https://api.github.com/users/djbrooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djbrooke/subscriptions","organizations_url":"https://api.github.com/users/djbrooke/orgs","repos_url":"https://api.github.com/users/djbrooke/repos","events_url":"https://api.github.com/users/djbrooke/events{/privacy}","received_events_url":"https://api.github.com/users/djbrooke/received_events","type":"User","site_admin":false},"created_at":"2017-07-19T16:55:43Z","updated_at":"2017-07-19T16:55:43Z","body":"Thanks for the discussion about this post-standup. The benefits of allowing these additional email addresses is a big plus. I understand there is some risk of undelivered mail, but we'll see how widespread it is before investigating adding a whitelist/blacklist or some other solution."}}
{"actor":{"display_login":"djbrooke"}}