{"action":"created","issue":{"url":"https://api.github.com/repos/r-spacex/SpaceX-API/issues/53","repository_url":"https://api.github.com/repos/r-spacex/SpaceX-API","labels_url":"https://api.github.com/repos/r-spacex/SpaceX-API/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/r-spacex/SpaceX-API/issues/53/comments","events_url":"https://api.github.com/repos/r-spacex/SpaceX-API/issues/53/events","html_url":"https://github.com/r-spacex/SpaceX-API/issues/53","id":270723872,"number":53,"title":"Source data is inconsistent","user":{"login":"Srokap","id":1339628,"avatar_url":"https://avatars2.githubusercontent.com/u/1339628?v=4","gravatar_id":"","url":"https://api.github.com/users/Srokap","html_url":"https://github.com/Srokap","followers_url":"https://api.github.com/users/Srokap/followers","following_url":"https://api.github.com/users/Srokap/following{/other_user}","gists_url":"https://api.github.com/users/Srokap/gists{/gist_id}","starred_url":"https://api.github.com/users/Srokap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Srokap/subscriptions","organizations_url":"https://api.github.com/users/Srokap/orgs","repos_url":"https://api.github.com/users/Srokap/repos","events_url":"https://api.github.com/users/Srokap/events{/privacy}","received_events_url":"https://api.github.com/users/Srokap/received_events","type":"User","site_admin":false},"labels":[{"id":633024489,"url":"https://api.github.com/repos/r-spacex/SpaceX-API/labels/Data%20Fix","name":"Data Fix","color":"5319e7","default":false},{"id":629947199,"url":"https://api.github.com/repos/r-spacex/SpaceX-API/labels/Ideas","name":"Ideas","color":"cc317c","default":false},{"id":631322581,"url":"https://api.github.com/repos/r-spacex/SpaceX-API/labels/In%20Progress","name":"In Progress","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"jakewmeyer","id":20619528,"avatar_url":"https://avatars1.githubusercontent.com/u/20619528?v=4","gravatar_id":"","url":"https://api.github.com/users/jakewmeyer","html_url":"https://github.com/jakewmeyer","followers_url":"https://api.github.com/users/jakewmeyer/followers","following_url":"https://api.github.com/users/jakewmeyer/following{/other_user}","gists_url":"https://api.github.com/users/jakewmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jakewmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakewmeyer/subscriptions","organizations_url":"https://api.github.com/users/jakewmeyer/orgs","repos_url":"https://api.github.com/users/jakewmeyer/repos","events_url":"https://api.github.com/users/jakewmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jakewmeyer/received_events","type":"User","site_admin":false},"assignees":[{"login":"jakewmeyer","id":20619528,"avatar_url":"https://avatars1.githubusercontent.com/u/20619528?v=4","gravatar_id":"","url":"https://api.github.com/users/jakewmeyer","html_url":"https://github.com/jakewmeyer","followers_url":"https://api.github.com/users/jakewmeyer/followers","following_url":"https://api.github.com/users/jakewmeyer/following{/other_user}","gists_url":"https://api.github.com/users/jakewmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jakewmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakewmeyer/subscriptions","organizations_url":"https://api.github.com/users/jakewmeyer/orgs","repos_url":"https://api.github.com/users/jakewmeyer/repos","events_url":"https://api.github.com/users/jakewmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jakewmeyer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-11-02T16:40:01Z","updated_at":"2017-12-06T23:07:04Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I'm not sure how do you input new data, but it looks like some of mongo documents have very different properties within same collection. It is important to know what to expect in the results form the api user perspective.\r\n\r\nI started a branch to add more assertions for results https://github.com/Srokap/SpaceX-API/tree/more_assertions and noticed that ie. dragon capsule and falcon rockets data differs wildly. The launches data has single launch with missing UTC timestamp.\r\n\r\nSo main question is about approach to take to make api useful for it's users that need to make assumptions about what to expect in results. We could track it in tests, or we could validate data when being put into db. In this use case, making extensive input tools might be not worth the effort, so we might run travis on master on schedule instead (don't remember if Travis allows to run tests on demand)."},"comment":{"url":"https://api.github.com/repos/r-spacex/SpaceX-API/issues/comments/349805117","html_url":"https://github.com/r-spacex/SpaceX-API/issues/53#issuecomment-349805117","issue_url":"https://api.github.com/repos/r-spacex/SpaceX-API/issues/53","id":349805117,"user":{"login":"jakewmeyer","id":20619528,"avatar_url":"https://avatars1.githubusercontent.com/u/20619528?v=4","gravatar_id":"","url":"https://api.github.com/users/jakewmeyer","html_url":"https://github.com/jakewmeyer","followers_url":"https://api.github.com/users/jakewmeyer/followers","following_url":"https://api.github.com/users/jakewmeyer/following{/other_user}","gists_url":"https://api.github.com/users/jakewmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/jakewmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakewmeyer/subscriptions","organizations_url":"https://api.github.com/users/jakewmeyer/orgs","repos_url":"https://api.github.com/users/jakewmeyer/repos","events_url":"https://api.github.com/users/jakewmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/jakewmeyer/received_events","type":"User","site_admin":false},"created_at":"2017-12-06T23:07:04Z","updated_at":"2017-12-06T23:07:04Z","author_association":"OWNER","body":"The schema changes are live now, all rockets should have exactly the same structure, solving the inconsistency issue. Dragon data is now on its own collection and endpoint as well."}}
{"actor":{"display_login":"jakewmeyer"}}