{"action":"created","issue":{"url":"https://api.github.com/repos/TryGhost/Ghost/issues/8983","repository_url":"https://api.github.com/repos/TryGhost/Ghost","labels_url":"https://api.github.com/repos/TryGhost/Ghost/issues/8983/labels{/name}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/8983/comments","events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/8983/events","html_url":"https://github.com/TryGhost/Ghost/pull/8983","id":255837331,"number":8983,"title":"ghost_head cleanup & debug statements","user":{"login":"ErisDS","id":101513,"avatar_url":"https://avatars1.githubusercontent.com/u/101513?v=4","gravatar_id":"","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"assignees":[{"login":"kirrg001","id":1160712,"avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-09-07T07:13:04Z","updated_at":"2017-09-07T10:49:41Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/8983","html_url":"https://github.com/TryGhost/Ghost/pull/8983","diff_url":"https://github.com/TryGhost/Ghost/pull/8983.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/8983.patch"},"body":"This adds 3 cleanup / minor change commits on top of the error handling PR #8982.\r\n\r\n- Adds a handful of debug statements, so it's easier to see where time is spent after rendering when in DEBUG mode.\r\n- Changes the layout of promises to always have the . on a newline, which makes it easier to read\r\n- Changes from using Promise.props to Promise.join, which allows us to remove a few lines of code that otherwise don't do much\r\n\r\nIt would be possible to squash and merge this instead of #8982, setting the commit message back to the error handling one."},"comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments/327764708","html_url":"https://github.com/TryGhost/Ghost/pull/8983#issuecomment-327764708","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/8983","id":327764708,"user":{"login":"ErisDS","id":101513,"avatar_url":"https://avatars1.githubusercontent.com/u/101513?v=4","gravatar_id":"","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false},"created_at":"2017-09-07T10:49:41Z","updated_at":"2017-09-07T10:49:41Z","author_association":"OWNER","body":"> It would be possible to squash and merge this instead of #8982, setting the commit message back to the error handling one.\r\n\r\nThis comment was if you merged this instead of #8982 as all 4 commits were here ;) Definitely squash this and give it a general message without an emoji!"}}
{"actor":{"display_login":"ErisDS"}}