{"action":"created","issue":{"url":"https://api.github.com/repos/ApiGen/ApiGen/issues/956","repository_url":"https://api.github.com/repos/ApiGen/ApiGen","labels_url":"https://api.github.com/repos/ApiGen/ApiGen/issues/956/labels{/name}","comments_url":"https://api.github.com/repos/ApiGen/ApiGen/issues/956/comments","events_url":"https://api.github.com/repos/ApiGen/ApiGen/issues/956/events","html_url":"https://github.com/ApiGen/ApiGen/pull/956","id":243638290,"number":956,"title":"Reflection: allowed nullable filenames","user":{"login":"vlastavesely","id":22521379,"avatar_url":"https://avatars2.githubusercontent.com/u/22521379?v=4","gravatar_id":"","url":"https://api.github.com/users/vlastavesely","html_url":"https://github.com/vlastavesely","followers_url":"https://api.github.com/users/vlastavesely/followers","following_url":"https://api.github.com/users/vlastavesely/following{/other_user}","gists_url":"https://api.github.com/users/vlastavesely/gists{/gist_id}","starred_url":"https://api.github.com/users/vlastavesely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlastavesely/subscriptions","organizations_url":"https://api.github.com/users/vlastavesely/orgs","repos_url":"https://api.github.com/users/vlastavesely/repos","events_url":"https://api.github.com/users/vlastavesely/events{/privacy}","received_events_url":"https://api.github.com/users/vlastavesely/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-18T08:28:28Z","updated_at":"2017-07-19T09:24:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ApiGen/ApiGen/pulls/956","html_url":"https://github.com/ApiGen/ApiGen/pull/956","diff_url":"https://github.com/ApiGen/ApiGen/pull/956.diff","patch_url":"https://github.com/ApiGen/ApiGen/pull/956.patch"},"body":"Output of `BetterReflection*::getFileName()` is nullable for internal PHP classes do not have source. We do not support generating API for PHP's internal classes but we need to. After it, current version would fail on type hint check."},"comment":{"url":"https://api.github.com/repos/ApiGen/ApiGen/issues/comments/316326290","html_url":"https://github.com/ApiGen/ApiGen/pull/956#issuecomment-316326290","issue_url":"https://api.github.com/repos/ApiGen/ApiGen/issues/956","id":316326290,"user":{"login":"vlastavesely","id":22521379,"avatar_url":"https://avatars2.githubusercontent.com/u/22521379?v=4","gravatar_id":"","url":"https://api.github.com/users/vlastavesely","html_url":"https://github.com/vlastavesely","followers_url":"https://api.github.com/users/vlastavesely/followers","following_url":"https://api.github.com/users/vlastavesely/following{/other_user}","gists_url":"https://api.github.com/users/vlastavesely/gists{/gist_id}","starred_url":"https://api.github.com/users/vlastavesely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlastavesely/subscriptions","organizations_url":"https://api.github.com/users/vlastavesely/orgs","repos_url":"https://api.github.com/users/vlastavesely/repos","events_url":"https://api.github.com/users/vlastavesely/events{/privacy}","received_events_url":"https://api.github.com/users/vlastavesely/received_events","type":"User","site_admin":false},"created_at":"2017-07-19T09:24:22Z","updated_at":"2017-07-19T09:24:22Z","body":">  I would not like to get to similar state, where they have own reflection api (InternalClassReflection, InternalClassMethodReflection etc.), generators and so on.\r\n\r\nNot even me. If it would be as hard, I would to skip it also. But I tried to add all parent classes and all interfaces implemented into `ReflectionStorage` and generate the API. For internal classes, nothing was broken (on the ones I tested) except the links to source codes. That should not be problem to fix.\r\n\r\nAnyway, for `BetterReflection's`functions can return `NULL` we should handle the possibility of it properly."}}
{"actor":{"display_login":"vlastavesely"}}