{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/32188","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/32188/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/32188/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/32188/events","html_url":"https://github.com/tgstation/tgstation/pull/32188","id":269314975,"number":32188,"title":"JSON feedback","user":{"login":"Jordie0608","id":4343468,"avatar_url":"https://avatars2.githubusercontent.com/u/4343468?v=4","gravatar_id":"","url":"https://api.github.com/users/Jordie0608","html_url":"https://github.com/Jordie0608","followers_url":"https://api.github.com/users/Jordie0608/followers","following_url":"https://api.github.com/users/Jordie0608/following{/other_user}","gists_url":"https://api.github.com/users/Jordie0608/gists{/gist_id}","starred_url":"https://api.github.com/users/Jordie0608/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jordie0608/subscriptions","organizations_url":"https://api.github.com/users/Jordie0608/orgs","repos_url":"https://api.github.com/users/Jordie0608/repos","events_url":"https://api.github.com/users/Jordie0608/events{/privacy}","received_events_url":"https://api.github.com/users/Jordie0608/received_events","type":"User","site_admin":false},"labels":[{"id":578922321,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Feedback","name":"Feedback","color":"0052cc","default":false},{"id":181676257,"url":"https://api.github.com/repos/tgstation/tgstation/labels/FUCK","name":"FUCK","color":"000000","default":false},{"id":380349558,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Refactor","name":"Refactor","color":"FF9933","default":false},{"id":634454568,"url":"https://api.github.com/repos/tgstation/tgstation/labels/SQL","name":"SQL","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars1.githubusercontent.com/u/7069733?v=4","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"assignees":[{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars1.githubusercontent.com/u/7069733?v=4","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-10-28T12:50:56Z","updated_at":"2017-11-14T00:29:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/32188","html_url":"https://github.com/tgstation/tgstation/pull/32188","diff_url":"https://github.com/tgstation/tgstation/pull/32188.diff","patch_url":"https://github.com/tgstation/tgstation/pull/32188.patch"},"body":"Replaces the string and int based feedback system with one that records data entirely in JSONs (LONGTEXT in Maria). For how this works see: https://github.com/Jordie0608/tgstation/blob/6ef229ddc4aa227b2f911def66b716bfa572fca2/code/controllers/subsystem/blackbox.dm#L129-L182\r\nThe blackbox subsystem no longer stores every radio message sent just to count how many there were and is updated to identify the current radio channels. The subsystem now stores the highest tech levels attained since everywhere else this is stored can be lost during the round, deleting the data.\r\n\r\nSome feedback keys have been changed or removed, a spreadsheet detailing all of these changes and notes pertaining to them can be found at: https://file.house/q7nI.ods\r\n\r\nDM side functionality tested to work. A couple of stat related fixes are scattered in, most being incorrect arguments being used.\r\n\r\nConversion of old data is done by a python script. As my first time in python it's not very pretty but I've tested that it handles all our feedback data as of 2017-10-23 01:34:06. Details on how it operates are in the script itself\r\n\r\n@nfreader \r\n@MrStonedOne"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/344105396","html_url":"https://github.com/tgstation/tgstation/pull/32188#issuecomment-344105396","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/32188","id":344105396,"user":{"login":"Jordie0608","id":4343468,"avatar_url":"https://avatars2.githubusercontent.com/u/4343468?v=4","gravatar_id":"","url":"https://api.github.com/users/Jordie0608","html_url":"https://github.com/Jordie0608","followers_url":"https://api.github.com/users/Jordie0608/followers","following_url":"https://api.github.com/users/Jordie0608/following{/other_user}","gists_url":"https://api.github.com/users/Jordie0608/gists{/gist_id}","starred_url":"https://api.github.com/users/Jordie0608/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jordie0608/subscriptions","organizations_url":"https://api.github.com/users/Jordie0608/orgs","repos_url":"https://api.github.com/users/Jordie0608/repos","events_url":"https://api.github.com/users/Jordie0608/events{/privacy}","received_events_url":"https://api.github.com/users/Jordie0608/received_events","type":"User","site_admin":false},"created_at":"2017-11-14T00:29:47Z","updated_at":"2017-11-14T00:29:47Z","author_association":"MEMBER","body":"Yes and some are also removed from current tracking or obsolete and no longer tracked at all."}}
{"actor":{"display_login":"Jordie0608"}}