{"action":"closed","issue":{"url":"https://api.github.com/repos/spesmilo/electrum/issues/2531","repository_url":"https://api.github.com/repos/spesmilo/electrum","labels_url":"https://api.github.com/repos/spesmilo/electrum/issues/2531/labels{/name}","comments_url":"https://api.github.com/repos/spesmilo/electrum/issues/2531/comments","events_url":"https://api.github.com/repos/spesmilo/electrum/issues/2531/events","html_url":"https://github.com/spesmilo/electrum/issues/2531","id":236724272,"number":2531,"title":"Generating DMG package from OSX fails because make_packages","user":{"login":"ottodevs","id":5030059,"avatar_url":"https://avatars2.githubusercontent.com/u/5030059?v=4","gravatar_id":"","url":"https://api.github.com/users/ottodevs","html_url":"https://github.com/ottodevs","followers_url":"https://api.github.com/users/ottodevs/followers","following_url":"https://api.github.com/users/ottodevs/following{/other_user}","gists_url":"https://api.github.com/users/ottodevs/gists{/gist_id}","starred_url":"https://api.github.com/users/ottodevs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottodevs/subscriptions","organizations_url":"https://api.github.com/users/ottodevs/orgs","repos_url":"https://api.github.com/users/ottodevs/repos","events_url":"https://api.github.com/users/ottodevs/events{/privacy}","received_events_url":"https://api.github.com/users/ottodevs/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-18T14:27:43Z","updated_at":"2017-08-30T10:23:21Z","closed_at":"2017-08-30T10:23:21Z","author_association":"NONE","body":"make_packages use of function imp.find_module() does not find the right path for modules, so it fails complaining about a \"module not find\" error, making imposible to generate the DMG install package.\r\n\r\nI looked into python documentation and it says you can pass module name + optional path as imp.find_module arguments, maybe we can solve the problem just pointing to the right path?\r\n(I verified that I have all modules installed by pip, I also tried with a python virtual env without success...)\r\n\r\nSince I am not python insights expert I would like to receive some help to fix this problem, not only for electrum BTC, but for every altcoin electrum forks that have the same problems.\r\n\r\nThanks in advance.\r\n\r\nSteps to reproduce:\r\nJust clone the repo from osx and try to execute `python contrib/make_package` from project folder\r\n\r\nAffected code block (find_module from imp):\r\n```\r\n    for module in deps:\r\n        f, pathname, descr = imp.find_module(module)\r\n        target = 'packages/' + module + descr[0]\r\n        if os.path.exists(target):\r\n            continue\r\n        d = os.path.dirname(target)\r\n        if d and not (os.path.exists(d)):\r\n            os.makedirs(d)\r\n        if descr[0]:\r\n            shutil.copy(pathname, target)\r\n        else:\r\n            shutil.copytree(pathname, target, ignore=shutil.ignore_patterns('*.pyc'))\r\n```"}}
{"actor":{"display_login":"ecdsa"}}