{"action":"opened","issue":{"url":"https://api.github.com/repos/plerup/makeEspArduino/issues/50","repository_url":"https://api.github.com/repos/plerup/makeEspArduino","labels_url":"https://api.github.com/repos/plerup/makeEspArduino/issues/50/labels{/name}","comments_url":"https://api.github.com/repos/plerup/makeEspArduino/issues/50/comments","events_url":"https://api.github.com/repos/plerup/makeEspArduino/issues/50/events","html_url":"https://github.com/plerup/makeEspArduino/issues/50","id":255220411,"number":50,"title":"Adding all sourcefiles in Sketch directory when LIBS variable is not defined","user":{"login":"Juanjbb","id":3214400,"avatar_url":"https://avatars1.githubusercontent.com/u/3214400?v=4","gravatar_id":"","url":"https://api.github.com/users/Juanjbb","html_url":"https://github.com/Juanjbb","followers_url":"https://api.github.com/users/Juanjbb/followers","following_url":"https://api.github.com/users/Juanjbb/following{/other_user}","gists_url":"https://api.github.com/users/Juanjbb/gists{/gist_id}","starred_url":"https://api.github.com/users/Juanjbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juanjbb/subscriptions","organizations_url":"https://api.github.com/users/Juanjbb/orgs","repos_url":"https://api.github.com/users/Juanjbb/repos","events_url":"https://api.github.com/users/Juanjbb/events{/privacy}","received_events_url":"https://api.github.com/users/Juanjbb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-05T09:49:16Z","updated_at":"2017-09-05T09:49:16Z","closed_at":null,"author_association":"NONE","body":"Thanks for such a great tool!\r\nI want to have my own folder structure and I was tweaking the Makefile a little bit, just found a small issue when the LIBS variable is empty:\r\n\r\nifneq ($(LIBS),)\r\n\tUSER_SRC := $(SKETCH) $(filter-out $(IGNORE_PATTERN),$(shell find $(dir $(LIBS)) -name \"*.S\" -o -name \"*.c\" -o -name \"*.cpp\"))\r\nelse\r\n\tUSER_SRC := $(SKETCH)\r\nendif\r\n\r\nWhen LIBS variable is empty (which was my case), it tries to compile all source files under the Makefile directory. So I added a simple check to assure it is not empty. "}}
{"actor":{"display_login":"Juanjbb"}}