{"action":"created","comment":{"url":"https://api.github.com/repos/sourcegraph/vscode/pulls/comments/100160004","pull_request_review_id":20856368,"id":100160004,"diff_hunk":"@@ -392,7 +392,7 @@ export interface ReferenceProvider {\n \t/**\n \t * Provide a set of project-wide references for the given position and document.\n \t */\n-\tprovideReferences(model: editorCommon.IReadOnlyModel, position: Position, context: ReferenceContext, token: CancellationToken): Location[] | Thenable<Location[]>;\n+\tprovideReferences(model: editorCommon.IReadOnlyModel, position: Position, context: ReferenceContext, progress: (value: Location) => void, token: CancellationToken): Location[] | Thenable<Location[]>;","path":"src/vs/editor/common/modes.ts","position":5,"original_position":5,"commit_id":"fdb48b853513493c53e3dc6beb881d717b6de76e","original_commit_id":"fdb48b853513493c53e3dc6beb881d717b6de76e","user":{"login":"felixfbecker","id":10532611,"avatar_url":"https://avatars.githubusercontent.com/u/10532611?v=3","gravatar_id":"","url":"https://api.github.com/users/felixfbecker","html_url":"https://github.com/felixfbecker","followers_url":"https://api.github.com/users/felixfbecker/followers","following_url":"https://api.github.com/users/felixfbecker/following{/other_user}","gists_url":"https://api.github.com/users/felixfbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfbecker/subscriptions","organizations_url":"https://api.github.com/users/felixfbecker/orgs","repos_url":"https://api.github.com/users/felixfbecker/repos","events_url":"https://api.github.com/users/felixfbecker/events{/privacy}","received_events_url":"https://api.github.com/users/felixfbecker/received_events","type":"User","site_admin":false},"body":"@sqs MS was against adding progress to the Promise type and I agree with them, it opens up all kinds of questions about chaining","created_at":"2017-02-08T20:17:21Z","updated_at":"2017-02-08T20:32:32Z","html_url":"https://github.com/sourcegraph/vscode/pull/1#discussion_r100160004","pull_request_url":"https://api.github.com/repos/sourcegraph/vscode/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/vscode/pulls/comments/100160004"},"html":{"href":"https://github.com/sourcegraph/vscode/pull/1#discussion_r100160004"},"pull_request":{"href":"https://api.github.com/repos/sourcegraph/vscode/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/sourcegraph/vscode/pulls/1","id":105283356,"html_url":"https://github.com/sourcegraph/vscode/pull/1","diff_url":"https://github.com/sourcegraph/vscode/pull/1.diff","patch_url":"https://github.com/sourcegraph/vscode/pull/1.patch","issue_url":"https://api.github.com/repos/sourcegraph/vscode/issues/1","number":1,"state":"open","locked":false,"title":"Stream references","user":{"login":"nicksnyder","id":754768,"avatar_url":"https://avatars.githubusercontent.com/u/754768?v=3","gravatar_id":"","url":"https://api.github.com/users/nicksnyder","html_url":"https://github.com/nicksnyder","followers_url":"https://api.github.com/users/nicksnyder/followers","following_url":"https://api.github.com/users/nicksnyder/following{/other_user}","gists_url":"https://api.github.com/users/nicksnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksnyder/subscriptions","organizations_url":"https://api.github.com/users/nicksnyder/orgs","repos_url":"https://api.github.com/users/nicksnyder/repos","events_url":"https://api.github.com/users/nicksnyder/events{/privacy}","received_events_url":"https://api.github.com/users/nicksnyder/received_events","type":"User","site_admin":false},"body":"This is a dummy pull request for us to review before we make an actual PR to microsoft/vscode.\r\n\r\nIt includes an extension that mocks a language server to test the logic. This extension probably won't be included in the actual PR to microsoft/vscode.","created_at":"2017-02-08T19:08:57Z","updated_at":"2017-02-08T20:32:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"291bf16952c94cd67c09815faf38fb59180e5d13","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sourcegraph/vscode/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sourcegraph/vscode/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sourcegraph/vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcegraph/vscode/issues/1/comments","statuses_url":"https://api.github.com/repos/sourcegraph/vscode/statuses/fdb48b853513493c53e3dc6beb881d717b6de76e","head":{"label":"sourcegraph:streamref","ref":"streamref","sha":"fdb48b853513493c53e3dc6beb881d717b6de76e","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":80780287,"name":"vscode","full_name":"sourcegraph/vscode","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/vscode","description":"Visual Studio Code","fork":true,"url":"https://api.github.com/repos/sourcegraph/vscode","forks_url":"https://api.github.com/repos/sourcegraph/vscode/forks","keys_url":"https://api.github.com/repos/sourcegraph/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/vscode/teams","hooks_url":"https://api.github.com/repos/sourcegraph/vscode/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/vscode/events","assignees_url":"https://api.github.com/repos/sourcegraph/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/vscode/tags","blobs_url":"https://api.github.com/repos/sourcegraph/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/vscode/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/vscode/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/vscode/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/vscode/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/vscode/subscription","commits_url":"https://api.github.com/repos/sourcegraph/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/vscode/merges","archive_url":"https://api.github.com/repos/sourcegraph/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/vscode/downloads","issues_url":"https://api.github.com/repos/sourcegraph/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/vscode/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/vscode/deployments","created_at":"2017-02-02T23:47:00Z","updated_at":"2017-02-03T16:44:02Z","pushed_at":"2017-02-08T20:15:25Z","git_url":"git://github.com/sourcegraph/vscode.git","ssh_url":"git@github.com:sourcegraph/vscode.git","clone_url":"https://github.com/sourcegraph/vscode.git","svn_url":"https://github.com/sourcegraph/vscode","homepage":"http://code.visualstudio.com","size":62595,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"sourcegraph:master","ref":"master","sha":"53cbf40759a295c3b399806f37dd40e79f3e15e9","user":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"repo":{"id":80780287,"name":"vscode","full_name":"sourcegraph/vscode","owner":{"login":"sourcegraph","id":3979584,"avatar_url":"https://avatars.githubusercontent.com/u/3979584?v=3","gravatar_id":"","url":"https://api.github.com/users/sourcegraph","html_url":"https://github.com/sourcegraph","followers_url":"https://api.github.com/users/sourcegraph/followers","following_url":"https://api.github.com/users/sourcegraph/following{/other_user}","gists_url":"https://api.github.com/users/sourcegraph/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcegraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcegraph/subscriptions","organizations_url":"https://api.github.com/users/sourcegraph/orgs","repos_url":"https://api.github.com/users/sourcegraph/repos","events_url":"https://api.github.com/users/sourcegraph/events{/privacy}","received_events_url":"https://api.github.com/users/sourcegraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcegraph/vscode","description":"Visual Studio Code","fork":true,"url":"https://api.github.com/repos/sourcegraph/vscode","forks_url":"https://api.github.com/repos/sourcegraph/vscode/forks","keys_url":"https://api.github.com/repos/sourcegraph/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcegraph/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcegraph/vscode/teams","hooks_url":"https://api.github.com/repos/sourcegraph/vscode/hooks","issue_events_url":"https://api.github.com/repos/sourcegraph/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/sourcegraph/vscode/events","assignees_url":"https://api.github.com/repos/sourcegraph/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/sourcegraph/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/sourcegraph/vscode/tags","blobs_url":"https://api.github.com/repos/sourcegraph/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcegraph/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcegraph/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcegraph/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcegraph/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcegraph/vscode/languages","stargazers_url":"https://api.github.com/repos/sourcegraph/vscode/stargazers","contributors_url":"https://api.github.com/repos/sourcegraph/vscode/contributors","subscribers_url":"https://api.github.com/repos/sourcegraph/vscode/subscribers","subscription_url":"https://api.github.com/repos/sourcegraph/vscode/subscription","commits_url":"https://api.github.com/repos/sourcegraph/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcegraph/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcegraph/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcegraph/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcegraph/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/sourcegraph/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcegraph/vscode/merges","archive_url":"https://api.github.com/repos/sourcegraph/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcegraph/vscode/downloads","issues_url":"https://api.github.com/repos/sourcegraph/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/sourcegraph/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcegraph/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcegraph/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcegraph/vscode/labels{/name}","releases_url":"https://api.github.com/repos/sourcegraph/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/sourcegraph/vscode/deployments","created_at":"2017-02-02T23:47:00Z","updated_at":"2017-02-03T16:44:02Z","pushed_at":"2017-02-08T20:15:25Z","git_url":"git://github.com/sourcegraph/vscode.git","ssh_url":"git@github.com:sourcegraph/vscode.git","clone_url":"https://github.com/sourcegraph/vscode.git","svn_url":"https://github.com/sourcegraph/vscode","homepage":"http://code.visualstudio.com","size":62595,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcegraph/vscode/pulls/1"},"html":{"href":"https://github.com/sourcegraph/vscode/pull/1"},"issue":{"href":"https://api.github.com/repos/sourcegraph/vscode/issues/1"},"comments":{"href":"https://api.github.com/repos/sourcegraph/vscode/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcegraph/vscode/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcegraph/vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcegraph/vscode/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sourcegraph/vscode/statuses/fdb48b853513493c53e3dc6beb881d717b6de76e"}}}}
{"actor":{"display_login":"felixfbecker"}}