{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/29245","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/29245/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/29245/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/29245/events","html_url":"https://github.com/Microsoft/vscode/issues/29245","id":237732504,"number":29245,"title":"Debug: make launching multi root folder aware","user":{"login":"bpasero","id":900690,"avatar_url":"https://avatars3.githubusercontent.com/u/900690?v=4","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"labels":[{"id":291054922,"url":"https://api.github.com/repos/Microsoft/vscode/labels/debug","name":"debug","color":"1d76db","default":false},{"id":535120898,"url":"https://api.github.com/repos/Microsoft/vscode/labels/multi-root","name":"multi-root","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":{"login":"weinand","id":1898161,"avatar_url":"https://avatars0.githubusercontent.com/u/1898161?v=4","gravatar_id":"","url":"https://api.github.com/users/weinand","html_url":"https://github.com/weinand","followers_url":"https://api.github.com/users/weinand/followers","following_url":"https://api.github.com/users/weinand/following{/other_user}","gists_url":"https://api.github.com/users/weinand/gists{/gist_id}","starred_url":"https://api.github.com/users/weinand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weinand/subscriptions","organizations_url":"https://api.github.com/users/weinand/orgs","repos_url":"https://api.github.com/users/weinand/repos","events_url":"https://api.github.com/users/weinand/events{/privacy}","received_events_url":"https://api.github.com/users/weinand/received_events","type":"User","site_admin":false},"assignees":[{"login":"weinand","id":1898161,"avatar_url":"https://avatars0.githubusercontent.com/u/1898161?v=4","gravatar_id":"","url":"https://api.github.com/users/weinand","html_url":"https://github.com/weinand","followers_url":"https://api.github.com/users/weinand/followers","following_url":"https://api.github.com/users/weinand/following{/other_user}","gists_url":"https://api.github.com/users/weinand/gists{/gist_id}","starred_url":"https://api.github.com/users/weinand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weinand/subscriptions","organizations_url":"https://api.github.com/users/weinand/orgs","repos_url":"https://api.github.com/users/weinand/repos","events_url":"https://api.github.com/users/weinand/events{/privacy}","received_events_url":"https://api.github.com/users/weinand/received_events","type":"User","site_admin":false},{"login":"isidorn","id":1926584,"avatar_url":"https://avatars2.githubusercontent.com/u/1926584?v=4","gravatar_id":"","url":"https://api.github.com/users/isidorn","html_url":"https://github.com/isidorn","followers_url":"https://api.github.com/users/isidorn/followers","following_url":"https://api.github.com/users/isidorn/following{/other_user}","gists_url":"https://api.github.com/users/isidorn/gists{/gist_id}","starred_url":"https://api.github.com/users/isidorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isidorn/subscriptions","organizations_url":"https://api.github.com/users/isidorn/orgs","repos_url":"https://api.github.com/users/isidorn/repos","events_url":"https://api.github.com/users/isidorn/events{/privacy}","received_events_url":"https://api.github.com/users/isidorn/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/46","html_url":"https://github.com/Microsoft/vscode/milestone/46","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/46/labels","id":2582711,"number":46,"title":"July 2017","description":"","creator":{"login":"bpasero","id":900690,"avatar_url":"https://avatars3.githubusercontent.com/u/900690?v=4","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"open_issues":185,"closed_issues":254,"state":"open","created_at":"2017-06-14T13:05:53Z","updated_at":"2017-07-20T14:58:15Z","due_on":"2017-07-31T07:00:00Z","closed_at":null},"comments":6,"created_at":"2017-06-22T05:01:58Z","updated_at":"2017-07-20T14:58:30Z","closed_at":null,"body":"Today we seem to collect the launch.json from the single root workspace here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/electron-browser/debugConfigurationManager.ts#L345\r\n\r\nIn a multi root environment we need to change this assumption. There are a couple of options:\r\n* just take the first folders configuration and show the others from a picker (e.g. add a \"More...\" command to the debug dropdown which opens a picker)\r\n* track the active file and then use that files workspace as default when checking for the config file (there is `IHistoryService.getLastActiveWorkspaceRoot()` to help out)\r\n* just treat all folders the same and collect configs from all folders and merge them into one list\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/316730135","html_url":"https://github.com/Microsoft/vscode/issues/29245#issuecomment-316730135","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/29245","id":316730135,"user":{"login":"bpasero","id":900690,"avatar_url":"https://avatars3.githubusercontent.com/u/900690?v=4","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"created_at":"2017-07-20T14:58:30Z","updated_at":"2017-07-20T14:58:30Z","body":"@isidorn makes sense, I think on top of that we discussed:\r\n* to show the folder from which a config is from in the dropdown to avoid name clashes\r\n* to pick a fixed number of configs from one of the folders (the first?) if no MRU list exists yet"}}
{"actor":{"display_login":"bpasero"}}