{"action":"created","comment":{"url":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/comments/112294238","pull_request_review_id":33591280,"id":112294238,"diff_hunk":"@@ -26,22 +26,23 @@\n     \"lint\": \"eslint . && jscs index.js bin/ lib/ test/\",\n     \"prepublish\": \"marked-man --name gulp docs/CLI.md > gulp.1\",\n     \"pretest\": \"npm run lint\",\n-    \"test\": \"mocha --async-only --timeout 3000\",\n+    \"test\": \"mocha --async-only --timeout 3000 test/lib test\",\n     \"cover\": \"nyc --reporter=lcov --reporter=text-summary npm test\",\n     \"coveralls\": \"nyc --reporter=text-lcov npm test | coveralls\",\n     \"changelog\": \"github-changes -o gulpjs -r gulp-cli -b master -f ./CHANGELOG.md --order-semver --use-commit-body\"\n   },\n   \"dependencies\": {\n     \"archy\": \"^1.0.0\",\n+    \"camelcase\": \"^3.0.0\",","path":"package.json","position":12,"original_position":12,"commit_id":"298426599884f8241d0ab8e31a89540539ff1add","original_commit_id":"298426599884f8241d0ab8e31a89540539ff1add","user":{"login":"phated","id":992373,"avatar_url":"https://avatars1.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"body":"This can be removed when `excludeCliArgs` is removed.","created_at":"2017-04-19T19:34:08Z","updated_at":"2017-04-19T19:37:00Z","html_url":"https://github.com/gulpjs/gulp-cli/pull/94#discussion_r112294238","pull_request_url":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/comments/112294238"},"html":{"href":"https://github.com/gulpjs/gulp-cli/pull/94#discussion_r112294238"},"pull_request":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/94","id":83925943,"html_url":"https://github.com/gulpjs/gulp-cli/pull/94","diff_url":"https://github.com/gulpjs/gulp-cli/pull/94.diff","patch_url":"https://github.com/gulpjs/gulp-cli/pull/94.patch","issue_url":"https://api.github.com/repos/gulpjs/gulp-cli/issues/94","number":94,"state":"open","locked":false,"title":"Restrict config properties (Implementation for Issue #92)","user":{"login":"sttk","id":8656098,"avatar_url":"https://avatars3.githubusercontent.com/u/8656098?v=3","gravatar_id":"","url":"https://api.github.com/users/sttk","html_url":"https://github.com/sttk","followers_url":"https://api.github.com/users/sttk/followers","following_url":"https://api.github.com/users/sttk/following{/other_user}","gists_url":"https://api.github.com/users/sttk/gists{/gist_id}","starred_url":"https://api.github.com/users/sttk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttk/subscriptions","organizations_url":"https://api.github.com/users/sttk/orgs","repos_url":"https://api.github.com/users/sttk/repos","events_url":"https://api.github.com/users/sttk/events{/privacy}","received_events_url":"https://api.github.com/users/sttk/received_events","type":"User","site_admin":false},"body":"This PR is for the issue #92.\n\n I only implemented about the properties: `description`, `flags.help`, and `flags.gulpfile` first. \n\nThe points that I modified from #90 are as follows:\n1. Config properties by cli-flags take precedence over them by config files.\n   \n   I made a mistake  in the previous implementation to merge properties of config files over `opts` properties, so config files took precedence over command line flags. I modified it. \n   \n   Since it would be confusing to control to change or not `opts` properties at the time of merging, the current code evacuates `opts` properties specified by cli-flags before merging, merge with config by config files, and merge with the evacuated properties at the end.\n2. Add an object `disp` for display settings.\n   \n   This object is used for outputing description for gulpfile and will be used for various display configurations.\n   \n   For this object, the api of the versioned cli modules in `lib/versioned/*/index.js` are added 3rd argument.\n3. Add validations for config properties of each config file.\n   \n   And if a validation fails, outputs the error and quits immediately. \n4. Add convert for config properties of each config file.\n   \n   Because it is needed to convert a property value into an absolute path with a base directory path if the property value is a path string.\n5. Add `env` to the merged targets because `env.cwd`, `env.configPath` and `env.require` are used for configuration of cwd, gulpfile and require.\n","created_at":"2016-09-04T15:33:09Z","updated_at":"2017-04-19T19:37:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e301b7538165e84c9b6d2605eb1486d65abb538","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/94/commits","review_comments_url":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/94/comments","review_comment_url":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gulpjs/gulp-cli/issues/94/comments","statuses_url":"https://api.github.com/repos/gulpjs/gulp-cli/statuses/298426599884f8241d0ab8e31a89540539ff1add","head":{"label":"sttk:restrict_config_props","ref":"restrict_config_props","sha":"298426599884f8241d0ab8e31a89540539ff1add","user":{"login":"sttk","id":8656098,"avatar_url":"https://avatars3.githubusercontent.com/u/8656098?v=3","gravatar_id":"","url":"https://api.github.com/users/sttk","html_url":"https://github.com/sttk","followers_url":"https://api.github.com/users/sttk/followers","following_url":"https://api.github.com/users/sttk/following{/other_user}","gists_url":"https://api.github.com/users/sttk/gists{/gist_id}","starred_url":"https://api.github.com/users/sttk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttk/subscriptions","organizations_url":"https://api.github.com/users/sttk/orgs","repos_url":"https://api.github.com/users/sttk/repos","events_url":"https://api.github.com/users/sttk/events{/privacy}","received_events_url":"https://api.github.com/users/sttk/received_events","type":"User","site_admin":false},"repo":{"id":47755454,"name":"gulp-cli","full_name":"sttk/gulp-cli","owner":{"login":"sttk","id":8656098,"avatar_url":"https://avatars3.githubusercontent.com/u/8656098?v=3","gravatar_id":"","url":"https://api.github.com/users/sttk","html_url":"https://github.com/sttk","followers_url":"https://api.github.com/users/sttk/followers","following_url":"https://api.github.com/users/sttk/following{/other_user}","gists_url":"https://api.github.com/users/sttk/gists{/gist_id}","starred_url":"https://api.github.com/users/sttk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttk/subscriptions","organizations_url":"https://api.github.com/users/sttk/orgs","repos_url":"https://api.github.com/users/sttk/repos","events_url":"https://api.github.com/users/sttk/events{/privacy}","received_events_url":"https://api.github.com/users/sttk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sttk/gulp-cli","description":"CLI for gulp","fork":true,"url":"https://api.github.com/repos/sttk/gulp-cli","forks_url":"https://api.github.com/repos/sttk/gulp-cli/forks","keys_url":"https://api.github.com/repos/sttk/gulp-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sttk/gulp-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sttk/gulp-cli/teams","hooks_url":"https://api.github.com/repos/sttk/gulp-cli/hooks","issue_events_url":"https://api.github.com/repos/sttk/gulp-cli/issues/events{/number}","events_url":"https://api.github.com/repos/sttk/gulp-cli/events","assignees_url":"https://api.github.com/repos/sttk/gulp-cli/assignees{/user}","branches_url":"https://api.github.com/repos/sttk/gulp-cli/branches{/branch}","tags_url":"https://api.github.com/repos/sttk/gulp-cli/tags","blobs_url":"https://api.github.com/repos/sttk/gulp-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sttk/gulp-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sttk/gulp-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/sttk/gulp-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sttk/gulp-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/sttk/gulp-cli/languages","stargazers_url":"https://api.github.com/repos/sttk/gulp-cli/stargazers","contributors_url":"https://api.github.com/repos/sttk/gulp-cli/contributors","subscribers_url":"https://api.github.com/repos/sttk/gulp-cli/subscribers","subscription_url":"https://api.github.com/repos/sttk/gulp-cli/subscription","commits_url":"https://api.github.com/repos/sttk/gulp-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/sttk/gulp-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/sttk/gulp-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/sttk/gulp-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/sttk/gulp-cli/contents/{+path}","compare_url":"https://api.github.com/repos/sttk/gulp-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sttk/gulp-cli/merges","archive_url":"https://api.github.com/repos/sttk/gulp-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sttk/gulp-cli/downloads","issues_url":"https://api.github.com/repos/sttk/gulp-cli/issues{/number}","pulls_url":"https://api.github.com/repos/sttk/gulp-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/sttk/gulp-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/sttk/gulp-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sttk/gulp-cli/labels{/name}","releases_url":"https://api.github.com/repos/sttk/gulp-cli/releases{/id}","deployments_url":"https://api.github.com/repos/sttk/gulp-cli/deployments","created_at":"2015-12-10T10:42:41Z","updated_at":"2016-04-05T14:01:54Z","pushed_at":"2017-04-02T08:14:03Z","git_url":"git://github.com/sttk/gulp-cli.git","ssh_url":"git@github.com:sttk/gulp-cli.git","clone_url":"https://github.com/sttk/gulp-cli.git","svn_url":"https://github.com/sttk/gulp-cli","homepage":null,"size":204,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gulpjs:master","ref":"master","sha":"f3b4d7ede06b9a41c2cdc5cf9fcccf2c1f4b67fa","user":{"login":"gulpjs","id":6200624,"avatar_url":"https://avatars3.githubusercontent.com/u/6200624?v=3","gravatar_id":"","url":"https://api.github.com/users/gulpjs","html_url":"https://github.com/gulpjs","followers_url":"https://api.github.com/users/gulpjs/followers","following_url":"https://api.github.com/users/gulpjs/following{/other_user}","gists_url":"https://api.github.com/users/gulpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gulpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulpjs/subscriptions","organizations_url":"https://api.github.com/users/gulpjs/orgs","repos_url":"https://api.github.com/users/gulpjs/repos","events_url":"https://api.github.com/users/gulpjs/events{/privacy}","received_events_url":"https://api.github.com/users/gulpjs/received_events","type":"Organization","site_admin":false},"repo":{"id":28062827,"name":"gulp-cli","full_name":"gulpjs/gulp-cli","owner":{"login":"gulpjs","id":6200624,"avatar_url":"https://avatars3.githubusercontent.com/u/6200624?v=3","gravatar_id":"","url":"https://api.github.com/users/gulpjs","html_url":"https://github.com/gulpjs","followers_url":"https://api.github.com/users/gulpjs/followers","following_url":"https://api.github.com/users/gulpjs/following{/other_user}","gists_url":"https://api.github.com/users/gulpjs/gists{/gist_id}","starred_url":"https://api.github.com/users/gulpjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulpjs/subscriptions","organizations_url":"https://api.github.com/users/gulpjs/orgs","repos_url":"https://api.github.com/users/gulpjs/repos","events_url":"https://api.github.com/users/gulpjs/events{/privacy}","received_events_url":"https://api.github.com/users/gulpjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gulpjs/gulp-cli","description":"CLI for gulp","fork":false,"url":"https://api.github.com/repos/gulpjs/gulp-cli","forks_url":"https://api.github.com/repos/gulpjs/gulp-cli/forks","keys_url":"https://api.github.com/repos/gulpjs/gulp-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gulpjs/gulp-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gulpjs/gulp-cli/teams","hooks_url":"https://api.github.com/repos/gulpjs/gulp-cli/hooks","issue_events_url":"https://api.github.com/repos/gulpjs/gulp-cli/issues/events{/number}","events_url":"https://api.github.com/repos/gulpjs/gulp-cli/events","assignees_url":"https://api.github.com/repos/gulpjs/gulp-cli/assignees{/user}","branches_url":"https://api.github.com/repos/gulpjs/gulp-cli/branches{/branch}","tags_url":"https://api.github.com/repos/gulpjs/gulp-cli/tags","blobs_url":"https://api.github.com/repos/gulpjs/gulp-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gulpjs/gulp-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gulpjs/gulp-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/gulpjs/gulp-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gulpjs/gulp-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/gulpjs/gulp-cli/languages","stargazers_url":"https://api.github.com/repos/gulpjs/gulp-cli/stargazers","contributors_url":"https://api.github.com/repos/gulpjs/gulp-cli/contributors","subscribers_url":"https://api.github.com/repos/gulpjs/gulp-cli/subscribers","subscription_url":"https://api.github.com/repos/gulpjs/gulp-cli/subscription","commits_url":"https://api.github.com/repos/gulpjs/gulp-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/gulpjs/gulp-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/gulpjs/gulp-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/gulpjs/gulp-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/gulpjs/gulp-cli/contents/{+path}","compare_url":"https://api.github.com/repos/gulpjs/gulp-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gulpjs/gulp-cli/merges","archive_url":"https://api.github.com/repos/gulpjs/gulp-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gulpjs/gulp-cli/downloads","issues_url":"https://api.github.com/repos/gulpjs/gulp-cli/issues{/number}","pulls_url":"https://api.github.com/repos/gulpjs/gulp-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/gulpjs/gulp-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/gulpjs/gulp-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gulpjs/gulp-cli/labels{/name}","releases_url":"https://api.github.com/repos/gulpjs/gulp-cli/releases{/id}","deployments_url":"https://api.github.com/repos/gulpjs/gulp-cli/deployments","created_at":"2014-12-16T00:25:41Z","updated_at":"2017-04-17T22:50:18Z","pushed_at":"2017-03-02T17:25:55Z","git_url":"git://github.com/gulpjs/gulp-cli.git","ssh_url":"git@github.com:gulpjs/gulp-cli.git","clone_url":"https://github.com/gulpjs/gulp-cli.git","svn_url":"https://github.com/gulpjs/gulp-cli","homepage":null,"size":159,"stargazers_count":149,"watchers_count":149,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":15,"forks":52,"open_issues":15,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/94"},"html":{"href":"https://github.com/gulpjs/gulp-cli/pull/94"},"issue":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/issues/94"},"comments":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/gulpjs/gulp-cli/statuses/298426599884f8241d0ab8e31a89540539ff1add"}}}}
{"actor":{"display_login":"phated"}}