{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/101467766","pull_request_review_id":22196153,"id":101467766,"diff_hunk":"@@ -173,6 +173,15 @@ func runStart(cmd *cobra.Command, args []string) {\n \t\tos.Setenv(k, v)\n \t}\n \n+\t//Create the host directories if not present\n+\thostDirs := []string{viper.GetString(hostConfigDir), viper.GetString(hostDataDir), viper.GetString(hostVolumesDir)}\n+\terr = cluster.EnsureHostDirectories(libMachineClient, hostDirs)","path":"cmd/minikube/cmd/start.go","position":26,"original_position":26,"commit_id":"6ac702fc57a7773622ce294a100a01aa6dd0d8b3","original_commit_id":"6ac702fc57a7773622ce294a100a01aa6dd0d8b3","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars.githubusercontent.com/u/1894?v=3","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"body":"On a sidr note, we only need to create the host volume folder, but for completeness we do all.\r\n\r\nI agree with the naming. When reviewing just now I had the same problem. It does not read well, as the intention is lost/missing.","created_at":"2017-02-16T08:44:02Z","updated_at":"2017-02-16T08:44:02Z","html_url":"https://github.com/minishift/minishift/pull/399#discussion_r101467766","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/399","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/101467766"},"html":{"href":"https://github.com/minishift/minishift/pull/399#discussion_r101467766"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/399"}}},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/399","id":106070669,"html_url":"https://github.com/minishift/minishift/pull/399","diff_url":"https://github.com/minishift/minishift/pull/399.diff","patch_url":"https://github.com/minishift/minishift/pull/399.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/399","number":399,"state":"open","locked":false,"title":"[WIP] Issue #355 Use persistent vol for host-volumes-dir","user":{"login":"LalatenduMohanty","id":3125299,"avatar_url":"https://avatars.githubusercontent.com/u/3125299?v=3","gravatar_id":"","url":"https://api.github.com/users/LalatenduMohanty","html_url":"https://github.com/LalatenduMohanty","followers_url":"https://api.github.com/users/LalatenduMohanty/followers","following_url":"https://api.github.com/users/LalatenduMohanty/following{/other_user}","gists_url":"https://api.github.com/users/LalatenduMohanty/gists{/gist_id}","starred_url":"https://api.github.com/users/LalatenduMohanty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LalatenduMohanty/subscriptions","organizations_url":"https://api.github.com/users/LalatenduMohanty/orgs","repos_url":"https://api.github.com/users/LalatenduMohanty/repos","events_url":"https://api.github.com/users/LalatenduMohanty/events{/privacy}","received_events_url":"https://api.github.com/users/LalatenduMohanty/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>","created_at":"2017-02-14T10:00:28Z","updated_at":"2017-02-16T08:44:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb806679efa171bf24f94b380490adeb654de038","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/399/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/399/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/399/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/6ac702fc57a7773622ce294a100a01aa6dd0d8b3","head":{"label":"LalatenduMohanty:issue-355","ref":"issue-355","sha":"6ac702fc57a7773622ce294a100a01aa6dd0d8b3","user":{"login":"LalatenduMohanty","id":3125299,"avatar_url":"https://avatars.githubusercontent.com/u/3125299?v=3","gravatar_id":"","url":"https://api.github.com/users/LalatenduMohanty","html_url":"https://github.com/LalatenduMohanty","followers_url":"https://api.github.com/users/LalatenduMohanty/followers","following_url":"https://api.github.com/users/LalatenduMohanty/following{/other_user}","gists_url":"https://api.github.com/users/LalatenduMohanty/gists{/gist_id}","starred_url":"https://api.github.com/users/LalatenduMohanty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LalatenduMohanty/subscriptions","organizations_url":"https://api.github.com/users/LalatenduMohanty/orgs","repos_url":"https://api.github.com/users/LalatenduMohanty/repos","events_url":"https://api.github.com/users/LalatenduMohanty/events{/privacy}","received_events_url":"https://api.github.com/users/LalatenduMohanty/received_events","type":"User","site_admin":false},"repo":{"id":68187657,"name":"minishift","full_name":"LalatenduMohanty/minishift","owner":{"login":"LalatenduMohanty","id":3125299,"avatar_url":"https://avatars.githubusercontent.com/u/3125299?v=3","gravatar_id":"","url":"https://api.github.com/users/LalatenduMohanty","html_url":"https://github.com/LalatenduMohanty","followers_url":"https://api.github.com/users/LalatenduMohanty/followers","following_url":"https://api.github.com/users/LalatenduMohanty/following{/other_user}","gists_url":"https://api.github.com/users/LalatenduMohanty/gists{/gist_id}","starred_url":"https://api.github.com/users/LalatenduMohanty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LalatenduMohanty/subscriptions","organizations_url":"https://api.github.com/users/LalatenduMohanty/orgs","repos_url":"https://api.github.com/users/LalatenduMohanty/repos","events_url":"https://api.github.com/users/LalatenduMohanty/events{/privacy}","received_events_url":"https://api.github.com/users/LalatenduMohanty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LalatenduMohanty/minishift","description":null,"fork":true,"url":"https://api.github.com/repos/LalatenduMohanty/minishift","forks_url":"https://api.github.com/repos/LalatenduMohanty/minishift/forks","keys_url":"https://api.github.com/repos/LalatenduMohanty/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LalatenduMohanty/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LalatenduMohanty/minishift/teams","hooks_url":"https://api.github.com/repos/LalatenduMohanty/minishift/hooks","issue_events_url":"https://api.github.com/repos/LalatenduMohanty/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/LalatenduMohanty/minishift/events","assignees_url":"https://api.github.com/repos/LalatenduMohanty/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/LalatenduMohanty/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/LalatenduMohanty/minishift/tags","blobs_url":"https://api.github.com/repos/LalatenduMohanty/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LalatenduMohanty/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LalatenduMohanty/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/LalatenduMohanty/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LalatenduMohanty/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/LalatenduMohanty/minishift/languages","stargazers_url":"https://api.github.com/repos/LalatenduMohanty/minishift/stargazers","contributors_url":"https://api.github.com/repos/LalatenduMohanty/minishift/contributors","subscribers_url":"https://api.github.com/repos/LalatenduMohanty/minishift/subscribers","subscription_url":"https://api.github.com/repos/LalatenduMohanty/minishift/subscription","commits_url":"https://api.github.com/repos/LalatenduMohanty/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/LalatenduMohanty/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/LalatenduMohanty/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/LalatenduMohanty/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/LalatenduMohanty/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/LalatenduMohanty/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LalatenduMohanty/minishift/merges","archive_url":"https://api.github.com/repos/LalatenduMohanty/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LalatenduMohanty/minishift/downloads","issues_url":"https://api.github.com/repos/LalatenduMohanty/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/LalatenduMohanty/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/LalatenduMohanty/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/LalatenduMohanty/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LalatenduMohanty/minishift/labels{/name}","releases_url":"https://api.github.com/repos/LalatenduMohanty/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/LalatenduMohanty/minishift/deployments","created_at":"2016-09-14T08:20:29Z","updated_at":"2016-09-14T08:20:30Z","pushed_at":"2017-02-16T07:23:31Z","git_url":"git://github.com/LalatenduMohanty/minishift.git","ssh_url":"git@github.com:LalatenduMohanty/minishift.git","clone_url":"https://github.com/LalatenduMohanty/minishift.git","svn_url":"https://github.com/LalatenduMohanty/minishift","homepage":null,"size":154957,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"e012ca44b8a38607520b129506e3366975fdf7c2","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-02-15T12:47:51Z","pushed_at":"2017-02-16T07:23:32Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":154951,"stargazers_count":227,"watchers_count":227,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":46,"mirror_url":null,"open_issues_count":100,"forks":46,"open_issues":100,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/399"},"html":{"href":"https://github.com/minishift/minishift/pull/399"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/399"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/399/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/399/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/399/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/6ac702fc57a7773622ce294a100a01aa6dd0d8b3"}}}}
{"actor":{"display_login":"gbraad"}}