{"action":"created","issue":{"url":"https://api.github.com/repos/nabto/unabto/issues/44","repository_url":"https://api.github.com/repos/nabto/unabto","labels_url":"https://api.github.com/repos/nabto/unabto/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/nabto/unabto/issues/44/comments","events_url":"https://api.github.com/repos/nabto/unabto/issues/44/events","html_url":"https://github.com/nabto/unabto/pull/44","id":237539488,"number":44,"title":"file_handling_improvement","user":{"login":"ThomasEnzinger","id":29595911,"avatar_url":"https://avatars0.githubusercontent.com/u/29595911?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasEnzinger","html_url":"https://github.com/ThomasEnzinger","followers_url":"https://api.github.com/users/ThomasEnzinger/followers","following_url":"https://api.github.com/users/ThomasEnzinger/following{/other_user}","gists_url":"https://api.github.com/users/ThomasEnzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasEnzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasEnzinger/subscriptions","organizations_url":"https://api.github.com/users/ThomasEnzinger/orgs","repos_url":"https://api.github.com/users/ThomasEnzinger/repos","events_url":"https://api.github.com/users/ThomasEnzinger/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasEnzinger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-21T13:44:43Z","updated_at":"2017-06-21T14:29:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nabto/unabto/pulls/44","html_url":"https://github.com/nabto/unabto/pull/44","diff_url":"https://github.com/nabto/unabto/pull/44.diff","patch_url":"https://github.com/nabto/unabto/pull/44.patch"},"body":"When testing the appmyproduct-device-stub I had the problem, that I could not save data to the fingerprint-memory. The error was thrown from 'rename(tempFilename, filename)' because the destination file was still open.\r\n\r\nOS: Windows 8.1, 64 Bit\r\nVisual Studio 2015 Community\r\n"},"comment":{"url":"https://api.github.com/repos/nabto/unabto/issues/comments/310096344","html_url":"https://github.com/nabto/unabto/pull/44#issuecomment-310096344","issue_url":"https://api.github.com/repos/nabto/unabto/issues/44","id":310096344,"user":{"login":"ThomasEnzinger","id":29595911,"avatar_url":"https://avatars0.githubusercontent.com/u/29595911?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasEnzinger","html_url":"https://github.com/ThomasEnzinger","followers_url":"https://api.github.com/users/ThomasEnzinger/followers","following_url":"https://api.github.com/users/ThomasEnzinger/following{/other_user}","gists_url":"https://api.github.com/users/ThomasEnzinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasEnzinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasEnzinger/subscriptions","organizations_url":"https://api.github.com/users/ThomasEnzinger/orgs","repos_url":"https://api.github.com/users/ThomasEnzinger/repos","events_url":"https://api.github.com/users/ThomasEnzinger/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasEnzinger/received_events","type":"User","site_admin":false},"created_at":"2017-06-21T14:29:05Z","updated_at":"2017-06-21T14:29:05Z","body":"Correct, I should have seen that too. I would suggest splitting ...\nshould I do this ... or is there a 'code owner' who should do this ? \n\nYes, the remove is necessary. First I tried to only put the close, but\nit was not sufficient. \n\nAm 2017-06-21 16:06, schrieb mkm85:\n\n> The missing fclose should be added in all occurences of return. A better approach would be splitting the function into a file opening/closing function and a file reading function. \n> \n> It seems like the remove is unfortunately neccessary on windows. \n> \n> --\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub [1], or mute the thread [2].\n \n\nLinks:\n------\n[1] https://github.com/nabto/unabto/pull/44#issuecomment-310089295\n[2]\nhttps://github.com/notifications/unsubscribe-auth/AcOZB-XFeE6ToltGJzmp5ZP0hkZQDEVMks5sGSNTgaJpZM4OA-4l"}}
{"actor":{"display_login":"ThomasEnzinger"}}