{"action":"created","comment":{"url":"https://api.github.com/repos/Ekryd/sortpom/pulls/comments/101904817","pull_request_review_id":22647932,"id":101904817,"diff_hunk":"@@ -93,6 +93,12 @@\n     private String lineSeparator;\n \n     /**\n+     * Ignore line separators when comparing current POM with sorted one\n+     */\n+    @Parameter(property = \"sort.ignoreLineSeparators\", defaultValue = \"true\")","path":"maven-plugin/src/main/java/sortpom/VerifyMojo.java","position":6,"original_position":6,"commit_id":"1ece7982c1a8998a436e1dfdfcc66110c8860c00","original_commit_id":"1ece7982c1a8998a436e1dfdfcc66110c8860c00","user":{"login":"Ekryd","id":851407,"avatar_url":"https://avatars.githubusercontent.com/u/851407?v=3","gravatar_id":"","url":"https://api.github.com/users/Ekryd","html_url":"https://github.com/Ekryd","followers_url":"https://api.github.com/users/Ekryd/followers","following_url":"https://api.github.com/users/Ekryd/following{/other_user}","gists_url":"https://api.github.com/users/Ekryd/gists{/gist_id}","starred_url":"https://api.github.com/users/Ekryd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ekryd/subscriptions","organizations_url":"https://api.github.com/users/Ekryd/orgs","repos_url":"https://api.github.com/users/Ekryd/repos","events_url":"https://api.github.com/users/Ekryd/events{/privacy}","received_events_url":"https://api.github.com/users/Ekryd/received_events","type":"User","site_admin":false},"body":"Question: The verify goal always compare only the structure to determine if the verification fails or not. (SortPomImp.isPomElementsSorted())\r\nDo we need to change that if we have this parameter?\r\nOtherwise this parameter should not be present for the verify mojo.","created_at":"2017-02-18T23:17:01Z","updated_at":"2017-02-18T23:20:00Z","html_url":"https://github.com/Ekryd/sortpom/pull/46#discussion_r101904817","pull_request_url":"https://api.github.com/repos/Ekryd/sortpom/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/Ekryd/sortpom/pulls/comments/101904817"},"html":{"href":"https://github.com/Ekryd/sortpom/pull/46#discussion_r101904817"},"pull_request":{"href":"https://api.github.com/repos/Ekryd/sortpom/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/Ekryd/sortpom/pulls/46","id":106611654,"html_url":"https://github.com/Ekryd/sortpom/pull/46","diff_url":"https://github.com/Ekryd/sortpom/pull/46.diff","patch_url":"https://github.com/Ekryd/sortpom/pull/46.patch","issue_url":"https://api.github.com/repos/Ekryd/sortpom/issues/46","number":46,"state":"open","locked":false,"title":"New parameter : forceEOL","user":{"login":"bguerin","id":800956,"avatar_url":"https://avatars.githubusercontent.com/u/800956?v=3","gravatar_id":"","url":"https://api.github.com/users/bguerin","html_url":"https://github.com/bguerin","followers_url":"https://api.github.com/users/bguerin/followers","following_url":"https://api.github.com/users/bguerin/following{/other_user}","gists_url":"https://api.github.com/users/bguerin/gists{/gist_id}","starred_url":"https://api.github.com/users/bguerin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bguerin/subscriptions","organizations_url":"https://api.github.com/users/bguerin/orgs","repos_url":"https://api.github.com/users/bguerin/repos","events_url":"https://api.github.com/users/bguerin/events{/privacy}","received_events_url":"https://api.github.com/users/bguerin/received_events","type":"User","site_admin":false},"body":"Thus POM always has the defined end of line. It is reformated with the specified one, even if it is well formated otherwise","created_at":"2017-02-16T20:52:54Z","updated_at":"2017-02-18T23:20:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3beca34bfcd38ba6504c45ca5c10ffe9812b6bf2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ekryd/sortpom/pulls/46/commits","review_comments_url":"https://api.github.com/repos/Ekryd/sortpom/pulls/46/comments","review_comment_url":"https://api.github.com/repos/Ekryd/sortpom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ekryd/sortpom/issues/46/comments","statuses_url":"https://api.github.com/repos/Ekryd/sortpom/statuses/1ece7982c1a8998a436e1dfdfcc66110c8860c00","head":{"label":"netceler:forceEOL","ref":"forceEOL","sha":"1ece7982c1a8998a436e1dfdfcc66110c8860c00","user":{"login":"netceler","id":2675587,"avatar_url":"https://avatars.githubusercontent.com/u/2675587?v=3","gravatar_id":"","url":"https://api.github.com/users/netceler","html_url":"https://github.com/netceler","followers_url":"https://api.github.com/users/netceler/followers","following_url":"https://api.github.com/users/netceler/following{/other_user}","gists_url":"https://api.github.com/users/netceler/gists{/gist_id}","starred_url":"https://api.github.com/users/netceler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netceler/subscriptions","organizations_url":"https://api.github.com/users/netceler/orgs","repos_url":"https://api.github.com/users/netceler/repos","events_url":"https://api.github.com/users/netceler/events{/privacy}","received_events_url":"https://api.github.com/users/netceler/received_events","type":"Organization","site_admin":false},"repo":{"id":81994705,"name":"sortpom","full_name":"netceler/sortpom","owner":{"login":"netceler","id":2675587,"avatar_url":"https://avatars.githubusercontent.com/u/2675587?v=3","gravatar_id":"","url":"https://api.github.com/users/netceler","html_url":"https://github.com/netceler","followers_url":"https://api.github.com/users/netceler/followers","following_url":"https://api.github.com/users/netceler/following{/other_user}","gists_url":"https://api.github.com/users/netceler/gists{/gist_id}","starred_url":"https://api.github.com/users/netceler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netceler/subscriptions","organizations_url":"https://api.github.com/users/netceler/orgs","repos_url":"https://api.github.com/users/netceler/repos","events_url":"https://api.github.com/users/netceler/events{/privacy}","received_events_url":"https://api.github.com/users/netceler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netceler/sortpom","description":"Maven plugin that helps the user sort pom.xml. ","fork":true,"url":"https://api.github.com/repos/netceler/sortpom","forks_url":"https://api.github.com/repos/netceler/sortpom/forks","keys_url":"https://api.github.com/repos/netceler/sortpom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netceler/sortpom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netceler/sortpom/teams","hooks_url":"https://api.github.com/repos/netceler/sortpom/hooks","issue_events_url":"https://api.github.com/repos/netceler/sortpom/issues/events{/number}","events_url":"https://api.github.com/repos/netceler/sortpom/events","assignees_url":"https://api.github.com/repos/netceler/sortpom/assignees{/user}","branches_url":"https://api.github.com/repos/netceler/sortpom/branches{/branch}","tags_url":"https://api.github.com/repos/netceler/sortpom/tags","blobs_url":"https://api.github.com/repos/netceler/sortpom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netceler/sortpom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netceler/sortpom/git/refs{/sha}","trees_url":"https://api.github.com/repos/netceler/sortpom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netceler/sortpom/statuses/{sha}","languages_url":"https://api.github.com/repos/netceler/sortpom/languages","stargazers_url":"https://api.github.com/repos/netceler/sortpom/stargazers","contributors_url":"https://api.github.com/repos/netceler/sortpom/contributors","subscribers_url":"https://api.github.com/repos/netceler/sortpom/subscribers","subscription_url":"https://api.github.com/repos/netceler/sortpom/subscription","commits_url":"https://api.github.com/repos/netceler/sortpom/commits{/sha}","git_commits_url":"https://api.github.com/repos/netceler/sortpom/git/commits{/sha}","comments_url":"https://api.github.com/repos/netceler/sortpom/comments{/number}","issue_comment_url":"https://api.github.com/repos/netceler/sortpom/issues/comments{/number}","contents_url":"https://api.github.com/repos/netceler/sortpom/contents/{+path}","compare_url":"https://api.github.com/repos/netceler/sortpom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netceler/sortpom/merges","archive_url":"https://api.github.com/repos/netceler/sortpom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netceler/sortpom/downloads","issues_url":"https://api.github.com/repos/netceler/sortpom/issues{/number}","pulls_url":"https://api.github.com/repos/netceler/sortpom/pulls{/number}","milestones_url":"https://api.github.com/repos/netceler/sortpom/milestones{/number}","notifications_url":"https://api.github.com/repos/netceler/sortpom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netceler/sortpom/labels{/name}","releases_url":"https://api.github.com/repos/netceler/sortpom/releases{/id}","deployments_url":"https://api.github.com/repos/netceler/sortpom/deployments","created_at":"2017-02-14T22:17:37Z","updated_at":"2017-02-14T22:17:39Z","pushed_at":"2017-02-18T21:42:16Z","git_url":"git://github.com/netceler/sortpom.git","ssh_url":"git@github.com:netceler/sortpom.git","clone_url":"https://github.com/netceler/sortpom.git","svn_url":"https://github.com/netceler/sortpom","homepage":"https://github.com/Ekryd/sortpom/wiki/","size":1733,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ekryd:master","ref":"master","sha":"984e1609ed7648352455827ed398c7cbf176994d","user":{"login":"Ekryd","id":851407,"avatar_url":"https://avatars.githubusercontent.com/u/851407?v=3","gravatar_id":"","url":"https://api.github.com/users/Ekryd","html_url":"https://github.com/Ekryd","followers_url":"https://api.github.com/users/Ekryd/followers","following_url":"https://api.github.com/users/Ekryd/following{/other_user}","gists_url":"https://api.github.com/users/Ekryd/gists{/gist_id}","starred_url":"https://api.github.com/users/Ekryd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ekryd/subscriptions","organizations_url":"https://api.github.com/users/Ekryd/orgs","repos_url":"https://api.github.com/users/Ekryd/repos","events_url":"https://api.github.com/users/Ekryd/events{/privacy}","received_events_url":"https://api.github.com/users/Ekryd/received_events","type":"User","site_admin":false},"repo":{"id":32216000,"name":"sortpom","full_name":"Ekryd/sortpom","owner":{"login":"Ekryd","id":851407,"avatar_url":"https://avatars.githubusercontent.com/u/851407?v=3","gravatar_id":"","url":"https://api.github.com/users/Ekryd","html_url":"https://github.com/Ekryd","followers_url":"https://api.github.com/users/Ekryd/followers","following_url":"https://api.github.com/users/Ekryd/following{/other_user}","gists_url":"https://api.github.com/users/Ekryd/gists{/gist_id}","starred_url":"https://api.github.com/users/Ekryd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ekryd/subscriptions","organizations_url":"https://api.github.com/users/Ekryd/orgs","repos_url":"https://api.github.com/users/Ekryd/repos","events_url":"https://api.github.com/users/Ekryd/events{/privacy}","received_events_url":"https://api.github.com/users/Ekryd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ekryd/sortpom","description":"Maven plugin that helps the user sort pom.xml. ","fork":false,"url":"https://api.github.com/repos/Ekryd/sortpom","forks_url":"https://api.github.com/repos/Ekryd/sortpom/forks","keys_url":"https://api.github.com/repos/Ekryd/sortpom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ekryd/sortpom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ekryd/sortpom/teams","hooks_url":"https://api.github.com/repos/Ekryd/sortpom/hooks","issue_events_url":"https://api.github.com/repos/Ekryd/sortpom/issues/events{/number}","events_url":"https://api.github.com/repos/Ekryd/sortpom/events","assignees_url":"https://api.github.com/repos/Ekryd/sortpom/assignees{/user}","branches_url":"https://api.github.com/repos/Ekryd/sortpom/branches{/branch}","tags_url":"https://api.github.com/repos/Ekryd/sortpom/tags","blobs_url":"https://api.github.com/repos/Ekryd/sortpom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ekryd/sortpom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ekryd/sortpom/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ekryd/sortpom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ekryd/sortpom/statuses/{sha}","languages_url":"https://api.github.com/repos/Ekryd/sortpom/languages","stargazers_url":"https://api.github.com/repos/Ekryd/sortpom/stargazers","contributors_url":"https://api.github.com/repos/Ekryd/sortpom/contributors","subscribers_url":"https://api.github.com/repos/Ekryd/sortpom/subscribers","subscription_url":"https://api.github.com/repos/Ekryd/sortpom/subscription","commits_url":"https://api.github.com/repos/Ekryd/sortpom/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ekryd/sortpom/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ekryd/sortpom/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ekryd/sortpom/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ekryd/sortpom/contents/{+path}","compare_url":"https://api.github.com/repos/Ekryd/sortpom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ekryd/sortpom/merges","archive_url":"https://api.github.com/repos/Ekryd/sortpom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ekryd/sortpom/downloads","issues_url":"https://api.github.com/repos/Ekryd/sortpom/issues{/number}","pulls_url":"https://api.github.com/repos/Ekryd/sortpom/pulls{/number}","milestones_url":"https://api.github.com/repos/Ekryd/sortpom/milestones{/number}","notifications_url":"https://api.github.com/repos/Ekryd/sortpom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ekryd/sortpom/labels{/name}","releases_url":"https://api.github.com/repos/Ekryd/sortpom/releases{/id}","deployments_url":"https://api.github.com/repos/Ekryd/sortpom/deployments","created_at":"2015-03-14T14:32:22Z","updated_at":"2017-02-14T22:24:17Z","pushed_at":"2017-02-18T21:42:18Z","git_url":"git://github.com/Ekryd/sortpom.git","ssh_url":"git@github.com:Ekryd/sortpom.git","clone_url":"https://github.com/Ekryd/sortpom.git","svn_url":"https://github.com/Ekryd/sortpom","homepage":"https://github.com/Ekryd/sortpom/wiki/","size":1721,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":4,"forks":13,"open_issues":4,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ekryd/sortpom/pulls/46"},"html":{"href":"https://github.com/Ekryd/sortpom/pull/46"},"issue":{"href":"https://api.github.com/repos/Ekryd/sortpom/issues/46"},"comments":{"href":"https://api.github.com/repos/Ekryd/sortpom/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/Ekryd/sortpom/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/Ekryd/sortpom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ekryd/sortpom/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/Ekryd/sortpom/statuses/1ece7982c1a8998a436e1dfdfcc66110c8860c00"}}}}
{"actor":{"display_login":"Ekryd"}}