{"action":"closed","issue":{"url":"https://api.github.com/repos/salesforce-ux/sass-deprecate/issues/14","repository_url":"https://api.github.com/repos/salesforce-ux/sass-deprecate","labels_url":"https://api.github.com/repos/salesforce-ux/sass-deprecate/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/salesforce-ux/sass-deprecate/issues/14/comments","events_url":"https://api.github.com/repos/salesforce-ux/sass-deprecate/issues/14/events","html_url":"https://github.com/salesforce-ux/sass-deprecate/issues/14","id":160672691,"number":14,"title":"Possible issue with fail deprecate mode.","user":{"login":"joeHillman","id":7363631,"avatar_url":"https://avatars.githubusercontent.com/u/7363631?v=3","gravatar_id":"","url":"https://api.github.com/users/joeHillman","html_url":"https://github.com/joeHillman","followers_url":"https://api.github.com/users/joeHillman/followers","following_url":"https://api.github.com/users/joeHillman/following{/other_user}","gists_url":"https://api.github.com/users/joeHillman/gists{/gist_id}","starred_url":"https://api.github.com/users/joeHillman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeHillman/subscriptions","organizations_url":"https://api.github.com/users/joeHillman/orgs","repos_url":"https://api.github.com/users/joeHillman/repos","events_url":"https://api.github.com/users/joeHillman/events{/privacy}","received_events_url":"https://api.github.com/users/joeHillman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-06-16T14:16:02Z","updated_at":"2017-01-27T07:54:10Z","closed_at":"2017-01-27T07:54:10Z","body":"Hello, cool project!\nLooking to setup on our application.\n\nOutline of my setup is below.\nFigured I'd put the potential issue first.\n\nThere's a potential issue with the deprecate mode fail.\nThe following snippets are returned on different modes...\n\n---\n- Sensible\n\n```\nRunning \"sass:common\" (sass) task\nWARNING: Deprecated code was found, it should be removed before its release.\nREASON:  Use .btn-primary-2-0-0 instead.\nBacktrace:\n    vendor/bower/sass-deprecate/index.scss:159, in mixin `deprecate`\n    src/script/li/stylesheets/scss/_button.scss:59\n\n\nDone, without errors.\n```\n\n---\n- Verbose\n\n```\nRunning \"sass:common\" (sass) task\nWARNING: Some code will be deprecated in 2.0.0. Current version: 2.0.0.\nBacktrace:\n    vendor/bower/sass-deprecate/index.scss:119, in mixin `deprecate`\n    src/script/li/stylesheets/scss/_button.scss:59\n\nWARNING: Deprecated code was found, it should be removed before its release.\nREASON:  Use .btn-primary-2-0-0 instead.\nBacktrace:\n    vendor/bower/sass-deprecate/index.scss:159, in mixin `deprecate`\n    src/script/li/stylesheets/scss/_button.scss:59\n\n\nDone, without errors.\n```\n\n---\n- Fail\n\n```\nRunning \"sass:common\" (sass) task\n>> Error: Deprecated code was found. Remove it to continue.\n>>        REASON:  Use .btn-primary-2-0-0 instead.\n>>         on line 157 of vendor/bower/sass-deprecate/index.scss\n>> >>           @error 'Deprecated code was found. Remove it to continue.#{$message}\n>>    ----------^\nWarning:  Use --force to continue.\n\nAborted due to warnings.\n```\n\nThe output the Fail provides I would have expected to point to the offending code in the source of the project, not so much the sass-deprecation index, though I may be wrong here.\n\n---\n- My setup as outlined here\n\n```\n@import \"base\"; // importing vars for btn-primary\n@import \"index\";\n\n$app-version: '2.0.0';\n$deprecate-mode: 'verbose';\n\n$btn-primary-bg-2-0-0: #333;\n$btn-primary-text-color-2-0-0: #ccc;\n$btn-primary-border-color-2-0-0: #333;\n\n@include deprecate('2.0.0', 'Use .btn-primary-2-0-0 instead.') {\n  .btn-primary {\n    @include button-type($btn-primary-bg, $btn-primary-text-color, $btn-primary-border-color);\n    &:hover {\n      color: $btn-primary-text-color;\n    }\n  }\n}\n.btn-primary-2-0-0 {\n  @include button-type($btn-primary-bg-2-0-0, $btn-primary-text-color-2-0-0, $btn-primary-border-color-2-0-0);\n  &:hover {\n    color: $btn-primary-text-color;\n  }\n}\n```\n"}}
{"actor":{"display_login":"kaelig"}}