{"action":"closed","number":273,"pull_request":{"url":"https://api.github.com/repos/drud/ddev/pulls/273","id":122511812,"html_url":"https://github.com/drud/ddev/pull/273","diff_url":"https://github.com/drud/ddev/pull/273.diff","patch_url":"https://github.com/drud/ddev/pull/273.patch","issue_url":"https://api.github.com/repos/drud/ddev/issues/273","number":273,"state":"closed","locked":false,"title":"removes requirement for exec cmds to be wrapped in quotes, updates help, fixes #68","user":{"login":"tannerjfco","id":1390210,"avatar_url":"https://avatars0.githubusercontent.com/u/1390210?v=3","gravatar_id":"","url":"https://api.github.com/users/tannerjfco","html_url":"https://github.com/tannerjfco","followers_url":"https://api.github.com/users/tannerjfco/followers","following_url":"https://api.github.com/users/tannerjfco/following{/other_user}","gists_url":"https://api.github.com/users/tannerjfco/gists{/gist_id}","starred_url":"https://api.github.com/users/tannerjfco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannerjfco/subscriptions","organizations_url":"https://api.github.com/users/tannerjfco/orgs","repos_url":"https://api.github.com/users/tannerjfco/repos","events_url":"https://api.github.com/users/tannerjfco/events{/privacy}","received_events_url":"https://api.github.com/users/tannerjfco/received_events","type":"User","site_admin":false},"body":"## The Problem:\r\n#68 identified some validation issues with ddev exec. Some of the issues have been addressed since the ticket was created, but the requirement to encapsulate multi-argument commands in quotes makes for a clunky experience compared to docker exec, which requires no quoting for such commands.\r\n\r\n## The Fix:\r\nThis PR updates the exec function, removing the requirement for users to quote commands that had multiple arguments or flags. It achieves this by disabling support for interspersed option/non-option arguments on the exec command. This means that flags for ddev exec will need to be defined prior to the command that will be exec'd in a container. The PR also introduces the \".\" alias for exec, allowing users to run commands like `ddev . drush status`. It also updates the help text and documentation for exec and ssh.\r\n\r\n## The Test:\r\nThe test is pretty straightforward for this - you should be able to run multi-argument commands, with flags, without wrapping in quotes.\r\n\r\nA couple commands that should work:\r\n`ddev exec drush --help` should return the drush help.\r\n`ddev exec -s db mysql` should run the mysql client in the db container.\r\n\r\n## Automation Overview:\r\n<!-- Please provide an overview of tests introduced by this PR, or an explanation for why no tests are needed. -->\r\nThe existing binary tests have been adjusted for these changes.\r\n\r\n## Related Issue Link(s):\r\n#68 validation for exec commands.\r\n## Release/Deployment notes:\r\n<!-- Does this affect anything else, or are there ramifications for other code? Does anything have to be done on deployment? -->\r\n\r\n","created_at":"2017-05-25T19:49:38Z","updated_at":"2017-05-31T22:45:43Z","closed_at":"2017-05-31T22:45:43Z","merged_at":"2017-05-31T22:45:43Z","merge_commit_sha":"9dfa4d27e6947de48b71a8134cad07a94618bbe5","assignee":{"login":"tannerjfco","id":1390210,"avatar_url":"https://avatars0.githubusercontent.com/u/1390210?v=3","gravatar_id":"","url":"https://api.github.com/users/tannerjfco","html_url":"https://github.com/tannerjfco","followers_url":"https://api.github.com/users/tannerjfco/followers","following_url":"https://api.github.com/users/tannerjfco/following{/other_user}","gists_url":"https://api.github.com/users/tannerjfco/gists{/gist_id}","starred_url":"https://api.github.com/users/tannerjfco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannerjfco/subscriptions","organizations_url":"https://api.github.com/users/tannerjfco/orgs","repos_url":"https://api.github.com/users/tannerjfco/repos","events_url":"https://api.github.com/users/tannerjfco/events{/privacy}","received_events_url":"https://api.github.com/users/tannerjfco/received_events","type":"User","site_admin":false},"assignees":[{"login":"tannerjfco","id":1390210,"avatar_url":"https://avatars0.githubusercontent.com/u/1390210?v=3","gravatar_id":"","url":"https://api.github.com/users/tannerjfco","html_url":"https://github.com/tannerjfco","followers_url":"https://api.github.com/users/tannerjfco/followers","following_url":"https://api.github.com/users/tannerjfco/following{/other_user}","gists_url":"https://api.github.com/users/tannerjfco/gists{/gist_id}","starred_url":"https://api.github.com/users/tannerjfco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannerjfco/subscriptions","organizations_url":"https://api.github.com/users/tannerjfco/orgs","repos_url":"https://api.github.com/users/tannerjfco/repos","events_url":"https://api.github.com/users/tannerjfco/events{/privacy}","received_events_url":"https://api.github.com/users/tannerjfco/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/drud/ddev/milestones/10","html_url":"https://github.com/drud/ddev/milestone/10","labels_url":"https://api.github.com/repos/drud/ddev/milestones/10/labels","id":2531315,"number":10,"title":"v0.8","description":null,"creator":{"login":"rickmanelius","id":913096,"avatar_url":"https://avatars2.githubusercontent.com/u/913096?v=3","gravatar_id":"","url":"https://api.github.com/users/rickmanelius","html_url":"https://github.com/rickmanelius","followers_url":"https://api.github.com/users/rickmanelius/followers","following_url":"https://api.github.com/users/rickmanelius/following{/other_user}","gists_url":"https://api.github.com/users/rickmanelius/gists{/gist_id}","starred_url":"https://api.github.com/users/rickmanelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickmanelius/subscriptions","organizations_url":"https://api.github.com/users/rickmanelius/orgs","repos_url":"https://api.github.com/users/rickmanelius/repos","events_url":"https://api.github.com/users/rickmanelius/events{/privacy}","received_events_url":"https://api.github.com/users/rickmanelius/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":3,"state":"open","created_at":"2017-05-19T12:51:17Z","updated_at":"2017-05-31T22:45:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/drud/ddev/pulls/273/commits","review_comments_url":"https://api.github.com/repos/drud/ddev/pulls/273/comments","review_comment_url":"https://api.github.com/repos/drud/ddev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drud/ddev/issues/273/comments","statuses_url":"https://api.github.com/repos/drud/ddev/statuses/d4f3c2185587139068842982791db415e5468af7","head":{"label":"tannerjfco:no-quote-exec","ref":"no-quote-exec","sha":"d4f3c2185587139068842982791db415e5468af7","user":{"login":"tannerjfco","id":1390210,"avatar_url":"https://avatars0.githubusercontent.com/u/1390210?v=3","gravatar_id":"","url":"https://api.github.com/users/tannerjfco","html_url":"https://github.com/tannerjfco","followers_url":"https://api.github.com/users/tannerjfco/followers","following_url":"https://api.github.com/users/tannerjfco/following{/other_user}","gists_url":"https://api.github.com/users/tannerjfco/gists{/gist_id}","starred_url":"https://api.github.com/users/tannerjfco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannerjfco/subscriptions","organizations_url":"https://api.github.com/users/tannerjfco/orgs","repos_url":"https://api.github.com/users/tannerjfco/repos","events_url":"https://api.github.com/users/tannerjfco/events{/privacy}","received_events_url":"https://api.github.com/users/tannerjfco/received_events","type":"User","site_admin":false},"repo":{"id":80775653,"name":"ddev","full_name":"tannerjfco/ddev","owner":{"login":"tannerjfco","id":1390210,"avatar_url":"https://avatars0.githubusercontent.com/u/1390210?v=3","gravatar_id":"","url":"https://api.github.com/users/tannerjfco","html_url":"https://github.com/tannerjfco","followers_url":"https://api.github.com/users/tannerjfco/followers","following_url":"https://api.github.com/users/tannerjfco/following{/other_user}","gists_url":"https://api.github.com/users/tannerjfco/gists{/gist_id}","starred_url":"https://api.github.com/users/tannerjfco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannerjfco/subscriptions","organizations_url":"https://api.github.com/users/tannerjfco/orgs","repos_url":"https://api.github.com/users/tannerjfco/repos","events_url":"https://api.github.com/users/tannerjfco/events{/privacy}","received_events_url":"https://api.github.com/users/tannerjfco/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tannerjfco/ddev","description":"Drud dev: a local development environment management system","fork":true,"url":"https://api.github.com/repos/tannerjfco/ddev","forks_url":"https://api.github.com/repos/tannerjfco/ddev/forks","keys_url":"https://api.github.com/repos/tannerjfco/ddev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tannerjfco/ddev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tannerjfco/ddev/teams","hooks_url":"https://api.github.com/repos/tannerjfco/ddev/hooks","issue_events_url":"https://api.github.com/repos/tannerjfco/ddev/issues/events{/number}","events_url":"https://api.github.com/repos/tannerjfco/ddev/events","assignees_url":"https://api.github.com/repos/tannerjfco/ddev/assignees{/user}","branches_url":"https://api.github.com/repos/tannerjfco/ddev/branches{/branch}","tags_url":"https://api.github.com/repos/tannerjfco/ddev/tags","blobs_url":"https://api.github.com/repos/tannerjfco/ddev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tannerjfco/ddev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tannerjfco/ddev/git/refs{/sha}","trees_url":"https://api.github.com/repos/tannerjfco/ddev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tannerjfco/ddev/statuses/{sha}","languages_url":"https://api.github.com/repos/tannerjfco/ddev/languages","stargazers_url":"https://api.github.com/repos/tannerjfco/ddev/stargazers","contributors_url":"https://api.github.com/repos/tannerjfco/ddev/contributors","subscribers_url":"https://api.github.com/repos/tannerjfco/ddev/subscribers","subscription_url":"https://api.github.com/repos/tannerjfco/ddev/subscription","commits_url":"https://api.github.com/repos/tannerjfco/ddev/commits{/sha}","git_commits_url":"https://api.github.com/repos/tannerjfco/ddev/git/commits{/sha}","comments_url":"https://api.github.com/repos/tannerjfco/ddev/comments{/number}","issue_comment_url":"https://api.github.com/repos/tannerjfco/ddev/issues/comments{/number}","contents_url":"https://api.github.com/repos/tannerjfco/ddev/contents/{+path}","compare_url":"https://api.github.com/repos/tannerjfco/ddev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tannerjfco/ddev/merges","archive_url":"https://api.github.com/repos/tannerjfco/ddev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tannerjfco/ddev/downloads","issues_url":"https://api.github.com/repos/tannerjfco/ddev/issues{/number}","pulls_url":"https://api.github.com/repos/tannerjfco/ddev/pulls{/number}","milestones_url":"https://api.github.com/repos/tannerjfco/ddev/milestones{/number}","notifications_url":"https://api.github.com/repos/tannerjfco/ddev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tannerjfco/ddev/labels{/name}","releases_url":"https://api.github.com/repos/tannerjfco/ddev/releases{/id}","deployments_url":"https://api.github.com/repos/tannerjfco/ddev/deployments","created_at":"2017-02-02T22:39:56Z","updated_at":"2017-04-18T16:37:30Z","pushed_at":"2017-05-31T22:43:07Z","git_url":"git://github.com/tannerjfco/ddev.git","ssh_url":"git@github.com:tannerjfco/ddev.git","clone_url":"https://github.com/tannerjfco/ddev.git","svn_url":"https://github.com/tannerjfco/ddev","homepage":null,"size":34092,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drud:master","ref":"master","sha":"2ca92ae527a4e0b3bb9da6100cef00356185461a","user":{"login":"drud","id":8115114,"avatar_url":"https://avatars1.githubusercontent.com/u/8115114?v=3","gravatar_id":"","url":"https://api.github.com/users/drud","html_url":"https://github.com/drud","followers_url":"https://api.github.com/users/drud/followers","following_url":"https://api.github.com/users/drud/following{/other_user}","gists_url":"https://api.github.com/users/drud/gists{/gist_id}","starred_url":"https://api.github.com/users/drud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drud/subscriptions","organizations_url":"https://api.github.com/users/drud/orgs","repos_url":"https://api.github.com/users/drud/repos","events_url":"https://api.github.com/users/drud/events{/privacy}","received_events_url":"https://api.github.com/users/drud/received_events","type":"Organization","site_admin":false},"repo":{"id":80669528,"name":"ddev","full_name":"drud/ddev","owner":{"login":"drud","id":8115114,"avatar_url":"https://avatars1.githubusercontent.com/u/8115114?v=3","gravatar_id":"","url":"https://api.github.com/users/drud","html_url":"https://github.com/drud","followers_url":"https://api.github.com/users/drud/followers","following_url":"https://api.github.com/users/drud/following{/other_user}","gists_url":"https://api.github.com/users/drud/gists{/gist_id}","starred_url":"https://api.github.com/users/drud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drud/subscriptions","organizations_url":"https://api.github.com/users/drud/orgs","repos_url":"https://api.github.com/users/drud/repos","events_url":"https://api.github.com/users/drud/events{/privacy}","received_events_url":"https://api.github.com/users/drud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drud/ddev","description":"ddev: a local development environment management system","fork":false,"url":"https://api.github.com/repos/drud/ddev","forks_url":"https://api.github.com/repos/drud/ddev/forks","keys_url":"https://api.github.com/repos/drud/ddev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drud/ddev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drud/ddev/teams","hooks_url":"https://api.github.com/repos/drud/ddev/hooks","issue_events_url":"https://api.github.com/repos/drud/ddev/issues/events{/number}","events_url":"https://api.github.com/repos/drud/ddev/events","assignees_url":"https://api.github.com/repos/drud/ddev/assignees{/user}","branches_url":"https://api.github.com/repos/drud/ddev/branches{/branch}","tags_url":"https://api.github.com/repos/drud/ddev/tags","blobs_url":"https://api.github.com/repos/drud/ddev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drud/ddev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drud/ddev/git/refs{/sha}","trees_url":"https://api.github.com/repos/drud/ddev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drud/ddev/statuses/{sha}","languages_url":"https://api.github.com/repos/drud/ddev/languages","stargazers_url":"https://api.github.com/repos/drud/ddev/stargazers","contributors_url":"https://api.github.com/repos/drud/ddev/contributors","subscribers_url":"https://api.github.com/repos/drud/ddev/subscribers","subscription_url":"https://api.github.com/repos/drud/ddev/subscription","commits_url":"https://api.github.com/repos/drud/ddev/commits{/sha}","git_commits_url":"https://api.github.com/repos/drud/ddev/git/commits{/sha}","comments_url":"https://api.github.com/repos/drud/ddev/comments{/number}","issue_comment_url":"https://api.github.com/repos/drud/ddev/issues/comments{/number}","contents_url":"https://api.github.com/repos/drud/ddev/contents/{+path}","compare_url":"https://api.github.com/repos/drud/ddev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drud/ddev/merges","archive_url":"https://api.github.com/repos/drud/ddev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drud/ddev/downloads","issues_url":"https://api.github.com/repos/drud/ddev/issues{/number}","pulls_url":"https://api.github.com/repos/drud/ddev/pulls{/number}","milestones_url":"https://api.github.com/repos/drud/ddev/milestones{/number}","notifications_url":"https://api.github.com/repos/drud/ddev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drud/ddev/labels{/name}","releases_url":"https://api.github.com/repos/drud/ddev/releases{/id}","deployments_url":"https://api.github.com/repos/drud/ddev/deployments","created_at":"2017-02-01T22:09:39Z","updated_at":"2017-05-18T19:21:31Z","pushed_at":"2017-05-31T22:45:42Z","git_url":"git://github.com/drud/ddev.git","ssh_url":"git@github.com:drud/ddev.git","clone_url":"https://github.com/drud/ddev.git","svn_url":"https://github.com/drud/ddev","homepage":"","size":33843,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":68,"forks":4,"open_issues":68,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drud/ddev/pulls/273"},"html":{"href":"https://github.com/drud/ddev/pull/273"},"issue":{"href":"https://api.github.com/repos/drud/ddev/issues/273"},"comments":{"href":"https://api.github.com/repos/drud/ddev/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/drud/ddev/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/drud/ddev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drud/ddev/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/drud/ddev/statuses/d4f3c2185587139068842982791db415e5468af7"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tannerjfco","id":1390210,"avatar_url":"https://avatars0.githubusercontent.com/u/1390210?v=3","gravatar_id":"","url":"https://api.github.com/users/tannerjfco","html_url":"https://github.com/tannerjfco","followers_url":"https://api.github.com/users/tannerjfco/followers","following_url":"https://api.github.com/users/tannerjfco/following{/other_user}","gists_url":"https://api.github.com/users/tannerjfco/gists{/gist_id}","starred_url":"https://api.github.com/users/tannerjfco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannerjfco/subscriptions","organizations_url":"https://api.github.com/users/tannerjfco/orgs","repos_url":"https://api.github.com/users/tannerjfco/repos","events_url":"https://api.github.com/users/tannerjfco/events{/privacy}","received_events_url":"https://api.github.com/users/tannerjfco/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":33,"deletions":35,"changed_files":5}}
{"actor":{"display_login":"tannerjfco"}}