{"action":"closed","number":21122,"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/21122","id":153927156,"html_url":"https://github.com/odoo/odoo/pull/21122","diff_url":"https://github.com/odoo/odoo/pull/21122.diff","patch_url":"https://github.com/odoo/odoo/pull/21122.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/21122","number":21122,"state":"closed","locked":false,"title":"[FIX] pos_cache: Adapt JS code to ac89783d2f6c.","user":{"login":"FalcoBolger","id":109190,"avatar_url":"https://avatars2.githubusercontent.com/u/109190?v=4","gravatar_id":"","url":"https://api.github.com/users/FalcoBolger","html_url":"https://github.com/FalcoBolger","followers_url":"https://api.github.com/users/FalcoBolger/followers","following_url":"https://api.github.com/users/FalcoBolger/following{/other_user}","gists_url":"https://api.github.com/users/FalcoBolger/gists{/gist_id}","starred_url":"https://api.github.com/users/FalcoBolger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FalcoBolger/subscriptions","organizations_url":"https://api.github.com/users/FalcoBolger/orgs","repos_url":"https://api.github.com/users/FalcoBolger/repos","events_url":"https://api.github.com/users/FalcoBolger/events{/privacy}","received_events_url":"https://api.github.com/users/FalcoBolger/received_events","type":"User","site_admin":false},"body":"Otherwise, when rendering the 'Product' template it crashes when calling\r\nthe 'get_price' method.\r\n\r\nIndeed, we need to add products as a Product model instead of as a plain\r\nJS object.\r\n\r\nDescription of the issue/feature this PR addresses:\r\n\r\nCurrent behavior before PR:\r\n\r\nDesired behavior after PR is merged:\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2017-11-21T15:48:30Z","updated_at":"2017-11-21T16:57:18Z","closed_at":"2017-11-21T16:57:18Z","merged_at":null,"merge_commit_sha":"5e4bf749f299f95327cf5341b28fb64f2e19e8ce","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jorenvo","id":10252581,"avatar_url":"https://avatars2.githubusercontent.com/u/10252581?v=4","gravatar_id":"","url":"https://api.github.com/users/jorenvo","html_url":"https://github.com/jorenvo","followers_url":"https://api.github.com/users/jorenvo/followers","following_url":"https://api.github.com/users/jorenvo/following{/other_user}","gists_url":"https://api.github.com/users/jorenvo/gists{/gist_id}","starred_url":"https://api.github.com/users/jorenvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorenvo/subscriptions","organizations_url":"https://api.github.com/users/jorenvo/orgs","repos_url":"https://api.github.com/users/jorenvo/repos","events_url":"https://api.github.com/users/jorenvo/events{/privacy}","received_events_url":"https://api.github.com/users/jorenvo/received_events","type":"User","site_admin":false},{"login":"pimodoo","id":20767708,"avatar_url":"https://avatars2.githubusercontent.com/u/20767708?v=4","gravatar_id":"","url":"https://api.github.com/users/pimodoo","html_url":"https://github.com/pimodoo","followers_url":"https://api.github.com/users/pimodoo/followers","following_url":"https://api.github.com/users/pimodoo/following{/other_user}","gists_url":"https://api.github.com/users/pimodoo/gists{/gist_id}","starred_url":"https://api.github.com/users/pimodoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pimodoo/subscriptions","organizations_url":"https://api.github.com/users/pimodoo/orgs","repos_url":"https://api.github.com/users/pimodoo/repos","events_url":"https://api.github.com/users/pimodoo/events{/privacy}","received_events_url":"https://api.github.com/users/pimodoo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/21122/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/21122/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/21122/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/9aceb7731662034e929a2cc66dd10912a58d3991","head":{"label":"odoo-dev:11.0-pos_cache-fix_adding_products_to_db-vta","ref":"11.0-pos_cache-fix_adding_products_to_db-vta","sha":"9aceb7731662034e929a2cc66dd10912a58d3991","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2017-10-03T02:33:34Z","pushed_at":"2017-11-21T16:55:33Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":1861484,"stargazers_count":72,"watchers_count":72,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":34,"open_issues":0,"watchers":72,"default_branch":"master"}},"base":{"label":"odoo:11.0","ref":"11.0","sha":"0593fd89540758c9cb5d76076c3d0c890bd6e1c3","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2017-11-21T14:37:19Z","pushed_at":"2017-11-21T16:56:36Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1859784,"stargazers_count":8047,"watchers_count":8047,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7126,"mirror_url":null,"archived":false,"open_issues_count":3702,"forks":7126,"open_issues":3702,"watchers":8047,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/21122"},"html":{"href":"https://github.com/odoo/odoo/pull/21122"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/21122"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/21122/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/21122/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/21122/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/9aceb7731662034e929a2cc66dd10912a58d3991"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"FalcoBolger"}}