{"action":"created","issue":{"url":"https://api.github.com/repos/AgileVentures/shf-project/issues/189","repository_url":"https://api.github.com/repos/AgileVentures/shf-project","labels_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/189/comments","events_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/189/events","html_url":"https://github.com/AgileVentures/shf-project/pull/189","id":213916111,"number":189,"title":"Edit company info #136724617","user":{"login":"patmbolger","id":9968213,"avatar_url":"https://avatars0.githubusercontent.com/u/9968213?v=3","gravatar_id":"","url":"https://api.github.com/users/patmbolger","html_url":"https://github.com/patmbolger","followers_url":"https://api.github.com/users/patmbolger/followers","following_url":"https://api.github.com/users/patmbolger/following{/other_user}","gists_url":"https://api.github.com/users/patmbolger/gists{/gist_id}","starred_url":"https://api.github.com/users/patmbolger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patmbolger/subscriptions","organizations_url":"https://api.github.com/users/patmbolger/orgs","repos_url":"https://api.github.com/users/patmbolger/repos","events_url":"https://api.github.com/users/patmbolger/events{/privacy}","received_events_url":"https://api.github.com/users/patmbolger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-03-13T22:28:19Z","updated_at":"2017-03-28T20:06:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189","html_url":"https://github.com/AgileVentures/shf-project/pull/189","diff_url":"https://github.com/AgileVentures/shf-project/pull/189.diff","patch_url":"https://github.com/AgileVentures/shf-project/pull/189.patch"},"body":"PT Story: https://www.pivotaltracker.com/story/show/136724617\r\n\r\n\r\nChanges proposed in this pull request:\r\n1. Embed ckeditor as in-line editor in company edit form (for field `info`).\r\n2. Add `info` attribute to Company model (used to store company info text in DB (images stored on file system))\r\n3. Add company info to companies#show view\r\n4. Add migrations for ckeditor STI table and for `info` field added to Company\r\n5. Store uploaded images under the ```/public``` folder but with obscured directory paths\r\n\r\nScreenshots (Optional):\r\n<hr>\r\nCompany info edit:\r\n<img width=\"801\" alt=\"screen shot 2017-03-25 at 9 26 25 am\" src=\"https://cloud.githubusercontent.com/assets/9968213/24322573/3516521c-113d-11e7-8e9f-9a3e18f4f5d7.png\">\r\n\r\n\r\n<hr>\r\nCompany #show view:\r\n<img width=\"784\" alt=\"screen shot 2017-03-25 at 9 40 14 am\" src=\"https://cloud.githubusercontent.com/assets/9968213/24322652/23ba3950-113f-11e7-873f-6fc9c9e8c121.png\">\r\n\r\n<hr>\r\n\r\nReady for review:\r\n@weedySeaDragon \r\n@thesuss \r\n\r\n### Questions / points for consideration:\r\n\r\n1. I am storing the `info` text in the DB (images are store in file system).  I think this is reasonable since company info text will not approach a huge size.\r\n\r\n2. I am not limiting the number of characters that could go into the `info` field.  The primary reason is that I don't see it as a problem since the user will see a limited window for editing (sized to typical size of `info` text plus image), and 3) `info` that is too large will push down other information in the company show page that the user will not want to get lost.\r\n\r\n3) The images stored on the server are isolated by company.\r\n\r\n4) In the #show view I have the company `info` at the top, and the address and map below that."},"comment":{"url":"https://api.github.com/repos/AgileVentures/shf-project/issues/comments/289888468","html_url":"https://github.com/AgileVentures/shf-project/pull/189#issuecomment-289888468","issue_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/189","id":289888468,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars2.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T20:06:59Z","updated_at":"2017-03-28T20:06:59Z","body":"\n[![Coverage Status](https://coveralls.io/builds/10816477/badge)](https://coveralls.io/builds/10816477)\n\nCoverage increased (+0.1%) to 98.302% when pulling **71a2c92e4bfcfafa92e3e0f1ca982a15ce9a65ff on patmbolger:edit-company-info#136724617** into **348a9809875ca212cf5a17bdc81dc340f20a0f24 on AgileVentures:develop**.\n"}}
{"actor":{"display_login":"coveralls"}}