{"action":"created","issue":{"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1267","repository_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer","labels_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1267/labels{/name}","comments_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1267/comments","events_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1267/events","html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1267","id":224627540,"number":1267,"title":"Implement GetProtocolInfo support","user":{"login":"Nadahar","id":12900583,"avatar_url":"https://avatars1.githubusercontent.com/u/12900583?v=3","gravatar_id":"","url":"https://api.github.com/users/Nadahar","html_url":"https://github.com/Nadahar","followers_url":"https://api.github.com/users/Nadahar/followers","following_url":"https://api.github.com/users/Nadahar/following{/other_user}","gists_url":"https://api.github.com/users/Nadahar/gists{/gist_id}","starred_url":"https://api.github.com/users/Nadahar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nadahar/subscriptions","organizations_url":"https://api.github.com/users/Nadahar/orgs","repos_url":"https://api.github.com/users/Nadahar/repos","events_url":"https://api.github.com/users/Nadahar/events{/privacy}","received_events_url":"https://api.github.com/users/Nadahar/received_events","type":"User","site_admin":false},"labels":[{"id":465229515,"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/labels/awaiting%20review","name":"awaiting review","color":"d93f0b","default":false},{"id":465697624,"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/labels/awaiting%20testing","name":"awaiting testing","color":"fbca04","default":false},{"id":6608012,"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2017-04-26T23:26:51Z","updated_at":"2017-05-13T00:51:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/pulls/1267","html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1267","diff_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1267.diff","patch_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1267.patch"},"body":"This implements support for querying the renderers with ```GetProtocolInfo``` and storing the reply with the renderer. While there is no easy way to apply this to audio and video since they currently don't have any DLNA format profile support, I've applied this information as a filter for the DLNA format profiles used for images and thumbnails.\r\n\r\nIt seems that one cannot trust this information absolutely (my Onkyo doesn't list any profiles for thumbnails or FLAC), and I also suspect there are renderers out there that doesn't support ```GetProtocolInfo``` at all. As a consequence, if the renderer doesn't supply any information about image profiles, all profiles are offered unfiltered.\r\n\r\nWhile I don't expect this to give any noticable results for anything but in rare cases (like @Sami32's preview window), I think it's a nice foundation to build on for better DLNA support in the future also for audio and video media. This also provides additional logging which will make it much easier to determine what profiles a renderer supports, and to debug renderer issues in general.\r\n\r\nIf this turns out to work well, there is room for optimization as this implementation first adds the unsupported profiles and then filters them."},"comment":{"url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/comments/301214793","html_url":"https://github.com/UniversalMediaServer/UniversalMediaServer/pull/1267#issuecomment-301214793","issue_url":"https://api.github.com/repos/UniversalMediaServer/UniversalMediaServer/issues/1267","id":301214793,"user":{"login":"Nadahar","id":12900583,"avatar_url":"https://avatars1.githubusercontent.com/u/12900583?v=3","gravatar_id":"","url":"https://api.github.com/users/Nadahar","html_url":"https://github.com/Nadahar","followers_url":"https://api.github.com/users/Nadahar/followers","following_url":"https://api.github.com/users/Nadahar/following{/other_user}","gists_url":"https://api.github.com/users/Nadahar/gists{/gist_id}","starred_url":"https://api.github.com/users/Nadahar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nadahar/subscriptions","organizations_url":"https://api.github.com/users/Nadahar/orgs","repos_url":"https://api.github.com/users/Nadahar/repos","events_url":"https://api.github.com/users/Nadahar/events{/privacy}","received_events_url":"https://api.github.com/users/Nadahar/received_events","type":"User","site_admin":false},"created_at":"2017-05-13T00:51:11Z","updated_at":"2017-05-13T00:51:11Z","body":"@valib Thanks for testing. I don't understand why it doesn't discover your Panasonic though. I haven't done anything (that I know of) that has to do with the discovery on non-UPnP devices (and the only thing I've done to the discovery of UPnP devices is to send a GetProtocolInfo query).\r\n\r\nI've looked in your log and I don't that your TV attempts to connect either. It must be something that prevents it from contacting UMS. Does the TV detect UMS? Can you browse form the TV? The only \"life sign\" I see from the TV is that it broadcasts M-SEARCH.\r\n\r\nIs detection working normally with latest master?"}}
{"actor":{"display_login":"Nadahar"}}