{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/104825891","pull_request_review_id":25679148,"id":104825891,"diff_hunk":"@@ -213,7 +214,9 @@ func Run(f cmdutil.Factory, cmdIn io.Reader, cmdOut, cmdErr io.Writer, cmd *cobr\n \t\t}\n \t\tswitch restartPolicy {\n \t\tcase api.RestartPolicyAlways:\n-\t\t\tif contains(resourcesList, v1beta1.SchemeGroupVersion.WithResource(\"deployments\")) {\n+\t\t\tif contains(resourcesList, appsv1beta1.SchemeGroupVersion.WithResource(\"deployments\")) {\n+\t\t\t\tgeneratorName = \"deployment/apps.v1beta1\"\n+\t\t\t} else if contains(resourcesList, extensionsv1beta1.SchemeGroupVersion.WithResource(\"deployments\")) {\n \t\t\t\tgeneratorName = \"deployment/v1beta1\"","path":"pkg/kubectl/cmd/run.go","position":19,"original_position":19,"commit_id":"f5357872439f59cf9c267f63cf71854c79716dbe","original_commit_id":"f5357872439f59cf9c267f63cf71854c79716dbe","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars2.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"body":"Also, add a note to deprecate `deployment/v1beta1` so that we can default to `deployment/apps.v1beta1` in the future. ","created_at":"2017-03-08T01:35:12Z","updated_at":"2017-03-08T01:35:12Z","html_url":"https://github.com/kubernetes/kubernetes/pull/42362#discussion_r104825891","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42362","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/104825891"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/42362#discussion_r104825891"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42362"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42362","id":108634762,"html_url":"https://github.com/kubernetes/kubernetes/pull/42362","diff_url":"https://github.com/kubernetes/kubernetes/pull/42362.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/42362.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42362","number":42362,"state":"open","locked":false,"title":"Fix deployment generator after introducing deployments in apps/v1beta1","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars1.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"body":"This PR does two things:\r\n\r\n1. Switches all generator to produce versioned objects, to bypass the problem of having an object in multiple versions, which then results in not having stable generator (iow. producing exactly the same object).\r\n2. Introduces new generator for `apps/v1beta1` deployments.\r\n\r\n@kargakis @janetkuo ptal\r\n\r\n@kubernetes/sig-apps-pr-reviews @kubernetes/sig-cli-pr-reviews ptal\r\n\r\nThis is a followup to https://github.com/kubernetes/kubernetes/pull/39683, so I'm adding 1.6 milestone.\r\n\r\n```release-note\r\nIntroduce new generator for apps/v1beta1 deployments\r\n```\r\n","created_at":"2017-03-01T21:41:10Z","updated_at":"2017-03-08T01:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41d58c96716c62d0c6aa91ea7b3e3c202252ce9b","assignee":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars0.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"kargakis","id":3900799,"avatar_url":"https://avatars0.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars2.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31","html_url":"https://github.com/kubernetes/kubernetes/milestone/31","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/31/labels","id":2130587,"number":31,"title":"v1.6","description":"","creator":{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars2.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false},"open_issues":534,"closed_issues":803,"state":"open","created_at":"2016-11-12T00:35:38Z","updated_at":"2017-03-08T01:14:33Z","due_on":"2017-03-22T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42362/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42362/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42362/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f5357872439f59cf9c267f63cf71854c79716dbe","head":{"label":"soltysh:deployment_generators","ref":"deployment_generators","sha":"f5357872439f59cf9c267f63cf71854c79716dbe","user":{"login":"soltysh","id":576341,"avatar_url":"https://avatars1.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"repo":{"id":22375428,"name":"kubernetes","full_name":"soltysh/kubernetes","owner":{"login":"soltysh","id":576341,"avatar_url":"https://avatars1.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/soltysh/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/soltysh/kubernetes","forks_url":"https://api.github.com/repos/soltysh/kubernetes/forks","keys_url":"https://api.github.com/repos/soltysh/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/soltysh/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/soltysh/kubernetes/teams","hooks_url":"https://api.github.com/repos/soltysh/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/soltysh/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/soltysh/kubernetes/events","assignees_url":"https://api.github.com/repos/soltysh/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/soltysh/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/soltysh/kubernetes/tags","blobs_url":"https://api.github.com/repos/soltysh/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/soltysh/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/soltysh/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/soltysh/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/soltysh/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/soltysh/kubernetes/languages","stargazers_url":"https://api.github.com/repos/soltysh/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/soltysh/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/soltysh/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/soltysh/kubernetes/subscription","commits_url":"https://api.github.com/repos/soltysh/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/soltysh/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/soltysh/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/soltysh/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/soltysh/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/soltysh/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/soltysh/kubernetes/merges","archive_url":"https://api.github.com/repos/soltysh/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/soltysh/kubernetes/downloads","issues_url":"https://api.github.com/repos/soltysh/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/soltysh/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/soltysh/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/soltysh/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/soltysh/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/soltysh/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/soltysh/kubernetes/deployments","created_at":"2014-07-29T09:56:32Z","updated_at":"2016-01-11T08:57:41Z","pushed_at":"2017-03-07T20:02:09Z","git_url":"git://github.com/soltysh/kubernetes.git","ssh_url":"git@github.com:soltysh/kubernetes.git","clone_url":"https://github.com/soltysh/kubernetes.git","svn_url":"https://github.com/soltysh/kubernetes","homepage":null,"size":407363,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"61e7d1ebf1e19023bc48cc573fbbbe20f0f01f0d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-03-07T23:44:39Z","pushed_at":"2017-03-08T01:18:05Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":565852,"stargazers_count":21214,"watchers_count":21214,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7264,"mirror_url":null,"open_issues_count":5593,"forks":7264,"open_issues":5593,"watchers":21214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42362"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/42362"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/42362"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/42362/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42362/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42362/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f5357872439f59cf9c267f63cf71854c79716dbe"}}}}
{"actor":{"display_login":"janetkuo"}}