{"action":"closed","issue":{"url":"https://api.github.com/repos/jfroelich/rss-reader/issues/252","repository_url":"https://api.github.com/repos/jfroelich/rss-reader","labels_url":"https://api.github.com/repos/jfroelich/rss-reader/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/jfroelich/rss-reader/issues/252/comments","events_url":"https://api.github.com/repos/jfroelich/rss-reader/issues/252/events","html_url":"https://github.com/jfroelich/rss-reader/issues/252","id":188947427,"number":252,"title":"DesktopNotification should be a class that can have instances","user":{"login":"jfroelich","id":7458347,"avatar_url":"https://avatars3.githubusercontent.com/u/7458347?v=4","gravatar_id":"","url":"https://api.github.com/users/jfroelich","html_url":"https://github.com/jfroelich","followers_url":"https://api.github.com/users/jfroelich/followers","following_url":"https://api.github.com/users/jfroelich/following{/other_user}","gists_url":"https://api.github.com/users/jfroelich/gists{/gist_id}","starred_url":"https://api.github.com/users/jfroelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfroelich/subscriptions","organizations_url":"https://api.github.com/users/jfroelich/orgs","repos_url":"https://api.github.com/users/jfroelich/repos","events_url":"https://api.github.com/users/jfroelich/events{/privacy}","received_events_url":"https://api.github.com/users/jfroelich/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"jfroelich","id":7458347,"avatar_url":"https://avatars3.githubusercontent.com/u/7458347?v=4","gravatar_id":"","url":"https://api.github.com/users/jfroelich","html_url":"https://github.com/jfroelich","followers_url":"https://api.github.com/users/jfroelich/followers","following_url":"https://api.github.com/users/jfroelich/following{/other_user}","gists_url":"https://api.github.com/users/jfroelich/gists{/gist_id}","starred_url":"https://api.github.com/users/jfroelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfroelich/subscriptions","organizations_url":"https://api.github.com/users/jfroelich/orgs","repos_url":"https://api.github.com/users/jfroelich/repos","events_url":"https://api.github.com/users/jfroelich/events{/privacy}","received_events_url":"https://api.github.com/users/jfroelich/received_events","type":"User","site_admin":false},"assignees":[{"login":"jfroelich","id":7458347,"avatar_url":"https://avatars3.githubusercontent.com/u/7458347?v=4","gravatar_id":"","url":"https://api.github.com/users/jfroelich","html_url":"https://github.com/jfroelich","followers_url":"https://api.github.com/users/jfroelich/followers","following_url":"https://api.github.com/users/jfroelich/following{/other_user}","gists_url":"https://api.github.com/users/jfroelich/gists{/gist_id}","starred_url":"https://api.github.com/users/jfroelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfroelich/subscriptions","organizations_url":"https://api.github.com/users/jfroelich/orgs","repos_url":"https://api.github.com/users/jfroelich/repos","events_url":"https://api.github.com/users/jfroelich/events{/privacy}","received_events_url":"https://api.github.com/users/jfroelich/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-11-13T02:19:52Z","updated_at":"2017-08-05T15:03:06Z","closed_at":"2017-08-05T15:03:06Z","body":"For example, SubscriptionService should have a notifier property. If the property is set to an instance of the DesktopNotification instance, then it fires off a notification to that, and DesktopNotification deals with showing the notification. If the property is not set, then it means that the SubscriptionService should not do notifications. Or maybe it is always set and DesktopNotification class has some boolean property \"enabled\" that is initialized to true, checked when calling show, and can be set to false if the show method should exit early.\r\n\r\nThen I do not need to have a suppressNotifications property of SubscriptionService. I just have a notifier property instead."}}
{"actor":{"display_login":"jfroelich"}}