{"action":"created","comment":{"url":"https://api.github.com/repos/drpoggi/compysition/pulls/comments/131215685","pull_request_review_id":54173367,"id":131215685,"diff_hunk":"@@ -73,14 +73,19 @@ def __init__(self, size=0):\n         self.error = _InternalQueuePool(size=size)\n         self.logs = _InternalQueuePool(size=size, placeholder=uuid().get_hex())\n \n-    def list_all_queues(self):\n-        queue_list = self.inbound.values() + self.outbound.values() + self.error.values() + self.logs.values()\n-        return queue_list\n+    def _list_of_queue_lists(self):\n+        return [\n+            self.inbound,\n+            self.outbound,\n+            self.error,\n+            self.logs\n+        ]\n \n     def join(self):\n         \"\"\"**Blocks until all queues in the pool are empty.**\"\"\"\n-        for queue in self.list_all_queues():\n-            queue.wait_until_empty()\n+        for lst in self._list_of_queue_lists():","path":"compysition/queue.py","position":19,"original_position":19,"commit_id":"2908dbcae2f4190ef2d89e9c60dd48813ec39c9e","original_commit_id":"2908dbcae2f4190ef2d89e9c60dd48813ec39c9e","user":{"login":"bkrantz","id":18538940,"avatar_url":"https://avatars3.githubusercontent.com/u/18538940?v=4","gravatar_id":"","url":"https://api.github.com/users/bkrantz","html_url":"https://github.com/bkrantz","followers_url":"https://api.github.com/users/bkrantz/followers","following_url":"https://api.github.com/users/bkrantz/following{/other_user}","gists_url":"https://api.github.com/users/bkrantz/gists{/gist_id}","starred_url":"https://api.github.com/users/bkrantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkrantz/subscriptions","organizations_url":"https://api.github.com/users/bkrantz/orgs","repos_url":"https://api.github.com/users/bkrantz/repos","events_url":"https://api.github.com/users/bkrantz/events{/privacy}","received_events_url":"https://api.github.com/users/bkrantz/received_events","type":"User","site_admin":false},"body":"I don't like this change as I am removing a function all together and it feels \"hacky\" (and haven't fully tested).  Though the theory was to iterate each list rather than iterating a **new** merged list.","created_at":"2017-08-03T17:56:08Z","updated_at":"2017-08-03T17:56:08Z","html_url":"https://github.com/drpoggi/compysition/pull/1#discussion_r131215685","pull_request_url":"https://api.github.com/repos/drpoggi/compysition/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/drpoggi/compysition/pulls/comments/131215685"},"html":{"href":"https://github.com/drpoggi/compysition/pull/1#discussion_r131215685"},"pull_request":{"href":"https://api.github.com/repos/drpoggi/compysition/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/drpoggi/compysition/pulls/1","id":133303489,"html_url":"https://github.com/drpoggi/compysition/pull/1","diff_url":"https://github.com/drpoggi/compysition/pull/1.diff","patch_url":"https://github.com/drpoggi/compysition/pull/1.patch","issue_url":"https://api.github.com/repos/drpoggi/compysition/issues/1","number":1,"state":"open","locked":false,"title":"from internal working branch","user":{"login":"bkrantz","id":18538940,"avatar_url":"https://avatars3.githubusercontent.com/u/18538940?v=4","gravatar_id":"","url":"https://api.github.com/users/bkrantz","html_url":"https://github.com/bkrantz","followers_url":"https://api.github.com/users/bkrantz/followers","following_url":"https://api.github.com/users/bkrantz/following{/other_user}","gists_url":"https://api.github.com/users/bkrantz/gists{/gist_id}","starred_url":"https://api.github.com/users/bkrantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkrantz/subscriptions","organizations_url":"https://api.github.com/users/bkrantz/orgs","repos_url":"https://api.github.com/users/bkrantz/repos","events_url":"https://api.github.com/users/bkrantz/events{/privacy}","received_events_url":"https://api.github.com/users/bkrantz/received_events","type":"User","site_admin":false},"body":"Changes include ...\r\n\r\nImplemented error handling override,\r\nImplemented small flow controlling changes,\r\nRemoved blanket excepts\r\nImplemented iterables where possible\r\nUpdated setup.py file","created_at":"2017-07-31T18:13:33Z","updated_at":"2017-08-03T17:56:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c16fe7a36b6dba15db4717816ca85dbe832fdb78","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/drpoggi/compysition/pulls/1/commits","review_comments_url":"https://api.github.com/repos/drpoggi/compysition/pulls/1/comments","review_comment_url":"https://api.github.com/repos/drpoggi/compysition/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drpoggi/compysition/issues/1/comments","statuses_url":"https://api.github.com/repos/drpoggi/compysition/statuses/2908dbcae2f4190ef2d89e9c60dd48813ec39c9e","head":{"label":"bkrantz:master","ref":"master","sha":"2908dbcae2f4190ef2d89e9c60dd48813ec39c9e","user":{"login":"bkrantz","id":18538940,"avatar_url":"https://avatars3.githubusercontent.com/u/18538940?v=4","gravatar_id":"","url":"https://api.github.com/users/bkrantz","html_url":"https://github.com/bkrantz","followers_url":"https://api.github.com/users/bkrantz/followers","following_url":"https://api.github.com/users/bkrantz/following{/other_user}","gists_url":"https://api.github.com/users/bkrantz/gists{/gist_id}","starred_url":"https://api.github.com/users/bkrantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkrantz/subscriptions","organizations_url":"https://api.github.com/users/bkrantz/orgs","repos_url":"https://api.github.com/users/bkrantz/repos","events_url":"https://api.github.com/users/bkrantz/events{/privacy}","received_events_url":"https://api.github.com/users/bkrantz/received_events","type":"User","site_admin":false},"repo":{"id":98915835,"name":"compysition","full_name":"bkrantz/compysition","owner":{"login":"bkrantz","id":18538940,"avatar_url":"https://avatars3.githubusercontent.com/u/18538940?v=4","gravatar_id":"","url":"https://api.github.com/users/bkrantz","html_url":"https://github.com/bkrantz","followers_url":"https://api.github.com/users/bkrantz/followers","following_url":"https://api.github.com/users/bkrantz/following{/other_user}","gists_url":"https://api.github.com/users/bkrantz/gists{/gist_id}","starred_url":"https://api.github.com/users/bkrantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkrantz/subscriptions","organizations_url":"https://api.github.com/users/bkrantz/orgs","repos_url":"https://api.github.com/users/bkrantz/repos","events_url":"https://api.github.com/users/bkrantz/events{/privacy}","received_events_url":"https://api.github.com/users/bkrantz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkrantz/compysition","description":"A python application framework and event loop for asynchronous event handling and processing","fork":true,"url":"https://api.github.com/repos/bkrantz/compysition","forks_url":"https://api.github.com/repos/bkrantz/compysition/forks","keys_url":"https://api.github.com/repos/bkrantz/compysition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkrantz/compysition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkrantz/compysition/teams","hooks_url":"https://api.github.com/repos/bkrantz/compysition/hooks","issue_events_url":"https://api.github.com/repos/bkrantz/compysition/issues/events{/number}","events_url":"https://api.github.com/repos/bkrantz/compysition/events","assignees_url":"https://api.github.com/repos/bkrantz/compysition/assignees{/user}","branches_url":"https://api.github.com/repos/bkrantz/compysition/branches{/branch}","tags_url":"https://api.github.com/repos/bkrantz/compysition/tags","blobs_url":"https://api.github.com/repos/bkrantz/compysition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkrantz/compysition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkrantz/compysition/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkrantz/compysition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkrantz/compysition/statuses/{sha}","languages_url":"https://api.github.com/repos/bkrantz/compysition/languages","stargazers_url":"https://api.github.com/repos/bkrantz/compysition/stargazers","contributors_url":"https://api.github.com/repos/bkrantz/compysition/contributors","subscribers_url":"https://api.github.com/repos/bkrantz/compysition/subscribers","subscription_url":"https://api.github.com/repos/bkrantz/compysition/subscription","commits_url":"https://api.github.com/repos/bkrantz/compysition/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkrantz/compysition/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkrantz/compysition/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkrantz/compysition/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkrantz/compysition/contents/{+path}","compare_url":"https://api.github.com/repos/bkrantz/compysition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkrantz/compysition/merges","archive_url":"https://api.github.com/repos/bkrantz/compysition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkrantz/compysition/downloads","issues_url":"https://api.github.com/repos/bkrantz/compysition/issues{/number}","pulls_url":"https://api.github.com/repos/bkrantz/compysition/pulls{/number}","milestones_url":"https://api.github.com/repos/bkrantz/compysition/milestones{/number}","notifications_url":"https://api.github.com/repos/bkrantz/compysition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkrantz/compysition/labels{/name}","releases_url":"https://api.github.com/repos/bkrantz/compysition/releases{/id}","deployments_url":"https://api.github.com/repos/bkrantz/compysition/deployments","created_at":"2017-07-31T18:08:28Z","updated_at":"2017-07-31T18:08:29Z","pushed_at":"2017-07-31T18:09:35Z","git_url":"git://github.com/bkrantz/compysition.git","ssh_url":"git@github.com:bkrantz/compysition.git","clone_url":"https://github.com/bkrantz/compysition.git","svn_url":"https://github.com/bkrantz/compysition","homepage":"","size":3410,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drpoggi:master","ref":"master","sha":"1d3a5faad3bfbb2eb7ef49e40eec1a5868e429bc","user":{"login":"drpoggi","id":6855663,"avatar_url":"https://avatars0.githubusercontent.com/u/6855663?v=4","gravatar_id":"","url":"https://api.github.com/users/drpoggi","html_url":"https://github.com/drpoggi","followers_url":"https://api.github.com/users/drpoggi/followers","following_url":"https://api.github.com/users/drpoggi/following{/other_user}","gists_url":"https://api.github.com/users/drpoggi/gists{/gist_id}","starred_url":"https://api.github.com/users/drpoggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpoggi/subscriptions","organizations_url":"https://api.github.com/users/drpoggi/orgs","repos_url":"https://api.github.com/users/drpoggi/repos","events_url":"https://api.github.com/users/drpoggi/events{/privacy}","received_events_url":"https://api.github.com/users/drpoggi/received_events","type":"User","site_admin":false},"repo":{"id":64865345,"name":"compysition","full_name":"drpoggi/compysition","owner":{"login":"drpoggi","id":6855663,"avatar_url":"https://avatars0.githubusercontent.com/u/6855663?v=4","gravatar_id":"","url":"https://api.github.com/users/drpoggi","html_url":"https://github.com/drpoggi","followers_url":"https://api.github.com/users/drpoggi/followers","following_url":"https://api.github.com/users/drpoggi/following{/other_user}","gists_url":"https://api.github.com/users/drpoggi/gists{/gist_id}","starred_url":"https://api.github.com/users/drpoggi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpoggi/subscriptions","organizations_url":"https://api.github.com/users/drpoggi/orgs","repos_url":"https://api.github.com/users/drpoggi/repos","events_url":"https://api.github.com/users/drpoggi/events{/privacy}","received_events_url":"https://api.github.com/users/drpoggi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drpoggi/compysition","description":"A python application framework and event loop for asynchronous event handling and processing","fork":true,"url":"https://api.github.com/repos/drpoggi/compysition","forks_url":"https://api.github.com/repos/drpoggi/compysition/forks","keys_url":"https://api.github.com/repos/drpoggi/compysition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drpoggi/compysition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drpoggi/compysition/teams","hooks_url":"https://api.github.com/repos/drpoggi/compysition/hooks","issue_events_url":"https://api.github.com/repos/drpoggi/compysition/issues/events{/number}","events_url":"https://api.github.com/repos/drpoggi/compysition/events","assignees_url":"https://api.github.com/repos/drpoggi/compysition/assignees{/user}","branches_url":"https://api.github.com/repos/drpoggi/compysition/branches{/branch}","tags_url":"https://api.github.com/repos/drpoggi/compysition/tags","blobs_url":"https://api.github.com/repos/drpoggi/compysition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drpoggi/compysition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drpoggi/compysition/git/refs{/sha}","trees_url":"https://api.github.com/repos/drpoggi/compysition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drpoggi/compysition/statuses/{sha}","languages_url":"https://api.github.com/repos/drpoggi/compysition/languages","stargazers_url":"https://api.github.com/repos/drpoggi/compysition/stargazers","contributors_url":"https://api.github.com/repos/drpoggi/compysition/contributors","subscribers_url":"https://api.github.com/repos/drpoggi/compysition/subscribers","subscription_url":"https://api.github.com/repos/drpoggi/compysition/subscription","commits_url":"https://api.github.com/repos/drpoggi/compysition/commits{/sha}","git_commits_url":"https://api.github.com/repos/drpoggi/compysition/git/commits{/sha}","comments_url":"https://api.github.com/repos/drpoggi/compysition/comments{/number}","issue_comment_url":"https://api.github.com/repos/drpoggi/compysition/issues/comments{/number}","contents_url":"https://api.github.com/repos/drpoggi/compysition/contents/{+path}","compare_url":"https://api.github.com/repos/drpoggi/compysition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drpoggi/compysition/merges","archive_url":"https://api.github.com/repos/drpoggi/compysition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drpoggi/compysition/downloads","issues_url":"https://api.github.com/repos/drpoggi/compysition/issues{/number}","pulls_url":"https://api.github.com/repos/drpoggi/compysition/pulls{/number}","milestones_url":"https://api.github.com/repos/drpoggi/compysition/milestones{/number}","notifications_url":"https://api.github.com/repos/drpoggi/compysition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drpoggi/compysition/labels{/name}","releases_url":"https://api.github.com/repos/drpoggi/compysition/releases{/id}","deployments_url":"https://api.github.com/repos/drpoggi/compysition/deployments","created_at":"2016-08-03T17:28:41Z","updated_at":"2017-07-31T18:56:58Z","pushed_at":"2017-08-03T11:17:39Z","git_url":"git://github.com/drpoggi/compysition.git","ssh_url":"git@github.com:drpoggi/compysition.git","clone_url":"https://github.com/drpoggi/compysition.git","svn_url":"https://github.com/drpoggi/compysition","homepage":"","size":3398,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drpoggi/compysition/pulls/1"},"html":{"href":"https://github.com/drpoggi/compysition/pull/1"},"issue":{"href":"https://api.github.com/repos/drpoggi/compysition/issues/1"},"comments":{"href":"https://api.github.com/repos/drpoggi/compysition/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/drpoggi/compysition/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/drpoggi/compysition/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drpoggi/compysition/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/drpoggi/compysition/statuses/2908dbcae2f4190ef2d89e9c60dd48813ec39c9e"}}}}
{"actor":{"display_login":"bkrantz"}}