{"action":"created","issue":{"url":"https://api.github.com/repos/fossasia/yaydoc/issues/224","repository_url":"https://api.github.com/repos/fossasia/yaydoc","labels_url":"https://api.github.com/repos/fossasia/yaydoc/issues/224/labels{/name}","comments_url":"https://api.github.com/repos/fossasia/yaydoc/issues/224/comments","events_url":"https://api.github.com/repos/fossasia/yaydoc/issues/224/events","html_url":"https://github.com/fossasia/yaydoc/pull/224","id":240741895,"number":224,"title":"Fixes #196 Improved subproject support","user":{"login":"pri22296","id":11555869,"avatar_url":"https://avatars0.githubusercontent.com/u/11555869?v=3","gravatar_id":"","url":"https://api.github.com/users/pri22296","html_url":"https://github.com/pri22296","followers_url":"https://api.github.com/users/pri22296/followers","following_url":"https://api.github.com/users/pri22296/following{/other_user}","gists_url":"https://api.github.com/users/pri22296/gists{/gist_id}","starred_url":"https://api.github.com/users/pri22296/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pri22296/subscriptions","organizations_url":"https://api.github.com/users/pri22296/orgs","repos_url":"https://api.github.com/users/pri22296/repos","events_url":"https://api.github.com/users/pri22296/events{/privacy}","received_events_url":"https://api.github.com/users/pri22296/received_events","type":"User","site_admin":false},"labels":[{"id":640528303,"url":"https://api.github.com/repos/fossasia/yaydoc/labels/needs-review","name":"needs-review","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"pri22296","id":11555869,"avatar_url":"https://avatars0.githubusercontent.com/u/11555869?v=3","gravatar_id":"","url":"https://api.github.com/users/pri22296","html_url":"https://github.com/pri22296","followers_url":"https://api.github.com/users/pri22296/followers","following_url":"https://api.github.com/users/pri22296/following{/other_user}","gists_url":"https://api.github.com/users/pri22296/gists{/gist_id}","starred_url":"https://api.github.com/users/pri22296/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pri22296/subscriptions","organizations_url":"https://api.github.com/users/pri22296/orgs","repos_url":"https://api.github.com/users/pri22296/repos","events_url":"https://api.github.com/users/pri22296/events{/privacy}","received_events_url":"https://api.github.com/users/pri22296/received_events","type":"User","site_admin":false},"assignees":[{"login":"pri22296","id":11555869,"avatar_url":"https://avatars0.githubusercontent.com/u/11555869?v=3","gravatar_id":"","url":"https://api.github.com/users/pri22296","html_url":"https://github.com/pri22296","followers_url":"https://api.github.com/users/pri22296/followers","following_url":"https://api.github.com/users/pri22296/following{/other_user}","gists_url":"https://api.github.com/users/pri22296/gists{/gist_id}","starred_url":"https://api.github.com/users/pri22296/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pri22296/subscriptions","organizations_url":"https://api.github.com/users/pri22296/orgs","repos_url":"https://api.github.com/users/pri22296/repos","events_url":"https://api.github.com/users/pri22296/events{/privacy}","received_events_url":"https://api.github.com/users/pri22296/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-07-05T18:48:08Z","updated_at":"2017-07-06T16:25:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fossasia/yaydoc/pulls/224","html_url":"https://github.com/fossasia/yaydoc/pull/224","diff_url":"https://github.com/fossasia/yaydoc/pull/224.diff","patch_url":"https://github.com/fossasia/yaydoc/pull/224.patch"},"body":"<!--\r\nThanks for submitting a change to yaydoc!\r\n\r\nTo make it possible for us to get your change reviewed and merged please fill out below information carefully.\r\n\r\n-->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n- Removed many redundant lines from `multiple_generate.sh`\r\n- Added support for subprojects having different `DOCPATH`. previously, it was constrained to be at `docs`.\r\n- Modified `genindex.py` so that while generating index automatically for parent project, we do not walk through the sub-project. This was done because, the sub-projects would have their own index.\r\n\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\nFixes #196 \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nThe existing implementation created a parallel script for sub-projects. This led to code being duplicated between both scripts. This PR ensures that does not happen.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nBuild Log- https://travis-ci.org/pri22296/testYaydoc2/builds/250469570\r\nGenerated Docs: https://pri22296.github.io/testYaydoc2/\r\n\r\n**Note** \r\n`susi_server` and `loklak_server` repos were specified as the sub-projects\r\n\r\n## Screenshots (if appropriate):\r\n![screenshot 174](https://user-images.githubusercontent.com/11555869/27904766-68eb10ae-625b-11e7-9819-a55874e2c8c2.png)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix \r\n- [x] New feature\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n- [x] I have read the [Contribution & Best practices Guide](https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia) and my PR follows them.\r\n- [x] There is a corresponding issue for this pull request.\r\n- [x] Mentioned the Issue number in the pull request commit message `Fixes #<number> commit message`\r\n- [x] There is only one commit per issue.\r\n"},"comment":{"url":"https://api.github.com/repos/fossasia/yaydoc/issues/comments/313447316","html_url":"https://github.com/fossasia/yaydoc/pull/224#issuecomment-313447316","issue_url":"https://api.github.com/repos/fossasia/yaydoc/issues/224","id":313447316,"user":{"login":"imujjwal96","id":8245662,"avatar_url":"https://avatars3.githubusercontent.com/u/8245662?v=3","gravatar_id":"","url":"https://api.github.com/users/imujjwal96","html_url":"https://github.com/imujjwal96","followers_url":"https://api.github.com/users/imujjwal96/followers","following_url":"https://api.github.com/users/imujjwal96/following{/other_user}","gists_url":"https://api.github.com/users/imujjwal96/gists{/gist_id}","starred_url":"https://api.github.com/users/imujjwal96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imujjwal96/subscriptions","organizations_url":"https://api.github.com/users/imujjwal96/orgs","repos_url":"https://api.github.com/users/imujjwal96/repos","events_url":"https://api.github.com/users/imujjwal96/events{/privacy}","received_events_url":"https://api.github.com/users/imujjwal96/received_events","type":"User","site_admin":false},"created_at":"2017-07-06T16:25:13Z","updated_at":"2017-07-06T16:25:13Z","body":"After adding `.yaydoc.yml`\r\n\r\n````\r\n    Console Output\r\n\r\n    Cloning Repository...\r\n    Repository Cloned Successfully!\r\n    Traceback (most recent call last):\r\n    File \"/app/modules/scripts/config.py\", line 138, in <module>\r\n    main()\r\n    File \"/app/modules/scripts/config.py\", line 131, in main\r\n    update_dict(conf, _get_yaml_config())\r\n    File \"/app/modules/scripts/config.py\", line 59, in _get_yaml_config\r\n    conf = yaml.safe_load(file)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/__init__.py\", line 94, in safe_load\r\n    return load(stream, SafeLoader)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/__init__.py\", line 72, in load\r\n    return loader.get_single_data()\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/constructor.py\", line 35, in get_single_data\r\n    node = self.get_single_node()\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 36, in get_single_node\r\n    document = self.compose_document()\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 55, in compose_document\r\n    node = self.compose_node(None, None)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 84, in compose_node\r\n    node = self.compose_mapping_node(anchor)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 133, in compose_mapping_node\r\n    item_value = self.compose_node(node, item_key)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 84, in compose_node\r\n    node = self.compose_mapping_node(anchor)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 133, in compose_mapping_node\r\n    item_value = self.compose_node(node, item_key)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 82, in compose_node\r\n    node = self.compose_sequence_node(anchor)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 111, in compose_sequence_node\r\n    node.value.append(self.compose_node(node, index))\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 84, in compose_node\r\n    node = self.compose_mapping_node(anchor)\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/composer.py\", line 127, in compose_mapping_node\r\n    while not self.check_event(MappingEndEvent):\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/parser.py\", line 98, in check_event\r\n    self.current_event = self.state()\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/parser.py\", line 428, in parse_block_mapping_key\r\n    if self.check_token(KeyToken):\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/scanner.py\", line 116, in check_token\r\n    self.fetch_more_tokens()\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/scanner.py\", line 220, in fetch_more_tokens\r\n    return self.fetch_value()\r\n    File \"/app/.heroku/python/lib/python3.6/site-packages/yaml/scanner.py\", line 576, in fetch_value\r\n    self.get_mark())\r\n    yaml.scanner.ScannerError: mapping values are not allowed here\r\n    in \".yaydoc.yml\", line 4, column 15\r\n    mkdir: cannot create directory ‘yaydoctemp’: Read-only file system\r\n    cp: cannot create directory '//yaydoctemp/': Read-only file system\r\n    cp: cannot create directory '//yaydoctemp/': Read-only file system\r\n    ./generate.sh: line 83: cd: //yaydoctemp: No such file or directory\r\n    Setting up documentation sources\r\n    Documentation setup successful!\r\n    cp: cannot create directory '//yaydoctemp/_themes/': No such file or directory\r\n    rsync: mkdir \"//yaydoctemp\" failed: Read-only file system (30)\r\n    rsync error: error in file IO (code 11) at main.c(674) [Receiver=3.1.1]\r\n    ./generate.sh: line 107: cd: //yaydoctemp: No such file or directory\r\n    No index.rst found. Auto generating...\r\n    usage: genindex.py [-h] [-s SUBPROJECTS] [-d SUB_DOCPATHS] root\r\n    genindex.py: error: argument -s/--subprojects: expected one argument\r\n    Auto generated index.rst\r\n    Starting Documentation Generation...\r\n    Running Sphinx v1.5.5\r\n    making output directory...\r\n    loading pickled environment... not yet created\r\n    building [mo]: targets for 0 po files that are out of date\r\n    building [html]: targets for 0 source files that are out of date\r\n    updating environment: 0 added, 0 changed, 0 removed\r\n    Sphinx error:\r\n    master file /app/temp/ujjwalb1996@gmail.com/0876ade4-e5c5-4dfc-8d37-da2cf01a70df/index.rst not found\r\n    Makefile:20: recipe for target 'html' failed\r\n    make: *** [html] Error 1\r\n    Failed to generate documentation.\r\n```"}}
{"actor":{"display_login":"imujjwal96"}}