{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/rpush/rpush-mongoid/pulls/6","id":147878194,"html_url":"https://github.com/rpush/rpush-mongoid/pull/6","diff_url":"https://github.com/rpush/rpush-mongoid/pull/6.diff","patch_url":"https://github.com/rpush/rpush-mongoid/pull/6.patch","issue_url":"https://api.github.com/repos/rpush/rpush-mongoid/issues/6","number":6,"state":"closed","locked":false,"title":"Update gemspec to use latest version of gems","user":{"login":"venriq","id":397755,"avatar_url":"https://avatars3.githubusercontent.com/u/397755?v=4","gravatar_id":"","url":"https://api.github.com/users/venriq","html_url":"https://github.com/venriq","followers_url":"https://api.github.com/users/venriq/followers","following_url":"https://api.github.com/users/venriq/following{/other_user}","gists_url":"https://api.github.com/users/venriq/gists{/gist_id}","starred_url":"https://api.github.com/users/venriq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venriq/subscriptions","organizations_url":"https://api.github.com/users/venriq/orgs","repos_url":"https://api.github.com/users/venriq/repos","events_url":"https://api.github.com/users/venriq/events{/privacy}","received_events_url":"https://api.github.com/users/venriq/received_events","type":"User","site_admin":false},"body":"@aried3r \r\nI was wondering if we need the `mongoid-autoinc` gem. I noticed that it's being used to generate a sequence for the `rpush_client_mongoid_notifications.integer_id` attribute. But, do we want this overhead? Couldn't we just use something like `Time.now.to_i`?\r\nI understand that parallelism would cause multiple `notifications` to hold the same `integer_id` value if we use this approach, but, would this be an issue?\r\nIn any case, the gem is there. I'll be working on the `rpush` changes soon.\r\n\r\n","created_at":"2017-10-20T19:33:04Z","updated_at":"2017-11-02T18:12:54Z","closed_at":"2017-11-02T18:12:54Z","merged_at":"2017-11-02T18:12:54Z","merge_commit_sha":"8c66b25e304d890c0234ec303c05f7cdd91bb93e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rpush/rpush-mongoid/pulls/6/commits","review_comments_url":"https://api.github.com/repos/rpush/rpush-mongoid/pulls/6/comments","review_comment_url":"https://api.github.com/repos/rpush/rpush-mongoid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpush/rpush-mongoid/issues/6/comments","statuses_url":"https://api.github.com/repos/rpush/rpush-mongoid/statuses/4153231caecf2ff1501e508bb08211ddeb819a83","head":{"label":"venriq:master","ref":"master","sha":"4153231caecf2ff1501e508bb08211ddeb819a83","user":{"login":"venriq","id":397755,"avatar_url":"https://avatars3.githubusercontent.com/u/397755?v=4","gravatar_id":"","url":"https://api.github.com/users/venriq","html_url":"https://github.com/venriq","followers_url":"https://api.github.com/users/venriq/followers","following_url":"https://api.github.com/users/venriq/following{/other_user}","gists_url":"https://api.github.com/users/venriq/gists{/gist_id}","starred_url":"https://api.github.com/users/venriq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venriq/subscriptions","organizations_url":"https://api.github.com/users/venriq/orgs","repos_url":"https://api.github.com/users/venriq/repos","events_url":"https://api.github.com/users/venriq/events{/privacy}","received_events_url":"https://api.github.com/users/venriq/received_events","type":"User","site_admin":false},"repo":{"id":57224684,"name":"rpush-mongoid","full_name":"venriq/rpush-mongoid","owner":{"login":"venriq","id":397755,"avatar_url":"https://avatars3.githubusercontent.com/u/397755?v=4","gravatar_id":"","url":"https://api.github.com/users/venriq","html_url":"https://github.com/venriq","followers_url":"https://api.github.com/users/venriq/followers","following_url":"https://api.github.com/users/venriq/following{/other_user}","gists_url":"https://api.github.com/users/venriq/gists{/gist_id}","starred_url":"https://api.github.com/users/venriq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venriq/subscriptions","organizations_url":"https://api.github.com/users/venriq/orgs","repos_url":"https://api.github.com/users/venriq/repos","events_url":"https://api.github.com/users/venriq/events{/privacy}","received_events_url":"https://api.github.com/users/venriq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/venriq/rpush-mongoid","description":"Provides the needed dependencies to use MongoDB with Rpush.","fork":true,"url":"https://api.github.com/repos/venriq/rpush-mongoid","forks_url":"https://api.github.com/repos/venriq/rpush-mongoid/forks","keys_url":"https://api.github.com/repos/venriq/rpush-mongoid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/venriq/rpush-mongoid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/venriq/rpush-mongoid/teams","hooks_url":"https://api.github.com/repos/venriq/rpush-mongoid/hooks","issue_events_url":"https://api.github.com/repos/venriq/rpush-mongoid/issues/events{/number}","events_url":"https://api.github.com/repos/venriq/rpush-mongoid/events","assignees_url":"https://api.github.com/repos/venriq/rpush-mongoid/assignees{/user}","branches_url":"https://api.github.com/repos/venriq/rpush-mongoid/branches{/branch}","tags_url":"https://api.github.com/repos/venriq/rpush-mongoid/tags","blobs_url":"https://api.github.com/repos/venriq/rpush-mongoid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/venriq/rpush-mongoid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/venriq/rpush-mongoid/git/refs{/sha}","trees_url":"https://api.github.com/repos/venriq/rpush-mongoid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/venriq/rpush-mongoid/statuses/{sha}","languages_url":"https://api.github.com/repos/venriq/rpush-mongoid/languages","stargazers_url":"https://api.github.com/repos/venriq/rpush-mongoid/stargazers","contributors_url":"https://api.github.com/repos/venriq/rpush-mongoid/contributors","subscribers_url":"https://api.github.com/repos/venriq/rpush-mongoid/subscribers","subscription_url":"https://api.github.com/repos/venriq/rpush-mongoid/subscription","commits_url":"https://api.github.com/repos/venriq/rpush-mongoid/commits{/sha}","git_commits_url":"https://api.github.com/repos/venriq/rpush-mongoid/git/commits{/sha}","comments_url":"https://api.github.com/repos/venriq/rpush-mongoid/comments{/number}","issue_comment_url":"https://api.github.com/repos/venriq/rpush-mongoid/issues/comments{/number}","contents_url":"https://api.github.com/repos/venriq/rpush-mongoid/contents/{+path}","compare_url":"https://api.github.com/repos/venriq/rpush-mongoid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/venriq/rpush-mongoid/merges","archive_url":"https://api.github.com/repos/venriq/rpush-mongoid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/venriq/rpush-mongoid/downloads","issues_url":"https://api.github.com/repos/venriq/rpush-mongoid/issues{/number}","pulls_url":"https://api.github.com/repos/venriq/rpush-mongoid/pulls{/number}","milestones_url":"https://api.github.com/repos/venriq/rpush-mongoid/milestones{/number}","notifications_url":"https://api.github.com/repos/venriq/rpush-mongoid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/venriq/rpush-mongoid/labels{/name}","releases_url":"https://api.github.com/repos/venriq/rpush-mongoid/releases{/id}","deployments_url":"https://api.github.com/repos/venriq/rpush-mongoid/deployments","created_at":"2016-04-27T15:31:11Z","updated_at":"2016-04-27T15:31:11Z","pushed_at":"2017-10-20T21:25:39Z","git_url":"git://github.com/venriq/rpush-mongoid.git","ssh_url":"git@github.com:venriq/rpush-mongoid.git","clone_url":"https://github.com/venriq/rpush-mongoid.git","svn_url":"https://github.com/venriq/rpush-mongoid","homepage":"","size":5,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rpush:master","ref":"master","sha":"2683de629bd9b37bff3e7719c4d4110c18b47551","user":{"login":"rpush","id":3169839,"avatar_url":"https://avatars1.githubusercontent.com/u/3169839?v=4","gravatar_id":"","url":"https://api.github.com/users/rpush","html_url":"https://github.com/rpush","followers_url":"https://api.github.com/users/rpush/followers","following_url":"https://api.github.com/users/rpush/following{/other_user}","gists_url":"https://api.github.com/users/rpush/gists{/gist_id}","starred_url":"https://api.github.com/users/rpush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpush/subscriptions","organizations_url":"https://api.github.com/users/rpush/orgs","repos_url":"https://api.github.com/users/rpush/repos","events_url":"https://api.github.com/users/rpush/events{/privacy}","received_events_url":"https://api.github.com/users/rpush/received_events","type":"Organization","site_admin":false},"repo":{"id":30473143,"name":"rpush-mongoid","full_name":"rpush/rpush-mongoid","owner":{"login":"rpush","id":3169839,"avatar_url":"https://avatars1.githubusercontent.com/u/3169839?v=4","gravatar_id":"","url":"https://api.github.com/users/rpush","html_url":"https://github.com/rpush","followers_url":"https://api.github.com/users/rpush/followers","following_url":"https://api.github.com/users/rpush/following{/other_user}","gists_url":"https://api.github.com/users/rpush/gists{/gist_id}","starred_url":"https://api.github.com/users/rpush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpush/subscriptions","organizations_url":"https://api.github.com/users/rpush/orgs","repos_url":"https://api.github.com/users/rpush/repos","events_url":"https://api.github.com/users/rpush/events{/privacy}","received_events_url":"https://api.github.com/users/rpush/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpush/rpush-mongoid","description":"Provides the needed dependencies to use MongoDB with Rpush.","fork":false,"url":"https://api.github.com/repos/rpush/rpush-mongoid","forks_url":"https://api.github.com/repos/rpush/rpush-mongoid/forks","keys_url":"https://api.github.com/repos/rpush/rpush-mongoid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpush/rpush-mongoid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpush/rpush-mongoid/teams","hooks_url":"https://api.github.com/repos/rpush/rpush-mongoid/hooks","issue_events_url":"https://api.github.com/repos/rpush/rpush-mongoid/issues/events{/number}","events_url":"https://api.github.com/repos/rpush/rpush-mongoid/events","assignees_url":"https://api.github.com/repos/rpush/rpush-mongoid/assignees{/user}","branches_url":"https://api.github.com/repos/rpush/rpush-mongoid/branches{/branch}","tags_url":"https://api.github.com/repos/rpush/rpush-mongoid/tags","blobs_url":"https://api.github.com/repos/rpush/rpush-mongoid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpush/rpush-mongoid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpush/rpush-mongoid/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpush/rpush-mongoid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpush/rpush-mongoid/statuses/{sha}","languages_url":"https://api.github.com/repos/rpush/rpush-mongoid/languages","stargazers_url":"https://api.github.com/repos/rpush/rpush-mongoid/stargazers","contributors_url":"https://api.github.com/repos/rpush/rpush-mongoid/contributors","subscribers_url":"https://api.github.com/repos/rpush/rpush-mongoid/subscribers","subscription_url":"https://api.github.com/repos/rpush/rpush-mongoid/subscription","commits_url":"https://api.github.com/repos/rpush/rpush-mongoid/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpush/rpush-mongoid/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpush/rpush-mongoid/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpush/rpush-mongoid/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpush/rpush-mongoid/contents/{+path}","compare_url":"https://api.github.com/repos/rpush/rpush-mongoid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpush/rpush-mongoid/merges","archive_url":"https://api.github.com/repos/rpush/rpush-mongoid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpush/rpush-mongoid/downloads","issues_url":"https://api.github.com/repos/rpush/rpush-mongoid/issues{/number}","pulls_url":"https://api.github.com/repos/rpush/rpush-mongoid/pulls{/number}","milestones_url":"https://api.github.com/repos/rpush/rpush-mongoid/milestones{/number}","notifications_url":"https://api.github.com/repos/rpush/rpush-mongoid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpush/rpush-mongoid/labels{/name}","releases_url":"https://api.github.com/repos/rpush/rpush-mongoid/releases{/id}","deployments_url":"https://api.github.com/repos/rpush/rpush-mongoid/deployments","created_at":"2015-02-07T22:49:17Z","updated_at":"2015-09-12T16:58:42Z","pushed_at":"2017-11-02T18:12:54Z","git_url":"git://github.com/rpush/rpush-mongoid.git","ssh_url":"git@github.com:rpush/rpush-mongoid.git","clone_url":"https://github.com/rpush/rpush-mongoid.git","svn_url":"https://github.com/rpush/rpush-mongoid","homepage":"","size":4,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":15,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpush/rpush-mongoid/pulls/6"},"html":{"href":"https://github.com/rpush/rpush-mongoid/pull/6"},"issue":{"href":"https://api.github.com/repos/rpush/rpush-mongoid/issues/6"},"comments":{"href":"https://api.github.com/repos/rpush/rpush-mongoid/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/rpush/rpush-mongoid/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/rpush/rpush-mongoid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpush/rpush-mongoid/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/rpush/rpush-mongoid/statuses/4153231caecf2ff1501e508bb08211ddeb819a83"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aried3r","id":1301152,"avatar_url":"https://avatars1.githubusercontent.com/u/1301152?v=4","gravatar_id":"","url":"https://api.github.com/users/aried3r","html_url":"https://github.com/aried3r","followers_url":"https://api.github.com/users/aried3r/followers","following_url":"https://api.github.com/users/aried3r/following{/other_user}","gists_url":"https://api.github.com/users/aried3r/gists{/gist_id}","starred_url":"https://api.github.com/users/aried3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aried3r/subscriptions","organizations_url":"https://api.github.com/users/aried3r/orgs","repos_url":"https://api.github.com/users/aried3r/repos","events_url":"https://api.github.com/users/aried3r/events{/privacy}","received_events_url":"https://api.github.com/users/aried3r/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":7,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"aried3r"}}