{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/97674156","pull_request_review_id":18291408,"id":97674156,"diff_hunk":"@@ -114,24 +114,44 @@ public static JSONObject getJsonDataNode(String hostname, int port, int sslPort,\n     return jsonObject;\n   }\n \n-  // Increments basePort for each DataNode to ensure unique DataNode given same hostname.\n-  public static JSONArray getJsonArrayDataNodes(int dataNodeCount, String hostname, int basePort,\n+  /**\n+   * Generates an array of JSON data node objects.\n+   * Increments basePort and sslPort for each node to ensure unique DataNode given same hostname.\n+   *\n+   * @param dataNodeCount how many data nodes to generate\n+   * @param hostname the hostname for each node in the array\n+   * @param basePort the starting standard port number for nodes generated\n+   * @param sslPort the starting SSL port number for nodes generated\n+   * @param hardwareState a {@link HardwareLayout} value for each node\n+   * @param disks a {@link JSONArray} of disks for each node\n+   * @return a {@link JSONArray} of nodes\n+   */\n+  static JSONArray getJsonArrayDataNodes(int dataNodeCount, String hostname, int basePort, int sslPort,\n       HardwareState hardwareState, JSONArray disks) throws JSONException {\n     JSONArray jsonArray = new JSONArray();\n     for (int i = 0; i < dataNodeCount; ++i) {\n-      jsonArray.put(getJsonDataNode(hostname, basePort + i, hardwareState, disks));\n+      jsonArray.put(getJsonDataNode(hostname, basePort + i, sslPort + i, hardwareState, disks));\n     }\n     return jsonArray;\n   }\n \n-  // Increments basePort and sslPort for each DataNode to ensure unique DataNode given same hostname.\n-  public static JSONArray getJsonArrayDataNodes(int dataNodeCount, String hostname, int basePort, int sslPort,\n-      HardwareState hardwareState, JSONArray disks) throws JSONException {\n-    JSONArray jsonArray = new JSONArray();\n-    for (int i = 0; i < dataNodeCount; ++i) {\n-      jsonArray.put(getJsonDataNode(hostname, basePort + i, sslPort + i, hardwareState, disks));\n+  /**\n+   * Updates the given array of JSON data node objects by adding new entries to reach the total datanode count.\n+   * Increments basePort and sslPort for each node to ensure unique DataNode given same hostname.\n+   *\n+   * @param dataNodeJsonArray the datanode JSONArray to update.\n+   * @param dataNodeCount how many total datanode entries the JSONArray should have.\n+   * @param hostname the hostname for each node in the array\n+   * @param basePort the starting standard port number for nodes generated\n+   * @param sslPort the starting SSL port number for nodes generated\n+   * @param hardwareState a {@link HardwareLayout} value for each node\n+   * @param disks a {@link JSONArray} of disks for each node","path":"ambry-clustermap/src/test/java/com.github.ambry.clustermap/TestUtils.java","position":15,"original_position":44,"commit_id":"1fdb745be3f07f58418e3645444386edd5f354e2","original_commit_id":"1fdb745be3f07f58418e3645444386edd5f354e2","user":{"login":"nsivabalan","id":513218,"avatar_url":"https://avatars.githubusercontent.com/u/513218?v=3","gravatar_id":"","url":"https://api.github.com/users/nsivabalan","html_url":"https://github.com/nsivabalan","followers_url":"https://api.github.com/users/nsivabalan/followers","following_url":"https://api.github.com/users/nsivabalan/following{/other_user}","gists_url":"https://api.github.com/users/nsivabalan/gists{/gist_id}","starred_url":"https://api.github.com/users/nsivabalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsivabalan/subscriptions","organizations_url":"https://api.github.com/users/nsivabalan/orgs","repos_url":"https://api.github.com/users/nsivabalan/repos","events_url":"https://api.github.com/users/nsivabalan/events{/privacy}","received_events_url":"https://api.github.com/users/nsivabalan/received_events","type":"User","site_admin":false},"body":"does every data node added has the same set of disks?","created_at":"2017-01-24T23:07:11Z","updated_at":"2017-01-24T23:07:12Z","html_url":"https://github.com/linkedin/ambry/pull/523#discussion_r97674156","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/523","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/97674156"},"html":{"href":"https://github.com/linkedin/ambry/pull/523#discussion_r97674156"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/523"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/523","id":101504056,"html_url":"https://github.com/linkedin/ambry/pull/523","diff_url":"https://github.com/linkedin/ambry/pull/523.diff","patch_url":"https://github.com/linkedin/ambry/pull/523.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/523","number":523,"state":"open","locked":false,"title":"Add a tool to map static cluster map information into Helix","user":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars.githubusercontent.com/u/1454915?v=3","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"body":"- Add a tool to bootstrap and, from time to time, upgrade\r\n  cluster map information in Helix from the static clustermap files.\r\n- Adds tests to verify the tool's claims.\r\n- Adds certain functionalities in the test classes of the static\r\n  cluster map to help test the tool.\r\n\r\nPart of #524 \r\n\r\n--\r\nNotes:\r\n* Main changes to be reviewed are in `HelixBootstrapUpgradeTool.java` and `HelixBootstrapUpgradeToolTest.java`.\r\n* Tests cover all of the core functionalities.\r\n* We make use of a recently added [method](https://github.com/apache/helix/commit/0737d7accbf70c78bab72be02a39ad8300266fe1) in Helix. This is available in Helix 0.6.7","created_at":"2017-01-13T19:37:25Z","updated_at":"2017-01-24T23:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3d11f43da7347d8e9e3a51d37a6beb6a2a85763","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/linkedin/ambry/milestones/4","html_url":"https://github.com/linkedin/ambry/milestone/4","labels_url":"https://api.github.com/repos/linkedin/ambry/milestones/4/labels","id":2251031,"number":4,"title":"Dynamic Cluster Management","description":null,"creator":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars.githubusercontent.com/u/1454915?v=3","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2017-01-13T19:36:55Z","updated_at":"2017-01-16T04:30:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/523/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/523/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/523/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/1fdb745be3f07f58418e3645444386edd5f354e2","head":{"label":"pnarayanan:helixTool","ref":"helixTool","sha":"1fdb745be3f07f58418e3645444386edd5f354e2","user":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars.githubusercontent.com/u/1454915?v=3","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"repo":{"id":25383889,"name":"ambry","full_name":"pnarayanan/ambry","owner":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars.githubusercontent.com/u/1454915?v=3","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnarayanan/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/pnarayanan/ambry","forks_url":"https://api.github.com/repos/pnarayanan/ambry/forks","keys_url":"https://api.github.com/repos/pnarayanan/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnarayanan/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnarayanan/ambry/teams","hooks_url":"https://api.github.com/repos/pnarayanan/ambry/hooks","issue_events_url":"https://api.github.com/repos/pnarayanan/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/pnarayanan/ambry/events","assignees_url":"https://api.github.com/repos/pnarayanan/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/pnarayanan/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/pnarayanan/ambry/tags","blobs_url":"https://api.github.com/repos/pnarayanan/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnarayanan/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnarayanan/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnarayanan/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnarayanan/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/pnarayanan/ambry/languages","stargazers_url":"https://api.github.com/repos/pnarayanan/ambry/stargazers","contributors_url":"https://api.github.com/repos/pnarayanan/ambry/contributors","subscribers_url":"https://api.github.com/repos/pnarayanan/ambry/subscribers","subscription_url":"https://api.github.com/repos/pnarayanan/ambry/subscription","commits_url":"https://api.github.com/repos/pnarayanan/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnarayanan/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnarayanan/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnarayanan/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnarayanan/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/pnarayanan/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnarayanan/ambry/merges","archive_url":"https://api.github.com/repos/pnarayanan/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnarayanan/ambry/downloads","issues_url":"https://api.github.com/repos/pnarayanan/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/pnarayanan/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/pnarayanan/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/pnarayanan/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnarayanan/ambry/labels{/name}","releases_url":"https://api.github.com/repos/pnarayanan/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/pnarayanan/ambry/deployments","created_at":"2014-10-18T01:44:12Z","updated_at":"2016-11-04T00:08:34Z","pushed_at":"2017-01-23T23:06:05Z","git_url":"git://github.com/pnarayanan/ambry.git","ssh_url":"git@github.com:pnarayanan/ambry.git","clone_url":"https://github.com/pnarayanan/ambry.git","svn_url":"https://github.com/pnarayanan/ambry","homepage":null,"size":8429,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"1881ac5051d7e2602b2895f636c46f13fdcfc9ae","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2017-01-24T02:13:58Z","pushed_at":"2017-01-24T22:48:32Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"git@github.com:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":8440,"stargazers_count":800,"watchers_count":800,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":59,"forks":129,"open_issues":59,"watchers":800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/523"},"html":{"href":"https://github.com/linkedin/ambry/pull/523"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/523"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/1fdb745be3f07f58418e3645444386edd5f354e2"}}}}
{"actor":{"display_login":"nsivabalan"}}