{"action":"created","issue":{"url":"https://api.github.com/repos/arvidn/libtorrent/issues/2135","repository_url":"https://api.github.com/repos/arvidn/libtorrent","labels_url":"https://api.github.com/repos/arvidn/libtorrent/issues/2135/labels{/name}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/2135/comments","events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/2135/events","html_url":"https://github.com/arvidn/libtorrent/pull/2135","id":241533161,"number":2135,"title":"torrent flags refactor","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars4.githubusercontent.com/u/661450?v=4","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-09T15:45:42Z","updated_at":"2017-07-16T18:27:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/2135","html_url":"https://github.com/arvidn/libtorrent/pull/2135","diff_url":"https://github.com/arvidn/libtorrent/pull/2135.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/2135.patch"},"body":"this amends https://github.com/arvidn/libtorrent/pull/2119 with making the flags strongly typed"},"comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments/315627497","html_url":"https://github.com/arvidn/libtorrent/pull/2135#issuecomment-315627497","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/2135","id":315627497,"user":{"login":"AllSeeingEyeTolledEweSew","id":23252004,"avatar_url":"https://avatars5.githubusercontent.com/u/23252004?v=4","gravatar_id":"","url":"https://api.github.com/users/AllSeeingEyeTolledEweSew","html_url":"https://github.com/AllSeeingEyeTolledEweSew","followers_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/followers","following_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/following{/other_user}","gists_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/gists{/gist_id}","starred_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/subscriptions","organizations_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/orgs","repos_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/repos","events_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/events{/privacy}","received_events_url":"https://api.github.com/users/AllSeeingEyeTolledEweSew/received_events","type":"User","site_admin":false},"created_at":"2017-07-16T18:27:44Z","updated_at":"2017-07-16T18:27:44Z","body":"Looks good overall. I actually started writing this myself: see https://github.com/AllSeeingEyeTolledEweSew/libtorrent/tree/asetes-torrent-flags-enum-class . I branched this from my #2119 branch. I thought it might go in a separate PR, but couldn't figure out how to create a new PR based off of a pending PR (this instinct comes from big-software-house source control processes, I guess it doesn't fit github as well), so I was waiting for #2119 to land.\r\n\r\nI had a few differences: I ended up adding `operator<<(std::ostream&, x)` to make it easier to log the flags.\r\n\r\nWould you mind also adding a python binding for the torrent_flags class? I have one in my branch.\r\n\r\nI kept `add_torrent_params::flags_t` separate from `torrent_flags`, but kept the numeric spaces the same. I like your approach more though; not all flags can be set in all cases (`seed_mode`) so there's no surprise that some flags only apply to `add_torrent`. May as well have a single class."}}
{"actor":{"display_login":"AllSeeingEyeTolledEweSew"}}