{"action":"created","comment":{"url":"https://api.github.com/repos/mamedev/mame/pulls/comments/100231094","pull_request_review_id":20930071,"id":100231094,"diff_hunk":"@@ -209,36 +442,126 @@ PALETTE_INIT_MEMBER(ms0515_state, ms0515)\n \tpalette.set_pen_color(15, rgb_t(255, 255, 255));\n }\n \n-WRITE8_MEMBER(ms0515_state::ms0515_portc_w)\n+// from vt240.cpp\n+void ms0515_state::irq_encoder(int irq, int state)\n+{\n+\tif(state == ASSERT_LINE)","path":"src/mame/drivers/ms0515.cpp","position":437,"original_position":437,"commit_id":"6b02619a47ed6f859fb002ac3357150bebcdf3f9","original_commit_id":"6b02619a47ed6f859fb002ac3357150bebcdf3f9","user":{"login":"cuavas","id":9678431,"avatar_url":"https://avatars.githubusercontent.com/u/9678431?v=3","gravatar_id":"","url":"https://api.github.com/users/cuavas","html_url":"https://github.com/cuavas","followers_url":"https://api.github.com/users/cuavas/followers","following_url":"https://api.github.com/users/cuavas/following{/other_user}","gists_url":"https://api.github.com/users/cuavas/gists{/gist_id}","starred_url":"https://api.github.com/users/cuavas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuavas/subscriptions","organizations_url":"https://api.github.com/users/cuavas/orgs","repos_url":"https://api.github.com/users/cuavas/repos","events_url":"https://api.github.com/users/cuavas/events{/privacy}","received_events_url":"https://api.github.com/users/cuavas/received_events","type":"User","site_admin":false},"body":"Spacing isn't consistent with the rest of the file here - there's no space after the `if` in this function while there is everywhere else.","created_at":"2017-02-09T05:00:30Z","updated_at":"2017-02-09T05:01:17Z","html_url":"https://github.com/mamedev/mame/pull/2052#discussion_r100231094","pull_request_url":"https://api.github.com/repos/mamedev/mame/pulls/2052","_links":{"self":{"href":"https://api.github.com/repos/mamedev/mame/pulls/comments/100231094"},"html":{"href":"https://github.com/mamedev/mame/pull/2052#discussion_r100231094"},"pull_request":{"href":"https://api.github.com/repos/mamedev/mame/pulls/2052"}}},"pull_request":{"url":"https://api.github.com/repos/mamedev/mame/pulls/2052","id":105328621,"html_url":"https://github.com/mamedev/mame/pull/2052","diff_url":"https://github.com/mamedev/mame/pull/2052.diff","patch_url":"https://github.com/mamedev/mame/pull/2052.patch","issue_url":"https://api.github.com/repos/mamedev/mame/issues/2052","number":2052,"state":"open","locked":false,"title":"ms0515.cpp -- hook up keyboard and floppy, improve video emulation etc.","user":{"login":"shattered","id":691524,"avatar_url":"https://avatars.githubusercontent.com/u/691524?v=3","gravatar_id":"","url":"https://api.github.com/users/shattered","html_url":"https://github.com/shattered","followers_url":"https://api.github.com/users/shattered/followers","following_url":"https://api.github.com/users/shattered/following{/other_user}","gists_url":"https://api.github.com/users/shattered/gists{/gist_id}","starred_url":"https://api.github.com/users/shattered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shattered/subscriptions","organizations_url":"https://api.github.com/users/shattered/orgs","repos_url":"https://api.github.com/users/shattered/repos","events_url":"https://api.github.com/users/shattered/events{/privacy}","received_events_url":"https://api.github.com/users/shattered/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-08T23:24:12Z","updated_at":"2017-02-09T05:01:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8911c81dc5dbbc2e78f2921357b426981cbb9d5e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mamedev/mame/pulls/2052/commits","review_comments_url":"https://api.github.com/repos/mamedev/mame/pulls/2052/comments","review_comment_url":"https://api.github.com/repos/mamedev/mame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mamedev/mame/issues/2052/comments","statuses_url":"https://api.github.com/repos/mamedev/mame/statuses/6b02619a47ed6f859fb002ac3357150bebcdf3f9","head":{"label":"shattered:_3345c3c","ref":"_3345c3c","sha":"6b02619a47ed6f859fb002ac3357150bebcdf3f9","user":{"login":"shattered","id":691524,"avatar_url":"https://avatars.githubusercontent.com/u/691524?v=3","gravatar_id":"","url":"https://api.github.com/users/shattered","html_url":"https://github.com/shattered","followers_url":"https://api.github.com/users/shattered/followers","following_url":"https://api.github.com/users/shattered/following{/other_user}","gists_url":"https://api.github.com/users/shattered/gists{/gist_id}","starred_url":"https://api.github.com/users/shattered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shattered/subscriptions","organizations_url":"https://api.github.com/users/shattered/orgs","repos_url":"https://api.github.com/users/shattered/repos","events_url":"https://api.github.com/users/shattered/events{/privacy}","received_events_url":"https://api.github.com/users/shattered/received_events","type":"User","site_admin":false},"repo":{"id":41606609,"name":"mame","full_name":"shattered/mame","owner":{"login":"shattered","id":691524,"avatar_url":"https://avatars.githubusercontent.com/u/691524?v=3","gravatar_id":"","url":"https://api.github.com/users/shattered","html_url":"https://github.com/shattered","followers_url":"https://api.github.com/users/shattered/followers","following_url":"https://api.github.com/users/shattered/following{/other_user}","gists_url":"https://api.github.com/users/shattered/gists{/gist_id}","starred_url":"https://api.github.com/users/shattered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shattered/subscriptions","organizations_url":"https://api.github.com/users/shattered/orgs","repos_url":"https://api.github.com/users/shattered/repos","events_url":"https://api.github.com/users/shattered/events{/privacy}","received_events_url":"https://api.github.com/users/shattered/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shattered/mame","description":"In Soviet Russia, arcades emulate YOU!","fork":true,"url":"https://api.github.com/repos/shattered/mame","forks_url":"https://api.github.com/repos/shattered/mame/forks","keys_url":"https://api.github.com/repos/shattered/mame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shattered/mame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shattered/mame/teams","hooks_url":"https://api.github.com/repos/shattered/mame/hooks","issue_events_url":"https://api.github.com/repos/shattered/mame/issues/events{/number}","events_url":"https://api.github.com/repos/shattered/mame/events","assignees_url":"https://api.github.com/repos/shattered/mame/assignees{/user}","branches_url":"https://api.github.com/repos/shattered/mame/branches{/branch}","tags_url":"https://api.github.com/repos/shattered/mame/tags","blobs_url":"https://api.github.com/repos/shattered/mame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shattered/mame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shattered/mame/git/refs{/sha}","trees_url":"https://api.github.com/repos/shattered/mame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shattered/mame/statuses/{sha}","languages_url":"https://api.github.com/repos/shattered/mame/languages","stargazers_url":"https://api.github.com/repos/shattered/mame/stargazers","contributors_url":"https://api.github.com/repos/shattered/mame/contributors","subscribers_url":"https://api.github.com/repos/shattered/mame/subscribers","subscription_url":"https://api.github.com/repos/shattered/mame/subscription","commits_url":"https://api.github.com/repos/shattered/mame/commits{/sha}","git_commits_url":"https://api.github.com/repos/shattered/mame/git/commits{/sha}","comments_url":"https://api.github.com/repos/shattered/mame/comments{/number}","issue_comment_url":"https://api.github.com/repos/shattered/mame/issues/comments{/number}","contents_url":"https://api.github.com/repos/shattered/mame/contents/{+path}","compare_url":"https://api.github.com/repos/shattered/mame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shattered/mame/merges","archive_url":"https://api.github.com/repos/shattered/mame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shattered/mame/downloads","issues_url":"https://api.github.com/repos/shattered/mame/issues{/number}","pulls_url":"https://api.github.com/repos/shattered/mame/pulls{/number}","milestones_url":"https://api.github.com/repos/shattered/mame/milestones{/number}","notifications_url":"https://api.github.com/repos/shattered/mame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shattered/mame/labels{/name}","releases_url":"https://api.github.com/repos/shattered/mame/releases{/id}","deployments_url":"https://api.github.com/repos/shattered/mame/deployments","created_at":"2015-08-29T20:36:50Z","updated_at":"2015-08-29T20:37:33Z","pushed_at":"2017-02-08T23:14:39Z","git_url":"git://github.com/shattered/mame.git","ssh_url":"git@github.com:shattered/mame.git","clone_url":"https://github.com/shattered/mame.git","svn_url":"https://github.com/shattered/mame","homepage":"","size":572661,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mamedev:master","ref":"master","sha":"a5aaaa047c9dc2d65af24cc0c8351ef9b1b95977","user":{"login":"mamedev","id":9024458,"avatar_url":"https://avatars.githubusercontent.com/u/9024458?v=3","gravatar_id":"","url":"https://api.github.com/users/mamedev","html_url":"https://github.com/mamedev","followers_url":"https://api.github.com/users/mamedev/followers","following_url":"https://api.github.com/users/mamedev/following{/other_user}","gists_url":"https://api.github.com/users/mamedev/gists{/gist_id}","starred_url":"https://api.github.com/users/mamedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamedev/subscriptions","organizations_url":"https://api.github.com/users/mamedev/orgs","repos_url":"https://api.github.com/users/mamedev/repos","events_url":"https://api.github.com/users/mamedev/events{/privacy}","received_events_url":"https://api.github.com/users/mamedev/received_events","type":"Organization","site_admin":false},"repo":{"id":14303048,"name":"mame","full_name":"mamedev/mame","owner":{"login":"mamedev","id":9024458,"avatar_url":"https://avatars.githubusercontent.com/u/9024458?v=3","gravatar_id":"","url":"https://api.github.com/users/mamedev","html_url":"https://github.com/mamedev","followers_url":"https://api.github.com/users/mamedev/followers","following_url":"https://api.github.com/users/mamedev/following{/other_user}","gists_url":"https://api.github.com/users/mamedev/gists{/gist_id}","starred_url":"https://api.github.com/users/mamedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamedev/subscriptions","organizations_url":"https://api.github.com/users/mamedev/orgs","repos_url":"https://api.github.com/users/mamedev/repos","events_url":"https://api.github.com/users/mamedev/events{/privacy}","received_events_url":"https://api.github.com/users/mamedev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mamedev/mame","description":"MAME","fork":false,"url":"https://api.github.com/repos/mamedev/mame","forks_url":"https://api.github.com/repos/mamedev/mame/forks","keys_url":"https://api.github.com/repos/mamedev/mame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mamedev/mame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mamedev/mame/teams","hooks_url":"https://api.github.com/repos/mamedev/mame/hooks","issue_events_url":"https://api.github.com/repos/mamedev/mame/issues/events{/number}","events_url":"https://api.github.com/repos/mamedev/mame/events","assignees_url":"https://api.github.com/repos/mamedev/mame/assignees{/user}","branches_url":"https://api.github.com/repos/mamedev/mame/branches{/branch}","tags_url":"https://api.github.com/repos/mamedev/mame/tags","blobs_url":"https://api.github.com/repos/mamedev/mame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mamedev/mame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mamedev/mame/git/refs{/sha}","trees_url":"https://api.github.com/repos/mamedev/mame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mamedev/mame/statuses/{sha}","languages_url":"https://api.github.com/repos/mamedev/mame/languages","stargazers_url":"https://api.github.com/repos/mamedev/mame/stargazers","contributors_url":"https://api.github.com/repos/mamedev/mame/contributors","subscribers_url":"https://api.github.com/repos/mamedev/mame/subscribers","subscription_url":"https://api.github.com/repos/mamedev/mame/subscription","commits_url":"https://api.github.com/repos/mamedev/mame/commits{/sha}","git_commits_url":"https://api.github.com/repos/mamedev/mame/git/commits{/sha}","comments_url":"https://api.github.com/repos/mamedev/mame/comments{/number}","issue_comment_url":"https://api.github.com/repos/mamedev/mame/issues/comments{/number}","contents_url":"https://api.github.com/repos/mamedev/mame/contents/{+path}","compare_url":"https://api.github.com/repos/mamedev/mame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mamedev/mame/merges","archive_url":"https://api.github.com/repos/mamedev/mame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mamedev/mame/downloads","issues_url":"https://api.github.com/repos/mamedev/mame/issues{/number}","pulls_url":"https://api.github.com/repos/mamedev/mame/pulls{/number}","milestones_url":"https://api.github.com/repos/mamedev/mame/milestones{/number}","notifications_url":"https://api.github.com/repos/mamedev/mame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mamedev/mame/labels{/name}","releases_url":"https://api.github.com/repos/mamedev/mame/releases{/id}","deployments_url":"https://api.github.com/repos/mamedev/mame/deployments","created_at":"2013-11-11T14:32:13Z","updated_at":"2017-02-08T23:22:34Z","pushed_at":"2017-02-09T00:07:38Z","git_url":"git://github.com/mamedev/mame.git","ssh_url":"git@github.com:mamedev/mame.git","clone_url":"https://github.com/mamedev/mame.git","svn_url":"https://github.com/mamedev/mame","homepage":"","size":595001,"stargazers_count":2123,"watchers_count":2123,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":490,"mirror_url":null,"open_issues_count":116,"forks":490,"open_issues":116,"watchers":2123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mamedev/mame/pulls/2052"},"html":{"href":"https://github.com/mamedev/mame/pull/2052"},"issue":{"href":"https://api.github.com/repos/mamedev/mame/issues/2052"},"comments":{"href":"https://api.github.com/repos/mamedev/mame/issues/2052/comments"},"review_comments":{"href":"https://api.github.com/repos/mamedev/mame/pulls/2052/comments"},"review_comment":{"href":"https://api.github.com/repos/mamedev/mame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mamedev/mame/pulls/2052/commits"},"statuses":{"href":"https://api.github.com/repos/mamedev/mame/statuses/6b02619a47ed6f859fb002ac3357150bebcdf3f9"}}}}
{"actor":{"display_login":"cuavas"}}