{"action":"created","issue":{"url":"https://api.github.com/repos/habitat-sh/habitat/issues/1755","repository_url":"https://api.github.com/repos/habitat-sh/habitat","labels_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1755/labels{/name}","comments_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1755/comments","events_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1755/events","html_url":"https://github.com/habitat-sh/habitat/pull/1755","id":207038489,"number":1755,"title":"Fix configuration and hook compilation errors","user":{"login":"reset","id":54036,"avatar_url":"https://avatars.githubusercontent.com/u/54036?v=3","gravatar_id":"","url":"https://api.github.com/users/reset","html_url":"https://github.com/reset","followers_url":"https://api.github.com/users/reset/followers","following_url":"https://api.github.com/users/reset/following{/other_user}","gists_url":"https://api.github.com/users/reset/gists{/gist_id}","starred_url":"https://api.github.com/users/reset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reset/subscriptions","organizations_url":"https://api.github.com/users/reset/orgs","repos_url":"https://api.github.com/users/reset/repos","events_url":"https://api.github.com/users/reset/events{/privacy}","received_events_url":"https://api.github.com/users/reset/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-02-12T09:10:14Z","updated_at":"2017-02-13T02:51:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/habitat-sh/habitat/pulls/1755","html_url":"https://github.com/habitat-sh/habitat/pull/1755","diff_url":"https://github.com/habitat-sh/habitat/pull/1755.diff","patch_url":"https://github.com/habitat-sh/habitat/pull/1755.patch"},"body":"This PR addresses some bugs that I introduced from a large refactor for multi-tenant supervisor support in #1734. I also removed a few duplicate fields from the `CensusEntry` struct which have moved to the struct in it's `sys` field.\r\n\r\ntldr; This allows the supervisor to run any service that defines it's own `run` hook once again and fixes a number of edge cases I introduced due by optimizing out unnecessary allocations we were previously doing on every server tick. "},"comment":{"url":"https://api.github.com/repos/habitat-sh/habitat/issues/comments/279282608","html_url":"https://github.com/habitat-sh/habitat/pull/1755#issuecomment-279282608","issue_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1755","id":279282608,"user":{"login":"reset","id":54036,"avatar_url":"https://avatars.githubusercontent.com/u/54036?v=3","gravatar_id":"","url":"https://api.github.com/users/reset","html_url":"https://github.com/reset","followers_url":"https://api.github.com/users/reset/followers","following_url":"https://api.github.com/users/reset/following{/other_user}","gists_url":"https://api.github.com/users/reset/gists{/gist_id}","starred_url":"https://api.github.com/users/reset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reset/subscriptions","organizations_url":"https://api.github.com/users/reset/orgs","repos_url":"https://api.github.com/users/reset/repos","events_url":"https://api.github.com/users/reset/events{/privacy}","received_events_url":"https://api.github.com/users/reset/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T02:51:08Z","updated_at":"2017-02-13T02:51:08Z","body":"@bodymindarts thank you so much for being patient and joining in on the development of the supervisor with us! I'm sorry that you were greeted with such a large and difficult to navigate refactoring in exactly the same spot of code that you were modifying. I swear, it's not always like this :).\r\n\r\nYou're spot on that `{{svc.leader.ip}}` and `{{svc.leader.port}}` have been removed. This upcoming release adds a new feature called [pkg_exports](https://github.com/habitat-sh/habitat/pull/1667) which replace the hack we had in place for providing templates with `{{svc.leader.port}}`.\r\n\r\n`{{svc.leader.address}}` remains for now - I need to have a conversation with @adamhjk and see if I'm correct that `{{svc.leader.address}}` is *always* the same as `{{sys.ip}}` or if it has a different intended use.\r\n\r\nI've pushed some changes to this branch to address timing issues with hook loading and compilation which should also be performant enough for now. Your comments from the work I pushed late last night helped greatly in getting that fixed ❤️ . Let's get this merged through to get to a working base and then let's get your timing issues integrated into that. I think we can get them in for the next release for sure!"}}
{"actor":{"display_login":"reset"}}