{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/99091080","pull_request_review_id":19753418,"id":99091080,"diff_hunk":"@@ -0,0 +1,48 @@\n+<?php\n+\n+/*\n+ * This file is part of the Sylius package.\n+ *\n+ * (c) Paweł Jędrzejewski\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Sylius\\Bundle\\ApiBundle\\Form\\Type;\n+\n+use Sylius\\Bundle\\ProductBundle\\Form\\Type\\ProductVariantType as BaseProductVariantType;\n+use Symfony\\Component\\Form\\AbstractType;\n+use Symfony\\Component\\Form\\FormBuilderInterface;\n+use Symfony\\Component\\Form\\FormEvent;\n+use Symfony\\Component\\Form\\FormEvents;\n+\n+/**\n+ * @author Anna Walasek <anna.walasek@lakion.com>\n+ */\n+final class ProductVariantType extends AbstractType\n+{\n+    /**\n+     * {@inheritdoc}\n+     */\n+    public function buildForm(FormBuilderInterface $builder, array $options)\n+    {\n+        $builder->addEventListener(FormEvents::PRE_SUBMIT , function (FormEvent $event) {\n+            $data = $event->getData();\n+            $form = $event->getForm();\n+\n+            if (!array_key_exists('onHand', $data)) {\n+                $data['onHand'] = $form->getNormData()->getOnHand();","path":"src/Sylius/Bundle/ApiBundle/Form/Type/ProductVariantType.php","position":35,"original_position":35,"commit_id":"7c4cf55a58f34ea75611200a175ffc8803f0c65b","original_commit_id":"7c4cf55a58f34ea75611200a175ffc8803f0c65b","user":{"login":"pjedrzejewski","id":614970,"avatar_url":"https://avatars.githubusercontent.com/u/614970?v=3","gravatar_id":"","url":"https://api.github.com/users/pjedrzejewski","html_url":"https://github.com/pjedrzejewski","followers_url":"https://api.github.com/users/pjedrzejewski/followers","following_url":"https://api.github.com/users/pjedrzejewski/following{/other_user}","gists_url":"https://api.github.com/users/pjedrzejewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pjedrzejewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjedrzejewski/subscriptions","organizations_url":"https://api.github.com/users/pjedrzejewski/orgs","repos_url":"https://api.github.com/users/pjedrzejewski/repos","events_url":"https://api.github.com/users/pjedrzejewski/events{/privacy}","received_events_url":"https://api.github.com/users/pjedrzejewski/received_events","type":"User","site_admin":false},"body":"We could simply remove the form field from the form if onHand is not sent? WDYT?","created_at":"2017-02-02T10:32:56Z","updated_at":"2017-02-02T10:38:47Z","html_url":"https://github.com/Sylius/Sylius/pull/7348#discussion_r99091080","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/7348","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/99091080"},"html":{"href":"https://github.com/Sylius/Sylius/pull/7348#discussion_r99091080"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7348"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/7348","id":103133514,"html_url":"https://github.com/Sylius/Sylius/pull/7348","diff_url":"https://github.com/Sylius/Sylius/pull/7348.diff","patch_url":"https://github.com/Sylius/Sylius/pull/7348.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/7348","number":7348,"state":"open","locked":false,"title":"[API][ProductVariant] Crud for product variants ","user":{"login":"tuka217","id":8963048,"avatar_url":"https://avatars.githubusercontent.com/u/8963048?v=3","gravatar_id":"","url":"https://api.github.com/users/tuka217","html_url":"https://github.com/tuka217","followers_url":"https://api.github.com/users/tuka217/followers","following_url":"https://api.github.com/users/tuka217/following{/other_user}","gists_url":"https://api.github.com/users/tuka217/gists{/gist_id}","starred_url":"https://api.github.com/users/tuka217/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuka217/subscriptions","organizations_url":"https://api.github.com/users/tuka217/orgs","repos_url":"https://api.github.com/users/tuka217/repos","events_url":"https://api.github.com/users/tuka217/events{/privacy}","received_events_url":"https://api.github.com/users/tuka217/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | no |\r\n| New feature?    | no |\r\n| BC breaks?      | no |\r\n| Related tickets | - |\r\n| License         | MIT |\r\n","created_at":"2017-01-25T14:52:12Z","updated_at":"2017-02-02T10:38:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66a5263a3e129102d443eca968c91f9e3159bdba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/7348/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/7348/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/7348/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/7c4cf55a58f34ea75611200a175ffc8803f0c65b","head":{"label":"tuka217:api-product-variant","ref":"api-product-variant","sha":"7c4cf55a58f34ea75611200a175ffc8803f0c65b","user":{"login":"tuka217","id":8963048,"avatar_url":"https://avatars.githubusercontent.com/u/8963048?v=3","gravatar_id":"","url":"https://api.github.com/users/tuka217","html_url":"https://github.com/tuka217","followers_url":"https://api.github.com/users/tuka217/followers","following_url":"https://api.github.com/users/tuka217/following{/other_user}","gists_url":"https://api.github.com/users/tuka217/gists{/gist_id}","starred_url":"https://api.github.com/users/tuka217/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuka217/subscriptions","organizations_url":"https://api.github.com/users/tuka217/orgs","repos_url":"https://api.github.com/users/tuka217/repos","events_url":"https://api.github.com/users/tuka217/events{/privacy}","received_events_url":"https://api.github.com/users/tuka217/received_events","type":"User","site_admin":false},"repo":{"id":42645712,"name":"Sylius","full_name":"tuka217/Sylius","owner":{"login":"tuka217","id":8963048,"avatar_url":"https://avatars.githubusercontent.com/u/8963048?v=3","gravatar_id":"","url":"https://api.github.com/users/tuka217","html_url":"https://github.com/tuka217","followers_url":"https://api.github.com/users/tuka217/followers","following_url":"https://api.github.com/users/tuka217/following{/other_user}","gists_url":"https://api.github.com/users/tuka217/gists{/gist_id}","starred_url":"https://api.github.com/users/tuka217/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuka217/subscriptions","organizations_url":"https://api.github.com/users/tuka217/orgs","repos_url":"https://api.github.com/users/tuka217/repos","events_url":"https://api.github.com/users/tuka217/events{/privacy}","received_events_url":"https://api.github.com/users/tuka217/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tuka217/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/tuka217/Sylius","forks_url":"https://api.github.com/repos/tuka217/Sylius/forks","keys_url":"https://api.github.com/repos/tuka217/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuka217/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuka217/Sylius/teams","hooks_url":"https://api.github.com/repos/tuka217/Sylius/hooks","issue_events_url":"https://api.github.com/repos/tuka217/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/tuka217/Sylius/events","assignees_url":"https://api.github.com/repos/tuka217/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/tuka217/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/tuka217/Sylius/tags","blobs_url":"https://api.github.com/repos/tuka217/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuka217/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuka217/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuka217/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuka217/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/tuka217/Sylius/languages","stargazers_url":"https://api.github.com/repos/tuka217/Sylius/stargazers","contributors_url":"https://api.github.com/repos/tuka217/Sylius/contributors","subscribers_url":"https://api.github.com/repos/tuka217/Sylius/subscribers","subscription_url":"https://api.github.com/repos/tuka217/Sylius/subscription","commits_url":"https://api.github.com/repos/tuka217/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuka217/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuka217/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuka217/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuka217/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/tuka217/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuka217/Sylius/merges","archive_url":"https://api.github.com/repos/tuka217/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuka217/Sylius/downloads","issues_url":"https://api.github.com/repos/tuka217/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/tuka217/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/tuka217/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/tuka217/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuka217/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/tuka217/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/tuka217/Sylius/deployments","created_at":"2015-09-17T08:53:41Z","updated_at":"2016-05-16T08:23:19Z","pushed_at":"2017-02-02T10:02:56Z","git_url":"git://github.com/tuka217/Sylius.git","ssh_url":"git@github.com:tuka217/Sylius.git","clone_url":"https://github.com/tuka217/Sylius.git","svn_url":"https://github.com/tuka217/Sylius","homepage":"Sylius.org","size":54043,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"6d004bcca1b3e1bf863c4a46cbc4d4cd7616413d","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2017-02-02T03:11:59Z","pushed_at":"2017-02-02T10:16:25Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":54431,"stargazers_count":2728,"watchers_count":2728,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1014,"mirror_url":null,"open_issues_count":472,"forks":1014,"open_issues":472,"watchers":2728,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7348"},"html":{"href":"https://github.com/Sylius/Sylius/pull/7348"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/7348"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/7348/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7348/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7348/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/7c4cf55a58f34ea75611200a175ffc8803f0c65b"}}}}
{"actor":{"display_login":"pjedrzejewski"}}