{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/1804","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/1804/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/1804/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/1804/events","html_url":"https://github.com/solidusio/solidus/pull/1804","id":217484489,"number":1804,"title":"Fix Spree::Admin::VariantsController#index for deleted products","user":{"login":"bbuchalter","id":540762,"avatar_url":"https://avatars3.githubusercontent.com/u/540762?v=3","gravatar_id":"","url":"https://api.github.com/users/bbuchalter","html_url":"https://github.com/bbuchalter","followers_url":"https://api.github.com/users/bbuchalter/followers","following_url":"https://api.github.com/users/bbuchalter/following{/other_user}","gists_url":"https://api.github.com/users/bbuchalter/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuchalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuchalter/subscriptions","organizations_url":"https://api.github.com/users/bbuchalter/orgs","repos_url":"https://api.github.com/users/bbuchalter/repos","events_url":"https://api.github.com/users/bbuchalter/events{/privacy}","received_events_url":"https://api.github.com/users/bbuchalter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-28T08:30:33Z","updated_at":"2017-03-28T20:06:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/1804","html_url":"https://github.com/solidusio/solidus/pull/1804","diff_url":"https://github.com/solidusio/solidus/pull/1804.diff","patch_url":"https://github.com/solidusio/solidus/pull/1804.patch"},"body":"Fixes https://github.com/solidusio/solidus/issues/1803\r\n\r\nWhen a `Product` was deleted, `@parent` would not be set correctly when accessing `Spree::Admin::VariantsController#index`. Adding the `with_deleted` scope for the assignment to `Spree::Admin::ResourceController#parent` addresses this problem.\r\n\r\nThe heart of the change happens in https://github.com/solidusio/solidus/pull/1804/commits/dec876c158abd343fcd2c41b3153744a0f724e7d while the rest of the commits clean up the specs for `Spree::Admin::VariantsController`."},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/289888359","html_url":"https://github.com/solidusio/solidus/pull/1804#issuecomment-289888359","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/1804","id":289888359,"user":{"login":"bbuchalter","id":540762,"avatar_url":"https://avatars3.githubusercontent.com/u/540762?v=3","gravatar_id":"","url":"https://api.github.com/users/bbuchalter","html_url":"https://github.com/bbuchalter","followers_url":"https://api.github.com/users/bbuchalter/followers","following_url":"https://api.github.com/users/bbuchalter/following{/other_user}","gists_url":"https://api.github.com/users/bbuchalter/gists{/gist_id}","starred_url":"https://api.github.com/users/bbuchalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbuchalter/subscriptions","organizations_url":"https://api.github.com/users/bbuchalter/orgs","repos_url":"https://api.github.com/users/bbuchalter/repos","events_url":"https://api.github.com/users/bbuchalter/events{/privacy}","received_events_url":"https://api.github.com/users/bbuchalter/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T20:06:34Z","updated_at":"2017-03-28T20:06:34Z","body":"> We could also just override the required methods in Spree::Admin::VariantsController itself?\r\n\r\nAs I was thinking about it more, this was the direction I was taking. The question now is to what degree: do I just override `#parent` or do I stop trying to use `ResourceController` as the base of `VariantsController`? Is there an interest in moving away from `ResourceController`? "}}
{"actor":{"display_login":"bbuchalter"}}