{"action":"created","issue":{"url":"https://api.github.com/repos/SharePoint/PnP-Sites-Core/issues/1000","repository_url":"https://api.github.com/repos/SharePoint/PnP-Sites-Core","labels_url":"https://api.github.com/repos/SharePoint/PnP-Sites-Core/issues/1000/labels{/name}","comments_url":"https://api.github.com/repos/SharePoint/PnP-Sites-Core/issues/1000/comments","events_url":"https://api.github.com/repos/SharePoint/PnP-Sites-Core/issues/1000/events","html_url":"https://github.com/SharePoint/PnP-Sites-Core/issues/1000","id":203119250,"number":1000,"title":"No Private Group Support?","user":{"login":"davros85","id":22449016,"avatar_url":"https://avatars.githubusercontent.com/u/22449016?v=3","gravatar_id":"","url":"https://api.github.com/users/davros85","html_url":"https://github.com/davros85","followers_url":"https://api.github.com/users/davros85/followers","following_url":"https://api.github.com/users/davros85/following{/other_user}","gists_url":"https://api.github.com/users/davros85/gists{/gist_id}","starred_url":"https://api.github.com/users/davros85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davros85/subscriptions","organizations_url":"https://api.github.com/users/davros85/orgs","repos_url":"https://api.github.com/users/davros85/repos","events_url":"https://api.github.com/users/davros85/events{/privacy}","received_events_url":"https://api.github.com/users/davros85/received_events","type":"User","site_admin":false},"labels":[{"id":239711234,"url":"https://api.github.com/repos/SharePoint/PnP-Sites-Core/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"PaoloPia","id":7582026,"avatar_url":"https://avatars.githubusercontent.com/u/7582026?v=3","gravatar_id":"","url":"https://api.github.com/users/PaoloPia","html_url":"https://github.com/PaoloPia","followers_url":"https://api.github.com/users/PaoloPia/followers","following_url":"https://api.github.com/users/PaoloPia/following{/other_user}","gists_url":"https://api.github.com/users/PaoloPia/gists{/gist_id}","starred_url":"https://api.github.com/users/PaoloPia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaoloPia/subscriptions","organizations_url":"https://api.github.com/users/PaoloPia/orgs","repos_url":"https://api.github.com/users/PaoloPia/repos","events_url":"https://api.github.com/users/PaoloPia/events{/privacy}","received_events_url":"https://api.github.com/users/PaoloPia/received_events","type":"User","site_admin":false},"assignees":[{"login":"PaoloPia","id":7582026,"avatar_url":"https://avatars.githubusercontent.com/u/7582026?v=3","gravatar_id":"","url":"https://api.github.com/users/PaoloPia","html_url":"https://github.com/PaoloPia","followers_url":"https://api.github.com/users/PaoloPia/followers","following_url":"https://api.github.com/users/PaoloPia/following{/other_user}","gists_url":"https://api.github.com/users/PaoloPia/gists{/gist_id}","starred_url":"https://api.github.com/users/PaoloPia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaoloPia/subscriptions","organizations_url":"https://api.github.com/users/PaoloPia/orgs","repos_url":"https://api.github.com/users/PaoloPia/repos","events_url":"https://api.github.com/users/PaoloPia/events{/privacy}","received_events_url":"https://api.github.com/users/PaoloPia/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-01-25T14:36:21Z","updated_at":"2017-02-16T16:00:28Z","closed_at":"2017-02-06T20:07:04Z","body":"#### Category\r\n[X] Bug\r\n[ ] Enhancement\r\n\r\n#### Environment\r\n[X] Office 365 / SharePoint Online\r\n[ ] SharePoint 2016\r\n[ ] SharePoint 2013\r\n\r\nIf SharePoint on-premises, what's exact CU version: \r\n\r\n#### Expected or Desired Behavior\r\nWhen supplying isPrivate: true to the CreateUnifiedGroup method in the UnifiedGroupsUtility class, the Office 365 group should be created as a 'private' group, without giving read access to everyone.\r\n\r\n#### Observed Behavior\r\nThe group and modern team site are created, marked as 'Public', and with 'Everyone Except External Users' added to the members group in the SharePoint site.\r\n\r\n#### Steps to Reproduce\r\n`UnifiedGroupsUtility.CreateUnifiedGroup(\"my group\", \"-\", \"mygroup\", accessToken, owners, members, isPrivate: true, retryCount: 10, delay: 500);`\r\n\r\nHaving looked through the utility code - I can't see where the `isPrivate` variable is even being used?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/SharePoint/PnP-Sites-Core/issues/comments/280372277","html_url":"https://github.com/SharePoint/PnP-Sites-Core/issues/1000#issuecomment-280372277","issue_url":"https://api.github.com/repos/SharePoint/PnP-Sites-Core/issues/1000","id":280372277,"user":{"login":"davros85","id":22449016,"avatar_url":"https://avatars.githubusercontent.com/u/22449016?v=3","gravatar_id":"","url":"https://api.github.com/users/davros85","html_url":"https://github.com/davros85","followers_url":"https://api.github.com/users/davros85/followers","following_url":"https://api.github.com/users/davros85/following{/other_user}","gists_url":"https://api.github.com/users/davros85/gists{/gist_id}","starred_url":"https://api.github.com/users/davros85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davros85/subscriptions","organizations_url":"https://api.github.com/users/davros85/orgs","repos_url":"https://api.github.com/users/davros85/repos","events_url":"https://api.github.com/users/davros85/events{/privacy}","received_events_url":"https://api.github.com/users/davros85/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T16:00:28Z","updated_at":"2017-02-16T16:00:28Z","body":"Hi all - whilst the group now gets set to Private - if it IS, the modern site URL coming out of the process in NULL in most cases. And whilst the owner may be added to the Exchange group side, the SP site doesn't have the permissions added. Also tried creating the group as public, adding the owners etc, then setting it to Private via an update - but the Privacy update has no effect. Is this PnP or the Graph API?"}}
{"actor":{"display_login":"davros85"}}