{"action":"created","issue":{"url":"https://api.github.com/repos/zotero/translation-server/issues/47","repository_url":"https://api.github.com/repos/zotero/translation-server","labels_url":"https://api.github.com/repos/zotero/translation-server/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/zotero/translation-server/issues/47/comments","events_url":"https://api.github.com/repos/zotero/translation-server/issues/47/events","html_url":"https://github.com/zotero/translation-server/issues/47","id":236925321,"number":47,"title":"CSL JSON import fails","user":{"login":"zuphilip","id":5199995,"avatar_url":"https://avatars3.githubusercontent.com/u/5199995?v=3","gravatar_id":"","url":"https://api.github.com/users/zuphilip","html_url":"https://github.com/zuphilip","followers_url":"https://api.github.com/users/zuphilip/followers","following_url":"https://api.github.com/users/zuphilip/following{/other_user}","gists_url":"https://api.github.com/users/zuphilip/gists{/gist_id}","starred_url":"https://api.github.com/users/zuphilip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuphilip/subscriptions","organizations_url":"https://api.github.com/users/zuphilip/orgs","repos_url":"https://api.github.com/users/zuphilip/repos","events_url":"https://api.github.com/users/zuphilip/events{/privacy}","received_events_url":"https://api.github.com/users/zuphilip/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-06-19T15:14:11Z","updated_at":"2017-06-23T16:29:32Z","closed_at":null,"body":"Currently the CSL JSON import fails in the [server tests](https://zotero-translator-tests.s3.amazonaws.com/testTranslators.html#date=2017-06-19&browser=v&version=4.0.SOURCE) with\r\n\r\n```\r\nTranslatorTester: Running 1 test for CSL JSON \r\nTranslatorTester: Running CSL JSON Test 1 \r\nTranslatorTester: Translating \r\nTranslation using CSL JSON failed: \r\nstring => TypeError: invalid 'instanceof' operand Zotero.Item \r\nstack => Zotero.Utilities.itemFromCSLJSON@chrome://translation-server/content/utilities.js:1640:7 \r\nZotero.Translate.SandboxManager.prototype.importObject/attachTo[localKey]<@chrome://translation-server/content/translation/translate_firefox.js:503:29 \r\n@chrome://translation-server/content/translation/translate_firefox.js:408:66 \r\ndoImport@CSL JSON:63:3 \r\n...\r\n```\r\n\r\nThis seems to refer to this line: https://github.com/zotero/zotero/blob/e2a3a6edbb8db4ce48d090f9e99bae6dca70251e/chrome/content/zotero/xpcom/utilities.js#L1640 which is not anymore used in the current Zotero code. Especially the commit [\"Make itemFromCSLJSON independent of Zotero.Item existance\"](https://github.com/zotero/zotero/commit/dbeecb9b0a15d17ffda1065521e2442d2827a787) seems related to this issue. Can this be fixed for the translation server as well?\r\n\r\nThere are some translator based on CSL JSON which I guess are also not working therefore...\r\n\r\nCC @adam3smith"},"comment":{"url":"https://api.github.com/repos/zotero/translation-server/issues/comments/310712206","html_url":"https://github.com/zotero/translation-server/issues/47#issuecomment-310712206","issue_url":"https://api.github.com/repos/zotero/translation-server/issues/47","id":310712206,"user":{"login":"AndrewIsh","id":9194223,"avatar_url":"https://avatars0.githubusercontent.com/u/9194223?v=3","gravatar_id":"","url":"https://api.github.com/users/AndrewIsh","html_url":"https://github.com/AndrewIsh","followers_url":"https://api.github.com/users/AndrewIsh/followers","following_url":"https://api.github.com/users/AndrewIsh/following{/other_user}","gists_url":"https://api.github.com/users/AndrewIsh/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewIsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewIsh/subscriptions","organizations_url":"https://api.github.com/users/AndrewIsh/orgs","repos_url":"https://api.github.com/users/AndrewIsh/repos","events_url":"https://api.github.com/users/AndrewIsh/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewIsh/received_events","type":"User","site_admin":false},"created_at":"2017-06-23T16:29:32Z","updated_at":"2017-06-23T16:29:32Z","body":"Aha, I'd not realised you were using submodules, makes sense! How do you usually handle pulling in updates?"}}
{"actor":{"display_login":"AndrewIsh"}}