{"action":"closed","number":2098,"pull_request":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/2098","id":140975887,"html_url":"https://github.com/MetaMask/metamask-extension/pull/2098","diff_url":"https://github.com/MetaMask/metamask-extension/pull/2098.diff","patch_url":"https://github.com/MetaMask/metamask-extension/pull/2098.patch","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/2098","number":2098,"state":"closed","locked":false,"title":"Integration test suite improvements","user":{"login":"kumavis","id":1474978,"avatar_url":"https://avatars0.githubusercontent.com/u/1474978?v=4","gravatar_id":"","url":"https://api.github.com/users/kumavis","html_url":"https://github.com/kumavis","followers_url":"https://api.github.com/users/kumavis/followers","following_url":"https://api.github.com/users/kumavis/following{/other_user}","gists_url":"https://api.github.com/users/kumavis/gists{/gist_id}","starred_url":"https://api.github.com/users/kumavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumavis/subscriptions","organizations_url":"https://api.github.com/users/kumavis/orgs","repos_url":"https://api.github.com/users/kumavis/repos","events_url":"https://api.github.com/users/kumavis/events{/privacy}","received_events_url":"https://api.github.com/users/kumavis/received_events","type":"User","site_admin":false},"body":"- [x] refactor and rename npm scripts (could affect your muscle memory)\r\n- [x] migrate mascara tests to karma\r\n- [x] mascara tests - move temp build files into dist/mascara\r\n- [ ] mascara tests - get em passing (sw race condition) @frankiebee \r\n- [ ] include mascara integration tests in normal CI run\r\n- [ ] maybe get UI dev helper working again, may have broken it\r\n- [x] check in with kyokan on these changes @chikeichan @sdtsui et al","created_at":"2017-09-14T03:33:35Z","updated_at":"2017-09-18T19:54:40Z","closed_at":"2017-09-18T19:54:40Z","merged_at":"2017-09-18T19:54:40Z","merge_commit_sha":"bbae8d975e1800b37b05b35713728cd39f992071","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/2098/commits","review_comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/2098/comments","review_comment_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/2098/comments","statuses_url":"https://api.github.com/repos/MetaMask/metamask-extension/statuses/784510f89fcb460bcf77ba477fe9a7c144c25f63","head":{"label":"MetaMask:mascara-tests","ref":"mascara-tests","sha":"784510f89fcb460bcf77ba477fe9a7c144c25f63","user":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars2.githubusercontent.com/u/11744586?v=4","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"repo":{"id":42009758,"name":"metamask-extension","full_name":"MetaMask/metamask-extension","owner":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars2.githubusercontent.com/u/11744586?v=4","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaMask/metamask-extension","description":":globe_with_meridians: :electric_plug: metamask chrome extension","fork":false,"url":"https://api.github.com/repos/MetaMask/metamask-extension","forks_url":"https://api.github.com/repos/MetaMask/metamask-extension/forks","keys_url":"https://api.github.com/repos/MetaMask/metamask-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaMask/metamask-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaMask/metamask-extension/teams","hooks_url":"https://api.github.com/repos/MetaMask/metamask-extension/hooks","issue_events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/events{/number}","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/events","assignees_url":"https://api.github.com/repos/MetaMask/metamask-extension/assignees{/user}","branches_url":"https://api.github.com/repos/MetaMask/metamask-extension/branches{/branch}","tags_url":"https://api.github.com/repos/MetaMask/metamask-extension/tags","blobs_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaMask/metamask-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaMask/metamask-extension/languages","stargazers_url":"https://api.github.com/repos/MetaMask/metamask-extension/stargazers","contributors_url":"https://api.github.com/repos/MetaMask/metamask-extension/contributors","subscribers_url":"https://api.github.com/repos/MetaMask/metamask-extension/subscribers","subscription_url":"https://api.github.com/repos/MetaMask/metamask-extension/subscription","commits_url":"https://api.github.com/repos/MetaMask/metamask-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetaMask/metamask-extension/contents/{+path}","compare_url":"https://api.github.com/repos/MetaMask/metamask-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaMask/metamask-extension/merges","archive_url":"https://api.github.com/repos/MetaMask/metamask-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaMask/metamask-extension/downloads","issues_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues{/number}","pulls_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaMask/metamask-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaMask/metamask-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/labels{/name}","releases_url":"https://api.github.com/repos/MetaMask/metamask-extension/releases{/id}","deployments_url":"https://api.github.com/repos/MetaMask/metamask-extension/deployments","created_at":"2015-09-06T16:34:48Z","updated_at":"2017-09-18T13:17:38Z","pushed_at":"2017-09-18T19:54:40Z","git_url":"git://github.com/MetaMask/metamask-extension.git","ssh_url":"git@github.com:MetaMask/metamask-extension.git","clone_url":"https://github.com/MetaMask/metamask-extension.git","svn_url":"https://github.com/MetaMask/metamask-extension","homepage":"https://metamask.io/","size":17531,"stargazers_count":469,"watchers_count":469,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"open_issues_count":330,"forks":118,"open_issues":330,"watchers":469,"default_branch":"master"}},"base":{"label":"MetaMask:master","ref":"master","sha":"693655e2da7cacf5a5326b50bddc37bcece9422e","user":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars2.githubusercontent.com/u/11744586?v=4","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"repo":{"id":42009758,"name":"metamask-extension","full_name":"MetaMask/metamask-extension","owner":{"login":"MetaMask","id":11744586,"avatar_url":"https://avatars2.githubusercontent.com/u/11744586?v=4","gravatar_id":"","url":"https://api.github.com/users/MetaMask","html_url":"https://github.com/MetaMask","followers_url":"https://api.github.com/users/MetaMask/followers","following_url":"https://api.github.com/users/MetaMask/following{/other_user}","gists_url":"https://api.github.com/users/MetaMask/gists{/gist_id}","starred_url":"https://api.github.com/users/MetaMask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MetaMask/subscriptions","organizations_url":"https://api.github.com/users/MetaMask/orgs","repos_url":"https://api.github.com/users/MetaMask/repos","events_url":"https://api.github.com/users/MetaMask/events{/privacy}","received_events_url":"https://api.github.com/users/MetaMask/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MetaMask/metamask-extension","description":":globe_with_meridians: :electric_plug: metamask chrome extension","fork":false,"url":"https://api.github.com/repos/MetaMask/metamask-extension","forks_url":"https://api.github.com/repos/MetaMask/metamask-extension/forks","keys_url":"https://api.github.com/repos/MetaMask/metamask-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MetaMask/metamask-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MetaMask/metamask-extension/teams","hooks_url":"https://api.github.com/repos/MetaMask/metamask-extension/hooks","issue_events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/events{/number}","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/events","assignees_url":"https://api.github.com/repos/MetaMask/metamask-extension/assignees{/user}","branches_url":"https://api.github.com/repos/MetaMask/metamask-extension/branches{/branch}","tags_url":"https://api.github.com/repos/MetaMask/metamask-extension/tags","blobs_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MetaMask/metamask-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/MetaMask/metamask-extension/languages","stargazers_url":"https://api.github.com/repos/MetaMask/metamask-extension/stargazers","contributors_url":"https://api.github.com/repos/MetaMask/metamask-extension/contributors","subscribers_url":"https://api.github.com/repos/MetaMask/metamask-extension/subscribers","subscription_url":"https://api.github.com/repos/MetaMask/metamask-extension/subscription","commits_url":"https://api.github.com/repos/MetaMask/metamask-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/MetaMask/metamask-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/MetaMask/metamask-extension/contents/{+path}","compare_url":"https://api.github.com/repos/MetaMask/metamask-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MetaMask/metamask-extension/merges","archive_url":"https://api.github.com/repos/MetaMask/metamask-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MetaMask/metamask-extension/downloads","issues_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues{/number}","pulls_url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/MetaMask/metamask-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/MetaMask/metamask-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/labels{/name}","releases_url":"https://api.github.com/repos/MetaMask/metamask-extension/releases{/id}","deployments_url":"https://api.github.com/repos/MetaMask/metamask-extension/deployments","created_at":"2015-09-06T16:34:48Z","updated_at":"2017-09-18T13:17:38Z","pushed_at":"2017-09-18T19:54:40Z","git_url":"git://github.com/MetaMask/metamask-extension.git","ssh_url":"git@github.com:MetaMask/metamask-extension.git","clone_url":"https://github.com/MetaMask/metamask-extension.git","svn_url":"https://github.com/MetaMask/metamask-extension","homepage":"https://metamask.io/","size":17531,"stargazers_count":469,"watchers_count":469,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"open_issues_count":330,"forks":118,"open_issues":330,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/2098"},"html":{"href":"https://github.com/MetaMask/metamask-extension/pull/2098"},"issue":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/issues/2098"},"comments":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/issues/2098/comments"},"review_comments":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/2098/comments"},"review_comment":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/2098/commits"},"statuses":{"href":"https://api.github.com/repos/MetaMask/metamask-extension/statuses/784510f89fcb460bcf77ba477fe9a7c144c25f63"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"frankiebee","id":11225267,"avatar_url":"https://avatars0.githubusercontent.com/u/11225267?v=4","gravatar_id":"","url":"https://api.github.com/users/frankiebee","html_url":"https://github.com/frankiebee","followers_url":"https://api.github.com/users/frankiebee/followers","following_url":"https://api.github.com/users/frankiebee/following{/other_user}","gists_url":"https://api.github.com/users/frankiebee/gists{/gist_id}","starred_url":"https://api.github.com/users/frankiebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankiebee/subscriptions","organizations_url":"https://api.github.com/users/frankiebee/orgs","repos_url":"https://api.github.com/users/frankiebee/repos","events_url":"https://api.github.com/users/frankiebee/events{/privacy}","received_events_url":"https://api.github.com/users/frankiebee/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":14,"additions":114,"deletions":229,"changed_files":17}}
{"actor":{"display_login":"frankiebee"}}