{"action":"opened","number":19498,"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19498","id":117160694,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/19498","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/19498.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/19498.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19498","number":19498,"state":"open","locked":false,"title":"[3.3.5] Core/Quest: always send the specified RewardNextQuest regardless of eventual scripts","user":{"login":"Xyventh","id":27926164,"avatar_url":"https://avatars1.githubusercontent.com/u/27926164?v=3","gravatar_id":"","url":"https://api.github.com/users/Xyventh","html_url":"https://github.com/Xyventh","followers_url":"https://api.github.com/users/Xyventh/followers","following_url":"https://api.github.com/users/Xyventh/following{/other_user}","gists_url":"https://api.github.com/users/Xyventh/gists{/gist_id}","starred_url":"https://api.github.com/users/Xyventh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xyventh/subscriptions","organizations_url":"https://api.github.com/users/Xyventh/orgs","repos_url":"https://api.github.com/users/Xyventh/repos","events_url":"https://api.github.com/users/Xyventh/events{/privacy}","received_events_url":"https://api.github.com/users/Xyventh/received_events","type":"User","site_admin":false},"body":"**Suggested changes**:\r\n\r\nBefore this change, if the OnQuestReward() hook returned true, the quest window would get stuck because it was expecting a RewardNextQuest that the server would not send.\r\n\r\nEasily noticeable with the quest [Envoy to the Horde](http://www.wowhead.com/quest=9812): the quest window will be stuck on quest reward, because Sylvanas has [a core script using that hook](https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/EasternKingdoms/zone_undercity.cpp#L99) which returns true.\r\n\r\nSince the purpose of RewardNextQuest is to show a quest straight after another quest is rewarded, it makes no sense to allow scripts to influence that behavior.\r\n\r\n**Target branch(es)**: 335\r\n\r\n**Issues addressed:** I could have sworn I saw an issue about this, but can't find it again.\r\n\r\n**Tests performed**: builds and works just fine.","created_at":"2017-04-23T18:45:34Z","updated_at":"2017-04-23T18:45:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19498/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19498/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19498/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/9e20d2454278a319551792520560af50ac0068a9","head":{"label":"Xyventh:reward_next_quest","ref":"reward_next_quest","sha":"9e20d2454278a319551792520560af50ac0068a9","user":{"login":"Xyventh","id":27926164,"avatar_url":"https://avatars1.githubusercontent.com/u/27926164?v=3","gravatar_id":"","url":"https://api.github.com/users/Xyventh","html_url":"https://github.com/Xyventh","followers_url":"https://api.github.com/users/Xyventh/followers","following_url":"https://api.github.com/users/Xyventh/following{/other_user}","gists_url":"https://api.github.com/users/Xyventh/gists{/gist_id}","starred_url":"https://api.github.com/users/Xyventh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xyventh/subscriptions","organizations_url":"https://api.github.com/users/Xyventh/orgs","repos_url":"https://api.github.com/users/Xyventh/repos","events_url":"https://api.github.com/users/Xyventh/events{/privacy}","received_events_url":"https://api.github.com/users/Xyventh/received_events","type":"User","site_admin":false},"repo":{"id":89162888,"name":"TrinityCore","full_name":"Xyventh/TrinityCore","owner":{"login":"Xyventh","id":27926164,"avatar_url":"https://avatars1.githubusercontent.com/u/27926164?v=3","gravatar_id":"","url":"https://api.github.com/users/Xyventh","html_url":"https://github.com/Xyventh","followers_url":"https://api.github.com/users/Xyventh/followers","following_url":"https://api.github.com/users/Xyventh/following{/other_user}","gists_url":"https://api.github.com/users/Xyventh/gists{/gist_id}","starred_url":"https://api.github.com/users/Xyventh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xyventh/subscriptions","organizations_url":"https://api.github.com/users/Xyventh/orgs","repos_url":"https://api.github.com/users/Xyventh/repos","events_url":"https://api.github.com/users/Xyventh/events{/privacy}","received_events_url":"https://api.github.com/users/Xyventh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Xyventh/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Xyventh/TrinityCore","forks_url":"https://api.github.com/repos/Xyventh/TrinityCore/forks","keys_url":"https://api.github.com/repos/Xyventh/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Xyventh/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Xyventh/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Xyventh/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Xyventh/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Xyventh/TrinityCore/events","assignees_url":"https://api.github.com/repos/Xyventh/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Xyventh/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Xyventh/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Xyventh/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Xyventh/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Xyventh/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Xyventh/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Xyventh/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Xyventh/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Xyventh/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Xyventh/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Xyventh/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Xyventh/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Xyventh/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Xyventh/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Xyventh/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Xyventh/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Xyventh/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Xyventh/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Xyventh/TrinityCore/merges","archive_url":"https://api.github.com/repos/Xyventh/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Xyventh/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Xyventh/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Xyventh/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Xyventh/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Xyventh/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Xyventh/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Xyventh/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/Xyventh/TrinityCore/deployments","created_at":"2017-04-23T18:23:35Z","updated_at":"2017-04-23T18:23:52Z","pushed_at":"2017-04-23T18:42:54Z","git_url":"git://github.com/Xyventh/TrinityCore.git","ssh_url":"git@github.com:Xyventh/TrinityCore.git","clone_url":"https://github.com/Xyventh/TrinityCore.git","svn_url":"https://github.com/Xyventh/TrinityCore","homepage":"http://www.trinitycore.org","size":433335,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"6cc267d90918a0663f928db302ef1465f7952c61","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars0.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars0.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2017-04-23T13:36:50Z","pushed_at":"2017-04-23T17:01:52Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":433335,"stargazers_count":3764,"watchers_count":3764,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3756,"mirror_url":null,"open_issues_count":1319,"forks":3756,"open_issues":1319,"watchers":3764,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19498"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/19498"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19498"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19498/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19498/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19498/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/9e20d2454278a319551792520560af50ac0068a9"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":23,"deletions":24,"changed_files":1}}
{"actor":{"display_login":"Xyventh"}}