{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker-credential-helpers/issues/49","repository_url":"https://api.github.com/repos/docker/docker-credential-helpers","labels_url":"https://api.github.com/repos/docker/docker-credential-helpers/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker-credential-helpers/issues/49/comments","events_url":"https://api.github.com/repos/docker/docker-credential-helpers/issues/49/events","html_url":"https://github.com/docker/docker-credential-helpers/pull/49","id":213360329,"number":49,"title":"Label credentials on each platform' creds store and fix secretservice behavior","user":{"login":"n4ss","id":5625058,"avatar_url":"https://avatars1.githubusercontent.com/u/5625058?v=3","gravatar_id":"","url":"https://api.github.com/users/n4ss","html_url":"https://github.com/n4ss","followers_url":"https://api.github.com/users/n4ss/followers","following_url":"https://api.github.com/users/n4ss/following{/other_user}","gists_url":"https://api.github.com/users/n4ss/gists{/gist_id}","starred_url":"https://api.github.com/users/n4ss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n4ss/subscriptions","organizations_url":"https://api.github.com/users/n4ss/orgs","repos_url":"https://api.github.com/users/n4ss/repos","events_url":"https://api.github.com/users/n4ss/events{/privacy}","received_events_url":"https://api.github.com/users/n4ss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-03-10T14:49:54Z","updated_at":"2017-03-10T15:13:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker-credential-helpers/pulls/49","html_url":"https://github.com/docker/docker-credential-helpers/pull/49","diff_url":"https://github.com/docker/docker-credential-helpers/pull/49.diff","patch_url":"https://github.com/docker/docker-credential-helpers/pull/49.patch"},"body":"Logic behind this PR's purpose and implementation are here:  https://github.com/docker/docker-credential-helpers/issues/46.\r\n\r\nThis PR is solving the following issues:\r\n\r\n- https://github.com/docker/docker-credential-helpers/issues/27\r\n- https://github.com/docker/docker-credential-helpers/issues/46\r\n- https://github.com/docker/docker-credential-helpers/issues/14\r\n- https://github.com/docker/docker-credential-helpers/issues/47\r\n\r\nand probably solving the following issue:\r\n\r\n- https://github.com/docker/docker-credential-helpers/issues/32\r\n\r\nAnd also solves one of the two reasons behind this issue:\r\n\r\n- https://github.com/docker/docker-credential-helpers/issues/48\r\n\r\nThe `\"Docker Credentials\"` label is now added to credentials on `osxkeychain` (macOS), `wincred` (Windows) and `secretservice` (Linux) to filter out non-Docker credentials when listing those.\r\n\r\n`secretservice` was broken in several spots, this is also fixed in this PR. The tests for this platform are fixed in the PR associated to this issue: https://github.com/docker/docker-credential-helpers/issues/48."},"comment":{"url":"https://api.github.com/repos/docker/docker-credential-helpers/issues/comments/285693989","html_url":"https://github.com/docker/docker-credential-helpers/pull/49#issuecomment-285693989","issue_url":"https://api.github.com/repos/docker/docker-credential-helpers/issues/49","id":285693989,"user":{"login":"simonferquel","id":1677333,"avatar_url":"https://avatars0.githubusercontent.com/u/1677333?v=3","gravatar_id":"","url":"https://api.github.com/users/simonferquel","html_url":"https://github.com/simonferquel","followers_url":"https://api.github.com/users/simonferquel/followers","following_url":"https://api.github.com/users/simonferquel/following{/other_user}","gists_url":"https://api.github.com/users/simonferquel/gists{/gist_id}","starred_url":"https://api.github.com/users/simonferquel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonferquel/subscriptions","organizations_url":"https://api.github.com/users/simonferquel/orgs","repos_url":"https://api.github.com/users/simonferquel/repos","events_url":"https://api.github.com/users/simonferquel/events{/privacy}","received_events_url":"https://api.github.com/users/simonferquel/received_events","type":"User","site_admin":false},"created_at":"2017-03-10T15:13:58Z","updated_at":"2017-03-10T15:13:58Z","body":"Hmm, what about existing users already logged in with the previous behavior ? I suppose they will appear as logged in and can do pull/pushes but will fail to build some dockerfiles?"}}
{"actor":{"display_login":"simonferquel"}}