{"action":"created","comment":{"url":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/comments/113984812","pull_request_review_id":35421657,"id":113984812,"diff_hunk":"@@ -72,7 +95,17 @@ test('BabelPluginExportToFunction should inject config ast', (t) => {\n test('BabelPluginExportToFunction should throw on invalid export', (t) => {\n     const exportToFunction = new BabelPluginExportToFunction(babelTypes.stringLiteral('testconfig'));\n     const code = 'function myRule() { exports.default = function (test) {}; }';\n-    t.throws(() => babel.transform(code, { plugins: [ exportToFunction ] }));\n+    const error = t.throws(() => babel.transform(code, { plugins: [ exportToFunction ] }));\n+\n+    t.is(error.message, 'unknown: auth0-bundler is missing default export in module');\n+});\n+\n+test('BabelPluginExportToFunction should throw on variable export', (t) => {\n+    const exportToFunction = new BabelPluginExportToFunction(babelTypes.stringLiteral('testconfig'));\n+    const code = 'const a = \"test\"; exports.default = a;';\n+    const error = t.throws(() => babel.transform(code, { plugins: [ exportToFunction ] }));\n+\n+    t.is(error.message, 'unknown: auth0-bundler is missing default export in module');","path":"test/unit/BabelPluginExportToFunctionSpec.js","position":54,"original_position":54,"commit_id":"7cf6879c3476809940f3202f0b6393fd7c955ca3","original_commit_id":"7cf6879c3476809940f3202f0b6393fd7c955ca3","user":{"login":"lo1tuma","id":169170,"avatar_url":"https://avatars3.githubusercontent.com/u/169170?v=3","gravatar_id":"","url":"https://api.github.com/users/lo1tuma","html_url":"https://github.com/lo1tuma","followers_url":"https://api.github.com/users/lo1tuma/followers","following_url":"https://api.github.com/users/lo1tuma/following{/other_user}","gists_url":"https://api.github.com/users/lo1tuma/gists{/gist_id}","starred_url":"https://api.github.com/users/lo1tuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lo1tuma/subscriptions","organizations_url":"https://api.github.com/users/lo1tuma/orgs","repos_url":"https://api.github.com/users/lo1tuma/repos","events_url":"https://api.github.com/users/lo1tuma/events{/privacy}","received_events_url":"https://api.github.com/users/lo1tuma/received_events","type":"User","site_admin":false},"body":"I’m not sure if I understand what the error message tries to explain.\r\nIsn’t the error that `auth0-bundler` is not able to resolve a function that is exported?\r\nIf so I would suggest something like this:\r\n\r\n`Error: auth0-bundler could not resolve a function that is being exported.`","created_at":"2017-04-28T17:50:47Z","updated_at":"2017-04-28T17:50:47Z","html_url":"https://github.com/holidaycheck/auth0-bundler/pull/6#discussion_r113984812","pull_request_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/comments/113984812"},"html":{"href":"https://github.com/holidaycheck/auth0-bundler/pull/6#discussion_r113984812"},"pull_request":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/6","id":117219437,"html_url":"https://github.com/holidaycheck/auth0-bundler/pull/6","diff_url":"https://github.com/holidaycheck/auth0-bundler/pull/6.diff","patch_url":"https://github.com/holidaycheck/auth0-bundler/pull/6.patch","issue_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues/6","number":6,"state":"open","locked":false,"title":"Support export of function declarations","user":{"login":"selaux","id":848854,"avatar_url":"https://avatars1.githubusercontent.com/u/848854?v=3","gravatar_id":"","url":"https://api.github.com/users/selaux","html_url":"https://github.com/selaux","followers_url":"https://api.github.com/users/selaux/followers","following_url":"https://api.github.com/users/selaux/following{/other_user}","gists_url":"https://api.github.com/users/selaux/gists{/gist_id}","starred_url":"https://api.github.com/users/selaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selaux/subscriptions","organizations_url":"https://api.github.com/users/selaux/orgs","repos_url":"https://api.github.com/users/selaux/repos","events_url":"https://api.github.com/users/selaux/events{/privacy}","received_events_url":"https://api.github.com/users/selaux/received_events","type":"User","site_admin":false},"body":"Currently it is only two failing tests...","created_at":"2017-04-24T09:15:10Z","updated_at":"2017-04-28T17:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9838df458f5b88aae8d646931805f82c15e013f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/6/commits","review_comments_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/6/comments","review_comment_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues/6/comments","statuses_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/statuses/7cf6879c3476809940f3202f0b6393fd7c955ca3","head":{"label":"holidaycheck:adapt-export-in-functional-test","ref":"adapt-export-in-functional-test","sha":"7cf6879c3476809940f3202f0b6393fd7c955ca3","user":{"login":"holidaycheck","id":2122343,"avatar_url":"https://avatars3.githubusercontent.com/u/2122343?v=3","gravatar_id":"","url":"https://api.github.com/users/holidaycheck","html_url":"https://github.com/holidaycheck","followers_url":"https://api.github.com/users/holidaycheck/followers","following_url":"https://api.github.com/users/holidaycheck/following{/other_user}","gists_url":"https://api.github.com/users/holidaycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/holidaycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidaycheck/subscriptions","organizations_url":"https://api.github.com/users/holidaycheck/orgs","repos_url":"https://api.github.com/users/holidaycheck/repos","events_url":"https://api.github.com/users/holidaycheck/events{/privacy}","received_events_url":"https://api.github.com/users/holidaycheck/received_events","type":"Organization","site_admin":false},"repo":{"id":87829882,"name":"auth0-bundler","full_name":"holidaycheck/auth0-bundler","owner":{"login":"holidaycheck","id":2122343,"avatar_url":"https://avatars3.githubusercontent.com/u/2122343?v=3","gravatar_id":"","url":"https://api.github.com/users/holidaycheck","html_url":"https://github.com/holidaycheck","followers_url":"https://api.github.com/users/holidaycheck/followers","following_url":"https://api.github.com/users/holidaycheck/following{/other_user}","gists_url":"https://api.github.com/users/holidaycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/holidaycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidaycheck/subscriptions","organizations_url":"https://api.github.com/users/holidaycheck/orgs","repos_url":"https://api.github.com/users/holidaycheck/repos","events_url":"https://api.github.com/users/holidaycheck/events{/privacy}","received_events_url":"https://api.github.com/users/holidaycheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidaycheck/auth0-bundler","description":"Bundle rules, scripts and hooks to deploy them to Auth0.","fork":false,"url":"https://api.github.com/repos/holidaycheck/auth0-bundler","forks_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/forks","keys_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/teams","hooks_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/hooks","issue_events_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues/events{/number}","events_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/events","assignees_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/assignees{/user}","branches_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/branches{/branch}","tags_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/tags","blobs_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/languages","stargazers_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/stargazers","contributors_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/contributors","subscribers_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/subscribers","subscription_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/subscription","commits_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/contents/{+path}","compare_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/merges","archive_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/downloads","issues_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues{/number}","pulls_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/labels{/name}","releases_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/releases{/id}","deployments_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/deployments","created_at":"2017-04-10T15:54:01Z","updated_at":"2017-04-12T20:59:53Z","pushed_at":"2017-04-28T17:13:46Z","git_url":"git://github.com/holidaycheck/auth0-bundler.git","ssh_url":"git@github.com:holidaycheck/auth0-bundler.git","clone_url":"https://github.com/holidaycheck/auth0-bundler.git","svn_url":"https://github.com/holidaycheck/auth0-bundler","homepage":null,"size":39,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"holidaycheck:master","ref":"master","sha":"690d7d3aa98b5c5ac299ffbf06f4fa7206c37f52","user":{"login":"holidaycheck","id":2122343,"avatar_url":"https://avatars3.githubusercontent.com/u/2122343?v=3","gravatar_id":"","url":"https://api.github.com/users/holidaycheck","html_url":"https://github.com/holidaycheck","followers_url":"https://api.github.com/users/holidaycheck/followers","following_url":"https://api.github.com/users/holidaycheck/following{/other_user}","gists_url":"https://api.github.com/users/holidaycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/holidaycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidaycheck/subscriptions","organizations_url":"https://api.github.com/users/holidaycheck/orgs","repos_url":"https://api.github.com/users/holidaycheck/repos","events_url":"https://api.github.com/users/holidaycheck/events{/privacy}","received_events_url":"https://api.github.com/users/holidaycheck/received_events","type":"Organization","site_admin":false},"repo":{"id":87829882,"name":"auth0-bundler","full_name":"holidaycheck/auth0-bundler","owner":{"login":"holidaycheck","id":2122343,"avatar_url":"https://avatars3.githubusercontent.com/u/2122343?v=3","gravatar_id":"","url":"https://api.github.com/users/holidaycheck","html_url":"https://github.com/holidaycheck","followers_url":"https://api.github.com/users/holidaycheck/followers","following_url":"https://api.github.com/users/holidaycheck/following{/other_user}","gists_url":"https://api.github.com/users/holidaycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/holidaycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holidaycheck/subscriptions","organizations_url":"https://api.github.com/users/holidaycheck/orgs","repos_url":"https://api.github.com/users/holidaycheck/repos","events_url":"https://api.github.com/users/holidaycheck/events{/privacy}","received_events_url":"https://api.github.com/users/holidaycheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/holidaycheck/auth0-bundler","description":"Bundle rules, scripts and hooks to deploy them to Auth0.","fork":false,"url":"https://api.github.com/repos/holidaycheck/auth0-bundler","forks_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/forks","keys_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/teams","hooks_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/hooks","issue_events_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues/events{/number}","events_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/events","assignees_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/assignees{/user}","branches_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/branches{/branch}","tags_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/tags","blobs_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/refs{/sha}","trees_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/statuses/{sha}","languages_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/languages","stargazers_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/stargazers","contributors_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/contributors","subscribers_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/subscribers","subscription_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/subscription","commits_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/commits{/sha}","git_commits_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/git/commits{/sha}","comments_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/comments{/number}","issue_comment_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues/comments{/number}","contents_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/contents/{+path}","compare_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/merges","archive_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/downloads","issues_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues{/number}","pulls_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls{/number}","milestones_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/milestones{/number}","notifications_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/labels{/name}","releases_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/releases{/id}","deployments_url":"https://api.github.com/repos/holidaycheck/auth0-bundler/deployments","created_at":"2017-04-10T15:54:01Z","updated_at":"2017-04-12T20:59:53Z","pushed_at":"2017-04-28T17:13:46Z","git_url":"git://github.com/holidaycheck/auth0-bundler.git","ssh_url":"git@github.com:holidaycheck/auth0-bundler.git","clone_url":"https://github.com/holidaycheck/auth0-bundler.git","svn_url":"https://github.com/holidaycheck/auth0-bundler","homepage":null,"size":39,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/6"},"html":{"href":"https://github.com/holidaycheck/auth0-bundler/pull/6"},"issue":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues/6"},"comments":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/holidaycheck/auth0-bundler/statuses/7cf6879c3476809940f3202f0b6393fd7c955ca3"}}}}
{"actor":{"display_login":"lo1tuma"}}