{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/ezenEgovProject/kobay/pulls/1","id":141628353,"html_url":"https://github.com/ezenEgovProject/kobay/pull/1","diff_url":"https://github.com/ezenEgovProject/kobay/pull/1.diff","patch_url":"https://github.com/ezenEgovProject/kobay/pull/1.patch","issue_url":"https://api.github.com/repos/ezenEgovProject/kobay/issues/1","number":1,"state":"closed","locked":false,"title":"로그인 및 회원가입 Review vol.1","user":{"login":"ezenProject","id":31654233,"avatar_url":"https://avatars1.githubusercontent.com/u/31654233?v=4","gravatar_id":"","url":"https://api.github.com/users/ezenProject","html_url":"https://github.com/ezenProject","followers_url":"https://api.github.com/users/ezenProject/followers","following_url":"https://api.github.com/users/ezenProject/following{/other_user}","gists_url":"https://api.github.com/users/ezenProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ezenProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezenProject/subscriptions","organizations_url":"https://api.github.com/users/ezenProject/orgs","repos_url":"https://api.github.com/users/ezenProject/repos","events_url":"https://api.github.com/users/ezenProject/events{/privacy}","received_events_url":"https://api.github.com/users/ezenProject/received_events","type":"User","site_admin":false},"body":" **수정 권고사항**\r\n1.  LoginController / LogoutController 결합 (같은 session 및 log 사용)\r\n2.  LoginController , MemberController\r\n// ------------- 삭제(사용X)\r\n\t@Resource(name = \"jsonView\")\r\n\tprotected MappingJackson2JsonView jsonView;\r\n// -------------\r\n\r\n**추가 제안사항**\r\n\r\n1. 로그인 UI(User Interface) 변경\r\n- 비로그인 시 상단의 아이콘 클릭 > 로그인페이지 이동,\r\n- 로그인 후 로그인페이지 이전에 있었던 페이지로 이동\r\n- 로그인 후 상단바에 회원정보 간단 (member_name)출력\r\n- 로그인 후 로그아웃 버튼 생성\r\n\r\n2. 필수사항 미입력시 sql로 넘어가기전 컨트롤 단에서 에러를 발생시켜 view에 에러메세지\r\n-> 스프링에서 에러체크로 제공하는  Validator, BindingResult, Errors 클래스 검색\r\n\r\n3. 회원가입시 정규식체크 (Controller단에서 check, Validator 클래스 이용가능)\r\n\r\n4. 아이디 저장 및 자동로그인 생성 (cookie 이용)\r\n\r\n5. 회원정보 수정페이지 작성\r\n\r\n6. 비밀번호 분실페이지 작성\r\n\r\n7. 비밀번호 암호와( Controller - java)  - 회원가입시 비밀번호는 DataBase에도 암호화되어 입력되어야함\r\n\r\n\r\n위의 순서대로 하실필요는 없으나 모두 필요한 내용입니다. \r\n스프링에서 제공하는 클래스를 더 활용할 수 있었으면 합니다.\r\n(Validator나 BindingResult는 수업에선 안배웠지만 egovsample에 보시면 이미 있는 내용입니다.)","created_at":"2017-09-18T15:09:42Z","updated_at":"2017-10-01T07:13:24Z","closed_at":"2017-10-01T07:13:24Z","merged_at":"2017-10-01T07:13:24Z","merge_commit_sha":"e4171095dd7abc21f0181db97c8a1f93e37401d6","assignee":{"login":"minuchi","id":31687775,"avatar_url":"https://avatars0.githubusercontent.com/u/31687775?v=4","gravatar_id":"","url":"https://api.github.com/users/minuchi","html_url":"https://github.com/minuchi","followers_url":"https://api.github.com/users/minuchi/followers","following_url":"https://api.github.com/users/minuchi/following{/other_user}","gists_url":"https://api.github.com/users/minuchi/gists{/gist_id}","starred_url":"https://api.github.com/users/minuchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minuchi/subscriptions","organizations_url":"https://api.github.com/users/minuchi/orgs","repos_url":"https://api.github.com/users/minuchi/repos","events_url":"https://api.github.com/users/minuchi/events{/privacy}","received_events_url":"https://api.github.com/users/minuchi/received_events","type":"User","site_admin":false},"assignees":[{"login":"minuchi","id":31687775,"avatar_url":"https://avatars0.githubusercontent.com/u/31687775?v=4","gravatar_id":"","url":"https://api.github.com/users/minuchi","html_url":"https://github.com/minuchi","followers_url":"https://api.github.com/users/minuchi/followers","following_url":"https://api.github.com/users/minuchi/following{/other_user}","gists_url":"https://api.github.com/users/minuchi/gists{/gist_id}","starred_url":"https://api.github.com/users/minuchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minuchi/subscriptions","organizations_url":"https://api.github.com/users/minuchi/orgs","repos_url":"https://api.github.com/users/minuchi/repos","events_url":"https://api.github.com/users/minuchi/events{/privacy}","received_events_url":"https://api.github.com/users/minuchi/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"minuchi","id":31687775,"avatar_url":"https://avatars0.githubusercontent.com/u/31687775?v=4","gravatar_id":"","url":"https://api.github.com/users/minuchi","html_url":"https://github.com/minuchi","followers_url":"https://api.github.com/users/minuchi/followers","following_url":"https://api.github.com/users/minuchi/following{/other_user}","gists_url":"https://api.github.com/users/minuchi/gists{/gist_id}","starred_url":"https://api.github.com/users/minuchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minuchi/subscriptions","organizations_url":"https://api.github.com/users/minuchi/orgs","repos_url":"https://api.github.com/users/minuchi/repos","events_url":"https://api.github.com/users/minuchi/events{/privacy}","received_events_url":"https://api.github.com/users/minuchi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ezenEgovProject/kobay/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ezenEgovProject/kobay/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ezenEgovProject/kobay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezenEgovProject/kobay/issues/1/comments","statuses_url":"https://api.github.com/repos/ezenEgovProject/kobay/statuses/e4171095dd7abc21f0181db97c8a1f93e37401d6","head":{"label":"ezenEgovProject:member","ref":"member","sha":"e4171095dd7abc21f0181db97c8a1f93e37401d6","user":{"login":"ezenEgovProject","id":31688726,"avatar_url":"https://avatars3.githubusercontent.com/u/31688726?v=4","gravatar_id":"","url":"https://api.github.com/users/ezenEgovProject","html_url":"https://github.com/ezenEgovProject","followers_url":"https://api.github.com/users/ezenEgovProject/followers","following_url":"https://api.github.com/users/ezenEgovProject/following{/other_user}","gists_url":"https://api.github.com/users/ezenEgovProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ezenEgovProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezenEgovProject/subscriptions","organizations_url":"https://api.github.com/users/ezenEgovProject/orgs","repos_url":"https://api.github.com/users/ezenEgovProject/repos","events_url":"https://api.github.com/users/ezenEgovProject/events{/privacy}","received_events_url":"https://api.github.com/users/ezenEgovProject/received_events","type":"Organization","site_admin":false},"repo":{"id":102583190,"name":"kobay","full_name":"ezenEgovProject/kobay","owner":{"login":"ezenEgovProject","id":31688726,"avatar_url":"https://avatars3.githubusercontent.com/u/31688726?v=4","gravatar_id":"","url":"https://api.github.com/users/ezenEgovProject","html_url":"https://github.com/ezenEgovProject","followers_url":"https://api.github.com/users/ezenEgovProject/followers","following_url":"https://api.github.com/users/ezenEgovProject/following{/other_user}","gists_url":"https://api.github.com/users/ezenEgovProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ezenEgovProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezenEgovProject/subscriptions","organizations_url":"https://api.github.com/users/ezenEgovProject/orgs","repos_url":"https://api.github.com/users/ezenEgovProject/repos","events_url":"https://api.github.com/users/ezenEgovProject/events{/privacy}","received_events_url":"https://api.github.com/users/ezenEgovProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezenEgovProject/kobay","description":"전자정부프레임워크 팀프로젝트","fork":false,"url":"https://api.github.com/repos/ezenEgovProject/kobay","forks_url":"https://api.github.com/repos/ezenEgovProject/kobay/forks","keys_url":"https://api.github.com/repos/ezenEgovProject/kobay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezenEgovProject/kobay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezenEgovProject/kobay/teams","hooks_url":"https://api.github.com/repos/ezenEgovProject/kobay/hooks","issue_events_url":"https://api.github.com/repos/ezenEgovProject/kobay/issues/events{/number}","events_url":"https://api.github.com/repos/ezenEgovProject/kobay/events","assignees_url":"https://api.github.com/repos/ezenEgovProject/kobay/assignees{/user}","branches_url":"https://api.github.com/repos/ezenEgovProject/kobay/branches{/branch}","tags_url":"https://api.github.com/repos/ezenEgovProject/kobay/tags","blobs_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezenEgovProject/kobay/statuses/{sha}","languages_url":"https://api.github.com/repos/ezenEgovProject/kobay/languages","stargazers_url":"https://api.github.com/repos/ezenEgovProject/kobay/stargazers","contributors_url":"https://api.github.com/repos/ezenEgovProject/kobay/contributors","subscribers_url":"https://api.github.com/repos/ezenEgovProject/kobay/subscribers","subscription_url":"https://api.github.com/repos/ezenEgovProject/kobay/subscription","commits_url":"https://api.github.com/repos/ezenEgovProject/kobay/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezenEgovProject/kobay/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezenEgovProject/kobay/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezenEgovProject/kobay/contents/{+path}","compare_url":"https://api.github.com/repos/ezenEgovProject/kobay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezenEgovProject/kobay/merges","archive_url":"https://api.github.com/repos/ezenEgovProject/kobay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezenEgovProject/kobay/downloads","issues_url":"https://api.github.com/repos/ezenEgovProject/kobay/issues{/number}","pulls_url":"https://api.github.com/repos/ezenEgovProject/kobay/pulls{/number}","milestones_url":"https://api.github.com/repos/ezenEgovProject/kobay/milestones{/number}","notifications_url":"https://api.github.com/repos/ezenEgovProject/kobay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezenEgovProject/kobay/labels{/name}","releases_url":"https://api.github.com/repos/ezenEgovProject/kobay/releases{/id}","deployments_url":"https://api.github.com/repos/ezenEgovProject/kobay/deployments","created_at":"2017-09-06T08:26:17Z","updated_at":"2017-09-27T11:48:02Z","pushed_at":"2017-10-01T07:13:23Z","git_url":"git://github.com/ezenEgovProject/kobay.git","ssh_url":"git@github.com:ezenEgovProject/kobay.git","clone_url":"https://github.com/ezenEgovProject/kobay.git","svn_url":"https://github.com/ezenEgovProject/kobay","homepage":null,"size":25184,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"ezenEgovProject:develop","ref":"develop","sha":"a790a7cd4a90281284b6023b53f1a666fbd640bb","user":{"login":"ezenEgovProject","id":31688726,"avatar_url":"https://avatars3.githubusercontent.com/u/31688726?v=4","gravatar_id":"","url":"https://api.github.com/users/ezenEgovProject","html_url":"https://github.com/ezenEgovProject","followers_url":"https://api.github.com/users/ezenEgovProject/followers","following_url":"https://api.github.com/users/ezenEgovProject/following{/other_user}","gists_url":"https://api.github.com/users/ezenEgovProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ezenEgovProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezenEgovProject/subscriptions","organizations_url":"https://api.github.com/users/ezenEgovProject/orgs","repos_url":"https://api.github.com/users/ezenEgovProject/repos","events_url":"https://api.github.com/users/ezenEgovProject/events{/privacy}","received_events_url":"https://api.github.com/users/ezenEgovProject/received_events","type":"Organization","site_admin":false},"repo":{"id":102583190,"name":"kobay","full_name":"ezenEgovProject/kobay","owner":{"login":"ezenEgovProject","id":31688726,"avatar_url":"https://avatars3.githubusercontent.com/u/31688726?v=4","gravatar_id":"","url":"https://api.github.com/users/ezenEgovProject","html_url":"https://github.com/ezenEgovProject","followers_url":"https://api.github.com/users/ezenEgovProject/followers","following_url":"https://api.github.com/users/ezenEgovProject/following{/other_user}","gists_url":"https://api.github.com/users/ezenEgovProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ezenEgovProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezenEgovProject/subscriptions","organizations_url":"https://api.github.com/users/ezenEgovProject/orgs","repos_url":"https://api.github.com/users/ezenEgovProject/repos","events_url":"https://api.github.com/users/ezenEgovProject/events{/privacy}","received_events_url":"https://api.github.com/users/ezenEgovProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezenEgovProject/kobay","description":"전자정부프레임워크 팀프로젝트","fork":false,"url":"https://api.github.com/repos/ezenEgovProject/kobay","forks_url":"https://api.github.com/repos/ezenEgovProject/kobay/forks","keys_url":"https://api.github.com/repos/ezenEgovProject/kobay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezenEgovProject/kobay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezenEgovProject/kobay/teams","hooks_url":"https://api.github.com/repos/ezenEgovProject/kobay/hooks","issue_events_url":"https://api.github.com/repos/ezenEgovProject/kobay/issues/events{/number}","events_url":"https://api.github.com/repos/ezenEgovProject/kobay/events","assignees_url":"https://api.github.com/repos/ezenEgovProject/kobay/assignees{/user}","branches_url":"https://api.github.com/repos/ezenEgovProject/kobay/branches{/branch}","tags_url":"https://api.github.com/repos/ezenEgovProject/kobay/tags","blobs_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezenEgovProject/kobay/statuses/{sha}","languages_url":"https://api.github.com/repos/ezenEgovProject/kobay/languages","stargazers_url":"https://api.github.com/repos/ezenEgovProject/kobay/stargazers","contributors_url":"https://api.github.com/repos/ezenEgovProject/kobay/contributors","subscribers_url":"https://api.github.com/repos/ezenEgovProject/kobay/subscribers","subscription_url":"https://api.github.com/repos/ezenEgovProject/kobay/subscription","commits_url":"https://api.github.com/repos/ezenEgovProject/kobay/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezenEgovProject/kobay/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezenEgovProject/kobay/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezenEgovProject/kobay/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezenEgovProject/kobay/contents/{+path}","compare_url":"https://api.github.com/repos/ezenEgovProject/kobay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezenEgovProject/kobay/merges","archive_url":"https://api.github.com/repos/ezenEgovProject/kobay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezenEgovProject/kobay/downloads","issues_url":"https://api.github.com/repos/ezenEgovProject/kobay/issues{/number}","pulls_url":"https://api.github.com/repos/ezenEgovProject/kobay/pulls{/number}","milestones_url":"https://api.github.com/repos/ezenEgovProject/kobay/milestones{/number}","notifications_url":"https://api.github.com/repos/ezenEgovProject/kobay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezenEgovProject/kobay/labels{/name}","releases_url":"https://api.github.com/repos/ezenEgovProject/kobay/releases{/id}","deployments_url":"https://api.github.com/repos/ezenEgovProject/kobay/deployments","created_at":"2017-09-06T08:26:17Z","updated_at":"2017-09-27T11:48:02Z","pushed_at":"2017-10-01T07:13:23Z","git_url":"git://github.com/ezenEgovProject/kobay.git","ssh_url":"git@github.com:ezenEgovProject/kobay.git","clone_url":"https://github.com/ezenEgovProject/kobay.git","svn_url":"https://github.com/ezenEgovProject/kobay","homepage":null,"size":25184,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ezenEgovProject/kobay/pulls/1"},"html":{"href":"https://github.com/ezenEgovProject/kobay/pull/1"},"issue":{"href":"https://api.github.com/repos/ezenEgovProject/kobay/issues/1"},"comments":{"href":"https://api.github.com/repos/ezenEgovProject/kobay/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ezenEgovProject/kobay/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ezenEgovProject/kobay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezenEgovProject/kobay/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ezenEgovProject/kobay/statuses/e4171095dd7abc21f0181db97c8a1f93e37401d6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ezenProject","id":31654233,"avatar_url":"https://avatars1.githubusercontent.com/u/31654233?v=4","gravatar_id":"","url":"https://api.github.com/users/ezenProject","html_url":"https://github.com/ezenProject","followers_url":"https://api.github.com/users/ezenProject/followers","following_url":"https://api.github.com/users/ezenProject/following{/other_user}","gists_url":"https://api.github.com/users/ezenProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ezenProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezenProject/subscriptions","organizations_url":"https://api.github.com/users/ezenProject/orgs","repos_url":"https://api.github.com/users/ezenProject/repos","events_url":"https://api.github.com/users/ezenProject/events{/privacy}","received_events_url":"https://api.github.com/users/ezenProject/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":13,"additions":16853,"deletions":181,"changed_files":78}}
{"actor":{"display_login":"ezenProject"}}