{"action":"created","comment":{"url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/comments/119037571","pull_request_review_id":40880133,"id":119037571,"diff_hunk":"@@ -0,0 +1,129 @@\n+package org.arquillian.cube.docker.impl.client;\n+\n+import org.arquillian.cube.docker.impl.docker.DockerClientExecutor;\n+import org.arquillian.cube.docker.impl.model.DockerCube;\n+import org.arquillian.cube.spi.Binding;\n+import org.arquillian.cube.spi.CubeRegistry;\n+import org.arquillian.cube.spi.event.lifecycle.AfterDestroy;\n+import org.arquillian.cube.spi.event.lifecycle.AfterStart;\n+import org.jboss.arquillian.test.spi.event.suite.AfterSuite;\n+import org.jboss.arquillian.test.spi.event.suite.BeforeSuite;\n+import org.junit.Before;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.contrib.java.lang.system.RestoreSystemProperties;\n+import org.junit.runner.RunWith;\n+import org.mockito.Mock;\n+import org.mockito.runners.MockitoJUnitRunner;\n+\n+import java.util.HashSet;\n+import java.util.Set;\n+\n+import static org.assertj.core.api.Assertions.assertThat;\n+import static org.mockito.Mockito.when;\n+\n+@RunWith(MockitoJUnitRunner.class)\n+public class SystemPropertiesCubeSetterTest {","path":"docker/docker/src/test/java/org/arquillian/cube/docker/impl/client/SystemPropertiesCubeSetterTest.java","position":26,"original_position":26,"commit_id":"98b068b4f349552fc3340e684607ad3b14ae834c","original_commit_id":"98b068b4f349552fc3340e684607ad3b14ae834c","user":{"login":"lordofthejars","id":1517153,"avatar_url":"https://avatars1.githubusercontent.com/u/1517153?v=3","gravatar_id":"","url":"https://api.github.com/users/lordofthejars","html_url":"https://github.com/lordofthejars","followers_url":"https://api.github.com/users/lordofthejars/followers","following_url":"https://api.github.com/users/lordofthejars/following{/other_user}","gists_url":"https://api.github.com/users/lordofthejars/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofthejars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofthejars/subscriptions","organizations_url":"https://api.github.com/users/lordofthejars/orgs","repos_url":"https://api.github.com/users/lordofthejars/repos","events_url":"https://api.github.com/users/lordofthejars/events{/privacy}","received_events_url":"https://api.github.com/users/lordofthejars/received_events","type":"User","site_admin":false},"body":"you mean using Arquillian capabilities? I don't think so since it is just a fire of the events. In general I usually this approach for testing observers. I mean in this concrete simple case firing the event or calling the method directly does not offer really a plus.","created_at":"2017-05-30T08:23:28Z","updated_at":"2017-05-30T08:23:28Z","html_url":"https://github.com/arquillian/arquillian-cube/pull/709#discussion_r119037571","pull_request_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/709","_links":{"self":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/comments/119037571"},"html":{"href":"https://github.com/arquillian/arquillian-cube/pull/709#discussion_r119037571"},"pull_request":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/709"}}},"pull_request":{"url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/709","id":122926730,"html_url":"https://github.com/arquillian/arquillian-cube/pull/709","diff_url":"https://github.com/arquillian/arquillian-cube/pull/709.diff","patch_url":"https://github.com/arquillian/arquillian-cube/pull/709.patch","issue_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/709","number":709,"state":"open","locked":false,"title":"feat(#708): Adds cube properties as system properties for test","user":{"login":"lordofthejars","id":1517153,"avatar_url":"https://avatars1.githubusercontent.com/u/1517153?v=3","gravatar_id":"","url":"https://api.github.com/users/lordofthejars","html_url":"https://github.com/lordofthejars","followers_url":"https://api.github.com/users/lordofthejars/followers","following_url":"https://api.github.com/users/lordofthejars/following{/other_user}","gists_url":"https://api.github.com/users/lordofthejars/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofthejars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofthejars/subscriptions","organizations_url":"https://api.github.com/users/lordofthejars/orgs","repos_url":"https://api.github.com/users/lordofthejars/repos","events_url":"https://api.github.com/users/lordofthejars/events{/privacy}","received_events_url":"https://api.github.com/users/lordofthejars/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-29T17:24:04Z","updated_at":"2017-05-30T08:23:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6d2bc47c2fdd0a8f5ec0e8ee1ae8450d08356fe","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MatousJobanek","id":1510709,"avatar_url":"https://avatars0.githubusercontent.com/u/1510709?v=3","gravatar_id":"","url":"https://api.github.com/users/MatousJobanek","html_url":"https://github.com/MatousJobanek","followers_url":"https://api.github.com/users/MatousJobanek/followers","following_url":"https://api.github.com/users/MatousJobanek/following{/other_user}","gists_url":"https://api.github.com/users/MatousJobanek/gists{/gist_id}","starred_url":"https://api.github.com/users/MatousJobanek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatousJobanek/subscriptions","organizations_url":"https://api.github.com/users/MatousJobanek/orgs","repos_url":"https://api.github.com/users/MatousJobanek/repos","events_url":"https://api.github.com/users/MatousJobanek/events{/privacy}","received_events_url":"https://api.github.com/users/MatousJobanek/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/709/commits","review_comments_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/709/comments","review_comment_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/709/comments","statuses_url":"https://api.github.com/repos/arquillian/arquillian-cube/statuses/98b068b4f349552fc3340e684607ad3b14ae834c","head":{"label":"lordofthejars:issue-708","ref":"issue-708","sha":"98b068b4f349552fc3340e684607ad3b14ae834c","user":{"login":"lordofthejars","id":1517153,"avatar_url":"https://avatars1.githubusercontent.com/u/1517153?v=3","gravatar_id":"","url":"https://api.github.com/users/lordofthejars","html_url":"https://github.com/lordofthejars","followers_url":"https://api.github.com/users/lordofthejars/followers","following_url":"https://api.github.com/users/lordofthejars/following{/other_user}","gists_url":"https://api.github.com/users/lordofthejars/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofthejars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofthejars/subscriptions","organizations_url":"https://api.github.com/users/lordofthejars/orgs","repos_url":"https://api.github.com/users/lordofthejars/repos","events_url":"https://api.github.com/users/lordofthejars/events{/privacy}","received_events_url":"https://api.github.com/users/lordofthejars/received_events","type":"User","site_admin":false},"repo":{"id":49945362,"name":"arquillian-cube","full_name":"lordofthejars/arquillian-cube","owner":{"login":"lordofthejars","id":1517153,"avatar_url":"https://avatars1.githubusercontent.com/u/1517153?v=3","gravatar_id":"","url":"https://api.github.com/users/lordofthejars","html_url":"https://github.com/lordofthejars","followers_url":"https://api.github.com/users/lordofthejars/followers","following_url":"https://api.github.com/users/lordofthejars/following{/other_user}","gists_url":"https://api.github.com/users/lordofthejars/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofthejars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofthejars/subscriptions","organizations_url":"https://api.github.com/users/lordofthejars/orgs","repos_url":"https://api.github.com/users/lordofthejars/repos","events_url":"https://api.github.com/users/lordofthejars/events{/privacy}","received_events_url":"https://api.github.com/users/lordofthejars/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lordofthejars/arquillian-cube","description":"Arquillian Docker","fork":true,"url":"https://api.github.com/repos/lordofthejars/arquillian-cube","forks_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/forks","keys_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/teams","hooks_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/hooks","issue_events_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/issues/events{/number}","events_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/events","assignees_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/assignees{/user}","branches_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/branches{/branch}","tags_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/tags","blobs_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/refs{/sha}","trees_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/statuses/{sha}","languages_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/languages","stargazers_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/stargazers","contributors_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/contributors","subscribers_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/subscribers","subscription_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/subscription","commits_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/commits{/sha}","git_commits_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/git/commits{/sha}","comments_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/comments{/number}","issue_comment_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/issues/comments{/number}","contents_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/contents/{+path}","compare_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/merges","archive_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/downloads","issues_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/issues{/number}","pulls_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/pulls{/number}","milestones_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/milestones{/number}","notifications_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/labels{/name}","releases_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/releases{/id}","deployments_url":"https://api.github.com/repos/lordofthejars/arquillian-cube/deployments","created_at":"2016-01-19T10:32:41Z","updated_at":"2016-01-19T10:32:42Z","pushed_at":"2017-05-29T17:36:07Z","git_url":"git://github.com/lordofthejars/arquillian-cube.git","ssh_url":"git@github.com:lordofthejars/arquillian-cube.git","clone_url":"https://github.com/lordofthejars/arquillian-cube.git","svn_url":"https://github.com/lordofthejars/arquillian-cube","homepage":null,"size":2657,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arquillian:master","ref":"master","sha":"706c45424901fd85442df41bdcb5c6b2ef26eb0c","user":{"login":"arquillian","id":330981,"avatar_url":"https://avatars0.githubusercontent.com/u/330981?v=3","gravatar_id":"","url":"https://api.github.com/users/arquillian","html_url":"https://github.com/arquillian","followers_url":"https://api.github.com/users/arquillian/followers","following_url":"https://api.github.com/users/arquillian/following{/other_user}","gists_url":"https://api.github.com/users/arquillian/gists{/gist_id}","starred_url":"https://api.github.com/users/arquillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arquillian/subscriptions","organizations_url":"https://api.github.com/users/arquillian/orgs","repos_url":"https://api.github.com/users/arquillian/repos","events_url":"https://api.github.com/users/arquillian/events{/privacy}","received_events_url":"https://api.github.com/users/arquillian/received_events","type":"Organization","site_admin":false},"repo":{"id":25573964,"name":"arquillian-cube","full_name":"arquillian/arquillian-cube","owner":{"login":"arquillian","id":330981,"avatar_url":"https://avatars0.githubusercontent.com/u/330981?v=3","gravatar_id":"","url":"https://api.github.com/users/arquillian","html_url":"https://github.com/arquillian","followers_url":"https://api.github.com/users/arquillian/followers","following_url":"https://api.github.com/users/arquillian/following{/other_user}","gists_url":"https://api.github.com/users/arquillian/gists{/gist_id}","starred_url":"https://api.github.com/users/arquillian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arquillian/subscriptions","organizations_url":"https://api.github.com/users/arquillian/orgs","repos_url":"https://api.github.com/users/arquillian/repos","events_url":"https://api.github.com/users/arquillian/events{/privacy}","received_events_url":"https://api.github.com/users/arquillian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arquillian/arquillian-cube","description":"Control (docker) containers in your tests with ease!","fork":false,"url":"https://api.github.com/repos/arquillian/arquillian-cube","forks_url":"https://api.github.com/repos/arquillian/arquillian-cube/forks","keys_url":"https://api.github.com/repos/arquillian/arquillian-cube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arquillian/arquillian-cube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arquillian/arquillian-cube/teams","hooks_url":"https://api.github.com/repos/arquillian/arquillian-cube/hooks","issue_events_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/events{/number}","events_url":"https://api.github.com/repos/arquillian/arquillian-cube/events","assignees_url":"https://api.github.com/repos/arquillian/arquillian-cube/assignees{/user}","branches_url":"https://api.github.com/repos/arquillian/arquillian-cube/branches{/branch}","tags_url":"https://api.github.com/repos/arquillian/arquillian-cube/tags","blobs_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/refs{/sha}","trees_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arquillian/arquillian-cube/statuses/{sha}","languages_url":"https://api.github.com/repos/arquillian/arquillian-cube/languages","stargazers_url":"https://api.github.com/repos/arquillian/arquillian-cube/stargazers","contributors_url":"https://api.github.com/repos/arquillian/arquillian-cube/contributors","subscribers_url":"https://api.github.com/repos/arquillian/arquillian-cube/subscribers","subscription_url":"https://api.github.com/repos/arquillian/arquillian-cube/subscription","commits_url":"https://api.github.com/repos/arquillian/arquillian-cube/commits{/sha}","git_commits_url":"https://api.github.com/repos/arquillian/arquillian-cube/git/commits{/sha}","comments_url":"https://api.github.com/repos/arquillian/arquillian-cube/comments{/number}","issue_comment_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues/comments{/number}","contents_url":"https://api.github.com/repos/arquillian/arquillian-cube/contents/{+path}","compare_url":"https://api.github.com/repos/arquillian/arquillian-cube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arquillian/arquillian-cube/merges","archive_url":"https://api.github.com/repos/arquillian/arquillian-cube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arquillian/arquillian-cube/downloads","issues_url":"https://api.github.com/repos/arquillian/arquillian-cube/issues{/number}","pulls_url":"https://api.github.com/repos/arquillian/arquillian-cube/pulls{/number}","milestones_url":"https://api.github.com/repos/arquillian/arquillian-cube/milestones{/number}","notifications_url":"https://api.github.com/repos/arquillian/arquillian-cube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arquillian/arquillian-cube/labels{/name}","releases_url":"https://api.github.com/repos/arquillian/arquillian-cube/releases{/id}","deployments_url":"https://api.github.com/repos/arquillian/arquillian-cube/deployments","created_at":"2014-10-22T09:47:10Z","updated_at":"2017-05-25T07:20:04Z","pushed_at":"2017-05-29T17:36:08Z","git_url":"git://github.com/arquillian/arquillian-cube.git","ssh_url":"git@github.com:arquillian/arquillian-cube.git","clone_url":"https://github.com/arquillian/arquillian-cube.git","svn_url":"https://github.com/arquillian/arquillian-cube","homepage":"http://arquillian.org/arquillian-cube/","size":3085,"stargazers_count":70,"watchers_count":70,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":59,"mirror_url":null,"open_issues_count":53,"forks":59,"open_issues":53,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/709"},"html":{"href":"https://github.com/arquillian/arquillian-cube/pull/709"},"issue":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/issues/709"},"comments":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/issues/709/comments"},"review_comments":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/709/comments"},"review_comment":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/pulls/709/commits"},"statuses":{"href":"https://api.github.com/repos/arquillian/arquillian-cube/statuses/98b068b4f349552fc3340e684607ad3b14ae834c"}}}}
{"actor":{"display_login":"lordofthejars"}}