{"action":"created","comment":{"url":"https://api.github.com/repos/HTBox/allReady/pulls/comments/99823385","pull_request_review_id":20507841,"id":99823385,"diff_hunk":"@@ -33,13 +33,13 @@ public AttachmentService(IOptions<AzureStorageSettings> options)\n         /// <param name=\"organizationId\">int ID</param>\n         /// <param name=\"attachment\">a attachment from Microsoft.AspNet.Http</param>\n         /// <returns>URL to the uploaded file</returns>\n-        public async Task<string> UploadTaskAttachmentAsync(int taskId, IFormFile attachment)\n+        public async Task<string> UploadAsync(int taskId, IFormFile attachment)\n         {\n             var blobPath = \"task/\" + taskId.ToString();","path":"AllReadyApp/Web-App/AllReady/Services/TaskAttachmentService.cs","position":null,"original_position":25,"commit_id":"0def8ffb75dd4b2717bac5094edd37e79e4394c6","original_commit_id":"0def8ffb75dd4b2717bac5094edd37e79e4394c6","user":{"login":"mgmccarthy","id":2428993,"avatar_url":"https://avatars.githubusercontent.com/u/2428993?v=3","gravatar_id":"","url":"https://api.github.com/users/mgmccarthy","html_url":"https://github.com/mgmccarthy","followers_url":"https://api.github.com/users/mgmccarthy/followers","following_url":"https://api.github.com/users/mgmccarthy/following{/other_user}","gists_url":"https://api.github.com/users/mgmccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/mgmccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgmccarthy/subscriptions","organizations_url":"https://api.github.com/users/mgmccarthy/orgs","repos_url":"https://api.github.com/users/mgmccarthy/repos","events_url":"https://api.github.com/users/mgmccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/mgmccarthy/received_events","type":"User","site_admin":false},"body":"delete `.ToString()` here as the int is converted to a string by ways of string concatenation","created_at":"2017-02-07T13:41:30Z","updated_at":"2017-02-07T13:45:40Z","html_url":"https://github.com/HTBox/allReady/pull/1660#discussion_r99823385","pull_request_url":"https://api.github.com/repos/HTBox/allReady/pulls/1660","_links":{"self":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/comments/99823385"},"html":{"href":"https://github.com/HTBox/allReady/pull/1660#discussion_r99823385"},"pull_request":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/1660"}}},"pull_request":{"url":"https://api.github.com/repos/HTBox/allReady/pulls/1660","id":98621856,"html_url":"https://github.com/HTBox/allReady/pull/1660","diff_url":"https://github.com/HTBox/allReady/pull/1660.diff","patch_url":"https://github.com/HTBox/allReady/pull/1660.patch","issue_url":"https://api.github.com/repos/HTBox/allReady/issues/1660","number":1660,"state":"open","locked":false,"title":"WIP: Issue1503: Task attachments - Admin pages","user":{"login":"DanielSchiavini","id":2369243,"avatar_url":"https://avatars.githubusercontent.com/u/2369243?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielSchiavini","html_url":"https://github.com/DanielSchiavini","followers_url":"https://api.github.com/users/DanielSchiavini/followers","following_url":"https://api.github.com/users/DanielSchiavini/following{/other_user}","gists_url":"https://api.github.com/users/DanielSchiavini/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielSchiavini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielSchiavini/subscriptions","organizations_url":"https://api.github.com/users/DanielSchiavini/orgs","repos_url":"https://api.github.com/users/DanielSchiavini/repos","events_url":"https://api.github.com/users/DanielSchiavini/events{/privacy}","received_events_url":"https://api.github.com/users/DanielSchiavini/received_events","type":"User","site_admin":false},"body":"This PR is part of issue #1503 and includes changes that allow saving PDF and image attachments to tasks. This only includes the attachments in the admin pages. There are some areas in which some improvement may be wished. For now, it's only possible to attach one file per form submission. Files are always downloaded when the user clicks on it, even for images. Also unit tests are still necessary.","created_at":"2016-12-19T19:09:20Z","updated_at":"2017-02-07T13:45:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dee6131909d67aee653ade961cc88a7949b2433","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HTBox/allReady/pulls/1660/commits","review_comments_url":"https://api.github.com/repos/HTBox/allReady/pulls/1660/comments","review_comment_url":"https://api.github.com/repos/HTBox/allReady/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HTBox/allReady/issues/1660/comments","statuses_url":"https://api.github.com/repos/HTBox/allReady/statuses/0def8ffb75dd4b2717bac5094edd37e79e4394c6","head":{"label":"DanielSchiavini:Issue1503_task_attachments","ref":"Issue1503_task_attachments","sha":"0def8ffb75dd4b2717bac5094edd37e79e4394c6","user":{"login":"DanielSchiavini","id":2369243,"avatar_url":"https://avatars.githubusercontent.com/u/2369243?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielSchiavini","html_url":"https://github.com/DanielSchiavini","followers_url":"https://api.github.com/users/DanielSchiavini/followers","following_url":"https://api.github.com/users/DanielSchiavini/following{/other_user}","gists_url":"https://api.github.com/users/DanielSchiavini/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielSchiavini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielSchiavini/subscriptions","organizations_url":"https://api.github.com/users/DanielSchiavini/orgs","repos_url":"https://api.github.com/users/DanielSchiavini/repos","events_url":"https://api.github.com/users/DanielSchiavini/events{/privacy}","received_events_url":"https://api.github.com/users/DanielSchiavini/received_events","type":"User","site_admin":false},"repo":{"id":74136707,"name":"allReady","full_name":"DanielSchiavini/allReady","owner":{"login":"DanielSchiavini","id":2369243,"avatar_url":"https://avatars.githubusercontent.com/u/2369243?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielSchiavini","html_url":"https://github.com/DanielSchiavini","followers_url":"https://api.github.com/users/DanielSchiavini/followers","following_url":"https://api.github.com/users/DanielSchiavini/following{/other_user}","gists_url":"https://api.github.com/users/DanielSchiavini/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielSchiavini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielSchiavini/subscriptions","organizations_url":"https://api.github.com/users/DanielSchiavini/orgs","repos_url":"https://api.github.com/users/DanielSchiavini/repos","events_url":"https://api.github.com/users/DanielSchiavini/events{/privacy}","received_events_url":"https://api.github.com/users/DanielSchiavini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanielSchiavini/allReady","description":"This repo contains the code for allReady, an open-source solution focused on increasing awareness, efficiency and impact of preparedness campaigns as they are delivered by humanitarian and disaster response organizations in local communities.","fork":true,"url":"https://api.github.com/repos/DanielSchiavini/allReady","forks_url":"https://api.github.com/repos/DanielSchiavini/allReady/forks","keys_url":"https://api.github.com/repos/DanielSchiavini/allReady/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanielSchiavini/allReady/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanielSchiavini/allReady/teams","hooks_url":"https://api.github.com/repos/DanielSchiavini/allReady/hooks","issue_events_url":"https://api.github.com/repos/DanielSchiavini/allReady/issues/events{/number}","events_url":"https://api.github.com/repos/DanielSchiavini/allReady/events","assignees_url":"https://api.github.com/repos/DanielSchiavini/allReady/assignees{/user}","branches_url":"https://api.github.com/repos/DanielSchiavini/allReady/branches{/branch}","tags_url":"https://api.github.com/repos/DanielSchiavini/allReady/tags","blobs_url":"https://api.github.com/repos/DanielSchiavini/allReady/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanielSchiavini/allReady/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanielSchiavini/allReady/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanielSchiavini/allReady/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanielSchiavini/allReady/statuses/{sha}","languages_url":"https://api.github.com/repos/DanielSchiavini/allReady/languages","stargazers_url":"https://api.github.com/repos/DanielSchiavini/allReady/stargazers","contributors_url":"https://api.github.com/repos/DanielSchiavini/allReady/contributors","subscribers_url":"https://api.github.com/repos/DanielSchiavini/allReady/subscribers","subscription_url":"https://api.github.com/repos/DanielSchiavini/allReady/subscription","commits_url":"https://api.github.com/repos/DanielSchiavini/allReady/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanielSchiavini/allReady/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanielSchiavini/allReady/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanielSchiavini/allReady/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanielSchiavini/allReady/contents/{+path}","compare_url":"https://api.github.com/repos/DanielSchiavini/allReady/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanielSchiavini/allReady/merges","archive_url":"https://api.github.com/repos/DanielSchiavini/allReady/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanielSchiavini/allReady/downloads","issues_url":"https://api.github.com/repos/DanielSchiavini/allReady/issues{/number}","pulls_url":"https://api.github.com/repos/DanielSchiavini/allReady/pulls{/number}","milestones_url":"https://api.github.com/repos/DanielSchiavini/allReady/milestones{/number}","notifications_url":"https://api.github.com/repos/DanielSchiavini/allReady/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanielSchiavini/allReady/labels{/name}","releases_url":"https://api.github.com/repos/DanielSchiavini/allReady/releases{/id}","deployments_url":"https://api.github.com/repos/DanielSchiavini/allReady/deployments","created_at":"2016-11-18T14:28:28Z","updated_at":"2016-11-18T14:28:30Z","pushed_at":"2017-01-30T08:49:20Z","git_url":"git://github.com/DanielSchiavini/allReady.git","ssh_url":"git@github.com:DanielSchiavini/allReady.git","clone_url":"https://github.com/DanielSchiavini/allReady.git","svn_url":"https://github.com/DanielSchiavini/allReady","homepage":"http://www.htbox.org/projects/allready","size":30376,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HTBox:master","ref":"master","sha":"c85081f31b6e98afa734739e49537d95023386b1","user":{"login":"HTBox","id":5184596,"avatar_url":"https://avatars.githubusercontent.com/u/5184596?v=3","gravatar_id":"","url":"https://api.github.com/users/HTBox","html_url":"https://github.com/HTBox","followers_url":"https://api.github.com/users/HTBox/followers","following_url":"https://api.github.com/users/HTBox/following{/other_user}","gists_url":"https://api.github.com/users/HTBox/gists{/gist_id}","starred_url":"https://api.github.com/users/HTBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTBox/subscriptions","organizations_url":"https://api.github.com/users/HTBox/orgs","repos_url":"https://api.github.com/users/HTBox/repos","events_url":"https://api.github.com/users/HTBox/events{/privacy}","received_events_url":"https://api.github.com/users/HTBox/received_events","type":"Organization","site_admin":false},"repo":{"id":39270253,"name":"allReady","full_name":"HTBox/allReady","owner":{"login":"HTBox","id":5184596,"avatar_url":"https://avatars.githubusercontent.com/u/5184596?v=3","gravatar_id":"","url":"https://api.github.com/users/HTBox","html_url":"https://github.com/HTBox","followers_url":"https://api.github.com/users/HTBox/followers","following_url":"https://api.github.com/users/HTBox/following{/other_user}","gists_url":"https://api.github.com/users/HTBox/gists{/gist_id}","starred_url":"https://api.github.com/users/HTBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTBox/subscriptions","organizations_url":"https://api.github.com/users/HTBox/orgs","repos_url":"https://api.github.com/users/HTBox/repos","events_url":"https://api.github.com/users/HTBox/events{/privacy}","received_events_url":"https://api.github.com/users/HTBox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HTBox/allReady","description":"This repo contains the code for allReady, an open-source solution focused on increasing awareness, efficiency and impact of preparedness campaigns as they are delivered by humanitarian and disaster response organizations in local communities.","fork":false,"url":"https://api.github.com/repos/HTBox/allReady","forks_url":"https://api.github.com/repos/HTBox/allReady/forks","keys_url":"https://api.github.com/repos/HTBox/allReady/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HTBox/allReady/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HTBox/allReady/teams","hooks_url":"https://api.github.com/repos/HTBox/allReady/hooks","issue_events_url":"https://api.github.com/repos/HTBox/allReady/issues/events{/number}","events_url":"https://api.github.com/repos/HTBox/allReady/events","assignees_url":"https://api.github.com/repos/HTBox/allReady/assignees{/user}","branches_url":"https://api.github.com/repos/HTBox/allReady/branches{/branch}","tags_url":"https://api.github.com/repos/HTBox/allReady/tags","blobs_url":"https://api.github.com/repos/HTBox/allReady/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HTBox/allReady/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HTBox/allReady/git/refs{/sha}","trees_url":"https://api.github.com/repos/HTBox/allReady/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HTBox/allReady/statuses/{sha}","languages_url":"https://api.github.com/repos/HTBox/allReady/languages","stargazers_url":"https://api.github.com/repos/HTBox/allReady/stargazers","contributors_url":"https://api.github.com/repos/HTBox/allReady/contributors","subscribers_url":"https://api.github.com/repos/HTBox/allReady/subscribers","subscription_url":"https://api.github.com/repos/HTBox/allReady/subscription","commits_url":"https://api.github.com/repos/HTBox/allReady/commits{/sha}","git_commits_url":"https://api.github.com/repos/HTBox/allReady/git/commits{/sha}","comments_url":"https://api.github.com/repos/HTBox/allReady/comments{/number}","issue_comment_url":"https://api.github.com/repos/HTBox/allReady/issues/comments{/number}","contents_url":"https://api.github.com/repos/HTBox/allReady/contents/{+path}","compare_url":"https://api.github.com/repos/HTBox/allReady/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HTBox/allReady/merges","archive_url":"https://api.github.com/repos/HTBox/allReady/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HTBox/allReady/downloads","issues_url":"https://api.github.com/repos/HTBox/allReady/issues{/number}","pulls_url":"https://api.github.com/repos/HTBox/allReady/pulls{/number}","milestones_url":"https://api.github.com/repos/HTBox/allReady/milestones{/number}","notifications_url":"https://api.github.com/repos/HTBox/allReady/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HTBox/allReady/labels{/name}","releases_url":"https://api.github.com/repos/HTBox/allReady/releases{/id}","deployments_url":"https://api.github.com/repos/HTBox/allReady/deployments","created_at":"2015-07-17T18:51:45Z","updated_at":"2017-02-07T12:33:52Z","pushed_at":"2017-02-07T00:49:01Z","git_url":"git://github.com/HTBox/allReady.git","ssh_url":"git@github.com:HTBox/allReady.git","clone_url":"https://github.com/HTBox/allReady.git","svn_url":"https://github.com/HTBox/allReady","homepage":"http://www.htbox.org/projects/allready","size":30366,"stargazers_count":494,"watchers_count":494,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":396,"mirror_url":null,"open_issues_count":178,"forks":396,"open_issues":178,"watchers":494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/1660"},"html":{"href":"https://github.com/HTBox/allReady/pull/1660"},"issue":{"href":"https://api.github.com/repos/HTBox/allReady/issues/1660"},"comments":{"href":"https://api.github.com/repos/HTBox/allReady/issues/1660/comments"},"review_comments":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/1660/comments"},"review_comment":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HTBox/allReady/pulls/1660/commits"},"statuses":{"href":"https://api.github.com/repos/HTBox/allReady/statuses/0def8ffb75dd4b2717bac5094edd37e79e4394c6"}}}}
{"actor":{"display_login":"mgmccarthy"}}