{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1058","repository_url":"https://api.github.com/repos/kubernetes-incubator/cri-o","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1058/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1058/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1058/events","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1058","id":268103191,"number":1058,"title":"Revert \"integration-playbook: Idempotent Swapping\"","user":{"login":"mrunalp","id":53798,"avatar_url":"https://avatars1.githubusercontent.com/u/53798?v=4","gravatar_id":"","url":"https://api.github.com/users/mrunalp","html_url":"https://github.com/mrunalp","followers_url":"https://api.github.com/users/mrunalp/followers","following_url":"https://api.github.com/users/mrunalp/following{/other_user}","gists_url":"https://api.github.com/users/mrunalp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrunalp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrunalp/subscriptions","organizations_url":"https://api.github.com/users/mrunalp/orgs","repos_url":"https://api.github.com/users/mrunalp/repos","events_url":"https://api.github.com/users/mrunalp/events{/privacy}","received_events_url":"https://api.github.com/users/mrunalp/received_events","type":"User","site_admin":false},"labels":[{"id":484626496,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":677262217,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels/size/M","name":"size/M","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-10-24T16:37:41Z","updated_at":"2017-10-24T19:04:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/1058","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1058","diff_url":"https://github.com/kubernetes-incubator/cri-o/pull/1058.diff","patch_url":"https://github.com/kubernetes-incubator/cri-o/pull/1058.patch"},"body":"This reverts commit b198c57cfb616594f1040a6f31293f0585ef17a6.\r\n\r\nSigned-off-by: Mrunal Patel <mrunalp@gmail.com>"},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/comments/339097407","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/1058#issuecomment-339097407","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/1058","id":339097407,"user":{"login":"cevich","id":1183438,"avatar_url":"https://avatars2.githubusercontent.com/u/1183438?v=4","gravatar_id":"","url":"https://api.github.com/users/cevich","html_url":"https://github.com/cevich","followers_url":"https://api.github.com/users/cevich/followers","following_url":"https://api.github.com/users/cevich/following{/other_user}","gists_url":"https://api.github.com/users/cevich/gists{/gist_id}","starred_url":"https://api.github.com/users/cevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cevich/subscriptions","organizations_url":"https://api.github.com/users/cevich/orgs","repos_url":"https://api.github.com/users/cevich/repos","events_url":"https://api.github.com/users/cevich/events{/privacy}","received_events_url":"https://api.github.com/users/cevich/received_events","type":"User","site_admin":false},"created_at":"2017-10-24T19:04:05Z","updated_at":"2017-10-24T19:04:05Z","author_association":"CONTRIBUTOR","body":"@mrunalp thx for the chat.  So to summarize, this isn't a cri-o bug because...\r\n\r\n1. k8's is responsible for passing down all the cgroup memory-limiting options into cri-o.\r\n2. The test that's failing is an 'integration test', which means k8's isn't in charge.\r\n3. There _should_ be a test for this swap limit vs memory limit enforcement in the e2e tests, but there isn't.\r\n\r\nThis PR is just a quick-fix to get CRI-O out the door, later we can consider bringing it back in and/or fixing the test so swap doesn't get in it's way."}}
{"actor":{"display_login":"cevich"}}