{"action":"created","issue":{"url":"https://api.github.com/repos/scipy/scipy/issues/7879","repository_url":"https://api.github.com/repos/scipy/scipy","labels_url":"https://api.github.com/repos/scipy/scipy/issues/7879/labels{/name}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/7879/comments","events_url":"https://api.github.com/repos/scipy/scipy/issues/7879/events","html_url":"https://github.com/scipy/scipy/pull/7879","id":258331356,"number":7879,"title":"ENH: re-enabled old sv lapack routine as defaults","user":{"login":"zerothi","id":4789793,"avatar_url":"https://avatars1.githubusercontent.com/u/4789793?v=4","gravatar_id":"","url":"https://api.github.com/users/zerothi","html_url":"https://github.com/zerothi","followers_url":"https://api.github.com/users/zerothi/followers","following_url":"https://api.github.com/users/zerothi/following{/other_user}","gists_url":"https://api.github.com/users/zerothi/gists{/gist_id}","starred_url":"https://api.github.com/users/zerothi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerothi/subscriptions","organizations_url":"https://api.github.com/users/zerothi/orgs","repos_url":"https://api.github.com/users/zerothi/repos","events_url":"https://api.github.com/users/zerothi/events{/privacy}","received_events_url":"https://api.github.com/users/zerothi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2017-09-17T20:29:44Z","updated_at":"2017-09-19T08:25:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/7879","html_url":"https://github.com/scipy/scipy/pull/7879","diff_url":"https://github.com/scipy/scipy/pull/7879.diff","patch_url":"https://github.com/scipy/scipy/pull/7879.patch"},"body":"This fixes the speed regression in #7847. Since the default\r\nchange of sv to svx the solve routine suffered a huge performance\r\npenalty for anything but low order NRHS.\r\n\r\nThis commit fixes that issue by enabling the use of either 1) the\r\nsvx or 2) the sv routines. With a default on the latter.\r\n\r\nHowever, the main funtionality by using svx was the easy check\r\nof the condition number to assert a non-singular matrix.\r\nThis commit adds a call to the con routines to extract the\r\nappropriate condition number. This force the addition of:\r\n\r\n   - lamch (machine precision extraction)\r\n   - gecon (condition number calculation from LU factorization)\r\n   - lange (1-norm of matrix)\r\n\r\nThis commit adds to arguments (and deprecates one) by:\r\n  - refine, bool, decides whether the svx (true) or sv (false)\r\n    routines should be used.\r\n  - form = 'none', 'trans', 'conj' which refers to the form\r\n    of the solution step. This is only valid if refine=True\r\n    A ValueError will be issued if not none and refine=False.\r\n    This keyword deprecates the \"transposed\" boolean value which\r\n    only allowed 'T' (real) and 'C' (complex) but not 'T' for\r\n    complex.\r\n\r\nA fix for the deprecated sym_pos keyword which wasn't used in the previous\r\nversion.\r\n\r\nA couple of additional tests have been added, mainly to check the arguments."},"comment":{"url":"https://api.github.com/repos/scipy/scipy/issues/comments/330466912","html_url":"https://github.com/scipy/scipy/pull/7879#issuecomment-330466912","issue_url":"https://api.github.com/repos/scipy/scipy/issues/7879","id":330466912,"user":{"login":"pv","id":35046,"avatar_url":"https://avatars1.githubusercontent.com/u/35046?v=4","gravatar_id":"","url":"https://api.github.com/users/pv","html_url":"https://github.com/pv","followers_url":"https://api.github.com/users/pv/followers","following_url":"https://api.github.com/users/pv/following{/other_user}","gists_url":"https://api.github.com/users/pv/gists{/gist_id}","starred_url":"https://api.github.com/users/pv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pv/subscriptions","organizations_url":"https://api.github.com/users/pv/orgs","repos_url":"https://api.github.com/users/pv/repos","events_url":"https://api.github.com/users/pv/events{/privacy}","received_events_url":"https://api.github.com/users/pv/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T08:25:27Z","updated_at":"2017-09-19T08:25:27Z","author_association":"OWNER","body":"Also, the expm test was written well before the change to gesvx, so I \nbelieve the test works as intended regardless of the bad conditioning.\n"}}
{"actor":{"display_login":"pv"}}