{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/comments/137960152","pull_request_review_id":61694616,"id":137960152,"diff_hunk":"@@ -26,6 +30,11 @@ public Address(String address, boolean isPrivate) throws IllegalValueException {\n         if (!isValidAddress(trimmedAddress)) {\n             throw new IllegalValueException(MESSAGE_ADDRESS_CONSTRAINTS);\n         }\n+        String[] splitAddress = trimmedAddress.split(\",\");\n+        block = splitAddress[0];","path":"src/seedu/addressbook/data/person/Address.java","position":16,"original_position":16,"commit_id":"549cb9b6fff0a3ed026e80aef9bbc064c6e83a58","original_commit_id":"549cb9b6fff0a3ed026e80aef9bbc064c6e83a58","user":{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars1.githubusercontent.com/u/1023494?v=4","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false},"body":"What does our coding standard say about using numbers in array indices? [Hint! read magic numbers]","created_at":"2017-09-10T21:10:02Z","updated_at":"2017-09-10T21:11:53Z","html_url":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2/pull/73#discussion_r137960152","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/73","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/comments/137960152"},"html":{"href":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2/pull/73#discussion_r137960152"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/73","id":139537372,"html_url":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2/pull/73","diff_url":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2/pull/73.diff","patch_url":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2/pull/73.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/issues/73","number":73,"state":"open","locked":false,"title":"[W4.3d][W14-A2]Daniel Berzin Chua","user":{"login":"danielbrzn","id":251231,"avatar_url":"https://avatars0.githubusercontent.com/u/251231?v=4","gravatar_id":"","url":"https://api.github.com/users/danielbrzn","html_url":"https://github.com/danielbrzn","followers_url":"https://api.github.com/users/danielbrzn/followers","following_url":"https://api.github.com/users/danielbrzn/following{/other_user}","gists_url":"https://api.github.com/users/danielbrzn/gists{/gist_id}","starred_url":"https://api.github.com/users/danielbrzn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielbrzn/subscriptions","organizations_url":"https://api.github.com/users/danielbrzn/orgs","repos_url":"https://api.github.com/users/danielbrzn/repos","events_url":"https://api.github.com/users/danielbrzn/events{/privacy}","received_events_url":"https://api.github.com/users/danielbrzn/received_events","type":"User","site_admin":false},"body":"Added 4 new variables to the Address class that hold different parts of the address, and updated tests to match.\r\n\r\nUpdated exception handling for when the addressbook.xml file is read-only, informing the user that the file is unable to be written to.","created_at":"2017-09-06T11:28:34Z","updated_at":"2017-09-10T21:11:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b3f7dc3391d512e4c0662c97e2c79b5f5a8be66","assignee":{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars1.githubusercontent.com/u/1023494?v=4","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false},"assignees":[{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars1.githubusercontent.com/u/1023494?v=4","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/73/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/73/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/issues/73/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/statuses/549cb9b6fff0a3ed026e80aef9bbc064c6e83a58","head":{"label":"danielbrzn:master","ref":"master","sha":"549cb9b6fff0a3ed026e80aef9bbc064c6e83a58","user":{"login":"danielbrzn","id":251231,"avatar_url":"https://avatars0.githubusercontent.com/u/251231?v=4","gravatar_id":"","url":"https://api.github.com/users/danielbrzn","html_url":"https://github.com/danielbrzn","followers_url":"https://api.github.com/users/danielbrzn/followers","following_url":"https://api.github.com/users/danielbrzn/following{/other_user}","gists_url":"https://api.github.com/users/danielbrzn/gists{/gist_id}","starred_url":"https://api.github.com/users/danielbrzn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielbrzn/subscriptions","organizations_url":"https://api.github.com/users/danielbrzn/orgs","repos_url":"https://api.github.com/users/danielbrzn/repos","events_url":"https://api.github.com/users/danielbrzn/events{/privacy}","received_events_url":"https://api.github.com/users/danielbrzn/received_events","type":"User","site_admin":false},"repo":{"id":102372689,"name":"addressbook-level2","full_name":"danielbrzn/addressbook-level2","owner":{"login":"danielbrzn","id":251231,"avatar_url":"https://avatars0.githubusercontent.com/u/251231?v=4","gravatar_id":"","url":"https://api.github.com/users/danielbrzn","html_url":"https://github.com/danielbrzn","followers_url":"https://api.github.com/users/danielbrzn/followers","following_url":"https://api.github.com/users/danielbrzn/following{/other_user}","gists_url":"https://api.github.com/users/danielbrzn/gists{/gist_id}","starred_url":"https://api.github.com/users/danielbrzn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielbrzn/subscriptions","organizations_url":"https://api.github.com/users/danielbrzn/orgs","repos_url":"https://api.github.com/users/danielbrzn/repos","events_url":"https://api.github.com/users/danielbrzn/events{/privacy}","received_events_url":"https://api.github.com/users/danielbrzn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielbrzn/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/danielbrzn/addressbook-level2","forks_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/forks","keys_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/events","assignees_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/merges","archive_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/danielbrzn/addressbook-level2/deployments","created_at":"2017-09-04T14:54:39Z","updated_at":"2017-09-04T14:54:41Z","pushed_at":"2017-09-10T05:29:27Z","git_url":"git://github.com/danielbrzn/addressbook-level2.git","ssh_url":"git@github.com:danielbrzn/addressbook-level2.git","clone_url":"https://github.com/danielbrzn/addressbook-level2.git","svn_url":"https://github.com/danielbrzn/addressbook-level2","homepage":null,"size":3291,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1718S1:master","ref":"master","sha":"96597ccb304d02dd6d675d9bcd1878f5eec4636e","user":{"login":"nus-cs2103-AY1718S1","id":30224930,"avatar_url":"https://avatars0.githubusercontent.com/u/30224930?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S1","html_url":"https://github.com/nus-cs2103-AY1718S1","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S1/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S1/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S1/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S1/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S1/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S1/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S1/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S1/received_events","type":"Organization","site_admin":false},"repo":{"id":99103737,"name":"addressbook-level2","full_name":"nus-cs2103-AY1718S1/addressbook-level2","owner":{"login":"nus-cs2103-AY1718S1","id":30224930,"avatar_url":"https://avatars0.githubusercontent.com/u/30224930?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S1","html_url":"https://github.com/nus-cs2103-AY1718S1","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S1/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S1/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S1/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S1/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S1/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S1/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S1/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S1/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/deployments","created_at":"2017-08-02T10:24:37Z","updated_at":"2017-09-10T07:25:50Z","pushed_at":"2017-09-10T19:22:27Z","git_url":"git://github.com/nus-cs2103-AY1718S1/addressbook-level2.git","ssh_url":"git@github.com:nus-cs2103-AY1718S1/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2","homepage":null,"size":3287,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"open_issues_count":201,"forks":208,"open_issues":201,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/73"},"html":{"href":"https://github.com/nus-cs2103-AY1718S1/addressbook-level2/pull/73"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/issues/73"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S1/addressbook-level2/statuses/549cb9b6fff0a3ed026e80aef9bbc064c6e83a58"}},"author_association":"NONE"}}
{"actor":{"display_login":"okkhoy"}}