{"action":"created","comment":{"url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/comments/158625342","pull_request_review_id":85465766,"id":158625342,"diff_hunk":"@@ -74,20 +75,21 @@ export function mkdirpSync(p: string): void {\n \t}\n };\n \n-export function convertGame(param: ConvertGameParameterObject): Promise<void> {\n+export async function convertGame(param: ConvertGameParameterObject): Promise<void> {\n \t_completeConvertGameParameterObject(param);\n \n-\tconst gamejsonString = fs.readFileSync(path.resolve(param.source, \"game.json\"), \"utf-8\");\n-\tconst gamejson = JSON.parse(gamejsonString) as cmn.GameConfiguration;\n+\tconst content = await cmn.ConfigurationFile.read(path.join(param.source, \"game.json\"), param.logger);","path":"src/convert.ts","position":18,"original_position":18,"commit_id":"642b360b1f424b630021962104af004aa2565b31","original_commit_id":"92b49a514773a8aa12639d9c6ab4eeea6c080a3b","user":{"login":"kamakiri01","id":3122541,"avatar_url":"https://avatars2.githubusercontent.com/u/3122541?v=4","gravatar_id":"","url":"https://api.github.com/users/kamakiri01","html_url":"https://github.com/kamakiri01","followers_url":"https://api.github.com/users/kamakiri01/followers","following_url":"https://api.github.com/users/kamakiri01/following{/other_user}","gists_url":"https://api.github.com/users/kamakiri01/gists{/gist_id}","starred_url":"https://api.github.com/users/kamakiri01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamakiri01/subscriptions","organizations_url":"https://api.github.com/users/kamakiri01/orgs","repos_url":"https://api.github.com/users/kamakiri01/repos","events_url":"https://api.github.com/users/kamakiri01/events{/privacy}","received_events_url":"https://api.github.com/users/kamakiri01/received_events","type":"User","site_admin":false},"body":"う、そうですね。 https://github.com/akashic-games/akashic-cli-export-zip/pull/6#discussion_r158416118 のasync対応込でthenに繋げます。","created_at":"2017-12-25T07:08:15Z","updated_at":"2017-12-25T07:08:15Z","html_url":"https://github.com/akashic-games/akashic-cli-export-zip/pull/6#discussion_r158625342","pull_request_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/6","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/comments/158625342"},"html":{"href":"https://github.com/akashic-games/akashic-cli-export-zip/pull/6#discussion_r158625342"},"pull_request":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/6"}},"in_reply_to_id":158416094},"pull_request":{"url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/6","id":159589634,"html_url":"https://github.com/akashic-games/akashic-cli-export-zip/pull/6","diff_url":"https://github.com/akashic-games/akashic-cli-export-zip/pull/6.diff","patch_url":"https://github.com/akashic-games/akashic-cli-export-zip/pull/6.patch","issue_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues/6","number":6,"state":"open","locked":false,"title":"Filename hashing","user":{"login":"kamakiri01","id":3122541,"avatar_url":"https://avatars2.githubusercontent.com/u/3122541?v=4","gravatar_id":"","url":"https://api.github.com/users/kamakiri01","html_url":"https://github.com/kamakiri01","followers_url":"https://api.github.com/users/kamakiri01/followers","following_url":"https://api.github.com/users/kamakiri01/following{/other_user}","gists_url":"https://api.github.com/users/kamakiri01/gists{/gist_id}","starred_url":"https://api.github.com/users/kamakiri01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamakiri01/subscriptions","organizations_url":"https://api.github.com/users/kamakiri01/orgs","repos_url":"https://api.github.com/users/kamakiri01/repos","events_url":"https://api.github.com/users/kamakiri01/events{/privacy}","received_events_url":"https://api.github.com/users/kamakiri01/received_events","type":"User","site_admin":false},"body":"## このPullRequestが解決する内容\r\n`$ akashic export zip --hash-filename 20` のようなオプションを追加することで、各アセットファイルのファイル名をハッシュ化する機能を追加します。\r\n\r\nhttps://github.com/akashic-games/akashic-cli-commons/pull/9 の対応PRです。\r\n\r\n## 破壊的な変更を含んでいるか?\r\n\r\n- なし\r\n\r\n","created_at":"2017-12-21T07:14:22Z","updated_at":"2017-12-25T07:08:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fcedb40d1d4b7d9a10b03d4cdda9b83a90da085","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/6/commits","review_comments_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/6/comments","review_comment_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues/6/comments","statuses_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/statuses/642b360b1f424b630021962104af004aa2565b31","head":{"label":"akashic-games:filename-hashing","ref":"filename-hashing","sha":"642b360b1f424b630021962104af004aa2565b31","user":{"login":"akashic-games","id":16815486,"avatar_url":"https://avatars1.githubusercontent.com/u/16815486?v=4","gravatar_id":"","url":"https://api.github.com/users/akashic-games","html_url":"https://github.com/akashic-games","followers_url":"https://api.github.com/users/akashic-games/followers","following_url":"https://api.github.com/users/akashic-games/following{/other_user}","gists_url":"https://api.github.com/users/akashic-games/gists{/gist_id}","starred_url":"https://api.github.com/users/akashic-games/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akashic-games/subscriptions","organizations_url":"https://api.github.com/users/akashic-games/orgs","repos_url":"https://api.github.com/users/akashic-games/repos","events_url":"https://api.github.com/users/akashic-games/events{/privacy}","received_events_url":"https://api.github.com/users/akashic-games/received_events","type":"Organization","site_admin":false},"repo":{"id":78590999,"name":"akashic-cli-export-zip","full_name":"akashic-games/akashic-cli-export-zip","owner":{"login":"akashic-games","id":16815486,"avatar_url":"https://avatars1.githubusercontent.com/u/16815486?v=4","gravatar_id":"","url":"https://api.github.com/users/akashic-games","html_url":"https://github.com/akashic-games","followers_url":"https://api.github.com/users/akashic-games/followers","following_url":"https://api.github.com/users/akashic-games/following{/other_user}","gists_url":"https://api.github.com/users/akashic-games/gists{/gist_id}","starred_url":"https://api.github.com/users/akashic-games/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akashic-games/subscriptions","organizations_url":"https://api.github.com/users/akashic-games/orgs","repos_url":"https://api.github.com/users/akashic-games/repos","events_url":"https://api.github.com/users/akashic-games/events{/privacy}","received_events_url":"https://api.github.com/users/akashic-games/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akashic-games/akashic-cli-export-zip","description":null,"fork":false,"url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip","forks_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/forks","keys_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/teams","hooks_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/hooks","issue_events_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues/events{/number}","events_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/events","assignees_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/assignees{/user}","branches_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/branches{/branch}","tags_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/tags","blobs_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/refs{/sha}","trees_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/statuses/{sha}","languages_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/languages","stargazers_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/stargazers","contributors_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/contributors","subscribers_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/subscribers","subscription_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/subscription","commits_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/commits{/sha}","git_commits_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/commits{/sha}","comments_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/comments{/number}","issue_comment_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues/comments{/number}","contents_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/contents/{+path}","compare_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/merges","archive_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/downloads","issues_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues{/number}","pulls_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls{/number}","milestones_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/milestones{/number}","notifications_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/labels{/name}","releases_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/releases{/id}","deployments_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/deployments","created_at":"2017-01-11T01:31:22Z","updated_at":"2017-01-11T02:21:58Z","pushed_at":"2017-12-25T05:39:13Z","git_url":"git://github.com/akashic-games/akashic-cli-export-zip.git","ssh_url":"git@github.com:akashic-games/akashic-cli-export-zip.git","clone_url":"https://github.com/akashic-games/akashic-cli-export-zip.git","svn_url":"https://github.com/akashic-games/akashic-cli-export-zip","homepage":null,"size":42,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"akashic-games:master","ref":"master","sha":"9a81ddaf4bf5d179dcbbaf149fd4cd48a197d48b","user":{"login":"akashic-games","id":16815486,"avatar_url":"https://avatars1.githubusercontent.com/u/16815486?v=4","gravatar_id":"","url":"https://api.github.com/users/akashic-games","html_url":"https://github.com/akashic-games","followers_url":"https://api.github.com/users/akashic-games/followers","following_url":"https://api.github.com/users/akashic-games/following{/other_user}","gists_url":"https://api.github.com/users/akashic-games/gists{/gist_id}","starred_url":"https://api.github.com/users/akashic-games/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akashic-games/subscriptions","organizations_url":"https://api.github.com/users/akashic-games/orgs","repos_url":"https://api.github.com/users/akashic-games/repos","events_url":"https://api.github.com/users/akashic-games/events{/privacy}","received_events_url":"https://api.github.com/users/akashic-games/received_events","type":"Organization","site_admin":false},"repo":{"id":78590999,"name":"akashic-cli-export-zip","full_name":"akashic-games/akashic-cli-export-zip","owner":{"login":"akashic-games","id":16815486,"avatar_url":"https://avatars1.githubusercontent.com/u/16815486?v=4","gravatar_id":"","url":"https://api.github.com/users/akashic-games","html_url":"https://github.com/akashic-games","followers_url":"https://api.github.com/users/akashic-games/followers","following_url":"https://api.github.com/users/akashic-games/following{/other_user}","gists_url":"https://api.github.com/users/akashic-games/gists{/gist_id}","starred_url":"https://api.github.com/users/akashic-games/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akashic-games/subscriptions","organizations_url":"https://api.github.com/users/akashic-games/orgs","repos_url":"https://api.github.com/users/akashic-games/repos","events_url":"https://api.github.com/users/akashic-games/events{/privacy}","received_events_url":"https://api.github.com/users/akashic-games/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akashic-games/akashic-cli-export-zip","description":null,"fork":false,"url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip","forks_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/forks","keys_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/teams","hooks_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/hooks","issue_events_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues/events{/number}","events_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/events","assignees_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/assignees{/user}","branches_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/branches{/branch}","tags_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/tags","blobs_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/refs{/sha}","trees_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/statuses/{sha}","languages_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/languages","stargazers_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/stargazers","contributors_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/contributors","subscribers_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/subscribers","subscription_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/subscription","commits_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/commits{/sha}","git_commits_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/git/commits{/sha}","comments_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/comments{/number}","issue_comment_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues/comments{/number}","contents_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/contents/{+path}","compare_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/merges","archive_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/downloads","issues_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues{/number}","pulls_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls{/number}","milestones_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/milestones{/number}","notifications_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/labels{/name}","releases_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/releases{/id}","deployments_url":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/deployments","created_at":"2017-01-11T01:31:22Z","updated_at":"2017-01-11T02:21:58Z","pushed_at":"2017-12-25T05:39:13Z","git_url":"git://github.com/akashic-games/akashic-cli-export-zip.git","ssh_url":"git@github.com:akashic-games/akashic-cli-export-zip.git","clone_url":"https://github.com/akashic-games/akashic-cli-export-zip.git","svn_url":"https://github.com/akashic-games/akashic-cli-export-zip","homepage":null,"size":42,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/6"},"html":{"href":"https://github.com/akashic-games/akashic-cli-export-zip/pull/6"},"issue":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues/6"},"comments":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/akashic-games/akashic-cli-export-zip/statuses/642b360b1f424b630021962104af004aa2565b31"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kamakiri01"}}