{"action":"created","comment":{"url":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments/152675689","pull_request_review_id":78574829,"id":152675689,"diff_hunk":"@@ -599,6 +599,17 @@ impl RawCommandBuffer<Backend> for CommandBuffer {\n                                         }\n                                     }\n                                 }\n+                                ConstantBuffer(ref buffers) => {\n+                                    if let EncoderState::Render(ref encoder) = inner.encoder_state {\n+                                        for (i, ref bref) in buffers.iter().enumerate() {\n+                                            if let Some(ref buffer) = **bref {\n+                                                let offset = 0; // TODO: ?","path":"src/backend/metal/src/command.rs","position":8,"original_position":8,"commit_id":"fac5fbd797be2307ad48f2d69bbcee7f0b2e5322","original_commit_id":"fac5fbd797be2307ad48f2d69bbcee7f0b2e5322","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"body":"should be stored in the `DescriptorSetBinding` alongside the buffer ID","created_at":"2017-11-22T20:48:54Z","updated_at":"2017-11-22T20:50:24Z","html_url":"https://github.com/gfx-rs/gfx/pull/1639#discussion_r152675689","pull_request_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1639","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments/152675689"},"html":{"href":"https://github.com/gfx-rs/gfx/pull/1639#discussion_r152675689"},"pull_request":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1639"}}},"pull_request":{"url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1639","id":154250283,"html_url":"https://github.com/gfx-rs/gfx/pull/1639","diff_url":"https://github.com/gfx-rs/gfx/pull/1639.diff","patch_url":"https://github.com/gfx-rs/gfx/pull/1639.patch","issue_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1639","number":1639,"state":"open","locked":false,"title":"metal: Implement ConstantBuffers","user":{"login":"scoopr","id":3896,"avatar_url":"https://avatars1.githubusercontent.com/u/3896?v=4","gravatar_id":"","url":"https://api.github.com/users/scoopr","html_url":"https://github.com/scoopr","followers_url":"https://api.github.com/users/scoopr/followers","following_url":"https://api.github.com/users/scoopr/following{/other_user}","gists_url":"https://api.github.com/users/scoopr/gists{/gist_id}","starred_url":"https://api.github.com/users/scoopr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoopr/subscriptions","organizations_url":"https://api.github.com/users/scoopr/orgs","repos_url":"https://api.github.com/users/scoopr/repos","events_url":"https://api.github.com/users/scoopr/events{/privacy}","received_events_url":"https://api.github.com/users/scoopr/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-22T20:36:17Z","updated_at":"2017-11-22T20:50:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c7b35ce701c9c1a74e2aa91c8e08ef27c7878f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1639/commits","review_comments_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1639/comments","review_comment_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1639/comments","statuses_url":"https://api.github.com/repos/gfx-rs/gfx/statuses/fac5fbd797be2307ad48f2d69bbcee7f0b2e5322","head":{"label":"scoopr:mtl_constantbuffers","ref":"mtl_constantbuffers","sha":"fac5fbd797be2307ad48f2d69bbcee7f0b2e5322","user":{"login":"scoopr","id":3896,"avatar_url":"https://avatars1.githubusercontent.com/u/3896?v=4","gravatar_id":"","url":"https://api.github.com/users/scoopr","html_url":"https://github.com/scoopr","followers_url":"https://api.github.com/users/scoopr/followers","following_url":"https://api.github.com/users/scoopr/following{/other_user}","gists_url":"https://api.github.com/users/scoopr/gists{/gist_id}","starred_url":"https://api.github.com/users/scoopr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoopr/subscriptions","organizations_url":"https://api.github.com/users/scoopr/orgs","repos_url":"https://api.github.com/users/scoopr/repos","events_url":"https://api.github.com/users/scoopr/events{/privacy}","received_events_url":"https://api.github.com/users/scoopr/received_events","type":"User","site_admin":false},"repo":{"id":111728898,"name":"gfx","full_name":"scoopr/gfx","owner":{"login":"scoopr","id":3896,"avatar_url":"https://avatars1.githubusercontent.com/u/3896?v=4","gravatar_id":"","url":"https://api.github.com/users/scoopr","html_url":"https://github.com/scoopr","followers_url":"https://api.github.com/users/scoopr/followers","following_url":"https://api.github.com/users/scoopr/following{/other_user}","gists_url":"https://api.github.com/users/scoopr/gists{/gist_id}","starred_url":"https://api.github.com/users/scoopr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoopr/subscriptions","organizations_url":"https://api.github.com/users/scoopr/orgs","repos_url":"https://api.github.com/users/scoopr/repos","events_url":"https://api.github.com/users/scoopr/events{/privacy}","received_events_url":"https://api.github.com/users/scoopr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scoopr/gfx","description":"A high-performance, bindless graphics API for Rust.","fork":true,"url":"https://api.github.com/repos/scoopr/gfx","forks_url":"https://api.github.com/repos/scoopr/gfx/forks","keys_url":"https://api.github.com/repos/scoopr/gfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scoopr/gfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scoopr/gfx/teams","hooks_url":"https://api.github.com/repos/scoopr/gfx/hooks","issue_events_url":"https://api.github.com/repos/scoopr/gfx/issues/events{/number}","events_url":"https://api.github.com/repos/scoopr/gfx/events","assignees_url":"https://api.github.com/repos/scoopr/gfx/assignees{/user}","branches_url":"https://api.github.com/repos/scoopr/gfx/branches{/branch}","tags_url":"https://api.github.com/repos/scoopr/gfx/tags","blobs_url":"https://api.github.com/repos/scoopr/gfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scoopr/gfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scoopr/gfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/scoopr/gfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scoopr/gfx/statuses/{sha}","languages_url":"https://api.github.com/repos/scoopr/gfx/languages","stargazers_url":"https://api.github.com/repos/scoopr/gfx/stargazers","contributors_url":"https://api.github.com/repos/scoopr/gfx/contributors","subscribers_url":"https://api.github.com/repos/scoopr/gfx/subscribers","subscription_url":"https://api.github.com/repos/scoopr/gfx/subscription","commits_url":"https://api.github.com/repos/scoopr/gfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/scoopr/gfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/scoopr/gfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/scoopr/gfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/scoopr/gfx/contents/{+path}","compare_url":"https://api.github.com/repos/scoopr/gfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scoopr/gfx/merges","archive_url":"https://api.github.com/repos/scoopr/gfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scoopr/gfx/downloads","issues_url":"https://api.github.com/repos/scoopr/gfx/issues{/number}","pulls_url":"https://api.github.com/repos/scoopr/gfx/pulls{/number}","milestones_url":"https://api.github.com/repos/scoopr/gfx/milestones{/number}","notifications_url":"https://api.github.com/repos/scoopr/gfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scoopr/gfx/labels{/name}","releases_url":"https://api.github.com/repos/scoopr/gfx/releases{/id}","deployments_url":"https://api.github.com/repos/scoopr/gfx/deployments","created_at":"2017-11-22T20:23:41Z","updated_at":"2017-11-22T20:23:44Z","pushed_at":"2017-11-22T20:28:10Z","git_url":"git://github.com/scoopr/gfx.git","ssh_url":"git@github.com:scoopr/gfx.git","clone_url":"https://github.com/scoopr/gfx.git","svn_url":"https://github.com/scoopr/gfx","homepage":"http://gfx-rs.github.io/","size":27548,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gfx-rs:master","ref":"master","sha":"c71fe15c1f93a3c0171414aa58ddb1f14b2eb376","user":{"login":"gfx-rs","id":8213174,"avatar_url":"https://avatars3.githubusercontent.com/u/8213174?v=4","gravatar_id":"","url":"https://api.github.com/users/gfx-rs","html_url":"https://github.com/gfx-rs","followers_url":"https://api.github.com/users/gfx-rs/followers","following_url":"https://api.github.com/users/gfx-rs/following{/other_user}","gists_url":"https://api.github.com/users/gfx-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gfx-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfx-rs/subscriptions","organizations_url":"https://api.github.com/users/gfx-rs/orgs","repos_url":"https://api.github.com/users/gfx-rs/repos","events_url":"https://api.github.com/users/gfx-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gfx-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":13847975,"name":"gfx","full_name":"gfx-rs/gfx","owner":{"login":"gfx-rs","id":8213174,"avatar_url":"https://avatars3.githubusercontent.com/u/8213174?v=4","gravatar_id":"","url":"https://api.github.com/users/gfx-rs","html_url":"https://github.com/gfx-rs","followers_url":"https://api.github.com/users/gfx-rs/followers","following_url":"https://api.github.com/users/gfx-rs/following{/other_user}","gists_url":"https://api.github.com/users/gfx-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gfx-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfx-rs/subscriptions","organizations_url":"https://api.github.com/users/gfx-rs/orgs","repos_url":"https://api.github.com/users/gfx-rs/repos","events_url":"https://api.github.com/users/gfx-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gfx-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gfx-rs/gfx","description":"A high-performance, bindless graphics API for Rust.","fork":false,"url":"https://api.github.com/repos/gfx-rs/gfx","forks_url":"https://api.github.com/repos/gfx-rs/gfx/forks","keys_url":"https://api.github.com/repos/gfx-rs/gfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfx-rs/gfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfx-rs/gfx/teams","hooks_url":"https://api.github.com/repos/gfx-rs/gfx/hooks","issue_events_url":"https://api.github.com/repos/gfx-rs/gfx/issues/events{/number}","events_url":"https://api.github.com/repos/gfx-rs/gfx/events","assignees_url":"https://api.github.com/repos/gfx-rs/gfx/assignees{/user}","branches_url":"https://api.github.com/repos/gfx-rs/gfx/branches{/branch}","tags_url":"https://api.github.com/repos/gfx-rs/gfx/tags","blobs_url":"https://api.github.com/repos/gfx-rs/gfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfx-rs/gfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfx-rs/gfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfx-rs/gfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfx-rs/gfx/statuses/{sha}","languages_url":"https://api.github.com/repos/gfx-rs/gfx/languages","stargazers_url":"https://api.github.com/repos/gfx-rs/gfx/stargazers","contributors_url":"https://api.github.com/repos/gfx-rs/gfx/contributors","subscribers_url":"https://api.github.com/repos/gfx-rs/gfx/subscribers","subscription_url":"https://api.github.com/repos/gfx-rs/gfx/subscription","commits_url":"https://api.github.com/repos/gfx-rs/gfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfx-rs/gfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfx-rs/gfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfx-rs/gfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfx-rs/gfx/contents/{+path}","compare_url":"https://api.github.com/repos/gfx-rs/gfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfx-rs/gfx/merges","archive_url":"https://api.github.com/repos/gfx-rs/gfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfx-rs/gfx/downloads","issues_url":"https://api.github.com/repos/gfx-rs/gfx/issues{/number}","pulls_url":"https://api.github.com/repos/gfx-rs/gfx/pulls{/number}","milestones_url":"https://api.github.com/repos/gfx-rs/gfx/milestones{/number}","notifications_url":"https://api.github.com/repos/gfx-rs/gfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfx-rs/gfx/labels{/name}","releases_url":"https://api.github.com/repos/gfx-rs/gfx/releases{/id}","deployments_url":"https://api.github.com/repos/gfx-rs/gfx/deployments","created_at":"2013-10-25T00:35:35Z","updated_at":"2017-11-22T19:08:11Z","pushed_at":"2017-11-22T20:36:17Z","git_url":"git://github.com/gfx-rs/gfx.git","ssh_url":"git@github.com:gfx-rs/gfx.git","clone_url":"https://github.com/gfx-rs/gfx.git","svn_url":"https://github.com/gfx-rs/gfx","homepage":"http://gfx-rs.github.io/","size":27548,"stargazers_count":1255,"watchers_count":1255,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":167,"forks":207,"open_issues":167,"watchers":1255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1639"},"html":{"href":"https://github.com/gfx-rs/gfx/pull/1639"},"issue":{"href":"https://api.github.com/repos/gfx-rs/gfx/issues/1639"},"comments":{"href":"https://api.github.com/repos/gfx-rs/gfx/issues/1639/comments"},"review_comments":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1639/comments"},"review_comment":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1639/commits"},"statuses":{"href":"https://api.github.com/repos/gfx-rs/gfx/statuses/fac5fbd797be2307ad48f2d69bbcee7f0b2e5322"}},"author_association":"NONE"}}
{"actor":{"display_login":"kvark"}}