{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45364","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45364/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45364/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45364/events","html_url":"https://github.com/kubernetes/kubernetes/pull/45364","id":226324327,"number":45364,"title":"[Federation] Record events in federated updater","user":{"login":"marun","id":451477,"avatar_url":"https://avatars0.githubusercontent.com/u/451477?v=3","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":258410135,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/federation","name":"sig/federation","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars3.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"assignees":[{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars3.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},{"login":"shashidharatd","id":8734900,"avatar_url":"https://avatars0.githubusercontent.com/u/8734900?v=3","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars3.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-05-04T15:43:37Z","updated_at":"2017-05-04T19:15:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45364","html_url":"https://github.com/kubernetes/kubernetes/pull/45364","diff_url":"https://github.com/kubernetes/kubernetes/pull/45364.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/45364.patch"},"body":"Controllers for federated types were previously recording events when generating the list of operations.  This change delegates responsibility for recording events to the federated updater so that events are recorded when the operations are actually executed, and ensures consistency across recording of both operation initiation and failure.  \r\n\r\nThe deletion helper was similarly updated to rely on the federated updater for event recording.  To support this change to the deletion helper, controllers have been updated to provide a namespace qualified name via the objNameFunc function to ensure that the updater can record events for deletions with the same detail as for add and update operations.\r\n\r\ncc: @kubernetes/sig-federation-pr-reviews @perotinus "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/299282273","html_url":"https://github.com/kubernetes/kubernetes/pull/45364#issuecomment-299282273","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45364","id":299282273,"user":{"login":"marun","id":451477,"avatar_url":"https://avatars0.githubusercontent.com/u/451477?v=3","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"created_at":"2017-05-04T19:15:38Z","updated_at":"2017-05-04T19:15:38Z","body":"I'm not sure why the unit tests are failing in ci, the failure looks unrelated and they pass locally. "}}
{"actor":{"display_login":"marun"}}