{"action":"opened","number":450,"pull_request":{"url":"https://api.github.com/repos/DoSomething/rogue/pulls/450","id":147078169,"html_url":"https://github.com/DoSomething/rogue/pull/450","diff_url":"https://github.com/DoSomething/rogue/pull/450.diff","patch_url":"https://github.com/DoSomething/rogue/pull/450.patch","issue_url":"https://api.github.com/repos/DoSomething/rogue/issues/450","number":450,"state":"open","locked":false,"title":"Support Contentful Campaign Ids","user":{"login":"sbsmith86","id":1700409,"avatar_url":"https://avatars0.githubusercontent.com/u/1700409?v=4","gravatar_id":"","url":"https://api.github.com/users/sbsmith86","html_url":"https://github.com/sbsmith86","followers_url":"https://api.github.com/users/sbsmith86/followers","following_url":"https://api.github.com/users/sbsmith86/following{/other_user}","gists_url":"https://api.github.com/users/sbsmith86/gists{/gist_id}","starred_url":"https://api.github.com/users/sbsmith86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbsmith86/subscriptions","organizations_url":"https://api.github.com/users/sbsmith86/orgs","repos_url":"https://api.github.com/users/sbsmith86/repos","events_url":"https://api.github.com/users/sbsmith86/events{/privacy}","received_events_url":"https://api.github.com/users/sbsmith86/received_events","type":"User","site_admin":false},"body":"#### What's this PR do?\r\n\r\nAllows Rogue to support Contentful Campaigns directly. Contentful Campaign IDs are strings in the vain of `6LQzMvDNQcYQYwso8qSkQ8`. So this PR updates the DB and some logic to support that. Also Contentful campaigns do not have runs, so this PR removes the requirements around `campaign_run_id`. Also adds tests for sending a request from Contentful. \r\n\r\n#### How should this be reviewed?\r\n\r\nI think you can go commit-by-commit. \r\n\r\n@DFurnes would love for you to check out the tests to make sure I am making the correct assumptions about what the request would look like. Mainly that PN would only send over a `campaign_id` with no run. \r\n\r\n#### Any background context you want to provide?\r\n\r\nThis will help PN talk directly to Rogue without needing a PA proxy endpoint. \r\n\r\n#### Relevant tickets\r\nFixes https://www.pivotaltracker.com/story/show/151853719\r\n\r\n#### Checklist\r\n- [ ] Documentation added for new features/changed endpoints.\r\n- [ ] Tested on staging.\r\n- [ ] Pinged a PM if this is a larger PR that would benefit from some additional testing love.","created_at":"2017-10-17T15:42:02Z","updated_at":"2017-10-17T15:42:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"DFurnes","id":583202,"avatar_url":"https://avatars1.githubusercontent.com/u/583202?v=4","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},{"login":"katiecrane","id":4240292,"avatar_url":"https://avatars1.githubusercontent.com/u/4240292?v=4","gravatar_id":"","url":"https://api.github.com/users/katiecrane","html_url":"https://github.com/katiecrane","followers_url":"https://api.github.com/users/katiecrane/followers","following_url":"https://api.github.com/users/katiecrane/following{/other_user}","gists_url":"https://api.github.com/users/katiecrane/gists{/gist_id}","starred_url":"https://api.github.com/users/katiecrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katiecrane/subscriptions","organizations_url":"https://api.github.com/users/katiecrane/orgs","repos_url":"https://api.github.com/users/katiecrane/repos","events_url":"https://api.github.com/users/katiecrane/events{/privacy}","received_events_url":"https://api.github.com/users/katiecrane/received_events","type":"User","site_admin":false},{"login":"chloealee","id":9019452,"avatar_url":"https://avatars2.githubusercontent.com/u/9019452?v=4","gravatar_id":"","url":"https://api.github.com/users/chloealee","html_url":"https://github.com/chloealee","followers_url":"https://api.github.com/users/chloealee/followers","following_url":"https://api.github.com/users/chloealee/following{/other_user}","gists_url":"https://api.github.com/users/chloealee/gists{/gist_id}","starred_url":"https://api.github.com/users/chloealee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chloealee/subscriptions","organizations_url":"https://api.github.com/users/chloealee/orgs","repos_url":"https://api.github.com/users/chloealee/repos","events_url":"https://api.github.com/users/chloealee/events{/privacy}","received_events_url":"https://api.github.com/users/chloealee/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/rogue/pulls/450/commits","review_comments_url":"https://api.github.com/repos/DoSomething/rogue/pulls/450/comments","review_comment_url":"https://api.github.com/repos/DoSomething/rogue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/rogue/issues/450/comments","statuses_url":"https://api.github.com/repos/DoSomething/rogue/statuses/05c2c9e01f07bc9483a1fda0ae98c58ae9d0ae2d","head":{"label":"DoSomething:campaign-id-as-string","ref":"campaign-id-as-string","sha":"05c2c9e01f07bc9483a1fda0ae98c58ae9d0ae2d","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":64166359,"name":"rogue","full_name":"DoSomething/rogue","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/rogue","description":":camera: The DoSomething.org campaign activity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/rogue","forks_url":"https://api.github.com/repos/DoSomething/rogue/forks","keys_url":"https://api.github.com/repos/DoSomething/rogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/rogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/rogue/teams","hooks_url":"https://api.github.com/repos/DoSomething/rogue/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/rogue/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/rogue/events","assignees_url":"https://api.github.com/repos/DoSomething/rogue/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/rogue/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/rogue/tags","blobs_url":"https://api.github.com/repos/DoSomething/rogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/rogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/rogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/rogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/rogue/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/rogue/languages","stargazers_url":"https://api.github.com/repos/DoSomething/rogue/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/rogue/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/rogue/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/rogue/subscription","commits_url":"https://api.github.com/repos/DoSomething/rogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/rogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/rogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/rogue/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/rogue/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/rogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/rogue/merges","archive_url":"https://api.github.com/repos/DoSomething/rogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/rogue/downloads","issues_url":"https://api.github.com/repos/DoSomething/rogue/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/rogue/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/rogue/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/rogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/rogue/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/rogue/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/rogue/deployments","created_at":"2016-07-25T20:38:30Z","updated_at":"2017-08-17T15:13:29Z","pushed_at":"2017-10-17T14:16:57Z","git_url":"git://github.com/DoSomething/rogue.git","ssh_url":"git@github.com:DoSomething/rogue.git","clone_url":"https://github.com/DoSomething/rogue.git","svn_url":"https://github.com/DoSomething/rogue","homepage":"https://rogue.dosomething.org","size":2860,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"DoSomething:master","ref":"master","sha":"f88239ef99577c07b9cbccaf8a78c7685aaad01d","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":64166359,"name":"rogue","full_name":"DoSomething/rogue","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars2.githubusercontent.com/u/731685?v=4","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/rogue","description":":camera: The DoSomething.org campaign activity service.","fork":false,"url":"https://api.github.com/repos/DoSomething/rogue","forks_url":"https://api.github.com/repos/DoSomething/rogue/forks","keys_url":"https://api.github.com/repos/DoSomething/rogue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/rogue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/rogue/teams","hooks_url":"https://api.github.com/repos/DoSomething/rogue/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/rogue/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/rogue/events","assignees_url":"https://api.github.com/repos/DoSomething/rogue/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/rogue/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/rogue/tags","blobs_url":"https://api.github.com/repos/DoSomething/rogue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/rogue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/rogue/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/rogue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/rogue/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/rogue/languages","stargazers_url":"https://api.github.com/repos/DoSomething/rogue/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/rogue/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/rogue/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/rogue/subscription","commits_url":"https://api.github.com/repos/DoSomething/rogue/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/rogue/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/rogue/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/rogue/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/rogue/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/rogue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/rogue/merges","archive_url":"https://api.github.com/repos/DoSomething/rogue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/rogue/downloads","issues_url":"https://api.github.com/repos/DoSomething/rogue/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/rogue/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/rogue/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/rogue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/rogue/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/rogue/releases{/id}","deployments_url":"https://api.github.com/repos/DoSomething/rogue/deployments","created_at":"2016-07-25T20:38:30Z","updated_at":"2017-08-17T15:13:29Z","pushed_at":"2017-10-17T14:16:57Z","git_url":"git://github.com/DoSomething/rogue.git","ssh_url":"git@github.com:DoSomething/rogue.git","clone_url":"https://github.com/DoSomething/rogue.git","svn_url":"https://github.com/DoSomething/rogue","homepage":"https://rogue.dosomething.org","size":2860,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/450"},"html":{"href":"https://github.com/DoSomething/rogue/pull/450"},"issue":{"href":"https://api.github.com/repos/DoSomething/rogue/issues/450"},"comments":{"href":"https://api.github.com/repos/DoSomething/rogue/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/rogue/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/rogue/statuses/05c2c9e01f07bc9483a1fda0ae98c58ae9d0ae2d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":9,"additions":382,"deletions":31,"changed_files":10}}
{"actor":{"display_login":"sbsmith86"}}