{"push_id":1755443118,"size":47,"distinct_size":13,"ref":"refs/heads/issue-1697-handle-redirects-when-getting-download-length","head":"ce5fb245d6fbcf1547551daa94b8e0b56a93971c","before":"958d3425d6b0bd9359958650562fe656a3a19737","commits":[{"sha":"ee4223edf281388ee1ed7a21203e8fee61d2befd","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Fix out-of-date map check\n\nThe out-of-date map check was using the wrong file name when looking for\na map's download properties.  It only considered the property file\n\"<mapName>.zip.properties\", which does not exist for map's downloaded\nfrom GitHub.  When the map download properties cannot be found, it is\nassumed the map is up-to-date.\n\nSince migrating the maps to GitHub, ResourceLoader considers the\nfollowing map zip file candidates when attempting to load a map:\n\n* <mapName>.zip\n* <normalizedMapName>-master.zip\n* <normalizedMapName>.zip\n\nThe fix for this issue was to modify the out-of-date map check to also\nconsider all these map zip file names when attempting to locate the\ncorresponding download properties file (the same name with \".properties\"\nappended).","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/ee4223edf281388ee1ed7a21203e8fee61d2befd"},{"sha":"a67c808b5fbb7f44fafda892d829632bd51e5c1f","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Initiate download of out-of-date maps upon user request\n\nPreviously, when the user answered Yes to the prompt to update their\nout-of-date maps, we would simply open the Download Maps window, and the\nuser would be required to manually update the maps.  This change\ninitiates the download of the out-of-date maps automatically in addition\nto opening the Download Maps window.","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/a67c808b5fbb7f44fafda892d829632bd51e5c1f"},{"sha":"ef8b1f989e7511a4cdf9aecc42af3b00550ff4b6","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Rename variables for consistency","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/ef8b1f989e7511a4cdf9aecc42af3b00550ff4b6"},{"sha":"de8d9052705d323d53be2618630708da549d2694","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Import predicate utilities statically for better readability","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/de8d9052705d323d53be2618630708da549d2694"},{"sha":"1376258389a03fbd69b97128cf3aee8cfa70a6e8","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Checkstyle: Fix missing Javadoc violations\n\nThe violations were fixed indirectly by either:\n\n1. Reducing the accessibility of the method from public to non-public if\n   it was not used outside its package\n2. Removing the method if it was unused","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/1376258389a03fbd69b97128cf3aee8cfa70a6e8"},{"sha":"492d5af31f1e214ab6f48747f41f621078052414","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Remove unused parameters from ProMatches methods","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/492d5af31f1e214ab6f48747f41f621078052414"},{"sha":"fc0f5323eb61e570c1c036577a1431a5e57787f7","author":{"name":"Ron","email":"f09ea674c9f5c875db0c4579cee54bd52fe6a78e@gmail.com"},"message":"Merge pull request #1724 from ssoloff/remove-unused-parameters-from-pro-matches-methods\n\nRemove unused parameters from ProMatches methods","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/fc0f5323eb61e570c1c036577a1431a5e57787f7"},{"sha":"2b1ed972908f769a205ce355e87af31ff4acffd7","author":{"name":"FrostionAAA","email":"50d0675dd20d649fd8bd0997d79622a09faf545e@hotmail.com"},"message":"Update triplea_maps.yaml\n\nUpdated Iron War to v0.1.5","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/2b1ed972908f769a205ce355e87af31ff4acffd7"},{"sha":"4c92fbff8c9cb39795b88a9de43df6e599d3256f","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Make private methods static where possible","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/4c92fbff8c9cb39795b88a9de43df6e599d3256f"},{"sha":"d65d17f219fb340c71085455c985e44dcee0708e","author":{"name":"Ron","email":"f09ea674c9f5c875db0c4579cee54bd52fe6a78e@gmail.com"},"message":"Merge pull request #1725 from FrostionAAA/patch-12\n\nUpdate triplea_maps.yaml","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/d65d17f219fb340c71085455c985e44dcee0708e"},{"sha":"5993b74ddb92e6390107cec70e29e3d545f7d90c","author":{"name":"Ron","email":"f09ea674c9f5c875db0c4579cee54bd52fe6a78e@gmail.com"},"message":"Merge pull request #1726 from ssoloff/make-private-methods-static-where-possible\n\nMake private methods static where possible","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/5993b74ddb92e6390107cec70e29e3d545f7d90c"},{"sha":"b994f609e47f326020a094f1d71806144441be2d","author":{"name":"RoiEX","email":"0d0860be757169ae6d9a398ad7378eda22205476@users.noreply.github.com"},"message":"Remove commented out lines","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/b994f609e47f326020a094f1d71806144441be2d"},{"sha":"b8ba4cb693f8d9603bbfe9a876b9d69ed2ee7911","author":{"name":"Ron","email":"f09ea674c9f5c875db0c4579cee54bd52fe6a78e@gmail.com"},"message":"Merge pull request #1727 from RoiEXLab/patch-1\n\nRemove commented out lines in travis-script","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/b8ba4cb693f8d9603bbfe9a876b9d69ed2ee7911"},{"sha":"c33e3c5a3307fa3924d8b71d02e83c0dff869915","author":{"name":"Ron","email":"f09ea674c9f5c875db0c4579cee54bd52fe6a78e@gmail.com"},"message":"Merge pull request #1713 from ssoloff/checkstyle-fix-missing-javadoc-violations-indirectly-part-1\n\nCheckstyle: Fix missing Javadoc violations indirectly (part 1)","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/c33e3c5a3307fa3924d8b71d02e83c0dff869915"},{"sha":"2c176902b0105b213a3e5fd90a198cd3529000d6","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Remove or document unused method parameters","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/2c176902b0105b213a3e5fd90a198cd3529000d6"},{"sha":"6df34cadc30c8ec70201f5154d070ae3caecc86e","author":{"name":"Ron","email":"f09ea674c9f5c875db0c4579cee54bd52fe6a78e@gmail.com"},"message":"Merge pull request #1729 from ssoloff/remove-or-document-unused-method-parameters-in-ai-code\n\nRemove or document unused method parameters in AI code","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/6df34cadc30c8ec70201f5154d070ae3caecc86e"},{"sha":"8c40d936c3b4c9395d7e721b0923ddd67f935cad","author":{"name":"Steven Soloff","email":"52845067cab45820870527292a782ac50ab49d4c@gmail.com"},"message":"Validate YAML files during build","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/8c40d936c3b4c9395d7e721b0923ddd67f935cad"},{"sha":"85c97b11d2e7bf31f31352c14dc8328607b768b7","author":{"name":"Dan Van Atta","email":"69de8b494ef4e6237ff7452df29a07088d6cda81@gmail.com"},"message":"Migration away from Derby DB: infrastructure for parallel DB writes\n\nThis is a precursor step to allow writing to both a new database and old.\n\nSummary of changes:\n- extracted an interface from DBUserController and named it 'UserDao'.\n- moved the static validation methods from DBUserController to the interface 'UserDao'\n- took the contents of DBUserController, and moved those contents to a new class 'DerbyUserController', which also impelments 'UserDao'\n- Updated DBUserController to delegates all calls to 'DerbyUserController' (DBUserController is now effectively a facade)\n- Added capability for primary/secondary datasource:\n  - DBUserController uses a UserDaoPrimarySecondary list to find a primary source to read from. DBUserController will log and ignore any errors thrown by the secondary datasource.\n  - Added a no-op secondary datasource\n\nWhat this commit changes:\n- we will now write to two datasources, the primary is the current (soon to be legacy) Derby DB datasource. The secondary is a no-op, and will have functionality added in further iterations\n- infrastructure only change, no user facing changes\n\nNext steps:\n- convert no-op datasource to do something, eventually writing to a datasource\n- add some migration logic, on logic, retrieve user records from old datasource and update the new one, re-encrypting the users password.\n- add infra to also read from both datasources and to give us a statistic of how much overlap there is\n- deploy this configuration\n- let some time pass while we wait for the overlap statistic to converge\n- switch primary datasources and then simpllify: remove parallel read/write infrastructure, remove non-primary datasource, rename SqlUserController to 'DBUserController'","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/85c97b11d2e7bf31f31352c14dc8328607b768b7"},{"sha":"87287f165cc6f40fa7a761ff205047d5ed0415fe","author":{"name":"Dan Van Atta","email":"69de8b494ef4e6237ff7452df29a07088d6cda81@gmail.com"},"message":"Checkstyle fixes, rename 'DB' -> 'Db', do variable renames, add javadocs.","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/87287f165cc6f40fa7a761ff205047d5ed0415fe"},{"sha":"91100d65fc18f24b0705918f82be572ee40a3bab","author":{"name":"Simon","email":"3a69a7dd305e9c7705028afae27095688d25197a@bigpond.com"},"message":"AutoSave + downgrade of #1583 in one commit","distinct":false,"url":"https://api.github.com/repos/ssoloff/triplea/commits/91100d65fc18f24b0705918f82be572ee40a3bab"}]}
{"actor":{"display_login":"ssoloff"}}