{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/smarthome/issues/4217","repository_url":"https://api.github.com/repos/eclipse/smarthome","labels_url":"https://api.github.com/repos/eclipse/smarthome/issues/4217/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/4217/comments","events_url":"https://api.github.com/repos/eclipse/smarthome/issues/4217/events","html_url":"https://github.com/eclipse/smarthome/pull/4217","id":256165084,"number":4217,"title":"support external annotations","user":{"login":"maggu2810","id":204670,"avatar_url":"https://avatars2.githubusercontent.com/u/204670?v=4","gravatar_id":"","url":"https://api.github.com/users/maggu2810","html_url":"https://github.com/maggu2810","followers_url":"https://api.github.com/users/maggu2810/followers","following_url":"https://api.github.com/users/maggu2810/following{/other_user}","gists_url":"https://api.github.com/users/maggu2810/gists{/gist_id}","starred_url":"https://api.github.com/users/maggu2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maggu2810/subscriptions","organizations_url":"https://api.github.com/users/maggu2810/orgs","repos_url":"https://api.github.com/users/maggu2810/repos","events_url":"https://api.github.com/users/maggu2810/events{/privacy}","received_events_url":"https://api.github.com/users/maggu2810/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-09-08T07:31:03Z","updated_at":"2017-09-15T05:10:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/4217","html_url":"https://github.com/eclipse/smarthome/pull/4217","diff_url":"https://github.com/eclipse/smarthome/pull/4217.diff","patch_url":"https://github.com/eclipse/smarthome/pull/4217.patch"},"body":"This commit adds initial support for external annotations.\r\n\r\nThere is a new project \"eclipse-external-annotations\" that must be\r\nimported in the Eclipse IDE.\r\n\r\nIf added already some annotations:\r\n* JRE\r\n   * Object.toString() returns a `@NonNull` String\r\n   * Collections.empty... returns a `@NonNull` reference\r\n   * Collections.singleton... returns a `@NonNull` reference\r\n   * Collections.synchronized... returns a `@NonNull` reference\r\n   * Collections.unmodifiable... returns a `@NonNull` reference\r\n* slf4j\r\n   * LoggerFactory.getLogger(...) returns a `@NonNull` reference\r\n\r\nIf a project should use external annotations this needs to be configured\r\nfor the Eclipse IDE in the project settings of each project.\r\nSee [Configuring a project to use external annotations]\r\nOpen the project settings and navigate to \"Java Build Path\", \"Library\"\r\ntab. Set the external annotation reference for \"JRE System Library\" and\r\n\"Plug-in Dependencies\".\r\nThis has been already applied for the core and the core.things project.\r\n\r\nFor the headless consumption a \"dedicated path\" is possible\r\n(\"-annotationpath location\").\r\nSee [Headless consumption]\r\nThis setting has been already added to the POM file.\r\n\r\nAdd new annotations is very easy as it is supported by the IDE.\r\nSee [Creating external annotations]\r\n\r\n[Configuring a project to use external annotations]: http://help.eclipse.org/oxygen/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Ftasks%2Ftask-using_external_null_annotations.htm&cp=1_3_9_2&anchor=configure\r\n[Creating external annotations]: http://help.eclipse.org/oxygen/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Ftasks%2Ftask-using_external_null_annotations.htm&cp=1_3_9_2&anchor=create\r\n[Headless consumption]: https://wiki.eclipse.org/JDT_Core/Null_Analysis/External_Annotations#Headless_consumption\r\n"},"comment":{"url":"https://api.github.com/repos/eclipse/smarthome/issues/comments/329682987","html_url":"https://github.com/eclipse/smarthome/pull/4217#issuecomment-329682987","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/4217","id":329682987,"user":{"login":"maggu2810","id":204670,"avatar_url":"https://avatars2.githubusercontent.com/u/204670?v=4","gravatar_id":"","url":"https://api.github.com/users/maggu2810","html_url":"https://github.com/maggu2810","followers_url":"https://api.github.com/users/maggu2810/followers","following_url":"https://api.github.com/users/maggu2810/following{/other_user}","gists_url":"https://api.github.com/users/maggu2810/gists{/gist_id}","starred_url":"https://api.github.com/users/maggu2810/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maggu2810/subscriptions","organizations_url":"https://api.github.com/users/maggu2810/orgs","repos_url":"https://api.github.com/users/maggu2810/repos","events_url":"https://api.github.com/users/maggu2810/events{/privacy}","received_events_url":"https://api.github.com/users/maggu2810/received_events","type":"User","site_admin":false},"created_at":"2017-09-15T05:10:12Z","updated_at":"2017-09-15T05:10:12Z","author_association":"CONTRIBUTOR","body":"@vorburger I have edit my comment last night again, so I assume you didn't get a mail. Can you please have a look at the edit post again?\r\nSorry for that effort, will create a new post next time."}}
{"actor":{"display_login":"maggu2810"}}