{"action":"created","comment":{"url":"https://api.github.com/repos/react-community/react-navigation/pulls/comments/113436428","pull_request_review_id":34823550,"id":113436428,"diff_hunk":"@@ -81,7 +81,8 @@ const RESPOND_THRESHOLD = 12;\n /**\n  * The distance of touch start from the edge of the screen where the gesture will be recognized\n  */\n-const GESTURE_RESPONSE_DISTANCE = 35;\n+const GESTURE_RESPONSE_DISTANCE_SIDE = 35;","path":"src/views/CardStack.js","position":5,"original_position":5,"commit_id":"05713a28d2dc2d2dcfd26f59a741b7930b2cb75b","original_commit_id":"05713a28d2dc2d2dcfd26f59a741b7930b2cb75b","user":{"login":"satya164","id":1174278,"avatar_url":"https://avatars1.githubusercontent.com/u/1174278?v=3","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false},"body":"nit: can we name it as `GESTURE_RESPONSE_DISTANCE_HORIZONTAL` and `GESTURE_RESPONSE_DISTANCE_VERTICAL`?","created_at":"2017-04-26T12:21:21Z","updated_at":"2017-04-26T12:22:30Z","html_url":"https://github.com/react-community/react-navigation/pull/1243#discussion_r113436428","pull_request_url":"https://api.github.com/repos/react-community/react-navigation/pulls/1243","_links":{"self":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/comments/113436428"},"html":{"href":"https://github.com/react-community/react-navigation/pull/1243#discussion_r113436428"},"pull_request":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/1243"}}},"pull_request":{"url":"https://api.github.com/repos/react-community/react-navigation/pulls/1243","id":117683893,"html_url":"https://github.com/react-community/react-navigation/pull/1243","diff_url":"https://github.com/react-community/react-navigation/pull/1243.diff","patch_url":"https://github.com/react-community/react-navigation/pull/1243.patch","issue_url":"https://api.github.com/repos/react-community/react-navigation/issues/1243","number":1243,"state":"open","locked":false,"title":"Modal gestureEnabled","user":{"login":"onlydave","id":2421197,"avatar_url":"https://avatars3.githubusercontent.com/u/2421197?v=3","gravatar_id":"","url":"https://api.github.com/users/onlydave","html_url":"https://github.com/onlydave","followers_url":"https://api.github.com/users/onlydave/followers","following_url":"https://api.github.com/users/onlydave/following{/other_user}","gists_url":"https://api.github.com/users/onlydave/gists{/gist_id}","starred_url":"https://api.github.com/users/onlydave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onlydave/subscriptions","organizations_url":"https://api.github.com/users/onlydave/orgs","repos_url":"https://api.github.com/users/onlydave/repos","events_url":"https://api.github.com/users/onlydave/events{/privacy}","received_events_url":"https://api.github.com/users/onlydave/received_events","type":"User","site_admin":false},"body":"Fixes #902\r\n\r\nAdding swipe down gesture back to modals.\r\n\r\nTested within our app on iOS and android.\r\n\r\nAnimations on android probably need some work but does the job. Card animation animates downwards.","created_at":"2017-04-26T10:44:32Z","updated_at":"2017-04-26T12:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce8571dcc9bd58cdaefffe913617ad0c4c6ab997","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-community/react-navigation/pulls/1243/commits","review_comments_url":"https://api.github.com/repos/react-community/react-navigation/pulls/1243/comments","review_comment_url":"https://api.github.com/repos/react-community/react-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-community/react-navigation/issues/1243/comments","statuses_url":"https://api.github.com/repos/react-community/react-navigation/statuses/05713a28d2dc2d2dcfd26f59a741b7930b2cb75b","head":{"label":"onlydave:modalGesture","ref":"modalGesture","sha":"05713a28d2dc2d2dcfd26f59a741b7930b2cb75b","user":{"login":"onlydave","id":2421197,"avatar_url":"https://avatars3.githubusercontent.com/u/2421197?v=3","gravatar_id":"","url":"https://api.github.com/users/onlydave","html_url":"https://github.com/onlydave","followers_url":"https://api.github.com/users/onlydave/followers","following_url":"https://api.github.com/users/onlydave/following{/other_user}","gists_url":"https://api.github.com/users/onlydave/gists{/gist_id}","starred_url":"https://api.github.com/users/onlydave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onlydave/subscriptions","organizations_url":"https://api.github.com/users/onlydave/orgs","repos_url":"https://api.github.com/users/onlydave/repos","events_url":"https://api.github.com/users/onlydave/events{/privacy}","received_events_url":"https://api.github.com/users/onlydave/received_events","type":"User","site_admin":false},"repo":{"id":88194848,"name":"react-navigation","full_name":"onlydave/react-navigation","owner":{"login":"onlydave","id":2421197,"avatar_url":"https://avatars3.githubusercontent.com/u/2421197?v=3","gravatar_id":"","url":"https://api.github.com/users/onlydave","html_url":"https://github.com/onlydave","followers_url":"https://api.github.com/users/onlydave/followers","following_url":"https://api.github.com/users/onlydave/following{/other_user}","gists_url":"https://api.github.com/users/onlydave/gists{/gist_id}","starred_url":"https://api.github.com/users/onlydave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onlydave/subscriptions","organizations_url":"https://api.github.com/users/onlydave/orgs","repos_url":"https://api.github.com/users/onlydave/repos","events_url":"https://api.github.com/users/onlydave/events{/privacy}","received_events_url":"https://api.github.com/users/onlydave/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/onlydave/react-navigation","description":"Learn once, navigate anywhere","fork":true,"url":"https://api.github.com/repos/onlydave/react-navigation","forks_url":"https://api.github.com/repos/onlydave/react-navigation/forks","keys_url":"https://api.github.com/repos/onlydave/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onlydave/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onlydave/react-navigation/teams","hooks_url":"https://api.github.com/repos/onlydave/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/onlydave/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/onlydave/react-navigation/events","assignees_url":"https://api.github.com/repos/onlydave/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/onlydave/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/onlydave/react-navigation/tags","blobs_url":"https://api.github.com/repos/onlydave/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onlydave/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onlydave/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/onlydave/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onlydave/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/onlydave/react-navigation/languages","stargazers_url":"https://api.github.com/repos/onlydave/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/onlydave/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/onlydave/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/onlydave/react-navigation/subscription","commits_url":"https://api.github.com/repos/onlydave/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/onlydave/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/onlydave/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/onlydave/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/onlydave/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/onlydave/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onlydave/react-navigation/merges","archive_url":"https://api.github.com/repos/onlydave/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onlydave/react-navigation/downloads","issues_url":"https://api.github.com/repos/onlydave/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/onlydave/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/onlydave/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/onlydave/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onlydave/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/onlydave/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/onlydave/react-navigation/deployments","created_at":"2017-04-13T18:30:48Z","updated_at":"2017-04-13T18:30:50Z","pushed_at":"2017-04-26T10:42:52Z","git_url":"git://github.com/onlydave/react-navigation.git","ssh_url":"git@github.com:onlydave/react-navigation.git","clone_url":"https://github.com/onlydave/react-navigation.git","svn_url":"https://github.com/onlydave/react-navigation","homepage":"https://reactnavigation.org","size":6780,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-community:master","ref":"master","sha":"8df3fa9db14640f7f9bf412bac5d2a3affc5f35a","user":{"login":"react-community","id":24483500,"avatar_url":"https://avatars0.githubusercontent.com/u/24483500?v=3","gravatar_id":"","url":"https://api.github.com/users/react-community","html_url":"https://github.com/react-community","followers_url":"https://api.github.com/users/react-community/followers","following_url":"https://api.github.com/users/react-community/following{/other_user}","gists_url":"https://api.github.com/users/react-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-community/subscriptions","organizations_url":"https://api.github.com/users/react-community/orgs","repos_url":"https://api.github.com/users/react-community/repos","events_url":"https://api.github.com/users/react-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-community/received_events","type":"Organization","site_admin":false},"repo":{"id":80149262,"name":"react-navigation","full_name":"react-community/react-navigation","owner":{"login":"react-community","id":24483500,"avatar_url":"https://avatars0.githubusercontent.com/u/24483500?v=3","gravatar_id":"","url":"https://api.github.com/users/react-community","html_url":"https://github.com/react-community","followers_url":"https://api.github.com/users/react-community/followers","following_url":"https://api.github.com/users/react-community/following{/other_user}","gists_url":"https://api.github.com/users/react-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-community/subscriptions","organizations_url":"https://api.github.com/users/react-community/orgs","repos_url":"https://api.github.com/users/react-community/repos","events_url":"https://api.github.com/users/react-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-community/react-navigation","description":"Learn once, navigate anywhere","fork":false,"url":"https://api.github.com/repos/react-community/react-navigation","forks_url":"https://api.github.com/repos/react-community/react-navigation/forks","keys_url":"https://api.github.com/repos/react-community/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-community/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-community/react-navigation/teams","hooks_url":"https://api.github.com/repos/react-community/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/react-community/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/react-community/react-navigation/events","assignees_url":"https://api.github.com/repos/react-community/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/react-community/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/react-community/react-navigation/tags","blobs_url":"https://api.github.com/repos/react-community/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-community/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-community/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-community/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-community/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/react-community/react-navigation/languages","stargazers_url":"https://api.github.com/repos/react-community/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/react-community/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/react-community/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/react-community/react-navigation/subscription","commits_url":"https://api.github.com/repos/react-community/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-community/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-community/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-community/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-community/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/react-community/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-community/react-navigation/merges","archive_url":"https://api.github.com/repos/react-community/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-community/react-navigation/downloads","issues_url":"https://api.github.com/repos/react-community/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/react-community/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/react-community/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/react-community/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-community/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/react-community/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/react-community/react-navigation/deployments","created_at":"2017-01-26T19:51:40Z","updated_at":"2017-04-26T11:45:14Z","pushed_at":"2017-04-26T12:06:00Z","git_url":"git://github.com/react-community/react-navigation.git","ssh_url":"git@github.com:react-community/react-navigation.git","clone_url":"https://github.com/react-community/react-navigation.git","svn_url":"https://github.com/react-community/react-navigation","homepage":"https://reactnavigation.org","size":6698,"stargazers_count":3902,"watchers_count":3902,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"open_issues_count":272,"forks":482,"open_issues":272,"watchers":3902,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/1243"},"html":{"href":"https://github.com/react-community/react-navigation/pull/1243"},"issue":{"href":"https://api.github.com/repos/react-community/react-navigation/issues/1243"},"comments":{"href":"https://api.github.com/repos/react-community/react-navigation/issues/1243/comments"},"review_comments":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/1243/comments"},"review_comment":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/1243/commits"},"statuses":{"href":"https://api.github.com/repos/react-community/react-navigation/statuses/05713a28d2dc2d2dcfd26f59a741b7930b2cb75b"}}}}
{"actor":{"display_login":"satya164"}}