{"action":"created","issue":{"url":"https://api.github.com/repos/LLNL/lbann/issues/92","repository_url":"https://api.github.com/repos/LLNL/lbann","labels_url":"https://api.github.com/repos/LLNL/lbann/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/LLNL/lbann/issues/92/comments","events_url":"https://api.github.com/repos/LLNL/lbann/issues/92/events","html_url":"https://github.com/LLNL/lbann/issues/92","id":241012993,"number":92,"title":"Layer indices","user":{"login":"ndryden","id":1119788,"avatar_url":"https://avatars0.githubusercontent.com/u/1119788?v=3","gravatar_id":"","url":"https://api.github.com/users/ndryden","html_url":"https://github.com/ndryden","followers_url":"https://api.github.com/users/ndryden/followers","following_url":"https://api.github.com/users/ndryden/following{/other_user}","gists_url":"https://api.github.com/users/ndryden/gists{/gist_id}","starred_url":"https://api.github.com/users/ndryden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndryden/subscriptions","organizations_url":"https://api.github.com/users/ndryden/orgs","repos_url":"https://api.github.com/users/ndryden/repos","events_url":"https://api.github.com/users/ndryden/events{/privacy}","received_events_url":"https://api.github.com/users/ndryden/received_events","type":"User","site_admin":false},"labels":[{"id":374636007,"url":"https://api.github.com/repos/LLNL/lbann/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-06T16:24:22Z","updated_at":"2017-07-06T16:37:23Z","closed_at":null,"body":"Currently, all our layers take a (manually-specified) index in their constructor. I propose removing this. Right now, `sequential_model` overrides what ever is set when its `add` method uses `set_index` to manually change the index to some sequential order (based on how the layers were added). Other model structures may do more complex things with indices.\r\n\r\nInstead, I propose that an index is assigned by a model via `set_index` when a layer is added to it.\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/LLNL/lbann/issues/comments/313450724","html_url":"https://github.com/LLNL/lbann/issues/92#issuecomment-313450724","issue_url":"https://api.github.com/repos/LLNL/lbann/issues/92","id":313450724,"user":{"login":"bvanessen","id":6210171,"avatar_url":"https://avatars1.githubusercontent.com/u/6210171?v=3","gravatar_id":"","url":"https://api.github.com/users/bvanessen","html_url":"https://github.com/bvanessen","followers_url":"https://api.github.com/users/bvanessen/followers","following_url":"https://api.github.com/users/bvanessen/following{/other_user}","gists_url":"https://api.github.com/users/bvanessen/gists{/gist_id}","starred_url":"https://api.github.com/users/bvanessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvanessen/subscriptions","organizations_url":"https://api.github.com/users/bvanessen/orgs","repos_url":"https://api.github.com/users/bvanessen/repos","events_url":"https://api.github.com/users/bvanessen/events{/privacy}","received_events_url":"https://api.github.com/users/bvanessen/received_events","type":"User","site_admin":false},"created_at":"2017-07-06T16:37:23Z","updated_at":"2017-07-06T16:37:23Z","body":"In general, I agree that the index should be set by the model rather than at the time of construction for the layer.  One consideration, is that if we add layers in a sequential fashion, this approach would work well.  However, if we want to insert a layer into a particular spot, how should we specify that?  Specifically, if we have a merge layer, how do we specify where the two previous layers sit.   I don’t think that we want to do this via dead reckoning with manual indices, however when we use a prototext description, how will we indicate that two layers are parallel versus serial?  Do we create a prototext group structure that contains multiple parallel layers and each group is sequential to the previous layer.\r\n\r\nBrian C. Van Essen\r\nvanessen1@llnl.gov\r\n(w) 925-422-9300\r\n(c) 925-290-5470\r\n\r\n\r\n\r\n\r\n\r\n> On Jul 6, 2017, at 9:24 AM, Nikoli Dryden <notifications@github.com> wrote:\r\n> \r\n> Currently, all our layers take a (manually-specified) index in their constructor. I propose removing this. Right now, sequential_model overrides what ever is set when its add method uses set_index to manually change the index to some sequential order (based on how the layers were added). Other model structures may do more complex things with indices.\r\n> \r\n> Instead, I propose that an index is assigned by a model via set_index when a layer is added to it.\r\n> \r\n> —\r\n> You are receiving this because you are subscribed to this thread.\r\n> Reply to this email directly, view it on GitHub, or mute the thread.\r\n> \r\n\r\n"}}
{"actor":{"display_login":"bvanessen"}}