{"action":"created","comment":{"url":"https://api.github.com/repos/krakenjs/xcomponent/pulls/comments/123910170","pull_request_review_id":46155664,"id":123910170,"diff_hunk":"@@ -137,19 +137,31 @@ export class Component extends BaseComponent {\n         // Register all of the drivers for instantiating components. The model used is -- there's a standard javascript\n         // way of rendering a component, then each other technology (e.g. react) needs to hook into that interface.\n         // This makes us a little more pluggable and loosely coupled.\n-\n+        this.driverResults = {};","path":"src/component/component/index.js","position":5,"original_position":5,"commit_id":"c09ba00b3e51b13ee72ec06d2d50a51b452303b6","original_commit_id":"c09ba00b3e51b13ee72ec06d2d50a51b452303b6","user":{"login":"harouny","id":1836266,"avatar_url":"https://avatars2.githubusercontent.com/u/1836266?v=3","gravatar_id":"","url":"https://api.github.com/users/harouny","html_url":"https://github.com/harouny","followers_url":"https://api.github.com/users/harouny/followers","following_url":"https://api.github.com/users/harouny/following{/other_user}","gists_url":"https://api.github.com/users/harouny/gists{/gist_id}","starred_url":"https://api.github.com/users/harouny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harouny/subscriptions","organizations_url":"https://api.github.com/users/harouny/orgs","repos_url":"https://api.github.com/users/harouny/repos","events_url":"https://api.github.com/users/harouny/events{/privacy}","received_events_url":"https://api.github.com/users/harouny/received_events","type":"User","site_admin":false},"body":"Its possible, actully I would have prefered that, however, it can be considered a breaking change scince same function returns the component itself in other drivers. i.e. angularJS","created_at":"2017-06-25T22:08:01Z","updated_at":"2017-06-25T22:08:01Z","html_url":"https://github.com/krakenjs/xcomponent/pull/102#discussion_r123910170","pull_request_url":"https://api.github.com/repos/krakenjs/xcomponent/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/krakenjs/xcomponent/pulls/comments/123910170"},"html":{"href":"https://github.com/krakenjs/xcomponent/pull/102#discussion_r123910170"},"pull_request":{"href":"https://api.github.com/repos/krakenjs/xcomponent/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/krakenjs/xcomponent/pulls/102","id":126658353,"html_url":"https://github.com/krakenjs/xcomponent/pull/102","diff_url":"https://github.com/krakenjs/xcomponent/pull/102.diff","patch_url":"https://github.com/krakenjs/xcomponent/pull/102.patch","issue_url":"https://api.github.com/repos/krakenjs/xcomponent/issues/102","number":102,"state":"open","locked":false,"title":"Feature/angular2 driver (#23)","user":{"login":"harouny","id":1836266,"avatar_url":"https://avatars2.githubusercontent.com/u/1836266?v=3","gravatar_id":"","url":"https://api.github.com/users/harouny","html_url":"https://github.com/harouny","followers_url":"https://api.github.com/users/harouny/followers","following_url":"https://api.github.com/users/harouny/following{/other_user}","gists_url":"https://api.github.com/users/harouny/gists{/gist_id}","starred_url":"https://api.github.com/users/harouny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harouny/subscriptions","organizations_url":"https://api.github.com/users/harouny/orgs","repos_url":"https://api.github.com/users/harouny/repos","events_url":"https://api.github.com/users/harouny/events{/privacy}","received_events_url":"https://api.github.com/users/harouny/received_events","type":"User","site_admin":false},"body":"Hey @bluepnume\r\n\r\nI expect a bit of discussion around this feature, no need to rush here. Feel free to send through any comments.\r\n\r\nThings worth to discuss:\r\nThe use of ```driverResults```.\r\nHaving to do ```bind(this)``` in host angular2 component.\r\n\r\nMy next step here is to work on loose props support, and add a few tests.","created_at":"2017-06-21T00:40:38Z","updated_at":"2017-06-25T22:08:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90b18a983b7a83904aab6d3bb7d7fabd1dca46af","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/krakenjs/xcomponent/pulls/102/commits","review_comments_url":"https://api.github.com/repos/krakenjs/xcomponent/pulls/102/comments","review_comment_url":"https://api.github.com/repos/krakenjs/xcomponent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/krakenjs/xcomponent/issues/102/comments","statuses_url":"https://api.github.com/repos/krakenjs/xcomponent/statuses/c09ba00b3e51b13ee72ec06d2d50a51b452303b6","head":{"label":"harouny:feature/angular2_driver","ref":"feature/angular2_driver","sha":"c09ba00b3e51b13ee72ec06d2d50a51b452303b6","user":{"login":"harouny","id":1836266,"avatar_url":"https://avatars2.githubusercontent.com/u/1836266?v=3","gravatar_id":"","url":"https://api.github.com/users/harouny","html_url":"https://github.com/harouny","followers_url":"https://api.github.com/users/harouny/followers","following_url":"https://api.github.com/users/harouny/following{/other_user}","gists_url":"https://api.github.com/users/harouny/gists{/gist_id}","starred_url":"https://api.github.com/users/harouny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harouny/subscriptions","organizations_url":"https://api.github.com/users/harouny/orgs","repos_url":"https://api.github.com/users/harouny/repos","events_url":"https://api.github.com/users/harouny/events{/privacy}","received_events_url":"https://api.github.com/users/harouny/received_events","type":"User","site_admin":false},"repo":{"id":84643859,"name":"xcomponent","full_name":"harouny/xcomponent","owner":{"login":"harouny","id":1836266,"avatar_url":"https://avatars2.githubusercontent.com/u/1836266?v=3","gravatar_id":"","url":"https://api.github.com/users/harouny","html_url":"https://github.com/harouny","followers_url":"https://api.github.com/users/harouny/followers","following_url":"https://api.github.com/users/harouny/following{/other_user}","gists_url":"https://api.github.com/users/harouny/gists{/gist_id}","starred_url":"https://api.github.com/users/harouny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harouny/subscriptions","organizations_url":"https://api.github.com/users/harouny/orgs","repos_url":"https://api.github.com/users/harouny/repos","events_url":"https://api.github.com/users/harouny/events{/privacy}","received_events_url":"https://api.github.com/users/harouny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harouny/xcomponent","description":"Cross domain components","fork":true,"url":"https://api.github.com/repos/harouny/xcomponent","forks_url":"https://api.github.com/repos/harouny/xcomponent/forks","keys_url":"https://api.github.com/repos/harouny/xcomponent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harouny/xcomponent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harouny/xcomponent/teams","hooks_url":"https://api.github.com/repos/harouny/xcomponent/hooks","issue_events_url":"https://api.github.com/repos/harouny/xcomponent/issues/events{/number}","events_url":"https://api.github.com/repos/harouny/xcomponent/events","assignees_url":"https://api.github.com/repos/harouny/xcomponent/assignees{/user}","branches_url":"https://api.github.com/repos/harouny/xcomponent/branches{/branch}","tags_url":"https://api.github.com/repos/harouny/xcomponent/tags","blobs_url":"https://api.github.com/repos/harouny/xcomponent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harouny/xcomponent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harouny/xcomponent/git/refs{/sha}","trees_url":"https://api.github.com/repos/harouny/xcomponent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harouny/xcomponent/statuses/{sha}","languages_url":"https://api.github.com/repos/harouny/xcomponent/languages","stargazers_url":"https://api.github.com/repos/harouny/xcomponent/stargazers","contributors_url":"https://api.github.com/repos/harouny/xcomponent/contributors","subscribers_url":"https://api.github.com/repos/harouny/xcomponent/subscribers","subscription_url":"https://api.github.com/repos/harouny/xcomponent/subscription","commits_url":"https://api.github.com/repos/harouny/xcomponent/commits{/sha}","git_commits_url":"https://api.github.com/repos/harouny/xcomponent/git/commits{/sha}","comments_url":"https://api.github.com/repos/harouny/xcomponent/comments{/number}","issue_comment_url":"https://api.github.com/repos/harouny/xcomponent/issues/comments{/number}","contents_url":"https://api.github.com/repos/harouny/xcomponent/contents/{+path}","compare_url":"https://api.github.com/repos/harouny/xcomponent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harouny/xcomponent/merges","archive_url":"https://api.github.com/repos/harouny/xcomponent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harouny/xcomponent/downloads","issues_url":"https://api.github.com/repos/harouny/xcomponent/issues{/number}","pulls_url":"https://api.github.com/repos/harouny/xcomponent/pulls{/number}","milestones_url":"https://api.github.com/repos/harouny/xcomponent/milestones{/number}","notifications_url":"https://api.github.com/repos/harouny/xcomponent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harouny/xcomponent/labels{/name}","releases_url":"https://api.github.com/repos/harouny/xcomponent/releases{/id}","deployments_url":"https://api.github.com/repos/harouny/xcomponent/deployments","created_at":"2017-03-11T11:04:19Z","updated_at":"2017-03-11T11:04:23Z","pushed_at":"2017-06-23T02:27:59Z","git_url":"git://github.com/harouny/xcomponent.git","ssh_url":"git@github.com:harouny/xcomponent.git","clone_url":"https://github.com/harouny/xcomponent.git","svn_url":"https://github.com/harouny/xcomponent","homepage":"","size":11489,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"krakenjs:master","ref":"master","sha":"dc5dbfc955a9daa1b598a7a34b1fd6e383db9276","user":{"login":"krakenjs","id":7001600,"avatar_url":"https://avatars3.githubusercontent.com/u/7001600?v=3","gravatar_id":"","url":"https://api.github.com/users/krakenjs","html_url":"https://github.com/krakenjs","followers_url":"https://api.github.com/users/krakenjs/followers","following_url":"https://api.github.com/users/krakenjs/following{/other_user}","gists_url":"https://api.github.com/users/krakenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/krakenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakenjs/subscriptions","organizations_url":"https://api.github.com/users/krakenjs/orgs","repos_url":"https://api.github.com/users/krakenjs/repos","events_url":"https://api.github.com/users/krakenjs/events{/privacy}","received_events_url":"https://api.github.com/users/krakenjs/received_events","type":"Organization","site_admin":false},"repo":{"id":59850602,"name":"xcomponent","full_name":"krakenjs/xcomponent","owner":{"login":"krakenjs","id":7001600,"avatar_url":"https://avatars3.githubusercontent.com/u/7001600?v=3","gravatar_id":"","url":"https://api.github.com/users/krakenjs","html_url":"https://github.com/krakenjs","followers_url":"https://api.github.com/users/krakenjs/followers","following_url":"https://api.github.com/users/krakenjs/following{/other_user}","gists_url":"https://api.github.com/users/krakenjs/gists{/gist_id}","starred_url":"https://api.github.com/users/krakenjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakenjs/subscriptions","organizations_url":"https://api.github.com/users/krakenjs/orgs","repos_url":"https://api.github.com/users/krakenjs/repos","events_url":"https://api.github.com/users/krakenjs/events{/privacy}","received_events_url":"https://api.github.com/users/krakenjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/krakenjs/xcomponent","description":"Cross domain components","fork":false,"url":"https://api.github.com/repos/krakenjs/xcomponent","forks_url":"https://api.github.com/repos/krakenjs/xcomponent/forks","keys_url":"https://api.github.com/repos/krakenjs/xcomponent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krakenjs/xcomponent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krakenjs/xcomponent/teams","hooks_url":"https://api.github.com/repos/krakenjs/xcomponent/hooks","issue_events_url":"https://api.github.com/repos/krakenjs/xcomponent/issues/events{/number}","events_url":"https://api.github.com/repos/krakenjs/xcomponent/events","assignees_url":"https://api.github.com/repos/krakenjs/xcomponent/assignees{/user}","branches_url":"https://api.github.com/repos/krakenjs/xcomponent/branches{/branch}","tags_url":"https://api.github.com/repos/krakenjs/xcomponent/tags","blobs_url":"https://api.github.com/repos/krakenjs/xcomponent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krakenjs/xcomponent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krakenjs/xcomponent/git/refs{/sha}","trees_url":"https://api.github.com/repos/krakenjs/xcomponent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krakenjs/xcomponent/statuses/{sha}","languages_url":"https://api.github.com/repos/krakenjs/xcomponent/languages","stargazers_url":"https://api.github.com/repos/krakenjs/xcomponent/stargazers","contributors_url":"https://api.github.com/repos/krakenjs/xcomponent/contributors","subscribers_url":"https://api.github.com/repos/krakenjs/xcomponent/subscribers","subscription_url":"https://api.github.com/repos/krakenjs/xcomponent/subscription","commits_url":"https://api.github.com/repos/krakenjs/xcomponent/commits{/sha}","git_commits_url":"https://api.github.com/repos/krakenjs/xcomponent/git/commits{/sha}","comments_url":"https://api.github.com/repos/krakenjs/xcomponent/comments{/number}","issue_comment_url":"https://api.github.com/repos/krakenjs/xcomponent/issues/comments{/number}","contents_url":"https://api.github.com/repos/krakenjs/xcomponent/contents/{+path}","compare_url":"https://api.github.com/repos/krakenjs/xcomponent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krakenjs/xcomponent/merges","archive_url":"https://api.github.com/repos/krakenjs/xcomponent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krakenjs/xcomponent/downloads","issues_url":"https://api.github.com/repos/krakenjs/xcomponent/issues{/number}","pulls_url":"https://api.github.com/repos/krakenjs/xcomponent/pulls{/number}","milestones_url":"https://api.github.com/repos/krakenjs/xcomponent/milestones{/number}","notifications_url":"https://api.github.com/repos/krakenjs/xcomponent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krakenjs/xcomponent/labels{/name}","releases_url":"https://api.github.com/repos/krakenjs/xcomponent/releases{/id}","deployments_url":"https://api.github.com/repos/krakenjs/xcomponent/deployments","created_at":"2016-05-27T17:05:58Z","updated_at":"2017-06-23T08:17:13Z","pushed_at":"2017-06-23T23:01:31Z","git_url":"git://github.com/krakenjs/xcomponent.git","ssh_url":"git@github.com:krakenjs/xcomponent.git","clone_url":"https://github.com/krakenjs/xcomponent.git","svn_url":"https://github.com/krakenjs/xcomponent","homepage":"","size":11024,"stargazers_count":183,"watchers_count":183,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":24,"forks":22,"open_issues":24,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/krakenjs/xcomponent/pulls/102"},"html":{"href":"https://github.com/krakenjs/xcomponent/pull/102"},"issue":{"href":"https://api.github.com/repos/krakenjs/xcomponent/issues/102"},"comments":{"href":"https://api.github.com/repos/krakenjs/xcomponent/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/krakenjs/xcomponent/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/krakenjs/xcomponent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/krakenjs/xcomponent/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/krakenjs/xcomponent/statuses/c09ba00b3e51b13ee72ec06d2d50a51b452303b6"}}}}
{"actor":{"display_login":"harouny"}}