{"action":"created","comment":{"url":"https://api.github.com/repos/google/keytransparency/pulls/comments/119143165","pull_request_review_id":40996383,"id":119143165,"diff_hunk":"@@ -132,7 +133,11 @@ func main() {\n \t}\n \tmutator := entry.New()\n \n+\tif *maxEpochDuration < *minEpochDuration {\n+\t\tglog.Exitf(\"Maximum time between epoch creation (%v) must be grater or equal minimum time between epoch creation.\")","path":"cmd/keytransparency-signer/backend.go","position":15,"original_position":15,"commit_id":"9d9a0c2fd3d139a88b3c09393d05e0ea9adbfacb","original_commit_id":"e20b42f6babdbbef7d2823c48799a6909a6c5904","user":{"login":"cesarghali","id":1832622,"avatar_url":"https://avatars1.githubusercontent.com/u/1832622?v=3","gravatar_id":"","url":"https://api.github.com/users/cesarghali","html_url":"https://github.com/cesarghali","followers_url":"https://api.github.com/users/cesarghali/followers","following_url":"https://api.github.com/users/cesarghali/following{/other_user}","gists_url":"https://api.github.com/users/cesarghali/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarghali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarghali/subscriptions","organizations_url":"https://api.github.com/users/cesarghali/orgs","repos_url":"https://api.github.com/users/cesarghali/repos","events_url":"https://api.github.com/users/cesarghali/events{/privacy}","received_events_url":"https://api.github.com/users/cesarghali/received_events","type":"User","site_admin":false},"body":"SG.","created_at":"2017-05-30T16:03:16Z","updated_at":"2017-05-30T16:03:16Z","html_url":"https://github.com/google/keytransparency/pull/593#discussion_r119143165","pull_request_url":"https://api.github.com/repos/google/keytransparency/pulls/593","_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments/119143165"},"html":{"href":"https://github.com/google/keytransparency/pull/593#discussion_r119143165"},"pull_request":{"href":"https://api.github.com/repos/google/keytransparency/pulls/593"}}},"pull_request":{"url":"https://api.github.com/repos/google/keytransparency/pulls/593","id":122432590,"html_url":"https://github.com/google/keytransparency/pull/593","diff_url":"https://github.com/google/keytransparency/pull/593.diff","patch_url":"https://github.com/google/keytransparency/pull/593.patch","issue_url":"https://api.github.com/repos/google/keytransparency/issues/593","number":593,"state":"open","locked":false,"title":"Only create epochs if there is something to process or the maximum nu…","user":{"login":"Liamsi","id":7441766,"avatar_url":"https://avatars0.githubusercontent.com/u/7441766?v=3","gravatar_id":"","url":"https://api.github.com/users/Liamsi","html_url":"https://github.com/Liamsi","followers_url":"https://api.github.com/users/Liamsi/followers","following_url":"https://api.github.com/users/Liamsi/following{/other_user}","gists_url":"https://api.github.com/users/Liamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamsi/subscriptions","organizations_url":"https://api.github.com/users/Liamsi/orgs","repos_url":"https://api.github.com/users/Liamsi/repos","events_url":"https://api.github.com/users/Liamsi/events{/privacy}","received_events_url":"https://api.github.com/users/Liamsi/received_events","type":"User","site_admin":false},"body":"…mber of min epoch intervals has passed\r\n\r\n- rename flag period to min-period\r\n- add max-period flag (number of passed min-periods until signer creates epoch independent from mutations)\r\n- add flag to `CreateEpoch` to let the caller enforce creating a new epoch (independent from mutations); update tests\r\n","created_at":"2017-05-25T12:42:54Z","updated_at":"2017-05-30T16:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c0d63fffc90e19aee735ad600db8789fc9f1551","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/keytransparency/pulls/593/commits","review_comments_url":"https://api.github.com/repos/google/keytransparency/pulls/593/comments","review_comment_url":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/keytransparency/issues/593/comments","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/9d9a0c2fd3d139a88b3c09393d05e0ea9adbfacb","head":{"label":"Liamsi:epochs-onlyif-mutations","ref":"epochs-onlyif-mutations","sha":"9d9a0c2fd3d139a88b3c09393d05e0ea9adbfacb","user":{"login":"Liamsi","id":7441766,"avatar_url":"https://avatars0.githubusercontent.com/u/7441766?v=3","gravatar_id":"","url":"https://api.github.com/users/Liamsi","html_url":"https://github.com/Liamsi","followers_url":"https://api.github.com/users/Liamsi/followers","following_url":"https://api.github.com/users/Liamsi/following{/other_user}","gists_url":"https://api.github.com/users/Liamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamsi/subscriptions","organizations_url":"https://api.github.com/users/Liamsi/orgs","repos_url":"https://api.github.com/users/Liamsi/repos","events_url":"https://api.github.com/users/Liamsi/events{/privacy}","received_events_url":"https://api.github.com/users/Liamsi/received_events","type":"User","site_admin":false},"repo":{"id":92180276,"name":"keytransparency","full_name":"Liamsi/keytransparency","owner":{"login":"Liamsi","id":7441766,"avatar_url":"https://avatars0.githubusercontent.com/u/7441766?v=3","gravatar_id":"","url":"https://api.github.com/users/Liamsi","html_url":"https://github.com/Liamsi","followers_url":"https://api.github.com/users/Liamsi/followers","following_url":"https://api.github.com/users/Liamsi/following{/other_user}","gists_url":"https://api.github.com/users/Liamsi/gists{/gist_id}","starred_url":"https://api.github.com/users/Liamsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Liamsi/subscriptions","organizations_url":"https://api.github.com/users/Liamsi/orgs","repos_url":"https://api.github.com/users/Liamsi/repos","events_url":"https://api.github.com/users/Liamsi/events{/privacy}","received_events_url":"https://api.github.com/users/Liamsi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Liamsi/keytransparency","description":"A transparent and secure way to look up public keys.","fork":true,"url":"https://api.github.com/repos/Liamsi/keytransparency","forks_url":"https://api.github.com/repos/Liamsi/keytransparency/forks","keys_url":"https://api.github.com/repos/Liamsi/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Liamsi/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Liamsi/keytransparency/teams","hooks_url":"https://api.github.com/repos/Liamsi/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/Liamsi/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/Liamsi/keytransparency/events","assignees_url":"https://api.github.com/repos/Liamsi/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/Liamsi/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/Liamsi/keytransparency/tags","blobs_url":"https://api.github.com/repos/Liamsi/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Liamsi/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Liamsi/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/Liamsi/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Liamsi/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/Liamsi/keytransparency/languages","stargazers_url":"https://api.github.com/repos/Liamsi/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/Liamsi/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/Liamsi/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/Liamsi/keytransparency/subscription","commits_url":"https://api.github.com/repos/Liamsi/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/Liamsi/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/Liamsi/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/Liamsi/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/Liamsi/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/Liamsi/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Liamsi/keytransparency/merges","archive_url":"https://api.github.com/repos/Liamsi/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Liamsi/keytransparency/downloads","issues_url":"https://api.github.com/repos/Liamsi/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/Liamsi/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/Liamsi/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/Liamsi/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Liamsi/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/Liamsi/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/Liamsi/keytransparency/deployments","created_at":"2017-05-23T14:06:38Z","updated_at":"2017-05-23T14:06:40Z","pushed_at":"2017-05-30T10:24:36Z","git_url":"git://github.com/Liamsi/keytransparency.git","ssh_url":"git@github.com:Liamsi/keytransparency.git","clone_url":"https://github.com/Liamsi/keytransparency.git","svn_url":"https://github.com/Liamsi/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":22001,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"8a73e56ae84ec0f504db51b2db900a83897cd4b6","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":37165115,"name":"keytransparency","full_name":"google/keytransparency","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/keytransparency","description":"A transparent and secure way to look up public keys.","fork":false,"url":"https://api.github.com/repos/google/keytransparency","forks_url":"https://api.github.com/repos/google/keytransparency/forks","keys_url":"https://api.github.com/repos/google/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/keytransparency/teams","hooks_url":"https://api.github.com/repos/google/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/google/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/keytransparency/events","assignees_url":"https://api.github.com/repos/google/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/keytransparency/tags","blobs_url":"https://api.github.com/repos/google/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/keytransparency/languages","stargazers_url":"https://api.github.com/repos/google/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/google/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/google/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/google/keytransparency/subscription","commits_url":"https://api.github.com/repos/google/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/keytransparency/merges","archive_url":"https://api.github.com/repos/google/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/keytransparency/downloads","issues_url":"https://api.github.com/repos/google/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/google/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/google/keytransparency/deployments","created_at":"2015-06-09T23:55:20Z","updated_at":"2017-05-29T18:47:52Z","pushed_at":"2017-05-30T10:24:37Z","git_url":"git://github.com/google/keytransparency.git","ssh_url":"git@github.com:google/keytransparency.git","clone_url":"https://github.com/google/keytransparency.git","svn_url":"https://github.com/google/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":21991,"stargazers_count":1122,"watchers_count":1122,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":37,"forks":61,"open_issues":37,"watchers":1122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/593"},"html":{"href":"https://github.com/google/keytransparency/pull/593"},"issue":{"href":"https://api.github.com/repos/google/keytransparency/issues/593"},"comments":{"href":"https://api.github.com/repos/google/keytransparency/issues/593/comments"},"review_comments":{"href":"https://api.github.com/repos/google/keytransparency/pulls/593/comments"},"review_comment":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/keytransparency/pulls/593/commits"},"statuses":{"href":"https://api.github.com/repos/google/keytransparency/statuses/9d9a0c2fd3d139a88b3c09393d05e0ea9adbfacb"}}}}
{"actor":{"display_login":"cesarghali"}}