{"action":"created","issue":{"url":"https://api.github.com/repos/o3ma/o3/issues/14","repository_url":"https://api.github.com/repos/o3ma/o3","labels_url":"https://api.github.com/repos/o3ma/o3/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/o3ma/o3/issues/14/comments","events_url":"https://api.github.com/repos/o3ma/o3/issues/14/events","html_url":"https://github.com/o3ma/o3/issues/14","id":200477914,"number":14,"title":"Crash","user":{"login":"Sec42","id":464856,"avatar_url":"https://avatars.githubusercontent.com/u/464856?v=3","gravatar_id":"","url":"https://api.github.com/users/Sec42","html_url":"https://github.com/Sec42","followers_url":"https://api.github.com/users/Sec42/followers","following_url":"https://api.github.com/users/Sec42/following{/other_user}","gists_url":"https://api.github.com/users/Sec42/gists{/gist_id}","starred_url":"https://api.github.com/users/Sec42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sec42/subscriptions","organizations_url":"https://api.github.com/users/Sec42/orgs","repos_url":"https://api.github.com/users/Sec42/repos","events_url":"https://api.github.com/users/Sec42/events{/privacy}","received_events_url":"https://api.github.com/users/Sec42/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-12T20:59:13Z","updated_at":"2017-01-18T18:51:39Z","closed_at":null,"body":"Leaving a bot running for some time, I got the following crash:\r\n\r\n```\r\npanic: not enough bytes were transmitted\r\n\r\ngoroutine 22 [running]:\r\npanic(0x66b820, 0xc420172d30)\r\n        /usr/local/go/src/runtime/panic.go:500 +0x1a1\r\ngithub.com/o3ma/o3.writeHelper(0x7ece40, 0xc420084048, 0xc4201775e0)\r\n        /home/sec/Projects/gopath/src/github.com/o3ma/o3/packetdispatcher.go:30 +0x11e\r\ngithub.com/o3ma/o3.(*SessionContext).dispatchEchoMsg(0x80b5c0, 0x7ece40, 0xc420084048, 0x80, 0x118)\r\n        /home/sec/Projects/gopath/src/github.com/o3ma/o3/packetdispatcher.go:119 +0x309\r\ngithub.com/o3ma/o3.(*SessionContext).sendLoop(0x80b5c0)\r\n        /home/sec/Projects/gopath/src/github.com/o3ma/o3/communicationhandler.go:131 +0x231\r\ncreated by github.com/o3ma/o3.(*SessionContext).receiveLoop\r\n        /home/sec/Projects/gopath/src/github.com/o3ma/o3/communicationhandler.go:103 +0x54e\r\nexit status 2\r\n```"},"comment":{"url":"https://api.github.com/repos/o3ma/o3/issues/comments/273565239","html_url":"https://github.com/o3ma/o3/issues/14#issuecomment-273565239","issue_url":"https://api.github.com/repos/o3ma/o3/issues/14","id":273565239,"user":{"login":"willnix","id":807270,"avatar_url":"https://avatars.githubusercontent.com/u/807270?v=3","gravatar_id":"","url":"https://api.github.com/users/willnix","html_url":"https://github.com/willnix","followers_url":"https://api.github.com/users/willnix/followers","following_url":"https://api.github.com/users/willnix/following{/other_user}","gists_url":"https://api.github.com/users/willnix/gists{/gist_id}","starred_url":"https://api.github.com/users/willnix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willnix/subscriptions","organizations_url":"https://api.github.com/users/willnix/orgs","repos_url":"https://api.github.com/users/willnix/repos","events_url":"https://api.github.com/users/willnix/events{/privacy}","received_events_url":"https://api.github.com/users/willnix/received_events","type":"User","site_admin":false},"created_at":"2017-01-18T18:51:39Z","updated_at":"2017-01-18T18:51:39Z","body":"Well this looks like the expected result of a network failure.\r\nI agree however, that a short network failure should be handled gracefully. \r\nI don't think this would have happened if the connection was alive, because TCP should handle minor packet losses.\r\nBut if the connection was closed we have to reconnect and do the handshake again before we can attempt to send the packet again.\r\nI have a redesign of the connection handling planned anyway. That should allow for easy connection renewal..."}}
{"actor":{"display_login":"willnix"}}