{"action":"opened","number":131,"pull_request":{"url":"https://api.github.com/repos/fnproject/cli/pulls/131","id":160486388,"html_url":"https://github.com/fnproject/cli/pull/131","diff_url":"https://github.com/fnproject/cli/pull/131.diff","patch_url":"https://github.com/fnproject/cli/pull/131.patch","issue_url":"https://api.github.com/repos/fnproject/cli/issues/131","number":131,"state":"open","locked":false,"title":"Allow port number in FN_REGISTRY for private registry support","user":{"login":"AstromechZA","id":1651305,"avatar_url":"https://avatars0.githubusercontent.com/u/1651305?v=4","gravatar_id":"","url":"https://api.github.com/users/AstromechZA","html_url":"https://github.com/AstromechZA","followers_url":"https://api.github.com/users/AstromechZA/followers","following_url":"https://api.github.com/users/AstromechZA/following{/other_user}","gists_url":"https://api.github.com/users/AstromechZA/gists{/gist_id}","starred_url":"https://api.github.com/users/AstromechZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AstromechZA/subscriptions","organizations_url":"https://api.github.com/users/AstromechZA/orgs","repos_url":"https://api.github.com/users/AstromechZA/repos","events_url":"https://api.github.com/users/AstromechZA/events{/privacy}","received_events_url":"https://api.github.com/users/AstromechZA/received_events","type":"User","site_admin":false},"body":"Fixes #69.\r\n\r\nAfter the discussion in https://github.com/fnproject/cli/pull/72 it looks like any heavy name validation will be moved to server side. However this doesn't fix the issue of the validateImageName implementation blocking port numbers in the image prefix. This PR just makes that function a bit more flexible and allows people to move forward with custom private registry paths and the like.\r\n\r\nThis now supports FN_REGISTRY being anything like:\r\n\r\n- `owner` (for docker.io)\r\n- `hostname.com` (for custom registry)\r\n- `hostname.com:port` (for custom registry on custom port)\r\n- `hostname.com/owner` (for owner in custom registry)\r\n\r\nDocker push automatically works out when you're talking about a custom registry or an owner in docker.io by doing DNS matching on the first part of the full image name. (see https://github.com/docker/distribution/blob/master/reference/normalize.go#L33)","created_at":"2017-12-29T08:18:33Z","updated_at":"2017-12-29T08:18:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fnproject/cli/pulls/131/commits","review_comments_url":"https://api.github.com/repos/fnproject/cli/pulls/131/comments","review_comment_url":"https://api.github.com/repos/fnproject/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fnproject/cli/issues/131/comments","statuses_url":"https://api.github.com/repos/fnproject/cli/statuses/d8a8cc9b1c1cd52c1cc767da4729d1938cc20dd2","head":{"label":"AstromechZA:aza-issue-69","ref":"aza-issue-69","sha":"d8a8cc9b1c1cd52c1cc767da4729d1938cc20dd2","user":{"login":"AstromechZA","id":1651305,"avatar_url":"https://avatars0.githubusercontent.com/u/1651305?v=4","gravatar_id":"","url":"https://api.github.com/users/AstromechZA","html_url":"https://github.com/AstromechZA","followers_url":"https://api.github.com/users/AstromechZA/followers","following_url":"https://api.github.com/users/AstromechZA/following{/other_user}","gists_url":"https://api.github.com/users/AstromechZA/gists{/gist_id}","starred_url":"https://api.github.com/users/AstromechZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AstromechZA/subscriptions","organizations_url":"https://api.github.com/users/AstromechZA/orgs","repos_url":"https://api.github.com/users/AstromechZA/repos","events_url":"https://api.github.com/users/AstromechZA/events{/privacy}","received_events_url":"https://api.github.com/users/AstromechZA/received_events","type":"User","site_admin":false},"repo":{"id":110598779,"name":"fnproject-cli","full_name":"AstromechZA/fnproject-cli","owner":{"login":"AstromechZA","id":1651305,"avatar_url":"https://avatars0.githubusercontent.com/u/1651305?v=4","gravatar_id":"","url":"https://api.github.com/users/AstromechZA","html_url":"https://github.com/AstromechZA","followers_url":"https://api.github.com/users/AstromechZA/followers","following_url":"https://api.github.com/users/AstromechZA/following{/other_user}","gists_url":"https://api.github.com/users/AstromechZA/gists{/gist_id}","starred_url":"https://api.github.com/users/AstromechZA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AstromechZA/subscriptions","organizations_url":"https://api.github.com/users/AstromechZA/orgs","repos_url":"https://api.github.com/users/AstromechZA/repos","events_url":"https://api.github.com/users/AstromechZA/events{/privacy}","received_events_url":"https://api.github.com/users/AstromechZA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AstromechZA/fnproject-cli","description":"CLI tool for fnproject. ","fork":true,"url":"https://api.github.com/repos/AstromechZA/fnproject-cli","forks_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/forks","keys_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/teams","hooks_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/hooks","issue_events_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/issues/events{/number}","events_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/events","assignees_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/assignees{/user}","branches_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/branches{/branch}","tags_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/tags","blobs_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/languages","stargazers_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/stargazers","contributors_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/contributors","subscribers_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/subscribers","subscription_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/subscription","commits_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/contents/{+path}","compare_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/merges","archive_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/downloads","issues_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/issues{/number}","pulls_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/labels{/name}","releases_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/releases{/id}","deployments_url":"https://api.github.com/repos/AstromechZA/fnproject-cli/deployments","created_at":"2017-11-13T20:33:36Z","updated_at":"2017-12-24T08:52:42Z","pushed_at":"2017-12-29T08:05:57Z","git_url":"git://github.com/AstromechZA/fnproject-cli.git","ssh_url":"git@github.com:AstromechZA/fnproject-cli.git","clone_url":"https://github.com/AstromechZA/fnproject-cli.git","svn_url":"https://github.com/AstromechZA/fnproject-cli","homepage":"https://fnproject.github.io/","size":230,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fnproject:master","ref":"master","sha":"41cffa4a5f26dd50c326eedc5dd872d841f545fe","user":{"login":"fnproject","id":30273834,"avatar_url":"https://avatars2.githubusercontent.com/u/30273834?v=4","gravatar_id":"","url":"https://api.github.com/users/fnproject","html_url":"https://github.com/fnproject","followers_url":"https://api.github.com/users/fnproject/followers","following_url":"https://api.github.com/users/fnproject/following{/other_user}","gists_url":"https://api.github.com/users/fnproject/gists{/gist_id}","starred_url":"https://api.github.com/users/fnproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnproject/subscriptions","organizations_url":"https://api.github.com/users/fnproject/orgs","repos_url":"https://api.github.com/users/fnproject/repos","events_url":"https://api.github.com/users/fnproject/events{/privacy}","received_events_url":"https://api.github.com/users/fnproject/received_events","type":"Organization","site_admin":false},"repo":{"id":98561430,"name":"cli","full_name":"fnproject/cli","owner":{"login":"fnproject","id":30273834,"avatar_url":"https://avatars2.githubusercontent.com/u/30273834?v=4","gravatar_id":"","url":"https://api.github.com/users/fnproject","html_url":"https://github.com/fnproject","followers_url":"https://api.github.com/users/fnproject/followers","following_url":"https://api.github.com/users/fnproject/following{/other_user}","gists_url":"https://api.github.com/users/fnproject/gists{/gist_id}","starred_url":"https://api.github.com/users/fnproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnproject/subscriptions","organizations_url":"https://api.github.com/users/fnproject/orgs","repos_url":"https://api.github.com/users/fnproject/repos","events_url":"https://api.github.com/users/fnproject/events{/privacy}","received_events_url":"https://api.github.com/users/fnproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fnproject/cli","description":"CLI tool for fnproject. ","fork":false,"url":"https://api.github.com/repos/fnproject/cli","forks_url":"https://api.github.com/repos/fnproject/cli/forks","keys_url":"https://api.github.com/repos/fnproject/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fnproject/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fnproject/cli/teams","hooks_url":"https://api.github.com/repos/fnproject/cli/hooks","issue_events_url":"https://api.github.com/repos/fnproject/cli/issues/events{/number}","events_url":"https://api.github.com/repos/fnproject/cli/events","assignees_url":"https://api.github.com/repos/fnproject/cli/assignees{/user}","branches_url":"https://api.github.com/repos/fnproject/cli/branches{/branch}","tags_url":"https://api.github.com/repos/fnproject/cli/tags","blobs_url":"https://api.github.com/repos/fnproject/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fnproject/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fnproject/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/fnproject/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fnproject/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/fnproject/cli/languages","stargazers_url":"https://api.github.com/repos/fnproject/cli/stargazers","contributors_url":"https://api.github.com/repos/fnproject/cli/contributors","subscribers_url":"https://api.github.com/repos/fnproject/cli/subscribers","subscription_url":"https://api.github.com/repos/fnproject/cli/subscription","commits_url":"https://api.github.com/repos/fnproject/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/fnproject/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/fnproject/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/fnproject/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/fnproject/cli/contents/{+path}","compare_url":"https://api.github.com/repos/fnproject/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fnproject/cli/merges","archive_url":"https://api.github.com/repos/fnproject/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fnproject/cli/downloads","issues_url":"https://api.github.com/repos/fnproject/cli/issues{/number}","pulls_url":"https://api.github.com/repos/fnproject/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/fnproject/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/fnproject/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fnproject/cli/labels{/name}","releases_url":"https://api.github.com/repos/fnproject/cli/releases{/id}","deployments_url":"https://api.github.com/repos/fnproject/cli/deployments","created_at":"2017-07-27T17:01:37Z","updated_at":"2017-12-29T07:51:14Z","pushed_at":"2017-12-28T19:38:20Z","git_url":"git://github.com/fnproject/cli.git","ssh_url":"git@github.com:fnproject/cli.git","clone_url":"https://github.com/fnproject/cli.git","svn_url":"https://github.com/fnproject/cli","homepage":"https://fnproject.github.io/","size":237,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11,"open_issues":36,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fnproject/cli/pulls/131"},"html":{"href":"https://github.com/fnproject/cli/pull/131"},"issue":{"href":"https://api.github.com/repos/fnproject/cli/issues/131"},"comments":{"href":"https://api.github.com/repos/fnproject/cli/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/fnproject/cli/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/fnproject/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fnproject/cli/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/fnproject/cli/statuses/d8a8cc9b1c1cd52c1cc767da4729d1938cc20dd2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":34,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"AstromechZA"}}