{"action":"created","comment":{"url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/comments/133027555","pull_request_review_id":56164638,"id":133027555,"diff_hunk":"@@ -618,13 +673,25 @@\n                                 {\n                                     \"Fn::GetAtt\": [\n                                         \"VPCStack\",\n-                                        \"Outputs.PublicSubnet1ID\"\n+                                        {\n+                                            \"Fn::If\": [\n+                                                \"PublicSubnetCondition\",\n+                                                \"Outputs.PublicSubnet1ID\",\n+                                                \"Outputs.PrivateSubnet1ID\"\n+                                            ]\n+                                        }\n                                     ]\n                                 },\n                                 {\n                                     \"Fn::GetAtt\": [\n                                         \"VPCStack\",\n-                                        \"Outputs.PublicSubnet2ID\"\n+                                        {\n+                                            \"Fn::If\": [\n+                                                \"PublicSubnetCondition\",\n+                                                \"Outputs.PublicSubnet2ID\",\n+                                                \"Outputs.PrivateSubnet2ID\"","path":"templates/confluent-kafka-master.template","position":142,"original_position":142,"commit_id":"be5d5e8f90a3c58d668e1ede4ffeadae666aea98","original_commit_id":"be5d5e8f90a3c58d668e1ede4ffeadae666aea98","user":{"login":"santiagocardenas","id":15354608,"avatar_url":"https://avatars0.githubusercontent.com/u/15354608?v=4","gravatar_id":"","url":"https://api.github.com/users/santiagocardenas","html_url":"https://github.com/santiagocardenas","followers_url":"https://api.github.com/users/santiagocardenas/followers","following_url":"https://api.github.com/users/santiagocardenas/following{/other_user}","gists_url":"https://api.github.com/users/santiagocardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/santiagocardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiagocardenas/subscriptions","organizations_url":"https://api.github.com/users/santiagocardenas/orgs","repos_url":"https://api.github.com/users/santiagocardenas/repos","events_url":"https://api.github.com/users/santiagocardenas/events{/privacy}","received_events_url":"https://api.github.com/users/santiagocardenas/received_events","type":"User","site_admin":false},"body":"Should be Outputs.PrivateSubnet2AID","created_at":"2017-08-14T18:37:30Z","updated_at":"2017-08-14T18:37:30Z","html_url":"https://github.com/aws-quickstart/quickstart-confluent-kafka/pull/38#discussion_r133027555","pull_request_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/comments/133027555"},"html":{"href":"https://github.com/aws-quickstart/quickstart-confluent-kafka/pull/38#discussion_r133027555"},"pull_request":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/38","id":133545464,"html_url":"https://github.com/aws-quickstart/quickstart-confluent-kafka/pull/38","diff_url":"https://github.com/aws-quickstart/quickstart-confluent-kafka/pull/38.diff","patch_url":"https://github.com/aws-quickstart/quickstart-confluent-kafka/pull/38.patch","issue_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/issues/38","number":38,"state":"open","locked":false,"title":"Add a parameter for AssociatePublicIpAddress","user":{"login":"bbck","id":154447,"avatar_url":"https://avatars1.githubusercontent.com/u/154447?v=4","gravatar_id":"","url":"https://api.github.com/users/bbck","html_url":"https://github.com/bbck","followers_url":"https://api.github.com/users/bbck/followers","following_url":"https://api.github.com/users/bbck/following{/other_user}","gists_url":"https://api.github.com/users/bbck/gists{/gist_id}","starred_url":"https://api.github.com/users/bbck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbck/subscriptions","organizations_url":"https://api.github.com/users/bbck/orgs","repos_url":"https://api.github.com/users/bbck/repos","events_url":"https://api.github.com/users/bbck/events{/privacy}","received_events_url":"https://api.github.com/users/bbck/received_events","type":"User","site_admin":false},"body":"Adds a parameter `AssignPublicIP` to pass to `AssociatePublicIpAddress` in the nodegroup template. Should resolve #29 ","created_at":"2017-08-01T18:52:09Z","updated_at":"2017-08-14T18:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d3b55a2ced668407973db6341fcb8745903a980","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/38/commits","review_comments_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/38/comments","review_comment_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/issues/38/comments","statuses_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/statuses/be5d5e8f90a3c58d668e1ede4ffeadae666aea98","head":{"label":"bbck:public-ip-parameter","ref":"public-ip-parameter","sha":"be5d5e8f90a3c58d668e1ede4ffeadae666aea98","user":{"login":"bbck","id":154447,"avatar_url":"https://avatars1.githubusercontent.com/u/154447?v=4","gravatar_id":"","url":"https://api.github.com/users/bbck","html_url":"https://github.com/bbck","followers_url":"https://api.github.com/users/bbck/followers","following_url":"https://api.github.com/users/bbck/following{/other_user}","gists_url":"https://api.github.com/users/bbck/gists{/gist_id}","starred_url":"https://api.github.com/users/bbck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbck/subscriptions","organizations_url":"https://api.github.com/users/bbck/orgs","repos_url":"https://api.github.com/users/bbck/repos","events_url":"https://api.github.com/users/bbck/events{/privacy}","received_events_url":"https://api.github.com/users/bbck/received_events","type":"User","site_admin":false},"repo":{"id":99029229,"name":"quickstart-confluent-kafka","full_name":"bbck/quickstart-confluent-kafka","owner":{"login":"bbck","id":154447,"avatar_url":"https://avatars1.githubusercontent.com/u/154447?v=4","gravatar_id":"","url":"https://api.github.com/users/bbck","html_url":"https://github.com/bbck","followers_url":"https://api.github.com/users/bbck/followers","following_url":"https://api.github.com/users/bbck/following{/other_user}","gists_url":"https://api.github.com/users/bbck/gists{/gist_id}","starred_url":"https://api.github.com/users/bbck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbck/subscriptions","organizations_url":"https://api.github.com/users/bbck/orgs","repos_url":"https://api.github.com/users/bbck/repos","events_url":"https://api.github.com/users/bbck/events{/privacy}","received_events_url":"https://api.github.com/users/bbck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbck/quickstart-confluent-kafka","description":"AWS Quick Start Team","fork":true,"url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka","forks_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/forks","keys_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/teams","hooks_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/hooks","issue_events_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/events","assignees_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/tags","blobs_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/languages","stargazers_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/stargazers","contributors_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/contributors","subscribers_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/subscribers","subscription_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/subscription","commits_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/merges","archive_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/downloads","issues_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/labels{/name}","releases_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/bbck/quickstart-confluent-kafka/deployments","created_at":"2017-08-01T18:00:38Z","updated_at":"2017-08-01T18:00:39Z","pushed_at":"2017-08-14T18:28:43Z","git_url":"git://github.com/bbck/quickstart-confluent-kafka.git","ssh_url":"git@github.com:bbck/quickstart-confluent-kafka.git","clone_url":"https://github.com/bbck/quickstart-confluent-kafka.git","svn_url":"https://github.com/bbck/quickstart-confluent-kafka","homepage":null,"size":187,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws-quickstart:develop","ref":"develop","sha":"10ab66882dee8bec2933c0923938ed10af44d545","user":{"login":"aws-quickstart","id":17076214,"avatar_url":"https://avatars2.githubusercontent.com/u/17076214?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-quickstart","html_url":"https://github.com/aws-quickstart","followers_url":"https://api.github.com/users/aws-quickstart/followers","following_url":"https://api.github.com/users/aws-quickstart/following{/other_user}","gists_url":"https://api.github.com/users/aws-quickstart/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-quickstart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-quickstart/subscriptions","organizations_url":"https://api.github.com/users/aws-quickstart/orgs","repos_url":"https://api.github.com/users/aws-quickstart/repos","events_url":"https://api.github.com/users/aws-quickstart/events{/privacy}","received_events_url":"https://api.github.com/users/aws-quickstart/received_events","type":"Organization","site_admin":false},"repo":{"id":80164424,"name":"quickstart-confluent-kafka","full_name":"aws-quickstart/quickstart-confluent-kafka","owner":{"login":"aws-quickstart","id":17076214,"avatar_url":"https://avatars2.githubusercontent.com/u/17076214?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-quickstart","html_url":"https://github.com/aws-quickstart","followers_url":"https://api.github.com/users/aws-quickstart/followers","following_url":"https://api.github.com/users/aws-quickstart/following{/other_user}","gists_url":"https://api.github.com/users/aws-quickstart/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-quickstart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-quickstart/subscriptions","organizations_url":"https://api.github.com/users/aws-quickstart/orgs","repos_url":"https://api.github.com/users/aws-quickstart/repos","events_url":"https://api.github.com/users/aws-quickstart/events{/privacy}","received_events_url":"https://api.github.com/users/aws-quickstart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws-quickstart/quickstart-confluent-kafka","description":"AWS Quick Start Team","fork":false,"url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka","forks_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/forks","keys_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/teams","hooks_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/hooks","issue_events_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/events","assignees_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/tags","blobs_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/languages","stargazers_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/stargazers","contributors_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/contributors","subscribers_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/subscribers","subscription_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/subscription","commits_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/merges","archive_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/downloads","issues_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/labels{/name}","releases_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/deployments","created_at":"2017-01-26T23:05:02Z","updated_at":"2017-08-03T16:53:18Z","pushed_at":"2017-08-14T18:28:45Z","git_url":"git://github.com/aws-quickstart/quickstart-confluent-kafka.git","ssh_url":"git@github.com:aws-quickstart/quickstart-confluent-kafka.git","clone_url":"https://github.com/aws-quickstart/quickstart-confluent-kafka.git","svn_url":"https://github.com/aws-quickstart/quickstart-confluent-kafka","homepage":null,"size":186,"stargazers_count":10,"watchers_count":10,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":9,"forks":9,"open_issues":9,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/38"},"html":{"href":"https://github.com/aws-quickstart/quickstart-confluent-kafka/pull/38"},"issue":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/issues/38"},"comments":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/aws-quickstart/quickstart-confluent-kafka/statuses/be5d5e8f90a3c58d668e1ede4ffeadae666aea98"}}}}
{"actor":{"display_login":"santiagocardenas"}}