{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/142269227","pull_request_review_id":66606445,"id":142269227,"diff_hunk":"@@ -146,19 +150,28 @@ func restartKubelet(f *framework.Framework) {\n \tkube := matches[0]\n \tframework.Logf(\"Get running kubelet with systemctl: %v, %v\", string(stdout), kube)\n \tstdout, err = exec.Command(\"sudo\", \"systemctl\", \"restart\", kube).CombinedOutput()\n-\tif err == nil {\n-\t\treturn\n+\tif err != nil {\n+\t\tframework.Failf(\"Failed to restart kubelet with systemctl: %v, %v\", err, stdout)\n \t}\n-\tframework.Failf(\"Failed to restart kubelet with systemctl: %v, %v\", err, stdout)\n+\tEventually(func() bool {\n+\t\tafterSocks, err := filepath.Glob(\"/var/lib/kubelet/device-plugins/nvidiaGPU*.sock\")","path":"test/e2e_node/gpu_device_plugin.go","position":null,"original_position":29,"commit_id":"3253b74e33705c4acf709b7c47b7ffea7adfa268","original_commit_id":"6a35373388d2e93de469d39f812f39f6ccca3f72","user":{"login":"jiayingz","id":29497748,"avatar_url":"https://avatars3.githubusercontent.com/u/29497748?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayingz","html_url":"https://github.com/jiayingz","followers_url":"https://api.github.com/users/jiayingz/followers","following_url":"https://api.github.com/users/jiayingz/following{/other_user}","gists_url":"https://api.github.com/users/jiayingz/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayingz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayingz/subscriptions","organizations_url":"https://api.github.com/users/jiayingz/orgs","repos_url":"https://api.github.com/users/jiayingz/repos","events_url":"https://api.github.com/users/jiayingz/events{/privacy}","received_events_url":"https://api.github.com/users/jiayingz/received_events","type":"User","site_admin":false},"body":"Just checking no. of GPUs is not enough because the capacity update may fall behind.","created_at":"2017-10-02T22:11:44Z","updated_at":"2017-10-02T22:17:02Z","html_url":"https://github.com/kubernetes/kubernetes/pull/53336#discussion_r142269227","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53336","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/142269227"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/53336#discussion_r142269227"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53336"}},"in_reply_to_id":142208102},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53336","id":144228396,"html_url":"https://github.com/kubernetes/kubernetes/pull/53336","diff_url":"https://github.com/kubernetes/kubernetes/pull/53336.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/53336.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/53336","number":53336,"state":"open","locked":false,"title":"Fixes test/e2e_node/gpu_device_plugin.go test failure.","user":{"login":"jiayingz","id":29497748,"avatar_url":"https://avatars3.githubusercontent.com/u/29497748?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayingz","html_url":"https://github.com/jiayingz","followers_url":"https://api.github.com/users/jiayingz/followers","following_url":"https://api.github.com/users/jiayingz/following{/other_user}","gists_url":"https://api.github.com/users/jiayingz/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayingz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayingz/subscriptions","organizations_url":"https://api.github.com/users/jiayingz/orgs","repos_url":"https://api.github.com/users/jiayingz/repos","events_url":"https://api.github.com/users/jiayingz/events{/privacy}","received_events_url":"https://api.github.com/users/jiayingz/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n","created_at":"2017-10-02T16:35:35Z","updated_at":"2017-10-02T22:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53cdee7b908f8f32c5020562b7acb7925f2a6fc6","assignee":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"assignees":[{"login":"feiskyer","id":676637,"avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},{"login":"mindprince","id":695290,"avatar_url":"https://avatars2.githubusercontent.com/u/695290?v=4","gravatar_id":"","url":"https://api.github.com/users/mindprince","html_url":"https://github.com/mindprince","followers_url":"https://api.github.com/users/mindprince/followers","following_url":"https://api.github.com/users/mindprince/following{/other_user}","gists_url":"https://api.github.com/users/mindprince/gists{/gist_id}","starred_url":"https://api.github.com/users/mindprince/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindprince/subscriptions","organizations_url":"https://api.github.com/users/mindprince/orgs","repos_url":"https://api.github.com/users/mindprince/repos","events_url":"https://api.github.com/users/mindprince/events{/privacy}","received_events_url":"https://api.github.com/users/mindprince/received_events","type":"User","site_admin":false},{"login":"tallclair","id":29742491,"avatar_url":"https://avatars1.githubusercontent.com/u/29742491?v=4","gravatar_id":"","url":"https://api.github.com/users/tallclair","html_url":"https://github.com/tallclair","followers_url":"https://api.github.com/users/tallclair/followers","following_url":"https://api.github.com/users/tallclair/following{/other_user}","gists_url":"https://api.github.com/users/tallclair/gists{/gist_id}","starred_url":"https://api.github.com/users/tallclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallclair/subscriptions","organizations_url":"https://api.github.com/users/tallclair/orgs","repos_url":"https://api.github.com/users/tallclair/repos","events_url":"https://api.github.com/users/tallclair/events{/privacy}","received_events_url":"https://api.github.com/users/tallclair/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53336/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53336/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/53336/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3253b74e33705c4acf709b7c47b7ffea7adfa268","head":{"label":"jiayingz:e2e-flaky","ref":"e2e-flaky","sha":"3253b74e33705c4acf709b7c47b7ffea7adfa268","user":{"login":"jiayingz","id":29497748,"avatar_url":"https://avatars3.githubusercontent.com/u/29497748?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayingz","html_url":"https://github.com/jiayingz","followers_url":"https://api.github.com/users/jiayingz/followers","following_url":"https://api.github.com/users/jiayingz/following{/other_user}","gists_url":"https://api.github.com/users/jiayingz/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayingz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayingz/subscriptions","organizations_url":"https://api.github.com/users/jiayingz/orgs","repos_url":"https://api.github.com/users/jiayingz/repos","events_url":"https://api.github.com/users/jiayingz/events{/privacy}","received_events_url":"https://api.github.com/users/jiayingz/received_events","type":"User","site_admin":false},"repo":{"id":94807444,"name":"kubernetes","full_name":"jiayingz/kubernetes","owner":{"login":"jiayingz","id":29497748,"avatar_url":"https://avatars3.githubusercontent.com/u/29497748?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayingz","html_url":"https://github.com/jiayingz","followers_url":"https://api.github.com/users/jiayingz/followers","following_url":"https://api.github.com/users/jiayingz/following{/other_user}","gists_url":"https://api.github.com/users/jiayingz/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayingz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayingz/subscriptions","organizations_url":"https://api.github.com/users/jiayingz/orgs","repos_url":"https://api.github.com/users/jiayingz/repos","events_url":"https://api.github.com/users/jiayingz/events{/privacy}","received_events_url":"https://api.github.com/users/jiayingz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiayingz/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/jiayingz/kubernetes","forks_url":"https://api.github.com/repos/jiayingz/kubernetes/forks","keys_url":"https://api.github.com/repos/jiayingz/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiayingz/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiayingz/kubernetes/teams","hooks_url":"https://api.github.com/repos/jiayingz/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jiayingz/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jiayingz/kubernetes/events","assignees_url":"https://api.github.com/repos/jiayingz/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jiayingz/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jiayingz/kubernetes/tags","blobs_url":"https://api.github.com/repos/jiayingz/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiayingz/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiayingz/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiayingz/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiayingz/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jiayingz/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jiayingz/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jiayingz/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jiayingz/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jiayingz/kubernetes/subscription","commits_url":"https://api.github.com/repos/jiayingz/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiayingz/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiayingz/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiayingz/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiayingz/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jiayingz/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiayingz/kubernetes/merges","archive_url":"https://api.github.com/repos/jiayingz/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiayingz/kubernetes/downloads","issues_url":"https://api.github.com/repos/jiayingz/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jiayingz/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jiayingz/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jiayingz/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiayingz/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jiayingz/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jiayingz/kubernetes/deployments","created_at":"2017-06-19T18:19:32Z","updated_at":"2017-06-19T18:20:12Z","pushed_at":"2017-10-02T22:16:01Z","git_url":"git://github.com/jiayingz/kubernetes.git","ssh_url":"git@github.com:jiayingz/kubernetes.git","clone_url":"https://github.com/jiayingz/kubernetes.git","svn_url":"https://github.com/jiayingz/kubernetes","homepage":"http://kubernetes.io","size":480327,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f0a061e361bccd7080e6adb0674b0c02582608e8","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-10-02T20:12:01Z","pushed_at":"2017-10-02T22:16:06Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":698816,"stargazers_count":27313,"watchers_count":27313,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9793,"mirror_url":null,"open_issues_count":5478,"forks":9793,"open_issues":5478,"watchers":27313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53336"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/53336"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/53336"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/53336/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53336/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53336/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3253b74e33705c4acf709b7c47b7ffea7adfa268"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jiayingz"}}