{"action":"created","comment":{"url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/comments/100278517","pull_request_review_id":20978842,"id":100278517,"diff_hunk":"@@ -0,0 +1,86 @@\n+<?php\n+/**\n+ * @license See the file LICENSE for copying permission\n+ */\n+\n+namespace ContainerInteropDoctrineTest;\n+\n+use Doctrine\\ORM\\Mapping\\Driver;\n+use OutOfBoundsException;\n+use ContainerInteropDoctrine\\DriverFactory;\n+use Interop\\Container\\ContainerInterface;\n+use PHPUnit_Framework_TestCase as TestCase;\n+\n+class DriverFactoryTest extends TestCase\n+{\n+    public function testMissingClassKeyWillReturnOutOfBoundException()\n+    {\n+        $container = $this->prophesize(ContainerInterface::class);\n+        $factory = new DriverFactory();\n+\n+        $this->setExpectedException(OutOfBoundsException::class, 'Missing \"class\" config key');\n+\n+        $factory($container->reveal());\n+    }\n+\n+    public function testItSupportsGlobalBasenameOptionOnFileDrivers()\n+    {\n+        $globalBasename = 'foobar';\n+\n+        $container = $this->prophesize(ContainerInterface::class);\n+        $container->has('config')->willReturn(true);\n+        $container->get('config')->willReturn([\n+            'doctrine' => [\n+                'driver' => [\n+                    'orm_default' => [\n+                        'class' => TestAsset\\StubFileDriver::class,\n+                        'global_basename' => $globalBasename\n+                    ],\n+                ],\n+            ],\n+        ]);\n+\n+        $factory = new DriverFactory();\n+\n+        $driver = $factory($container->reveal());\n+        static::assertSame($globalBasename, $driver->getGlobalBasename());","path":"test/DriverFactoryTest.php","position":46,"original_position":46,"commit_id":"16ea1331425799c6301c6537734b949aa6d02a1b","original_commit_id":"16ea1331425799c6301c6537734b949aa6d02a1b","user":{"login":"DASPRiD","id":233300,"avatar_url":"https://avatars.githubusercontent.com/u/233300?v=3","gravatar_id":"","url":"https://api.github.com/users/DASPRiD","html_url":"https://github.com/DASPRiD","followers_url":"https://api.github.com/users/DASPRiD/followers","following_url":"https://api.github.com/users/DASPRiD/following{/other_user}","gists_url":"https://api.github.com/users/DASPRiD/gists{/gist_id}","starred_url":"https://api.github.com/users/DASPRiD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DASPRiD/subscriptions","organizations_url":"https://api.github.com/users/DASPRiD/orgs","repos_url":"https://api.github.com/users/DASPRiD/repos","events_url":"https://api.github.com/users/DASPRiD/events{/privacy}","received_events_url":"https://api.github.com/users/DASPRiD/received_events","type":"User","site_admin":false},"body":"Please use local assertions.","created_at":"2017-02-09T10:45:41Z","updated_at":"2017-02-09T10:45:41Z","html_url":"https://github.com/DASPRiD/container-interop-doctrine/pull/17#discussion_r100278517","pull_request_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/comments/100278517"},"html":{"href":"https://github.com/DASPRiD/container-interop-doctrine/pull/17#discussion_r100278517"},"pull_request":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/17","id":103947730,"html_url":"https://github.com/DASPRiD/container-interop-doctrine/pull/17","diff_url":"https://github.com/DASPRiD/container-interop-doctrine/pull/17.diff","patch_url":"https://github.com/DASPRiD/container-interop-doctrine/pull/17.patch","issue_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/issues/17","number":17,"state":"open","locked":false,"title":"Add global basename support","user":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"body":"This PR add to `DriverFactory` the ability to use a `global_basename` key in the driver options, only relevant for `Doctrine\\Common\\Persistence\\Mapping\\Driver\\FileDriver` implementations.\r\n\r\nThis makes possible to correctly configure an instance of `Doctrine\\ORM\\Mapping\\Driver\\SimplifiedXmlDriver`, which [requires setting that property to work as intended](http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/xml-mapping.html#simplified-xml-driver).","created_at":"2017-01-31T14:36:26Z","updated_at":"2017-02-09T10:45:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a84c97b4898fe9f22dff9baf42672a3fafbdbe42","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/17/commits","review_comments_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/17/comments","review_comment_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/issues/17/comments","statuses_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/statuses/16ea1331425799c6301c6537734b949aa6d02a1b","head":{"label":"stefanotorresi:add-globalbasename-support","ref":"add-globalbasename-support","sha":"16ea1331425799c6301c6537734b949aa6d02a1b","user":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"repo":{"id":80526748,"name":"container-interop-doctrine","full_name":"stefanotorresi/container-interop-doctrine","owner":{"login":"stefanotorresi","id":2952427,"avatar_url":"https://avatars.githubusercontent.com/u/2952427?v=3","gravatar_id":"","url":"https://api.github.com/users/stefanotorresi","html_url":"https://github.com/stefanotorresi","followers_url":"https://api.github.com/users/stefanotorresi/followers","following_url":"https://api.github.com/users/stefanotorresi/following{/other_user}","gists_url":"https://api.github.com/users/stefanotorresi/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanotorresi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanotorresi/subscriptions","organizations_url":"https://api.github.com/users/stefanotorresi/orgs","repos_url":"https://api.github.com/users/stefanotorresi/repos","events_url":"https://api.github.com/users/stefanotorresi/events{/privacy}","received_events_url":"https://api.github.com/users/stefanotorresi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefanotorresi/container-interop-doctrine","description":"Doctrine factories for container-interop","fork":true,"url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine","forks_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/forks","keys_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/teams","hooks_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/hooks","issue_events_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/issues/events{/number}","events_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/events","assignees_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/assignees{/user}","branches_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/branches{/branch}","tags_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/tags","blobs_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/statuses/{sha}","languages_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/languages","stargazers_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/stargazers","contributors_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/contributors","subscribers_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/subscribers","subscription_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/subscription","commits_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/contents/{+path}","compare_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/merges","archive_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/downloads","issues_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/issues{/number}","pulls_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/pulls{/number}","milestones_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/milestones{/number}","notifications_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/labels{/name}","releases_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/releases{/id}","deployments_url":"https://api.github.com/repos/stefanotorresi/container-interop-doctrine/deployments","created_at":"2017-01-31T14:19:07Z","updated_at":"2017-01-31T14:19:10Z","pushed_at":"2017-02-01T15:42:37Z","git_url":"git://github.com/stefanotorresi/container-interop-doctrine.git","ssh_url":"git@github.com:stefanotorresi/container-interop-doctrine.git","clone_url":"https://github.com/stefanotorresi/container-interop-doctrine.git","svn_url":"https://github.com/stefanotorresi/container-interop-doctrine","homepage":"","size":47,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DASPRiD:master","ref":"master","sha":"05041506e35cbc4ddd89374ca5998c3544b14a52","user":{"login":"DASPRiD","id":233300,"avatar_url":"https://avatars.githubusercontent.com/u/233300?v=3","gravatar_id":"","url":"https://api.github.com/users/DASPRiD","html_url":"https://github.com/DASPRiD","followers_url":"https://api.github.com/users/DASPRiD/followers","following_url":"https://api.github.com/users/DASPRiD/following{/other_user}","gists_url":"https://api.github.com/users/DASPRiD/gists{/gist_id}","starred_url":"https://api.github.com/users/DASPRiD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DASPRiD/subscriptions","organizations_url":"https://api.github.com/users/DASPRiD/orgs","repos_url":"https://api.github.com/users/DASPRiD/repos","events_url":"https://api.github.com/users/DASPRiD/events{/privacy}","received_events_url":"https://api.github.com/users/DASPRiD/received_events","type":"User","site_admin":false},"repo":{"id":51779193,"name":"container-interop-doctrine","full_name":"DASPRiD/container-interop-doctrine","owner":{"login":"DASPRiD","id":233300,"avatar_url":"https://avatars.githubusercontent.com/u/233300?v=3","gravatar_id":"","url":"https://api.github.com/users/DASPRiD","html_url":"https://github.com/DASPRiD","followers_url":"https://api.github.com/users/DASPRiD/followers","following_url":"https://api.github.com/users/DASPRiD/following{/other_user}","gists_url":"https://api.github.com/users/DASPRiD/gists{/gist_id}","starred_url":"https://api.github.com/users/DASPRiD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DASPRiD/subscriptions","organizations_url":"https://api.github.com/users/DASPRiD/orgs","repos_url":"https://api.github.com/users/DASPRiD/repos","events_url":"https://api.github.com/users/DASPRiD/events{/privacy}","received_events_url":"https://api.github.com/users/DASPRiD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DASPRiD/container-interop-doctrine","description":"Doctrine factories for container-interop","fork":false,"url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine","forks_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/forks","keys_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/teams","hooks_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/hooks","issue_events_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/issues/events{/number}","events_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/events","assignees_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/assignees{/user}","branches_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/branches{/branch}","tags_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/tags","blobs_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/git/refs{/sha}","trees_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/statuses/{sha}","languages_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/languages","stargazers_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/stargazers","contributors_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/contributors","subscribers_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/subscribers","subscription_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/subscription","commits_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/commits{/sha}","git_commits_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/git/commits{/sha}","comments_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/comments{/number}","issue_comment_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/issues/comments{/number}","contents_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/contents/{+path}","compare_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/merges","archive_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/downloads","issues_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/issues{/number}","pulls_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls{/number}","milestones_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/milestones{/number}","notifications_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/labels{/name}","releases_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/releases{/id}","deployments_url":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/deployments","created_at":"2016-02-15T19:19:46Z","updated_at":"2017-02-04T22:40:37Z","pushed_at":"2017-02-01T15:42:39Z","git_url":"git://github.com/DASPRiD/container-interop-doctrine.git","ssh_url":"git@github.com:DASPRiD/container-interop-doctrine.git","clone_url":"https://github.com/DASPRiD/container-interop-doctrine.git","svn_url":"https://github.com/DASPRiD/container-interop-doctrine","homepage":"","size":38,"stargazers_count":50,"watchers_count":50,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":5,"forks":13,"open_issues":5,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/17"},"html":{"href":"https://github.com/DASPRiD/container-interop-doctrine/pull/17"},"issue":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/issues/17"},"comments":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/DASPRiD/container-interop-doctrine/statuses/16ea1331425799c6301c6537734b949aa6d02a1b"}}}}
{"actor":{"display_login":"DASPRiD"}}