{"action":"created","comment":{"url":"https://api.github.com/repos/kontena/kontena/pulls/comments/120046344","pull_request_review_id":41975562,"id":120046344,"diff_hunk":"@@ -15,43 +15,59 @@ def initialize(container)\n       @uuid = SecureRandom.uuid\n       @container = container\n       @read_pipe, @write_pipe = IO.pipe\n+      @last_input = Time.now.to_i\n       info \"initialized (session #{@uuid})\"\n+\n+      every(60) { self.check_activity }\n     end\n \n-    # @param [String] input\n-    def input(input)\n-      @write_pipe.write(input)\n+    def check_activity\n+      if @last_input < (Time.now.to_i - 60*60)","path":"agent/lib/kontena/actors/container_exec.rb","position":14,"original_position":14,"commit_id":"031e705adf18893f892c6b322f06001a32e4ef9b","original_commit_id":"031e705adf18893f892c6b322f06001a32e4ef9b","user":{"login":"jnummelin","id":3205505,"avatar_url":"https://avatars3.githubusercontent.com/u/3205505?v=3","gravatar_id":"","url":"https://api.github.com/users/jnummelin","html_url":"https://github.com/jnummelin","followers_url":"https://api.github.com/users/jnummelin/followers","following_url":"https://api.github.com/users/jnummelin/following{/other_user}","gists_url":"https://api.github.com/users/jnummelin/gists{/gist_id}","starred_url":"https://api.github.com/users/jnummelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnummelin/subscriptions","organizations_url":"https://api.github.com/users/jnummelin/orgs","repos_url":"https://api.github.com/users/jnummelin/repos","events_url":"https://api.github.com/users/jnummelin/events{/privacy}","received_events_url":"https://api.github.com/users/jnummelin/received_events","type":"User","site_admin":false},"body":"The possible ping-pong can be implemented in a later PR as an enhancement.","created_at":"2017-06-05T06:04:34Z","updated_at":"2017-06-05T06:06:19Z","html_url":"https://github.com/kontena/kontena/pull/2412#discussion_r120046344","pull_request_url":"https://api.github.com/repos/kontena/kontena/pulls/2412","_links":{"self":{"href":"https://api.github.com/repos/kontena/kontena/pulls/comments/120046344"},"html":{"href":"https://github.com/kontena/kontena/pull/2412#discussion_r120046344"},"pull_request":{"href":"https://api.github.com/repos/kontena/kontena/pulls/2412"}}},"pull_request":{"url":"https://api.github.com/repos/kontena/kontena/pulls/2412","id":123851385,"html_url":"https://github.com/kontena/kontena/pull/2412","diff_url":"https://github.com/kontena/kontena/pull/2412.diff","patch_url":"https://github.com/kontena/kontena/pull/2412.patch","issue_url":"https://api.github.com/repos/kontena/kontena/issues/2412","number":2412,"state":"open","locked":false,"title":"Add tty as separation option in container/service exec","user":{"login":"jakolehm","id":1446224,"avatar_url":"https://avatars3.githubusercontent.com/u/1446224?v=3","gravatar_id":"","url":"https://api.github.com/users/jakolehm","html_url":"https://github.com/jakolehm","followers_url":"https://api.github.com/users/jakolehm/followers","following_url":"https://api.github.com/users/jakolehm/following{/other_user}","gists_url":"https://api.github.com/users/jakolehm/gists{/gist_id}","starred_url":"https://api.github.com/users/jakolehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakolehm/subscriptions","organizations_url":"https://api.github.com/users/jakolehm/orgs","repos_url":"https://api.github.com/users/jakolehm/repos","events_url":"https://api.github.com/users/jakolehm/events{/privacy}","received_events_url":"https://api.github.com/users/jakolehm/received_events","type":"User","site_admin":false},"body":"This has one breaking change, now `-i` option means `--interactive` in `service exec` (to match docker etc tools behaviour).","created_at":"2017-06-03T18:19:50Z","updated_at":"2017-06-05T06:06:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0eb5c56f7ff0de09f3de8e331856ed6100e55e32","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kontena/kontena/milestones/68","html_url":"https://github.com/kontena/kontena/milestone/68","labels_url":"https://api.github.com/repos/kontena/kontena/milestones/68/labels","id":2412966,"number":68,"title":"1.3.0","description":"","creator":{"login":"jakolehm","id":1446224,"avatar_url":"https://avatars3.githubusercontent.com/u/1446224?v=3","gravatar_id":"","url":"https://api.github.com/users/jakolehm","html_url":"https://github.com/jakolehm","followers_url":"https://api.github.com/users/jakolehm/followers","following_url":"https://api.github.com/users/jakolehm/following{/other_user}","gists_url":"https://api.github.com/users/jakolehm/gists{/gist_id}","starred_url":"https://api.github.com/users/jakolehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakolehm/subscriptions","organizations_url":"https://api.github.com/users/jakolehm/orgs","repos_url":"https://api.github.com/users/jakolehm/repos","events_url":"https://api.github.com/users/jakolehm/events{/privacy}","received_events_url":"https://api.github.com/users/jakolehm/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":71,"state":"open","created_at":"2017-03-27T09:11:26Z","updated_at":"2017-06-04T20:26:54Z","due_on":"2017-05-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kontena/kontena/pulls/2412/commits","review_comments_url":"https://api.github.com/repos/kontena/kontena/pulls/2412/comments","review_comment_url":"https://api.github.com/repos/kontena/kontena/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kontena/kontena/issues/2412/comments","statuses_url":"https://api.github.com/repos/kontena/kontena/statuses/031e705adf18893f892c6b322f06001a32e4ef9b","head":{"label":"kontena:fix/split-interactive-and-tty-options","ref":"fix/split-interactive-and-tty-options","sha":"031e705adf18893f892c6b322f06001a32e4ef9b","user":{"login":"kontena","id":10419574,"avatar_url":"https://avatars1.githubusercontent.com/u/10419574?v=3","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"repo":{"id":32689932,"name":"kontena","full_name":"kontena/kontena","owner":{"login":"kontena","id":10419574,"avatar_url":"https://avatars1.githubusercontent.com/u/10419574?v=3","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kontena/kontena","description":"The developer friendly container and micro services platform. Works on any cloud, easy to setup, simple to use.","fork":false,"url":"https://api.github.com/repos/kontena/kontena","forks_url":"https://api.github.com/repos/kontena/kontena/forks","keys_url":"https://api.github.com/repos/kontena/kontena/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontena/kontena/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontena/kontena/teams","hooks_url":"https://api.github.com/repos/kontena/kontena/hooks","issue_events_url":"https://api.github.com/repos/kontena/kontena/issues/events{/number}","events_url":"https://api.github.com/repos/kontena/kontena/events","assignees_url":"https://api.github.com/repos/kontena/kontena/assignees{/user}","branches_url":"https://api.github.com/repos/kontena/kontena/branches{/branch}","tags_url":"https://api.github.com/repos/kontena/kontena/tags","blobs_url":"https://api.github.com/repos/kontena/kontena/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontena/kontena/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontena/kontena/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontena/kontena/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontena/kontena/statuses/{sha}","languages_url":"https://api.github.com/repos/kontena/kontena/languages","stargazers_url":"https://api.github.com/repos/kontena/kontena/stargazers","contributors_url":"https://api.github.com/repos/kontena/kontena/contributors","subscribers_url":"https://api.github.com/repos/kontena/kontena/subscribers","subscription_url":"https://api.github.com/repos/kontena/kontena/subscription","commits_url":"https://api.github.com/repos/kontena/kontena/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontena/kontena/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontena/kontena/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontena/kontena/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontena/kontena/contents/{+path}","compare_url":"https://api.github.com/repos/kontena/kontena/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontena/kontena/merges","archive_url":"https://api.github.com/repos/kontena/kontena/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontena/kontena/downloads","issues_url":"https://api.github.com/repos/kontena/kontena/issues{/number}","pulls_url":"https://api.github.com/repos/kontena/kontena/pulls{/number}","milestones_url":"https://api.github.com/repos/kontena/kontena/milestones{/number}","notifications_url":"https://api.github.com/repos/kontena/kontena/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontena/kontena/labels{/name}","releases_url":"https://api.github.com/repos/kontena/kontena/releases{/id}","deployments_url":"https://api.github.com/repos/kontena/kontena/deployments","created_at":"2015-03-22T18:52:32Z","updated_at":"2017-06-03T14:11:00Z","pushed_at":"2017-06-04T22:45:23Z","git_url":"git://github.com/kontena/kontena.git","ssh_url":"git@github.com:kontena/kontena.git","clone_url":"https://github.com/kontena/kontena.git","svn_url":"https://github.com/kontena/kontena","homepage":"http://www.kontena.io","size":6750,"stargazers_count":1124,"watchers_count":1124,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":308,"forks":101,"open_issues":308,"watchers":1124,"default_branch":"master"}},"base":{"label":"kontena:master","ref":"master","sha":"51ed961292a21d486431898853424b3fab39646d","user":{"login":"kontena","id":10419574,"avatar_url":"https://avatars1.githubusercontent.com/u/10419574?v=3","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"repo":{"id":32689932,"name":"kontena","full_name":"kontena/kontena","owner":{"login":"kontena","id":10419574,"avatar_url":"https://avatars1.githubusercontent.com/u/10419574?v=3","gravatar_id":"","url":"https://api.github.com/users/kontena","html_url":"https://github.com/kontena","followers_url":"https://api.github.com/users/kontena/followers","following_url":"https://api.github.com/users/kontena/following{/other_user}","gists_url":"https://api.github.com/users/kontena/gists{/gist_id}","starred_url":"https://api.github.com/users/kontena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kontena/subscriptions","organizations_url":"https://api.github.com/users/kontena/orgs","repos_url":"https://api.github.com/users/kontena/repos","events_url":"https://api.github.com/users/kontena/events{/privacy}","received_events_url":"https://api.github.com/users/kontena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kontena/kontena","description":"The developer friendly container and micro services platform. Works on any cloud, easy to setup, simple to use.","fork":false,"url":"https://api.github.com/repos/kontena/kontena","forks_url":"https://api.github.com/repos/kontena/kontena/forks","keys_url":"https://api.github.com/repos/kontena/kontena/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kontena/kontena/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kontena/kontena/teams","hooks_url":"https://api.github.com/repos/kontena/kontena/hooks","issue_events_url":"https://api.github.com/repos/kontena/kontena/issues/events{/number}","events_url":"https://api.github.com/repos/kontena/kontena/events","assignees_url":"https://api.github.com/repos/kontena/kontena/assignees{/user}","branches_url":"https://api.github.com/repos/kontena/kontena/branches{/branch}","tags_url":"https://api.github.com/repos/kontena/kontena/tags","blobs_url":"https://api.github.com/repos/kontena/kontena/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kontena/kontena/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kontena/kontena/git/refs{/sha}","trees_url":"https://api.github.com/repos/kontena/kontena/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kontena/kontena/statuses/{sha}","languages_url":"https://api.github.com/repos/kontena/kontena/languages","stargazers_url":"https://api.github.com/repos/kontena/kontena/stargazers","contributors_url":"https://api.github.com/repos/kontena/kontena/contributors","subscribers_url":"https://api.github.com/repos/kontena/kontena/subscribers","subscription_url":"https://api.github.com/repos/kontena/kontena/subscription","commits_url":"https://api.github.com/repos/kontena/kontena/commits{/sha}","git_commits_url":"https://api.github.com/repos/kontena/kontena/git/commits{/sha}","comments_url":"https://api.github.com/repos/kontena/kontena/comments{/number}","issue_comment_url":"https://api.github.com/repos/kontena/kontena/issues/comments{/number}","contents_url":"https://api.github.com/repos/kontena/kontena/contents/{+path}","compare_url":"https://api.github.com/repos/kontena/kontena/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kontena/kontena/merges","archive_url":"https://api.github.com/repos/kontena/kontena/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kontena/kontena/downloads","issues_url":"https://api.github.com/repos/kontena/kontena/issues{/number}","pulls_url":"https://api.github.com/repos/kontena/kontena/pulls{/number}","milestones_url":"https://api.github.com/repos/kontena/kontena/milestones{/number}","notifications_url":"https://api.github.com/repos/kontena/kontena/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kontena/kontena/labels{/name}","releases_url":"https://api.github.com/repos/kontena/kontena/releases{/id}","deployments_url":"https://api.github.com/repos/kontena/kontena/deployments","created_at":"2015-03-22T18:52:32Z","updated_at":"2017-06-03T14:11:00Z","pushed_at":"2017-06-04T22:45:23Z","git_url":"git://github.com/kontena/kontena.git","ssh_url":"git@github.com:kontena/kontena.git","clone_url":"https://github.com/kontena/kontena.git","svn_url":"https://github.com/kontena/kontena","homepage":"http://www.kontena.io","size":6750,"stargazers_count":1124,"watchers_count":1124,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":308,"forks":101,"open_issues":308,"watchers":1124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kontena/kontena/pulls/2412"},"html":{"href":"https://github.com/kontena/kontena/pull/2412"},"issue":{"href":"https://api.github.com/repos/kontena/kontena/issues/2412"},"comments":{"href":"https://api.github.com/repos/kontena/kontena/issues/2412/comments"},"review_comments":{"href":"https://api.github.com/repos/kontena/kontena/pulls/2412/comments"},"review_comment":{"href":"https://api.github.com/repos/kontena/kontena/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kontena/kontena/pulls/2412/commits"},"statuses":{"href":"https://api.github.com/repos/kontena/kontena/statuses/031e705adf18893f892c6b322f06001a32e4ef9b"}}}}
{"actor":{"display_login":"jnummelin"}}