{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/omr/issues/1205","repository_url":"https://api.github.com/repos/eclipse/omr","labels_url":"https://api.github.com/repos/eclipse/omr/issues/1205/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/1205/comments","events_url":"https://api.github.com/repos/eclipse/omr/issues/1205/events","html_url":"https://github.com/eclipse/omr/pull/1205","id":232990017,"number":1205,"title":"Fix iu2l not being evaluated on z systems","user":{"login":"NigelYiboYu","id":22299200,"avatar_url":"https://avatars1.githubusercontent.com/u/22299200?v=3","gravatar_id":"","url":"https://api.github.com/users/NigelYiboYu","html_url":"https://github.com/NigelYiboYu","followers_url":"https://api.github.com/users/NigelYiboYu/followers","following_url":"https://api.github.com/users/NigelYiboYu/following{/other_user}","gists_url":"https://api.github.com/users/NigelYiboYu/gists{/gist_id}","starred_url":"https://api.github.com/users/NigelYiboYu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NigelYiboYu/subscriptions","organizations_url":"https://api.github.com/users/NigelYiboYu/orgs","repos_url":"https://api.github.com/users/NigelYiboYu/repos","events_url":"https://api.github.com/users/NigelYiboYu/events{/privacy}","received_events_url":"https://api.github.com/users/NigelYiboYu/received_events","type":"User","site_admin":false},"labels":[{"id":463261830,"url":"https://api.github.com/repos/eclipse/omr/labels/compiler","name":"compiler","color":"00d73d","default":false}],"state":"open","locked":false,"assignee":{"login":"vijaysun-omr","id":22303775,"avatar_url":"https://avatars3.githubusercontent.com/u/22303775?v=3","gravatar_id":"","url":"https://api.github.com/users/vijaysun-omr","html_url":"https://github.com/vijaysun-omr","followers_url":"https://api.github.com/users/vijaysun-omr/followers","following_url":"https://api.github.com/users/vijaysun-omr/following{/other_user}","gists_url":"https://api.github.com/users/vijaysun-omr/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaysun-omr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaysun-omr/subscriptions","organizations_url":"https://api.github.com/users/vijaysun-omr/orgs","repos_url":"https://api.github.com/users/vijaysun-omr/repos","events_url":"https://api.github.com/users/vijaysun-omr/events{/privacy}","received_events_url":"https://api.github.com/users/vijaysun-omr/received_events","type":"User","site_admin":false},"assignees":[{"login":"vijaysun-omr","id":22303775,"avatar_url":"https://avatars3.githubusercontent.com/u/22303775?v=3","gravatar_id":"","url":"https://api.github.com/users/vijaysun-omr","html_url":"https://github.com/vijaysun-omr","followers_url":"https://api.github.com/users/vijaysun-omr/followers","following_url":"https://api.github.com/users/vijaysun-omr/following{/other_user}","gists_url":"https://api.github.com/users/vijaysun-omr/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaysun-omr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaysun-omr/subscriptions","organizations_url":"https://api.github.com/users/vijaysun-omr/orgs","repos_url":"https://api.github.com/users/vijaysun-omr/repos","events_url":"https://api.github.com/users/vijaysun-omr/events{/privacy}","received_events_url":"https://api.github.com/users/vijaysun-omr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-06-01T19:46:36Z","updated_at":"2017-06-02T13:49:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/1205","html_url":"https://github.com/eclipse/omr/pull/1205","diff_url":"https://github.com/eclipse/omr/pull/1205.diff","patch_url":"https://github.com/eclipse/omr/pull/1205.patch"},"body":"iu2l was not evaluated and resulted in incorrect array indexing in\r\nBigInteger Multiplication operations.\r\n\r\nThis is fixed by calling generic load helper if the input is unsigned; and\r\nwe skip the node evaluations only if the nodes are signed and already\r\nsign exnended.\r\n\r\nSigned-off-by: Nigel Yu <yunigel@ca.ibm.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/omr/issues/comments/305792406","html_url":"https://github.com/eclipse/omr/pull/1205#issuecomment-305792406","issue_url":"https://api.github.com/repos/eclipse/omr/issues/1205","id":305792406,"user":{"login":"NigelYiboYu","id":22299200,"avatar_url":"https://avatars1.githubusercontent.com/u/22299200?v=3","gravatar_id":"","url":"https://api.github.com/users/NigelYiboYu","html_url":"https://github.com/NigelYiboYu","followers_url":"https://api.github.com/users/NigelYiboYu/followers","following_url":"https://api.github.com/users/NigelYiboYu/following{/other_user}","gists_url":"https://api.github.com/users/NigelYiboYu/gists{/gist_id}","starred_url":"https://api.github.com/users/NigelYiboYu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NigelYiboYu/subscriptions","organizations_url":"https://api.github.com/users/NigelYiboYu/orgs","repos_url":"https://api.github.com/users/NigelYiboYu/repos","events_url":"https://api.github.com/users/NigelYiboYu/events{/privacy}","received_events_url":"https://api.github.com/users/NigelYiboYu/received_events","type":"User","site_admin":false},"created_at":"2017-06-02T13:49:00Z","updated_at":"2017-06-02T13:49:00Z","body":"Added the following comment to this commit:\r\n```\r\n A load (for proper type conversion) is required if the node is unsigned, not sign extended and\r\n not marked as unneeded conversion.\r\n\r\n For example, codegen can encounter the following tree:\r\n\r\n n4188n   (  0)  iRegStore GPR6  (Unsigned NeedsSignExt privatizedInlinerArg )\r\n n4109n   (  3)    l2i\r\n n19339n  (  1)      ==>lRegLoad (in GPR_3616) (highWordZero X>=0 cannotOverflow SeenRealReference )\r\n  .....\r\n n4182n   (  0)      iu2l (in GPR_3616) (highWordZero X>=0 )\r\n n4109n   (  0)        ==>l2i (in GPR_3616)\r\n\r\n In this case, a load is needed to zero the high half of the long to corretly convert iu to l.\r\n```"}}
{"actor":{"display_login":"NigelYiboYu"}}