{"action":"created","issue":{"url":"https://api.github.com/repos/nim-lang/Nim/issues/5614","repository_url":"https://api.github.com/repos/nim-lang/Nim","labels_url":"https://api.github.com/repos/nim-lang/Nim/issues/5614/labels{/name}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/5614/comments","events_url":"https://api.github.com/repos/nim-lang/Nim/issues/5614/events","html_url":"https://github.com/nim-lang/Nim/pull/5614","id":217083794,"number":5614,"title":"Times: JS: Remove implicit UTC convesion.","user":{"login":"moigagoo","id":1045340,"avatar_url":"https://avatars3.githubusercontent.com/u/1045340?v=3","gravatar_id":"","url":"https://api.github.com/users/moigagoo","html_url":"https://github.com/moigagoo","followers_url":"https://api.github.com/users/moigagoo/followers","following_url":"https://api.github.com/users/moigagoo/following{/other_user}","gists_url":"https://api.github.com/users/moigagoo/gists{/gist_id}","starred_url":"https://api.github.com/users/moigagoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moigagoo/subscriptions","organizations_url":"https://api.github.com/users/moigagoo/orgs","repos_url":"https://api.github.com/users/moigagoo/repos","events_url":"https://api.github.com/users/moigagoo/events{/privacy}","received_events_url":"https://api.github.com/users/moigagoo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-03-26T19:52:02Z","updated_at":"2017-03-27T17:05:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/5614","html_url":"https://github.com/nim-lang/Nim/pull/5614","diff_url":"https://github.com/nim-lang/Nim/pull/5614.diff","patch_url":"https://github.com/nim-lang/Nim/pull/5614.patch"},"body":"The conversion would produce incorrect timestamps during parsing.\nSee https://forum.nim-lang.org/t/2876, point 2."},"comment":{"url":"https://api.github.com/repos/nim-lang/Nim/issues/comments/289518024","html_url":"https://github.com/nim-lang/Nim/pull/5614#issuecomment-289518024","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/5614","id":289518024,"user":{"login":"moigagoo","id":1045340,"avatar_url":"https://avatars3.githubusercontent.com/u/1045340?v=3","gravatar_id":"","url":"https://api.github.com/users/moigagoo","html_url":"https://github.com/moigagoo","followers_url":"https://api.github.com/users/moigagoo/followers","following_url":"https://api.github.com/users/moigagoo/following{/other_user}","gists_url":"https://api.github.com/users/moigagoo/gists{/gist_id}","starred_url":"https://api.github.com/users/moigagoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moigagoo/subscriptions","organizations_url":"https://api.github.com/users/moigagoo/orgs","repos_url":"https://api.github.com/users/moigagoo/repos","events_url":"https://api.github.com/users/moigagoo/events{/privacy}","received_events_url":"https://api.github.com/users/moigagoo/received_events","type":"User","site_admin":false},"created_at":"2017-03-27T17:05:38Z","updated_at":"2017-03-27T17:05:38Z","body":"OK, the previous examples work like they should, but here's the actual tests that passes when it should not:\r\n\r\n```nim\r\n# test times module with JS backend\r\ndiscard \"\"\"\r\n  action: run\r\n\"\"\"\r\n\r\nimport times\r\n\r\n# $ date --date='@2147483647'\r\n# Tue 19 Jan 03:14:07 GMT 2038\r\n\r\nblock yeardayTest:\r\n  # check\r\n\r\n  doAssert fromSeconds(2147483647).getGMTime().yearday == 0\r\n```\r\n\r\nThis one fails as it should:\r\n\r\n```nim\r\ndiscard \"\"\"\r\n  action: run\r\n\"\"\"\r\n\r\nimport times\r\n\r\n# $ date --date='@2147483647'\r\n# Tue 19 Jan 03:14:07 GMT 2038\r\n\r\nblock yeardayTest:\r\n  # check\r\n\r\n  doAssert fromSeconds(2147483647).getGMTime().yearday == 0\r\n```\r\n"}}
{"actor":{"display_login":"moigagoo"}}