{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/120681972","pull_request_review_id":42665280,"id":120681972,"diff_hunk":"@@ -85,13 +85,240 @@ namespace ADDON\n   typedef std::map<std::string, std::string> InfoMap;\n   typedef std::map<std::string, std::string> ArtMap;\n \n+  class CAddonBuilder;\n+\n   class CAddonInfo\n   {\n   public:\n     CAddonInfo();\n     CAddonInfo(std::string id, TYPE type);\n \n     /*!\n+     * @brief To ask generated class is usable and all needed parts are set.\n+     *\n+     * @return True is OK and usable, otherwise false.\n+     *\n+     * @note This function is only be related to constructor's who read the\n+     * addon xml part.\n+     */\n+    bool IsUsable() const { return m_usable; }\n+\n+    /*!\n+     * @brief Parts used from ADDON::CAddonDatabase\n+     */\n+    //@{\n+    void SetInstallDate(CDateTime installDate) { m_installDate = installDate; }\n+    void SetLastUpdated(CDateTime lastUpdated) { m_lastUpdated = lastUpdated; }\n+    void SetLastUsed(CDateTime lastUsed) { m_lastUsed = lastUsed; }\n+    void SetOrigin(std::string origin) { m_origin = std::move(origin); }\n+    //@}","path":"xbmc/addons/AddonInfo.h","position":30,"original_position":30,"commit_id":"407196a9c274f3bec9e17b111619903852d60fe3","original_commit_id":"407196a9c274f3bec9e17b111619903852d60fe3","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars0.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"body":"Also a part who becomes in future used from CAddonDatabase. Can remove it and add later.","created_at":"2017-06-07T16:47:44Z","updated_at":"2017-06-07T16:47:44Z","html_url":"https://github.com/xbmc/xbmc/pull/12260#discussion_r120681972","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/12260","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/120681972"},"html":{"href":"https://github.com/xbmc/xbmc/pull/12260#discussion_r120681972"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/12260"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/12260","id":124378957,"html_url":"https://github.com/xbmc/xbmc/pull/12260","diff_url":"https://github.com/xbmc/xbmc/pull/12260.diff","patch_url":"https://github.com/xbmc/xbmc/pull/12260.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/12260","number":12260,"state":"open","locked":false,"title":"[addons] add next step on CAddonInfo to become independent","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars0.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!--- Describe your change in detail -->\r\nThis change all values on CAddonInfo to private and access\r\nthem over functions.\r\n\r\nMain reason for them is to make the class more safe for next changes\r\nwhere CAddonInfo is no longer in CAddon, but globally as replacement\r\nfor cpluff.\r\n\r\nSet of this value becomes in future mainly done from the class constructor\r\nand no more by external parts.\r\n\r\n<!--- Provide a general summary of your change in the Title above -->\r\n\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your change -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [x] All new and existing tests passed\r\n","created_at":"2017-06-07T09:49:05Z","updated_at":"2017-06-07T16:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bde230d89972e30474b87c223f4b1358d3b5d89c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Montellese","id":75864,"avatar_url":"https://avatars2.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},{"login":"garbear","id":531482,"avatar_url":"https://avatars1.githubusercontent.com/u/531482?v=3","gravatar_id":"","url":"https://api.github.com/users/garbear","html_url":"https://github.com/garbear","followers_url":"https://api.github.com/users/garbear/followers","following_url":"https://api.github.com/users/garbear/following{/other_user}","gists_url":"https://api.github.com/users/garbear/gists{/gist_id}","starred_url":"https://api.github.com/users/garbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbear/subscriptions","organizations_url":"https://api.github.com/users/garbear/orgs","repos_url":"https://api.github.com/users/garbear/repos","events_url":"https://api.github.com/users/garbear/events{/privacy}","received_events_url":"https://api.github.com/users/garbear/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/95","html_url":"https://github.com/xbmc/xbmc/milestone/95","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/95/labels","id":2166828,"number":95,"title":"L 18.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars2.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":817,"state":"open","created_at":"2016-11-30T16:58:49Z","updated_at":"2017-06-07T14:08:05Z","due_on":"2017-07-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/12260/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/12260/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/12260/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/407196a9c274f3bec9e17b111619903852d60fe3","head":{"label":"AlwinEsch:add-addon-info","ref":"add-addon-info","sha":"407196a9c274f3bec9e17b111619903852d60fe3","user":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars0.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"repo":{"id":17647639,"name":"kodi","full_name":"AlwinEsch/kodi","owner":{"login":"AlwinEsch","id":6879739,"avatar_url":"https://avatars0.githubusercontent.com/u/6879739?v=3","gravatar_id":"","url":"https://api.github.com/users/AlwinEsch","html_url":"https://github.com/AlwinEsch","followers_url":"https://api.github.com/users/AlwinEsch/followers","following_url":"https://api.github.com/users/AlwinEsch/following{/other_user}","gists_url":"https://api.github.com/users/AlwinEsch/gists{/gist_id}","starred_url":"https://api.github.com/users/AlwinEsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlwinEsch/subscriptions","organizations_url":"https://api.github.com/users/AlwinEsch/orgs","repos_url":"https://api.github.com/users/AlwinEsch/repos","events_url":"https://api.github.com/users/AlwinEsch/events{/privacy}","received_events_url":"https://api.github.com/users/AlwinEsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlwinEsch/kodi","description":"Fork of Kodi Main Repository","fork":true,"url":"https://api.github.com/repos/AlwinEsch/kodi","forks_url":"https://api.github.com/repos/AlwinEsch/kodi/forks","keys_url":"https://api.github.com/repos/AlwinEsch/kodi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlwinEsch/kodi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlwinEsch/kodi/teams","hooks_url":"https://api.github.com/repos/AlwinEsch/kodi/hooks","issue_events_url":"https://api.github.com/repos/AlwinEsch/kodi/issues/events{/number}","events_url":"https://api.github.com/repos/AlwinEsch/kodi/events","assignees_url":"https://api.github.com/repos/AlwinEsch/kodi/assignees{/user}","branches_url":"https://api.github.com/repos/AlwinEsch/kodi/branches{/branch}","tags_url":"https://api.github.com/repos/AlwinEsch/kodi/tags","blobs_url":"https://api.github.com/repos/AlwinEsch/kodi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlwinEsch/kodi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlwinEsch/kodi/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlwinEsch/kodi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlwinEsch/kodi/statuses/{sha}","languages_url":"https://api.github.com/repos/AlwinEsch/kodi/languages","stargazers_url":"https://api.github.com/repos/AlwinEsch/kodi/stargazers","contributors_url":"https://api.github.com/repos/AlwinEsch/kodi/contributors","subscribers_url":"https://api.github.com/repos/AlwinEsch/kodi/subscribers","subscription_url":"https://api.github.com/repos/AlwinEsch/kodi/subscription","commits_url":"https://api.github.com/repos/AlwinEsch/kodi/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlwinEsch/kodi/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlwinEsch/kodi/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlwinEsch/kodi/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlwinEsch/kodi/contents/{+path}","compare_url":"https://api.github.com/repos/AlwinEsch/kodi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlwinEsch/kodi/merges","archive_url":"https://api.github.com/repos/AlwinEsch/kodi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlwinEsch/kodi/downloads","issues_url":"https://api.github.com/repos/AlwinEsch/kodi/issues{/number}","pulls_url":"https://api.github.com/repos/AlwinEsch/kodi/pulls{/number}","milestones_url":"https://api.github.com/repos/AlwinEsch/kodi/milestones{/number}","notifications_url":"https://api.github.com/repos/AlwinEsch/kodi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlwinEsch/kodi/labels{/name}","releases_url":"https://api.github.com/repos/AlwinEsch/kodi/releases{/id}","deployments_url":"https://api.github.com/repos/AlwinEsch/kodi/deployments","created_at":"2014-03-11T22:34:10Z","updated_at":"2017-05-10T00:36:19Z","pushed_at":"2017-06-07T11:41:27Z","git_url":"git://github.com/AlwinEsch/kodi.git","ssh_url":"git@github.com:AlwinEsch/kodi.git","clone_url":"https://github.com/AlwinEsch/kodi.git","svn_url":"https://github.com/AlwinEsch/kodi","homepage":"http://kodi.tv","size":593892,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"6925568547456c87d40aae0c58e4124c108fb5fb","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars1.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars1.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2017-06-07T16:37:23Z","pushed_at":"2017-06-07T16:30:40Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1418816,"stargazers_count":6022,"watchers_count":6022,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4174,"mirror_url":null,"open_issues_count":168,"forks":4174,"open_issues":168,"watchers":6022,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/12260"},"html":{"href":"https://github.com/xbmc/xbmc/pull/12260"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/12260"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/12260/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/12260/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/12260/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/407196a9c274f3bec9e17b111619903852d60fe3"}}}}
{"actor":{"display_login":"AlwinEsch"}}