{"action":"created","comment":{"url":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/comments/147809737","pull_request_review_id":72958318,"id":147809737,"diff_hunk":"@@ -142,7 +164,7 @@ int main() {\n       // Check if path is within web_root_path\n       if(distance(web_root_path.begin(), web_root_path.end()) > distance(path.begin(), path.end()) ||\n          !equal(web_root_path.begin(), web_root_path.end(), path.begin()))\n-        throw invalid_argument(\"path must be within root path\");\n+        throw invalid_argument(\"Path must be within root path\");","path":"http_examples.cpp","position":52,"original_position":52,"commit_id":"295f3839ee6928203a7544d9f9da1ba345f4e7f4","original_commit_id":"295f3839ee6928203a7544d9f9da1ba345f4e7f4","user":{"login":"eidheim","id":5269318,"avatar_url":"https://avatars0.githubusercontent.com/u/5269318?v=4","gravatar_id":"","url":"https://api.github.com/users/eidheim","html_url":"https://github.com/eidheim","followers_url":"https://api.github.com/users/eidheim/followers","following_url":"https://api.github.com/users/eidheim/following{/other_user}","gists_url":"https://api.github.com/users/eidheim/gists{/gist_id}","starred_url":"https://api.github.com/users/eidheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eidheim/subscriptions","organizations_url":"https://api.github.com/users/eidheim/orgs","repos_url":"https://api.github.com/users/eidheim/repos","events_url":"https://api.github.com/users/eidheim/events{/privacy}","received_events_url":"https://api.github.com/users/eidheim/received_events","type":"User","site_admin":false},"body":"Exception messages typically starts with lower case","created_at":"2017-10-30T19:28:57Z","updated_at":"2017-10-30T19:28:57Z","html_url":"https://github.com/eidheim/Simple-Web-Server/pull/162#discussion_r147809737","pull_request_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/162","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/comments/147809737"},"html":{"href":"https://github.com/eidheim/Simple-Web-Server/pull/162#discussion_r147809737"},"pull_request":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/162","id":149348605,"html_url":"https://github.com/eidheim/Simple-Web-Server/pull/162","diff_url":"https://github.com/eidheim/Simple-Web-Server/pull/162.diff","patch_url":"https://github.com/eidheim/Simple-Web-Server/pull/162.patch","issue_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/issues/162","number":162,"state":"open","locked":false,"title":"Added a parse_query_string() example","user":{"login":"vitor-alves","id":9059637,"avatar_url":"https://avatars2.githubusercontent.com/u/9059637?v=4","gravatar_id":"","url":"https://api.github.com/users/vitor-alves","html_url":"https://github.com/vitor-alves","followers_url":"https://api.github.com/users/vitor-alves/followers","following_url":"https://api.github.com/users/vitor-alves/following{/other_user}","gists_url":"https://api.github.com/users/vitor-alves/gists{/gist_id}","starred_url":"https://api.github.com/users/vitor-alves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitor-alves/subscriptions","organizations_url":"https://api.github.com/users/vitor-alves/orgs","repos_url":"https://api.github.com/users/vitor-alves/repos","events_url":"https://api.github.com/users/vitor-alves/events{/privacy}","received_events_url":"https://api.github.com/users/vitor-alves/received_events","type":"User","site_admin":false},"body":"Hi\r\n\r\nI added one more example that uses  `parse_query_string()` to parse the GET request parameters.\r\nI think it might be useful for newcomers. It's a pretty common thing to do and I needed it in one of my projects and couldn't find any examples.\r\n\r\nThe following GET to path `/parse` with parameters `name=Mary` and `lastName=Smith`\r\n\r\n`localhost:8080/parse?name=Mary&lastName=Smith`\r\n\r\nwill be parsed with `parse_query_string()` and the `name + lastName` will be returned as response.\r\n\r\nIts similar to the _John Smith_  example, but instead of parsing a JSON the `query_string` is parsed.\r\n\r\nI also fixed a few typos here and there. \r\n\r\nPlease consider this pull request, and thanks for this project. I have been using it a lot.\r\n\r\n","created_at":"2017-10-28T18:28:16Z","updated_at":"2017-10-30T19:28:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79c0e2b1b40deb08d8c21fa7ed029d4940af03a7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/162/commits","review_comments_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/162/comments","review_comment_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/issues/162/comments","statuses_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/statuses/295f3839ee6928203a7544d9f9da1ba345f4e7f4","head":{"label":"vitor-alves:master","ref":"master","sha":"295f3839ee6928203a7544d9f9da1ba345f4e7f4","user":{"login":"vitor-alves","id":9059637,"avatar_url":"https://avatars2.githubusercontent.com/u/9059637?v=4","gravatar_id":"","url":"https://api.github.com/users/vitor-alves","html_url":"https://github.com/vitor-alves","followers_url":"https://api.github.com/users/vitor-alves/followers","following_url":"https://api.github.com/users/vitor-alves/following{/other_user}","gists_url":"https://api.github.com/users/vitor-alves/gists{/gist_id}","starred_url":"https://api.github.com/users/vitor-alves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitor-alves/subscriptions","organizations_url":"https://api.github.com/users/vitor-alves/orgs","repos_url":"https://api.github.com/users/vitor-alves/repos","events_url":"https://api.github.com/users/vitor-alves/events{/privacy}","received_events_url":"https://api.github.com/users/vitor-alves/received_events","type":"User","site_admin":false},"repo":{"id":108672374,"name":"Simple-Web-Server","full_name":"vitor-alves/Simple-Web-Server","owner":{"login":"vitor-alves","id":9059637,"avatar_url":"https://avatars2.githubusercontent.com/u/9059637?v=4","gravatar_id":"","url":"https://api.github.com/users/vitor-alves","html_url":"https://github.com/vitor-alves","followers_url":"https://api.github.com/users/vitor-alves/followers","following_url":"https://api.github.com/users/vitor-alves/following{/other_user}","gists_url":"https://api.github.com/users/vitor-alves/gists{/gist_id}","starred_url":"https://api.github.com/users/vitor-alves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitor-alves/subscriptions","organizations_url":"https://api.github.com/users/vitor-alves/orgs","repos_url":"https://api.github.com/users/vitor-alves/repos","events_url":"https://api.github.com/users/vitor-alves/events{/privacy}","received_events_url":"https://api.github.com/users/vitor-alves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vitor-alves/Simple-Web-Server","description":"A very simple, fast, multithreaded, platform independent HTTP and HTTPS server and client library implemented using C++11 and Boost.Asio. Created to be an easy way to make REST resources available from C++ applications.","fork":true,"url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server","forks_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/forks","keys_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/teams","hooks_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/hooks","issue_events_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/issues/events{/number}","events_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/events","assignees_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/assignees{/user}","branches_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/branches{/branch}","tags_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/tags","blobs_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/languages","stargazers_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/stargazers","contributors_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/contributors","subscribers_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/subscribers","subscription_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/subscription","commits_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/contents/{+path}","compare_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/merges","archive_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/downloads","issues_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/issues{/number}","pulls_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/labels{/name}","releases_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/releases{/id}","deployments_url":"https://api.github.com/repos/vitor-alves/Simple-Web-Server/deployments","created_at":"2017-10-28T18:08:19Z","updated_at":"2017-10-28T18:08:21Z","pushed_at":"2017-10-28T18:12:14Z","git_url":"git://github.com/vitor-alves/Simple-Web-Server.git","ssh_url":"git@github.com:vitor-alves/Simple-Web-Server.git","clone_url":"https://github.com/vitor-alves/Simple-Web-Server.git","svn_url":"https://github.com/vitor-alves/Simple-Web-Server","homepage":"","size":473,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eidheim:master","ref":"master","sha":"bc4c49134d212b304fbdcb5cb147cc4027bbddad","user":{"login":"eidheim","id":5269318,"avatar_url":"https://avatars0.githubusercontent.com/u/5269318?v=4","gravatar_id":"","url":"https://api.github.com/users/eidheim","html_url":"https://github.com/eidheim","followers_url":"https://api.github.com/users/eidheim/followers","following_url":"https://api.github.com/users/eidheim/following{/other_user}","gists_url":"https://api.github.com/users/eidheim/gists{/gist_id}","starred_url":"https://api.github.com/users/eidheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eidheim/subscriptions","organizations_url":"https://api.github.com/users/eidheim/orgs","repos_url":"https://api.github.com/users/eidheim/repos","events_url":"https://api.github.com/users/eidheim/events{/privacy}","received_events_url":"https://api.github.com/users/eidheim/received_events","type":"User","site_admin":false},"repo":{"id":21517184,"name":"Simple-Web-Server","full_name":"eidheim/Simple-Web-Server","owner":{"login":"eidheim","id":5269318,"avatar_url":"https://avatars0.githubusercontent.com/u/5269318?v=4","gravatar_id":"","url":"https://api.github.com/users/eidheim","html_url":"https://github.com/eidheim","followers_url":"https://api.github.com/users/eidheim/followers","following_url":"https://api.github.com/users/eidheim/following{/other_user}","gists_url":"https://api.github.com/users/eidheim/gists{/gist_id}","starred_url":"https://api.github.com/users/eidheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eidheim/subscriptions","organizations_url":"https://api.github.com/users/eidheim/orgs","repos_url":"https://api.github.com/users/eidheim/repos","events_url":"https://api.github.com/users/eidheim/events{/privacy}","received_events_url":"https://api.github.com/users/eidheim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eidheim/Simple-Web-Server","description":"A very simple, fast, multithreaded, platform independent HTTP and HTTPS server and client library implemented using C++11 and Boost.Asio. Created to be an easy way to make REST resources available from C++ applications.","fork":false,"url":"https://api.github.com/repos/eidheim/Simple-Web-Server","forks_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/forks","keys_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/teams","hooks_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/hooks","issue_events_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/issues/events{/number}","events_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/events","assignees_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/assignees{/user}","branches_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/branches{/branch}","tags_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/tags","blobs_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/git/refs{/sha}","trees_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/statuses/{sha}","languages_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/languages","stargazers_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/stargazers","contributors_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/contributors","subscribers_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/subscribers","subscription_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/subscription","commits_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/commits{/sha}","git_commits_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/git/commits{/sha}","comments_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/comments{/number}","issue_comment_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/issues/comments{/number}","contents_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/contents/{+path}","compare_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/merges","archive_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/downloads","issues_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/issues{/number}","pulls_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls{/number}","milestones_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/milestones{/number}","notifications_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/labels{/name}","releases_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/releases{/id}","deployments_url":"https://api.github.com/repos/eidheim/Simple-Web-Server/deployments","created_at":"2014-07-05T09:47:12Z","updated_at":"2017-10-30T15:33:46Z","pushed_at":"2017-10-29T08:41:31Z","git_url":"git://github.com/eidheim/Simple-Web-Server.git","ssh_url":"git@github.com:eidheim/Simple-Web-Server.git","clone_url":"https://github.com/eidheim/Simple-Web-Server.git","svn_url":"https://github.com/eidheim/Simple-Web-Server","homepage":"","size":473,"stargazers_count":986,"watchers_count":986,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":339,"mirror_url":null,"archived":false,"open_issues_count":30,"forks":339,"open_issues":30,"watchers":986,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/162"},"html":{"href":"https://github.com/eidheim/Simple-Web-Server/pull/162"},"issue":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/issues/162"},"comments":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/eidheim/Simple-Web-Server/statuses/295f3839ee6928203a7544d9f9da1ba345f4e7f4"}},"author_association":"NONE"}}
{"actor":{"display_login":"eidheim"}}