{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/110850276","pull_request_review_id":32050124,"id":110850276,"diff_hunk":"@@ -0,0 +1,89 @@\n+package aws\n+\n+import (\n+\t\"fmt\"\n+\n+\t\"github.com/aws/aws-sdk-go/aws\"\n+\t\"github.com/aws/aws-sdk-go/service/ec2\"\n+\tmicroerror \"github.com/giantswarm/microkit/error\"\n+)\n+\n+type RouteTable struct {\n+\tName  string\n+\tVpcID string\n+\tid    string","path":"resources/aws/routetable.go","position":14,"original_position":14,"commit_id":"634eed1cd095a7bac61ce2b59b5e04aa7e874bef","original_commit_id":"634eed1cd095a7bac61ce2b59b5e04aa7e874bef","user":{"login":"nhlfr","id":1553979,"avatar_url":"https://avatars2.githubusercontent.com/u/1553979?v=3","gravatar_id":"","url":"https://api.github.com/users/nhlfr","html_url":"https://github.com/nhlfr","followers_url":"https://api.github.com/users/nhlfr/followers","following_url":"https://api.github.com/users/nhlfr/following{/other_user}","gists_url":"https://api.github.com/users/nhlfr/gists{/gist_id}","starred_url":"https://api.github.com/users/nhlfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhlfr/subscriptions","organizations_url":"https://api.github.com/users/nhlfr/orgs","repos_url":"https://api.github.com/users/nhlfr/repos","events_url":"https://api.github.com/users/nhlfr/events{/privacy}","received_events_url":"https://api.github.com/users/nhlfr/received_events","type":"User","site_admin":false},"body":"I want to keep that field private. The only places that modifiy the ID, should be `CreateOrFail` and `CreateIfNotExists` methods, then we should be able to only get it through the interface method.","created_at":"2017-04-11T09:08:22Z","updated_at":"2017-04-11T09:08:22Z","html_url":"https://github.com/giantswarm/aws-operator/pull/90#discussion_r110850276","pull_request_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/110850276"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/90#discussion_r110850276"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/90","id":114148870,"html_url":"https://github.com/giantswarm/aws-operator/pull/90","diff_url":"https://github.com/giantswarm/aws-operator/pull/90.diff","patch_url":"https://github.com/giantswarm/aws-operator/pull/90.patch","issue_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/90","number":90,"state":"open","locked":false,"title":"create/resources: Use VPC for network separation of clusters","user":{"login":"nhlfr","id":1553979,"avatar_url":"https://avatars2.githubusercontent.com/u/1553979?v=3","gravatar_id":"","url":"https://api.github.com/users/nhlfr","html_url":"https://github.com/nhlfr","followers_url":"https://api.github.com/users/nhlfr/followers","following_url":"https://api.github.com/users/nhlfr/following{/other_user}","gists_url":"https://api.github.com/users/nhlfr/gists{/gist_id}","starred_url":"https://api.github.com/users/nhlfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhlfr/subscriptions","organizations_url":"https://api.github.com/users/nhlfr/orgs","repos_url":"https://api.github.com/users/nhlfr/repos","events_url":"https://api.github.com/users/nhlfr/events{/privacy}","received_events_url":"https://api.github.com/users/nhlfr/received_events","type":"User","site_admin":false},"body":"In order to separate Kubernetes cluster in AWS, we will run each cluster in the separate VPC, with the two submets:\r\n- public - for master nodes\r\n- private - for worker nodes\r\n\r\nWe also set up security group in order to have control on which ports we want to expose in each machine.\r\n\r\nFixes #27","created_at":"2017-04-04T13:32:08Z","updated_at":"2017-04-11T09:08:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1fd0ced09a22d523fd6191f28b8913b480ba9c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/90/commits","review_comments_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/90/comments","review_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/90/comments","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/634eed1cd095a7bac61ce2b59b5e04aa7e874bef","head":{"label":"kinvolk:nhlfr/vpc","ref":"nhlfr/vpc","sha":"634eed1cd095a7bac61ce2b59b5e04aa7e874bef","user":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars3.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"repo":{"id":82806234,"name":"aws-operator","full_name":"kinvolk/aws-operator","owner":{"login":"kinvolk","id":14073052,"avatar_url":"https://avatars3.githubusercontent.com/u/14073052?v=3","gravatar_id":"","url":"https://api.github.com/users/kinvolk","html_url":"https://github.com/kinvolk","followers_url":"https://api.github.com/users/kinvolk/followers","following_url":"https://api.github.com/users/kinvolk/following{/other_user}","gists_url":"https://api.github.com/users/kinvolk/gists{/gist_id}","starred_url":"https://api.github.com/users/kinvolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinvolk/subscriptions","organizations_url":"https://api.github.com/users/kinvolk/orgs","repos_url":"https://api.github.com/users/kinvolk/repos","events_url":"https://api.github.com/users/kinvolk/events{/privacy}","received_events_url":"https://api.github.com/users/kinvolk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kinvolk/aws-operator","description":"AWS operator creates/configure/manages Kubernetes clusters on AWS by using Giantnetes.","fork":true,"url":"https://api.github.com/repos/kinvolk/aws-operator","forks_url":"https://api.github.com/repos/kinvolk/aws-operator/forks","keys_url":"https://api.github.com/repos/kinvolk/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinvolk/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinvolk/aws-operator/teams","hooks_url":"https://api.github.com/repos/kinvolk/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/kinvolk/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/kinvolk/aws-operator/events","assignees_url":"https://api.github.com/repos/kinvolk/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/kinvolk/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/kinvolk/aws-operator/tags","blobs_url":"https://api.github.com/repos/kinvolk/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinvolk/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinvolk/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinvolk/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinvolk/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/kinvolk/aws-operator/languages","stargazers_url":"https://api.github.com/repos/kinvolk/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/kinvolk/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/kinvolk/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/kinvolk/aws-operator/subscription","commits_url":"https://api.github.com/repos/kinvolk/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinvolk/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinvolk/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinvolk/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinvolk/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/kinvolk/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinvolk/aws-operator/merges","archive_url":"https://api.github.com/repos/kinvolk/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinvolk/aws-operator/downloads","issues_url":"https://api.github.com/repos/kinvolk/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/kinvolk/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/kinvolk/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/kinvolk/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinvolk/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/kinvolk/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/kinvolk/aws-operator/deployments","created_at":"2017-02-22T13:16:01Z","updated_at":"2017-03-09T09:46:04Z","pushed_at":"2017-04-10T15:24:51Z","git_url":"git://github.com/kinvolk/aws-operator.git","ssh_url":"git@github.com:kinvolk/aws-operator.git","clone_url":"https://github.com/kinvolk/aws-operator.git","svn_url":"https://github.com/kinvolk/aws-operator","homepage":null,"size":12644,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"5fa4aa099a3538b9cb08a914553c25d170d3883c","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"name":"aws-operator","full_name":"giantswarm/aws-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars0.githubusercontent.com/u/7556340?v=3","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/aws-operator","description":"AWS operator creates/configure/manages Kubernetes clusters on AWS by using Giantnetes.","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2017-04-07T12:47:21Z","pushed_at":"2017-04-10T15:24:52Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":null,"size":12474,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":18,"forks":1,"open_issues":18,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/90"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/90"},"issue":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/90"},"comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/aws-operator/statuses/634eed1cd095a7bac61ce2b59b5e04aa7e874bef"}}}}
{"actor":{"display_login":"nhlfr"}}