{"action":"closed","number":1040,"pull_request":{"url":"https://api.github.com/repos/Bash-it/bash-it/pulls/1040","id":141319957,"html_url":"https://github.com/Bash-it/bash-it/pull/1040","diff_url":"https://github.com/Bash-it/bash-it/pull/1040.diff","patch_url":"https://github.com/Bash-it/bash-it/pull/1040.patch","issue_url":"https://api.github.com/repos/Bash-it/bash-it/issues/1040","number":1040,"state":"closed","locked":false,"title":"Fix execution of trap DEBUG on subshells","user":{"login":"pmoranga","id":92371,"avatar_url":"https://avatars1.githubusercontent.com/u/92371?v=4","gravatar_id":"","url":"https://api.github.com/users/pmoranga","html_url":"https://github.com/pmoranga","followers_url":"https://api.github.com/users/pmoranga/followers","following_url":"https://api.github.com/users/pmoranga/following{/other_user}","gists_url":"https://api.github.com/users/pmoranga/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoranga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoranga/subscriptions","organizations_url":"https://api.github.com/users/pmoranga/orgs","repos_url":"https://api.github.com/users/pmoranga/repos","events_url":"https://api.github.com/users/pmoranga/events{/privacy}","received_events_url":"https://api.github.com/users/pmoranga/received_events","type":"User","site_admin":false},"body":"Disable trap DEBUG on subshells, this will fix issue where some sub-shell could issue unexpectedly some of the subshell commands.\r\n\r\nExample:\r\n\r\n    ~ for i in $(ls /tmp | head -2) ; do ssh $i lala; done \r\n    ssh: Could not resolve hostname \\033]0;fri: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname sep: Temporary failure in name resolution\r\n    ssh: connect to host 2017 port 22: Invalid argument\r\n    ssh: Could not resolve hostname 14:51:18: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname +0200: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname for: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname i: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname in: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname $(ls: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname /tmp: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname |: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname head: Temporary failure in name resolution\r\n    unknown option -- )\r\n    usage: ssh [-1246AaCfGgKkMNnqsTtVvXxYy] [-b bind_address] [-c cipher_spec]\r\n               [-D [bind_address:]port] [-E log_file] [-e escape_char]\r\n               [-F configfile] [-I pkcs11] [-i identity_file] [-L address]\r\n               [-l login_name] [-m mac_spec] [-O ctl_cmd] [-o option] [-p port]\r\n               [-Q query_option] [-R address] [-S ctl_path] [-W host:port]\r\n               [-w local_tun[:remote_tun]] [user@]hostname [command]\r\n    ssh: Could not resolve hostname ;: Temporary failure in name resolution\r\n\r\nAfter patch:\r\n\r\n     ~ for i in $(ls /tmp | head -2) ; do ssh $i lala; done \r\n    ssh: Could not resolve hostname ch-6n92k: Temporary failure in name resolution\r\n    ssh: Could not resolve hostname chfailed-z9qbc: Temporary failure in name resolution\r\n     ~ \r\n\r\n","created_at":"2017-09-15T14:09:11Z","updated_at":"2017-09-25T08:12:01Z","closed_at":"2017-09-25T08:12:01Z","merged_at":"2017-09-25T08:12:01Z","merge_commit_sha":"5a92d26cabd195ba4186ec7f6d3e572ec1a6ffa8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bash-it/bash-it/pulls/1040/commits","review_comments_url":"https://api.github.com/repos/Bash-it/bash-it/pulls/1040/comments","review_comment_url":"https://api.github.com/repos/Bash-it/bash-it/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bash-it/bash-it/issues/1040/comments","statuses_url":"https://api.github.com/repos/Bash-it/bash-it/statuses/0fc26dfad2fdbb52665a8ec9bf1af944761cebff","head":{"label":"pmoranga:fix_trap_subshell","ref":"fix_trap_subshell","sha":"0fc26dfad2fdbb52665a8ec9bf1af944761cebff","user":{"login":"pmoranga","id":92371,"avatar_url":"https://avatars1.githubusercontent.com/u/92371?v=4","gravatar_id":"","url":"https://api.github.com/users/pmoranga","html_url":"https://github.com/pmoranga","followers_url":"https://api.github.com/users/pmoranga/followers","following_url":"https://api.github.com/users/pmoranga/following{/other_user}","gists_url":"https://api.github.com/users/pmoranga/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoranga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoranga/subscriptions","organizations_url":"https://api.github.com/users/pmoranga/orgs","repos_url":"https://api.github.com/users/pmoranga/repos","events_url":"https://api.github.com/users/pmoranga/events{/privacy}","received_events_url":"https://api.github.com/users/pmoranga/received_events","type":"User","site_admin":false},"repo":{"id":103656994,"name":"bash-it","full_name":"pmoranga/bash-it","owner":{"login":"pmoranga","id":92371,"avatar_url":"https://avatars1.githubusercontent.com/u/92371?v=4","gravatar_id":"","url":"https://api.github.com/users/pmoranga","html_url":"https://github.com/pmoranga","followers_url":"https://api.github.com/users/pmoranga/followers","following_url":"https://api.github.com/users/pmoranga/following{/other_user}","gists_url":"https://api.github.com/users/pmoranga/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoranga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoranga/subscriptions","organizations_url":"https://api.github.com/users/pmoranga/orgs","repos_url":"https://api.github.com/users/pmoranga/repos","events_url":"https://api.github.com/users/pmoranga/events{/privacy}","received_events_url":"https://api.github.com/users/pmoranga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmoranga/bash-it","description":"A community Bash framework.","fork":true,"url":"https://api.github.com/repos/pmoranga/bash-it","forks_url":"https://api.github.com/repos/pmoranga/bash-it/forks","keys_url":"https://api.github.com/repos/pmoranga/bash-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmoranga/bash-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmoranga/bash-it/teams","hooks_url":"https://api.github.com/repos/pmoranga/bash-it/hooks","issue_events_url":"https://api.github.com/repos/pmoranga/bash-it/issues/events{/number}","events_url":"https://api.github.com/repos/pmoranga/bash-it/events","assignees_url":"https://api.github.com/repos/pmoranga/bash-it/assignees{/user}","branches_url":"https://api.github.com/repos/pmoranga/bash-it/branches{/branch}","tags_url":"https://api.github.com/repos/pmoranga/bash-it/tags","blobs_url":"https://api.github.com/repos/pmoranga/bash-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmoranga/bash-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmoranga/bash-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmoranga/bash-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmoranga/bash-it/statuses/{sha}","languages_url":"https://api.github.com/repos/pmoranga/bash-it/languages","stargazers_url":"https://api.github.com/repos/pmoranga/bash-it/stargazers","contributors_url":"https://api.github.com/repos/pmoranga/bash-it/contributors","subscribers_url":"https://api.github.com/repos/pmoranga/bash-it/subscribers","subscription_url":"https://api.github.com/repos/pmoranga/bash-it/subscription","commits_url":"https://api.github.com/repos/pmoranga/bash-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmoranga/bash-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmoranga/bash-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmoranga/bash-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmoranga/bash-it/contents/{+path}","compare_url":"https://api.github.com/repos/pmoranga/bash-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmoranga/bash-it/merges","archive_url":"https://api.github.com/repos/pmoranga/bash-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmoranga/bash-it/downloads","issues_url":"https://api.github.com/repos/pmoranga/bash-it/issues{/number}","pulls_url":"https://api.github.com/repos/pmoranga/bash-it/pulls{/number}","milestones_url":"https://api.github.com/repos/pmoranga/bash-it/milestones{/number}","notifications_url":"https://api.github.com/repos/pmoranga/bash-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmoranga/bash-it/labels{/name}","releases_url":"https://api.github.com/repos/pmoranga/bash-it/releases{/id}","deployments_url":"https://api.github.com/repos/pmoranga/bash-it/deployments","created_at":"2017-09-15T12:55:06Z","updated_at":"2017-09-15T12:55:08Z","pushed_at":"2017-09-22T10:24:20Z","git_url":"git://github.com/pmoranga/bash-it.git","ssh_url":"git@github.com:pmoranga/bash-it.git","clone_url":"https://github.com/pmoranga/bash-it.git","svn_url":"https://github.com/pmoranga/bash-it","homepage":"","size":39159,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bash-it:master","ref":"master","sha":"c4da957450036f4e8ef58ee1d98ffb07c58cf7aa","user":{"login":"Bash-it","id":11575812,"avatar_url":"https://avatars0.githubusercontent.com/u/11575812?v=4","gravatar_id":"","url":"https://api.github.com/users/Bash-it","html_url":"https://github.com/Bash-it","followers_url":"https://api.github.com/users/Bash-it/followers","following_url":"https://api.github.com/users/Bash-it/following{/other_user}","gists_url":"https://api.github.com/users/Bash-it/gists{/gist_id}","starred_url":"https://api.github.com/users/Bash-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bash-it/subscriptions","organizations_url":"https://api.github.com/users/Bash-it/orgs","repos_url":"https://api.github.com/users/Bash-it/repos","events_url":"https://api.github.com/users/Bash-it/events{/privacy}","received_events_url":"https://api.github.com/users/Bash-it/received_events","type":"Organization","site_admin":false},"repo":{"id":957012,"name":"bash-it","full_name":"Bash-it/bash-it","owner":{"login":"Bash-it","id":11575812,"avatar_url":"https://avatars0.githubusercontent.com/u/11575812?v=4","gravatar_id":"","url":"https://api.github.com/users/Bash-it","html_url":"https://github.com/Bash-it","followers_url":"https://api.github.com/users/Bash-it/followers","following_url":"https://api.github.com/users/Bash-it/following{/other_user}","gists_url":"https://api.github.com/users/Bash-it/gists{/gist_id}","starred_url":"https://api.github.com/users/Bash-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bash-it/subscriptions","organizations_url":"https://api.github.com/users/Bash-it/orgs","repos_url":"https://api.github.com/users/Bash-it/repos","events_url":"https://api.github.com/users/Bash-it/events{/privacy}","received_events_url":"https://api.github.com/users/Bash-it/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bash-it/bash-it","description":"A community Bash framework.","fork":false,"url":"https://api.github.com/repos/Bash-it/bash-it","forks_url":"https://api.github.com/repos/Bash-it/bash-it/forks","keys_url":"https://api.github.com/repos/Bash-it/bash-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bash-it/bash-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bash-it/bash-it/teams","hooks_url":"https://api.github.com/repos/Bash-it/bash-it/hooks","issue_events_url":"https://api.github.com/repos/Bash-it/bash-it/issues/events{/number}","events_url":"https://api.github.com/repos/Bash-it/bash-it/events","assignees_url":"https://api.github.com/repos/Bash-it/bash-it/assignees{/user}","branches_url":"https://api.github.com/repos/Bash-it/bash-it/branches{/branch}","tags_url":"https://api.github.com/repos/Bash-it/bash-it/tags","blobs_url":"https://api.github.com/repos/Bash-it/bash-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bash-it/bash-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bash-it/bash-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bash-it/bash-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bash-it/bash-it/statuses/{sha}","languages_url":"https://api.github.com/repos/Bash-it/bash-it/languages","stargazers_url":"https://api.github.com/repos/Bash-it/bash-it/stargazers","contributors_url":"https://api.github.com/repos/Bash-it/bash-it/contributors","subscribers_url":"https://api.github.com/repos/Bash-it/bash-it/subscribers","subscription_url":"https://api.github.com/repos/Bash-it/bash-it/subscription","commits_url":"https://api.github.com/repos/Bash-it/bash-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bash-it/bash-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bash-it/bash-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bash-it/bash-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bash-it/bash-it/contents/{+path}","compare_url":"https://api.github.com/repos/Bash-it/bash-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bash-it/bash-it/merges","archive_url":"https://api.github.com/repos/Bash-it/bash-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bash-it/bash-it/downloads","issues_url":"https://api.github.com/repos/Bash-it/bash-it/issues{/number}","pulls_url":"https://api.github.com/repos/Bash-it/bash-it/pulls{/number}","milestones_url":"https://api.github.com/repos/Bash-it/bash-it/milestones{/number}","notifications_url":"https://api.github.com/repos/Bash-it/bash-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bash-it/bash-it/labels{/name}","releases_url":"https://api.github.com/repos/Bash-it/bash-it/releases{/id}","deployments_url":"https://api.github.com/repos/Bash-it/bash-it/deployments","created_at":"2010-10-02T18:36:17Z","updated_at":"2017-09-24T18:39:18Z","pushed_at":"2017-09-25T08:12:01Z","git_url":"git://github.com/Bash-it/bash-it.git","ssh_url":"git@github.com:Bash-it/bash-it.git","clone_url":"https://github.com/Bash-it/bash-it.git","svn_url":"https://github.com/Bash-it/bash-it","homepage":"","size":39163,"stargazers_count":6736,"watchers_count":6736,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1406,"mirror_url":null,"open_issues_count":132,"forks":1406,"open_issues":132,"watchers":6736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bash-it/bash-it/pulls/1040"},"html":{"href":"https://github.com/Bash-it/bash-it/pull/1040"},"issue":{"href":"https://api.github.com/repos/Bash-it/bash-it/issues/1040"},"comments":{"href":"https://api.github.com/repos/Bash-it/bash-it/issues/1040/comments"},"review_comments":{"href":"https://api.github.com/repos/Bash-it/bash-it/pulls/1040/comments"},"review_comment":{"href":"https://api.github.com/repos/Bash-it/bash-it/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bash-it/bash-it/pulls/1040/commits"},"statuses":{"href":"https://api.github.com/repos/Bash-it/bash-it/statuses/0fc26dfad2fdbb52665a8ec9bf1af944761cebff"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nwinkler","id":907063,"avatar_url":"https://avatars1.githubusercontent.com/u/907063?v=4","gravatar_id":"","url":"https://api.github.com/users/nwinkler","html_url":"https://github.com/nwinkler","followers_url":"https://api.github.com/users/nwinkler/followers","following_url":"https://api.github.com/users/nwinkler/following{/other_user}","gists_url":"https://api.github.com/users/nwinkler/gists{/gist_id}","starred_url":"https://api.github.com/users/nwinkler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwinkler/subscriptions","organizations_url":"https://api.github.com/users/nwinkler/orgs","repos_url":"https://api.github.com/users/nwinkler/repos","events_url":"https://api.github.com/users/nwinkler/events{/privacy}","received_events_url":"https://api.github.com/users/nwinkler/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"nwinkler"}}