{"push_id":1659425400,"size":428,"distinct_size":0,"ref":"refs/heads/oes-dev","head":"e07336c91a70c6c22a34790d2ca98025e0440eab","before":"400389b0ca7a1ab8a0c2f1ca6857cd85250cf579","commits":[{"sha":"76c27d728f15abc6b5c53d34719311a1a81bd402","author":{"name":"Nick Houle","email":"09078cc9004deb492623f7d0fe45f0e8557aa0d7@instructure.com"},"message":"Revert \"Remove Feature Flag for SIS Integration API\"\n\nFixes: SIS-2713\n\nTest plan:\n- 'Allow Bulk Grade Export to SIS' is avaible and it should\n  enable Post To SIS checkbox for assignments and should\n  enable SIS Assignments API\n\nThis reverts commit f5587d1b21f481704ce0603db535f66946f5c7bf.\n\nChange-Id: Id0edafe64847d16c03f25c63527fa0e43d4f996a\nReviewed-on: https://gerrit.instructure.com/100799\nTested-by: Jenkins\nReviewed-by: Brad Humphrey <brad@instructure.com>\nQA-Review: Mark McDermott <mmcdermott@instructure.com>\nProduct-Review: Nick Houle <nhoule@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/76c27d728f15abc6b5c53d34719311a1a81bd402"},{"sha":"617a6f410a986dc83e1ef11943f483f77dcb65de","author":{"name":"Jon Jensen","email":"1bde51fb45d31234a937eabeae454399af21dc56@instructure.com"},"message":"spec: fix brittle specs\n\nthese primarily fail due to focus-jacking, but a couple other things are\nproblematic (.dev is a valid tld, and ajax might fail so it's better to\nensure it succeeded)\n\nChange-Id: I76cd9adc5fc59ced254bb278f0b67a03bc198e6b\nReviewed-on: https://gerrit.instructure.com/100816\nTested-by: Jenkins\nReviewed-by: Landon Wilkins <lwilkins@instructure.com>\nProduct-Review: Landon Wilkins <lwilkins@instructure.com>\nQA-Review: Landon Wilkins <lwilkins@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/617a6f410a986dc83e1ef11943f483f77dcb65de"},{"sha":"f083316b51806ced66d908f8853b4fe4d4abb7ea","author":{"name":"Spencer Olson","email":"474c9a5927d8c4fa504cff0f820e3413c2221e9e@instructure.com"},"message":"fix bug with max calculation\n\ncloses CNVS-34622\n\ntest plan:\n1. Enroll a user as 'Teacher' in at least two courses.\n2. In one of those courses, add a student to multiple sections.\n3. Log in as the teacher and go to the global grades page at /grades.\n4. Verify the page loads.\n\nChange-Id: Ifa2b95d2d67fce649de410cc91f52514c71ab4df\nReviewed-on: https://gerrit.instructure.com/100796\nReviewed-by: Neil Gupta <ngupta@instructure.com>\nTested-by: Jenkins\nReviewed-by: Keith T. Garner <kgarner@instructure.com>\nQA-Review: Anju Reddy <areddy@instructure.com>\nProduct-Review: Keith T. Garner <kgarner@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/f083316b51806ced66d908f8853b4fe4d4abb7ea"},{"sha":"89431b972cdceb6402034fadb2a8bad2f168e701","author":{"name":"Jon Jensen","email":"1bde51fb45d31234a937eabeae454399af21dc56@instructure.com"},"message":"spec: lower a bunch of timeouts\n\nif new specs can't exceed 15 sec, we :totes: should lower these.\n\nalso speed up request handling a little bit for 404'd assets (this ensures\nsome theme_specs don't hit the new script timeout)\n\nChange-Id: I1e099f6b0a54961e87c43c1d99a281c6ae4dcc10\nReviewed-on: https://gerrit.instructure.com/100737\nTested-by: Jenkins\nReviewed-by: Simon Williams <simon@instructure.com>\nProduct-Review: Jon Jensen <jon@instructure.com>\nQA-Review: Jon Jensen <jon@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/89431b972cdceb6402034fadb2a8bad2f168e701"},{"sha":"18a1b4d1dc05015895a3e34913ec6b8af7e5b2dc","author":{"name":"Jon Jensen","email":"1bde51fb45d31234a937eabeae454399af21dc56@instructure.com"},"message":"spec: consolidate finders, fixes SD-1868\n\nalso make Driver#find_elements raise when it can't find something. this\nway we won't use it to assert the absence of elements, since that's\neffectively an implicit `sleep 5` (the implicit wait timeout)\n\ntest plan:\nn/a, specs\n\nChange-Id: I999d60a28df503b078dd37d09d633c35154a5644\nReviewed-on: https://gerrit.instructure.com/100844\nTested-by: Jenkins\nReviewed-by: Landon Wilkins <lwilkins@instructure.com>\nProduct-Review: Landon Wilkins <lwilkins@instructure.com>\nQA-Review: Landon Wilkins <lwilkins@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/18a1b4d1dc05015895a3e34913ec6b8af7e5b2dc"},{"sha":"c9bd5c7d3b1b98104b76372fdd2c30c12490a1a4","author":{"name":"James Williams","email":"9044a6e2bf9507e481a4e56842ca8c51da2437b7@instructure.com"},"message":"fix tabs api documentation again\n\noops\n\ncloses #CNVS-34637\n\nChange-Id: Ia8f1f74eca69cb4630c1291843f45be444c3d0d8\nReviewed-on: https://gerrit.instructure.com/100862\nTested-by: Jenkins\nReviewed-by: Jeremy Stanley <jeremy@instructure.com>\nProduct-Review: James Williams  <jamesw@instructure.com>\nQA-Review: James Williams  <jamesw@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/c9bd5c7d3b1b98104b76372fdd2c30c12490a1a4"},{"sha":"cf87cc08b8c234ad12b0fd6abeb6940f2c916a8d","author":{"name":"Jon Jensen","email":"1bde51fb45d31234a937eabeae454399af21dc56@instructure.com"},"message":"spec: when using test-queue, don't truncate tables in main process\n\nwe're going to do it again after fork anyway, so it's redundant\n\nChange-Id: Iede3160a8daf63869a42505bbec0496c12336912\nReviewed-on: https://gerrit.instructure.com/100875\nTested-by: Jenkins\nReviewed-by: Landon Wilkins <lwilkins@instructure.com>\nProduct-Review: Landon Wilkins <lwilkins@instructure.com>\nQA-Review: Landon Wilkins <lwilkins@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/cf87cc08b8c234ad12b0fd6abeb6940f2c916a8d"},{"sha":"7e24f9e319925cf3dc3e7657ed53c2e8cd694cf8","author":{"name":"Cody Cutrer","email":"7e9fd717623d5c1ae8b16d280e7174a66cf3cec7@instructure.com"},"message":"Revert \"remove functionaltiy to move courses between root accounts\"\n\nThis reverts commit 3fb74991d6d9798b95de76a15230943203360e1e.\n\nalso hide it behind a setting\n\nChange-Id: Iec49940426c73632e191af2f99f36e6e3c4b6f0d\nReviewed-on: https://gerrit.instructure.com/100872\nReviewed-by: Simon Williams <simon@instructure.com>\nTested-by: Jenkins\nQA-Review: Jeremy Putnam <jeremyp@instructure.com>\nProduct-Review: Cody Cutrer <cody@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/7e24f9e319925cf3dc3e7657ed53c2e8cd694cf8"},{"sha":"3545d2a11dbbcd43e8f9044734a0e2c8b05f4a69","author":{"name":"Cody Cutrer","email":"7e9fd717623d5c1ae8b16d280e7174a66cf3cec7@instructure.com"},"message":"remove a require_relative\n\n a) it was causing double-requires because it's an autoloaded constant\n b) it's an autoloaded constant, so you don't need to explicitly require\n    it (even for disambiguation purposes; ActiveSupport will _always_\n    autoload Assignment _before_ it autoloads Assignment::SpeedGrader)\n\nChange-Id: Ibab9be04d5ac286d97b5d3b061c96c4c2a10e85c\nReviewed-on: https://gerrit.instructure.com/100892\nTested-by: Jenkins\nReviewed-by: Simon Williams <simon@instructure.com>\nProduct-Review: Cody Cutrer <cody@instructure.com>\nQA-Review: Cody Cutrer <cody@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/3545d2a11dbbcd43e8f9044734a0e2c8b05f4a69"},{"sha":"ba61494d34238ea3c44124d0c1975e616a9cde49","author":{"name":"Jeremy Stanley","email":"67d05a303f608c8860c0ff063dc59351aa55b332@instructure.com"},"message":"allow limited editing of default help links\n\ntest plan: In account settings, you should be able to edit the name,\n description, and available-to setting for default help links in\n an account, and these settings should apply as expected.\n (the URL should not be editable. only the account's copy of the\n  default link should be changed.)\n\ncloses CNVS-34471\n\nChange-Id: I501d4a04c558d211d63c716738075b54ddf9a79c\nReviewed-on: https://gerrit.instructure.com/100285\nReviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>\nTested-by: Jenkins\nQA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>\nProduct-Review: Chris Ward <cward@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/ba61494d34238ea3c44124d0c1975e616a9cde49"},{"sha":"4a5cbcdc0479c03da1f8b0637ae1cf7c02f82782","author":{"name":"Jeremy Stanley","email":"67d05a303f608c8860c0ff063dc59351aa55b332@instructure.com"},"message":"$.getJSON instead of $.get where we're getting JSON\n\nso ids are properly stringified\n\nChange-Id: I8bf20ff2c0cbba1022ee5444cc6af2a23e834526\nReviewed-on: https://gerrit.instructure.com/96008\nReviewed-by: Clay Diffrient <cdiffrient@instructure.com>\nTested-by: Jenkins\nProduct-Review: Jeremy Stanley <jeremy@instructure.com>\nQA-Review: Jeremy Stanley <jeremy@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/4a5cbcdc0479c03da1f8b0637ae1cf7c02f82782"},{"sha":"c501e5ecd489596e4a1e36f37287ef36a3aaf03b","author":{"name":"Ed Schiebel","email":"7a81b666de83d1d7726119c1091519dc40fae8ae@instructure.com"},"message":"Delete attachments from discussion replies\n\nThe original ticket asked to enable adding and removing attacments,\nwhile editing a reply.  This has been split into 2 separate tasks,\nthis one addresses the remove.\n\nfixes CNVS-29918\n\nTest plan:\n  - goto a course > discussions\n  - start a new discussion\n  - add a reply, attach a file to it and save\n  - edit the reply\n  - click the 'x' to remove the attachment\n  - click \"cancel\"\n  > expected result: the attachment is still there\n\n  - edit the reply\n  - click on the 'x' to remove the attachment\n  - click \"done\"\n  > expected result: the attachment has been removed\n\nChange-Id: I957ea08f77527e816f74799e3501b284dac5c882\nReviewed-on: https://gerrit.instructure.com/99661\nReviewed-by: Clay Diffrient <cdiffrient@instructure.com>\nQA-Review: David Tan <dtan@instructure.com>\nProduct-Review: Chris Ward <cward@instructure.com>\nTested-by: Jenkins","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/c501e5ecd489596e4a1e36f37287ef36a3aaf03b"},{"sha":"28f76d20b63f54a1c8c8aca2d232d4b439c6bb2e","author":{"name":"Augusto Callejas","email":"13cff03885407e4dcea880a44eeb95c2fa5749c0@instructure.com"},"message":"Fix clearing rubric criterion bug\n\ncloses OUT-1072\n\ntest plan:\n  - enable and config Academic Benchmarks plugins\n  - import standards into global outcomes\n    > AcademicBenchmark.import('A834CC02-901A-11DF-A622-0C319DFF4B22')\n  - monitor the import until its complete\n    > ContentMigration.last.workflow_state\n  - on an account's outcome page, import a single global outcome\n  - on a course's outcome page, import the single account outcome\n  - create an assignment\n  - align the course outcome with the assignment\n  - as a student, submit to the assignment\n  - as a teacher, assess the assignment, including the rubric asssessment\n  - import standards again, but override the mastery points\n    > AcademicBenchmark.import('A834CC02-901A-11DF-A622-0C319DFF4B22', {mastery_points: 4})\n  - monitor the import until its complete\n    > ContentMigration.last.workflow_state\n  - return to the account's outcome page and click on Find to view\n    the global outcomes\n  - confirm that the outcome that was assessed still has a mastery points value of 3,\n    while all other global outcomes have a mastery points value of 4\n\nChange-Id: I11fd260e1753ec959fc9160a357f9f6441041682\nReviewed-on: https://gerrit.instructure.com/100768\nTested-by: Jenkins\nReviewed-by: Matt Berns <mberns@instructure.com>\nQA-Review: Alex Ortiz-Rosado <aortiz@instructure.com>\nProduct-Review: Michael Brewer-Davis <mbd@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/28f76d20b63f54a1c8c8aca2d232d4b439c6bb2e"},{"sha":"31c81635177dbec396d78a8f0ff75dd0bafe8b4e","author":{"name":"Benjamin Porter","email":"9c9114853cfe9699a8787c5c2460f271c514639a@instructure.com"},"message":"Fix bug in doc rendering to HTML\n\nThe missing newline caused the markdown to be rendered\nall on the same line.\n\nChange-Id: Ibf6982536cd5edaa908a52a1fe885814d5f8dc50\nReviewed-on: https://gerrit.instructure.com/100568\nTested-by: Jenkins\nReviewed-by: Aaron Shafovaloff <ashafovaloff@instructure.com>\nProduct-Review: Aaron Shafovaloff <ashafovaloff@instructure.com>\nQA-Review: Caleb Guanzon <cguanzon@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/31c81635177dbec396d78a8f0ff75dd0bafe8b4e"},{"sha":"693a81e579386c2ff00948ecb6d55fd9f82386da","author":{"name":"Jeremy Neander","email":"f741c2bc464d3dd3dce932fc3824725070fe4f59@instructure.com"},"message":"resize media comments dialog to fit video\n\nWhen audio or video recordings are used in submission comments on\nan assignment (in SpeedGrader or Submission Details), clicking\nthe thumbnail opens a modal that automatically plays the media,\nbut displays no controls, making it impossible to pause or\nrewind.\n\nThis commit resizes the dialog so the controls are not hidden in\nthe overflow of the element.\n\nfixes CNVS-30875\n\ntest plan:\n* create a media comment\n* click the thumbnail for the media comment\n* verify the controls are visible\n\nChange-Id: I8d1eadccec28c42c957f95546af3af762b2231dd\nReviewed-on: https://gerrit.instructure.com/100551\nReviewed-by: Shahbaz Javeed <sjaveed@instructure.com>\nReviewed-by: Derek Bender <djbender@instructure.com>\nTested-by: Jenkins\nQA-Review: Anju Reddy <areddy@instructure.com>\nProduct-Review: Keith T. Garner <kgarner@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/693a81e579386c2ff00948ecb6d55fd9f82386da"},{"sha":"89f882b0390c3914c60f98906f723eaeea4001bb","author":{"name":"Jon Jensen","email":"1bde51fb45d31234a937eabeae454399af21dc56@instructure.com"},"message":"spec: fix byebug+timeouts, consolidate logic\n\ni had thought it was working w/ byebug, but apparently not. presumably\nsometime after the initializer was written, byebug introduced its\nfreeze-all-other-threads behavior. so make it work again, but make it\nlike the Pry approach in that if we have ever debugger'd, timeouts\nbecome disabled for the rest of the process' lifetime (and not just if\nwe are currently debugger'ing, since that's impossible w/ byebug since\nthe timeout thread is frozen)\n\ntest plan\n1. put a debugger in a spec and continue after a minute\n2. confirm you don't get hit by the spec timeout\n3. put a binding.pry in a spec and continue after a minute\n4. confirm you don't get hit by the spec timeout\n\nChange-Id: I78f2ed4c2501273564cfed77504ec14d4b442d66\nReviewed-on: https://gerrit.instructure.com/100936\nTested-by: Jenkins\nReviewed-by: Shawn Meredith <shawn@instructure.com>\nProduct-Review: Shawn Meredith <shawn@instructure.com>\nQA-Review: Shawn Meredith <shawn@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/89f882b0390c3914c60f98906f723eaeea4001bb"},{"sha":"f2fa39e4daa86965518d8aefe102e78d103c8195","author":{"name":"Steven Burnett","email":"ff6168ef9cff0a1a0e976c880e18c55bfcf53183@instructure.com"},"message":"fix course_user_search tests\n\nTest Plan:\n- Jenkins passes\n\nChange-Id: I8f868d28388ad555408a79feb664c268d2e71e53\nReviewed-on: https://gerrit.instructure.com/100889\nTested-by: Jenkins\nReviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>\nProduct-Review: Steven Burnett <sburnett@instructure.com>\nQA-Review: Steven Burnett <sburnett@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/f2fa39e4daa86965518d8aefe102e78d103c8195"},{"sha":"6421eca9273e2f1ee281d633d597ee4d96f7f43c","author":{"name":"Steven Burnett","email":"ff6168ef9cff0a1a0e976c880e18c55bfcf53183@instructure.com"},"message":"fix warnings\n\nTest Plan:\n- Jenkins Passes\n\nChange-Id: Ie71062c87f8b114e146251190556fa082c097823\nReviewed-on: https://gerrit.instructure.com/100878\nTested-by: Jenkins\nReviewed-by: Felix Milea-Ciobanu <fmileaciobanu@instructure.com>\nProduct-Review: Steven Burnett <sburnett@instructure.com>\nQA-Review: Steven Burnett <sburnett@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/6421eca9273e2f1ee281d633d597ee4d96f7f43c"},{"sha":"b5190965fb3e6485397b2e87d3b80e8f41f7982a","author":{"name":"James Williams","email":"9044a6e2bf9507e481a4e56842ca8c51da2437b7@instructure.com"},"message":"fix setting of new announcement home page course settings\n\ntest plan:\n* changing the \"Show recent announcements\"\n and \"Number of announcements shown\" course settings\n should work\n\ncloses #CNVS-34595\n\nChange-Id: Ib7822208c96ef45eaa4e4158ba8b1cf3ec9adb74\nReviewed-on: https://gerrit.instructure.com/100657\nTested-by: Jenkins\nReviewed-by: Dan Minkevitch <dan@instructure.com>\nQA-Review: Heath Hales <hhales@instructure.com>\nProduct-Review: James Williams  <jamesw@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/b5190965fb3e6485397b2e87d3b80e8f41f7982a"},{"sha":"26bda5b6112446dca5c1ca91e90316a02a8fbc21","author":{"name":"Simon Williams","email":"3a69a7dd305e9c7705028afae27095688d25197a@instructure.com"},"message":"upgrade rubocop and rubocop-rspec to latest\n\ncloses CNVS-34657\n\ntest plan: rubocop should still work\n\nChange-Id: Ibdd340dd7ba516639ee5b7225449422b324bd33a\nReviewed-on: https://gerrit.instructure.com/100831\nTested-by: Jenkins\nReviewed-by: Tyler Pickett <tpickett@instructure.com>\nProduct-Review: Simon Williams <simon@instructure.com>\nQA-Review: Simon Williams <simon@instructure.com>","distinct":false,"url":"https://api.github.com/repos/SwinburneOnline/canvas-lms/commits/26bda5b6112446dca5c1ca91e90316a02a8fbc21"}]}
{"actor":{"display_login":"lsornanathan"}}