{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/118698097","pull_request_review_id":40516687,"id":118698097,"diff_hunk":"@@ -20,7 +20,7 @@ class MyBatchPipelineConfigCtrl {\n     this.HydratorPlusPlusHydratorService = HydratorPlusPlusHydratorService;\n \n     this.engine = this.store.getEngine();\n-    this.engineForDisplay = this.engine === 'mapreduce' ? 'MapReduce' : 'Spark';\n+    this.engineForDisplay = this.engine === 'mapreduce' ? 'MapReduce' : 'Apache Spark';","path":"cdap-ui/app/directives/my-pipeline-configurations/my-batch-pipeline-config/my-batch-pipeline-config-ctrl.js","position":null,"original_position":5,"commit_id":"62ab99eda12d72f5efc715d6cef5e8f8a412795e","original_commit_id":"0b08008b53b1423ce6607280bf066d7add20527f","user":{"login":"bdmogal","id":3895099,"avatar_url":"https://avatars3.githubusercontent.com/u/3895099?v=3","gravatar_id":"","url":"https://api.github.com/users/bdmogal","html_url":"https://github.com/bdmogal","followers_url":"https://api.github.com/users/bdmogal/followers","following_url":"https://api.github.com/users/bdmogal/following{/other_user}","gists_url":"https://api.github.com/users/bdmogal/gists{/gist_id}","starred_url":"https://api.github.com/users/bdmogal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdmogal/subscriptions","organizations_url":"https://api.github.com/users/bdmogal/orgs","repos_url":"https://api.github.com/users/bdmogal/repos","events_url":"https://api.github.com/users/bdmogal/events{/privacy}","received_events_url":"https://api.github.com/users/bdmogal/received_events","type":"User","site_admin":false},"body":"why did we change this?","created_at":"2017-05-26T13:10:15Z","updated_at":"2017-05-26T13:10:15Z","html_url":"https://github.com/caskdata/cdap/pull/8868#discussion_r118698097","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/8868","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/118698097"},"html":{"href":"https://github.com/caskdata/cdap/pull/8868#discussion_r118698097"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/8868"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/8868","id":121979922,"html_url":"https://github.com/caskdata/cdap/pull/8868","diff_url":"https://github.com/caskdata/cdap/pull/8868.diff","patch_url":"https://github.com/caskdata/cdap/pull/8868.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/8868","number":8868,"state":"open","locked":false,"title":"[CDAP-9091] New pipeline config tabs","user":{"login":"tonybach","id":6516002,"avatar_url":"https://avatars3.githubusercontent.com/u/6516002?v=3","gravatar_id":"","url":"https://api.github.com/users/tonybach","html_url":"https://github.com/tonybach","followers_url":"https://api.github.com/users/tonybach/followers","following_url":"https://api.github.com/users/tonybach/following{/other_user}","gists_url":"https://api.github.com/users/tonybach/gists{/gist_id}","starred_url":"https://api.github.com/users/tonybach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonybach/subscriptions","organizations_url":"https://api.github.com/users/tonybach/orgs","repos_url":"https://api.github.com/users/tonybach/repos","events_url":"https://api.github.com/users/tonybach/events{/privacy}","received_events_url":"https://api.github.com/users/tonybach/received_events","type":"User","site_admin":false},"body":"* Main JIRA: https://issues.cask.co/browse/CDAP-9091\r\n* Sub-JIRAs:\r\n    * Engine config tab: https://issues.cask.co/browse/CDAP-11528\r\n    * Pipeline config tab: https://issues.cask.co/browse/CDAP-11524\r\n    * Resources tab: https://issues.cask.co/browse/CDAP-11541\r\n\r\n**TODO**:\r\n- ~~The batch interval dropdown in pipeline config tab for realtime pipelines.~~\r\n- ~~Resources tab~~\r\n- ~~Preview config tab ([CDAP-9110](https://issues.cask.co/browse/CDAP-9110))~~\r\n- ~~Alerts tab (Post-run actions)~~\r\n- ~~Replace and remove the Settings button when all of the above are implemented.~~\r\n- ~~Reorders Labels after removing Settings button ([CDAP-11550](https://issues.cask.co/browse/CDAP-11550))~~","created_at":"2017-05-23T11:59:23Z","updated_at":"2017-05-26T13:10:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"837a21e98f96c1f73c8c62a22c5abe8b36d6838c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/8868/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/8868/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/8868/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/62ab99eda12d72f5efc715d6cef5e8f8a412795e","head":{"label":"caskdata:feature/new-config-tabs","ref":"feature/new-config-tabs","sha":"62ab99eda12d72f5efc715d6cef5e8f8a412795e","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars1.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars1.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2017-05-23T15:55:40Z","pushed_at":"2017-05-26T08:28:25Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"","size":499258,"stargazers_count":172,"watchers_count":172,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":85,"mirror_url":null,"open_issues_count":27,"forks":85,"open_issues":27,"watchers":172,"default_branch":"release/4.2"}},"base":{"label":"caskdata:release/4.2","ref":"release/4.2","sha":"c58220bb01b75fa490c59069a96cf72a8b3fff57","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars1.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars1.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2017-05-23T15:55:40Z","pushed_at":"2017-05-26T08:28:25Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"","size":499258,"stargazers_count":172,"watchers_count":172,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":85,"mirror_url":null,"open_issues_count":27,"forks":85,"open_issues":27,"watchers":172,"default_branch":"release/4.2"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/8868"},"html":{"href":"https://github.com/caskdata/cdap/pull/8868"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/8868"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/8868/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/8868/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/8868/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/62ab99eda12d72f5efc715d6cef5e8f8a412795e"}}}}
{"actor":{"display_login":"bdmogal"}}