{"action":"closed","number":291,"pull_request":{"url":"https://api.github.com/repos/pulp/pulp_packaging/pulls/291","id":104897454,"html_url":"https://github.com/pulp/pulp_packaging/pull/291","diff_url":"https://github.com/pulp/pulp_packaging/pull/291.diff","patch_url":"https://github.com/pulp/pulp_packaging/pull/291.patch","issue_url":"https://api.github.com/repos/pulp/pulp_packaging/issues/291","number":291,"state":"closed","locked":false,"title":"\"Librarize\" common git cloning code across scripts","user":{"login":"seandst","id":441252,"avatar_url":"https://avatars.githubusercontent.com/u/441252?v=3","gravatar_id":"","url":"https://api.github.com/users/seandst","html_url":"https://github.com/seandst","followers_url":"https://api.github.com/users/seandst/followers","following_url":"https://api.github.com/users/seandst/following{/other_user}","gists_url":"https://api.github.com/users/seandst/gists{/gist_id}","starred_url":"https://api.github.com/users/seandst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandst/subscriptions","organizations_url":"https://api.github.com/users/seandst/orgs","repos_url":"https://api.github.com/users/seandst/repos","events_url":"https://api.github.com/users/seandst/events{/privacy}","received_events_url":"https://api.github.com/users/seandst/received_events","type":"User","site_admin":false},"body":"Both the merge forward script and build-all have had duplicated\r\ncode for a while. The introduction of docs-builder came with a\r\nthird place where git cloning was done. I put in a hacky fix in\r\ncentralizing the git cloning and update code.\r\n\r\nThis is that follow-up. :)\r\n\r\nThe diff is, I think, a case of \"It looks worse than it is.\" The\r\nbasic plan I followed was to functionalize behaviors, and then move\r\nany function that isn't \"parse_args\", \"main\", etc. up into the lib\r\nmodules to be shared by the multiple scripts that want to use them.\r\n\r\nTo test, build-all, docs-builder, and the update-version-and-merge-forward\r\nscripts should all work as expected, and definitely not explode.","created_at":"2017-02-06T22:34:31Z","updated_at":"2017-02-07T17:09:26Z","closed_at":"2017-02-07T17:09:26Z","merged_at":"2017-02-07T17:09:26Z","merge_commit_sha":"9a261c24e6eff843c0281fcd63d177402f969b08","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pulp/pulp_packaging/pulls/291/commits","review_comments_url":"https://api.github.com/repos/pulp/pulp_packaging/pulls/291/comments","review_comment_url":"https://api.github.com/repos/pulp/pulp_packaging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pulp/pulp_packaging/issues/291/comments","statuses_url":"https://api.github.com/repos/pulp/pulp_packaging/statuses/2c7fff2445bce1866bc01a3e7a0f59369830900a","head":{"label":"seandst:librarize-update-versions","ref":"librarize-update-versions","sha":"2c7fff2445bce1866bc01a3e7a0f59369830900a","user":{"login":"seandst","id":441252,"avatar_url":"https://avatars.githubusercontent.com/u/441252?v=3","gravatar_id":"","url":"https://api.github.com/users/seandst","html_url":"https://github.com/seandst","followers_url":"https://api.github.com/users/seandst/followers","following_url":"https://api.github.com/users/seandst/following{/other_user}","gists_url":"https://api.github.com/users/seandst/gists{/gist_id}","starred_url":"https://api.github.com/users/seandst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandst/subscriptions","organizations_url":"https://api.github.com/users/seandst/orgs","repos_url":"https://api.github.com/users/seandst/repos","events_url":"https://api.github.com/users/seandst/events{/privacy}","received_events_url":"https://api.github.com/users/seandst/received_events","type":"User","site_admin":false},"repo":{"id":47142267,"name":"pulp_packaging","full_name":"seandst/pulp_packaging","owner":{"login":"seandst","id":441252,"avatar_url":"https://avatars.githubusercontent.com/u/441252?v=3","gravatar_id":"","url":"https://api.github.com/users/seandst","html_url":"https://github.com/seandst","followers_url":"https://api.github.com/users/seandst/followers","following_url":"https://api.github.com/users/seandst/following{/other_user}","gists_url":"https://api.github.com/users/seandst/gists{/gist_id}","starred_url":"https://api.github.com/users/seandst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandst/subscriptions","organizations_url":"https://api.github.com/users/seandst/orgs","repos_url":"https://api.github.com/users/seandst/repos","events_url":"https://api.github.com/users/seandst/events{/privacy}","received_events_url":"https://api.github.com/users/seandst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seandst/pulp_packaging","description":null,"fork":true,"url":"https://api.github.com/repos/seandst/pulp_packaging","forks_url":"https://api.github.com/repos/seandst/pulp_packaging/forks","keys_url":"https://api.github.com/repos/seandst/pulp_packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seandst/pulp_packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seandst/pulp_packaging/teams","hooks_url":"https://api.github.com/repos/seandst/pulp_packaging/hooks","issue_events_url":"https://api.github.com/repos/seandst/pulp_packaging/issues/events{/number}","events_url":"https://api.github.com/repos/seandst/pulp_packaging/events","assignees_url":"https://api.github.com/repos/seandst/pulp_packaging/assignees{/user}","branches_url":"https://api.github.com/repos/seandst/pulp_packaging/branches{/branch}","tags_url":"https://api.github.com/repos/seandst/pulp_packaging/tags","blobs_url":"https://api.github.com/repos/seandst/pulp_packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seandst/pulp_packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seandst/pulp_packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/seandst/pulp_packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seandst/pulp_packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/seandst/pulp_packaging/languages","stargazers_url":"https://api.github.com/repos/seandst/pulp_packaging/stargazers","contributors_url":"https://api.github.com/repos/seandst/pulp_packaging/contributors","subscribers_url":"https://api.github.com/repos/seandst/pulp_packaging/subscribers","subscription_url":"https://api.github.com/repos/seandst/pulp_packaging/subscription","commits_url":"https://api.github.com/repos/seandst/pulp_packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/seandst/pulp_packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/seandst/pulp_packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/seandst/pulp_packaging/issues/comments{/number}","contents_url":"https://api.github.com/repos/seandst/pulp_packaging/contents/{+path}","compare_url":"https://api.github.com/repos/seandst/pulp_packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seandst/pulp_packaging/merges","archive_url":"https://api.github.com/repos/seandst/pulp_packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seandst/pulp_packaging/downloads","issues_url":"https://api.github.com/repos/seandst/pulp_packaging/issues{/number}","pulls_url":"https://api.github.com/repos/seandst/pulp_packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/seandst/pulp_packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/seandst/pulp_packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seandst/pulp_packaging/labels{/name}","releases_url":"https://api.github.com/repos/seandst/pulp_packaging/releases{/id}","deployments_url":"https://api.github.com/repos/seandst/pulp_packaging/deployments","created_at":"2015-11-30T19:53:12Z","updated_at":"2016-02-10T22:27:19Z","pushed_at":"2017-02-07T17:05:04Z","git_url":"git://github.com/seandst/pulp_packaging.git","ssh_url":"git@github.com:seandst/pulp_packaging.git","clone_url":"https://github.com/seandst/pulp_packaging.git","svn_url":"https://github.com/seandst/pulp_packaging","homepage":null,"size":717,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pulp:master","ref":"master","sha":"ea2ed9f17b701941551216fce21a7877acad8d02","user":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"repo":{"id":23434004,"name":"pulp_packaging","full_name":"pulp/pulp_packaging","owner":{"login":"pulp","id":2103606,"avatar_url":"https://avatars.githubusercontent.com/u/2103606?v=3","gravatar_id":"","url":"https://api.github.com/users/pulp","html_url":"https://github.com/pulp","followers_url":"https://api.github.com/users/pulp/followers","following_url":"https://api.github.com/users/pulp/following{/other_user}","gists_url":"https://api.github.com/users/pulp/gists{/gist_id}","starred_url":"https://api.github.com/users/pulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pulp/subscriptions","organizations_url":"https://api.github.com/users/pulp/orgs","repos_url":"https://api.github.com/users/pulp/repos","events_url":"https://api.github.com/users/pulp/events{/privacy}","received_events_url":"https://api.github.com/users/pulp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pulp/pulp_packaging","description":null,"fork":false,"url":"https://api.github.com/repos/pulp/pulp_packaging","forks_url":"https://api.github.com/repos/pulp/pulp_packaging/forks","keys_url":"https://api.github.com/repos/pulp/pulp_packaging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pulp/pulp_packaging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pulp/pulp_packaging/teams","hooks_url":"https://api.github.com/repos/pulp/pulp_packaging/hooks","issue_events_url":"https://api.github.com/repos/pulp/pulp_packaging/issues/events{/number}","events_url":"https://api.github.com/repos/pulp/pulp_packaging/events","assignees_url":"https://api.github.com/repos/pulp/pulp_packaging/assignees{/user}","branches_url":"https://api.github.com/repos/pulp/pulp_packaging/branches{/branch}","tags_url":"https://api.github.com/repos/pulp/pulp_packaging/tags","blobs_url":"https://api.github.com/repos/pulp/pulp_packaging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pulp/pulp_packaging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pulp/pulp_packaging/git/refs{/sha}","trees_url":"https://api.github.com/repos/pulp/pulp_packaging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pulp/pulp_packaging/statuses/{sha}","languages_url":"https://api.github.com/repos/pulp/pulp_packaging/languages","stargazers_url":"https://api.github.com/repos/pulp/pulp_packaging/stargazers","contributors_url":"https://api.github.com/repos/pulp/pulp_packaging/contributors","subscribers_url":"https://api.github.com/repos/pulp/pulp_packaging/subscribers","subscription_url":"https://api.github.com/repos/pulp/pulp_packaging/subscription","commits_url":"https://api.github.com/repos/pulp/pulp_packaging/commits{/sha}","git_commits_url":"https://api.github.com/repos/pulp/pulp_packaging/git/commits{/sha}","comments_url":"https://api.github.com/repos/pulp/pulp_packaging/comments{/number}","issue_comment_url":"https://api.github.com/repos/pulp/pulp_packaging/issues/comments{/number}","contents_url":"https://api.github.com/repos/pulp/pulp_packaging/contents/{+path}","compare_url":"https://api.github.com/repos/pulp/pulp_packaging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pulp/pulp_packaging/merges","archive_url":"https://api.github.com/repos/pulp/pulp_packaging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pulp/pulp_packaging/downloads","issues_url":"https://api.github.com/repos/pulp/pulp_packaging/issues{/number}","pulls_url":"https://api.github.com/repos/pulp/pulp_packaging/pulls{/number}","milestones_url":"https://api.github.com/repos/pulp/pulp_packaging/milestones{/number}","notifications_url":"https://api.github.com/repos/pulp/pulp_packaging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pulp/pulp_packaging/labels{/name}","releases_url":"https://api.github.com/repos/pulp/pulp_packaging/releases{/id}","deployments_url":"https://api.github.com/repos/pulp/pulp_packaging/deployments","created_at":"2014-08-28T15:54:53Z","updated_at":"2016-10-24T19:11:32Z","pushed_at":"2017-02-07T17:09:25Z","git_url":"git://github.com/pulp/pulp_packaging.git","ssh_url":"git@github.com:pulp/pulp_packaging.git","clone_url":"https://github.com/pulp/pulp_packaging.git","svn_url":"https://github.com/pulp/pulp_packaging","homepage":null,"size":672,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":2,"forks":38,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pulp/pulp_packaging/pulls/291"},"html":{"href":"https://github.com/pulp/pulp_packaging/pull/291"},"issue":{"href":"https://api.github.com/repos/pulp/pulp_packaging/issues/291"},"comments":{"href":"https://api.github.com/repos/pulp/pulp_packaging/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/pulp/pulp_packaging/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/pulp/pulp_packaging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pulp/pulp_packaging/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/pulp/pulp_packaging/statuses/2c7fff2445bce1866bc01a3e7a0f59369830900a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"seandst","id":441252,"avatar_url":"https://avatars.githubusercontent.com/u/441252?v=3","gravatar_id":"","url":"https://api.github.com/users/seandst","html_url":"https://github.com/seandst","followers_url":"https://api.github.com/users/seandst/followers","following_url":"https://api.github.com/users/seandst/following{/other_user}","gists_url":"https://api.github.com/users/seandst/gists{/gist_id}","starred_url":"https://api.github.com/users/seandst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seandst/subscriptions","organizations_url":"https://api.github.com/users/seandst/orgs","repos_url":"https://api.github.com/users/seandst/repos","events_url":"https://api.github.com/users/seandst/events{/privacy}","received_events_url":"https://api.github.com/users/seandst/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"maintainer_can_modify":false,"commits":1,"additions":356,"deletions":354,"changed_files":7}}
{"actor":{"display_login":"seandst"}}