{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/comments/142707053","pull_request_review_id":67107802,"id":142707053,"diff_hunk":"@@ -73,6 +81,9 @@ func clientSTS(s logical.Storage) (*sts.STS, error) {\n \t\treturn nil, err\n \t}\n \tclient := sts.New(session.New(awsConfig))\n+\tif *awsConfig.Endpoint != \"none\" {\n+\t\tclient = sts.New(session.New(awsConfig.WithEndpoint(*awsConfig.Endpoint)))","path":"builtin/logical/aws/client.go","position":35,"original_position":35,"commit_id":"57cf97db6a846b31cc2ff0b2858a02eb9a414405","original_commit_id":"57cf97db6a846b31cc2ff0b2858a02eb9a414405","user":{"login":"joelthompson","id":1562980,"avatar_url":"https://avatars2.githubusercontent.com/u/1562980?v=4","gravatar_id":"","url":"https://api.github.com/users/joelthompson","html_url":"https://github.com/joelthompson","followers_url":"https://api.github.com/users/joelthompson/followers","following_url":"https://api.github.com/users/joelthompson/following{/other_user}","gists_url":"https://api.github.com/users/joelthompson/gists{/gist_id}","starred_url":"https://api.github.com/users/joelthompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelthompson/subscriptions","organizations_url":"https://api.github.com/users/joelthompson/orgs","repos_url":"https://api.github.com/users/joelthompson/repos","events_url":"https://api.github.com/users/joelthompson/events{/privacy}","received_events_url":"https://api.github.com/users/joelthompson/received_events","type":"User","site_admin":false},"body":"You're configuring STS and IAM clients with the same endpoints, and I doubt that will work. They likely need different endpoints.","created_at":"2017-10-04T15:34:15Z","updated_at":"2017-10-04T15:34:59Z","html_url":"https://github.com/hashicorp/vault/pull/3416#discussion_r142707053","pull_request_url":"https://api.github.com/repos/hashicorp/vault/pulls/3416","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments/142707053"},"html":{"href":"https://github.com/hashicorp/vault/pull/3416#discussion_r142707053"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/3416"}}},"pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/3416","id":144621104,"html_url":"https://github.com/hashicorp/vault/pull/3416","diff_url":"https://github.com/hashicorp/vault/pull/3416.diff","patch_url":"https://github.com/hashicorp/vault/pull/3416.patch","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/3416","number":3416,"state":"open","locked":false,"title":"added AWS enpoint handling","user":{"login":"ror6ax","id":2385157,"avatar_url":"https://avatars2.githubusercontent.com/u/2385157?v=4","gravatar_id":"","url":"https://api.github.com/users/ror6ax","html_url":"https://github.com/ror6ax","followers_url":"https://api.github.com/users/ror6ax/followers","following_url":"https://api.github.com/users/ror6ax/following{/other_user}","gists_url":"https://api.github.com/users/ror6ax/gists{/gist_id}","starred_url":"https://api.github.com/users/ror6ax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ror6ax/subscriptions","organizations_url":"https://api.github.com/users/ror6ax/orgs","repos_url":"https://api.github.com/users/ror6ax/repos","events_url":"https://api.github.com/users/ror6ax/events{/privacy}","received_events_url":"https://api.github.com/users/ror6ax/received_events","type":"User","site_admin":false},"body":"In AWS, IAM endpoint(API you actually talk to get users) is determined by the region.\r\n\r\nThere is a number of AWS clones out there, like Eucalyptus. IAM works in very similar way, but endpoints are not standardized. The only way to make clones work with Vault is to provide optional endpoint parameter. \r\n","created_at":"2017-10-04T09:31:41Z","updated_at":"2017-10-04T15:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7be854ce52374401428ce0322a6787019eed87a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/vault/pulls/3416/commits","review_comments_url":"https://api.github.com/repos/hashicorp/vault/pulls/3416/comments","review_comment_url":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/3416/comments","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/57cf97db6a846b31cc2ff0b2858a02eb9a414405","head":{"label":"nokia:endpoint_patch","ref":"endpoint_patch","sha":"57cf97db6a846b31cc2ff0b2858a02eb9a414405","user":{"login":"nokia","id":341053,"avatar_url":"https://avatars1.githubusercontent.com/u/341053?v=4","gravatar_id":"","url":"https://api.github.com/users/nokia","html_url":"https://github.com/nokia","followers_url":"https://api.github.com/users/nokia/followers","following_url":"https://api.github.com/users/nokia/following{/other_user}","gists_url":"https://api.github.com/users/nokia/gists{/gist_id}","starred_url":"https://api.github.com/users/nokia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nokia/subscriptions","organizations_url":"https://api.github.com/users/nokia/orgs","repos_url":"https://api.github.com/users/nokia/repos","events_url":"https://api.github.com/users/nokia/events{/privacy}","received_events_url":"https://api.github.com/users/nokia/received_events","type":"Organization","site_admin":false},"repo":{"id":105746313,"name":"vault","full_name":"nokia/vault","owner":{"login":"nokia","id":341053,"avatar_url":"https://avatars1.githubusercontent.com/u/341053?v=4","gravatar_id":"","url":"https://api.github.com/users/nokia","html_url":"https://github.com/nokia","followers_url":"https://api.github.com/users/nokia/followers","following_url":"https://api.github.com/users/nokia/following{/other_user}","gists_url":"https://api.github.com/users/nokia/gists{/gist_id}","starred_url":"https://api.github.com/users/nokia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nokia/subscriptions","organizations_url":"https://api.github.com/users/nokia/orgs","repos_url":"https://api.github.com/users/nokia/repos","events_url":"https://api.github.com/users/nokia/events{/privacy}","received_events_url":"https://api.github.com/users/nokia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nokia/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":true,"url":"https://api.github.com/repos/nokia/vault","forks_url":"https://api.github.com/repos/nokia/vault/forks","keys_url":"https://api.github.com/repos/nokia/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nokia/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nokia/vault/teams","hooks_url":"https://api.github.com/repos/nokia/vault/hooks","issue_events_url":"https://api.github.com/repos/nokia/vault/issues/events{/number}","events_url":"https://api.github.com/repos/nokia/vault/events","assignees_url":"https://api.github.com/repos/nokia/vault/assignees{/user}","branches_url":"https://api.github.com/repos/nokia/vault/branches{/branch}","tags_url":"https://api.github.com/repos/nokia/vault/tags","blobs_url":"https://api.github.com/repos/nokia/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nokia/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nokia/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/nokia/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nokia/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/nokia/vault/languages","stargazers_url":"https://api.github.com/repos/nokia/vault/stargazers","contributors_url":"https://api.github.com/repos/nokia/vault/contributors","subscribers_url":"https://api.github.com/repos/nokia/vault/subscribers","subscription_url":"https://api.github.com/repos/nokia/vault/subscription","commits_url":"https://api.github.com/repos/nokia/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/nokia/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/nokia/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/nokia/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/nokia/vault/contents/{+path}","compare_url":"https://api.github.com/repos/nokia/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nokia/vault/merges","archive_url":"https://api.github.com/repos/nokia/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nokia/vault/downloads","issues_url":"https://api.github.com/repos/nokia/vault/issues{/number}","pulls_url":"https://api.github.com/repos/nokia/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/nokia/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/nokia/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nokia/vault/labels{/name}","releases_url":"https://api.github.com/repos/nokia/vault/releases{/id}","deployments_url":"https://api.github.com/repos/nokia/vault/deployments","created_at":"2017-10-04T08:27:04Z","updated_at":"2017-10-04T08:27:09Z","pushed_at":"2017-10-04T11:15:14Z","git_url":"git://github.com/nokia/vault.git","ssh_url":"git@github.com:nokia/vault.git","clone_url":"https://github.com/nokia/vault.git","svn_url":"https://github.com/nokia/vault","homepage":"https://www.vaultproject.io/","size":33252,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"5c4fb67fb8a97d2d10ff7dd6254f10fb100ec838","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2017-10-04T15:32:06Z","pushed_at":"2017-10-04T13:45:54Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":33277,"stargazers_count":7655,"watchers_count":7655,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1048,"mirror_url":null,"open_issues_count":326,"forks":1048,"open_issues":326,"watchers":7655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/3416"},"html":{"href":"https://github.com/hashicorp/vault/pull/3416"},"issue":{"href":"https://api.github.com/repos/hashicorp/vault/issues/3416"},"comments":{"href":"https://api.github.com/repos/hashicorp/vault/issues/3416/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/3416/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/3416/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/vault/statuses/57cf97db6a846b31cc2ff0b2858a02eb9a414405"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joelthompson"}}