{"action":"created","comment":{"url":"https://api.github.com/repos/c-cube/funarith/pulls/comments/158655814","pull_request_review_id":85497372,"id":158655814,"diff_hunk":"@@ -0,0 +1,167 @@\n+(*\n+  copyright (c) 2014-2018, Guillaume Bury, Simon Cruanes\n+  *)\n+\n+module type COEF = Expr_intf.COEF\n+\n+module type VAR = Expr_intf.VAR\n+module type FRESH = Expr_intf.FRESH\n+module type VAR_GEN = Expr_intf.VAR_GEN\n+\n+module Linear = struct","path":"src/Expr.ml","position":11,"original_position":11,"commit_id":"152adcd241fe3270e2906ff7340eb244c8dc7670","original_commit_id":"152adcd241fe3270e2906ff7340eb244c8dc7670","user":{"login":"Gbury","id":1477907,"avatar_url":"https://avatars2.githubusercontent.com/u/1477907?v=4","gravatar_id":"","url":"https://api.github.com/users/Gbury","html_url":"https://github.com/Gbury","followers_url":"https://api.github.com/users/Gbury/followers","following_url":"https://api.github.com/users/Gbury/following{/other_user}","gists_url":"https://api.github.com/users/Gbury/gists{/gist_id}","starred_url":"https://api.github.com/users/Gbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gbury/subscriptions","organizations_url":"https://api.github.com/users/Gbury/orgs","repos_url":"https://api.github.com/users/Gbury/repos","events_url":"https://api.github.com/users/Gbury/events{/privacy}","received_events_url":"https://api.github.com/users/Gbury/received_events","type":"User","site_admin":false},"body":"Eventually (in a long time probably), I expect some non-linear expressions, such as polynomials of arbitrary degree to be of interest ?","created_at":"2017-12-25T22:45:11Z","updated_at":"2017-12-25T22:45:11Z","html_url":"https://github.com/c-cube/funarith/pull/8#discussion_r158655814","pull_request_url":"https://api.github.com/repos/c-cube/funarith/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/c-cube/funarith/pulls/comments/158655814"},"html":{"href":"https://github.com/c-cube/funarith/pull/8#discussion_r158655814"},"pull_request":{"href":"https://api.github.com/repos/c-cube/funarith/pulls/8"}},"in_reply_to_id":158655621},"pull_request":{"url":"https://api.github.com/repos/c-cube/funarith/pulls/8","id":160069735,"html_url":"https://github.com/c-cube/funarith/pull/8","diff_url":"https://github.com/c-cube/funarith/pull/8.diff","patch_url":"https://github.com/c-cube/funarith/pull/8.patch","issue_url":"https://api.github.com/repos/c-cube/funarith/issues/8","number":8,"state":"open","locked":false,"title":"[WIP] Proper expressions","user":{"login":"Gbury","id":1477907,"avatar_url":"https://avatars2.githubusercontent.com/u/1477907?v=4","gravatar_id":"","url":"https://api.github.com/users/Gbury","html_url":"https://github.com/Gbury","followers_url":"https://api.github.com/users/Gbury/followers","following_url":"https://api.github.com/users/Gbury/following{/other_user}","gists_url":"https://api.github.com/users/Gbury/gists{/gist_id}","starred_url":"https://api.github.com/users/Gbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gbury/subscriptions","organizations_url":"https://api.github.com/users/Gbury/orgs","repos_url":"https://api.github.com/users/Gbury/repos","events_url":"https://api.github.com/users/Gbury/events{/privacy}","received_events_url":"https://api.github.com/users/Gbury/received_events","type":"User","site_admin":false},"body":"This is Work in Progress. This PR is mainly there to open discussion about the design.\r\n\r\n# Goal\r\nThe goal is to have expressions not tied to a specific algorithm. Indeed, arithmetic expressions, and particularly linear expressions, are pretty straight-forward to represent, and it seems a bit of a waste to have a different representation for each algorithm.\r\n\r\n# Implementation\r\nMost of the implementation has been extracted from the one that was in the `Simplex` module, wiht a few notable changes:\r\n- renamed expressions to linear combinations (i.e degree 1 polynomials with no constant term)\r\n- introduced linear expressions (i.e. exactly the polynomials of degree 1)\r\n- changed the constraint type to use expressions instead of linear combinations, and make it polymorphic in the comparison operators used.\r\n\r\nThe `Simplex.Make_full` functor was replaced to take as argument the linear expression module.\r\n\r\n# Current status\r\nThe `Expr` module compile, as well as the `Simplex` module. However, some changes are still needed to:\r\n- [ ] Adapt the `qcheck` generators to the new representation\r\n- [ ] Adapt the `Diophantine` module to use these expressions (and provide a high-level API similar to the one given for the simplex).\r\n- [ ] Add more operators for the constraints (such as divisibility, etc...)","created_at":"2017-12-25T22:20:16Z","updated_at":"2017-12-25T22:45:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdffe1d5d1e6596910b81e36fc36243cbae5c104","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/c-cube/funarith/pulls/8/commits","review_comments_url":"https://api.github.com/repos/c-cube/funarith/pulls/8/comments","review_comment_url":"https://api.github.com/repos/c-cube/funarith/pulls/comments{/number}","comments_url":"https://api.github.com/repos/c-cube/funarith/issues/8/comments","statuses_url":"https://api.github.com/repos/c-cube/funarith/statuses/152adcd241fe3270e2906ff7340eb244c8dc7670","head":{"label":"c-cube:expr","ref":"expr","sha":"152adcd241fe3270e2906ff7340eb244c8dc7670","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars0.githubusercontent.com/u/1274291?v=4","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"repo":{"id":114383539,"name":"funarith","full_name":"c-cube/funarith","owner":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars0.githubusercontent.com/u/1274291?v=4","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c-cube/funarith","description":"functorial library with classic algorithms for arithmetic","fork":false,"url":"https://api.github.com/repos/c-cube/funarith","forks_url":"https://api.github.com/repos/c-cube/funarith/forks","keys_url":"https://api.github.com/repos/c-cube/funarith/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c-cube/funarith/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c-cube/funarith/teams","hooks_url":"https://api.github.com/repos/c-cube/funarith/hooks","issue_events_url":"https://api.github.com/repos/c-cube/funarith/issues/events{/number}","events_url":"https://api.github.com/repos/c-cube/funarith/events","assignees_url":"https://api.github.com/repos/c-cube/funarith/assignees{/user}","branches_url":"https://api.github.com/repos/c-cube/funarith/branches{/branch}","tags_url":"https://api.github.com/repos/c-cube/funarith/tags","blobs_url":"https://api.github.com/repos/c-cube/funarith/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c-cube/funarith/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c-cube/funarith/git/refs{/sha}","trees_url":"https://api.github.com/repos/c-cube/funarith/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c-cube/funarith/statuses/{sha}","languages_url":"https://api.github.com/repos/c-cube/funarith/languages","stargazers_url":"https://api.github.com/repos/c-cube/funarith/stargazers","contributors_url":"https://api.github.com/repos/c-cube/funarith/contributors","subscribers_url":"https://api.github.com/repos/c-cube/funarith/subscribers","subscription_url":"https://api.github.com/repos/c-cube/funarith/subscription","commits_url":"https://api.github.com/repos/c-cube/funarith/commits{/sha}","git_commits_url":"https://api.github.com/repos/c-cube/funarith/git/commits{/sha}","comments_url":"https://api.github.com/repos/c-cube/funarith/comments{/number}","issue_comment_url":"https://api.github.com/repos/c-cube/funarith/issues/comments{/number}","contents_url":"https://api.github.com/repos/c-cube/funarith/contents/{+path}","compare_url":"https://api.github.com/repos/c-cube/funarith/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c-cube/funarith/merges","archive_url":"https://api.github.com/repos/c-cube/funarith/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c-cube/funarith/downloads","issues_url":"https://api.github.com/repos/c-cube/funarith/issues{/number}","pulls_url":"https://api.github.com/repos/c-cube/funarith/pulls{/number}","milestones_url":"https://api.github.com/repos/c-cube/funarith/milestones{/number}","notifications_url":"https://api.github.com/repos/c-cube/funarith/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c-cube/funarith/labels{/name}","releases_url":"https://api.github.com/repos/c-cube/funarith/releases{/id}","deployments_url":"https://api.github.com/repos/c-cube/funarith/deployments","created_at":"2017-12-15T15:16:33Z","updated_at":"2017-12-24T09:54:23Z","pushed_at":"2017-12-25T22:20:17Z","git_url":"git://github.com/c-cube/funarith.git","ssh_url":"git@github.com:c-cube/funarith.git","clone_url":"https://github.com/c-cube/funarith.git","svn_url":"https://github.com/c-cube/funarith","homepage":"https://c-cube.github.io/funarith/","size":143,"stargazers_count":8,"watchers_count":8,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"c-cube:master","ref":"master","sha":"0497017547c558ebf1e5997c1a5d3e5461e2f630","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars0.githubusercontent.com/u/1274291?v=4","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"repo":{"id":114383539,"name":"funarith","full_name":"c-cube/funarith","owner":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars0.githubusercontent.com/u/1274291?v=4","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c-cube/funarith","description":"functorial library with classic algorithms for arithmetic","fork":false,"url":"https://api.github.com/repos/c-cube/funarith","forks_url":"https://api.github.com/repos/c-cube/funarith/forks","keys_url":"https://api.github.com/repos/c-cube/funarith/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c-cube/funarith/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c-cube/funarith/teams","hooks_url":"https://api.github.com/repos/c-cube/funarith/hooks","issue_events_url":"https://api.github.com/repos/c-cube/funarith/issues/events{/number}","events_url":"https://api.github.com/repos/c-cube/funarith/events","assignees_url":"https://api.github.com/repos/c-cube/funarith/assignees{/user}","branches_url":"https://api.github.com/repos/c-cube/funarith/branches{/branch}","tags_url":"https://api.github.com/repos/c-cube/funarith/tags","blobs_url":"https://api.github.com/repos/c-cube/funarith/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c-cube/funarith/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c-cube/funarith/git/refs{/sha}","trees_url":"https://api.github.com/repos/c-cube/funarith/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c-cube/funarith/statuses/{sha}","languages_url":"https://api.github.com/repos/c-cube/funarith/languages","stargazers_url":"https://api.github.com/repos/c-cube/funarith/stargazers","contributors_url":"https://api.github.com/repos/c-cube/funarith/contributors","subscribers_url":"https://api.github.com/repos/c-cube/funarith/subscribers","subscription_url":"https://api.github.com/repos/c-cube/funarith/subscription","commits_url":"https://api.github.com/repos/c-cube/funarith/commits{/sha}","git_commits_url":"https://api.github.com/repos/c-cube/funarith/git/commits{/sha}","comments_url":"https://api.github.com/repos/c-cube/funarith/comments{/number}","issue_comment_url":"https://api.github.com/repos/c-cube/funarith/issues/comments{/number}","contents_url":"https://api.github.com/repos/c-cube/funarith/contents/{+path}","compare_url":"https://api.github.com/repos/c-cube/funarith/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c-cube/funarith/merges","archive_url":"https://api.github.com/repos/c-cube/funarith/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c-cube/funarith/downloads","issues_url":"https://api.github.com/repos/c-cube/funarith/issues{/number}","pulls_url":"https://api.github.com/repos/c-cube/funarith/pulls{/number}","milestones_url":"https://api.github.com/repos/c-cube/funarith/milestones{/number}","notifications_url":"https://api.github.com/repos/c-cube/funarith/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c-cube/funarith/labels{/name}","releases_url":"https://api.github.com/repos/c-cube/funarith/releases{/id}","deployments_url":"https://api.github.com/repos/c-cube/funarith/deployments","created_at":"2017-12-15T15:16:33Z","updated_at":"2017-12-24T09:54:23Z","pushed_at":"2017-12-25T22:20:17Z","git_url":"git://github.com/c-cube/funarith.git","ssh_url":"git@github.com:c-cube/funarith.git","clone_url":"https://github.com/c-cube/funarith.git","svn_url":"https://github.com/c-cube/funarith","homepage":"https://c-cube.github.io/funarith/","size":143,"stargazers_count":8,"watchers_count":8,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/c-cube/funarith/pulls/8"},"html":{"href":"https://github.com/c-cube/funarith/pull/8"},"issue":{"href":"https://api.github.com/repos/c-cube/funarith/issues/8"},"comments":{"href":"https://api.github.com/repos/c-cube/funarith/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/c-cube/funarith/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/c-cube/funarith/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/c-cube/funarith/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/c-cube/funarith/statuses/152adcd241fe3270e2906ff7340eb244c8dc7670"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Gbury"}}