{"action":"created","issue":{"url":"https://api.github.com/repos/php/php-src/issues/2910","repository_url":"https://api.github.com/repos/php/php-src","labels_url":"https://api.github.com/repos/php/php-src/issues/2910/labels{/name}","comments_url":"https://api.github.com/repos/php/php-src/issues/2910/comments","events_url":"https://api.github.com/repos/php/php-src/issues/2910/events","html_url":"https://github.com/php/php-src/pull/2910","id":272522022,"number":2910,"title":"Increase the PCRE JIT stack size","user":{"login":"khromov","id":1207507,"avatar_url":"https://avatars0.githubusercontent.com/u/1207507?v=4","gravatar_id":"","url":"https://api.github.com/users/khromov","html_url":"https://github.com/khromov","followers_url":"https://api.github.com/users/khromov/followers","following_url":"https://api.github.com/users/khromov/following{/other_user}","gists_url":"https://api.github.com/users/khromov/gists{/gist_id}","starred_url":"https://api.github.com/users/khromov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khromov/subscriptions","organizations_url":"https://api.github.com/users/khromov/orgs","repos_url":"https://api.github.com/users/khromov/repos","events_url":"https://api.github.com/users/khromov/events{/privacy}","received_events_url":"https://api.github.com/users/khromov/received_events","type":"User","site_admin":false},"labels":[{"id":148912334,"url":"https://api.github.com/repos/php/php-src/labels/Enhancement","name":"Enhancement","color":"bfe5bf","default":false},{"id":510750432,"url":"https://api.github.com/repos/php/php-src/labels/Waiting%20on%20Review","name":"Waiting on Review","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-09T10:57:53Z","updated_at":"2017-11-16T13:29:03Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/2910","html_url":"https://github.com/php/php-src/pull/2910","diff_url":"https://github.com/php/php-src/pull/2910.diff","patch_url":"https://github.com/php/php-src/pull/2910.patch"},"body":"Related issues:\r\nhttps://bugs.php.net/bug.php?id=70110\r\nhttps://bugs.exim.org/show_bug.cgi?id=1663\r\n\r\nFrom the PCRE docs:\r\n*A maximum stack size of 512K to 1M should be more than enough for any pattern.*\r\n\r\nhttps://www.pcre.org/original/doc/html/pcre_jit_stack_alloc.html\r\n\r\nThis also affects applications all over the web that fail by the strange behaviour that `preg_` calls return errors for valid expressions. Some highlights:\r\nhttps://www.drupal.org/node/2792877\r\n\r\nHeroku have defaulted `pcre.jit = 0`, presumably due to this issue. \r\nhttps://devcenter.heroku.com/changelog-items/853"},"comment":{"url":"https://api.github.com/repos/php/php-src/issues/comments/344922529","html_url":"https://github.com/php/php-src/pull/2910#issuecomment-344922529","issue_url":"https://api.github.com/repos/php/php-src/issues/2910","id":344922529,"user":{"login":"weltling","id":22016,"avatar_url":"https://avatars0.githubusercontent.com/u/22016?v=4","gravatar_id":"","url":"https://api.github.com/users/weltling","html_url":"https://github.com/weltling","followers_url":"https://api.github.com/users/weltling/followers","following_url":"https://api.github.com/users/weltling/following{/other_user}","gists_url":"https://api.github.com/users/weltling/gists{/gist_id}","starred_url":"https://api.github.com/users/weltling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weltling/subscriptions","organizations_url":"https://api.github.com/users/weltling/orgs","repos_url":"https://api.github.com/users/weltling/repos","events_url":"https://api.github.com/users/weltling/events{/privacy}","received_events_url":"https://api.github.com/users/weltling/received_events","type":"User","site_admin":false},"created_at":"2017-11-16T13:29:03Z","updated_at":"2017-11-16T13:29:03Z","author_association":"CONTRIBUTOR","body":"The pattern `preg_match('/(*NO_JIT)^(A{1,2}B)+$$/',str_repeat('AB',8192));` from #70110 crashes 5.6, 7.0 and so forth when JIT is disabled. Same with `preg_match('~(a)*~', str_repeat('a', 5431));` from there. The crash is not a JIT issue but a recursion one. I don't see how this bug matches JIT stack limit question.\r\n\r\n@khromov regarding the Drupal issue you've linked, were it possible you to post some short reproduce code as it doesn't seem clear from the ticket and that patch isn't merged in Drupal.\r\n\r\nThanks.\r\n"}}
{"actor":{"display_login":"weltling"}}