{"action":"created","comment":{"url":"https://api.github.com/repos/graalvm/truffleruby/pulls/comments/140827813","pull_request_review_id":64956226,"id":140827813,"diff_hunk":"@@ -2506,9 +2506,20 @@ public DynamicObject upcase(DynamicObject string,\n             }\n         }\n \n-        @TruffleBoundary\n-        private boolean singleByteUpcase(byte[] bytes, int s, int end) {\n-            return StringSupport.singleByteUpcase(bytes, s, end);\n+        private boolean singleByteUpcase(byte[] bytes) {\n+            boolean modify = false;\n+\n+            for (int i = 0; i < bytes.length; i++) {\n+                final byte b = bytes[i];\n+\n+                // Check if between 'a' - 'z'.\n+                if (b >= 0x61 && b <= 0x7a) {\n+                    bytes[i] ^= 0x20;","path":"src/main/java/org/truffleruby/core/string/StringNodes.java","position":null,"original_position":24,"commit_id":"597b0c8ba097f5ddb627e1e318019ee33886ed33","original_commit_id":"d3dd22102eb309e97978132cb588b450e7b1bdab","user":{"login":"nirvdrum","id":12584,"avatar_url":"https://avatars2.githubusercontent.com/u/12584?v=4","gravatar_id":"","url":"https://api.github.com/users/nirvdrum","html_url":"https://github.com/nirvdrum","followers_url":"https://api.github.com/users/nirvdrum/followers","following_url":"https://api.github.com/users/nirvdrum/following{/other_user}","gists_url":"https://api.github.com/users/nirvdrum/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvdrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvdrum/subscriptions","organizations_url":"https://api.github.com/users/nirvdrum/orgs","repos_url":"https://api.github.com/users/nirvdrum/repos","events_url":"https://api.github.com/users/nirvdrum/events{/privacy}","received_events_url":"https://api.github.com/users/nirvdrum/received_events","type":"User","site_admin":false},"body":"Bah. I used to have lower and upper bounds as passed variables and the `^` worked in both cases. I had to break them out for `swapcase`. I'll fix.","created_at":"2017-09-25T16:29:36Z","updated_at":"2017-09-25T16:29:36Z","html_url":"https://github.com/graalvm/truffleruby/pull/563#discussion_r140827813","pull_request_url":"https://api.github.com/repos/graalvm/truffleruby/pulls/563","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/graalvm/truffleruby/pulls/comments/140827813"},"html":{"href":"https://github.com/graalvm/truffleruby/pull/563#discussion_r140827813"},"pull_request":{"href":"https://api.github.com/repos/graalvm/truffleruby/pulls/563"}},"in_reply_to_id":140823806},"pull_request":{"url":"https://api.github.com/repos/graalvm/truffleruby/pulls/563","id":142923179,"html_url":"https://github.com/graalvm/truffleruby/pull/563","diff_url":"https://github.com/graalvm/truffleruby/pull/563.diff","patch_url":"https://github.com/graalvm/truffleruby/pull/563.patch","issue_url":"https://api.github.com/repos/graalvm/truffleruby/issues/563","number":563,"state":"open","locked":false,"title":"Simpler string casing methods","user":{"login":"nirvdrum","id":12584,"avatar_url":"https://avatars2.githubusercontent.com/u/12584?v=4","gravatar_id":"","url":"https://api.github.com/users/nirvdrum","html_url":"https://github.com/nirvdrum","followers_url":"https://api.github.com/users/nirvdrum/followers","following_url":"https://api.github.com/users/nirvdrum/following{/other_user}","gists_url":"https://api.github.com/users/nirvdrum/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvdrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvdrum/subscriptions","organizations_url":"https://api.github.com/users/nirvdrum/orgs","repos_url":"https://api.github.com/users/nirvdrum/repos","events_url":"https://api.github.com/users/nirvdrum/events{/privacy}","received_events_url":"https://api.github.com/users/nirvdrum/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-25T16:06:43Z","updated_at":"2017-09-25T16:29:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be1ba152b79b9746a40f034466037f357aa1b290","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chrisseaton","id":341094,"avatar_url":"https://avatars2.githubusercontent.com/u/341094?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisseaton","html_url":"https://github.com/chrisseaton","followers_url":"https://api.github.com/users/chrisseaton/followers","following_url":"https://api.github.com/users/chrisseaton/following{/other_user}","gists_url":"https://api.github.com/users/chrisseaton/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisseaton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisseaton/subscriptions","organizations_url":"https://api.github.com/users/chrisseaton/orgs","repos_url":"https://api.github.com/users/chrisseaton/repos","events_url":"https://api.github.com/users/chrisseaton/events{/privacy}","received_events_url":"https://api.github.com/users/chrisseaton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/graalvm/truffleruby/pulls/563/commits","review_comments_url":"https://api.github.com/repos/graalvm/truffleruby/pulls/563/comments","review_comment_url":"https://api.github.com/repos/graalvm/truffleruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graalvm/truffleruby/issues/563/comments","statuses_url":"https://api.github.com/repos/graalvm/truffleruby/statuses/597b0c8ba097f5ddb627e1e318019ee33886ed33","head":{"label":"graalvm:simpler-string-casing-methods","ref":"simpler-string-casing-methods","sha":"597b0c8ba097f5ddb627e1e318019ee33886ed33","user":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars3.githubusercontent.com/u/10176827?v=4","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"repo":{"id":51164398,"name":"truffleruby","full_name":"graalvm/truffleruby","owner":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars3.githubusercontent.com/u/10176827?v=4","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graalvm/truffleruby","description":"A high performance implementation of the Ruby programming language. Built on the GraalVM by Oracle Labs.","fork":false,"url":"https://api.github.com/repos/graalvm/truffleruby","forks_url":"https://api.github.com/repos/graalvm/truffleruby/forks","keys_url":"https://api.github.com/repos/graalvm/truffleruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graalvm/truffleruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graalvm/truffleruby/teams","hooks_url":"https://api.github.com/repos/graalvm/truffleruby/hooks","issue_events_url":"https://api.github.com/repos/graalvm/truffleruby/issues/events{/number}","events_url":"https://api.github.com/repos/graalvm/truffleruby/events","assignees_url":"https://api.github.com/repos/graalvm/truffleruby/assignees{/user}","branches_url":"https://api.github.com/repos/graalvm/truffleruby/branches{/branch}","tags_url":"https://api.github.com/repos/graalvm/truffleruby/tags","blobs_url":"https://api.github.com/repos/graalvm/truffleruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graalvm/truffleruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graalvm/truffleruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/graalvm/truffleruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graalvm/truffleruby/statuses/{sha}","languages_url":"https://api.github.com/repos/graalvm/truffleruby/languages","stargazers_url":"https://api.github.com/repos/graalvm/truffleruby/stargazers","contributors_url":"https://api.github.com/repos/graalvm/truffleruby/contributors","subscribers_url":"https://api.github.com/repos/graalvm/truffleruby/subscribers","subscription_url":"https://api.github.com/repos/graalvm/truffleruby/subscription","commits_url":"https://api.github.com/repos/graalvm/truffleruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/graalvm/truffleruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/graalvm/truffleruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/graalvm/truffleruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/graalvm/truffleruby/contents/{+path}","compare_url":"https://api.github.com/repos/graalvm/truffleruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graalvm/truffleruby/merges","archive_url":"https://api.github.com/repos/graalvm/truffleruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graalvm/truffleruby/downloads","issues_url":"https://api.github.com/repos/graalvm/truffleruby/issues{/number}","pulls_url":"https://api.github.com/repos/graalvm/truffleruby/pulls{/number}","milestones_url":"https://api.github.com/repos/graalvm/truffleruby/milestones{/number}","notifications_url":"https://api.github.com/repos/graalvm/truffleruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graalvm/truffleruby/labels{/name}","releases_url":"https://api.github.com/repos/graalvm/truffleruby/releases{/id}","deployments_url":"https://api.github.com/repos/graalvm/truffleruby/deployments","created_at":"2016-02-05T18:03:11Z","updated_at":"2017-09-24T14:18:30Z","pushed_at":"2017-09-25T16:06:44Z","git_url":"git://github.com/graalvm/truffleruby.git","ssh_url":"git@github.com:graalvm/truffleruby.git","clone_url":"https://github.com/graalvm/truffleruby.git","svn_url":"https://github.com/graalvm/truffleruby","homepage":"","size":221675,"stargazers_count":811,"watchers_count":811,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":18,"forks":34,"open_issues":18,"watchers":811,"default_branch":"master"}},"base":{"label":"graalvm:master","ref":"master","sha":"14b63e152f1b1c20317605a0834ffcf05472fa0c","user":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars3.githubusercontent.com/u/10176827?v=4","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"repo":{"id":51164398,"name":"truffleruby","full_name":"graalvm/truffleruby","owner":{"login":"graalvm","id":10176827,"avatar_url":"https://avatars3.githubusercontent.com/u/10176827?v=4","gravatar_id":"","url":"https://api.github.com/users/graalvm","html_url":"https://github.com/graalvm","followers_url":"https://api.github.com/users/graalvm/followers","following_url":"https://api.github.com/users/graalvm/following{/other_user}","gists_url":"https://api.github.com/users/graalvm/gists{/gist_id}","starred_url":"https://api.github.com/users/graalvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graalvm/subscriptions","organizations_url":"https://api.github.com/users/graalvm/orgs","repos_url":"https://api.github.com/users/graalvm/repos","events_url":"https://api.github.com/users/graalvm/events{/privacy}","received_events_url":"https://api.github.com/users/graalvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graalvm/truffleruby","description":"A high performance implementation of the Ruby programming language. Built on the GraalVM by Oracle Labs.","fork":false,"url":"https://api.github.com/repos/graalvm/truffleruby","forks_url":"https://api.github.com/repos/graalvm/truffleruby/forks","keys_url":"https://api.github.com/repos/graalvm/truffleruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graalvm/truffleruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graalvm/truffleruby/teams","hooks_url":"https://api.github.com/repos/graalvm/truffleruby/hooks","issue_events_url":"https://api.github.com/repos/graalvm/truffleruby/issues/events{/number}","events_url":"https://api.github.com/repos/graalvm/truffleruby/events","assignees_url":"https://api.github.com/repos/graalvm/truffleruby/assignees{/user}","branches_url":"https://api.github.com/repos/graalvm/truffleruby/branches{/branch}","tags_url":"https://api.github.com/repos/graalvm/truffleruby/tags","blobs_url":"https://api.github.com/repos/graalvm/truffleruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graalvm/truffleruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graalvm/truffleruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/graalvm/truffleruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graalvm/truffleruby/statuses/{sha}","languages_url":"https://api.github.com/repos/graalvm/truffleruby/languages","stargazers_url":"https://api.github.com/repos/graalvm/truffleruby/stargazers","contributors_url":"https://api.github.com/repos/graalvm/truffleruby/contributors","subscribers_url":"https://api.github.com/repos/graalvm/truffleruby/subscribers","subscription_url":"https://api.github.com/repos/graalvm/truffleruby/subscription","commits_url":"https://api.github.com/repos/graalvm/truffleruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/graalvm/truffleruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/graalvm/truffleruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/graalvm/truffleruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/graalvm/truffleruby/contents/{+path}","compare_url":"https://api.github.com/repos/graalvm/truffleruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graalvm/truffleruby/merges","archive_url":"https://api.github.com/repos/graalvm/truffleruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graalvm/truffleruby/downloads","issues_url":"https://api.github.com/repos/graalvm/truffleruby/issues{/number}","pulls_url":"https://api.github.com/repos/graalvm/truffleruby/pulls{/number}","milestones_url":"https://api.github.com/repos/graalvm/truffleruby/milestones{/number}","notifications_url":"https://api.github.com/repos/graalvm/truffleruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graalvm/truffleruby/labels{/name}","releases_url":"https://api.github.com/repos/graalvm/truffleruby/releases{/id}","deployments_url":"https://api.github.com/repos/graalvm/truffleruby/deployments","created_at":"2016-02-05T18:03:11Z","updated_at":"2017-09-24T14:18:30Z","pushed_at":"2017-09-25T16:06:44Z","git_url":"git://github.com/graalvm/truffleruby.git","ssh_url":"git@github.com:graalvm/truffleruby.git","clone_url":"https://github.com/graalvm/truffleruby.git","svn_url":"https://github.com/graalvm/truffleruby","homepage":"","size":221675,"stargazers_count":811,"watchers_count":811,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":18,"forks":34,"open_issues":18,"watchers":811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graalvm/truffleruby/pulls/563"},"html":{"href":"https://github.com/graalvm/truffleruby/pull/563"},"issue":{"href":"https://api.github.com/repos/graalvm/truffleruby/issues/563"},"comments":{"href":"https://api.github.com/repos/graalvm/truffleruby/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/graalvm/truffleruby/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/graalvm/truffleruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graalvm/truffleruby/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/graalvm/truffleruby/statuses/597b0c8ba097f5ddb627e1e318019ee33886ed33"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nirvdrum"}}