{"action":"created","comment":{"url":"https://api.github.com/repos/ros/catkin/pulls/comments/127781182","pull_request_review_id":50399320,"id":127781182,"diff_hunk":"@@ -0,0 +1,55 @@\n+#\n+# Append key[=value] elements from one list to another list if they are not already in the target list.","path":"cmake/list_insert_options.cmake","position":2,"original_position":2,"commit_id":"77485d76f7e553b935912f488695cea8f07ee343","original_commit_id":"77485d76f7e553b935912f488695cea8f07ee343","user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars1.githubusercontent.com/u/1335366?v=4","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"body":"If the same key is being inserted multiple time with different values shouldn't the last one be used (instead of the first one)?","created_at":"2017-07-17T18:09:29Z","updated_at":"2017-07-17T18:14:39Z","html_url":"https://github.com/ros/catkin/pull/844#discussion_r127781182","pull_request_url":"https://api.github.com/repos/ros/catkin/pulls/844","_links":{"self":{"href":"https://api.github.com/repos/ros/catkin/pulls/comments/127781182"},"html":{"href":"https://github.com/ros/catkin/pull/844#discussion_r127781182"},"pull_request":{"href":"https://api.github.com/repos/ros/catkin/pulls/844"}}},"pull_request":{"url":"https://api.github.com/repos/ros/catkin/pulls/844","id":100587697,"html_url":"https://github.com/ros/catkin/pull/844","diff_url":"https://github.com/ros/catkin/pull/844.diff","patch_url":"https://github.com/ros/catkin/pull/844.patch","issue_url":"https://api.github.com/repos/ros/catkin/issues/844","number":844,"state":"open","locked":false,"title":"Added support for compile options","user":{"login":"ipa-mdl","id":727227,"avatar_url":"https://avatars3.githubusercontent.com/u/727227?v=4","gravatar_id":"","url":"https://api.github.com/users/ipa-mdl","html_url":"https://github.com/ipa-mdl","followers_url":"https://api.github.com/users/ipa-mdl/followers","following_url":"https://api.github.com/users/ipa-mdl/following{/other_user}","gists_url":"https://api.github.com/users/ipa-mdl/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-mdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-mdl/subscriptions","organizations_url":"https://api.github.com/users/ipa-mdl/orgs","repos_url":"https://api.github.com/users/ipa-mdl/repos","events_url":"https://api.github.com/users/ipa-mdl/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-mdl/received_events","type":"User","site_admin":false},"body":"After the discussions in #610 I have now refactored and improved #842 \r\n\r\n* introduces `<comp>_COMPILE_OPTIONS` and  `catkin_COMPILE_OPTIONS`\r\n* all entries get set-filtered (stable) with warnings for colliding entries ( `key` vs. `key=` vs. `key=val1` vs. `key=val2`) \r\n* `<comp>_COMPILE_OPTIONS` will be passed to CMake config in `catkin_package`\r\n* added `COMPILE_OPTIONS` option to `catkin_package`\r\n\r\nI made the decision to switch to compile options completely for the following reasons:\r\n* `add_compile_options` can handle all `*_DEFINITIONS` settings\r\n* users would need to call `add_compile_options` and `add_definitions`\r\n* duplicates and collisions would have to be checked in compile options and definitions\r\n\r\nOpen issues:\r\n* How to properly add `test/test_list_append_keys_from.cmake` to catkin tests? It prints CMake warnings..\r\n* ~~Not sure if the `DEFINES` option is really needed. In most cases `<comp>_COMPILE_OPTIONS` might be more reasonable, since it can be passed to the exporting package easily (see `set_compile_options` example package)~~\r\n* documentation is not complete","created_at":"2017-01-08T00:43:41Z","updated_at":"2017-07-17T18:14:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3ef57ddbfa0f7320896c283f1ef2cc1ddbd9358","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros/catkin/pulls/844/commits","review_comments_url":"https://api.github.com/repos/ros/catkin/pulls/844/comments","review_comment_url":"https://api.github.com/repos/ros/catkin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/catkin/issues/844/comments","statuses_url":"https://api.github.com/repos/ros/catkin/statuses/77485d76f7e553b935912f488695cea8f07ee343","head":{"label":"ipa-mdl:compile-options","ref":"compile-options","sha":"77485d76f7e553b935912f488695cea8f07ee343","user":{"login":"ipa-mdl","id":727227,"avatar_url":"https://avatars3.githubusercontent.com/u/727227?v=4","gravatar_id":"","url":"https://api.github.com/users/ipa-mdl","html_url":"https://github.com/ipa-mdl","followers_url":"https://api.github.com/users/ipa-mdl/followers","following_url":"https://api.github.com/users/ipa-mdl/following{/other_user}","gists_url":"https://api.github.com/users/ipa-mdl/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-mdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-mdl/subscriptions","organizations_url":"https://api.github.com/users/ipa-mdl/orgs","repos_url":"https://api.github.com/users/ipa-mdl/repos","events_url":"https://api.github.com/users/ipa-mdl/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-mdl/received_events","type":"User","site_admin":false},"repo":{"id":77920990,"name":"catkin","full_name":"ipa-mdl/catkin","owner":{"login":"ipa-mdl","id":727227,"avatar_url":"https://avatars3.githubusercontent.com/u/727227?v=4","gravatar_id":"","url":"https://api.github.com/users/ipa-mdl","html_url":"https://github.com/ipa-mdl","followers_url":"https://api.github.com/users/ipa-mdl/followers","following_url":"https://api.github.com/users/ipa-mdl/following{/other_user}","gists_url":"https://api.github.com/users/ipa-mdl/gists{/gist_id}","starred_url":"https://api.github.com/users/ipa-mdl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipa-mdl/subscriptions","organizations_url":"https://api.github.com/users/ipa-mdl/orgs","repos_url":"https://api.github.com/users/ipa-mdl/repos","events_url":"https://api.github.com/users/ipa-mdl/events{/privacy}","received_events_url":"https://api.github.com/users/ipa-mdl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ipa-mdl/catkin","description":"A CMake-based build system that is used to build all packages in ROS.","fork":true,"url":"https://api.github.com/repos/ipa-mdl/catkin","forks_url":"https://api.github.com/repos/ipa-mdl/catkin/forks","keys_url":"https://api.github.com/repos/ipa-mdl/catkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipa-mdl/catkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipa-mdl/catkin/teams","hooks_url":"https://api.github.com/repos/ipa-mdl/catkin/hooks","issue_events_url":"https://api.github.com/repos/ipa-mdl/catkin/issues/events{/number}","events_url":"https://api.github.com/repos/ipa-mdl/catkin/events","assignees_url":"https://api.github.com/repos/ipa-mdl/catkin/assignees{/user}","branches_url":"https://api.github.com/repos/ipa-mdl/catkin/branches{/branch}","tags_url":"https://api.github.com/repos/ipa-mdl/catkin/tags","blobs_url":"https://api.github.com/repos/ipa-mdl/catkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipa-mdl/catkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipa-mdl/catkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipa-mdl/catkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipa-mdl/catkin/statuses/{sha}","languages_url":"https://api.github.com/repos/ipa-mdl/catkin/languages","stargazers_url":"https://api.github.com/repos/ipa-mdl/catkin/stargazers","contributors_url":"https://api.github.com/repos/ipa-mdl/catkin/contributors","subscribers_url":"https://api.github.com/repos/ipa-mdl/catkin/subscribers","subscription_url":"https://api.github.com/repos/ipa-mdl/catkin/subscription","commits_url":"https://api.github.com/repos/ipa-mdl/catkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipa-mdl/catkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipa-mdl/catkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipa-mdl/catkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipa-mdl/catkin/contents/{+path}","compare_url":"https://api.github.com/repos/ipa-mdl/catkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipa-mdl/catkin/merges","archive_url":"https://api.github.com/repos/ipa-mdl/catkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipa-mdl/catkin/downloads","issues_url":"https://api.github.com/repos/ipa-mdl/catkin/issues{/number}","pulls_url":"https://api.github.com/repos/ipa-mdl/catkin/pulls{/number}","milestones_url":"https://api.github.com/repos/ipa-mdl/catkin/milestones{/number}","notifications_url":"https://api.github.com/repos/ipa-mdl/catkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipa-mdl/catkin/labels{/name}","releases_url":"https://api.github.com/repos/ipa-mdl/catkin/releases{/id}","deployments_url":"https://api.github.com/repos/ipa-mdl/catkin/deployments","created_at":"2017-01-03T13:48:01Z","updated_at":"2017-01-03T13:48:05Z","pushed_at":"2017-07-17T18:06:45Z","git_url":"git://github.com/ipa-mdl/catkin.git","ssh_url":"git@github.com:ipa-mdl/catkin.git","clone_url":"https://github.com/ipa-mdl/catkin.git","svn_url":"https://github.com/ipa-mdl/catkin","homepage":"http://wiki.ros.org/catkin","size":3401,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"kinetic-devel"}},"base":{"label":"ros:kinetic-devel","ref":"kinetic-devel","sha":"f9cad28fb34bb6a270703753bcd47e9150e57035","user":{"login":"ros","id":547448,"avatar_url":"https://avatars2.githubusercontent.com/u/547448?v=4","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":2729788,"name":"catkin","full_name":"ros/catkin","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars2.githubusercontent.com/u/547448?v=4","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/catkin","description":"A CMake-based build system that is used to build all packages in ROS.","fork":false,"url":"https://api.github.com/repos/ros/catkin","forks_url":"https://api.github.com/repos/ros/catkin/forks","keys_url":"https://api.github.com/repos/ros/catkin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/catkin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/catkin/teams","hooks_url":"https://api.github.com/repos/ros/catkin/hooks","issue_events_url":"https://api.github.com/repos/ros/catkin/issues/events{/number}","events_url":"https://api.github.com/repos/ros/catkin/events","assignees_url":"https://api.github.com/repos/ros/catkin/assignees{/user}","branches_url":"https://api.github.com/repos/ros/catkin/branches{/branch}","tags_url":"https://api.github.com/repos/ros/catkin/tags","blobs_url":"https://api.github.com/repos/ros/catkin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/catkin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/catkin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/catkin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/catkin/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/catkin/languages","stargazers_url":"https://api.github.com/repos/ros/catkin/stargazers","contributors_url":"https://api.github.com/repos/ros/catkin/contributors","subscribers_url":"https://api.github.com/repos/ros/catkin/subscribers","subscription_url":"https://api.github.com/repos/ros/catkin/subscription","commits_url":"https://api.github.com/repos/ros/catkin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/catkin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/catkin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/catkin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/catkin/contents/{+path}","compare_url":"https://api.github.com/repos/ros/catkin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/catkin/merges","archive_url":"https://api.github.com/repos/ros/catkin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/catkin/downloads","issues_url":"https://api.github.com/repos/ros/catkin/issues{/number}","pulls_url":"https://api.github.com/repos/ros/catkin/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/catkin/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/catkin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/catkin/labels{/name}","releases_url":"https://api.github.com/repos/ros/catkin/releases{/id}","deployments_url":"https://api.github.com/repos/ros/catkin/deployments","created_at":"2011-11-07T22:19:26Z","updated_at":"2017-07-07T15:36:27Z","pushed_at":"2017-07-17T18:06:46Z","git_url":"git://github.com/ros/catkin.git","ssh_url":"git@github.com:ros/catkin.git","clone_url":"https://github.com/ros/catkin.git","svn_url":"https://github.com/ros/catkin","homepage":"http://wiki.ros.org/catkin","size":3413,"stargazers_count":101,"watchers_count":101,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":130,"mirror_url":null,"open_issues_count":41,"forks":130,"open_issues":41,"watchers":101,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/catkin/pulls/844"},"html":{"href":"https://github.com/ros/catkin/pull/844"},"issue":{"href":"https://api.github.com/repos/ros/catkin/issues/844"},"comments":{"href":"https://api.github.com/repos/ros/catkin/issues/844/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/catkin/pulls/844/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/catkin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/catkin/pulls/844/commits"},"statuses":{"href":"https://api.github.com/repos/ros/catkin/statuses/77485d76f7e553b935912f488695cea8f07ee343"}}}}
{"actor":{"display_login":"dirk-thomas"}}