{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-server/issues/5619","repository_url":"https://api.github.com/repos/mozilla/addons-server","labels_url":"https://api.github.com/repos/mozilla/addons-server/issues/5619/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-server/issues/5619/comments","events_url":"https://api.github.com/repos/mozilla/addons-server/issues/5619/events","html_url":"https://github.com/mozilla/addons-server/issues/5619","id":234932512,"number":5619,"title":"Don't sign Mozilla Signed Extensions","user":{"login":"jvillalobos","id":62568,"avatar_url":"https://avatars6.githubusercontent.com/u/62568?v=4","gravatar_id":"","url":"https://api.github.com/users/jvillalobos","html_url":"https://github.com/jvillalobos","followers_url":"https://api.github.com/users/jvillalobos/followers","following_url":"https://api.github.com/users/jvillalobos/following{/other_user}","gists_url":"https://api.github.com/users/jvillalobos/gists{/gist_id}","starred_url":"https://api.github.com/users/jvillalobos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvillalobos/subscriptions","organizations_url":"https://api.github.com/users/jvillalobos/orgs","repos_url":"https://api.github.com/users/jvillalobos/repos","events_url":"https://api.github.com/users/jvillalobos/events{/privacy}","received_events_url":"https://api.github.com/users/jvillalobos/received_events","type":"User","site_admin":false},"labels":[{"id":260731116,"url":"https://api.github.com/repos/mozilla/addons-server/labels/state:%20pull%20request%20ready","name":"state: pull request ready","color":"fbca04","default":false},{"id":540035677,"url":"https://api.github.com/repos/mozilla/addons-server/labels/triaged","name":"triaged","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"eviljeff","id":768592,"avatar_url":"https://avatars6.githubusercontent.com/u/768592?v=4","gravatar_id":"","url":"https://api.github.com/users/eviljeff","html_url":"https://github.com/eviljeff","followers_url":"https://api.github.com/users/eviljeff/followers","following_url":"https://api.github.com/users/eviljeff/following{/other_user}","gists_url":"https://api.github.com/users/eviljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eviljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviljeff/subscriptions","organizations_url":"https://api.github.com/users/eviljeff/orgs","repos_url":"https://api.github.com/users/eviljeff/repos","events_url":"https://api.github.com/users/eviljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eviljeff/received_events","type":"User","site_admin":false},"assignees":[{"login":"eviljeff","id":768592,"avatar_url":"https://avatars6.githubusercontent.com/u/768592?v=4","gravatar_id":"","url":"https://api.github.com/users/eviljeff","html_url":"https://github.com/eviljeff","followers_url":"https://api.github.com/users/eviljeff/followers","following_url":"https://api.github.com/users/eviljeff/following{/other_user}","gists_url":"https://api.github.com/users/eviljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eviljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviljeff/subscriptions","organizations_url":"https://api.github.com/users/eviljeff/orgs","repos_url":"https://api.github.com/users/eviljeff/repos","events_url":"https://api.github.com/users/eviljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eviljeff/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mozilla/addons-server/milestones/68","html_url":"https://github.com/mozilla/addons-server/milestone/68","labels_url":"https://api.github.com/repos/mozilla/addons-server/milestones/68/labels","id":2577705,"number":68,"title":"2017.07.20","description":"","creator":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars1.githubusercontent.com/u/1514?v=4","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":6,"state":"open","created_at":"2017-06-12T13:06:14Z","updated_at":"2017-07-13T21:36:01Z","due_on":"2017-07-18T07:00:00Z","closed_at":null},"comments":11,"created_at":"2017-06-09T20:35:20Z","updated_at":"2017-07-14T08:54:36Z","closed_at":"2017-07-13T18:08:23Z","body":"[Mozilla Signed Extensions](https://wiki.mozilla.org/Add-ons/InternalSigning) are internal add-ons that will be signed using a different signature than the one used on AMO. While generally they won't be distributed on AMO, some people have shown interest in doing so because of the facilities AMO provides (auto-updates and statistics, mainly).\r\n\r\nIf one of these extensions is submitted, we should do two things:\r\n\r\n1) Don't allow submission unless the owner has a Mozilla email address (#4688 is similar, but it's only based on the add-on ID). \r\n2) Once the add-on passes all checks, it shouldn't be signed again. We did a similar thing for the Hotfix add-on, but I don't know if we made the exception by ID or by the detected signature. The latter would be ideal for this new kind of add-on.\r\n\r\n@andymckay: what would be look for in the signature to identify these add-ons?"},"comment":{"url":"https://api.github.com/repos/mozilla/addons-server/issues/comments/315308197","html_url":"https://github.com/mozilla/addons-server/issues/5619#issuecomment-315308197","issue_url":"https://api.github.com/repos/mozilla/addons-server/issues/5619","id":315308197,"user":{"login":"eviljeff","id":768592,"avatar_url":"https://avatars6.githubusercontent.com/u/768592?v=4","gravatar_id":"","url":"https://api.github.com/users/eviljeff","html_url":"https://github.com/eviljeff","followers_url":"https://api.github.com/users/eviljeff/followers","following_url":"https://api.github.com/users/eviljeff/following{/other_user}","gists_url":"https://api.github.com/users/eviljeff/gists{/gist_id}","starred_url":"https://api.github.com/users/eviljeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eviljeff/subscriptions","organizations_url":"https://api.github.com/users/eviljeff/orgs","repos_url":"https://api.github.com/users/eviljeff/repos","events_url":"https://api.github.com/users/eviljeff/events{/privacy}","received_events_url":"https://api.github.com/users/eviljeff/received_events","type":"User","site_admin":false},"created_at":"2017-07-14T08:54:36Z","updated_at":"2017-07-14T08:54:36Z","body":"That's the first part checked, so is probably enough.  To fully test you need to get past that to confirm that the file _isn't_ re-signed*, but it's limited to users logging in with a `@mozilla.com` email address though.\r\n\r\n* the UI hasn't been changed so the site still tells you the add-on will be signed in various places."}}
{"actor":{"display_login":"eviljeff"}}