{"action":"created","issue":{"url":"https://api.github.com/repos/terminal42/contao-ce-access/issues/8","repository_url":"https://api.github.com/repos/terminal42/contao-ce-access","labels_url":"https://api.github.com/repos/terminal42/contao-ce-access/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/terminal42/contao-ce-access/issues/8/comments","events_url":"https://api.github.com/repos/terminal42/contao-ce-access/issues/8/events","html_url":"https://github.com/terminal42/contao-ce-access/pull/8","id":248244256,"number":8,"title":"Loosen type check on parameter act","user":{"login":"martinschumann","id":13613966,"avatar_url":"https://avatars3.githubusercontent.com/u/13613966?v=4","gravatar_id":"","url":"https://api.github.com/users/martinschumann","html_url":"https://github.com/martinschumann","followers_url":"https://api.github.com/users/martinschumann/followers","following_url":"https://api.github.com/users/martinschumann/following{/other_user}","gists_url":"https://api.github.com/users/martinschumann/gists{/gist_id}","starred_url":"https://api.github.com/users/martinschumann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinschumann/subscriptions","organizations_url":"https://api.github.com/users/martinschumann/orgs","repos_url":"https://api.github.com/users/martinschumann/repos","events_url":"https://api.github.com/users/martinschumann/events{/privacy}","received_events_url":"https://api.github.com/users/martinschumann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-08-06T12:27:33Z","updated_at":"2017-08-10T14:55:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/terminal42/contao-ce-access/pulls/8","html_url":"https://github.com/terminal42/contao-ce-access/pull/8","diff_url":"https://github.com/terminal42/contao-ce-access/pull/8.diff","patch_url":"https://github.com/terminal42/contao-ce-access/pull/8.patch"},"body":"Hi Andreas!\r\n\r\nHighly appreciating an heavily using ce-access we ran into this:\r\n\r\nAccess to an article in some cases is denied by mistake and redirects to error message caused by strict comparison on parameter `'act'`.  \r\n\r\nSpecifically:\r\n- if `tl_content` contains a record with the same ID as the article to be listed with its content elements and \r\n- current user is not allowed to edit the specific type of this unconnected content element.\r\n\r\nThis happens since param `'act'` is now validated in a negated strict comparison and the following filtering block and final redirect exit will be applied when listing the content elements of an article (`'act' == NULL`, and therefore not a `string`). For this request `$dc->id` contains the ID of an article and must not be compared to IDs of table `tl_content`.\r\n\r\nSince `Input::get` always returns either `string` or `NULL` I would propose to discard strict comparison later on as well.\r\n\r\nRegards\r\nMartin"},"comment":{"url":"https://api.github.com/repos/terminal42/contao-ce-access/issues/comments/321576044","html_url":"https://github.com/terminal42/contao-ce-access/pull/8#issuecomment-321576044","issue_url":"https://api.github.com/repos/terminal42/contao-ce-access/issues/8","id":321576044,"user":{"login":"aschempp","id":1073273,"avatar_url":"https://avatars0.githubusercontent.com/u/1073273?v=4","gravatar_id":"","url":"https://api.github.com/users/aschempp","html_url":"https://github.com/aschempp","followers_url":"https://api.github.com/users/aschempp/followers","following_url":"https://api.github.com/users/aschempp/following{/other_user}","gists_url":"https://api.github.com/users/aschempp/gists{/gist_id}","starred_url":"https://api.github.com/users/aschempp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschempp/subscriptions","organizations_url":"https://api.github.com/users/aschempp/orgs","repos_url":"https://api.github.com/users/aschempp/repos","events_url":"https://api.github.com/users/aschempp/events{/privacy}","received_events_url":"https://api.github.com/users/aschempp/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T14:55:03Z","updated_at":"2017-08-10T14:55:03Z","body":"Why don't you just do a `(string) \\Input::get('act') !== ''` ? 😂 "}}
{"actor":{"display_login":"aschempp"}}