{"action":"created","comment":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/comments/106025884","pull_request_review_id":26930819,"id":106025884,"diff_hunk":"@@ -26,11 +26,13 @@\n \n <div class=\"col-sm-9\">\n \n-  <% if @node && @node.path\n-    url = { :controller => \"wiki\", :action => \"update\", :id => @node.id }\n-  else \n-    url = { :controller => \"wiki\", :action => \"create\", :id => params[:id] }\n-   end %>\n+  <%\n+    if @node.persisted?","path":"app/views/wiki/edit.html.erb","position":10,"original_position":10,"commit_id":"87f09e251d976035f02349b35b67ffd3057e1bb1","original_commit_id":"87f09e251d976035f02349b35b67ffd3057e1bb1","user":{"login":"jywarren","id":24359,"avatar_url":"https://avatars2.githubusercontent.com/u/24359?v=3","gravatar_id":"","url":"https://api.github.com/users/jywarren","html_url":"https://github.com/jywarren","followers_url":"https://api.github.com/users/jywarren/followers","following_url":"https://api.github.com/users/jywarren/following{/other_user}","gists_url":"https://api.github.com/users/jywarren/gists{/gist_id}","starred_url":"https://api.github.com/users/jywarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jywarren/subscriptions","organizations_url":"https://api.github.com/users/jywarren/orgs","repos_url":"https://api.github.com/users/jywarren/repos","events_url":"https://api.github.com/users/jywarren/events{/privacy}","received_events_url":"https://api.github.com/users/jywarren/received_events","type":"User","site_admin":false},"body":"Here, we may still want to check that `@node` exists before calling a sub-method. This can occasionally cause page failures as a pattern, though I'm not sure it would in this case? I do so by habit these days. ","created_at":"2017-03-14T21:00:38Z","updated_at":"2017-03-14T21:00:38Z","html_url":"https://github.com/publiclab/plots2/pull/1338#discussion_r106025884","pull_request_url":"https://api.github.com/repos/publiclab/plots2/pulls/1338","_links":{"self":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/comments/106025884"},"html":{"href":"https://github.com/publiclab/plots2/pull/1338#discussion_r106025884"},"pull_request":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/1338"}}},"pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/1338","id":110703771,"html_url":"https://github.com/publiclab/plots2/pull/1338","diff_url":"https://github.com/publiclab/plots2/pull/1338.diff","patch_url":"https://github.com/publiclab/plots2/pull/1338.patch","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/1338","number":1338,"state":"open","locked":false,"title":"Fixes #1333","user":{"login":"amiedes","id":9287468,"avatar_url":"https://avatars2.githubusercontent.com/u/9287468?v=3","gravatar_id":"","url":"https://api.github.com/users/amiedes","html_url":"https://github.com/amiedes","followers_url":"https://api.github.com/users/amiedes/followers","following_url":"https://api.github.com/users/amiedes/following{/other_user}","gists_url":"https://api.github.com/users/amiedes/gists{/gist_id}","starred_url":"https://api.github.com/users/amiedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiedes/subscriptions","organizations_url":"https://api.github.com/users/amiedes/orgs","repos_url":"https://api.github.com/users/amiedes/repos","events_url":"https://api.github.com/users/amiedes/events{/privacy}","received_events_url":"https://api.github.com/users/amiedes/received_events","type":"User","site_admin":false},"body":"This PR fixes #1333 \r\n\r\nMake sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!\r\n\r\n* [x] all tests pass -- `rake test:all`\r\n* [x] code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)\r\n* [x] pull request is descriptively named with #number reference back to original issue\r\n\r\nPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software\r\n\r\nWe have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.\r\n\r\nThanks!\r\n","created_at":"2017-03-14T19:52:18Z","updated_at":"2017-03-14T21:00:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"905b09026c7b6260093672898e2164278d5cb786","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/publiclab/plots2/pulls/1338/commits","review_comments_url":"https://api.github.com/repos/publiclab/plots2/pulls/1338/comments","review_comment_url":"https://api.github.com/repos/publiclab/plots2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/1338/comments","statuses_url":"https://api.github.com/repos/publiclab/plots2/statuses/87f09e251d976035f02349b35b67ffd3057e1bb1","head":{"label":"amiedes:issue-1333","ref":"issue-1333","sha":"87f09e251d976035f02349b35b67ffd3057e1bb1","user":{"login":"amiedes","id":9287468,"avatar_url":"https://avatars2.githubusercontent.com/u/9287468?v=3","gravatar_id":"","url":"https://api.github.com/users/amiedes","html_url":"https://github.com/amiedes","followers_url":"https://api.github.com/users/amiedes/followers","following_url":"https://api.github.com/users/amiedes/following{/other_user}","gists_url":"https://api.github.com/users/amiedes/gists{/gist_id}","starred_url":"https://api.github.com/users/amiedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiedes/subscriptions","organizations_url":"https://api.github.com/users/amiedes/orgs","repos_url":"https://api.github.com/users/amiedes/repos","events_url":"https://api.github.com/users/amiedes/events{/privacy}","received_events_url":"https://api.github.com/users/amiedes/received_events","type":"User","site_admin":false},"repo":{"id":84817016,"name":"plots2","full_name":"amiedes/plots2","owner":{"login":"amiedes","id":9287468,"avatar_url":"https://avatars2.githubusercontent.com/u/9287468?v=3","gravatar_id":"","url":"https://api.github.com/users/amiedes","html_url":"https://github.com/amiedes","followers_url":"https://api.github.com/users/amiedes/followers","following_url":"https://api.github.com/users/amiedes/following{/other_user}","gists_url":"https://api.github.com/users/amiedes/gists{/gist_id}","starred_url":"https://api.github.com/users/amiedes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiedes/subscriptions","organizations_url":"https://api.github.com/users/amiedes/orgs","repos_url":"https://api.github.com/users/amiedes/repos","events_url":"https://api.github.com/users/amiedes/events{/privacy}","received_events_url":"https://api.github.com/users/amiedes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amiedes/plots2","description":"PublicLab.org - a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:","fork":true,"url":"https://api.github.com/repos/amiedes/plots2","forks_url":"https://api.github.com/repos/amiedes/plots2/forks","keys_url":"https://api.github.com/repos/amiedes/plots2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amiedes/plots2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amiedes/plots2/teams","hooks_url":"https://api.github.com/repos/amiedes/plots2/hooks","issue_events_url":"https://api.github.com/repos/amiedes/plots2/issues/events{/number}","events_url":"https://api.github.com/repos/amiedes/plots2/events","assignees_url":"https://api.github.com/repos/amiedes/plots2/assignees{/user}","branches_url":"https://api.github.com/repos/amiedes/plots2/branches{/branch}","tags_url":"https://api.github.com/repos/amiedes/plots2/tags","blobs_url":"https://api.github.com/repos/amiedes/plots2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amiedes/plots2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amiedes/plots2/git/refs{/sha}","trees_url":"https://api.github.com/repos/amiedes/plots2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amiedes/plots2/statuses/{sha}","languages_url":"https://api.github.com/repos/amiedes/plots2/languages","stargazers_url":"https://api.github.com/repos/amiedes/plots2/stargazers","contributors_url":"https://api.github.com/repos/amiedes/plots2/contributors","subscribers_url":"https://api.github.com/repos/amiedes/plots2/subscribers","subscription_url":"https://api.github.com/repos/amiedes/plots2/subscription","commits_url":"https://api.github.com/repos/amiedes/plots2/commits{/sha}","git_commits_url":"https://api.github.com/repos/amiedes/plots2/git/commits{/sha}","comments_url":"https://api.github.com/repos/amiedes/plots2/comments{/number}","issue_comment_url":"https://api.github.com/repos/amiedes/plots2/issues/comments{/number}","contents_url":"https://api.github.com/repos/amiedes/plots2/contents/{+path}","compare_url":"https://api.github.com/repos/amiedes/plots2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amiedes/plots2/merges","archive_url":"https://api.github.com/repos/amiedes/plots2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amiedes/plots2/downloads","issues_url":"https://api.github.com/repos/amiedes/plots2/issues{/number}","pulls_url":"https://api.github.com/repos/amiedes/plots2/pulls{/number}","milestones_url":"https://api.github.com/repos/amiedes/plots2/milestones{/number}","notifications_url":"https://api.github.com/repos/amiedes/plots2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amiedes/plots2/labels{/name}","releases_url":"https://api.github.com/repos/amiedes/plots2/releases{/id}","deployments_url":"https://api.github.com/repos/amiedes/plots2/deployments","created_at":"2017-03-13T11:07:21Z","updated_at":"2017-03-13T11:07:23Z","pushed_at":"2017-03-14T19:51:06Z","git_url":"git://github.com/amiedes/plots2.git","ssh_url":"git@github.com:amiedes/plots2.git","clone_url":"https://github.com/amiedes/plots2.git","svn_url":"https://github.com/amiedes/plots2","homepage":"https://publiclab.org","size":12416,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"publiclab:master","ref":"master","sha":"1deb8cd5a03e9b94df7d444f99856dc54b402e14","user":{"login":"publiclab","id":4621650,"avatar_url":"https://avatars0.githubusercontent.com/u/4621650?v=3","gravatar_id":"","url":"https://api.github.com/users/publiclab","html_url":"https://github.com/publiclab","followers_url":"https://api.github.com/users/publiclab/followers","following_url":"https://api.github.com/users/publiclab/following{/other_user}","gists_url":"https://api.github.com/users/publiclab/gists{/gist_id}","starred_url":"https://api.github.com/users/publiclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/publiclab/subscriptions","organizations_url":"https://api.github.com/users/publiclab/orgs","repos_url":"https://api.github.com/users/publiclab/repos","events_url":"https://api.github.com/users/publiclab/events{/privacy}","received_events_url":"https://api.github.com/users/publiclab/received_events","type":"Organization","site_admin":false},"repo":{"id":10504669,"name":"plots2","full_name":"publiclab/plots2","owner":{"login":"publiclab","id":4621650,"avatar_url":"https://avatars0.githubusercontent.com/u/4621650?v=3","gravatar_id":"","url":"https://api.github.com/users/publiclab","html_url":"https://github.com/publiclab","followers_url":"https://api.github.com/users/publiclab/followers","following_url":"https://api.github.com/users/publiclab/following{/other_user}","gists_url":"https://api.github.com/users/publiclab/gists{/gist_id}","starred_url":"https://api.github.com/users/publiclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/publiclab/subscriptions","organizations_url":"https://api.github.com/users/publiclab/orgs","repos_url":"https://api.github.com/users/publiclab/repos","events_url":"https://api.github.com/users/publiclab/events{/privacy}","received_events_url":"https://api.github.com/users/publiclab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/publiclab/plots2","description":"PublicLab.org - a collaborative knowledge-exchange platform in Rails; we welcome first-time contributors! :balloon:","fork":false,"url":"https://api.github.com/repos/publiclab/plots2","forks_url":"https://api.github.com/repos/publiclab/plots2/forks","keys_url":"https://api.github.com/repos/publiclab/plots2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/publiclab/plots2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/publiclab/plots2/teams","hooks_url":"https://api.github.com/repos/publiclab/plots2/hooks","issue_events_url":"https://api.github.com/repos/publiclab/plots2/issues/events{/number}","events_url":"https://api.github.com/repos/publiclab/plots2/events","assignees_url":"https://api.github.com/repos/publiclab/plots2/assignees{/user}","branches_url":"https://api.github.com/repos/publiclab/plots2/branches{/branch}","tags_url":"https://api.github.com/repos/publiclab/plots2/tags","blobs_url":"https://api.github.com/repos/publiclab/plots2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/publiclab/plots2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/publiclab/plots2/git/refs{/sha}","trees_url":"https://api.github.com/repos/publiclab/plots2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/publiclab/plots2/statuses/{sha}","languages_url":"https://api.github.com/repos/publiclab/plots2/languages","stargazers_url":"https://api.github.com/repos/publiclab/plots2/stargazers","contributors_url":"https://api.github.com/repos/publiclab/plots2/contributors","subscribers_url":"https://api.github.com/repos/publiclab/plots2/subscribers","subscription_url":"https://api.github.com/repos/publiclab/plots2/subscription","commits_url":"https://api.github.com/repos/publiclab/plots2/commits{/sha}","git_commits_url":"https://api.github.com/repos/publiclab/plots2/git/commits{/sha}","comments_url":"https://api.github.com/repos/publiclab/plots2/comments{/number}","issue_comment_url":"https://api.github.com/repos/publiclab/plots2/issues/comments{/number}","contents_url":"https://api.github.com/repos/publiclab/plots2/contents/{+path}","compare_url":"https://api.github.com/repos/publiclab/plots2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/publiclab/plots2/merges","archive_url":"https://api.github.com/repos/publiclab/plots2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/publiclab/plots2/downloads","issues_url":"https://api.github.com/repos/publiclab/plots2/issues{/number}","pulls_url":"https://api.github.com/repos/publiclab/plots2/pulls{/number}","milestones_url":"https://api.github.com/repos/publiclab/plots2/milestones{/number}","notifications_url":"https://api.github.com/repos/publiclab/plots2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/publiclab/plots2/labels{/name}","releases_url":"https://api.github.com/repos/publiclab/plots2/releases{/id}","deployments_url":"https://api.github.com/repos/publiclab/plots2/deployments","created_at":"2013-06-05T14:36:10Z","updated_at":"2017-03-10T17:49:44Z","pushed_at":"2017-03-14T19:52:18Z","git_url":"git://github.com/publiclab/plots2.git","ssh_url":"git@github.com:publiclab/plots2.git","clone_url":"https://github.com/publiclab/plots2.git","svn_url":"https://github.com/publiclab/plots2","homepage":"https://publiclab.org","size":12414,"stargazers_count":103,"watchers_count":103,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"open_issues_count":189,"forks":155,"open_issues":189,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/1338"},"html":{"href":"https://github.com/publiclab/plots2/pull/1338"},"issue":{"href":"https://api.github.com/repos/publiclab/plots2/issues/1338"},"comments":{"href":"https://api.github.com/repos/publiclab/plots2/issues/1338/comments"},"review_comments":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/1338/comments"},"review_comment":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/publiclab/plots2/pulls/1338/commits"},"statuses":{"href":"https://api.github.com/repos/publiclab/plots2/statuses/87f09e251d976035f02349b35b67ffd3057e1bb1"}}}}
{"actor":{"display_login":"jywarren"}}