{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/comments/106808463","pull_request_review_id":27749789,"id":106808463,"diff_hunk":"@@ -1,38 +1,36 @@\n-// Copyright (c) 2016 Mattermost, Inc. All Rights Reserved.\n+// Copyright (c) 2017 Mattermost, Inc. All Rights Reserved.\n // See License.txt for license information.\n \n-import keyMirror from 'utils/key_mirror';\n+export default {\n+    CONFIG_CHANGED: 'config_changed',\n \n-const GeneralTypes = keyMirror({\n-    RECEIVED_APP_STATE: null,\n-    RECEIVED_APP_CREDENTIALS: null,\n-    REMOVED_APP_CREDENTIALS: null,\n-    RECEIVED_APP_DEVICE_TOKEN: null,\n+    PROFILE_CHUNK_SIZE: 100,\n+    CHANNELS_CHUNK_SIZE: 50,\n+    SEARCH_TIMEOUT_MILLISECONDS: 100,\n+    STATUS_INTERVAL: 60000,\n \n-    PING_REQUEST: null,\n-    PING_SUCCESS: null,\n-    PING_FAILURE: null,\n-    PING_RESET: null,\n+    MENTION: 'mention',\n \n-    RECEIVED_SERVER_VERSION: null,\n+    OFFLINE: 'offline',\n+    AWAY: 'away',\n+    ONLINE: 'online',","path":"src/constants/general.js","position":28,"original_position":28,"commit_id":"0e01f1e97fc55524919a9014bb58c73e97570b8e","original_commit_id":"0e01f1e97fc55524919a9014bb58c73e97570b8e","user":{"login":"enahum","id":6757047,"avatar_url":"https://avatars2.githubusercontent.com/u/6757047?v=3","gravatar_id":"","url":"https://api.github.com/users/enahum","html_url":"https://github.com/enahum","followers_url":"https://api.github.com/users/enahum/followers","following_url":"https://api.github.com/users/enahum/following{/other_user}","gists_url":"https://api.github.com/users/enahum/gists{/gist_id}","starred_url":"https://api.github.com/users/enahum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enahum/subscriptions","organizations_url":"https://api.github.com/users/enahum/orgs","repos_url":"https://api.github.com/users/enahum/repos","events_url":"https://api.github.com/users/enahum/events{/privacy}","received_events_url":"https://api.github.com/users/enahum/received_events","type":"User","site_admin":false},"body":"we can move this three to the user constant file","created_at":"2017-03-19T14:49:26Z","updated_at":"2017-03-19T14:53:15Z","html_url":"https://github.com/mattermost/mattermost-redux/pull/9#discussion_r106808463","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/comments/106808463"},"html":{"href":"https://github.com/mattermost/mattermost-redux/pull/9#discussion_r106808463"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/9","id":111452400,"html_url":"https://github.com/mattermost/mattermost-redux/pull/9","diff_url":"https://github.com/mattermost/mattermost-redux/pull/9.diff","patch_url":"https://github.com/mattermost/mattermost-redux/pull/9.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-redux/issues/9","number":9,"state":"open","locked":false,"title":"PLT-5932 Split out action_types from constants","user":{"login":"jwilander","id":2672098,"avatar_url":"https://avatars3.githubusercontent.com/u/2672098?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilander","html_url":"https://github.com/jwilander","followers_url":"https://api.github.com/users/jwilander/followers","following_url":"https://api.github.com/users/jwilander/following{/other_user}","gists_url":"https://api.github.com/users/jwilander/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilander/subscriptions","organizations_url":"https://api.github.com/users/jwilander/orgs","repos_url":"https://api.github.com/users/jwilander/repos","events_url":"https://api.github.com/users/jwilander/events{/privacy}","received_events_url":"https://api.github.com/users/jwilander/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n* Split out action_types from constants\r\n* Remove `s` for type names (ex. `UsersTypes`  to `UserTypes`)\r\n* Separate some constants out into different files\r\n\r\n#### Ticket Link\r\nhttps://mattermost.atlassian.net/browse/PLT-5932\r\n\r\n#### Checklist\r\n- [x] Added or updated unit tests (required for all new features)\r\n","created_at":"2017-03-19T14:39:15Z","updated_at":"2017-03-19T14:53:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1b1ad3aa879366b785da4cbb1f3414021ce825b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/9/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/9/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-redux/issues/9/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-redux/statuses/0e01f1e97fc55524919a9014bb58c73e97570b8e","head":{"label":"mattermost:plt-5932","ref":"plt-5932","sha":"0e01f1e97fc55524919a9014bb58c73e97570b8e","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars2.githubusercontent.com/u/9828093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":84744614,"name":"mattermost-redux","full_name":"mattermost/mattermost-redux","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars2.githubusercontent.com/u/9828093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-redux","description":"Redux for Mattermost","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-redux","forks_url":"https://api.github.com/repos/mattermost/mattermost-redux/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-redux/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-redux/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-redux/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-redux/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-redux/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-redux/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-redux/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-redux/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-redux/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-redux/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-redux/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-redux/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-redux/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-redux/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-redux/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-redux/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-redux/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-redux/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-redux/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-redux/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-redux/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-redux/deployments","created_at":"2017-03-12T17:40:39Z","updated_at":"2017-03-15T16:30:17Z","pushed_at":"2017-03-19T14:39:15Z","git_url":"git://github.com/mattermost/mattermost-redux.git","ssh_url":"git@github.com:mattermost/mattermost-redux.git","clone_url":"https://github.com/mattermost/mattermost-redux.git","svn_url":"https://github.com/mattermost/mattermost-redux","homepage":null,"size":85,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"c27ceb5cc90760924c5925b353e35afdbc7bf621","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars2.githubusercontent.com/u/9828093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":84744614,"name":"mattermost-redux","full_name":"mattermost/mattermost-redux","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars2.githubusercontent.com/u/9828093?v=3","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-redux","description":"Redux for Mattermost","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-redux","forks_url":"https://api.github.com/repos/mattermost/mattermost-redux/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-redux/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-redux/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-redux/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-redux/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-redux/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-redux/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-redux/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-redux/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-redux/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-redux/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-redux/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-redux/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-redux/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-redux/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-redux/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-redux/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-redux/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-redux/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-redux/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-redux/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-redux/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-redux/deployments","created_at":"2017-03-12T17:40:39Z","updated_at":"2017-03-15T16:30:17Z","pushed_at":"2017-03-19T14:39:15Z","git_url":"git://github.com/mattermost/mattermost-redux.git","ssh_url":"git@github.com:mattermost/mattermost-redux.git","clone_url":"https://github.com/mattermost/mattermost-redux.git","svn_url":"https://github.com/mattermost/mattermost-redux","homepage":null,"size":85,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/9"},"html":{"href":"https://github.com/mattermost/mattermost-redux/pull/9"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/issues/9"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-redux/statuses/0e01f1e97fc55524919a9014bb58c73e97570b8e"}}}}
{"actor":{"display_login":"enahum"}}