{"action":"created","comment":{"url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/comments/144858846","pull_request_review_id":69571704,"id":144858846,"diff_hunk":"@@ -32,11 +32,11 @@ def created_at\n   end\n \n   def questions\n-    form_questions = []\n-    object.survey_forms.includes(form: { form_questions: [:response_set, { question: :concepts }] }).each do |sf|\n-      form_questions.concat sf.form.form_questions.to_a\n+    section_questions = []\n+    object.survey_sections.includes(section: { section_questions: [:response_set, { question: :concepts }] }).each do |sf|\n+      section_questions.concat sf.section.section_questions.to_a\n     end\n-    form_questions.collect do |fq|\n+    section_questions.collect do |fq|","path":"app/serializers/es_survey_serializer.rb","position":21,"original_position":21,"commit_id":"2d950365ab8c336622bdf45c6356cc269ed5d1d5","original_commit_id":"2d950365ab8c336622bdf45c6356cc269ed5d1d5","user":{"login":"eedrummer","id":17500,"avatar_url":"https://avatars3.githubusercontent.com/u/17500?v=4","gravatar_id":"","url":"https://api.github.com/users/eedrummer","html_url":"https://github.com/eedrummer","followers_url":"https://api.github.com/users/eedrummer/followers","following_url":"https://api.github.com/users/eedrummer/following{/other_user}","gists_url":"https://api.github.com/users/eedrummer/gists{/gist_id}","starred_url":"https://api.github.com/users/eedrummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eedrummer/subscriptions","organizations_url":"https://api.github.com/users/eedrummer/orgs","repos_url":"https://api.github.com/users/eedrummer/repos","events_url":"https://api.github.com/users/eedrummer/events{/privacy}","received_events_url":"https://api.github.com/users/eedrummer/received_events","type":"User","site_admin":false},"body":"`sq`","created_at":"2017-10-16T14:15:30Z","updated_at":"2017-10-16T14:43:01Z","html_url":"https://github.com/CDCgov/SDP-Vocabulary-Service/pull/381#discussion_r144858846","pull_request_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/381","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/comments/144858846"},"html":{"href":"https://github.com/CDCgov/SDP-Vocabulary-Service/pull/381#discussion_r144858846"},"pull_request":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/381"}}},"pull_request":{"url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/381","id":146732404,"html_url":"https://github.com/CDCgov/SDP-Vocabulary-Service/pull/381","diff_url":"https://github.com/CDCgov/SDP-Vocabulary-Service/pull/381.diff","patch_url":"https://github.com/CDCgov/SDP-Vocabulary-Service/pull/381.patch","issue_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues/381","number":381,"state":"open","locked":false,"title":"[SDPV-116] Forms renamed to Sections","user":{"login":"kierk","id":15838082,"avatar_url":"https://avatars0.githubusercontent.com/u/15838082?v=4","gravatar_id":"","url":"https://api.github.com/users/kierk","html_url":"https://github.com/kierk","followers_url":"https://api.github.com/users/kierk/followers","following_url":"https://api.github.com/users/kierk/following{/other_user}","gists_url":"https://api.github.com/users/kierk/gists{/gist_id}","starred_url":"https://api.github.com/users/kierk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kierk/subscriptions","organizations_url":"https://api.github.com/users/kierk/orgs","repos_url":"https://api.github.com/users/kierk/repos","events_url":"https://api.github.com/users/kierk/events{/privacy}","received_events_url":"https://api.github.com/users/kierk/received_events","type":"User","site_admin":false},"body":"N.B.: When this PR is merged it will require a deletion of the Elasticsearch index for forms. running `rake es:sync` will add all of the renamed objects to elastic search as Sections (as intended) but the forms already added are not deleted. This results in objects coming back from elastic search that the app doesn't know how to handle properly.\r\n\r\n\r\nMake sure you include the related JIRA issue in the title e.g. '[SDP-007] Fixed navbar issue'\r\nMake sure you have checked off the following before you issue your Pull Request:\r\n\r\n- [x] Added unit tests for new functionality\r\n- [x] Passed all unit tests using `rails test` with 90%+ coverage\r\n- [x] Added cucumber tests for any new functionality\r\n- [x] Passed all cucumber tests using `bundle exec cucumber`\r\n- [x] Passed overcommit hooks, including running all code through Rubocop\r\n- [x] If any database changes were made, run `rake generate_erd` to update the README.md\r\n- [x] If any changes were made to config/routes.rb run `rake jsroutes:generate`\r\n- [x] If any HTML was added or modified check to make sure it was still 508 compliant with WAVE tool / carried over any attributes from similar sections\r\n","created_at":"2017-10-16T09:12:25Z","updated_at":"2017-10-16T14:43:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ba23a78b8a973e42af6f52598f6086002ac396","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/381/commits","review_comments_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/381/comments","review_comment_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues/381/comments","statuses_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/statuses/2d950365ab8c336622bdf45c6356cc269ed5d1d5","head":{"label":"CDCgov:form-rename","ref":"form-rename","sha":"2d950365ab8c336622bdf45c6356cc269ed5d1d5","user":{"login":"CDCgov","id":12104975,"avatar_url":"https://avatars1.githubusercontent.com/u/12104975?v=4","gravatar_id":"","url":"https://api.github.com/users/CDCgov","html_url":"https://github.com/CDCgov","followers_url":"https://api.github.com/users/CDCgov/followers","following_url":"https://api.github.com/users/CDCgov/following{/other_user}","gists_url":"https://api.github.com/users/CDCgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CDCgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDCgov/subscriptions","organizations_url":"https://api.github.com/users/CDCgov/orgs","repos_url":"https://api.github.com/users/CDCgov/repos","events_url":"https://api.github.com/users/CDCgov/events{/privacy}","received_events_url":"https://api.github.com/users/CDCgov/received_events","type":"Organization","site_admin":false},"repo":{"id":68638942,"name":"SDP-Vocabulary-Service","full_name":"CDCgov/SDP-Vocabulary-Service","owner":{"login":"CDCgov","id":12104975,"avatar_url":"https://avatars1.githubusercontent.com/u/12104975?v=4","gravatar_id":"","url":"https://api.github.com/users/CDCgov","html_url":"https://github.com/CDCgov","followers_url":"https://api.github.com/users/CDCgov/followers","following_url":"https://api.github.com/users/CDCgov/following{/other_user}","gists_url":"https://api.github.com/users/CDCgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CDCgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDCgov/subscriptions","organizations_url":"https://api.github.com/users/CDCgov/orgs","repos_url":"https://api.github.com/users/CDCgov/repos","events_url":"https://api.github.com/users/CDCgov/events{/privacy}","received_events_url":"https://api.github.com/users/CDCgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CDCgov/SDP-Vocabulary-Service","description":"Repository for the development of the initial SDP vocabulary service. ","fork":false,"url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service","forks_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/forks","keys_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/teams","hooks_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/hooks","issue_events_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues/events{/number}","events_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/events","assignees_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/assignees{/user}","branches_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/branches{/branch}","tags_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/tags","blobs_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/refs{/sha}","trees_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/statuses/{sha}","languages_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/languages","stargazers_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/stargazers","contributors_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/contributors","subscribers_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/subscribers","subscription_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/subscription","commits_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/commits{/sha}","git_commits_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/commits{/sha}","comments_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/comments{/number}","issue_comment_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues/comments{/number}","contents_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/contents/{+path}","compare_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/merges","archive_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/downloads","issues_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues{/number}","pulls_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls{/number}","milestones_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/milestones{/number}","notifications_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/labels{/name}","releases_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/releases{/id}","deployments_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/deployments","created_at":"2016-09-19T19:28:16Z","updated_at":"2017-03-28T15:26:52Z","pushed_at":"2017-10-16T09:12:25Z","git_url":"git://github.com/CDCgov/SDP-Vocabulary-Service.git","ssh_url":"git@github.com:CDCgov/SDP-Vocabulary-Service.git","clone_url":"https://github.com/CDCgov/SDP-Vocabulary-Service.git","svn_url":"https://github.com/CDCgov/SDP-Vocabulary-Service","homepage":null,"size":13713,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"CDCgov:development","ref":"development","sha":"b382f5cd903ec5999244dbc88a6dc193714cdb29","user":{"login":"CDCgov","id":12104975,"avatar_url":"https://avatars1.githubusercontent.com/u/12104975?v=4","gravatar_id":"","url":"https://api.github.com/users/CDCgov","html_url":"https://github.com/CDCgov","followers_url":"https://api.github.com/users/CDCgov/followers","following_url":"https://api.github.com/users/CDCgov/following{/other_user}","gists_url":"https://api.github.com/users/CDCgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CDCgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDCgov/subscriptions","organizations_url":"https://api.github.com/users/CDCgov/orgs","repos_url":"https://api.github.com/users/CDCgov/repos","events_url":"https://api.github.com/users/CDCgov/events{/privacy}","received_events_url":"https://api.github.com/users/CDCgov/received_events","type":"Organization","site_admin":false},"repo":{"id":68638942,"name":"SDP-Vocabulary-Service","full_name":"CDCgov/SDP-Vocabulary-Service","owner":{"login":"CDCgov","id":12104975,"avatar_url":"https://avatars1.githubusercontent.com/u/12104975?v=4","gravatar_id":"","url":"https://api.github.com/users/CDCgov","html_url":"https://github.com/CDCgov","followers_url":"https://api.github.com/users/CDCgov/followers","following_url":"https://api.github.com/users/CDCgov/following{/other_user}","gists_url":"https://api.github.com/users/CDCgov/gists{/gist_id}","starred_url":"https://api.github.com/users/CDCgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDCgov/subscriptions","organizations_url":"https://api.github.com/users/CDCgov/orgs","repos_url":"https://api.github.com/users/CDCgov/repos","events_url":"https://api.github.com/users/CDCgov/events{/privacy}","received_events_url":"https://api.github.com/users/CDCgov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CDCgov/SDP-Vocabulary-Service","description":"Repository for the development of the initial SDP vocabulary service. ","fork":false,"url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service","forks_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/forks","keys_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/teams","hooks_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/hooks","issue_events_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues/events{/number}","events_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/events","assignees_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/assignees{/user}","branches_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/branches{/branch}","tags_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/tags","blobs_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/refs{/sha}","trees_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/statuses/{sha}","languages_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/languages","stargazers_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/stargazers","contributors_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/contributors","subscribers_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/subscribers","subscription_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/subscription","commits_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/commits{/sha}","git_commits_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/git/commits{/sha}","comments_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/comments{/number}","issue_comment_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues/comments{/number}","contents_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/contents/{+path}","compare_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/merges","archive_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/downloads","issues_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues{/number}","pulls_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls{/number}","milestones_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/milestones{/number}","notifications_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/labels{/name}","releases_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/releases{/id}","deployments_url":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/deployments","created_at":"2016-09-19T19:28:16Z","updated_at":"2017-03-28T15:26:52Z","pushed_at":"2017-10-16T09:12:25Z","git_url":"git://github.com/CDCgov/SDP-Vocabulary-Service.git","ssh_url":"git@github.com:CDCgov/SDP-Vocabulary-Service.git","clone_url":"https://github.com/CDCgov/SDP-Vocabulary-Service.git","svn_url":"https://github.com/CDCgov/SDP-Vocabulary-Service","homepage":null,"size":13713,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/381"},"html":{"href":"https://github.com/CDCgov/SDP-Vocabulary-Service/pull/381"},"issue":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues/381"},"comments":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/issues/381/comments"},"review_comments":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/381/comments"},"review_comment":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/pulls/381/commits"},"statuses":{"href":"https://api.github.com/repos/CDCgov/SDP-Vocabulary-Service/statuses/2d950365ab8c336622bdf45c6356cc269ed5d1d5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eedrummer"}}