{"action":"created","comment":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments/128827004","pull_request_review_id":51547183,"id":128827004,"diff_hunk":"@@ -131,5 +131,124 @@\n         jwplayerCompatible.vid = playerLibrary.vid;\n \n         window.jwplayer = jwplayerCompatible;\n+","path":"src/js/compatibility.js","position":4,"original_position":4,"commit_id":"beb9198f3e34c3b46405e284bcc8caf55c150827","original_commit_id":"beb9198f3e34c3b46405e284bcc8caf55c150827","user":{"login":"robwalch","id":333258,"avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"body":"Add `events` to `jwplayerCompatible` before the line above.","created_at":"2017-07-21T18:13:47Z","updated_at":"2017-07-21T18:16:12Z","html_url":"https://github.com/jwplayer/jwplayer/pull/2179#discussion_r128827004","pull_request_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2179","_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments/128827004"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/2179#discussion_r128827004"},"pull_request":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2179"}}},"pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2179","id":131677385,"html_url":"https://github.com/jwplayer/jwplayer/pull/2179","diff_url":"https://github.com/jwplayer/jwplayer/pull/2179.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/2179.patch","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2179","number":2179,"state":"open","locked":false,"title":"Events and states deprecation","user":{"login":"karimJWP","id":12138319,"avatar_url":"https://avatars1.githubusercontent.com/u/12138319?v=4","gravatar_id":"","url":"https://api.github.com/users/karimJWP","html_url":"https://github.com/karimJWP","followers_url":"https://api.github.com/users/karimJWP/followers","following_url":"https://api.github.com/users/karimJWP/following{/other_user}","gists_url":"https://api.github.com/users/karimJWP/gists{/gist_id}","starred_url":"https://api.github.com/users/karimJWP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karimJWP/subscriptions","organizations_url":"https://api.github.com/users/karimJWP/orgs","repos_url":"https://api.github.com/users/karimJWP/repos","events_url":"https://api.github.com/users/karimJWP/events{/privacy}","received_events_url":"https://api.github.com/users/karimJWP/received_events","type":"User","site_admin":false},"body":"### This PR will...\r\nReplace events and states with ES6 constants and move obsolete events to the compatibility script.\r\n\r\n### Why is this Pull Request needed?\r\nTo deprecate Events and States for JW 8.\r\n\r\n### Are there any points in the code the reviewer needs to double check?\r\nA sanity check would be much appreciated. Keep in mind Documentation for ES6 constants will be added in separate PR\r\n\r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\nhttps://github.com/jwplayer/jwplayer-commercial/pull/3776\r\n\r\n#### Addresses Issue(s):\r\nJW8-120\r\n\r\n","created_at":"2017-07-21T00:34:57Z","updated_at":"2017-07-21T18:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2179/commits","review_comments_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2179/comments","review_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2179/comments","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/beb9198f3e34c3b46405e284bcc8caf55c150827","head":{"label":"jwplayer:feature/deprecate-events","ref":"feature/deprecate-events","sha":"beb9198f3e34c3b46405e284bcc8caf55c150827","user":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2017-07-21T08:41:04Z","pushed_at":"2017-07-21T03:30:33Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":82675,"stargazers_count":1312,"watchers_count":1312,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":573,"mirror_url":null,"open_issues_count":61,"forks":573,"open_issues":61,"watchers":1312,"default_branch":"master"}},"base":{"label":"jwplayer:master","ref":"master","sha":"4c43be9b56ccc914e947753c2993ccb1143217bf","user":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2017-07-21T08:41:04Z","pushed_at":"2017-07-21T03:30:33Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":82675,"stargazers_count":1312,"watchers_count":1312,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":573,"mirror_url":null,"open_issues_count":61,"forks":573,"open_issues":61,"watchers":1312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2179"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/2179"},"issue":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2179"},"comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2179/comments"},"review_comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2179/comments"},"review_comment":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2179/commits"},"statuses":{"href":"https://api.github.com/repos/jwplayer/jwplayer/statuses/beb9198f3e34c3b46405e284bcc8caf55c150827"}}}}
{"actor":{"display_login":"robwalch"}}