{"action":"closed","issue":{"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2485","repository_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons","labels_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2485/labels{/name}","comments_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2485/comments","events_url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/issues/2485/events","html_url":"https://github.com/unknown-horizons/unknown-horizons/issues/2485","id":177862829,"number":2485,"title":"Consider using the nosetests flaky plugin for GUI tests","user":{"login":"squiddy","id":50333,"avatar_url":"https://avatars.githubusercontent.com/u/50333?v=3","gravatar_id":"","url":"https://api.github.com/users/squiddy","html_url":"https://github.com/squiddy","followers_url":"https://api.github.com/users/squiddy/followers","following_url":"https://api.github.com/users/squiddy/following{/other_user}","gists_url":"https://api.github.com/users/squiddy/gists{/gist_id}","starred_url":"https://api.github.com/users/squiddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squiddy/subscriptions","organizations_url":"https://api.github.com/users/squiddy/orgs","repos_url":"https://api.github.com/users/squiddy/repos","events_url":"https://api.github.com/users/squiddy/events{/privacy}","received_events_url":"https://api.github.com/users/squiddy/received_events","type":"User","site_admin":false},"labels":[{"id":470242383,"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/labels/A-internals","name":"A-internals","color":"ffd154","default":false},{"id":12193372,"url":"https://api.github.com/repos/unknown-horizons/unknown-horizons/labels/tests","name":"tests","color":"fffbb5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-19T18:38:27Z","updated_at":"2017-02-25T08:12:43Z","closed_at":"2017-02-25T08:12:43Z","body":"Since we enabled gui tests on CI, about 10 tests showed inconsistent behaviour, i.e. sometimes they succeed and sometimes not.\r\n\r\nWe still have about 65 gui tests that succeed, in order to not fail the whole build I marked these inconsistent tests with a `mark_flaky` decorator that will simply mark the test as skipped if it fails. Obviously this is not a long-term solution.\r\n\r\nI've briefly looked at https://github.com/box/flaky, which let's us define how many tests reruns have to pass in order to have the test succeed."}}
{"actor":{"display_login":"squiddy"}}