{"action":"created","comment":{"url":"https://api.github.com/repos/lxc/lxd/pulls/comments/102567241","pull_request_review_id":23327232,"id":102567241,"diff_hunk":"@@ -1319,82 +1329,70 @@ func (s *storageBtrfs) btrfsPoolVolumeQGroupUsage(subvol string) (int64, error)\n \treturn -1, fmt.Errorf(\"Unable to find current qgroup usage\")\n }\n \n-func (s *storageBtrfs) btrfsPoolVolumeDelete(subvol string) error {\n+func btrfsSubVolumeDelete(subvol string) error {\n \t// Attempt (but don't fail on) to delete any qgroup on the subvolume\n-\tqgroup, err := s.btrfsPoolVolumeQGroup(subvol)\n+\tqgroup, err := btrfsSubVolumeQGroup(subvol)\n \tif err == nil {\n-\t\toutput, err := exec.Command(\n+\t\texec.Command(\n \t\t\t\"btrfs\",\n \t\t\t\"qgroup\",\n \t\t\t\"destroy\",\n \t\t\tqgroup,\n-\t\t\tsubvol).CombinedOutput()\n-\n-\t\tif err != nil {\n-\t\t\ts.log.Warn(\n-\t\t\t\t\"subvolume qgroup delete failed\",\n-\t\t\t\tlog.Ctx{\"subvol\": subvol, \"output\": string(output)},\n-\t\t\t)\n-\t\t}\n+\t\t\tsubvol).Run()\n \t}\n \n \t// Attempt to make the subvolume writable\n \texec.Command(\"btrfs\", \"property\", \"set\", subvol, \"ro\", \"false\").CombinedOutput()\n \n \t// Delete the subvolume itself\n-\toutput, err := exec.Command(\n+\terr = exec.Command(\n \t\t\"btrfs\",\n \t\t\"subvolume\",\n \t\t\"delete\",\n \t\tsubvol,\n-\t).CombinedOutput()\n+\t).Run()\n \n-\tif err != nil {\n-\t\ts.log.Warn(\n-\t\t\t\"subvolume delete failed\",\n-\t\t\tlog.Ctx{\"subvol\": subvol, \"output\": string(output)},\n-\t\t)\n-\t}\n \treturn nil","path":"lxd/storage_btrfs.go","position":232,"original_position":232,"commit_id":"464fd933ca66a3365a627983daf01f265ae31691","original_commit_id":"464fd933ca66a3365a627983daf01f265ae31691","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"body":"nope, it was only the qgroup stuff removal stuff","created_at":"2017-02-22T20:43:06Z","updated_at":"2017-02-22T20:43:06Z","html_url":"https://github.com/lxc/lxd/pull/2925#discussion_r102567241","pull_request_url":"https://api.github.com/repos/lxc/lxd/pulls/2925","_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments/102567241"},"html":{"href":"https://github.com/lxc/lxd/pull/2925#discussion_r102567241"},"pull_request":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2925"}}},"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/2925","id":107326216,"html_url":"https://github.com/lxc/lxd/pull/2925","diff_url":"https://github.com/lxc/lxd/pull/2925.diff","patch_url":"https://github.com/lxc/lxd/pull/2925.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/2925","number":2925,"state":"open","locked":false,"title":"storage: bugfixes","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-22T03:03:59Z","updated_at":"2017-02-22T20:43:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c6880553b47c5968005aa13de1e3e14e679c8d4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/2925/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/2925/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/2925/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/464fd933ca66a3365a627983daf01f265ae31691","head":{"label":"brauner:2017-02-21/post_storage_api_lvm_fixes","ref":"2017-02-21/post_storage_api_lvm_fixes","sha":"464fd933ca66a3365a627983daf01f265ae31691","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"repo":{"id":67736764,"name":"lxd","full_name":"brauner/lxd","owner":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brauner/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":true,"url":"https://api.github.com/repos/brauner/lxd","forks_url":"https://api.github.com/repos/brauner/lxd/forks","keys_url":"https://api.github.com/repos/brauner/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brauner/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brauner/lxd/teams","hooks_url":"https://api.github.com/repos/brauner/lxd/hooks","issue_events_url":"https://api.github.com/repos/brauner/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/brauner/lxd/events","assignees_url":"https://api.github.com/repos/brauner/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/brauner/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/brauner/lxd/tags","blobs_url":"https://api.github.com/repos/brauner/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brauner/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brauner/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/brauner/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brauner/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/brauner/lxd/languages","stargazers_url":"https://api.github.com/repos/brauner/lxd/stargazers","contributors_url":"https://api.github.com/repos/brauner/lxd/contributors","subscribers_url":"https://api.github.com/repos/brauner/lxd/subscribers","subscription_url":"https://api.github.com/repos/brauner/lxd/subscription","commits_url":"https://api.github.com/repos/brauner/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/brauner/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/brauner/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/brauner/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/brauner/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/brauner/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brauner/lxd/merges","archive_url":"https://api.github.com/repos/brauner/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brauner/lxd/downloads","issues_url":"https://api.github.com/repos/brauner/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/brauner/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/brauner/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/brauner/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brauner/lxd/labels{/name}","releases_url":"https://api.github.com/repos/brauner/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/brauner/lxd/deployments","created_at":"2016-09-08T20:11:08Z","updated_at":"2016-09-08T20:11:10Z","pushed_at":"2017-02-22T18:04:36Z","git_url":"git://github.com/brauner/lxd.git","ssh_url":"git@github.com:brauner/lxd.git","clone_url":"https://github.com/brauner/lxd.git","svn_url":"https://github.com/brauner/lxd","homepage":"https://linuxcontainers.org/lxd","size":9441,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"1c51872156a52dc9f10b8d206bf106f10999c5c1","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars.githubusercontent.com/u/2301756?v=3","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxd/deployments","created_at":"2014-11-04T22:40:52Z","updated_at":"2017-02-21T23:55:39Z","pushed_at":"2017-02-22T18:04:37Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org/lxd","size":9365,"stargazers_count":1266,"watchers_count":1266,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":277,"mirror_url":null,"open_issues_count":85,"forks":277,"open_issues":85,"watchers":1266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2925"},"html":{"href":"https://github.com/lxc/lxd/pull/2925"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/2925"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/2925/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2925/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/2925/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/464fd933ca66a3365a627983daf01f265ae31691"}}}}
{"actor":{"display_login":"brauner"}}