{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vs-threading/pulls/comments/117055489","pull_request_review_id":38727357,"id":117055489,"diff_hunk":"@@ -52,7 +52,7 @@ public static void WaitWithoutInlining(this Task task)\n             if (!task.IsCompleted)\n             {\n                 // Waiting on a continuation of a task won't ever inline the predecessor (in .NET 4.x anyway).\n-                var continuation = task.ContinueWith(t => { }, CancellationToken.None, TaskContinuationOptions.ExecuteSynchronously, TaskScheduler.Default);\n+                var continuation = task.ContinueWith(t => { }, CancellationToken.None, TaskContinuationOptions.None, TaskScheduler.Default);\n                 continuation.Wait();","path":"src/Microsoft.VisualStudio.Threading/TplExtensions.cs","position":6,"original_position":6,"commit_id":"facbc7364448ee18a7c97f2ffc31ffe78dedd2d5","original_commit_id":"facbc7364448ee18a7c97f2ffc31ffe78dedd2d5","user":{"login":"IlyaBiryukov","id":15989459,"avatar_url":"https://avatars2.githubusercontent.com/u/15989459?v=3","gravatar_id":"","url":"https://api.github.com/users/IlyaBiryukov","html_url":"https://github.com/IlyaBiryukov","followers_url":"https://api.github.com/users/IlyaBiryukov/followers","following_url":"https://api.github.com/users/IlyaBiryukov/following{/other_user}","gists_url":"https://api.github.com/users/IlyaBiryukov/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaBiryukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaBiryukov/subscriptions","organizations_url":"https://api.github.com/users/IlyaBiryukov/orgs","repos_url":"https://api.github.com/users/IlyaBiryukov/repos","events_url":"https://api.github.com/users/IlyaBiryukov/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaBiryukov/received_events","type":"User","site_admin":false},"body":"Interesting inconsistency: Task.Wait() throws if the task failed. Task.WaitWithoutInlining() does not throw.\r\nIs there a reason for that? And should the comment highlight this difference.","created_at":"2017-05-17T16:52:17Z","updated_at":"2017-05-17T16:52:17Z","html_url":"https://github.com/Microsoft/vs-threading/pull/113#discussion_r117055489","pull_request_url":"https://api.github.com/repos/Microsoft/vs-threading/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vs-threading/pulls/comments/117055489"},"html":{"href":"https://github.com/Microsoft/vs-threading/pull/113#discussion_r117055489"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vs-threading/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vs-threading/pulls/113","id":121095699,"html_url":"https://github.com/Microsoft/vs-threading/pull/113","diff_url":"https://github.com/Microsoft/vs-threading/pull/113.diff","patch_url":"https://github.com/Microsoft/vs-threading/pull/113.patch","issue_url":"https://api.github.com/repos/Microsoft/vs-threading/issues/113","number":113,"state":"open","locked":false,"title":"Fix WaitWithoutInlinining to not wait for inlined continuations","user":{"login":"AArnott","id":3548,"avatar_url":"https://avatars1.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"body":"This adds a slight inefficiency (requiring the threadpool to execute a no-op delegate) in favor of mitigating the risk of deadlocks or very long unnecessary waits due to inlined continuations that precede the one we add.","created_at":"2017-05-17T16:06:32Z","updated_at":"2017-05-17T16:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e2740e4b77c4eb68e9dc6033155340fe58a7349","assignee":{"login":"AArnott","id":3548,"avatar_url":"https://avatars1.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"assignees":[{"login":"AArnott","id":3548,"avatar_url":"https://avatars1.githubusercontent.com/u/3548?v=3","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"sharwell","id":1408396,"avatar_url":"https://avatars2.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},{"login":"stephentoub","id":2642209,"avatar_url":"https://avatars3.githubusercontent.com/u/2642209?v=3","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vs-threading/pulls/113/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vs-threading/pulls/113/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vs-threading/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vs-threading/issues/113/comments","statuses_url":"https://api.github.com/repos/Microsoft/vs-threading/statuses/facbc7364448ee18a7c97f2ffc31ffe78dedd2d5","head":{"label":"Microsoft:dev/andarno/fix112","ref":"dev/andarno/fix112","sha":"facbc7364448ee18a7c97f2ffc31ffe78dedd2d5","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":70068171,"name":"vs-threading","full_name":"Microsoft/vs-threading","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vs-threading","description":"The Microsoft.VisualStudio.Threading is a xplat library that provides many threading and synchronization primitives used in Visual Studio and other applications. ","fork":false,"url":"https://api.github.com/repos/Microsoft/vs-threading","forks_url":"https://api.github.com/repos/Microsoft/vs-threading/forks","keys_url":"https://api.github.com/repos/Microsoft/vs-threading/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vs-threading/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vs-threading/teams","hooks_url":"https://api.github.com/repos/Microsoft/vs-threading/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vs-threading/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vs-threading/events","assignees_url":"https://api.github.com/repos/Microsoft/vs-threading/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vs-threading/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vs-threading/tags","blobs_url":"https://api.github.com/repos/Microsoft/vs-threading/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vs-threading/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vs-threading/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vs-threading/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vs-threading/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vs-threading/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vs-threading/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vs-threading/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vs-threading/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vs-threading/subscription","commits_url":"https://api.github.com/repos/Microsoft/vs-threading/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vs-threading/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vs-threading/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vs-threading/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vs-threading/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vs-threading/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vs-threading/merges","archive_url":"https://api.github.com/repos/Microsoft/vs-threading/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vs-threading/downloads","issues_url":"https://api.github.com/repos/Microsoft/vs-threading/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vs-threading/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vs-threading/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vs-threading/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vs-threading/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vs-threading/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vs-threading/deployments","created_at":"2016-10-05T14:27:26Z","updated_at":"2017-05-17T12:41:36Z","pushed_at":"2017-05-17T16:06:32Z","git_url":"git://github.com/Microsoft/vs-threading.git","ssh_url":"git@github.com:Microsoft/vs-threading.git","clone_url":"https://github.com/Microsoft/vs-threading.git","svn_url":"https://github.com/Microsoft/vs-threading","homepage":null,"size":4710,"stargazers_count":102,"watchers_count":102,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":22,"forks":11,"open_issues":22,"watchers":102,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"f26e88b9dc0cc76935446d5ce17d09edb28c72d9","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":70068171,"name":"vs-threading","full_name":"Microsoft/vs-threading","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vs-threading","description":"The Microsoft.VisualStudio.Threading is a xplat library that provides many threading and synchronization primitives used in Visual Studio and other applications. ","fork":false,"url":"https://api.github.com/repos/Microsoft/vs-threading","forks_url":"https://api.github.com/repos/Microsoft/vs-threading/forks","keys_url":"https://api.github.com/repos/Microsoft/vs-threading/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vs-threading/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vs-threading/teams","hooks_url":"https://api.github.com/repos/Microsoft/vs-threading/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vs-threading/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vs-threading/events","assignees_url":"https://api.github.com/repos/Microsoft/vs-threading/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vs-threading/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vs-threading/tags","blobs_url":"https://api.github.com/repos/Microsoft/vs-threading/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vs-threading/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vs-threading/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vs-threading/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vs-threading/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vs-threading/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vs-threading/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vs-threading/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vs-threading/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vs-threading/subscription","commits_url":"https://api.github.com/repos/Microsoft/vs-threading/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vs-threading/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vs-threading/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vs-threading/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vs-threading/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vs-threading/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vs-threading/merges","archive_url":"https://api.github.com/repos/Microsoft/vs-threading/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vs-threading/downloads","issues_url":"https://api.github.com/repos/Microsoft/vs-threading/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vs-threading/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vs-threading/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vs-threading/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vs-threading/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vs-threading/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vs-threading/deployments","created_at":"2016-10-05T14:27:26Z","updated_at":"2017-05-17T12:41:36Z","pushed_at":"2017-05-17T16:06:32Z","git_url":"git://github.com/Microsoft/vs-threading.git","ssh_url":"git@github.com:Microsoft/vs-threading.git","clone_url":"https://github.com/Microsoft/vs-threading.git","svn_url":"https://github.com/Microsoft/vs-threading","homepage":null,"size":4710,"stargazers_count":102,"watchers_count":102,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":22,"forks":11,"open_issues":22,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vs-threading/pulls/113"},"html":{"href":"https://github.com/Microsoft/vs-threading/pull/113"},"issue":{"href":"https://api.github.com/repos/Microsoft/vs-threading/issues/113"},"comments":{"href":"https://api.github.com/repos/Microsoft/vs-threading/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vs-threading/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vs-threading/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vs-threading/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vs-threading/statuses/facbc7364448ee18a7c97f2ffc31ffe78dedd2d5"}}}}
{"actor":{"display_login":"IlyaBiryukov"}}