{"action":"created","issue":{"url":"https://api.github.com/repos/sindresorhus/delay/issues/23","repository_url":"https://api.github.com/repos/sindresorhus/delay","labels_url":"https://api.github.com/repos/sindresorhus/delay/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/sindresorhus/delay/issues/23/comments","events_url":"https://api.github.com/repos/sindresorhus/delay/issues/23/events","html_url":"https://github.com/sindresorhus/delay/pull/23","id":277248346,"number":23,"title":"Remove thunk API","user":{"login":"olsonpm","id":5957709,"avatar_url":"https://avatars2.githubusercontent.com/u/5957709?v=4","gravatar_id":"","url":"https://api.github.com/users/olsonpm","html_url":"https://github.com/olsonpm","followers_url":"https://api.github.com/users/olsonpm/followers","following_url":"https://api.github.com/users/olsonpm/following{/other_user}","gists_url":"https://api.github.com/users/olsonpm/gists{/gist_id}","starred_url":"https://api.github.com/users/olsonpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olsonpm/subscriptions","organizations_url":"https://api.github.com/users/olsonpm/orgs","repos_url":"https://api.github.com/users/olsonpm/repos","events_url":"https://api.github.com/users/olsonpm/events{/privacy}","received_events_url":"https://api.github.com/users/olsonpm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-11-28T03:41:43Z","updated_at":"2017-12-10T11:15:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sindresorhus/delay/pulls/23","html_url":"https://github.com/sindresorhus/delay/pull/23","diff_url":"https://github.com/sindresorhus/delay/pull/23.diff","patch_url":"https://github.com/sindresorhus/delay/pull/23.patch"},"body":"I know I modified the code a fair bit from the original.  If you'd prefer I keep closer to the original code (e.g. variable names, use of [p-defer](https://github.com/sindresorhus/p-defer), remove package-lock.json) then I will do that.  I can also add any additional tests you have on your mind."},"comment":{"url":"https://api.github.com/repos/sindresorhus/delay/issues/comments/350540964","html_url":"https://github.com/sindresorhus/delay/pull/23#issuecomment-350540964","issue_url":"https://api.github.com/repos/sindresorhus/delay/issues/23","id":350540964,"user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars1.githubusercontent.com/u/170270?v=4","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"created_at":"2017-12-10T11:15:25Z","updated_at":"2017-12-10T11:15:25Z","author_association":"OWNER","body":"> I was going to ask you how you wanted to handle that, granted that work is for another PR.\r\n\r\nYup, definitely. Just wanted to bring it up here as I usually don't have anyone to discuss this with, and I want to do the change now before doing another major version bump.\r\n\r\n> Another thing I don't like about placing cancel right on the promise is it would be confusing for people familiar with semantics such as Bluebird's cancel.\r\n\r\nCurrently, it works like Bluebird's `.cancel()`, but I agree.\r\n\r\nI kinda want to remove the `.cancel()` semantics from this module and just do a `.clear()` method that does what you would expect. If people need `.cancel()` semantics, they could just wrap it in [`p-cancelable`](https://github.com/sindresorhus/p-cancelable).\r\n\r\nWhat do you think?\r\n\r\n> Resolving with the complete value also sounds reasonable. For some reason I still think the promise should pass the knowledge that it was cancelled/cleared in some way.\r\n\r\nI understand needing to know if it was canceled, but I don't think being cleared is something that should be known from the outside. It changes nothing for the consumer other than the operation finishing sooner. They will still have the full value.\r\n"}}
{"actor":{"display_login":"sindresorhus"}}