{"action":"created","comment":{"url":"https://api.github.com/repos/Kitware/fletch/pulls/comments/133457682","pull_request_review_id":56629290,"id":133457682,"diff_hunk":"@@ -0,0 +1,150 @@\n+# This file is included from a subdirectory","path":"Patches/OpenCV/3.1.0/common.cmake","position":1,"original_position":1,"commit_id":"6e736a7c32cc00940e564ab5eecdff9418137866","original_commit_id":"1e067f0749d580ce6c90dab596a331c2bcf4ffda","user":{"login":"dstoup","id":5521498,"avatar_url":"https://avatars3.githubusercontent.com/u/5521498?v=4","gravatar_id":"","url":"https://api.github.com/users/dstoup","html_url":"https://github.com/dstoup","followers_url":"https://api.github.com/users/dstoup/followers","following_url":"https://api.github.com/users/dstoup/following{/other_user}","gists_url":"https://api.github.com/users/dstoup/gists{/gist_id}","starred_url":"https://api.github.com/users/dstoup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstoup/subscriptions","organizations_url":"https://api.github.com/users/dstoup/orgs","repos_url":"https://api.github.com/users/dstoup/repos","events_url":"https://api.github.com/users/dstoup/events{/privacy}","received_events_url":"https://api.github.com/users/dstoup/received_events","type":"User","site_admin":false},"body":"Again, not trying to make more work but, my preference for patching code is to do it in 2 commits. The first commit adds the file, the second commit applies the patch. That allows us to see exactly what was changed in the file.\r\n\r\nHaving said that, I think that line should be added to a developer contribution document if we have such a thing.  ","created_at":"2017-08-16T14:00:39Z","updated_at":"2017-08-16T14:03:33Z","html_url":"https://github.com/Kitware/fletch/pull/174#discussion_r133457682","pull_request_url":"https://api.github.com/repos/Kitware/fletch/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/Kitware/fletch/pulls/comments/133457682"},"html":{"href":"https://github.com/Kitware/fletch/pull/174#discussion_r133457682"},"pull_request":{"href":"https://api.github.com/repos/Kitware/fletch/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/Kitware/fletch/pulls/174","id":134226470,"html_url":"https://github.com/Kitware/fletch/pull/174","diff_url":"https://github.com/Kitware/fletch/pull/174.diff","patch_url":"https://github.com/Kitware/fletch/pull/174.patch","issue_url":"https://api.github.com/repos/Kitware/fletch/issues/174","number":174,"state":"open","locked":false,"title":"Versioned OpenCV and added patch for 3.1.0","user":{"login":"Erotemic","id":3186211,"avatar_url":"https://avatars3.githubusercontent.com/u/3186211?v=4","gravatar_id":"","url":"https://api.github.com/users/Erotemic","html_url":"https://github.com/Erotemic","followers_url":"https://api.github.com/users/Erotemic/followers","following_url":"https://api.github.com/users/Erotemic/following{/other_user}","gists_url":"https://api.github.com/users/Erotemic/gists{/gist_id}","starred_url":"https://api.github.com/users/Erotemic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Erotemic/subscriptions","organizations_url":"https://api.github.com/users/Erotemic/orgs","repos_url":"https://api.github.com/users/Erotemic/repos","events_url":"https://api.github.com/users/Erotemic/events{/privacy}","received_events_url":"https://api.github.com/users/Erotemic/received_events","type":"User","site_admin":false},"body":"This PR updates OpenCV patches to use the versioning conventions proposed in #173 \r\nThis exposes 3.2.0 as an option, but leaves the current version (3.1.0) as the default.  \r\n\r\nIn addition, this patches a bug in version 3.1.0 (which was fixed in 3.2.0), which is described [here](http://answers.opencv.org/question/86541/opencv-make/). This bug would cause the build to fail if the string `cuda` was found anywhere in the path to the build directory.","created_at":"2017-08-04T18:36:46Z","updated_at":"2017-08-16T14:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"443a52159bb3725da865b3bc0249ea5062b1c4a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kitware/fletch/pulls/174/commits","review_comments_url":"https://api.github.com/repos/Kitware/fletch/pulls/174/comments","review_comment_url":"https://api.github.com/repos/Kitware/fletch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kitware/fletch/issues/174/comments","statuses_url":"https://api.github.com/repos/Kitware/fletch/statuses/6e736a7c32cc00940e564ab5eecdff9418137866","head":{"label":"Erotemic:dev/update-opencv","ref":"dev/update-opencv","sha":"6e736a7c32cc00940e564ab5eecdff9418137866","user":{"login":"Erotemic","id":3186211,"avatar_url":"https://avatars3.githubusercontent.com/u/3186211?v=4","gravatar_id":"","url":"https://api.github.com/users/Erotemic","html_url":"https://github.com/Erotemic","followers_url":"https://api.github.com/users/Erotemic/followers","following_url":"https://api.github.com/users/Erotemic/following{/other_user}","gists_url":"https://api.github.com/users/Erotemic/gists{/gist_id}","starred_url":"https://api.github.com/users/Erotemic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Erotemic/subscriptions","organizations_url":"https://api.github.com/users/Erotemic/orgs","repos_url":"https://api.github.com/users/Erotemic/repos","events_url":"https://api.github.com/users/Erotemic/events{/privacy}","received_events_url":"https://api.github.com/users/Erotemic/received_events","type":"User","site_admin":false},"repo":{"id":99159658,"name":"fletch","full_name":"Erotemic/fletch","owner":{"login":"Erotemic","id":3186211,"avatar_url":"https://avatars3.githubusercontent.com/u/3186211?v=4","gravatar_id":"","url":"https://api.github.com/users/Erotemic","html_url":"https://github.com/Erotemic","followers_url":"https://api.github.com/users/Erotemic/followers","following_url":"https://api.github.com/users/Erotemic/following{/other_user}","gists_url":"https://api.github.com/users/Erotemic/gists{/gist_id}","starred_url":"https://api.github.com/users/Erotemic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Erotemic/subscriptions","organizations_url":"https://api.github.com/users/Erotemic/orgs","repos_url":"https://api.github.com/users/Erotemic/repos","events_url":"https://api.github.com/users/Erotemic/events{/privacy}","received_events_url":"https://api.github.com/users/Erotemic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Erotemic/fletch","description":null,"fork":true,"url":"https://api.github.com/repos/Erotemic/fletch","forks_url":"https://api.github.com/repos/Erotemic/fletch/forks","keys_url":"https://api.github.com/repos/Erotemic/fletch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Erotemic/fletch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Erotemic/fletch/teams","hooks_url":"https://api.github.com/repos/Erotemic/fletch/hooks","issue_events_url":"https://api.github.com/repos/Erotemic/fletch/issues/events{/number}","events_url":"https://api.github.com/repos/Erotemic/fletch/events","assignees_url":"https://api.github.com/repos/Erotemic/fletch/assignees{/user}","branches_url":"https://api.github.com/repos/Erotemic/fletch/branches{/branch}","tags_url":"https://api.github.com/repos/Erotemic/fletch/tags","blobs_url":"https://api.github.com/repos/Erotemic/fletch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Erotemic/fletch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Erotemic/fletch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Erotemic/fletch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Erotemic/fletch/statuses/{sha}","languages_url":"https://api.github.com/repos/Erotemic/fletch/languages","stargazers_url":"https://api.github.com/repos/Erotemic/fletch/stargazers","contributors_url":"https://api.github.com/repos/Erotemic/fletch/contributors","subscribers_url":"https://api.github.com/repos/Erotemic/fletch/subscribers","subscription_url":"https://api.github.com/repos/Erotemic/fletch/subscription","commits_url":"https://api.github.com/repos/Erotemic/fletch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Erotemic/fletch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Erotemic/fletch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Erotemic/fletch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Erotemic/fletch/contents/{+path}","compare_url":"https://api.github.com/repos/Erotemic/fletch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Erotemic/fletch/merges","archive_url":"https://api.github.com/repos/Erotemic/fletch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Erotemic/fletch/downloads","issues_url":"https://api.github.com/repos/Erotemic/fletch/issues{/number}","pulls_url":"https://api.github.com/repos/Erotemic/fletch/pulls{/number}","milestones_url":"https://api.github.com/repos/Erotemic/fletch/milestones{/number}","notifications_url":"https://api.github.com/repos/Erotemic/fletch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Erotemic/fletch/labels{/name}","releases_url":"https://api.github.com/repos/Erotemic/fletch/releases{/id}","deployments_url":"https://api.github.com/repos/Erotemic/fletch/deployments","created_at":"2017-08-02T20:49:08Z","updated_at":"2017-08-02T20:49:11Z","pushed_at":"2017-08-16T13:20:51Z","git_url":"git://github.com/Erotemic/fletch.git","ssh_url":"git@github.com:Erotemic/fletch.git","clone_url":"https://github.com/Erotemic/fletch.git","svn_url":"https://github.com/Erotemic/fletch","homepage":null,"size":1868,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Kitware:master","ref":"master","sha":"a9bd525693a7974635e4e0654c5d110f163acf75","user":{"login":"Kitware","id":87549,"avatar_url":"https://avatars3.githubusercontent.com/u/87549?v=4","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"repo":{"id":30549625,"name":"fletch","full_name":"Kitware/fletch","owner":{"login":"Kitware","id":87549,"avatar_url":"https://avatars3.githubusercontent.com/u/87549?v=4","gravatar_id":"","url":"https://api.github.com/users/Kitware","html_url":"https://github.com/Kitware","followers_url":"https://api.github.com/users/Kitware/followers","following_url":"https://api.github.com/users/Kitware/following{/other_user}","gists_url":"https://api.github.com/users/Kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/Kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kitware/subscriptions","organizations_url":"https://api.github.com/users/Kitware/orgs","repos_url":"https://api.github.com/users/Kitware/repos","events_url":"https://api.github.com/users/Kitware/events{/privacy}","received_events_url":"https://api.github.com/users/Kitware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kitware/fletch","description":null,"fork":false,"url":"https://api.github.com/repos/Kitware/fletch","forks_url":"https://api.github.com/repos/Kitware/fletch/forks","keys_url":"https://api.github.com/repos/Kitware/fletch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kitware/fletch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kitware/fletch/teams","hooks_url":"https://api.github.com/repos/Kitware/fletch/hooks","issue_events_url":"https://api.github.com/repos/Kitware/fletch/issues/events{/number}","events_url":"https://api.github.com/repos/Kitware/fletch/events","assignees_url":"https://api.github.com/repos/Kitware/fletch/assignees{/user}","branches_url":"https://api.github.com/repos/Kitware/fletch/branches{/branch}","tags_url":"https://api.github.com/repos/Kitware/fletch/tags","blobs_url":"https://api.github.com/repos/Kitware/fletch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kitware/fletch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kitware/fletch/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kitware/fletch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kitware/fletch/statuses/{sha}","languages_url":"https://api.github.com/repos/Kitware/fletch/languages","stargazers_url":"https://api.github.com/repos/Kitware/fletch/stargazers","contributors_url":"https://api.github.com/repos/Kitware/fletch/contributors","subscribers_url":"https://api.github.com/repos/Kitware/fletch/subscribers","subscription_url":"https://api.github.com/repos/Kitware/fletch/subscription","commits_url":"https://api.github.com/repos/Kitware/fletch/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kitware/fletch/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kitware/fletch/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kitware/fletch/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kitware/fletch/contents/{+path}","compare_url":"https://api.github.com/repos/Kitware/fletch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kitware/fletch/merges","archive_url":"https://api.github.com/repos/Kitware/fletch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kitware/fletch/downloads","issues_url":"https://api.github.com/repos/Kitware/fletch/issues{/number}","pulls_url":"https://api.github.com/repos/Kitware/fletch/pulls{/number}","milestones_url":"https://api.github.com/repos/Kitware/fletch/milestones{/number}","notifications_url":"https://api.github.com/repos/Kitware/fletch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kitware/fletch/labels{/name}","releases_url":"https://api.github.com/repos/Kitware/fletch/releases{/id}","deployments_url":"https://api.github.com/repos/Kitware/fletch/deployments","created_at":"2015-02-09T17:54:44Z","updated_at":"2017-07-15T23:11:35Z","pushed_at":"2017-08-16T13:20:52Z","git_url":"git://github.com/Kitware/fletch.git","ssh_url":"git@github.com:Kitware/fletch.git","clone_url":"https://github.com/Kitware/fletch.git","svn_url":"https://github.com/Kitware/fletch","homepage":null,"size":1831,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":30,"forks":20,"open_issues":30,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kitware/fletch/pulls/174"},"html":{"href":"https://github.com/Kitware/fletch/pull/174"},"issue":{"href":"https://api.github.com/repos/Kitware/fletch/issues/174"},"comments":{"href":"https://api.github.com/repos/Kitware/fletch/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/Kitware/fletch/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/Kitware/fletch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kitware/fletch/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/Kitware/fletch/statuses/6e736a7c32cc00940e564ab5eecdff9418137866"}}}}
{"actor":{"display_login":"dstoup"}}