{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/32258","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/32258/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/32258/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/32258/events","html_url":"https://github.com/NixOS/nixpkgs/pull/32258","id":278705230,"number":32258,"title":"nat: add extraCommands option","user":{"login":"ryantrinkle","id":1156448,"avatar_url":"https://avatars1.githubusercontent.com/u/1156448?v=4","gravatar_id":"","url":"https://api.github.com/users/ryantrinkle","html_url":"https://github.com/ryantrinkle","followers_url":"https://api.github.com/users/ryantrinkle/followers","following_url":"https://api.github.com/users/ryantrinkle/following{/other_user}","gists_url":"https://api.github.com/users/ryantrinkle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantrinkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantrinkle/subscriptions","organizations_url":"https://api.github.com/users/ryantrinkle/orgs","repos_url":"https://api.github.com/users/ryantrinkle/repos","events_url":"https://api.github.com/users/ryantrinkle/events{/privacy}","received_events_url":"https://api.github.com/users/ryantrinkle/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-12-02T18:23:26Z","updated_at":"2017-12-06T16:32:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/32258","html_url":"https://github.com/NixOS/nixpkgs/pull/32258","diff_url":"https://github.com/NixOS/nixpkgs/pull/32258.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/32258.patch"},"body":"###### Motivation for this change\r\n\r\nDue to the order in which the iptables rules are combined, it's not possible to write some NAT rules in `networking.firewall.extraCommands`.  This PR adds `networking.nat.extraCommands`, which is inserted in the appropriate place for users to add their own custom NAT commands.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/349695683","html_url":"https://github.com/NixOS/nixpkgs/pull/32258#issuecomment-349695683","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/32258","id":349695683,"user":{"login":"ryantrinkle","id":1156448,"avatar_url":"https://avatars1.githubusercontent.com/u/1156448?v=4","gravatar_id":"","url":"https://api.github.com/users/ryantrinkle","html_url":"https://github.com/ryantrinkle","followers_url":"https://api.github.com/users/ryantrinkle/followers","following_url":"https://api.github.com/users/ryantrinkle/following{/other_user}","gists_url":"https://api.github.com/users/ryantrinkle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryantrinkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryantrinkle/subscriptions","organizations_url":"https://api.github.com/users/ryantrinkle/orgs","repos_url":"https://api.github.com/users/ryantrinkle/repos","events_url":"https://api.github.com/users/ryantrinkle/events{/privacy}","received_events_url":"https://api.github.com/users/ryantrinkle/received_events","type":"User","site_admin":false},"created_at":"2017-12-06T16:32:57Z","updated_at":"2017-12-06T16:32:57Z","author_association":"CONTRIBUTOR","body":"@volhovm Ah ok, cool!  I kept it a bit shorter here, and just made it the opposite of the example extraCommands, so hopefully that will give people a good enough sense of what to do!"}}
{"actor":{"display_login":"ryantrinkle"}}