{"action":"created","comment":{"url":"https://api.github.com/repos/apache/drill/pulls/comments/99408793","pull_request_review_id":20088895,"id":99408793,"diff_hunk":"@@ -77,12 +77,14 @@\n    */\n   public static String getPrettyDuration(long startTimeMillis, long endTimeMillis) {\n     long durationInMillis = (startTimeMillis > endTimeMillis ? System.currentTimeMillis() : endTimeMillis) - startTimeMillis;\n-    long hours = TimeUnit.MILLISECONDS.toHours(durationInMillis);\n+    long days = TimeUnit.MILLISECONDS.toDays(durationInMillis);","path":"exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java","position":5,"original_position":5,"commit_id":"c1fa2cb2d1a8dcf96603bbd448a86fed8f1ec3a6","original_commit_id":"c1fa2cb2d1a8dcf96603bbd448a86fed8f1ec3a6","user":{"login":"kkhatua","id":4335237,"avatar_url":"https://avatars.githubusercontent.com/u/4335237?v=3","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},"body":"@paul-rogers , The format in DRILL-5230 is compacted to an approximation (i.e. we retain the 2 largest units of time) so as to fit within the cells of a table. \r\nThis format is more verbose as it gives the complete picture, down to the smallest unit of time. Do we want to still merge the two into a single utility method?\r\n","created_at":"2017-02-03T19:44:07Z","updated_at":"2017-02-03T19:44:07Z","html_url":"https://github.com/apache/drill/pull/738#discussion_r99408793","pull_request_url":"https://api.github.com/repos/apache/drill/pulls/738","_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/comments/99408793"},"html":{"href":"https://github.com/apache/drill/pull/738#discussion_r99408793"},"pull_request":{"href":"https://api.github.com/repos/apache/drill/pulls/738"}}},"pull_request":{"url":"https://api.github.com/repos/apache/drill/pulls/738","id":104427413,"html_url":"https://github.com/apache/drill/pull/738","diff_url":"https://github.com/apache/drill/pull/738.diff","patch_url":"https://github.com/apache/drill/pull/738.patch","issue_url":"https://api.github.com/repos/apache/drill/issues/738","number":738,"state":"open","locked":false,"title":"DRILL-5190: Display planning time for a query in its profile page","user":{"login":"kkhatua","id":4335237,"avatar_url":"https://avatars.githubusercontent.com/u/4335237?v=3","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},"body":"Modified UserSharedBit protobuf for marking planning end time. This will allow for accurately reporting the planning time of a query.\r\nIn the absence of this property, for older profiles, the root fragment's (i.e. SCREEN operator) start time is taken as the estimated end of planning time.","created_at":"2017-02-02T21:29:34Z","updated_at":"2017-02-03T19:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8e2dbd123236bd3fde86638a9148b300d34c6d6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/drill/pulls/738/commits","review_comments_url":"https://api.github.com/repos/apache/drill/pulls/738/comments","review_comment_url":"https://api.github.com/repos/apache/drill/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/drill/issues/738/comments","statuses_url":"https://api.github.com/repos/apache/drill/statuses/c1fa2cb2d1a8dcf96603bbd448a86fed8f1ec3a6","head":{"label":"kkhatua:DRILL-5190","ref":"DRILL-5190","sha":"c1fa2cb2d1a8dcf96603bbd448a86fed8f1ec3a6","user":{"login":"kkhatua","id":4335237,"avatar_url":"https://avatars.githubusercontent.com/u/4335237?v=3","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},"repo":{"id":78692639,"name":"drill","full_name":"kkhatua/drill","owner":{"login":"kkhatua","id":4335237,"avatar_url":"https://avatars.githubusercontent.com/u/4335237?v=3","gravatar_id":"","url":"https://api.github.com/users/kkhatua","html_url":"https://github.com/kkhatua","followers_url":"https://api.github.com/users/kkhatua/followers","following_url":"https://api.github.com/users/kkhatua/following{/other_user}","gists_url":"https://api.github.com/users/kkhatua/gists{/gist_id}","starred_url":"https://api.github.com/users/kkhatua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkhatua/subscriptions","organizations_url":"https://api.github.com/users/kkhatua/orgs","repos_url":"https://api.github.com/users/kkhatua/repos","events_url":"https://api.github.com/users/kkhatua/events{/privacy}","received_events_url":"https://api.github.com/users/kkhatua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkhatua/drill","description":"Mirror of Apache Drill","fork":true,"url":"https://api.github.com/repos/kkhatua/drill","forks_url":"https://api.github.com/repos/kkhatua/drill/forks","keys_url":"https://api.github.com/repos/kkhatua/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkhatua/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkhatua/drill/teams","hooks_url":"https://api.github.com/repos/kkhatua/drill/hooks","issue_events_url":"https://api.github.com/repos/kkhatua/drill/issues/events{/number}","events_url":"https://api.github.com/repos/kkhatua/drill/events","assignees_url":"https://api.github.com/repos/kkhatua/drill/assignees{/user}","branches_url":"https://api.github.com/repos/kkhatua/drill/branches{/branch}","tags_url":"https://api.github.com/repos/kkhatua/drill/tags","blobs_url":"https://api.github.com/repos/kkhatua/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkhatua/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkhatua/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkhatua/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkhatua/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/kkhatua/drill/languages","stargazers_url":"https://api.github.com/repos/kkhatua/drill/stargazers","contributors_url":"https://api.github.com/repos/kkhatua/drill/contributors","subscribers_url":"https://api.github.com/repos/kkhatua/drill/subscribers","subscription_url":"https://api.github.com/repos/kkhatua/drill/subscription","commits_url":"https://api.github.com/repos/kkhatua/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkhatua/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkhatua/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkhatua/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkhatua/drill/contents/{+path}","compare_url":"https://api.github.com/repos/kkhatua/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkhatua/drill/merges","archive_url":"https://api.github.com/repos/kkhatua/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkhatua/drill/downloads","issues_url":"https://api.github.com/repos/kkhatua/drill/issues{/number}","pulls_url":"https://api.github.com/repos/kkhatua/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/kkhatua/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/kkhatua/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkhatua/drill/labels{/name}","releases_url":"https://api.github.com/repos/kkhatua/drill/releases{/id}","deployments_url":"https://api.github.com/repos/kkhatua/drill/deployments","created_at":"2017-01-12T00:27:42Z","updated_at":"2017-01-12T00:27:54Z","pushed_at":"2017-02-03T19:35:14Z","git_url":"git://github.com/kkhatua/drill.git","ssh_url":"git@github.com:kkhatua/drill.git","clone_url":"https://github.com/kkhatua/drill.git","svn_url":"https://github.com/kkhatua/drill","homepage":"","size":44385,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"88655adfea8e7884e67559d9ff6053b01890ad7a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":5683653,"name":"drill","full_name":"apache/drill","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/drill","description":"Mirror of Apache Drill","fork":false,"url":"https://api.github.com/repos/apache/drill","forks_url":"https://api.github.com/repos/apache/drill/forks","keys_url":"https://api.github.com/repos/apache/drill/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/drill/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/drill/teams","hooks_url":"https://api.github.com/repos/apache/drill/hooks","issue_events_url":"https://api.github.com/repos/apache/drill/issues/events{/number}","events_url":"https://api.github.com/repos/apache/drill/events","assignees_url":"https://api.github.com/repos/apache/drill/assignees{/user}","branches_url":"https://api.github.com/repos/apache/drill/branches{/branch}","tags_url":"https://api.github.com/repos/apache/drill/tags","blobs_url":"https://api.github.com/repos/apache/drill/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/drill/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/drill/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/drill/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/drill/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/drill/languages","stargazers_url":"https://api.github.com/repos/apache/drill/stargazers","contributors_url":"https://api.github.com/repos/apache/drill/contributors","subscribers_url":"https://api.github.com/repos/apache/drill/subscribers","subscription_url":"https://api.github.com/repos/apache/drill/subscription","commits_url":"https://api.github.com/repos/apache/drill/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/drill/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/drill/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/drill/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/drill/contents/{+path}","compare_url":"https://api.github.com/repos/apache/drill/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/drill/merges","archive_url":"https://api.github.com/repos/apache/drill/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/drill/downloads","issues_url":"https://api.github.com/repos/apache/drill/issues{/number}","pulls_url":"https://api.github.com/repos/apache/drill/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/drill/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/drill/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/drill/labels{/name}","releases_url":"https://api.github.com/repos/apache/drill/releases{/id}","deployments_url":"https://api.github.com/repos/apache/drill/deployments","created_at":"2012-09-05T07:00:26Z","updated_at":"2017-02-02T15:24:31Z","pushed_at":"2017-02-03T19:35:16Z","git_url":"git://github.com/apache/drill.git","ssh_url":"git@github.com:apache/drill.git","clone_url":"https://github.com/apache/drill.git","svn_url":"https://github.com/apache/drill","homepage":"","size":44407,"stargazers_count":748,"watchers_count":748,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":513,"mirror_url":"git://git.apache.org/drill.git","open_issues_count":139,"forks":513,"open_issues":139,"watchers":748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/drill/pulls/738"},"html":{"href":"https://github.com/apache/drill/pull/738"},"issue":{"href":"https://api.github.com/repos/apache/drill/issues/738"},"comments":{"href":"https://api.github.com/repos/apache/drill/issues/738/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/drill/pulls/738/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/drill/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/drill/pulls/738/commits"},"statuses":{"href":"https://api.github.com/repos/apache/drill/statuses/c1fa2cb2d1a8dcf96603bbd448a86fed8f1ec3a6"}}}}
{"actor":{"display_login":"kkhatua"}}