{"action":"opened","number":3398,"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/3398","id":117034368,"html_url":"https://github.com/open-mpi/ompi/pull/3398","diff_url":"https://github.com/open-mpi/ompi/pull/3398.diff","patch_url":"https://github.com/open-mpi/ompi/pull/3398.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/3398","number":3398,"state":"open","locked":false,"title":"Implement a background fence that collects all data during modex operation","user":{"login":"rhc54","id":2440928,"avatar_url":"https://avatars2.githubusercontent.com/u/2440928?v=3","gravatar_id":"","url":"https://api.github.com/users/rhc54","html_url":"https://github.com/rhc54","followers_url":"https://api.github.com/users/rhc54/followers","following_url":"https://api.github.com/users/rhc54/following{/other_user}","gists_url":"https://api.github.com/users/rhc54/gists{/gist_id}","starred_url":"https://api.github.com/users/rhc54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhc54/subscriptions","organizations_url":"https://api.github.com/users/rhc54/orgs","repos_url":"https://api.github.com/users/rhc54/repos","events_url":"https://api.github.com/users/rhc54/events{/privacy}","received_events_url":"https://api.github.com/users/rhc54/received_events","type":"User","site_admin":false},"body":"The direct modex operation is slow, especially at scale for even modestly-connected applications. Likewise, blocking in MPI_Init while we wait for a full modex to complete takes too long. However, as George pointed out, there is a middle ground here. We could kickoff the modex operation in the background, and then trap any modex_recv's until the modex completes and the data is delivered. For most non-benchmark apps, this may prove to be the best of the available options as they are likely to perform other (non-communicating) setup operations after MPI_Init, and so there is a reasonable chance that the modex will actually be done before the first modex_recv gets called.\r\n\r\nOnce we get instant-on-enabled hardware, this won't be necessary. Clearly, zero time will always out-perform the time spent doing a modex. However, this provides a decent compromise in the interim.\r\n\r\nThis PR changes the default settings of a few relevant params to make \"background modex\" the default behavior:\r\n\r\n* pmix_base_async_modex -> defaults to true\r\n\r\n* pmix_base_collect_data -> continues to default to true (no change)\r\n\r\n* async_mpi_init - defaults to true. Note that the prior code attempted to base the default setting of this value on the setting of pmix_base_async_modex. Unfortunately, the pmix value isn't set prior to setting async_mpi_init, and so that attempt failed to accomplish anything.\r\n\r\nThe logic in MPI_Init is:\r\n\r\n* if async_modex AND collect_data are set, AND we have a non-blocking fence available, then we execute the background modex operation\r\n\r\n* if async_modex is set, but collect_data is false, then we simply skip the modex entirely - no fence is performed\r\n\r\n* if async_modex is not set, then we block until the fence completes (regardless of collecting data or not)\r\n\r\n* if we do NOT have a non-blocking fence (e.g., we are not using PMIx), then we always perform the full blocking modex operation.\r\n\r\n* if we do perform the background modex, and the user requested the barrier be performed at the end of MPI_Init, then we check to see if the modex has completed when we reach that point. If it has, then we execute the barrier. However, if the modex has NOT completed, then we block until the modex does complete and skip the extra barrier. So we never perform two barriers in that case.\r\n\r\nSigned-off-by: Ralph Castain <rhc@open-mpi.org>","created_at":"2017-04-21T17:43:00Z","updated_at":"2017-04-21T17:43:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/ompi/pulls/3398/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi/pulls/3398/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/3398/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/9fc3079ac2eb6e0fd54264e2062e6477c1930bdb","head":{"label":"rhc54:topic/modex","ref":"topic/modex","sha":"9fc3079ac2eb6e0fd54264e2062e6477c1930bdb","user":{"login":"rhc54","id":2440928,"avatar_url":"https://avatars2.githubusercontent.com/u/2440928?v=3","gravatar_id":"","url":"https://api.github.com/users/rhc54","html_url":"https://github.com/rhc54","followers_url":"https://api.github.com/users/rhc54/followers","following_url":"https://api.github.com/users/rhc54/following{/other_user}","gists_url":"https://api.github.com/users/rhc54/gists{/gist_id}","starred_url":"https://api.github.com/users/rhc54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhc54/subscriptions","organizations_url":"https://api.github.com/users/rhc54/orgs","repos_url":"https://api.github.com/users/rhc54/repos","events_url":"https://api.github.com/users/rhc54/events{/privacy}","received_events_url":"https://api.github.com/users/rhc54/received_events","type":"User","site_admin":false},"repo":{"id":75768233,"name":"ompi","full_name":"rhc54/ompi","owner":{"login":"rhc54","id":2440928,"avatar_url":"https://avatars2.githubusercontent.com/u/2440928?v=3","gravatar_id":"","url":"https://api.github.com/users/rhc54","html_url":"https://github.com/rhc54","followers_url":"https://api.github.com/users/rhc54/followers","following_url":"https://api.github.com/users/rhc54/following{/other_user}","gists_url":"https://api.github.com/users/rhc54/gists{/gist_id}","starred_url":"https://api.github.com/users/rhc54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhc54/subscriptions","organizations_url":"https://api.github.com/users/rhc54/orgs","repos_url":"https://api.github.com/users/rhc54/repos","events_url":"https://api.github.com/users/rhc54/events{/privacy}","received_events_url":"https://api.github.com/users/rhc54/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhc54/ompi","description":"Open MPI main development repository","fork":true,"url":"https://api.github.com/repos/rhc54/ompi","forks_url":"https://api.github.com/repos/rhc54/ompi/forks","keys_url":"https://api.github.com/repos/rhc54/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhc54/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhc54/ompi/teams","hooks_url":"https://api.github.com/repos/rhc54/ompi/hooks","issue_events_url":"https://api.github.com/repos/rhc54/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/rhc54/ompi/events","assignees_url":"https://api.github.com/repos/rhc54/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/rhc54/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/rhc54/ompi/tags","blobs_url":"https://api.github.com/repos/rhc54/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhc54/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhc54/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhc54/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhc54/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/rhc54/ompi/languages","stargazers_url":"https://api.github.com/repos/rhc54/ompi/stargazers","contributors_url":"https://api.github.com/repos/rhc54/ompi/contributors","subscribers_url":"https://api.github.com/repos/rhc54/ompi/subscribers","subscription_url":"https://api.github.com/repos/rhc54/ompi/subscription","commits_url":"https://api.github.com/repos/rhc54/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhc54/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhc54/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhc54/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhc54/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/rhc54/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhc54/ompi/merges","archive_url":"https://api.github.com/repos/rhc54/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhc54/ompi/downloads","issues_url":"https://api.github.com/repos/rhc54/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/rhc54/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/rhc54/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/rhc54/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhc54/ompi/labels{/name}","releases_url":"https://api.github.com/repos/rhc54/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/rhc54/ompi/deployments","created_at":"2016-12-06T20:24:47Z","updated_at":"2016-12-06T20:25:04Z","pushed_at":"2017-04-21T17:42:14Z","git_url":"git://github.com/rhc54/ompi.git","ssh_url":"git@github.com:rhc54/ompi.git","clone_url":"https://github.com/rhc54/ompi.git","svn_url":"https://github.com/rhc54/ompi","homepage":null,"size":107521,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"e9e89e502b701db9a76ee798117dcf8e350067da","user":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars2.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107001,"name":"ompi","full_name":"open-mpi/ompi","owner":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars2.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/ompi","description":"Open MPI main development repository","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi","forks_url":"https://api.github.com/repos/open-mpi/ompi/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/open-mpi/ompi/deployments","created_at":"2014-09-16T16:08:30Z","updated_at":"2017-04-21T10:08:44Z","pushed_at":"2017-04-21T16:17:42Z","git_url":"git://github.com/open-mpi/ompi.git","ssh_url":"git@github.com:open-mpi/ompi.git","clone_url":"https://github.com/open-mpi/ompi.git","svn_url":"https://github.com/open-mpi/ompi","homepage":null,"size":107599,"stargazers_count":293,"watchers_count":293,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":209,"mirror_url":null,"open_issues_count":403,"forks":209,"open_issues":403,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/3398"},"html":{"href":"https://github.com/open-mpi/ompi/pull/3398"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/3398"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/3398/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/3398/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/3398/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi/statuses/9fc3079ac2eb6e0fd54264e2062e6477c1930bdb"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":108,"deletions":27,"changed_files":10}}
{"actor":{"display_login":"rhc54"}}