{"action":"created","comment":{"url":"https://api.github.com/repos/paypal/glamorous/pulls/comments/110425123","pull_request_review_id":31600582,"id":110425123,"diff_hunk":"@@ -5,7 +5,11 @@\n import React from 'react'\n import {css, styleSheet} from 'glamor'\n import shouldForwardProperty from './should-forward-property'\n-import domElements from './dom-elements'\n+\n+const htmlTagNames = require('html-tag-names')\n+const svgTagNames = require('svg-tag-names')","path":"src/index.js","position":7,"original_position":7,"commit_id":"455750189bd1c0cfb5aa4482c946b6b324ce59c4","original_commit_id":"455750189bd1c0cfb5aa4482c946b6b324ce59c4","user":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars3.githubusercontent.com/u/1500684?v=3","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"body":"Instead of `require` I'd prefer to use ESModules with `import` statements:\r\n\r\n```javascript\r\nimport htmlTagNames from 'html-tag-names'\r\nimport svgTagNames from 'svg-tag-names'\r\n```","created_at":"2017-04-07T16:05:19Z","updated_at":"2017-04-07T16:05:27Z","html_url":"https://github.com/paypal/glamorous/pull/26#discussion_r110425123","pull_request_url":"https://api.github.com/repos/paypal/glamorous/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/paypal/glamorous/pulls/comments/110425123"},"html":{"href":"https://github.com/paypal/glamorous/pull/26#discussion_r110425123"},"pull_request":{"href":"https://api.github.com/repos/paypal/glamorous/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/paypal/glamorous/pulls/26","id":114755147,"html_url":"https://github.com/paypal/glamorous/pull/26","diff_url":"https://github.com/paypal/glamorous/pull/26.diff","patch_url":"https://github.com/paypal/glamorous/pull/26.patch","issue_url":"https://api.github.com/repos/paypal/glamorous/issues/26","number":26,"state":"open","locked":false,"title":"refactor: use html-tag-names","user":{"login":"tsriram","id":450559,"avatar_url":"https://avatars0.githubusercontent.com/u/450559?v=3","gravatar_id":"","url":"https://api.github.com/users/tsriram","html_url":"https://github.com/tsriram","followers_url":"https://api.github.com/users/tsriram/followers","following_url":"https://api.github.com/users/tsriram/following{/other_user}","gists_url":"https://api.github.com/users/tsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/tsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsriram/subscriptions","organizations_url":"https://api.github.com/users/tsriram/orgs","repos_url":"https://api.github.com/users/tsriram/repos","events_url":"https://api.github.com/users/tsriram/events{/privacy}","received_events_url":"https://api.github.com/users/tsriram/received_events","type":"User","site_admin":false},"body":"We'd been using a local file (src/dom-elements.js) which exported an array of all HTML elements. We\r\nnow use html-tag-names module which has a more comprehensive list of HTML elements.\r\n\r\ncloses #8\r\n\r\n<!--\r\nThanks for your interest in the project. I appreciate bugs filed and PRs submitted!\r\n\r\nPlease make sure that you are familiar with and follow the Code of Conduct for\r\nthis project (found in the CODE_OF_CONDUCT.md file).\r\n\r\nAlso, please make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nIf you're new to contributing to open source projects, you might find this free\r\nvideo course helpful: http://kcd.im/pull-request\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n**What**: Refactoring the code to use `html-tag-names` module instead of local file to get the list of HTML elements.\r\n\r\n<!-- Why are these changes necessary? -->\r\n**Why**: `html-tag-names` has more comprehensive and up-to-date list of HTML elements.\r\n\r\n<!-- How were these changes implemented? -->\r\n**How**: Removed the local file `src/dom-elements.js` and added `html-tag-names` as a dependency. \r\n\r\n\r\n<!-- feel free to add additional comments -->\r\n","created_at":"2017-04-07T07:01:53Z","updated_at":"2017-04-07T16:05:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bb45179e1327926583bfbc0367c4cdced8f510a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/glamorous/pulls/26/commits","review_comments_url":"https://api.github.com/repos/paypal/glamorous/pulls/26/comments","review_comment_url":"https://api.github.com/repos/paypal/glamorous/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/glamorous/issues/26/comments","statuses_url":"https://api.github.com/repos/paypal/glamorous/statuses/455750189bd1c0cfb5aa4482c946b6b324ce59c4","head":{"label":"tsriram:html-tag-names","ref":"html-tag-names","sha":"455750189bd1c0cfb5aa4482c946b6b324ce59c4","user":{"login":"tsriram","id":450559,"avatar_url":"https://avatars0.githubusercontent.com/u/450559?v=3","gravatar_id":"","url":"https://api.github.com/users/tsriram","html_url":"https://github.com/tsriram","followers_url":"https://api.github.com/users/tsriram/followers","following_url":"https://api.github.com/users/tsriram/following{/other_user}","gists_url":"https://api.github.com/users/tsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/tsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsriram/subscriptions","organizations_url":"https://api.github.com/users/tsriram/orgs","repos_url":"https://api.github.com/users/tsriram/repos","events_url":"https://api.github.com/users/tsriram/events{/privacy}","received_events_url":"https://api.github.com/users/tsriram/received_events","type":"User","site_admin":false},"repo":{"id":87430494,"name":"glamorous","full_name":"tsriram/glamorous","owner":{"login":"tsriram","id":450559,"avatar_url":"https://avatars0.githubusercontent.com/u/450559?v=3","gravatar_id":"","url":"https://api.github.com/users/tsriram","html_url":"https://github.com/tsriram","followers_url":"https://api.github.com/users/tsriram/followers","following_url":"https://api.github.com/users/tsriram/following{/other_user}","gists_url":"https://api.github.com/users/tsriram/gists{/gist_id}","starred_url":"https://api.github.com/users/tsriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsriram/subscriptions","organizations_url":"https://api.github.com/users/tsriram/orgs","repos_url":"https://api.github.com/users/tsriram/repos","events_url":"https://api.github.com/users/tsriram/events{/privacy}","received_events_url":"https://api.github.com/users/tsriram/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsriram/glamorous","description":"React component styling solved 💄 ","fork":true,"url":"https://api.github.com/repos/tsriram/glamorous","forks_url":"https://api.github.com/repos/tsriram/glamorous/forks","keys_url":"https://api.github.com/repos/tsriram/glamorous/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsriram/glamorous/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsriram/glamorous/teams","hooks_url":"https://api.github.com/repos/tsriram/glamorous/hooks","issue_events_url":"https://api.github.com/repos/tsriram/glamorous/issues/events{/number}","events_url":"https://api.github.com/repos/tsriram/glamorous/events","assignees_url":"https://api.github.com/repos/tsriram/glamorous/assignees{/user}","branches_url":"https://api.github.com/repos/tsriram/glamorous/branches{/branch}","tags_url":"https://api.github.com/repos/tsriram/glamorous/tags","blobs_url":"https://api.github.com/repos/tsriram/glamorous/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsriram/glamorous/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsriram/glamorous/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsriram/glamorous/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsriram/glamorous/statuses/{sha}","languages_url":"https://api.github.com/repos/tsriram/glamorous/languages","stargazers_url":"https://api.github.com/repos/tsriram/glamorous/stargazers","contributors_url":"https://api.github.com/repos/tsriram/glamorous/contributors","subscribers_url":"https://api.github.com/repos/tsriram/glamorous/subscribers","subscription_url":"https://api.github.com/repos/tsriram/glamorous/subscription","commits_url":"https://api.github.com/repos/tsriram/glamorous/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsriram/glamorous/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsriram/glamorous/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsriram/glamorous/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsriram/glamorous/contents/{+path}","compare_url":"https://api.github.com/repos/tsriram/glamorous/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsriram/glamorous/merges","archive_url":"https://api.github.com/repos/tsriram/glamorous/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsriram/glamorous/downloads","issues_url":"https://api.github.com/repos/tsriram/glamorous/issues{/number}","pulls_url":"https://api.github.com/repos/tsriram/glamorous/pulls{/number}","milestones_url":"https://api.github.com/repos/tsriram/glamorous/milestones{/number}","notifications_url":"https://api.github.com/repos/tsriram/glamorous/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsriram/glamorous/labels{/name}","releases_url":"https://api.github.com/repos/tsriram/glamorous/releases{/id}","deployments_url":"https://api.github.com/repos/tsriram/glamorous/deployments","created_at":"2017-04-06T13:06:36Z","updated_at":"2017-04-06T13:06:37Z","pushed_at":"2017-04-07T15:45:24Z","git_url":"git://github.com/tsriram/glamorous.git","ssh_url":"git@github.com:tsriram/glamorous.git","clone_url":"https://github.com/tsriram/glamorous.git","svn_url":"https://github.com/tsriram/glamorous","homepage":"http://npm.im/glamorous","size":135,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"f75fd4556edf826c927e6ffba20a7f950229b133","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars2.githubusercontent.com/u/476675?v=3","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":87123146,"name":"glamorous","full_name":"paypal/glamorous","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars2.githubusercontent.com/u/476675?v=3","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/glamorous","description":"React component styling solved 💄 ","fork":false,"url":"https://api.github.com/repos/paypal/glamorous","forks_url":"https://api.github.com/repos/paypal/glamorous/forks","keys_url":"https://api.github.com/repos/paypal/glamorous/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/glamorous/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/glamorous/teams","hooks_url":"https://api.github.com/repos/paypal/glamorous/hooks","issue_events_url":"https://api.github.com/repos/paypal/glamorous/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/glamorous/events","assignees_url":"https://api.github.com/repos/paypal/glamorous/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/glamorous/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/glamorous/tags","blobs_url":"https://api.github.com/repos/paypal/glamorous/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/glamorous/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/glamorous/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/glamorous/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/glamorous/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/glamorous/languages","stargazers_url":"https://api.github.com/repos/paypal/glamorous/stargazers","contributors_url":"https://api.github.com/repos/paypal/glamorous/contributors","subscribers_url":"https://api.github.com/repos/paypal/glamorous/subscribers","subscription_url":"https://api.github.com/repos/paypal/glamorous/subscription","commits_url":"https://api.github.com/repos/paypal/glamorous/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/glamorous/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/glamorous/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/glamorous/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/glamorous/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/glamorous/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/glamorous/merges","archive_url":"https://api.github.com/repos/paypal/glamorous/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/glamorous/downloads","issues_url":"https://api.github.com/repos/paypal/glamorous/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/glamorous/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/glamorous/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/glamorous/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/glamorous/labels{/name}","releases_url":"https://api.github.com/repos/paypal/glamorous/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/glamorous/deployments","created_at":"2017-04-03T21:35:49Z","updated_at":"2017-04-07T16:02:50Z","pushed_at":"2017-04-07T15:45:26Z","git_url":"git://github.com/paypal/glamorous.git","ssh_url":"git@github.com:paypal/glamorous.git","clone_url":"https://github.com/paypal/glamorous.git","svn_url":"https://github.com/paypal/glamorous","homepage":"http://npm.im/glamorous","size":133,"stargazers_count":671,"watchers_count":671,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":13,"forks":26,"open_issues":13,"watchers":671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/glamorous/pulls/26"},"html":{"href":"https://github.com/paypal/glamorous/pull/26"},"issue":{"href":"https://api.github.com/repos/paypal/glamorous/issues/26"},"comments":{"href":"https://api.github.com/repos/paypal/glamorous/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/glamorous/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/glamorous/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/glamorous/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/glamorous/statuses/455750189bd1c0cfb5aa4482c946b6b324ce59c4"}}}}
{"actor":{"display_login":"kentcdodds"}}