{"action":"created","comment":{"url":"https://api.github.com/repos/deeplook/svglib/pulls/comments/101727365","pull_request_review_id":22464737,"id":101727365,"diff_hunk":"@@ -200,6 +200,13 @@ def convertTransform(self, svgAttr):\n class Svg2RlgAttributeConverter(AttributeConverter):\n     \"A concrete SVG to RLG attribute converter.\"\n \n+    def __init__(self,colorConverter=None):\n+        self.colorConverter = colorConverter or self.identityColorConverter","path":"svglib/svglib.py","position":5,"original_position":5,"commit_id":"2fea7ae2a964cf77f908811396da920203b5d09e","original_commit_id":"2fea7ae2a964cf77f908811396da920203b5d09e","user":{"login":"claudep","id":143192,"avatar_url":"https://avatars.githubusercontent.com/u/143192?v=3","gravatar_id":"","url":"https://api.github.com/users/claudep","html_url":"https://github.com/claudep","followers_url":"https://api.github.com/users/claudep/followers","following_url":"https://api.github.com/users/claudep/following{/other_user}","gists_url":"https://api.github.com/users/claudep/gists{/gist_id}","starred_url":"https://api.github.com/users/claudep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudep/subscriptions","organizations_url":"https://api.github.com/users/claudep/orgs","repos_url":"https://api.github.com/users/claudep/repos","events_url":"https://api.github.com/users/claudep/events{/privacy}","received_events_url":"https://api.github.com/users/claudep/received_events","type":"User","site_admin":false},"body":"We're trying to progressively depart from the old CamelCase syntax to use a more Pythonic syntax with underscores for class attribute and method names. Could you move `colorConverter` to `color_converter`, and the same for the new method?","created_at":"2017-02-17T10:22:24Z","updated_at":"2017-02-17T10:22:24Z","html_url":"https://github.com/deeplook/svglib/pull/73#discussion_r101727365","pull_request_url":"https://api.github.com/repos/deeplook/svglib/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/deeplook/svglib/pulls/comments/101727365"},"html":{"href":"https://github.com/deeplook/svglib/pull/73#discussion_r101727365"},"pull_request":{"href":"https://api.github.com/repos/deeplook/svglib/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/deeplook/svglib/pulls/73","id":106700045,"html_url":"https://github.com/deeplook/svglib/pull/73","diff_url":"https://github.com/deeplook/svglib/pull/73.diff","patch_url":"https://github.com/deeplook/svglib/pull/73.patch","issue_url":"https://api.github.com/repos/deeplook/svglib/issues/73","number":73,"state":"open","locked":false,"title":"add colorConverter option","user":{"login":"replabrobin","id":2532126,"avatar_url":"https://avatars.githubusercontent.com/u/2532126?v=3","gravatar_id":"","url":"https://api.github.com/users/replabrobin","html_url":"https://github.com/replabrobin","followers_url":"https://api.github.com/users/replabrobin/followers","following_url":"https://api.github.com/users/replabrobin/following{/other_user}","gists_url":"https://api.github.com/users/replabrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/replabrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replabrobin/subscriptions","organizations_url":"https://api.github.com/users/replabrobin/orgs","repos_url":"https://api.github.com/users/replabrobin/repos","events_url":"https://api.github.com/users/replabrobin/events{/privacy}","received_events_url":"https://api.github.com/users/replabrobin/received_events","type":"User","site_admin":false},"body":"Hi, when using svglib to create RL drawings for use with existing document flows it may be necessary to use specific color schemes. This pull request does 2 things:\r\n\r\n1) use a single Svg2RlgAttributeConverter instance by passing the renderer instance to the  Svg2RlgShapeConverter instance.\r\n\r\n2) Add optional colorConverter argument to the Svg2RlgAttributeConverter class to allow conversion to take place in convertColor.\r\n\r\nWith these in place I can use svg2rl to make CMYK etc etc drawings.\r\n\r\n--HG--\r\nbranch : colorConverter","created_at":"2017-02-17T09:54:27Z","updated_at":"2017-02-17T10:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a2be8f8fc85ae367646c97b38b995e87e8c27e2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/deeplook/svglib/pulls/73/commits","review_comments_url":"https://api.github.com/repos/deeplook/svglib/pulls/73/comments","review_comment_url":"https://api.github.com/repos/deeplook/svglib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/deeplook/svglib/issues/73/comments","statuses_url":"https://api.github.com/repos/deeplook/svglib/statuses/2fea7ae2a964cf77f908811396da920203b5d09e","head":{"label":"replabrobin:master","ref":"master","sha":"2fea7ae2a964cf77f908811396da920203b5d09e","user":{"login":"replabrobin","id":2532126,"avatar_url":"https://avatars.githubusercontent.com/u/2532126?v=3","gravatar_id":"","url":"https://api.github.com/users/replabrobin","html_url":"https://github.com/replabrobin","followers_url":"https://api.github.com/users/replabrobin/followers","following_url":"https://api.github.com/users/replabrobin/following{/other_user}","gists_url":"https://api.github.com/users/replabrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/replabrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replabrobin/subscriptions","organizations_url":"https://api.github.com/users/replabrobin/orgs","repos_url":"https://api.github.com/users/replabrobin/repos","events_url":"https://api.github.com/users/replabrobin/events{/privacy}","received_events_url":"https://api.github.com/users/replabrobin/received_events","type":"User","site_admin":false},"repo":{"id":80744557,"name":"svglib","full_name":"replabrobin/svglib","owner":{"login":"replabrobin","id":2532126,"avatar_url":"https://avatars.githubusercontent.com/u/2532126?v=3","gravatar_id":"","url":"https://api.github.com/users/replabrobin","html_url":"https://github.com/replabrobin","followers_url":"https://api.github.com/users/replabrobin/followers","following_url":"https://api.github.com/users/replabrobin/following{/other_user}","gists_url":"https://api.github.com/users/replabrobin/gists{/gist_id}","starred_url":"https://api.github.com/users/replabrobin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replabrobin/subscriptions","organizations_url":"https://api.github.com/users/replabrobin/orgs","repos_url":"https://api.github.com/users/replabrobin/repos","events_url":"https://api.github.com/users/replabrobin/events{/privacy}","received_events_url":"https://api.github.com/users/replabrobin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/replabrobin/svglib","description":"Read SVG files and convert them to other formats (moved to here from https://bitbucket.org/deeplook/svglib).","fork":true,"url":"https://api.github.com/repos/replabrobin/svglib","forks_url":"https://api.github.com/repos/replabrobin/svglib/forks","keys_url":"https://api.github.com/repos/replabrobin/svglib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/replabrobin/svglib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/replabrobin/svglib/teams","hooks_url":"https://api.github.com/repos/replabrobin/svglib/hooks","issue_events_url":"https://api.github.com/repos/replabrobin/svglib/issues/events{/number}","events_url":"https://api.github.com/repos/replabrobin/svglib/events","assignees_url":"https://api.github.com/repos/replabrobin/svglib/assignees{/user}","branches_url":"https://api.github.com/repos/replabrobin/svglib/branches{/branch}","tags_url":"https://api.github.com/repos/replabrobin/svglib/tags","blobs_url":"https://api.github.com/repos/replabrobin/svglib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/replabrobin/svglib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/replabrobin/svglib/git/refs{/sha}","trees_url":"https://api.github.com/repos/replabrobin/svglib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/replabrobin/svglib/statuses/{sha}","languages_url":"https://api.github.com/repos/replabrobin/svglib/languages","stargazers_url":"https://api.github.com/repos/replabrobin/svglib/stargazers","contributors_url":"https://api.github.com/repos/replabrobin/svglib/contributors","subscribers_url":"https://api.github.com/repos/replabrobin/svglib/subscribers","subscription_url":"https://api.github.com/repos/replabrobin/svglib/subscription","commits_url":"https://api.github.com/repos/replabrobin/svglib/commits{/sha}","git_commits_url":"https://api.github.com/repos/replabrobin/svglib/git/commits{/sha}","comments_url":"https://api.github.com/repos/replabrobin/svglib/comments{/number}","issue_comment_url":"https://api.github.com/repos/replabrobin/svglib/issues/comments{/number}","contents_url":"https://api.github.com/repos/replabrobin/svglib/contents/{+path}","compare_url":"https://api.github.com/repos/replabrobin/svglib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/replabrobin/svglib/merges","archive_url":"https://api.github.com/repos/replabrobin/svglib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/replabrobin/svglib/downloads","issues_url":"https://api.github.com/repos/replabrobin/svglib/issues{/number}","pulls_url":"https://api.github.com/repos/replabrobin/svglib/pulls{/number}","milestones_url":"https://api.github.com/repos/replabrobin/svglib/milestones{/number}","notifications_url":"https://api.github.com/repos/replabrobin/svglib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/replabrobin/svglib/labels{/name}","releases_url":"https://api.github.com/repos/replabrobin/svglib/releases{/id}","deployments_url":"https://api.github.com/repos/replabrobin/svglib/deployments","created_at":"2017-02-02T16:34:10Z","updated_at":"2017-02-02T16:34:11Z","pushed_at":"2017-02-17T09:42:44Z","git_url":"git://github.com/replabrobin/svglib.git","ssh_url":"git@github.com:replabrobin/svglib.git","clone_url":"https://github.com/replabrobin/svglib.git","svn_url":"https://github.com/replabrobin/svglib","homepage":"","size":703,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"deeplook:master","ref":"master","sha":"f119290706b4b01df71e69e2a321749884219974","user":{"login":"deeplook","id":1001778,"avatar_url":"https://avatars.githubusercontent.com/u/1001778?v=3","gravatar_id":"","url":"https://api.github.com/users/deeplook","html_url":"https://github.com/deeplook","followers_url":"https://api.github.com/users/deeplook/followers","following_url":"https://api.github.com/users/deeplook/following{/other_user}","gists_url":"https://api.github.com/users/deeplook/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplook/subscriptions","organizations_url":"https://api.github.com/users/deeplook/orgs","repos_url":"https://api.github.com/users/deeplook/repos","events_url":"https://api.github.com/users/deeplook/events{/privacy}","received_events_url":"https://api.github.com/users/deeplook/received_events","type":"User","site_admin":false},"repo":{"id":77148264,"name":"svglib","full_name":"deeplook/svglib","owner":{"login":"deeplook","id":1001778,"avatar_url":"https://avatars.githubusercontent.com/u/1001778?v=3","gravatar_id":"","url":"https://api.github.com/users/deeplook","html_url":"https://github.com/deeplook","followers_url":"https://api.github.com/users/deeplook/followers","following_url":"https://api.github.com/users/deeplook/following{/other_user}","gists_url":"https://api.github.com/users/deeplook/gists{/gist_id}","starred_url":"https://api.github.com/users/deeplook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deeplook/subscriptions","organizations_url":"https://api.github.com/users/deeplook/orgs","repos_url":"https://api.github.com/users/deeplook/repos","events_url":"https://api.github.com/users/deeplook/events{/privacy}","received_events_url":"https://api.github.com/users/deeplook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deeplook/svglib","description":"Read SVG files and convert them to other formats (moved to here from https://bitbucket.org/deeplook/svglib).","fork":false,"url":"https://api.github.com/repos/deeplook/svglib","forks_url":"https://api.github.com/repos/deeplook/svglib/forks","keys_url":"https://api.github.com/repos/deeplook/svglib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deeplook/svglib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deeplook/svglib/teams","hooks_url":"https://api.github.com/repos/deeplook/svglib/hooks","issue_events_url":"https://api.github.com/repos/deeplook/svglib/issues/events{/number}","events_url":"https://api.github.com/repos/deeplook/svglib/events","assignees_url":"https://api.github.com/repos/deeplook/svglib/assignees{/user}","branches_url":"https://api.github.com/repos/deeplook/svglib/branches{/branch}","tags_url":"https://api.github.com/repos/deeplook/svglib/tags","blobs_url":"https://api.github.com/repos/deeplook/svglib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deeplook/svglib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deeplook/svglib/git/refs{/sha}","trees_url":"https://api.github.com/repos/deeplook/svglib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deeplook/svglib/statuses/{sha}","languages_url":"https://api.github.com/repos/deeplook/svglib/languages","stargazers_url":"https://api.github.com/repos/deeplook/svglib/stargazers","contributors_url":"https://api.github.com/repos/deeplook/svglib/contributors","subscribers_url":"https://api.github.com/repos/deeplook/svglib/subscribers","subscription_url":"https://api.github.com/repos/deeplook/svglib/subscription","commits_url":"https://api.github.com/repos/deeplook/svglib/commits{/sha}","git_commits_url":"https://api.github.com/repos/deeplook/svglib/git/commits{/sha}","comments_url":"https://api.github.com/repos/deeplook/svglib/comments{/number}","issue_comment_url":"https://api.github.com/repos/deeplook/svglib/issues/comments{/number}","contents_url":"https://api.github.com/repos/deeplook/svglib/contents/{+path}","compare_url":"https://api.github.com/repos/deeplook/svglib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deeplook/svglib/merges","archive_url":"https://api.github.com/repos/deeplook/svglib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deeplook/svglib/downloads","issues_url":"https://api.github.com/repos/deeplook/svglib/issues{/number}","pulls_url":"https://api.github.com/repos/deeplook/svglib/pulls{/number}","milestones_url":"https://api.github.com/repos/deeplook/svglib/milestones{/number}","notifications_url":"https://api.github.com/repos/deeplook/svglib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deeplook/svglib/labels{/name}","releases_url":"https://api.github.com/repos/deeplook/svglib/releases{/id}","deployments_url":"https://api.github.com/repos/deeplook/svglib/deployments","created_at":"2016-12-22T13:51:29Z","updated_at":"2017-01-10T10:46:01Z","pushed_at":"2017-02-17T09:54:28Z","git_url":"git://github.com/deeplook/svglib.git","ssh_url":"git@github.com:deeplook/svglib.git","clone_url":"https://github.com/deeplook/svglib.git","svn_url":"https://github.com/deeplook/svglib","homepage":"","size":696,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/deeplook/svglib/pulls/73"},"html":{"href":"https://github.com/deeplook/svglib/pull/73"},"issue":{"href":"https://api.github.com/repos/deeplook/svglib/issues/73"},"comments":{"href":"https://api.github.com/repos/deeplook/svglib/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/deeplook/svglib/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/deeplook/svglib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/deeplook/svglib/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/deeplook/svglib/statuses/2fea7ae2a964cf77f908811396da920203b5d09e"}}}}
{"actor":{"display_login":"claudep"}}