{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/webflo/drupal-finder/pulls/13","id":106692245,"html_url":"https://github.com/webflo/drupal-finder/pull/13","diff_url":"https://github.com/webflo/drupal-finder/pull/13.diff","patch_url":"https://github.com/webflo/drupal-finder/pull/13.patch","issue_url":"https://api.github.com/repos/webflo/drupal-finder/issues/13","number":13,"state":"closed","locked":false,"title":"Fail to detect right composer root when drupal/core in subfolder.","user":{"login":"david-garcia-garcia","id":9599352,"avatar_url":"https://avatars3.githubusercontent.com/u/9599352?v=3","gravatar_id":"","url":"https://api.github.com/users/david-garcia-garcia","html_url":"https://github.com/david-garcia-garcia","followers_url":"https://api.github.com/users/david-garcia-garcia/followers","following_url":"https://api.github.com/users/david-garcia-garcia/following{/other_user}","gists_url":"https://api.github.com/users/david-garcia-garcia/gists{/gist_id}","starred_url":"https://api.github.com/users/david-garcia-garcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-garcia-garcia/subscriptions","organizations_url":"https://api.github.com/users/david-garcia-garcia/orgs","repos_url":"https://api.github.com/users/david-garcia-garcia/repos","events_url":"https://api.github.com/users/david-garcia-garcia/events{/privacy}","received_events_url":"https://api.github.com/users/david-garcia-garcia/received_events","type":"User","site_admin":false},"body":"When using drupal composer project template:\r\n\r\nhttps://github.com/drupal-composer/drupal-project\r\n\r\nYou get a folder structure such as:\r\n\r\n/my-project\r\n/my-project/vendor\r\n/my-project/web\r\n\r\nWhere drupal core is installed inside the /web directory.\r\n\r\nIf you use the directory \"/myproject/web\" in isValidRoot($path) current implementation will say this is a valid drupal/composer root, but this is wrong, because the composer root is one level up. It will then fail to loop up a level to find the right composer and drupal root directories.","created_at":"2017-02-17T09:04:17Z","updated_at":"2017-06-18T12:26:42Z","closed_at":"2017-06-18T12:26:42Z","merged_at":null,"merge_commit_sha":"15ddccd01ce2ac819a6eda561a56d94a396d4925","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/webflo/drupal-finder/pulls/13/commits","review_comments_url":"https://api.github.com/repos/webflo/drupal-finder/pulls/13/comments","review_comment_url":"https://api.github.com/repos/webflo/drupal-finder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webflo/drupal-finder/issues/13/comments","statuses_url":"https://api.github.com/repos/webflo/drupal-finder/statuses/3bd9239ded352303da26167cb9217219aebb7199","head":{"label":"david-garcia-garcia:broken-vendor","ref":"broken-vendor","sha":"3bd9239ded352303da26167cb9217219aebb7199","user":{"login":"david-garcia-garcia","id":9599352,"avatar_url":"https://avatars3.githubusercontent.com/u/9599352?v=3","gravatar_id":"","url":"https://api.github.com/users/david-garcia-garcia","html_url":"https://github.com/david-garcia-garcia","followers_url":"https://api.github.com/users/david-garcia-garcia/followers","following_url":"https://api.github.com/users/david-garcia-garcia/following{/other_user}","gists_url":"https://api.github.com/users/david-garcia-garcia/gists{/gist_id}","starred_url":"https://api.github.com/users/david-garcia-garcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-garcia-garcia/subscriptions","organizations_url":"https://api.github.com/users/david-garcia-garcia/orgs","repos_url":"https://api.github.com/users/david-garcia-garcia/repos","events_url":"https://api.github.com/users/david-garcia-garcia/events{/privacy}","received_events_url":"https://api.github.com/users/david-garcia-garcia/received_events","type":"User","site_admin":false},"repo":{"id":82277529,"name":"drupal-finder","full_name":"david-garcia-garcia/drupal-finder","owner":{"login":"david-garcia-garcia","id":9599352,"avatar_url":"https://avatars3.githubusercontent.com/u/9599352?v=3","gravatar_id":"","url":"https://api.github.com/users/david-garcia-garcia","html_url":"https://github.com/david-garcia-garcia","followers_url":"https://api.github.com/users/david-garcia-garcia/followers","following_url":"https://api.github.com/users/david-garcia-garcia/following{/other_user}","gists_url":"https://api.github.com/users/david-garcia-garcia/gists{/gist_id}","starred_url":"https://api.github.com/users/david-garcia-garcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-garcia-garcia/subscriptions","organizations_url":"https://api.github.com/users/david-garcia-garcia/orgs","repos_url":"https://api.github.com/users/david-garcia-garcia/repos","events_url":"https://api.github.com/users/david-garcia-garcia/events{/privacy}","received_events_url":"https://api.github.com/users/david-garcia-garcia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-garcia-garcia/drupal-finder","description":null,"fork":true,"url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder","forks_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/forks","keys_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/teams","hooks_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/hooks","issue_events_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/issues/events{/number}","events_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/events","assignees_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/assignees{/user}","branches_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/branches{/branch}","tags_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/tags","blobs_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/statuses/{sha}","languages_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/languages","stargazers_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/stargazers","contributors_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/contributors","subscribers_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/subscribers","subscription_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/subscription","commits_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/contents/{+path}","compare_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/merges","archive_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/downloads","issues_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/issues{/number}","pulls_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/pulls{/number}","milestones_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/milestones{/number}","notifications_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/labels{/name}","releases_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/releases{/id}","deployments_url":"https://api.github.com/repos/david-garcia-garcia/drupal-finder/deployments","created_at":"2017-02-17T08:57:16Z","updated_at":"2017-02-17T08:57:17Z","pushed_at":"2017-02-17T09:00:12Z","git_url":"git://github.com/david-garcia-garcia/drupal-finder.git","ssh_url":"git@github.com:david-garcia-garcia/drupal-finder.git","clone_url":"https://github.com/david-garcia-garcia/drupal-finder.git","svn_url":"https://github.com/david-garcia-garcia/drupal-finder","homepage":null,"size":10,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webflo:master","ref":"master","sha":"4bd98f7e7b1d30e284e55f51d5d0c8712f676348","user":{"login":"webflo","id":123946,"avatar_url":"https://avatars2.githubusercontent.com/u/123946?v=3","gravatar_id":"","url":"https://api.github.com/users/webflo","html_url":"https://github.com/webflo","followers_url":"https://api.github.com/users/webflo/followers","following_url":"https://api.github.com/users/webflo/following{/other_user}","gists_url":"https://api.github.com/users/webflo/gists{/gist_id}","starred_url":"https://api.github.com/users/webflo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webflo/subscriptions","organizations_url":"https://api.github.com/users/webflo/orgs","repos_url":"https://api.github.com/users/webflo/repos","events_url":"https://api.github.com/users/webflo/events{/privacy}","received_events_url":"https://api.github.com/users/webflo/received_events","type":"User","site_admin":false},"repo":{"id":69790820,"name":"drupal-finder","full_name":"webflo/drupal-finder","owner":{"login":"webflo","id":123946,"avatar_url":"https://avatars2.githubusercontent.com/u/123946?v=3","gravatar_id":"","url":"https://api.github.com/users/webflo","html_url":"https://github.com/webflo","followers_url":"https://api.github.com/users/webflo/followers","following_url":"https://api.github.com/users/webflo/following{/other_user}","gists_url":"https://api.github.com/users/webflo/gists{/gist_id}","starred_url":"https://api.github.com/users/webflo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webflo/subscriptions","organizations_url":"https://api.github.com/users/webflo/orgs","repos_url":"https://api.github.com/users/webflo/repos","events_url":"https://api.github.com/users/webflo/events{/privacy}","received_events_url":"https://api.github.com/users/webflo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/webflo/drupal-finder","description":null,"fork":false,"url":"https://api.github.com/repos/webflo/drupal-finder","forks_url":"https://api.github.com/repos/webflo/drupal-finder/forks","keys_url":"https://api.github.com/repos/webflo/drupal-finder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webflo/drupal-finder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webflo/drupal-finder/teams","hooks_url":"https://api.github.com/repos/webflo/drupal-finder/hooks","issue_events_url":"https://api.github.com/repos/webflo/drupal-finder/issues/events{/number}","events_url":"https://api.github.com/repos/webflo/drupal-finder/events","assignees_url":"https://api.github.com/repos/webflo/drupal-finder/assignees{/user}","branches_url":"https://api.github.com/repos/webflo/drupal-finder/branches{/branch}","tags_url":"https://api.github.com/repos/webflo/drupal-finder/tags","blobs_url":"https://api.github.com/repos/webflo/drupal-finder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webflo/drupal-finder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webflo/drupal-finder/git/refs{/sha}","trees_url":"https://api.github.com/repos/webflo/drupal-finder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webflo/drupal-finder/statuses/{sha}","languages_url":"https://api.github.com/repos/webflo/drupal-finder/languages","stargazers_url":"https://api.github.com/repos/webflo/drupal-finder/stargazers","contributors_url":"https://api.github.com/repos/webflo/drupal-finder/contributors","subscribers_url":"https://api.github.com/repos/webflo/drupal-finder/subscribers","subscription_url":"https://api.github.com/repos/webflo/drupal-finder/subscription","commits_url":"https://api.github.com/repos/webflo/drupal-finder/commits{/sha}","git_commits_url":"https://api.github.com/repos/webflo/drupal-finder/git/commits{/sha}","comments_url":"https://api.github.com/repos/webflo/drupal-finder/comments{/number}","issue_comment_url":"https://api.github.com/repos/webflo/drupal-finder/issues/comments{/number}","contents_url":"https://api.github.com/repos/webflo/drupal-finder/contents/{+path}","compare_url":"https://api.github.com/repos/webflo/drupal-finder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webflo/drupal-finder/merges","archive_url":"https://api.github.com/repos/webflo/drupal-finder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webflo/drupal-finder/downloads","issues_url":"https://api.github.com/repos/webflo/drupal-finder/issues{/number}","pulls_url":"https://api.github.com/repos/webflo/drupal-finder/pulls{/number}","milestones_url":"https://api.github.com/repos/webflo/drupal-finder/milestones{/number}","notifications_url":"https://api.github.com/repos/webflo/drupal-finder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webflo/drupal-finder/labels{/name}","releases_url":"https://api.github.com/repos/webflo/drupal-finder/releases{/id}","deployments_url":"https://api.github.com/repos/webflo/drupal-finder/deployments","created_at":"2016-10-02T10:13:52Z","updated_at":"2017-04-09T13:31:57Z","pushed_at":"2017-05-04T08:54:42Z","git_url":"git://github.com/webflo/drupal-finder.git","ssh_url":"git@github.com:webflo/drupal-finder.git","clone_url":"https://github.com/webflo/drupal-finder.git","svn_url":"https://github.com/webflo/drupal-finder","homepage":null,"size":10,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webflo/drupal-finder/pulls/13"},"html":{"href":"https://github.com/webflo/drupal-finder/pull/13"},"issue":{"href":"https://api.github.com/repos/webflo/drupal-finder/issues/13"},"comments":{"href":"https://api.github.com/repos/webflo/drupal-finder/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/webflo/drupal-finder/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/webflo/drupal-finder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webflo/drupal-finder/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/webflo/drupal-finder/statuses/3bd9239ded352303da26167cb9217219aebb7199"}},"merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"webflo"}}