{"action":"created","comment":{"url":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/comments/109682365","pull_request_review_id":30800228,"id":109682365,"diff_hunk":"@@ -42,19 +43,26 @@ public V instantiateItem(ViewGroup container, int position) {\n     protected abstract V createView(ViewGroup container, int position);\n \n     /**\n+     * Bind the view to the item at the given position with view state.","path":"library/src/main/java/com/novoda/viewpageradapter/ViewPagerAdapter.java","position":26,"original_position":26,"commit_id":"690ac89cd70e64e231c5c597bc7e333b61e42662","original_commit_id":"690ac89cd70e64e231c5c597bc7e333b61e42662","user":{"login":"Electryc","id":913571,"avatar_url":"https://avatars1.githubusercontent.com/u/913571?v=3","gravatar_id":"","url":"https://api.github.com/users/Electryc","html_url":"https://github.com/Electryc","followers_url":"https://api.github.com/users/Electryc/followers","following_url":"https://api.github.com/users/Electryc/following{/other_user}","gists_url":"https://api.github.com/users/Electryc/gists{/gist_id}","starred_url":"https://api.github.com/users/Electryc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Electryc/subscriptions","organizations_url":"https://api.github.com/users/Electryc/orgs","repos_url":"https://api.github.com/users/Electryc/repos","events_url":"https://api.github.com/users/Electryc/events{/privacy}","received_events_url":"https://api.github.com/users/Electryc/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2017-04-04T14:44:02Z","updated_at":"2017-04-04T14:45:57Z","html_url":"https://github.com/novoda/view-pager-adapter/pull/9#discussion_r109682365","pull_request_url":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/comments/109682365"},"html":{"href":"https://github.com/novoda/view-pager-adapter/pull/9#discussion_r109682365"},"pull_request":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/9","id":114161911,"html_url":"https://github.com/novoda/view-pager-adapter/pull/9","diff_url":"https://github.com/novoda/view-pager-adapter/pull/9.diff","patch_url":"https://github.com/novoda/view-pager-adapter/pull/9.patch","issue_url":"https://api.github.com/repos/novoda/view-pager-adapter/issues/9","number":9,"state":"open","locked":false,"title":"VPA-7/Binding View with state","user":{"login":"ouchadam","id":1848238,"avatar_url":"https://avatars3.githubusercontent.com/u/1848238?v=3","gravatar_id":"","url":"https://api.github.com/users/ouchadam","html_url":"https://github.com/ouchadam","followers_url":"https://api.github.com/users/ouchadam/followers","following_url":"https://api.github.com/users/ouchadam/following{/other_user}","gists_url":"https://api.github.com/users/ouchadam/gists{/gist_id}","starred_url":"https://api.github.com/users/ouchadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ouchadam/subscriptions","organizations_url":"https://api.github.com/users/ouchadam/orgs","repos_url":"https://api.github.com/users/ouchadam/repos","events_url":"https://api.github.com/users/ouchadam/events{/privacy}","received_events_url":"https://api.github.com/users/ouchadam/received_events","type":"User","site_admin":false},"body":"#### Problem/Goal\r\n\r\nFixes #4 and #7\r\n\r\n- Adds new `bindView(view, position, viewState)` (similar to `Activity.onCreate(instanceState)`) to allow clients to manually handle the restoration of the view's state. Fixes #7 \r\n\r\n- Allows `bindView` to NOT be implemented by becoming protected and empty. This made more sense now that we have 2 binds. Fixes #4\r\n\r\n##### Screenshots\r\n\r\nno UI changes","created_at":"2017-04-04T14:27:37Z","updated_at":"2017-04-04T14:45:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0967d2bc3b83c965dea1e499ee400361da9a3dfc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/9/commits","review_comments_url":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/9/comments","review_comment_url":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novoda/view-pager-adapter/issues/9/comments","statuses_url":"https://api.github.com/repos/novoda/view-pager-adapter/statuses/690ac89cd70e64e231c5c597bc7e333b61e42662","head":{"label":"novoda:VPA-7/binding-with-state","ref":"VPA-7/binding-with-state","sha":"690ac89cd70e64e231c5c597bc7e333b61e42662","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars1.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":55979944,"name":"view-pager-adapter","full_name":"novoda/view-pager-adapter","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars1.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/view-pager-adapter","description":"A simple implementation of PagerAdapter that supports Views.","fork":false,"url":"https://api.github.com/repos/novoda/view-pager-adapter","forks_url":"https://api.github.com/repos/novoda/view-pager-adapter/forks","keys_url":"https://api.github.com/repos/novoda/view-pager-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/view-pager-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/view-pager-adapter/teams","hooks_url":"https://api.github.com/repos/novoda/view-pager-adapter/hooks","issue_events_url":"https://api.github.com/repos/novoda/view-pager-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/view-pager-adapter/events","assignees_url":"https://api.github.com/repos/novoda/view-pager-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/view-pager-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/view-pager-adapter/tags","blobs_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/view-pager-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/view-pager-adapter/languages","stargazers_url":"https://api.github.com/repos/novoda/view-pager-adapter/stargazers","contributors_url":"https://api.github.com/repos/novoda/view-pager-adapter/contributors","subscribers_url":"https://api.github.com/repos/novoda/view-pager-adapter/subscribers","subscription_url":"https://api.github.com/repos/novoda/view-pager-adapter/subscription","commits_url":"https://api.github.com/repos/novoda/view-pager-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/view-pager-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/view-pager-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/view-pager-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/view-pager-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/view-pager-adapter/merges","archive_url":"https://api.github.com/repos/novoda/view-pager-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/view-pager-adapter/downloads","issues_url":"https://api.github.com/repos/novoda/view-pager-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/view-pager-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/view-pager-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/view-pager-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/view-pager-adapter/labels{/name}","releases_url":"https://api.github.com/repos/novoda/view-pager-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/view-pager-adapter/deployments","created_at":"2016-04-11T14:35:48Z","updated_at":"2017-03-15T15:28:41Z","pushed_at":"2017-04-04T14:27:37Z","git_url":"git://github.com/novoda/view-pager-adapter.git","ssh_url":"git@github.com:novoda/view-pager-adapter.git","clone_url":"https://github.com/novoda/view-pager-adapter.git","svn_url":"https://github.com/novoda/view-pager-adapter","homepage":null,"size":87,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":8,"default_branch":"master"}},"base":{"label":"novoda:master","ref":"master","sha":"9d8898d1cc70467cc55c275e078f54b9af0abbc1","user":{"login":"novoda","id":74874,"avatar_url":"https://avatars1.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"repo":{"id":55979944,"name":"view-pager-adapter","full_name":"novoda/view-pager-adapter","owner":{"login":"novoda","id":74874,"avatar_url":"https://avatars1.githubusercontent.com/u/74874?v=3","gravatar_id":"","url":"https://api.github.com/users/novoda","html_url":"https://github.com/novoda","followers_url":"https://api.github.com/users/novoda/followers","following_url":"https://api.github.com/users/novoda/following{/other_user}","gists_url":"https://api.github.com/users/novoda/gists{/gist_id}","starred_url":"https://api.github.com/users/novoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novoda/subscriptions","organizations_url":"https://api.github.com/users/novoda/orgs","repos_url":"https://api.github.com/users/novoda/repos","events_url":"https://api.github.com/users/novoda/events{/privacy}","received_events_url":"https://api.github.com/users/novoda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novoda/view-pager-adapter","description":"A simple implementation of PagerAdapter that supports Views.","fork":false,"url":"https://api.github.com/repos/novoda/view-pager-adapter","forks_url":"https://api.github.com/repos/novoda/view-pager-adapter/forks","keys_url":"https://api.github.com/repos/novoda/view-pager-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novoda/view-pager-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novoda/view-pager-adapter/teams","hooks_url":"https://api.github.com/repos/novoda/view-pager-adapter/hooks","issue_events_url":"https://api.github.com/repos/novoda/view-pager-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/novoda/view-pager-adapter/events","assignees_url":"https://api.github.com/repos/novoda/view-pager-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/novoda/view-pager-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/novoda/view-pager-adapter/tags","blobs_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novoda/view-pager-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/novoda/view-pager-adapter/languages","stargazers_url":"https://api.github.com/repos/novoda/view-pager-adapter/stargazers","contributors_url":"https://api.github.com/repos/novoda/view-pager-adapter/contributors","subscribers_url":"https://api.github.com/repos/novoda/view-pager-adapter/subscribers","subscription_url":"https://api.github.com/repos/novoda/view-pager-adapter/subscription","commits_url":"https://api.github.com/repos/novoda/view-pager-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/novoda/view-pager-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/novoda/view-pager-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/novoda/view-pager-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/novoda/view-pager-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/novoda/view-pager-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novoda/view-pager-adapter/merges","archive_url":"https://api.github.com/repos/novoda/view-pager-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novoda/view-pager-adapter/downloads","issues_url":"https://api.github.com/repos/novoda/view-pager-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/novoda/view-pager-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/novoda/view-pager-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/novoda/view-pager-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novoda/view-pager-adapter/labels{/name}","releases_url":"https://api.github.com/repos/novoda/view-pager-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/novoda/view-pager-adapter/deployments","created_at":"2016-04-11T14:35:48Z","updated_at":"2017-03-15T15:28:41Z","pushed_at":"2017-04-04T14:27:37Z","git_url":"git://github.com/novoda/view-pager-adapter.git","ssh_url":"git@github.com:novoda/view-pager-adapter.git","clone_url":"https://github.com/novoda/view-pager-adapter.git","svn_url":"https://github.com/novoda/view-pager-adapter","homepage":null,"size":87,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/9"},"html":{"href":"https://github.com/novoda/view-pager-adapter/pull/9"},"issue":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/issues/9"},"comments":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/novoda/view-pager-adapter/statuses/690ac89cd70e64e231c5c597bc7e333b61e42662"}}}}
{"actor":{"display_login":"Electryc"}}