{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/113955161","pull_request_review_id":35388463,"id":113955161,"diff_hunk":"@@ -810,16 +810,14 @@ func (b *builtinAtanSig) eval(row []types.Datum) (d types.Datum, err error) {\n \t\tx, err := args[1].ToFloat64(sc)\n \t\tif err != nil {\n \t\t\td.SetFloat64(math.Atan(y))\n-\t\t\t// FIXME: Trigger a warning perhaps.","path":"expression/builtin_math.go","position":4,"original_position":4,"commit_id":"8887aed16a0210f2b9fb3e58e8dd41669917823f","original_commit_id":"8887aed16a0210f2b9fb3e58e8dd41669917823f","user":{"login":"astaxie","id":233907,"avatar_url":"https://avatars0.githubusercontent.com/u/233907?v=3","gravatar_id":"","url":"https://api.github.com/users/astaxie","html_url":"https://github.com/astaxie","followers_url":"https://api.github.com/users/astaxie/followers","following_url":"https://api.github.com/users/astaxie/following{/other_user}","gists_url":"https://api.github.com/users/astaxie/gists{/gist_id}","starred_url":"https://api.github.com/users/astaxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaxie/subscriptions","organizations_url":"https://api.github.com/users/astaxie/orgs","repos_url":"https://api.github.com/users/astaxie/repos","events_url":"https://api.github.com/users/astaxie/events{/privacy}","received_events_url":"https://api.github.com/users/astaxie/received_events","type":"User","site_admin":false},"body":"No, I think this trigger warning is the `err assigned and not used`\r\n\r\n","created_at":"2017-04-28T15:21:07Z","updated_at":"2017-04-28T15:21:08Z","html_url":"https://github.com/pingcap/tidb/pull/3178#discussion_r113955161","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/3178","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/113955161"},"html":{"href":"https://github.com/pingcap/tidb/pull/3178#discussion_r113955161"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/3178"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/3178","id":118159853,"html_url":"https://github.com/pingcap/tidb/pull/3178","diff_url":"https://github.com/pingcap/tidb/pull/3178.diff","patch_url":"https://github.com/pingcap/tidb/pull/3178.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/3178","number":3178,"state":"open","locked":false,"title":"err assigned and not used","user":{"login":"astaxie","id":233907,"avatar_url":"https://avatars0.githubusercontent.com/u/233907?v=3","gravatar_id":"","url":"https://api.github.com/users/astaxie","html_url":"https://github.com/astaxie","followers_url":"https://api.github.com/users/astaxie/followers","following_url":"https://api.github.com/users/astaxie/following{/other_user}","gists_url":"https://api.github.com/users/astaxie/gists{/gist_id}","starred_url":"https://api.github.com/users/astaxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaxie/subscriptions","organizations_url":"https://api.github.com/users/astaxie/orgs","repos_url":"https://api.github.com/users/astaxie/repos","events_url":"https://api.github.com/users/astaxie/events{/privacy}","received_events_url":"https://api.github.com/users/astaxie/received_events","type":"User","site_admin":false},"body":"1. Miss a lot of err check in test case\r\n2. return value and local variable mixed\r\n\r\nplease review","created_at":"2017-04-28T14:05:56Z","updated_at":"2017-04-28T15:21:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc8fcb581b3666f20b6ba3cabc9316428a024104","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/3178/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/3178/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/3178/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/8887aed16a0210f2b9fb3e58e8dd41669917823f","head":{"label":"astaxie:master","ref":"master","sha":"8887aed16a0210f2b9fb3e58e8dd41669917823f","user":{"login":"astaxie","id":233907,"avatar_url":"https://avatars0.githubusercontent.com/u/233907?v=3","gravatar_id":"","url":"https://api.github.com/users/astaxie","html_url":"https://github.com/astaxie","followers_url":"https://api.github.com/users/astaxie/followers","following_url":"https://api.github.com/users/astaxie/following{/other_user}","gists_url":"https://api.github.com/users/astaxie/gists{/gist_id}","starred_url":"https://api.github.com/users/astaxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaxie/subscriptions","organizations_url":"https://api.github.com/users/astaxie/orgs","repos_url":"https://api.github.com/users/astaxie/repos","events_url":"https://api.github.com/users/astaxie/events{/privacy}","received_events_url":"https://api.github.com/users/astaxie/received_events","type":"User","site_admin":false},"repo":{"id":41996346,"name":"tidb","full_name":"astaxie/tidb","owner":{"login":"astaxie","id":233907,"avatar_url":"https://avatars0.githubusercontent.com/u/233907?v=3","gravatar_id":"","url":"https://api.github.com/users/astaxie","html_url":"https://github.com/astaxie","followers_url":"https://api.github.com/users/astaxie/followers","following_url":"https://api.github.com/users/astaxie/following{/other_user}","gists_url":"https://api.github.com/users/astaxie/gists{/gist_id}","starred_url":"https://api.github.com/users/astaxie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astaxie/subscriptions","organizations_url":"https://api.github.com/users/astaxie/orgs","repos_url":"https://api.github.com/users/astaxie/repos","events_url":"https://api.github.com/users/astaxie/events{/privacy}","received_events_url":"https://api.github.com/users/astaxie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astaxie/tidb","description":"TiDB is a distributed SQL database.","fork":true,"url":"https://api.github.com/repos/astaxie/tidb","forks_url":"https://api.github.com/repos/astaxie/tidb/forks","keys_url":"https://api.github.com/repos/astaxie/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astaxie/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astaxie/tidb/teams","hooks_url":"https://api.github.com/repos/astaxie/tidb/hooks","issue_events_url":"https://api.github.com/repos/astaxie/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/astaxie/tidb/events","assignees_url":"https://api.github.com/repos/astaxie/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/astaxie/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/astaxie/tidb/tags","blobs_url":"https://api.github.com/repos/astaxie/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astaxie/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astaxie/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/astaxie/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astaxie/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/astaxie/tidb/languages","stargazers_url":"https://api.github.com/repos/astaxie/tidb/stargazers","contributors_url":"https://api.github.com/repos/astaxie/tidb/contributors","subscribers_url":"https://api.github.com/repos/astaxie/tidb/subscribers","subscription_url":"https://api.github.com/repos/astaxie/tidb/subscription","commits_url":"https://api.github.com/repos/astaxie/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/astaxie/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/astaxie/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/astaxie/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/astaxie/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/astaxie/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astaxie/tidb/merges","archive_url":"https://api.github.com/repos/astaxie/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astaxie/tidb/downloads","issues_url":"https://api.github.com/repos/astaxie/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/astaxie/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/astaxie/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/astaxie/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astaxie/tidb/labels{/name}","releases_url":"https://api.github.com/repos/astaxie/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/astaxie/tidb/deployments","created_at":"2015-09-06T09:15:40Z","updated_at":"2017-04-28T13:49:33Z","pushed_at":"2017-04-28T14:04:21Z","git_url":"git://github.com/astaxie/tidb.git","ssh_url":"git@github.com:astaxie/tidb.git","clone_url":"https://github.com/astaxie/tidb.git","svn_url":"https://github.com/astaxie/tidb","homepage":"","size":24221,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"441f4b60eea35fa3e260dda8422ee0ad5aa39894","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars0.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2017-04-28T13:12:53Z","pushed_at":"2017-04-28T15:16:18Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"","size":24681,"stargazers_count":7815,"watchers_count":7815,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1030,"mirror_url":null,"open_issues_count":201,"forks":1030,"open_issues":201,"watchers":7815,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/3178"},"html":{"href":"https://github.com/pingcap/tidb/pull/3178"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/3178"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/3178/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/3178/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/3178/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/8887aed16a0210f2b9fb3e58e8dd41669917823f"}}}}
{"actor":{"display_login":"astaxie"}}