{"action":"created","comment":{"url":"https://api.github.com/repos/danliris/dl-ui/pulls/comments/97253093","pull_request_review_id":17856337,"id":97253093,"diff_hunk":"@@ -10,51 +10,43 @@ export class Service extends RestService {\n         super(http, aggregator, config, \"production\");\n     }\n \n-    getReport(sdate, edate, machine, shift) {\n+    getReport(sdate, edate, machine) {\n         var endpoint = `${serviceUri}`;\n         var query = '';\n         if (sdate) {\n-            if (query == '') query = `dateFrom=${sdate}`;\n+            if (query === '') query = `dateFrom=${sdate}`;\n             else query = `${query}&dateFrom=${sdate}`;\n         }\n         if (edate) {\n-            if (query == '') query = `dateTo=${edate}`;\n+            if (query === '') query = `dateTo=${edate}`;\n             else query = `${query}&dateTo=${edate}`;\n         }\n         if (machine) {\n-            if (query == '') query = `machine=${machine._id}`;\n+            if (query === '') query = `machine=${machine._id}`;\n             else query = `${query}&machine=${machine._id}`;\n         }\n-        if (shift) {\n-            if (query == '') query = `shift=${shift}`;\n-            else query = `${query}&shift=${shift}`;\n-        }\n-        if (query != '')\n+        if (query !== '')\n             endpoint = `${serviceUri}?${query}`;\n \n         return super.get(endpoint);\n     }\n \n-    generateExcel(sdate, edate, machine, shift) {\n+    generateExcel(sdate, edate, machine) {\n         var endpoint = `${serviceUri}`;\n         var query = '';\n         if (sdate) {\n-            if (query == '') query = `dateFrom=${sdate}`;\n+            if (query === '') query = `dateFrom=${sdate}`;\n             else query = `${query}&dateFrom=${sdate}`;\n         }\n         if (edate) {\n-            if (query == '') query = `dateTo=${edate}`;\n+            if (query === '') query = `dateTo=${edate}`;\n             else query = `${query}&dateTo=${edate}`;\n         }\n         if (machine) {\n-            if (query == '') query = `machine=${machine._id}`;\n+            if (query === '') query = `machine=${machine._id}`;","path":"src/modules/production/finishing-printing/reports/daily-operation-report/service.js","position":20,"original_position":50,"commit_id":"96cbbe7173125fcddd1a31adc5b6f654c911f42b","original_commit_id":"96cbbe7173125fcddd1a31adc5b6f654c911f42b","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'template literal syntax' is only available in ES6 (use 'esversion: 6').","created_at":"2017-01-23T04:58:19Z","updated_at":"2017-01-23T04:58:19Z","html_url":"https://github.com/danliris/dl-ui/pull/200#discussion_r97253093","pull_request_url":"https://api.github.com/repos/danliris/dl-ui/pulls/200","_links":{"self":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/comments/97253093"},"html":{"href":"https://github.com/danliris/dl-ui/pull/200#discussion_r97253093"},"pull_request":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/danliris/dl-ui/pulls/200","id":102658013,"html_url":"https://github.com/danliris/dl-ui/pull/200","diff_url":"https://github.com/danliris/dl-ui/pull/200.diff","patch_url":"https://github.com/danliris/dl-ui/pull/200.patch","issue_url":"https://api.github.com/repos/danliris/dl-ui/issues/200","number":200,"state":"open","locked":false,"title":"update main","user":{"login":"SirDimas","id":20527329,"avatar_url":"https://avatars.githubusercontent.com/u/20527329?v=3","gravatar_id":"","url":"https://api.github.com/users/SirDimas","html_url":"https://github.com/SirDimas","followers_url":"https://api.github.com/users/SirDimas/followers","following_url":"https://api.github.com/users/SirDimas/following{/other_user}","gists_url":"https://api.github.com/users/SirDimas/gists{/gist_id}","starred_url":"https://api.github.com/users/SirDimas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirDimas/subscriptions","organizations_url":"https://api.github.com/users/SirDimas/orgs","repos_url":"https://api.github.com/users/SirDimas/repos","events_url":"https://api.github.com/users/SirDimas/events{/privacy}","received_events_url":"https://api.github.com/users/SirDimas/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-01-23T04:58:10Z","updated_at":"2017-01-23T04:58:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c247b290f992ef14a52da177ed575cea3abb4bd0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/danliris/dl-ui/pulls/200/commits","review_comments_url":"https://api.github.com/repos/danliris/dl-ui/pulls/200/comments","review_comment_url":"https://api.github.com/repos/danliris/dl-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danliris/dl-ui/issues/200/comments","statuses_url":"https://api.github.com/repos/danliris/dl-ui/statuses/96cbbe7173125fcddd1a31adc5b6f654c911f42b","head":{"label":"SirDimas:dev","ref":"dev","sha":"96cbbe7173125fcddd1a31adc5b6f654c911f42b","user":{"login":"SirDimas","id":20527329,"avatar_url":"https://avatars.githubusercontent.com/u/20527329?v=3","gravatar_id":"","url":"https://api.github.com/users/SirDimas","html_url":"https://github.com/SirDimas","followers_url":"https://api.github.com/users/SirDimas/followers","following_url":"https://api.github.com/users/SirDimas/following{/other_user}","gists_url":"https://api.github.com/users/SirDimas/gists{/gist_id}","starred_url":"https://api.github.com/users/SirDimas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirDimas/subscriptions","organizations_url":"https://api.github.com/users/SirDimas/orgs","repos_url":"https://api.github.com/users/SirDimas/repos","events_url":"https://api.github.com/users/SirDimas/events{/privacy}","received_events_url":"https://api.github.com/users/SirDimas/received_events","type":"User","site_admin":false},"repo":{"id":78392828,"name":"dl-ui","full_name":"SirDimas/dl-ui","owner":{"login":"SirDimas","id":20527329,"avatar_url":"https://avatars.githubusercontent.com/u/20527329?v=3","gravatar_id":"","url":"https://api.github.com/users/SirDimas","html_url":"https://github.com/SirDimas","followers_url":"https://api.github.com/users/SirDimas/followers","following_url":"https://api.github.com/users/SirDimas/following{/other_user}","gists_url":"https://api.github.com/users/SirDimas/gists{/gist_id}","starred_url":"https://api.github.com/users/SirDimas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirDimas/subscriptions","organizations_url":"https://api.github.com/users/SirDimas/orgs","repos_url":"https://api.github.com/users/SirDimas/repos","events_url":"https://api.github.com/users/SirDimas/events{/privacy}","received_events_url":"https://api.github.com/users/SirDimas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SirDimas/dl-ui","description":"Dan Liris ui with Aurelia","fork":true,"url":"https://api.github.com/repos/SirDimas/dl-ui","forks_url":"https://api.github.com/repos/SirDimas/dl-ui/forks","keys_url":"https://api.github.com/repos/SirDimas/dl-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SirDimas/dl-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SirDimas/dl-ui/teams","hooks_url":"https://api.github.com/repos/SirDimas/dl-ui/hooks","issue_events_url":"https://api.github.com/repos/SirDimas/dl-ui/issues/events{/number}","events_url":"https://api.github.com/repos/SirDimas/dl-ui/events","assignees_url":"https://api.github.com/repos/SirDimas/dl-ui/assignees{/user}","branches_url":"https://api.github.com/repos/SirDimas/dl-ui/branches{/branch}","tags_url":"https://api.github.com/repos/SirDimas/dl-ui/tags","blobs_url":"https://api.github.com/repos/SirDimas/dl-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SirDimas/dl-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SirDimas/dl-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/SirDimas/dl-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SirDimas/dl-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/SirDimas/dl-ui/languages","stargazers_url":"https://api.github.com/repos/SirDimas/dl-ui/stargazers","contributors_url":"https://api.github.com/repos/SirDimas/dl-ui/contributors","subscribers_url":"https://api.github.com/repos/SirDimas/dl-ui/subscribers","subscription_url":"https://api.github.com/repos/SirDimas/dl-ui/subscription","commits_url":"https://api.github.com/repos/SirDimas/dl-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/SirDimas/dl-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/SirDimas/dl-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/SirDimas/dl-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/SirDimas/dl-ui/contents/{+path}","compare_url":"https://api.github.com/repos/SirDimas/dl-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SirDimas/dl-ui/merges","archive_url":"https://api.github.com/repos/SirDimas/dl-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SirDimas/dl-ui/downloads","issues_url":"https://api.github.com/repos/SirDimas/dl-ui/issues{/number}","pulls_url":"https://api.github.com/repos/SirDimas/dl-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/SirDimas/dl-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/SirDimas/dl-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SirDimas/dl-ui/labels{/name}","releases_url":"https://api.github.com/repos/SirDimas/dl-ui/releases{/id}","deployments_url":"https://api.github.com/repos/SirDimas/dl-ui/deployments","created_at":"2017-01-09T04:07:36Z","updated_at":"2017-01-09T04:07:38Z","pushed_at":"2017-01-23T04:56:38Z","git_url":"git://github.com/SirDimas/dl-ui.git","ssh_url":"git@github.com:SirDimas/dl-ui.git","clone_url":"https://github.com/SirDimas/dl-ui.git","svn_url":"https://github.com/SirDimas/dl-ui","homepage":null,"size":2215,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danliris:dev","ref":"dev","sha":"c3dc5fc64a94ecd4c72ba837457518271e696330","user":{"login":"danliris","id":20855729,"avatar_url":"https://avatars.githubusercontent.com/u/20855729?v=3","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"repo":{"id":64897822,"name":"dl-ui","full_name":"danliris/dl-ui","owner":{"login":"danliris","id":20855729,"avatar_url":"https://avatars.githubusercontent.com/u/20855729?v=3","gravatar_id":"","url":"https://api.github.com/users/danliris","html_url":"https://github.com/danliris","followers_url":"https://api.github.com/users/danliris/followers","following_url":"https://api.github.com/users/danliris/following{/other_user}","gists_url":"https://api.github.com/users/danliris/gists{/gist_id}","starred_url":"https://api.github.com/users/danliris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danliris/subscriptions","organizations_url":"https://api.github.com/users/danliris/orgs","repos_url":"https://api.github.com/users/danliris/repos","events_url":"https://api.github.com/users/danliris/events{/privacy}","received_events_url":"https://api.github.com/users/danliris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danliris/dl-ui","description":"Dan Liris ui with Aurelia","fork":false,"url":"https://api.github.com/repos/danliris/dl-ui","forks_url":"https://api.github.com/repos/danliris/dl-ui/forks","keys_url":"https://api.github.com/repos/danliris/dl-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danliris/dl-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danliris/dl-ui/teams","hooks_url":"https://api.github.com/repos/danliris/dl-ui/hooks","issue_events_url":"https://api.github.com/repos/danliris/dl-ui/issues/events{/number}","events_url":"https://api.github.com/repos/danliris/dl-ui/events","assignees_url":"https://api.github.com/repos/danliris/dl-ui/assignees{/user}","branches_url":"https://api.github.com/repos/danliris/dl-ui/branches{/branch}","tags_url":"https://api.github.com/repos/danliris/dl-ui/tags","blobs_url":"https://api.github.com/repos/danliris/dl-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danliris/dl-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danliris/dl-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/danliris/dl-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danliris/dl-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/danliris/dl-ui/languages","stargazers_url":"https://api.github.com/repos/danliris/dl-ui/stargazers","contributors_url":"https://api.github.com/repos/danliris/dl-ui/contributors","subscribers_url":"https://api.github.com/repos/danliris/dl-ui/subscribers","subscription_url":"https://api.github.com/repos/danliris/dl-ui/subscription","commits_url":"https://api.github.com/repos/danliris/dl-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/danliris/dl-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/danliris/dl-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/danliris/dl-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/danliris/dl-ui/contents/{+path}","compare_url":"https://api.github.com/repos/danliris/dl-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danliris/dl-ui/merges","archive_url":"https://api.github.com/repos/danliris/dl-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danliris/dl-ui/downloads","issues_url":"https://api.github.com/repos/danliris/dl-ui/issues{/number}","pulls_url":"https://api.github.com/repos/danliris/dl-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/danliris/dl-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/danliris/dl-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danliris/dl-ui/labels{/name}","releases_url":"https://api.github.com/repos/danliris/dl-ui/releases{/id}","deployments_url":"https://api.github.com/repos/danliris/dl-ui/deployments","created_at":"2016-08-04T03:06:28Z","updated_at":"2016-09-22T05:03:51Z","pushed_at":"2017-01-23T04:58:11Z","git_url":"git://github.com/danliris/dl-ui.git","ssh_url":"git@github.com:danliris/dl-ui.git","clone_url":"https://github.com/danliris/dl-ui.git","svn_url":"https://github.com/danliris/dl-ui","homepage":null,"size":2238,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":16,"forks":14,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/200"},"html":{"href":"https://github.com/danliris/dl-ui/pull/200"},"issue":{"href":"https://api.github.com/repos/danliris/dl-ui/issues/200"},"comments":{"href":"https://api.github.com/repos/danliris/dl-ui/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danliris/dl-ui/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/danliris/dl-ui/statuses/96cbbe7173125fcddd1a31adc5b6f654c911f42b"}}}}
{"actor":{"display_login":"houndci-bot"}}