{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/sdk/pulls/comments/95254023","pull_request_review_id":15803599,"id":95254023,"diff_hunk":"@@ -28,7 +28,7 @@ public void It_builds_the_project_successfully()\n             // (TestApp transitively depends on AuxLibrary)\n \n             var testAsset = _testAssetsManager\n-                .CopyTestAsset(\"AppWithTransitiveProjectRefs\")\n+                .CopyTestAsset(\"AppWithTransitiveProjectRefs\", \"BuildAppWithTransitiveProjectRef\")","path":"test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildAnAppWithTransitiveProjectRefs.cs","position":5,"original_position":5,"commit_id":"67630b2f21654466047aaf7a967b73cae0307c92","original_commit_id":"67630b2f21654466047aaf7a967b73cae0307c92","user":{"login":"eerhardt","id":8291187,"avatar_url":"https://avatars.githubusercontent.com/u/8291187?v=3","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"Oh, right.  Makes sense.","created_at":"2017-01-09T21:48:58Z","updated_at":"2017-01-09T21:48:58Z","html_url":"https://github.com/dotnet/sdk/pull/608#discussion_r95254023","pull_request_url":"https://api.github.com/repos/dotnet/sdk/pulls/608","_links":{"self":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/comments/95254023"},"html":{"href":"https://github.com/dotnet/sdk/pull/608#discussion_r95254023"},"pull_request":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/608"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/sdk/pulls/608","id":100754008,"html_url":"https://github.com/dotnet/sdk/pull/608","diff_url":"https://github.com/dotnet/sdk/pull/608.diff","patch_url":"https://github.com/dotnet/sdk/pull/608.patch","issue_url":"https://api.github.com/repos/dotnet/sdk/issues/608","number":608,"state":"open","locked":false,"title":"Fix publishing with project references, re-enable tests","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"body":"https://github.com/NuGet/NuGet.Client/pull/1072, adde files under project entries in the assets file, such as the following, under `compile` and `runtime`:\r\n\r\n```json\r\n      \"MainLibrary/1.0.0\": {\r\n        \"type\": \"project\",\r\n        \"framework\": \".NETStandard,Version=v1.4\",\r\n        \"dependencies\": {\r\n          \"AuxLibrary\": \"1.0.0\",\r\n          \"NETStandard.Library\": \"1.6.1\"\r\n        },\r\n        \"compile\": {\r\n          \"bin/placeholder/netstandard1.4/MainLibrary.dll\": {}\r\n        },\r\n        \"runtime\": {\r\n          \"bin/placeholder/netstandard1.4/MainLibrary.dll\": {}\r\n        }\r\n      }\r\n```\r\n\r\nThe `PublishAssembliesResolver` was trying to process the runtime files and getting a null reference because the package directory returned from the resolver was null.  I believe the right thing to do is to skip these projects entirely in `PublishAssembliesResolver.Resolve`, as the runtime and native assets from those projects should already have come in via the `ProjectReference` process.\r\n\r\n@natidea @emgarten @eerhardt for review","created_at":"2017-01-09T20:24:53Z","updated_at":"2017-01-09T21:48:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb9927fa092ca1a4f1510d902cbd91c69b261044","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/sdk/pulls/608/commits","review_comments_url":"https://api.github.com/repos/dotnet/sdk/pulls/608/comments","review_comment_url":"https://api.github.com/repos/dotnet/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/sdk/issues/608/comments","statuses_url":"https://api.github.com/repos/dotnet/sdk/statuses/67630b2f21654466047aaf7a967b73cae0307c92","head":{"label":"dsplaisted:fix-publish","ref":"fix-publish","sha":"67630b2f21654466047aaf7a967b73cae0307c92","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"repo":{"id":71603526,"name":"sdk","full_name":"dsplaisted/sdk","owner":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsplaisted/sdk","description":"Core functionality needed to create .NET Core projects, that is shared between VisualStudio and CLI","fork":true,"url":"https://api.github.com/repos/dsplaisted/sdk","forks_url":"https://api.github.com/repos/dsplaisted/sdk/forks","keys_url":"https://api.github.com/repos/dsplaisted/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsplaisted/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsplaisted/sdk/teams","hooks_url":"https://api.github.com/repos/dsplaisted/sdk/hooks","issue_events_url":"https://api.github.com/repos/dsplaisted/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/dsplaisted/sdk/events","assignees_url":"https://api.github.com/repos/dsplaisted/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/dsplaisted/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/dsplaisted/sdk/tags","blobs_url":"https://api.github.com/repos/dsplaisted/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsplaisted/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsplaisted/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsplaisted/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsplaisted/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/dsplaisted/sdk/languages","stargazers_url":"https://api.github.com/repos/dsplaisted/sdk/stargazers","contributors_url":"https://api.github.com/repos/dsplaisted/sdk/contributors","subscribers_url":"https://api.github.com/repos/dsplaisted/sdk/subscribers","subscription_url":"https://api.github.com/repos/dsplaisted/sdk/subscription","commits_url":"https://api.github.com/repos/dsplaisted/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsplaisted/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsplaisted/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsplaisted/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsplaisted/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/dsplaisted/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsplaisted/sdk/merges","archive_url":"https://api.github.com/repos/dsplaisted/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsplaisted/sdk/downloads","issues_url":"https://api.github.com/repos/dsplaisted/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/dsplaisted/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/dsplaisted/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/dsplaisted/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsplaisted/sdk/labels{/name}","releases_url":"https://api.github.com/repos/dsplaisted/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/dsplaisted/sdk/deployments","created_at":"2016-10-21T23:10:24Z","updated_at":"2016-10-21T23:11:54Z","pushed_at":"2017-01-09T20:57:01Z","git_url":"git://github.com/dsplaisted/sdk.git","ssh_url":"git@github.com:dsplaisted/sdk.git","clone_url":"https://github.com/dsplaisted/sdk.git","svn_url":"https://github.com/dsplaisted/sdk","homepage":"","size":1411,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"183394cfc07c317501297f91208b5c6313b09d76","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":63984307,"name":"sdk","full_name":"dotnet/sdk","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/sdk","description":"Core functionality needed to create .NET Core projects, that is shared between VisualStudio and CLI","fork":false,"url":"https://api.github.com/repos/dotnet/sdk","forks_url":"https://api.github.com/repos/dotnet/sdk/forks","keys_url":"https://api.github.com/repos/dotnet/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/sdk/teams","hooks_url":"https://api.github.com/repos/dotnet/sdk/hooks","issue_events_url":"https://api.github.com/repos/dotnet/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/sdk/events","assignees_url":"https://api.github.com/repos/dotnet/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/sdk/tags","blobs_url":"https://api.github.com/repos/dotnet/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/sdk/languages","stargazers_url":"https://api.github.com/repos/dotnet/sdk/stargazers","contributors_url":"https://api.github.com/repos/dotnet/sdk/contributors","subscribers_url":"https://api.github.com/repos/dotnet/sdk/subscribers","subscription_url":"https://api.github.com/repos/dotnet/sdk/subscription","commits_url":"https://api.github.com/repos/dotnet/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/sdk/merges","archive_url":"https://api.github.com/repos/dotnet/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/sdk/downloads","issues_url":"https://api.github.com/repos/dotnet/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/sdk/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/sdk/deployments","created_at":"2016-07-22T21:26:02Z","updated_at":"2017-01-02T14:32:33Z","pushed_at":"2017-01-09T21:33:40Z","git_url":"git://github.com/dotnet/sdk.git","ssh_url":"git@github.com:dotnet/sdk.git","clone_url":"https://github.com/dotnet/sdk.git","svn_url":"https://github.com/dotnet/sdk","homepage":"htts://dot.net/core","size":1407,"stargazers_count":57,"watchers_count":57,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":126,"forks":38,"open_issues":126,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/608"},"html":{"href":"https://github.com/dotnet/sdk/pull/608"},"issue":{"href":"https://api.github.com/repos/dotnet/sdk/issues/608"},"comments":{"href":"https://api.github.com/repos/dotnet/sdk/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/sdk/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/sdk/statuses/67630b2f21654466047aaf7a967b73cae0307c92"}}}}
{"actor":{"display_login":"eerhardt"}}