{"action":"created","comment":{"url":"https://api.github.com/repos/9hack/aldente/pulls/comments/112801403","pull_request_review_id":34148671,"id":112801403,"diff_hunk":"@@ -0,0 +1,196 @@\n+#include \"keyboard.h\"\n+#include \"aldente.h\"\n+#include \"physics.h\"\n+#include \"scene/scene_camera.h\"\n+\n+bool Keyboard::keys[1024];\n+bool Keyboard::lmb_down;\n+bool Keyboard::rmb_down;\n+bool Keyboard::mouse_moved;\n+glm::vec3 Keyboard::last_cursor_pos;\n+\n+// TODO : This class won't be used in the final game anyways.\n+const GLfloat BASE_CAM_SPEED = 0.1f;","path":"src/keyboard.cpp","position":13,"original_position":13,"commit_id":"c9fceeea874d23b4fb49ebfa4b62fd3c54cad7d4","original_commit_id":"c9fceeea874d23b4fb49ebfa4b62fd3c54cad7d4","user":{"login":"metakirby5","id":3402603,"avatar_url":"https://avatars0.githubusercontent.com/u/3402603?v=3","gravatar_id":"","url":"https://api.github.com/users/metakirby5","html_url":"https://github.com/metakirby5","followers_url":"https://api.github.com/users/metakirby5/followers","following_url":"https://api.github.com/users/metakirby5/following{/other_user}","gists_url":"https://api.github.com/users/metakirby5/gists{/gist_id}","starred_url":"https://api.github.com/users/metakirby5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metakirby5/subscriptions","organizations_url":"https://api.github.com/users/metakirby5/orgs","repos_url":"https://api.github.com/users/metakirby5/repos","events_url":"https://api.github.com/users/metakirby5/events{/privacy}","received_events_url":"https://api.github.com/users/metakirby5/received_events","type":"User","site_admin":false},"body":"Please qualify with static if these are not meant to be globally visible.\r\n\r\nAlso, we should separate input logic from camera logic. Consider a separate `Camera` module, and we can lump in keyboard and mouse stuff into our existing gamepad-handling `input` module.","created_at":"2017-04-22T03:10:48Z","updated_at":"2017-04-22T03:14:41Z","html_url":"https://github.com/9hack/aldente/pull/18#discussion_r112801403","pull_request_url":"https://api.github.com/repos/9hack/aldente/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/9hack/aldente/pulls/comments/112801403"},"html":{"href":"https://github.com/9hack/aldente/pull/18#discussion_r112801403"},"pull_request":{"href":"https://api.github.com/repos/9hack/aldente/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/9hack/aldente/pulls/18","id":116901832,"html_url":"https://github.com/9hack/aldente/pull/18","diff_url":"https://github.com/9hack/aldente/pull/18.diff","patch_url":"https://github.com/9hack/aldente/pull/18.patch","issue_url":"https://api.github.com/repos/9hack/aldente/issues/18","number":18,"state":"open","locked":false,"title":"My name is Austin \"Refactor\" Puk","user":{"login":"jytang","id":5395665,"avatar_url":"https://avatars1.githubusercontent.com/u/5395665?v=3","gravatar_id":"","url":"https://api.github.com/users/jytang","html_url":"https://github.com/jytang","followers_url":"https://api.github.com/users/jytang/followers","following_url":"https://api.github.com/users/jytang/following{/other_user}","gists_url":"https://api.github.com/users/jytang/gists{/gist_id}","starred_url":"https://api.github.com/users/jytang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jytang/subscriptions","organizations_url":"https://api.github.com/users/jytang/orgs","repos_url":"https://api.github.com/users/jytang/repos","events_url":"https://api.github.com/users/jytang/events{/privacy}","received_events_url":"https://api.github.com/users/jytang/received_events","type":"User","site_admin":false},"body":"\"don't worry about Keyboard for now, it kind of needs attention\"","created_at":"2017-04-21T02:43:32Z","updated_at":"2017-04-22T03:14:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26dd87991959bf556d52ac5e2895fe0226123e82","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/9hack/aldente/pulls/18/commits","review_comments_url":"https://api.github.com/repos/9hack/aldente/pulls/18/comments","review_comment_url":"https://api.github.com/repos/9hack/aldente/pulls/comments{/number}","comments_url":"https://api.github.com/repos/9hack/aldente/issues/18/comments","statuses_url":"https://api.github.com/repos/9hack/aldente/statuses/c9fceeea874d23b4fb49ebfa4b62fd3c54cad7d4","head":{"label":"9hack:scene_structure","ref":"scene_structure","sha":"c9fceeea874d23b4fb49ebfa4b62fd3c54cad7d4","user":{"login":"9hack","id":27243771,"avatar_url":"https://avatars3.githubusercontent.com/u/27243771?v=3","gravatar_id":"","url":"https://api.github.com/users/9hack","html_url":"https://github.com/9hack","followers_url":"https://api.github.com/users/9hack/followers","following_url":"https://api.github.com/users/9hack/following{/other_user}","gists_url":"https://api.github.com/users/9hack/gists{/gist_id}","starred_url":"https://api.github.com/users/9hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9hack/subscriptions","organizations_url":"https://api.github.com/users/9hack/orgs","repos_url":"https://api.github.com/users/9hack/repos","events_url":"https://api.github.com/users/9hack/events{/privacy}","received_events_url":"https://api.github.com/users/9hack/received_events","type":"Organization","site_admin":false},"repo":{"id":87496187,"name":"aldente","full_name":"9hack/aldente","owner":{"login":"9hack","id":27243771,"avatar_url":"https://avatars3.githubusercontent.com/u/27243771?v=3","gravatar_id":"","url":"https://api.github.com/users/9hack","html_url":"https://github.com/9hack","followers_url":"https://api.github.com/users/9hack/followers","following_url":"https://api.github.com/users/9hack/following{/other_user}","gists_url":"https://api.github.com/users/9hack/gists{/gist_id}","starred_url":"https://api.github.com/users/9hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9hack/subscriptions","organizations_url":"https://api.github.com/users/9hack/orgs","repos_url":"https://api.github.com/users/9hack/repos","events_url":"https://api.github.com/users/9hack/events{/privacy}","received_events_url":"https://api.github.com/users/9hack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/9hack/aldente","description":"Main repository.","fork":false,"url":"https://api.github.com/repos/9hack/aldente","forks_url":"https://api.github.com/repos/9hack/aldente/forks","keys_url":"https://api.github.com/repos/9hack/aldente/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9hack/aldente/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9hack/aldente/teams","hooks_url":"https://api.github.com/repos/9hack/aldente/hooks","issue_events_url":"https://api.github.com/repos/9hack/aldente/issues/events{/number}","events_url":"https://api.github.com/repos/9hack/aldente/events","assignees_url":"https://api.github.com/repos/9hack/aldente/assignees{/user}","branches_url":"https://api.github.com/repos/9hack/aldente/branches{/branch}","tags_url":"https://api.github.com/repos/9hack/aldente/tags","blobs_url":"https://api.github.com/repos/9hack/aldente/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9hack/aldente/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9hack/aldente/git/refs{/sha}","trees_url":"https://api.github.com/repos/9hack/aldente/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9hack/aldente/statuses/{sha}","languages_url":"https://api.github.com/repos/9hack/aldente/languages","stargazers_url":"https://api.github.com/repos/9hack/aldente/stargazers","contributors_url":"https://api.github.com/repos/9hack/aldente/contributors","subscribers_url":"https://api.github.com/repos/9hack/aldente/subscribers","subscription_url":"https://api.github.com/repos/9hack/aldente/subscription","commits_url":"https://api.github.com/repos/9hack/aldente/commits{/sha}","git_commits_url":"https://api.github.com/repos/9hack/aldente/git/commits{/sha}","comments_url":"https://api.github.com/repos/9hack/aldente/comments{/number}","issue_comment_url":"https://api.github.com/repos/9hack/aldente/issues/comments{/number}","contents_url":"https://api.github.com/repos/9hack/aldente/contents/{+path}","compare_url":"https://api.github.com/repos/9hack/aldente/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9hack/aldente/merges","archive_url":"https://api.github.com/repos/9hack/aldente/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9hack/aldente/downloads","issues_url":"https://api.github.com/repos/9hack/aldente/issues{/number}","pulls_url":"https://api.github.com/repos/9hack/aldente/pulls{/number}","milestones_url":"https://api.github.com/repos/9hack/aldente/milestones{/number}","notifications_url":"https://api.github.com/repos/9hack/aldente/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9hack/aldente/labels{/name}","releases_url":"https://api.github.com/repos/9hack/aldente/releases{/id}","deployments_url":"https://api.github.com/repos/9hack/aldente/deployments","created_at":"2017-04-07T02:33:12Z","updated_at":"2017-04-18T07:52:27Z","pushed_at":"2017-04-22T01:32:33Z","git_url":"git://github.com/9hack/aldente.git","ssh_url":"git@github.com:9hack/aldente.git","clone_url":"https://github.com/9hack/aldente.git","svn_url":"https://github.com/9hack/aldente","homepage":"","size":22786,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"9hack:master","ref":"master","sha":"2bf06c1260af6595f8d476d6d32f7691ea13a3cb","user":{"login":"9hack","id":27243771,"avatar_url":"https://avatars3.githubusercontent.com/u/27243771?v=3","gravatar_id":"","url":"https://api.github.com/users/9hack","html_url":"https://github.com/9hack","followers_url":"https://api.github.com/users/9hack/followers","following_url":"https://api.github.com/users/9hack/following{/other_user}","gists_url":"https://api.github.com/users/9hack/gists{/gist_id}","starred_url":"https://api.github.com/users/9hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9hack/subscriptions","organizations_url":"https://api.github.com/users/9hack/orgs","repos_url":"https://api.github.com/users/9hack/repos","events_url":"https://api.github.com/users/9hack/events{/privacy}","received_events_url":"https://api.github.com/users/9hack/received_events","type":"Organization","site_admin":false},"repo":{"id":87496187,"name":"aldente","full_name":"9hack/aldente","owner":{"login":"9hack","id":27243771,"avatar_url":"https://avatars3.githubusercontent.com/u/27243771?v=3","gravatar_id":"","url":"https://api.github.com/users/9hack","html_url":"https://github.com/9hack","followers_url":"https://api.github.com/users/9hack/followers","following_url":"https://api.github.com/users/9hack/following{/other_user}","gists_url":"https://api.github.com/users/9hack/gists{/gist_id}","starred_url":"https://api.github.com/users/9hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9hack/subscriptions","organizations_url":"https://api.github.com/users/9hack/orgs","repos_url":"https://api.github.com/users/9hack/repos","events_url":"https://api.github.com/users/9hack/events{/privacy}","received_events_url":"https://api.github.com/users/9hack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/9hack/aldente","description":"Main repository.","fork":false,"url":"https://api.github.com/repos/9hack/aldente","forks_url":"https://api.github.com/repos/9hack/aldente/forks","keys_url":"https://api.github.com/repos/9hack/aldente/keys{/key_id}","collaborators_url":"https://api.github.com/repos/9hack/aldente/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/9hack/aldente/teams","hooks_url":"https://api.github.com/repos/9hack/aldente/hooks","issue_events_url":"https://api.github.com/repos/9hack/aldente/issues/events{/number}","events_url":"https://api.github.com/repos/9hack/aldente/events","assignees_url":"https://api.github.com/repos/9hack/aldente/assignees{/user}","branches_url":"https://api.github.com/repos/9hack/aldente/branches{/branch}","tags_url":"https://api.github.com/repos/9hack/aldente/tags","blobs_url":"https://api.github.com/repos/9hack/aldente/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/9hack/aldente/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/9hack/aldente/git/refs{/sha}","trees_url":"https://api.github.com/repos/9hack/aldente/git/trees{/sha}","statuses_url":"https://api.github.com/repos/9hack/aldente/statuses/{sha}","languages_url":"https://api.github.com/repos/9hack/aldente/languages","stargazers_url":"https://api.github.com/repos/9hack/aldente/stargazers","contributors_url":"https://api.github.com/repos/9hack/aldente/contributors","subscribers_url":"https://api.github.com/repos/9hack/aldente/subscribers","subscription_url":"https://api.github.com/repos/9hack/aldente/subscription","commits_url":"https://api.github.com/repos/9hack/aldente/commits{/sha}","git_commits_url":"https://api.github.com/repos/9hack/aldente/git/commits{/sha}","comments_url":"https://api.github.com/repos/9hack/aldente/comments{/number}","issue_comment_url":"https://api.github.com/repos/9hack/aldente/issues/comments{/number}","contents_url":"https://api.github.com/repos/9hack/aldente/contents/{+path}","compare_url":"https://api.github.com/repos/9hack/aldente/compare/{base}...{head}","merges_url":"https://api.github.com/repos/9hack/aldente/merges","archive_url":"https://api.github.com/repos/9hack/aldente/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/9hack/aldente/downloads","issues_url":"https://api.github.com/repos/9hack/aldente/issues{/number}","pulls_url":"https://api.github.com/repos/9hack/aldente/pulls{/number}","milestones_url":"https://api.github.com/repos/9hack/aldente/milestones{/number}","notifications_url":"https://api.github.com/repos/9hack/aldente/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/9hack/aldente/labels{/name}","releases_url":"https://api.github.com/repos/9hack/aldente/releases{/id}","deployments_url":"https://api.github.com/repos/9hack/aldente/deployments","created_at":"2017-04-07T02:33:12Z","updated_at":"2017-04-18T07:52:27Z","pushed_at":"2017-04-22T01:32:33Z","git_url":"git://github.com/9hack/aldente.git","ssh_url":"git@github.com:9hack/aldente.git","clone_url":"https://github.com/9hack/aldente.git","svn_url":"https://github.com/9hack/aldente","homepage":"","size":22786,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/9hack/aldente/pulls/18"},"html":{"href":"https://github.com/9hack/aldente/pull/18"},"issue":{"href":"https://api.github.com/repos/9hack/aldente/issues/18"},"comments":{"href":"https://api.github.com/repos/9hack/aldente/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/9hack/aldente/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/9hack/aldente/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/9hack/aldente/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/9hack/aldente/statuses/c9fceeea874d23b4fb49ebfa4b62fd3c54cad7d4"}}}}
{"actor":{"display_login":"metakirby5"}}