{"action":"created","issue":{"url":"https://api.github.com/repos/strongloop/strong-remoting/issues/410","repository_url":"https://api.github.com/repos/strongloop/strong-remoting","labels_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/410/labels{/name}","comments_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/410/comments","events_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/410/events","html_url":"https://github.com/strongloop/strong-remoting/pull/410","id":241395425,"number":410,"title":"Move HTTP normalization to RestAdapter.getRoutes()","user":{"login":"lehni","id":213275,"avatar_url":"https://avatars3.githubusercontent.com/u/213275?v=4","gravatar_id":"","url":"https://api.github.com/users/lehni","html_url":"https://github.com/lehni","followers_url":"https://api.github.com/users/lehni/followers","following_url":"https://api.github.com/users/lehni/following{/other_user}","gists_url":"https://api.github.com/users/lehni/gists{/gist_id}","starred_url":"https://api.github.com/users/lehni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lehni/subscriptions","organizations_url":"https://api.github.com/users/lehni/orgs","repos_url":"https://api.github.com/users/lehni/repos","events_url":"https://api.github.com/users/lehni/events{/privacy}","received_events_url":"https://api.github.com/users/lehni/received_events","type":"User","site_admin":false},"labels":[{"id":310001601,"url":"https://api.github.com/repos/strongloop/strong-remoting/labels/feature","name":"feature","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars1.githubusercontent.com/u/1140553?v=4","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"assignees":[{"login":"bajtos","id":1140553,"avatar_url":"https://avatars1.githubusercontent.com/u/1140553?v=4","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-07-07T22:24:20Z","updated_at":"2017-07-21T09:00:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/strongloop/strong-remoting/pulls/410","html_url":"https://github.com/strongloop/strong-remoting/pull/410","diff_url":"https://github.com/strongloop/strong-remoting/pull/410.diff","patch_url":"https://github.com/strongloop/strong-remoting/pull/410.patch"},"body":"### Description\r\n\r\nSetting `\"normalizeHttpPath\"` in `confing.json` currently has no effect on models:\r\n\r\n```json\r\n\"remoting\": {\r\n  \"rest\": {\r\n    \"normalizeHttpPath\": true\r\n  }\r\n}\r\n```\r\n\r\nThis PR addresses this issue by implementing a proposal that @ritch has mentioned in a comment here:\r\n\r\nhttps://github.com/strongloop/strong-remoting/blob/master/lib/shared-class.js#L64\r\n\r\n#### Related issues\r\n\r\nstrongloop/loopback#608\r\n"},"comment":{"url":"https://api.github.com/repos/strongloop/strong-remoting/issues/comments/316946655","html_url":"https://github.com/strongloop/strong-remoting/pull/410#issuecomment-316946655","issue_url":"https://api.github.com/repos/strongloop/strong-remoting/issues/410","id":316946655,"user":{"login":"bajtos","id":1140553,"avatar_url":"https://avatars1.githubusercontent.com/u/1140553?v=4","gravatar_id":"","url":"https://api.github.com/users/bajtos","html_url":"https://github.com/bajtos","followers_url":"https://api.github.com/users/bajtos/followers","following_url":"https://api.github.com/users/bajtos/following{/other_user}","gists_url":"https://api.github.com/users/bajtos/gists{/gist_id}","starred_url":"https://api.github.com/users/bajtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bajtos/subscriptions","organizations_url":"https://api.github.com/users/bajtos/orgs","repos_url":"https://api.github.com/users/bajtos/repos","events_url":"https://api.github.com/users/bajtos/events{/privacy}","received_events_url":"https://api.github.com/users/bajtos/received_events","type":"User","site_admin":false},"created_at":"2017-07-21T09:00:14Z","updated_at":"2017-07-21T09:00:14Z","body":"> The problem I am seeing is that the tests you point to use givenSharedStaticMethod(), which doesn't even create a SharedClass instance. It just creates an object literal:\r\n`remotes.testClass = {testMethod: fn}`\r\n\r\nThis is the old (legacy) way of defining remote methods, we are supporting it for backwards compatibility.\r\n\r\n> I don't think there would be any normalization either way then?\r\n\r\nWell, there will be normalization when it's configured at the adapter level.\r\n\r\n> I also didn't see any tests that were actually using the paths to invoke the methods. They all use `objects.invoke()` with method.name directly... I do't really know how I would have to write these tests : /\r\n\r\nYeah, I see what you mean. I'll try to find some time next week to investigate this and provide you with an example of such test."}}
{"actor":{"display_login":"bajtos"}}