{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/109953425","pull_request_review_id":31089916,"id":109953425,"diff_hunk":"@@ -61,6 +67,15 @@ module.exports = CoreView.extend({\n     });\n   },\n \n+  _addNotification: function (error) {","path":"lib/assets/core/javascripts/cartodb3/editor/export-image-pane/export-image-pane.js","position":31,"original_position":31,"commit_id":"4367291c0847d80dd23d13dd3bba41a8cad4135e","original_commit_id":"4367291c0847d80dd23d13dd3bba41a8cad4135e","user":{"login":"javierarce","id":4933,"avatar_url":"https://avatars1.githubusercontent.com/u/4933?v=3","gravatar_id":"","url":"https://api.github.com/users/javierarce","html_url":"https://github.com/javierarce","followers_url":"https://api.github.com/users/javierarce/followers","following_url":"https://api.github.com/users/javierarce/following{/other_user}","gists_url":"https://api.github.com/users/javierarce/gists{/gist_id}","starred_url":"https://api.github.com/users/javierarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierarce/subscriptions","organizations_url":"https://api.github.com/users/javierarce/orgs","repos_url":"https://api.github.com/users/javierarce/repos","events_url":"https://api.github.com/users/javierarce/events{/privacy}","received_events_url":"https://api.github.com/users/javierarce/received_events","type":"User","site_admin":false},"body":"👌 ","created_at":"2017-04-05T15:47:49Z","updated_at":"2017-04-05T15:47:49Z","html_url":"https://github.com/CartoDB/cartodb/pull/11920#discussion_r109953425","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/11920","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/109953425"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/11920#discussion_r109953425"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/11920"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/11920","id":114338976,"html_url":"https://github.com/CartoDB/cartodb/pull/11920","diff_url":"https://github.com/CartoDB/cartodb/pull/11920.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/11920.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11920","number":11920,"state":"open","locked":false,"title":"Show errors on Image Export","user":{"login":"javierarce","id":4933,"avatar_url":"https://avatars1.githubusercontent.com/u/4933?v=3","gravatar_id":"","url":"https://api.github.com/users/javierarce","html_url":"https://github.com/javierarce","followers_url":"https://api.github.com/users/javierarce/followers","following_url":"https://api.github.com/users/javierarce/following{/other_user}","gists_url":"https://api.github.com/users/javierarce/gists{/gist_id}","starred_url":"https://api.github.com/users/javierarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierarce/subscriptions","organizations_url":"https://api.github.com/users/javierarce/orgs","repos_url":"https://api.github.com/users/javierarce/repos","events_url":"https://api.github.com/users/javierarce/events{/privacy}","received_events_url":"https://api.github.com/users/javierarce/received_events","type":"User","site_admin":false},"body":"This PR adds errors on the image export functionality.\r\n\r\n![screen shot 2017-04-05 at 11 42 57](https://cloud.githubusercontent.com/assets/4933/24700400/566c2884-19f7-11e7-93fa-11be5b229b81.png)\r\n\r\nThe following errors are rendered:\r\n\r\n- \"Error generating attribution. Please, try again. If the problem persists, contact support\"\r\n- \"Error loading basemap. Please, try again. If the problem persists, contact support\",\r\n- \"Error generating image. Please, try again. If the problem persists, contact support\"\r\n\r\n### How to test\r\n\r\n1. Create a map.\r\n2. Export an image in a way that causes an error (for example, go offline before generating the image or use a fake Google Maps API key)\r\n\r\nOriginal issue: https://github.com/CartoDB/cartodb/issues/11887","created_at":"2017-04-05T10:01:50Z","updated_at":"2017-04-05T15:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e940812bfe0e67be6ba5da9905614f575faf4368","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/11920/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/11920/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11920/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/4367291c0847d80dd23d13dd3bba41a8cad4135e","head":{"label":"CartoDB:11887-image-export-error","ref":"11887-image-export-error","sha":"4367291c0847d80dd23d13dd3bba41a8cad4135e","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars3.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars3.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2017-04-05T14:06:26Z","pushed_at":"2017-04-05T15:43:09Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":349323,"stargazers_count":1431,"watchers_count":1431,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":403,"mirror_url":null,"open_issues_count":725,"forks":403,"open_issues":725,"watchers":1431,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"37b4546d89e820406d832dcaeee0fff73737c7e5","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars3.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars3.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2017-04-05T14:06:26Z","pushed_at":"2017-04-05T15:43:09Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":349323,"stargazers_count":1431,"watchers_count":1431,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":403,"mirror_url":null,"open_issues_count":725,"forks":403,"open_issues":725,"watchers":1431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/11920"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/11920"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/11920"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/11920/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/11920/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/11920/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/4367291c0847d80dd23d13dd3bba41a8cad4135e"}}}}
{"actor":{"display_login":"javierarce"}}