{"action":"created","issue":{"url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/184","repository_url":"https://api.github.com/repos/bluejekyll/trust-dns","labels_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/184/comments","events_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/184/events","html_url":"https://github.com/bluejekyll/trust-dns/issues/184","id":256867929,"number":184,"title":"[Resolver] Allow CNAME returns on Resolver requests for Records","user":{"login":"bluejekyll","id":986845,"avatar_url":"https://avatars3.githubusercontent.com/u/986845?v=4","gravatar_id":"","url":"https://api.github.com/users/bluejekyll","html_url":"https://github.com/bluejekyll","followers_url":"https://api.github.com/users/bluejekyll/followers","following_url":"https://api.github.com/users/bluejekyll/following{/other_user}","gists_url":"https://api.github.com/users/bluejekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/bluejekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluejekyll/subscriptions","organizations_url":"https://api.github.com/users/bluejekyll/orgs","repos_url":"https://api.github.com/users/bluejekyll/repos","events_url":"https://api.github.com/users/bluejekyll/events{/privacy}","received_events_url":"https://api.github.com/users/bluejekyll/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-09-11T23:06:12Z","updated_at":"2017-09-11T23:58:24Z","closed_at":null,"author_association":"OWNER","body":"From: https://github.com/bluejekyll/trust-dns/commit/b68318e2b97701dede0702b7c9414ac41d7045f0#commitcomment-24233884\r\n\r\n> @NfNitLoop\r\n\r\nBTW, I ran into an issue where if I do a lookup for RecordType::A, I only get back A records. It'd be super handy to get back any intermediate CNAME records too. (I want both, and would like to be able to grab them in one query instead of making two every time.) I tried reading the code to see if it was filtering those by the RecordType I passed in but I have to admit I got lost in all the async code.\r\n\r\nAre you on the #rust IRC channel by any chance? I'm NfNitLoop there. I don't want to bloat your commit with too much conversation. :p"},"comment":{"url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/comments/328691550","html_url":"https://github.com/bluejekyll/trust-dns/issues/184#issuecomment-328691550","issue_url":"https://api.github.com/repos/bluejekyll/trust-dns/issues/184","id":328691550,"user":{"login":"bluejekyll","id":986845,"avatar_url":"https://avatars3.githubusercontent.com/u/986845?v=4","gravatar_id":"","url":"https://api.github.com/users/bluejekyll","html_url":"https://github.com/bluejekyll","followers_url":"https://api.github.com/users/bluejekyll/followers","following_url":"https://api.github.com/users/bluejekyll/following{/other_user}","gists_url":"https://api.github.com/users/bluejekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/bluejekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluejekyll/subscriptions","organizations_url":"https://api.github.com/users/bluejekyll/orgs","repos_url":"https://api.github.com/users/bluejekyll/repos","events_url":"https://api.github.com/users/bluejekyll/events{/privacy}","received_events_url":"https://api.github.com/users/bluejekyll/received_events","type":"User","site_admin":false},"created_at":"2017-09-11T23:58:24Z","updated_at":"2017-09-11T23:58:24Z","author_association":"OWNER","body":"> That's a no-go.\r\n\r\nI figured... worth a shot :)\r\n\r\n>  opts.validate = false;\r\n\r\nThat only applies to DNSSec, and you wouldn't want that, as I strip invalidly signed DNSSec response records. Though I've been considering changing that to always return, and allow the user to decide what to do with invalid records.\r\n\r\n> Hmm, I'm not versed enough in DNS to follow here. I see the RData::CNAME(Name), though?\r\n\r\nSo a response is generally broken up into three sections, Answer (records that match the query), Authority/Nameservers (SOA records and/or Nameservers for the zone) and Additional (SIG0, EDNS, etc.).\r\n\r\nFor CNAME responses you basically get this in the Answers section (though sometimes Answer + Additional), assuming this was an A record lookup:\r\n\r\n```\r\nwww.example.com  CNAME host1.example.com\r\nhost1.example.com A           192.168.0.1\r\n```\r\n\r\nTaking this example, the `www.example.com` in the first `CNAME` record is the label/name of the record, `CNAME` the type, and `host1.example.com` the RData. What I was pointing out with my comment, and the reason this interface is problematic for your use case is that I don't return the entire Record, just the RData. So what this would mean is it would look like you're getting `192.168.0.1` as it's associated with a query for `www.example.com` and an `A` record type, but in fact it's associated with the name `host1.example.com`.\r\n\r\nThis might mean that the interface for this function should be more generalized so that this information is more obvious. But, I am still leaning toward pushing towards the client which allows for all of this data to be viewed. Does all of that makes sense?"}}
{"actor":{"display_login":"bluejekyll"}}