{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/126703109","pull_request_review_id":49209348,"id":126703109,"diff_hunk":"@@ -169,6 +170,20 @@ public function isRequired()\n     }\n \n     /**\n+     * Sets the node as deprecated.\n+     *\n+     * @param string $message Deprecation message\n+     *\n+     * @return $this\n+     */\n+    public function isDeprecated($message = 'The child node \"%node%\" at path \"%path%\" is deprecated.')\n+    {\n+        $this->deprecatedMessage = $message;","path":"src/Symfony/Component/Config/Definition/Builder/NodeDefinition.php","position":20,"original_position":20,"commit_id":"8e8fa55cc1da9ae04a7abe2cd1a76d100b0f0828","original_commit_id":"8e8fa55cc1da9ae04a7abe2cd1a76d100b0f0828","user":{"login":"nicolas-grekas","id":243674,"avatar_url":"https://avatars0.githubusercontent.com/u/243674?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"body":"[in Definition](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Definition.php#L680), we enforce that the placeholder is used, we should do the same here IMHO, for both placeholders","created_at":"2017-07-11T14:22:22Z","updated_at":"2017-07-11T14:23:16Z","html_url":"https://github.com/symfony/symfony/pull/22382#discussion_r126703109","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/22382","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/126703109"},"html":{"href":"https://github.com/symfony/symfony/pull/22382#discussion_r126703109"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/22382"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/22382","id":115403669,"html_url":"https://github.com/symfony/symfony/pull/22382","diff_url":"https://github.com/symfony/symfony/pull/22382.diff","patch_url":"https://github.com/symfony/symfony/pull/22382.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/22382","number":22382,"state":"open","locked":false,"title":"[config] Add abbitily to deprecate a node","user":{"login":"sanpii","id":113045,"avatar_url":"https://avatars0.githubusercontent.com/u/113045?v=3","gravatar_id":"","url":"https://api.github.com/users/sanpii","html_url":"https://github.com/sanpii","followers_url":"https://api.github.com/users/sanpii/followers","following_url":"https://api.github.com/users/sanpii/following{/other_user}","gists_url":"https://api.github.com/users/sanpii/gists{/gist_id}","starred_url":"https://api.github.com/users/sanpii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanpii/subscriptions","organizations_url":"https://api.github.com/users/sanpii/orgs","repos_url":"https://api.github.com/users/sanpii/repos","events_url":"https://api.github.com/users/sanpii/events{/privacy}","received_events_url":"https://api.github.com/users/sanpii/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | maybe\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | n/a\r\n| License       | MIT\r\n| Doc PR        | https://github.com/symfony/symfony-docs/pull/7794\r\n\r\nFor BC breaks, I don’t know if modifying the Xml and Yaml dumper output is considering as a BC break (it’s just a comment).","created_at":"2017-04-11T20:07:44Z","updated_at":"2017-07-11T14:23:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aae5b57266a4aff3834dbc72afbfdc1ab2661388","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.4","description":"https://symfony.com/roadmap?version=3.4#checker","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars0.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":139,"closed_issues":109,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2017-07-11T14:03:42Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/22382/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/22382/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/22382/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/8e8fa55cc1da9ae04a7abe2cd1a76d100b0f0828","head":{"label":"sanpii:config-deprecated","ref":"config-deprecated","sha":"8e8fa55cc1da9ae04a7abe2cd1a76d100b0f0828","user":{"login":"sanpii","id":113045,"avatar_url":"https://avatars0.githubusercontent.com/u/113045?v=3","gravatar_id":"","url":"https://api.github.com/users/sanpii","html_url":"https://github.com/sanpii","followers_url":"https://api.github.com/users/sanpii/followers","following_url":"https://api.github.com/users/sanpii/following{/other_user}","gists_url":"https://api.github.com/users/sanpii/gists{/gist_id}","starred_url":"https://api.github.com/users/sanpii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanpii/subscriptions","organizations_url":"https://api.github.com/users/sanpii/orgs","repos_url":"https://api.github.com/users/sanpii/repos","events_url":"https://api.github.com/users/sanpii/events{/privacy}","received_events_url":"https://api.github.com/users/sanpii/received_events","type":"User","site_admin":false},"repo":{"id":50854858,"name":"symfony","full_name":"sanpii/symfony","owner":{"login":"sanpii","id":113045,"avatar_url":"https://avatars0.githubusercontent.com/u/113045?v=3","gravatar_id":"","url":"https://api.github.com/users/sanpii","html_url":"https://github.com/sanpii","followers_url":"https://api.github.com/users/sanpii/followers","following_url":"https://api.github.com/users/sanpii/following{/other_user}","gists_url":"https://api.github.com/users/sanpii/gists{/gist_id}","starred_url":"https://api.github.com/users/sanpii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanpii/subscriptions","organizations_url":"https://api.github.com/users/sanpii/orgs","repos_url":"https://api.github.com/users/sanpii/repos","events_url":"https://api.github.com/users/sanpii/events{/privacy}","received_events_url":"https://api.github.com/users/sanpii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sanpii/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/sanpii/symfony","forks_url":"https://api.github.com/repos/sanpii/symfony/forks","keys_url":"https://api.github.com/repos/sanpii/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanpii/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanpii/symfony/teams","hooks_url":"https://api.github.com/repos/sanpii/symfony/hooks","issue_events_url":"https://api.github.com/repos/sanpii/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/sanpii/symfony/events","assignees_url":"https://api.github.com/repos/sanpii/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/sanpii/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/sanpii/symfony/tags","blobs_url":"https://api.github.com/repos/sanpii/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanpii/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanpii/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanpii/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanpii/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/sanpii/symfony/languages","stargazers_url":"https://api.github.com/repos/sanpii/symfony/stargazers","contributors_url":"https://api.github.com/repos/sanpii/symfony/contributors","subscribers_url":"https://api.github.com/repos/sanpii/symfony/subscribers","subscription_url":"https://api.github.com/repos/sanpii/symfony/subscription","commits_url":"https://api.github.com/repos/sanpii/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanpii/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanpii/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanpii/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanpii/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/sanpii/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanpii/symfony/merges","archive_url":"https://api.github.com/repos/sanpii/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanpii/symfony/downloads","issues_url":"https://api.github.com/repos/sanpii/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/sanpii/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/sanpii/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/sanpii/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanpii/symfony/labels{/name}","releases_url":"https://api.github.com/repos/sanpii/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/sanpii/symfony/deployments","created_at":"2016-02-01T16:56:16Z","updated_at":"2016-02-01T16:56:29Z","pushed_at":"2017-07-08T16:02:15Z","git_url":"git://github.com/sanpii/symfony.git","ssh_url":"git@github.com:sanpii/symfony.git","clone_url":"https://github.com/sanpii/symfony.git","svn_url":"https://github.com/sanpii/symfony","homepage":"symfony.com","size":94913,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"d203ee33954f4e0c5b39cdc6224fe4fb96cac0c3","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars0.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars0.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-07-11T12:28:54Z","pushed_at":"2017-07-11T14:22:46Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":99030,"stargazers_count":14814,"watchers_count":14814,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5596,"mirror_url":null,"open_issues_count":837,"forks":5596,"open_issues":837,"watchers":14814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/22382"},"html":{"href":"https://github.com/symfony/symfony/pull/22382"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/22382"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/22382/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/22382/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/22382/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/8e8fa55cc1da9ae04a7abe2cd1a76d100b0f0828"}}}}
{"actor":{"display_login":"nicolas-grekas"}}