{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42296","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42296/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42296/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42296/events","html_url":"https://github.com/kubernetes/kubernetes/pull/42296","id":210958203,"number":42296,"title":"[Federation] Improve the logging and user feedback in 'kubefed init'","user":{"login":"perotinus","id":5122391,"avatar_url":"https://avatars2.githubusercontent.com/u/5122391?v=3","gravatar_id":"","url":"https://api.github.com/users/perotinus","html_url":"https://github.com/perotinus","followers_url":"https://api.github.com/users/perotinus/followers","following_url":"https://api.github.com/users/perotinus/following{/other_user}","gists_url":"https://api.github.com/users/perotinus/gists{/gist_id}","starred_url":"https://api.github.com/users/perotinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perotinus/subscriptions","organizations_url":"https://api.github.com/users/perotinus/orgs","repos_url":"https://api.github.com/users/perotinus/repos","events_url":"https://api.github.com/users/perotinus/events{/privacy}","received_events_url":"https://api.github.com/users/perotinus/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":258410135,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/federation","name":"sig/federation","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars3.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},"assignees":[{"login":"madhusudancs","id":10183,"avatar_url":"https://avatars3.githubusercontent.com/u/10183?v=3","gravatar_id":"","url":"https://api.github.com/users/madhusudancs","html_url":"https://github.com/madhusudancs","followers_url":"https://api.github.com/users/madhusudancs/followers","following_url":"https://api.github.com/users/madhusudancs/following{/other_user}","gists_url":"https://api.github.com/users/madhusudancs/gists{/gist_id}","starred_url":"https://api.github.com/users/madhusudancs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhusudancs/subscriptions","organizations_url":"https://api.github.com/users/madhusudancs/orgs","repos_url":"https://api.github.com/users/madhusudancs/repos","events_url":"https://api.github.com/users/madhusudancs/events{/privacy}","received_events_url":"https://api.github.com/users/madhusudancs/received_events","type":"User","site_admin":false},{"login":"csbell","id":23373339,"avatar_url":"https://avatars2.githubusercontent.com/u/23373339?v=3","gravatar_id":"","url":"https://api.github.com/users/csbell","html_url":"https://github.com/csbell","followers_url":"https://api.github.com/users/csbell/followers","following_url":"https://api.github.com/users/csbell/following{/other_user}","gists_url":"https://api.github.com/users/csbell/gists{/gist_id}","starred_url":"https://api.github.com/users/csbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csbell/subscriptions","organizations_url":"https://api.github.com/users/csbell/orgs","repos_url":"https://api.github.com/users/csbell/repos","events_url":"https://api.github.com/users/csbell/events{/privacy}","received_events_url":"https://api.github.com/users/csbell/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/32","html_url":"https://github.com/kubernetes/kubernetes/milestone/32","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/32/labels","id":2264750,"number":32,"title":"v1.7","description":"","creator":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars3.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"open_issues":309,"closed_issues":215,"state":"open","created_at":"2017-01-19T17:41:27Z","updated_at":"2017-05-09T21:02:40Z","due_on":null,"closed_at":null},"comments":25,"created_at":"2017-03-01T02:02:01Z","updated_at":"2017-05-09T23:08:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42296","html_url":"https://github.com/kubernetes/kubernetes/pull/42296","diff_url":"https://github.com/kubernetes/kubernetes/pull/42296.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/42296.patch"},"body":"This is a follow-up to #41849, which added some status information. This PR is based off of that one, and includes its changes as well.\r\n\r\nSee #41725.\r\n\r\n```release-note\r\nNone\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/300326972","html_url":"https://github.com/kubernetes/kubernetes/pull/42296#issuecomment-300326972","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42296","id":300326972,"user":{"login":"perotinus","id":5122391,"avatar_url":"https://avatars2.githubusercontent.com/u/5122391?v=3","gravatar_id":"","url":"https://api.github.com/users/perotinus","html_url":"https://github.com/perotinus","followers_url":"https://api.github.com/users/perotinus/followers","following_url":"https://api.github.com/users/perotinus/following{/other_user}","gists_url":"https://api.github.com/users/perotinus/gists{/gist_id}","starred_url":"https://api.github.com/users/perotinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perotinus/subscriptions","organizations_url":"https://api.github.com/users/perotinus/orgs","repos_url":"https://api.github.com/users/perotinus/repos","events_url":"https://api.github.com/users/perotinus/events{/privacy}","received_events_url":"https://api.github.com/users/perotinus/received_events","type":"User","site_admin":false},"created_at":"2017-05-09T23:08:05Z","updated_at":"2017-05-09T23:08:05Z","body":"Heh. Someone recommended in an earlier PR to remove the ellipses, but with this change, it seems to make sense to add them back.\n\n---\n\nReview status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.\n\n---\n\n*[federation/pkg/kubefed/init/init.go, line 304 at r3](https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/42296#-KiXJMwkfU8NSZrwb8R8:-KjjPcLk6I8Lb5fa2bH8:b-vp8ga4) ([raw file](https://github.com/kubernetes/kubernetes/blob/55ce28bfbc7f7ca553ec4768606786b052aa839c/federation/pkg/kubefed/init/init.go#L304)):*\n<details><summary><i>Previously, marun (Maru Newby) wrote…</i></summary><blockquote>\n\nWhat's to stop a period from appearing at the start of a line, e.g.\n\n```\n.Creating federation control plane service\n```\n\nNot the end of the world, but it would probably annoy me.\n</blockquote></details>\n\nThis should be fixed now, based on @madhusudancs's suggestions.\n\n---\n\n*[federation/pkg/kubefed/init/init.go, line 88 at r4](https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/42296#-KjU1AlUPy8uYB5j0x5R:-KjjT2976zfs3SjYfgH6:b-896fix) ([raw file](https://github.com/kubernetes/kubernetes/blob/604e63c3e2ba1d3f24d30c97c9b50d53867b178f/federation/pkg/kubefed/init/init.go#L88)):*\n<details><summary><i>Previously, madhusudancs (Madhusudan.C.S) wrote…</i></summary><blockquote>\n\n5 minutes is low. GCE LB allocations can sometimes take longer. This should be somewhere in the 20 minutes ballpark. I would just get rid of this for now by using `PollInfinite` and address this as part of issue #43123.\n</blockquote></details>\n\nDone.\n\n---\n\n*[federation/pkg/kubefed/init/init.go, line 301 at r4](https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/42296#-KjU65IR2ATrFe00KKnD:-KjjPb-wCLB2ipWc-p-U:b-896fix) ([raw file](https://github.com/kubernetes/kubernetes/blob/604e63c3e2ba1d3f24d30c97c9b50d53867b178f/federation/pkg/kubefed/init/init.go#L301)):*\n<details><summary><i>Previously, madhusudancs (Madhusudan.C.S) wrote…</i></summary><blockquote>\n\nSee my comment above. This goroutine is not required.\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.kubernetes.io:443/reviews/kubernetes/kubernetes/42296#-:-KjjOgC373dT8u8x2K1W:b-uowj27)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"perotinus"}}