{"action":"created","comment":{"url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/comments/108299529","pull_request_review_id":29322463,"id":108299529,"diff_hunk":"@@ -498,6 +539,30 @@ private static JSONObject createObjectDeleteMessage(int requestId, ParseObject p\n         return jsonObject;\n     }\n \n+    private static class LoggingCallbacks implements ParseLiveQueryClientCallbacks {","path":"ParseLiveQuery/src/test/java/com/parse/TestParseLiveQueryClient.java","position":66,"original_position":66,"commit_id":"89e3809d3c3ba8db5aa020e38abd2254b2d3d25b","original_commit_id":"89e3809d3c3ba8db5aa020e38abd2254b2d3d25b","user":{"login":"jhansche","id":99272,"avatar_url":"https://avatars0.githubusercontent.com/u/99272?v=3","gravatar_id":"","url":"https://api.github.com/users/jhansche","html_url":"https://github.com/jhansche","followers_url":"https://api.github.com/users/jhansche/followers","following_url":"https://api.github.com/users/jhansche/following{/other_user}","gists_url":"https://api.github.com/users/jhansche/gists{/gist_id}","starred_url":"https://api.github.com/users/jhansche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhansche/subscriptions","organizations_url":"https://api.github.com/users/jhansche/orgs","repos_url":"https://api.github.com/users/jhansche/repos","events_url":"https://api.github.com/users/jhansche/events{/privacy}","received_events_url":"https://api.github.com/users/jhansche/received_events","type":"User","site_admin":false},"body":"Ah. Yeah the class still needs to be instantiated in order to use Transcript. It's declared `final`, but not `static`.  So it is still a new Transcript instance for every instance of LoggingCallbacks (as it should be, in order to properly test that the callbacks are invoked when they're supposed to be).\r\n\r\nJust want to make sure we're on the same page about the class and field declarations. The class being declared `static` _does not_ mean that the transcript is a `static` field. It's still an instance field.","created_at":"2017-03-27T22:51:01Z","updated_at":"2017-03-27T22:51:01Z","html_url":"https://github.com/ParsePlatform/ParseLiveQuery-Android/pull/34#discussion_r108299529","pull_request_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/comments/108299529"},"html":{"href":"https://github.com/ParsePlatform/ParseLiveQuery-Android/pull/34#discussion_r108299529"},"pull_request":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/34","id":112833221,"html_url":"https://github.com/ParsePlatform/ParseLiveQuery-Android/pull/34","diff_url":"https://github.com/ParsePlatform/ParseLiveQuery-Android/pull/34.diff","patch_url":"https://github.com/ParsePlatform/ParseLiveQuery-Android/pull/34.patch","issue_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/issues/34","number":34,"state":"open","locked":false,"title":"Add callbacks to be notified of connect/disconnect/error events","user":{"login":"jhansche","id":99272,"avatar_url":"https://avatars0.githubusercontent.com/u/99272?v=3","gravatar_id":"","url":"https://api.github.com/users/jhansche","html_url":"https://github.com/jhansche","followers_url":"https://api.github.com/users/jhansche/followers","following_url":"https://api.github.com/users/jhansche/following{/other_user}","gists_url":"https://api.github.com/users/jhansche/gists{/gist_id}","starred_url":"https://api.github.com/users/jhansche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhansche/subscriptions","organizations_url":"https://api.github.com/users/jhansche/orgs","repos_url":"https://api.github.com/users/jhansche/repos","events_url":"https://api.github.com/users/jhansche/events{/privacy}","received_events_url":"https://api.github.com/users/jhansche/received_events","type":"User","site_admin":false},"body":"This enables a partial fix/workaround for #6, which otherwise wouldn't even\r\nbe possible in its current state.\r\n\r\nFuture changes will allow the client to automatically reconnect when the\r\nconnection has been broken for any reason other than explicit disconnect().","created_at":"2017-03-27T20:37:42Z","updated_at":"2017-03-27T22:51:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31cc60653301fb32252b42ca2fbd5fd7599eb896","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/34/commits","review_comments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/34/comments","review_comment_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/issues/34/comments","statuses_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/statuses/89e3809d3c3ba8db5aa020e38abd2254b2d3d25b","head":{"label":"wondrous-io:pr/register-callbacks","ref":"pr/register-callbacks","sha":"89e3809d3c3ba8db5aa020e38abd2254b2d3d25b","user":{"login":"wondrous-io","id":23220051,"avatar_url":"https://avatars1.githubusercontent.com/u/23220051?v=3","gravatar_id":"","url":"https://api.github.com/users/wondrous-io","html_url":"https://github.com/wondrous-io","followers_url":"https://api.github.com/users/wondrous-io/followers","following_url":"https://api.github.com/users/wondrous-io/following{/other_user}","gists_url":"https://api.github.com/users/wondrous-io/gists{/gist_id}","starred_url":"https://api.github.com/users/wondrous-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wondrous-io/subscriptions","organizations_url":"https://api.github.com/users/wondrous-io/orgs","repos_url":"https://api.github.com/users/wondrous-io/repos","events_url":"https://api.github.com/users/wondrous-io/events{/privacy}","received_events_url":"https://api.github.com/users/wondrous-io/received_events","type":"Organization","site_admin":false},"repo":{"id":85985668,"name":"ParseLiveQuery-Android","full_name":"wondrous-io/ParseLiveQuery-Android","owner":{"login":"wondrous-io","id":23220051,"avatar_url":"https://avatars1.githubusercontent.com/u/23220051?v=3","gravatar_id":"","url":"https://api.github.com/users/wondrous-io","html_url":"https://github.com/wondrous-io","followers_url":"https://api.github.com/users/wondrous-io/followers","following_url":"https://api.github.com/users/wondrous-io/following{/other_user}","gists_url":"https://api.github.com/users/wondrous-io/gists{/gist_id}","starred_url":"https://api.github.com/users/wondrous-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wondrous-io/subscriptions","organizations_url":"https://api.github.com/users/wondrous-io/orgs","repos_url":"https://api.github.com/users/wondrous-io/repos","events_url":"https://api.github.com/users/wondrous-io/events{/privacy}","received_events_url":"https://api.github.com/users/wondrous-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wondrous-io/ParseLiveQuery-Android","description":"Parse LiveQuery client for Android.","fork":true,"url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android","forks_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/forks","keys_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/teams","hooks_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/hooks","issue_events_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/issues/events{/number}","events_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/events","assignees_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/assignees{/user}","branches_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/branches{/branch}","tags_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/tags","blobs_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/languages","stargazers_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/stargazers","contributors_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/contributors","subscribers_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/subscribers","subscription_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/subscription","commits_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/contents/{+path}","compare_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/merges","archive_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/downloads","issues_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/issues{/number}","pulls_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/labels{/name}","releases_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/releases{/id}","deployments_url":"https://api.github.com/repos/wondrous-io/ParseLiveQuery-Android/deployments","created_at":"2017-03-23T18:45:44Z","updated_at":"2017-03-23T18:45:46Z","pushed_at":"2017-03-27T20:36:30Z","git_url":"git://github.com/wondrous-io/ParseLiveQuery-Android.git","ssh_url":"git@github.com:wondrous-io/ParseLiveQuery-Android.git","clone_url":"https://github.com/wondrous-io/ParseLiveQuery-Android.git","svn_url":"https://github.com/wondrous-io/ParseLiveQuery-Android","homepage":"","size":131,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParsePlatform:master","ref":"master","sha":"e299789bf28a1ad2deb1f7bed60d8aa3eca414c6","user":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars2.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":68854119,"name":"ParseLiveQuery-Android","full_name":"ParsePlatform/ParseLiveQuery-Android","owner":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars2.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParsePlatform/ParseLiveQuery-Android","description":"Parse LiveQuery client for Android.","fork":false,"url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android","forks_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/forks","keys_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/teams","hooks_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/hooks","issue_events_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/issues/events{/number}","events_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/events","assignees_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/assignees{/user}","branches_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/branches{/branch}","tags_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/tags","blobs_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/languages","stargazers_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/stargazers","contributors_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/contributors","subscribers_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/subscribers","subscription_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/subscription","commits_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/contents/{+path}","compare_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/merges","archive_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/downloads","issues_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/issues{/number}","pulls_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/labels{/name}","releases_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/releases{/id}","deployments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/deployments","created_at":"2016-09-21T20:16:57Z","updated_at":"2017-03-27T22:25:55Z","pushed_at":"2017-03-27T21:27:21Z","git_url":"git://github.com/ParsePlatform/ParseLiveQuery-Android.git","ssh_url":"git@github.com:ParsePlatform/ParseLiveQuery-Android.git","clone_url":"https://github.com/ParsePlatform/ParseLiveQuery-Android.git","svn_url":"https://github.com/ParsePlatform/ParseLiveQuery-Android","homepage":"","size":117,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/34"},"html":{"href":"https://github.com/ParsePlatform/ParseLiveQuery-Android/pull/34"},"issue":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/issues/34"},"comments":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-Android/statuses/89e3809d3c3ba8db5aa020e38abd2254b2d3d25b"}}}}
{"actor":{"display_login":"jhansche"}}