{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/2240","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/2240/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/2240/comments","events_url":"https://api.github.com/repos/istio/istio/issues/2240/events","html_url":"https://github.com/istio/istio/pull/2240","id":283066261,"number":2240,"title":"Switch to Istio logging","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"c2e0c6","default":false},{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false},{"id":737750176,"url":"https://api.github.com/repos/istio/istio/labels/pilot","name":"pilot","color":"c11783","default":false},{"id":660558399,"url":"https://api.github.com/repos/istio/istio/labels/release-note-none","name":"release-note-none","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"assignees":[{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2017-12-19T00:27:45Z","updated_at":"2017-12-21T20:43:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/2240","html_url":"https://github.com/istio/istio/pull/2240","diff_url":"https://github.com/istio/istio/pull/2240.diff","patch_url":"https://github.com/istio/istio/pull/2240.patch"},"body":"This completes the transition from the entire Istio code base over\r\nto the new Istio logging library (replacing glog).\r\n\r\nThe mapping is roughly as follows:\r\n\r\nglog.Debug -> log.Debug\r\nglog.Info -> log.Info\r\nglog.Warning -> log.Warn\r\nglog.Error -> log.Error\r\nglog.Fatal -> log.Error + os.Exit(-1)\r\nglog.V(1) -> log.Info\r\nglog.V(2) -> log.Info\r\nglog.V(3+) -> log.Debug\r\nglog.Flush -> log.Sync\r\n\r\nPartially addresses #2174\r\n\r\n```release-note\r\nNone\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/353453142","html_url":"https://github.com/istio/istio/pull/2240#issuecomment-353453142","issue_url":"https://api.github.com/repos/istio/istio/issues/2240","id":353453142,"user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"created_at":"2017-12-21T20:43:02Z","updated_at":"2017-12-21T20:43:02Z","author_association":"CONTRIBUTOR","body":"@geeknoid I'm actually already doing that (see `SupressGlogWarnings`, which I copied from Mixer).  Is it important as to when this code is executed? I wonder if I need to move things around a bit."}}
{"actor":{"display_login":"nmittler"}}