{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/105041570","pull_request_review_id":25903134,"id":105041570,"diff_hunk":"@@ -130,6 +147,31 @@ def apply_role_pre_chef_call(old_role, role, all_nodes)\n     end\n \n     @logger.debug(\"Keystone apply_role_pre_chef_call: leaving\")\n+    @logger.debug(\"**********************************************************\")\n+  end\n+\n+  def apply_role_post_chef_call(old_role, role, all_nodes)\n+    @logger.debug(\"**********************************************************\")\n+    @logger.debug(\"Keystone apply_role_post_chef_call: entering #{all_nodes.inspect}\")\n+\n+    server_elements, server_nodes, ha_enabled = role_expand_elements(role, \"keystone-server\")\n+    @logger.debug(\"server_nodes: #{server_nodes}\")\n+\n+    # Save current keystone endpoints to role.\n+    #node = Node::find_nodes_by_name(all_nodes.first).first.node.default_attrs\n+    node = Node::find_nodes_by_name(all_nodes.first).first.node\n+    attributes = role.override_attributes[\"keystone\"]\n+    attributes[\"endpoint\"] = {\n+      :insecure => node[:keystone][:ssl][:insecure],\n+      :protocol => node[:keystone][:api][:protocol],\n+      :internal_url_host => node[:keystone][:api][:internal_url_host],","path":"crowbar_framework/app/models/keystone_service.rb","position":48,"original_position":48,"commit_id":"c3b17d827b29f38c4547b158abc4e947b0db5b91","original_commit_id":"c3b17d827b29f38c4547b158abc4e947b0db5b91","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/HashSyntax: Use the new Ruby 1.9 hash syntax. (https://github.com/bbatsov/ruby-style-guide#hash-literals)","created_at":"2017-03-08T22:32:29Z","updated_at":"2017-03-08T22:32:29Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/859#discussion_r105041570","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/859","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/105041570"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/859#discussion_r105041570"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/859"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/859","id":108813808,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/859","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/859.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/859.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/859","number":859,"state":"open","locked":false,"title":"keystone: Update keystone endpoint (bsc#1004219)","user":{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars2.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},"body":"Currently the keystone endpoint is created during bootstrapping\r\nkeystone but can not be updated. This means that the keystone barclamp\r\ncan not be switched from http to https once it is already deployed\r\nbecause the endpoints are not updated.\r\n\r\nThis patch introduces a new keystone resource, `update_endpoint`, which\r\nupdates the endpoints of a service.","created_at":"2017-03-02T17:45:32Z","updated_at":"2017-03-08T22:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0322add9d3813c610eb193c3ddf56041fce6170","assignee":{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars2.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},"assignees":[{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars2.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/859/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/859/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/859/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/c3b17d827b29f38c4547b158abc4e947b0db5b91","head":{"label":"nicolasbock:keystone_ssl","ref":"keystone_ssl","sha":"c3b17d827b29f38c4547b158abc4e947b0db5b91","user":{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars2.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},"repo":{"id":56667869,"name":"crowbar-openstack","full_name":"nicolasbock/crowbar-openstack","owner":{"login":"nicolasbock","id":841385,"avatar_url":"https://avatars2.githubusercontent.com/u/841385?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasbock","html_url":"https://github.com/nicolasbock","followers_url":"https://api.github.com/users/nicolasbock/followers","following_url":"https://api.github.com/users/nicolasbock/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbock/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbock/subscriptions","organizations_url":"https://api.github.com/users/nicolasbock/orgs","repos_url":"https://api.github.com/users/nicolasbock/repos","events_url":"https://api.github.com/users/nicolasbock/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nicolasbock/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/nicolasbock/crowbar-openstack","forks_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/nicolasbock/crowbar-openstack/deployments","created_at":"2016-04-20T08:03:17Z","updated_at":"2016-12-27T04:26:05Z","pushed_at":"2017-03-08T22:32:12Z","git_url":"git://github.com/nicolasbock/crowbar-openstack.git","ssh_url":"git@github.com:nicolasbock/crowbar-openstack.git","clone_url":"https://github.com/nicolasbock/crowbar-openstack.git","svn_url":"https://github.com/nicolasbock/crowbar-openstack","homepage":null,"size":18381,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"187d3a625ecfd49b837d665dca480cdcde105154","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2017-01-21T12:07:09Z","pushed_at":"2017-03-08T22:32:13Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":18463,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":53,"forks":51,"open_issues":53,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/859"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/859"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/859"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/859/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/859/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/859/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/c3b17d827b29f38c4547b158abc4e947b0db5b91"}}}}
{"actor":{"display_login":"houndci-bot"}}