{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/109455793","pull_request_review_id":30558903,"id":109455793,"diff_hunk":"@@ -56,6 +56,11 @@ class SILOptions {\n   /// Controls how to perform SIL linking.\n   LinkingMode LinkMode = LinkNormal;\n \n+  /// Controls whether to pull in SIL from partial modules during the\n+  /// merge modules step. Could perhaps be merged with the link mode\n+  /// above but the interactions between all the flags are tricky.","path":"include/swift/AST/SILOptions.h","position":6,"original_position":6,"commit_id":"f731ea506836fa927e80dbd9f34edd27c296b960","original_commit_id":"f731ea506836fa927e80dbd9f34edd27c296b960","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars1.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"I think it's worth trying to merge them, in the spirit of \"not leaving work around to clean up later\". The settings are already not orthogonal.","created_at":"2017-04-03T16:00:41Z","updated_at":"2017-04-03T16:04:51Z","html_url":"https://github.com/apple/swift/pull/8388#discussion_r109455793","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/8388","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/109455793"},"html":{"href":"https://github.com/apple/swift/pull/8388#discussion_r109455793"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/8388"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/8388","id":112926083,"html_url":"https://github.com/apple/swift/pull/8388","diff_url":"https://github.com/apple/swift/pull/8388.diff","patch_url":"https://github.com/apple/swift/pull/8388.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/8388","number":8388,"state":"open","locked":false,"title":"Preserve SIL when merging modules","user":{"login":"slavapestov","id":66486,"avatar_url":"https://avatars2.githubusercontent.com/u/66486?v=3","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"body":"Fixes <rdar://problem/18913977>.\r\n\r\nNext steps in this area:\r\n- Emit default argument generators with shared linkage and serialized bit set in Swift 4 mode\r\n- Finish investigating emitting inlineable functions with shared linkage","created_at":"2017-03-28T09:31:10Z","updated_at":"2017-04-03T16:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d356a0b433ce73a68796350a8505278262253ab0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/8388/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/8388/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/8388/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/f731ea506836fa927e80dbd9f34edd27c296b960","head":{"label":"slavapestov:preserve-sil-when-merging-modules","ref":"preserve-sil-when-merging-modules","sha":"f731ea506836fa927e80dbd9f34edd27c296b960","user":{"login":"slavapestov","id":66486,"avatar_url":"https://avatars2.githubusercontent.com/u/66486?v=3","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"repo":{"id":50827146,"name":"swift","full_name":"slavapestov/swift","owner":{"login":"slavapestov","id":66486,"avatar_url":"https://avatars2.githubusercontent.com/u/66486?v=3","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slavapestov/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/slavapestov/swift","forks_url":"https://api.github.com/repos/slavapestov/swift/forks","keys_url":"https://api.github.com/repos/slavapestov/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slavapestov/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slavapestov/swift/teams","hooks_url":"https://api.github.com/repos/slavapestov/swift/hooks","issue_events_url":"https://api.github.com/repos/slavapestov/swift/issues/events{/number}","events_url":"https://api.github.com/repos/slavapestov/swift/events","assignees_url":"https://api.github.com/repos/slavapestov/swift/assignees{/user}","branches_url":"https://api.github.com/repos/slavapestov/swift/branches{/branch}","tags_url":"https://api.github.com/repos/slavapestov/swift/tags","blobs_url":"https://api.github.com/repos/slavapestov/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slavapestov/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slavapestov/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/slavapestov/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slavapestov/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/slavapestov/swift/languages","stargazers_url":"https://api.github.com/repos/slavapestov/swift/stargazers","contributors_url":"https://api.github.com/repos/slavapestov/swift/contributors","subscribers_url":"https://api.github.com/repos/slavapestov/swift/subscribers","subscription_url":"https://api.github.com/repos/slavapestov/swift/subscription","commits_url":"https://api.github.com/repos/slavapestov/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/slavapestov/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/slavapestov/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/slavapestov/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/slavapestov/swift/contents/{+path}","compare_url":"https://api.github.com/repos/slavapestov/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slavapestov/swift/merges","archive_url":"https://api.github.com/repos/slavapestov/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slavapestov/swift/downloads","issues_url":"https://api.github.com/repos/slavapestov/swift/issues{/number}","pulls_url":"https://api.github.com/repos/slavapestov/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/slavapestov/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/slavapestov/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slavapestov/swift/labels{/name}","releases_url":"https://api.github.com/repos/slavapestov/swift/releases{/id}","deployments_url":"https://api.github.com/repos/slavapestov/swift/deployments","created_at":"2016-02-01T08:58:18Z","updated_at":"2017-03-07T14:20:29Z","pushed_at":"2017-04-03T08:27:03Z","git_url":"git://github.com/slavapestov/swift.git","ssh_url":"git@github.com:slavapestov/swift.git","clone_url":"https://github.com/slavapestov/swift.git","svn_url":"https://github.com/slavapestov/swift","homepage":"https://swift.org/","size":177799,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"2a50cc02266dc1479a5db643ee37f770a151bdbc","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-04-03T15:46:37Z","pushed_at":"2017-04-03T14:12:54Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":181588,"stargazers_count":37716,"watchers_count":37716,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5580,"mirror_url":null,"open_issues_count":159,"forks":5580,"open_issues":159,"watchers":37716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/8388"},"html":{"href":"https://github.com/apple/swift/pull/8388"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/8388"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/8388/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/8388/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/8388/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/f731ea506836fa927e80dbd9f34edd27c296b960"}}}}
{"actor":{"display_login":"jrose-apple"}}