{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/5050","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/5050/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/5050/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/5050/events","html_url":"https://github.com/minetest/minetest/pull/5050","id":200947773,"number":5050,"title":"Limit per round MapBlockMeshes created in MeshUpdateThread","user":{"login":"lhofhansl","id":446130,"avatar_url":"https://avatars.githubusercontent.com/u/446130?v=3","gravatar_id":"","url":"https://api.github.com/users/lhofhansl","html_url":"https://github.com/lhofhansl","followers_url":"https://api.github.com/users/lhofhansl/followers","following_url":"https://api.github.com/users/lhofhansl/following{/other_user}","gists_url":"https://api.github.com/users/lhofhansl/gists{/gist_id}","starred_url":"https://api.github.com/users/lhofhansl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhofhansl/subscriptions","organizations_url":"https://api.github.com/users/lhofhansl/orgs","repos_url":"https://api.github.com/users/lhofhansl/repos","events_url":"https://api.github.com/users/lhofhansl/events{/privacy}","received_events_url":"https://api.github.com/users/lhofhansl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-01-16T07:28:22Z","updated_at":"2017-01-17T03:38:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/5050","html_url":"https://github.com/minetest/minetest/pull/5050","diff_url":"https://github.com/minetest/minetest/pull/5050.diff","patch_url":"https://github.com/minetest/minetest/pull/5050.patch"},"body":"This should be considered experimental. In order to reduce jitter when moving around with blocks loading, limit the number of MapBlockMeshes created per call MeshUpdateThread::doUpdate.\r\n\r\nWhere does the 40 come from. No idea, it tested well... Would be nice to derive a good default from the minetest settings. Perhaps this should be around the servers `max_simultaneous_block_sends_per_client` setting.\r\n\r\nI also observer that it is slightly more likely that block that are updated again are found towards the end of the incoming queue, so there's a slight improvement to have by looking from the end of the queue (std::vector).\r\n\r\nIf somebody could test whether this reduces jitter with their setup... @Fixer-007 hint, hint :) That'd be great."},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/273014626","html_url":"https://github.com/minetest/minetest/pull/5050#issuecomment-273014626","issue_url":"https://api.github.com/repos/minetest/minetest/issues/5050","id":273014626,"user":{"login":"lhofhansl","id":446130,"avatar_url":"https://avatars.githubusercontent.com/u/446130?v=3","gravatar_id":"","url":"https://api.github.com/users/lhofhansl","html_url":"https://github.com/lhofhansl","followers_url":"https://api.github.com/users/lhofhansl/followers","following_url":"https://api.github.com/users/lhofhansl/following{/other_user}","gists_url":"https://api.github.com/users/lhofhansl/gists{/gist_id}","starred_url":"https://api.github.com/users/lhofhansl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhofhansl/subscriptions","organizations_url":"https://api.github.com/users/lhofhansl/orgs","repos_url":"https://api.github.com/users/lhofhansl/repos","events_url":"https://api.github.com/users/lhofhansl/events{/privacy}","received_events_url":"https://api.github.com/users/lhofhansl/received_events","type":"User","site_admin":false},"created_at":"2017-01-17T03:38:34Z","updated_at":"2017-01-17T03:38:34Z","body":"MapBlockMesh::MapBlockMesh showed up top in the perf counters when the jitter happens, that pointed me this way."}}
{"actor":{"display_login":"lhofhansl"}}