{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/135402716","pull_request_review_id":58814210,"id":135402716,"diff_hunk":"@@ -96,7 +86,7 @@\n      * @return Set of interface names\n      */\n     public Set<String> getInterfaceNames() {\n-        Set<String> result = new HashSet<String>();","path":"addons/binding/org.openhab.binding.network/src/main/java/org/openhab/binding/network/internal/utils/NetworkUtils.java","position":75,"original_position":75,"commit_id":"e120386abda5cbddfab0f53b0351597120ff755c","original_commit_id":"e120386abda5cbddfab0f53b0351597120ff755c","user":{"login":"martinvw","id":2625279,"avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2017-08-27T04:53:32Z","updated_at":"2017-08-27T04:53:33Z","html_url":"https://github.com/openhab/openhab2-addons/pull/2580#discussion_r135402716","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2580","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/135402716"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2580#discussion_r135402716"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2580"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2580","id":136971883,"html_url":"https://github.com/openhab/openhab2-addons/pull/2580","diff_url":"https://github.com/openhab/openhab2-addons/pull/2580.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/2580.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2580","number":2580,"state":"open","locked":false,"title":"Network: Fix native ping on MacOS, Fix arping with second arping utility","user":{"login":"davidgraeff","id":66436,"avatar_url":"https://avatars2.githubusercontent.com/u/66436?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgraeff","html_url":"https://github.com/davidgraeff","followers_url":"https://api.github.com/users/davidgraeff/followers","following_url":"https://api.github.com/users/davidgraeff/following{/other_user}","gists_url":"https://api.github.com/users/davidgraeff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgraeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgraeff/subscriptions","organizations_url":"https://api.github.com/users/davidgraeff/orgs","repos_url":"https://api.github.com/users/davidgraeff/repos","events_url":"https://api.github.com/users/davidgraeff/events{/privacy}","received_events_url":"https://api.github.com/users/davidgraeff/received_events","type":"User","site_admin":false},"body":"Fixes #2579\r\nFixes #2577\r\nFixes #2581\r\nFixes #2578 \r\nFixes #2591\r\nFixes https://github.com/openhab/openhab-distro/issues/525\r\n\r\nDepends on https://github.com/eclipse/smarthome/pull/4109\r\n\r\nThis should be merged before the next OH release, otherwise it would introduce breaking changes.\r\n\r\n* Use OSGi DS\r\n* Remove NetworkHandlerBuilder\r\n* Add NetworkBindingConfiguration\r\n* Move not exported classes to \"internal\" package\r\n* Add support for Thomas Habets arping, which uses -W instead of -w for timeouts.\r\n* Show the user via a property which arping was recognised.\r\n* Readme: Add section about arping: Installation, Access permissions.\r\n* Limit the number of IPs to scan for discovery\r\n\r\n## Breaking change for snapshot users\r\n* The network binding configuration names have changed, because the guidelines suggest camelcase and forbid \"_\" names:\r\n  This only affects early-adaptors, because the binding configuration parameters were not part of a release so far.\r\n\r\nSigned-off-by: David Gräff <david.graeff@web.de>","created_at":"2017-08-22T12:52:23Z","updated_at":"2017-08-27T04:53:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba82b4f39c22c92dc33a55bf95917c285f0d7fa4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2580/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2580/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2580/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/e120386abda5cbddfab0f53b0351597120ff755c","head":{"label":"davidgraeff:fixnetwork","ref":"fixnetwork","sha":"e120386abda5cbddfab0f53b0351597120ff755c","user":{"login":"davidgraeff","id":66436,"avatar_url":"https://avatars2.githubusercontent.com/u/66436?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgraeff","html_url":"https://github.com/davidgraeff","followers_url":"https://api.github.com/users/davidgraeff/followers","following_url":"https://api.github.com/users/davidgraeff/following{/other_user}","gists_url":"https://api.github.com/users/davidgraeff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgraeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgraeff/subscriptions","organizations_url":"https://api.github.com/users/davidgraeff/orgs","repos_url":"https://api.github.com/users/davidgraeff/repos","events_url":"https://api.github.com/users/davidgraeff/events{/privacy}","received_events_url":"https://api.github.com/users/davidgraeff/received_events","type":"User","site_admin":false},"repo":{"id":61587957,"name":"openhab2-addons","full_name":"davidgraeff/openhab2-addons","owner":{"login":"davidgraeff","id":66436,"avatar_url":"https://avatars2.githubusercontent.com/u/66436?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgraeff","html_url":"https://github.com/davidgraeff","followers_url":"https://api.github.com/users/davidgraeff/followers","following_url":"https://api.github.com/users/davidgraeff/following{/other_user}","gists_url":"https://api.github.com/users/davidgraeff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgraeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgraeff/subscriptions","organizations_url":"https://api.github.com/users/davidgraeff/orgs","repos_url":"https://api.github.com/users/davidgraeff/repos","events_url":"https://api.github.com/users/davidgraeff/events{/privacy}","received_events_url":"https://api.github.com/users/davidgraeff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidgraeff/openhab2-addons","description":"The next-generation open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/davidgraeff/openhab2-addons","forks_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/forks","keys_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/events","assignees_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/merges","archive_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/davidgraeff/openhab2-addons/deployments","created_at":"2016-06-20T23:44:51Z","updated_at":"2017-08-17T08:33:18Z","pushed_at":"2017-08-26T19:37:18Z","git_url":"git://github.com/davidgraeff/openhab2-addons.git","ssh_url":"git@github.com:davidgraeff/openhab2-addons.git","clone_url":"https://github.com/davidgraeff/openhab2-addons.git","svn_url":"https://github.com/davidgraeff/openhab2-addons","homepage":null,"size":85020,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"e10a971b82998065df6d02d768ce358842654a87","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"name":"openhab2-addons","full_name":"openhab/openhab2-addons","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2017-08-26T17:30:40Z","pushed_at":"2017-08-26T21:20:34Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":258706,"stargazers_count":635,"watchers_count":635,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1099,"mirror_url":null,"open_issues_count":326,"forks":1099,"open_issues":326,"watchers":635,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2580"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2580"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2580"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2580/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2580/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2580/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/e120386abda5cbddfab0f53b0351597120ff755c"}}}}
{"actor":{"display_login":"martinvw"}}