{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/110549087","pull_request_review_id":31730952,"id":110549087,"diff_hunk":"@@ -173,6 +170,7 @@ Status DBImpl::WriteImpl(const WriteOptions& write_options,\n       }\n     }\n \n+    uint64_t last_sequence = versions_->LastSequence();","path":"db/db_impl_write.cc","position":41,"original_position":41,"commit_id":"deefb712cbf428645ee0ef875b4d365829928dfd","original_commit_id":"deefb712cbf428645ee0ef875b4d365829928dfd","user":{"login":"yiwu-arbug","id":2606959,"avatar_url":"https://avatars0.githubusercontent.com/u/2606959?v=3","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false},"body":"Is all the tests pass after this change? (Don't know how to read the phabricator result after the fbcode migjration..)","created_at":"2017-04-09T18:10:27Z","updated_at":"2017-04-09T18:43:36Z","html_url":"https://github.com/facebook/rocksdb/pull/2115#discussion_r110549087","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/2115","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/110549087"},"html":{"href":"https://github.com/facebook/rocksdb/pull/2115#discussion_r110549087"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2115"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/2115","id":114919527,"html_url":"https://github.com/facebook/rocksdb/pull/2115","diff_url":"https://github.com/facebook/rocksdb/pull/2115.diff","patch_url":"https://github.com/facebook/rocksdb/pull/2115.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/2115","number":2115,"state":"open","locked":false,"title":"Adding comments to the write path","user":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars1.githubusercontent.com/u/1167741?v=3","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"body":"also did minor refactoring","created_at":"2017-04-07T23:41:41Z","updated_at":"2017-04-09T18:43:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3b3317f8ac9345e1f5df9608c54cfdfddf3eb08","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/2115/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/2115/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/2115/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/deefb712cbf428645ee0ef875b4d365829928dfd","head":{"label":"maysamyabandeh:doc-write-path","ref":"doc-write-path","sha":"deefb712cbf428645ee0ef875b4d365829928dfd","user":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars1.githubusercontent.com/u/1167741?v=3","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"repo":{"id":73221890,"name":"rocksdb","full_name":"maysamyabandeh/rocksdb","owner":{"login":"maysamyabandeh","id":1167741,"avatar_url":"https://avatars1.githubusercontent.com/u/1167741?v=3","gravatar_id":"","url":"https://api.github.com/users/maysamyabandeh","html_url":"https://github.com/maysamyabandeh","followers_url":"https://api.github.com/users/maysamyabandeh/followers","following_url":"https://api.github.com/users/maysamyabandeh/following{/other_user}","gists_url":"https://api.github.com/users/maysamyabandeh/gists{/gist_id}","starred_url":"https://api.github.com/users/maysamyabandeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maysamyabandeh/subscriptions","organizations_url":"https://api.github.com/users/maysamyabandeh/orgs","repos_url":"https://api.github.com/users/maysamyabandeh/repos","events_url":"https://api.github.com/users/maysamyabandeh/events{/privacy}","received_events_url":"https://api.github.com/users/maysamyabandeh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maysamyabandeh/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/maysamyabandeh/rocksdb","forks_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/forks","keys_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/teams","hooks_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/events","assignees_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/tags","blobs_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/languages","stargazers_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/subscription","commits_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/merges","archive_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/downloads","issues_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/maysamyabandeh/rocksdb/deployments","created_at":"2016-11-08T19:56:13Z","updated_at":"2016-11-08T19:56:19Z","pushed_at":"2017-04-09T05:58:02Z","git_url":"git://github.com/maysamyabandeh/rocksdb.git","ssh_url":"git@github.com:maysamyabandeh/rocksdb.git","clone_url":"https://github.com/maysamyabandeh/rocksdb.git","svn_url":"https://github.com/maysamyabandeh/rocksdb","homepage":"http://rocksdb.org","size":100286,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"360e9960f8fdbd65e8299230941528a06a2d842c","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars0.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2017-04-09T17:03:04Z","pushed_at":"2017-04-09T18:26:52Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":100507,"stargazers_count":7389,"watchers_count":7389,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1573,"mirror_url":null,"open_issues_count":403,"forks":1573,"open_issues":403,"watchers":7389,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2115"},"html":{"href":"https://github.com/facebook/rocksdb/pull/2115"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/2115"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/2115/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2115/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/2115/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/deefb712cbf428645ee0ef875b4d365829928dfd"}}}}
{"actor":{"display_login":"yiwu-arbug"}}