{"push_id":2014020279,"size":8,"distinct_size":3,"ref":"refs/heads/jro-prevent-infinite-page-looping","head":"601201fe22f09a3367409af83a5d1d5c91b1ec53","before":"5438a1eb02c7715773230f15c46c5474fd9a584b","commits":[{"sha":"336316f94ec79a0ae0e202803a894dfa52cbad00","author":{"name":"Jessie A. Young","email":"4b455d87763ab10480d3f7a3044eefca69ede5ab@users.noreply.github.com"},"message":"Add default response for Child support question (#279)\n\n**WHY**: I didn't catch this before because MI Bridges only shows this\r\nquestion if there is someone under 18 in the household.\r\n\r\nThe tricky thing about this is that we know if *anyone* receives child\r\nsupport income in a household, but MI Bridges wants to know which child.\r\n\r\nAfter you select a name, it follows up with a queston about the amount\r\nof child support income for each name selected.i\r\n\r\nOptions are:\r\n- always say \"no one\" (easiest)\r\n- always select first child (second easiest)\r\n- collect more granular child support data in MI Benefits so we can fill\r\nthis out accurately (hardest)\r\n\r\nIn order to know which is best, it would be good to get context on the\r\nimportance of this question for the county workers.","distinct":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits/336316f94ec79a0ae0e202803a894dfa52cbad00"},{"sha":"2fd7b7252f3558ae98d8fa1a280fac6b7fd701e6","author":{"name":"Jessie A. Young","email":"4b455d87763ab10480d3f7a3044eefca69ede5ab@users.noreply.github.com"},"message":"Absent parent pages (#286)\n\n* We are filling in the minimal info possible, which means only filling\r\nin required fields. This means that we have the following data for all\r\nminors who are not living with both parents:\r\n  1. Indicating that the mother (if absent) was single - never married when pregnant\r\n  2. Indicating name unknown for all absent parents, which means we do not\r\n     need to include the required first and last name for absent parents.","distinct":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits/2fd7b7252f3558ae98d8fa1a280fac6b7fd701e6"},{"sha":"c8b8d7b9e13fb9e21fc76a84cd66a6d1a7882c6d","author":{"name":"Jessie A. Young","email":"4b455d87763ab10480d3f7a3044eefca69ede5ab@users.noreply.github.com"},"message":"Validate employer name for employed members (#282)\n\n**WHY**: This is a required field in MI Bridges, so we need to collect\r\nthe info in order to drive applications successfully.","distinct":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits/c8b8d7b9e13fb9e21fc76a84cd66a6d1a7882c6d"},{"sha":"9b34cb5248224f02bdd5e6db16157df4411f6d95","author":{"name":"Joel Oliveira","email":"b2682d0be4b1ad1b2d0ed411571a375da9a8db5d@gmail.com"},"message":"Add \"More About <client>'s Checking Account\" page\n\nSince we don't specifically ask how much is in individual accounts, this\npage will continue with an \"I don't know\" answer.","distinct":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits/9b34cb5248224f02bdd5e6db16157df4411f6d95"},{"sha":"3d53ccdbba3a222b06157db82a530520368b3b56","author":{"name":"Joel Oliveira","email":"b2682d0be4b1ad1b2d0ed411571a375da9a8db5d@gmail.com"},"message":"Real estate and vehicle information pages.\n\nThe real estate and vehicle information pages are tricky in that we\ndon't ask for more information about *what* type of vehicle or\nhouse/home/domicile the client owns. We just know they have one or do\nnot. As a result we'll be as generic as we can and continue on with the\ndriving process.\n\nAlso move \"JobIncomeMoreAboutPage\" to \"MoreAboutJobIncomePage\" so that\nit adheres to our \"MorAbout*\" naming convention.","distinct":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits/3d53ccdbba3a222b06157db82a530520368b3b56"},{"sha":"5ea12c5ac7246e5f7aa00d0df76b01562401f335","author":{"name":"Joel Oliveira","email":"b2682d0be4b1ad1b2d0ed411571a375da9a8db5d@gmail.com"},"message":"Prevent infinite looping over the same page\n\nOccasionally, some pages will be submitted and redirect back to\nthemselves, which will be filled in the same way, and result in an\ninfinite loop of:\n\n1. Detect\n2. Submit\n3. Fail\n4. Re-render same page\n5. GOTO 1\n\nThis commit will keep a count of number of times a particular child\nclass page object is instantiated, and will raise an exception with that\nclass's name so that we can tell _which_ page is getting looped over.","distinct":true,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits/5ea12c5ac7246e5f7aa00d0df76b01562401f335"},{"sha":"d1312ae5f2e326d442784c61b79a7c20fd4b785f","author":{"name":"Joel Oliveira","email":"b2682d0be4b1ad1b2d0ed411571a375da9a8db5d@gmail.com"},"message":"Assign instantiation limit to a constant\n\nUpdate specs to refer to the limit +1","distinct":true,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits/d1312ae5f2e326d442784c61b79a7c20fd4b785f"},{"sha":"601201fe22f09a3367409af83a5d1d5c91b1ec53","author":{"name":"Joel Oliveira","email":"b2682d0be4b1ad1b2d0ed411571a375da9a8db5d@gmail.com"},"message":"Allow skipping instance limitation for some pages\n\n[According to Jessie] there are instances (pun intended) where some page\nobjects are created more than the number of times we're limiting. As a\nresult we should allow these page objects to opt out of the instance\ncheck.\n\nThis commit adds that ability by defining a class method for the page\nobjects we expect could run into these situations - `.skip_instance_limitation`.\n\n[According to Jessie]: https://github.com/codeforamerica/michigan-benefits/pull/287#discussion_r141438656\n\nAlso - refactor related initializer contents to be a little easier to read.","distinct":true,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits/601201fe22f09a3367409af83a5d1d5c91b1ec53"}]}
{"actor":{"display_login":"jayroh"}}