{"action":"created","issue":{"url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/1538","repository_url":"https://api.github.com/repos/sonyxperiadev/kernel","labels_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/1538/labels{/name}","comments_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/1538/comments","events_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/1538/events","html_url":"https://github.com/sonyxperiadev/kernel/pull/1538","id":284951664,"number":1538,"title":"re-enable ARMV8_DEPRECATED and SWP_EMULATION","user":{"login":"DevriesL","id":10823329,"avatar_url":"https://avatars1.githubusercontent.com/u/10823329?v=4","gravatar_id":"","url":"https://api.github.com/users/DevriesL","html_url":"https://github.com/DevriesL","followers_url":"https://api.github.com/users/DevriesL/followers","following_url":"https://api.github.com/users/DevriesL/following{/other_user}","gists_url":"https://api.github.com/users/DevriesL/gists{/gist_id}","starred_url":"https://api.github.com/users/DevriesL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevriesL/subscriptions","organizations_url":"https://api.github.com/users/DevriesL/orgs","repos_url":"https://api.github.com/users/DevriesL/repos","events_url":"https://api.github.com/users/DevriesL/events{/privacy}","received_events_url":"https://api.github.com/users/DevriesL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-12-28T16:52:25Z","updated_at":"2017-12-31T04:01:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sonyxperiadev/kernel/pulls/1538","html_url":"https://github.com/sonyxperiadev/kernel/pull/1538","diff_url":"https://github.com/sonyxperiadev/kernel/pull/1538.diff","patch_url":"https://github.com/sonyxperiadev/kernel/pull/1538.patch"},"body":"Since many applications use boost c++ library such as WeChat, in the boost library, the try_lock() function calls 'swp', if we disable SWP_EMULATION, that will cause application crash, for about boost library in WeChat, please refer to:\r\nhttps://github.com/Tencent/mars/blob/master/mars/boost/smart_ptr/detail/spinlock_gcc_arm.hpp#L62\r\n\r\nBTW: this Tencent's opensource module 'mars' not only used in the WeChat, but also used by many applications in China, so we really need swp. Here is the WeChat crash log:\r\n********** Crash dump: **********\r\nBuild fingerprint: Sony/maple/maple:8.0.0/OPR3.170623.013/devrie12222235:userdebug/test-keys\r\npid: 23687, tid: 23687(main thread)  >>> com.tencent.mm <<<\r\nsignal 4 (SIGILL), code 1 (ILL_ILLOPC), fault addr cf7d5388\r\n???): Routine mars_boost::detail::spinlock::try_lock() at /mars/mars/log/../boost/smart_ptr/detail/spinlock_gcc_arm.hpp:66\r\n(???): Routine mars_boost::shared_ptr<mars_boost::filesystem::detail::dir_itr_imp>::~shared_ptr() at /mars/mars/comm/../boost/smart_ptr/shared_ptr.hpp:336\r\n(???): Routine mars_boost::filesystem::detail::directory_iterator_increment(mars_boost::filesystem::directory_iterator&, mars_boost::system::error_code*) at /mars/mars/comm/jni/../../boost/libs/filesystem/src/operations.cpp:2327\r\n(???): Routine mars_boost::filesystem::directory_iterator::increment(mars_boost::system::error_code&) at /mars/mars/comm/../boost/filesystem/operations.hpp:914\r\n???): Routine mars_boost::filesystem::directory_iterator::directory_iterator(mars_boost::filesystem::path const&) at /mars/mars/log/../boost/filesystem/operations.hpp:904\r\n(appender_open_with_cache(TAppenderMode, std::string const&, std::string const&, char const*, char const*)+216): Routine appender_open_with_cache(TAppenderMode, std::string const&, std::string const&, char const*, char const*) at /mars/mars/log/jni/../src/appender.cc:895\r\nJava_com_tencent_mars_xlog_Xlog_appenderOpen+424): Routine Java_com_tencent_mars_xlog_Xlog_appenderOpen at /mars/mars/log/jni/../jni/Java2C_Xlog.cc:52 (discriminator 7)\r\nc+4293984499)"},"comment":{"url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/comments/354583995","html_url":"https://github.com/sonyxperiadev/kernel/pull/1538#issuecomment-354583995","issue_url":"https://api.github.com/repos/sonyxperiadev/kernel/issues/1538","id":354583995,"user":{"login":"DevriesL","id":10823329,"avatar_url":"https://avatars1.githubusercontent.com/u/10823329?v=4","gravatar_id":"","url":"https://api.github.com/users/DevriesL","html_url":"https://github.com/DevriesL","followers_url":"https://api.github.com/users/DevriesL/followers","following_url":"https://api.github.com/users/DevriesL/following{/other_user}","gists_url":"https://api.github.com/users/DevriesL/gists{/gist_id}","starred_url":"https://api.github.com/users/DevriesL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevriesL/subscriptions","organizations_url":"https://api.github.com/users/DevriesL/orgs","repos_url":"https://api.github.com/users/DevriesL/repos","events_url":"https://api.github.com/users/DevriesL/events{/privacy}","received_events_url":"https://api.github.com/users/DevriesL/received_events","type":"User","site_admin":false},"created_at":"2017-12-31T04:01:03Z","updated_at":"2017-12-31T04:01:03Z","author_association":"NONE","body":"Hi @jerpelea updated, please review 😄 "}}
{"actor":{"display_login":"DevriesL"}}