{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/139101347","pull_request_review_id":62988437,"id":139101347,"diff_hunk":"@@ -174,15 +180,25 @@ func (rh *runHook) afterHook(state State) (bool, error) {\n \t\tlogger.Debugf(\"unit %v has started but has not yet set status\", ctx.UnitName())\n \t\t// We've finished the start hook and the charm has not updated its\n \t\t// own status so we'll set it to unknown.\n-\t\terr = rh.runner.Context().SetUnitStatus(jujuc.StatusInfo{\n+\t\terr = ctx.SetUnitStatus(jujuc.StatusInfo{\n \t\t\tStatus: string(status.Unknown),\n \t\t})\n+\tcase hooks.RelationBroken:\n+\t\tvar isLeader bool\n+\t\tisLeader, err = ctx.IsLeader()","path":"worker/uniter/operation/runhook.go","position":41,"original_position":41,"commit_id":"37156e42a2bfb1846edbc3bb4a0f3fd142414e9d","original_commit_id":"37156e42a2bfb1846edbc3bb4a0f3fd142414e9d","user":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars3.githubusercontent.com/u/5808968?v=4","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-09-15T09:20:54Z","updated_at":"2017-09-15T09:20:54Z","html_url":"https://github.com/juju/juju/pull/7857#discussion_r139101347","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/7857","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/139101347"},"html":{"href":"https://github.com/juju/juju/pull/7857#discussion_r139101347"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/7857"}},"in_reply_to_id":139091628},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/7857","id":141208644,"html_url":"https://github.com/juju/juju/pull/7857","diff_url":"https://github.com/juju/juju/pull/7857.diff","patch_url":"https://github.com/juju/juju/pull/7857.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/7857","number":7857,"state":"open","locked":false,"title":"Uniter reacts to relation suspended flag; new suspending/joining states","user":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars3.githubusercontent.com/u/5808968?v=4","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"body":"## Description of change\r\n\r\nThe uniter now listens to the relation suspended flag to determine if a relation needs to be suspended, rather than status itself. Two new status values are introduced - \"joining\" and \"suspending\". When the CLI updates a relation status flag, the status changes to one of the above values; when the uniter has processed the change, it then sets \"suspended\" or \"joined\" accordingly. A relation status also starts out as \"joining\" until the uniter first runs the necessary hooks.\r\n\r\n## QA steps\r\n\r\nBootstrap a CMR scenario, mediawiki related to mysql in another model.\r\nwatch juju status on the mediawiki model\r\nin the mysql model:\r\nsuspend the remote relation\r\nobserve the status change in the watch status to suspending and then suspended, relation becomes broken\r\nresume the remote relation\r\nobserve the status change in the watch status to joining and then joined, relation becomes ok again\r\nfor both the above, listing offers in mysql model reflects the correct status\r\n","created_at":"2017-09-15T01:02:19Z","updated_at":"2017-09-15T09:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80513332a4332244a398031ffa184eab07d30780","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/7857/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/7857/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/7857/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/37156e42a2bfb1846edbc3bb4a0f3fd142414e9d","head":{"label":"wallyworld:relation-suspend-resume","ref":"relation-suspend-resume","sha":"37156e42a2bfb1846edbc3bb4a0f3fd142414e9d","user":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars3.githubusercontent.com/u/5808968?v=4","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"repo":{"id":20465218,"name":"juju","full_name":"wallyworld/juju","owner":{"login":"wallyworld","id":5808968,"avatar_url":"https://avatars3.githubusercontent.com/u/5808968?v=4","gravatar_id":"","url":"https://api.github.com/users/wallyworld","html_url":"https://github.com/wallyworld","followers_url":"https://api.github.com/users/wallyworld/followers","following_url":"https://api.github.com/users/wallyworld/following{/other_user}","gists_url":"https://api.github.com/users/wallyworld/gists{/gist_id}","starred_url":"https://api.github.com/users/wallyworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wallyworld/subscriptions","organizations_url":"https://api.github.com/users/wallyworld/orgs","repos_url":"https://api.github.com/users/wallyworld/repos","events_url":"https://api.github.com/users/wallyworld/events{/privacy}","received_events_url":"https://api.github.com/users/wallyworld/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wallyworld/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/wallyworld/juju","forks_url":"https://api.github.com/repos/wallyworld/juju/forks","keys_url":"https://api.github.com/repos/wallyworld/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wallyworld/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wallyworld/juju/teams","hooks_url":"https://api.github.com/repos/wallyworld/juju/hooks","issue_events_url":"https://api.github.com/repos/wallyworld/juju/issues/events{/number}","events_url":"https://api.github.com/repos/wallyworld/juju/events","assignees_url":"https://api.github.com/repos/wallyworld/juju/assignees{/user}","branches_url":"https://api.github.com/repos/wallyworld/juju/branches{/branch}","tags_url":"https://api.github.com/repos/wallyworld/juju/tags","blobs_url":"https://api.github.com/repos/wallyworld/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wallyworld/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wallyworld/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/wallyworld/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wallyworld/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/wallyworld/juju/languages","stargazers_url":"https://api.github.com/repos/wallyworld/juju/stargazers","contributors_url":"https://api.github.com/repos/wallyworld/juju/contributors","subscribers_url":"https://api.github.com/repos/wallyworld/juju/subscribers","subscription_url":"https://api.github.com/repos/wallyworld/juju/subscription","commits_url":"https://api.github.com/repos/wallyworld/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/wallyworld/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/wallyworld/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/wallyworld/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/wallyworld/juju/contents/{+path}","compare_url":"https://api.github.com/repos/wallyworld/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wallyworld/juju/merges","archive_url":"https://api.github.com/repos/wallyworld/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wallyworld/juju/downloads","issues_url":"https://api.github.com/repos/wallyworld/juju/issues{/number}","pulls_url":"https://api.github.com/repos/wallyworld/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/wallyworld/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/wallyworld/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wallyworld/juju/labels{/name}","releases_url":"https://api.github.com/repos/wallyworld/juju/releases{/id}","deployments_url":"https://api.github.com/repos/wallyworld/juju/deployments","created_at":"2014-06-04T00:56:12Z","updated_at":"2016-01-11T16:57:01Z","pushed_at":"2017-09-15T09:20:53Z","git_url":"git://github.com/wallyworld/juju.git","ssh_url":"git@github.com:wallyworld/juju.git","clone_url":"https://github.com/wallyworld/juju.git","svn_url":"https://github.com/wallyworld/juju","homepage":null,"size":201131,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:develop","ref":"develop","sha":"763d8e64fbf10d74bfb66384b9d3ae5987275a6a","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2017-09-15T07:01:10Z","pushed_at":"2017-09-15T08:26:25Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":201215,"stargazers_count":1017,"watchers_count":1017,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"open_issues_count":15,"forks":229,"open_issues":15,"watchers":1017,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/7857"},"html":{"href":"https://github.com/juju/juju/pull/7857"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/7857"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/7857/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/7857/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/7857/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/37156e42a2bfb1846edbc3bb4a0f3fd142414e9d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"wallyworld"}}