{"action":"created","comment":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/150385365","pull_request_review_id":75933748,"id":150385365,"diff_hunk":"@@ -1,76 +1,95 @@\n+import _ from 'underscore';\n+import Backbone from 'backbone';\n+import Marionette from '../../src/backbone.marionette';","path":"test/unit/on-dom-remove.spec.js","position":3,"original_position":3,"commit_id":"b4ed1b750334d1b9c75ecaf3419dd8ed542cb635","original_commit_id":"b4ed1b750334d1b9c75ecaf3419dd8ed542cb635","user":{"login":"paulfalgout","id":2028470,"avatar_url":"https://avatars2.githubusercontent.com/u/2028470?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfalgout","html_url":"https://github.com/paulfalgout","followers_url":"https://api.github.com/users/paulfalgout/followers","following_url":"https://api.github.com/users/paulfalgout/following{/other_user}","gists_url":"https://api.github.com/users/paulfalgout/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfalgout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfalgout/subscriptions","organizations_url":"https://api.github.com/users/paulfalgout/orgs","repos_url":"https://api.github.com/users/paulfalgout/repos","events_url":"https://api.github.com/users/paulfalgout/events{/privacy}","received_events_url":"https://api.github.com/users/paulfalgout/received_events","type":"User","site_admin":false},"body":"Same here","created_at":"2017-11-11T14:58:09Z","updated_at":"2017-11-11T14:58:10Z","html_url":"https://github.com/marionettejs/backbone.marionette/pull/3533#discussion_r150385365","pull_request_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3533","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments/150385365"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/3533#discussion_r150385365"},"pull_request":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3533"}}},"pull_request":{"url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3533","id":151724182,"html_url":"https://github.com/marionettejs/backbone.marionette/pull/3533","diff_url":"https://github.com/marionettejs/backbone.marionette/pull/3533.diff","patch_url":"https://github.com/marionettejs/backbone.marionette/pull/3533.patch","issue_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/3533","number":3533,"state":"open","locked":false,"title":"Tests/onAttach, onDomRefresh, onDomRemove, and precompiled template","user":{"login":"wesmangum","id":5713417,"avatar_url":"https://avatars2.githubusercontent.com/u/5713417?v=4","gravatar_id":"","url":"https://api.github.com/users/wesmangum","html_url":"https://github.com/wesmangum","followers_url":"https://api.github.com/users/wesmangum/followers","following_url":"https://api.github.com/users/wesmangum/following{/other_user}","gists_url":"https://api.github.com/users/wesmangum/gists{/gist_id}","starred_url":"https://api.github.com/users/wesmangum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesmangum/subscriptions","organizations_url":"https://api.github.com/users/wesmangum/orgs","repos_url":"https://api.github.com/users/wesmangum/repos","events_url":"https://api.github.com/users/wesmangum/events{/privacy}","received_events_url":"https://api.github.com/users/wesmangum/received_events","type":"User","site_admin":false},"body":"### Proposed changes\r\n- Reorganize tests to match order of codebase\r\n- Import dependencies to move away from using global ones\r\n- Use let in favor of this in beforeEach\r\n\r\nLink to the issue: #3248\r\n\r\nThis pr is a small part of the work to refactor the whole unit tests directory. Merging this issue should keep #3248 open","created_at":"2017-11-09T18:11:14Z","updated_at":"2017-11-11T14:58:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00b510fbe472b81dfc0e1096759d8034d8a45635","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3533/commits","review_comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3533/comments","review_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments{/number}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/3533/comments","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/b4ed1b750334d1b9c75ecaf3419dd8ed542cb635","head":{"label":"wesmangum:tests/onAttach-onDomRefresh-onDomRemove-templateRenderer","ref":"tests/onAttach-onDomRefresh-onDomRemove-templateRenderer","sha":"b4ed1b750334d1b9c75ecaf3419dd8ed542cb635","user":{"login":"wesmangum","id":5713417,"avatar_url":"https://avatars2.githubusercontent.com/u/5713417?v=4","gravatar_id":"","url":"https://api.github.com/users/wesmangum","html_url":"https://github.com/wesmangum","followers_url":"https://api.github.com/users/wesmangum/followers","following_url":"https://api.github.com/users/wesmangum/following{/other_user}","gists_url":"https://api.github.com/users/wesmangum/gists{/gist_id}","starred_url":"https://api.github.com/users/wesmangum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesmangum/subscriptions","organizations_url":"https://api.github.com/users/wesmangum/orgs","repos_url":"https://api.github.com/users/wesmangum/repos","events_url":"https://api.github.com/users/wesmangum/events{/privacy}","received_events_url":"https://api.github.com/users/wesmangum/received_events","type":"User","site_admin":false},"repo":{"id":60553529,"name":"backbone.marionette","full_name":"wesmangum/backbone.marionette","owner":{"login":"wesmangum","id":5713417,"avatar_url":"https://avatars2.githubusercontent.com/u/5713417?v=4","gravatar_id":"","url":"https://api.github.com/users/wesmangum","html_url":"https://github.com/wesmangum","followers_url":"https://api.github.com/users/wesmangum/followers","following_url":"https://api.github.com/users/wesmangum/following{/other_user}","gists_url":"https://api.github.com/users/wesmangum/gists{/gist_id}","starred_url":"https://api.github.com/users/wesmangum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesmangum/subscriptions","organizations_url":"https://api.github.com/users/wesmangum/orgs","repos_url":"https://api.github.com/users/wesmangum/repos","events_url":"https://api.github.com/users/wesmangum/events{/privacy}","received_events_url":"https://api.github.com/users/wesmangum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wesmangum/backbone.marionette","description":"The Backbone Framework","fork":true,"url":"https://api.github.com/repos/wesmangum/backbone.marionette","forks_url":"https://api.github.com/repos/wesmangum/backbone.marionette/forks","keys_url":"https://api.github.com/repos/wesmangum/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wesmangum/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wesmangum/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/wesmangum/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/wesmangum/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/wesmangum/backbone.marionette/events","assignees_url":"https://api.github.com/repos/wesmangum/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/wesmangum/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/wesmangum/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/wesmangum/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wesmangum/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wesmangum/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/wesmangum/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wesmangum/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/wesmangum/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/wesmangum/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/wesmangum/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/wesmangum/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/wesmangum/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/wesmangum/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/wesmangum/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/wesmangum/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/wesmangum/backbone.marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/wesmangum/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/wesmangum/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wesmangum/backbone.marionette/merges","archive_url":"https://api.github.com/repos/wesmangum/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wesmangum/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/wesmangum/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/wesmangum/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/wesmangum/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/wesmangum/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wesmangum/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/wesmangum/backbone.marionette/releases{/id}","deployments_url":"https://api.github.com/repos/wesmangum/backbone.marionette/deployments","created_at":"2016-06-06T19:04:22Z","updated_at":"2016-06-06T19:04:24Z","pushed_at":"2017-11-10T18:59:26Z","git_url":"git://github.com/wesmangum/backbone.marionette.git","ssh_url":"git@github.com:wesmangum/backbone.marionette.git","clone_url":"https://github.com/wesmangum/backbone.marionette.git","svn_url":"https://github.com/wesmangum/backbone.marionette","homepage":"http://marionettejs.com","size":11999,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"marionettejs:next","ref":"next","sha":"91ab7ea72cf710fe13bfdb290b2fe9130caad3ae","user":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars1.githubusercontent.com/u/2273169?v=4","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"repo":{"id":2965621,"name":"backbone.marionette","full_name":"marionettejs/backbone.marionette","owner":{"login":"marionettejs","id":2273169,"avatar_url":"https://avatars1.githubusercontent.com/u/2273169?v=4","gravatar_id":"","url":"https://api.github.com/users/marionettejs","html_url":"https://github.com/marionettejs","followers_url":"https://api.github.com/users/marionettejs/followers","following_url":"https://api.github.com/users/marionettejs/following{/other_user}","gists_url":"https://api.github.com/users/marionettejs/gists{/gist_id}","starred_url":"https://api.github.com/users/marionettejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marionettejs/subscriptions","organizations_url":"https://api.github.com/users/marionettejs/orgs","repos_url":"https://api.github.com/users/marionettejs/repos","events_url":"https://api.github.com/users/marionettejs/events{/privacy}","received_events_url":"https://api.github.com/users/marionettejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/marionettejs/backbone.marionette","description":"The Backbone Framework","fork":false,"url":"https://api.github.com/repos/marionettejs/backbone.marionette","forks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/forks","keys_url":"https://api.github.com/repos/marionettejs/backbone.marionette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marionettejs/backbone.marionette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marionettejs/backbone.marionette/teams","hooks_url":"https://api.github.com/repos/marionettejs/backbone.marionette/hooks","issue_events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/events{/number}","events_url":"https://api.github.com/repos/marionettejs/backbone.marionette/events","assignees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/assignees{/user}","branches_url":"https://api.github.com/repos/marionettejs/backbone.marionette/branches{/branch}","tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/tags","blobs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/refs{/sha}","trees_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/{sha}","languages_url":"https://api.github.com/repos/marionettejs/backbone.marionette/languages","stargazers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/stargazers","contributors_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contributors","subscribers_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscribers","subscription_url":"https://api.github.com/repos/marionettejs/backbone.marionette/subscription","commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/commits{/sha}","git_commits_url":"https://api.github.com/repos/marionettejs/backbone.marionette/git/commits{/sha}","comments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/comments{/number}","issue_comment_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/comments{/number}","contents_url":"https://api.github.com/repos/marionettejs/backbone.marionette/contents/{+path}","compare_url":"https://api.github.com/repos/marionettejs/backbone.marionette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marionettejs/backbone.marionette/merges","archive_url":"https://api.github.com/repos/marionettejs/backbone.marionette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marionettejs/backbone.marionette/downloads","issues_url":"https://api.github.com/repos/marionettejs/backbone.marionette/issues{/number}","pulls_url":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls{/number}","milestones_url":"https://api.github.com/repos/marionettejs/backbone.marionette/milestones{/number}","notifications_url":"https://api.github.com/repos/marionettejs/backbone.marionette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marionettejs/backbone.marionette/labels{/name}","releases_url":"https://api.github.com/repos/marionettejs/backbone.marionette/releases{/id}","deployments_url":"https://api.github.com/repos/marionettejs/backbone.marionette/deployments","created_at":"2011-12-12T16:36:09Z","updated_at":"2017-11-10T06:24:01Z","pushed_at":"2017-11-10T18:59:27Z","git_url":"git://github.com/marionettejs/backbone.marionette.git","ssh_url":"git@github.com:marionettejs/backbone.marionette.git","clone_url":"https://github.com/marionettejs/backbone.marionette.git","svn_url":"https://github.com/marionettejs/backbone.marionette","homepage":"http://marionettejs.com","size":11686,"stargazers_count":7169,"watchers_count":7169,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1363,"mirror_url":null,"archived":false,"open_issues_count":58,"forks":1363,"open_issues":58,"watchers":7169,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3533"},"html":{"href":"https://github.com/marionettejs/backbone.marionette/pull/3533"},"issue":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/3533"},"comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/issues/3533/comments"},"review_comments":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3533/comments"},"review_comment":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/pulls/3533/commits"},"statuses":{"href":"https://api.github.com/repos/marionettejs/backbone.marionette/statuses/b4ed1b750334d1b9c75ecaf3419dd8ed542cb635"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"paulfalgout"}}