{"action":"closed","number":765,"pull_request":{"url":"https://api.github.com/repos/nlohmann/json/pulls/765","id":144480792,"html_url":"https://github.com/nlohmann/json/pull/765","diff_url":"https://github.com/nlohmann/json/pull/765.diff","patch_url":"https://github.com/nlohmann/json/pull/765.patch","issue_url":"https://api.github.com/repos/nlohmann/json/issues/765","number":765,"state":"closed","locked":false,"title":"using more CMake","user":{"login":"nlohmann","id":159488,"avatar_url":"https://avatars2.githubusercontent.com/u/159488?v=4","gravatar_id":"","url":"https://api.github.com/users/nlohmann","html_url":"https://github.com/nlohmann","followers_url":"https://api.github.com/users/nlohmann/followers","following_url":"https://api.github.com/users/nlohmann/following{/other_user}","gists_url":"https://api.github.com/users/nlohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nlohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlohmann/subscriptions","organizations_url":"https://api.github.com/users/nlohmann/orgs","repos_url":"https://api.github.com/users/nlohmann/repos","events_url":"https://api.github.com/users/nlohmann/events{/privacy}","received_events_url":"https://api.github.com/users/nlohmann/received_events","type":"User","site_admin":false},"body":"Done:\r\n\r\n- using CMake for the special targets Valgrind (JSON_Valgrind), Clang sanitizers (JSON_Sanitizer), and no-exceptions (JSON_NoExceptions)\r\n- using Ninja to improve compilation speed\r\n- compiling and executing each test suite individually\r\n- removed test cases that broke the MSVC 2017 build\r\n\r\nMissing:\r\n\r\n- some magic to get Coveralls to work with individual executables (maybe @theodelrieu can help here with his approach from #700)","created_at":"2017-10-03T17:25:24Z","updated_at":"2017-10-04T08:39:57Z","closed_at":"2017-10-04T08:39:57Z","merged_at":"2017-10-04T08:39:57Z","merge_commit_sha":"4e81c1db47e87ff59bcb606499c6d657ac26bc60","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nlohmann/json/pulls/765/commits","review_comments_url":"https://api.github.com/repos/nlohmann/json/pulls/765/comments","review_comment_url":"https://api.github.com/repos/nlohmann/json/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nlohmann/json/issues/765/comments","statuses_url":"https://api.github.com/repos/nlohmann/json/statuses/e2045eae53500863e47f0023893c81f00b81100e","head":{"label":"nlohmann:feature/issue698","ref":"feature/issue698","sha":"e2045eae53500863e47f0023893c81f00b81100e","user":{"login":"nlohmann","id":159488,"avatar_url":"https://avatars2.githubusercontent.com/u/159488?v=4","gravatar_id":"","url":"https://api.github.com/users/nlohmann","html_url":"https://github.com/nlohmann","followers_url":"https://api.github.com/users/nlohmann/followers","following_url":"https://api.github.com/users/nlohmann/following{/other_user}","gists_url":"https://api.github.com/users/nlohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nlohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlohmann/subscriptions","organizations_url":"https://api.github.com/users/nlohmann/orgs","repos_url":"https://api.github.com/users/nlohmann/repos","events_url":"https://api.github.com/users/nlohmann/events{/privacy}","received_events_url":"https://api.github.com/users/nlohmann/received_events","type":"User","site_admin":false},"repo":{"id":11171548,"name":"json","full_name":"nlohmann/json","owner":{"login":"nlohmann","id":159488,"avatar_url":"https://avatars2.githubusercontent.com/u/159488?v=4","gravatar_id":"","url":"https://api.github.com/users/nlohmann","html_url":"https://github.com/nlohmann","followers_url":"https://api.github.com/users/nlohmann/followers","following_url":"https://api.github.com/users/nlohmann/following{/other_user}","gists_url":"https://api.github.com/users/nlohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nlohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlohmann/subscriptions","organizations_url":"https://api.github.com/users/nlohmann/orgs","repos_url":"https://api.github.com/users/nlohmann/repos","events_url":"https://api.github.com/users/nlohmann/events{/privacy}","received_events_url":"https://api.github.com/users/nlohmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlohmann/json","description":"JSON for Modern C++","fork":false,"url":"https://api.github.com/repos/nlohmann/json","forks_url":"https://api.github.com/repos/nlohmann/json/forks","keys_url":"https://api.github.com/repos/nlohmann/json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlohmann/json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlohmann/json/teams","hooks_url":"https://api.github.com/repos/nlohmann/json/hooks","issue_events_url":"https://api.github.com/repos/nlohmann/json/issues/events{/number}","events_url":"https://api.github.com/repos/nlohmann/json/events","assignees_url":"https://api.github.com/repos/nlohmann/json/assignees{/user}","branches_url":"https://api.github.com/repos/nlohmann/json/branches{/branch}","tags_url":"https://api.github.com/repos/nlohmann/json/tags","blobs_url":"https://api.github.com/repos/nlohmann/json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlohmann/json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlohmann/json/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlohmann/json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlohmann/json/statuses/{sha}","languages_url":"https://api.github.com/repos/nlohmann/json/languages","stargazers_url":"https://api.github.com/repos/nlohmann/json/stargazers","contributors_url":"https://api.github.com/repos/nlohmann/json/contributors","subscribers_url":"https://api.github.com/repos/nlohmann/json/subscribers","subscription_url":"https://api.github.com/repos/nlohmann/json/subscription","commits_url":"https://api.github.com/repos/nlohmann/json/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlohmann/json/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlohmann/json/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlohmann/json/issues/comments{/number}","contents_url":"https://api.github.com/repos/nlohmann/json/contents/{+path}","compare_url":"https://api.github.com/repos/nlohmann/json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlohmann/json/merges","archive_url":"https://api.github.com/repos/nlohmann/json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlohmann/json/downloads","issues_url":"https://api.github.com/repos/nlohmann/json/issues{/number}","pulls_url":"https://api.github.com/repos/nlohmann/json/pulls{/number}","milestones_url":"https://api.github.com/repos/nlohmann/json/milestones{/number}","notifications_url":"https://api.github.com/repos/nlohmann/json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlohmann/json/labels{/name}","releases_url":"https://api.github.com/repos/nlohmann/json/releases{/id}","deployments_url":"https://api.github.com/repos/nlohmann/json/deployments","created_at":"2013-07-04T08:47:49Z","updated_at":"2017-10-04T07:23:53Z","pushed_at":"2017-10-04T08:39:57Z","git_url":"git://github.com/nlohmann/json.git","ssh_url":"git@github.com:nlohmann/json.git","clone_url":"https://github.com/nlohmann/json.git","svn_url":"https://github.com/nlohmann/json","homepage":"https://nlohmann.github.io/json/","size":140594,"stargazers_count":6690,"watchers_count":6690,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1060,"mirror_url":null,"open_issues_count":26,"forks":1060,"open_issues":26,"watchers":6690,"default_branch":"develop"}},"base":{"label":"nlohmann:develop","ref":"develop","sha":"7435d54e9751cf5469b7e8a4ad63990d08d9cdda","user":{"login":"nlohmann","id":159488,"avatar_url":"https://avatars2.githubusercontent.com/u/159488?v=4","gravatar_id":"","url":"https://api.github.com/users/nlohmann","html_url":"https://github.com/nlohmann","followers_url":"https://api.github.com/users/nlohmann/followers","following_url":"https://api.github.com/users/nlohmann/following{/other_user}","gists_url":"https://api.github.com/users/nlohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nlohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlohmann/subscriptions","organizations_url":"https://api.github.com/users/nlohmann/orgs","repos_url":"https://api.github.com/users/nlohmann/repos","events_url":"https://api.github.com/users/nlohmann/events{/privacy}","received_events_url":"https://api.github.com/users/nlohmann/received_events","type":"User","site_admin":false},"repo":{"id":11171548,"name":"json","full_name":"nlohmann/json","owner":{"login":"nlohmann","id":159488,"avatar_url":"https://avatars2.githubusercontent.com/u/159488?v=4","gravatar_id":"","url":"https://api.github.com/users/nlohmann","html_url":"https://github.com/nlohmann","followers_url":"https://api.github.com/users/nlohmann/followers","following_url":"https://api.github.com/users/nlohmann/following{/other_user}","gists_url":"https://api.github.com/users/nlohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nlohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlohmann/subscriptions","organizations_url":"https://api.github.com/users/nlohmann/orgs","repos_url":"https://api.github.com/users/nlohmann/repos","events_url":"https://api.github.com/users/nlohmann/events{/privacy}","received_events_url":"https://api.github.com/users/nlohmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlohmann/json","description":"JSON for Modern C++","fork":false,"url":"https://api.github.com/repos/nlohmann/json","forks_url":"https://api.github.com/repos/nlohmann/json/forks","keys_url":"https://api.github.com/repos/nlohmann/json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlohmann/json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlohmann/json/teams","hooks_url":"https://api.github.com/repos/nlohmann/json/hooks","issue_events_url":"https://api.github.com/repos/nlohmann/json/issues/events{/number}","events_url":"https://api.github.com/repos/nlohmann/json/events","assignees_url":"https://api.github.com/repos/nlohmann/json/assignees{/user}","branches_url":"https://api.github.com/repos/nlohmann/json/branches{/branch}","tags_url":"https://api.github.com/repos/nlohmann/json/tags","blobs_url":"https://api.github.com/repos/nlohmann/json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlohmann/json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlohmann/json/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlohmann/json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlohmann/json/statuses/{sha}","languages_url":"https://api.github.com/repos/nlohmann/json/languages","stargazers_url":"https://api.github.com/repos/nlohmann/json/stargazers","contributors_url":"https://api.github.com/repos/nlohmann/json/contributors","subscribers_url":"https://api.github.com/repos/nlohmann/json/subscribers","subscription_url":"https://api.github.com/repos/nlohmann/json/subscription","commits_url":"https://api.github.com/repos/nlohmann/json/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlohmann/json/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlohmann/json/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlohmann/json/issues/comments{/number}","contents_url":"https://api.github.com/repos/nlohmann/json/contents/{+path}","compare_url":"https://api.github.com/repos/nlohmann/json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlohmann/json/merges","archive_url":"https://api.github.com/repos/nlohmann/json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlohmann/json/downloads","issues_url":"https://api.github.com/repos/nlohmann/json/issues{/number}","pulls_url":"https://api.github.com/repos/nlohmann/json/pulls{/number}","milestones_url":"https://api.github.com/repos/nlohmann/json/milestones{/number}","notifications_url":"https://api.github.com/repos/nlohmann/json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlohmann/json/labels{/name}","releases_url":"https://api.github.com/repos/nlohmann/json/releases{/id}","deployments_url":"https://api.github.com/repos/nlohmann/json/deployments","created_at":"2013-07-04T08:47:49Z","updated_at":"2017-10-04T07:23:53Z","pushed_at":"2017-10-04T08:39:57Z","git_url":"git://github.com/nlohmann/json.git","ssh_url":"git@github.com:nlohmann/json.git","clone_url":"https://github.com/nlohmann/json.git","svn_url":"https://github.com/nlohmann/json","homepage":"https://nlohmann.github.io/json/","size":140594,"stargazers_count":6690,"watchers_count":6690,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1060,"mirror_url":null,"open_issues_count":26,"forks":1060,"open_issues":26,"watchers":6690,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/nlohmann/json/pulls/765"},"html":{"href":"https://github.com/nlohmann/json/pull/765"},"issue":{"href":"https://api.github.com/repos/nlohmann/json/issues/765"},"comments":{"href":"https://api.github.com/repos/nlohmann/json/issues/765/comments"},"review_comments":{"href":"https://api.github.com/repos/nlohmann/json/pulls/765/comments"},"review_comment":{"href":"https://api.github.com/repos/nlohmann/json/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nlohmann/json/pulls/765/commits"},"statuses":{"href":"https://api.github.com/repos/nlohmann/json/statuses/e2045eae53500863e47f0023893c81f00b81100e"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nlohmann","id":159488,"avatar_url":"https://avatars2.githubusercontent.com/u/159488?v=4","gravatar_id":"","url":"https://api.github.com/users/nlohmann","html_url":"https://github.com/nlohmann","followers_url":"https://api.github.com/users/nlohmann/followers","following_url":"https://api.github.com/users/nlohmann/following{/other_user}","gists_url":"https://api.github.com/users/nlohmann/gists{/gist_id}","starred_url":"https://api.github.com/users/nlohmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlohmann/subscriptions","organizations_url":"https://api.github.com/users/nlohmann/orgs","repos_url":"https://api.github.com/users/nlohmann/repos","events_url":"https://api.github.com/users/nlohmann/events{/privacy}","received_events_url":"https://api.github.com/users/nlohmann/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":25,"additions":107,"deletions":113,"changed_files":4}}
{"actor":{"display_login":"nlohmann"}}