{"action":"opened","number":490,"pull_request":{"url":"https://api.github.com/repos/zanata/zanata-platform/pulls/490","id":136874245,"html_url":"https://github.com/zanata/zanata-platform/pull/490","diff_url":"https://github.com/zanata/zanata-platform/pull/490.diff","patch_url":"https://github.com/zanata/zanata-platform/pull/490.patch","issue_url":"https://api.github.com/repos/zanata/zanata-platform/issues/490","number":490,"state":"open","locked":false,"title":"fix: functional test","user":{"login":"aeng","id":766762,"avatar_url":"https://avatars0.githubusercontent.com/u/766762?v=4","gravatar_id":"","url":"https://api.github.com/users/aeng","html_url":"https://github.com/aeng","followers_url":"https://api.github.com/users/aeng/followers","following_url":"https://api.github.com/users/aeng/following{/other_user}","gists_url":"https://api.github.com/users/aeng/gists{/gist_id}","starred_url":"https://api.github.com/users/aeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeng/subscriptions","organizations_url":"https://api.github.com/users/aeng/orgs","repos_url":"https://api.github.com/users/aeng/repos","events_url":"https://api.github.com/users/aeng/events{/privacy}","received_events_url":"https://api.github.com/users/aeng/received_events","type":"User","site_admin":false},"body":"JIRA issue URL: *paste URL here*\r\n\r\n*[Add a short description of what is changed here.]*\r\n\r\n\r\n## Reviewer tasks\r\n\r\nThe following is based on the\r\n[Zanata Development Guidelines](https://github.com/zanata/zanata-platform/wiki/Development-Guidelines).\r\nAs a reviewer, you should check the guidelines regularly for updates, and just\r\nto refresh your memory.\r\n\r\n\r\nThe reviewer can use this list for reference to make sure\r\nthey have considered all the important points.\r\n\r\nUse the checkboxes or not, whatever works best for you.\r\n\r\n - Code quality\r\n   - [ ] Code passes style check (checkstyle/eslint)\r\n   - [ ] Code is clear and concise\r\n   - [ ] UI code is internationalised\r\n   - [ ] Code has adequate comments where appropriate\r\n   - Code is in an appropriate place\r\n     - [ ] Classes are in appropriate packages\r\n     - [ ] Code fits with class's responsibilities (SRP)\r\n   - [ ] Configuration files are documented enough\r\n   - If code is removed\r\n     - [ ] No remaining code references the removed code\r\n       - [ ] No orphaned rewrite rules\r\n       - [ ] No orphaned config settings\r\n     - [ ] No remaining comments refer to the removed code\r\n     - [ ] Unused imports and libraries are removed\r\n - Testing\r\n   - [ ] New code has tests\r\n   - [ ] Changed code has tests\r\n   - [ ] All tests pass\r\n   - [ ] Test coverage stable or increased\r\n - Documentation\r\n   - [ ] New features are documented\r\n   - [ ] Docs removed for deleted features\r\n   - [ ] Docs updated for all changed features\r\n   - [ ] Developer/sysadmin docs updated if appropriate\r\n - If there are new dependencies\r\n   - [ ] Does each new dependency pass all the\r\n         [Considerations for new dependencies](https://github.com/zanata/zanata-platform/wiki/Development-Guidelines#new-technologies-and-dependencies)?\r\n\r\n\r\n----\r\n*This template can be updated in .github/PULL_REQUEST_TEMPLATE.md*\r\n","created_at":"2017-08-22T01:31:25Z","updated_at":"2017-08-22T01:31:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"aeng","id":766762,"avatar_url":"https://avatars0.githubusercontent.com/u/766762?v=4","gravatar_id":"","url":"https://api.github.com/users/aeng","html_url":"https://github.com/aeng","followers_url":"https://api.github.com/users/aeng/followers","following_url":"https://api.github.com/users/aeng/following{/other_user}","gists_url":"https://api.github.com/users/aeng/gists{/gist_id}","starred_url":"https://api.github.com/users/aeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeng/subscriptions","organizations_url":"https://api.github.com/users/aeng/orgs","repos_url":"https://api.github.com/users/aeng/repos","events_url":"https://api.github.com/users/aeng/events{/privacy}","received_events_url":"https://api.github.com/users/aeng/received_events","type":"User","site_admin":false},"assignees":[{"login":"aeng","id":766762,"avatar_url":"https://avatars0.githubusercontent.com/u/766762?v=4","gravatar_id":"","url":"https://api.github.com/users/aeng","html_url":"https://github.com/aeng","followers_url":"https://api.github.com/users/aeng/followers","following_url":"https://api.github.com/users/aeng/following{/other_user}","gists_url":"https://api.github.com/users/aeng/gists{/gist_id}","starred_url":"https://api.github.com/users/aeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeng/subscriptions","organizations_url":"https://api.github.com/users/aeng/orgs","repos_url":"https://api.github.com/users/aeng/repos","events_url":"https://api.github.com/users/aeng/events{/privacy}","received_events_url":"https://api.github.com/users/aeng/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zanata/zanata-platform/pulls/490/commits","review_comments_url":"https://api.github.com/repos/zanata/zanata-platform/pulls/490/comments","review_comment_url":"https://api.github.com/repos/zanata/zanata-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zanata/zanata-platform/issues/490/comments","statuses_url":"https://api.github.com/repos/zanata/zanata-platform/statuses/d39c5a43f94ef144126e26d361c48e6b0f42ad2b","head":{"label":"zanata:fix-ft","ref":"fix-ft","sha":"d39c5a43f94ef144126e26d361c48e6b0f42ad2b","user":{"login":"zanata","id":637455,"avatar_url":"https://avatars0.githubusercontent.com/u/637455?v=4","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"repo":{"id":71434550,"name":"zanata-platform","full_name":"zanata/zanata-platform","owner":{"login":"zanata","id":637455,"avatar_url":"https://avatars0.githubusercontent.com/u/637455?v=4","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zanata/zanata-platform","description":"Zanata is a web-based system for translators to translate documentation and software online using a web browser.","fork":false,"url":"https://api.github.com/repos/zanata/zanata-platform","forks_url":"https://api.github.com/repos/zanata/zanata-platform/forks","keys_url":"https://api.github.com/repos/zanata/zanata-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanata/zanata-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanata/zanata-platform/teams","hooks_url":"https://api.github.com/repos/zanata/zanata-platform/hooks","issue_events_url":"https://api.github.com/repos/zanata/zanata-platform/issues/events{/number}","events_url":"https://api.github.com/repos/zanata/zanata-platform/events","assignees_url":"https://api.github.com/repos/zanata/zanata-platform/assignees{/user}","branches_url":"https://api.github.com/repos/zanata/zanata-platform/branches{/branch}","tags_url":"https://api.github.com/repos/zanata/zanata-platform/tags","blobs_url":"https://api.github.com/repos/zanata/zanata-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanata/zanata-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanata/zanata-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanata/zanata-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanata/zanata-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/zanata/zanata-platform/languages","stargazers_url":"https://api.github.com/repos/zanata/zanata-platform/stargazers","contributors_url":"https://api.github.com/repos/zanata/zanata-platform/contributors","subscribers_url":"https://api.github.com/repos/zanata/zanata-platform/subscribers","subscription_url":"https://api.github.com/repos/zanata/zanata-platform/subscription","commits_url":"https://api.github.com/repos/zanata/zanata-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanata/zanata-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanata/zanata-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanata/zanata-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/zanata/zanata-platform/contents/{+path}","compare_url":"https://api.github.com/repos/zanata/zanata-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanata/zanata-platform/merges","archive_url":"https://api.github.com/repos/zanata/zanata-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanata/zanata-platform/downloads","issues_url":"https://api.github.com/repos/zanata/zanata-platform/issues{/number}","pulls_url":"https://api.github.com/repos/zanata/zanata-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/zanata/zanata-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/zanata/zanata-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanata/zanata-platform/labels{/name}","releases_url":"https://api.github.com/repos/zanata/zanata-platform/releases{/id}","deployments_url":"https://api.github.com/repos/zanata/zanata-platform/deployments","created_at":"2016-10-20T07:02:02Z","updated_at":"2017-08-08T02:35:00Z","pushed_at":"2017-08-22T01:31:17Z","git_url":"git://github.com/zanata/zanata-platform.git","ssh_url":"git@github.com:zanata/zanata-platform.git","clone_url":"https://github.com/zanata/zanata-platform.git","svn_url":"https://github.com/zanata/zanata-platform","homepage":null,"size":41884,"stargazers_count":71,"watchers_count":71,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":18,"forks":22,"open_issues":18,"watchers":71,"default_branch":"master"}},"base":{"label":"zanata:master","ref":"master","sha":"5057f6fd65653867ad4b157fdf0311063514abd3","user":{"login":"zanata","id":637455,"avatar_url":"https://avatars0.githubusercontent.com/u/637455?v=4","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"repo":{"id":71434550,"name":"zanata-platform","full_name":"zanata/zanata-platform","owner":{"login":"zanata","id":637455,"avatar_url":"https://avatars0.githubusercontent.com/u/637455?v=4","gravatar_id":"","url":"https://api.github.com/users/zanata","html_url":"https://github.com/zanata","followers_url":"https://api.github.com/users/zanata/followers","following_url":"https://api.github.com/users/zanata/following{/other_user}","gists_url":"https://api.github.com/users/zanata/gists{/gist_id}","starred_url":"https://api.github.com/users/zanata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanata/subscriptions","organizations_url":"https://api.github.com/users/zanata/orgs","repos_url":"https://api.github.com/users/zanata/repos","events_url":"https://api.github.com/users/zanata/events{/privacy}","received_events_url":"https://api.github.com/users/zanata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zanata/zanata-platform","description":"Zanata is a web-based system for translators to translate documentation and software online using a web browser.","fork":false,"url":"https://api.github.com/repos/zanata/zanata-platform","forks_url":"https://api.github.com/repos/zanata/zanata-platform/forks","keys_url":"https://api.github.com/repos/zanata/zanata-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zanata/zanata-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zanata/zanata-platform/teams","hooks_url":"https://api.github.com/repos/zanata/zanata-platform/hooks","issue_events_url":"https://api.github.com/repos/zanata/zanata-platform/issues/events{/number}","events_url":"https://api.github.com/repos/zanata/zanata-platform/events","assignees_url":"https://api.github.com/repos/zanata/zanata-platform/assignees{/user}","branches_url":"https://api.github.com/repos/zanata/zanata-platform/branches{/branch}","tags_url":"https://api.github.com/repos/zanata/zanata-platform/tags","blobs_url":"https://api.github.com/repos/zanata/zanata-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zanata/zanata-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zanata/zanata-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/zanata/zanata-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zanata/zanata-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/zanata/zanata-platform/languages","stargazers_url":"https://api.github.com/repos/zanata/zanata-platform/stargazers","contributors_url":"https://api.github.com/repos/zanata/zanata-platform/contributors","subscribers_url":"https://api.github.com/repos/zanata/zanata-platform/subscribers","subscription_url":"https://api.github.com/repos/zanata/zanata-platform/subscription","commits_url":"https://api.github.com/repos/zanata/zanata-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/zanata/zanata-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/zanata/zanata-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/zanata/zanata-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/zanata/zanata-platform/contents/{+path}","compare_url":"https://api.github.com/repos/zanata/zanata-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zanata/zanata-platform/merges","archive_url":"https://api.github.com/repos/zanata/zanata-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zanata/zanata-platform/downloads","issues_url":"https://api.github.com/repos/zanata/zanata-platform/issues{/number}","pulls_url":"https://api.github.com/repos/zanata/zanata-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/zanata/zanata-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/zanata/zanata-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zanata/zanata-platform/labels{/name}","releases_url":"https://api.github.com/repos/zanata/zanata-platform/releases{/id}","deployments_url":"https://api.github.com/repos/zanata/zanata-platform/deployments","created_at":"2016-10-20T07:02:02Z","updated_at":"2017-08-08T02:35:00Z","pushed_at":"2017-08-22T01:31:17Z","git_url":"git://github.com/zanata/zanata-platform.git","ssh_url":"git@github.com:zanata/zanata-platform.git","clone_url":"https://github.com/zanata/zanata-platform.git","svn_url":"https://github.com/zanata/zanata-platform","homepage":null,"size":41884,"stargazers_count":71,"watchers_count":71,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":18,"forks":22,"open_issues":18,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zanata/zanata-platform/pulls/490"},"html":{"href":"https://github.com/zanata/zanata-platform/pull/490"},"issue":{"href":"https://api.github.com/repos/zanata/zanata-platform/issues/490"},"comments":{"href":"https://api.github.com/repos/zanata/zanata-platform/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/zanata/zanata-platform/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/zanata/zanata-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zanata/zanata-platform/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/zanata/zanata-platform/statuses/d39c5a43f94ef144126e26d361c48e6b0f42ad2b"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"aeng"}}