{"action":"created","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/2561","repository_url":"https://api.github.com/repos/buildbot/buildbot","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/2561/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/2561/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/2561/events","html_url":"https://github.com/buildbot/buildbot/pull/2561","id":198799264,"number":2561,"title":"3197 DB schema: change_properties to text","user":{"login":"nand0p","id":1916245,"avatar_url":"https://avatars.githubusercontent.com/u/1916245?v=3","gravatar_id":"","url":"https://api.github.com/users/nand0p","html_url":"https://github.com/nand0p","followers_url":"https://api.github.com/users/nand0p/followers","following_url":"https://api.github.com/users/nand0p/following{/other_user}","gists_url":"https://api.github.com/users/nand0p/gists{/gist_id}","starred_url":"https://api.github.com/users/nand0p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nand0p/subscriptions","organizations_url":"https://api.github.com/users/nand0p/orgs","repos_url":"https://api.github.com/users/nand0p/repos","events_url":"https://api.github.com/users/nand0p/events{/privacy}","received_events_url":"https://api.github.com/users/nand0p/received_events","type":"User","site_admin":false},"labels":[{"id":239247466,"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20relnotes","name":"needs relnotes","color":"f7c6c7","default":false},{"id":239245799,"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20tests","name":"needs tests","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-01-04T20:10:12Z","updated_at":"2017-01-13T22:46:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/2561","html_url":"https://github.com/buildbot/buildbot/pull/2561","diff_url":"https://github.com/buildbot/buildbot/pull/2561.diff","patch_url":"https://github.com/buildbot/buildbot/pull/2561.patch"},"body":"Alters change_properties.propery_value from String(1024) to Text\r\n\r\nhttp://trac.buildbot.net/ticket/3197\r\n"},"comment":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/272568785","html_url":"https://github.com/buildbot/buildbot/pull/2561#issuecomment-272568785","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/2561","id":272568785,"user":{"login":"nand0p","id":1916245,"avatar_url":"https://avatars.githubusercontent.com/u/1916245?v=3","gravatar_id":"","url":"https://api.github.com/users/nand0p","html_url":"https://github.com/nand0p","followers_url":"https://api.github.com/users/nand0p/followers","following_url":"https://api.github.com/users/nand0p/following{/other_user}","gists_url":"https://api.github.com/users/nand0p/gists{/gist_id}","starred_url":"https://api.github.com/users/nand0p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nand0p/subscriptions","organizations_url":"https://api.github.com/users/nand0p/orgs","repos_url":"https://api.github.com/users/nand0p/repos","events_url":"https://api.github.com/users/nand0p/events{/privacy}","received_events_url":"https://api.github.com/users/nand0p/received_events","type":"User","site_admin":false},"created_at":"2017-01-13T22:46:21Z","updated_at":"2017-01-13T22:46:21Z","body":"@tardyp You're right, there does appear to be an issue with sqlalchemy truncating text fields when they contain large strings. To compensate, I kept the type as string(varchar), but upped to 14336 (1024*14), to deal with mysql limits. http://stackoverflow.com/questions/13506832/what-is-the-mysql-varchar-max-size\r\n\r\nshould we worry about truncation for any of these?\r\n\r\n> ./master/buildbot/db/model.py:        sa.Column('value', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('state_string', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('state_string', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('urls_json', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('name', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('property_value', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('parent_relationship', sa.Text),\r\n> ./master/buildbot/db/model.py:        sa.Column('name', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('comments', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('patch_base64', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('patch_author', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('patch_comment', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('subdir', sa.Text),\r\n> ./master/buildbot/db/model.py:        sa.Column('name', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('name', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('description', sa.Text, nullable=True),\r\n> ./master/buildbot/db/model.py:        sa.Column('name', sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column(\"value_json\", sa.Text, nullable=False),\r\n> ./master/buildbot/db/model.py:        sa.Column('name', sa.Text, nullable=False),\r\n"}}
{"actor":{"display_login":"nand0p"}}