{"action":"opened","number":1218,"pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1218","id":129805076,"html_url":"https://github.com/Mudlet/Mudlet/pull/1218","diff_url":"https://github.com/Mudlet/Mudlet/pull/1218.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/1218.patch","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1218","number":1218,"state":"open","locked":false,"title":"Enhance editing","user":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars0.githubusercontent.com/u/6163092?v=3","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"body":"This somewhat large PR enhances the Editor in several ways:\r\n+ It makes the search have an option to be case-sensitive so that searching for \"Needle\" will ignore \"needle\" - which, as Lua is a case sensitive language can be a big help to find miss-capitalisations in identifiers.\r\n+ It provides a means to clear the search result outlining in the edbee editor widget that result from a search operation (and clears the search results widget)\r\n+ **It allows the user to click on a search result item and the editor will switch to the selected item and position the cursor on the item in the editor that produced the result - and for ones where this is a multi-line widget and the result would otherwise be off-screen - scrolls so that the result is visible.**† Not only are the lua code scripts, trigger patterns and item names searched but it has been extended to also search:\r\n    + the \"command\" field(s) for those items that have it (or them for push-down buttons)\r\n    + the \"Css\" (now renamed \"Stylesheet\") field for \"Button/Menu/Toolbar\" items\r\n    + \r\n+ For \"Lua code\" and \"Stylesheet\" search areas where there can be multiple results on many different lines the \"Where\" field in the search results include a position indicator of the form `{L: ## C: ##}` to help in locating which result to click on - similarly \"Pattern\" results from triggers include a \"{##}\" addition to indicate which pattern provided the result. {Also the pattern numbers have been shifted up on screen in the GUI to be `1`-`50` instead of `0`-`49` and this is reflected in the search results and also fixes the bug from 2009 now recorded as #608 ! 😀}\r\n+ Tweaks the \"xxxx_main_area\" forms for most Mudlet item types so that item is identified uniformly by the term \"Name:\" and the term for the plain text that is sent straight to the MUD server is called \"Command\" - except for Push down buttons of course which have \"Command {Down}\" and \"Command {Up}\". To keep things simpler when I was making this PR I also renamed and relaid out some of the items in the above forms/files as there was quite a few oddly named widgets and it was confusing to keep track of which type I was working with - so the ones I have \"adjusted\" have all gained (if necessary) a camel case prefix of the widget type sans the initial \"Q\" followed by (in hindsight a somewhat redundant \"Item\" e.g. \"trigger\", \"action\", \"key\" etc.\r\n+ Specifically for the Variables part of the editor I implemented a tweak that disables the user choosing invalid types for the \"key\" and \"value\" of an item selected in that view but allowing them to be set for \"display\" purposes - __this ought to be checked by reviewers__.\r\n\r\n\r\n_† - This feature is, I think, a major item to be trumpeted in the release announcement._ 😤 ","created_at":"2017-07-11T01:13:39Z","updated_at":"2017-07-11T01:13:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"vadi2","id":110988,"avatar_url":"https://avatars2.githubusercontent.com/u/110988?v=3","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"assignees":[{"login":"vadi2","id":110988,"avatar_url":"https://avatars2.githubusercontent.com/u/110988?v=3","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},{"login":"itsTheFae","id":22507613,"avatar_url":"https://avatars3.githubusercontent.com/u/22507613?v=3","gravatar_id":"","url":"https://api.github.com/users/itsTheFae","html_url":"https://github.com/itsTheFae","followers_url":"https://api.github.com/users/itsTheFae/followers","following_url":"https://api.github.com/users/itsTheFae/following{/other_user}","gists_url":"https://api.github.com/users/itsTheFae/gists{/gist_id}","starred_url":"https://api.github.com/users/itsTheFae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itsTheFae/subscriptions","organizations_url":"https://api.github.com/users/itsTheFae/orgs","repos_url":"https://api.github.com/users/itsTheFae/repos","events_url":"https://api.github.com/users/itsTheFae/events{/privacy}","received_events_url":"https://api.github.com/users/itsTheFae/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/Mudlet/Mudlet/milestones/6","html_url":"https://github.com/Mudlet/Mudlet/milestone/6","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones/6/labels","id":2617474,"number":6,"title":"3.4","description":"","creator":{"login":"vadi2","id":110988,"avatar_url":"https://avatars2.githubusercontent.com/u/110988?v=3","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2017-07-03T03:33:23Z","updated_at":"2017-07-11T01:13:39Z","due_on":"2017-08-06T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1218/commits","review_comments_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1218/comments","review_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1218/comments","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/c64a5cb02e55e3750000ced4f328683769fa0b4b","head":{"label":"SlySven:Enhance_editing","ref":"Enhance_editing","sha":"c64a5cb02e55e3750000ced4f328683769fa0b4b","user":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars0.githubusercontent.com/u/6163092?v=3","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"repo":{"id":22490921,"name":"Mudlet","full_name":"SlySven/Mudlet","owner":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars0.githubusercontent.com/u/6163092?v=3","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SlySven/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":true,"url":"https://api.github.com/repos/SlySven/Mudlet","forks_url":"https://api.github.com/repos/SlySven/Mudlet/forks","keys_url":"https://api.github.com/repos/SlySven/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SlySven/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SlySven/Mudlet/teams","hooks_url":"https://api.github.com/repos/SlySven/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/SlySven/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/SlySven/Mudlet/events","assignees_url":"https://api.github.com/repos/SlySven/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/SlySven/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/SlySven/Mudlet/tags","blobs_url":"https://api.github.com/repos/SlySven/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SlySven/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SlySven/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/SlySven/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SlySven/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/SlySven/Mudlet/languages","stargazers_url":"https://api.github.com/repos/SlySven/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/SlySven/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/SlySven/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/SlySven/Mudlet/subscription","commits_url":"https://api.github.com/repos/SlySven/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/SlySven/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/SlySven/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/SlySven/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/SlySven/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/SlySven/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SlySven/Mudlet/merges","archive_url":"https://api.github.com/repos/SlySven/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SlySven/Mudlet/downloads","issues_url":"https://api.github.com/repos/SlySven/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/SlySven/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/SlySven/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/SlySven/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SlySven/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/SlySven/Mudlet/releases{/id}","deployments_url":"https://api.github.com/repos/SlySven/Mudlet/deployments","created_at":"2014-08-01T01:05:26Z","updated_at":"2017-05-10T14:53:57Z","pushed_at":"2017-07-11T00:21:21Z","git_url":"git://github.com/SlySven/Mudlet.git","ssh_url":"git@github.com:SlySven/Mudlet.git","clone_url":"https://github.com/SlySven/Mudlet.git","svn_url":"https://github.com/SlySven/Mudlet","homepage":null,"size":26941,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"development"}},"base":{"label":"Mudlet:development","ref":"development","sha":"1fea403904b82f3a81c4ecbc6bcb37f9cea4b354","user":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars0.githubusercontent.com/u/6158612?v=3","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"repo":{"id":15108812,"name":"Mudlet","full_name":"Mudlet/Mudlet","owner":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars0.githubusercontent.com/u/6158612?v=3","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mudlet/Mudlet","description":"A cross-platform, open source, and super fast MUD client with scripting in Lua","fork":false,"url":"https://api.github.com/repos/Mudlet/Mudlet","forks_url":"https://api.github.com/repos/Mudlet/Mudlet/forks","keys_url":"https://api.github.com/repos/Mudlet/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mudlet/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mudlet/Mudlet/teams","hooks_url":"https://api.github.com/repos/Mudlet/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/Mudlet/Mudlet/events","assignees_url":"https://api.github.com/repos/Mudlet/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/Mudlet/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/Mudlet/Mudlet/tags","blobs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mudlet/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mudlet/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/Mudlet/Mudlet/languages","stargazers_url":"https://api.github.com/repos/Mudlet/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/Mudlet/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/Mudlet/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/Mudlet/Mudlet/subscription","commits_url":"https://api.github.com/repos/Mudlet/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mudlet/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mudlet/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/Mudlet/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mudlet/Mudlet/merges","archive_url":"https://api.github.com/repos/Mudlet/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mudlet/Mudlet/downloads","issues_url":"https://api.github.com/repos/Mudlet/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/Mudlet/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/Mudlet/Mudlet/releases{/id}","deployments_url":"https://api.github.com/repos/Mudlet/Mudlet/deployments","created_at":"2013-12-11T14:04:21Z","updated_at":"2017-07-10T18:37:15Z","pushed_at":"2017-07-10T15:47:32Z","git_url":"git://github.com/Mudlet/Mudlet.git","ssh_url":"git@github.com:Mudlet/Mudlet.git","clone_url":"https://github.com/Mudlet/Mudlet.git","svn_url":"https://github.com/Mudlet/Mudlet","homepage":"http://mudlet.org","size":24364,"stargazers_count":99,"watchers_count":99,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":385,"forks":57,"open_issues":385,"watchers":99,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1218"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/1218"},"issue":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/1218"},"comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/1218/comments"},"review_comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1218/comments"},"review_comment":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1218/commits"},"statuses":{"href":"https://api.github.com/repos/Mudlet/Mudlet/statuses/c64a5cb02e55e3750000ced4f328683769fa0b4b"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":3153,"deletions":2160,"changed_files":27}}
{"actor":{"display_login":"SlySven"}}