{"action":"created","comment":{"url":"https://api.github.com/repos/roundware/roundware-server/pulls/comments/102063389","pull_request_review_id":22806789,"id":102063389,"diff_hunk":"@@ -281,3 +297,68 @@ def _update_playlist_timed(self):\n         self.playlist_timed = self.order_assets(self.playlist_timed)\n \n         # logger.debug(\"Found timed assets: %s\" % self.playlist_timed)\n+\n+\n+    def _assets_by_user(self, user_id):","path":"roundwared/recording_collection.py","position":82,"original_position":82,"commit_id":"073c70184aff4c544bd9ac9d05d69b5824b8fb6b","original_commit_id":"073c70184aff4c544bd9ac9d05d69b5824b8fb6b","user":{"login":"jslootbeek","id":907827,"avatar_url":"https://avatars.githubusercontent.com/u/907827?v=3","gravatar_id":"","url":"https://api.github.com/users/jslootbeek","html_url":"https://github.com/jslootbeek","followers_url":"https://api.github.com/users/jslootbeek/followers","following_url":"https://api.github.com/users/jslootbeek/following{/other_user}","gists_url":"https://api.github.com/users/jslootbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/jslootbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jslootbeek/subscriptions","organizations_url":"https://api.github.com/users/jslootbeek/orgs","repos_url":"https://api.github.com/users/jslootbeek/repos","events_url":"https://api.github.com/users/jslootbeek/events{/privacy}","received_events_url":"https://api.github.com/users/jslootbeek/received_events","type":"User","site_admin":false},"body":"This can maybe be optimized into a single query. I'm not sure its worth spending time on now, but I would keep an eye on this function in production and see if it causes a bottleneck.","created_at":"2017-02-20T17:21:58Z","updated_at":"2017-02-20T17:27:12Z","html_url":"https://github.com/roundware/roundware-server/pull/318#discussion_r102063389","pull_request_url":"https://api.github.com/repos/roundware/roundware-server/pulls/318","_links":{"self":{"href":"https://api.github.com/repos/roundware/roundware-server/pulls/comments/102063389"},"html":{"href":"https://github.com/roundware/roundware-server/pull/318#discussion_r102063389"},"pull_request":{"href":"https://api.github.com/repos/roundware/roundware-server/pulls/318"}}},"pull_request":{"url":"https://api.github.com/repos/roundware/roundware-server/pulls/318","id":103537486,"html_url":"https://github.com/roundware/roundware-server/pull/318","diff_url":"https://github.com/roundware/roundware-server/pull/318.diff","patch_url":"https://github.com/roundware/roundware-server/pull/318.patch","issue_url":"https://api.github.com/repos/roundware/roundware-server/issues/318","number":318,"state":"open","locked":false,"title":"content blocking system","user":{"login":"hburgund","id":1714948,"avatar_url":"https://avatars.githubusercontent.com/u/1714948?v=3","gravatar_id":"","url":"https://api.github.com/users/hburgund","html_url":"https://github.com/hburgund","followers_url":"https://api.github.com/users/hburgund/followers","following_url":"https://api.github.com/users/hburgund/following{/other_user}","gists_url":"https://api.github.com/users/hburgund/gists{/gist_id}","starred_url":"https://api.github.com/users/hburgund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hburgund/subscriptions","organizations_url":"https://api.github.com/users/hburgund/orgs","repos_url":"https://api.github.com/users/hburgund/repos","events_url":"https://api.github.com/users/hburgund/events{/privacy}","received_events_url":"https://api.github.com/users/hburgund/received_events","type":"User","site_admin":false},"body":"### Feature Updates\r\n* `POST /api/2/assets/1/votes/` now has `vote_type` options of `block_asset` and `block_user`.\r\n* `block_*` requests log a vote for the session and cause the current asset to fade out and the next in the playlist to fade in.\r\n* `block_asset` ensures that the specified asset will not get played in any current and future sessions of the current user.\r\n* `block_user` ensures that all assets created by the same user as the asset on which the vote was cast will not be added to the playlist for any sessions of the current user.\r\n* as with all votes, `block_*` votes can be toggled by logging the same vote on the same asset with identical `vote_type` and `session_id`.\r\n* A new `session` variable called `user_blocked_list []` has been introduced which is populated when the session is initialized with any `asset_ids` that are either directly blocked by `block_asset` votes or indirectly blocked by `block_user` votes. This list is recalculated whenever a new `block_*` vote is cast in the session.\r\n* basic unit testing is included for both database logging of votes as well as proper playlist population based on `block_*` votes\r\n* no new default json fixture required because new `vote.voter` field is optional and is not needed in a default setup\r\n\r\nfixes #304","created_at":"2017-01-27T17:57:03Z","updated_at":"2017-02-20T17:27:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9dabe47c6a85d91a47fc1097cf85b7531552d44","assignee":{"login":"hburgund","id":1714948,"avatar_url":"https://avatars.githubusercontent.com/u/1714948?v=3","gravatar_id":"","url":"https://api.github.com/users/hburgund","html_url":"https://github.com/hburgund","followers_url":"https://api.github.com/users/hburgund/followers","following_url":"https://api.github.com/users/hburgund/following{/other_user}","gists_url":"https://api.github.com/users/hburgund/gists{/gist_id}","starred_url":"https://api.github.com/users/hburgund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hburgund/subscriptions","organizations_url":"https://api.github.com/users/hburgund/orgs","repos_url":"https://api.github.com/users/hburgund/repos","events_url":"https://api.github.com/users/hburgund/events{/privacy}","received_events_url":"https://api.github.com/users/hburgund/received_events","type":"User","site_admin":false},"assignees":[{"login":"hburgund","id":1714948,"avatar_url":"https://avatars.githubusercontent.com/u/1714948?v=3","gravatar_id":"","url":"https://api.github.com/users/hburgund","html_url":"https://github.com/hburgund","followers_url":"https://api.github.com/users/hburgund/followers","following_url":"https://api.github.com/users/hburgund/following{/other_user}","gists_url":"https://api.github.com/users/hburgund/gists{/gist_id}","starred_url":"https://api.github.com/users/hburgund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hburgund/subscriptions","organizations_url":"https://api.github.com/users/hburgund/orgs","repos_url":"https://api.github.com/users/hburgund/repos","events_url":"https://api.github.com/users/hburgund/events{/privacy}","received_events_url":"https://api.github.com/users/hburgund/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/roundware/roundware-server/pulls/318/commits","review_comments_url":"https://api.github.com/repos/roundware/roundware-server/pulls/318/comments","review_comment_url":"https://api.github.com/repos/roundware/roundware-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/roundware/roundware-server/issues/318/comments","statuses_url":"https://api.github.com/repos/roundware/roundware-server/statuses/073c70184aff4c544bd9ac9d05d69b5824b8fb6b","head":{"label":"hburgund:304/content-blocking","ref":"304/content-blocking","sha":"073c70184aff4c544bd9ac9d05d69b5824b8fb6b","user":{"login":"hburgund","id":1714948,"avatar_url":"https://avatars.githubusercontent.com/u/1714948?v=3","gravatar_id":"","url":"https://api.github.com/users/hburgund","html_url":"https://github.com/hburgund","followers_url":"https://api.github.com/users/hburgund/followers","following_url":"https://api.github.com/users/hburgund/following{/other_user}","gists_url":"https://api.github.com/users/hburgund/gists{/gist_id}","starred_url":"https://api.github.com/users/hburgund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hburgund/subscriptions","organizations_url":"https://api.github.com/users/hburgund/orgs","repos_url":"https://api.github.com/users/hburgund/repos","events_url":"https://api.github.com/users/hburgund/events{/privacy}","received_events_url":"https://api.github.com/users/hburgund/received_events","type":"User","site_admin":false},"repo":{"id":34191480,"name":"roundware-server","full_name":"hburgund/roundware-server","owner":{"login":"hburgund","id":1714948,"avatar_url":"https://avatars.githubusercontent.com/u/1714948?v=3","gravatar_id":"","url":"https://api.github.com/users/hburgund","html_url":"https://github.com/hburgund","followers_url":"https://api.github.com/users/hburgund/followers","following_url":"https://api.github.com/users/hburgund/following{/other_user}","gists_url":"https://api.github.com/users/hburgund/gists{/gist_id}","starred_url":"https://api.github.com/users/hburgund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hburgund/subscriptions","organizations_url":"https://api.github.com/users/hburgund/orgs","repos_url":"https://api.github.com/users/hburgund/repos","events_url":"https://api.github.com/users/hburgund/events{/privacy}","received_events_url":"https://api.github.com/users/hburgund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hburgund/roundware-server","description":"location-based contributory audio platform for art, education and documentary","fork":true,"url":"https://api.github.com/repos/hburgund/roundware-server","forks_url":"https://api.github.com/repos/hburgund/roundware-server/forks","keys_url":"https://api.github.com/repos/hburgund/roundware-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hburgund/roundware-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hburgund/roundware-server/teams","hooks_url":"https://api.github.com/repos/hburgund/roundware-server/hooks","issue_events_url":"https://api.github.com/repos/hburgund/roundware-server/issues/events{/number}","events_url":"https://api.github.com/repos/hburgund/roundware-server/events","assignees_url":"https://api.github.com/repos/hburgund/roundware-server/assignees{/user}","branches_url":"https://api.github.com/repos/hburgund/roundware-server/branches{/branch}","tags_url":"https://api.github.com/repos/hburgund/roundware-server/tags","blobs_url":"https://api.github.com/repos/hburgund/roundware-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hburgund/roundware-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hburgund/roundware-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/hburgund/roundware-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hburgund/roundware-server/statuses/{sha}","languages_url":"https://api.github.com/repos/hburgund/roundware-server/languages","stargazers_url":"https://api.github.com/repos/hburgund/roundware-server/stargazers","contributors_url":"https://api.github.com/repos/hburgund/roundware-server/contributors","subscribers_url":"https://api.github.com/repos/hburgund/roundware-server/subscribers","subscription_url":"https://api.github.com/repos/hburgund/roundware-server/subscription","commits_url":"https://api.github.com/repos/hburgund/roundware-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/hburgund/roundware-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/hburgund/roundware-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/hburgund/roundware-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/hburgund/roundware-server/contents/{+path}","compare_url":"https://api.github.com/repos/hburgund/roundware-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hburgund/roundware-server/merges","archive_url":"https://api.github.com/repos/hburgund/roundware-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hburgund/roundware-server/downloads","issues_url":"https://api.github.com/repos/hburgund/roundware-server/issues{/number}","pulls_url":"https://api.github.com/repos/hburgund/roundware-server/pulls{/number}","milestones_url":"https://api.github.com/repos/hburgund/roundware-server/milestones{/number}","notifications_url":"https://api.github.com/repos/hburgund/roundware-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hburgund/roundware-server/labels{/name}","releases_url":"https://api.github.com/repos/hburgund/roundware-server/releases{/id}","deployments_url":"https://api.github.com/repos/hburgund/roundware-server/deployments","created_at":"2015-04-19T03:02:52Z","updated_at":"2016-02-27T20:33:31Z","pushed_at":"2017-02-13T02:55:51Z","git_url":"git://github.com/hburgund/roundware-server.git","ssh_url":"git@github.com:hburgund/roundware-server.git","clone_url":"https://github.com/hburgund/roundware-server.git","svn_url":"https://github.com/hburgund/roundware-server","homepage":"http://roundware.org","size":13568,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"roundware:develop","ref":"develop","sha":"822aae15b974535cf3b445d9d9cc4ea73b49027b","user":{"login":"roundware","id":10054725,"avatar_url":"https://avatars.githubusercontent.com/u/10054725?v=3","gravatar_id":"","url":"https://api.github.com/users/roundware","html_url":"https://github.com/roundware","followers_url":"https://api.github.com/users/roundware/followers","following_url":"https://api.github.com/users/roundware/following{/other_user}","gists_url":"https://api.github.com/users/roundware/gists{/gist_id}","starred_url":"https://api.github.com/users/roundware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roundware/subscriptions","organizations_url":"https://api.github.com/users/roundware/orgs","repos_url":"https://api.github.com/users/roundware/repos","events_url":"https://api.github.com/users/roundware/events{/privacy}","received_events_url":"https://api.github.com/users/roundware/received_events","type":"Organization","site_admin":false},"repo":{"id":6511853,"name":"roundware-server","full_name":"roundware/roundware-server","owner":{"login":"roundware","id":10054725,"avatar_url":"https://avatars.githubusercontent.com/u/10054725?v=3","gravatar_id":"","url":"https://api.github.com/users/roundware","html_url":"https://github.com/roundware","followers_url":"https://api.github.com/users/roundware/followers","following_url":"https://api.github.com/users/roundware/following{/other_user}","gists_url":"https://api.github.com/users/roundware/gists{/gist_id}","starred_url":"https://api.github.com/users/roundware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roundware/subscriptions","organizations_url":"https://api.github.com/users/roundware/orgs","repos_url":"https://api.github.com/users/roundware/repos","events_url":"https://api.github.com/users/roundware/events{/privacy}","received_events_url":"https://api.github.com/users/roundware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/roundware/roundware-server","description":"Location-based contributory audio platform for art, education and documentary","fork":false,"url":"https://api.github.com/repos/roundware/roundware-server","forks_url":"https://api.github.com/repos/roundware/roundware-server/forks","keys_url":"https://api.github.com/repos/roundware/roundware-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roundware/roundware-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roundware/roundware-server/teams","hooks_url":"https://api.github.com/repos/roundware/roundware-server/hooks","issue_events_url":"https://api.github.com/repos/roundware/roundware-server/issues/events{/number}","events_url":"https://api.github.com/repos/roundware/roundware-server/events","assignees_url":"https://api.github.com/repos/roundware/roundware-server/assignees{/user}","branches_url":"https://api.github.com/repos/roundware/roundware-server/branches{/branch}","tags_url":"https://api.github.com/repos/roundware/roundware-server/tags","blobs_url":"https://api.github.com/repos/roundware/roundware-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roundware/roundware-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roundware/roundware-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/roundware/roundware-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roundware/roundware-server/statuses/{sha}","languages_url":"https://api.github.com/repos/roundware/roundware-server/languages","stargazers_url":"https://api.github.com/repos/roundware/roundware-server/stargazers","contributors_url":"https://api.github.com/repos/roundware/roundware-server/contributors","subscribers_url":"https://api.github.com/repos/roundware/roundware-server/subscribers","subscription_url":"https://api.github.com/repos/roundware/roundware-server/subscription","commits_url":"https://api.github.com/repos/roundware/roundware-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/roundware/roundware-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/roundware/roundware-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/roundware/roundware-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/roundware/roundware-server/contents/{+path}","compare_url":"https://api.github.com/repos/roundware/roundware-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roundware/roundware-server/merges","archive_url":"https://api.github.com/repos/roundware/roundware-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roundware/roundware-server/downloads","issues_url":"https://api.github.com/repos/roundware/roundware-server/issues{/number}","pulls_url":"https://api.github.com/repos/roundware/roundware-server/pulls{/number}","milestones_url":"https://api.github.com/repos/roundware/roundware-server/milestones{/number}","notifications_url":"https://api.github.com/repos/roundware/roundware-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roundware/roundware-server/labels{/name}","releases_url":"https://api.github.com/repos/roundware/roundware-server/releases{/id}","deployments_url":"https://api.github.com/repos/roundware/roundware-server/deployments","created_at":"2012-11-02T20:00:40Z","updated_at":"2016-11-21T18:25:33Z","pushed_at":"2017-02-13T02:52:27Z","git_url":"git://github.com/roundware/roundware-server.git","ssh_url":"git@github.com:roundware/roundware-server.git","clone_url":"https://github.com/roundware/roundware-server.git","svn_url":"https://github.com/roundware/roundware-server","homepage":"http://roundware.org","size":13552,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":85,"forks":16,"open_issues":85,"watchers":18,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/roundware/roundware-server/pulls/318"},"html":{"href":"https://github.com/roundware/roundware-server/pull/318"},"issue":{"href":"https://api.github.com/repos/roundware/roundware-server/issues/318"},"comments":{"href":"https://api.github.com/repos/roundware/roundware-server/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/roundware/roundware-server/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/roundware/roundware-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/roundware/roundware-server/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/roundware/roundware-server/statuses/073c70184aff4c544bd9ac9d05d69b5824b8fb6b"}}}}
{"actor":{"display_login":"jslootbeek"}}