{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/136138530","pull_request_review_id":59635590,"id":136138530,"diff_hunk":"@@ -113,6 +121,29 @@ static void store32_little_endian(uint32_t value, unsigned char *buf) {\n   buf[0] = (unsigned char)((value)&0xFF);\n }\n \n+static uint32_t read_frame_size(const grpc_slice_buffer *sb) {\n+  GPR_ASSERT(sb != NULL && sb->length >= TSI_FAKE_FRAME_HEADER_SIZE);\n+  uint8_t frame_size_buffer[TSI_FAKE_FRAME_HEADER_SIZE];\n+  uint8_t *buf = frame_size_buffer;\n+  /* Copies the first 4 bytes to a temporary buffer.  */\n+  size_t i;","path":"src/core/tsi/fake_transport_security.c","position":null,"original_position":33,"commit_id":"cac54bb2e7cde4aeddac1bdd300d9dea837023f0","original_commit_id":"cd405d7270dcc6e6eedca80dbae6831afe88f76f","user":{"login":"jiangtaoli2016","id":19913700,"avatar_url":"https://avatars2.githubusercontent.com/u/19913700?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangtaoli2016","html_url":"https://github.com/jiangtaoli2016","followers_url":"https://api.github.com/users/jiangtaoli2016/followers","following_url":"https://api.github.com/users/jiangtaoli2016/following{/other_user}","gists_url":"https://api.github.com/users/jiangtaoli2016/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangtaoli2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangtaoli2016/subscriptions","organizations_url":"https://api.github.com/users/jiangtaoli2016/orgs","repos_url":"https://api.github.com/users/jiangtaoli2016/repos","events_url":"https://api.github.com/users/jiangtaoli2016/events{/privacy}","received_events_url":"https://api.github.com/users/jiangtaoli2016/received_events","type":"User","site_admin":false},"body":"DONE.","created_at":"2017-08-30T17:35:23Z","updated_at":"2017-08-30T17:36:06Z","html_url":"https://github.com/grpc/grpc/pull/12308#discussion_r136138530","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/12308","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/136138530"},"html":{"href":"https://github.com/grpc/grpc/pull/12308#discussion_r136138530"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/12308"}},"in_reply_to_id":136103376},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/12308","id":138059224,"html_url":"https://github.com/grpc/grpc/pull/12308","diff_url":"https://github.com/grpc/grpc/pull/12308.diff","patch_url":"https://github.com/grpc/grpc/pull/12308.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/12308","number":12308,"state":"open","locked":false,"title":"Fake zero copy protector","user":{"login":"jiangtaoli2016","id":19913700,"avatar_url":"https://avatars2.githubusercontent.com/u/19913700?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangtaoli2016","html_url":"https://github.com/jiangtaoli2016","followers_url":"https://api.github.com/users/jiangtaoli2016/followers","following_url":"https://api.github.com/users/jiangtaoli2016/following{/other_user}","gists_url":"https://api.github.com/users/jiangtaoli2016/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangtaoli2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangtaoli2016/subscriptions","organizations_url":"https://api.github.com/users/jiangtaoli2016/orgs","repos_url":"https://api.github.com/users/jiangtaoli2016/repos","events_url":"https://api.github.com/users/jiangtaoli2016/events{/privacy}","received_events_url":"https://api.github.com/users/jiangtaoli2016/received_events","type":"User","site_admin":false},"body":"This CL implements two items\r\n1. If zero-copy protector exist, secure_endpoint will use zero-copy protector to protect/unprotect\r\n2. Implement zero-copy grpc protector for fake TSI","created_at":"2017-08-28T23:28:31Z","updated_at":"2017-08-30T17:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c535c93cebc1c2000ac275f3e84eb6abba00b698","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/12308/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/12308/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/12308/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/cac54bb2e7cde4aeddac1bdd300d9dea837023f0","head":{"label":"jiangtaoli2016:fake_zero_copy_protector","ref":"fake_zero_copy_protector","sha":"cac54bb2e7cde4aeddac1bdd300d9dea837023f0","user":{"login":"jiangtaoli2016","id":19913700,"avatar_url":"https://avatars2.githubusercontent.com/u/19913700?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangtaoli2016","html_url":"https://github.com/jiangtaoli2016","followers_url":"https://api.github.com/users/jiangtaoli2016/followers","following_url":"https://api.github.com/users/jiangtaoli2016/following{/other_user}","gists_url":"https://api.github.com/users/jiangtaoli2016/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangtaoli2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangtaoli2016/subscriptions","organizations_url":"https://api.github.com/users/jiangtaoli2016/orgs","repos_url":"https://api.github.com/users/jiangtaoli2016/repos","events_url":"https://api.github.com/users/jiangtaoli2016/events{/privacy}","received_events_url":"https://api.github.com/users/jiangtaoli2016/received_events","type":"User","site_admin":false},"repo":{"id":87572969,"name":"grpc","full_name":"jiangtaoli2016/grpc","owner":{"login":"jiangtaoli2016","id":19913700,"avatar_url":"https://avatars2.githubusercontent.com/u/19913700?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangtaoli2016","html_url":"https://github.com/jiangtaoli2016","followers_url":"https://api.github.com/users/jiangtaoli2016/followers","following_url":"https://api.github.com/users/jiangtaoli2016/following{/other_user}","gists_url":"https://api.github.com/users/jiangtaoli2016/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangtaoli2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangtaoli2016/subscriptions","organizations_url":"https://api.github.com/users/jiangtaoli2016/orgs","repos_url":"https://api.github.com/users/jiangtaoli2016/repos","events_url":"https://api.github.com/users/jiangtaoli2016/events{/privacy}","received_events_url":"https://api.github.com/users/jiangtaoli2016/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiangtaoli2016/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/jiangtaoli2016/grpc","forks_url":"https://api.github.com/repos/jiangtaoli2016/grpc/forks","keys_url":"https://api.github.com/repos/jiangtaoli2016/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiangtaoli2016/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiangtaoli2016/grpc/teams","hooks_url":"https://api.github.com/repos/jiangtaoli2016/grpc/hooks","issue_events_url":"https://api.github.com/repos/jiangtaoli2016/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/jiangtaoli2016/grpc/events","assignees_url":"https://api.github.com/repos/jiangtaoli2016/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/jiangtaoli2016/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/jiangtaoli2016/grpc/tags","blobs_url":"https://api.github.com/repos/jiangtaoli2016/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiangtaoli2016/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiangtaoli2016/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiangtaoli2016/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiangtaoli2016/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/jiangtaoli2016/grpc/languages","stargazers_url":"https://api.github.com/repos/jiangtaoli2016/grpc/stargazers","contributors_url":"https://api.github.com/repos/jiangtaoli2016/grpc/contributors","subscribers_url":"https://api.github.com/repos/jiangtaoli2016/grpc/subscribers","subscription_url":"https://api.github.com/repos/jiangtaoli2016/grpc/subscription","commits_url":"https://api.github.com/repos/jiangtaoli2016/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiangtaoli2016/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiangtaoli2016/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiangtaoli2016/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiangtaoli2016/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/jiangtaoli2016/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiangtaoli2016/grpc/merges","archive_url":"https://api.github.com/repos/jiangtaoli2016/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiangtaoli2016/grpc/downloads","issues_url":"https://api.github.com/repos/jiangtaoli2016/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/jiangtaoli2016/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/jiangtaoli2016/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/jiangtaoli2016/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiangtaoli2016/grpc/labels{/name}","releases_url":"https://api.github.com/repos/jiangtaoli2016/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/jiangtaoli2016/grpc/deployments","created_at":"2017-04-07T17:58:28Z","updated_at":"2017-04-07T17:58:42Z","pushed_at":"2017-08-30T17:33:37Z","git_url":"git://github.com/jiangtaoli2016/grpc.git","ssh_url":"git@github.com:jiangtaoli2016/grpc.git","clone_url":"https://github.com/jiangtaoli2016/grpc.git","svn_url":"https://github.com/jiangtaoli2016/grpc","homepage":"","size":129464,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"5646c7463c24ddd04e639ddd35b63db0c0dc06fb","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2017-08-30T15:32:45Z","pushed_at":"2017-08-30T17:33:40Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":133414,"stargazers_count":11109,"watchers_count":11109,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2341,"mirror_url":null,"open_issues_count":1356,"forks":2341,"open_issues":1356,"watchers":11109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/12308"},"html":{"href":"https://github.com/grpc/grpc/pull/12308"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/12308"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/12308/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/12308/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/12308/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/cac54bb2e7cde4aeddac1bdd300d9dea837023f0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jiangtaoli2016"}}