{"action":"created","comment":{"url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments/107328053","pull_request_review_id":28291684,"id":107328053,"diff_hunk":"@@ -20,11 +20,12 @@ import com.intel.analytics.bigdl._\n import com.intel.analytics.bigdl.nn.abstractnn.{AbstractModule, Activity, TensorModule}\n import com.intel.analytics.bigdl.tensor.Tensor\n import com.intel.analytics.bigdl.tensor.TensorNumericMath.TensorNumeric\n-import com.intel.analytics.bigdl.utils.T\n+import com.intel.analytics.bigdl.utils.{T, Table}\n \n import scala.reflect.ClassTag\n \n-class BiRecurrent[T : ClassTag] ()\n+class BiRecurrent[T : ClassTag] (\n+  merge: AbstractModule[Table, Tensor[T], T])","path":"spark/dl/src/main/scala/com/intel/analytics/bigdl/nn/BiRecurrent.scala","position":11,"original_position":11,"commit_id":"aa49cc3d53374719c58181ae167dcb34923698d4","original_commit_id":"aa49cc3d53374719c58181ae167dcb34923698d4","user":{"login":"jason-dai","id":1931082,"avatar_url":"https://avatars0.githubusercontent.com/u/1931082?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-dai","html_url":"https://github.com/jason-dai","followers_url":"https://api.github.com/users/jason-dai/followers","following_url":"https://api.github.com/users/jason-dai/following{/other_user}","gists_url":"https://api.github.com/users/jason-dai/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-dai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-dai/subscriptions","organizations_url":"https://api.github.com/users/jason-dai/orgs","repos_url":"https://api.github.com/users/jason-dai/repos","events_url":"https://api.github.com/users/jason-dai/events{/privacy}","received_events_url":"https://api.github.com/users/jason-dai/received_events","type":"User","site_admin":false},"body":"add a default value?","created_at":"2017-03-22T03:48:35Z","updated_at":"2017-03-22T03:48:35Z","html_url":"https://github.com/intel-analytics/BigDL/pull/639#discussion_r107328053","pull_request_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/639","_links":{"self":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments/107328053"},"html":{"href":"https://github.com/intel-analytics/BigDL/pull/639#discussion_r107328053"},"pull_request":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/639"}}},"pull_request":{"url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/639","id":111918551,"html_url":"https://github.com/intel-analytics/BigDL/pull/639","diff_url":"https://github.com/intel-analytics/BigDL/pull/639.diff","patch_url":"https://github.com/intel-analytics/BigDL/pull/639.patch","issue_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/639","number":639,"state":"open","locked":false,"title":"add Merge Module to the constructor to support multi-layer BiRNN","user":{"login":"JerryYanWan","id":12810691,"avatar_url":"https://avatars0.githubusercontent.com/u/12810691?v=3","gravatar_id":"","url":"https://api.github.com/users/JerryYanWan","html_url":"https://github.com/JerryYanWan","followers_url":"https://api.github.com/users/JerryYanWan/followers","following_url":"https://api.github.com/users/JerryYanWan/following{/other_user}","gists_url":"https://api.github.com/users/JerryYanWan/gists{/gist_id}","starred_url":"https://api.github.com/users/JerryYanWan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JerryYanWan/subscriptions","organizations_url":"https://api.github.com/users/JerryYanWan/orgs","repos_url":"https://api.github.com/users/JerryYanWan/repos","events_url":"https://api.github.com/users/JerryYanWan/events{/privacy}","received_events_url":"https://api.github.com/users/JerryYanWan/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\nadd Merge Module to the constructor to support multi-layer BiRNN\r\n\r\n## How was this patch tested?\r\nUnit Test\r\nTest the correctness by comparing it to Element research's brnn\r\n\r\n\r\n","created_at":"2017-03-22T02:09:44Z","updated_at":"2017-03-22T03:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adea898012f2f6fd9cbe41fc072c4e08101bae51","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/639/commits","review_comments_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/639/comments","review_comment_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/639/comments","statuses_url":"https://api.github.com/repos/intel-analytics/BigDL/statuses/aa49cc3d53374719c58181ae167dcb34923698d4","head":{"label":"JerryYanWan:multilayerBiRNN","ref":"multilayerBiRNN","sha":"aa49cc3d53374719c58181ae167dcb34923698d4","user":{"login":"JerryYanWan","id":12810691,"avatar_url":"https://avatars0.githubusercontent.com/u/12810691?v=3","gravatar_id":"","url":"https://api.github.com/users/JerryYanWan","html_url":"https://github.com/JerryYanWan","followers_url":"https://api.github.com/users/JerryYanWan/followers","following_url":"https://api.github.com/users/JerryYanWan/following{/other_user}","gists_url":"https://api.github.com/users/JerryYanWan/gists{/gist_id}","starred_url":"https://api.github.com/users/JerryYanWan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JerryYanWan/subscriptions","organizations_url":"https://api.github.com/users/JerryYanWan/orgs","repos_url":"https://api.github.com/users/JerryYanWan/repos","events_url":"https://api.github.com/users/JerryYanWan/events{/privacy}","received_events_url":"https://api.github.com/users/JerryYanWan/received_events","type":"User","site_admin":false},"repo":{"id":77734582,"name":"BigDL","full_name":"JerryYanWan/BigDL","owner":{"login":"JerryYanWan","id":12810691,"avatar_url":"https://avatars0.githubusercontent.com/u/12810691?v=3","gravatar_id":"","url":"https://api.github.com/users/JerryYanWan","html_url":"https://github.com/JerryYanWan","followers_url":"https://api.github.com/users/JerryYanWan/followers","following_url":"https://api.github.com/users/JerryYanWan/following{/other_user}","gists_url":"https://api.github.com/users/JerryYanWan/gists{/gist_id}","starred_url":"https://api.github.com/users/JerryYanWan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JerryYanWan/subscriptions","organizations_url":"https://api.github.com/users/JerryYanWan/orgs","repos_url":"https://api.github.com/users/JerryYanWan/repos","events_url":"https://api.github.com/users/JerryYanWan/events{/privacy}","received_events_url":"https://api.github.com/users/JerryYanWan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JerryYanWan/BigDL","description":"BigDL: Distributed Deep learning Library for Apache Spark","fork":true,"url":"https://api.github.com/repos/JerryYanWan/BigDL","forks_url":"https://api.github.com/repos/JerryYanWan/BigDL/forks","keys_url":"https://api.github.com/repos/JerryYanWan/BigDL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JerryYanWan/BigDL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JerryYanWan/BigDL/teams","hooks_url":"https://api.github.com/repos/JerryYanWan/BigDL/hooks","issue_events_url":"https://api.github.com/repos/JerryYanWan/BigDL/issues/events{/number}","events_url":"https://api.github.com/repos/JerryYanWan/BigDL/events","assignees_url":"https://api.github.com/repos/JerryYanWan/BigDL/assignees{/user}","branches_url":"https://api.github.com/repos/JerryYanWan/BigDL/branches{/branch}","tags_url":"https://api.github.com/repos/JerryYanWan/BigDL/tags","blobs_url":"https://api.github.com/repos/JerryYanWan/BigDL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JerryYanWan/BigDL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JerryYanWan/BigDL/git/refs{/sha}","trees_url":"https://api.github.com/repos/JerryYanWan/BigDL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JerryYanWan/BigDL/statuses/{sha}","languages_url":"https://api.github.com/repos/JerryYanWan/BigDL/languages","stargazers_url":"https://api.github.com/repos/JerryYanWan/BigDL/stargazers","contributors_url":"https://api.github.com/repos/JerryYanWan/BigDL/contributors","subscribers_url":"https://api.github.com/repos/JerryYanWan/BigDL/subscribers","subscription_url":"https://api.github.com/repos/JerryYanWan/BigDL/subscription","commits_url":"https://api.github.com/repos/JerryYanWan/BigDL/commits{/sha}","git_commits_url":"https://api.github.com/repos/JerryYanWan/BigDL/git/commits{/sha}","comments_url":"https://api.github.com/repos/JerryYanWan/BigDL/comments{/number}","issue_comment_url":"https://api.github.com/repos/JerryYanWan/BigDL/issues/comments{/number}","contents_url":"https://api.github.com/repos/JerryYanWan/BigDL/contents/{+path}","compare_url":"https://api.github.com/repos/JerryYanWan/BigDL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JerryYanWan/BigDL/merges","archive_url":"https://api.github.com/repos/JerryYanWan/BigDL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JerryYanWan/BigDL/downloads","issues_url":"https://api.github.com/repos/JerryYanWan/BigDL/issues{/number}","pulls_url":"https://api.github.com/repos/JerryYanWan/BigDL/pulls{/number}","milestones_url":"https://api.github.com/repos/JerryYanWan/BigDL/milestones{/number}","notifications_url":"https://api.github.com/repos/JerryYanWan/BigDL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JerryYanWan/BigDL/labels{/name}","releases_url":"https://api.github.com/repos/JerryYanWan/BigDL/releases{/id}","deployments_url":"https://api.github.com/repos/JerryYanWan/BigDL/deployments","created_at":"2016-12-31T09:48:33Z","updated_at":"2016-12-31T09:49:16Z","pushed_at":"2017-03-22T03:45:57Z","git_url":"git://github.com/JerryYanWan/BigDL.git","ssh_url":"git@github.com:JerryYanWan/BigDL.git","clone_url":"https://github.com/JerryYanWan/BigDL.git","svn_url":"https://github.com/JerryYanWan/BigDL","homepage":"","size":10203,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intel-analytics:master","ref":"master","sha":"c421ca38028797f73cea007c48f240a57243e815","user":{"login":"intel-analytics","id":10941215,"avatar_url":"https://avatars0.githubusercontent.com/u/10941215?v=3","gravatar_id":"","url":"https://api.github.com/users/intel-analytics","html_url":"https://github.com/intel-analytics","followers_url":"https://api.github.com/users/intel-analytics/followers","following_url":"https://api.github.com/users/intel-analytics/following{/other_user}","gists_url":"https://api.github.com/users/intel-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-analytics/subscriptions","organizations_url":"https://api.github.com/users/intel-analytics/orgs","repos_url":"https://api.github.com/users/intel-analytics/repos","events_url":"https://api.github.com/users/intel-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/intel-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":66823715,"name":"BigDL","full_name":"intel-analytics/BigDL","owner":{"login":"intel-analytics","id":10941215,"avatar_url":"https://avatars0.githubusercontent.com/u/10941215?v=3","gravatar_id":"","url":"https://api.github.com/users/intel-analytics","html_url":"https://github.com/intel-analytics","followers_url":"https://api.github.com/users/intel-analytics/followers","following_url":"https://api.github.com/users/intel-analytics/following{/other_user}","gists_url":"https://api.github.com/users/intel-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-analytics/subscriptions","organizations_url":"https://api.github.com/users/intel-analytics/orgs","repos_url":"https://api.github.com/users/intel-analytics/repos","events_url":"https://api.github.com/users/intel-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/intel-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel-analytics/BigDL","description":"BigDL: Distributed Deep Learning Library for Apache Spark","fork":false,"url":"https://api.github.com/repos/intel-analytics/BigDL","forks_url":"https://api.github.com/repos/intel-analytics/BigDL/forks","keys_url":"https://api.github.com/repos/intel-analytics/BigDL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel-analytics/BigDL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel-analytics/BigDL/teams","hooks_url":"https://api.github.com/repos/intel-analytics/BigDL/hooks","issue_events_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/events{/number}","events_url":"https://api.github.com/repos/intel-analytics/BigDL/events","assignees_url":"https://api.github.com/repos/intel-analytics/BigDL/assignees{/user}","branches_url":"https://api.github.com/repos/intel-analytics/BigDL/branches{/branch}","tags_url":"https://api.github.com/repos/intel-analytics/BigDL/tags","blobs_url":"https://api.github.com/repos/intel-analytics/BigDL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel-analytics/BigDL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel-analytics/BigDL/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel-analytics/BigDL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel-analytics/BigDL/statuses/{sha}","languages_url":"https://api.github.com/repos/intel-analytics/BigDL/languages","stargazers_url":"https://api.github.com/repos/intel-analytics/BigDL/stargazers","contributors_url":"https://api.github.com/repos/intel-analytics/BigDL/contributors","subscribers_url":"https://api.github.com/repos/intel-analytics/BigDL/subscribers","subscription_url":"https://api.github.com/repos/intel-analytics/BigDL/subscription","commits_url":"https://api.github.com/repos/intel-analytics/BigDL/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel-analytics/BigDL/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel-analytics/BigDL/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel-analytics/BigDL/contents/{+path}","compare_url":"https://api.github.com/repos/intel-analytics/BigDL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel-analytics/BigDL/merges","archive_url":"https://api.github.com/repos/intel-analytics/BigDL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel-analytics/BigDL/downloads","issues_url":"https://api.github.com/repos/intel-analytics/BigDL/issues{/number}","pulls_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls{/number}","milestones_url":"https://api.github.com/repos/intel-analytics/BigDL/milestones{/number}","notifications_url":"https://api.github.com/repos/intel-analytics/BigDL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel-analytics/BigDL/labels{/name}","releases_url":"https://api.github.com/repos/intel-analytics/BigDL/releases{/id}","deployments_url":"https://api.github.com/repos/intel-analytics/BigDL/deployments","created_at":"2016-08-29T07:59:50Z","updated_at":"2017-03-21T12:29:10Z","pushed_at":"2017-03-22T03:07:32Z","git_url":"git://github.com/intel-analytics/BigDL.git","ssh_url":"git@github.com:intel-analytics/BigDL.git","clone_url":"https://github.com/intel-analytics/BigDL.git","svn_url":"https://github.com/intel-analytics/BigDL","homepage":"","size":10060,"stargazers_count":1586,"watchers_count":1586,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"open_issues_count":96,"forks":280,"open_issues":96,"watchers":1586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/639"},"html":{"href":"https://github.com/intel-analytics/BigDL/pull/639"},"issue":{"href":"https://api.github.com/repos/intel-analytics/BigDL/issues/639"},"comments":{"href":"https://api.github.com/repos/intel-analytics/BigDL/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/intel-analytics/BigDL/statuses/aa49cc3d53374719c58181ae167dcb34923698d4"}}}}
{"actor":{"display_login":"jason-dai"}}