{"action":"created","issue":{"url":"https://api.github.com/repos/WebReflection/circular-json/issues/33","repository_url":"https://api.github.com/repos/WebReflection/circular-json","labels_url":"https://api.github.com/repos/WebReflection/circular-json/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/WebReflection/circular-json/issues/33/comments","events_url":"https://api.github.com/repos/WebReflection/circular-json/issues/33/events","html_url":"https://github.com/WebReflection/circular-json/issues/33","id":258981846,"number":33,"title":"The $String = String is unnecessary ","user":{"login":"louisbuchbinder","id":16655975,"avatar_url":"https://avatars3.githubusercontent.com/u/16655975?v=4","gravatar_id":"","url":"https://api.github.com/users/louisbuchbinder","html_url":"https://github.com/louisbuchbinder","followers_url":"https://api.github.com/users/louisbuchbinder/followers","following_url":"https://api.github.com/users/louisbuchbinder/following{/other_user}","gists_url":"https://api.github.com/users/louisbuchbinder/gists{/gist_id}","starred_url":"https://api.github.com/users/louisbuchbinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louisbuchbinder/subscriptions","organizations_url":"https://api.github.com/users/louisbuchbinder/orgs","repos_url":"https://api.github.com/users/louisbuchbinder/repos","events_url":"https://api.github.com/users/louisbuchbinder/events{/privacy}","received_events_url":"https://api.github.com/users/louisbuchbinder/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-09-19T22:18:57Z","updated_at":"2017-09-19T22:47:56Z","closed_at":"2017-09-19T22:24:37Z","author_association":"NONE","body":"Hi I am really happy to have found this module. The next best option is [cycle.js](https://github.com/dscape/cycle) which is using `eval`... \r\n\r\nBut I have a question/comment on the code. Please direct your attention to https://github.com/WebReflection/circular-json/blob/master/src/circular-json.js#L20-L22 and https://github.com/WebReflection/circular-json/blob/master/src/circular-json.js#L97-L100\r\n\r\nIt seems the assignment of `String` to `$String` is a bit awkward, as referenced by the comment. Then the only usage is L99 and L131. L131 can be replaced with `String` directly and L99 is not necessary because `value.slice(1)` creates a new string anyway because strings are literals in js. \r\n\r\nHope this helps. Not an issue per se, but was definitely a stumbling point for me when reading the code."},"comment":{"url":"https://api.github.com/repos/WebReflection/circular-json/issues/comments/330695297","html_url":"https://github.com/WebReflection/circular-json/issues/33#issuecomment-330695297","issue_url":"https://api.github.com/repos/WebReflection/circular-json/issues/33","id":330695297,"user":{"login":"louisbuchbinder","id":16655975,"avatar_url":"https://avatars3.githubusercontent.com/u/16655975?v=4","gravatar_id":"","url":"https://api.github.com/users/louisbuchbinder","html_url":"https://github.com/louisbuchbinder","followers_url":"https://api.github.com/users/louisbuchbinder/followers","following_url":"https://api.github.com/users/louisbuchbinder/following{/other_user}","gists_url":"https://api.github.com/users/louisbuchbinder/gists{/gist_id}","starred_url":"https://api.github.com/users/louisbuchbinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louisbuchbinder/subscriptions","organizations_url":"https://api.github.com/users/louisbuchbinder/orgs","repos_url":"https://api.github.com/users/louisbuchbinder/repos","events_url":"https://api.github.com/users/louisbuchbinder/events{/privacy}","received_events_url":"https://api.github.com/users/louisbuchbinder/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T22:47:56Z","updated_at":"2017-09-19T22:47:56Z","author_association":"NONE","body":"yes I am playing with exactly that now"}}
{"actor":{"display_login":"louisbuchbinder"}}