{"action":"created","comment":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/comments/128013115","pull_request_review_id":50652561,"id":128013115,"diff_hunk":"@@ -118,15 +119,21 @@ export default Component.extend({\n \n   init () {\n     this._super(...arguments)\n-    this.attrs.dispatch({\n+    this.dispatch({\n       type: 'REGISTER_AXIS'\n     })\n   },\n \n-  didInsertElement () {\n-    this._super(...arguments)\n-    run.scheduleOnce('afterRender', this, this._dispatchRenderedAxis)\n-  }\n-\n   // == Actions ===============================================================\n+  actions: {\n+    _dispatchTickRendered (action) {","path":"addon/components/frost-chart-y-axis.js","position":36,"original_position":36,"commit_id":"9ac4c90002f9165b9edf2f0c921feb064c16ca82","original_commit_id":"9ac4c90002f9165b9edf2f0c921feb064c16ca82","user":{"login":"quincyle","id":14845784,"avatar_url":"https://avatars2.githubusercontent.com/u/14845784?v=4","gravatar_id":"","url":"https://api.github.com/users/quincyle","html_url":"https://github.com/quincyle","followers_url":"https://api.github.com/users/quincyle/followers","following_url":"https://api.github.com/users/quincyle/following{/other_user}","gists_url":"https://api.github.com/users/quincyle/gists{/gist_id}","starred_url":"https://api.github.com/users/quincyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quincyle/subscriptions","organizations_url":"https://api.github.com/users/quincyle/orgs","repos_url":"https://api.github.com/users/quincyle/repos","events_url":"https://api.github.com/users/quincyle/events{/privacy}","received_events_url":"https://api.github.com/users/quincyle/received_events","type":"User","site_admin":false},"body":"I personally like the conversion so it's very simple to distinguish what's internal state/methods and what's being exposed. ","created_at":"2017-07-18T15:38:01Z","updated_at":"2017-07-18T15:38:01Z","html_url":"https://github.com/ciena-frost/ember-frost-chart/pull/22#discussion_r128013115","pull_request_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/comments/128013115"},"html":{"href":"https://github.com/ciena-frost/ember-frost-chart/pull/22#discussion_r128013115"},"pull_request":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/22","id":129960771,"html_url":"https://github.com/ciena-frost/ember-frost-chart/pull/22","diff_url":"https://github.com/ciena-frost/ember-frost-chart/pull/22.diff","patch_url":"https://github.com/ciena-frost/ember-frost-chart/pull/22.patch","issue_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/22","number":22,"state":"open","locked":false,"title":"Upgrade to `ember-cli@2.12.3`","user":{"login":"dafortin","id":18552536,"avatar_url":"https://avatars1.githubusercontent.com/u/18552536?v=4","gravatar_id":"","url":"https://api.github.com/users/dafortin","html_url":"https://github.com/dafortin","followers_url":"https://api.github.com/users/dafortin/followers","following_url":"https://api.github.com/users/dafortin/following{/other_user}","gists_url":"https://api.github.com/users/dafortin/gists{/gist_id}","starred_url":"https://api.github.com/users/dafortin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dafortin/subscriptions","organizations_url":"https://api.github.com/users/dafortin/orgs","repos_url":"https://api.github.com/users/dafortin/repos","events_url":"https://api.github.com/users/dafortin/events{/privacy}","received_events_url":"https://api.github.com/users/dafortin/received_events","type":"User","site_admin":false},"body":"### This project uses [semver](semver.org), please check the scope of this pr:\r\n\r\n- [ ] #none# - documentation fixes and/or test additions\r\n- [x] #patch# - backwards-compatible bug fix\r\n- [ ] #minor# - adding functionality in a backwards-compatible manner\r\n- [ ] #major# - incompatible API change\r\n\r\n# CHANGELOG\r\n* **Upgrade** to `ember-cli@2.12.3`","created_at":"2017-07-11T17:15:00Z","updated_at":"2017-07-18T15:38:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f41526427df3156a54073c5a63d57820fc703eb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/22/commits","review_comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/22/comments","review_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/22/comments","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/statuses/9ac4c90002f9165b9edf2f0c921feb064c16ca82","head":{"label":"dafortin:master","ref":"master","sha":"9ac4c90002f9165b9edf2f0c921feb064c16ca82","user":{"login":"dafortin","id":18552536,"avatar_url":"https://avatars1.githubusercontent.com/u/18552536?v=4","gravatar_id":"","url":"https://api.github.com/users/dafortin","html_url":"https://github.com/dafortin","followers_url":"https://api.github.com/users/dafortin/followers","following_url":"https://api.github.com/users/dafortin/following{/other_user}","gists_url":"https://api.github.com/users/dafortin/gists{/gist_id}","starred_url":"https://api.github.com/users/dafortin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dafortin/subscriptions","organizations_url":"https://api.github.com/users/dafortin/orgs","repos_url":"https://api.github.com/users/dafortin/repos","events_url":"https://api.github.com/users/dafortin/events{/privacy}","received_events_url":"https://api.github.com/users/dafortin/received_events","type":"User","site_admin":false},"repo":{"id":90871633,"name":"ember-frost-chart","full_name":"dafortin/ember-frost-chart","owner":{"login":"dafortin","id":18552536,"avatar_url":"https://avatars1.githubusercontent.com/u/18552536?v=4","gravatar_id":"","url":"https://api.github.com/users/dafortin","html_url":"https://github.com/dafortin","followers_url":"https://api.github.com/users/dafortin/followers","following_url":"https://api.github.com/users/dafortin/following{/other_user}","gists_url":"https://api.github.com/users/dafortin/gists{/gist_id}","starred_url":"https://api.github.com/users/dafortin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dafortin/subscriptions","organizations_url":"https://api.github.com/users/dafortin/orgs","repos_url":"https://api.github.com/users/dafortin/repos","events_url":"https://api.github.com/users/dafortin/events{/privacy}","received_events_url":"https://api.github.com/users/dafortin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dafortin/ember-frost-chart","description":"Composable charts with decoupled axes / plots and some extra pizzazz","fork":true,"url":"https://api.github.com/repos/dafortin/ember-frost-chart","forks_url":"https://api.github.com/repos/dafortin/ember-frost-chart/forks","keys_url":"https://api.github.com/repos/dafortin/ember-frost-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dafortin/ember-frost-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dafortin/ember-frost-chart/teams","hooks_url":"https://api.github.com/repos/dafortin/ember-frost-chart/hooks","issue_events_url":"https://api.github.com/repos/dafortin/ember-frost-chart/issues/events{/number}","events_url":"https://api.github.com/repos/dafortin/ember-frost-chart/events","assignees_url":"https://api.github.com/repos/dafortin/ember-frost-chart/assignees{/user}","branches_url":"https://api.github.com/repos/dafortin/ember-frost-chart/branches{/branch}","tags_url":"https://api.github.com/repos/dafortin/ember-frost-chart/tags","blobs_url":"https://api.github.com/repos/dafortin/ember-frost-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dafortin/ember-frost-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dafortin/ember-frost-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/dafortin/ember-frost-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dafortin/ember-frost-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/dafortin/ember-frost-chart/languages","stargazers_url":"https://api.github.com/repos/dafortin/ember-frost-chart/stargazers","contributors_url":"https://api.github.com/repos/dafortin/ember-frost-chart/contributors","subscribers_url":"https://api.github.com/repos/dafortin/ember-frost-chart/subscribers","subscription_url":"https://api.github.com/repos/dafortin/ember-frost-chart/subscription","commits_url":"https://api.github.com/repos/dafortin/ember-frost-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/dafortin/ember-frost-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/dafortin/ember-frost-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/dafortin/ember-frost-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/dafortin/ember-frost-chart/contents/{+path}","compare_url":"https://api.github.com/repos/dafortin/ember-frost-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dafortin/ember-frost-chart/merges","archive_url":"https://api.github.com/repos/dafortin/ember-frost-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dafortin/ember-frost-chart/downloads","issues_url":"https://api.github.com/repos/dafortin/ember-frost-chart/issues{/number}","pulls_url":"https://api.github.com/repos/dafortin/ember-frost-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/dafortin/ember-frost-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/dafortin/ember-frost-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dafortin/ember-frost-chart/labels{/name}","releases_url":"https://api.github.com/repos/dafortin/ember-frost-chart/releases{/id}","deployments_url":"https://api.github.com/repos/dafortin/ember-frost-chart/deployments","created_at":"2017-05-10T14:09:46Z","updated_at":"2017-05-10T14:09:47Z","pushed_at":"2017-07-12T13:16:43Z","git_url":"git://github.com/dafortin/ember-frost-chart.git","ssh_url":"git@github.com:dafortin/ember-frost-chart.git","clone_url":"https://github.com/dafortin/ember-frost-chart.git","svn_url":"https://github.com/dafortin/ember-frost-chart","homepage":null,"size":125,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ciena-frost:master","ref":"master","sha":"abf7ce2d4896ab40adb8960c3b8329951ce0081a","user":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars2.githubusercontent.com/u/16601148?v=4","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"repo":{"id":86949493,"name":"ember-frost-chart","full_name":"ciena-frost/ember-frost-chart","owner":{"login":"ciena-frost","id":16601148,"avatar_url":"https://avatars2.githubusercontent.com/u/16601148?v=4","gravatar_id":"","url":"https://api.github.com/users/ciena-frost","html_url":"https://github.com/ciena-frost","followers_url":"https://api.github.com/users/ciena-frost/followers","following_url":"https://api.github.com/users/ciena-frost/following{/other_user}","gists_url":"https://api.github.com/users/ciena-frost/gists{/gist_id}","starred_url":"https://api.github.com/users/ciena-frost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciena-frost/subscriptions","organizations_url":"https://api.github.com/users/ciena-frost/orgs","repos_url":"https://api.github.com/users/ciena-frost/repos","events_url":"https://api.github.com/users/ciena-frost/events{/privacy}","received_events_url":"https://api.github.com/users/ciena-frost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ciena-frost/ember-frost-chart","description":"Composable charts with decoupled axes / plots and some extra pizzazz","fork":false,"url":"https://api.github.com/repos/ciena-frost/ember-frost-chart","forks_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/forks","keys_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/teams","hooks_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/hooks","issue_events_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/events{/number}","events_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/events","assignees_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/assignees{/user}","branches_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/branches{/branch}","tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/tags","blobs_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/languages","stargazers_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/stargazers","contributors_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/contributors","subscribers_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/subscribers","subscription_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/subscription","commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/contents/{+path}","compare_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/merges","archive_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/downloads","issues_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues{/number}","pulls_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/labels{/name}","releases_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/releases{/id}","deployments_url":"https://api.github.com/repos/ciena-frost/ember-frost-chart/deployments","created_at":"2017-04-01T23:35:40Z","updated_at":"2017-07-05T17:36:52Z","pushed_at":"2017-07-12T13:16:44Z","git_url":"git://github.com/ciena-frost/ember-frost-chart.git","ssh_url":"git@github.com:ciena-frost/ember-frost-chart.git","clone_url":"https://github.com/ciena-frost/ember-frost-chart.git","svn_url":"https://github.com/ciena-frost/ember-frost-chart","homepage":"http://ciena-frost.github.io/ember-frost-chart","size":1151,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":7,"forks":8,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/22"},"html":{"href":"https://github.com/ciena-frost/ember-frost-chart/pull/22"},"issue":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/22"},"comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/ciena-frost/ember-frost-chart/statuses/9ac4c90002f9165b9edf2f0c921feb064c16ca82"}}}}
{"actor":{"display_login":"quincyle"}}