{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3922","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3922/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3922/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3922/events","html_url":"https://github.com/fish-shell/fish-shell/pull/3922","id":217854602,"number":3922,"title":"Also give subshells the terminal","user":{"login":"faho","id":5185367,"avatar_url":"https://avatars0.githubusercontent.com/u/5185367?v=3","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"labels":[{"id":4724776,"url":"https://api.github.com/repos/fish-shell/fish-shell/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/16","html_url":"https://github.com/fish-shell/fish-shell/milestone/16","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/16/labels","id":2146982,"number":16,"title":"2.6.0","description":"The next minor release (2.6.0)","creator":{"login":"faho","id":5185367,"avatar_url":"https://avatars0.githubusercontent.com/u/5185367?v=3","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":108,"state":"open","created_at":"2016-11-20T22:01:32Z","updated_at":"2017-03-29T21:57:02Z","due_on":"2017-04-23T07:00:00Z","closed_at":null},"comments":4,"created_at":"2017-03-29T12:08:19Z","updated_at":"2017-03-30T10:38:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fish-shell/fish-shell/pulls/3922","html_url":"https://github.com/fish-shell/fish-shell/pull/3922","diff_url":"https://github.com/fish-shell/fish-shell/pull/3922.diff","patch_url":"https://github.com/fish-shell/fish-shell/pull/3922.patch"},"body":"## Description\r\n\r\nIt turns out the reason `fzf` et al don't work in command substitutions (for some reason known as \"subshells\" in this part of the code) is that we don't give them the JOB_TERMINAL flag, which means we don't hand control of the terminal to their process group.\r\n\r\nThis is likely to need more testing.\r\n\r\nThings I've tested so far:\r\n\r\n- `echo -s x(git branch | fzf | string trim)x` (which would previously hang)\r\n\r\n- `echo (cat)` (which would print a newline and leave a stopped cat)\r\n\r\nAlso `sudo` and `percol`.\r\n\r\nFixes issue #1362.\r\n\r\n## TODOs:\r\n<!-- Just check off what what we know been done so far. We can help you with this stuff. -->\r\n- [N/A] Changes to fish usage are reflected in user documentation/manpages.\r\n- [ ] Tests have been added for regressions fixed\r\n- [ ] User-visible changes noted in CHANGELOG.md\r\n"},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/290372881","html_url":"https://github.com/fish-shell/fish-shell/pull/3922#issuecomment-290372881","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/3922","id":290372881,"user":{"login":"faho","id":5185367,"avatar_url":"https://avatars0.githubusercontent.com/u/5185367?v=3","gravatar_id":"","url":"https://api.github.com/users/faho","html_url":"https://github.com/faho","followers_url":"https://api.github.com/users/faho/followers","following_url":"https://api.github.com/users/faho/following{/other_user}","gists_url":"https://api.github.com/users/faho/gists{/gist_id}","starred_url":"https://api.github.com/users/faho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faho/subscriptions","organizations_url":"https://api.github.com/users/faho/orgs","repos_url":"https://api.github.com/users/faho/repos","events_url":"https://api.github.com/users/faho/events{/privacy}","received_events_url":"https://api.github.com/users/faho/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T10:38:16Z","updated_at":"2017-03-30T10:38:16Z","body":">May I however add that it does not solve the issue with pipes, for example with sudo netstat -tnpa | grep sshd. Should I file a different issue ?\r\n\r\nNo, that's #206."}}
{"actor":{"display_login":"faho"}}