{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/132727661","pull_request_review_id":55843314,"id":132727661,"diff_hunk":"@@ -692,22 +695,56 @@ internal nfloat GetEstimatedRowHeight(UITableView table)\n \t\t\t\treturn CalculateHeightForCell(table, firstCell);\n \t\t\t}\n \n-\t\t\tpublic override nfloat EstimatedHeight(UITableView tableView, NSIndexPath indexPath)","path":"Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs","position":140,"original_position":140,"commit_id":"403ba2bd69430ffd988c8730274eba93e29d02a4","original_commit_id":"403ba2bd69430ffd988c8730274eba93e29d02a4","user":{"login":"kingces95","id":4120386,"avatar_url":"https://avatars1.githubusercontent.com/u/4120386?v=4","gravatar_id":"","url":"https://api.github.com/users/kingces95","html_url":"https://github.com/kingces95","followers_url":"https://api.github.com/users/kingces95/followers","following_url":"https://api.github.com/users/kingces95/following{/other_user}","gists_url":"https://api.github.com/users/kingces95/gists{/gist_id}","starred_url":"https://api.github.com/users/kingces95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingces95/subscriptions","organizations_url":"https://api.github.com/users/kingces95/orgs","repos_url":"https://api.github.com/users/kingces95/repos","events_url":"https://api.github.com/users/kingces95/events{/privacy}","received_events_url":"https://api.github.com/users/kingces95/received_events","type":"User","site_admin":false},"body":"Hopefully, by caching prototypical cells, we can compute heights fast enough so we don't need to async generate actual/estimated heights. Seems to work on the test case. ","created_at":"2017-08-11T16:24:09Z","updated_at":"2017-08-11T16:24:09Z","html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1085#discussion_r132727661","pull_request_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1085","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments/132727661"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/1085#discussion_r132727661"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1085"}}},"pull_request":{"url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1085","id":134084115,"html_url":"https://github.com/xamarin/Xamarin.Forms/pull/1085","diff_url":"https://github.com/xamarin/Xamarin.Forms/pull/1085.diff","patch_url":"https://github.com/xamarin/Xamarin.Forms/pull/1085.patch","issue_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1085","number":1085,"state":"open","locked":false,"title":"Add ListViewCachingStrategy.RecycleElementAndDataTemplate","user":{"login":"kingces95","id":4120386,"avatar_url":"https://avatars1.githubusercontent.com/u/4120386?v=4","gravatar_id":"","url":"https://api.github.com/users/kingces95","html_url":"https://github.com/kingces95","followers_url":"https://api.github.com/users/kingces95/followers","following_url":"https://api.github.com/users/kingces95/following{/other_user}","gists_url":"https://api.github.com/users/kingces95/gists{/gist_id}","starred_url":"https://api.github.com/users/kingces95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingces95/subscriptions","organizations_url":"https://api.github.com/users/kingces95/orgs","repos_url":"https://api.github.com/users/kingces95/repos","events_url":"https://api.github.com/users/kingces95/events{/privacy}","received_events_url":"https://api.github.com/users/kingces95/received_events","type":"User","site_admin":false},"body":"### Description of Change ###\r\n\r\nReduce ListView DataTemplate dynamism to enable caching DataTemplate by the type of the item in the ItemsSource. This in turn allows caching prototypical cells by the item type which are used under the hood to pre-compute height of a cell before scrolling on screen. \r\n\r\n### Bugs Fixed ###\r\n\r\nhttps://bugzilla.xamarin.com/show_bug.cgi?id=52487\r\n\r\n### API Changes ###\r\n\r\nAdded ListViewCachingStrategy.RecycleElementAndDataTemplate. When set OnSelectTemplate will be called once per item _type_ instead of once per _instance_. Consequently, a DataTemplate should be selected solely based on an items type and not any of it's data. Furthermore, the DataTemplate must be activated using the ctor that takes a Type.\r\n\r\n### Behavioral Changes ###\r\n\r\nListView activates only as many cells as are visible on screen. Finally. \r\n\r\n### PR Checklist ###\r\n\r\nTODO: Commented out some code to fix other issues which may need to be added back if they're not fixed by this PR. \r\n\r\n- [ ] Has tests (if omitted, state reason in description)\r\n- [ ] Rebased on top of master at time of PR\r\n- [ ] Changes adhere to coding standard\r\n- [ ] Consolidate commits as makes sense\r\n","created_at":"2017-08-04T03:27:50Z","updated_at":"2017-08-11T16:24:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a17bdde7334ad6923bf11670448c3605cf80a1a7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1085/commits","review_comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1085/comments","review_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1085/comments","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/403ba2bd69430ffd988c8730274eba93e29d02a4","head":{"label":"xamarin:52487","ref":"52487","sha":"403ba2bd69430ffd988c8730274eba93e29d02a4","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2017-08-11T08:38:03Z","pushed_at":"2017-08-11T16:02:03Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":24579,"stargazers_count":1514,"watchers_count":1514,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":644,"mirror_url":null,"open_issues_count":62,"forks":644,"open_issues":62,"watchers":1514,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"ec10a37ff125fd920616649ec9ffde2f51d77a37","user":{"login":"xamarin","id":790012,"avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":54213490,"name":"Xamarin.Forms","full_name":"xamarin/Xamarin.Forms","owner":{"login":"xamarin","id":790012,"avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/Xamarin.Forms","description":"Xamarin.Forms official home","fork":false,"url":"https://api.github.com/repos/xamarin/Xamarin.Forms","forks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/forks","keys_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/teams","hooks_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/events","assignees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/tags","blobs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/languages","stargazers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/subscription","commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/merges","archive_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/downloads","issues_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Xamarin.Forms/deployments","created_at":"2016-03-18T15:52:03Z","updated_at":"2017-08-11T08:38:03Z","pushed_at":"2017-08-11T16:02:03Z","git_url":"git://github.com/xamarin/Xamarin.Forms.git","ssh_url":"git@github.com:xamarin/Xamarin.Forms.git","clone_url":"https://github.com/xamarin/Xamarin.Forms.git","svn_url":"https://github.com/xamarin/Xamarin.Forms","homepage":"https://xamarin.com/forms","size":24579,"stargazers_count":1514,"watchers_count":1514,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":644,"mirror_url":null,"open_issues_count":62,"forks":644,"open_issues":62,"watchers":1514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1085"},"html":{"href":"https://github.com/xamarin/Xamarin.Forms/pull/1085"},"issue":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1085"},"comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/issues/1085/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1085/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/pulls/1085/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Xamarin.Forms/statuses/403ba2bd69430ffd988c8730274eba93e29d02a4"}}}}
{"actor":{"display_login":"kingces95"}}