{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vcpkg/issues/1861","repository_url":"https://api.github.com/repos/Microsoft/vcpkg","labels_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/1861/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/1861/comments","events_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/1861/events","html_url":"https://github.com/Microsoft/vcpkg/pull/1861","id":259989823,"number":1861,"title":"[shapelib] initial port","user":{"login":"alex85k","id":4124648,"avatar_url":"https://avatars2.githubusercontent.com/u/4124648?v=4","gravatar_id":"","url":"https://api.github.com/users/alex85k","html_url":"https://github.com/alex85k","followers_url":"https://api.github.com/users/alex85k/followers","following_url":"https://api.github.com/users/alex85k/following{/other_user}","gists_url":"https://api.github.com/users/alex85k/gists{/gist_id}","starred_url":"https://api.github.com/users/alex85k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex85k/subscriptions","organizations_url":"https://api.github.com/users/alex85k/orgs","repos_url":"https://api.github.com/users/alex85k/repos","events_url":"https://api.github.com/users/alex85k/events{/privacy}","received_events_url":"https://api.github.com/users/alex85k/received_events","type":"User","site_admin":false},"labels":[{"id":446354983,"url":"https://api.github.com/repos/Microsoft/vcpkg/labels/cla-signed","name":"cla-signed","color":"207de5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-23T07:23:03Z","updated_at":"2017-09-24T09:31:20Z","closed_at":"2017-09-24T09:31:16Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Microsoft/vcpkg/pulls/1861","html_url":"https://github.com/Microsoft/vcpkg/pull/1861","diff_url":"https://github.com/Microsoft/vcpkg/pull/1861.diff","patch_url":"https://github.com/Microsoft/vcpkg/pull/1861.patch"},"body":"I propose to add Shapelib package to this great libraries collection.\r\nhttp://shapelib.maptools.org\r\nIt is widely used in GIS application, can provide aditional format for GDAL etc.\r\n\r\nThis is my first PR here so the code may need checking (have some experience in CMake though not profsessional, helped with Windows support and build scripts fo several OpenStreetMap related projects). If sucessful, can provide packages for `spatialite`, `readosm`, `freexl`, 'sparsehash`, update `geos` and `gdal`,\r\n\r\n\r\nPossible issue: some small executables for processing shapefiles are included in tools. Are they to be removed? Is there a way to add extra option allowing to pack them if user needs?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vcpkg/issues/comments/331698363","html_url":"https://github.com/Microsoft/vcpkg/pull/1861#issuecomment-331698363","issue_url":"https://api.github.com/repos/Microsoft/vcpkg/issues/1861","id":331698363,"user":{"login":"alexkaratarakis","id":128712,"avatar_url":"https://avatars1.githubusercontent.com/u/128712?v=4","gravatar_id":"","url":"https://api.github.com/users/alexkaratarakis","html_url":"https://github.com/alexkaratarakis","followers_url":"https://api.github.com/users/alexkaratarakis/followers","following_url":"https://api.github.com/users/alexkaratarakis/following{/other_user}","gists_url":"https://api.github.com/users/alexkaratarakis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexkaratarakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexkaratarakis/subscriptions","organizations_url":"https://api.github.com/users/alexkaratarakis/orgs","repos_url":"https://api.github.com/users/alexkaratarakis/repos","events_url":"https://api.github.com/users/alexkaratarakis/events{/privacy}","received_events_url":"https://api.github.com/users/alexkaratarakis/received_events","type":"User","site_admin":false},"created_at":"2017-09-24T09:31:20Z","updated_at":"2017-09-24T09:31:20Z","author_association":"MEMBER","body":"Thanks for the PR! Looks good to me.\r\n\r\n> Possible issue: some small executables for processing shapefiles are included in tools. Are they to be removed?\r\n\r\nIf the exes are necessary/useful, you can keep them and place them in the `tools\\` subfolder (as you already do). \r\n\r\n> Is there a way to add extra option allowing to pack them if user needs?\r\n\r\nNot sure what you mean by \"pack\" here. Can you elaborate?\r\nIf you mean `vcpkg export`, the `tools\\` folder is included in the exported files. "}}
{"actor":{"display_login":"alexkaratarakis"}}