{"action":"created","issue":{"url":"https://api.github.com/repos/istio/mixer/issues/392","repository_url":"https://api.github.com/repos/istio/mixer","labels_url":"https://api.github.com/repos/istio/mixer/issues/392/labels{/name}","comments_url":"https://api.github.com/repos/istio/mixer/issues/392/comments","events_url":"https://api.github.com/repos/istio/mixer/issues/392/events","html_url":"https://github.com/istio/mixer/pull/392","id":214709958,"number":392,"title":"Improve expr performance","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars1.githubusercontent.com/u/800375?v=3","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"labels":[{"id":491317866,"url":"https://api.github.com/repos/istio/mixer/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2017-03-16T13:49:27Z","updated_at":"2017-03-22T00:02:55Z","closed_at":"2017-03-21T23:49:44Z","pull_request":{"url":"https://api.github.com/repos/istio/mixer/pulls/392","html_url":"https://github.com/istio/mixer/pull/392","diff_url":"https://github.com/istio/mixer/pull/392.diff","patch_url":"https://github.com/istio/mixer/pull/392.patch"},"body":"initial perf: 1600 ns/op\r\nnew: 450 ns/op\r\n\r\nUse unmanaged functions.\r\n  Previously framework was doing a lot of common work and giving\r\n  elementary types to Funcs, but it was not performant.\r\n  Now writing a func is more involved, but it is more performant.\r\n  Now funcs receive []*Expression\r\n\r\nconvert all existing funcs to unmanaged.\r\n\r\nIssues with managed funcs:\r\n1. involved creating a lot of objects. Could be resolved by using a pool of slices,\r\n   but now removed the need for it.\r\n2. Short circuit functions are easier with unmanaged.  { A && B && C } should return false if A is false and not evaluate B and C.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/istio/mixer/392)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/istio/mixer/issues/comments/288257516","html_url":"https://github.com/istio/mixer/pull/392#issuecomment-288257516","issue_url":"https://api.github.com/repos/istio/mixer/issues/392","id":288257516,"user":{"login":"istio-testing","id":25311884,"avatar_url":"https://avatars2.githubusercontent.com/u/25311884?v=3","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2017-03-22T00:02:55Z","updated_at":"2017-03-22T00:02:55Z","body":"Jenkins job manager/mixer-pr passed"}}
{"actor":{"display_login":"istio-testing"}}