{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/156588489","pull_request_review_id":83088988,"id":156588489,"diff_hunk":"@@ -221,6 +221,8 @@ public void setConfigPatternMatcher(ConfigPatternMatcher configPatternMatcher) {\n      * @param name property name\n      * @return property value\n      * @see #setProperty(String, String)\n+     * @see <a href=\"http://docs.hazelcast.org/docs/latest/manual/html-single/index.html#system-properties\">","path":"hazelcast/src/main/java/com/hazelcast/config/Config.java","position":4,"original_position":4,"commit_id":"b58a65b41f3125447be593615397a22e1f4226ef","original_commit_id":"b58a65b41f3125447be593615397a22e1f4226ef","user":{"login":"ahmetmircik","id":2960360,"avatar_url":"https://avatars2.githubusercontent.com/u/2960360?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmetmircik","html_url":"https://github.com/ahmetmircik","followers_url":"https://api.github.com/users/ahmetmircik/followers","following_url":"https://api.github.com/users/ahmetmircik/following{/other_user}","gists_url":"https://api.github.com/users/ahmetmircik/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmetmircik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmetmircik/subscriptions","organizations_url":"https://api.github.com/users/ahmetmircik/orgs","repos_url":"https://api.github.com/users/ahmetmircik/repos","events_url":"https://api.github.com/users/ahmetmircik/events{/privacy}","received_events_url":"https://api.github.com/users/ahmetmircik/received_events","type":"User","site_admin":false},"body":"Seems this can be misleading in time, valid properties can be different between versions. A version agnostic link may fit better. But this PR is a step forward.","created_at":"2017-12-13T08:22:32Z","updated_at":"2017-12-13T08:22:33Z","html_url":"https://github.com/hazelcast/hazelcast/pull/11971#discussion_r156588489","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11971","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/156588489"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/11971#discussion_r156588489"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11971"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11971","id":157897217,"html_url":"https://github.com/hazelcast/hazelcast/pull/11971","diff_url":"https://github.com/hazelcast/hazelcast/pull/11971.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/11971.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/11971","number":11971,"state":"open","locked":false,"title":"Die tabs die","user":{"login":"dbrimley","id":1588244,"avatar_url":"https://avatars1.githubusercontent.com/u/1588244?v=4","gravatar_id":"","url":"https://api.github.com/users/dbrimley","html_url":"https://github.com/dbrimley","followers_url":"https://api.github.com/users/dbrimley/followers","following_url":"https://api.github.com/users/dbrimley/following{/other_user}","gists_url":"https://api.github.com/users/dbrimley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrimley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrimley/subscriptions","organizations_url":"https://api.github.com/users/dbrimley/orgs","repos_url":"https://api.github.com/users/dbrimley/repos","events_url":"https://api.github.com/users/dbrimley/events{/privacy}","received_events_url":"https://api.github.com/users/dbrimley/received_events","type":"User","site_admin":false},"body":"Some tabs made their way in the hazelcast-default.xml, only noticed when I pulled in the default xml into ASCIIDOC for the new Coherence migration guide and the formatting was off.","created_at":"2017-12-12T17:54:47Z","updated_at":"2017-12-13T08:22:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0717b160f9b764fad57bc14979443c77fa704a5b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jerrinot","id":158619,"avatar_url":"https://avatars1.githubusercontent.com/u/158619?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11971/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11971/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/11971/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/b58a65b41f3125447be593615397a22e1f4226ef","head":{"label":"dbrimley:die-tabs-die","ref":"die-tabs-die","sha":"b58a65b41f3125447be593615397a22e1f4226ef","user":{"login":"dbrimley","id":1588244,"avatar_url":"https://avatars1.githubusercontent.com/u/1588244?v=4","gravatar_id":"","url":"https://api.github.com/users/dbrimley","html_url":"https://github.com/dbrimley","followers_url":"https://api.github.com/users/dbrimley/followers","following_url":"https://api.github.com/users/dbrimley/following{/other_user}","gists_url":"https://api.github.com/users/dbrimley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrimley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrimley/subscriptions","organizations_url":"https://api.github.com/users/dbrimley/orgs","repos_url":"https://api.github.com/users/dbrimley/repos","events_url":"https://api.github.com/users/dbrimley/events{/privacy}","received_events_url":"https://api.github.com/users/dbrimley/received_events","type":"User","site_admin":false},"repo":{"id":45253360,"name":"hazelcast","full_name":"dbrimley/hazelcast","owner":{"login":"dbrimley","id":1588244,"avatar_url":"https://avatars1.githubusercontent.com/u/1588244?v=4","gravatar_id":"","url":"https://api.github.com/users/dbrimley","html_url":"https://github.com/dbrimley","followers_url":"https://api.github.com/users/dbrimley/followers","following_url":"https://api.github.com/users/dbrimley/following{/other_user}","gists_url":"https://api.github.com/users/dbrimley/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrimley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrimley/subscriptions","organizations_url":"https://api.github.com/users/dbrimley/orgs","repos_url":"https://api.github.com/users/dbrimley/repos","events_url":"https://api.github.com/users/dbrimley/events{/privacy}","received_events_url":"https://api.github.com/users/dbrimley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbrimley/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/dbrimley/hazelcast","forks_url":"https://api.github.com/repos/dbrimley/hazelcast/forks","keys_url":"https://api.github.com/repos/dbrimley/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbrimley/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbrimley/hazelcast/teams","hooks_url":"https://api.github.com/repos/dbrimley/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/dbrimley/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/dbrimley/hazelcast/events","assignees_url":"https://api.github.com/repos/dbrimley/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/dbrimley/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/dbrimley/hazelcast/tags","blobs_url":"https://api.github.com/repos/dbrimley/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbrimley/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbrimley/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbrimley/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbrimley/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/dbrimley/hazelcast/languages","stargazers_url":"https://api.github.com/repos/dbrimley/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/dbrimley/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/dbrimley/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/dbrimley/hazelcast/subscription","commits_url":"https://api.github.com/repos/dbrimley/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbrimley/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbrimley/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbrimley/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbrimley/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/dbrimley/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbrimley/hazelcast/merges","archive_url":"https://api.github.com/repos/dbrimley/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbrimley/hazelcast/downloads","issues_url":"https://api.github.com/repos/dbrimley/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/dbrimley/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/dbrimley/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/dbrimley/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbrimley/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/dbrimley/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/dbrimley/hazelcast/deployments","created_at":"2015-10-30T13:45:05Z","updated_at":"2017-02-23T12:42:09Z","pushed_at":"2017-12-12T17:52:08Z","git_url":"git://github.com/dbrimley/hazelcast.git","ssh_url":"git@github.com:dbrimley/hazelcast.git","clone_url":"https://github.com/dbrimley/hazelcast.git","svn_url":"https://github.com/dbrimley/hazelcast","homepage":"www.hazelcast.com","size":117681,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"44045949b683b958e4e245040b65f947f143a9ef","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2017-12-13T06:45:27Z","pushed_at":"2017-12-12T22:51:12Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"http://www.hazelcast.org","size":118734,"stargazers_count":2338,"watchers_count":2338,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":961,"mirror_url":null,"archived":false,"open_issues_count":678,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":961,"open_issues":678,"watchers":2338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11971"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/11971"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/11971"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/11971/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11971/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11971/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/b58a65b41f3125447be593615397a22e1f4226ef"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ahmetmircik"}}