{"action":"opened","number":2028,"pull_request":{"url":"https://api.github.com/repos/domoticz/domoticz/pulls/2028","id":160488547,"html_url":"https://github.com/domoticz/domoticz/pull/2028","diff_url":"https://github.com/domoticz/domoticz/pull/2028.diff","patch_url":"https://github.com/domoticz/domoticz/pull/2028.patch","issue_url":"https://api.github.com/repos/domoticz/domoticz/issues/2028","number":2028,"state":"open","locked":false,"title":"Blocky (Eventsystem) memory leak fix","user":{"login":"Siewert308SW","id":25230393,"avatar_url":"https://avatars0.githubusercontent.com/u/25230393?v=4","gravatar_id":"","url":"https://api.github.com/users/Siewert308SW","html_url":"https://github.com/Siewert308SW","followers_url":"https://api.github.com/users/Siewert308SW/followers","following_url":"https://api.github.com/users/Siewert308SW/following{/other_user}","gists_url":"https://api.github.com/users/Siewert308SW/gists{/gist_id}","starred_url":"https://api.github.com/users/Siewert308SW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siewert308SW/subscriptions","organizations_url":"https://api.github.com/users/Siewert308SW/orgs","repos_url":"https://api.github.com/users/Siewert308SW/repos","events_url":"https://api.github.com/users/Siewert308SW/events{/privacy}","received_events_url":"https://api.github.com/users/Siewert308SW/received_events","type":"User","site_admin":false},"body":"This should fix Blockly (eventsystem) memory leak as reported here: https://github.com/domoticz/domoticz/issues/2000\r\n\r\nOriginal fix was by @jvandenbroek on the 24th july 2017 https://github.com/domoticz/domoticz/pull/1714/commits/c8ec141f3b998ba5ef811074cd2214a677b2a51d\r\nBut according to @gizmocuz his advice the check for allocation was put back as discussed here: https://github.com/domoticz/domoticz/pull/1714\r\nDon't know the reason for that but we still had memory leak.\r\n\r\nAfter a couple of days testing with my pull request the leak seems to be fixed.\r\nVmem stays stable instead if increasing insanely as before the fix.\r\nAs mentioned here https://github.com/domoticz/domoticz/issues/2000 i put my production system to the test.\r\nWhich stays stable and all eventsystems (blocky, lua, python) worked like charm.\r\n\r\np.s\r\nDon't know if it's related but could it be that the python plugin system is affected by this fix also.\r\nAs before the my pull request some plugins after a reboot had a error like (hardware stopped)\r\nAfter the pull request i didn't see any of them.","created_at":"2017-12-29T08:44:40Z","updated_at":"2017-12-29T08:44:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/domoticz/domoticz/pulls/2028/commits","review_comments_url":"https://api.github.com/repos/domoticz/domoticz/pulls/2028/comments","review_comment_url":"https://api.github.com/repos/domoticz/domoticz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/domoticz/domoticz/issues/2028/comments","statuses_url":"https://api.github.com/repos/domoticz/domoticz/statuses/4a34eb02e11395bef78fe03d706d3ae56a596c89","head":{"label":"Siewert308SW:development","ref":"development","sha":"4a34eb02e11395bef78fe03d706d3ae56a596c89","user":{"login":"Siewert308SW","id":25230393,"avatar_url":"https://avatars0.githubusercontent.com/u/25230393?v=4","gravatar_id":"","url":"https://api.github.com/users/Siewert308SW","html_url":"https://github.com/Siewert308SW","followers_url":"https://api.github.com/users/Siewert308SW/followers","following_url":"https://api.github.com/users/Siewert308SW/following{/other_user}","gists_url":"https://api.github.com/users/Siewert308SW/gists{/gist_id}","starred_url":"https://api.github.com/users/Siewert308SW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siewert308SW/subscriptions","organizations_url":"https://api.github.com/users/Siewert308SW/orgs","repos_url":"https://api.github.com/users/Siewert308SW/repos","events_url":"https://api.github.com/users/Siewert308SW/events{/privacy}","received_events_url":"https://api.github.com/users/Siewert308SW/received_events","type":"User","site_admin":false},"repo":{"id":114791006,"name":"domoticz","full_name":"Siewert308SW/domoticz","owner":{"login":"Siewert308SW","id":25230393,"avatar_url":"https://avatars0.githubusercontent.com/u/25230393?v=4","gravatar_id":"","url":"https://api.github.com/users/Siewert308SW","html_url":"https://github.com/Siewert308SW","followers_url":"https://api.github.com/users/Siewert308SW/followers","following_url":"https://api.github.com/users/Siewert308SW/following{/other_user}","gists_url":"https://api.github.com/users/Siewert308SW/gists{/gist_id}","starred_url":"https://api.github.com/users/Siewert308SW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siewert308SW/subscriptions","organizations_url":"https://api.github.com/users/Siewert308SW/orgs","repos_url":"https://api.github.com/users/Siewert308SW/repos","events_url":"https://api.github.com/users/Siewert308SW/events{/privacy}","received_events_url":"https://api.github.com/users/Siewert308SW/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Siewert308SW/domoticz","description":"Open source Home Automation System","fork":true,"url":"https://api.github.com/repos/Siewert308SW/domoticz","forks_url":"https://api.github.com/repos/Siewert308SW/domoticz/forks","keys_url":"https://api.github.com/repos/Siewert308SW/domoticz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Siewert308SW/domoticz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Siewert308SW/domoticz/teams","hooks_url":"https://api.github.com/repos/Siewert308SW/domoticz/hooks","issue_events_url":"https://api.github.com/repos/Siewert308SW/domoticz/issues/events{/number}","events_url":"https://api.github.com/repos/Siewert308SW/domoticz/events","assignees_url":"https://api.github.com/repos/Siewert308SW/domoticz/assignees{/user}","branches_url":"https://api.github.com/repos/Siewert308SW/domoticz/branches{/branch}","tags_url":"https://api.github.com/repos/Siewert308SW/domoticz/tags","blobs_url":"https://api.github.com/repos/Siewert308SW/domoticz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Siewert308SW/domoticz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Siewert308SW/domoticz/git/refs{/sha}","trees_url":"https://api.github.com/repos/Siewert308SW/domoticz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Siewert308SW/domoticz/statuses/{sha}","languages_url":"https://api.github.com/repos/Siewert308SW/domoticz/languages","stargazers_url":"https://api.github.com/repos/Siewert308SW/domoticz/stargazers","contributors_url":"https://api.github.com/repos/Siewert308SW/domoticz/contributors","subscribers_url":"https://api.github.com/repos/Siewert308SW/domoticz/subscribers","subscription_url":"https://api.github.com/repos/Siewert308SW/domoticz/subscription","commits_url":"https://api.github.com/repos/Siewert308SW/domoticz/commits{/sha}","git_commits_url":"https://api.github.com/repos/Siewert308SW/domoticz/git/commits{/sha}","comments_url":"https://api.github.com/repos/Siewert308SW/domoticz/comments{/number}","issue_comment_url":"https://api.github.com/repos/Siewert308SW/domoticz/issues/comments{/number}","contents_url":"https://api.github.com/repos/Siewert308SW/domoticz/contents/{+path}","compare_url":"https://api.github.com/repos/Siewert308SW/domoticz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Siewert308SW/domoticz/merges","archive_url":"https://api.github.com/repos/Siewert308SW/domoticz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Siewert308SW/domoticz/downloads","issues_url":"https://api.github.com/repos/Siewert308SW/domoticz/issues{/number}","pulls_url":"https://api.github.com/repos/Siewert308SW/domoticz/pulls{/number}","milestones_url":"https://api.github.com/repos/Siewert308SW/domoticz/milestones{/number}","notifications_url":"https://api.github.com/repos/Siewert308SW/domoticz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Siewert308SW/domoticz/labels{/name}","releases_url":"https://api.github.com/repos/Siewert308SW/domoticz/releases{/id}","deployments_url":"https://api.github.com/repos/Siewert308SW/domoticz/deployments","created_at":"2017-12-19T17:07:02Z","updated_at":"2017-12-19T17:07:10Z","pushed_at":"2017-12-29T08:28:23Z","git_url":"git://github.com/Siewert308SW/domoticz.git","ssh_url":"git@github.com:Siewert308SW/domoticz.git","clone_url":"https://github.com/Siewert308SW/domoticz.git","svn_url":"https://github.com/Siewert308SW/domoticz","homepage":"http://www.domoticz.com","size":201454,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"domoticz:development","ref":"development","sha":"2d99bbbc80b717eecc83cf1edf7b4f619f025135","user":{"login":"domoticz","id":6067010,"avatar_url":"https://avatars2.githubusercontent.com/u/6067010?v=4","gravatar_id":"","url":"https://api.github.com/users/domoticz","html_url":"https://github.com/domoticz","followers_url":"https://api.github.com/users/domoticz/followers","following_url":"https://api.github.com/users/domoticz/following{/other_user}","gists_url":"https://api.github.com/users/domoticz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoticz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoticz/subscriptions","organizations_url":"https://api.github.com/users/domoticz/orgs","repos_url":"https://api.github.com/users/domoticz/repos","events_url":"https://api.github.com/users/domoticz/events{/privacy}","received_events_url":"https://api.github.com/users/domoticz/received_events","type":"Organization","site_admin":false},"repo":{"id":40759227,"name":"domoticz","full_name":"domoticz/domoticz","owner":{"login":"domoticz","id":6067010,"avatar_url":"https://avatars2.githubusercontent.com/u/6067010?v=4","gravatar_id":"","url":"https://api.github.com/users/domoticz","html_url":"https://github.com/domoticz","followers_url":"https://api.github.com/users/domoticz/followers","following_url":"https://api.github.com/users/domoticz/following{/other_user}","gists_url":"https://api.github.com/users/domoticz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoticz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoticz/subscriptions","organizations_url":"https://api.github.com/users/domoticz/orgs","repos_url":"https://api.github.com/users/domoticz/repos","events_url":"https://api.github.com/users/domoticz/events{/privacy}","received_events_url":"https://api.github.com/users/domoticz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/domoticz/domoticz","description":"Open source Home Automation System","fork":false,"url":"https://api.github.com/repos/domoticz/domoticz","forks_url":"https://api.github.com/repos/domoticz/domoticz/forks","keys_url":"https://api.github.com/repos/domoticz/domoticz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domoticz/domoticz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domoticz/domoticz/teams","hooks_url":"https://api.github.com/repos/domoticz/domoticz/hooks","issue_events_url":"https://api.github.com/repos/domoticz/domoticz/issues/events{/number}","events_url":"https://api.github.com/repos/domoticz/domoticz/events","assignees_url":"https://api.github.com/repos/domoticz/domoticz/assignees{/user}","branches_url":"https://api.github.com/repos/domoticz/domoticz/branches{/branch}","tags_url":"https://api.github.com/repos/domoticz/domoticz/tags","blobs_url":"https://api.github.com/repos/domoticz/domoticz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domoticz/domoticz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domoticz/domoticz/git/refs{/sha}","trees_url":"https://api.github.com/repos/domoticz/domoticz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domoticz/domoticz/statuses/{sha}","languages_url":"https://api.github.com/repos/domoticz/domoticz/languages","stargazers_url":"https://api.github.com/repos/domoticz/domoticz/stargazers","contributors_url":"https://api.github.com/repos/domoticz/domoticz/contributors","subscribers_url":"https://api.github.com/repos/domoticz/domoticz/subscribers","subscription_url":"https://api.github.com/repos/domoticz/domoticz/subscription","commits_url":"https://api.github.com/repos/domoticz/domoticz/commits{/sha}","git_commits_url":"https://api.github.com/repos/domoticz/domoticz/git/commits{/sha}","comments_url":"https://api.github.com/repos/domoticz/domoticz/comments{/number}","issue_comment_url":"https://api.github.com/repos/domoticz/domoticz/issues/comments{/number}","contents_url":"https://api.github.com/repos/domoticz/domoticz/contents/{+path}","compare_url":"https://api.github.com/repos/domoticz/domoticz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domoticz/domoticz/merges","archive_url":"https://api.github.com/repos/domoticz/domoticz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domoticz/domoticz/downloads","issues_url":"https://api.github.com/repos/domoticz/domoticz/issues{/number}","pulls_url":"https://api.github.com/repos/domoticz/domoticz/pulls{/number}","milestones_url":"https://api.github.com/repos/domoticz/domoticz/milestones{/number}","notifications_url":"https://api.github.com/repos/domoticz/domoticz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domoticz/domoticz/labels{/name}","releases_url":"https://api.github.com/repos/domoticz/domoticz/releases{/id}","deployments_url":"https://api.github.com/repos/domoticz/domoticz/deployments","created_at":"2015-08-15T12:49:39Z","updated_at":"2017-12-29T00:37:32Z","pushed_at":"2017-12-28T21:52:03Z","git_url":"git://github.com/domoticz/domoticz.git","ssh_url":"git@github.com:domoticz/domoticz.git","clone_url":"https://github.com/domoticz/domoticz.git","svn_url":"https://github.com/domoticz/domoticz","homepage":"http://www.domoticz.com","size":331511,"stargazers_count":1003,"watchers_count":1003,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":554,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":554,"open_issues":73,"watchers":1003,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/2028"},"html":{"href":"https://github.com/domoticz/domoticz/pull/2028"},"issue":{"href":"https://api.github.com/repos/domoticz/domoticz/issues/2028"},"comments":{"href":"https://api.github.com/repos/domoticz/domoticz/issues/2028/comments"},"review_comments":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/2028/comments"},"review_comment":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/2028/commits"},"statuses":{"href":"https://api.github.com/repos/domoticz/domoticz/statuses/4a34eb02e11395bef78fe03d706d3ae56a596c89"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":0,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Siewert308SW"}}