{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/143716425","pull_request_review_id":68266975,"id":143716425,"diff_hunk":"@@ -145,18 +145,18 @@ ROOT_BUILD_OPTION(python3 OFF \"Python 3 ROOT bindings, requires python >= 3.1\")\n ROOT_BUILD_OPTION(qt OFF \"Qt graphics backend, requires libqt >= 4.8\")\n ROOT_BUILD_OPTION(qtgsi OFF \"GSI's Qt integration, requires libqt >= 4.8\")\n ROOT_BUILD_OPTION(r OFF \"R ROOT bindings, requires R, Rcpp and RInside\")\n-ROOT_BUILD_OPTION(rfio ON \"RFIO support, requires libshift from CASTOR >= 1.5.2\")\n+ROOT_BUILD_OPTION(rfio OFF \"RFIO support, requires libshift from CASTOR >= 1.5.2\")\n ROOT_BUILD_OPTION(roofit OFF \"Build the libRooFit advanced fitting package\")\n ROOT_BUILD_OPTION(root7 OFF \"Build the ROOT 7 interface prototype, requires >= cxx14\")\n ROOT_BUILD_OPTION(rpath OFF \"Set run-time library load path on executables and shared libraries (at installation area)\")\n ROOT_BUILD_OPTION(ruby OFF \"Ruby ROOT bindings, requires ruby >= 1.8\")\n ROOT_BUILD_OPTION(runtime_cxxmodules OFF \"Enable runtime support for C++ modules.\")\n-ROOT_BUILD_OPTION(sapdb ON \"MaxDB/SapDB support, requires libsqlod and libsqlrte\")\n+ROOT_BUILD_OPTION(sapdb OFF \"MaxDB/SapDB support, requires libsqlod and libsqlrte\")\n ROOT_BUILD_OPTION(shadowpw ON \"Shadow password support\")\n ROOT_BUILD_OPTION(shared ON \"Use shared 3rd party libraries if possible\")\n ROOT_BUILD_OPTION(soversion OFF \"Set version number in sonames (recommended)\")","path":"cmake/modules/RootBuildOptions.cmake","position":82,"original_position":82,"commit_id":"b2491f9299aa53498634a9c550085849125b54ba","original_commit_id":"b2491f9299aa53498634a9c550085849125b54ba","user":{"login":"amadio","id":249404,"avatar_url":"https://avatars2.githubusercontent.com/u/249404?v=4","gravatar_id":"","url":"https://api.github.com/users/amadio","html_url":"https://github.com/amadio","followers_url":"https://api.github.com/users/amadio/followers","following_url":"https://api.github.com/users/amadio/following{/other_user}","gists_url":"https://api.github.com/users/amadio/gists{/gist_id}","starred_url":"https://api.github.com/users/amadio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amadio/subscriptions","organizations_url":"https://api.github.com/users/amadio/orgs","repos_url":"https://api.github.com/users/amadio/repos","events_url":"https://api.github.com/users/amadio/events{/privacy}","received_events_url":"https://api.github.com/users/amadio/received_events","type":"User","site_admin":false},"body":"Fair enough, this can be changed after the release. One nice thing is that it would help to find out when people link against one version of ROOT then try to run with another. This would make that fail, which is good, since ROOT isn't compatible across versions.","created_at":"2017-10-10T12:49:36Z","updated_at":"2017-10-10T12:49:36Z","html_url":"https://github.com/root-project/root/pull/1167#discussion_r143716425","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/1167","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/143716425"},"html":{"href":"https://github.com/root-project/root/pull/1167#discussion_r143716425"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/1167"}},"in_reply_to_id":143708861},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/1167","id":145673038,"html_url":"https://github.com/root-project/root/pull/1167","diff_url":"https://github.com/root-project/root/pull/1167.diff","patch_url":"https://github.com/root-project/root/pull/1167.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/1167","number":1167,"state":"open","locked":false,"title":"An haircut for the default components built for ROOT","user":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"body":"Do not build niche components by default, enable http server since it is used for json serialisation, notebooks and elsewhere.","created_at":"2017-10-10T12:05:01Z","updated_at":"2017-10-10T12:49:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cb0fe6c9f5628facce3040c895e3d847fbf5642","assignee":null,"assignees":[],"requested_reviewers":[{"login":"peremato","id":6952498,"avatar_url":"https://avatars2.githubusercontent.com/u/6952498?v=4","gravatar_id":"","url":"https://api.github.com/users/peremato","html_url":"https://github.com/peremato","followers_url":"https://api.github.com/users/peremato/followers","following_url":"https://api.github.com/users/peremato/following{/other_user}","gists_url":"https://api.github.com/users/peremato/gists{/gist_id}","starred_url":"https://api.github.com/users/peremato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peremato/subscriptions","organizations_url":"https://api.github.com/users/peremato/orgs","repos_url":"https://api.github.com/users/peremato/repos","events_url":"https://api.github.com/users/peremato/events{/privacy}","received_events_url":"https://api.github.com/users/peremato/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/1167/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/1167/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/1167/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/b2491f9299aa53498634a9c550085849125b54ba","head":{"label":"dpiparo:disableByDefault","ref":"disableByDefault","sha":"b2491f9299aa53498634a9c550085849125b54ba","user":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"repo":{"id":88480268,"name":"root","full_name":"dpiparo/root","owner":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpiparo/root","description":"The official ROOT repository","fork":true,"url":"https://api.github.com/repos/dpiparo/root","forks_url":"https://api.github.com/repos/dpiparo/root/forks","keys_url":"https://api.github.com/repos/dpiparo/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpiparo/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpiparo/root/teams","hooks_url":"https://api.github.com/repos/dpiparo/root/hooks","issue_events_url":"https://api.github.com/repos/dpiparo/root/issues/events{/number}","events_url":"https://api.github.com/repos/dpiparo/root/events","assignees_url":"https://api.github.com/repos/dpiparo/root/assignees{/user}","branches_url":"https://api.github.com/repos/dpiparo/root/branches{/branch}","tags_url":"https://api.github.com/repos/dpiparo/root/tags","blobs_url":"https://api.github.com/repos/dpiparo/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpiparo/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpiparo/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpiparo/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpiparo/root/statuses/{sha}","languages_url":"https://api.github.com/repos/dpiparo/root/languages","stargazers_url":"https://api.github.com/repos/dpiparo/root/stargazers","contributors_url":"https://api.github.com/repos/dpiparo/root/contributors","subscribers_url":"https://api.github.com/repos/dpiparo/root/subscribers","subscription_url":"https://api.github.com/repos/dpiparo/root/subscription","commits_url":"https://api.github.com/repos/dpiparo/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpiparo/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpiparo/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpiparo/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpiparo/root/contents/{+path}","compare_url":"https://api.github.com/repos/dpiparo/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpiparo/root/merges","archive_url":"https://api.github.com/repos/dpiparo/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpiparo/root/downloads","issues_url":"https://api.github.com/repos/dpiparo/root/issues{/number}","pulls_url":"https://api.github.com/repos/dpiparo/root/pulls{/number}","milestones_url":"https://api.github.com/repos/dpiparo/root/milestones{/number}","notifications_url":"https://api.github.com/repos/dpiparo/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpiparo/root/labels{/name}","releases_url":"https://api.github.com/repos/dpiparo/root/releases{/id}","deployments_url":"https://api.github.com/repos/dpiparo/root/deployments","created_at":"2017-04-17T06:48:51Z","updated_at":"2017-04-17T06:49:54Z","pushed_at":"2017-10-10T12:02:50Z","git_url":"git://github.com/dpiparo/root.git","ssh_url":"git@github.com:dpiparo/root.git","clone_url":"https://github.com/dpiparo/root.git","svn_url":"https://github.com/dpiparo/root","homepage":"","size":663123,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"b85edb7e5890733ce82ca37d0439db076623ffb6","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official ROOT repository","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2017-10-09T12:02:29Z","pushed_at":"2017-10-10T12:37:36Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"","size":663416,"stargazers_count":410,"watchers_count":410,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":301,"mirror_url":null,"open_issues_count":48,"forks":301,"open_issues":48,"watchers":410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/1167"},"html":{"href":"https://github.com/root-project/root/pull/1167"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/1167"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/1167/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/1167/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/1167/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/b2491f9299aa53498634a9c550085849125b54ba"}},"author_association":"OWNER"}}
{"actor":{"display_login":"amadio"}}