{"action":"created","comment":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/comments/132722919","pull_request_review_id":55838253,"id":132722919,"diff_hunk":"@@ -239,23 +236,17 @@ def multiply(s, pub, usehex, rawpub=True):\n     of the scalar s.\n     ('raw' options passed in)\n     '''\n-    newpub = secp256k1.PublicKey(pub, raw=rawpub, ctx=ctx)\n-    #see note to \"tweak_mul\" function in podle.py\n-    res = secp256k1._tweak_public(newpub,\n-                                   secp256k1.lib.secp256k1_ec_pubkey_tweak_mul,\n-                                   s)\n-    return res.serialize()\n+    res = coincurve.PublicKey(pub)\n+    res.multiply(s, update=True)","path":"bitcoin/secp256k1_main.py","position":34,"original_position":34,"commit_id":"bb93d144bceea3e06b2a5da16b988b104e6cc8ea","original_commit_id":"bb93d144bceea3e06b2a5da16b988b104e6cc8ea","user":{"login":"ofek","id":9677399,"avatar_url":"https://avatars1.githubusercontent.com/u/9677399?v=4","gravatar_id":"","url":"https://api.github.com/users/ofek","html_url":"https://github.com/ofek","followers_url":"https://api.github.com/users/ofek/followers","following_url":"https://api.github.com/users/ofek/following{/other_user}","gists_url":"https://api.github.com/users/ofek/gists{/gist_id}","starred_url":"https://api.github.com/users/ofek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofek/subscriptions","organizations_url":"https://api.github.com/users/ofek/orgs","repos_url":"https://api.github.com/users/ofek/repos","events_url":"https://api.github.com/users/ofek/events{/privacy}","received_events_url":"https://api.github.com/users/ofek/received_events","type":"User","site_admin":false},"body":"Both versions here are functionally equivalent. The difference is the new version doesn't require a temporary variable.","created_at":"2017-08-11T16:03:45Z","updated_at":"2017-08-11T16:03:45Z","html_url":"https://github.com/JoinMarket-Org/joinmarket/pull/749#discussion_r132722919","pull_request_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/749","_links":{"self":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/comments/132722919"},"html":{"href":"https://github.com/JoinMarket-Org/joinmarket/pull/749#discussion_r132722919"},"pull_request":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/749"}}},"pull_request":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/749","id":134982408,"html_url":"https://github.com/JoinMarket-Org/joinmarket/pull/749","diff_url":"https://github.com/JoinMarket-Org/joinmarket/pull/749.diff","patch_url":"https://github.com/JoinMarket-Org/joinmarket/pull/749.patch","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/749","number":749,"state":"open","locked":false,"title":"change from secp256k1-py to coincurve","user":{"login":"mb300sd","id":1869901,"avatar_url":"https://avatars1.githubusercontent.com/u/1869901?v=4","gravatar_id":"","url":"https://api.github.com/users/mb300sd","html_url":"https://github.com/mb300sd","followers_url":"https://api.github.com/users/mb300sd/followers","following_url":"https://api.github.com/users/mb300sd/following{/other_user}","gists_url":"https://api.github.com/users/mb300sd/gists{/gist_id}","starred_url":"https://api.github.com/users/mb300sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mb300sd/subscriptions","organizations_url":"https://api.github.com/users/mb300sd/orgs","repos_url":"https://api.github.com/users/mb300sd/repos","events_url":"https://api.github.com/users/mb300sd/events{/privacy}","received_events_url":"https://api.github.com/users/mb300sd/received_events","type":"User","site_admin":false},"body":"Switching from the no longer maintained secp256k1-py library to coincurve.\r\n\r\nRemoves the hacks for Windows compatibility and enable donations on Windows. (untested)\r\n\r\n#728 ","created_at":"2017-08-09T20:26:43Z","updated_at":"2017-08-11T16:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71459598853e6decc9b9d97d4b6998c04057e26a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/749/commits","review_comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/749/comments","review_comment_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/749/comments","statuses_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/statuses/bb93d144bceea3e06b2a5da16b988b104e6cc8ea","head":{"label":"mb300sd:coincurve","ref":"coincurve","sha":"bb93d144bceea3e06b2a5da16b988b104e6cc8ea","user":{"login":"mb300sd","id":1869901,"avatar_url":"https://avatars1.githubusercontent.com/u/1869901?v=4","gravatar_id":"","url":"https://api.github.com/users/mb300sd","html_url":"https://github.com/mb300sd","followers_url":"https://api.github.com/users/mb300sd/followers","following_url":"https://api.github.com/users/mb300sd/following{/other_user}","gists_url":"https://api.github.com/users/mb300sd/gists{/gist_id}","starred_url":"https://api.github.com/users/mb300sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mb300sd/subscriptions","organizations_url":"https://api.github.com/users/mb300sd/orgs","repos_url":"https://api.github.com/users/mb300sd/repos","events_url":"https://api.github.com/users/mb300sd/events{/privacy}","received_events_url":"https://api.github.com/users/mb300sd/received_events","type":"User","site_admin":false},"repo":{"id":99729573,"name":"joinmarket","full_name":"mb300sd/joinmarket","owner":{"login":"mb300sd","id":1869901,"avatar_url":"https://avatars1.githubusercontent.com/u/1869901?v=4","gravatar_id":"","url":"https://api.github.com/users/mb300sd","html_url":"https://github.com/mb300sd","followers_url":"https://api.github.com/users/mb300sd/followers","following_url":"https://api.github.com/users/mb300sd/following{/other_user}","gists_url":"https://api.github.com/users/mb300sd/gists{/gist_id}","starred_url":"https://api.github.com/users/mb300sd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mb300sd/subscriptions","organizations_url":"https://api.github.com/users/mb300sd/orgs","repos_url":"https://api.github.com/users/mb300sd/repos","events_url":"https://api.github.com/users/mb300sd/events{/privacy}","received_events_url":"https://api.github.com/users/mb300sd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mb300sd/joinmarket","description":"CoinJoin implementation with incentive structure to convince people to take part","fork":true,"url":"https://api.github.com/repos/mb300sd/joinmarket","forks_url":"https://api.github.com/repos/mb300sd/joinmarket/forks","keys_url":"https://api.github.com/repos/mb300sd/joinmarket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mb300sd/joinmarket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mb300sd/joinmarket/teams","hooks_url":"https://api.github.com/repos/mb300sd/joinmarket/hooks","issue_events_url":"https://api.github.com/repos/mb300sd/joinmarket/issues/events{/number}","events_url":"https://api.github.com/repos/mb300sd/joinmarket/events","assignees_url":"https://api.github.com/repos/mb300sd/joinmarket/assignees{/user}","branches_url":"https://api.github.com/repos/mb300sd/joinmarket/branches{/branch}","tags_url":"https://api.github.com/repos/mb300sd/joinmarket/tags","blobs_url":"https://api.github.com/repos/mb300sd/joinmarket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mb300sd/joinmarket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mb300sd/joinmarket/git/refs{/sha}","trees_url":"https://api.github.com/repos/mb300sd/joinmarket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mb300sd/joinmarket/statuses/{sha}","languages_url":"https://api.github.com/repos/mb300sd/joinmarket/languages","stargazers_url":"https://api.github.com/repos/mb300sd/joinmarket/stargazers","contributors_url":"https://api.github.com/repos/mb300sd/joinmarket/contributors","subscribers_url":"https://api.github.com/repos/mb300sd/joinmarket/subscribers","subscription_url":"https://api.github.com/repos/mb300sd/joinmarket/subscription","commits_url":"https://api.github.com/repos/mb300sd/joinmarket/commits{/sha}","git_commits_url":"https://api.github.com/repos/mb300sd/joinmarket/git/commits{/sha}","comments_url":"https://api.github.com/repos/mb300sd/joinmarket/comments{/number}","issue_comment_url":"https://api.github.com/repos/mb300sd/joinmarket/issues/comments{/number}","contents_url":"https://api.github.com/repos/mb300sd/joinmarket/contents/{+path}","compare_url":"https://api.github.com/repos/mb300sd/joinmarket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mb300sd/joinmarket/merges","archive_url":"https://api.github.com/repos/mb300sd/joinmarket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mb300sd/joinmarket/downloads","issues_url":"https://api.github.com/repos/mb300sd/joinmarket/issues{/number}","pulls_url":"https://api.github.com/repos/mb300sd/joinmarket/pulls{/number}","milestones_url":"https://api.github.com/repos/mb300sd/joinmarket/milestones{/number}","notifications_url":"https://api.github.com/repos/mb300sd/joinmarket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mb300sd/joinmarket/labels{/name}","releases_url":"https://api.github.com/repos/mb300sd/joinmarket/releases{/id}","deployments_url":"https://api.github.com/repos/mb300sd/joinmarket/deployments","created_at":"2017-08-08T19:38:50Z","updated_at":"2017-08-08T19:38:52Z","pushed_at":"2017-08-10T02:11:37Z","git_url":"git://github.com/mb300sd/joinmarket.git","ssh_url":"git@github.com:mb300sd/joinmarket.git","clone_url":"https://github.com/mb300sd/joinmarket.git","svn_url":"https://github.com/mb300sd/joinmarket","homepage":"","size":2471,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JoinMarket-Org:develop","ref":"develop","sha":"61f5179ff31c6775220de3f5a790b0e7a6c5321c","user":{"login":"JoinMarket-Org","id":16105296,"avatar_url":"https://avatars3.githubusercontent.com/u/16105296?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinMarket-Org","html_url":"https://github.com/JoinMarket-Org","followers_url":"https://api.github.com/users/JoinMarket-Org/followers","following_url":"https://api.github.com/users/JoinMarket-Org/following{/other_user}","gists_url":"https://api.github.com/users/JoinMarket-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinMarket-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinMarket-Org/subscriptions","organizations_url":"https://api.github.com/users/JoinMarket-Org/orgs","repos_url":"https://api.github.com/users/JoinMarket-Org/repos","events_url":"https://api.github.com/users/JoinMarket-Org/events{/privacy}","received_events_url":"https://api.github.com/users/JoinMarket-Org/received_events","type":"Organization","site_admin":false},"repo":{"id":27746301,"name":"joinmarket","full_name":"JoinMarket-Org/joinmarket","owner":{"login":"JoinMarket-Org","id":16105296,"avatar_url":"https://avatars3.githubusercontent.com/u/16105296?v=4","gravatar_id":"","url":"https://api.github.com/users/JoinMarket-Org","html_url":"https://github.com/JoinMarket-Org","followers_url":"https://api.github.com/users/JoinMarket-Org/followers","following_url":"https://api.github.com/users/JoinMarket-Org/following{/other_user}","gists_url":"https://api.github.com/users/JoinMarket-Org/gists{/gist_id}","starred_url":"https://api.github.com/users/JoinMarket-Org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoinMarket-Org/subscriptions","organizations_url":"https://api.github.com/users/JoinMarket-Org/orgs","repos_url":"https://api.github.com/users/JoinMarket-Org/repos","events_url":"https://api.github.com/users/JoinMarket-Org/events{/privacy}","received_events_url":"https://api.github.com/users/JoinMarket-Org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JoinMarket-Org/joinmarket","description":"CoinJoin implementation with incentive structure to convince people to take part","fork":false,"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket","forks_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/forks","keys_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/teams","hooks_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/hooks","issue_events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/events{/number}","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/events","assignees_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/assignees{/user}","branches_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/branches{/branch}","tags_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/tags","blobs_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/statuses/{sha}","languages_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/languages","stargazers_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/stargazers","contributors_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/contributors","subscribers_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/subscribers","subscription_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/subscription","commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/contents/{+path}","compare_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/merges","archive_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/downloads","issues_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues{/number}","pulls_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls{/number}","milestones_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/milestones{/number}","notifications_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/labels{/name}","releases_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/releases{/id}","deployments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/deployments","created_at":"2014-12-09T02:44:35Z","updated_at":"2017-07-29T22:45:57Z","pushed_at":"2017-08-11T10:33:25Z","git_url":"git://github.com/JoinMarket-Org/joinmarket.git","ssh_url":"git@github.com:JoinMarket-Org/joinmarket.git","clone_url":"https://github.com/JoinMarket-Org/joinmarket.git","svn_url":"https://github.com/JoinMarket-Org/joinmarket","homepage":"","size":2471,"stargazers_count":280,"watchers_count":280,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":221,"forks":97,"open_issues":221,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/749"},"html":{"href":"https://github.com/JoinMarket-Org/joinmarket/pull/749"},"issue":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/749"},"comments":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/749/comments"},"review_comments":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/749/comments"},"review_comment":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/pulls/749/commits"},"statuses":{"href":"https://api.github.com/repos/JoinMarket-Org/joinmarket/statuses/bb93d144bceea3e06b2a5da16b988b104e6cc8ea"}}}}
{"actor":{"display_login":"ofek"}}