{"action":"created","comment":{"url":"https://api.github.com/repos/druid-io/druid/pulls/comments/110614017","pull_request_review_id":31797508,"id":110614017,"diff_hunk":"@@ -415,23 +413,15 @@ public IndexedInts getRow()\n         if (indices == null || indices.length == 0) {\n           final int nullId = getEncodedValue(null, false);\n           if (nullId > -1) {\n-            if (nullId < maxId) {\n-              row = new int[] {nullId};\n-              rowSize = 1;\n-            } else {\n-              // Choose to use ArrayBasedIndexedInts later, instead of EmptyIndexedInts, for monomorphism\n-              row = IntArrays.EMPTY_ARRAY;\n-              rowSize = 0;\n-            }\n+            row = new int[] {nullId};","path":"processing/src/main/java/io/druid/segment/StringDimensionIndexer.java","position":null,"original_position":28,"commit_id":"4041dbade9b220588d2105271f97bbc1f325b4c3","original_commit_id":"f57f3f1b076b48da101bf4f72614824b5be83d18","user":{"login":"kaijianding","id":8663725,"avatar_url":"https://avatars2.githubusercontent.com/u/8663725?v=3","gravatar_id":"","url":"https://api.github.com/users/kaijianding","html_url":"https://github.com/kaijianding","followers_url":"https://api.github.com/users/kaijianding/followers","following_url":"https://api.github.com/users/kaijianding/following{/other_user}","gists_url":"https://api.github.com/users/kaijianding/gists{/gist_id}","starred_url":"https://api.github.com/users/kaijianding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaijianding/subscriptions","organizations_url":"https://api.github.com/users/kaijianding/orgs","repos_url":"https://api.github.com/users/kaijianding/repos","events_url":"https://api.github.com/users/kaijianding/events{/privacy}","received_events_url":"https://api.github.com/users/kaijianding/received_events","type":"User","site_admin":false},"body":"Done memoizing the nullId int array","created_at":"2017-04-10T09:46:10Z","updated_at":"2017-04-10T09:46:10Z","html_url":"https://github.com/druid-io/druid/pull/4049#discussion_r110614017","pull_request_url":"https://api.github.com/repos/druid-io/druid/pulls/4049","_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments/110614017"},"html":{"href":"https://github.com/druid-io/druid/pull/4049#discussion_r110614017"},"pull_request":{"href":"https://api.github.com/repos/druid-io/druid/pulls/4049"}}},"pull_request":{"url":"https://api.github.com/repos/druid-io/druid/pulls/4049","id":110565918,"html_url":"https://github.com/druid-io/druid/pull/4049","diff_url":"https://github.com/druid-io/druid/pull/4049.diff","patch_url":"https://github.com/druid-io/druid/pull/4049.patch","issue_url":"https://api.github.com/repos/druid-io/druid/issues/4049","number":4049,"state":"open","locked":false,"title":"fix can't get dim value via IncrementalIndexStorageAdapter cursor","user":{"login":"kaijianding","id":8663725,"avatar_url":"https://avatars2.githubusercontent.com/u/8663725?v=3","gravatar_id":"","url":"https://api.github.com/users/kaijianding","html_url":"https://github.com/kaijianding","followers_url":"https://api.github.com/users/kaijianding/followers","following_url":"https://api.github.com/users/kaijianding/following{/other_user}","gists_url":"https://api.github.com/users/kaijianding/gists{/gist_id}","starred_url":"https://api.github.com/users/kaijianding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaijianding/subscriptions","organizations_url":"https://api.github.com/users/kaijianding/orgs","repos_url":"https://api.github.com/users/kaijianding/repos","events_url":"https://api.github.com/users/kaijianding/events{/privacy}","received_events_url":"https://api.github.com/users/kaijianding/received_events","type":"User","site_admin":false},"body":"The checking maxId behavior is weird, We can get dims array from cursor's currEntry in IndexerDimensionSelector, but choosing to ignore the dims if dims are beyond maxId which is actually too old if data arrives after the cursor is made and cursor can retrieve really new data when the new data is inside the cursor's interval.\r\nBut think about this case, a group by query may produces aggregator values with empty string dimensions, while actually these aggregator values should bound to some non-empty dimensions.\r\n\r\n--update\r\nthe reason why maxId check is needed is explained here https://github.com/druid-io/druid/pull/4052#issuecomment-286779784\r\nbut still we can do it in a better way as described at https://github.com/druid-io/druid/pull/4052#issuecomment-288976998\r\n\r\nThe behavior test is already in IncrementalIndexStorageAdapterTest.testCursoringAndIndexUpdationInterleaving()","created_at":"2017-03-14T08:03:54Z","updated_at":"2017-04-10T09:46:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6052a45afa32268268a5f5bfd6298de55248324","assignee":{"login":"leventov","id":609240,"avatar_url":"https://avatars3.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false},"assignees":[{"login":"leventov","id":609240,"avatar_url":"https://avatars3.githubusercontent.com/u/609240?v=3","gravatar_id":"","url":"https://api.github.com/users/leventov","html_url":"https://github.com/leventov","followers_url":"https://api.github.com/users/leventov/followers","following_url":"https://api.github.com/users/leventov/following{/other_user}","gists_url":"https://api.github.com/users/leventov/gists{/gist_id}","starred_url":"https://api.github.com/users/leventov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leventov/subscriptions","organizations_url":"https://api.github.com/users/leventov/orgs","repos_url":"https://api.github.com/users/leventov/repos","events_url":"https://api.github.com/users/leventov/events{/privacy}","received_events_url":"https://api.github.com/users/leventov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/druid-io/druid/milestones/19","html_url":"https://github.com/druid-io/druid/milestone/19","labels_url":"https://api.github.com/repos/druid-io/druid/milestones/19/labels","id":1571408,"number":19,"title":"0.10.1","description":"","creator":{"login":"fjy","id":428325,"avatar_url":"https://avatars3.githubusercontent.com/u/428325?v=3","gravatar_id":"","url":"https://api.github.com/users/fjy","html_url":"https://github.com/fjy","followers_url":"https://api.github.com/users/fjy/followers","following_url":"https://api.github.com/users/fjy/following{/other_user}","gists_url":"https://api.github.com/users/fjy/gists{/gist_id}","starred_url":"https://api.github.com/users/fjy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjy/subscriptions","organizations_url":"https://api.github.com/users/fjy/orgs","repos_url":"https://api.github.com/users/fjy/repos","events_url":"https://api.github.com/users/fjy/events{/privacy}","received_events_url":"https://api.github.com/users/fjy/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":40,"state":"open","created_at":"2016-02-08T22:01:01Z","updated_at":"2017-04-10T04:06:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/druid-io/druid/pulls/4049/commits","review_comments_url":"https://api.github.com/repos/druid-io/druid/pulls/4049/comments","review_comment_url":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/druid-io/druid/issues/4049/comments","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/4041dbade9b220588d2105271f97bbc1f325b4c3","head":{"label":"kaijianding:dim","ref":"dim","sha":"4041dbade9b220588d2105271f97bbc1f325b4c3","user":{"login":"kaijianding","id":8663725,"avatar_url":"https://avatars2.githubusercontent.com/u/8663725?v=3","gravatar_id":"","url":"https://api.github.com/users/kaijianding","html_url":"https://github.com/kaijianding","followers_url":"https://api.github.com/users/kaijianding/followers","following_url":"https://api.github.com/users/kaijianding/following{/other_user}","gists_url":"https://api.github.com/users/kaijianding/gists{/gist_id}","starred_url":"https://api.github.com/users/kaijianding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaijianding/subscriptions","organizations_url":"https://api.github.com/users/kaijianding/orgs","repos_url":"https://api.github.com/users/kaijianding/repos","events_url":"https://api.github.com/users/kaijianding/events{/privacy}","received_events_url":"https://api.github.com/users/kaijianding/received_events","type":"User","site_admin":false},"repo":{"id":59644737,"name":"druid","full_name":"kaijianding/druid","owner":{"login":"kaijianding","id":8663725,"avatar_url":"https://avatars2.githubusercontent.com/u/8663725?v=3","gravatar_id":"","url":"https://api.github.com/users/kaijianding","html_url":"https://github.com/kaijianding","followers_url":"https://api.github.com/users/kaijianding/followers","following_url":"https://api.github.com/users/kaijianding/following{/other_user}","gists_url":"https://api.github.com/users/kaijianding/gists{/gist_id}","starred_url":"https://api.github.com/users/kaijianding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaijianding/subscriptions","organizations_url":"https://api.github.com/users/kaijianding/orgs","repos_url":"https://api.github.com/users/kaijianding/repos","events_url":"https://api.github.com/users/kaijianding/events{/privacy}","received_events_url":"https://api.github.com/users/kaijianding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaijianding/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":true,"url":"https://api.github.com/repos/kaijianding/druid","forks_url":"https://api.github.com/repos/kaijianding/druid/forks","keys_url":"https://api.github.com/repos/kaijianding/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaijianding/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaijianding/druid/teams","hooks_url":"https://api.github.com/repos/kaijianding/druid/hooks","issue_events_url":"https://api.github.com/repos/kaijianding/druid/issues/events{/number}","events_url":"https://api.github.com/repos/kaijianding/druid/events","assignees_url":"https://api.github.com/repos/kaijianding/druid/assignees{/user}","branches_url":"https://api.github.com/repos/kaijianding/druid/branches{/branch}","tags_url":"https://api.github.com/repos/kaijianding/druid/tags","blobs_url":"https://api.github.com/repos/kaijianding/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaijianding/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaijianding/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaijianding/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaijianding/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/kaijianding/druid/languages","stargazers_url":"https://api.github.com/repos/kaijianding/druid/stargazers","contributors_url":"https://api.github.com/repos/kaijianding/druid/contributors","subscribers_url":"https://api.github.com/repos/kaijianding/druid/subscribers","subscription_url":"https://api.github.com/repos/kaijianding/druid/subscription","commits_url":"https://api.github.com/repos/kaijianding/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaijianding/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaijianding/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaijianding/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaijianding/druid/contents/{+path}","compare_url":"https://api.github.com/repos/kaijianding/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaijianding/druid/merges","archive_url":"https://api.github.com/repos/kaijianding/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaijianding/druid/downloads","issues_url":"https://api.github.com/repos/kaijianding/druid/issues{/number}","pulls_url":"https://api.github.com/repos/kaijianding/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/kaijianding/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/kaijianding/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaijianding/druid/labels{/name}","releases_url":"https://api.github.com/repos/kaijianding/druid/releases{/id}","deployments_url":"https://api.github.com/repos/kaijianding/druid/deployments","created_at":"2016-05-25T08:22:38Z","updated_at":"2016-05-25T08:22:47Z","pushed_at":"2017-04-10T09:35:59Z","git_url":"git://github.com/kaijianding/druid.git","ssh_url":"git@github.com:kaijianding/druid.git","clone_url":"https://github.com/kaijianding/druid.git","svn_url":"https://github.com/kaijianding/druid","homepage":"http://druid.io","size":118797,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"druid-io:master","ref":"master","sha":"15f3a944745ba19d8063d7f189121d61f0378f9a","user":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars3.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"repo":{"id":6358188,"name":"druid","full_name":"druid-io/druid","owner":{"login":"druid-io","id":4203474,"avatar_url":"https://avatars3.githubusercontent.com/u/4203474?v=3","gravatar_id":"","url":"https://api.github.com/users/druid-io","html_url":"https://github.com/druid-io","followers_url":"https://api.github.com/users/druid-io/followers","following_url":"https://api.github.com/users/druid-io/following{/other_user}","gists_url":"https://api.github.com/users/druid-io/gists{/gist_id}","starred_url":"https://api.github.com/users/druid-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druid-io/subscriptions","organizations_url":"https://api.github.com/users/druid-io/orgs","repos_url":"https://api.github.com/users/druid-io/repos","events_url":"https://api.github.com/users/druid-io/events{/privacy}","received_events_url":"https://api.github.com/users/druid-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/druid-io/druid","description":"Column oriented distributed data store ideal for powering interactive applications","fork":false,"url":"https://api.github.com/repos/druid-io/druid","forks_url":"https://api.github.com/repos/druid-io/druid/forks","keys_url":"https://api.github.com/repos/druid-io/druid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druid-io/druid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druid-io/druid/teams","hooks_url":"https://api.github.com/repos/druid-io/druid/hooks","issue_events_url":"https://api.github.com/repos/druid-io/druid/issues/events{/number}","events_url":"https://api.github.com/repos/druid-io/druid/events","assignees_url":"https://api.github.com/repos/druid-io/druid/assignees{/user}","branches_url":"https://api.github.com/repos/druid-io/druid/branches{/branch}","tags_url":"https://api.github.com/repos/druid-io/druid/tags","blobs_url":"https://api.github.com/repos/druid-io/druid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druid-io/druid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druid-io/druid/git/refs{/sha}","trees_url":"https://api.github.com/repos/druid-io/druid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druid-io/druid/statuses/{sha}","languages_url":"https://api.github.com/repos/druid-io/druid/languages","stargazers_url":"https://api.github.com/repos/druid-io/druid/stargazers","contributors_url":"https://api.github.com/repos/druid-io/druid/contributors","subscribers_url":"https://api.github.com/repos/druid-io/druid/subscribers","subscription_url":"https://api.github.com/repos/druid-io/druid/subscription","commits_url":"https://api.github.com/repos/druid-io/druid/commits{/sha}","git_commits_url":"https://api.github.com/repos/druid-io/druid/git/commits{/sha}","comments_url":"https://api.github.com/repos/druid-io/druid/comments{/number}","issue_comment_url":"https://api.github.com/repos/druid-io/druid/issues/comments{/number}","contents_url":"https://api.github.com/repos/druid-io/druid/contents/{+path}","compare_url":"https://api.github.com/repos/druid-io/druid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druid-io/druid/merges","archive_url":"https://api.github.com/repos/druid-io/druid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druid-io/druid/downloads","issues_url":"https://api.github.com/repos/druid-io/druid/issues{/number}","pulls_url":"https://api.github.com/repos/druid-io/druid/pulls{/number}","milestones_url":"https://api.github.com/repos/druid-io/druid/milestones{/number}","notifications_url":"https://api.github.com/repos/druid-io/druid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druid-io/druid/labels{/name}","releases_url":"https://api.github.com/repos/druid-io/druid/releases{/id}","deployments_url":"https://api.github.com/repos/druid-io/druid/deployments","created_at":"2012-10-23T19:08:07Z","updated_at":"2017-04-10T09:02:56Z","pushed_at":"2017-04-10T09:36:01Z","git_url":"git://github.com/druid-io/druid.git","ssh_url":"git@github.com:druid-io/druid.git","clone_url":"https://github.com/druid-io/druid.git","svn_url":"https://github.com/druid-io/druid","homepage":"http://druid.io","size":119372,"stargazers_count":4693,"watchers_count":4693,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1110,"mirror_url":null,"open_issues_count":645,"forks":1110,"open_issues":645,"watchers":4693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/druid-io/druid/pulls/4049"},"html":{"href":"https://github.com/druid-io/druid/pull/4049"},"issue":{"href":"https://api.github.com/repos/druid-io/druid/issues/4049"},"comments":{"href":"https://api.github.com/repos/druid-io/druid/issues/4049/comments"},"review_comments":{"href":"https://api.github.com/repos/druid-io/druid/pulls/4049/comments"},"review_comment":{"href":"https://api.github.com/repos/druid-io/druid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/druid-io/druid/pulls/4049/commits"},"statuses":{"href":"https://api.github.com/repos/druid-io/druid/statuses/4041dbade9b220588d2105271f97bbc1f325b4c3"}}}}
{"actor":{"display_login":"kaijianding"}}