{"action":"created","issue":{"url":"https://api.github.com/repos/piroor/treestyletab/issues/1531","repository_url":"https://api.github.com/repos/piroor/treestyletab","labels_url":"https://api.github.com/repos/piroor/treestyletab/issues/1531/labels{/name}","comments_url":"https://api.github.com/repos/piroor/treestyletab/issues/1531/comments","events_url":"https://api.github.com/repos/piroor/treestyletab/issues/1531/events","html_url":"https://github.com/piroor/treestyletab/issues/1531","id":273936683,"number":1531,"title":"Better behavior around tab switching via Ctrl-Tab shortcut (\"Missing\" legacy behavior)","user":{"login":"Sinewyk","id":1826366,"avatar_url":"https://avatars2.githubusercontent.com/u/1826366?v=4","gravatar_id":"","url":"https://api.github.com/users/Sinewyk","html_url":"https://github.com/Sinewyk","followers_url":"https://api.github.com/users/Sinewyk/followers","following_url":"https://api.github.com/users/Sinewyk/following{/other_user}","gists_url":"https://api.github.com/users/Sinewyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinewyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinewyk/subscriptions","organizations_url":"https://api.github.com/users/Sinewyk/orgs","repos_url":"https://api.github.com/users/Sinewyk/repos","events_url":"https://api.github.com/users/Sinewyk/events{/privacy}","received_events_url":"https://api.github.com/users/Sinewyk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-14T20:45:45Z","updated_at":"2017-11-15T05:08:16Z","closed_at":null,"author_association":"NONE","body":"<!--\r\nNOTE: Please read the guideline to open a new issue at first.\r\nhttps://github.com/piroor/treestyletab/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n## Short description\r\nNavigating between tabs is less intuitive than legacy, navigating to previous tab by keyboard previous will expand previous tree and go to last tab of that tree (just not taking into account TST, but just regular tabs) instead of staying on the same level and going to previous tab AND THEN if we keep Ctrl pressed extending that tab (and collapsing others).\r\n\r\n## Steps to reproduce\r\n\r\n 1. Start Firefox with clean profile.\r\n 2. Install TST.\r\n 3. Create this structure with tabs\r\n\r\n```\r\nA (collapsed)\r\n\\- A1\r\n\\- A2\r\nB (collapsed)\r\n\\- B1\r\n\\- B2\r\nC (selected)\r\n```\r\n\r\n5. press Ctrl + Shift + Tab (or Ctrl + Page Up), the previous tab shortcut\r\n\r\n## Legacy behavior\r\nIt would go from C to B (and not expand B until pressing Ctrl for a short amount of time, a quick press would leave B collapsed)\r\n\r\n## Current behavior\r\nIt goes from C to B2 (and does not expand B by keeping Control pressed, and does not collapse C if B expands).\r\n\r\n## Environment\r\n\r\n * Platform (OS): Windows 10 Pro (1703, build 15063.674)\r\n * Version of Firefox: 57.0 (64 bits)\r\n * Version (or revision) of Tree Style Tab: 2.2.3\r\n"},"comment":{"url":"https://api.github.com/repos/piroor/treestyletab/issues/comments/344487289","html_url":"https://github.com/piroor/treestyletab/issues/1531#issuecomment-344487289","issue_url":"https://api.github.com/repos/piroor/treestyletab/issues/1531","id":344487289,"user":{"login":"piroor","id":70062,"avatar_url":"https://avatars2.githubusercontent.com/u/70062?v=4","gravatar_id":"","url":"https://api.github.com/users/piroor","html_url":"https://github.com/piroor","followers_url":"https://api.github.com/users/piroor/followers","following_url":"https://api.github.com/users/piroor/following{/other_user}","gists_url":"https://api.github.com/users/piroor/gists{/gist_id}","starred_url":"https://api.github.com/users/piroor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piroor/subscriptions","organizations_url":"https://api.github.com/users/piroor/orgs","repos_url":"https://api.github.com/users/piroor/repos","events_url":"https://api.github.com/users/piroor/events{/privacy}","received_events_url":"https://api.github.com/users/piroor/received_events","type":"User","site_admin":false},"created_at":"2017-11-15T05:08:16Z","updated_at":"2017-11-15T05:08:16Z","author_association":"OWNER","body":"I've implemented this by 0f74d53, but there are some problems from limitations of WebExtensions APIs:\r\n\r\n * TST cannot detect keydown/keyop of the ctrl key on special pages (about:addons, https://addons.mozilla.org/, etc.)\r\n   * Thus TST can misunderstand like \"now the user is trying to switch tab focus by Ctrl-Tab/Ctrl-Shift-Tab, so I don't expand this newly focused collapsed tree\" when you focus to any tab after you released the ctrl key on any special page tab.\r\n * TST cannot detect keydown/keyop of the ctrl key on Firefox's UI (location bar, web search box, find bar, etc.)\r\n   * Thus TST can misunderstand like \"now the user is not trying to switch tab focus by Ctrl-Tab/Ctrl-Shift-Tab, so I expand this newly focused collapsed tree\" when you are hitting Ctrl-Tab/Ctrl-Shift-Tab on the location bar or somewhere."}}
{"actor":{"display_login":"piroor"}}