{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments/127785224","pull_request_review_id":50404747,"id":127785224,"diff_hunk":"@@ -211,18 +211,40 @@ pipeline {\n                   checkout scm\n                   unstash 'installer'\n                   unstash 'smoke'\n-                  timeout(45) {\n-                    sh \"\"\"#!/bin/bash -ex\n-                    . ${WORKSPACE}/tests/smoke/aws/smoke.sh create-vpc\n-                    ${WORKSPACE}/tests/smoke/aws/smoke.sh plan vars/aws-vpc.tfvars\n-                    ${WORKSPACE}/tests/smoke/aws/smoke.sh create vars/aws-vpc.tfvars\n-                    ${WORKSPACE}/tests/smoke/aws/smoke.sh test vars/aws-vpc.tfvars\n-                    ${WORKSPACE}/tests/smoke/aws/smoke.sh destroy vars/aws-vpc.tfvars\n-                    ${WORKSPACE}/tests/smoke/aws/smoke.sh destroy-vpc\n-                    # As /build is created by root, make sure to remove it again\n-                    # so non-root can create it later.\n-                    rm -r ${WORKSPACE}/build\n-                    \"\"\"\n+                  script {\n+                    try {\n+                      timeout(45) {\n+                        sh \"\"\"#!/bin/bash -ex\n+                        . ${WORKSPACE}/tests/smoke/aws/smoke.sh create-vpc\n+                        ${WORKSPACE}/tests/smoke/aws/smoke.sh plan vars/aws-vpc.tfvars\n+                        ${WORKSPACE}/tests/smoke/aws/smoke.sh create vars/aws-vpc.tfvars\n+                        ${WORKSPACE}/tests/smoke/aws/smoke.sh test vars/aws-vpc.tfvars\n+                        \"\"\"\n+                      }\n+                    }\n+                    catch (error) {\n+                        throw error\n+                    }\n+                    finally {\n+                      retry(3) {\n+                        timeout(15) {\n+                          sh \"\"\"#!/bin/bash -x\n+                            # No \"-e\" so all commands are executed even if one\n+                            # fails, still return non-zero if one command\n+                            # returns non-zero\n+                            EXIT_STATUS=0\n+\n+                            ${WORKSPACE}/tests/smoke/aws/smoke.sh destroy vars/aws-vpc.tfvars || EXIT_STATUS=$?\n+                            ${WORKSPACE}/tests/smoke/aws/smoke.sh destroy-vpc || EXIT_STATUS=$?\n+\n+                            # As /build is created by root, make sure to remove it again\n+                            # so non-root can create it later.\n+                            rm -r ${WORKSPACE}/build || EXIT_STATUS=$?","path":"Jenkinsfile","position":null,"original_position":44,"commit_id":"1bc6252698b118a8b3d7d41034956ee1fdb93af8","original_commit_id":"21ae2739cf8d143859f47189eb60ddeaacb99a0e","user":{"login":"mxinden","id":7047859,"avatar_url":"https://avatars0.githubusercontent.com/u/7047859?v=4","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"body":"@estroz Are other `timeout` blocks still executed even if one of them fails?","created_at":"2017-07-17T18:24:58Z","updated_at":"2017-07-17T18:24:58Z","html_url":"https://github.com/coreos/tectonic-installer/pull/1400#discussion_r127785224","pull_request_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1400","_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments/127785224"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/1400#discussion_r127785224"},"pull_request":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1400"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1400","id":130617243,"html_url":"https://github.com/coreos/tectonic-installer/pull/1400","diff_url":"https://github.com/coreos/tectonic-installer/pull/1400.diff","patch_url":"https://github.com/coreos/tectonic-installer/pull/1400.patch","issue_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/1400","number":1400,"state":"open","locked":false,"title":"tests: Prevent *permission denied* errors","user":{"login":"mxinden","id":7047859,"avatar_url":"https://avatars0.githubusercontent.com/u/7047859?v=4","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"body":"* Wrap clean up steps of tests, executed by root, inside *try catch\r\nfinally* blocks. This way whenever *plan* or *apply* fails, the cleanup\r\nsteps are still executed.\r\n\r\n* Remove `-e` (# exit immediately when a command fails) from shebang in\r\nclean up steps, so if one clean up step fails others are still executed.","created_at":"2017-07-14T15:43:22Z","updated_at":"2017-07-17T18:24:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c6e1758a153bd9fe5e0c982b8b2e264b82fee25","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kans","id":986627,"avatar_url":"https://avatars3.githubusercontent.com/u/986627?v=4","gravatar_id":"","url":"https://api.github.com/users/kans","html_url":"https://github.com/kans","followers_url":"https://api.github.com/users/kans/followers","following_url":"https://api.github.com/users/kans/following{/other_user}","gists_url":"https://api.github.com/users/kans/gists{/gist_id}","starred_url":"https://api.github.com/users/kans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kans/subscriptions","organizations_url":"https://api.github.com/users/kans/orgs","repos_url":"https://api.github.com/users/kans/repos","events_url":"https://api.github.com/users/kans/events{/privacy}","received_events_url":"https://api.github.com/users/kans/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1400/commits","review_comments_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1400/comments","review_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/1400/comments","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/1bc6252698b118a8b3d7d41034956ee1fdb93af8","head":{"label":"mxinden:permission-denied","ref":"permission-denied","sha":"1bc6252698b118a8b3d7d41034956ee1fdb93af8","user":{"login":"mxinden","id":7047859,"avatar_url":"https://avatars0.githubusercontent.com/u/7047859?v=4","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"repo":{"id":87096095,"name":"tectonic-installer","full_name":"mxinden/tectonic-installer","owner":{"login":"mxinden","id":7047859,"avatar_url":"https://avatars0.githubusercontent.com/u/7047859?v=4","gravatar_id":"","url":"https://api.github.com/users/mxinden","html_url":"https://github.com/mxinden","followers_url":"https://api.github.com/users/mxinden/followers","following_url":"https://api.github.com/users/mxinden/following{/other_user}","gists_url":"https://api.github.com/users/mxinden/gists{/gist_id}","starred_url":"https://api.github.com/users/mxinden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxinden/subscriptions","organizations_url":"https://api.github.com/users/mxinden/orgs","repos_url":"https://api.github.com/users/mxinden/repos","events_url":"https://api.github.com/users/mxinden/events{/privacy}","received_events_url":"https://api.github.com/users/mxinden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mxinden/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":true,"url":"https://api.github.com/repos/mxinden/tectonic-installer","forks_url":"https://api.github.com/repos/mxinden/tectonic-installer/forks","keys_url":"https://api.github.com/repos/mxinden/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxinden/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxinden/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/mxinden/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/mxinden/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/mxinden/tectonic-installer/events","assignees_url":"https://api.github.com/repos/mxinden/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/mxinden/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/mxinden/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/mxinden/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxinden/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxinden/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxinden/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxinden/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/mxinden/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/mxinden/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/mxinden/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/mxinden/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/mxinden/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/mxinden/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxinden/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxinden/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxinden/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxinden/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/mxinden/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxinden/tectonic-installer/merges","archive_url":"https://api.github.com/repos/mxinden/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxinden/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/mxinden/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/mxinden/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/mxinden/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/mxinden/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxinden/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/mxinden/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/mxinden/tectonic-installer/deployments","created_at":"2017-04-03T16:28:52Z","updated_at":"2017-04-03T16:28:54Z","pushed_at":"2017-07-17T18:18:37Z","git_url":"git://github.com/mxinden/tectonic-installer.git","ssh_url":"git@github.com:mxinden/tectonic-installer.git","clone_url":"https://github.com/mxinden/tectonic-installer.git","svn_url":"https://github.com/mxinden/tectonic-installer","homepage":"","size":25291,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"69dfe14a4062612eaefbdd99243545fafd9c1bb0","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":81620471,"name":"tectonic-installer","full_name":"coreos/tectonic-installer","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":false,"url":"https://api.github.com/repos/coreos/tectonic-installer","forks_url":"https://api.github.com/repos/coreos/tectonic-installer/forks","keys_url":"https://api.github.com/repos/coreos/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/coreos/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/tectonic-installer/events","assignees_url":"https://api.github.com/repos/coreos/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/coreos/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/coreos/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/coreos/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/coreos/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/coreos/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/tectonic-installer/merges","archive_url":"https://api.github.com/repos/coreos/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/coreos/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/coreos/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/tectonic-installer/deployments","created_at":"2017-02-11T00:52:23Z","updated_at":"2017-07-17T15:00:12Z","pushed_at":"2017-07-17T18:18:39Z","git_url":"git://github.com/coreos/tectonic-installer.git","ssh_url":"git@github.com:coreos/tectonic-installer.git","clone_url":"https://github.com/coreos/tectonic-installer.git","svn_url":"https://github.com/coreos/tectonic-installer","homepage":"","size":25438,"stargazers_count":232,"watchers_count":232,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":276,"forks":139,"open_issues":276,"watchers":232,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1400"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/1400"},"issue":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/1400"},"comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/1400/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1400/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1400/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/tectonic-installer/statuses/1bc6252698b118a8b3d7d41034956ee1fdb93af8"}}}}
{"actor":{"display_login":"mxinden"}}