{"action":"created","comment":{"url":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments/130700112","pull_request_review_id":53604940,"id":130700112,"diff_hunk":"@@ -187,10 +203,25 @@ const OpenxAdapter = function OpenxAdapter() {\n       }\n     });\n \n-    params.callback = 'window.$$PREBID_GLOBAL$$.oxARJResponse';\n-    let queryString = buildQueryStringFromParams(params);\n+    if (window.XMLHttpRequest && 'withCredentials' in new XMLHttpRequest()) {","path":"modules/openxBidAdapter.js","position":75,"original_position":75,"commit_id":"24c8e6a59667271403f4a151b439756af937da5d","original_commit_id":"24c8e6a59667271403f4a151b439756af937da5d","user":{"login":"lntho","id":22649074,"avatar_url":"https://avatars2.githubusercontent.com/u/22649074?v=4","gravatar_id":"","url":"https://api.github.com/users/lntho","html_url":"https://github.com/lntho","followers_url":"https://api.github.com/users/lntho/followers","following_url":"https://api.github.com/users/lntho/following{/other_user}","gists_url":"https://api.github.com/users/lntho/gists{/gist_id}","starred_url":"https://api.github.com/users/lntho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lntho/subscriptions","organizations_url":"https://api.github.com/users/lntho/orgs","repos_url":"https://api.github.com/users/lntho/repos","events_url":"https://api.github.com/users/lntho/events{/privacy}","received_events_url":"https://api.github.com/users/lntho/received_events","type":"User","site_admin":false},"body":"Unfortunately we require the credentials for our ajax support to function correctly, so we must do this check here","created_at":"2017-08-01T19:09:07Z","updated_at":"2017-08-01T19:09:07Z","html_url":"https://github.com/prebid/Prebid.js/pull/1438#discussion_r130700112","pull_request_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/1438","_links":{"self":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments/130700112"},"html":{"href":"https://github.com/prebid/Prebid.js/pull/1438#discussion_r130700112"},"pull_request":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/1438"}}},"pull_request":{"url":"https://api.github.com/repos/prebid/Prebid.js/pulls/1438","id":133061261,"html_url":"https://github.com/prebid/Prebid.js/pull/1438","diff_url":"https://github.com/prebid/Prebid.js/pull/1438.diff","patch_url":"https://github.com/prebid/Prebid.js/pull/1438.patch","issue_url":"https://api.github.com/repos/prebid/Prebid.js/issues/1438","number":1438,"state":"open","locked":false,"title":"OpenX Adapter Update:","user":{"login":"lntho","id":22649074,"avatar_url":"https://avatars2.githubusercontent.com/u/22649074?v=4","gravatar_id":"","url":"https://api.github.com/users/lntho","html_url":"https://github.com/lntho","followers_url":"https://api.github.com/users/lntho/followers","following_url":"https://api.github.com/users/lntho/following{/other_user}","gists_url":"https://api.github.com/users/lntho/gists{/gist_id}","starred_url":"https://api.github.com/users/lntho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lntho/subscriptions","organizations_url":"https://api.github.com/users/lntho/orgs","repos_url":"https://api.github.com/users/lntho/repos","events_url":"https://api.github.com/users/lntho/events{/privacy}","received_events_url":"https://api.github.com/users/lntho/received_events","type":"User","site_admin":false},"body":"1) Implementing AJAX calls for ad requests\r\n2) Adding prebid trasaction id to ad request\r\n3) Updated timeout to use the timeout passed as params\r\n4) Implemented cache busting on ad request\r\n5) Add tbd feature field to bidResponse\r\n\r\n<!--\r\nThank you for your pull request. Please make sure this PR is scoped to one change, and that any added or changed code includes tests with greater than 80% code coverage. See https://github.com/prebid/Prebid.js/blob/master/CONTRIBUTING.md#testing-prebidjs for documentation on testing Prebid.js.\r\n-->\r\n\r\n## Type of change\r\n<!-- Remove items that don't apply and/or select an item by changing [ ] to [x] -->\r\n- [x] Bugfix\r\n- [x] Feature\r\n\r\n## Description of change\r\n1) Implementing AJAX calls for ad requests\r\n2) Adding prebid trasaction id to ad request\r\n3) Updated timeout to use the timeout passed as params\r\n4) Implemented cache busting on ad request\r\n5) Add tbd feature field to bidResponse\r\n","created_at":"2017-07-28T22:13:32Z","updated_at":"2017-08-01T19:09:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09600349dd3deaae10e2d9ddc6bf6f8439d3f69d","assignee":{"login":"snapwich","id":551085,"avatar_url":"https://avatars3.githubusercontent.com/u/551085?v=4","gravatar_id":"","url":"https://api.github.com/users/snapwich","html_url":"https://github.com/snapwich","followers_url":"https://api.github.com/users/snapwich/followers","following_url":"https://api.github.com/users/snapwich/following{/other_user}","gists_url":"https://api.github.com/users/snapwich/gists{/gist_id}","starred_url":"https://api.github.com/users/snapwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapwich/subscriptions","organizations_url":"https://api.github.com/users/snapwich/orgs","repos_url":"https://api.github.com/users/snapwich/repos","events_url":"https://api.github.com/users/snapwich/events{/privacy}","received_events_url":"https://api.github.com/users/snapwich/received_events","type":"User","site_admin":false},"assignees":[{"login":"snapwich","id":551085,"avatar_url":"https://avatars3.githubusercontent.com/u/551085?v=4","gravatar_id":"","url":"https://api.github.com/users/snapwich","html_url":"https://github.com/snapwich","followers_url":"https://api.github.com/users/snapwich/followers","following_url":"https://api.github.com/users/snapwich/following{/other_user}","gists_url":"https://api.github.com/users/snapwich/gists{/gist_id}","starred_url":"https://api.github.com/users/snapwich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapwich/subscriptions","organizations_url":"https://api.github.com/users/snapwich/orgs","repos_url":"https://api.github.com/users/snapwich/repos","events_url":"https://api.github.com/users/snapwich/events{/privacy}","received_events_url":"https://api.github.com/users/snapwich/received_events","type":"User","site_admin":false},{"login":"ndhimehta","id":26911109,"avatar_url":"https://avatars2.githubusercontent.com/u/26911109?v=4","gravatar_id":"","url":"https://api.github.com/users/ndhimehta","html_url":"https://github.com/ndhimehta","followers_url":"https://api.github.com/users/ndhimehta/followers","following_url":"https://api.github.com/users/ndhimehta/following{/other_user}","gists_url":"https://api.github.com/users/ndhimehta/gists{/gist_id}","starred_url":"https://api.github.com/users/ndhimehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndhimehta/subscriptions","organizations_url":"https://api.github.com/users/ndhimehta/orgs","repos_url":"https://api.github.com/users/ndhimehta/repos","events_url":"https://api.github.com/users/ndhimehta/events{/privacy}","received_events_url":"https://api.github.com/users/ndhimehta/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/1438/commits","review_comments_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/1438/comments","review_comment_url":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prebid/Prebid.js/issues/1438/comments","statuses_url":"https://api.github.com/repos/prebid/Prebid.js/statuses/24c8e6a59667271403f4a151b439756af937da5d","head":{"label":"openx:openx-release","ref":"openx-release","sha":"24c8e6a59667271403f4a151b439756af937da5d","user":{"login":"openx","id":161648,"avatar_url":"https://avatars0.githubusercontent.com/u/161648?v=4","gravatar_id":"","url":"https://api.github.com/users/openx","html_url":"https://github.com/openx","followers_url":"https://api.github.com/users/openx/followers","following_url":"https://api.github.com/users/openx/following{/other_user}","gists_url":"https://api.github.com/users/openx/gists{/gist_id}","starred_url":"https://api.github.com/users/openx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openx/subscriptions","organizations_url":"https://api.github.com/users/openx/orgs","repos_url":"https://api.github.com/users/openx/repos","events_url":"https://api.github.com/users/openx/events{/privacy}","received_events_url":"https://api.github.com/users/openx/received_events","type":"Organization","site_admin":false},"repo":{"id":70182407,"name":"Prebid.js","full_name":"openx/Prebid.js","owner":{"login":"openx","id":161648,"avatar_url":"https://avatars0.githubusercontent.com/u/161648?v=4","gravatar_id":"","url":"https://api.github.com/users/openx","html_url":"https://github.com/openx","followers_url":"https://api.github.com/users/openx/followers","following_url":"https://api.github.com/users/openx/following{/other_user}","gists_url":"https://api.github.com/users/openx/gists{/gist_id}","starred_url":"https://api.github.com/users/openx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openx/subscriptions","organizations_url":"https://api.github.com/users/openx/orgs","repos_url":"https://api.github.com/users/openx/repos","events_url":"https://api.github.com/users/openx/events{/privacy}","received_events_url":"https://api.github.com/users/openx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openx/Prebid.js","description":"Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.","fork":true,"url":"https://api.github.com/repos/openx/Prebid.js","forks_url":"https://api.github.com/repos/openx/Prebid.js/forks","keys_url":"https://api.github.com/repos/openx/Prebid.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openx/Prebid.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openx/Prebid.js/teams","hooks_url":"https://api.github.com/repos/openx/Prebid.js/hooks","issue_events_url":"https://api.github.com/repos/openx/Prebid.js/issues/events{/number}","events_url":"https://api.github.com/repos/openx/Prebid.js/events","assignees_url":"https://api.github.com/repos/openx/Prebid.js/assignees{/user}","branches_url":"https://api.github.com/repos/openx/Prebid.js/branches{/branch}","tags_url":"https://api.github.com/repos/openx/Prebid.js/tags","blobs_url":"https://api.github.com/repos/openx/Prebid.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openx/Prebid.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openx/Prebid.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/openx/Prebid.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openx/Prebid.js/statuses/{sha}","languages_url":"https://api.github.com/repos/openx/Prebid.js/languages","stargazers_url":"https://api.github.com/repos/openx/Prebid.js/stargazers","contributors_url":"https://api.github.com/repos/openx/Prebid.js/contributors","subscribers_url":"https://api.github.com/repos/openx/Prebid.js/subscribers","subscription_url":"https://api.github.com/repos/openx/Prebid.js/subscription","commits_url":"https://api.github.com/repos/openx/Prebid.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/openx/Prebid.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/openx/Prebid.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/openx/Prebid.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/openx/Prebid.js/contents/{+path}","compare_url":"https://api.github.com/repos/openx/Prebid.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openx/Prebid.js/merges","archive_url":"https://api.github.com/repos/openx/Prebid.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openx/Prebid.js/downloads","issues_url":"https://api.github.com/repos/openx/Prebid.js/issues{/number}","pulls_url":"https://api.github.com/repos/openx/Prebid.js/pulls{/number}","milestones_url":"https://api.github.com/repos/openx/Prebid.js/milestones{/number}","notifications_url":"https://api.github.com/repos/openx/Prebid.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openx/Prebid.js/labels{/name}","releases_url":"https://api.github.com/repos/openx/Prebid.js/releases{/id}","deployments_url":"https://api.github.com/repos/openx/Prebid.js/deployments","created_at":"2016-10-06T18:40:54Z","updated_at":"2016-11-03T16:48:24Z","pushed_at":"2017-07-28T22:23:12Z","git_url":"git://github.com/openx/Prebid.js.git","ssh_url":"git@github.com:openx/Prebid.js.git","clone_url":"https://github.com/openx/Prebid.js.git","svn_url":"https://github.com/openx/Prebid.js","homepage":"http://prebid.org","size":21886,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"prebid:master","ref":"master","sha":"6069d9b1274c04dc59a739b89ce8439ea763ce6a","user":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":39321023,"name":"Prebid.js","full_name":"prebid/Prebid.js","owner":{"login":"prebid","id":13242760,"avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prebid/Prebid.js","description":"Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.","fork":false,"url":"https://api.github.com/repos/prebid/Prebid.js","forks_url":"https://api.github.com/repos/prebid/Prebid.js/forks","keys_url":"https://api.github.com/repos/prebid/Prebid.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/Prebid.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/Prebid.js/teams","hooks_url":"https://api.github.com/repos/prebid/Prebid.js/hooks","issue_events_url":"https://api.github.com/repos/prebid/Prebid.js/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/Prebid.js/events","assignees_url":"https://api.github.com/repos/prebid/Prebid.js/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/Prebid.js/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/Prebid.js/tags","blobs_url":"https://api.github.com/repos/prebid/Prebid.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/Prebid.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/Prebid.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/Prebid.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/Prebid.js/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/Prebid.js/languages","stargazers_url":"https://api.github.com/repos/prebid/Prebid.js/stargazers","contributors_url":"https://api.github.com/repos/prebid/Prebid.js/contributors","subscribers_url":"https://api.github.com/repos/prebid/Prebid.js/subscribers","subscription_url":"https://api.github.com/repos/prebid/Prebid.js/subscription","commits_url":"https://api.github.com/repos/prebid/Prebid.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/Prebid.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/Prebid.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/Prebid.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/Prebid.js/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/Prebid.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/Prebid.js/merges","archive_url":"https://api.github.com/repos/prebid/Prebid.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/Prebid.js/downloads","issues_url":"https://api.github.com/repos/prebid/Prebid.js/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/Prebid.js/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/Prebid.js/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/Prebid.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/Prebid.js/labels{/name}","releases_url":"https://api.github.com/repos/prebid/Prebid.js/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/Prebid.js/deployments","created_at":"2015-07-19T03:26:23Z","updated_at":"2017-07-28T07:57:30Z","pushed_at":"2017-08-01T18:22:59Z","git_url":"git://github.com/prebid/Prebid.js.git","ssh_url":"git@github.com:prebid/Prebid.js.git","clone_url":"https://github.com/prebid/Prebid.js.git","svn_url":"https://github.com/prebid/Prebid.js","homepage":"http://prebid.org","size":3182,"stargazers_count":495,"watchers_count":495,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":438,"mirror_url":null,"open_issues_count":109,"forks":438,"open_issues":109,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/1438"},"html":{"href":"https://github.com/prebid/Prebid.js/pull/1438"},"issue":{"href":"https://api.github.com/repos/prebid/Prebid.js/issues/1438"},"comments":{"href":"https://api.github.com/repos/prebid/Prebid.js/issues/1438/comments"},"review_comments":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/1438/comments"},"review_comment":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prebid/Prebid.js/pulls/1438/commits"},"statuses":{"href":"https://api.github.com/repos/prebid/Prebid.js/statuses/24c8e6a59667271403f4a151b439756af937da5d"}}}}
{"actor":{"display_login":"lntho"}}