{"action":"created","comment":{"url":"https://api.github.com/repos/friendica/friendica/pulls/comments/127981948","pull_request_review_id":50617448,"id":127981948,"diff_hunk":"@@ -113,6 +112,7 @@ public static function feed($dfrn_id, $owner_nick, $last_update, $direction = 0,\n \t\t);\n \n \t\tif (! dbm::is_result($r)) {\n+\t\t\tlogger(sprintf('No contact found for nickname=%d', $owner_nick), LOGGER_WARNING);","path":"include/dfrn.php","position":30,"original_position":30,"commit_id":"24855f8ff1dc6d5cfd164bc40b51fcdda7a1b325","original_commit_id":"24855f8ff1dc6d5cfd164bc40b51fcdda7a1b325","user":{"login":"annando","id":844208,"avatar_url":"https://avatars1.githubusercontent.com/u/844208?v=4","gravatar_id":"","url":"https://api.github.com/users/annando","html_url":"https://github.com/annando","followers_url":"https://api.github.com/users/annando/followers","following_url":"https://api.github.com/users/annando/following{/other_user}","gists_url":"https://api.github.com/users/annando/gists{/gist_id}","starred_url":"https://api.github.com/users/annando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annando/subscriptions","organizations_url":"https://api.github.com/users/annando/orgs","repos_url":"https://api.github.com/users/annando/repos","events_url":"https://api.github.com/users/annando/events{/privacy}","received_events_url":"https://api.github.com/users/annando/received_events","type":"User","site_admin":false},"body":"See here for a list: https://github.com/friendica/friendica/blob/develop/boot.php#L114-L118","created_at":"2017-07-18T13:56:05Z","updated_at":"2017-07-18T13:56:05Z","html_url":"https://github.com/friendica/friendica/pull/3588#discussion_r127981948","pull_request_url":"https://api.github.com/repos/friendica/friendica/pulls/3588","_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments/127981948"},"html":{"href":"https://github.com/friendica/friendica/pull/3588#discussion_r127981948"},"pull_request":{"href":"https://api.github.com/repos/friendica/friendica/pulls/3588"}}},"pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/3588","id":130958755,"html_url":"https://github.com/friendica/friendica/pull/3588","diff_url":"https://github.com/friendica/friendica/pull/3588.diff","patch_url":"https://github.com/friendica/friendica/pull/3588.patch","issue_url":"https://api.github.com/repos/friendica/friendica/issues/3588","number":3588,"state":"open","locked":false,"title":"Coding convention applied split 2-7-2 (of 2-14-2)","user":{"login":"Quix0r","id":470798,"avatar_url":"https://avatars3.githubusercontent.com/u/470798?v=4","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"body":"This PR is the next of **14** upcoming splits of the first series (yes, a lot has been changed) which started with #3254 (origin: #3112 ). It includes coding-convention stuff like added spaces and curly braces. Also some `dbm::is_result()` may have been included.\r\n\r\nThe commit has been split out from a larger commit containing 192 (!) changed files.\r\n\r\nMore similar changes: (in order they are created)\r\n\r\n- [x] part 2 #3254 \r\n- [x] part 2-1-2 #3287\r\n- [x] part 2-2-2 #3369\r\n- [x] part 2-3-2 #3375\r\n- [x] part 2-4-2 #3381\r\n- [x] part 2-5-2 #3469 \r\n- [x] part 2-6-2 #3473 \r\n- [ ] part 2-7-2 (this)\r\n- [ ] part 2-8-2 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split2-8-2\r\n- [ ] part 2-9-2 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split2-9-2\r\n- [ ] part 2-10-2 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split2-10-2\r\n- [ ] part 2-11-2 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split2-11-2\r\n- [ ] part 2-12-2 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split2-12-2\r\n- [ ] part 2-13-2 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split2-13-2\r\n- [ ] part 2-14-2 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split2-14-2\r\n- [ ] part 2-2 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split2-2 (**final!**)\r\n- [ ] part 3 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split3\r\n- [ ] part 4 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split4\r\n- [ ] part 5 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split5\r\n- [ ] part 6 https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-split6\r\n- [ ] / : https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-root\r\n- [ ] utils/ : https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-utils\r\n- [ ] mod/ https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-mod\r\n- [ ] include 1: https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-include-if\r\n- [ ] include 2: https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-include-foreach\r\n- [ ] others: https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-others\r\n- [ ] else-if: https://github.com/Quix0r/friendica/tree/rewrites/coding-convention-else-if\r\n\r\nUnrelated but comes next:\r\n- [ ] chmod https://github.com/Quix0r/friendica/tree/fixes/chmod","created_at":"2017-07-17T21:44:44Z","updated_at":"2017-07-18T13:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67432d4a77ae78bbe8e02725f099749d7f48e483","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/friendica/friendica/pulls/3588/commits","review_comments_url":"https://api.github.com/repos/friendica/friendica/pulls/3588/comments","review_comment_url":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/3588/comments","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/24855f8ff1dc6d5cfd164bc40b51fcdda7a1b325","head":{"label":"Quix0r:rewrites/coding-convention-split2-7-2","ref":"rewrites/coding-convention-split2-7-2","sha":"24855f8ff1dc6d5cfd164bc40b51fcdda7a1b325","user":{"login":"Quix0r","id":470798,"avatar_url":"https://avatars3.githubusercontent.com/u/470798?v=4","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"repo":{"id":52880546,"name":"friendica","full_name":"Quix0r/friendica","owner":{"login":"Quix0r","id":470798,"avatar_url":"https://avatars3.githubusercontent.com/u/470798?v=4","gravatar_id":"","url":"https://api.github.com/users/Quix0r","html_url":"https://github.com/Quix0r","followers_url":"https://api.github.com/users/Quix0r/followers","following_url":"https://api.github.com/users/Quix0r/following{/other_user}","gists_url":"https://api.github.com/users/Quix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Quix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quix0r/subscriptions","organizations_url":"https://api.github.com/users/Quix0r/orgs","repos_url":"https://api.github.com/users/Quix0r/repos","events_url":"https://api.github.com/users/Quix0r/events{/privacy}","received_events_url":"https://api.github.com/users/Quix0r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Quix0r/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/Quix0r/friendica","forks_url":"https://api.github.com/repos/Quix0r/friendica/forks","keys_url":"https://api.github.com/repos/Quix0r/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quix0r/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quix0r/friendica/teams","hooks_url":"https://api.github.com/repos/Quix0r/friendica/hooks","issue_events_url":"https://api.github.com/repos/Quix0r/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/Quix0r/friendica/events","assignees_url":"https://api.github.com/repos/Quix0r/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/Quix0r/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/Quix0r/friendica/tags","blobs_url":"https://api.github.com/repos/Quix0r/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quix0r/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quix0r/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quix0r/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quix0r/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/Quix0r/friendica/languages","stargazers_url":"https://api.github.com/repos/Quix0r/friendica/stargazers","contributors_url":"https://api.github.com/repos/Quix0r/friendica/contributors","subscribers_url":"https://api.github.com/repos/Quix0r/friendica/subscribers","subscription_url":"https://api.github.com/repos/Quix0r/friendica/subscription","commits_url":"https://api.github.com/repos/Quix0r/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quix0r/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quix0r/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quix0r/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quix0r/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/Quix0r/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quix0r/friendica/merges","archive_url":"https://api.github.com/repos/Quix0r/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quix0r/friendica/downloads","issues_url":"https://api.github.com/repos/Quix0r/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/Quix0r/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/Quix0r/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/Quix0r/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quix0r/friendica/labels{/name}","releases_url":"https://api.github.com/repos/Quix0r/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/Quix0r/friendica/deployments","created_at":"2016-03-01T13:56:00Z","updated_at":"2016-03-01T13:56:05Z","pushed_at":"2017-07-17T21:36:48Z","git_url":"git://github.com/Quix0r/friendica.git","ssh_url":"git@github.com:Quix0r/friendica.git","clone_url":"https://github.com/Quix0r/friendica.git","svn_url":"https://github.com/Quix0r/friendica","homepage":"","size":76296,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"friendica:develop","ref":"develop","sha":"f71bd4f1f79c3a05cc1620cfceebb6f50a95cc66","user":{"login":"friendica","id":1176581,"avatar_url":"https://avatars1.githubusercontent.com/u/1176581?v=4","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"repo":{"id":2722709,"name":"friendica","full_name":"friendica/friendica","owner":{"login":"friendica","id":1176581,"avatar_url":"https://avatars1.githubusercontent.com/u/1176581?v=4","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/friendica/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/friendica/friendica","forks_url":"https://api.github.com/repos/friendica/friendica/forks","keys_url":"https://api.github.com/repos/friendica/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friendica/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friendica/friendica/teams","hooks_url":"https://api.github.com/repos/friendica/friendica/hooks","issue_events_url":"https://api.github.com/repos/friendica/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/friendica/friendica/events","assignees_url":"https://api.github.com/repos/friendica/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/friendica/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/friendica/friendica/tags","blobs_url":"https://api.github.com/repos/friendica/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friendica/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friendica/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/friendica/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/friendica/friendica/languages","stargazers_url":"https://api.github.com/repos/friendica/friendica/stargazers","contributors_url":"https://api.github.com/repos/friendica/friendica/contributors","subscribers_url":"https://api.github.com/repos/friendica/friendica/subscribers","subscription_url":"https://api.github.com/repos/friendica/friendica/subscription","commits_url":"https://api.github.com/repos/friendica/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/friendica/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/friendica/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/friendica/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/friendica/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/friendica/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friendica/friendica/merges","archive_url":"https://api.github.com/repos/friendica/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friendica/friendica/downloads","issues_url":"https://api.github.com/repos/friendica/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/friendica/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/friendica/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/friendica/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friendica/friendica/labels{/name}","releases_url":"https://api.github.com/repos/friendica/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/friendica/friendica/deployments","created_at":"2011-11-06T22:19:41Z","updated_at":"2017-07-09T04:48:16Z","pushed_at":"2017-07-17T21:44:45Z","git_url":"git://github.com/friendica/friendica.git","ssh_url":"git@github.com:friendica/friendica.git","clone_url":"https://github.com/friendica/friendica.git","svn_url":"https://github.com/friendica/friendica","homepage":"http://friendi.ca","size":76298,"stargazers_count":474,"watchers_count":474,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":176,"mirror_url":null,"open_issues_count":288,"forks":176,"open_issues":288,"watchers":474,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/3588"},"html":{"href":"https://github.com/friendica/friendica/pull/3588"},"issue":{"href":"https://api.github.com/repos/friendica/friendica/issues/3588"},"comments":{"href":"https://api.github.com/repos/friendica/friendica/issues/3588/comments"},"review_comments":{"href":"https://api.github.com/repos/friendica/friendica/pulls/3588/comments"},"review_comment":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/friendica/friendica/pulls/3588/commits"},"statuses":{"href":"https://api.github.com/repos/friendica/friendica/statuses/24855f8ff1dc6d5cfd164bc40b51fcdda7a1b325"}}}}
{"actor":{"display_login":"annando"}}