{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/98234174","pull_request_review_id":18871707,"id":98234174,"diff_hunk":"@@ -468,18 +468,28 @@ open class DriverDSL(\n             else\n                 \"\"\n \n-            val javaArgs = listOf(\n-                    path,\n-                    \"-Dname=${nodeConf.myLegalName}\",\n-                    \"-javaagent:$quasarJarPath\",\n-                    debugPortArg,\n-                    \"-Dvisualvm.display.name=Corda\",\n-                    \"-Xmx200m\",\n-                    \"-XX:+UseG1GC\",\n-                    \"-cp\", classpath,\n-                    className,\n-                    \"--base-directory=${nodeConf.baseDirectory}\"\n-            ).filter(String::isNotEmpty)\n+            val additionalKeys = listOf(\"AMQ_DELIVERY_DELAY_MS\")\n+\n+            val systemArgs = mutableMapOf(\"name\" to nodeConf.myLegalName)","path":"node/src/main/kotlin/net/corda/node/driver/Driver.kt","position":null,"original_position":18,"commit_id":"ad55d4d8d43dc2603a4a4c98b9dde9bd6e06aba8","original_commit_id":"d982a28144b87e6b5bbf4b5b1b6c95f7f2f66d58","user":{"login":"ragmondo","id":616888,"avatar_url":"https://avatars.githubusercontent.com/u/616888?v=3","gravatar_id":"","url":"https://api.github.com/users/ragmondo","html_url":"https://github.com/ragmondo","followers_url":"https://api.github.com/users/ragmondo/followers","following_url":"https://api.github.com/users/ragmondo/following{/other_user}","gists_url":"https://api.github.com/users/ragmondo/gists{/gist_id}","starred_url":"https://api.github.com/users/ragmondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragmondo/subscriptions","organizations_url":"https://api.github.com/users/ragmondo/orgs","repos_url":"https://api.github.com/users/ragmondo/repos","events_url":"https://api.github.com/users/ragmondo/events{/privacy}","received_events_url":"https://api.github.com/users/ragmondo/received_events","type":"User","site_admin":false},"body":"Ah yes - added","created_at":"2017-01-27T16:09:54Z","updated_at":"2017-01-27T16:09:54Z","html_url":"https://github.com/corda/corda/pull/185#discussion_r98234174","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/98234174"},"html":{"href":"https://github.com/corda/corda/pull/185#discussion_r98234174"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/185","id":103480867,"html_url":"https://github.com/corda/corda/pull/185","diff_url":"https://github.com/corda/corda/pull/185.diff","patch_url":"https://github.com/corda/corda/pull/185.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/185","number":185,"state":"open","locked":false,"title":"Adding optional delay to AMQ message sending via system properties","user":{"login":"ragmondo","id":616888,"avatar_url":"https://avatars.githubusercontent.com/u/616888?v=3","gravatar_id":"","url":"https://api.github.com/users/ragmondo","html_url":"https://github.com/ragmondo","followers_url":"https://api.github.com/users/ragmondo/followers","following_url":"https://api.github.com/users/ragmondo/following{/other_user}","gists_url":"https://api.github.com/users/ragmondo/gists{/gist_id}","starred_url":"https://api.github.com/users/ragmondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ragmondo/subscriptions","organizations_url":"https://api.github.com/users/ragmondo/orgs","repos_url":"https://api.github.com/users/ragmondo/repos","events_url":"https://api.github.com/users/ragmondo/events{/privacy}","received_events_url":"https://api.github.com/users/ragmondo/received_events","type":"User","site_admin":false},"body":"This enables the user to add a system property option to add delays to the AMQ message being sent in order to demonstrate flows in slowtime. It is (obviously) not intended for production, hence the use of system properties.","created_at":"2017-01-27T12:04:34Z","updated_at":"2017-01-27T16:09:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd470dddc7990476244a48690bafd7762e9a044c","assignee":{"login":"exFalso","id":1042674,"avatar_url":"https://avatars.githubusercontent.com/u/1042674?v=3","gravatar_id":"","url":"https://api.github.com/users/exFalso","html_url":"https://github.com/exFalso","followers_url":"https://api.github.com/users/exFalso/followers","following_url":"https://api.github.com/users/exFalso/following{/other_user}","gists_url":"https://api.github.com/users/exFalso/gists{/gist_id}","starred_url":"https://api.github.com/users/exFalso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exFalso/subscriptions","organizations_url":"https://api.github.com/users/exFalso/orgs","repos_url":"https://api.github.com/users/exFalso/repos","events_url":"https://api.github.com/users/exFalso/events{/privacy}","received_events_url":"https://api.github.com/users/exFalso/received_events","type":"User","site_admin":false},"assignees":[{"login":"exFalso","id":1042674,"avatar_url":"https://avatars.githubusercontent.com/u/1042674?v=3","gravatar_id":"","url":"https://api.github.com/users/exFalso","html_url":"https://github.com/exFalso","followers_url":"https://api.github.com/users/exFalso/followers","following_url":"https://api.github.com/users/exFalso/following{/other_user}","gists_url":"https://api.github.com/users/exFalso/gists{/gist_id}","starred_url":"https://api.github.com/users/exFalso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exFalso/subscriptions","organizations_url":"https://api.github.com/users/exFalso/orgs","repos_url":"https://api.github.com/users/exFalso/repos","events_url":"https://api.github.com/users/exFalso/events{/privacy}","received_events_url":"https://api.github.com/users/exFalso/received_events","type":"User","site_admin":false},{"login":"shamsasari","id":3883563,"avatar_url":"https://avatars.githubusercontent.com/u/3883563?v=3","gravatar_id":"","url":"https://api.github.com/users/shamsasari","html_url":"https://github.com/shamsasari","followers_url":"https://api.github.com/users/shamsasari/followers","following_url":"https://api.github.com/users/shamsasari/following{/other_user}","gists_url":"https://api.github.com/users/shamsasari/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsasari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsasari/subscriptions","organizations_url":"https://api.github.com/users/shamsasari/orgs","repos_url":"https://api.github.com/users/shamsasari/repos","events_url":"https://api.github.com/users/shamsasari/events{/privacy}","received_events_url":"https://api.github.com/users/shamsasari/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/185/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/185/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/185/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/ad55d4d8d43dc2603a4a4c98b9dde9bd6e06aba8","head":{"label":"corda:rg_adding_optional_delay_to_amq","ref":"rg_adding_optional_delay_to_amq","sha":"ad55d4d8d43dc2603a4a4c98b9dde9bd6e06aba8","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions, it offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2017-01-27T10:02:15Z","pushed_at":"2017-01-27T16:09:33Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":57747,"stargazers_count":442,"watchers_count":442,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":24,"forks":136,"open_issues":24,"watchers":442,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"3676425781142a89646b0ad164d8fcf1234529f5","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars.githubusercontent.com/u/22600631?v=3","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions, it offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2017-01-27T10:02:15Z","pushed_at":"2017-01-27T16:09:33Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":57747,"stargazers_count":442,"watchers_count":442,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":24,"forks":136,"open_issues":24,"watchers":442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/185"},"html":{"href":"https://github.com/corda/corda/pull/185"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/185"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/ad55d4d8d43dc2603a4a4c98b9dde9bd6e06aba8"}}}}
{"actor":{"display_login":"ragmondo"}}