{"action":"created","comment":{"url":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/comments/109335743","pull_request_review_id":30430053,"id":109335743,"diff_hunk":"@@ -2014,7 +2014,63 @@ public object GetValue (object obj)\n \t\t\t\treturn _prop.GetValue (obj, null);\n \t\t\t}\n \t\t}\n-\t}\n+\t}\r\n+\r\n+    internal class EnumCacheInfo\r\n+    {\r\n+        public EnumCacheInfo(Type type)\r\n+        {\r\n+#if !USE_NEW_REFLECTION_API\n+            IsEnum = type.IsEnum;\n+#else\n+            IsEnum = type.GetTypeInfo().IsEnum;\r\n+#endif\n+\r\n+            if (IsEnum)\r\n+            {\r\n+                // This is a big assumption, but for now support ints only as key, otherwise we still\r\n+                // have to pay the price for boxing\r\n+                EnumValues = Enum.GetValues(type).Cast<int>().ToDictionary(x => x, x => x.ToString());\r","path":"src/SQLite.cs","position":21,"original_position":21,"commit_id":"e342123cb031bd3bbda9cbdf09a89777880a14d1","original_commit_id":"5a72c4c4e906db3b0622f024f2b733a66d2a7cc5","user":{"login":"ea-orbital8","id":26862828,"avatar_url":"https://avatars1.githubusercontent.com/u/26862828?v=3","gravatar_id":"","url":"https://api.github.com/users/ea-orbital8","html_url":"https://github.com/ea-orbital8","followers_url":"https://api.github.com/users/ea-orbital8/followers","following_url":"https://api.github.com/users/ea-orbital8/following{/other_user}","gists_url":"https://api.github.com/users/ea-orbital8/gists{/gist_id}","starred_url":"https://api.github.com/users/ea-orbital8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ea-orbital8/subscriptions","organizations_url":"https://api.github.com/users/ea-orbital8/orgs","repos_url":"https://api.github.com/users/ea-orbital8/repos","events_url":"https://api.github.com/users/ea-orbital8/events{/privacy}","received_events_url":"https://api.github.com/users/ea-orbital8/received_events","type":"User","site_admin":false},"body":"Cast<int> seems to cause InvalidCastException if enum type is not int. ","created_at":"2017-04-03T03:37:29Z","updated_at":"2017-04-03T03:37:29Z","html_url":"https://github.com/praeclarum/sqlite-net/pull/479#discussion_r109335743","pull_request_url":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/479","_links":{"self":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/comments/109335743"},"html":{"href":"https://github.com/praeclarum/sqlite-net/pull/479#discussion_r109335743"},"pull_request":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/479"}}},"pull_request":{"url":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/479","id":96598732,"html_url":"https://github.com/praeclarum/sqlite-net/pull/479","diff_url":"https://github.com/praeclarum/sqlite-net/pull/479.diff","patch_url":"https://github.com/praeclarum/sqlite-net/pull/479.patch","issue_url":"https://api.github.com/repos/praeclarum/sqlite-net/issues/479","number":479,"state":"closed","locked":false,"title":"Enum performance improvements to solve #458","user":{"login":"GeertvanHorrik","id":1246444,"avatar_url":"https://avatars3.githubusercontent.com/u/1246444?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertvanHorrik","html_url":"https://github.com/GeertvanHorrik","followers_url":"https://api.github.com/users/GeertvanHorrik/followers","following_url":"https://api.github.com/users/GeertvanHorrik/following{/other_user}","gists_url":"https://api.github.com/users/GeertvanHorrik/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertvanHorrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertvanHorrik/subscriptions","organizations_url":"https://api.github.com/users/GeertvanHorrik/orgs","repos_url":"https://api.github.com/users/GeertvanHorrik/repos","events_url":"https://api.github.com/users/GeertvanHorrik/events{/privacy}","received_events_url":"https://api.github.com/users/GeertvanHorrik/received_events","type":"User","site_admin":false},"body":"Still WIP.\r\n\r\nFor now:\r\n\r\n- Added NuGet reference to NUnit 2.6.4\r\n- Added unit tests for enum values","created_at":"2016-12-05T20:01:12Z","updated_at":"2017-04-03T03:37:29Z","closed_at":"2016-12-05T22:47:33Z","merged_at":"2016-12-05T22:47:33Z","merge_commit_sha":"a49db3a96f2a857bb478cffb05d76b3c072c9737","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/479/commits","review_comments_url":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/479/comments","review_comment_url":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/praeclarum/sqlite-net/issues/479/comments","statuses_url":"https://api.github.com/repos/praeclarum/sqlite-net/statuses/e342123cb031bd3bbda9cbdf09a89777880a14d1","head":{"label":"GeertvanHorrik:pr/enum-performance","ref":"pr/enum-performance","sha":"e342123cb031bd3bbda9cbdf09a89777880a14d1","user":{"login":"GeertvanHorrik","id":1246444,"avatar_url":"https://avatars3.githubusercontent.com/u/1246444?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertvanHorrik","html_url":"https://github.com/GeertvanHorrik","followers_url":"https://api.github.com/users/GeertvanHorrik/followers","following_url":"https://api.github.com/users/GeertvanHorrik/following{/other_user}","gists_url":"https://api.github.com/users/GeertvanHorrik/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertvanHorrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertvanHorrik/subscriptions","organizations_url":"https://api.github.com/users/GeertvanHorrik/orgs","repos_url":"https://api.github.com/users/GeertvanHorrik/repos","events_url":"https://api.github.com/users/GeertvanHorrik/events{/privacy}","received_events_url":"https://api.github.com/users/GeertvanHorrik/received_events","type":"User","site_admin":false},"repo":{"id":70417685,"name":"sqlite-net","full_name":"GeertvanHorrik/sqlite-net","owner":{"login":"GeertvanHorrik","id":1246444,"avatar_url":"https://avatars3.githubusercontent.com/u/1246444?v=3","gravatar_id":"","url":"https://api.github.com/users/GeertvanHorrik","html_url":"https://github.com/GeertvanHorrik","followers_url":"https://api.github.com/users/GeertvanHorrik/followers","following_url":"https://api.github.com/users/GeertvanHorrik/following{/other_user}","gists_url":"https://api.github.com/users/GeertvanHorrik/gists{/gist_id}","starred_url":"https://api.github.com/users/GeertvanHorrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeertvanHorrik/subscriptions","organizations_url":"https://api.github.com/users/GeertvanHorrik/orgs","repos_url":"https://api.github.com/users/GeertvanHorrik/repos","events_url":"https://api.github.com/users/GeertvanHorrik/events{/privacy}","received_events_url":"https://api.github.com/users/GeertvanHorrik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeertvanHorrik/sqlite-net","description":"Simple, powerful, cross-platform SQLite client and ORM for .NET","fork":true,"url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net","forks_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/forks","keys_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/teams","hooks_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/hooks","issue_events_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/issues/events{/number}","events_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/events","assignees_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/assignees{/user}","branches_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/branches{/branch}","tags_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/tags","blobs_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/statuses/{sha}","languages_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/languages","stargazers_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/stargazers","contributors_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/contributors","subscribers_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/subscribers","subscription_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/subscription","commits_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/contents/{+path}","compare_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/merges","archive_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/downloads","issues_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/issues{/number}","pulls_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/pulls{/number}","milestones_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/milestones{/number}","notifications_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/labels{/name}","releases_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/releases{/id}","deployments_url":"https://api.github.com/repos/GeertvanHorrik/sqlite-net/deployments","created_at":"2016-10-09T17:01:46Z","updated_at":"2016-10-09T17:01:48Z","pushed_at":"2016-12-05T20:43:58Z","git_url":"git://github.com/GeertvanHorrik/sqlite-net.git","ssh_url":"git@github.com:GeertvanHorrik/sqlite-net.git","clone_url":"https://github.com/GeertvanHorrik/sqlite-net.git","svn_url":"https://github.com/GeertvanHorrik/sqlite-net","homepage":"","size":4555,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"praeclarum:master","ref":"master","sha":"31da82be8c48eea729fdccf59320daa81880e937","user":{"login":"praeclarum","id":323548,"avatar_url":"https://avatars2.githubusercontent.com/u/323548?v=3","gravatar_id":"","url":"https://api.github.com/users/praeclarum","html_url":"https://github.com/praeclarum","followers_url":"https://api.github.com/users/praeclarum/followers","following_url":"https://api.github.com/users/praeclarum/following{/other_user}","gists_url":"https://api.github.com/users/praeclarum/gists{/gist_id}","starred_url":"https://api.github.com/users/praeclarum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praeclarum/subscriptions","organizations_url":"https://api.github.com/users/praeclarum/orgs","repos_url":"https://api.github.com/users/praeclarum/repos","events_url":"https://api.github.com/users/praeclarum/events{/privacy}","received_events_url":"https://api.github.com/users/praeclarum/received_events","type":"User","site_admin":false},"repo":{"id":1666245,"name":"sqlite-net","full_name":"praeclarum/sqlite-net","owner":{"login":"praeclarum","id":323548,"avatar_url":"https://avatars2.githubusercontent.com/u/323548?v=3","gravatar_id":"","url":"https://api.github.com/users/praeclarum","html_url":"https://github.com/praeclarum","followers_url":"https://api.github.com/users/praeclarum/followers","following_url":"https://api.github.com/users/praeclarum/following{/other_user}","gists_url":"https://api.github.com/users/praeclarum/gists{/gist_id}","starred_url":"https://api.github.com/users/praeclarum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praeclarum/subscriptions","organizations_url":"https://api.github.com/users/praeclarum/orgs","repos_url":"https://api.github.com/users/praeclarum/repos","events_url":"https://api.github.com/users/praeclarum/events{/privacy}","received_events_url":"https://api.github.com/users/praeclarum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/praeclarum/sqlite-net","description":"Simple, powerful, cross-platform SQLite client and ORM for .NET","fork":false,"url":"https://api.github.com/repos/praeclarum/sqlite-net","forks_url":"https://api.github.com/repos/praeclarum/sqlite-net/forks","keys_url":"https://api.github.com/repos/praeclarum/sqlite-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praeclarum/sqlite-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praeclarum/sqlite-net/teams","hooks_url":"https://api.github.com/repos/praeclarum/sqlite-net/hooks","issue_events_url":"https://api.github.com/repos/praeclarum/sqlite-net/issues/events{/number}","events_url":"https://api.github.com/repos/praeclarum/sqlite-net/events","assignees_url":"https://api.github.com/repos/praeclarum/sqlite-net/assignees{/user}","branches_url":"https://api.github.com/repos/praeclarum/sqlite-net/branches{/branch}","tags_url":"https://api.github.com/repos/praeclarum/sqlite-net/tags","blobs_url":"https://api.github.com/repos/praeclarum/sqlite-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praeclarum/sqlite-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praeclarum/sqlite-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/praeclarum/sqlite-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praeclarum/sqlite-net/statuses/{sha}","languages_url":"https://api.github.com/repos/praeclarum/sqlite-net/languages","stargazers_url":"https://api.github.com/repos/praeclarum/sqlite-net/stargazers","contributors_url":"https://api.github.com/repos/praeclarum/sqlite-net/contributors","subscribers_url":"https://api.github.com/repos/praeclarum/sqlite-net/subscribers","subscription_url":"https://api.github.com/repos/praeclarum/sqlite-net/subscription","commits_url":"https://api.github.com/repos/praeclarum/sqlite-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/praeclarum/sqlite-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/praeclarum/sqlite-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/praeclarum/sqlite-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/praeclarum/sqlite-net/contents/{+path}","compare_url":"https://api.github.com/repos/praeclarum/sqlite-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praeclarum/sqlite-net/merges","archive_url":"https://api.github.com/repos/praeclarum/sqlite-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praeclarum/sqlite-net/downloads","issues_url":"https://api.github.com/repos/praeclarum/sqlite-net/issues{/number}","pulls_url":"https://api.github.com/repos/praeclarum/sqlite-net/pulls{/number}","milestones_url":"https://api.github.com/repos/praeclarum/sqlite-net/milestones{/number}","notifications_url":"https://api.github.com/repos/praeclarum/sqlite-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praeclarum/sqlite-net/labels{/name}","releases_url":"https://api.github.com/repos/praeclarum/sqlite-net/releases{/id}","deployments_url":"https://api.github.com/repos/praeclarum/sqlite-net/deployments","created_at":"2011-04-26T17:33:28Z","updated_at":"2017-04-02T07:01:23Z","pushed_at":"2017-03-29T03:49:58Z","git_url":"git://github.com/praeclarum/sqlite-net.git","ssh_url":"git@github.com:praeclarum/sqlite-net.git","clone_url":"https://github.com/praeclarum/sqlite-net.git","svn_url":"https://github.com/praeclarum/sqlite-net","homepage":"","size":4557,"stargazers_count":1265,"watchers_count":1265,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":904,"mirror_url":null,"open_issues_count":303,"forks":904,"open_issues":303,"watchers":1265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/479"},"html":{"href":"https://github.com/praeclarum/sqlite-net/pull/479"},"issue":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/issues/479"},"comments":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/issues/479/comments"},"review_comments":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/479/comments"},"review_comment":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/pulls/479/commits"},"statuses":{"href":"https://api.github.com/repos/praeclarum/sqlite-net/statuses/e342123cb031bd3bbda9cbdf09a89777880a14d1"}}}}
{"actor":{"display_login":"ea-orbital8"}}