{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/150692372","pull_request_review_id":76278525,"id":150692372,"diff_hunk":"@@ -33167,7 +33173,106 @@ stats_merge_clause : /*empty */\n                { $$ = SQLCLI_PROGRESS_STATS; }\n              | TOK_DEFAULT\n                { $$ = SQLCLI_SAME_STATS; }  \n-                   \n+\n+\n+/* type pStmtDDL */\n+comment_on_statement : TOK_COMMENT TOK_ON comment_on_object_types ddl_qualified_name TOK_IS QUOTED_STRING\n+               {\n+                 StmtDDLCommentOn *pNode = \n+                   new(PARSERHEAP()) StmtDDLCommentOn(\n+                     $3,\n+                     *$4,\n+                     *$6,\n+                     PARSERHEAP()\n+                   );\n+\n+                 $$ = pNode;\n+               }\n+             | TOK_COMMENT TOK_ON TOK_SCHEMA schema_name TOK_IS QUOTED_STRING\n+               {\n+                 // EJF L4J - CQD dynamic are not allowed in Compound Statements","path":"core/sql/parser/sqlparser.y","position":58,"original_position":58,"commit_id":"6af42567b9c6d53937fa735f162da4833dee8896","original_commit_id":"6af42567b9c6d53937fa735f162da4833dee8896","user":{"login":"DaveBirdsall","id":5659628,"avatar_url":"https://avatars2.githubusercontent.com/u/5659628?v=4","gravatar_id":"","url":"https://api.github.com/users/DaveBirdsall","html_url":"https://github.com/DaveBirdsall","followers_url":"https://api.github.com/users/DaveBirdsall/followers","following_url":"https://api.github.com/users/DaveBirdsall/following{/other_user}","gists_url":"https://api.github.com/users/DaveBirdsall/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveBirdsall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveBirdsall/subscriptions","organizations_url":"https://api.github.com/users/DaveBirdsall/orgs","repos_url":"https://api.github.com/users/DaveBirdsall/repos","events_url":"https://api.github.com/users/DaveBirdsall/events{/privacy}","received_events_url":"https://api.github.com/users/DaveBirdsall/received_events","type":"User","site_admin":false},"body":"The comment is incorrect. But was it your intent to disallow COMMENT ON within a compound statement? If so, you may want to disallow it in the first TOK_COMMENT production as well.","created_at":"2017-11-13T23:01:48Z","updated_at":"2017-11-13T23:14:16Z","html_url":"https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150692372","pull_request_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1288","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments/150692372"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/1288#discussion_r150692372"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1288"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1288","id":150256866,"html_url":"https://github.com/apache/incubator-trafodion/pull/1288","diff_url":"https://github.com/apache/incubator-trafodion/pull/1288.diff","patch_url":"https://github.com/apache/incubator-trafodion/pull/1288.patch","issue_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/1288","number":1288,"state":"open","locked":false,"title":"New COMMENT-ON SQL statement","user":{"login":"EEDY","id":1920776,"avatar_url":"https://avatars1.githubusercontent.com/u/1920776?v=4","gravatar_id":"","url":"https://api.github.com/users/EEDY","html_url":"https://github.com/EEDY","followers_url":"https://api.github.com/users/EEDY/followers","following_url":"https://api.github.com/users/EEDY/following{/other_user}","gists_url":"https://api.github.com/users/EEDY/gists{/gist_id}","starred_url":"https://api.github.com/users/EEDY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EEDY/subscriptions","organizations_url":"https://api.github.com/users/EEDY/orgs","repos_url":"https://api.github.com/users/EEDY/repos","events_url":"https://api.github.com/users/EEDY/events{/privacy}","received_events_url":"https://api.github.com/users/EEDY/received_events","type":"User","site_admin":false},"body":"Please see design doc here: [SQL_COMMENT_feature_design.171025.docx](https://github.com/apache/incubator-trafodion/files/1437382/SQL_COMMENT_feature_design.171025.docx)\r\n\r\n1. new SQL syntax: COMMENT ON\r\n2. new component privilege: SQL_OPERATIONS::COMMENT\r\n3. MD table changes: add new column named \"COMMENT\" for tables \"_MD_\".OBJECTS and \"_MD_\".COLUMNS\r\n4. SHOWDDL changes: add COMMENT-ON output for each object\r\n5. new build-in views: \"_MD_\".OBJECT_COMMENT_VIEW and \"_MD_\".COLUMN_COMMENT_VIEW","created_at":"2017-11-02T10:45:19Z","updated_at":"2017-11-13T23:14:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8eca266524a5204bd3287a819def07dcee82d622","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1288/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1288/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/1288/comments","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/6af42567b9c6d53937fa735f162da4833dee8896","head":{"label":"EEDY:master","ref":"master","sha":"6af42567b9c6d53937fa735f162da4833dee8896","user":{"login":"EEDY","id":1920776,"avatar_url":"https://avatars1.githubusercontent.com/u/1920776?v=4","gravatar_id":"","url":"https://api.github.com/users/EEDY","html_url":"https://github.com/EEDY","followers_url":"https://api.github.com/users/EEDY/followers","following_url":"https://api.github.com/users/EEDY/following{/other_user}","gists_url":"https://api.github.com/users/EEDY/gists{/gist_id}","starred_url":"https://api.github.com/users/EEDY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EEDY/subscriptions","organizations_url":"https://api.github.com/users/EEDY/orgs","repos_url":"https://api.github.com/users/EEDY/repos","events_url":"https://api.github.com/users/EEDY/events{/privacy}","received_events_url":"https://api.github.com/users/EEDY/received_events","type":"User","site_admin":false},"repo":{"id":109238047,"name":"incubator-trafodion","full_name":"EEDY/incubator-trafodion","owner":{"login":"EEDY","id":1920776,"avatar_url":"https://avatars1.githubusercontent.com/u/1920776?v=4","gravatar_id":"","url":"https://api.github.com/users/EEDY","html_url":"https://github.com/EEDY","followers_url":"https://api.github.com/users/EEDY/followers","following_url":"https://api.github.com/users/EEDY/following{/other_user}","gists_url":"https://api.github.com/users/EEDY/gists{/gist_id}","starred_url":"https://api.github.com/users/EEDY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EEDY/subscriptions","organizations_url":"https://api.github.com/users/EEDY/orgs","repos_url":"https://api.github.com/users/EEDY/repos","events_url":"https://api.github.com/users/EEDY/events{/privacy}","received_events_url":"https://api.github.com/users/EEDY/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EEDY/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":true,"url":"https://api.github.com/repos/EEDY/incubator-trafodion","forks_url":"https://api.github.com/repos/EEDY/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/EEDY/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EEDY/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EEDY/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/EEDY/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/EEDY/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/EEDY/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/EEDY/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/EEDY/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/EEDY/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/EEDY/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EEDY/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EEDY/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/EEDY/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EEDY/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/EEDY/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/EEDY/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/EEDY/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/EEDY/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/EEDY/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/EEDY/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/EEDY/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/EEDY/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/EEDY/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/EEDY/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/EEDY/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EEDY/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/EEDY/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EEDY/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/EEDY/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/EEDY/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/EEDY/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/EEDY/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EEDY/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/EEDY/incubator-trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/EEDY/incubator-trafodion/deployments","created_at":"2017-11-02T08:33:08Z","updated_at":"2017-11-02T08:33:36Z","pushed_at":"2017-11-10T01:51:51Z","git_url":"git://github.com/EEDY/incubator-trafodion.git","ssh_url":"git@github.com:EEDY/incubator-trafodion.git","clone_url":"https://github.com/EEDY/incubator-trafodion.git","svn_url":"https://github.com/EEDY/incubator-trafodion","homepage":null,"size":83280,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"68fe67f4fc83fe4885222cb9aa33c6a627bc766e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36349344,"name":"incubator-trafodion","full_name":"apache/incubator-trafodion","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-trafodion","forks_url":"https://api.github.com/repos/apache/incubator-trafodion/forks","keys_url":"https://api.github.com/repos/apache/incubator-trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-trafodion/teams","hooks_url":"https://api.github.com/repos/apache/incubator-trafodion/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-trafodion/events","assignees_url":"https://api.github.com/repos/apache/incubator-trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-trafodion/tags","blobs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-trafodion/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-trafodion/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-trafodion/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-trafodion/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-trafodion/subscription","commits_url":"https://api.github.com/repos/apache/incubator-trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-trafodion/merges","archive_url":"https://api.github.com/repos/apache/incubator-trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-trafodion/downloads","issues_url":"https://api.github.com/repos/apache/incubator-trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-trafodion/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-trafodion/deployments","created_at":"2015-05-27T07:00:05Z","updated_at":"2017-11-05T07:23:39Z","pushed_at":"2017-11-13T22:43:50Z","git_url":"git://github.com/apache/incubator-trafodion.git","ssh_url":"git@github.com:apache/incubator-trafodion.git","clone_url":"https://github.com/apache/incubator-trafodion.git","svn_url":"https://github.com/apache/incubator-trafodion","homepage":null,"size":83076,"stargazers_count":118,"watchers_count":118,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":"git://git.apache.org/incubator-trafodion.git","archived":false,"open_issues_count":12,"forks":106,"open_issues":12,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1288"},"html":{"href":"https://github.com/apache/incubator-trafodion/pull/1288"},"issue":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/1288"},"comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/issues/1288/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1288/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-trafodion/pulls/1288/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-trafodion/statuses/6af42567b9c6d53937fa735f162da4833dee8896"}},"author_association":"NONE"}}
{"actor":{"display_login":"DaveBirdsall"}}