{"action":"created","comment":{"url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/comments/117153686","pull_request_review_id":38834490,"id":117153686,"diff_hunk":"@@ -39,15 +55,32 @@ private static PhoneNumber createRandomPhoneNumber() {\n      * @return a new phone number object\n      */ //TODO - if input is valid, return respective PhoneNumber object, else return null\n     public static PhoneNumber createPhoneNumberSafely(int areaCode, int centralOfficeCode, int phoneLineCode) {\n-        return createPhoneNumber(null);\n+\n+        try{\n+            String myphonenum = \"(\"+areaCode+\")\"+\"-\"+centralOfficeCode+\"-\"+phoneLineCode;\n+            //return new PhoneNumber(myphonenum);\n+            return createPhoneNumber(myphonenum);\n+        }\n+        catch(InvalidPhoneNumberFormatException myphonenum){\n+            logger.info(\"(\"+areaCode+\")\"+centralOfficeCode+phoneLineCode+\"is not a valid phone number\");\n+            return null;\n+        }\n+        //return null;\n+        //return createPhoneNumber(null);\n     }\n \n     /**\n      * @param phoneNumberString - some String corresponding to a phone number whose format is `(###)-###-####`\n      * @return a new phone number object\n      * @throws InvalidPhoneNumberFormatException - thrown if phoneNumberString does not match acceptable format\n      */ // TODO - Add throws statement to method signature\n-    public static PhoneNumber createPhoneNumber(String phoneNumberString) {\n-        return null;\n+    public static PhoneNumber createPhoneNumber(String phoneNumberString) throws InvalidPhoneNumberFormatException{\n+        //*****************VL:just need to add throw statement here! no need for try/catch\n+\n+        PhoneNumber myphonenum = new PhoneNumber(phoneNumberString);\n+        //logger.info(\"Attempting to create a new PhoneNumber object with a value of\"+myphonenum.getAreaCode()+\n+        //        myphonenum.getCentralOfficeCode()+myphonenum.getPhoneLineCode());","path":"src/main/java/com/zipcodewilmington/phone/PhoneNumberFactory.java","position":71,"original_position":71,"commit_id":"09414fc091882d93cb7fb0ebe69677fdb1c583bf","original_commit_id":"09414fc091882d93cb7fb0ebe69677fdb1c583bf","user":{"login":"LeonHunter0","id":16881117,"avatar_url":"https://avatars0.githubusercontent.com/u/16881117?v=3","gravatar_id":"","url":"https://api.github.com/users/LeonHunter0","html_url":"https://github.com/LeonHunter0","followers_url":"https://api.github.com/users/LeonHunter0/followers","following_url":"https://api.github.com/users/LeonHunter0/following{/other_user}","gists_url":"https://api.github.com/users/LeonHunter0/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonHunter0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonHunter0/subscriptions","organizations_url":"https://api.github.com/users/LeonHunter0/orgs","repos_url":"https://api.github.com/users/LeonHunter0/repos","events_url":"https://api.github.com/users/LeonHunter0/events{/privacy}","received_events_url":"https://api.github.com/users/LeonHunter0/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2017-05-18T03:11:46Z","updated_at":"2017-05-18T03:12:12Z","html_url":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pull/21#discussion_r117153686","pull_request_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/comments/117153686"},"html":{"href":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pull/21#discussion_r117153686"},"pull_request":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/21","id":120906442,"html_url":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pull/21","diff_url":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pull/21.diff","patch_url":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pull/21.patch","issue_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/issues/21","number":21,"state":"open","locked":false,"title":"MicroLabs-Exceptions&Logging","user":{"login":"vll88","id":28021932,"avatar_url":"https://avatars0.githubusercontent.com/u/28021932?v=3","gravatar_id":"","url":"https://api.github.com/users/vll88","html_url":"https://github.com/vll88","followers_url":"https://api.github.com/users/vll88/followers","following_url":"https://api.github.com/users/vll88/following{/other_user}","gists_url":"https://api.github.com/users/vll88/gists{/gist_id}","starred_url":"https://api.github.com/users/vll88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vll88/subscriptions","organizations_url":"https://api.github.com/users/vll88/orgs","repos_url":"https://api.github.com/users/vll88/repos","events_url":"https://api.github.com/users/vll88/events{/privacy}","received_events_url":"https://api.github.com/users/vll88/received_events","type":"User","site_admin":false},"body":"submitting pulling request for yesterday's work","created_at":"2017-05-16T19:26:55Z","updated_at":"2017-05-18T03:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64e95e6fd47a97ba61a297bf736f33d9d100c466","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/21/commits","review_comments_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/21/comments","review_comment_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/issues/21/comments","statuses_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/statuses/09414fc091882d93cb7fb0ebe69677fdb1c583bf","head":{"label":"vll88:master","ref":"master","sha":"09414fc091882d93cb7fb0ebe69677fdb1c583bf","user":{"login":"vll88","id":28021932,"avatar_url":"https://avatars0.githubusercontent.com/u/28021932?v=3","gravatar_id":"","url":"https://api.github.com/users/vll88","html_url":"https://github.com/vll88","followers_url":"https://api.github.com/users/vll88/followers","following_url":"https://api.github.com/users/vll88/following{/other_user}","gists_url":"https://api.github.com/users/vll88/gists{/gist_id}","starred_url":"https://api.github.com/users/vll88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vll88/subscriptions","organizations_url":"https://api.github.com/users/vll88/orgs","repos_url":"https://api.github.com/users/vll88/repos","events_url":"https://api.github.com/users/vll88/events{/privacy}","received_events_url":"https://api.github.com/users/vll88/received_events","type":"User","site_admin":false},"repo":{"id":91369527,"name":"ZCW-MicroLabs-ExceptionsAndLogging","full_name":"vll88/ZCW-MicroLabs-ExceptionsAndLogging","owner":{"login":"vll88","id":28021932,"avatar_url":"https://avatars0.githubusercontent.com/u/28021932?v=3","gravatar_id":"","url":"https://api.github.com/users/vll88","html_url":"https://github.com/vll88","followers_url":"https://api.github.com/users/vll88/followers","following_url":"https://api.github.com/users/vll88/following{/other_user}","gists_url":"https://api.github.com/users/vll88/gists{/gist_id}","starred_url":"https://api.github.com/users/vll88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vll88/subscriptions","organizations_url":"https://api.github.com/users/vll88/orgs","repos_url":"https://api.github.com/users/vll88/repos","events_url":"https://api.github.com/users/vll88/events{/privacy}","received_events_url":"https://api.github.com/users/vll88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vll88/ZCW-MicroLabs-ExceptionsAndLogging","description":null,"fork":true,"url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging","forks_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/forks","keys_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/teams","hooks_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/hooks","issue_events_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/issues/events{/number}","events_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/events","assignees_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/assignees{/user}","branches_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/branches{/branch}","tags_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/tags","blobs_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/git/refs{/sha}","trees_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/statuses/{sha}","languages_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/languages","stargazers_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/stargazers","contributors_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/contributors","subscribers_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/subscribers","subscription_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/subscription","commits_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/commits{/sha}","git_commits_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/git/commits{/sha}","comments_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/comments{/number}","issue_comment_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/issues/comments{/number}","contents_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/contents/{+path}","compare_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/merges","archive_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/downloads","issues_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/issues{/number}","pulls_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/pulls{/number}","milestones_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/milestones{/number}","notifications_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/labels{/name}","releases_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/releases{/id}","deployments_url":"https://api.github.com/repos/vll88/ZCW-MicroLabs-ExceptionsAndLogging/deployments","created_at":"2017-05-15T18:12:26Z","updated_at":"2017-05-15T18:12:27Z","pushed_at":"2017-05-15T20:58:26Z","git_url":"git://github.com/vll88/ZCW-MicroLabs-ExceptionsAndLogging.git","ssh_url":"git@github.com:vll88/ZCW-MicroLabs-ExceptionsAndLogging.git","clone_url":"https://github.com/vll88/ZCW-MicroLabs-ExceptionsAndLogging.git","svn_url":"https://github.com/vll88/ZCW-MicroLabs-ExceptionsAndLogging","homepage":null,"size":141,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Zipcoder:master","ref":"master","sha":"0d68feba03866846bec73e73257acbf0d28e32c4","user":{"login":"Zipcoder","id":13836040,"avatar_url":"https://avatars1.githubusercontent.com/u/13836040?v=3","gravatar_id":"","url":"https://api.github.com/users/Zipcoder","html_url":"https://github.com/Zipcoder","followers_url":"https://api.github.com/users/Zipcoder/followers","following_url":"https://api.github.com/users/Zipcoder/following{/other_user}","gists_url":"https://api.github.com/users/Zipcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/Zipcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zipcoder/subscriptions","organizations_url":"https://api.github.com/users/Zipcoder/orgs","repos_url":"https://api.github.com/users/Zipcoder/repos","events_url":"https://api.github.com/users/Zipcoder/events{/privacy}","received_events_url":"https://api.github.com/users/Zipcoder/received_events","type":"Organization","site_admin":false},"repo":{"id":91364465,"name":"ZCW-MicroLabs-ExceptionsAndLogging","full_name":"Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging","owner":{"login":"Zipcoder","id":13836040,"avatar_url":"https://avatars1.githubusercontent.com/u/13836040?v=3","gravatar_id":"","url":"https://api.github.com/users/Zipcoder","html_url":"https://github.com/Zipcoder","followers_url":"https://api.github.com/users/Zipcoder/followers","following_url":"https://api.github.com/users/Zipcoder/following{/other_user}","gists_url":"https://api.github.com/users/Zipcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/Zipcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zipcoder/subscriptions","organizations_url":"https://api.github.com/users/Zipcoder/orgs","repos_url":"https://api.github.com/users/Zipcoder/repos","events_url":"https://api.github.com/users/Zipcoder/events{/privacy}","received_events_url":"https://api.github.com/users/Zipcoder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging","description":null,"fork":false,"url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging","forks_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/forks","keys_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/teams","hooks_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/hooks","issue_events_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/issues/events{/number}","events_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/events","assignees_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/assignees{/user}","branches_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/branches{/branch}","tags_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/tags","blobs_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/statuses/{sha}","languages_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/languages","stargazers_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/stargazers","contributors_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/contributors","subscribers_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/subscribers","subscription_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/subscription","commits_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/contents/{+path}","compare_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/merges","archive_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/downloads","issues_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/issues{/number}","pulls_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls{/number}","milestones_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/milestones{/number}","notifications_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/labels{/name}","releases_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/releases{/id}","deployments_url":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/deployments","created_at":"2017-05-15T17:17:36Z","updated_at":"2017-05-15T17:18:27Z","pushed_at":"2017-05-18T02:42:55Z","git_url":"git://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging.git","ssh_url":"git@github.com:Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging.git","clone_url":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging.git","svn_url":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":22,"forks":24,"open_issues":22,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/21"},"html":{"href":"https://github.com/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pull/21"},"issue":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/issues/21"},"comments":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/Zipcoder/ZCW-MicroLabs-ExceptionsAndLogging/statuses/09414fc091882d93cb7fb0ebe69677fdb1c583bf"}}}}
{"actor":{"display_login":"LeonHunter0"}}