{"action":"created","comment":{"url":"https://api.github.com/repos/nitlang/nit/pulls/comments/127705764","pull_request_review_id":50316460,"id":127705764,"diff_hunk":"@@ -406,8 +415,58 @@ class BMFontAsset\n \t\t\t\t\telse 16.0\n \t\t\t\tdx += space_advance * scale\n \t\t\t\tword_break = true\n+\t\t\telse if c == '[' then\n+\t\t\t\t# Open link?\n+\t\t\t\tif i + 1 < text.length and text[i+1] == '[' then\n+\t\t\t\t\t# Escape if duplicated","path":"lib/gamnit/bmfont.nit","position":65,"original_position":33,"commit_id":"215c61e2183fc89d3005fdcd2a0b7fb7079d3401","original_commit_id":"8a08b0fcda02361140ce4ee31de7e0c2a4a676d4","user":{"login":"privat","id":135828,"avatar_url":"https://avatars5.githubusercontent.com/u/135828?v=4","gravatar_id":"","url":"https://api.github.com/users/privat","html_url":"https://github.com/privat","followers_url":"https://api.github.com/users/privat/followers","following_url":"https://api.github.com/users/privat/following{/other_user}","gists_url":"https://api.github.com/users/privat/gists{/gist_id}","starred_url":"https://api.github.com/users/privat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privat/subscriptions","organizations_url":"https://api.github.com/users/privat/orgs","repos_url":"https://api.github.com/users/privat/repos","events_url":"https://api.github.com/users/privat/events{/privacy}","received_events_url":"https://api.github.com/users/privat/received_events","type":"User","site_admin":false},"body":"What about a traditional POLA \\ escaping?","created_at":"2017-07-17T13:22:50Z","updated_at":"2017-07-17T13:27:50Z","html_url":"https://github.com/nitlang/nit/pull/2527#discussion_r127705764","pull_request_url":"https://api.github.com/repos/nitlang/nit/pulls/2527","_links":{"self":{"href":"https://api.github.com/repos/nitlang/nit/pulls/comments/127705764"},"html":{"href":"https://github.com/nitlang/nit/pull/2527#discussion_r127705764"},"pull_request":{"href":"https://api.github.com/repos/nitlang/nit/pulls/2527"}}},"pull_request":{"url":"https://api.github.com/repos/nitlang/nit/pulls/2527","id":130589509,"html_url":"https://github.com/nitlang/nit/pull/2527","diff_url":"https://github.com/nitlang/nit/pull/2527.diff","patch_url":"https://github.com/nitlang/nit/pull/2527.patch","issue_url":"https://api.github.com/repos/nitlang/nit/issues/2527","number":2527,"state":"open","locked":false,"title":"gamnit: scale text, add custom characters and create links with `BMFont`","user":{"login":"xymus","id":208057,"avatar_url":"https://avatars4.githubusercontent.com/u/208057?v=4","gravatar_id":"","url":"https://api.github.com/users/xymus","html_url":"https://github.com/xymus","followers_url":"https://api.github.com/users/xymus/followers","following_url":"https://api.github.com/users/xymus/following{/other_user}","gists_url":"https://api.github.com/users/xymus/gists{/gist_id}","starred_url":"https://api.github.com/users/xymus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymus/subscriptions","organizations_url":"https://api.github.com/users/xymus/orgs","repos_url":"https://api.github.com/users/xymus/repos","events_url":"https://api.github.com/users/xymus/events{/privacy}","received_events_url":"https://api.github.com/users/xymus/received_events","type":"User","site_admin":false},"body":"This PR adds more customization options when drawing text using `BMFont`:\r\n\r\n* Change the size of the text with a simple attribute `TextSprites::scale`.\r\n* Insert artificial chars to a `BMFont` using the more permissive `BMFontChar`. This way, one can set custom textures for a letter, an emojis or any character from the private use areas. \r\n* Add \"links\" to the text using Markdown-like syntax (`[my link]` or `[pretty name](internal name)`). Note that the links are not clickable by themselves. However, the client code can access the sprites representing the link to change their style or to get their position. This will work well with a rumored future feature making sprites clickable...\r\n\r\nNotice the colored links and the smaller text box in the following screenshot of `fonts_showcase`: \r\n![screenshot from 2017-07-13 22-09-20](https://user-images.githubusercontent.com/208057/28196740-8f8630b6-6820-11e7-8915-1df02b4edee5.png)\r\n\r\n---\r\n\r\nOnce again, these new features are not implemented for `TileSetFont`. I'm considering keeping the API of `TileSetFont` but replacing its implementation by a `BMFont` for it to gets all the new shiny features.","created_at":"2017-07-14T13:30:44Z","updated_at":"2017-07-17T13:27:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53f148035ae67a27d829c19cde9a0f16f522130c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nitlang/nit/pulls/2527/commits","review_comments_url":"https://api.github.com/repos/nitlang/nit/pulls/2527/comments","review_comment_url":"https://api.github.com/repos/nitlang/nit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nitlang/nit/issues/2527/comments","statuses_url":"https://api.github.com/repos/nitlang/nit/statuses/215c61e2183fc89d3005fdcd2a0b7fb7079d3401","head":{"label":"xymus:bmfont","ref":"bmfont","sha":"215c61e2183fc89d3005fdcd2a0b7fb7079d3401","user":{"login":"xymus","id":208057,"avatar_url":"https://avatars4.githubusercontent.com/u/208057?v=4","gravatar_id":"","url":"https://api.github.com/users/xymus","html_url":"https://github.com/xymus","followers_url":"https://api.github.com/users/xymus/followers","following_url":"https://api.github.com/users/xymus/following{/other_user}","gists_url":"https://api.github.com/users/xymus/gists{/gist_id}","starred_url":"https://api.github.com/users/xymus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymus/subscriptions","organizations_url":"https://api.github.com/users/xymus/orgs","repos_url":"https://api.github.com/users/xymus/repos","events_url":"https://api.github.com/users/xymus/events{/privacy}","received_events_url":"https://api.github.com/users/xymus/received_events","type":"User","site_admin":false},"repo":{"id":1275771,"name":"nit","full_name":"xymus/nit","owner":{"login":"xymus","id":208057,"avatar_url":"https://avatars4.githubusercontent.com/u/208057?v=4","gravatar_id":"","url":"https://api.github.com/users/xymus","html_url":"https://github.com/xymus","followers_url":"https://api.github.com/users/xymus/followers","following_url":"https://api.github.com/users/xymus/following{/other_user}","gists_url":"https://api.github.com/users/xymus/gists{/gist_id}","starred_url":"https://api.github.com/users/xymus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xymus/subscriptions","organizations_url":"https://api.github.com/users/xymus/orgs","repos_url":"https://api.github.com/users/xymus/repos","events_url":"https://api.github.com/users/xymus/events{/privacy}","received_events_url":"https://api.github.com/users/xymus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xymus/nit","description":"Nit language","fork":true,"url":"https://api.github.com/repos/xymus/nit","forks_url":"https://api.github.com/repos/xymus/nit/forks","keys_url":"https://api.github.com/repos/xymus/nit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xymus/nit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xymus/nit/teams","hooks_url":"https://api.github.com/repos/xymus/nit/hooks","issue_events_url":"https://api.github.com/repos/xymus/nit/issues/events{/number}","events_url":"https://api.github.com/repos/xymus/nit/events","assignees_url":"https://api.github.com/repos/xymus/nit/assignees{/user}","branches_url":"https://api.github.com/repos/xymus/nit/branches{/branch}","tags_url":"https://api.github.com/repos/xymus/nit/tags","blobs_url":"https://api.github.com/repos/xymus/nit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xymus/nit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xymus/nit/git/refs{/sha}","trees_url":"https://api.github.com/repos/xymus/nit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xymus/nit/statuses/{sha}","languages_url":"https://api.github.com/repos/xymus/nit/languages","stargazers_url":"https://api.github.com/repos/xymus/nit/stargazers","contributors_url":"https://api.github.com/repos/xymus/nit/contributors","subscribers_url":"https://api.github.com/repos/xymus/nit/subscribers","subscription_url":"https://api.github.com/repos/xymus/nit/subscription","commits_url":"https://api.github.com/repos/xymus/nit/commits{/sha}","git_commits_url":"https://api.github.com/repos/xymus/nit/git/commits{/sha}","comments_url":"https://api.github.com/repos/xymus/nit/comments{/number}","issue_comment_url":"https://api.github.com/repos/xymus/nit/issues/comments{/number}","contents_url":"https://api.github.com/repos/xymus/nit/contents/{+path}","compare_url":"https://api.github.com/repos/xymus/nit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xymus/nit/merges","archive_url":"https://api.github.com/repos/xymus/nit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xymus/nit/downloads","issues_url":"https://api.github.com/repos/xymus/nit/issues{/number}","pulls_url":"https://api.github.com/repos/xymus/nit/pulls{/number}","milestones_url":"https://api.github.com/repos/xymus/nit/milestones{/number}","notifications_url":"https://api.github.com/repos/xymus/nit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xymus/nit/labels{/name}","releases_url":"https://api.github.com/repos/xymus/nit/releases{/id}","deployments_url":"https://api.github.com/repos/xymus/nit/deployments","created_at":"2011-01-20T19:43:31Z","updated_at":"2016-11-15T23:19:46Z","pushed_at":"2017-07-14T16:53:56Z","git_url":"git://github.com/xymus/nit.git","ssh_url":"git@github.com:xymus/nit.git","clone_url":"https://github.com/xymus/nit.git","svn_url":"https://github.com/xymus/nit","homepage":"http://nitlanguage.org","size":126662,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"nitlang:master","ref":"master","sha":"8a9dd1d5aaacff9cd8655cdc0c6a1f597a398f4f","user":{"login":"nitlang","id":5420298,"avatar_url":"https://avatars5.githubusercontent.com/u/5420298?v=4","gravatar_id":"","url":"https://api.github.com/users/nitlang","html_url":"https://github.com/nitlang","followers_url":"https://api.github.com/users/nitlang/followers","following_url":"https://api.github.com/users/nitlang/following{/other_user}","gists_url":"https://api.github.com/users/nitlang/gists{/gist_id}","starred_url":"https://api.github.com/users/nitlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitlang/subscriptions","organizations_url":"https://api.github.com/users/nitlang/orgs","repos_url":"https://api.github.com/users/nitlang/repos","events_url":"https://api.github.com/users/nitlang/events{/privacy}","received_events_url":"https://api.github.com/users/nitlang/received_events","type":"Organization","site_admin":false},"repo":{"id":328597,"name":"nit","full_name":"nitlang/nit","owner":{"login":"nitlang","id":5420298,"avatar_url":"https://avatars5.githubusercontent.com/u/5420298?v=4","gravatar_id":"","url":"https://api.github.com/users/nitlang","html_url":"https://github.com/nitlang","followers_url":"https://api.github.com/users/nitlang/followers","following_url":"https://api.github.com/users/nitlang/following{/other_user}","gists_url":"https://api.github.com/users/nitlang/gists{/gist_id}","starred_url":"https://api.github.com/users/nitlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitlang/subscriptions","organizations_url":"https://api.github.com/users/nitlang/orgs","repos_url":"https://api.github.com/users/nitlang/repos","events_url":"https://api.github.com/users/nitlang/events{/privacy}","received_events_url":"https://api.github.com/users/nitlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nitlang/nit","description":"Nit language","fork":false,"url":"https://api.github.com/repos/nitlang/nit","forks_url":"https://api.github.com/repos/nitlang/nit/forks","keys_url":"https://api.github.com/repos/nitlang/nit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitlang/nit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitlang/nit/teams","hooks_url":"https://api.github.com/repos/nitlang/nit/hooks","issue_events_url":"https://api.github.com/repos/nitlang/nit/issues/events{/number}","events_url":"https://api.github.com/repos/nitlang/nit/events","assignees_url":"https://api.github.com/repos/nitlang/nit/assignees{/user}","branches_url":"https://api.github.com/repos/nitlang/nit/branches{/branch}","tags_url":"https://api.github.com/repos/nitlang/nit/tags","blobs_url":"https://api.github.com/repos/nitlang/nit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitlang/nit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitlang/nit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitlang/nit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitlang/nit/statuses/{sha}","languages_url":"https://api.github.com/repos/nitlang/nit/languages","stargazers_url":"https://api.github.com/repos/nitlang/nit/stargazers","contributors_url":"https://api.github.com/repos/nitlang/nit/contributors","subscribers_url":"https://api.github.com/repos/nitlang/nit/subscribers","subscription_url":"https://api.github.com/repos/nitlang/nit/subscription","commits_url":"https://api.github.com/repos/nitlang/nit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitlang/nit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitlang/nit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitlang/nit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nitlang/nit/contents/{+path}","compare_url":"https://api.github.com/repos/nitlang/nit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitlang/nit/merges","archive_url":"https://api.github.com/repos/nitlang/nit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitlang/nit/downloads","issues_url":"https://api.github.com/repos/nitlang/nit/issues{/number}","pulls_url":"https://api.github.com/repos/nitlang/nit/pulls{/number}","milestones_url":"https://api.github.com/repos/nitlang/nit/milestones{/number}","notifications_url":"https://api.github.com/repos/nitlang/nit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitlang/nit/labels{/name}","releases_url":"https://api.github.com/repos/nitlang/nit/releases{/id}","deployments_url":"https://api.github.com/repos/nitlang/nit/deployments","created_at":"2009-10-06T15:03:00Z","updated_at":"2017-06-19T01:27:53Z","pushed_at":"2017-07-14T16:53:57Z","git_url":"git://github.com/nitlang/nit.git","ssh_url":"git@github.com:nitlang/nit.git","clone_url":"https://github.com/nitlang/nit.git","svn_url":"https://github.com/nitlang/nit","homepage":"http://nitlanguage.org","size":121175,"stargazers_count":158,"watchers_count":158,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":174,"forks":56,"open_issues":174,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nitlang/nit/pulls/2527"},"html":{"href":"https://github.com/nitlang/nit/pull/2527"},"issue":{"href":"https://api.github.com/repos/nitlang/nit/issues/2527"},"comments":{"href":"https://api.github.com/repos/nitlang/nit/issues/2527/comments"},"review_comments":{"href":"https://api.github.com/repos/nitlang/nit/pulls/2527/comments"},"review_comment":{"href":"https://api.github.com/repos/nitlang/nit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nitlang/nit/pulls/2527/commits"},"statuses":{"href":"https://api.github.com/repos/nitlang/nit/statuses/215c61e2183fc89d3005fdcd2a0b7fb7079d3401"}}}}
{"actor":{"display_login":"privat"}}