{"action":"created","issue":{"url":"https://api.github.com/repos/all-of-us/workbench/issues/294","repository_url":"https://api.github.com/repos/all-of-us/workbench","labels_url":"https://api.github.com/repos/all-of-us/workbench/issues/294/labels{/name}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/294/comments","events_url":"https://api.github.com/repos/all-of-us/workbench/issues/294/events","html_url":"https://github.com/all-of-us/workbench/pull/294","id":274634476,"number":294,"title":"[RW-252] @Autowire WorkspaceService","user":{"login":"calbach","id":822298,"avatar_url":"https://avatars0.githubusercontent.com/u/822298?v=4","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-16T19:25:38Z","updated_at":"2017-11-17T18:39:43Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/294","html_url":"https://github.com/all-of-us/workbench/pull/294","diff_url":"https://github.com/all-of-us/workbench/pull/294.diff","patch_url":"https://github.com/all-of-us/workbench/pull/294.patch"},"body":"Apparently @DataJpaTest restricts autowiring configuration to just JPA-related things, e.g. DAOs. Other component bindings are technically picked up via `Application`, but are not actually wired up do to the default @ComponentScan filter applied by @DataJpaTest, which is to not bring in anything.\r\n\r\nPlease share any further insights here if you have any.\r\n\r\nNote: any other @autowire deps for these services can be connected via an inner @TestConfiguration class within the TestCase, or with a reusable @ActiveProfile. I will likely include this in a follow-up change, but not needed for this CL.\r\n\r\nVerified that updateUserRoles now works without the `save()`, didn't update in this change though."},"comment":{"url":"https://api.github.com/repos/all-of-us/workbench/issues/comments/345327500","html_url":"https://github.com/all-of-us/workbench/pull/294#issuecomment-345327500","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/294","id":345327500,"user":{"login":"calbach","id":822298,"avatar_url":"https://avatars0.githubusercontent.com/u/822298?v=4","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false},"created_at":"2017-11-17T18:39:43Z","updated_at":"2017-11-17T18:39:43Z","author_association":"COLLABORATOR","body":"Yep - I've verified locally that this works but I just left that as-is in this PR since I'm going to be slightly reworking that in my next change anyways (which removes @ Transactional)."}}
{"actor":{"display_login":"calbach"}}